From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 00:13:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 28 Feb 2019 23:13:33 +0000
Subject: [Koha-bugs] [Bug 3298] Independent item "Status Check"
functionality needed
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3298
Daniel Gaghan changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |daniel.gaghan at pueblolibrary
| |.org
--- Comment #2 from Daniel Gaghan ---
As of 18.05 this is still not a feature and is requested by PCCLD staff.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 01:54:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 00:54:17 +0000
Subject: [Koha-bugs] [Bug 11529] Add subtitle,
medium and part fields to biblio table
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529
Bob Birchall changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |bob at calyx.net.au
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 02:10:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 01:10:11 +0000
Subject: [Koha-bugs] [Bug 11529] Add subtitle,
medium and part fields to biblio table
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529
arees at stlukes.nsw.edu.au changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |arees at stlukes.nsw.edu.au
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 02:10:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 01:10:31 +0000
Subject: [Koha-bugs] [Bug 20364] Show languages from MARC21 field 041 in
intranet
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20364
arees at stlukes.nsw.edu.au changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |arees at stlukes.nsw.edu.au
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 03:09:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 02:09:41 +0000
Subject: [Koha-bugs] [Bug 22417] Delegate background jobs execution
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417
--- Comment #15 from David Cook ---
(In reply to Jonathan Druart from comment #13)
> (In reply to Tom?s Cohen Arazi from comment #12)
> > I agree with David that this of course would require a single RabbitMQ
> > server so questions: Is there a concept of namespaces? can any Koha instance
> > access other instance's messages?
>
> I really would like you guys to apply, read and try the patches, read the
> code, then discuss :)
> There are a lot of FIXME and TODO.
>
> This one answers your question:
>
> 16 sub connect {
> 17 my ( $self );
> 18 my $conn = Net::RabbitFoot->new()->load_xml_spec()->connect(
> 19 host => 'localhost', # TODO Move this to KOHA_CONF
> 20 port => 5672,
> 21 user => 'guest',
> 22 pass => 'guest',
> 23 vhost => '/',
> 24 );
> 25
> 26 return $conn;
> 27 }
>
> So different vhost, user and pass can be used.
I haven't tried the patches but I have read your code, and that's why I've
voiced my concerns about multi-tenancy. There wasn't enough information there
to understand, so that's why I asked the questions.
Your reply almost answers the question, but not quite, so now I'm just reading
about RabbitMQ.
If I understand correctly, each Koha instance would get its own RabbitMQ
"vhost", and within each "vhost" there would be named queues (which at the
moment are hard-coded but could be configurable I suppose).
Cool. That removes my concerns about multi-tenancy. Thanks for that, Jonathan.
(Maybe in your example you could use something like "vhost => '/kohademo'" or
maybe include some code comments just so it's more obvious how it works.)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 03:20:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 02:20:27 +0000
Subject: [Koha-bugs] [Bug 22417] Delegate background jobs execution
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417
--- Comment #16 from David Cook ---
(In reply to Tom?s Cohen Arazi from comment #12)
> My only doubt is if we should really model the task queue with a message
> queue. I tried the same Jonathan tried but using AnyEvent::Task and the
> results where similar, and it only required a unix socket to communicate
> client and server processes. My suggestion was to use zeromq. But lets see
> how this goes. Specially in the integration step.
Yeah, for #10662, I used POE::Component::JobQueue and a Unix socket. It was
very effective, although my bespoke implementation had a number of limitations.
I figured allowing TCP sockets also might be a good idea just to allow for more
distributed architectures.
When I was working on #10662, I was considering both RabbitMQ and ZeroMQ, but
ended up doing my own job queue. I'm not necessarily sold on RabbitMQ yet, but
I figure if Jonathan is willing to do it, I'm happy to see how this goes too.
I'm not willing to put in the time to make it happen :/.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 04:28:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 03:28:47 +0000
Subject: [Koha-bugs] [Bug 22437] Subsequent authority merges in cron cause
biblios to lose authority information
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22437
David Cook changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |dcook at prosentient.com.au
--- Comment #2 from David Cook ---
I don't have time to look at this, but I applaud you on your efforts!
If you have any issues with
https://wiki.koha-community.org/wiki/Git_bz_configuration, visit #koha on the
OFTC IRC network, or email koha-devel at lists.koha-community.org.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 07:11:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 06:11:16 +0000
Subject: [Koha-bugs] [Bug 21538] Show ilbrary on account page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21538
Bug 21538 depends on bug 21401, which changed state.
Bug 21401 Summary: Account offsets should save the transacting library
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21401
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |WONTFIX
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 07:11:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 06:11:15 +0000
Subject: [Koha-bugs] [Bug 21401] Account offsets should save the transacting
library
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21401
Josef Moravec changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |WONTFIX
--- Comment #28 from Josef Moravec ---
(In reply to Martin Renvoize from comment #27)
> Was there any further work you wanted to undertake here Josef.. or did it
> all end up folded into bug 19066?
For me, it is covered by bug 19066, so I am not going to continue on this.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 07:12:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 06:12:28 +0000
Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not
descriptions
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435
Josef Moravec changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |josef.moravec at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 07:56:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 06:56:54 +0000
Subject: [Koha-bugs] [Bug 14293] Error in the calculation of the suspension
of users per day
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293
--- Comment #26 from Katrin Fischer ---
(In reply to Jonathan Druart from comment #25)
> (In reply to Koha Team Lyon 3 from comment #24)
> > In my opinion, if suspension_chargeperiod = 2, we should not charge on the
> > first day... but, I'm not sure of the behaviour in the current version of
> > Koha.
>
> Did not test neither remember. But my feeling is that: if you are late, you
> pay. If you do not want this behavior you could use the grace.
>
> Before continuing on this maybe we should ask on the list?
I think we could use the "when to charge" parameter for this as it's the same
problem as with fines. It allows to charge at the beginning of the interval
(charge first day) or at the end (charge after 2 days). This way the behavior
would be configurable and we even have the option already.
What do you think?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 08:28:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 07:28:34 +0000
Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235
--- Comment #48 from Josef Moravec ---
Created attachment 85885
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85885&action=edit
Bug 18235: (QA follow-up) Fix POD
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 08:28:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 07:28:39 +0000
Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235
--- Comment #49 from Josef Moravec ---
Created attachment 85886
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85886&action=edit
Bug 18235: (QA follow-up) Add missing filters
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 08:29:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 07:29:32 +0000
Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235
--- Comment #50 from Josef Moravec ---
Comment on attachment 85214
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85214
Bug 18235: DB changes
Review of attachment 85214:
--> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18235&attachment=85214)
-----------------------------------------------------------------
:::
installer/data/mysql/atomicupdate/bug_18235-add-search_field-facet_order.sql
@@ +1,1 @@
> +ALTER TABLE search_field ADD COLUMN facet_order TINYINT(4) DEFAULT '0' AFTER weight;
Here is default 0
::: installer/data/mysql/kohastructure.sql
@@ +1493,4 @@
> `label` varchar(255) NOT NULL COMMENT 'the human readable name of the field, for display',
> `type` ENUM('', 'string', 'date', 'number', 'boolean', 'sum', 'isbn', 'stdno') NOT NULL COMMENT 'what type of data this holds, relevant when storing it in the search engine',
> `weight` decimal(5,2) DEFAULT NULL,
> + `facet_order` TINYINT(4) DEFAULT NULL COMMENT 'the order place of the field in facet list if faceted',
And here NULL
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 08:35:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 07:35:48 +0000
Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235
--- Comment #51 from Josef Moravec ---
Comment on attachment 85212
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85212
Bug 18235: ES - Facets configurable
Review of attachment 85212:
--> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18235&attachment=85212)
-----------------------------------------------------------------
::: Koha/SearchEngine/Elasticsearch.pm
@@ +971,5 @@
> + my @faceted_fields = Koha::SearchFields->search(
> + { name => { -in => \@search_field_names }, facet_order => { '!=' => undef } }, { order_by => ['facet_order'] }
> + );
> + my @not_faceted_fields = Koha::SearchFields->search(
> + { name => { -in => \@search_field_names }, facet_order => undef }, { order_by => ['facet_order'] }
Why do you retrieve fields from database in 2 queries, you always use them all.
::: admin/searchengine/elasticsearch/mappings.pl
@@ +215,4 @@
> push @all_search_fields, $search_field_unblessed;
> }
>
> +my @facetable_fields = Koha::SearchEngine::Elasticsearch->get_facetable_fields();
get_facetable_fields is called 3 or 4 times every run of mappings.pl.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 08:38:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 07:38:35 +0000
Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235
Josef Moravec changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
CC| |josef.moravec at gmail.com,
| |oleonard at myacpl.org
--- Comment #52 from Josef Moravec ---
Hi Jonathan, great job, I have just some small questions (see above)
I also adding Owen if he can advice us how to do the UI better, it is not
obvious that the facet order could be changed, also the facet table is at the
end of page and easy to oversee...
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 09:18:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 08:18:48 +0000
Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567
--- Comment #49 from Josef Moravec ---
Created attachment 85887
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85887&action=edit
Bug 14567: (QA follow-up) Fix html structure
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 09:18:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 08:18:52 +0000
Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567
--- Comment #50 from Josef Moravec ---
Created attachment 85888
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85888&action=edit
Bug 14567: (QA follow-up) Remove use of not needed modules
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 09:21:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 08:21:26 +0000
Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567
Josef Moravec changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |josef.moravec at gmail.com
Status|Signed Off |Failed QA
--- Comment #51 from Josef Moravec ---
I have only one concern here: You can't say from system preference
place/descipriton it is only Opac related! I would to see this preference in
OPAC category, or at least update descirption?
Marking failed QA means I would like to have an answer here...
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 09:33:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 08:33:59 +0000
Subject: [Koha-bugs] [Bug 21401] Account offsets should save the transacting
library
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21401
--- Comment #29 from Martin Renvoize ---
Brill, thanks for the update Josef. ?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 09:42:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 08:42:50 +0000
Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request
datatable to be customisable
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063
--- Comment #36 from Josef Moravec ---
Comment on attachment 84788
--> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84788
Bug 21063: (follow-up) Add user ID to column list
Review of attachment 84788:
--> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=21063&attachment=84788)
-----------------------------------------------------------------
::: Koha/REST/V1/Illrequests.pm
@@ +125,4 @@
> foreach my $p(@{$patron_arr}) {
> if ($p->{borrowernumber} == $req->borrowernumber) {
> $to_push->{patron} = {
> + borrowernumber => $p->{borrowernumber},
according to our api name conventions, this should be patron_id
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 09:44:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 08:44:03 +0000
Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request
datatable to be customisable
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063
Josef Moravec changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
--- Comment #37 from Josef Moravec ---
(In reply to Andrew Isherwood from comment #35)
> (In reply to Josef Moravec from comment #33)
> > Also, why to have three columns for patron identity?
> We had different customers asking for different fields (for sorting and
> filtering), so it was easiest just to include all three, then they can be
> turned on or off as needed
I don't like this, it makes inconsistancy in system, we should use standard
pattern here: Firstname Surname (cardnumber) with link to moremember.pl.
Ideally generated by patron-title.inc template.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 09:44:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 08:44:34 +0000
Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request
datatable to be customisable
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063
--- Comment #38 from Josef Moravec ---
Created attachment 85889
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85889&action=edit
Bug 21063: Add more tests
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 09:50:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 08:50:54 +0000
Subject: [Koha-bugs] [Bug 22306] Elasticsearch search not working - it
returns no result found in catalog search
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22306
--- Comment #2 from Ere Maijala ---
Have you tried resetting the index mappings (Koha administration => Search
engine configuration)?
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 09:51:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 08:51:38 +0000
Subject: [Koha-bugs] [Bug 20535] ModZebra called with $record with items
stripped in ModBiblioMarc
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20535
Josef Moravec changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 09:51:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 08:51:41 +0000
Subject: [Koha-bugs] [Bug 20535] ModZebra called with $record with items
stripped in ModBiblioMarc
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20535
Josef Moravec changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #82844|0 |1
is obsolete| |
--- Comment #4 from Josef Moravec ---
Created attachment 85890
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85890&action=edit
Bug 20535: ModZebra called with $record with items stripped
ModZebra called with $record with items stripped in
ModBiblioMarc. Remove $record argument to force
record to be loaded again from database with items
embedded.
How to test:
1) Make sure biblios are indexed (with
rebuild_elastic_search.pl).
2) Perform a search that will produce a sample result
containing at least one biblio with items.
3) Edit and save a biblio with items.
4) Perform the same search again, the updated biblio
should now have no items when viewed in the search
results (No items).
5) Apply patch.
6) Repeat step 1-3.
7) The updated biblio should now have items when viewed
in the search results.
Signed-off-by: Josef Moravec
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 10:06:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 09:06:13 +0000
Subject: [Koha-bugs] [Bug 22439] New: Duplicated code in PrepHostMarcField
and prepare_host_field
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22439
Bug ID: 22439
Summary: Duplicated code in PrepHostMarcField and
prepare_host_field
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Cataloging
Assignee: koha-bugs at lists.koha-community.org
Reporter: pasi.kallinen at koha-suomi.fi
QA Contact: testopia at bugs.koha-community.org
CC: m.de.rooy at rijksmuseum.nl
Target Milestone: ---
The C4/Biblio.pm subroutines PrepHostMarcField and prepare_host_field both do
the same thing, so should be merged.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 10:08:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 09:08:59 +0000
Subject: [Koha-bugs] [Bug 20492] Add missing case for advanced search year
limit in _fix_limit_special_cases
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20492
Josef Moravec changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
CC| |josef.moravec at gmail.com
--- Comment #5 from Josef Moravec ---
Hi David,
This does work, however only in OPAC, publication year in staff is not affected
and still does not work in Elasticsearch
Also, I think the test for this change is needed...
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 10:20:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 09:20:19 +0000
Subject: [Koha-bugs] [Bug 18163] Elasticsearch advanced search by item type
not working with item-level_itypes turned off (biblio record)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18163
Josef Moravec changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #75564|0 |1
is obsolete| |
Attachment #75565|0 |1
is obsolete| |
--- Comment #7 from Josef Moravec ---
Created attachment 85891
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85891&action=edit
Bug 18163: Unit tests
prove -v t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 10:20:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 09:20:22 +0000
Subject: [Koha-bugs] [Bug 18163] Elasticsearch advanced search by item type
not working with item-level_itypes turned off (biblio record)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18163
--- Comment #8 from Josef Moravec ---
Created attachment 85892
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85892&action=edit
Bug 18163: Pass through limits in ES
Before these patches we only allow a small subset of indexes to be used
as limits - if we are going to let users add new fields eventually we
probably don't want to strip out terms we didn't plan for.
To test:
1 - Enable ES
2 - Using sample kohadevbox data try a search like this (or adjust as
necessary):
http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=kw&idx=kw&idx=kw&limit=subject%2Cphr%3Astreet&sort_by=relevance&do=Search
3 - Note nothing is found
4 - Apply patches
5 - Repeat search
6 - It works!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 10:21:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 09:21:06 +0000
Subject: [Koha-bugs] [Bug 18163] Elasticsearch advanced search by item type
not working with item-level_itypes turned off (biblio record)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18163
Josef Moravec changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
Assignee|gmcharlt at gmail.com |nick at bywatersolutions.com
CC| |josef.moravec at gmail.com
--- Comment #9 from Josef Moravec ---
Hi Nick, nice enhancement, but the test does not cover the change - it passes
with and without the second patch.
I am attaching rebased patches, as there were some minor conflicts.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 10:21:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 09:21:16 +0000
Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request
datatable to be customisable
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063
--- Comment #39 from Andrew Isherwood ---
Created attachment 85893
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85893&action=edit
Bug 21063: (follow-up) borrowernumber -> patron_id
As per comment #36 here:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063#c36
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 10:27:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 09:27:53 +0000
Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request
datatable to be customisable
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063
--- Comment #40 from Andrew Isherwood ---
(In reply to Josef Moravec from comment #36)
> Comment on attachment 84788 [details] [review]
> Bug 21063: (follow-up) Add user ID to column list
>
> Review of attachment 84788 [details] [review]:
> -----------------------------------------------------------------
>
> ::: Koha/REST/V1/Illrequests.pm
> @@ +125,4 @@
> > foreach my $p(@{$patron_arr}) {
> > if ($p->{borrowernumber} == $req->borrowernumber) {
> > $to_push->{patron} = {
> > + borrowernumber => $p->{borrowernumber},
>
> according to our api name conventions, this should be patron_id
Thanks for that Josef, this is now done. It has introduced a slight
inconsistency in that we now have the following in the API response:
Request object:
{
[...]
borrowernumber: 123,
patron: {
patron_id: 123
}
[...]
}
The borrowernumber in the request object comes directly from the column name in
the request table. It feels potentially error prone to start introducing
mapping from borrowernumber->patron_id on egress and patron_id->borrowernumber
on ingress. What do you think?
I don't know, in my mind, it's not an ideal situation to be in having a naming
convention for API routes that differs from the naming convention everywhere
else, but that's how it is, so I guess we just need to work with it.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 10:39:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 09:39:07 +0000
Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request
datatable to be customisable
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063
--- Comment #41 from Josef Moravec ---
(In reply to Andrew Isherwood from comment #40)
> (In reply to Josef Moravec from comment #36)
> > Comment on attachment 84788 [details] [review] [review]
> > Bug 21063: (follow-up) Add user ID to column list
> >
> > Review of attachment 84788 [details] [review] [review]:
> > -----------------------------------------------------------------
> >
> > ::: Koha/REST/V1/Illrequests.pm
> > @@ +125,4 @@
> > > foreach my $p(@{$patron_arr}) {
> > > if ($p->{borrowernumber} == $req->borrowernumber) {
> > > $to_push->{patron} = {
> > > + borrowernumber => $p->{borrowernumber},
> >
> > according to our api name conventions, this should be patron_id
>
> Thanks for that Josef, this is now done. It has introduced a slight
> inconsistency in that we now have the following in the API response:
>
> Request object:
> {
> [...]
> borrowernumber: 123,
> patron: {
> patron_id: 123
> }
> [...]
> }
>
> The borrowernumber in the request object comes directly from the column name
> in the request table. It feels potentially error prone to start introducing
> mapping from borrowernumber->patron_id on egress and
> patron_id->borrowernumber on ingress. What do you think?
>
> I don't know, in my mind, it's not an ideal situation to be in having a
> naming convention for API routes that differs from the naming convention
> everywhere else, but that's how it is, so I guess we just need to work with
> it.
We should take the rfc to development meeting, vote it and then update the
endpoint as it was done with /holds endpoint
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:08:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 10:08:56 +0000
Subject: [Koha-bugs] [Bug 22283] Translation file
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22283
--- Comment #10 from Alex Arnaud ---
(In reply to Katrin Fischer from comment #9)
> Would it not be easier to avoid the quotes overall? I think translators
> won't be able to tell when they are translating Javascript strings and when
> they are working on normal text, where this trick won't work. But glad you
> found a fix! Will you change on pootle?
Seems that Pootle treat escaping as an error. So i made a suggestion without
quotes.
NoQuote++
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:16:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 10:16:23 +0000
Subject: [Koha-bugs] [Bug 17229] ILS-DI HoldTitle and HoldItem should check
if patron is expired
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229
--- Comment #31 from Victor Grousset/tuxayo ---
Hi :)
To preserve the validity of the sign off (and other reasons which I don't
remember ^^"), it's usual to do followup patches instead of amending the signed
one.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:22:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 10:22:08 +0000
Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request
datatable to be customisable
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063
--- Comment #42 from Andrew Isherwood ---
(In reply to Josef Moravec from comment #37)
> (In reply to Andrew Isherwood from comment #35)
> > (In reply to Josef Moravec from comment #33)
> > > Also, why to have three columns for patron identity?
>
> > We had different customers asking for different fields (for sorting and
> > filtering), so it was easiest just to include all three, then they can be
> > turned on or off as needed
>
> I don't like this, it makes inconsistancy in system, we should use standard
> pattern here: Firstname Surname (cardnumber) with link to moremember.pl.
> Ideally generated by patron-title.inc template.
I think this raises a bigger question of whether the current convention of
Firstname Surname (cardnumber) addresses users' requirements. In our experience
here, it doesn't. I think it's maybe worth having a separate discussion of
whether we should be reconsidering the current situation and whether we should
be making other DataTable instances in line with what we have here. I think
it's certainly worth at least discussing.
Which does beg the question of what we do to achieve PQA on this bug. We don't
want it to be dependent on a potentially far reaching discussion. Do you think
we should keep it as is, pending the discussion, or make it consistent with
elsewhere, then address as appropriate following the discussion?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:23:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 10:23:23 +0000
Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request
datatable to be customisable
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063
--- Comment #43 from Andrew Isherwood ---
Adding Katrin and Owen to this so they're aware of the issue detailed in
comment #42
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:33:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 10:33:09 +0000
Subject: [Koha-bugs] [Bug 22440] New: ILL API response objects inconsistent
with other endpoints
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440
Bug ID: 22440
Summary: ILL API response objects inconsistent with other
endpoints
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: ILL
Assignee: koha-bugs at lists.koha-community.org
Reporter: andrew.isherwood at ptfs-europe.com
Target Milestone: ---
The response object returned from the /api/vi/illrequest GET route isn't
consistent with response objects supplied by other routes, such as the patrons
route.
We have an RFC for this route here:
https://wiki.koha-community.org/wiki/Illrequests_endpoint_RFC
Josef has made some initial recommendations on what the properties should be
named to make them consistent with other routes. We could do with expanding
this RFC to make it complete, including a spec on how object embedding should
be done since, to date, this is the only route that does this.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:33:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 10:33:50 +0000
Subject: [Koha-bugs] [Bug 22440] ILL API response objects inconsistent with
other endpoints
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440
Andrew Isherwood changed:
What |Removed |Added
----------------------------------------------------------------------------
Priority|P5 - low |P4
CC| |josef.moravec at gmail.com
Depends on| |18589
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589
[Bug 18589] Show ILLs as part of patron profile
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:33:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 10:33:50 +0000
Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589
Andrew Isherwood changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |22440
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440
[Bug 22440] ILL API response objects inconsistent with other endpoints
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:34:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 10:34:01 +0000
Subject: [Koha-bugs] [Bug 22440] ILL API response objects inconsistent with
other endpoints
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440
Andrew Isherwood changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |In Discussion
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:38:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 10:38:39 +0000
Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request
datatable to be customisable
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063
--- Comment #44 from Josef Moravec ---
(In reply to Andrew Isherwood from comment #42)
> (In reply to Josef Moravec from comment #37)
> > (In reply to Andrew Isherwood from comment #35)
> > > (In reply to Josef Moravec from comment #33)
> > > > Also, why to have three columns for patron identity?
> >
> > > We had different customers asking for different fields (for sorting and
> > > filtering), so it was easiest just to include all three, then they can be
> > > turned on or off as needed
> >
> > I don't like this, it makes inconsistancy in system, we should use standard
> > pattern here: Firstname Surname (cardnumber) with link to moremember.pl.
> > Ideally generated by patron-title.inc template.
>
> I think this raises a bigger question of whether the current convention of
> Firstname Surname (cardnumber) addresses users' requirements. In our
> experience here, it doesn't. I think it's maybe worth having a separate
> discussion of whether we should be reconsidering the current situation and
> whether we should be making other DataTable instances in line with what we
> have here. I think it's certainly worth at least discussing.
>
> Which does beg the question of what we do to achieve PQA on this bug. We
> don't want it to be dependent on a potentially far reaching discussion. Do
> you think we should keep it as is, pending the discussion, or make it
> consistent with elsewhere, then address as appropriate following the
> discussion?
My opinion is, to make it consistent with current system. As you pointed out,
such a discussion could take 'some' time... And is definitely out of scope of
this report...
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:59:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 10:59:00 +0000
Subject: [Koha-bugs] [Bug 22396] koha-sip script does not start the server
correctly
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22396
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |martin.renvoize at ptfs-europe
| |.com
Status|Pushed to Master |Pushed to Stable
--- Comment #7 from Martin Renvoize ---
Pushed to 18.11.x for 18.11.04
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:00:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 11:00:32 +0000
Subject: [Koha-bugs] [Bug 14850] Funds from inactive budgets appear in
'Funds' dropdown on acqui/invoice.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14850
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |martin.renvoize at ptfs-europe
| |.com
Status|Pushed to Master |Pushed to Stable
--- Comment #20 from Martin Renvoize ---
Pushed to 18.11.x for 18.11.04
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:03:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 11:03:14 +0000
Subject: [Koha-bugs] [Bug 18957] Item renewed online does not show the time
of renewal
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18957
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |Pushed to Stable
CC| |martin.renvoize at ptfs-europe
| |.com
--- Comment #15 from Martin Renvoize ---
Pushed to 18.11.x for 18.11.04
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:04:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 11:04:45 +0000
Subject: [Koha-bugs] [Bug 15149] Serials: Test prediction pattern does not
consider Subscription start and end date
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15149
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |Pushed to Stable
CC| |martin.renvoize at ptfs-europe
| |.com
--- Comment #10 from Martin Renvoize ---
Pushed to 18.11.x for 18.11.04
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:05:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 11:05:52 +0000
Subject: [Koha-bugs] [Bug 22411] Dates in log viewer not formatted correctly
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22411
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |Pushed to Stable
CC| |martin.renvoize at ptfs-europe
| |.com
--- Comment #5 from Martin Renvoize ---
Pushed to 18.11.x for 18.11.04
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:08:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 11:08:09 +0000
Subject: [Koha-bugs] [Bug 22378] Fix sound alerts on SCO
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22378
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |martin.renvoize at ptfs-europe
| |.com
Status|Pushed to Master |Pushed to Stable
--- Comment #5 from Martin Renvoize ---
Pushed to 18.11.x for 18.11.04.
I'm sure we've broken this sort of thing a few times.. would have liked to have
seen a selenium test for it...
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:09:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 11:09:39 +0000
Subject: [Koha-bugs] [Bug 22441] New: SCO sound alerts need a selenium test
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22441
Bug ID: 22441
Summary: SCO sound alerts need a selenium test
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Test Suite
Assignee: chris at bigballofwax.co.nz
Reporter: martin.renvoize at ptfs-europe.com
QA Contact: testopia at bugs.koha-community.org
Target Milestone: ---
I've vague recollection of fixes around this area often introducing
regressions.. could we perhaps work out a selenium test for this?
Relates to my comment in bug 22378
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:09:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 11:09:49 +0000
Subject: [Koha-bugs] [Bug 22441] SCO sound alerts need a selenium test
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22441
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |22378
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22378
[Bug 22378] Fix sound alerts on SCO
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:09:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 11:09:49 +0000
Subject: [Koha-bugs] [Bug 22378] Fix sound alerts on SCO
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22378
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |22441
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22441
[Bug 22441] SCO sound alerts need a selenium test
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:10:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 11:10:25 +0000
Subject: [Koha-bugs] [Bug 22441] SCO sound alerts need a selenium test
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22441
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:12:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 11:12:50 +0000
Subject: [Koha-bugs] [Bug 18251] SCO alerts - need a trigger for successful
checkouts
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|minor |enhancement
CC| |martin.renvoize at ptfs-europe
| |.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:13:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 11:13:51 +0000
Subject: [Koha-bugs] [Bug 17168] Add a command line script for updating
patron category based on status
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168
Tom?s Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
|y.org |
CC| |tomascohen at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:14:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 11:14:59 +0000
Subject: [Koha-bugs] [Bug 18251] SCO alerts - need a trigger for successful
checkouts
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |RESOLVED
Resolution|--- |FIXED
--- Comment #44 from Martin Renvoize ---
Enhancement won't be backported to 18.11.x series.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:15:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 11:15:00 +0000
Subject: [Koha-bugs] [Bug 22406] Add ability to play internal sounds in self
checkout system
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22406
Bug 22406 depends on bug 18251, which changed state.
Bug 18251 Summary: SCO alerts - need a trigger for successful checkouts
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:15:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 11:15:46 +0000
Subject: [Koha-bugs] [Bug 22397] Wrong message in koha-sip --start
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22397
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |Pushed to Stable
CC| |martin.renvoize at ptfs-europe
| |.com
--- Comment #5 from Martin Renvoize ---
Pushed to 18.11.x for 18.11.04
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:16:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 11:16:12 +0000
Subject: [Koha-bugs] [Bug 21206] C4::Items - Remove GetItem
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |martin.renvoize at ptfs-europe
| |.com
Resolution|--- |FIXED
Status|Pushed to Master |RESOLVED
--- Comment #38 from Martin Renvoize ---
Enhancement will not be backported to 18.11.x series.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:16:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 11:16:12 +0000
Subject: [Koha-bugs] [Bug 18252] Move C4::Items code to the Koha namespace
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18252
Bug 18252 depends on bug 21206, which changed state.
Bug 21206 Summary: C4::Items - Remove GetItem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:16:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 11:16:12 +0000
Subject: [Koha-bugs] [Bug 21252]
Koha::Patron->do_check_for_previous_checkout should take Koha::Item as
parameter
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21252
Bug 21252 depends on bug 21206, which changed state.
Bug 21206 Summary: C4::Items - Remove GetItem
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:16:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 11:16:50 +0000
Subject: [Koha-bugs] [Bug 22300] Staff search results: Opt groups in 'sort'
pull down are not well formatted
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22300
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|Pushed to Master |RESOLVED
CC| |martin.renvoize at ptfs-europe
| |.com
--- Comment #5 from Martin Renvoize ---
Enhancement, will not be backported to 18.11.x series
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:17:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 11:17:19 +0000
Subject: [Koha-bugs] [Bug 21870] Convert browser alerts to modals: OPAC user
summary
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21870
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|Pushed to Master |RESOLVED
CC| |martin.renvoize at ptfs-europe
| |.com
--- Comment #6 from Martin Renvoize ---
Enhancement will not be backported to 18.11.x series.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:17:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 11:17:20 +0000
Subject: [Koha-bugs] [Bug 18117] Convert browser alerts to modals
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18117
Bug 18117 depends on bug 21870, which changed state.
Bug 21870 Summary: Convert browser alerts to modals: OPAC user summary
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21870
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:17:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 11:17:53 +0000
Subject: [Koha-bugs] [Bug 22026] Remove `use Modern::Perl` from
Koha::REST::classes
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22026
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|REOPENED |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:19:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 11:19:05 +0000
Subject: [Koha-bugs] [Bug 22349] Overzealous deletion of data in
t/db_dependant/Koha/Acquisitions/Booksellers.t
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22349
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|Pushed to Master |RESOLVED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:20:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 11:20:39 +0000
Subject: [Koha-bugs] [Bug 22337] Make it clearer that language preferences
can be re-ordered
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22337
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|Pushed to Master |RESOLVED
--- Comment #6 from Martin Renvoize ---
Enhancement, will not be backported to 18.11.x series.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:28:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 11:28:42 +0000
Subject: [Koha-bugs] [Bug 22014] Add ability to send "00" in SIP CV field on
checkin success
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22014
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|Pushed to Master |RESOLVED
CC| |martin.renvoize at ptfs-europe
| |.com
--- Comment #8 from Martin Renvoize ---
Enhancement, will not be backported to 18.11.x series
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:28:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 11:28:42 +0000
Subject: [Koha-bugs] [Bug 22016] Always send CT field for SIP checkin,
even if empty
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22016
Bug 22016 depends on bug 22014, which changed state.
Bug 22014 Summary: Add ability to send "00" in SIP CV field on checkin success
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22014
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:29:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 11:29:24 +0000
Subject: [Koha-bugs] [Bug 22016] Always send CT field for SIP checkin,
even if empty
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22016
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |martin.renvoize at ptfs-europe
| |.com
Resolution|--- |FIXED
Status|Pushed to Master |RESOLVED
--- Comment #6 from Martin Renvoize ---
Enhancement, will not be backported to 18.11.x series.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:29:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 11:29:25 +0000
Subject: [Koha-bugs] [Bug 22043] SIP Checkin Response alert flag set to
often set to Y incorrectly
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22043
Bug 22043 depends on bug 22016, which changed state.
Bug 22016 Summary: Always send CT field for SIP checkin, even if empty
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22016
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:30:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 11:30:18 +0000
Subject: [Koha-bugs] [Bug 12318] Show subscription shelving location on
subscription tabs
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12318
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |FIXED
Status|Pushed to Master |RESOLVED
--- Comment #9 from Martin Renvoize ---
Enhancement, will not be backported to 18.11.x series.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:29:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 11:29:53 +0000
Subject: [Koha-bugs] [Bug 21875] Handling subject line in Letters.pm
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21875
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |RESOLVED
Resolution|--- |FIXED
--- Comment #16 from Martin Renvoize ---
Enhancement will not be backported to 18.11.x series.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:33:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 11:33:55 +0000
Subject: [Koha-bugs] [Bug 21765] AutoUnsuspendReserves manually sets holds
fields instead of calling ->resume
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21765
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |martin.renvoize at ptfs-europe
| |.com
Severity|enhancement |minor
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:35:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 11:35:34 +0000
Subject: [Koha-bugs] [Bug 21765] AutoUnsuspendReserves manually sets holds
fields instead of calling ->resume
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21765
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |Pushed to Stable
--- Comment #9 from Martin Renvoize ---
Pushed to 18.11.x for 18.11.04 - I considered the lack of an action log in this
case a bug the overriding factor here and so switch back from 'enhancement' to
'bug'.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:38:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 11:38:30 +0000
Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376
Victor Grousset/tuxayo changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |victor.grousset at biblibre.co
| |m
--- Comment #56 from Victor Grousset/tuxayo ---
Hi, are you sure that bug 22330 encompasses this one? Because it(22330) seems
to concert only holds.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:40:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 11:40:06 +0000
Subject: [Koha-bugs] [Bug 22084] Plugin upgrade method and database plugin
version storage will never be triggered for existing installs
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22084
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |martin.renvoize at ptfs-europe
| |.com
Severity|enhancement |normal
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:41:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 11:41:39 +0000
Subject: [Koha-bugs] [Bug 22084] Plugin upgrade method and database plugin
version storage will never be triggered for existing installs
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22084
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |Pushed to Stable
--- Comment #9 from Martin Renvoize ---
Pushed to 18.11.x for 18.11.04
rmaint note: the parent bug for this was backported all the way to 17.11.x
series so we need it all the way down.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:42:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 11:42:20 +0000
Subject: [Koha-bugs] [Bug 22084] Plugin upgrade method and database plugin
version storage will never be triggered for existing installs
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22084
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |rel_17_11_candidate,
| |rel_18_05_candidate,
| |rel_18_11_candidate
Status|Pushed to Stable |Pushed to Master
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:42:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 11:42:29 +0000
Subject: [Koha-bugs] [Bug 22084] Plugin upgrade method and database plugin
version storage will never be triggered for existing installs
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22084
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |Pushed to Stable
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:42:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 11:42:58 +0000
Subject: [Koha-bugs] [Bug 21722] Update C4::Accounts::chargelostitem to use
Koha::Account->add_debit
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722
Bug 21722 depends on bug 21747, which changed state.
Bug 21747 Summary: Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |RESOLVED
Resolution|--- |FIXED
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:42:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 11:42:58 +0000
Subject: [Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use
Koha::Account->add_debit and Koha::Account::Line->adjust
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Pushed to Master |RESOLVED
Resolution|--- |FIXED
--- Comment #24 from Martin Renvoize ---
Enhancement, will not be backported to 18.11.x series.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:47:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 11:47:06 +0000
Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request
datatable to be customisable
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063
--- Comment #45 from Andrew Isherwood ---
Created attachment 85894
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85894&action=edit
Bug 21063: (follow-up) Fix more rebase problems
More minor rebase problems fixed
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:48:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 11:48:11 +0000
Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request
datatable to be customisable
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063
--- Comment #46 from Andrew Isherwood ---
Created attachment 85895
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85895&action=edit
Bug 21063: (follow-up) Make patron col consistent
As per comment #44 here:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063#c44
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:49:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 11:49:54 +0000
Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request
datatable to be customisable
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063
Andrew Isherwood changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #85895|0 |1
is obsolete| |
--- Comment #47 from Andrew Isherwood ---
Created attachment 85896
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85896&action=edit
Bug 21063: (follow-up) Make patron col consistent
As per comment #44 here:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063#c44
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:53:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 11:53:59 +0000
Subject: [Koha-bugs] [Bug 22043] SIP Checkin Response alert flag set to
often set to Y incorrectly
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22043
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #85884|0 |1
is obsolete| |
--- Comment #8 from Kyle M Hall ---
Created attachment 85897
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85897&action=edit
Bug 22043: (QA Follow-up) Add paramter to control behavior
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 14:27:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 13:27:39 +0000
Subject: [Koha-bugs] [Bug 22442] New: Item search CSV export broken
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22442
Bug ID: 22442
Summary: Item search CSV export broken
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: major
Priority: P5 - low
Component: Searching
Assignee: koha-bugs at lists.koha-community.org
Reporter: oleonard at myacpl.org
QA Contact: testopia at bugs.koha-community.org
Target Milestone: ---
Several columns in the item search CSV export are empty: Title, Publication
date, Publisher, Collection.
I think this was caused by the template variable filter switch.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 15:17:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 14:17:28 +0000
Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Ere Maijala changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 15:17:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 14:17:38 +0000
Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Ere Maijala changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #85777|0 |1
is obsolete| |
--- Comment #69 from Ere Maijala ---
Created attachment 85899
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85899&action=edit
Bug 20664: Add unit tests for GetMarcItem
To test:
prove -v t/db_dependent/Items.t
Signed-off-by: Josef Moravec
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 15:17:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 14:17:42 +0000
Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Ere Maijala changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #85778|0 |1
is obsolete| |
--- Comment #70 from Ere Maijala ---
Created attachment 85900
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85900&action=edit
Bug 20664: Unit tests for GetMarcItemFields
To test:
prove -v t/db_dependent/Items.t
Signed-off-by: Josef Moravec
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 15:17:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 14:17:33 +0000
Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Ere Maijala changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #85776|0 |1
is obsolete| |
--- Comment #68 from Ere Maijala ---
Created attachment 85898
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85898&action=edit
Bug 20664: Optimize retrieval of biblio and item data
Optimizes embedding of item data in MARC and fixes several bottlenecks
encountered while profiling OAI-PMH and exporting of records. There are two
ways this is accomplished:
1.) Create optimized method for fetching item fields for MARC embedding.
2.) Use the cache service more and where repeated calls are made.
Test plan:
1.) Before applying the patch, time an export_records.pl run for a set of
biblios that also have items. Run it a couple of times to account for initial
slowness and possible fluctuations. For example:
time misc/export_records.pl --record-type bibs --starting_biblionumber 960000
--ending_biblionumber 965000 --format xml --filename unoptimized.xml
2.) Apply the patch.
3.) Time the export process again with a different output file:
time misc/export_records.pl --record-type bibs --starting_biblionumber 960000
--ending_biblionumber 965000 --format xml --filename optimized.xml
4.) Verify that the optimized process is faster.
5.) Compare the resulting export files to make sure they're identical:
Signed-off-by: Josef Moravec
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 15:17:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 14:17:47 +0000
Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Ere Maijala changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #85779|0 |1
is obsolete| |
--- Comment #71 from Ere Maijala ---
Created attachment 85901
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85901&action=edit
Bug 20664: (follow-up) Fix test for GetMarcItemFields
Without this patch I got this error running the test:
YAML Error: Stream does not end with newline character
Test plan:
prove t/db_dependent/Items.t
Signed-off-by: Josef Moravec
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 15:17:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 14:17:51 +0000
Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Ere Maijala changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #85780|0 |1
is obsolete| |
--- Comment #72 from Ere Maijala ---
Created attachment 85902
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85902&action=edit
Bug 20664: (follow-up) Fix QA whitespace errors
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 15:17:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 14:17:56 +0000
Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
Ere Maijala changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #85781|0 |1
is obsolete| |
--- Comment #73 from Ere Maijala ---
Created attachment 85903
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85903&action=edit
Bug 20664: (follow-up) Fix tests on rebase
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 15:18:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 14:18:00 +0000
Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
--- Comment #74 from Ere Maijala ---
Created attachment 85904
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85904&action=edit
Bug 20664: (follow-up) Switch to Koha objects for retrieving items
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 15:18:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 14:18:04 +0000
Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664
--- Comment #75 from Ere Maijala ---
Created attachment 85905
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85905&action=edit
Bug 20664: (follow-up) Add tests for UseHidingRulesWithBorrowerCategory
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 15:37:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 14:37:15 +0000
Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447
Ere Maijala changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #85416|0 |1
is obsolete| |
--- Comment #89 from Ere Maijala ---
Created attachment 85906
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85906&action=edit
Bug 20447: MARC Holdings support
Enable by setting "SummaryHoldings" option to "Use".
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 15:37:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 14:37:19 +0000
Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447
Ere Maijala changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #85417|0 |1
is obsolete| |
--- Comment #90 from Ere Maijala ---
Created attachment 85907
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85907&action=edit
Bug 20447: Add a batch rebuild script for holdings table.
This script can be used to update the columns in the holdings table from the
MARC record using the rules in the framework. In practice this will only be
required if the koha link field is changed in the framework.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 15:37:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 14:37:24 +0000
Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447
Ere Maijala changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #85418|0 |1
is obsolete| |
--- Comment #91 from Ere Maijala ---
Created attachment 85908
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85908&action=edit
Bug 20447: Add import/export support for holdings
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447
Adds support for importing and exporting biblios with interleaved holdings.
Test plan:
1.) Import the MARCXML file attached to the bug with the -holdings parameter:
misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m
MARCXML
2.) Verify that the holdings records were imported.
3.) Export the same records with holdings:
misc/export_records.pl --record-type=bibs --starting_biblionumber 103
--ending_biblionumber 104 --filename=holdings_export.xml --format=xml
--holdings
4.) Verify that both bibliographic and holding records are exported.
5.) Verify that tests in t/db_dependent/Exporter/Record.t pass.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 15:37:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 14:37:29 +0000
Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447
Ere Maijala changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #85419|0 |1
is obsolete| |
--- Comment #92 from Ere Maijala ---
Created attachment 85909
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85909&action=edit
Bug 20447: DBIX schema changes
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 15:53:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 14:53:48 +0000
Subject: [Koha-bugs] [Bug 3298] Independent item "Status Check"
functionality needed
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3298
Sally Healey changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |sally.healey at cheshireshared
| |services.gov.uk
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 16:04:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 15:04:50 +0000
Subject: [Koha-bugs] [Bug 19318] Add ability to use custom file upload paths
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19318
Kyle M Hall changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |DUPLICATE
Status|Needs Signoff |RESOLVED
--- Comment #6 from Kyle M Hall ---
Pretty sure this is a duplicate of bug 20208 which is a bit fresher than mine.
Closing as a duplicate on that assumption.
*** This bug has been marked as a duplicate of bug 20208 ***
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 16:04:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 15:04:50 +0000
Subject: [Koha-bugs] [Bug 20208] Development - Peddie School - Custom file
upload paths
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20208
--- Comment #6 from Kyle M Hall ---
*** Bug 19318 has been marked as a duplicate of this bug. ***
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 16:31:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 15:31:34 +0000
Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235
--- Comment #53 from Owen Leonard ---
(In reply to Josef Moravec from comment #52)
> the facet table is at
> the end of page and easy to oversee...
I wonder if it should be in a separate tab?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 17:27:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 16:27:44 +0000
Subject: [Koha-bugs] [Bug 8775] Add collection code to lost report
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8775
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 17:27:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 16:27:47 +0000
Subject: [Koha-bugs] [Bug 8775] Add collection code to lost report
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8775
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #85526|0 |1
is obsolete| |
--- Comment #4 from Owen Leonard ---
Created attachment 85910
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85910&action=edit
Bug 8775: Add collection code to lost report
This patch adds a column for collection code to the lost items report.
To test, apply the patch and run the lost items report. You should see a
collection code column.
Test column configuration for this table: Go to Administration ->
Configure columns. Confirm that the "collection_code" column can be
configured and that configuration choices are applied correctly.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 17:36:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 16:36:30 +0000
Subject: [Koha-bugs] [Bug 14451] OPAC Bootstrap theme hides table headings
in holdings display
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14451
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Bootstrap framework drops |OPAC Bootstrap theme hides
|table headings in holdings |table headings in holdings
|display |display
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 17:47:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 16:47:21 +0000
Subject: [Koha-bugs] [Bug 7713] display local license files in about.pl,
rather than via external urls
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7713
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|In Discussion |RESOLVED
Resolution|--- |WONTFIX
--- Comment #2 from Owen Leonard ---
No discussion after seven years... I think this can be closed.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 17:50:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 16:50:07 +0000
Subject: [Koha-bugs] [Bug 7088] Cannot renew items on hold even with override
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088
Liz Rea changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
--- Comment #39 from Liz Rea ---
I personally don't like the 2nd date picker and think it's confusing, at least
how it is labelled. There is something that I find ambiguous about "On hold due
date" but I'm having a hard time putting what it is into words.
Maybe a hover text on the label that explains more what the box is for?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 17:58:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 16:58:17 +0000
Subject: [Koha-bugs] [Bug 22443] New:
t/db_dependent/Koha/Patron/Categories.t contains a DateTime maths error
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22443
Bug ID: 22443
Summary: t/db_dependent/Koha/Patron/Categories.t contains a
DateTime maths error
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Test Suite
Assignee: chris at bigballofwax.co.nz
Reporter: martin.renvoize at ptfs-europe.com
QA Contact: testopia at bugs.koha-community.org
Target Milestone: ---
So, one of the peculiarities of DateTime maths is that 12 plus 1 doesn't always
equal 13 ;)
This calls for an example (using 'limit' for end_of_month mode):
2019-01-31 + 1 month = 2019-02-28
2019-01-31 + 13 months = 2020-02-29 (this one maintains 'end of month' over the
leap year)
2019-02-28 + 12 months = 2020-02-28
Koha does the third case but the test is currently setup for the second.
'dateexpiry'
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 18:04:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 17:04:35 +0000
Subject: [Koha-bugs] [Bug 11340] Make the 'print summary' a custom
slip/notice
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11340
Felicia Beaudry changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |felicia.beaudry at equinoxinit
| |iative.org
--- Comment #4 from Felicia Beaudry ---
+1
This would be really useful.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 18:09:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 17:09:53 +0000
Subject: [Koha-bugs] [Bug 20830] Make sure a fund is selected when ordering
from staged file
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20830
--- Comment #4 from Koha Team Lyon 3 ---
Created attachment 85911
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85911&action=edit
bug 20830: Make sure a fund is selected when ordering from staged file
I simply took again bug 20798 code with a little modification to set the
checking only on selected items of "Select to import" tab. Seems to do the
trick (patch done on version 17.11.13).
Test Plan:
1) Add records to a basket from an import batch
2) Select only some of those items in the batch and don't select any fund for
them.
3) Save : you get the message "Some budgets are no defined .."
4) Apply this patch
5) Select some items and choose a fund for each of them
6) Save : no more message.
Olivier Crouzet
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 18:10:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 17:10:12 +0000
Subject: [Koha-bugs] [Bug 20830] Make sure a fund is selected when ordering
from staged file
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20830
Koha Team Lyon 3 changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 19:51:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 18:51:23 +0000
Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when
adding on order item to existing record
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817
Liz Rea changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
CC| |wizzyrea at gmail.com
--- Comment #6 from Liz Rea ---
Hi Devinim,
Thanks for looking at this feature, it will be really cool.
This works well populating item values from a staged record. I don't
particularly like the UX of adding the two items (the "add item" button is hard
to spot in the long list of fields), but that isn't related to this patch.
There are some QA fails here:
FAIL koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt
FAIL filters
missing_filter at line 328 (
)
missing_filter at line 309 (
)
missing_filter at line 777 ( [% jsinclude # Parse the page
template's JavaScript block if necessary %])
missing_filter at line 329 (
)
missing_filter at line 330 (
)
missing_filter at line 311 (
)
missing_filter at line 307 (
)
missing_filter at line 319 (
)
missing_filter at line 326 (
)
missing_filter at line 324 (
[% iteminfo.marc_value %])
missing_filter at line 327 (
)
missing_filter at line 337 ( )
missing_filter at line 299 (
)
missing_filter at line 317 (
)
missing_filter at line 342 ( )
missing_filter at line 303 (
)
* Commit title does not start with 'Bug XXXXX: ' - 034220c0cc
Fix those up and I'll sign off on this for you. :)
Cheers,
Liz
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 19:56:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 18:56:23 +0000
Subject: [Koha-bugs] [Bug 20208] Custom file upload paths
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20208
Liz Rea changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |wizzyrea at gmail.com
Summary|Development - Peddie School |Custom file upload paths
|- Custom file upload paths |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 20:07:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 19:07:01 +0000
Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for
Z39.50 server searches
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297
Jos?-Mario Monteiro-Santos changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jose-mario.monteiro-santos@
| |inlibro.com
--- Comment #106 from Jos?-Mario Monteiro-Santos ---
(In reply to Martin Renvoize from comment #105)
> I'll try and take a look at tests tomorrow, sorry guys.
Any specific plan in mind ? It's a pretty daunting task to correctly test the
entirety of the Z3950Search sub. I can take a stab at it, but I'd love some
pointers to help me get started.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 20:51:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 19:51:05 +0000
Subject: [Koha-bugs] [Bug 5594] Option to configure default sort order for
items on bib records
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5594
--- Comment #6 from Marjorie Barry-Vila ---
+1
--
You are receiving this mail because:
You are the assignee for the bug.
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 20:57:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 19:57:40 +0000
Subject: [Koha-bugs] [Bug 8775] Add collection code to lost report
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8775
Bin changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #85910|0 |1
is obsolete| |
--- Comment #5 from Bin ---
Created attachment 85912
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85912&action=edit
Bug 8775: Add collection code to lost report
This patch adds a column for collection code to the lost items report.
To test, apply the patch and run the lost items report. You should see a
collection code column.
Test column configuration for this table: Go to Administration ->
Configure columns. Confirm that the "collection_code" column can be
configured and that configuration choices are applied correctly.
Signed-off-by: Bin Wen
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 21:06:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 20:06:43 +0000
Subject: [Koha-bugs] [Bug 13420] Holdings table sorting on volume
information incorrect
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13420
--- Comment #12 from Marjorie Barry-Vila ---
+1
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 21:44:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 20:44:02 +0000
Subject: [Koha-bugs] [Bug 21308] Results from order search do not show the
search parameters.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21308
Bin changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #85525|0 |1
is obsolete| |
--- Comment #4 from Bin ---
Created attachment 85913
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85913&action=edit
Bug 21308: Results from order search do not show the search parameters
This patch modifies the orders search results page so that the search
form appears in the sidebar. This allows the user to view and re-use
their search parameters.
This patch also moves the "no search results" message to the top of the
page in a message box.
To test, apply the patch and go to Acquisitions -> Orders search.
- Perform a search which will return results. In the sidebar you should
see the full orders search form with your search parameters in the
form fields.
- Perform a search which will return no results. You should see the
"Your search returned no results." message in a standard message
dialog.
Signed-off-by: Bin Wen
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 21:51:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 20:51:53 +0000
Subject: [Koha-bugs] [Bug 20882] URI column in the items table is limited to
255 characters
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20882
Marjorie Barry-Vila changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |marjorie.barry-vila at collect
| |o.ca
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 22:00:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 21:00:58 +0000
Subject: [Koha-bugs] [Bug 22444] New: currencies_manage permission doesn't
provide link to manage currencies when selected alone
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22444
Bug ID: 22444
Summary: currencies_manage permission doesn't provide link to
manage currencies when selected alone
Change sponsored?: ---
Product: Koha
Version: 18.11
Hardware: All
OS: All
Status: NEW
Severity: minor
Priority: P5 - low
Component: Acquisitions
Assignee: koha-bugs at lists.koha-community.org
Reporter: andrew at bywatersolutions.com
QA Contact: testopia at bugs.koha-community.org
Target Milestone: ---
Bug 7651 added the permission currencies_manage within the acquisitions
permission subgroup. Giving a borrower just this permission and catalogue does
make them technically able to load /currency.pl, but it doesn't provide them
any link to get there.
To Test:
- create a patron
- give them currencies_manage and catalogue permissions
- log in as this patron
- observe that there is no Currencies link out of Acquisitions and
Administration doesn't appear on the home page or the More menu
- give the patron any other admin permission
- observe that the Currencies link now shows in Acquisitions
- take away admin permissions and give the patron full acquisitions permissions
- observe that a link to Currencies still appears in Acquisitions
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 22:04:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 21:04:38 +0000
Subject: [Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal
fine amount after delay
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336
Mika?l Olangcay Brisebois changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #75379|0 |1
is obsolete| |
--- Comment #13 from Mika?l Olangcay Brisebois ---
Created attachment 85914
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85914&action=edit
Bug 19336: Add --maxfinesday option to fines.pl
This is a functionality we have for some of our clients we want to push
to the community.
Adds the --maxfinesday argument to fines.pl which creates or updates a
fine with the maximum amount set in the circulation rules after the
delay has passed.
e.g.:
./fines.pl --maxfinesdays 30
All item over 30 days late will have the maximal fine applied.
Here is a test plan I followed based on above.
Test plan:
1. Create circulation rule with Overdue fines cap set
2. Set finesMode systempreference to 'Calculate and charge'
3. Check out an item with the due date set 30 days ago
4. In Koha shell run ./fines.pl --maxfinesdays 30
5. There should now be a new fine in the accountlines table of the
amount set in overdue fines cap
Followed test plan, patch worked as intended
Signed-off-by: Alex Buckley
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 22:04:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 21:04:44 +0000
Subject: [Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal
fine amount after delay
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336
Mika?l Olangcay Brisebois changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #75380|0 |1
is obsolete| |
--- Comment #14 from Mika?l Olangcay Brisebois ---
Created attachment 85915
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85915&action=edit
Bug 19336: (follow-up) Correct DateTime and Koha calls
This fixes the 'DateTime does not overload' error.
It also fixes the next error, which was that C4::GetIssuingRules is deprecated.
Finally it now handles no overduefinescap being define (does nothing).
Passes QA test tool
Signed-off-by: Alex Buckley
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 22:04:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 21:04:52 +0000
Subject: [Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal
fine amount after delay
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336
Mika?l Olangcay Brisebois changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #75381|0 |1
is obsolete| |
--- Comment #15 from Mika?l Olangcay Brisebois ---
Created attachment 85916
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85916&action=edit
Bug 19336: (QA follow-up) Initialize $unitcounttotal in case a report is
written
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 22:08:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 21:08:12 +0000
Subject: [Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal
fine amount after delay
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336
Mika?l Olangcay Brisebois changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #85914|0 |1
is obsolete| |
--- Comment #16 from Mika?l Olangcay Brisebois ---
Created attachment 85917
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85917&action=edit
Bug 19336: Add --maxfinesday option to fines.pl
This is a functionality we have for some of our clients we want to push
to the community.
Adds the --maxfinesday argument to fines.pl which creates or updates a
fine with the maximum amount set in the circulation rules after the
delay has passed.
e.g.:
./fines.pl --maxfinesdays 30
All item over 30 days late will have the maximal fine applied.
Here is a test plan I followed based on above.
Test plan:
1. Create circulation rule with Overdue fines cap set
2. Set finesMode systempreference to 'Calculate and charge'
3. Check out an item with the due date set 30 days ago
4. In Koha shell run ./fines.pl --maxfinesdays 30
5. There should now be a new fine in the accountlines table of the
amount set in overdue fines cap
Followed test plan, patch worked as intended
Signed-off-by: Alex Buckley
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 22:08:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 21:08:16 +0000
Subject: [Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal
fine amount after delay
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336
Mika?l Olangcay Brisebois changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #85915|0 |1
is obsolete| |
--- Comment #17 from Mika?l Olangcay Brisebois ---
Created attachment 85918
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85918&action=edit
Bug 19336: (follow-up) Correct DateTime and Koha calls
This fixes the 'DateTime does not overload' error.
It also fixes the next error, which was that C4::GetIssuingRules is deprecated.
Finally it now handles no overduefinescap being define (does nothing).
Passes QA test tool
Signed-off-by: Alex Buckley
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 22:08:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 21:08:21 +0000
Subject: [Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal
fine amount after delay
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336
Mika?l Olangcay Brisebois changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #85916|0 |1
is obsolete| |
--- Comment #18 from Mika?l Olangcay Brisebois ---
Created attachment 85919
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85919&action=edit
Bug 19336: (QA follow-up) Initialize $unitcounttotal in case a report is
written
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 22:08:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 21:08:53 +0000
Subject: [Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal
fine amount after delay
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336
Mika?l Olangcay Brisebois changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #85917|0 |1
is obsolete| |
--- Comment #19 from Mika?l Olangcay Brisebois ---
Created attachment 85920
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85920&action=edit
Bug 19336: Add --maxfinesday option to fines.pl
This is a functionality we have for some of our clients we want to push
to the community.
Adds the --maxfinesday argument to fines.pl which creates or updates a
fine with the maximum amount set in the circulation rules after the
delay has passed.
e.g.:
./fines.pl --maxfinesdays 30
All item over 30 days late will have the maximal fine applied.
Here is a test plan I followed based on above.
Test plan:
1. Create circulation rule with Overdue fines cap set
2. Set finesMode systempreference to 'Calculate and charge'
3. Check out an item with the due date set 30 days ago
4. In Koha shell run ./fines.pl --maxfinesdays 30
5. There should now be a new fine in the accountlines table of the
amount set in overdue fines cap
Followed test plan, patch worked as intended
Signed-off-by: Alex Buckley
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 22:08:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 21:08:57 +0000
Subject: [Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal
fine amount after delay
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336
Mika?l Olangcay Brisebois changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #85918|0 |1
is obsolete| |
--- Comment #20 from Mika?l Olangcay Brisebois ---
Created attachment 85921
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85921&action=edit
Bug 19336: (follow-up) Correct DateTime and Koha calls
This fixes the 'DateTime does not overload' error.
It also fixes the next error, which was that C4::GetIssuingRules is deprecated.
Finally it now handles no overduefinescap being define (does nothing).
Passes QA test tool
Signed-off-by: Alex Buckley
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 22:09:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 21:09:02 +0000
Subject: [Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal
fine amount after delay
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336
Mika?l Olangcay Brisebois changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #85919|0 |1
is obsolete| |
--- Comment #21 from Mika?l Olangcay Brisebois ---
Created attachment 85922
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85922&action=edit
Bug 19336: (QA follow-up) Initialize $unitcounttotal in case a report is
written
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 22:09:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 21:09:06 +0000
Subject: [Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal
fine amount after delay
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336
--- Comment #22 from Mika?l Olangcay Brisebois ---
Created attachment 85923
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85923&action=edit
Bug 19336: (follow-up) Initialize $unitcount instead of $unitcounttotal after
changes on master
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 22:30:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 21:30:06 +0000
Subject: [Koha-bugs] [Bug 16440] Update report parameters
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16440
--- Comment #5 from Christopher Brannon ---
Another option is to place fields in the "Show SQL code" section where each
parameter is, with the values that were used. Place a Re-run button under the
code, and if needed, you can change a value in this code, and rerun the report.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 22:30:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 21:30:36 +0000
Subject: [Koha-bugs] [Bug 16440] Update report parameters
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16440
Christopher Brannon changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |oleonard at myacpl.org
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 23:03:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 22:03:15 +0000
Subject: [Koha-bugs] [Bug 22303] Wrong bottom in
virtualshelves/addbybiblionumber.tt
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22303
Maryse Simard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 23:03:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Mar 2019 22:03:17 +0000
Subject: [Koha-bugs] [Bug 22303] Wrong bottom in
virtualshelves/addbybiblionumber.tt
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22303
Maryse Simard changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #85882|0 |1
is obsolete| |
--- Comment #6 from Maryse Simard ---
Created attachment 85924
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85924&action=edit
Bug 22303: Correct bottom in virtualshelves/addbybiblionumber.tt
In virtualshelves/addbybiblionumber.tt the include intranet-bottom.inc which
closes the HTML last tag is not the last line of the template.
This patch moved bottom include to last line and uses popup-bottom.inc.
Test plan :
1) Permission OK :
1.1) Login in staff interface with user 'Bob'
1.2) Create a new list 'Readme' : category public and allow changes to contents
from anyone
1.3) Perform a search
1.4) Check some results
1.5) Click 'Add to list' and on the list 'Readme'
1.6) A popup window opens
1.7) Check its HTML is OK, ending with