From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 00:13:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Feb 2019 23:13:33 +0000 Subject: [Koha-bugs] [Bug 3298] Independent item "Status Check" functionality needed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3298 Daniel Gaghan changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |daniel.gaghan at pueblolibrary | |.org --- Comment #2 from Daniel Gaghan --- As of 18.05 this is still not a feature and is requested by PCCLD staff. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 01:54:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 00:54:17 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Bob Birchall changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bob at calyx.net.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 02:10:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 01:10:11 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 arees at stlukes.nsw.edu.au changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arees at stlukes.nsw.edu.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 02:10:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 01:10:31 +0000 Subject: [Koha-bugs] [Bug 20364] Show languages from MARC21 field 041 in intranet In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20364 arees at stlukes.nsw.edu.au changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arees at stlukes.nsw.edu.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 03:09:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 02:09:41 +0000 Subject: [Koha-bugs] [Bug 22417] Delegate background jobs execution In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #15 from David Cook --- (In reply to Jonathan Druart from comment #13) > (In reply to Tom?s Cohen Arazi from comment #12) > > I agree with David that this of course would require a single RabbitMQ > > server so questions: Is there a concept of namespaces? can any Koha instance > > access other instance's messages? > > I really would like you guys to apply, read and try the patches, read the > code, then discuss :) > There are a lot of FIXME and TODO. > > This one answers your question: > > 16 sub connect { > 17 my ( $self ); > 18 my $conn = Net::RabbitFoot->new()->load_xml_spec()->connect( > 19 host => 'localhost', # TODO Move this to KOHA_CONF > 20 port => 5672, > 21 user => 'guest', > 22 pass => 'guest', > 23 vhost => '/', > 24 ); > 25 > 26 return $conn; > 27 } > > So different vhost, user and pass can be used. I haven't tried the patches but I have read your code, and that's why I've voiced my concerns about multi-tenancy. There wasn't enough information there to understand, so that's why I asked the questions. Your reply almost answers the question, but not quite, so now I'm just reading about RabbitMQ. If I understand correctly, each Koha instance would get its own RabbitMQ "vhost", and within each "vhost" there would be named queues (which at the moment are hard-coded but could be configurable I suppose). Cool. That removes my concerns about multi-tenancy. Thanks for that, Jonathan. (Maybe in your example you could use something like "vhost => '/kohademo'" or maybe include some code comments just so it's more obvious how it works.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 03:20:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 02:20:27 +0000 Subject: [Koha-bugs] [Bug 22417] Delegate background jobs execution In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #16 from David Cook --- (In reply to Tom?s Cohen Arazi from comment #12) > My only doubt is if we should really model the task queue with a message > queue. I tried the same Jonathan tried but using AnyEvent::Task and the > results where similar, and it only required a unix socket to communicate > client and server processes. My suggestion was to use zeromq. But lets see > how this goes. Specially in the integration step. Yeah, for #10662, I used POE::Component::JobQueue and a Unix socket. It was very effective, although my bespoke implementation had a number of limitations. I figured allowing TCP sockets also might be a good idea just to allow for more distributed architectures. When I was working on #10662, I was considering both RabbitMQ and ZeroMQ, but ended up doing my own job queue. I'm not necessarily sold on RabbitMQ yet, but I figure if Jonathan is willing to do it, I'm happy to see how this goes too. I'm not willing to put in the time to make it happen :/. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 04:28:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 03:28:47 +0000 Subject: [Koha-bugs] [Bug 22437] Subsequent authority merges in cron cause biblios to lose authority information In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22437 David Cook changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #2 from David Cook --- I don't have time to look at this, but I applaud you on your efforts! If you have any issues with https://wiki.koha-community.org/wiki/Git_bz_configuration, visit #koha on the OFTC IRC network, or email koha-devel at lists.koha-community.org. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 07:11:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 06:11:16 +0000 Subject: [Koha-bugs] [Bug 21538] Show ilbrary on account page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21538 Bug 21538 depends on bug 21401, which changed state. Bug 21401 Summary: Account offsets should save the transacting library https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21401 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 07:11:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 06:11:15 +0000 Subject: [Koha-bugs] [Bug 21401] Account offsets should save the transacting library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21401 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |WONTFIX --- Comment #28 from Josef Moravec --- (In reply to Martin Renvoize from comment #27) > Was there any further work you wanted to undertake here Josef.. or did it > all end up folded into bug 19066? For me, it is covered by bug 19066, so I am not going to continue on this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 07:12:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 06:12:28 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 07:56:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 06:56:54 +0000 Subject: [Koha-bugs] [Bug 14293] Error in the calculation of the suspension of users per day In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 --- Comment #26 from Katrin Fischer --- (In reply to Jonathan Druart from comment #25) > (In reply to Koha Team Lyon 3 from comment #24) > > In my opinion, if suspension_chargeperiod = 2, we should not charge on the > > first day... but, I'm not sure of the behaviour in the current version of > > Koha. > > Did not test neither remember. But my feeling is that: if you are late, you > pay. If you do not want this behavior you could use the grace. > > Before continuing on this maybe we should ask on the list? I think we could use the "when to charge" parameter for this as it's the same problem as with fines. It allows to charge at the beginning of the interval (charge first day) or at the end (charge after 2 days). This way the behavior would be configurable and we even have the option already. What do you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 08:28:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 07:28:34 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #48 from Josef Moravec --- Created attachment 85885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85885&action=edit Bug 18235: (QA follow-up) Fix POD -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 08:28:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 07:28:39 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #49 from Josef Moravec --- Created attachment 85886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85886&action=edit Bug 18235: (QA follow-up) Add missing filters -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 08:29:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 07:29:32 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #50 from Josef Moravec --- Comment on attachment 85214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85214 Bug 18235: DB changes Review of attachment 85214: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18235&attachment=85214) ----------------------------------------------------------------- ::: installer/data/mysql/atomicupdate/bug_18235-add-search_field-facet_order.sql @@ +1,1 @@ > +ALTER TABLE search_field ADD COLUMN facet_order TINYINT(4) DEFAULT '0' AFTER weight; Here is default 0 ::: installer/data/mysql/kohastructure.sql @@ +1493,4 @@ > `label` varchar(255) NOT NULL COMMENT 'the human readable name of the field, for display', > `type` ENUM('', 'string', 'date', 'number', 'boolean', 'sum', 'isbn', 'stdno') NOT NULL COMMENT 'what type of data this holds, relevant when storing it in the search engine', > `weight` decimal(5,2) DEFAULT NULL, > + `facet_order` TINYINT(4) DEFAULT NULL COMMENT 'the order place of the field in facet list if faceted', And here NULL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 08:35:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 07:35:48 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #51 from Josef Moravec --- Comment on attachment 85212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85212 Bug 18235: ES - Facets configurable Review of attachment 85212: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18235&attachment=85212) ----------------------------------------------------------------- ::: Koha/SearchEngine/Elasticsearch.pm @@ +971,5 @@ > + my @faceted_fields = Koha::SearchFields->search( > + { name => { -in => \@search_field_names }, facet_order => { '!=' => undef } }, { order_by => ['facet_order'] } > + ); > + my @not_faceted_fields = Koha::SearchFields->search( > + { name => { -in => \@search_field_names }, facet_order => undef }, { order_by => ['facet_order'] } Why do you retrieve fields from database in 2 queries, you always use them all. ::: admin/searchengine/elasticsearch/mappings.pl @@ +215,4 @@ > push @all_search_fields, $search_field_unblessed; > } > > +my @facetable_fields = Koha::SearchEngine::Elasticsearch->get_facetable_fields(); get_facetable_fields is called 3 or 4 times every run of mappings.pl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 08:38:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 07:38:35 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |josef.moravec at gmail.com, | |oleonard at myacpl.org --- Comment #52 from Josef Moravec --- Hi Jonathan, great job, I have just some small questions (see above) I also adding Owen if he can advice us how to do the UI better, it is not obvious that the facet order could be changed, also the facet table is at the end of page and easy to oversee... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 09:18:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 08:18:48 +0000 Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 --- Comment #49 from Josef Moravec --- Created attachment 85887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85887&action=edit Bug 14567: (QA follow-up) Fix html structure -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 09:18:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 08:18:52 +0000 Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 --- Comment #50 from Josef Moravec --- Created attachment 85888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85888&action=edit Bug 14567: (QA follow-up) Remove use of not needed modules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 09:21:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 08:21:26 +0000 Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Status|Signed Off |Failed QA --- Comment #51 from Josef Moravec --- I have only one concern here: You can't say from system preference place/descipriton it is only Opac related! I would to see this preference in OPAC category, or at least update descirption? Marking failed QA means I would like to have an answer here... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 09:33:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 08:33:59 +0000 Subject: [Koha-bugs] [Bug 21401] Account offsets should save the transacting library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21401 --- Comment #29 from Martin Renvoize --- Brill, thanks for the update Josef. ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 09:42:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 08:42:50 +0000 Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request datatable to be customisable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 --- Comment #36 from Josef Moravec --- Comment on attachment 84788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=84788 Bug 21063: (follow-up) Add user ID to column list Review of attachment 84788: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=21063&attachment=84788) ----------------------------------------------------------------- ::: Koha/REST/V1/Illrequests.pm @@ +125,4 @@ > foreach my $p(@{$patron_arr}) { > if ($p->{borrowernumber} == $req->borrowernumber) { > $to_push->{patron} = { > + borrowernumber => $p->{borrowernumber}, according to our api name conventions, this should be patron_id -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 09:44:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 08:44:03 +0000 Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request datatable to be customisable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #37 from Josef Moravec --- (In reply to Andrew Isherwood from comment #35) > (In reply to Josef Moravec from comment #33) > > Also, why to have three columns for patron identity? > We had different customers asking for different fields (for sorting and > filtering), so it was easiest just to include all three, then they can be > turned on or off as needed I don't like this, it makes inconsistancy in system, we should use standard pattern here: Firstname Surname (cardnumber) with link to moremember.pl. Ideally generated by patron-title.inc template. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 09:44:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 08:44:34 +0000 Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request datatable to be customisable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 --- Comment #38 from Josef Moravec --- Created attachment 85889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85889&action=edit Bug 21063: Add more tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 09:50:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 08:50:54 +0000 Subject: [Koha-bugs] [Bug 22306] Elasticsearch search not working - it returns no result found in catalog search In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22306 --- Comment #2 from Ere Maijala --- Have you tried resetting the index mappings (Koha administration => Search engine configuration)? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 09:51:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 08:51:38 +0000 Subject: [Koha-bugs] [Bug 20535] ModZebra called with $record with items stripped in ModBiblioMarc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20535 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 09:51:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 08:51:41 +0000 Subject: [Koha-bugs] [Bug 20535] ModZebra called with $record with items stripped in ModBiblioMarc In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20535 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82844|0 |1 is obsolete| | --- Comment #4 from Josef Moravec --- Created attachment 85890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85890&action=edit Bug 20535: ModZebra called with $record with items stripped ModZebra called with $record with items stripped in ModBiblioMarc. Remove $record argument to force record to be loaded again from database with items embedded. How to test: 1) Make sure biblios are indexed (with rebuild_elastic_search.pl). 2) Perform a search that will produce a sample result containing at least one biblio with items. 3) Edit and save a biblio with items. 4) Perform the same search again, the updated biblio should now have no items when viewed in the search results (No items). 5) Apply patch. 6) Repeat step 1-3. 7) The updated biblio should now have items when viewed in the search results. Signed-off-by: Josef Moravec -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 10:06:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 09:06:13 +0000 Subject: [Koha-bugs] [Bug 22439] New: Duplicated code in PrepHostMarcField and prepare_host_field Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22439 Bug ID: 22439 Summary: Duplicated code in PrepHostMarcField and prepare_host_field Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at koha-suomi.fi QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Target Milestone: --- The C4/Biblio.pm subroutines PrepHostMarcField and prepare_host_field both do the same thing, so should be merged. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 10:08:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 09:08:59 +0000 Subject: [Koha-bugs] [Bug 20492] Add missing case for advanced search year limit in _fix_limit_special_cases In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20492 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |josef.moravec at gmail.com --- Comment #5 from Josef Moravec --- Hi David, This does work, however only in OPAC, publication year in staff is not affected and still does not work in Elasticsearch Also, I think the test for this change is needed... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 10:20:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 09:20:19 +0000 Subject: [Koha-bugs] [Bug 18163] Elasticsearch advanced search by item type not working with item-level_itypes turned off (biblio record) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18163 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75564|0 |1 is obsolete| | Attachment #75565|0 |1 is obsolete| | --- Comment #7 from Josef Moravec --- Created attachment 85891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85891&action=edit Bug 18163: Unit tests prove -v t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 10:20:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 09:20:22 +0000 Subject: [Koha-bugs] [Bug 18163] Elasticsearch advanced search by item type not working with item-level_itypes turned off (biblio record) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18163 --- Comment #8 from Josef Moravec --- Created attachment 85892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85892&action=edit Bug 18163: Pass through limits in ES Before these patches we only allow a small subset of indexes to be used as limits - if we are going to let users add new fields eventually we probably don't want to strip out terms we didn't plan for. To test: 1 - Enable ES 2 - Using sample kohadevbox data try a search like this (or adjust as necessary): http://localhost:8080/cgi-bin/koha/opac-search.pl?idx=kw&idx=kw&idx=kw&limit=subject%2Cphr%3Astreet&sort_by=relevance&do=Search 3 - Note nothing is found 4 - Apply patches 5 - Repeat search 6 - It works! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 10:21:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 09:21:06 +0000 Subject: [Koha-bugs] [Bug 18163] Elasticsearch advanced search by item type not working with item-level_itypes turned off (biblio record) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18163 Josef Moravec changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA Assignee|gmcharlt at gmail.com |nick at bywatersolutions.com CC| |josef.moravec at gmail.com --- Comment #9 from Josef Moravec --- Hi Nick, nice enhancement, but the test does not cover the change - it passes with and without the second patch. I am attaching rebased patches, as there were some minor conflicts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 10:21:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 09:21:16 +0000 Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request datatable to be customisable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 --- Comment #39 from Andrew Isherwood --- Created attachment 85893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85893&action=edit Bug 21063: (follow-up) borrowernumber -> patron_id As per comment #36 here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063#c36 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 10:27:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 09:27:53 +0000 Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request datatable to be customisable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 --- Comment #40 from Andrew Isherwood --- (In reply to Josef Moravec from comment #36) > Comment on attachment 84788 [details] [review] > Bug 21063: (follow-up) Add user ID to column list > > Review of attachment 84788 [details] [review]: > ----------------------------------------------------------------- > > ::: Koha/REST/V1/Illrequests.pm > @@ +125,4 @@ > > foreach my $p(@{$patron_arr}) { > > if ($p->{borrowernumber} == $req->borrowernumber) { > > $to_push->{patron} = { > > + borrowernumber => $p->{borrowernumber}, > > according to our api name conventions, this should be patron_id Thanks for that Josef, this is now done. It has introduced a slight inconsistency in that we now have the following in the API response: Request object: { [...] borrowernumber: 123, patron: { patron_id: 123 } [...] } The borrowernumber in the request object comes directly from the column name in the request table. It feels potentially error prone to start introducing mapping from borrowernumber->patron_id on egress and patron_id->borrowernumber on ingress. What do you think? I don't know, in my mind, it's not an ideal situation to be in having a naming convention for API routes that differs from the naming convention everywhere else, but that's how it is, so I guess we just need to work with it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 10:39:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 09:39:07 +0000 Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request datatable to be customisable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 --- Comment #41 from Josef Moravec --- (In reply to Andrew Isherwood from comment #40) > (In reply to Josef Moravec from comment #36) > > Comment on attachment 84788 [details] [review] [review] > > Bug 21063: (follow-up) Add user ID to column list > > > > Review of attachment 84788 [details] [review] [review]: > > ----------------------------------------------------------------- > > > > ::: Koha/REST/V1/Illrequests.pm > > @@ +125,4 @@ > > > foreach my $p(@{$patron_arr}) { > > > if ($p->{borrowernumber} == $req->borrowernumber) { > > > $to_push->{patron} = { > > > + borrowernumber => $p->{borrowernumber}, > > > > according to our api name conventions, this should be patron_id > > Thanks for that Josef, this is now done. It has introduced a slight > inconsistency in that we now have the following in the API response: > > Request object: > { > [...] > borrowernumber: 123, > patron: { > patron_id: 123 > } > [...] > } > > The borrowernumber in the request object comes directly from the column name > in the request table. It feels potentially error prone to start introducing > mapping from borrowernumber->patron_id on egress and > patron_id->borrowernumber on ingress. What do you think? > > I don't know, in my mind, it's not an ideal situation to be in having a > naming convention for API routes that differs from the naming convention > everywhere else, but that's how it is, so I guess we just need to work with > it. We should take the rfc to development meeting, vote it and then update the endpoint as it was done with /holds endpoint -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:08:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 10:08:56 +0000 Subject: [Koha-bugs] [Bug 22283] Translation file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22283 --- Comment #10 from Alex Arnaud --- (In reply to Katrin Fischer from comment #9) > Would it not be easier to avoid the quotes overall? I think translators > won't be able to tell when they are translating Javascript strings and when > they are working on normal text, where this trick won't work. But glad you > found a fix! Will you change on pootle? Seems that Pootle treat escaping as an error. So i made a suggestion without quotes. NoQuote++ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:16:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 10:16:23 +0000 Subject: [Koha-bugs] [Bug 17229] ILS-DI HoldTitle and HoldItem should check if patron is expired In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 --- Comment #31 from Victor Grousset/tuxayo --- Hi :) To preserve the validity of the sign off (and other reasons which I don't remember ^^"), it's usual to do followup patches instead of amending the signed one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:22:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 10:22:08 +0000 Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request datatable to be customisable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 --- Comment #42 from Andrew Isherwood --- (In reply to Josef Moravec from comment #37) > (In reply to Andrew Isherwood from comment #35) > > (In reply to Josef Moravec from comment #33) > > > Also, why to have three columns for patron identity? > > > We had different customers asking for different fields (for sorting and > > filtering), so it was easiest just to include all three, then they can be > > turned on or off as needed > > I don't like this, it makes inconsistancy in system, we should use standard > pattern here: Firstname Surname (cardnumber) with link to moremember.pl. > Ideally generated by patron-title.inc template. I think this raises a bigger question of whether the current convention of Firstname Surname (cardnumber) addresses users' requirements. In our experience here, it doesn't. I think it's maybe worth having a separate discussion of whether we should be reconsidering the current situation and whether we should be making other DataTable instances in line with what we have here. I think it's certainly worth at least discussing. Which does beg the question of what we do to achieve PQA on this bug. We don't want it to be dependent on a potentially far reaching discussion. Do you think we should keep it as is, pending the discussion, or make it consistent with elsewhere, then address as appropriate following the discussion? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:23:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 10:23:23 +0000 Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request datatable to be customisable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 --- Comment #43 from Andrew Isherwood --- Adding Katrin and Owen to this so they're aware of the issue detailed in comment #42 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:33:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 10:33:09 +0000 Subject: [Koha-bugs] [Bug 22440] New: ILL API response objects inconsistent with other endpoints Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Bug ID: 22440 Summary: ILL API response objects inconsistent with other endpoints Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: ILL Assignee: koha-bugs at lists.koha-community.org Reporter: andrew.isherwood at ptfs-europe.com Target Milestone: --- The response object returned from the /api/vi/illrequest GET route isn't consistent with response objects supplied by other routes, such as the patrons route. We have an RFC for this route here: https://wiki.koha-community.org/wiki/Illrequests_endpoint_RFC Josef has made some initial recommendations on what the properties should be named to make them consistent with other routes. We could do with expanding this RFC to make it complete, including a spec on how object embedding should be done since, to date, this is the only route that does this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:33:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 10:33:50 +0000 Subject: [Koha-bugs] [Bug 22440] ILL API response objects inconsistent with other endpoints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P4 CC| |josef.moravec at gmail.com Depends on| |18589 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 [Bug 18589] Show ILLs as part of patron profile -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:33:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 10:33:50 +0000 Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22440 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 [Bug 22440] ILL API response objects inconsistent with other endpoints -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:34:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 10:34:01 +0000 Subject: [Koha-bugs] [Bug 22440] ILL API response objects inconsistent with other endpoints In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:38:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 10:38:39 +0000 Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request datatable to be customisable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 --- Comment #44 from Josef Moravec --- (In reply to Andrew Isherwood from comment #42) > (In reply to Josef Moravec from comment #37) > > (In reply to Andrew Isherwood from comment #35) > > > (In reply to Josef Moravec from comment #33) > > > > Also, why to have three columns for patron identity? > > > > > We had different customers asking for different fields (for sorting and > > > filtering), so it was easiest just to include all three, then they can be > > > turned on or off as needed > > > > I don't like this, it makes inconsistancy in system, we should use standard > > pattern here: Firstname Surname (cardnumber) with link to moremember.pl. > > Ideally generated by patron-title.inc template. > > I think this raises a bigger question of whether the current convention of > Firstname Surname (cardnumber) addresses users' requirements. In our > experience here, it doesn't. I think it's maybe worth having a separate > discussion of whether we should be reconsidering the current situation and > whether we should be making other DataTable instances in line with what we > have here. I think it's certainly worth at least discussing. > > Which does beg the question of what we do to achieve PQA on this bug. We > don't want it to be dependent on a potentially far reaching discussion. Do > you think we should keep it as is, pending the discussion, or make it > consistent with elsewhere, then address as appropriate following the > discussion? My opinion is, to make it consistent with current system. As you pointed out, such a discussion could take 'some' time... And is definitely out of scope of this report... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 11:59:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 10:59:00 +0000 Subject: [Koha-bugs] [Bug 22396] koha-sip script does not start the server correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22396 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #7 from Martin Renvoize --- Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:00:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 11:00:32 +0000 Subject: [Koha-bugs] [Bug 14850] Funds from inactive budgets appear in 'Funds' dropdown on acqui/invoice.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14850 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #20 from Martin Renvoize --- Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:03:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 11:03:14 +0000 Subject: [Koha-bugs] [Bug 18957] Item renewed online does not show the time of renewal In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18957 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize at ptfs-europe | |.com --- Comment #15 from Martin Renvoize --- Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:04:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 11:04:45 +0000 Subject: [Koha-bugs] [Bug 15149] Serials: Test prediction pattern does not consider Subscription start and end date In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15149 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize at ptfs-europe | |.com --- Comment #10 from Martin Renvoize --- Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:05:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 11:05:52 +0000 Subject: [Koha-bugs] [Bug 22411] Dates in log viewer not formatted correctly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22411 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize at ptfs-europe | |.com --- Comment #5 from Martin Renvoize --- Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:08:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 11:08:09 +0000 Subject: [Koha-bugs] [Bug 22378] Fix sound alerts on SCO In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22378 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #5 from Martin Renvoize --- Pushed to 18.11.x for 18.11.04. I'm sure we've broken this sort of thing a few times.. would have liked to have seen a selenium test for it... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:09:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 11:09:39 +0000 Subject: [Koha-bugs] [Bug 22441] New: SCO sound alerts need a selenium test Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22441 Bug ID: 22441 Summary: SCO sound alerts need a selenium test Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- I've vague recollection of fixes around this area often introducing regressions.. could we perhaps work out a selenium test for this? Relates to my comment in bug 22378 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:09:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 11:09:49 +0000 Subject: [Koha-bugs] [Bug 22441] SCO sound alerts need a selenium test In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22441 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22378 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22378 [Bug 22378] Fix sound alerts on SCO -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:09:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 11:09:49 +0000 Subject: [Koha-bugs] [Bug 22378] Fix sound alerts on SCO In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22378 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22441 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22441 [Bug 22441] SCO sound alerts need a selenium test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:10:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 11:10:25 +0000 Subject: [Koha-bugs] [Bug 22441] SCO sound alerts need a selenium test In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22441 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:12:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 11:12:50 +0000 Subject: [Koha-bugs] [Bug 18251] SCO alerts - need a trigger for successful checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |enhancement CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:13:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 11:13:51 +0000 Subject: [Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:14:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 11:14:59 +0000 Subject: [Koha-bugs] [Bug 18251] SCO alerts - need a trigger for successful checkouts In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #44 from Martin Renvoize --- Enhancement won't be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:15:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 11:15:00 +0000 Subject: [Koha-bugs] [Bug 22406] Add ability to play internal sounds in self checkout system In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22406 Bug 22406 depends on bug 18251, which changed state. Bug 18251 Summary: SCO alerts - need a trigger for successful checkouts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:15:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 11:15:46 +0000 Subject: [Koha-bugs] [Bug 22397] Wrong message in koha-sip --start In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22397 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize at ptfs-europe | |.com --- Comment #5 from Martin Renvoize --- Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:16:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 11:16:12 +0000 Subject: [Koha-bugs] [Bug 21206] C4::Items - Remove GetItem In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #38 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:16:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 11:16:12 +0000 Subject: [Koha-bugs] [Bug 18252] Move C4::Items code to the Koha namespace In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18252 Bug 18252 depends on bug 21206, which changed state. Bug 21206 Summary: C4::Items - Remove GetItem https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:16:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 11:16:12 +0000 Subject: [Koha-bugs] [Bug 21252] Koha::Patron->do_check_for_previous_checkout should take Koha::Item as parameter In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21252 Bug 21252 depends on bug 21206, which changed state. Bug 21206 Summary: C4::Items - Remove GetItem https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:16:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 11:16:50 +0000 Subject: [Koha-bugs] [Bug 22300] Staff search results: Opt groups in 'sort' pull down are not well formatted In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22300 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |martin.renvoize at ptfs-europe | |.com --- Comment #5 from Martin Renvoize --- Enhancement, will not be backported to 18.11.x series -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:17:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 11:17:19 +0000 Subject: [Koha-bugs] [Bug 21870] Convert browser alerts to modals: OPAC user summary In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21870 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |martin.renvoize at ptfs-europe | |.com --- Comment #6 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:17:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 11:17:20 +0000 Subject: [Koha-bugs] [Bug 18117] Convert browser alerts to modals In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18117 Bug 18117 depends on bug 21870, which changed state. Bug 21870 Summary: Convert browser alerts to modals: OPAC user summary https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21870 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:17:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 11:17:53 +0000 Subject: [Koha-bugs] [Bug 22026] Remove `use Modern::Perl` from Koha::REST::classes In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22026 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:19:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 11:19:05 +0000 Subject: [Koha-bugs] [Bug 22349] Overzealous deletion of data in t/db_dependant/Koha/Acquisitions/Booksellers.t In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22349 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:20:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 11:20:39 +0000 Subject: [Koha-bugs] [Bug 22337] Make it clearer that language preferences can be re-ordered In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22337 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #6 from Martin Renvoize --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:28:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 11:28:42 +0000 Subject: [Koha-bugs] [Bug 22014] Add ability to send "00" in SIP CV field on checkin success In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22014 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |martin.renvoize at ptfs-europe | |.com --- Comment #8 from Martin Renvoize --- Enhancement, will not be backported to 18.11.x series -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:28:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 11:28:42 +0000 Subject: [Koha-bugs] [Bug 22016] Always send CT field for SIP checkin, even if empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22016 Bug 22016 depends on bug 22014, which changed state. Bug 22014 Summary: Add ability to send "00" in SIP CV field on checkin success https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22014 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:29:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 11:29:24 +0000 Subject: [Koha-bugs] [Bug 22016] Always send CT field for SIP checkin, even if empty In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22016 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #6 from Martin Renvoize --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:29:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 11:29:25 +0000 Subject: [Koha-bugs] [Bug 22043] SIP Checkin Response alert flag set to often set to Y incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22043 Bug 22043 depends on bug 22016, which changed state. Bug 22016 Summary: Always send CT field for SIP checkin, even if empty https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22016 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:30:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 11:30:18 +0000 Subject: [Koha-bugs] [Bug 12318] Show subscription shelving location on subscription tabs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12318 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #9 from Martin Renvoize --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:29:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 11:29:53 +0000 Subject: [Koha-bugs] [Bug 21875] Handling subject line in Letters.pm In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21875 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #16 from Martin Renvoize --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:33:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 11:33:55 +0000 Subject: [Koha-bugs] [Bug 21765] AutoUnsuspendReserves manually sets holds fields instead of calling ->resume In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21765 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:35:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 11:35:34 +0000 Subject: [Koha-bugs] [Bug 21765] AutoUnsuspendReserves manually sets holds fields instead of calling ->resume In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21765 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #9 from Martin Renvoize --- Pushed to 18.11.x for 18.11.04 - I considered the lack of an action log in this case a bug the overriding factor here and so switch back from 'enhancement' to 'bug'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:38:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 11:38:30 +0000 Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Victor Grousset/tuxayo changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor.grousset at biblibre.co | |m --- Comment #56 from Victor Grousset/tuxayo --- Hi, are you sure that bug 22330 encompasses this one? Because it(22330) seems to concert only holds. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:40:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 11:40:06 +0000 Subject: [Koha-bugs] [Bug 22084] Plugin upgrade method and database plugin version storage will never be triggered for existing installs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22084 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:41:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 11:41:39 +0000 Subject: [Koha-bugs] [Bug 22084] Plugin upgrade method and database plugin version storage will never be triggered for existing installs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22084 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #9 from Martin Renvoize --- Pushed to 18.11.x for 18.11.04 rmaint note: the parent bug for this was backported all the way to 17.11.x series so we need it all the way down. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:42:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 11:42:20 +0000 Subject: [Koha-bugs] [Bug 22084] Plugin upgrade method and database plugin version storage will never be triggered for existing installs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22084 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_17_11_candidate, | |rel_18_05_candidate, | |rel_18_11_candidate Status|Pushed to Stable |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:42:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 11:42:29 +0000 Subject: [Koha-bugs] [Bug 22084] Plugin upgrade method and database plugin version storage will never be triggered for existing installs In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22084 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:42:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 11:42:58 +0000 Subject: [Koha-bugs] [Bug 21722] Update C4::Accounts::chargelostitem to use Koha::Account->add_debit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 Bug 21722 depends on bug 21747, which changed state. Bug 21747 Summary: Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:42:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 11:42:58 +0000 Subject: [Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #24 from Martin Renvoize --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:47:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 11:47:06 +0000 Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request datatable to be customisable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 --- Comment #45 from Andrew Isherwood --- Created attachment 85894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85894&action=edit Bug 21063: (follow-up) Fix more rebase problems More minor rebase problems fixed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:48:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 11:48:11 +0000 Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request datatable to be customisable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 --- Comment #46 from Andrew Isherwood --- Created attachment 85895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85895&action=edit Bug 21063: (follow-up) Make patron col consistent As per comment #44 here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063#c44 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:49:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 11:49:54 +0000 Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request datatable to be customisable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 Andrew Isherwood changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85895|0 |1 is obsolete| | --- Comment #47 from Andrew Isherwood --- Created attachment 85896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85896&action=edit Bug 21063: (follow-up) Make patron col consistent As per comment #44 here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063#c44 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 12:53:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 11:53:59 +0000 Subject: [Koha-bugs] [Bug 22043] SIP Checkin Response alert flag set to often set to Y incorrectly In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22043 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85884|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall --- Created attachment 85897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85897&action=edit Bug 22043: (QA Follow-up) Add paramter to control behavior -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 14:27:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 13:27:39 +0000 Subject: [Koha-bugs] [Bug 22442] New: Item search CSV export broken Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22442 Bug ID: 22442 Summary: Item search CSV export broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Several columns in the item search CSV export are empty: Title, Publication date, Publisher, Collection. I think this was caused by the template variable filter switch. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 15:17:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 14:17:28 +0000 Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 15:17:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 14:17:38 +0000 Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85777|0 |1 is obsolete| | --- Comment #69 from Ere Maijala --- Created attachment 85899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85899&action=edit Bug 20664: Add unit tests for GetMarcItem To test: prove -v t/db_dependent/Items.t Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 15:17:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 14:17:42 +0000 Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85778|0 |1 is obsolete| | --- Comment #70 from Ere Maijala --- Created attachment 85900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85900&action=edit Bug 20664: Unit tests for GetMarcItemFields To test: prove -v t/db_dependent/Items.t Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 15:17:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 14:17:33 +0000 Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85776|0 |1 is obsolete| | --- Comment #68 from Ere Maijala --- Created attachment 85898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85898&action=edit Bug 20664: Optimize retrieval of biblio and item data Optimizes embedding of item data in MARC and fixes several bottlenecks encountered while profiling OAI-PMH and exporting of records. There are two ways this is accomplished: 1.) Create optimized method for fetching item fields for MARC embedding. 2.) Use the cache service more and where repeated calls are made. Test plan: 1.) Before applying the patch, time an export_records.pl run for a set of biblios that also have items. Run it a couple of times to account for initial slowness and possible fluctuations. For example: time misc/export_records.pl --record-type bibs --starting_biblionumber 960000 --ending_biblionumber 965000 --format xml --filename unoptimized.xml 2.) Apply the patch. 3.) Time the export process again with a different output file: time misc/export_records.pl --record-type bibs --starting_biblionumber 960000 --ending_biblionumber 965000 --format xml --filename optimized.xml 4.) Verify that the optimized process is faster. 5.) Compare the resulting export files to make sure they're identical: Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 15:17:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 14:17:47 +0000 Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85779|0 |1 is obsolete| | --- Comment #71 from Ere Maijala --- Created attachment 85901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85901&action=edit Bug 20664: (follow-up) Fix test for GetMarcItemFields Without this patch I got this error running the test: YAML Error: Stream does not end with newline character Test plan: prove t/db_dependent/Items.t Signed-off-by: Josef Moravec Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 15:17:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 14:17:51 +0000 Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85780|0 |1 is obsolete| | --- Comment #72 from Ere Maijala --- Created attachment 85902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85902&action=edit Bug 20664: (follow-up) Fix QA whitespace errors Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 15:17:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 14:17:56 +0000 Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85781|0 |1 is obsolete| | --- Comment #73 from Ere Maijala --- Created attachment 85903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85903&action=edit Bug 20664: (follow-up) Fix tests on rebase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 15:18:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 14:18:00 +0000 Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664 --- Comment #74 from Ere Maijala --- Created attachment 85904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85904&action=edit Bug 20664: (follow-up) Switch to Koha objects for retrieving items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 15:18:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 14:18:04 +0000 Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664 --- Comment #75 from Ere Maijala --- Created attachment 85905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85905&action=edit Bug 20664: (follow-up) Add tests for UseHidingRulesWithBorrowerCategory -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 15:37:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 14:37:15 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85416|0 |1 is obsolete| | --- Comment #89 from Ere Maijala --- Created attachment 85906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85906&action=edit Bug 20447: MARC Holdings support Enable by setting "SummaryHoldings" option to "Use". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 15:37:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 14:37:19 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85417|0 |1 is obsolete| | --- Comment #90 from Ere Maijala --- Created attachment 85907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85907&action=edit Bug 20447: Add a batch rebuild script for holdings table. This script can be used to update the columns in the holdings table from the MARC record using the rules in the framework. In practice this will only be required if the koha link field is changed in the framework. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 15:37:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 14:37:24 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85418|0 |1 is obsolete| | --- Comment #91 from Ere Maijala --- Created attachment 85908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85908&action=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 15:37:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 14:37:29 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85419|0 |1 is obsolete| | --- Comment #92 from Ere Maijala --- Created attachment 85909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85909&action=edit Bug 20447: DBIX schema changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 15:53:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 14:53:48 +0000 Subject: [Koha-bugs] [Bug 3298] Independent item "Status Check" functionality needed In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3298 Sally Healey changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 16:04:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 15:04:50 +0000 Subject: [Koha-bugs] [Bug 19318] Add ability to use custom file upload paths In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19318 Kyle M Hall changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Needs Signoff |RESOLVED --- Comment #6 from Kyle M Hall --- Pretty sure this is a duplicate of bug 20208 which is a bit fresher than mine. Closing as a duplicate on that assumption. *** This bug has been marked as a duplicate of bug 20208 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 16:04:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 15:04:50 +0000 Subject: [Koha-bugs] [Bug 20208] Development - Peddie School - Custom file upload paths In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20208 --- Comment #6 from Kyle M Hall --- *** Bug 19318 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 16:31:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 15:31:34 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #53 from Owen Leonard --- (In reply to Josef Moravec from comment #52) > the facet table is at > the end of page and easy to oversee... I wonder if it should be in a separate tab? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 17:27:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 16:27:44 +0000 Subject: [Koha-bugs] [Bug 8775] Add collection code to lost report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8775 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 17:27:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 16:27:47 +0000 Subject: [Koha-bugs] [Bug 8775] Add collection code to lost report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8775 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85526|0 |1 is obsolete| | --- Comment #4 from Owen Leonard --- Created attachment 85910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85910&action=edit Bug 8775: Add collection code to lost report This patch adds a column for collection code to the lost items report. To test, apply the patch and run the lost items report. You should see a collection code column. Test column configuration for this table: Go to Administration -> Configure columns. Confirm that the "collection_code" column can be configured and that configuration choices are applied correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 17:36:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 16:36:30 +0000 Subject: [Koha-bugs] [Bug 14451] OPAC Bootstrap theme hides table headings in holdings display In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14451 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Bootstrap framework drops |OPAC Bootstrap theme hides |table headings in holdings |table headings in holdings |display |display -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 17:47:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 16:47:21 +0000 Subject: [Koha-bugs] [Bug 7713] display local license files in about.pl, rather than via external urls In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7713 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |WONTFIX --- Comment #2 from Owen Leonard --- No discussion after seven years... I think this can be closed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 17:50:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 16:50:07 +0000 Subject: [Koha-bugs] [Bug 7088] Cannot renew items on hold even with override In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #39 from Liz Rea --- I personally don't like the 2nd date picker and think it's confusing, at least how it is labelled. There is something that I find ambiguous about "On hold due date" but I'm having a hard time putting what it is into words. Maybe a hover text on the label that explains more what the box is for? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 17:58:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 16:58:17 +0000 Subject: [Koha-bugs] [Bug 22443] New: t/db_dependent/Koha/Patron/Categories.t contains a DateTime maths error Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22443 Bug ID: 22443 Summary: t/db_dependent/Koha/Patron/Categories.t contains a DateTime maths error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- So, one of the peculiarities of DateTime maths is that 12 plus 1 doesn't always equal 13 ;) This calls for an example (using 'limit' for end_of_month mode): 2019-01-31 + 1 month = 2019-02-28 2019-01-31 + 13 months = 2020-02-29 (this one maintains 'end of month' over the leap year) 2019-02-28 + 12 months = 2020-02-28 Koha does the third case but the test is currently setup for the second. 'dateexpiry' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 18:04:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 17:04:35 +0000 Subject: [Koha-bugs] [Bug 11340] Make the 'print summary' a custom slip/notice In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11340 Felicia Beaudry changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |felicia.beaudry at equinoxinit | |iative.org --- Comment #4 from Felicia Beaudry --- +1 This would be really useful. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 18:09:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 17:09:53 +0000 Subject: [Koha-bugs] [Bug 20830] Make sure a fund is selected when ordering from staged file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20830 --- Comment #4 from Koha Team Lyon 3 --- Created attachment 85911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85911&action=edit bug 20830: Make sure a fund is selected when ordering from staged file I simply took again bug 20798 code with a little modification to set the checking only on selected items of "Select to import" tab. Seems to do the trick (patch done on version 17.11.13). Test Plan: 1) Add records to a basket from an import batch 2) Select only some of those items in the batch and don't select any fund for them. 3) Save : you get the message "Some budgets are no defined .." 4) Apply this patch 5) Select some items and choose a fund for each of them 6) Save : no more message. Olivier Crouzet -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 18:10:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 17:10:12 +0000 Subject: [Koha-bugs] [Bug 20830] Make sure a fund is selected when ordering from staged file In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20830 Koha Team Lyon 3 changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 19:51:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 18:51:23 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |wizzyrea at gmail.com --- Comment #6 from Liz Rea --- Hi Devinim, Thanks for looking at this feature, it will be really cool. This works well populating item values from a staged record. I don't particularly like the UX of adding the two items (the "add item" button is hard to spot in the long list of fields), but that isn't related to this patch. There are some QA fails here: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt FAIL filters missing_filter at line 328 ( ) missing_filter at line 309 ( ) missing_filter at line 777 ( [% jsinclude # Parse the page template's JavaScript block if necessary %]) missing_filter at line 329 ( ) missing_filter at line 330 ( ) missing_filter at line 311 ( ) missing_filter at line 307 (
) missing_filter at line 319 ( ) missing_filter at line 326 ( ) missing_filter at line 324 ( [% iteminfo.marc_value %]) missing_filter at line 327 ( ) missing_filter at line 337 ( ) missing_filter at line 299 (
) missing_filter at line 317 ( ) missing_filter at line 342 ( ) missing_filter at line 303 (
  • ) * Commit title does not start with 'Bug XXXXX: ' - 034220c0cc Fix those up and I'll sign off on this for you. :) Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 19:56:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 18:56:23 +0000 Subject: [Koha-bugs] [Bug 20208] Custom file upload paths In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20208 Liz Rea changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com Summary|Development - Peddie School |Custom file upload paths |- Custom file upload paths | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 20:07:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 19:07:01 +0000 Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Jos?-Mario Monteiro-Santos changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jose-mario.monteiro-santos@ | |inlibro.com --- Comment #106 from Jos?-Mario Monteiro-Santos --- (In reply to Martin Renvoize from comment #105) > I'll try and take a look at tests tomorrow, sorry guys. Any specific plan in mind ? It's a pretty daunting task to correctly test the entirety of the Z3950Search sub. I can take a stab at it, but I'd love some pointers to help me get started. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 20:51:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 19:51:05 +0000 Subject: [Koha-bugs] [Bug 5594] Option to configure default sort order for items on bib records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5594 --- Comment #6 from Marjorie Barry-Vila --- +1 -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 20:57:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 19:57:40 +0000 Subject: [Koha-bugs] [Bug 8775] Add collection code to lost report In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8775 Bin changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85910|0 |1 is obsolete| | --- Comment #5 from Bin --- Created attachment 85912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85912&action=edit Bug 8775: Add collection code to lost report This patch adds a column for collection code to the lost items report. To test, apply the patch and run the lost items report. You should see a collection code column. Test column configuration for this table: Go to Administration -> Configure columns. Confirm that the "collection_code" column can be configured and that configuration choices are applied correctly. Signed-off-by: Bin Wen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 21:06:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 20:06:43 +0000 Subject: [Koha-bugs] [Bug 13420] Holdings table sorting on volume information incorrect In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13420 --- Comment #12 from Marjorie Barry-Vila --- +1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 21:44:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 20:44:02 +0000 Subject: [Koha-bugs] [Bug 21308] Results from order search do not show the search parameters. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21308 Bin changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85525|0 |1 is obsolete| | --- Comment #4 from Bin --- Created attachment 85913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85913&action=edit Bug 21308: Results from order search do not show the search parameters This patch modifies the orders search results page so that the search form appears in the sidebar. This allows the user to view and re-use their search parameters. This patch also moves the "no search results" message to the top of the page in a message box. To test, apply the patch and go to Acquisitions -> Orders search. - Perform a search which will return results. In the sidebar you should see the full orders search form with your search parameters in the form fields. - Perform a search which will return no results. You should see the "Your search returned no results." message in a standard message dialog. Signed-off-by: Bin Wen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 21:51:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 20:51:53 +0000 Subject: [Koha-bugs] [Bug 20882] URI column in the items table is limited to 255 characters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20882 Marjorie Barry-Vila changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 22:00:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 21:00:58 +0000 Subject: [Koha-bugs] [Bug 22444] New: currencies_manage permission doesn't provide link to manage currencies when selected alone Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22444 Bug ID: 22444 Summary: currencies_manage permission doesn't provide link to manage currencies when selected alone Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Bug 7651 added the permission currencies_manage within the acquisitions permission subgroup. Giving a borrower just this permission and catalogue does make them technically able to load /currency.pl, but it doesn't provide them any link to get there. To Test: - create a patron - give them currencies_manage and catalogue permissions - log in as this patron - observe that there is no Currencies link out of Acquisitions and Administration doesn't appear on the home page or the More menu - give the patron any other admin permission - observe that the Currencies link now shows in Acquisitions - take away admin permissions and give the patron full acquisitions permissions - observe that a link to Currencies still appears in Acquisitions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 22:04:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 21:04:38 +0000 Subject: [Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336 Mika?l Olangcay Brisebois changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75379|0 |1 is obsolete| | --- Comment #13 from Mika?l Olangcay Brisebois --- Created attachment 85914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85914&action=edit Bug 19336: Add --maxfinesday option to fines.pl This is a functionality we have for some of our clients we want to push to the community. Adds the --maxfinesday argument to fines.pl which creates or updates a fine with the maximum amount set in the circulation rules after the delay has passed. e.g.: ./fines.pl --maxfinesdays 30 All item over 30 days late will have the maximal fine applied. Here is a test plan I followed based on above. Test plan: 1. Create circulation rule with Overdue fines cap set 2. Set finesMode systempreference to 'Calculate and charge' 3. Check out an item with the due date set 30 days ago 4. In Koha shell run ./fines.pl --maxfinesdays 30 5. There should now be a new fine in the accountlines table of the amount set in overdue fines cap Followed test plan, patch worked as intended Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 22:04:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 21:04:44 +0000 Subject: [Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336 Mika?l Olangcay Brisebois changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75380|0 |1 is obsolete| | --- Comment #14 from Mika?l Olangcay Brisebois --- Created attachment 85915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85915&action=edit Bug 19336: (follow-up) Correct DateTime and Koha calls This fixes the 'DateTime does not overload' error. It also fixes the next error, which was that C4::GetIssuingRules is deprecated. Finally it now handles no overduefinescap being define (does nothing). Passes QA test tool Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 22:04:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 21:04:52 +0000 Subject: [Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336 Mika?l Olangcay Brisebois changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75381|0 |1 is obsolete| | --- Comment #15 from Mika?l Olangcay Brisebois --- Created attachment 85916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85916&action=edit Bug 19336: (QA follow-up) Initialize $unitcounttotal in case a report is written -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 22:08:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 21:08:12 +0000 Subject: [Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336 Mika?l Olangcay Brisebois changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85914|0 |1 is obsolete| | --- Comment #16 from Mika?l Olangcay Brisebois --- Created attachment 85917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85917&action=edit Bug 19336: Add --maxfinesday option to fines.pl This is a functionality we have for some of our clients we want to push to the community. Adds the --maxfinesday argument to fines.pl which creates or updates a fine with the maximum amount set in the circulation rules after the delay has passed. e.g.: ./fines.pl --maxfinesdays 30 All item over 30 days late will have the maximal fine applied. Here is a test plan I followed based on above. Test plan: 1. Create circulation rule with Overdue fines cap set 2. Set finesMode systempreference to 'Calculate and charge' 3. Check out an item with the due date set 30 days ago 4. In Koha shell run ./fines.pl --maxfinesdays 30 5. There should now be a new fine in the accountlines table of the amount set in overdue fines cap Followed test plan, patch worked as intended Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 22:08:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 21:08:16 +0000 Subject: [Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336 Mika?l Olangcay Brisebois changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85915|0 |1 is obsolete| | --- Comment #17 from Mika?l Olangcay Brisebois --- Created attachment 85918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85918&action=edit Bug 19336: (follow-up) Correct DateTime and Koha calls This fixes the 'DateTime does not overload' error. It also fixes the next error, which was that C4::GetIssuingRules is deprecated. Finally it now handles no overduefinescap being define (does nothing). Passes QA test tool Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 22:08:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 21:08:21 +0000 Subject: [Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336 Mika?l Olangcay Brisebois changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85916|0 |1 is obsolete| | --- Comment #18 from Mika?l Olangcay Brisebois --- Created attachment 85919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85919&action=edit Bug 19336: (QA follow-up) Initialize $unitcounttotal in case a report is written -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 22:08:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 21:08:53 +0000 Subject: [Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336 Mika?l Olangcay Brisebois changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85917|0 |1 is obsolete| | --- Comment #19 from Mika?l Olangcay Brisebois --- Created attachment 85920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85920&action=edit Bug 19336: Add --maxfinesday option to fines.pl This is a functionality we have for some of our clients we want to push to the community. Adds the --maxfinesday argument to fines.pl which creates or updates a fine with the maximum amount set in the circulation rules after the delay has passed. e.g.: ./fines.pl --maxfinesdays 30 All item over 30 days late will have the maximal fine applied. Here is a test plan I followed based on above. Test plan: 1. Create circulation rule with Overdue fines cap set 2. Set finesMode systempreference to 'Calculate and charge' 3. Check out an item with the due date set 30 days ago 4. In Koha shell run ./fines.pl --maxfinesdays 30 5. There should now be a new fine in the accountlines table of the amount set in overdue fines cap Followed test plan, patch worked as intended Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 22:08:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 21:08:57 +0000 Subject: [Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336 Mika?l Olangcay Brisebois changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85918|0 |1 is obsolete| | --- Comment #20 from Mika?l Olangcay Brisebois --- Created attachment 85921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85921&action=edit Bug 19336: (follow-up) Correct DateTime and Koha calls This fixes the 'DateTime does not overload' error. It also fixes the next error, which was that C4::GetIssuingRules is deprecated. Finally it now handles no overduefinescap being define (does nothing). Passes QA test tool Signed-off-by: Alex Buckley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 22:09:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 21:09:02 +0000 Subject: [Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336 Mika?l Olangcay Brisebois changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85919|0 |1 is obsolete| | --- Comment #21 from Mika?l Olangcay Brisebois --- Created attachment 85922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85922&action=edit Bug 19336: (QA follow-up) Initialize $unitcounttotal in case a report is written -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 22:09:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 21:09:06 +0000 Subject: [Koha-bugs] [Bug 19336] Add option to fines.pl to apply maximal fine amount after delay In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19336 --- Comment #22 from Mika?l Olangcay Brisebois --- Created attachment 85923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85923&action=edit Bug 19336: (follow-up) Initialize $unitcount instead of $unitcounttotal after changes on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 22:30:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 21:30:06 +0000 Subject: [Koha-bugs] [Bug 16440] Update report parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16440 --- Comment #5 from Christopher Brannon --- Another option is to place fields in the "Show SQL code" section where each parameter is, with the values that were used. Place a Re-run button under the code, and if needed, you can change a value in this code, and rerun the report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 22:30:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 21:30:36 +0000 Subject: [Koha-bugs] [Bug 16440] Update report parameters In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16440 Christopher Brannon changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 23:03:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 22:03:15 +0000 Subject: [Koha-bugs] [Bug 22303] Wrong bottom in virtualshelves/addbybiblionumber.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22303 Maryse Simard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 23:03:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 22:03:17 +0000 Subject: [Koha-bugs] [Bug 22303] Wrong bottom in virtualshelves/addbybiblionumber.tt In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22303 Maryse Simard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85882|0 |1 is obsolete| | --- Comment #6 from Maryse Simard --- Created attachment 85924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85924&action=edit Bug 22303: Correct bottom in virtualshelves/addbybiblionumber.tt In virtualshelves/addbybiblionumber.tt the include intranet-bottom.inc which closes the HTML last tag is not the last line of the template. This patch moved bottom include to last line and uses popup-bottom.inc. Test plan : 1) Permission OK : 1.1) Login in staff interface with user 'Bob' 1.2) Create a new list 'Readme' : category public and allow changes to contents from anyone 1.3) Perform a search 1.4) Check some results 1.5) Click 'Add to list' and on the list 'Readme' 1.6) A popup window opens 1.7) Check its HTML is OK, ending with 2) Permission KO : 2.1) Open a new window (Firefox private session) and login in staff interface with user 'Bill' 2.2) Perform a search 2.3) Check some results 2.4) On session of 'Bob', edit list 'Readme' 2.5) Change : category private and allow changes to contents from owner only 2.6) On session of 'Bill' 2.7) Click 'Add to list' and on the list 'Readme' 2.8) A popup window opens saying 'Sorry, you do not have permission to add items to this list' 2.9) Check its HTML is OK, ending with Signed-off-by: Maryse Simard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 23:54:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 22:54:30 +0000 Subject: [Koha-bugs] [Bug 22445] New: Ability to define a url for custom cover images Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Bug ID: 22445 Summary: Ability to define a url for custom cover images Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Target Milestone: --- So far we have cover images from a list of webservices, COCE, locally, but we cannot define a custom url. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 1 23:54:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 22:54:38 +0000 Subject: [Koha-bugs] [Bug 22445] Ability to define a url for custom cover images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 00:01:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 23:01:43 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #54 from Jonathan Druart --- I would support an integration ASAP then we could discuss the ergonomic (patches submitted 2 years ago). Unless somebody else is willing to make the changes ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 00:11:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 23:11:57 +0000 Subject: [Koha-bugs] [Bug 22445] Ability to define a url for custom cover images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #1 from Jonathan Druart --- Created attachment 85925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85925&action=edit Bug 22445: Add new prefs *CustomCoverImages* This patch set adds a new method to display cover images for bibliographic records. The idea is to provide a flexible way allowing several use cases: - local path - remote url - webservice which would follow a given pattern. So far only the following patterns are available: - %isbn% will be replaced byt the isbn of the record - %issn% - using MARC subfields: %024$a% to replace with the value in 024$a For example - /your/local/images/%isbn%.png - https://covers.openlibrary.org/b/isbn/%isbn%-M.jpb - etc. There are 3 new sysprefs: CustomCoverImagesURL => Define the path/url CustomCoverImages => Turn on/off the display of the custom cover image in the staff client OPACCustomCoverImages => Turn on/off the display of the custom cover image at the OPAC Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 00:12:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 23:12:03 +0000 Subject: [Koha-bugs] [Bug 22445] Ability to define a url for custom cover images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #2 from Jonathan Druart --- Created attachment 85926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85926&action=edit Bug 22445: Add new method Koha::Biblio->custom_cover_image_url Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 00:12:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 23:12:07 +0000 Subject: [Koha-bugs] [Bug 22445] Ability to define a url for custom cover images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #3 from Jonathan Druart --- Created attachment 85927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85927&action=edit Bug 22445: Add tests for Koha::Biblio->custom_cover_image_url Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 00:12:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 23:12:11 +0000 Subject: [Koha-bugs] [Bug 22445] Ability to define a url for custom cover images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #4 from Jonathan Druart --- Created attachment 85928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85928&action=edit Bug 22445: Allow marc fields as pattern %tag$field% There is a limitation here, only one replacement will work. Let see if it is needed later to support several patterns Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 00:11:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 23:11:51 +0000 Subject: [Koha-bugs] [Bug 22445] Ability to define a url for custom cover images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 00:12:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 23:12:14 +0000 Subject: [Koha-bugs] [Bug 22445] Ability to define a url for custom cover images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #5 from Jonathan Druart --- Created attachment 85929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85929&action=edit Bug 22445: Custom cover images - opac shelfbrowser Test plan: Go to the detail page of a bibliographic record (at the OPAC) and confirm the at custom cover images are displayed in the shelf browser Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 00:12:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 23:12:19 +0000 Subject: [Koha-bugs] [Bug 22445] Ability to define a url for custom cover images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #6 from Jonathan Druart --- Created attachment 85930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85930&action=edit Bug 22445: Custom cover images - opac results Test plan: Search for bibliographic records at the OPAC, the custom cover should be displayed Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 00:12:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 23:12:23 +0000 Subject: [Koha-bugs] [Bug 22445] Ability to define a url for custom cover images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #7 from Jonathan Druart --- Created attachment 85931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85931&action=edit Bug 22445: Custom cover images - opac detail Test plan: Go to the bibliographic record detail page at the OPAC, you should see the custom cover image. Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 00:12:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 23:12:27 +0000 Subject: [Koha-bugs] [Bug 22445] Ability to define a url for custom cover images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #8 from Jonathan Druart --- Created attachment 85932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85932&action=edit Bug 22445: Custom cover images - opac result (rss) This cannot be tested, it seems that the template is broken. Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 00:12:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 23:12:31 +0000 Subject: [Koha-bugs] [Bug 22445] Ability to define a url for custom cover images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #9 from Jonathan Druart --- Created attachment 85933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85933&action=edit Bug 22445: Custom cover images - opac shelves Test plan: Add a bibliographic record (that has a custom image) to a shelf, view the shelf (OPAC). You should see the image. Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 00:12:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 23:12:35 +0000 Subject: [Koha-bugs] [Bug 22445] Ability to define a url for custom cover images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #10 from Jonathan Druart --- Created attachment 85934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85934&action=edit Bug 22445: Custom cover images - opac reviews Test plan: - enable OpacShowRecentComments - make a comment (OPAC) - approve it (staff) - click 'Recent comments' (OPAC) => You should see the custom cover Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 00:12:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 23:12:41 +0000 Subject: [Koha-bugs] [Bug 22445] Ability to define a url for custom cover images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #11 from Jonathan Druart --- Created attachment 85935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85935&action=edit Bug 22445: Custom cover images - opac reviews (rss) Test plan: Same as previous patch, then click on the feeds link Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 00:12:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 23:12:44 +0000 Subject: [Koha-bugs] [Bug 22445] Ability to define a url for custom cover images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #12 from Jonathan Druart --- Created attachment 85936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85936&action=edit Bug 22445: Custom cover images - opac user (checkout list) Test plan: - Check an item out to a patron - At the OPAC loggin as this patron On the checkout list you should see the cover image. Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 00:12:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 23:12:48 +0000 Subject: [Koha-bugs] [Bug 22445] Ability to define a url for custom cover images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #13 from Jonathan Druart --- Created attachment 85937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85937&action=edit Bug 22445: Custom cover images - detail (staff) Test plan: Staff side now, go the detail page of a bibliographic record You should see the cover image. Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 00:12:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 23:12:53 +0000 Subject: [Koha-bugs] [Bug 22445] Ability to define a url for custom cover images In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #14 from Jonathan Druart --- Created attachment 85938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85938&action=edit Bug 22445: Custom cover images - search resulta (staff) Test plan: Search for bibliographic records, the custom covers should be displayed. Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 00:17:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Mar 2019 23:17:21 +0000 Subject: [Koha-bugs] [Bug 18064] Long overdue cronjob does not follow the library's calendar and skip closed days In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18064 Joy Nelson changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Assignee|gmcharlt at gmail.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 01:35:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 00:35:52 +0000 Subject: [Koha-bugs] [Bug 22446] New: Koha/Patron/Categories.t is failing on March 1st (2019 only?) Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22446 Bug ID: 22446 Summary: Koha/Patron/Categories.t is failing on March 1st (2019 only?) Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: martin.renvoize at ptfs-europe.com Target Milestone: --- koha_1 | # Failed test 'With enrolmentperiod defined and a date given in parameter, ->get_expiry_date should take this date + enrolmentperiod' koha_1 | # at t/db_dependent/Koha/Patron/Categories.t line 80. koha_1 | # got: '-1' koha_1 | # expected: '0' koha_1 | # Looks like you failed 1 test of 5. koha_1 | koha_1 | # Failed test 'get_expiry_date' koha_1 | # at t/db_dependent/Koha/Patron/Categories.t line 86. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 13:50:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 12:50:35 +0000 Subject: [Koha-bugs] [Bug 22284] Hiding libraries outside group for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|nick at bywatersolutions.com |agustinmoyano at theke.io Status|NEW |ASSIGNED Severity|enhancement |new feature CC| |tomascohen at gmail.com --- Comment #2 from Tom?s Cohen Arazi --- This development will add pickup location groups. 1. Add a new feature checkbox to groups feature to define 'local hold groups' 2. Hold policy in circ rules - new option 'from local hold group' [effectively act as homelibrary + libraries in groups you are in] 2a. This will apply per item (C4::Reserves::CanItemBeReserved) 2b. possibly add a system preference to set home or holding as control 2c. Will check patron's homelibrary to see if possible 3. On checkin, hold policy will be checked to see if hold can be filled according to policy in 2a (dropping through all holds to find highest priority that can be satisfied) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 13:50:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 12:50:47 +0000 Subject: [Koha-bugs] [Bug 22284] Hiding libraries outside group for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 14:06:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 13:06:18 +0000 Subject: [Koha-bugs] [Bug 22284] Hiding libraries outside group for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20747 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 14:06:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 13:06:18 +0000 Subject: [Koha-bugs] [Bug 20747] Allow LocalHoldsPriority to fill by hierarchical groups system rather than individual library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22284 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 14:08:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 13:08:50 +0000 Subject: [Koha-bugs] [Bug 20747] Allow LocalHoldsPriority to fill by hierarchical groups system rather than individual library In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|NEW |In Discussion --- Comment #1 from Tom?s Cohen Arazi --- Lisette, could you please explain a bit further? Also, can you take a look at bug 22284 and see how it fits? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 14:09:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 13:09:37 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Hiding libraries outside |Groups of pickup locations |group for holds |for holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 14:29:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 13:29:39 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #65 from Tom?s Cohen Arazi --- All looks good to me. The only doubt is why aren't the maxissueqty and maxonsiteissureqty columns removed from issuingrules. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 14:38:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 13:38:21 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85480|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 14:38:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 13:38:28 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85481|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 14:38:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 13:38:36 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85482|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 14:38:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 13:38:43 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85483|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 14:38:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 13:38:47 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85484|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 14:38:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 13:38:54 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85485|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 14:39:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 13:39:00 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85486|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 14:39:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 13:39:36 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #66 from Tom?s Cohen Arazi --- Created attachment 85939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85939&action=edit Bug 18925: Move maxissueqty and maxonsiteissueqty to circulation_rules This patch set moves maxissueqty and maxonsiteissueqty to the circulation_rules table. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) prove t/db_dependent/Circulation.t 4) prove t/db_dependent/Circulation/Branch.t 5) prove t/db_dependent/Circulation/GetHardDueDate.t 6) prove t/db_dependent/Circulation/Returns.t 7) prove t/db_dependent/Circulation/SwitchOnSiteCheckouts.t 8) prove t/db_dependent/Circulation/TooMany.t 9) prove t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t 10) prove t/db_dependent/Reserves.t 11) Note no changes in circulation behavior related to check out limis both on and off site Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 14:39:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 13:39:46 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #67 from Tom?s Cohen Arazi --- Created attachment 85940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85940&action=edit Bug 18925: (follow-up) Change name of rule to fix ambiguity There was previously an ambiguity between the branch/category/itemtype specific max{,onsite}issueqty and the total-per-patron max{,onsite}issueqty. The latter has been renamed to patron_max{,onsite}issueqty. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 14:39:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 13:39:56 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #68 from Tom?s Cohen Arazi --- Created attachment 85941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85941&action=edit Bug 18925: (follow-up) Fix null/empty behavior Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 14:40:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 13:40:04 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #69 from Tom?s Cohen Arazi --- Created attachment 85942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85942&action=edit Bug 18925: Replace logic in GetBranchBorrowerCircRule with get_effective_rule Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 14:40:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 13:40:15 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #70 from Tom?s Cohen Arazi --- Created attachment 85943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85943&action=edit Bug 18925: Update schema files Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 14:40:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 13:40:27 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #72 from Tom?s Cohen Arazi --- Created attachment 85945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85945&action=edit Bug 18925: Update new occurrences Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 14:40:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 13:40:38 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #73 from Tom?s Cohen Arazi --- Created attachment 85946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85946&action=edit Bug 18925: (QA follow-up) Make DB update idempotent Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 14:40:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 13:40:46 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #74 from Tom?s Cohen Arazi --- Created attachment 85947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85947&action=edit Bug 18925: (QA follow-up) Fix indentation characters in smart-rules.tt Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 14:40:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 13:40:21 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #71 from Tom?s Cohen Arazi --- Created attachment 85944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85944&action=edit Bug 18925: Fix null/empty behavior, again Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 14:49:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 13:49:24 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #75 from Tom?s Cohen Arazi --- Everything looks great. Minor stuffs: - The question about issuingrules. - Related to issuingrules: basic_workflow.t needs to be adjusted to use the new set_rule method for maxissueqty -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 15:03:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 14:03:24 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #76 from Tom?s Cohen Arazi --- Created attachment 85948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85948&action=edit Bug 18925: (QA follow-up) Fix basic_workflow.t Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 15:38:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 14:38:29 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 16:17:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 15:17:59 +0000 Subject: [Koha-bugs] [Bug 22444] currencies_manage permission doesn't provide link to manage currencies when selected alone In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22444 Nick Clemens changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |katrin.fischer at bsz-bw.de, | |martin.renvoize at ptfs-europe | |.com, | |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 18:15:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 17:15:37 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #77 from Jonathan Druart --- Created attachment 85949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85949&action=edit Bug 18925: Move existing rules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 18:15:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 17:15:53 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #78 from Jonathan Druart --- Created attachment 85950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85950&action=edit Bug 18925: (follow-up) DBIC schema changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 18:16:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 17:16:00 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #79 from Jonathan Druart --- Created attachment 85951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85951&action=edit Bug 18925: Fix 'Default checkout, hold policy by patron category' block We want ->Search to return undef if the rule does not exist. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 18:19:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 17:19:07 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Jonathan Druart changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #80 from Jonathan Druart --- (In reply to Tom?s Cohen Arazi from comment #75) > Everything looks great. Minor stuffs: > > - The question about issuingrules. > - Related to issuingrules: basic_workflow.t needs to be adjusted to use the > new set_rule method for maxissueqty Indeed, thanks for catching that! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 18:37:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 17:37:05 +0000 Subject: [Koha-bugs] [Bug 22446] Koha/Patron/Categories.t is failing on March 1st (2019 only?) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22446 --- Comment #1 from Jonathan Druart --- Created attachment 85952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85952&action=edit Bug 22446: Add tests to highlight the problem -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 18:46:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 17:46:28 +0000 Subject: [Koha-bugs] [Bug 21892] Robin Sheat is not a typo In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21892 --- Comment #14 from Jonathan Druart --- I would not expect a script to remove/install packages without asking anything. I warning message with the detailed steps sounds better to me. What do you think? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 20:30:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 19:30:32 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 20:30:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 19:30:44 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85939|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 20:30:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 19:30:54 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85940|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 20:31:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 19:31:08 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85941|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 20:31:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 19:31:30 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85943|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 20:31:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 19:31:41 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85944|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 20:31:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 19:31:19 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85942|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 20:31:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 19:31:47 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85945|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 20:31:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 19:31:55 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85946|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 20:32:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 19:32:02 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85947|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 20:32:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 19:32:08 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85948|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 20:32:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 19:32:13 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85949|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 20:32:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 19:32:18 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85950|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 20:32:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 19:32:22 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Tom?s Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85951|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 20:33:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 19:33:23 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #81 from Tom?s Cohen Arazi --- Created attachment 85953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85953&action=edit Bug 18925: Move maxissueqty and maxonsiteissueqty to circulation_rules This patch set moves maxissueqty and maxonsiteissueqty to the circulation_rules table. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) prove t/db_dependent/Circulation.t 4) prove t/db_dependent/Circulation/Branch.t 5) prove t/db_dependent/Circulation/GetHardDueDate.t 6) prove t/db_dependent/Circulation/Returns.t 7) prove t/db_dependent/Circulation/SwitchOnSiteCheckouts.t 8) prove t/db_dependent/Circulation/TooMany.t 9) prove t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t 10) prove t/db_dependent/Reserves.t 11) Note no changes in circulation behavior related to check out limis both on and off site Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 20:33:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 19:33:31 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #82 from Tom?s Cohen Arazi --- Created attachment 85954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85954&action=edit Bug 18925: (follow-up) Change name of rule to fix ambiguity There was previously an ambiguity between the branch/category/itemtype specific max{,onsite}issueqty and the total-per-patron max{,onsite}issueqty. The latter has been renamed to patron_max{,onsite}issueqty. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 20:33:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 19:33:37 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #83 from Tom?s Cohen Arazi --- Created attachment 85955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85955&action=edit Bug 18925: (follow-up) Fix null/empty behavior Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 20:33:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 19:33:44 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #84 from Tom?s Cohen Arazi --- Created attachment 85956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85956&action=edit Bug 18925: Replace logic in GetBranchBorrowerCircRule with get_effective_rule Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 20:33:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 19:33:52 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #85 from Tom?s Cohen Arazi --- Created attachment 85957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85957&action=edit Bug 18925: Update schema files Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 20:34:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 19:34:02 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #86 from Tom?s Cohen Arazi --- Created attachment 85958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85958&action=edit Bug 18925: Fix null/empty behavior, again Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 20:34:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 19:34:27 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #87 from Tom?s Cohen Arazi --- Created attachment 85959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85959&action=edit Bug 18925: Update new occurrences Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 20:34:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 19:34:44 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #88 from Tom?s Cohen Arazi --- Created attachment 85960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85960&action=edit Bug 18925: (QA follow-up) Make DB update idempotent Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 20:35:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 19:35:00 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #89 from Tom?s Cohen Arazi --- Created attachment 85961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85961&action=edit Bug 18925: (QA follow-up) Fix indentation characters in smart-rules.tt Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 20:35:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 19:35:08 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #90 from Tom?s Cohen Arazi --- Created attachment 85962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85962&action=edit Bug 18925: (QA follow-up) Fix basic_workflow.t Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 20:35:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 19:35:13 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #91 from Tom?s Cohen Arazi --- Created attachment 85963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85963&action=edit Bug 18925: Move existing rules Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 20:35:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 19:35:19 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #92 from Tom?s Cohen Arazi --- Created attachment 85964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85964&action=edit Bug 18925: (follow-up) DBIC schema changes Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 20:35:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 19:35:29 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #93 from Tom?s Cohen Arazi --- Created attachment 85965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85965&action=edit Bug 18925: Fix 'Default checkout, hold policy by patron category' block We want ->Search to return undef if the rule does not exist. Signed-off-by: Tomas Cohen Arazi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 21:14:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 20:14:44 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #55 from Owen Leonard --- I've got some interface changes in process, but they don't need to hold this up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 2 22:19:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Mar 2019 21:19:19 +0000 Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307 --- Comment #5 from Jonathan Druart --- Should we continue on the same way of item types (translation from the UI), or extract the strings from the DB then use the new Koha::I18 module (translation from POs)? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Mar 3 01:39:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Mar 2019 00:39:14 +0000 Subject: [Koha-bugs] [Bug 22447] New: Server error on report with missing parameter Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22447 Bug ID: 22447 Summary: Server error on report with missing parameter Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: rbit at rbit.cz QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Save this SQL report: SELECT title FROM biblio where YEAR(copyrightdate) > YEAR(<>) and title = <> Run it, leave the date field "from" empty and fill any text into the "title" field. Sending the half-filled form causes internal server error to show up. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 3 01:39:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Mar 2019 00:39:58 +0000 Subject: [Koha-bugs] [Bug 22447] Server error on report with missing parameter In-Reply-To: <bug-22447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22447-70-H7tY4GdaHD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22447 Radek ?iman (R-Bit Technology, s.r.o.) <rbit at rbit.cz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com, | |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 3 20:47:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Mar 2019 19:47:14 +0000 Subject: [Koha-bugs] [Bug 17433] Koha::Validator. Validation for the masses! In-Reply-To: <bug-17433-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17433-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17433-70-Q1ca3yFJ11@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17433 --- Comment #7 from Brian <bklein at dubuque.lib.ia.us> --- I just know that it is related to at least 3 other patches of a ticket that concerns a problem with the Validation for *MandatoryField and *UnwantedField sysprefs. For now I'm putting my foot in the door as to speak so I receive email updates when progress is made and hopefully the patch is eventually finished -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 3 22:57:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Mar 2019 21:57:37 +0000 Subject: [Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces In-Reply-To: <bug-18584-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18584-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18584-70-NHRJzrgjmM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 3 22:57:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Mar 2019 21:57:57 +0000 Subject: [Koha-bugs] [Bug 22303] Wrong bottom in virtualshelves/addbybiblionumber.tt In-Reply-To: <bug-22303-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22303-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22303-70-xFe6CdE3D1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22303 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|fridolin.somers at biblibre.co |hayleymapley at catalyst.net.n |m |z CC| |hayleymapley at catalyst.net.n | |z -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 3 22:59:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Mar 2019 21:59:09 +0000 Subject: [Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces In-Reply-To: <bug-18584-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18584-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18584-70-Di8YaJHYtJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |hayleymapley at catalyst.net.n |ity.org |z Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Mar 3 23:49:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Mar 2019 22:49:34 +0000 Subject: [Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces In-Reply-To: <bug-18584-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18584-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18584-70-BxPD4sKy90@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 --- Comment #40 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Created attachment 85966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85966&action=edit Bug 18584: remove trailing space from C4/XSLT.pm Test plan: 1) Open C4/XSLT.pm and confirm that the trailing space at line 313 is gone. 2) Sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 3 23:51:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Mar 2019 22:51:17 +0000 Subject: [Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces In-Reply-To: <bug-18584-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18584-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18584-70-vIA7X236hi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 3 23:56:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Mar 2019 22:56:46 +0000 Subject: [Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces In-Reply-To: <bug-18584-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18584-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18584-70-EBTKQnVLkW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85966|0 |1 is obsolete| | --- Comment #41 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Created attachment 85967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85967&action=edit Bug 18584: remove trailing space from C4/XSLT.pm Test plan: 1) Open C4/XSLT.pm and confirm that the trailing space at line 313 is gone. 2) Sign off. Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 3 23:57:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Mar 2019 22:57:02 +0000 Subject: [Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces In-Reply-To: <bug-18584-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18584-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18584-70-qQDcGm6gZO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 00:19:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Mar 2019 23:19:39 +0000 Subject: [Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces In-Reply-To: <bug-18584-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18584-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18584-70-MuAOQVakPn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82347|0 |1 is obsolete| | Attachment #85967|0 |1 is obsolete| | --- Comment #42 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 85968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85968&action=edit Bug 18584: remove trailing space from C4/XSLT.pm Test plan: 1) Open C4/XSLT.pm and confirm that the trailing space at line 313 is gone. 2) Sign off. Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 00:19:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Mar 2019 23:19:31 +0000 Subject: [Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces In-Reply-To: <bug-18584-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18584-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18584-70-Ku36cgYXuI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 01:14:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 00:14:39 +0000 Subject: [Koha-bugs] [Bug 22366] Web-based installer mentions PostgreSQL In-Reply-To: <bug-22366-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22366-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22366-70-9asnhG8Cix@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22366 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |hayleymapley at catalyst.net.n |ity.org |z CC| |hayleymapley at catalyst.net.n | |z -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 01:35:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 00:35:50 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18235-70-H6uTyr8cHX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #56 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Josef Moravec from comment #50) > Comment on attachment 85214 [details] [review] > Bug 18235: DB changes > > Review of attachment 85214 [details] [review]: > ----------------------------------------------------------------- > > ::: > installer/data/mysql/atomicupdate/bug_18235-add-search_field-facet_order.sql > @@ +1,1 @@ > > +ALTER TABLE search_field ADD COLUMN facet_order TINYINT(4) DEFAULT '0' AFTER weight; > > Here is default 0 > > ::: installer/data/mysql/kohastructure.sql > @@ +1493,4 @@ > > `label` varchar(255) NOT NULL COMMENT 'the human readable name of the field, for display', > > `type` ENUM('', 'string', 'date', 'number', 'boolean', 'sum', 'isbn', 'stdno') NOT NULL COMMENT 'what type of data this holds, relevant when storing it in the search engine', > > `weight` decimal(5,2) DEFAULT NULL, > > + `facet_order` TINYINT(4) DEFAULT NULL COMMENT 'the order place of the field in facet list if faceted', > > And here NULL Right, must be NULL in the atomic update file. (In reply to Josef Moravec from comment #51) > Comment on attachment 85212 [details] [review] > Bug 18235: ES - Facets configurable > > Review of attachment 85212 [details] [review]: > ----------------------------------------------------------------- > > ::: Koha/SearchEngine/Elasticsearch.pm > @@ +971,5 @@ > > + my @faceted_fields = Koha::SearchFields->search( > > + { name => { -in => \@search_field_names }, facet_order => { '!=' => undef } }, { order_by => ['facet_order'] } > > + ); > > + my @not_faceted_fields = Koha::SearchFields->search( > > + { name => { -in => \@search_field_names }, facet_order => undef }, { order_by => ['facet_order'] } > > Why do you retrieve fields from database in 2 queries, you always use them > all. To have the not faceted fields at the end of the array. I agree it's a lazy way to handle that, but it works :) > ::: admin/searchengine/elasticsearch/mappings.pl > @@ +215,4 @@ > > push @all_search_fields, $search_field_unblessed; > > } > > > > +my @facetable_fields = Koha::SearchEngine::Elasticsearch->get_facetable_fields(); > > get_facetable_fields is called 3 or 4 times every run of mappings.pl. Yep, could be lowered to 2. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 01:37:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 00:37:04 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18235-70-7oybmhJCO9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 01:37:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 00:37:11 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18235-70-sjhpRxoqez@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #57 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 85969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85969&action=edit Bug 18235: Update facet_order default value in atomic update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 01:37:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 00:37:18 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18235-70-cCf2YZWW2a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #58 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 85970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85970&action=edit Bug 18235: Do not call get_facetable_fields excessively -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 01:41:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 00:41:14 +0000 Subject: [Koha-bugs] [Bug 22444] currencies_manage permission doesn't provide link to manage currencies when selected alone In-Reply-To: <bug-22444-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22444-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22444-70-Ep0ZXvKesn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22444 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I guess this apply for other permissions as well. It seems tedious to handle that case. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 01:42:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 00:42:00 +0000 Subject: [Koha-bugs] [Bug 22026] Remove `use Modern::Perl` from Koha::REST::classes In-Reply-To: <bug-22026-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22026-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22026-70-07CKr36cld@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22026 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 01:48:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 00:48:01 +0000 Subject: [Koha-bugs] [Bug 22417] Delegate background jobs execution In-Reply-To: <bug-22417-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22417-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22417-70-jhUDqDkC6X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to David Cook from comment #15) > If I understand correctly, each Koha instance would get its own RabbitMQ > "vhost", and within each "vhost" there would be named queues (which at the > moment are hard-coded but could be configurable I suppose). I imaged one koha-worker script per Koha instance, with as well one vhost. The queues would be named 'batch_record_modification', 'manage-marc-import', 'batch_item_modification', etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 01:50:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 00:50:06 +0000 Subject: [Koha-bugs] [Bug 22417] Delegate background jobs execution In-Reply-To: <bug-22417-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22417-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22417-70-Df8s2fJeki@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- TODO, remove that: Bug 15032: UpdateDB entry + # $dbh->do( "ALTER TABLE biblio ADD COLUMN badtaste int" ); Bug 22417: Add the ability to cancel a job + sleep(5); :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 01:51:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 00:51:36 +0000 Subject: [Koha-bugs] [Bug 21846] Using emoji as tags doesn't discriminate between emoji when calculating weights or searching In-Reply-To: <bug-21846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21846-70-UapcYbE3tb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 --- Comment #38 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- In my opinion we should fix bug 22420 first. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 02:10:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 01:10:01 +0000 Subject: [Koha-bugs] [Bug 22366] Web-based installer mentions PostgreSQL In-Reply-To: <bug-22366-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22366-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22366-70-OhVetdnZ4Q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22366 --- Comment #2 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Created attachment 85971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85971&action=edit Bug 22366: Amended help text - Web Installer step2 On Step 2 of the Web Installer, the 'Need Help?' section refers to MySQL documentation if the DB used is MySQL, or refers to PostgreSQL documentation in all other cases. This patch removes the reference to PostgreSQL and instead only displays the 'Need Help' text if the user's database is MySQL. To test: When running the Web Installer, if you are using MySQL then text that says Need Help? with a link to the documentation should be present. If you are using anything else (PostgreSQL, MariaDB, etc.), this text and link should not be present. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 02:10:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 01:10:33 +0000 Subject: [Koha-bugs] [Bug 22366] Web-based installer mentions PostgreSQL In-Reply-To: <bug-22366-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22366-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22366-70-G937Dh4lUE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22366 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 02:35:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 01:35:36 +0000 Subject: [Koha-bugs] [Bug 22395] Data in 245 field (subfield a or b) will be deleted if it has Quotation Marks In-Reply-To: <bug-22395-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22395-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22395-70-eK3c0MdykO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22395 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|ASSIGNED |RESOLVED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 02:52:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 01:52:18 +0000 Subject: [Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2 In-Reply-To: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17140-70-A5OxPrwubn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z Status|Needs Signoff |Patch doesn't apply --- Comment #27 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Patch 54542 did not apply cleanly. Marking as Patch doesn't apply. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 03:04:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 02:04:59 +0000 Subject: [Koha-bugs] [Bug 21846] Using emoji as tags doesn't discriminate between emoji when calculating weights or searching In-Reply-To: <bug-21846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21846-70-BhYPr01Lxl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 --- Comment #39 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- (In reply to Jonathan Druart from comment #38) > In my opinion we should fix bug 22420 first. No, 22420 won't be fixed if the weights are wrongly calculated, which is fixed here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 03:51:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 02:51:50 +0000 Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV In-Reply-To: <bug-7957-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7957-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7957-70-Q74eV2lVt7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #81 from David Cook <dcook at prosentient.com.au> --- Looking at the patches, is the idea that you'd have a routing list per issue? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 03:52:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 02:52:36 +0000 Subject: [Koha-bugs] [Bug 22434] correct item callnumber search link In-Reply-To: <bug-22434-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22434-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22434-70-zbrXxuaf2I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22434 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z --- Comment #2 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Hi, I've tested up until Step 7, all looks fine. Would you mind explaining what you mean in Step 7 when you say 'group search'? Cheers, Hayley -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 03:52:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 02:52:51 +0000 Subject: [Koha-bugs] [Bug 10265] 830 needs spaces in XSLT display In-Reply-To: <bug-10265-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10265-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10265-70-3tsW4JRwmb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10265 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 05:09:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 04:09:14 +0000 Subject: [Koha-bugs] [Bug 21948] Clean up style of item detail page In-Reply-To: <bug-21948-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21948-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21948-70-A38DO34Dfs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21948 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |hayleymapley at catalyst.net.n | |z --- Comment #4 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Patch does not apply. Applying: Bug 21948: Clean up style of item detail page .git/rebase-apply/patch:46: trailing whitespace. <li><span class="label">No. of items:</span> [% count | html %] [% IF ( hiddencount ) %]total ([% showncount | html %] shown / [% hiddencount | html %] hidden) error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss). error: could not build fake ancestor Patch failed at 0001 Bug 21948: Clean up style of item detail page The copy of the patch that failed is found in: .git/rebase-apply/patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 07:05:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 06:05:33 +0000 Subject: [Koha-bugs] [Bug 22429] Infinite loop in patron card printing In-Reply-To: <bug-22429-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22429-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22429-70-spOCUdZpHA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22429 --- Comment #4 from David Cook <dcook at prosentient.com.au> --- (In reply to Katrin Fischer from comment #1) > We have seen conditions where exporting a batch of patron cards brings down > the instance. Do you know how the patron cards need to be set up to create > this one? I don't have master conditions yet but in a 17.05.x I've reproduced with the following: -- Layout: Units: PostScript Points Field 1 Text: <firstname> <surname> Font: Times-Roman Font size: 20pt Text alignment: Center Lower left X coordinate: 40pt Lower left Y coordinate: 20pt Barcode Print card number as barcode: checked Lower left X coordinate: 0 Lower left Y coordinate: 50 Print card number as text under barcode: checked -- -- Template: Units: SI Millimeters Page height: 32mm Page width: 95mm Card width: 95mm Card height: 30mm Top page margin: 5mm Left page margin: 2mm Number of columns: 1 Number of rows: 1 -- -- User: Cardnumber: 1 Surname: Test Firnatme: 12345678 123456 (Test) -- This can generate an infinitely looping process of /home/dcook/git/patroncards/create-pdf.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 07:08:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 06:08:17 +0000 Subject: [Koha-bugs] [Bug 22429] Infinite loop in patron card printing In-Reply-To: <bug-22429-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22429-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22429-70-ZDIgYhpIt9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22429 --- Comment #5 from David Cook <dcook at prosentient.com.au> --- Forgot to mention the problem is in C4/Patroncards/Patroncard.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 07:35:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 06:35:31 +0000 Subject: [Koha-bugs] [Bug 22429] Infinite loop in patron card printing In-Reply-To: <bug-22429-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22429-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22429-70-HuyMy5Z8t6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22429 --- Comment #6 from David Cook <dcook at prosentient.com.au> --- Aha... it's the parentheses which are the problem. They're being interpreted as regex metacharacters and not literal values! First line: '12345678 123456 (Test) Test' First string width: 299.775390625 First $1: ' Test' First $trim: '' Next line: '12345678 123456 (Test)' Next string width: 249.94140625 Next $1: ' (Test)' Next $trim: ' (Test) Test' Next line: '12345678 123456 (Test)' Next string width: 249.94140625 Next $1: ' (Test)' Next $trim: ' (Test) (Test) Test' And the $trim just keeps prepending (Test) over and over again. -- Fortunately, this is a very easy solve. I change the following $line =~ s/$1//; to $line =~ s/\Q$1\E//; And voila. It works. I bet this sort of "regular expression injection" could bite us in other parts of Koha... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 07:53:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 06:53:23 +0000 Subject: [Koha-bugs] [Bug 22429] Infinite loop in patron card printing In-Reply-To: <bug-22429-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22429-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22429-70-ngd2qk0OnC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22429 --- Comment #7 from David Cook <dcook at prosentient.com.au> --- Created attachment 85972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85972&action=edit Bug 22429: Infinite loop in patron card printing Text fields in Patron Card Text Layouts can contain regular expression metacharacters, which - instead of being treated as literal values - are interpreted and prevent line wrapping. This causes the process to get stuck in an infinite loop, which keeps running even after the web server has timed out (at least when using CGI). This patch escapes the relevant input from the text field so the regular expression substitution treats characters as literals instead of as metacharacters. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 07:53:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 06:53:20 +0000 Subject: [Koha-bugs] [Bug 22429] Infinite loop in patron card printing In-Reply-To: <bug-22429-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22429-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22429-70-w9HncidUPC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22429 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 07:57:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 06:57:16 +0000 Subject: [Koha-bugs] [Bug 22429] Infinite loop in patron card printing In-Reply-To: <bug-22429-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22429-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22429-70-F7ZaIhhalc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22429 --- Comment #8 from David Cook <dcook at prosentient.com.au> --- Test plan: 1. Create data in your test Koha as follows: Layout: Units: PostScript Points Field 1 Text: <firstname> <surname> Font: Times-Roman Font size: 20pt Text alignment: Center Lower left X coordinate: 40pt Lower left Y coordinate: 20pt Barcode Print card number as barcode: checked Lower left X coordinate: 0 Lower left Y coordinate: 50 Print card number as text under barcode: checked -- -- Template: Units: SI Millimeters Page height: 32mm Page width: 95mm Card width: 95mm Card height: 30mm Top page margin: 5mm Left page margin: 2mm Number of columns: 1 Number of rows: 1 -- -- User: Cardnumber: 1 Surname: Test Firstname: 12345678 123456 (Test) 2. Before applying the patch, try to export a batch that contains the user with cardnumber 1 3. Note that Apache will timeout and that create-pdf.pl infinitely loops in the background (I haven't tested with Plack, but Katrin has mentioned in https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22429#c1 that it will bring down the instance.) 3a. ps -efww | grep "create-pdf" 4. Apply the patch 5. Note that the patron card is generated and downloaded via your browser -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 07:57:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 06:57:24 +0000 Subject: [Koha-bugs] [Bug 22429] Infinite loop in patron card printing In-Reply-To: <bug-22429-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22429-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22429-70-VtPfOHDPD5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22429 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cnighswonger at foundations.ed |dcook at prosentient.com.au |u | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 09:10:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 08:10:39 +0000 Subject: [Koha-bugs] [Bug 19635] OAI-PMH deleted records are now default and are listed first In-Reply-To: <bug-19635-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19635-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19635-70-Nm6OW5AV2e@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19635 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |BLOCKED Depends on| |20271 --- Comment #4 from Ere Maijala <ere.maijala at helsinki.fi> --- Note that this will change when normal and deleted records get merged into a single table. That's bug 20271. I'd like to close this one as Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables with their "alive" cousins -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 09:10:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 08:10:39 +0000 Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables with their "alive" cousins In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20271-70-Q1ScdLl2Qu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19635 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19635 [Bug 19635] OAI-PMH deleted records are now default and are listed first -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 09:11:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 08:11:18 +0000 Subject: [Koha-bugs] [Bug 19635] OAI-PMH deleted records are now default and are listed first In-Reply-To: <bug-19635-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19635-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19635-70-XHqLJ2expN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19635 --- Comment #5 from Ere Maijala <ere.maijala at helsinki.fi> --- ... no changes are needed here, but we can also keep this blocked for now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 09:13:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 08:13:04 +0000 Subject: [Koha-bugs] [Bug 21872] Elasticsearch indexing faster by making it multi-threaded In-Reply-To: <bug-21872-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21872-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21872-70-GVy0ZGCfYI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21872 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |ere.maijala at helsinki.fi |ity.org | Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 09:17:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 08:17:28 +0000 Subject: [Koha-bugs] [Bug 22439] Duplicated code in PrepHostMarcField and prepare_host_field In-Reply-To: <bug-22439-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22439-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22439-70-mSefU39DiG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22439 --- Comment #1 from paxed <pasi.kallinen at koha-suomi.fi> --- In addition: 1) prepare_host_field: if ( $field = $host->field('100') || $host->field('110') || $host->field('11') ) - the '11' should be '111' 2) prepare_host_field has a 240 -> 773b, which should be 250a -> 773b, as it is in PrepHostMarcField 3) There's a difference in how the 773a is set: prepare_host_field uses 100ab | 110ab | 11ab, but PrepHostMarcField uses 100a | 110a | 111a -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 10:09:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 09:09:11 +0000 Subject: [Koha-bugs] [Bug 22275] 18.06.00.060 DB update fails (incomplete/incorrect defaults) In-Reply-To: <bug-22275-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22275-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22275-70-wFKFs22eEh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22275 sandboxes at biblibre.com <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes at biblibre.com --- Comment #14 from sandboxes at biblibre.com <sandboxes at biblibre.com> --- Patch tested with a sandbox, by Oliver Behnke <oliver.behnke at aei.mpg.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 10:15:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 09:15:48 +0000 Subject: [Koha-bugs] [Bug 22275] 18.06.00.060 DB update fails (incomplete/incorrect defaults) In-Reply-To: <bug-22275-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22275-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22275-70-lBqODCJqol@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22275 --- Comment #15 from Oliver Behnke <oliver.behnke at aei.mpg.de> --- FYI, I couldn't coerce any sandbox into first deploying a pre-15836 database, then provide manually the necessary test and finally apply the path without further DB changes. Anyhow, I double checked the patch itself so my sign-off still holds. Cheers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 10:27:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 09:27:49 +0000 Subject: [Koha-bugs] [Bug 22443] t/db_dependent/Koha/Patron/Categories.t contains a DateTime maths error In-Reply-To: <bug-22443-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22443-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22443-70-foT6WPiwNC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22443 --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 85973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85973&action=edit Bug 22443: Increase test coverage of get_expiry_date This method did not test for 'special' dates, i.e. handling for leap years. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 10:29:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 09:29:06 +0000 Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request datatable to be customisable In-Reply-To: <bug-21063-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21063-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21063-70-DzFtbhiLED@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 10:53:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 09:53:51 +0000 Subject: [Koha-bugs] [Bug 22443] t/db_dependent/Koha/Patron/Categories.t contains a DateTime maths error In-Reply-To: <bug-22443-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22443-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22443-70-qfpBUx6x1k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22443 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 10:53:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 09:53:28 +0000 Subject: [Koha-bugs] [Bug 22443] t/db_dependent/Koha/Patron/Categories.t contains a DateTime maths error In-Reply-To: <bug-22443-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22443-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22443-70-HWmilgiXtl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22443 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 10:54:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 09:54:16 +0000 Subject: [Koha-bugs] [Bug 22443] t/db_dependent/Koha/Patron/Categories.t contains a DateTime maths error In-Reply-To: <bug-22443-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22443-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22443-70-40hAbtFnxK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22443 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 11:13:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 10:13:35 +0000 Subject: [Koha-bugs] [Bug 22448] New: advance_notices.pl generates DUE(DGST) too early Message-ID: <bug-22448-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22448 Bug ID: 22448 Summary: advance_notices.pl generates DUE(DGST) too early Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Target Milestone: --- Looking in message_queue, I see DUE messages with message_queue.time_queued = 2019-03-04 00:10:07 where the content says The following item is now due: and gives a due date/time of: 2019-03-04 23:59 ... So the loan is actually not due for another 23 hours and 49 minutes. This is especially bothersome for one-day-loans, where the DUE(DGST) messages are never triggered, because the trigger is set off before the patron has a chance to borrow the item. Wouldn't it be better to fire off the DUE(DGST) messages 24 hours later, so at 2019-03-05 00:10:07 it would say "The following item is now due: 2019-03-04 23:59 ..."? Or am I missing something? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 11:14:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 10:14:15 +0000 Subject: [Koha-bugs] [Bug 22443] t/db_dependent/Koha/Patron/Categories.t contains a DateTime maths error In-Reply-To: <bug-22443-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22443-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22443-70-CVBtAbkdkU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22443 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85973|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 85974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85974&action=edit Bug 22443: Increase test coverage of get_expiry_date This method did not test for 'special' dates, i.e. handling for leap years. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 11:45:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 10:45:01 +0000 Subject: [Koha-bugs] [Bug 21872] Elasticsearch indexing faster by making it multi-threaded In-Reply-To: <bug-21872-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21872-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21872-70-JAQVb9HknM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21872 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com --- Comment #43 from Josef Moravec <josef.moravec at gmail.com> --- Hi Ere, I think that koha-elasticsearch debian script should be able to pass -p parameter to rebuild_elastic_search.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 12:13:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 11:13:40 +0000 Subject: [Koha-bugs] [Bug 21872] Elasticsearch indexing faster by making it multi-threaded In-Reply-To: <bug-21872-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21872-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21872-70-1sXRtSrKRh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21872 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #44 from Ere Maijala <ere.maijala at helsinki.fi> --- Right, I'll add it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 12:29:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 11:29:00 +0000 Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request datatable to be customisable In-Reply-To: <bug-21063-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21063-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21063-70-AtV8q7XN9k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #48 from Josef Moravec <josef.moravec at gmail.com> --- Thanks Andrew for quick follow-ups. I continue testing, but found functional issue - some metadata are not shown in ill request list table, so far i found problem with: pages comments article (part title), it is shown in title instead completed on cost -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 13:02:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 12:02:04 +0000 Subject: [Koha-bugs] [Bug 21872] Elasticsearch indexing faster by making it multi-threaded In-Reply-To: <bug-21872-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21872-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21872-70-Lqo7Fr2D4b@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21872 --- Comment #45 from Josef Moravec <josef.moravec at gmail.com> --- (In reply to Ere Maijala from comment #44) > Right, I'll add it. Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 13:36:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 12:36:47 +0000 Subject: [Koha-bugs] [Bug 21872] Elasticsearch indexing faster by making it multi-threaded In-Reply-To: <bug-21872-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21872-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21872-70-RBRx5xTIqU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21872 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 13:36:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 12:36:50 +0000 Subject: [Koha-bugs] [Bug 21872] Elasticsearch indexing faster by making it multi-threaded In-Reply-To: <bug-21872-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21872-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21872-70-8yELfrEnNP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21872 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82780|0 |1 is obsolete| | --- Comment #46 from Ere Maijala <ere.maijala at helsinki.fi> --- Created attachment 85975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85975&action=edit Bug 21872: Add multiprocess support to Elasticsearch indexing utility Test plan: 1. Time execution without -p parameter 2. Time execution with -p 2 or -p3 or -p 4 depending on CPU core count -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 13:36:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 12:36:54 +0000 Subject: [Koha-bugs] [Bug 21872] Elasticsearch indexing faster by making it multi-threaded In-Reply-To: <bug-21872-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21872-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21872-70-Tdv6HbN00B@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21872 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85119|0 |1 is obsolete| | --- Comment #47 from Ere Maijala <ere.maijala at helsinki.fi> --- Created attachment 85976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85976&action=edit Bug 21872: Simplify conditions and exit on invalid combination of arguments Change to zero based indexing for slice index to simplify some conditions. Exit with error message if trying to combine processes and biblio numbers arguments. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 13:36:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 12:36:57 +0000 Subject: [Koha-bugs] [Bug 21872] Elasticsearch indexing faster by making it multi-threaded In-Reply-To: <bug-21872-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21872-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21872-70-Z2EaPdYgla@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21872 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85121|0 |1 is obsolete| | --- Comment #48 from Ere Maijala <ere.maijala at helsinki.fi> --- Created attachment 85977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85977&action=edit Bug 21872: Remove duplicate modulo condition in authorities iterator -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 13:37:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 12:37:01 +0000 Subject: [Koha-bugs] [Bug 21872] Elasticsearch indexing faster by making it multi-threaded In-Reply-To: <bug-21872-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21872-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21872-70-8Pu2TjpHUH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21872 --- Comment #49 from Ere Maijala <ere.maijala at helsinki.fi> --- Created attachment 85978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85978&action=edit Bug 21872: Add support for -p parameter to koha-elasticsearch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 13:37:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 12:37:04 +0000 Subject: [Koha-bugs] [Bug 21872] Elasticsearch indexing faster by making it multi-threaded In-Reply-To: <bug-21872-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21872-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21872-70-khz8ksqN1R@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21872 --- Comment #50 from Ere Maijala <ere.maijala at helsinki.fi> --- Created attachment 85979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85979&action=edit Bug 21872: Fix name of rebuild_elasticsearch.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 13:48:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 12:48:33 +0000 Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap grid: Catalog In-Reply-To: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21304-70-UGIo2ygtrj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84704|0 |1 is obsolete| | Attachment #84705|0 |1 is obsolete| | --- Comment #20 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 85980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85980&action=edit Bug 21304: (follow-up) Fix style of search results browser This follow-up revises the style of the search result browser in the staff client, making it behave better at smaller browser widths. The patch also makes a couple of ESLint-prompted changes to browser.js To test, apply the patch and regenerate CSS. - Perform a catalog search in the staff client. - Click on one of the search results. - On the bibliographic detail page there should be results browsing controls in the left-hand sidebar. - Resize the browser window and confirm that the controls work well at various sizes. - Test with both the first and last search result. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 13:50:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 12:50:54 +0000 Subject: [Koha-bugs] [Bug 21948] Clean up style of item detail page In-Reply-To: <bug-21948-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21948-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21948-70-G3uXg2w2XZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21948 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 13:50:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 12:50:56 +0000 Subject: [Koha-bugs] [Bug 21948] Clean up style of item detail page In-Reply-To: <bug-21948-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21948-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21948-70-j2fELUIten@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21948 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82859|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 85981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85981&action=edit Bug 21948: Clean up style of item detail page This patch removes some page-specific style from the item detail page in the staff client and adds some markup in order to trigger a more generally-used style. This patch also adds a font-awesome icon to the "Edit item" link on the page. To test, apply the patch and regenerate the staff client CSS. Open a bibliographic record and view the "Items tab." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 13:52:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 12:52:13 +0000 Subject: [Koha-bugs] [Bug 21948] Clean up style of item detail page In-Reply-To: <bug-21948-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21948-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21948-70-eLWSqvIIg9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21948 --- Comment #6 from Owen Leonard <oleonard at myacpl.org> --- (In reply to Hayley Mapley from comment #4) > Patch does not apply. > error: sha1 information is lacking or useless Usually this kind of error means the patch required a dependency (Bug 21304), but I have rebased both patches to be safe. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 13:52:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 12:52:36 +0000 Subject: [Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2 In-Reply-To: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17140-70-CXxhWkC8IX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 --- Comment #28 from Blou <philippe.blouin at inlibro.com> --- Hi Hayley, Have you tried applying only 83467 (the last one), which is separated from the others (see my previous comments)? Or maybe its solution is not what you're looking for... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 14:08:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 13:08:33 +0000 Subject: [Koha-bugs] [Bug 22443] t/db_dependent/Koha/Patron/Categories.t contains a DateTime maths error In-Reply-To: <bug-22443-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22443-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22443-70-ecvjZ3Iy13@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22443 --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Did not see the patch on bug 22443? :-/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 14:09:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 13:09:22 +0000 Subject: [Koha-bugs] [Bug 22443] t/db_dependent/Koha/Patron/Categories.t contains a DateTime maths error In-Reply-To: <bug-22443-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22443-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22443-70-JpTjsQPASs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22443 --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Did not see the patch on bug 22446? :-/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 14:16:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 13:16:21 +0000 Subject: [Koha-bugs] [Bug 22429] Infinite loop in patron card printing In-Reply-To: <bug-22429-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22429-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22429-70-ocnFpjDe20@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22429 Christian Stelzenm?ller <christian.stelzenmueller at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christian.stelzenmueller at bs | |z-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 14:20:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 13:20:03 +0000 Subject: [Koha-bugs] [Bug 19635] OAI-PMH deleted records are now default and are listed first In-Reply-To: <bug-19635-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19635-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19635-70-F2mPkfmX2J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19635 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|BLOCKED |RESOLVED --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- I am okay with closing, once service got used to the change things have been working fine. Cosmetic not functional issue -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 14:24:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 13:24:58 +0000 Subject: [Koha-bugs] [Bug 22429] Infinite loop in patron card printing In-Reply-To: <bug-22429-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22429-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22429-70-eAyrbzL2oZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22429 --- Comment #9 from Christian Stelzenm?ller <christian.stelzenmueller at bsz-bw.de> --- > "Aha... it's the parentheses which are the problem. They're being interpreted as > regex metacharacters and not literal values!" We noticed that there seems to be an infinite loop if the template has some or all entries with "0" in it (like in default when creating a new template). Could this be the same cause? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 14:33:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 13:33:50 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18235-70-EJhDQbByDr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #59 from Josef Moravec <josef.moravec at gmail.com> --- (In reply to Owen Leonard from comment #53) > (In reply to Josef Moravec from comment #52) > > the facet table is at > > the end of page and easy to oversee... > > I wonder if it should be in a separate tab? I think it is good idea. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 14:37:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 13:37:06 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18235-70-xSYocVjq7v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #60 from Josef Moravec <josef.moravec at gmail.com> --- (In reply to Jonathan Druart from comment #54) > I would support an integration ASAP then we could discuss the ergonomic > (patches submitted 2 years ago). > > Unless somebody else is willing to make the changes ;) (In reply to Owen Leonard from comment #55) > I've got some interface changes in process, but they don't need to hold this > up. I agree, we could pass and push this soon and then work on UI -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 14:41:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 13:41:56 +0000 Subject: [Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields In-Reply-To: <bug-8643-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8643-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8643-70-ybjTWKnOoz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81032|0 |1 is obsolete| | --- Comment #76 from Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> --- Created attachment 85982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85982&action=edit Bug 8643: Add important constraint to marc subfields This fix permits to add an "Important" option to the marc structure pages. Testing: 1) Apply the patch 2) Run updatedatabase.pl 3) Regenerate CSS 4) Define 100 as an "important" field ( Administration ? MARC bibliographic framework ? MARC structure ( Default Frameword) ? Edit ) 5) Define 100$a as an "important" subfield (Administration ? MARC bibliographic framework ? MARC structure (Default Frameword) ? Subfield ? Onglet a) 6) Edit a record to clear the field 100 (subfields are all blank) 7) Save the record. 8) Validate the following message: A few important fields are not filled: * tag 100 subfield a Nom de personne in tab * Field 100 is important, at least one of its subfields should be filled. Are you sure you want to save? Sponsored by the CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 14:43:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 13:43:38 +0000 Subject: [Koha-bugs] [Bug 8643] Add important constraint to MARC tags and subfields In-Reply-To: <bug-8643-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8643-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8643-70-0UOpLftY35@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8643 Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #77 from Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> --- The patch has been fixed and can be applied on master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 14:52:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 13:52:25 +0000 Subject: [Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page In-Reply-To: <bug-12502-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12502-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12502-70-QQTl96wXcr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 14:57:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 13:57:17 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18235-70-oDswhvvcFY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85212|0 |1 is obsolete| | Attachment #85213|0 |1 is obsolete| | Attachment #85214|0 |1 is obsolete| | Attachment #85215|0 |1 is obsolete| | Attachment #85216|0 |1 is obsolete| | Attachment #85885|0 |1 is obsolete| | Attachment #85886|0 |1 is obsolete| | Attachment #85969|0 |1 is obsolete| | Attachment #85970|0 |1 is obsolete| | --- Comment #61 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 85983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85983&action=edit Bug 18235: ES - Facets configurable This patch adds a new section 'Facet order' in the Biblio tab of the 'Search engine configuration' admin page of the Elastic mappings. The idea is to let the librarians define the facet to display and order them as their needs. The ergonomic is not perfect and I am open to any suggestions. Test plan: Move up and down the field list to order the facets Hide/show some facets Rebuild index At the OPAC and the staff interface you should see the changes on the search result page. Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 14:57:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 13:57:11 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18235-70-UbqB8WPnd9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 14:57:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 13:57:28 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18235-70-VNGlhlg6FJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #63 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 85985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85985&action=edit Bug 18235: DB changes Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 14:57:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 13:57:34 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18235-70-2hJJuJQibz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #64 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 85986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85986&action=edit Bug 18235: Add unit tests for get_facetable_fields Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 14:57:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 13:57:39 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18235-70-kQlTvNLMHt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #65 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 85987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85987&action=edit Bug 18235: DBIx schema changes Fresh changes for SearchField, facet_order. Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 14:57:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 13:57:23 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18235-70-KuAatBX8yk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #62 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 85984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85984&action=edit Bug 18235: Add missing POD to get_facetable_fields Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 14:57:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 13:57:45 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18235-70-Srk8zNqVLm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #66 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 85988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85988&action=edit Bug 18235: (QA follow-up) Fix POD Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 14:57:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 13:57:50 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18235-70-nPC1ig3TnD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #67 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 85989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85989&action=edit Bug 18235: (QA follow-up) Add missing filters Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 14:57:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 13:57:55 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18235-70-RZ78g4T7lx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #68 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 85990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85990&action=edit Bug 18235: Update facet_order default value in atomic update Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 14:58:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 13:58:00 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18235-70-RSE7oCBwWe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #69 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 85991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85991&action=edit Bug 18235: Do not call get_facetable_fields excessively Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 14:58:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 13:58:06 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18235-70-kHEiIU3NJX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #70 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 85992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85992&action=edit Bug 18235: (QA follow-up) Make db update idempotent Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 14:59:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 13:59:06 +0000 Subject: [Koha-bugs] [Bug 22449] New: Improve Elastic search facet setting UI Message-ID: <bug-22449-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22449 Bug ID: 22449 Summary: Improve Elastic search facet setting UI Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: josef.moravec at gmail.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- As discussed on bug 18235, the UI of facet settings should be improved - probably make it separate tab on elastic search admin page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 14:59:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 13:59:45 +0000 Subject: [Koha-bugs] [Bug 22449] Improve Elastic search facet setting UI In-Reply-To: <bug-22449-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22449-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22449-70-5gUggJU6sa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22449 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Target Milestone|--- |19.05 Depends on| |18235 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 [Bug 18235] Elastic search - Configurable facets -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 14:59:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 13:59:45 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18235-70-IsFT4K3Hj2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22449 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22449 [Bug 22449] Improve Elastic search facet setting UI -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 14:59:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 13:59:57 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18235-70-RfCK0Jpcux@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |19.05 QA Contact|m.de.rooy at rijksmuseum.nl |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 15:01:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 14:01:14 +0000 Subject: [Koha-bugs] [Bug 18213] Add language facets to Elasticsearch In-Reply-To: <bug-18213-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18213-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18213-70-xvbnHCe5rj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Status|BLOCKED |Signed Off --- Comment #22 from Josef Moravec <josef.moravec at gmail.com> --- dependency bug 18235 passed qa, setting this back to signed off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 15:02:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 14:02:36 +0000 Subject: [Koha-bugs] [Bug 22449] Improve Elastic search facet setting UI In-Reply-To: <bug-22449-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22449-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22449-70-QZfnjWuS2o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22449 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 15:04:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 14:04:48 +0000 Subject: [Koha-bugs] [Bug 22228] Elasticsearch - standalone colons should be escaped when performing a search In-Reply-To: <bug-22228-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22228-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22228-70-8BXWDnCsJG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22228 Bj?rn Nyl?n <bjorn.nylen at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 15:04:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 14:04:51 +0000 Subject: [Koha-bugs] [Bug 22228] Elasticsearch - standalone colons should be escaped when performing a search In-Reply-To: <bug-22228-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22228-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22228-70-C2rCc4SRBR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22228 Bj?rn Nyl?n <bjorn.nylen at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84568|0 |1 is obsolete| | --- Comment #2 from Bj?rn Nyl?n <bjorn.nylen at ub.lu.se> --- Created attachment 85993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85993&action=edit Bug 22228: Escape lone colons and make sure term is balanced Escapes unquoted colons that have whitespace on either side. Removed unbalanced quotes. Test plan: 1. Make sure the test case described in the bug works 2. Make sure tests pass: prove t/Koha/SearchEngine/Elasticsearch/QueryBuilder.t Signed-off-by: Bj?rn Nyl?n <bjorn.nylen(at)ub.lu.se> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 15:13:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 14:13:01 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20447-70-sNYkGuzCdy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85907|0 |1 is obsolete| | --- Comment #94 from Ere Maijala <ere.maijala at helsinki.fi> --- Created attachment 85995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85995&action=edit Bug 20447: Add a batch rebuild script for holdings table. This script can be used to update the columns in the holdings table from the MARC record using the rules in the framework. In practice this will only be required if the koha link field is changed in the framework. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 15:13:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 14:13:06 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20447-70-AHv7ef6AY7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85908|0 |1 is obsolete| | --- Comment #95 from Ere Maijala <ere.maijala at helsinki.fi> --- Created attachment 85996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85996&action=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 15:13:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 14:13:10 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20447-70-UoH2caDsWq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85909|0 |1 is obsolete| | --- Comment #96 from Ere Maijala <ere.maijala at helsinki.fi> --- Created attachment 85997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85997&action=edit Bug 20447: DBIX schema changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 15:12:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 14:12:56 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20447-70-dQC2gtFcu7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85906|0 |1 is obsolete| | --- Comment #93 from Ere Maijala <ere.maijala at helsinki.fi> --- Created attachment 85994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85994&action=edit Bug 20447: MARC Holdings support Enable by setting "SummaryHoldings" option to "Use". Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 15:14:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 14:14:53 +0000 Subject: [Koha-bugs] [Bug 21872] Elasticsearch indexing faster by making it multi-threaded In-Reply-To: <bug-21872-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21872-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21872-70-oXdf4gfqJA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21872 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 --- Comment #51 from Ere Maijala <ere.maijala at helsinki.fi> --- Increasing importance since this can make a huge difference in bigger libraries. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 15:21:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 14:21:39 +0000 Subject: [Koha-bugs] [Bug 21846] Using emoji as tags doesn't discriminate between emoji when calculating weights or searching In-Reply-To: <bug-21846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21846-70-q2KAK01oC2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 --- Comment #40 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Tom?s Cohen Arazi from comment #39) > (In reply to Jonathan Druart from comment #38) > > In my opinion we should fix bug 22420 first. > > No, 22420 won't be fixed if the weights are wrongly calculated, which is > fixed here. IIRC it affects any tags, not only emoji. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 15:21:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 14:21:57 +0000 Subject: [Koha-bugs] [Bug 22413] Elasticsearch - Index title is lost after sorting In-Reply-To: <bug-22413-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22413-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22413-70-n9clYEbYJq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22413 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |ere.maijala at helsinki.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 15:22:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 14:22:26 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20447-70-grNJgw706K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 15:48:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 14:48:39 +0000 Subject: [Koha-bugs] [Bug 18213] Add language facets to Elasticsearch In-Reply-To: <bug-18213-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18213-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18213-70-kQ4glKjnnR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 15:48:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 14:48:42 +0000 Subject: [Koha-bugs] [Bug 18213] Add language facets to Elasticsearch In-Reply-To: <bug-18213-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18213-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18213-70-kS1DgSpGR4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75971|0 |1 is obsolete| | Attachment #75972|0 |1 is obsolete| | Attachment #75973|0 |1 is obsolete| | Attachment #75974|0 |1 is obsolete| | --- Comment #23 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 85998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85998&action=edit Bug 18213: Add language facets to Elasticsearch This patch add language as a facet to ES results - it adds a new template plugin for languages to get the appropriate description given an iso 639-2 code To test: 1 - Make sure you have records with differing languages (in the MARC21 008 field characters 35-37 or UNIMARC 101a) 2 - Apply patch 3 - Reload Elasticsearch settings: http://localhost:8081/cgi-bin/koha/admin/searchengine/elasticsearch/mappings.pl?op=reset&i_know_what_i_am_doing=1 4 - Reindex your records 5 - Search for a phrase that will return results in several languages 6 - Verify you see factes correctly labelled for 'Language' 7 - Verify the facets work 8 - Verify both opac and staff results 9 - prove t/db_dependent/Languages.t Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr> Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 15:48:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 14:48:46 +0000 Subject: [Koha-bugs] [Bug 18213] Add language facets to Elasticsearch In-Reply-To: <bug-18213-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18213-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18213-70-61C0rC65uE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 --- Comment #24 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 85999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85999&action=edit Bug 18213: DB Update (facet order) Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr> Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 15:48:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 14:48:50 +0000 Subject: [Koha-bugs] [Bug 18213] Add language facets to Elasticsearch In-Reply-To: <bug-18213-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18213-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18213-70-0gYV61lJWV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 --- Comment #25 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86000&action=edit Bug 18213: Add Template plugin and fix for C4/Languages Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr> Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 15:48:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 14:48:54 +0000 Subject: [Koha-bugs] [Bug 18213] Add language facets to Elasticsearch In-Reply-To: <bug-18213-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18213-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18213-70-rRxKI6KdB9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 --- Comment #26 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86001&action=edit Bug 18213: (follow-up) Correctly sort facets Previously we sorted alphabetically - that works for 1-9. With a 10th facet category we should sort numerically Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr> Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 15:49:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 14:49:07 +0000 Subject: [Koha-bugs] [Bug 18213] Add language facets to Elasticsearch In-Reply-To: <bug-18213-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18213-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18213-70-POrkmzNWBP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 15:49:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 14:49:31 +0000 Subject: [Koha-bugs] [Bug 22449] Improve Elastic search facet setting UI In-Reply-To: <bug-22449-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22449-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22449-70-UnXlbNeutw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22449 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|18235 |18213 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 [Bug 18213] Add language facets to Elasticsearch https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 [Bug 18235] Elastic search - Configurable facets -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 15:49:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 14:49:31 +0000 Subject: [Koha-bugs] [Bug 18213] Add language facets to Elasticsearch In-Reply-To: <bug-18213-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18213-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18213-70-LlCoTAliWx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22449 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22449 [Bug 22449] Improve Elastic search facet setting UI -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 15:49:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 14:49:31 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18235-70-EfFjO91mqt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22449 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22449 [Bug 22449] Improve Elastic search facet setting UI -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 15:56:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 14:56:40 +0000 Subject: [Koha-bugs] [Bug 21308] Results from order search do not show the search parameters. In-Reply-To: <bug-21308-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21308-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21308-70-Nya7UQIN9I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21308 --- Comment #5 from Josef Moravec <josef.moravec at gmail.com> --- (In reply to Bin from comment #4) > > Signed-off-by: Bin Wen <bin.wen at inlibro.com> Bin, you should also change status of report to "Signed off" when you are signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 15:56:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 14:56:45 +0000 Subject: [Koha-bugs] [Bug 20830] Make sure a fund is selected when ordering from staged file In-Reply-To: <bug-20830-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20830-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20830-70-hErW7bJ042@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20830 --- Comment #5 from Koha Team Lyon 3 <koha at univ-lyon3.fr> --- More precise Test : 1) Add records to a basket from an import batch 2) Select only some of those items in the batch and don't select any fund for them. 3) Save : you get the message "Some budgets are no defined .." 4) Select a fund for each of them 5) click on Save again : you still get the message "Some budgets are no defined .." 6) Apply this patch 7) Redo steps 2,3 and 4 8) Click on Save again : no more message;. The records are imported. Olivier Crouzet -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 16:03:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 15:03:27 +0000 Subject: [Koha-bugs] [Bug 21846] Using emoji as tags doesn't discriminate between emoji when calculating weights or searching In-Reply-To: <bug-21846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21846-70-39QKmnu16D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 --- Comment #41 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- (In reply to Jonathan Druart from comment #40) > (In reply to Tom?s Cohen Arazi from comment #39) > > (In reply to Jonathan Druart from comment #38) > > > In my opinion we should fix bug 22420 first. > > > > No, 22420 won't be fixed if the weights are wrongly calculated, which is > > fixed here. > > IIRC it affects any tags, not only emoji. Yes, what I'm saying is that even though they are both about tags, they aren't really dependent as you propose. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 16:07:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 15:07:49 +0000 Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data In-Reply-To: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20664-70-GAVK61fkEw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 16:07:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 15:07:56 +0000 Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data In-Reply-To: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20664-70-3f53I8zdc4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664 --- Comment #77 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86003&action=edit Bug 20664: Add unit tests for GetMarcItem To test: prove -v t/db_dependent/Items.t Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 16:08:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 15:08:00 +0000 Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data In-Reply-To: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20664-70-vk0rcThNUO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664 --- Comment #78 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86004&action=edit Bug 20664: Unit tests for GetMarcItemFields To test: prove -v t/db_dependent/Items.t Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 16:08:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 15:08:04 +0000 Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data In-Reply-To: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20664-70-OWTMVgWGBP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664 --- Comment #79 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86005&action=edit Bug 20664: (follow-up) Fix test for GetMarcItemFields Without this patch I got this error running the test: YAML Error: Stream does not end with newline character Test plan: prove t/db_dependent/Items.t Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 16:07:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 15:07:52 +0000 Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data In-Reply-To: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20664-70-JD7sUqsoAZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85898|0 |1 is obsolete| | Attachment #85899|0 |1 is obsolete| | Attachment #85900|0 |1 is obsolete| | Attachment #85901|0 |1 is obsolete| | Attachment #85902|0 |1 is obsolete| | Attachment #85903|0 |1 is obsolete| | Attachment #85904|0 |1 is obsolete| | Attachment #85905|0 |1 is obsolete| | --- Comment #76 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86002&action=edit Bug 20664: Optimize retrieval of biblio and item data Optimizes embedding of item data in MARC and fixes several bottlenecks encountered while profiling OAI-PMH and exporting of records. There are two ways this is accomplished: 1.) Create optimized method for fetching item fields for MARC embedding. 2.) Use the cache service more and where repeated calls are made. Test plan: 1.) Before applying the patch, time an export_records.pl run for a set of biblios that also have items. Run it a couple of times to account for initial slowness and possible fluctuations. For example: time misc/export_records.pl --record-type bibs --starting_biblionumber 960000 --ending_biblionumber 965000 --format xml --filename unoptimized.xml 2.) Apply the patch. 3.) Time the export process again with a different output file: time misc/export_records.pl --record-type bibs --starting_biblionumber 960000 --ending_biblionumber 965000 --format xml --filename optimized.xml 4.) Verify that the optimized process is faster. 5.) Compare the resulting export files to make sure they're identical: Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 16:08:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 15:08:09 +0000 Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data In-Reply-To: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20664-70-EuT124WL4h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664 --- Comment #80 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86006&action=edit Bug 20664: (follow-up) Fix QA whitespace errors Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 16:08:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 15:08:12 +0000 Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data In-Reply-To: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20664-70-fGHwxihIMo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664 --- Comment #81 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86007&action=edit Bug 20664: (follow-up) Fix tests on rebase Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 16:08:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 15:08:16 +0000 Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data In-Reply-To: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20664-70-I4cvpMlk8N@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664 --- Comment #82 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86008&action=edit Bug 20664: (follow-up) Switch to Koha objects for retrieving items Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 16:08:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 15:08:20 +0000 Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data In-Reply-To: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20664-70-xvsE08FqgM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664 --- Comment #83 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86009&action=edit Bug 20664: (follow-up) Add tests for UseHidingRulesWithBorrowerCategory Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 16:11:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 15:11:01 +0000 Subject: [Koha-bugs] [Bug 22440] ILL API response objects inconsistent with other endpoints In-Reply-To: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22440-70-aIfF6Ax42v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://wiki.koha-community | |.org/wiki/Illrequests_endpo | |int_RFC -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 16:25:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 15:25:25 +0000 Subject: [Koha-bugs] [Bug 21587] Patrons to notify on receiving doesn't work on new order creation, only on modification In-Reply-To: <bug-21587-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21587-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21587-70-mN0MewD5v6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21587 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #11 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Followup pushed to 17.11.x for 17.11.17 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 16:25:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 15:25:43 +0000 Subject: [Koha-bugs] [Bug 21587] Patrons to notify on receiving doesn't work on new order creation, only on modification In-Reply-To: <bug-21587-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21587-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21587-70-VsmOsACxFL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21587 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 16:25:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 15:25:51 +0000 Subject: [Koha-bugs] [Bug 21587] Patrons to notify on receiving doesn't work on new order creation, only on modification In-Reply-To: <bug-21587-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21587-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21587-70-NuPqfUhs5Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21587 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 16:28:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 15:28:06 +0000 Subject: [Koha-bugs] [Bug 22450] New: Show if due date or return date has been changed from circ rules Message-ID: <bug-22450-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22450 Bug ID: 22450 Summary: Show if due date or return date has been changed from circ rules Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Target Milestone: --- If the SpecifyDueDate or SpecifyReturnDate system preferences are enabled, circulation staff can change due date or return date respectively. Likewise, return date can be altered by the branch calendar. These changes can be very confusing to staff; having some way of displaying the reason that an item was due would alleviate support issues. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 16:46:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 15:46:08 +0000 Subject: [Koha-bugs] [Bug 17050] Accessing the REST API through Plack kicks the session out In-Reply-To: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17050-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17050-70-mjwdESDrCL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17050 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew.isherwood at ptfs-europ | |e.com Status|CLOSED |REOPENED Resolution|FIXED |--- --- Comment #20 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- I've been facing this problem, or something very similar, today. This is on 18.11.03.000 with Plack and memcached enabled and with the SessionRestrictionByIP syspref enabled. I am finding that API requests that require authorisation are causing the session to time out. This manifests itself as the API request returning a 401, with the body {"error":"Session has been expired."}. After doing some digging, the "timeouts" happen because the condition on this line fails: https://github.com/PTFS-Europe/koha/blob/18.11.03/C4/Auth.pm#L912 Specifically, $ip is coming back from the session store as 127.0.0.1 and $ENV{'REMOTE_ADDR'} is the true client IP, so they do not match and the condition fails. So, it seems to me that when the session is created, for some reason 127.0.0.1 is being stored as the remote IP. Doing some research, the "acknowledged" way of ensuring the remote IP passes through an Apache proxy cleanly is: ProxyPreserveHost On However, including this in the Apache config doesn't resolve the problem. Anyone got any ideas? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 16:46:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 15:46:09 +0000 Subject: [Koha-bugs] [Bug 14868] REST API: Swagger2-driven permission checking In-Reply-To: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14868-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14868-70-5YXdKOfnsI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14868 Bug 14868 depends on bug 17050, which changed state. Bug 17050 Summary: Accessing the REST API through Plack kicks the session out https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17050 What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 16:57:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 15:57:59 +0000 Subject: [Koha-bugs] [Bug 22228] Elasticsearch - standalone colons should be escaped when performing a search In-Reply-To: <bug-22228-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22228-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22228-70-q7CdjHXKFD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22228 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 16:58:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 15:58:02 +0000 Subject: [Koha-bugs] [Bug 22228] Elasticsearch - standalone colons should be escaped when performing a search In-Reply-To: <bug-22228-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22228-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22228-70-2MjEkarP0r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22228 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85993|0 |1 is obsolete| | --- Comment #3 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86010&action=edit Bug 22228: Escape lone colons and make sure term is balanced Escapes unquoted colons that have whitespace on either side. Removed unbalanced quotes. Test plan: 1. Make sure the test case described in the bug works 2. Make sure tests pass: prove t/Koha/SearchEngine/Elasticsearch/QueryBuilder.t Signed-off-by: Bj?rn Nyl?n <bjorn.nylen(at)ub.lu.se> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 16:58:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 15:58:09 +0000 Subject: [Koha-bugs] [Bug 22228] Elasticsearch - standalone colons should be escaped when performing a search In-Reply-To: <bug-22228-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22228-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22228-70-YXOsBs4MsI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22228 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |josef.moravec at gmail.com CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 17:19:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 16:19:20 +0000 Subject: [Koha-bugs] [Bug 22446] Koha/Patron/Categories.t is failing on March 1st (2019 only?) In-Reply-To: <bug-22446-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22446-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22446-70-dCDZJR3rJA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22446 --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86011&action=edit Bug 22446: Explicitely list what we expect to avoid ambiguity -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 17:20:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 16:20:04 +0000 Subject: [Koha-bugs] [Bug 22446] Koha/Patron/Categories.t is failing on March 1st (2019 only?) In-Reply-To: <bug-22446-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22446-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22446-70-mwargPEV4b@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22446 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22443 --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- This is a duplicate of bug 22443. However here I suspect a bug in ->get_expiry_date, not a calculation problem in tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 17:20:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 16:20:04 +0000 Subject: [Koha-bugs] [Bug 22443] t/db_dependent/Koha/Patron/Categories.t contains a DateTime maths error In-Reply-To: <bug-22443-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22443-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22443-70-FBrOq90MIZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22443 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22446 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 17:24:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 16:24:14 +0000 Subject: [Koha-bugs] [Bug 21411] Advanced cataloging editor - rancor - Allow configuration of Keyboard shortcuts In-Reply-To: <bug-21411-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21411-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21411-70-iiaHbCNUSi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21411 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85397|0 |1 is obsolete| | Attachment #85398|0 |1 is obsolete| | --- Comment #8 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 86012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86012&action=edit Bug 21411 - Advanced cataloging editor - rancor - Allow configuration of Keyboard This patch allows for redfining the keyboard shortcuts used in rancor. For now these are set globally (per instance) Ctrl-S is a codemirror setting and cannot be altered To test: 1 - Apply patches 2 - update database 3 - Load the advanced cataloging editor 4 - Click the "Keyboard shortcuts" button 5 - Ensure the list looks correct 6 - Note that 'Ctrl-S' note sit cannot be remapped 7 - Note the 'Redefine shortcuts' link at the top of the menu 8 - Confirm all the listed shortcuts work as expected 9 - Click the 'Redefine' link 10 - Ensure current mappings load correctly 11 - Read explanation and verify it makes sense 12 - Remap some functions 13 - Return to the cataloging editor 14 - Confirm your mappings work -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 17:24:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 16:24:16 +0000 Subject: [Koha-bugs] [Bug 21411] Advanced cataloging editor - rancor - Allow configuration of Keyboard shortcuts In-Reply-To: <bug-21411-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21411-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21411-70-ZW0wTFTYoS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21411 --- Comment #9 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 86013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86013&action=edit Bug 21411: DO NOT PUSH - Schema changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 17:41:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 16:41:45 +0000 Subject: [Koha-bugs] [Bug 21411] Advanced cataloging editor - rancor - Allow configuration of Keyboard shortcuts In-Reply-To: <bug-21411-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21411-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21411-70-tHoCcyPmsN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21411 --- Comment #10 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 86014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86014&action=edit Bug 21411: (follow-up) Missing filters and unused variable POD warnings from QA tool are false positives (basic functionsn POD not needed) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 17:43:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 16:43:53 +0000 Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap grid: Catalog In-Reply-To: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21304-70-bgRULpocSe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85980|0 |1 is obsolete| | --- Comment #21 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 86015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86015&action=edit Bug 21304: Update two-column templates with Bootstrap grid: Catalog This patch modifies several catalog templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from <script> tags and "text/css" attributes from <style> tags in the modified templates. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Catalog -> Search - Search results - Bibliographic details - MARC details (viewMARC preference enabled) - Labeled MARC details (viewLabeledMARC preference enabled) - ISBD (viewISBD preference enabled) - Items - Checkout history - Rota (stock rotation) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 17:43:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 16:43:56 +0000 Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap grid: Catalog In-Reply-To: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21304-70-TOL0ZzGwD6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 --- Comment #22 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 86016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86016&action=edit Bug 21304: (follow-up) Fix style of search results browser This follow-up revises the style of the search result browser in the staff client, making it behave better at smaller browser widths. The patch also makes a couple of ESLint-prompted changes to browser.js To test, apply the patch and regenerate CSS. - Perform a catalog search in the staff client. - Click on one of the search results. - On the bibliographic detail page there should be results browsing controls in the left-hand sidebar. - Resize the browser window and confirm that the controls work well at various sizes. - Test with both the first and last search result. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 18:00:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 17:00:15 +0000 Subject: [Koha-bugs] [Bug 21761] Koha::Object supports passing through 'update' which means we can side step 'set' + 'store' In-Reply-To: <bug-21761-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21761-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21761-70-ONQWzZqdWT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21761 --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86017&action=edit Bug 21761: Try to overload Koha::Object->update to handle incorrect values And use default values instead. This is a terrible patch, but publish it to help others having their try. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 18:08:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 17:08:51 +0000 Subject: [Koha-bugs] [Bug 22443] t/db_dependent/Koha/Patron/Categories.t contains a DateTime maths error In-Reply-To: <bug-22443-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22443-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22443-70-uWOkZKPAS7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22443 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Switched to in discussion, see related bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 18:44:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 17:44:01 +0000 Subject: [Koha-bugs] [Bug 21411] Advanced cataloging editor - rancor - Allow configuration of Keyboard shortcuts In-Reply-To: <bug-21411-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21411-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21411-70-KAsmPVsqPN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21411 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 18:44:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 17:44:04 +0000 Subject: [Koha-bugs] [Bug 21411] Advanced cataloging editor - rancor - Allow configuration of Keyboard shortcuts In-Reply-To: <bug-21411-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21411-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21411-70-Tek54sMXF3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21411 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86012|0 |1 is obsolete| | Attachment #86013|0 |1 is obsolete| | Attachment #86014|0 |1 is obsolete| | --- Comment #11 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86018&action=edit Bug 21411 - Advanced cataloging editor - rancor - Allow configuration of Keyboard This patch allows for redfining the keyboard shortcuts used in rancor. For now these are set globally (per instance) Ctrl-S is a codemirror setting and cannot be altered To test: 1 - Apply patches 2 - update database 3 - Load the advanced cataloging editor 4 - Click the "Keyboard shortcuts" button 5 - Ensure the list looks correct 6 - Note that 'Ctrl-S' note sit cannot be remapped 7 - Note the 'Redefine shortcuts' link at the top of the menu 8 - Confirm all the listed shortcuts work as expected 9 - Click the 'Redefine' link 10 - Ensure current mappings load correctly 11 - Read explanation and verify it makes sense 12 - Remap some functions 13 - Return to the cataloging editor 14 - Confirm your mappings work Signed-off-by: Liz Rea <liz at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 18:44:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 17:44:07 +0000 Subject: [Koha-bugs] [Bug 21411] Advanced cataloging editor - rancor - Allow configuration of Keyboard shortcuts In-Reply-To: <bug-21411-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21411-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21411-70-FNqKvl3TRV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21411 --- Comment #12 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86019&action=edit Bug 21411: DO NOT PUSH - Schema changes Signed-off-by: Liz Rea <liz at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 18:44:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 17:44:10 +0000 Subject: [Koha-bugs] [Bug 21411] Advanced cataloging editor - rancor - Allow configuration of Keyboard shortcuts In-Reply-To: <bug-21411-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21411-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21411-70-6R3PDr92nH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21411 --- Comment #13 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86020&action=edit Bug 21411: (follow-up) Missing filters and unused variable POD warnings from QA tool are false positives (basic functionsn POD not needed) Signed-off-by: Liz Rea <liz at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 18:50:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 17:50:21 +0000 Subject: [Koha-bugs] [Bug 21411] Advanced cataloging editor - rancor - Allow configuration of Keyboard shortcuts In-Reply-To: <bug-21411-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21411-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21411-70-44mzoI5des@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21411 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #14 from Liz Rea <wizzyrea at gmail.com> --- I've got a bad git email address hiding out somewhere in my git config, so sorry if those look like my old email address at Catalyst. I'm still signing off and if you're inclined you can change them to wizzyrea at gmail.com. I don't want to clutter the bug by fixing it but I'll fix it before I do my next one. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 18:52:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 17:52:55 +0000 Subject: [Koha-bugs] [Bug 22442] Item search CSV export broken In-Reply-To: <bug-22442-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22442-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22442-70-XRGnNBQxgb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22442 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 18:53:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 17:53:03 +0000 Subject: [Koha-bugs] [Bug 22442] Item search CSV export broken In-Reply-To: <bug-22442-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22442-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22442-70-xky8U3gZDL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22442 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86021&action=edit Bug 22442: (bug 13618 follow-up) Fix item search CSV export We must not filter assignements statements. Test plan: Export item search result as CSV Without this patch the biblio and biblioitem values are not displayed. With this patch applied everything is displayed correctly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 18:53:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 17:53:22 +0000 Subject: [Koha-bugs] [Bug 22442] Item search CSV export broken In-Reply-To: <bug-22442-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22442-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22442-70-KXKJZyINtY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22442 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13618 Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 [Bug 13618] Add additional template filter methods and a filter presence test to Koha -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 18:53:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 17:53:22 +0000 Subject: [Koha-bugs] [Bug 13618] Add additional template filter methods and a filter presence test to Koha In-Reply-To: <bug-13618-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13618-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13618-70-zymjQO5eX2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22442 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22442 [Bug 22442] Item search CSV export broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 19:03:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 18:03:19 +0000 Subject: [Koha-bugs] [Bug 15504] Track Patron's Last Activity In-Reply-To: <bug-15504-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15504-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15504-70-PvaGZwaDKi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15504 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Indeed, you are right. The description of bug 16276 says: """ We would like to automate the delation of expired patrons to comply to french laws regarding privacy. But we don't want to delate an expired patron which is still using the OPAC for bibliographical purpose, like managing lists. We would like to be able to say when the patron logged himself for the last time to permit this. """ It could be renamed last_login to avoid ambiguity. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 19:25:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 18:25:37 +0000 Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve aliased fields In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19575-70-Xpz5clbI4W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575 --- Comment #93 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Nick Clemens from comment #92) Talked with Ere, he verified these make sense -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 19:33:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 18:33:58 +0000 Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap grid: Catalog In-Reply-To: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21304-70-u5VyHElrYM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 19:34:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 18:34:01 +0000 Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap grid: Catalog In-Reply-To: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21304-70-QAsk6cj1ux@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86015|0 |1 is obsolete| | Attachment #86016|0 |1 is obsolete| | --- Comment #23 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86022&action=edit Bug 21304: Update two-column templates with Bootstrap grid: Catalog This patch modifies several catalog templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from <script> tags and "text/css" attributes from <style> tags in the modified templates. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Catalog -> Search - Search results - Bibliographic details - MARC details (viewMARC preference enabled) - Labeled MARC details (viewLabeledMARC preference enabled) - ISBD (viewISBD preference enabled) - Items - Checkout history - Rota (stock rotation) Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 19:34:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 18:34:04 +0000 Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap grid: Catalog In-Reply-To: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21304-70-ncc20xTXxg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 --- Comment #24 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86023&action=edit Bug 21304: (follow-up) Fix style of search results browser This follow-up revises the style of the search result browser in the staff client, making it behave better at smaller browser widths. The patch also makes a couple of ESLint-prompted changes to browser.js To test, apply the patch and regenerate CSS. - Perform a catalog search in the staff client. - Click on one of the search results. - On the bibliographic detail page there should be results browsing controls in the left-hand sidebar. - Resize the browser window and confirm that the controls work well at various sizes. - Test with both the first and last search result. Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 19:34:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 18:34:41 +0000 Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve aliased fields In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19575-70-vtM2LwwAIB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patchset makes some release notes| |changes to Elasticsearch | |mappings in the database. | |The changes alter existing | |indices and are intended to | |fix issues with the current | |mappings, however, if you | |have done customization of | |mappings you may want to | |back them up before | |upgrading. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 19:42:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 18:42:06 +0000 Subject: [Koha-bugs] [Bug 19046] IntranetCatalogSearchPulldown doesn't retain last selection In-Reply-To: <bug-19046-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19046-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19046-70-nDQKyFlMP0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19046 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 19:42:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 18:42:18 +0000 Subject: [Koha-bugs] [Bug 19046] IntranetCatalogSearchPulldown doesn't retain last selection In-Reply-To: <bug-19046-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19046-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19046-70-JLKtINaGHp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19046 --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86024&action=edit Bug 19046: Make seach pulldown to retain index selection This patch also fixes add the term in the search input Test plan: Enable IntranetCatalogSearchPulldown Search for a term using the search input in the header (simple search) Re-do selecting different indices The selection must retain on the search result page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 19:42:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 18:42:28 +0000 Subject: [Koha-bugs] [Bug 19046] IntranetCatalogSearchPulldown doesn't retain last selection In-Reply-To: <bug-19046-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19046-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19046-70-vo2zIRLc0J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19046 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 19:44:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 18:44:12 +0000 Subject: [Koha-bugs] [Bug 17496] install-CPAN.pl documentation/removal In-Reply-To: <bug-17496-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17496-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17496-70-3HaSfgR0mw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17496 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- Leaving this open for a week in case any one cares to comment, then will push -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 19:47:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 18:47:25 +0000 Subject: [Koha-bugs] [Bug 20649] C4::Auth should use C4::Context->IsSuperLibrarian() In-Reply-To: <bug-20649-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20649-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20649-70-Ua7YB9uLKx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20649 --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #4) > Sorry, Jonathan, I don't understand yet. Maybe we can take a look at it > together sometime? Scratch comment 2, we could replace it instead. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 19:49:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 18:49:19 +0000 Subject: [Koha-bugs] [Bug 22370] OPAC users should not be allowed to view staff news items In-Reply-To: <bug-22370-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22370-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22370-70-MaVZN7JB0f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22370 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 19:49:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 18:49:30 +0000 Subject: [Koha-bugs] [Bug 22360] On order information missing in OPAC normal display In-Reply-To: <bug-22360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22360-70-EbRTyijFWQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22360 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #13 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 19:49:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 18:49:44 +0000 Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve aliased fields In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19575-70-6bEIuVB8LJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #94 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 19:49:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 18:49:55 +0000 Subject: [Koha-bugs] [Bug 22228] Elasticsearch - standalone colons should be escaped when performing a search In-Reply-To: <bug-22228-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22228-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22228-70-gMvxl4CTJI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22228 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 19:50:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 18:50:32 +0000 Subject: [Koha-bugs] [Bug 22246] Elasticsearch indexing needs a maximum length for __sort fields In-Reply-To: <bug-22246-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22246-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22246-70-qSJBmKjtjC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22246 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |nick at bywatersolutions.com --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- Please rebase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 19:50:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 18:50:54 +0000 Subject: [Koha-bugs] [Bug 22404] Some labels in subscription add form has wrong parameter "for" In-Reply-To: <bug-22404-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22404-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22404-70-cbjDY34dq0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22404 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 19:51:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 18:51:07 +0000 Subject: [Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces In-Reply-To: <bug-18584-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18584-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18584-70-8ZiqPiZNHU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #43 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 19:51:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 18:51:29 +0000 Subject: [Koha-bugs] [Bug 22451] New: Asset plugin is using the version from the DB Message-ID: <bug-22451-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22451 Bug ID: 22451 Summary: Asset plugin is using the version from the DB Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Should not be retrieved with Koha::Version? See bug 20658 comment 13. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 19:51:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 18:51:29 +0000 Subject: [Koha-bugs] [Bug 20658] Move template JavaScript to the footer: Installer and onboarding In-Reply-To: <bug-20658-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20658-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20658-70-H5lBUYqha0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22451 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 19:52:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 18:52:05 +0000 Subject: [Koha-bugs] [Bug 20658] Move template JavaScript to the footer: Installer and onboarding In-Reply-To: <bug-20658-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20658-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20658-70-uOIKwkBH86@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Pushed for QA --- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Opened bug 22451 and switched back to PQA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 19:52:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 18:52:15 +0000 Subject: [Koha-bugs] [Bug 20658] Move template JavaScript to the footer: Installer and onboarding In-Reply-To: <bug-20658-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20658-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20658-70-Odr72b3JSk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed for QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 19:53:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 18:53:14 +0000 Subject: [Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces In-Reply-To: <bug-18584-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18584-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18584-70-jzkurdo1f7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|hayleymapley at catalyst.net.n |koha-bugs at lists.koha-commun |z |ity.org Status|Pushed to Master |ASSIGNED --- Comment #44 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Resetting to New. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 19:53:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 18:53:24 +0000 Subject: [Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces In-Reply-To: <bug-18584-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18584-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18584-70-b5eBw5jIzn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 19:53:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 18:53:37 +0000 Subject: [Koha-bugs] [Bug 18584] Our legacy code contains trailing-spaces In-Reply-To: <bug-18584-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18584-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18584-70-LQ0ssBhydf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18584 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85968|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 19:55:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 18:55:11 +0000 Subject: [Koha-bugs] [Bug 17179] Advanced editor: Add keyboard shortcuts to repeat (duplicate) a field, and cut text In-Reply-To: <bug-17179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17179-70-ryMPRld3Ui@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67817|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 19:55:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 18:55:34 +0000 Subject: [Koha-bugs] [Bug 17179] Advanced editor: Add keyboard shortcuts to repeat (duplicate) a field, and cut text In-Reply-To: <bug-17179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17179-70-J7GEgMPHVa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68675|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 20:00:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 19:00:50 +0000 Subject: [Koha-bugs] [Bug 17179] Advanced editor: Add keyboard shortcuts to repeat (duplicate) a field, and cut text In-Reply-To: <bug-17179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17179-70-J318VVxmYO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85396|0 |1 is obsolete| | --- Comment #8 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 86025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86025&action=edit Bug 17179: Add keyboard shortcuts to repeat (duplicate) a field, and cut text This patchset introduces an internal clipboard to the advanced editor and provides some new functionality to make use of this, default shortcuts are provided but can be edited per bug 21411 The default shortcuts for new/changed functions are: Changed: Ctrl-X: Now cuts a line into the clipboard area Shift-Ctrl-X: Now cuts current subfield into clipboard area Added: Ctrl-C: Copies a line into the clipboard area Shift-Ctrl-C: Copies current subfield into clipboard area Ctrl-P: Pastes the selected item from the clipboard at cursor Ctrl-I: Copies the current line and inserts onto a new line below To test: Verify all functionality above and confirm it behaves as expected Note: Ctrl-v pastes from the system clipboard - codemirror does not have access and this is why we use our "Clipboard" For browser cut/paste please use mouse right click or context menus Ctrl-P can be accessed as print by focusing outside the editor window -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 20:04:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 19:04:46 +0000 Subject: [Koha-bugs] [Bug 22442] Item search CSV export broken In-Reply-To: <bug-22442-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22442-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22442-70-d0pD4ucu7A@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22442 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86021|0 |1 is obsolete| | --- Comment #2 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86026&action=edit Bug 22442: (bug 13618 follow-up) Fix item search CSV export We must not filter assignements statements. Test plan: Export item search result as CSV Without this patch the biblio and biblioitem values are not displayed. With this patch applied everything is displayed correctly Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 20:05:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 19:05:03 +0000 Subject: [Koha-bugs] [Bug 22442] Item search CSV export broken In-Reply-To: <bug-22442-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22442-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22442-70-zpgeYW2PIp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22442 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 20:07:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 19:07:43 +0000 Subject: [Koha-bugs] [Bug 22390] When duplicating existing order lines new items are not created In-Reply-To: <bug-22390-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22390-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22390-70-nnDqbiAO1V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22390 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 20:07:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 19:07:50 +0000 Subject: [Koha-bugs] [Bug 22390] When duplicating existing order lines new items are not created In-Reply-To: <bug-22390-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22390-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22390-70-Yr2KiRNQnL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22390 --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86027&action=edit Bug 22390: Never copy items if original order has been created from a subscription -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 20:15:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 19:15:39 +0000 Subject: [Koha-bugs] [Bug 22025] Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018 for /usr/share/koha/bin/import_patrons.pl In-Reply-To: <bug-22025-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22025-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22025-70-CzZ6Jl5uUp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22025 --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I do not recreate against master, can you share an example file? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 20:17:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 19:17:46 +0000 Subject: [Koha-bugs] [Bug 22025] Argument "" isn't numeric in numeric eq (==) at /usr/share/perl5/DBIx/Class/Row.pm line 1018 for /usr/share/koha/bin/import_patrons.pl In-Reply-To: <bug-22025-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22025-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22025-70-baOiwYuvZK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22025 --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I would expect the warnings to appear if you are doing an update, not an insert. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 20:23:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 19:23:15 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18823-70-NPNV21sROo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Cori Lynn Arnold <carnold at dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #65 from Cori Lynn Arnold <carnold at dgiinc.com> --- Can't search the import batch I just created and added two records to. Steps to reproduce: 1. Create a new import batch (Settings->Import batches...) called "New Batch" 2. Make "New Batch" searchable and a save target https://paste.pics/300ea164128d55e87c65652f1abd6223 3. Create 2 records. One with 001 as faw00012345, the other with 001 as faw00054321 ; 245 as "Penultimate Test" for one, "Antonomasia Test" for the other. Save both to "New Batch" import batch. 4. Search using the left hand search area for "Penultimate Test" in keywords Expected: "New Batch" is listed as a searchable target. Result: "New Batch" is not listed as a searchable target. https://paste.pics/33d5257511e53ee1d46722c1b1a8cece -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 20:24:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 19:24:18 +0000 Subject: [Koha-bugs] [Bug 21720] Update C4::Circulation::AddIssuingCharge to use Koha::Account->add_debit In-Reply-To: <bug-21720-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21720-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21720-70-AtfDP6wogJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21720 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #12 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 20:24:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 19:24:26 +0000 Subject: [Koha-bugs] [Bug 21728] Update C4::Reserves::ChargeReserveFee to use Koha::Account->add_debit In-Reply-To: <bug-21728-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21728-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21728-70-Vd5Qlaz4TZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21728 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #13 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 20:24:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 19:24:33 +0000 Subject: [Koha-bugs] [Bug 21722] Update C4::Accounts::chargelostitem to use Koha::Account->add_debit In-Reply-To: <bug-21722-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21722-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21722-70-w1aFK22Uc4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #19 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 20:25:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 19:25:44 +0000 Subject: [Koha-bugs] [Bug 21721] Update C4::Circulation::AddRenewal to use Koha::Account->add_debit In-Reply-To: <bug-21721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21721-70-t6vCNQVAAd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21721 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Patch doesn't apply --- Comment #7 from Nick Clemens <nick at bywatersolutions.com> --- Dependencies pushed to master, yet: error: sha1 information is lacking or useless (C4/Circulation.pm). error: could not build fake ancestor Patch failed at 0001 Bug 21721: Use Koha::Account->add_debit in AddRenewal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 20:26:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 19:26:04 +0000 Subject: [Koha-bugs] [Bug 22442] Item search CSV export broken In-Reply-To: <bug-22442-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22442-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22442-70-2kWU9LzVx3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22442 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 20:26:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 19:26:20 +0000 Subject: [Koha-bugs] [Bug 22237] Subscriptions are not linked to Mana upon edit In-Reply-To: <bug-22237-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22237-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22237-70-dKwBK8pG1L@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22237 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84533|0 |1 is obsolete| | --- Comment #2 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86028&action=edit Bug 22237: Subscriptions are not linked to Mana upon edit This patch modifies C4/Serials.pm so that during the process of editing a subscription a link to Mana can be created. To test, apply the patch and go to Serials. - Locate a subscription which was not created using Mana data but which can be found in Mana. - Edit the subscription, skipping to the second page. - View the results returned by Mana and select one. - Save the subscription. - Upon being redirected to the subscription detail page you should see a "Report mistake" button. This shows that the subscription has been linked to Mana successfully. Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 20:26:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 19:26:36 +0000 Subject: [Koha-bugs] [Bug 22237] Subscriptions are not linked to Mana upon edit In-Reply-To: <bug-22237-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22237-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22237-70-q0zXEhbNCk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22237 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 20:29:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 19:29:49 +0000 Subject: [Koha-bugs] [Bug 22452] New: 'Caracters' is typo Message-ID: <bug-22452-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22452 Bug ID: 22452 Summary: 'Caracters' is typo Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: josef.moravec at gmail.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- in mana related templates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 20:29:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 19:29:58 +0000 Subject: [Koha-bugs] [Bug 17643] The bug 3333 breaks intranet search results in column Location In-Reply-To: <bug-17643-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17643-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17643-70-EOn2zH45cX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17643 --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I do not recreate: 1. Setting NOT_LOAN=1 to "XXXXXXXXXXXXX" MariaDB [koha_kohadev]> select * from authorised_values where category="NOT_LOAN"; +----+----------+------------------+------------------+----------+----------+ | id | category | authorised_value | lib | lib_opac | imageurl | +----+----------+------------------+------------------+----------+----------+ | 32 | NOT_LOAN | -1 | Ordered | NULL | NULL | | 33 | NOT_LOAN | 1 | XXXXXXXXXXXXX | NULL | | | 34 | NOT_LOAN | 2 | Staff Collection | NULL | NULL | +----+----------+------------------+------------------+----------+----------+ 3 rows in set (0.00 sec) 2. Setting Computer file as not for loan MariaDB [koha_kohadev]> select notforloan from itemtypes where itemtype="CF"; +------------+ | notforloan | +------------+ | 1 | +------------+ 3. Set this itemtype for a given item: MariaDB [koha_kohadev]> select itype from items where biblionumber=4; +-------+ | itype | +-------+ | CF | | BK | | BK | | BK | +-------+ I see: https://snag.gy/YojeUb.jpg -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 20:30:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 19:30:07 +0000 Subject: [Koha-bugs] [Bug 22452] 'Caracters' is typo In-Reply-To: <bug-22452-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22452-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22452-70-CS8CSXrqDQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22452 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |josef.moravec at gmail.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 20:35:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 19:35:38 +0000 Subject: [Koha-bugs] [Bug 22452] 'Caracters' is typo In-Reply-To: <bug-22452-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22452-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22452-70-GiZ0URE45a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22452 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 20:35:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 19:35:42 +0000 Subject: [Koha-bugs] [Bug 22452] 'Caracters' is typo In-Reply-To: <bug-22452-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22452-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22452-70-ENrvMQY0sS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22452 --- Comment #1 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86029&action=edit Bug 22452: Fix typo caracters -> characters There is typo in modal where you can add a comment to mana Test plan: 1) Create subscription from Mana 2) On subscription detail page: report mistake > other a modal is shown --> without patch it reads 'Please enter a new commment (max 35 caracters)' --> with patch it reads 'Please enter a new commment (max 35 characters)' 3) The same in mana search resultss and in reports -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 20:59:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 19:59:46 +0000 Subject: [Koha-bugs] [Bug 22219] C4::Biblio->GetItemsForInventory can return wrong count / duplicated items when skipping waiting holds In-Reply-To: <bug-22219-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22219-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22219-70-wXPqzHQ2u6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22219 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 20:59:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 19:59:55 +0000 Subject: [Koha-bugs] [Bug 22219] C4::Biblio->GetItemsForInventory can return wrong count / duplicated items when skipping waiting holds In-Reply-To: <bug-22219-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22219-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22219-70-6ZnFbxFZ8Q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22219 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86030&action=edit Bug 22219: Add tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 21:00:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 20:00:02 +0000 Subject: [Koha-bugs] [Bug 22219] C4::Biblio->GetItemsForInventory can return wrong count / duplicated items when skipping waiting holds In-Reply-To: <bug-22219-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22219-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22219-70-bzZnMNJa8P@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22219 --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86031&action=edit Bug 22219: Remove duplicated items in inventory (when skipping waiting holds) Test plan: 0/ Do not apply this patch 1/ Place several holds on a given item 2/ Use the inventory with the "skip waiting holds" option to list this item. It will be displayed several times 3/ Apply this patch and confirm that the item is now only displayed once -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 21:00:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 20:00:25 +0000 Subject: [Koha-bugs] [Bug 22219] C4::Biblio->GetItemsForInventory can return wrong count / duplicated items when skipping waiting holds In-Reply-To: <bug-22219-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22219-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22219-70-oZ8DHueXnc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22219 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 21:13:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 20:13:25 +0000 Subject: [Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2 In-Reply-To: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17140-70-N60r4AUPu3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #29 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- (In reply to Blou from comment #28) > Hi Hayley, > Have you tried applying only 83467 (the last one), which is separated from > the others (see my previous comments)? Or maybe its solution is not what > you're looking for... Hi Blou, My bad! I missed your comment. Will try to sign off today. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 21:27:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 20:27:01 +0000 Subject: [Koha-bugs] [Bug 21728] Update C4::Reserves::ChargeReserveFee to use Koha::Account->add_debit In-Reply-To: <bug-21728-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21728-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21728-70-54SfDJMuBH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21728 --- Comment #14 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 86032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86032&action=edit Bug 21728: (RM follow-up) Add 'Reserve Fee' for new installs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 21:36:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 20:36:09 +0000 Subject: [Koha-bugs] [Bug 19417] Improve display of errors from background job during stage for import In-Reply-To: <bug-19417-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19417-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19417-70-8aFgt7WRH9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19417 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 21:36:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 20:36:11 +0000 Subject: [Koha-bugs] [Bug 22451] Asset plugin is using the version from the DB In-Reply-To: <bug-22451-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22451-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22451-70-J1UHitrZMN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22451 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 21:36:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 20:36:11 +0000 Subject: [Koha-bugs] [Bug 19417] Improve display of errors from background job during stage for import In-Reply-To: <bug-19417-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19417-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19417-70-ZgAJWEmr04@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19417 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85367|0 |1 is obsolete| | --- Comment #7 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86033&action=edit Bug 19417 - Display full error text when problem importing records To test: 1 - Upload a file to stage 2 - Select your import options 3 - Delete the file from the server, example: sudo rm /tmp/koha_kohadev_uploads/ 4 - 'Click stage for import' 5 - Get an alert 'Failed to submit form: error' 6 - Apply patches 7 - Repeat 1-4 8 - Get a pretty error with additional info -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 21:36:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 20:36:14 +0000 Subject: [Koha-bugs] [Bug 22451] Asset plugin is using the version from the DB In-Reply-To: <bug-22451-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22451-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22451-70-gJucAWyvdk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22451 --- Comment #1 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86034&action=edit Bug 22451: Make Asset plugin use Koha::version instead of version from db Test plan: Apply the patch a try to use Koha, css and js files should be used normally -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 21:36:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 20:36:18 +0000 Subject: [Koha-bugs] [Bug 22451] Asset plugin is using the version from the DB In-Reply-To: <bug-22451-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22451-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22451-70-ciaZUHrwna@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22451 --- Comment #2 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86035&action=edit Bug 22451: Update test Test plan: prove t/db_dependent/Koha/Template/Plugin/Asset.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 21:36:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 20:36:22 +0000 Subject: [Koha-bugs] [Bug 22451] Asset plugin is using the version from the DB In-Reply-To: <bug-22451-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22451-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22451-70-wd7JCSfEOl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22451 --- Comment #3 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86036&action=edit Bug 22451: Use Asset everywhere Test plan: Use installer and onboaarding tool, make sure the js and css files are loaded -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 21:36:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 20:36:52 +0000 Subject: [Koha-bugs] [Bug 19417] Improve display of errors from background job during stage for import In-Reply-To: <bug-19417-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19417-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19417-70-hcnnZApi9q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19417 --- Comment #8 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86037&action=edit Bug 19417 - Make error just a wee more human Small follow up to make the text explicitly say "Import of records failed" instead of "Failed to submit form" Users don't even know that they're submitting a form, what they think they're doing is uploading records. Let's use their words instead of developer words. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 21:36:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 20:36:54 +0000 Subject: [Koha-bugs] [Bug 22451] Asset plugin is using the version from the DB In-Reply-To: <bug-22451-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22451-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22451-70-zcKfh2gYGo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22451 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Assignee|koha-bugs at lists.koha-commun |josef.moravec at gmail.com |ity.org | Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 21:38:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 20:38:40 +0000 Subject: [Koha-bugs] [Bug 19417] Improve display of errors from background job during stage for import In-Reply-To: <bug-19417-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19417-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19417-70-uNohtwhMk6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19417 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com Attachment #86033|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 21:38:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 20:38:56 +0000 Subject: [Koha-bugs] [Bug 19417] Improve display of errors from background job during stage for import In-Reply-To: <bug-19417-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19417-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19417-70-WHYCqA6PPd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19417 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86037|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 21:39:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 20:39:50 +0000 Subject: [Koha-bugs] [Bug 19417] Improve display of errors from background job during stage for import In-Reply-To: <bug-19417-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19417-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19417-70-m0T5dIrBxT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19417 --- Comment #9 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86038&action=edit Bug 19417 - Display full error text when problem importing records To test: 1 - Upload a file to stage 2 - Select your import options 3 - Delete the file from the server, example: sudo rm /tmp/koha_kohadev_uploads/ 4 - 'Click stage for import' 5 - Get an alert 'Failed to submit form: error' 6 - Apply patches 7 - Repeat 1-4 8 - Get a pretty error with additional info Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 21:40:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 20:40:10 +0000 Subject: [Koha-bugs] [Bug 19417] Improve display of errors from background job during stage for import In-Reply-To: <bug-19417-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19417-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19417-70-LSWka0Dn7E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19417 --- Comment #10 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86039&action=edit Bug 19417 - Make error just a wee more human Small follow up to make the text explicitly say "Import of records failed" instead of "Failed to submit form" Users don't even know that they're submitting a form, what they think they're doing is uploading records. Let's use their words instead of developer words. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 22:12:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 21:12:04 +0000 Subject: [Koha-bugs] [Bug 22453] New: TestBuilder should generate now() using the current timezone Message-ID: <bug-22453-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22453 Bug ID: 22453 Summary: TestBuilder should generate now() using the current timezone Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Target Milestone: --- I have no idea why this only appears today but TestBuilder generates dates using DateTime->now, which does not take into account the timezone. It has been highlights by a failing test today on U18. Why today whereas this patch was pushed few weeks ago? Why U18 and not D9? The output of the test is: koha_1 | # Failed test 'With BorrowerLogs and TrackLastPatronActivity we should not spam the logs' koha_1 | # at t/db_dependent/Koha/Patrons.t line 1421. koha_1 | # got: '2' koha_1 | # expected: '1' koha_1 | # Looks like you failed 1 test of 4. koha_1 | koha_1 | # Failed test 'BorrowersLog tests' koha_1 | # at t/db_dependent/Koha/Patrons.t line 1422. koha_1 | # Looks like you failed 1 test of 33. koha_1 | [19:51:44] t/db_dependent/Koha/Patrons.t Actually there are 2 logs, one for the cardnumber that is expected, and on for updated_on: "updated_on" : { "after" : "2019-03-04 21:10:00", "before" : "2019-03-04 18:10:00" } Apart from the fact that we may want to remove this updated_on field from MODIFY, the before/after dates differ from 3 hours. Here it's currently 18:10 and in UTC-3 To prevent such behaviors in tests (create stuffs in the future...), we should use our Koha::DateUtils::dt_from_string method that takes care of the timezone used in other places of Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 22:14:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 21:14:37 +0000 Subject: [Koha-bugs] [Bug 22453] TestBuilder should generate now() using the current timezone In-Reply-To: <bug-22453-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22453-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22453-70-oCMV7lnQh9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22453 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 22:14:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 21:14:50 +0000 Subject: [Koha-bugs] [Bug 22453] TestBuilder should generate now() using the current timezone In-Reply-To: <bug-22453-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22453-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22453-70-amON0wD4W1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22453 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86040&action=edit Bug 22453: Make TestBuilder generates dates taking into account the timezone I have no idea why this only appears today but TestBuilder generates dates using DateTime->now, which does not take into account the timezone. It has been highlights by a failing test today on U18. Why today whereas this patch was pushed few weeks ago? Why U18 and not D9? The output of the test is: koha_1 | # Failed test 'With BorrowerLogs and TrackLastPatronActivity we should not spam the logs' koha_1 | # at t/db_dependent/Koha/Patrons.t line 1421. koha_1 | # got: '2' koha_1 | # expected: '1' koha_1 | # Looks like you failed 1 test of 4. koha_1 | koha_1 | # Failed test 'BorrowersLog tests' koha_1 | # at t/db_dependent/Koha/Patrons.t line 1422. koha_1 | # Looks like you failed 1 test of 33. koha_1 | [19:51:44] t/db_dependent/Koha/Patrons.t Actually there are 2 logs, one for the cardnumber that is expected, and on for updated_on: "updated_on" : { "after" : "2019-03-04 21:10:00", "before" : "2019-03-04 18:10:00" } Apart from the fact that we may want to remove this updated_on field from MODIFY, the before/after dates differ from 3 hours. Here it's currently 18:10 and in UTC-3 To prevent such behaviors in tests (create stuffs in the future...), we should use our Koha::DateUtils::dt_from_string method that takes care of the timezone used in other places of Koha. Test plan: prove t/db_dependent/Koha/Patrons.t May fail without this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 22:18:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 21:18:47 +0000 Subject: [Koha-bugs] [Bug 17179] Advanced editor: Add keyboard shortcuts to repeat (duplicate) a field, and cut text In-Reply-To: <bug-17179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17179-70-b3ZqH8DzkM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86025|0 |1 is obsolete| | --- Comment #9 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 86041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86041&action=edit Bug 17179: Add keyboard shortcuts to repeat (duplicate) a field, and cut text This patchset introduces an internal clipboard to the advanced editor and provides some new functionality to make use of this, default shortcuts are provided but can be edited per bug 21411 The default shortcuts for new/changed functions are: Changed: Ctrl-X: Now cuts a line into the clipboard area Shift-Ctrl-X: Now cuts current subfield into clipboard area Added: Ctrl-C: Copies a line into the clipboard area Shift-Ctrl-C: Copies current subfield into clipboard area Ctrl-P: Pastes the selected item from the clipboard at cursor Ctrl-I: Copies the current line and inserts onto a new line below To test: Verify all functionality above and confirm it behaves as expected Note: Ctrl-v pastes from the system clipboard - codemirror does not have access and this is why we use our "Clipboard" For browser cut/paste please use mouse right click or context menus Ctrl-P can be accessed as print by focusing outside the editor window -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 22:20:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 21:20:01 +0000 Subject: [Koha-bugs] [Bug 22436] add move or copy control field from or to subfield in MARC modification templates In-Reply-To: <bug-22436-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22436-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22436-70-MW6uQSt0z3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22436 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 22:22:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 21:22:42 +0000 Subject: [Koha-bugs] [Bug 19417] Improve display of errors from background job during stage for import In-Reply-To: <bug-19417-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19417-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19417-70-Jjci2vTvRY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19417 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86039|0 |1 is obsolete| | --- Comment #11 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Created attachment 86042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86042&action=edit Bug 19417 - Make error just a wee more human Small follow up to make the text explicitly say "Import of records failed" instead of "Failed to submit form" Users don't even know that they're submitting a form, what they think they're doing is uploading records. Let's use their words instead of developer words. Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 22:33:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 21:33:20 +0000 Subject: [Koha-bugs] [Bug 22300] Staff search results: Opt groups in 'sort' pull down are not well formatted In-Reply-To: <bug-22300-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22300-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22300-70-tUDehTAlpi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22300 --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- This could also be seen as a regression to previous versions (bug fix vs. enh) - see first comment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 22:41:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 21:41:22 +0000 Subject: [Koha-bugs] [Bug 22222] Mana subscription search always returns all results In-Reply-To: <bug-22222-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22222-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22222-70-p4XV84Z5qK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22222 --- Comment #1 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86043&action=edit Bug 22222: Don't send empty params to mana service Test plan: 0) Do not apply the patch 1) Go to serials > Search on Mana 2) Insert some value into the form 3) Submit -> you get many (3000+) results 4) Apply the patch and restart_all 5) Repeat, now, you get only the subscription matching your query -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 22:41:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 21:41:50 +0000 Subject: [Koha-bugs] [Bug 22222] Mana subscription search always returns all results In-Reply-To: <bug-22222-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22222-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22222-70-OgNlCM47p5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22222 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|alex.arnaud at biblibre.com |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 22:42:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 21:42:25 +0000 Subject: [Koha-bugs] [Bug 22249] Error when submitting Mana comment In-Reply-To: <bug-22249-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22249-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22249-70-cBx9vmx2f0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22249 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 22:48:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 21:48:31 +0000 Subject: [Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2 In-Reply-To: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17140-70-75olpPxeAW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 22:48:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 21:48:36 +0000 Subject: [Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2 In-Reply-To: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17140-70-RtyTz5uzvj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83467|0 |1 is obsolete| | --- Comment #30 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Created attachment 86044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86044&action=edit Bug 17140: fix rounding errors when paying fines Whenever a fine (accountlines in DB) has a precision longer than two floating points, it becomes very hard for a user to clear it. Ex: 1.035 will be displayed as 1.04 or 1.03 depending on the screen. But entering any of those value in Pay Fine will not clear it. The user has no way to know the exact value to enter. This fix makes sure that the intent of the user is met, by matching the EXACT needed sum when the difference is less than 0.01. TEST 1) Create a 1.035 fine - Go to a Patron screen - Fines tab on the left - Create manual invoice 2) go to Pay fines, click Pay amount on bottom left. 3) It will show 1.03 as Total, and as Collect from patron. Click confirm. 4) An error message will appear. 5) Apply patch, do again. Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 23:33:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 22:33:04 +0000 Subject: [Koha-bugs] [Bug 22140] More use of EasyAnalyticalRecords pref In-Reply-To: <bug-22140-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22140-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22140-70-2fZEFNR3pZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22140 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #22 from Lucas Gass <lucas at bywatersolutions.com> --- cant cleanly apply this to 18.05.x. If needed please rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 23:41:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 22:41:26 +0000 Subject: [Koha-bugs] [Bug 22067] Koha::Patron->can_see_patron_infos should return if no patron is passed In-Reply-To: <bug-22067-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22067-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22067-70-Tpwc67sDVK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22067 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> --- backported to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 4 23:45:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 22:45:37 +0000 Subject: [Koha-bugs] [Bug 8775] Add collection code to lost report In-Reply-To: <bug-8775-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8775-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8775-70-GwX6XvKi6z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8775 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Bin, please make sure to change the status to "Signed Off" when signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 00:14:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 23:14:50 +0000 Subject: [Koha-bugs] [Bug 21948] Clean up style of item detail page In-Reply-To: <bug-21948-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21948-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21948-70-6v62nleycZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21948 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 00:15:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 23:15:08 +0000 Subject: [Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized In-Reply-To: <bug-22381-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22381-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22381-70-6pqoxF4tMs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 --- Comment #1 from Andrew <andrew at bywatersolutions.com> --- Furthermore "closed days to be taken into account" on ExcludeHolidaysFromMaxPickUpDelay is very much open to two contradictory readings. Does taking closed days "into account" mean we are *counting* those days? Or does it mean we *are* using the calendar and therefore *not counting* those days? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 00:14:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 23:14:53 +0000 Subject: [Koha-bugs] [Bug 21948] Clean up style of item detail page In-Reply-To: <bug-21948-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21948-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21948-70-0Okgnaexmq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21948 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85981|0 |1 is obsolete| | --- Comment #7 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Created attachment 86045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86045&action=edit Bug 21948: Clean up style of item detail page This patch removes some page-specific style from the item detail page in the staff client and adds some markup in order to trigger a more generally-used style. This patch also adds a font-awesome icon to the "Edit item" link on the page. To test, apply the patch and regenerate the staff client CSS. Open a bibliographic record and view the "Items tab." Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 00:20:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 23:20:46 +0000 Subject: [Koha-bugs] [Bug 18064] Long overdue cronjob does not follow the library's calendar and skip closed days In-Reply-To: <bug-18064-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18064-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18064-70-c2oDUrY8l8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18064 --- Comment #6 from Joy Nelson <joy at bywatersolutions.com> --- In order to preserve the current functionality of the long overdue cronjob not following the 'calendar/closed days', we will need a new syspref in the Long Overdue area. DefaultLongOverdueCalendar: Use Calendar/Ignore Calendar when working out the period for setting items to long overdue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 00:25:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Mar 2019 23:25:31 +0000 Subject: [Koha-bugs] [Bug 18064] Long overdue cronjob does not follow the library's calendar and skip closed days In-Reply-To: <bug-18064-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18064-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18064-70-U5W0nk2T1V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18064 Kelly McElligott <kelly at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 01:34:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 00:34:01 +0000 Subject: [Koha-bugs] [Bug 22429] Infinite loop in patron card printing In-Reply-To: <bug-22429-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22429-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22429-70-G8Inc2tK3c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22429 --- Comment #10 from David Cook <dcook at prosentient.com.au> --- (In reply to Christian Stelzenm?ller from comment #9) > > "Aha... it's the parentheses which are the problem. They're being interpreted as > > regex metacharacters and not literal values!" > > We noticed that there seems to be an infinite loop if the template has some > or all entries with "0" in it (like in default when creating a new > template). Could this be the same cause? I don't think it would be the exact same cause, but probably related. My guess would be that the other regular expression used for "trimming" the long line might have problems with the 0s. I could probably look at that later today. Infinite loops are very easy to encounter with this code because it only breaks the loops for some very specific positive conditions. There probably should be some kind of sanity check to prevent infinite loops, or a more mathematically precise loop... I have an urgent matter at hand but I'll keep this in mind to look at later today... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 01:57:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 00:57:44 +0000 Subject: [Koha-bugs] [Bug 22429] Infinite loop in patron card printing In-Reply-To: <bug-22429-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22429-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22429-70-zTCm7nVaKu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22429 --- Comment #11 from David Cook <dcook at prosentient.com.au> --- (In reply to Christian Stelzenm?ller from comment #9) > > "Aha... it's the parentheses which are the problem. They're being interpreted as > > regex metacharacters and not literal values!" > > We noticed that there seems to be an infinite loop if the template has some > or all entries with "0" in it (like in default when creating a new > template). Could this be the same cause? Sorry, I just realized that you were referring to the template rather than the layout. Yes, it would be a related problem, but a separate issue. If 'label_width' is 0, then $self->{'width'} will be 0. That means that this condition will be triggered: if (($string_width + $text_attribs->{'llx'}) > $self->{'width'}) And because $self->{'width'} is 0, then the following condition would never feasibly be triggered: if (($string_width + $text_attribs->{'llx'}) < $self->{'width'}) And this condition is the only thing that can stop the infinite loop. Really the line wrapping code looks like it would benefit from a re-write. I'd suggest opening a new bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 02:17:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 01:17:41 +0000 Subject: [Koha-bugs] [Bug 15911] Use noEnterSubmit CSS class instead of prevent_submit.js In-Reply-To: <bug-15911-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15911-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15911-70-pVj1agOIWx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15911 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 02:17:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 01:17:45 +0000 Subject: [Koha-bugs] [Bug 15911] Use noEnterSubmit CSS class instead of prevent_submit.js In-Reply-To: <bug-15911-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15911-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15911-70-HkZ2K3b86l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15911 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85539|0 |1 is obsolete| | --- Comment #2 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Created attachment 86046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86046&action=edit Bug 15911: Use noEnterSubmit CSS class instead of prevent_submit.js This patch removes the use of a separate js file, prevent_submit.js, in favor of using a CSS class to trigger the same functionality in staff-global.js. To test, apply the patch and test the following pages to confirm that pressing "Enter" when the cursor is in any field in the main form does not submit the form. - In Acquisitions, add to a basket from a new (empty) record - In Acquisitions, receive an order line - In Serials, locate a subscription and open the "Edit serials" page from the "Serial collection" page. Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 02:48:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 01:48:24 +0000 Subject: [Koha-bugs] [Bug 11969] Show patrons star rating on their reading history In-Reply-To: <bug-11969-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11969-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11969-70-lh52sLLOJw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11969 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 02:48:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 01:48:27 +0000 Subject: [Koha-bugs] [Bug 11969] Show patrons star rating on their reading history In-Reply-To: <bug-11969-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11969-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11969-70-fwlXUqDMvD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11969 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85354|0 |1 is obsolete| | --- Comment #4 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Created attachment 86047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86047&action=edit Bug 11969: Show patrons star rating on their reading history This patch adds display of a user's ratings to their reading history in the OPAC. Also changed: Removed obsolete "border" attribute from the template. To test, apply the patch and rebuild the OPAC CSS. OpacStarRatings should be enabled. - Log in to the OPAC as a user with a reading history and titles in that history which have ratings. - Under the "your reading history" tab, your ratings should show under rated titles with the date of the rating. - Test also with OpacStarRatings disabled. Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz> Star ratings are displayed in Reading History with OpacStarRatings enabled, and are not displayed when OpacStarRatings is disabled, as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 07:34:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 06:34:54 +0000 Subject: [Koha-bugs] [Bug 22448] advance_notices.pl generates DUE(DGST) too early In-Reply-To: <bug-22448-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22448-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22448-70-mlYl9hvWQj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22448 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Due messages are sent the day the item is due = can be returned without without being late. I think this is the correct behavior, it warns you before things get overdue. (2019-03-04 sent on -05 would be overdue) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 07:48:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 06:48:35 +0000 Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values In-Reply-To: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20307-70-4R3YL3BT2G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307 --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Jonathan Druart from comment #5) > Should we continue on the same way of item types (translation from the UI), > or extract the strings from the DB then use the new Koha::I18 module > (translation from POs)? If I am not mistaken the translation from POs would always require to run jobs on the server, maintain your own po files... put them in the right place. I think we need something that can be done in the GUI to manage the translations. I am not sure if that could be achieved differently than what you have done for the itemtypes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 07:56:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 06:56:43 +0000 Subject: [Koha-bugs] [Bug 17433] Koha::Validator. Validation for the masses! In-Reply-To: <bug-17433-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17433-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17433-70-fcJ5PntmrI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17433 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Brian from comment #7) > I just know that it is related to at least 3 other patches of a ticket that > concerns a problem with the Validation for *MandatoryField and > *UnwantedField sysprefs. For now I'm putting my foot in the door as to > speak so I receive email updates when progress is made and hopefully the > patch is eventually finished There are no other bugs linked to this, so you probably will not receive any emails. This is at the moment a bit of a dead end. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 07:58:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 06:58:14 +0000 Subject: [Koha-bugs] [Bug 17433] Koha::Validator. Validation for the masses! In-Reply-To: <bug-17433-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17433-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17433-70-caItqZ4gg1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17433 --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Katrin Fischer from comment #8) > (In reply to Brian from comment #7) > > I just know that it is related to at least 3 other patches of a ticket that > > concerns a problem with the Validation for *MandatoryField and > > *UnwantedField sysprefs. For now I'm putting my foot in the door as to > > speak so I receive email updates when progress is made and hopefully the > > patch is eventually finished > > There are no other bugs linked to this, so you probably will not receive any > emails. This is at the moment a bit of a dead end. Filing a new separate omnibus bug for validation issues and link them there could be a good idea. I just wouldn't use this here as development seems to have stopped. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 10:02:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 09:02:02 +0000 Subject: [Koha-bugs] [Bug 22275] 18.06.00.060 DB update fails (incomplete/incorrect defaults) In-Reply-To: <bug-22275-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22275-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22275-70-MeyigXlGqL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22275 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 10:02:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 09:02:06 +0000 Subject: [Koha-bugs] [Bug 22275] 18.06.00.060 DB update fails (incomplete/incorrect defaults) In-Reply-To: <bug-22275-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22275-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22275-70-36WLlJGsgK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22275 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85772|0 |1 is obsolete| | --- Comment #16 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86048&action=edit Bug 22275: (bug 15836 follow-up) Fix class_sources.class_split_rule FK creation 18.06.00.060 will fail if custom Classification sources were created. In that case we should use the 'generic' split rule. Test plan: % git checkout -b bug_22395_pre 3a0cba67f1387595f570ab9d9efdeabc856345b4 Reset the DB Go to Home ? Administration ? Classification sources Create a custom "Classification filing rules" Create a custom "Classification sources" using this filing rules % git checkout master % perl installer/data/mysql/updatedatabase.pl => Without this patch you will get: DBD::mysql::db do failed: Cannot add or update a child row: a foreign key constraint fails (`koha_kohadev`.`#sql-33a_67`, CONSTRAINT `class_source_ibfk_2` FOREIGN KEY (`class_split_rule`) REFERENCES `class_split _rules` (`class_split_rule`)) [for Statement " ALTER TABLE class_sources ADD CONSTRAINT class_source_ibfk_2 FOREIGN KEY (class_split_rule) REFERENCES class_split_rules (class_split_rule) "] at installer/data/mysql/updatedatabase.pl line 17104. => With this patch applied the FK will be created successfully class_sources.class_split_rule will be set to "generic" for these custom values. Signed-off-by: Oliver Behnke <oliver.behnke at aei.mpg.de> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 10:02:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 09:02:58 +0000 Subject: [Koha-bugs] [Bug 22275] 18.06.00.060 DB update fails (incomplete/incorrect defaults) In-Reply-To: <bug-22275-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22275-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22275-70-zO6tbtOJ6E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22275 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 10:06:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 09:06:40 +0000 Subject: [Koha-bugs] [Bug 22413] Elasticsearch - Index title is lost after sorting In-Reply-To: <bug-22413-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22413-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22413-70-cJT1xYTAKs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22413 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 10:06:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 09:06:43 +0000 Subject: [Koha-bugs] [Bug 22413] Elasticsearch - Index title is lost after sorting In-Reply-To: <bug-22413-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22413-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22413-70-DlwrxAvMVa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22413 --- Comment #3 from Ere Maijala <ere.maijala at helsinki.fi> --- Created attachment 86049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86049&action=edit Bug 22413: Improve query string and desc creation for Elasticsearch Test plan: After each of the following steps, verify that the results and query description looks ok. 1. Do a simple keyword query 2. Change sort order 3. Click a facet 4. Do an advanced search with title and author 5. Change sort order 6. Click a facet -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 10:13:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 09:13:34 +0000 Subject: [Koha-bugs] [Bug 22246] Elasticsearch indexing needs a maximum length for __sort fields In-Reply-To: <bug-22246-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22246-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22246-70-7KBUD6PtyE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22246 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 10:13:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 09:13:37 +0000 Subject: [Koha-bugs] [Bug 22246] Elasticsearch indexing needs a maximum length for __sort fields In-Reply-To: <bug-22246-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22246-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22246-70-GjAEDv9zj6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22246 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85863|0 |1 is obsolete| | --- Comment #6 from Ere Maijala <ere.maijala at helsinki.fi> --- Created attachment 86050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86050&action=edit Bug 22246: Fix indexing of large fields with Elasticsearch Deduplicate multivalued fields and make sure sort fields are not excessively long. Also updates default mappings so that sort fields are not created for item fields where it doesn't make sense. Test plan: 1. Reset ES mappings in administration 2. Check that sort is '0' for local-classification in biblio mappings. 3. Change sort back to '1' for local-classification for the next steps. 4. Create a record with 20 items, each with a 100 character long call number 5. Check that when indexed, the record in ES does not have duplicates in any of the item fields and local-classification__sort is truncated to 255 characters. Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 10:13:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 09:13:56 +0000 Subject: [Koha-bugs] [Bug 22246] Elasticsearch indexing needs a maximum length for __sort fields In-Reply-To: <bug-22246-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22246-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22246-70-seMm8N2mQa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22246 --- Comment #7 from Ere Maijala <ere.maijala at helsinki.fi> --- Rebased. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 11:41:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 10:41:00 +0000 Subject: [Koha-bugs] [Bug 22448] advance_notices.pl generates DUE(DGST) too early In-Reply-To: <bug-22448-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22448-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22448-70-2hLk3asfyE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22448 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #2 from Magnus Enger <magnus at libriotech.no> --- You are right, of course. And changing the wording of the message a bit would make it make more sense. Closing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 11:45:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 10:45:46 +0000 Subject: [Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2 In-Reply-To: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17140-70-Oa946b7I7j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Attachment #54542|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 11:46:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 10:46:04 +0000 Subject: [Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2 In-Reply-To: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17140-70-AavZ9fFZDB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #54611|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 11:47:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 10:47:34 +0000 Subject: [Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2 In-Reply-To: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17140-70-bCteTtMWaa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 --- Comment #31 from Josef Moravec <josef.moravec at gmail.com> --- I obsoleted first two patches, they do not apply anymore, the updated part of code was refactored and the original issue from comment 1 is fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 11:54:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 10:54:57 +0000 Subject: [Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2 In-Reply-To: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17140-70-GPyJJW5tck@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86044|0 |1 is obsolete| | --- Comment #32 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86051&action=edit Bug 17140: fix rounding errors when paying fines Whenever a fine (accountlines in DB) has a precision longer than two floating points, it becomes very hard for a user to clear it. Ex: 1.035 will be displayed as 1.04 or 1.03 depending on the screen. But entering any of those value in Pay Fine will not clear it. The user has no way to know the exact value to enter. This fix makes sure that the intent of the user is met, by matching the EXACT needed sum when the difference is less than 0.01. TEST 1) Create a 1.035 fine - Go to a Patron screen - Fines tab on the left - Create manual invoice 2) go to Pay fines, click Pay amount on bottom left. 3) It will show 1.03 as Total, and as Collect from patron. Click confirm. 4) An error message will appear. 5) Apply patch, do again. Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 11:56:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 10:56:56 +0000 Subject: [Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2 In-Reply-To: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17140-70-vlpNhOSUhK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | Status|Signed Off |Passed QA --- Comment #33 from Josef Moravec <josef.moravec at gmail.com> --- I am passing it QA, as it is at least quick fix of long standing issue. It definitely could be done better, but it would need more refactoring and maybe some architectural changes I think. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 12:03:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 11:03:27 +0000 Subject: [Koha-bugs] [Bug 21974] cxn_pool must be configurable In-Reply-To: <bug-21974-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21974-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21974-70-utQ1Wf78Ed@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21974 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83291|0 |1 is obsolete| | --- Comment #2 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86052&action=edit Bug 21974: Make Elasticsearch connection settings configurable Default settings are appended in get_elasticsearch_params so that there's a central place for them. Defaults can be overridden in koha-conf.xml. Test plan: 1. Verify that searches still work with the patch applied. 2. Verify that search fails after adding the following under <elasticsearch> in koha-conf.xml: <cxn_pool>Static</cxn_pool> 3. Verify that search fails after adding the following under <elasticsearch> in koha-conf.xml: <cxn_pool>FOO</cxn_pool> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 12:03:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 11:03:43 +0000 Subject: [Koha-bugs] [Bug 21974] cxn_pool must be configurable In-Reply-To: <bug-21974-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21974-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21974-70-ACaidqglcb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21974 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 12:30:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 11:30:40 +0000 Subject: [Koha-bugs] [Bug 21872] Elasticsearch indexing faster by making it multi-threaded In-Reply-To: <bug-21872-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21872-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21872-70-il3ECP9IqG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21872 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85975|0 |1 is obsolete| | --- Comment #52 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86053&action=edit Bug 21872: Add multiprocess support to Elasticsearch indexing utility Test plan: 1. Time execution without -p parameter 2. Time execution with -p 2 or -p3 or -p 4 depending on CPU core count Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 12:30:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 11:30:44 +0000 Subject: [Koha-bugs] [Bug 21872] Elasticsearch indexing faster by making it multi-threaded In-Reply-To: <bug-21872-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21872-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21872-70-IrFDrPyqoA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21872 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85976|0 |1 is obsolete| | --- Comment #53 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86054&action=edit Bug 21872: Simplify conditions and exit on invalid combination of arguments Change to zero based indexing for slice index to simplify some conditions. Exit with error message if trying to combine processes and biblio numbers arguments. Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 12:30:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 11:30:48 +0000 Subject: [Koha-bugs] [Bug 21872] Elasticsearch indexing faster by making it multi-threaded In-Reply-To: <bug-21872-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21872-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21872-70-omrh5fanoO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21872 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85977|0 |1 is obsolete| | --- Comment #54 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86055&action=edit Bug 21872: Remove duplicate modulo condition in authorities iterator Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 12:30:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 11:30:52 +0000 Subject: [Koha-bugs] [Bug 21872] Elasticsearch indexing faster by making it multi-threaded In-Reply-To: <bug-21872-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21872-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21872-70-pntna08L8o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21872 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85978|0 |1 is obsolete| | --- Comment #55 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86056&action=edit Bug 21872: Add support for -p parameter to koha-elasticsearch Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 12:30:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 11:30:55 +0000 Subject: [Koha-bugs] [Bug 21872] Elasticsearch indexing faster by making it multi-threaded In-Reply-To: <bug-21872-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21872-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21872-70-TIL5lpJmkX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21872 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85979|0 |1 is obsolete| | --- Comment #56 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86057&action=edit Bug 21872: Fix name of rebuild_elasticsearch.pl Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 12:31:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 11:31:08 +0000 Subject: [Koha-bugs] [Bug 21872] Elasticsearch indexing faster by making it multi-threaded In-Reply-To: <bug-21872-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21872-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21872-70-in9vRbfgQg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21872 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 12:32:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 11:32:42 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18925-70-35qPrQjLfv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|tomascohen at gmail.com |testopia at bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 12:49:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 11:49:01 +0000 Subject: [Koha-bugs] [Bug 22413] Elasticsearch - Index title is lost after sorting In-Reply-To: <bug-22413-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22413-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22413-70-hzJaozBivE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22413 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.05 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 12:54:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 11:54:20 +0000 Subject: [Koha-bugs] [Bug 22256] llength mapping wrong in default Elasticsearch mappings In-Reply-To: <bug-22256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22256-70-UQ5itsX6NQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22256 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84630|0 |1 is obsolete| | --- Comment #3 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86058&action=edit Bug 22256: Fix llength mapping in Elasticsearch Test plan: 1. Reset mappings 2. Index records 3. Check that in Elasticsearch the correct length information is stored in llength Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 12:54:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 11:54:42 +0000 Subject: [Koha-bugs] [Bug 22256] llength mapping wrong in default Elasticsearch mappings In-Reply-To: <bug-22256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22256-70-5krInRxHSR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22256 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Attachment #84609|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 12:55:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 11:55:01 +0000 Subject: [Koha-bugs] [Bug 22256] llength mapping wrong in default Elasticsearch mappings In-Reply-To: <bug-22256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22256-70-iZcKXvgtC5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22256 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 12:59:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 11:59:32 +0000 Subject: [Koha-bugs] [Bug 22413] Elasticsearch - Index title is lost after sorting In-Reply-To: <bug-22413-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22413-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22413-70-XBlCjjJ4Gv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22413 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86049|0 |1 is obsolete| | --- Comment #4 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86059&action=edit Bug 22413: Improve query string and desc creation for Elasticsearch Test plan: After each of the following steps, verify that the results and query description looks ok. 1. Do a simple keyword query 2. Change sort order 3. Click a facet 4. Do an advanced search with title and author 5. Change sort order 6. Click a facet Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 12:59:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 11:59:50 +0000 Subject: [Koha-bugs] [Bug 22413] Elasticsearch - Index title is lost after sorting In-Reply-To: <bug-22413-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22413-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22413-70-EMhZyGkPYn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22413 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 13:11:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 12:11:08 +0000 Subject: [Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13937-70-pmL5dUxL8o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #120 from Josef Moravec <josef.moravec at gmail.com> --- Just started to testing, but file Koha/Z3950Responder/Session.pm calls C4::Items::GetItem which was removed from master... Could you add a follow-up for that? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 13:14:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 12:14:30 +0000 Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request datatable to be customisable In-Reply-To: <bug-21063-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21063-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21063-70-1F4a4y5YKa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 --- Comment #49 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 86060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86060&action=edit Bug 21063: (follow-up) Fix missing table values As per comment #48 here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063#c48 >pages This was a misnamed property in colums_settings.yml >comments This was a missing embed in the API call, probably a rebase error >article (part title) This was a bug. A combination of a misnamed property in columns_settings.yml and a missing "render" method on the datatable >completed on This was an oversight and had apparently never worked. It has now been added >cost I cannot replicate this, cost is displaying fine for me -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 13:44:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 12:44:08 +0000 Subject: [Koha-bugs] [Bug 22454] New: Add Koha::Item::hidden_in_opac method Message-ID: <bug-22454-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22454 Bug ID: 22454 Summary: Add Koha::Item::hidden_in_opac method Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- We need such a method to determine if an item needs to be hidden in OPAC. It should take the OpacHiddenItems hashref as (optional) parameter. The case for 'exceptions' is left out on purpose. This should be just calculated by the calling party. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 13:47:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 12:47:48 +0000 Subject: [Koha-bugs] [Bug 22454] Add Koha::Item::hidden_in_opac method In-Reply-To: <bug-22454-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22454-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22454-70-RGNEqqxjXF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22454 --- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 86061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86061&action=edit Bug 22454: Unit tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 13:47:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 12:47:52 +0000 Subject: [Koha-bugs] [Bug 22454] Add Koha::Item::hidden_in_opac method In-Reply-To: <bug-22454-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22454-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22454-70-Bv75GLriIB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22454 --- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 86062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86062&action=edit Bug 22454: Add Koha::Item::hidden_in_opac method This patch adds a hidden_in_opac method that does the same calculation done in GetHiddenItemnumbers, but for a single item, and doesn't get the OpacHiddenItems syspref, but expects them to be passed as parameters (to avoid multiple reads). To test: - Apply this patches - Run: $ kshell k$ prove t/db_dependent/Koha/Item.t => SUCCESS: Tests pass! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 13:48:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 12:48:12 +0000 Subject: [Koha-bugs] [Bug 22454] Add Koha::Item::hidden_in_opac method In-Reply-To: <bug-22454-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22454-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22454-70-rGr36zcWOW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22454 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 13:58:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 12:58:49 +0000 Subject: [Koha-bugs] [Bug 22454] Add Koha::Item::hidden_in_opac method In-Reply-To: <bug-22454-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22454-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22454-70-nhnB8nL5zX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22454 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 14:02:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 13:02:13 +0000 Subject: [Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2 In-Reply-To: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17140-70-58yQYiuNb0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 --- Comment #34 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I am not against a quick fix, but things are weird (with or without the patch): Add a 1.035 fine, you see: https://snag.gy/hmFX51.jpg Go to make a payment, you see: https://snag.gy/0MuCxY.jpg Click "Pay", you see: https://snag.gy/bA5O3C.jpg If we push this as it, we should ask have people to focus on a global solution. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 14:10:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 13:10:07 +0000 Subject: [Koha-bugs] [Bug 21832] Restore is_expired in ILS-DI GetPatronInfo service In-Reply-To: <bug-21832-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21832-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21832-70-rrJIIAGcjE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21832 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85800|0 |1 is obsolete| | Attachment #85801|0 |1 is obsolete| | --- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86063&action=edit Bug 21832: Restore is_expired in ILS-DI GetPatronInfo service Since Bug 17578 removed C4::Member::GetMemberDetails, the information "is_expired" disappeared from ILS-DI service GetPatronInfo. I propose to restore in by adding the code that exisited in C4::Member::GetMemberDetails directly in C4::ILSDI::Services. Test plan : 1) Enable ILS-DI webservice 2) Choose a patron not expired 3) Call web-service (replace X with patron's borrowernumber) : /cgi-bin/koha/ilsdi.pl?service=GetPatronInfo&patron_id=X 4) You see : <is_expired>0</is_expired> 5) Choose a patron expired 6) Call web-service (replace X with patron's borrowernumber) : /cgi-bin/koha/ilsdi.pl?service=GetPatronInfo&patron_id=X 7) You see : <is_expired>1</is_expired> Signed-off-by: Maryse Simard <maryse.simard at inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 14:10:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 13:10:01 +0000 Subject: [Koha-bugs] [Bug 21832] Restore is_expired in ILS-DI GetPatronInfo service In-Reply-To: <bug-21832-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21832-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21832-70-4pb1gKfskQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21832 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 14:10:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 13:10:15 +0000 Subject: [Koha-bugs] [Bug 21832] Restore is_expired in ILS-DI GetPatronInfo service In-Reply-To: <bug-21832-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21832-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21832-70-VOsaa0lcdc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21832 --- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86064&action=edit Bug 21832: add unit test Adds a check that is_expired exists in service GetPatronInfo. Test plan : Run : prove t/db_dependent/ILSDI_Services.t Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Amended patch: remove ref to bug number, we have git for that -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 14:14:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 13:14:31 +0000 Subject: [Koha-bugs] [Bug 21832] Restore is_expired in ILS-DI GetPatronInfo service In-Reply-To: <bug-21832-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21832-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21832-70-o5lCsX8uej@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21832 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion --- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- one sec. I had (and still have) issues when I refactored C4 code called from the ILSDI module. The problem is: what is really expected and what was there by 'accident'? IMO is_expired was in the response by accident, proof of that: it is not in the "Example response" on http://catalogue.kohadev.org/cgi-bin/koha/ilsdi.pl?service=Describe&verb=GetPatronInfo Moreover we have dateexpiry, so client can guess if the patron's account has expired or not :) Swithing to In Discussion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 14:16:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 13:16:46 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18925-70-ZwiQxjoRAc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 14:19:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 13:19:08 +0000 Subject: [Koha-bugs] [Bug 21721] Update C4::Circulation::AddRenewal to use Koha::Account->add_debit In-Reply-To: <bug-21721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21721-70-Ls5ZnTntjf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21721 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85529|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86065&action=edit Bug 21721: Use Koha::Account->add_debit in AddRenewal Known Side Effect: Prior to this patch renewal charges were not recorded in the FinesLog. After this patch, if the FinesLog is enabled then the 'action' will be recorded as `create_rent`. Sponsored-by: PTFS Europe Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 14:20:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 13:20:30 +0000 Subject: [Koha-bugs] [Bug 21721] Update C4::Circulation::AddRenewal to use Koha::Account->add_debit In-Reply-To: <bug-21721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21721-70-kILIYcrgl1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21721 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 14:21:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 13:21:15 +0000 Subject: [Koha-bugs] [Bug 21721] Update C4::Circulation::AddRenewal to use Koha::Account->add_debit In-Reply-To: <bug-21721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21721-70-sSdtLQyDmo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21721 --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Wierd.. I've just rebased my accounts branch and it seems happy.. attached the patch from that https://github.com/PTFS-Europe/koha/compare/master...PTFS-Europe:accounts_all is where I'm tracking this little lot if it helps -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 14:50:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 13:50:05 +0000 Subject: [Koha-bugs] [Bug 22435] account_offset types should be codes not descriptions In-Reply-To: <bug-22435-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22435-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22435-70-DFKiv2u0W7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|14825 | Blocks| |14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 14:50:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 13:50:05 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14825-70-4ydyhzTWIS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22435 | Depends on| |22435 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22435 [Bug 22435] account_offset types should be codes not descriptions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 14:50:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 13:50:14 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20447-70-DCtfS49yib@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Joonas Kylm?l? <joonas.kylmala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at helsinki.fi --- Comment #97 from Joonas Kylm?l? <joonas.kylmala at helsinki.fi> --- Why is there deleted_on on in both holdings and holdings_metadata tables? Why is it not enough to have it just in holdings? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 14:50:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 13:50:47 +0000 Subject: [Koha-bugs] [Bug 22393] Remove last remaining manualinvoice use In-Reply-To: <bug-22393-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22393-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22393-70-6fs5wzCwf4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22393 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|21756 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 14:50:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 13:50:47 +0000 Subject: [Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead) In-Reply-To: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21756-70-Qgne64a7E3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22393 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22393 [Bug 22393] Remove last remaining manualinvoice use -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 14:57:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 13:57:16 +0000 Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale' In-Reply-To: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13985-70-SsbesR2wFh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17702 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 [Bug 17702] Create configuration for account types -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 14:57:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 13:57:16 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account types In-Reply-To: <bug-17702-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17702-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17702-70-EOllhZJWep@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13985 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 14:58:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 13:58:25 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20447-70-O2JMNaVUAS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #98 from Joonas Kylm?l? <joonas.kylmala at helsinki.fi> --- Comment on attachment 85994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85994 Bug 20447: MARC Holdings support Review of attachment 85994: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20447&attachment=85994) ----------------------------------------------------------------- ::: C4/Biblio.pm @@ +1563,5 @@ > } > > + #---- holdings > + if ( $tagslib->{$tag}->{$subfield}->{'authorised_value'} eq "holdings" ) { > + my $holding = Koha::Holdings->find( $value ); does the find need "deleted_on => undef" as a parameter in order to not care about deleted holdings? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 14:59:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 13:59:29 +0000 Subject: [Koha-bugs] [Bug 22455] New: Add Koha::Biblio::hidden_in_opac method Message-ID: <bug-22455-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22455 Bug ID: 22455 Summary: Add Koha::Biblio::hidden_in_opac method Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- We need such a method to determine if a biblio needs to be hidden in OPAC. It should take the OpacHiddenItems hashref as (optional) parameter. The case for 'exceptions' is left out on purpose. This should be just calculated by the calling party. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 14:59:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 13:59:37 +0000 Subject: [Koha-bugs] [Bug 22455] Add Koha::Biblio::hidden_in_opac method In-Reply-To: <bug-22455-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22455-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22455-70-PuY4HmPqfF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22455 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 15:00:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 14:00:01 +0000 Subject: [Koha-bugs] [Bug 22455] Add Koha::Biblio::hidden_in_opac method In-Reply-To: <bug-22455-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22455-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22455-70-L7adNYWtT4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22455 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Depends on| |22454 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22454 [Bug 22454] Add Koha::Item::hidden_in_opac method -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 15:00:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 14:00:01 +0000 Subject: [Koha-bugs] [Bug 22454] Add Koha::Item::hidden_in_opac method In-Reply-To: <bug-22454-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22454-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22454-70-XkTR8kg7T6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22454 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22455 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22455 [Bug 22455] Add Koha::Biblio::hidden_in_opac method -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 15:00:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 14:00:46 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20447-70-nqGlNEm7QY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #99 from Joonas Kylm?l? <joonas.kylmala at helsinki.fi> --- Comment on attachment 85994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85994 Bug 20447: MARC Holdings support Review of attachment 85994: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20447&attachment=85994) ----------------------------------------------------------------- ::: C4/Items.pm @@ +1705,5 @@ > + holdingbranch => $oldHolding->{'holdingbranch'}, > + location => $oldHolding->{'location'}, > + callnumber => $oldHolding->{'callnumber'}, > + suppress => $oldHolding->{'suppress'}, > + deleted_on => undef if deleted_on is not needed / is undef by default this can be removed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 15:05:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 14:05:01 +0000 Subject: [Koha-bugs] [Bug 22455] Add Koha::Biblio::hidden_in_opac method In-Reply-To: <bug-22455-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22455-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22455-70-YXgjKEBFhi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22455 --- Comment #1 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 86066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86066&action=edit Bug 22455: Unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 15:05:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 14:05:01 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20447-70-PobnSdRF22@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20271 --- Comment #100 from Ere Maijala <ere.maijala at helsinki.fi> --- (In reply to Joonas Kylm?l? from comment #97) > Why is there deleted_on on in both holdings and holdings_metadata tables? > Why is it not enough to have it just in holdings? Because that's how it's done also for biblios in bug 20271. There's at least one practical upside: it allows one to fetch a metadata record without joining with the base table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 15:05:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 14:05:01 +0000 Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables with their "alive" cousins In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20271-70-GBJKPJGW6Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20447 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 15:05:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 14:05:09 +0000 Subject: [Koha-bugs] [Bug 22455] Add Koha::Biblio::hidden_in_opac method In-Reply-To: <bug-22455-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22455-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22455-70-DwFDArsbQ2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22455 --- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 86067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86067&action=edit Bug 22455: Add Koha::Biblio::hidden_in_opac method This patch adds a hidden_in_opac method that does the same calculation done in places like opac-tags.pl. The condition that is checked is that all items belonging to the biblio are hidden. This is the current behaviour in the code. To test: - Apply this patches - Run: $ kshell k$ prove t/db_dependent/Koha/Biblio.t => SUCCESS: Tests pass! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 15:05:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 14:05:42 +0000 Subject: [Koha-bugs] [Bug 22455] Add Koha::Biblio::hidden_in_opac method In-Reply-To: <bug-22455-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22455-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22455-70-rB1nE6TVty@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22455 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |tomascohen at gmail.com Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 15:07:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 14:07:53 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20447-70-PyJt3Qk83O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #101 from Ere Maijala <ere.maijala at helsinki.fi> --- (In reply to Joonas Kylm?l? from comment #98) > Comment on attachment 85994 [details] [review] > Bug 20447: MARC Holdings support > > Review of attachment 85994 [details] [review]: > ----------------------------------------------------------------- > > ::: C4/Biblio.pm > @@ +1563,5 @@ > > } > > > > + #---- holdings > > + if ( $tagslib->{$tag}->{$subfield}->{'authorised_value'} eq "holdings" ) { > > + my $holding = Koha::Holdings->find( $value ); > > does the find need "deleted_on => undef" as a parameter in order to not care > about deleted holdings? It allows one to fetch a holdings record by ID even if it's deleted. I believe it makes sense since otherwise it would be possible, at least in theory, for an item to point to a deleted holdings record without it showing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 15:11:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 14:11:04 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18925-70-py15RxM9nm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85953|0 |1 is obsolete| | --- Comment #94 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86068&action=edit Bug 18925: Move maxissueqty and maxonsiteissueqty to circulation_rules This patch set moves maxissueqty and maxonsiteissueqty to the circulation_rules table. Test Plan: 1) Apply this patch 2) Run updatedatabase 3) prove t/db_dependent/Circulation.t 4) prove t/db_dependent/Circulation/Branch.t 5) prove t/db_dependent/Circulation/GetHardDueDate.t 6) prove t/db_dependent/Circulation/Returns.t 7) prove t/db_dependent/Circulation/SwitchOnSiteCheckouts.t 8) prove t/db_dependent/Circulation/TooMany.t 9) prove t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t 10) prove t/db_dependent/Reserves.t 11) Note no changes in circulation behavior related to check out limis both on and off site Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 15:11:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 14:11:09 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18925-70-T0RTsWS6Ni@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85954|0 |1 is obsolete| | --- Comment #95 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86069&action=edit Bug 18925: (follow-up) Change name of rule to fix ambiguity There was previously an ambiguity between the branch/category/itemtype specific max{,onsite}issueqty and the total-per-patron max{,onsite}issueqty. The latter has been renamed to patron_max{,onsite}issueqty. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 15:11:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 14:11:18 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18925-70-8BbeHIsu6T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85956|0 |1 is obsolete| | --- Comment #97 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86071&action=edit Bug 18925: Replace logic in GetBranchBorrowerCircRule with get_effective_rule Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 15:11:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 14:11:13 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18925-70-51pB6WtpEW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85955|0 |1 is obsolete| | --- Comment #96 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86070&action=edit Bug 18925: (follow-up) Fix null/empty behavior Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 15:11:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 14:11:22 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18925-70-B8BAfnSG47@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85957|0 |1 is obsolete| | --- Comment #98 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86072&action=edit Bug 18925: Update schema files Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 15:11:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 14:11:27 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18925-70-Vi0ROM1B0H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85958|0 |1 is obsolete| | --- Comment #99 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86073&action=edit Bug 18925: Fix null/empty behavior, again Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 15:11:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 14:11:31 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18925-70-Axxbi1winA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85959|0 |1 is obsolete| | --- Comment #100 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86074&action=edit Bug 18925: Update new occurrences Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 15:11:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 14:11:36 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18925-70-TrQkiysBdy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85960|0 |1 is obsolete| | --- Comment #101 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86075&action=edit Bug 18925: (QA follow-up) Make DB update idempotent Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 15:11:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 14:11:40 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18925-70-aaTK1flshU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85961|0 |1 is obsolete| | --- Comment #102 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86076&action=edit Bug 18925: (QA follow-up) Fix indentation characters in smart-rules.tt Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 15:11:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 14:11:45 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18925-70-q5nkM0wEuA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85962|0 |1 is obsolete| | --- Comment #103 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86077&action=edit Bug 18925: (QA follow-up) Fix basic_workflow.t Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 15:11:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 14:11:49 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18925-70-X2F0PB8ILR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85963|0 |1 is obsolete| | --- Comment #104 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86078&action=edit Bug 18925: Move existing rules Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 15:11:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 14:11:54 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18925-70-ly1b4g6PpC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85964|0 |1 is obsolete| | --- Comment #105 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86079&action=edit Bug 18925: (follow-up) DBIC schema changes Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 15:11:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 14:11:59 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18925-70-B0wMb7pZ9L@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85965|0 |1 is obsolete| | --- Comment #106 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86080&action=edit Bug 18925: Fix 'Default checkout, hold policy by patron category' block We want ->Search to return undef if the rule does not exist. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 15:12:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 14:12:03 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18925-70-tgDhW4hJ9z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #107 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86081&action=edit Bug 18925: (QA follow-up) Fix Circulation.t Test plan: t/db_dependent/Circulation.t Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 15:12:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 14:12:30 +0000 Subject: [Koha-bugs] [Bug 22456] New: Customers Cancelling their Pending Holds Message-ID: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Bug ID: 22456 Summary: Customers Cancelling their Pending Holds Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: christofer.zorn at ajaxlibrary.ca QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Good morning! I'm not sure if I should have piggybacked this off of the previous ticket, but I'd like to open the discussion on bug 18856 again. We'd like the ability to have patrons cancel their holds once they have been pulled by staff and are awaiting pick up. Our previous catalogue (Bibliocommons) allowed the cancellation of holds once it as captured. This feature was well like and used by our patrons who had determined they didn't need/want the item any longer. This gave the perception that they were freeing up the item for the next person. We have fielded a number of grumpy comments since our migration about the inability to perform this functionality. >From my perspective, if we're allowing patrons to place holds and cancel them before they're captured, we should offer the ability to cancel them up until they're picked up. At the very least, this should be a system option to allow the Library to choose whether they'd like to enable this functionality. Even if the implemented functionality is a placebo for the user ... offer them the ability to cancel the hold and have it remove from their account. As long as optically it appears they've cancelled the hold, there is no harm. If desired, a report could be run to allow staff to pull those items from the shelf if needed. I'm more than happy to elaborate if needed on this, but I feel that this is a feature that is currently missing from Koha that would be a boon to customer service. Thanks Christofer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 15:13:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 14:13:21 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20447-70-eErLQJVAv8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #102 from Ere Maijala <ere.maijala at helsinki.fi> --- (In reply to Joonas Kylm?l? from comment #99) > Comment on attachment 85994 [details] [review] > Bug 20447: MARC Holdings support > > Review of attachment 85994 [details] [review]: > ----------------------------------------------------------------- > > ::: C4/Items.pm > @@ +1705,5 @@ > > + holdingbranch => $oldHolding->{'holdingbranch'}, > > + location => $oldHolding->{'location'}, > > + callnumber => $oldHolding->{'callnumber'}, > > + suppress => $oldHolding->{'suppress'}, > > + deleted_on => undef > > if deleted_on is not needed / is undef by default this can be removed It tries to find an existing holdings record for the item to be attached to. Deleted holdings do not qualify, so the filter is needed. However, I just realized that the search terms can match multiple records which would cause find() to fail. I need to revise that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 15:14:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 14:14:01 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20447-70-LNJeqlFKeO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #103 from Joonas Kylm?l? <joonas.kylmala at helsinki.fi> --- (In reply to Ere Maijala from comment #100) > (In reply to Joonas Kylm?l? from comment #97) > > Why is there deleted_on on in both holdings and holdings_metadata tables? > > Why is it not enough to have it just in holdings? > > Because that's how it's done also for biblios in bug 20271. There's at least > one practical upside: it allows one to fetch a metadata record without > joining with the base table. #1 rule in my database course was always use the normal form for databases. It feels wrong to have the data in one place: twice the possibility of having bugs and also taking twice as much space. I read quickly https://stackoverflow.com/questions/2623852/why-are-joins-bad-when-considering-scalability and in the end the performance difference might not be that big. I would like you to provide performance benchmarks if we are going to use the non-normalized way. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 15:16:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 14:16:29 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18925-70-OD9jbVDSAA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #108 from Josef Moravec <josef.moravec at gmail.com> --- Just a note: The patron_maxissueqty, and maxissueqty rules represents the same thing: it is number of max issues possible. There is no setting from "Default checkout, hold policy by patron category" you can't make in the main circulation rules settings table. But as this is the same on master and as this development leads to revamp circulation rules setting UI, this could be fixed in the future. Hopefully the solution arise during developing/testing... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 15:18:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 14:18:12 +0000 Subject: [Koha-bugs] [Bug 22457] New: OpacHiddenItemsExceptions should be moved to a category attribute Message-ID: <bug-22457-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22457 Bug ID: 22457 Summary: OpacHiddenItemsExceptions should be moved to a category attribute Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- In order to determine if an item should be hidden for a specific patron category, we now need to: - Read and parse OpacHiddenItemsExceptions - Verify it is a real category (subject to typos) - Compare to the current patron category This would be avoided by just having an attribute on the categories table (e.g. overrides_hidding_policy). I leave choosing the right attribute name to native speakers. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 15:18:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 14:18:33 +0000 Subject: [Koha-bugs] [Bug 22457] OpacHiddenItemsExceptions should be moved to a category attribute In-Reply-To: <bug-22457-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22457-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22457-70-6j3ON03ooc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22457 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |kyle at bywatersolutions.com, | |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 15:21:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 14:21:20 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20447-70-v6wO9jBuUP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #104 from Joonas Kylm?l? <joonas.kylmala at helsinki.fi> --- (In reply to Joonas Kylm?l? from comment #103) > #1 rule in my database course was always use the normal form for databases. > It feels wrong to have the data in one place: twice the possibility of > having bugs and also taking twice as much space. I read quickly > https://stackoverflow.com/questions/2623852/why-are-joins-bad-when- > considering-scalability and in the end the performance difference might not > be that big. I would like you to provide performance benchmarks if we are > going to use the non-normalized way. Here is a few pages of reasoning why we should use the normal form: https://mariadb.com/kb/en/library/database-normalization/ (unless there is a significant performance gain) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 15:21:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 14:21:55 +0000 Subject: [Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive In-Reply-To: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18723-70-H2EBOyZ4VZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 --- Comment #41 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Created attachment 86082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86082&action=edit Backport of the patch to 18.05.x Cherry-picked from 18.11.x branch on top of current 18.05.x (0dd262a02e) Removed replacement cost stuff which didn't exist in 18.05 Test plan "ran" successfully. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 15:23:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 14:23:07 +0000 Subject: [Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive In-Reply-To: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18723-70-OEGruk3EnB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86082|1 |0 is patch| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 15:26:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 14:26:32 +0000 Subject: [Koha-bugs] [Bug 22446] Koha/Patron/Categories.t is failing on March 1st (2019 only?) In-Reply-To: <bug-22446-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22446-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22446-70-ggafZlClo2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22446 --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Comment on attachment 86011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86011 Bug 22446: Explicitely list what we expect to avoid ambiguity Review of attachment 86011: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=22446&attachment=86011) ----------------------------------------------------------------- ::: t/db_dependent/Koha/Patron/Categories.t @@ +110,3 @@ > Time::Fake->offset( $dt->epoch ); > > + my $next_month = dt_from_string($date->{next_month}, 'iso'); I think I found that $next_month was not actually used anywhere.. be nice to do a little housekeeping whilst in here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 15:28:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 14:28:28 +0000 Subject: [Koha-bugs] [Bug 22446] Koha/Patron/Categories.t is failing on March 1st (2019 only?) In-Reply-To: <bug-22446-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22446-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22446-70-LB3umpacrt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22446 --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- I actually prefer hard-coding these dates for tests as you have done here.. our Koha code relies on DateTime maths so by relying on the same DateTime maths in the test we were realistically just testing DateTime against DateTime so wouldn't have picked up breaking changes in the parent library. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 15:29:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 14:29:10 +0000 Subject: [Koha-bugs] [Bug 22446] Koha/Patron/Categories.t is failing on March 1st (2019 only?) In-Reply-To: <bug-22446-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22446-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22446-70-gz6qjFAkmk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22446 --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- *** Bug 22443 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 15:29:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 14:29:10 +0000 Subject: [Koha-bugs] [Bug 22443] t/db_dependent/Koha/Patron/Categories.t contains a DateTime maths error In-Reply-To: <bug-22443-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22443-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22443-70-rllZrOBzhU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22443 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- I agree with Jonathan.. think we should close this one as a duplicate. *** This bug has been marked as a duplicate of bug 22446 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 15:32:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 14:32:09 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20447-70-509oocz1f4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #105 from Ere Maijala <ere.maijala at helsinki.fi> --- I'm aware of that, but I'm not making the call here. I think it would be better to continue discussion about the deleted_on field in the metadata tables in bug 20271. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 15:35:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 14:35:54 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18925-70-ofDw1TGhjT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #109 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Josef Moravec from comment #108) > Just a note: The patron_maxissueqty, and maxissueqty rules represents the > same thing: it is number of max issues possible. > > There is no setting from "Default checkout, hold policy by patron category" > you can't make in the main circulation rules settings table. But as this is > the same on master and as this development leads to revamp circulation rules > setting UI, this could be fixed in the future. Hopefully the solution arise > during developing/testing... Reading your discussion with Joubu in IRC I think this is incorrect. Let say Branch A has rules for 'Patron' catgory: itype = BOOK, Current checkouts allowed = 5 itype = All, Current checkouts allowed = 5 This patron can checkout 5 books and 5 of anything else. If you also set "Default checkout, hold policy by patron category" for 'Patron' to 5 then the patron can only checkout 5 items total (e.g. 3 books, 2 anything else) The top section always checks the most specific rule and 'All' rules are really 'All not defined elsewhere' or 'Default' or 'Generic' - All is really a bad name when you look at it this way -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 15:37:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 14:37:39 +0000 Subject: [Koha-bugs] [Bug 22300] Staff search results: Opt groups in 'sort' pull down are not well formatted In-Reply-To: <bug-22300-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22300-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22300-70-UyJeBtzdiu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22300 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Okies, I take your point.. pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 15:37:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 14:37:51 +0000 Subject: [Koha-bugs] [Bug 22300] Staff search results: Opt groups in 'sort' pull down are not well formatted In-Reply-To: <bug-22300-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22300-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22300-70-XFuiAeDptA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22300 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 15:37:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 14:37:59 +0000 Subject: [Koha-bugs] [Bug 22300] Staff search results: Opt groups in 'sort' pull down are not well formatted In-Reply-To: <bug-22300-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22300-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22300-70-aAEyHE2RrF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22300 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 15:38:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 14:38:04 +0000 Subject: [Koha-bugs] [Bug 22300] Staff search results: Opt groups in 'sort' pull down are not well formatted In-Reply-To: <bug-22300-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22300-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22300-70-9vUZMwbJbG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22300 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 15:38:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 14:38:10 +0000 Subject: [Koha-bugs] [Bug 22300] Staff search results: Opt groups in 'sort' pull down are not well formatted In-Reply-To: <bug-22300-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22300-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22300-70-piVaVXB5hP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22300 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 15:42:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 14:42:44 +0000 Subject: [Koha-bugs] [Bug 22370] OPAC users should not be allowed to view staff news items In-Reply-To: <bug-22370-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22370-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22370-70-y95hUsN4IW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22370 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |martin.renvoize at ptfs-europe | |.com --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Bug against enhancement for 19.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 15:43:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 14:43:15 +0000 Subject: [Koha-bugs] [Bug 20535] ModZebra called with $record with items stripped in ModBiblioMarc In-Reply-To: <bug-20535-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20535-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20535-70-OmTdPY1D1R@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20535 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 15:43:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 14:43:18 +0000 Subject: [Koha-bugs] [Bug 20535] ModZebra called with $record with items stripped in ModBiblioMarc In-Reply-To: <bug-20535-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20535-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20535-70-vCERwelL4o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20535 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85890|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 86083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86083&action=edit Bug 20535: ModZebra called with $record with items stripped ModZebra called with $record with items stripped in ModBiblioMarc. Remove $record argument to force record to be loaded again from database with items embedded. How to test: 1) Make sure biblios are indexed (with rebuild_elastic_search.pl). 2) Perform a search that will produce a sample result containing at least one biblio with items. 3) Edit and save a biblio with items. 4) Perform the same search again, the updated biblio should now have no items when viewed in the search results (No items). 5) Apply patch. 6) Repeat step 1-3. 7) The updated biblio should now have items when viewed in the search results. Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 15:44:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 14:44:16 +0000 Subject: [Koha-bugs] [Bug 22360] On order information missing in OPAC normal display In-Reply-To: <bug-22360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22360-70-EiwLr7ybpS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22360 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize at ptfs-europe | |.com --- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 15:48:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 14:48:05 +0000 Subject: [Koha-bugs] [Bug 21560] Optimize ODS exports In-Reply-To: <bug-21560-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21560-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21560-70-WoAoAR2IZG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21560 --- Comment #24 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- > I realise the script has inlined the use statements previously, but any > chance we could use this opportunity to tidy up a little and put this at the > top of the file for consistency.. I nearly failed the patch thinking it was > missing. OK I'm on it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 15:52:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 14:52:18 +0000 Subject: [Koha-bugs] [Bug 21560] Optimize ODS exports In-Reply-To: <bug-21560-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21560-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21560-70-A8vtV95gYP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21560 --- Comment #25 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Created attachment 86084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86084&action=edit Bug 21560: (follow-up) move use at the top -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 15:56:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 14:56:53 +0000 Subject: [Koha-bugs] [Bug 21307] Switch two-column templates to Bootstrap grid: Cataloging In-Reply-To: <bug-21307-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21307-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21307-70-H8vLvGmKnO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21307 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 15:56:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 14:56:55 +0000 Subject: [Koha-bugs] [Bug 21307] Switch two-column templates to Bootstrap grid: Cataloging In-Reply-To: <bug-21307-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21307-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21307-70-CoakUkMsqa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21307 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78428|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 86085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86085&action=edit Bug 21307: Switch two-column templates to Bootstrap grid: Cataloging This patch modifies two cataloging templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from <script> tags in the modified templates and updates a couple of <script>s to use the Asset plugin. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Cataloging -> Edit record using the advanced editor - Cataloging -> Edit items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 15:56:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 14:56:58 +0000 Subject: [Koha-bugs] [Bug 21307] Switch two-column templates to Bootstrap grid: Cataloging In-Reply-To: <bug-21307-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21307-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21307-70-mh1ToRc5xc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21307 --- Comment #5 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 86086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86086&action=edit Bug 21307: (follow-up) Change the way Codemirror height is calculated This follow-up changes the way the height of the Codemirror editor is calculated. Using offset() instead of position() returns the correct values with the changed markup. To test, apply the patch and load the advanced MARC editor. The "status bar" should display correctly a the bottom of the editor and there should be no double scrollbar. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 15:59:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 14:59:05 +0000 Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve aliased fields In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19575-70-d99MqnGtVB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #95 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Pushed to 18.11.x for 18.11.04 I had a brief discussion regarding this one in IRC and we reached the consensus that we are both earlier enough in the cycle and the lifetime of the Elasticsearch use that it was a sensible one to backport even though it has further reaching effects than we would normally permit in a stable branch release. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 16:04:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 15:04:28 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18823-70-8MWAnA6yif@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 --- Comment #66 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 86087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86087&action=edit Bug 18823: Fix targets registering -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 16:04:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 15:04:50 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18823-70-vkIIZ2dxdk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 16:09:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 15:09:13 +0000 Subject: [Koha-bugs] [Bug 22228] Elasticsearch - standalone colons should be escaped when performing a search In-Reply-To: <bug-22228-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22228-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22228-70-SVcVMCkZmt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22228 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize at ptfs-europe | |.com --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 16:14:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 15:14:01 +0000 Subject: [Koha-bugs] [Bug 22404] Some labels in subscription add form has wrong parameter "for" In-Reply-To: <bug-22404-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22404-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22404-70-cwSmyaESLV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22404 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize at ptfs-europe | |.com --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 16:16:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 15:16:16 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20447-70-vpRd353OUG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85994|0 |1 is obsolete| | --- Comment #106 from Ere Maijala <ere.maijala at helsinki.fi> --- Created attachment 86088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86088&action=edit Bug 20447: MARC Holdings support Enable by setting "SummaryHoldings" option to "Use". Sponsored-by: The National Library of Finland -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 16:16:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 15:16:21 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20447-70-Dc6mhbmxSp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85995|0 |1 is obsolete| | --- Comment #107 from Ere Maijala <ere.maijala at helsinki.fi> --- Created attachment 86089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86089&action=edit Bug 20447: Add a batch rebuild script for holdings table. This script can be used to update the columns in the holdings table from the MARC record using the rules in the framework. In practice this will only be required if the koha link field is changed in the framework. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 16:16:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 15:16:26 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20447-70-nJIPvb7mSq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85996|0 |1 is obsolete| | --- Comment #108 from Ere Maijala <ere.maijala at helsinki.fi> --- Created attachment 86090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86090&action=edit Bug 20447: Add import/export support for holdings https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Adds support for importing and exporting biblios with interleaved holdings. Test plan: 1.) Import the MARCXML file attached to the bug with the -holdings parameter: misc/migration_tools/bulkmarcimport.pl -biblios -holdings -file holdings.xml -m MARCXML 2.) Verify that the holdings records were imported. 3.) Export the same records with holdings: misc/export_records.pl --record-type=bibs --starting_biblionumber 103 --ending_biblionumber 104 --filename=holdings_export.xml --format=xml --holdings 4.) Verify that both bibliographic and holding records are exported. 5.) Verify that tests in t/db_dependent/Exporter/Record.t pass. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 16:16:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 15:16:32 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20447-70-UsvRrWjzaA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85997|0 |1 is obsolete| | --- Comment #109 from Ere Maijala <ere.maijala at helsinki.fi> --- Created attachment 86091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86091&action=edit Bug 20447: DBIX schema changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 16:17:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 15:17:45 +0000 Subject: [Koha-bugs] [Bug 21722] Update C4::Accounts::chargelostitem to use Koha::Account->add_debit In-Reply-To: <bug-21722-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21722-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21722-70-byLq5kFZli@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Enhancement will not be backported to stable branch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 16:17:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 15:17:46 +0000 Subject: [Koha-bugs] [Bug 21728] Update C4::Reserves::ChargeReserveFee to use Koha::Account->add_debit In-Reply-To: <bug-21728-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21728-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21728-70-3VZLZ8EJhM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21728 Bug 21728 depends on bug 21722, which changed state. Bug 21722 Summary: Update C4::Accounts::chargelostitem to use Koha::Account->add_debit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21722 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 16:18:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 15:18:06 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20447-70-clrDKnzyWv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #110 from Ere Maijala <ere.maijala at helsinki.fi> --- Fixed item relinking and made saving a holdings record reindex its biblio record. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 16:18:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 15:18:13 +0000 Subject: [Koha-bugs] [Bug 21720] Update C4::Circulation::AddIssuingCharge to use Koha::Account->add_debit In-Reply-To: <bug-21720-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21720-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21720-70-wxcE1fT4MG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21720 Bug 21720 depends on bug 21728, which changed state. Bug 21728 Summary: Update C4::Reserves::ChargeReserveFee to use Koha::Account->add_debit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21728 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 16:18:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 15:18:13 +0000 Subject: [Koha-bugs] [Bug 21728] Update C4::Reserves::ChargeReserveFee to use Koha::Account->add_debit In-Reply-To: <bug-21728-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21728-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21728-70-lZ57rabwIs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21728 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Enhancement will not be backported to stable branch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 16:18:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 15:18:50 +0000 Subject: [Koha-bugs] [Bug 21720] Update C4::Circulation::AddIssuingCharge to use Koha::Account->add_debit In-Reply-To: <bug-21720-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21720-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21720-70-qe5tvbZIke@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21720 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Enhancement will not be backported to the stable branch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 16:18:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 15:18:50 +0000 Subject: [Koha-bugs] [Bug 21721] Update C4::Circulation::AddRenewal to use Koha::Account->add_debit In-Reply-To: <bug-21721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21721-70-2t8OPjXZRd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21721 Bug 21721 depends on bug 21720, which changed state. Bug 21720 Summary: Update C4::Circulation::AddIssuingCharge to use Koha::Account->add_debit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21720 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 16:22:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 15:22:10 +0000 Subject: [Koha-bugs] [Bug 22458] New: PatronSelfRegistrationEmailMustBeUnique disallows self modification requests if multiple accounts share an email address Message-ID: <bug-22458-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22458 Bug ID: 22458 Summary: PatronSelfRegistrationEmailMustBeUnique disallows self modification requests if multiple accounts share an email address Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: jrobb at sekls.org QA Contact: testopia at bugs.koha-community.org Target Milestone: --- PatronSelfRegistrationEmailMustBeUnique causes unexpected behavior on the patron self modification screen ("your personal details") in the OPAC. When enabled, the system preference blocks existing accounts from submitting account modification requests if the primary email associated with the account is also associated with another account in the database. This means if a parent account and a child account both use the same email address, neither can submit account modification requests via the OPAC. This system preference should only affect new self registered accounts. To reproduce this behavior: 1. Set PatronSelfRegistrationEmailMustBeUnique to 'Consider' 2. Create two different accounts with the same primary email address 3. Log into the OPAC with either account 4. Visit "your personal details" 5. Make a change unrelated to email address and submit 6. The submission is blocked with a message about duplicate email addresses -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 16:23:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 15:23:26 +0000 Subject: [Koha-bugs] [Bug 22287] Correct new charts CSS In-Reply-To: <bug-22287-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22287-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22287-70-CtmRVMCGfB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22287 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> --- missing 22168 in 18.05.x series. won't backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 16:26:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 15:26:36 +0000 Subject: [Koha-bugs] [Bug 16113] Specify due date for batch check out In-Reply-To: <bug-16113-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16113-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16113-70-ep8yxaqwye@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16113 BASE Library Consortium <baselibrary.consortium at nhs.net> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC| |baselibrary.consortium at nhs. | |net --- Comment #1 from BASE Library Consortium <baselibrary.consortium at nhs.net> --- Duplicate of Bug 16748 *** This bug has been marked as a duplicate of bug 16748 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 16:26:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 15:26:36 +0000 Subject: [Koha-bugs] [Bug 16748] Batch checkout needs set due date In-Reply-To: <bug-16748-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16748-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16748-70-alxXtBxrJy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16748 BASE Library Consortium <baselibrary.consortium at nhs.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca --- Comment #6 from BASE Library Consortium <baselibrary.consortium at nhs.net> --- *** Bug 16113 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 16:29:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 15:29:17 +0000 Subject: [Koha-bugs] [Bug 12488] Make bulkmarcimport.pl -d use DELETE instead of TRUNCATE In-Reply-To: <bug-12488-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12488-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12488-70-JH9ZEedP9G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12488 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #21 from Lucas Gass <lucas at bywatersolutions.com> --- backported to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 16:29:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 15:29:36 +0000 Subject: [Koha-bugs] [Bug 20747] Allow LocalHoldsPriority to fill by hierarchical groups system rather than individual library In-Reply-To: <bug-20747-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20747-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20747-70-qd4YMgYgmw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 --- Comment #2 from Lisette Scheer <lisetteslatah at gmail.com> --- LocalHoldsPriority currently looks only at home library. We would like if it could look at groups and look first at the whole group then outside the group for priority. Example: MOS and TRO are in group together and LAP is not in the same group. MOS has the only copy of a new book and the holds are: 1. MOS patron 2. LAP patron1 3. LAP patron2 4. TRO patron We would like it to fill: 1. MOS Patron 2. TRO Patron 3. LAP patron1 4. LAP patron2 Assuming no additional holds were place by MOS or TRO patrons before it got to LAP. Another Example might be if LAP also had a copy but the order of holds was: 1. MOS patron 2. LAP patron1 3. TRO patron 4. LAP patron2 The 2 copies could bounce around between the 3 branches taking extra courier time (LAP to TRO has to take 3 different courier routes, LAP to MOS 2) but with what we would like, the MOS copy would fill for MOS and then TRO (1 courier route) then go out to the consortium and the LAP one could stay in LAP (or its group) before going out to the consortium, potentially cutting down wait time for branches where their group has purchased copies. I may have it wrong, but it looks like bug 22284 would prevent the holds from going out of the groups? That isn't what we would want, as we still want our items to be able to go out of the district once holds for our district have been filled. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 16:35:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 15:35:58 +0000 Subject: [Koha-bugs] [Bug 20535] ModZebra called with $record with items stripped in ModBiblioMarc In-Reply-To: <bug-20535-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20535-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20535-70-icDtxqgX3E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20535 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Maybe we should remove this parameter from ModZebra? And improve ModZebra in that case, it calls GetMarcBiblio without testing $server. (On a separate bug report of course) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 16:41:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 15:41:40 +0000 Subject: [Koha-bugs] [Bug 16149] Generate and send custom notices based on report output In-Reply-To: <bug-16149-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16149-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16149-70-BwaStswlq9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 Margaret <margaret at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |margaret at bywatersolutions.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 16:42:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 15:42:10 +0000 Subject: [Koha-bugs] [Bug 22142] An item's current location changes to blank when it is removed from Course Reserves In-Reply-To: <bug-22142-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22142-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22142-70-2S1dNlvxll@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22142 Patrick Robitaille <patrick.robitaille at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 16:46:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 15:46:36 +0000 Subject: [Koha-bugs] [Bug 22456] Customers Cancelling their Pending Holds In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22456-70-Y6tFFBCAFP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Lisette Scheer <lisetteslatah at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 16:48:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 15:48:14 +0000 Subject: [Koha-bugs] [Bug 22200] Forgiving a fine (FFOR) does not update the accountline date In-Reply-To: <bug-22200-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22200-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22200-70-zt64ZCMeh9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22200 --- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> --- I think we're barking up the wrong tree here. At this time, I think updating the date column is a *bad* idea. It is our 'created on' date, and timestamp is our 'last updated on' date. Really, we shouldn't be changing the fee type to FFOR, we should be generating a FFOR payment and applying it to the fee. I'm going to ask Tomas to chime in. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 16:59:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 15:59:57 +0000 Subject: [Koha-bugs] [Bug 10676] OpacHiddenItems not working for restricted on OPAC detail In-Reply-To: <bug-10676-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10676-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10676-70-iVMribSbAg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10676 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #32 from Lucas Gass <lucas at bywatersolutions.com> --- backported to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 17:03:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 16:03:05 +0000 Subject: [Koha-bugs] [Bug 13420] Holdings table sorting on volume information incorrect In-Reply-To: <bug-13420-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13420-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13420-70-WHyI4ESo3p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13420 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Would it make sense to sort by published dates? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 17:08:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 16:08:53 +0000 Subject: [Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2 In-Reply-To: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17140-70-QDaEeWFH9M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #35 from Josef Moravec <josef.moravec at gmail.com> --- (In reply to Jonathan Druart from comment #34) > I am not against a quick fix, but things are weird (with or without the > patch): > > Add a 1.035 fine, you see: > https://snag.gy/hmFX51.jpg > > Go to make a payment, you see: > https://snag.gy/0MuCxY.jpg > > Click "Pay", you see: > https://snag.gy/bA5O3C.jpg > > If we push this as it, we should ask have people to focus on a global > solution. Yes, it is definitely bad, and I thought, that we should push this and work on better general solutions, but thinking about this again: we should not push this, because it silently pay different amount then expected. The quick fix should be just show warning there is something wrong with some advice probably (like, writeoff an debit when it looks like zero, maybe...) Or, if we are able to fix it right until 19.05, then we should do it... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 17:26:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 16:26:09 +0000 Subject: [Koha-bugs] [Bug 22459] New: Shibboleth create/sync: Allow mapping of extended patron attributes Message-ID: <bug-22459-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22459 Bug ID: 22459 Summary: Shibboleth create/sync: Allow mapping of extended patron attributes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org Depends on: 18507 Target Milestone: --- It woudl be great if extended patron attributes could be mapped for provisioning with Shibboleth as well. One use case would be a unique key, that is also used/neded for patron imports and stored in an unique extended patron attribute. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18507 [Bug 18507] Shibboleth auto-provisioning - Sync -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 17:26:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 16:26:09 +0000 Subject: [Koha-bugs] [Bug 18507] Shibboleth auto-provisioning - Sync In-Reply-To: <bug-18507-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18507-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18507-70-vdI0T7Av5g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18507 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22459 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22459 [Bug 22459] Shibboleth create/sync: Allow mapping of extended patron attributes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 17:33:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 16:33:49 +0000 Subject: [Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2 In-Reply-To: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17140-70-wzA9uCdJrJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 --- Comment #36 from Blou <philippe.blouin at inlibro.com> --- To quote "if we are able to fix it right until 19.05, then we should do it..." This was opened in 2016, so good luck with that. It IS a complicated issue to fix right. The patch allows librarian to move ahead when this occurs whereas a popup will just tell them they are not crazy, but leave them helpless again. In our production environments, it has occured a few times (to much frustration and bewilderment, and never a complaint since we put the patch on, even though the discremencies in the UI a quite obvious). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 17:47:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 16:47:49 +0000 Subject: [Koha-bugs] [Bug 22430] importing from a UNIMARC backup will import biblio records but not items In-Reply-To: <bug-22430-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22430-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22430-70-HAE5vH7wYD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22430 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- What is a backup in this context? I have exported the records then imported them in a fresh DB. I got: MARC staging results : Processing bibliographic records 1 records in file 0 records not staged because of MARC error 1 records staged Did not check for matches with existing records in catalog 5 item records found and staged then: MariaDB [koha_kohadev]> select count(*) from items; +----------+ | count(*) | +----------+ | 5 | +----------+ All looks good for me (items are displayed on the detail page of the bibliographic record). Tested with UNIMARC. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 17:49:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 16:49:15 +0000 Subject: [Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive In-Reply-To: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18723-70-TUBmVHAeyV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 --- Comment #42 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Applying the previous patch (Backport for 18.05) on top of current 17.11.x (tag v17.11.16) works. Test plan "ran" successfully. Lucas, Frido: is there anything else doable to help landing in 18.05.x and 17.11.x ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 17:52:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 16:52:13 +0000 Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request datatable to be customisable In-Reply-To: <bug-21063-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21063-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21063-70-EkJwzLe9cI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #50 from Josef Moravec <josef.moravec at gmail.com> --- (In reply to Andrew Isherwood from comment #49) > >cost > I cannot replicate this, cost is displaying fine for me My mistake, cost is ok -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 17:52:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 16:52:35 +0000 Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request datatable to be customisable In-Reply-To: <bug-21063-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21063-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21063-70-2aDIEx7R22@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 17:58:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 16:58:41 +0000 Subject: [Koha-bugs] [Bug 22453] TestBuilder should generate now() using the current timezone In-Reply-To: <bug-22453-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22453-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22453-70-4bvk93a6HR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22453 --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- % more build_date.pl use Modern::Perl; use t::lib::TestBuilder; my $builder = t::lib::TestBuilder->new; my $patron = $builder->build_object( { class => 'Koha::Patrons' } ); say $patron->updated_on; say `date`; % perl build_date.pl 2019-03-05 16:57:57 Tue Mar 5 13:57:57 -03 2019 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 17:58:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 16:58:50 +0000 Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request datatable to be customisable In-Reply-To: <bug-21063-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21063-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21063-70-j8a0qlSWY0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 17:58:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 16:58:53 +0000 Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request datatable to be customisable In-Reply-To: <bug-21063-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21063-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21063-70-dRKiwhg7qm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84786|0 |1 is obsolete| | Attachment #84787|0 |1 is obsolete| | Attachment #84788|0 |1 is obsolete| | Attachment #84789|0 |1 is obsolete| | Attachment #84790|0 |1 is obsolete| | Attachment #84862|0 |1 is obsolete| | Attachment #85854|0 |1 is obsolete| | Attachment #85869|0 |1 is obsolete| | Attachment #85889|0 |1 is obsolete| | Attachment #85893|0 |1 is obsolete| | Attachment #85894|0 |1 is obsolete| | Attachment #85896|0 |1 is obsolete| | Attachment #86060|0 |1 is obsolete| | --- Comment #51 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86092&action=edit Bug 21063: Add "Columns settings" for ILL This patch adds the "Columns settings" values for the illrequests table Signed-off-by: Niamh.Walker-Headon at it-tallaght.ie Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 17:58:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 16:58:59 +0000 Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request datatable to be customisable In-Reply-To: <bug-21063-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21063-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21063-70-KB3kHh1wkG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 --- Comment #52 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86093&action=edit Bug 21063: Add ability to show / hide columns This patch adds the "Column visibility" functionality to the main ILL request list table. To test: - Ensure ILL is enabled and you have some requests - Apply patch - From the "Koha administration screen, select "Configure columns" - In the "Columns settings" page: => TEST: Ensure an "Interlibrary loans" category exists - Upon expanding the category: => TEST: Ensure a table is displayed showing columns => TEST: Ensure the "action" column has "Cannot be toggled" pre-selected => TEST: Change values for columns and ensure they're saved - From the main staff menu, select "ILL requests" - In the table: => TEST: Click the "Column visibility" button and ensure a modal containing all columns (except "Action") is displayed => TEST: Select various columns and ensure they are shown and hidden Signed-off-by: Niamh.Walker-Headon at it-tallaght.ie Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 17:59:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 16:59:03 +0000 Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request datatable to be customisable In-Reply-To: <bug-21063-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21063-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21063-70-wg5m1Gce5M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 --- Comment #53 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86094&action=edit Bug 21063: (follow-up) Add user ID to column list As originally specified in bug 20883, there is a requirement for some users to be able to display the user ID (borrowernumber) in the UI. This patch adds that ability to this bug, 20883 will be marked as a duplicate of this one. Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 17:59:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 16:59:08 +0000 Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request datatable to be customisable In-Reply-To: <bug-21063-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21063-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21063-70-YooWOG2m22@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 --- Comment #54 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86095&action=edit Bug 21063: (follow-up) Amendments for rebase Modify to add the additional changes required now we're rebasing on top of the dependency tree. Includes adding additional columns (and changing indexes for search/filter where appropriate) Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 17:59:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 16:59:13 +0000 Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request datatable to be customisable In-Reply-To: <bug-21063-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21063-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21063-70-y4Ef7VWpOd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 --- Comment #55 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86096&action=edit Bug 21063: (follow-up) Add comments to column list Since this bug is now dependent on Bug 18591 (Allow an arbitrary number of comments on ILLs) we need to add the comments column to this table and the list of selectable columns. This patch does this. Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 17:59:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 16:59:18 +0000 Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request datatable to be customisable In-Reply-To: <bug-21063-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21063-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21063-70-BqqG65dqYZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 --- Comment #56 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86097&action=edit Bug 21063: (follow-up) Sanitize datatable data This mitigates bug 22268 by sanitizing data prior to display using the built in $.fn.dataTable.render.text() helper provided by Datatables. The patch was added here, rather that in 22268 since this is the bug that introduced the problem by increasing the number of fields that are displayed in the table, some of which could contain user provided malicious data Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 17:59:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 16:59:23 +0000 Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request datatable to be customisable In-Reply-To: <bug-21063-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21063-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21063-70-y0ZCFv19Xh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 --- Comment #57 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86098&action=edit Bug 21063: (follow-up) Fix bad rebase in javascript Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 17:59:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 16:59:28 +0000 Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request datatable to be customisable In-Reply-To: <bug-21063-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21063-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21063-70-gvdqbsL4oa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 --- Comment #58 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86099&action=edit Bug 21063: (follow-up) Fix rebase problems A couple of minor rebase problems resolved Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 17:59:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 16:59:33 +0000 Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request datatable to be customisable In-Reply-To: <bug-21063-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21063-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21063-70-03n4v3PdQl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 --- Comment #59 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86100&action=edit Bug 21063: Add more tests Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 17:59:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 16:59:39 +0000 Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request datatable to be customisable In-Reply-To: <bug-21063-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21063-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21063-70-vg2UVsdTCP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 --- Comment #60 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86101&action=edit Bug 21063: (follow-up) borrowernumber -> patron_id As per comment #36 here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063#c36 Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 17:59:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 16:59:44 +0000 Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request datatable to be customisable In-Reply-To: <bug-21063-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21063-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21063-70-YPmpSV8HHe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 --- Comment #61 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86102&action=edit Bug 21063: (follow-up) Fix more rebase problems More minor rebase problems fixed Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 17:59:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 16:59:48 +0000 Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request datatable to be customisable In-Reply-To: <bug-21063-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21063-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21063-70-HjsAFuHhsX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 --- Comment #62 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86103&action=edit Bug 21063: (follow-up) Make patron col consistent As per comment #44 here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063#c44 Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 17:59:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 16:59:54 +0000 Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request datatable to be customisable In-Reply-To: <bug-21063-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21063-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21063-70-QPkrY1pWYI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 --- Comment #63 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86104&action=edit Bug 21063: (follow-up) Fix missing table values As per comment #48 here: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063#c48 >pages This was a misnamed property in colums_settings.yml >comments This was a missing embed in the API call, probably a rebase error >article (part title) This was a bug. A combination of a misnamed property in columns_settings.yml and a missing "render" method on the datatable >completed on This was an oversight and had apparently never worked. It has now been added >cost I cannot replicate this, cost is displaying fine for me Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 17:59:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 16:59:59 +0000 Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request datatable to be customisable In-Reply-To: <bug-21063-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21063-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21063-70-OtQccPpl2O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 --- Comment #64 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86105&action=edit Bug 21063: (QA follow-up) Fix terminology Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 18:00:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 17:00:05 +0000 Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request datatable to be customisable In-Reply-To: <bug-21063-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21063-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21063-70-2vGNst5WmH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 --- Comment #65 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86106&action=edit Bug 21063: (QA follow-up) Remove debug message Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 18:01:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 17:01:58 +0000 Subject: [Koha-bugs] [Bug 18837] Add an unmediated Interlibrary Loans workflow In-Reply-To: <bug-18837-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18837-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18837-70-LcVU8MaQTG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #17 from Josef Moravec <josef.moravec at gmail.com> --- Could you rebase please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 18:07:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 17:07:32 +0000 Subject: [Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2 In-Reply-To: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17140-70-SSkNnPEW3Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 --- Comment #37 from Josef Moravec <josef.moravec at gmail.com> --- (In reply to Blou from comment #36) > To quote "if we are able to fix it right until 19.05, then we should do > it..." > > This was opened in 2016, so good luck with that. It IS a complicated issue > to fix right. > > The patch allows librarian to move ahead when this occurs whereas a popup > will just tell them they are not crazy, but leave them helpless again. > > In our production environments, it has occured a few times (to much > frustration and bewilderment, and never a complaint since we put the patch > on, even though the discremencies in the UI a quite obvious). I understand you.... But your patch could lead to bugs in fine reports, couldn't it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 18:08:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 17:08:20 +0000 Subject: [Koha-bugs] [Bug 22377] Lost fines may not be refunded if another patron has a writeoff for the same item In-Reply-To: <bug-22377-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22377-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22377-70-6ZVCJEktFD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22377 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Do you have the rule defined? It seems that it is not created on install. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 18:15:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 17:15:15 +0000 Subject: [Koha-bugs] [Bug 22303] Wrong bottom in virtualshelves/addbybiblionumber.tt In-Reply-To: <bug-22303-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22303-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22303-70-6CXJXMVQ6F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22303 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85924|0 |1 is obsolete| | --- Comment #7 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86107&action=edit Bug 22303: Correct bottom in virtualshelves/addbybiblionumber.tt In virtualshelves/addbybiblionumber.tt the include intranet-bottom.inc which closes the HTML last tag is not the last line of the template. This patch moved bottom include to last line and uses popup-bottom.inc. Test plan : 1) Permission OK : 1.1) Login in staff interface with user 'Bob' 1.2) Create a new list 'Readme' : category public and allow changes to contents from anyone 1.3) Perform a search 1.4) Check some results 1.5) Click 'Add to list' and on the list 'Readme' 1.6) A popup window opens 1.7) Check its HTML is OK, ending with </html> 2) Permission KO : 2.1) Open a new window (Firefox private session) and login in staff interface with user 'Bill' 2.2) Perform a search 2.3) Check some results 2.4) On session of 'Bob', edit list 'Readme' 2.5) Change : category private and allow changes to contents from owner only 2.6) On session of 'Bill' 2.7) Click 'Add to list' and on the list 'Readme' 2.8) A popup window opens saying 'Sorry, you do not have permission to add items to this list' 2.9) Check its HTML is OK, ending with </html> Signed-off-by: Maryse Simard <maryse.simard at inlibro.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 18:15:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 17:15:43 +0000 Subject: [Koha-bugs] [Bug 22303] Wrong bottom in virtualshelves/addbybiblionumber.tt In-Reply-To: <bug-22303-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22303-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22303-70-6BflEmZptz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22303 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 18:22:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 17:22:05 +0000 Subject: [Koha-bugs] [Bug 14708] The patron set as the anonymous patron should not be deletable. In-Reply-To: <bug-14708-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14708-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14708-70-RlyiUxmKoZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14708 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |josef.moravec at gmail.com --- Comment #6 from Josef Moravec <josef.moravec at gmail.com> --- (In reply to Jonathan Druart from comment #5) > Hi Kyle, > At first glance I'd say tools/cleanborrowers.pl is missing. > Maybe we should have this constraint in Koha::Patron->delete/move_to_deleted > to make sure we are covering all cases? Definitey... Another place could merging patrons.... so hard to not forget anything... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 18:30:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 17:30:56 +0000 Subject: [Koha-bugs] [Bug 22416] Search.t tests need adjustment for EasyAnalyticRecords syspref In-Reply-To: <bug-22416-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22416-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22416-70-mCRtqfK6pY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22416 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 18:31:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 17:31:02 +0000 Subject: [Koha-bugs] [Bug 22416] Search.t tests need adjustment for EasyAnalyticRecords syspref In-Reply-To: <bug-22416-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22416-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22416-70-XOyjjzrJHp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22416 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86108&action=edit Bug 22416: (bug 22140 follow-up) Remove warnings in Search.t Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 18:31:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 17:31:39 +0000 Subject: [Koha-bugs] [Bug 22416] Search.t tests need adjustment for EasyAnalyticRecords syspref In-Reply-To: <bug-22416-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22416-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22416-70-zXfI7gnavo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22416 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 18:31:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 17:31:32 +0000 Subject: [Koha-bugs] [Bug 22416] Search.t tests need adjustment for EasyAnalyticRecords syspref In-Reply-To: <bug-22416-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22416-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22416-70-X1dZMI5GHY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22416 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|fridolin.somers at biblibre.co |jonathan.druart at bugs.koha-c |m |ommunity.org Status|Needs Signoff |Signed Off CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Trivial patch, sending to PQA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 18:41:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 17:41:09 +0000 Subject: [Koha-bugs] [Bug 18337] No results found when advanced searching branches In-Reply-To: <bug-18337-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18337-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18337-70-BDtNXRhzbj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18337 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 18:43:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 17:43:22 +0000 Subject: [Koha-bugs] [Bug 21307] Switch two-column templates to Bootstrap grid: Cataloging In-Reply-To: <bug-21307-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21307-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21307-70-1yOzpngpNY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21307 --- Comment #6 from Josef Moravec <josef.moravec at gmail.com> --- Comment on attachment 86085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86085 Bug 21307: Switch two-column templates to Bootstrap grid: Cataloging Review of attachment 86085: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=21307&attachment=86085) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/additem.tt @@ +378,5 @@ > + </div> <!-- /.col-sm-10.col-sm-push-2 --> > + > + <div class="col-sm-2 col-sm-pull-10"> > + <aside> > + [% INCLUDE 'admin-menu.inc' %] This should be deleted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 19:15:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 18:15:01 +0000 Subject: [Koha-bugs] [Bug 22419] removing multiple items from basket.pl causes browser timeout In-Reply-To: <bug-22419-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22419-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22419-70-thyuzBvvCz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22419 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Depends on| |19290 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Caused by commit c9a7b6742b970d1e605f84ff001f609ddda8eaa2 Bug 19290: Browse selected bibliographic records - Staff interface Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19290 [Bug 19290] Browse selected biblios - Staff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 19:15:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 18:15:01 +0000 Subject: [Koha-bugs] [Bug 19290] Browse selected biblios - Staff In-Reply-To: <bug-19290-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19290-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19290-70-dtBvtgljkU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19290 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22419 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22419 [Bug 22419] removing multiple items from basket.pl causes browser timeout -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 19:15:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 18:15:11 +0000 Subject: [Koha-bugs] [Bug 22419] removing multiple items from basket.pl causes browser timeout In-Reply-To: <bug-22419-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22419-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22419-70-NGekpoXYdT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22419 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 19:18:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 18:18:32 +0000 Subject: [Koha-bugs] [Bug 21307] Switch two-column templates to Bootstrap grid: Cataloging In-Reply-To: <bug-21307-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21307-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21307-70-LxQFRUDKCF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21307 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com --- Comment #7 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86109&action=edit Rancor glitch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 19:18:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 18:18:57 +0000 Subject: [Koha-bugs] [Bug 21307] Switch two-column templates to Bootstrap grid: Cataloging In-Reply-To: <bug-21307-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21307-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21307-70-57dmIL0kOe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21307 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 19:21:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 18:21:48 +0000 Subject: [Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2 In-Reply-To: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17140-70-CTVOh0TiUW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 --- Comment #38 from Blou <philippe.blouin at inlibro.com> --- Interesting. Showing the extent of what to consider for a complete solution. That said, I wouldn't call it a "bug". The report would still work, but have a 0.005 discrepancy somewhere, right? To which I would oppose a 9$ discrepency because the staff could never enter the payment made by the borrower in the other case. I'm not particularly attached to this solution, I argue for the sake of the staff users who have encountered the problem, and I believe this is the lesser of two evils (the other one being the status quo). If Evil is against your policy, that's ok too... :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 19:21:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 18:21:57 +0000 Subject: [Koha-bugs] [Bug 22419] removing multiple items from basket.pl causes browser timeout In-Reply-To: <bug-22419-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22419-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22419-70-5DDBfjSWQl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22419 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 19:23:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 18:23:46 +0000 Subject: [Koha-bugs] [Bug 22419] removing multiple items from basket.pl causes browser timeout In-Reply-To: <bug-22419-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22419-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22419-70-AaDukrct3k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22419 --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86110&action=edit Bug 22419: Records listed twice when select/unselect all from the cart It fixes a browser timeout when records are removed from the cart. The onchange event already call selRecord. Test plan: Launch a search Add all the result to your cart Open the cart Click "select all" Then remove them all from your cart => Without this patch the action will timeout => With this patch applied the action is immediate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 19:28:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 18:28:11 +0000 Subject: [Koha-bugs] [Bug 22451] Asset plugin is using the version from the DB In-Reply-To: <bug-22451-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22451-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22451-70-HBL0ju2eFB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22451 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/includes/installer-doc-head-close.inc). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 19:33:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 18:33:10 +0000 Subject: [Koha-bugs] [Bug 22451] Asset plugin is using the version from the DB In-Reply-To: <bug-22451-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22451-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22451-70-btOOzV1DG7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22451 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff Depends on| |20658 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658 [Bug 20658] Move template JavaScript to the footer: Installer and onboarding -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 19:33:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 18:33:10 +0000 Subject: [Koha-bugs] [Bug 20658] Move template JavaScript to the footer: Installer and onboarding In-Reply-To: <bug-20658-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20658-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20658-70-QNKzSb3HxE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22451 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22451 [Bug 22451] Asset plugin is using the version from the DB -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 19:39:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 18:39:33 +0000 Subject: [Koha-bugs] [Bug 21030] Date widget on suspend modal not working correctly In-Reply-To: <bug-21030-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21030-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21030-70-BvaYMNUqHB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21030 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 19:39:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 18:39:36 +0000 Subject: [Koha-bugs] [Bug 21030] Date widget on suspend modal not working correctly In-Reply-To: <bug-21030-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21030-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21030-70-PRQhfgmATy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21030 --- Comment #4 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 86111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86111&action=edit Bug 21030: Date widget on suspend modal not working correctly This patch makes a change to the suspend hold modal markup in order to allow the datepicker <selects> to work properly. To test, apply the patch and locate a patron in the staff client who has holds. - On the checkout or patron detail page, open the holds tab. - Click the "Suspend" button for one of the holds. - In the modal, trigger the date picker and confirm that the dropdowns for selecting month and year work correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 19:40:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 18:40:41 +0000 Subject: [Koha-bugs] [Bug 19428] I cannot change the item type of a record in edit item page without changinging the item type in record. In-Reply-To: <bug-19428-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19428-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19428-70-666iUWUQ9b@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19428 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 19:43:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 18:43:21 +0000 Subject: [Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS In-Reply-To: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19474-70-ggZShgjN41@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #72 from Owen Leonard <oleonard at myacpl.org> --- *** Bug 11896 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 19:43:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 18:43:21 +0000 Subject: [Koha-bugs] [Bug 11896] add tools for compiling LESS files In-Reply-To: <bug-11896-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11896-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11896-70-SUa0PqPpyo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11896 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #4 from Owen Leonard <oleonard at myacpl.org> --- *** This bug has been marked as a duplicate of bug 19474 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 19:44:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 18:44:44 +0000 Subject: [Koha-bugs] [Bug 22451] Asset plugin is using the version from the DB In-Reply-To: <bug-22451-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22451-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22451-70-AANF5y3B1H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22451 --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- 1. I'd say there is a dot missing: $1$2$3 should be $1.$2$3 to match the value in the DB 2. I do not understand the changes in the tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 19:55:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 18:55:51 +0000 Subject: [Koha-bugs] [Bug 21457] datelastseen and datelastborrowed out of sync In-Reply-To: <bug-21457-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21457-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21457-70-B38M0dNVaz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21457 --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Sorry I do not have any ideas, the code looks ok. Maybe in September 2018 the Koha version was older? What is the % of items with this problem? Does it still happen? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 19:57:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 18:57:20 +0000 Subject: [Koha-bugs] [Bug 7890] Highlight required field in MARC editor In-Reply-To: <bug-7890-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7890-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7890-70-5a9tF6m3t6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7890 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|highlight required in |Highlight required field in |yellow |MARC editor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 20:00:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 19:00:47 +0000 Subject: [Koha-bugs] [Bug 22399] Improve responsive behavior of the basic marc editor In-Reply-To: <bug-22399-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22399-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22399-70-G93BzMJ5R0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7890 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7890 [Bug 7890] Highlight required field in MARC editor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 20:00:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 19:00:47 +0000 Subject: [Koha-bugs] [Bug 7890] Highlight required field in MARC editor In-Reply-To: <bug-7890-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7890-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7890-70-NHTRgaDsF6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7890 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22399 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 [Bug 22399] Improve responsive behavior of the basic marc editor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 20:01:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 19:01:09 +0000 Subject: [Koha-bugs] [Bug 7890] Highlight required field in MARC editor In-Reply-To: <bug-7890-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7890-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7890-70-jQBsAK2D1y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7890 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 20:01:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 19:01:11 +0000 Subject: [Koha-bugs] [Bug 7890] Highlight required field in MARC editor In-Reply-To: <bug-7890-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7890-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7890-70-BjluOGkDvU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7890 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 86112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86112&action=edit Bug 7890: Highlight required field in MARC editor This patch modifies the basic MARC editor so that required fields have the standard "Required" label on them instead of a small red asterisk. To test, apply the patch and create a new record in the basic MARC editor. Tags which are marked mandatory in your selected MARC bibliographic framework should be labeled "Required." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 20:04:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 19:04:05 +0000 Subject: [Koha-bugs] [Bug 22419] removing multiple items from basket.pl causes browser timeout In-Reply-To: <bug-22419-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22419-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22419-70-HmzKEOQ1SS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22419 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86110|0 |1 is obsolete| | --- Comment #3 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 86113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86113&action=edit Bug 22419: Records listed twice when select/unselect all from the cart It fixes a browser timeout when records are removed from the cart. The onchange event already call selRecord. Test plan: Launch a search Add all the result to your cart Open the cart Click "select all" Then remove them all from your cart => Without this patch the action will timeout => With this patch applied the action is immediate Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 20:11:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 19:11:29 +0000 Subject: [Koha-bugs] [Bug 21316] Adding controlfields to the ACQ framework causes issues when adding to basket In-Reply-To: <bug-21316-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21316-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21316-70-jPxnW4j9YZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21316 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 20:11:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 19:11:42 +0000 Subject: [Koha-bugs] [Bug 21316] Adding controlfields to the ACQ framework causes issues when adding to basket In-Reply-To: <bug-21316-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21316-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21316-70-b56MyCUBAk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21316 --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86114&action=edit Bug 21316: Handle control fields in the ACQ frameworks Test plan: Turn UseACQFrameworkForBiblioRecords on Add 003@ to the ACQ framework Create an order from an existing record => The 003 value will be displayed! It fixes the following error: Control fields (generally, just tags below 010) do not have subfields, use data() at /home/vagrant/kohaclone/acqui/neworderempty.pl line 293. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 20:11:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 19:11:54 +0000 Subject: [Koha-bugs] [Bug 21316] Adding controlfields to the ACQ framework causes issues when adding to basket In-Reply-To: <bug-21316-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21316-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21316-70-VsDvSOa4vE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21316 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 20:14:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 19:14:44 +0000 Subject: [Koha-bugs] [Bug 21591] Data inconsistencies - Item types and biblio level In-Reply-To: <bug-21591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21591-70-RDRPVL8Tx3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21591 --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- IMO we should not hide/skip something in this script. We display possible issues, if you are aware of them you can just ignore it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 20:15:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 19:15:20 +0000 Subject: [Koha-bugs] [Bug 21591] Data inconsistencies - Item types and biblio level In-Reply-To: <bug-21591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21591-70-YtpaXrIJpS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21591 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #2) > What about NULL vs ''? > > I think we should alert if '', do not you think? Failing QA to get an answer ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 20:30:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 19:30:11 +0000 Subject: [Koha-bugs] [Bug 22451] Asset plugin is using the version from the DB In-Reply-To: <bug-22451-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22451-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22451-70-RdJWVqeRpm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22451 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86034|0 |1 is obsolete| | Attachment #86035|0 |1 is obsolete| | Attachment #86036|0 |1 is obsolete| | --- Comment #6 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86115&action=edit Bug 22451: Make Asset plugin use Koha::version instead of version from db Test plan: Apply the patch a try to use Koha, css and js files should be used normally -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 20:30:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 19:30:15 +0000 Subject: [Koha-bugs] [Bug 22451] Asset plugin is using the version from the DB In-Reply-To: <bug-22451-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22451-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22451-70-pk7YFN8YBo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22451 --- Comment #7 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86116&action=edit Bug 22451: Update test Test plan: prove t/db_dependent/Koha/Template/Plugin/Asset.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 20:30:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 19:30:19 +0000 Subject: [Koha-bugs] [Bug 22451] Asset plugin is using the version from the DB In-Reply-To: <bug-22451-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22451-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22451-70-8eYGasqmzj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22451 --- Comment #8 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86117&action=edit Bug 22451: Use Asset everywhere Test plan: Use installer and onboaarding tool, make sure the js and css files are loaded -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 20:31:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 19:31:33 +0000 Subject: [Koha-bugs] [Bug 22451] Asset plugin is using the version from the DB In-Reply-To: <bug-22451-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22451-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22451-70-BLh24sR81u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22451 --- Comment #9 from Josef Moravec <josef.moravec at gmail.com> --- (In reply to Jonathan Druart from comment #5) > 1. I'd say there is a dot missing: > $1$2$3 should be $1.$2$3 to match the value in the DB $1 is for first two version parts with dot... so dot is here, but I agree it is not obvious... maybe better to format regex with 4 parts to make it better readable - i updated the first patch > > 2. I do not understand the changes in the tests. When database is not fully updated, then the test could fail if using version preference... maybe a bit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 21:07:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 20:07:56 +0000 Subject: [Koha-bugs] [Bug 21466] Data inconsistencies - items.location values must have a corresponding authorised value In-Reply-To: <bug-21466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21466-70-V6YuRIdVCa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21466 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 21:08:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 20:08:21 +0000 Subject: [Koha-bugs] [Bug 21466] Data inconsistencies - items.location values must have a corresponding authorised value In-Reply-To: <bug-21466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21466-70-a9ueFomhnV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21466 --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86118&action=edit Bug 21466: Catch any values that should be defined in the AV but are not Let's expand the idea of the first patch to catch the wrong values for any others AV. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 21:09:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 20:09:55 +0000 Subject: [Koha-bugs] [Bug 21466] Data inconsistencies - koha fields linked to AV cat values must have a corresponding authorised value In-Reply-To: <bug-21466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21466-70-waDEmqoh6N@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21466 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Data inconsistencies - |Data inconsistencies - koha |items.location values must |fields linked to AV cat |have a corresponding |values must have a |authorised value |corresponding authorised | |value -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 21:09:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 20:09:57 +0000 Subject: [Koha-bugs] [Bug 22303] Wrong bottom in virtualshelves/addbybiblionumber.tt In-Reply-To: <bug-22303-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22303-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22303-70-dIQFkeZi6u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22303 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|hayleymapley at catalyst.net.n |oleonard at myacpl.org |z | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 21:31:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 20:31:23 +0000 Subject: [Koha-bugs] [Bug 19302] Pass objects to IsAvailableForItemLevelRequest In-Reply-To: <bug-19302-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19302-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19302-70-E2jnvBGDTR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19302 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 21:31:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 20:31:33 +0000 Subject: [Koha-bugs] [Bug 19302] Pass objects to IsAvailableForItemLevelRequest In-Reply-To: <bug-19302-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19302-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19302-70-Nu02UVByeK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19302 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #68845|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86119&action=edit Bug 19302: Send koha::objects to C4::Reserves::IsAvailableForItemLevelRequest Almost everywhere we call IsAvailableForItemLevelRequest we already have a Koha::Patron and Koha::Item object. It makes sense to use them to avoid a refetch Test plan: It would be good to test this patch on top of 19300 and 19301 and make sure everything works as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 21:37:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 20:37:37 +0000 Subject: [Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13895-70-YU55W5xsrN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Michal Denar <black23 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 21:37:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 20:37:40 +0000 Subject: [Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13895-70-ST0PAQMICb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Michal Denar <black23 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85676|0 |1 is obsolete| | --- Comment #68 from Michal Denar <black23 at gmail.com> --- Created attachment 86120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86120&action=edit Bug 13895: (follow-up) Fix POST response Test plan: prove t/db_dependent/api/v1/chcekouts.t Signed-off-by: Michal Denar <black23 at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 21:43:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 20:43:34 +0000 Subject: [Koha-bugs] [Bug 21346] Clean up dialogs in returns.pl In-Reply-To: <bug-21346-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21346-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21346-70-1asVzoEiJq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21346 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #52 from Liz Rea <wizzyrea at gmail.com> --- Mark, Does this qualify as a FQA for you? Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 21:45:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 20:45:49 +0000 Subject: [Koha-bugs] [Bug 22023] Further improve responsive layout handling of staff client menu bar In-Reply-To: <bug-22023-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22023-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22023-70-fHzbGFpCW8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22023 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z Status|Needs Signoff |Patch doesn't apply --- Comment #4 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Patch doesn't apply cleanly: CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss error: Failed to merge in the changes. Perhaps a rebase is needed? Let me know if I'm missing something. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 21:53:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 20:53:28 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18925-70-hPC8qAfTHf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #110 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 86121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86121&action=edit Bug 18925: (RM follow-up) Remove issuingrules columns for new installs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 22:05:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 21:05:07 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18925-70-M5PqfvVXFn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #111 from Nick Clemens <nick at bywatersolutions.com> --- QA tool complaint: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt FAIL filters missing_filter at line 12 ( [% categorycodes.push( pc.id ) %]) Is this a false positive? Or how can we filter on pushing to an array? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 22:09:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 21:09:00 +0000 Subject: [Koha-bugs] [Bug 22419] removing multiple items from basket.pl causes browser timeout In-Reply-To: <bug-22419-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22419-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22419-70-xqvTm1LBx0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22419 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Lucas, please change the status to 'signed off' when you sign-off :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 22:13:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 21:13:41 +0000 Subject: [Koha-bugs] [Bug 22457] OpacHiddenItemsExceptions should be moved to a category attribute In-Reply-To: <bug-22457-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22457-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22457-70-uwcaofxAyo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22457 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 22:13:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 21:13:51 +0000 Subject: [Koha-bugs] [Bug 18393] Statistics wizard for acquisitions not filtering correctly by collection code In-Reply-To: <bug-18393-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18393-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18393-70-VKjVV9sqGg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18393 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #9 from Lucas Gass <lucas at bywatersolutions.com> --- backported to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 22:16:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 21:16:54 +0000 Subject: [Koha-bugs] [Bug 20210] Claimed Return In-Reply-To: <bug-20210-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20210-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20210-70-pRJC3cI3RB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20210 Joy Nelson <joy at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE CC| |joy at bywatersolutions.com Status|NEW |RESOLVED --- Comment #2 from Joy Nelson <joy at bywatersolutions.com> --- *** This bug has been marked as a duplicate of bug 14697 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 22:16:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 21:16:54 +0000 Subject: [Koha-bugs] [Bug 14697] Extend and enhance "Claims returned" lost status In-Reply-To: <bug-14697-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14697-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14697-70-0HXzEKkONJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 --- Comment #11 from Joy Nelson <joy at bywatersolutions.com> --- *** Bug 20210 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 22:23:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 21:23:31 +0000 Subject: [Koha-bugs] [Bug 21798] We need t::lib::TestBuilder::build_sample_biblio In-Reply-To: <bug-21798-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21798-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21798-70-3Wq64JVO51@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21798 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #45 from Lucas Gass <lucas at bywatersolutions.com> --- lots of troubles applying this one to 18.05.x, not backporting to 18.05.x, enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 22:26:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 21:26:31 +0000 Subject: [Koha-bugs] [Bug 21971] TestBuilder::build_sample_item In-Reply-To: <bug-21971-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21971-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21971-70-27bAfQUMXP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21971 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #15 from Lucas Gass <lucas at bywatersolutions.com> --- enhancement not backporting to 18.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 22:35:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 21:35:05 +0000 Subject: [Koha-bugs] [Bug 19342] Show private list on detail page in OPAC when user is logged in In-Reply-To: <bug-19342-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19342-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19342-70-SIuT04Qnyl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19342 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Show name private list on |Show private list on detail |biblio when user is logged |page in OPAC when user is | |logged in CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 23:02:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 22:02:19 +0000 Subject: [Koha-bugs] [Bug 14697] Extend and enhance "Claims returned" lost status In-Reply-To: <bug-14697-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14697-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14697-70-ADN5awwiFN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 Joy Nelson <joy at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|Seeking cosponsors |Sponsored CC| |joy at bywatersolutions.com --- Comment #12 from Joy Nelson <joy at bywatersolutions.com> --- (In reply to Laura Horgan from comment #9) > We are also interested in an update of this enhancement. Once a request is > funded what is the procedure for moving an option into development. I don't > believe all the libraries in our group are interested in this feature so it > would be good if each library could decide for itself. Hi Laura, The ability to use claims returned at a branch specific level is not part of this development and is outside the scope of this development. This feature is intended to be global and turned on or off for the system through system preferences. joy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 23:29:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 22:29:44 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18925-70-oOAQKc865P@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #112 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- (In reply to Nick Clemens from comment #111) > QA tool complaint: > FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt > FAIL filters > missing_filter at line 12 ( [% categorycodes.push( pc.id ) %]) > > Is this a false positive? Or how can we filter on pushing to an array? It is! We shouldn't mess with this cases. Only when displaying. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 23:46:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 22:46:19 +0000 Subject: [Koha-bugs] [Bug 8387] Hide headings in tools when user has no permissions for any listed below In-Reply-To: <bug-8387-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8387-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8387-70-nCCuW5xhbN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8387 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #10 from Lucas Gass <lucas at bywatersolutions.com> --- backported to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 23:46:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 22:46:57 +0000 Subject: [Koha-bugs] [Bug 22445] Ability to define a url for custom cover images In-Reply-To: <bug-22445-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22445-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22445-70-6MzhCfNRUd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |hayleymapley at catalyst.net.n | |z --- Comment #15 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- These patches don't seem to work fully as expected for me, as outlined below. When clicking Edit on the bibliographic record details page and uploading a custom image, all test plans pass except for: - OPAC reviews (Comment #11 rss - template is still broken it seems), - OPAC reviews (Comment #10 Recent Comments), - OPAC user (Comment #12 checkout list). In the case of the latter two scenarios, instead of displaying the image or the 'no cover image' placeholder image, a link that says 'Cover image' is displayed. In terms of the url/local path options in the system prefs, is there anything that needs to be done apart from allowing display, setting the path/url and ensuring that the biblio has a url that is present in the path/url? I'm having trouble testing this (I'm pretty new) Additionally, in most places where the cover image is displayed (such as the item detail page, etc.), the 'Cover image' link is also displayed underneath. I'm assuming this is a bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 23:48:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 22:48:56 +0000 Subject: [Koha-bugs] [Bug 22445] Ability to define a url for custom cover images In-Reply-To: <bug-22445-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22445-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22445-70-dZ8u97XbBe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 23:51:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 22:51:35 +0000 Subject: [Koha-bugs] [Bug 20544] Wrong comment in database documentation for items.itemnotes In-Reply-To: <bug-20544-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20544-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20544-70-gw2swogUjs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20544 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> --- backported to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 23:53:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 22:53:39 +0000 Subject: [Koha-bugs] [Bug 21710] Fix typo atributes in some installer files In-Reply-To: <bug-21710-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21710-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21710-70-8pNBBU3OJJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21710 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #8 from Lucas Gass <lucas at bywatersolutions.com> --- backported to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 5 23:58:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 22:58:49 +0000 Subject: [Koha-bugs] [Bug 22171] Format shipping cost on invoice.pl with with 2 decimals In-Reply-To: <bug-22171-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22171-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22171-70-b7XzGcKN7t@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22171 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> --- backported to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 00:01:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 23:01:01 +0000 Subject: [Koha-bugs] [Bug 22453] TestBuilder should generate now() using the current timezone In-Reply-To: <bug-22453-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22453-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22453-70-fwZbIYH5ZL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22453 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z Status|Needs Signoff |Failed QA --- Comment #3 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- prove t/db_dependent/Koha/Patrons.t fails before and after applying this patch - setting to Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 00:11:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 23:11:55 +0000 Subject: [Koha-bugs] [Bug 17179] Advanced editor: Add keyboard shortcuts to repeat (duplicate) a field, and cut text In-Reply-To: <bug-17179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17179-70-kmJjZ6JM5Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Cori Lynn Arnold <carnold at dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carnold at dgiinc.com Status|Needs Signoff |Failed QA --- Comment #10 from Cori Lynn Arnold <carnold at dgiinc.com> --- I got these to work okay: Changed: Ctrl-X: Now cuts a line into the clipboard area Added: Ctrl-C: Copies a line into the clipboard area Ctrl-P: Pastes the selected item from the clipboard at cursor Ctrl-I: Copies the current line and inserts onto a new line below (and I really like Ctrl-I!!, but Control-P if you don't have the cursor in just the right place will pop the print menu) These did not work: Expected: Shift-Ctrl-C: Copies current subfield into clipboard area Result (in firefox and chrome): Pops up the "Inspector" / Development tools Expected: Nothing happens. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 00:11:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 23:11:49 +0000 Subject: [Koha-bugs] [Bug 21904] Patron search library dropdown should be limited by group if "Hide patron info" is enabled for group In-Reply-To: <bug-21904-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21904-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21904-70-GHmU558RPQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21904 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #9 from Lucas Gass <lucas at bywatersolutions.com> --- pushed to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 00:59:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Mar 2019 23:59:12 +0000 Subject: [Koha-bugs] [Bug 7890] Highlight required field in MARC editor In-Reply-To: <bug-7890-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7890-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7890-70-xNbnGlk8dh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7890 Cori Lynn Arnold <carnold at dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carnold at dgiinc.com Status|Needs Signoff |Failed QA --- Comment #2 from Cori Lynn Arnold <carnold at dgiinc.com> --- I got this error below when I tried to import a record ("Sometimes I lie" by Alice Feeney) Steps: 1. Go to Cataloging 2. Click "New from Z39.5/SRU" button 3. Put "Sometimes I lie" in the title field and hit "Search" 4. Click on a row and select "Import" Error: Could not compile /kohadevbox/koha/cataloguing/addbiblio.pl: Global symbol "$tab" requires explicit package name (did you forget to declare "my $tab"?) at /kohadevbox/koha/cataloguing/addbiblio.pl line 876. Global symbol "$tab" requires explicit package name (did you forget to declare "my $tab"?) at /kohadevbox/koha/cataloguing/addbiblio.pl line 877. Global symbol "$title" requires explicit package name (did you forget to declare "my $title"?) at /kohadevbox/koha/cataloguing/addbiblio.pl line 889. Global symbol "$title" requires explicit package name (did you forget to declare "my $title"?) at /kohadevbox/koha/cataloguing/addbiblio.pl line 890. Global symbol "$uxml" requires explicit package name (did you forget to declare "my $uxml"?) at /kohadevbox/koha/cataloguing/addbiblio.pl line 941. Global symbol "$urecord" requires explicit package name (did you forget to declare "my $urecord"?) at /kohadevbox/koha/cataloguing/addbiblio.pl line 944. Global symbol "$uxml" requires explicit package name (did you forget to declare "my $uxml"?) at /kohadevbox/koha/cataloguing/addbiblio.pl line 944. Global symbol "$urecord" requires explicit package name (did you forget to declare "my $urecord"?) at /kohadevbox/koha/cataloguing/addbiblio.pl line 945. syntax error at /kohadevbox/koha/cataloguing/addbiblio.pl line 961, near ") {" BEGIN not safe after errors--compilation aborted at /kohadevbox/koha/cataloguing/addbiblio.pl line 978. at /usr/share/perl5/CGI/Compile.pm line 132 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 01:32:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 00:32:06 +0000 Subject: [Koha-bugs] [Bug 15067] Add additional languages to advanced search language search In-Reply-To: <bug-15067-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15067-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15067-70-uSkg2kCf5m@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 01:32:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 00:32:10 +0000 Subject: [Koha-bugs] [Bug 15067] Add additional languages to advanced search language search In-Reply-To: <bug-15067-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15067-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15067-70-NELhEiDZkt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15067 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84124|0 |1 is obsolete| | --- Comment #13 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Created attachment 86122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86122&action=edit Bug 15067: Added translations of languages to those 5 languages. Estonian, Latvian, Lithuanian, Inuktitut and Inupiaq are added with their translations to the Advanced Search languages. Test Plan: 1. From homepage, go to Advanced search 2. Click on More options next to the Search button 3. Scroll down to the Limits section 4. Click on Language: No limit 5. Find Estonian, Latvian, Lithuanian, Inuktitut and Inupiaq at the bottom of the dropdown. 6. They should all be there. 7. Estonian and Latvian are repeated, this need to be fixed. 8. They need to be put in alphabetical order. Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz> The five languages are present, sorted alphabetically, and are not repeated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 01:35:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 00:35:16 +0000 Subject: [Koha-bugs] [Bug 22371] MARC bibliographic framework plugin to generate Cutter-Sanborn In-Reply-To: <bug-22371-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22371-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22371-70-pkvdvV2Rkc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22371 Cori Lynn Arnold <carnold at dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carnold at dgiinc.com --- Comment #2 from Cori Lynn Arnold <carnold at dgiinc.com> --- I'm trying to test this functionality. Can you explain this step in more detail: To use the plugin, it is necessary to associate it with the Cutter field in the framework. Thanks! -cori lynn -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 01:54:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 00:54:40 +0000 Subject: [Koha-bugs] [Bug 16440] Update report parameters In-Reply-To: <bug-16440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16440-70-6uINVgw5sk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16440 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 01:55:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 00:55:02 +0000 Subject: [Koha-bugs] [Bug 16440] Update report parameters In-Reply-To: <bug-16440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16440-70-MObVruqnhl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16440 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|hayleymapley at catalyst.net.n | |z | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 02:11:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 01:11:17 +0000 Subject: [Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint In-Reply-To: <bug-22008-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22008-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22008-70-1mcY6qjxZQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z --- Comment #28 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Is there a test plan for this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 02:32:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 01:32:34 +0000 Subject: [Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses In-Reply-To: <bug-14407-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14407-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14407-70-mdV155AFRR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80738|0 |1 is obsolete| | --- Comment #60 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Created attachment 86123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86123&action=edit Bug 14407: Follow up to add test case and clean noise Comment #28 has a /36 which is invalid CIDR. This triggers a crash and noise. This cleans up the crash and noise, and adds test cases to check for them. prove t/Auth.t -- before missing null case, and /36 case. -- after null case, and /36 with/without warnings. Signed-off-by: Mark Tompsett <mtompset at hotmail.com> Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz> Looked signed off but status was Needs Signoff so I tested it again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 02:32:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 01:32:56 +0000 Subject: [Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses In-Reply-To: <bug-14407-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14407-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14407-70-eekpsQv2UZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 03:09:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 02:09:25 +0000 Subject: [Koha-bugs] [Bug 20537] Warnings in overdue_notices.pl In-Reply-To: <bug-20537-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20537-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20537-70-NAsXIWQl0e@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20537 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |hayleymapley at catalyst.net.n |ity.org |z CC| |hayleymapley at catalyst.net.n | |z Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 05:20:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 04:20:12 +0000 Subject: [Koha-bugs] [Bug 20537] Warnings in overdue_notices.pl In-Reply-To: <bug-20537-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20537-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20537-70-HE1CkIIEBv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20537 --- Comment #2 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Created attachment 86124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86124&action=edit Bug 20537: Added check to remove warning from overdue_notices.pl When executing overdue_notices.pl on borrowers that lack a surname, we see this error: Use of uninitialized value in concatenation (.) or string at /usr/share/koha/bin/cronjobs/overdue_notices.pl line 575. This patch fixes this issue by setting the $borr variable based on the information that has been defined. To test: 1) Create a borrower and set its surname to null 2) Checkout an item to the borrower and set it to be overdue 3) Navigate to kohaclone/misc/cronjobs and enter a koha-shell 4) Run the script: ./overdue_notices.pl 5) Observe the error appears 6) Apply the patch 7) Repeat steps 3-4 8) Observe the error is gone 9) Sign off! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 05:20:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 04:20:09 +0000 Subject: [Koha-bugs] [Bug 20537] Warnings in overdue_notices.pl In-Reply-To: <bug-20537-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20537-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20537-70-mIOne5edsc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20537 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 07:29:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 06:29:18 +0000 Subject: [Koha-bugs] [Bug 22445] Ability to define a url for custom cover images In-Reply-To: <bug-22445-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22445-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22445-70-gSFiGF1bGI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Haley, 'Failed QA' is ok for getting answers to your questions. Thx for testing! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 07:39:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 06:39:50 +0000 Subject: [Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint In-Reply-To: <bug-22008-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22008-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22008-70-bP3EFAcdqW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #29 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- The test plan is basically to run the included unit tests. They test for adding a non-existant user as the manager for an accountline, and they then try deleting a user whose attached to an accountline as a manager and test that the accountline isn't deleted. You could replicate all that manually if you wanted to take the belt and braces approach. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 07:51:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 06:51:03 +0000 Subject: [Koha-bugs] [Bug 11969] Show patrons star rating on their reading history In-Reply-To: <bug-11969-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11969-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11969-70-nK43Fibt8R@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11969 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Comment on attachment 86047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86047 Bug 11969: Show patrons star rating on their reading history Review of attachment 86047: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=11969&attachment=86047) ----------------------------------------------------------------- ::: opac/opac-readingrecord.pl @@ +147,4 @@ > } > } > > +for(qw(OPACAmazonCoverImages GoogleJackets SyndeticsCoverImages)) { # BakerTaylorEnabled handled above Why this change? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 07:56:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 06:56:13 +0000 Subject: [Koha-bugs] [Bug 21948] Clean up style of item detail page In-Reply-To: <bug-21948-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21948-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21948-70-pvTli10Jjy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21948 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86045|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 86125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86125&action=edit Bug 21948: Clean up style of item detail page This patch removes some page-specific style from the item detail page in the staff client and adds some markup in order to trigger a more generally-used style. This patch also adds a font-awesome icon to the "Edit item" link on the page. To test, apply the patch and regenerate the staff client CSS. Open a bibliographic record and view the "Items tab." Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 08:03:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 07:03:15 +0000 Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap grid: Catalog In-Reply-To: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21304-70-K5lZfSCiDJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 08:03:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 07:03:22 +0000 Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap grid: Catalog In-Reply-To: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21304-70-blfBTKXQ9I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86023|0 |1 is obsolete| | --- Comment #26 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 86127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86127&action=edit Bug 21304: (follow-up) Fix style of search results browser This follow-up revises the style of the search result browser in the staff client, making it behave better at smaller browser widths. The patch also makes a couple of ESLint-prompted changes to browser.js To test, apply the patch and regenerate CSS. - Perform a catalog search in the staff client. - Click on one of the search results. - On the bibliographic detail page there should be results browsing controls in the left-hand sidebar. - Resize the browser window and confirm that the controls work well at various sizes. - Test with both the first and last search result. Signed-off-by: Liz Rea <wizzyrea at gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 08:03:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 07:03:19 +0000 Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap grid: Catalog In-Reply-To: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21304-70-oSqXUBQrVY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86022|0 |1 is obsolete| | --- Comment #25 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 86126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86126&action=edit Bug 21304: Update two-column templates with Bootstrap grid: Catalog This patch modifies several catalog templates to use the Bootstrap grid instead of YUI. This patch also removes obsolete "text/javascript" attributes from <script> tags and "text/css" attributes from <style> tags in the modified templates. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Catalog -> Search - Search results - Bibliographic details - MARC details (viewMARC preference enabled) - Labeled MARC details (viewLabeledMARC preference enabled) - ISBD (viewISBD preference enabled) - Items - Checkout history - Rota (stock rotation) Signed-off-by: Liz Rea <wizzyrea at gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 08:04:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 07:04:13 +0000 Subject: [Koha-bugs] [Bug 21948] Clean up style of item detail page In-Reply-To: <bug-21948-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21948-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21948-70-O5kDTZ5dwA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21948 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 08:04:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 07:04:36 +0000 Subject: [Koha-bugs] [Bug 22032] Improve local cover image tab on detail page In-Reply-To: <bug-22032-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22032-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22032-70-h0HjyVhFPu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22032 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 08:11:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 07:11:30 +0000 Subject: [Koha-bugs] [Bug 22032] Improve local cover image tab on detail page In-Reply-To: <bug-22032-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22032-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22032-70-mI0pzLbfnB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22032 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 08:11:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 07:11:33 +0000 Subject: [Koha-bugs] [Bug 22032] Improve local cover image tab on detail page In-Reply-To: <bug-22032-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22032-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22032-70-YvzImAKl4m@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22032 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83481|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 86128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86128&action=edit Bug 22032: Improve local cover image tab on detail page This patch makes a variety of improvements to the images tab of the staff client's bibliographic detail page. To test, apply the patch and regenerate the staff client CSS. - Enable the LocalCoverImages system preference. - Locate a bibliographic record which has no images attached. - There should be a "no images" message and an upload button. - Upload an image and return to the detail page. - The "Images" tab should have a nicely-styled thumbnail of the image you uploaded. - Test the "Delete image" link: It should ask for a confirmation. If you confirm, the image should disappear and a "loading" spinner should appear. - When the image has been deleted the thumbnail container should disappear and the "no images" message should reappear. - Test this process with AllowMultipleCovers enabled and disabled. Extra credit: Modify the AJAX url in the removeLocalImage function in detail.tt. After misspelling a parameter name or the URL path, clicking the "Delete image" link should trigger an alert and re-show the image thumbnail. Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 08:17:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 07:17:37 +0000 Subject: [Koha-bugs] [Bug 8775] Add collection code to lost report In-Reply-To: <bug-8775-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8775-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8775-70-vdq9FeYqMX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8775 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- The sequence of columns appears a little strange: - Library (homelibrary) - Item type - Collection code - Current location (holdinglibrary) - Location Out of scope here, but can we change "Collection code" to be "Collection"? We are not showing the code, but the description :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 08:20:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 07:20:08 +0000 Subject: [Koha-bugs] [Bug 22419] Removing multiple records from intranet cart causes browser timeout In-Reply-To: <bug-22419-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22419-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22419-70-n44UuUPeca@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22419 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|removing multiple items |Removing multiple records |from basket.pl causes |from intranet cart causes |browser timeout |browser timeout -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 08:22:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 07:22:51 +0000 Subject: [Koha-bugs] [Bug 22419] Removing multiple records from intranet cart causes browser timeout In-Reply-To: <bug-22419-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22419-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22419-70-yifvHpMdej@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22419 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86113|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 86129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86129&action=edit Bug 22419: Records listed twice when select/unselect all from the cart It fixes a browser timeout when records are removed from the cart. The onchange event already call selRecord. Test plan: Launch a search Add all the result to your cart Open the cart Click "select all" Then remove them all from your cart => Without this patch the action will timeout => With this patch applied the action is immediate Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 08:22:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 07:22:47 +0000 Subject: [Koha-bugs] [Bug 22419] Removing multiple records from intranet cart causes browser timeout In-Reply-To: <bug-22419-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22419-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22419-70-yLaVF9qald@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22419 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 09:05:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 08:05:02 +0000 Subject: [Koha-bugs] [Bug 16251] Material type is not correctly set for Rancor 008 widget In-Reply-To: <bug-16251-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16251-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16251-70-PxYuCKDvHs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16251 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jweaver at bywatersolutions.co |julian.maurice at biblibre.com |m | Status|NEW |ASSIGNED CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 09:05:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 08:05:55 +0000 Subject: [Koha-bugs] [Bug 16251] Material type is not correctly set for Rancor 008 widget In-Reply-To: <bug-16251-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16251-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16251-70-VKFQOclKdq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16251 --- Comment #2 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 86130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86130&action=edit Bug 16251: Fix value of material select for Rancor 008 widget The material type is selected in accordance with the leader (06-07) Test plan: 1. Create a new record using the advanced editor 2. Set the leader 6th position to 'c' 3. Save the record and reload the page 4. 'Music' should be automatically selected for 008 5. Try other values for the leader 6th and 7th positions See comment 0 of this bug for the complete mapping -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 09:06:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 08:06:08 +0000 Subject: [Koha-bugs] [Bug 16251] Material type is not correctly set for Rancor 008 widget In-Reply-To: <bug-16251-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16251-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16251-70-8nlvHhH48i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16251 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 09:06:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 08:06:31 +0000 Subject: [Koha-bugs] [Bug 21049] Rancor 007 field does not retain value In-Reply-To: <bug-21049-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21049-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21049-70-mtivCNvB4M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21049 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |julian.maurice at biblibre.com |ity.org | CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 09:06:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 08:06:55 +0000 Subject: [Koha-bugs] [Bug 21049] Rancor 007 field does not retain value In-Reply-To: <bug-21049-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21049-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21049-70-htBlFHWCCY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21049 --- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 86131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86131&action=edit Bug 21049: Fix value of material select for Rancor 007 widget The material type is selected in accordance with position 0 of 007 Test plan: 1. Create a new record using the advanced editor 2. Select a material type for field 007 and set at least the position 0 of this field 3. Save the record and reload the page 4. The material type should remain selected 5. Try with all available material types -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 09:07:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 08:07:07 +0000 Subject: [Koha-bugs] [Bug 21049] Rancor 007 field does not retain value In-Reply-To: <bug-21049-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21049-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21049-70-77yihVGRxP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21049 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 10:07:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 09:07:46 +0000 Subject: [Koha-bugs] [Bug 22460] New: Printer doesn't save, when bin is left empty Message-ID: <bug-22460-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22460 Bug ID: 22460 Summary: Printer doesn't save, when bin is left empty Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Target Milestone: --- When adding a new printer for patron card or label printing, the bin appears to be a required field, but is not marked as such. If left empty, the printer is not saved correctly, but there is no error message or similar. This is very confusing when working with the module. The required field should be enforced or if not necessary the behaviour needs to be fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 10:08:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 09:08:11 +0000 Subject: [Koha-bugs] [Bug 22460] Printer doesn't save, when 'paper bin' is left empty In-Reply-To: <bug-22460-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22460-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22460-70-TSYXkFSkOk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22460 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Printer doesn't save, when |Printer doesn't save, when |bin is left empty |'paper bin' is left empty -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 10:57:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 09:57:29 +0000 Subject: [Koha-bugs] [Bug 22371] MARC bibliographic framework plugin to generate Cutter-Sanborn In-Reply-To: <bug-22371-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22371-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22371-70-ls4CvouUCq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22371 paxed <pasi.kallinen at koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pasi.kallinen at koha-suomi.fi --- Comment #3 from paxed <pasi.kallinen at koha-suomi.fi> --- Any chance of converting the comments in the plugin to english? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 11:02:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 10:02:10 +0000 Subject: [Koha-bugs] [Bug 22434] correct item callnumber search link In-Reply-To: <bug-22434-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22434-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22434-70-CxInvsfhaS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22434 sandboxes at biblibre.com <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes at biblibre.com Status|Needs Signoff |Signed Off --- Comment #3 from sandboxes at biblibre.com <sandboxes at biblibre.com> --- Patch tested with a sandbox, by Theodoros Theodoropoulos <theod at lib.auth.gr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 11:02:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 10:02:24 +0000 Subject: [Koha-bugs] [Bug 22434] correct item callnumber search link In-Reply-To: <bug-22434-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22434-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22434-70-LuxzP0ZW9M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22434 sandboxes at biblibre.com <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85879|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 11:02:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 10:02:32 +0000 Subject: [Koha-bugs] [Bug 22434] correct item callnumber search link In-Reply-To: <bug-22434-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22434-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22434-70-W1XPpzwh3D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22434 --- Comment #4 from sandboxes at biblibre.com <sandboxes at biblibre.com> --- Created attachment 86132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86132&action=edit Bug 22434: correct item callnumber search link Many places show item callnumber as a link to a search on this callnumber. The correct way is : (opac-)search.pl?q=callnum:%22[% callnumber | uri %]%22 I propose an include that creates think search link. Patch does not create an include for OPAC since callnumber search link is only in display without XSLT which will be obsolete. It juste corrects the filtering with uri instead of url. Test plan : 1) Create an item with callnumber : AAA&1(2)3 2) Check callnumber display and search link ar OK in : 3) Intranet : perform a search in catalog search that displays this item 4) Intranet : perform a search in cataloguing serach that displays this item 5) Intranet : Create a list that displays this item 6) OPAC without XSLT : perform a search in catalog search that displays this item 7) OPAC without XSLT : perform a group search in catalog search that displays this item Signed-off-by: Theodoros Theodoropoulos <theod at lib.auth.gr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 11:02:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 10:02:57 +0000 Subject: [Koha-bugs] [Bug 22371] MARC bibliographic framework plugin to generate Cutter-Sanborn In-Reply-To: <bug-22371-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22371-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22371-70-KWLcN8ItbG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22371 --- Comment #4 from paxed <pasi.kallinen at koha-suomi.fi> --- Should also perhaps use String.prototype.normalize() if it's available -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 11:14:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 10:14:37 +0000 Subject: [Koha-bugs] [Bug 22434] correct item callnumber search link In-Reply-To: <bug-22434-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22434-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22434-70-U8fNEo6q3Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22434 Theodoros Theodoropoulos <theod at lib.auth.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |theod at lib.auth.gr --- Comment #5 from Theodoros Theodoropoulos <theod at lib.auth.gr> --- The proposed patch seems to work with the latest master (as of today) and with minor changes can be backported to 17.xx Thanks Fridolin for taking time to work on this issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 11:32:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 10:32:51 +0000 Subject: [Koha-bugs] [Bug 22455] Add Koha::Biblio::hidden_in_opac method In-Reply-To: <bug-22455-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22455-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22455-70-UNI7VU8DwC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22455 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 11:33:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 10:33:14 +0000 Subject: [Koha-bugs] [Bug 22454] Add Koha::Item::hidden_in_opac method In-Reply-To: <bug-22454-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22454-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22454-70-Caklj9yYWo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22454 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 11:33:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 10:33:32 +0000 Subject: [Koha-bugs] [Bug 22455] Add Koha::Biblio::hidden_in_opac method In-Reply-To: <bug-22455-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22455-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22455-70-NVfFhKwHyX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22455 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 11:53:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 10:53:27 +0000 Subject: [Koha-bugs] [Bug 10589] Override OpacHiddenItems based on Patron Branch In-Reply-To: <bug-10589-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10589-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10589-70-xaMgD5DKfR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10589 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #47 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Please take a look at bug 22454 and bug 22455. The rationale is that if you have the biblio object, you can know all that is needed regarding hiding in OPAC without fetching MARC data or complex calculations. And if we were to add parameters like category and library, I would rather pass the Koha::Patron object altogether. This check, with bug 22457 in mind could be written: my $should_hide = ( $patron->category->overrides_opac_hidding_policy or $patron->library->overrides_opac_hidding_policy ) ? 0 : 1; while ( my $biblio = $biblios->next ) { next if $biblio->hidden_in_opac and $should_hide; do_your_things(); } This check should be written on the controller script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 11:57:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 10:57:09 +0000 Subject: [Koha-bugs] [Bug 22456] Customers Cancelling their Pending Holds In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22456-70-74P5kvhEdL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 12:09:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 11:09:09 +0000 Subject: [Koha-bugs] [Bug 22461] New: Regression in #20287: LDAP user replication broken with mapped extended patron attributes Message-ID: <bug-22461-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22461 Bug ID: 22461 Summary: Regression in #20287: LDAP user replication broken with mapped extended patron attributes Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: oliver.behnke at aei.mpg.de QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Reproduce: 1) Use LDAP authentication with user replication 2) Add a field mapping for an extended patron attribute (e.g. MYATTRIB) 3) Try to log in for the first time (new Koha user) 4) Error: "opac-user.pl: DBIx::Class::Row::store_column(): No such column 'MYATTRIB' on Koha::Schema::Result::Borrower at /usr/share/koha/lib/Koha/Object.pm line 75" Presumed cause: Commit [1] changed the way new patrons are created during LDAP replication (first login). The previous implementation (C4::Members::AddMember) took into account extended patron attributes by filtering them out before instantiating the new patron DB object [2]. The current implementation lacks this vital step. I chose a severity of critical because after upgrading from 18.05 to 18.11 no new users are able to log in anymore. Cheers [1] https://github.com/Koha-Community/Koha/commit/a6059c4d2d43e43aa021069ce97d6424a76c4f41#diff-56b596ea4e46031303c060d360a16eddL226 [2] https://github.com/Koha-Community/Koha/blob/1b13c453e20e47c5e25bd946b50dd3838e29c3ce/C4/Members.pm#L448 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 12:08:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 11:08:51 +0000 Subject: [Koha-bugs] [Bug 16357] Plack error logs are not time stamped In-Reply-To: <bug-16357-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16357-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16357-70-wLAEHd4m6y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 p.sztuczynski at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |p.sztuczynski at gmail.com --- Comment #30 from p.sztuczynski at gmail.com --- After applying this patch :https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=77533 i had the same problem. Make sure all the files defined in log4perl.conf exist and are writable. In my case, plack is logging into /var/log/koha/plack-error.log (which makes sense - this is the file defined in starman parameters) while log4perl.conf has log4perl.appender.INTRANET.filename=/var/log/koha/intranet-error.log [..] log4perl.appender.OPAC.filename=/var/log/koha/opac-error.log [..] log4perl.appender.PLACK.filename=/var/log/koha/plack-error.log [..] manually creating those and making them writable seems to fix the issue. Plack logs now are timestamped: [2019/03/06 12:06:57] [WARN] Use of uninitialized value in subroutine entry at /usr/share/perl5/URI/Escape.pm line 184. [2019/03/06 12:07:10] [WARN] Use of uninitialized value in concatenation (.) or string at /usr/share/koha/intranet/cgi-bin/members/memberentry.pl line 296. [2019/03/06 12:07:10] [WARN] Use of uninitialized value in concatenation (.) or string at /usr/share/koha/intranet/cgi-bin/members/memberentry.pl line 296. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 12:09:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 11:09:32 +0000 Subject: [Koha-bugs] [Bug 22461] Regression in #20287: LDAP user replication broken with mapped extended patron attributes In-Reply-To: <bug-22461-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22461-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22461-70-N1iIOdNzBR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22461 Oliver Behnke <oliver.behnke at aei.mpg.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20287 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 [Bug 20287] Move AddMember and ModMember to Koha::Patron -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 12:09:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 11:09:32 +0000 Subject: [Koha-bugs] [Bug 20287] Move AddMember and ModMember to Koha::Patron In-Reply-To: <bug-20287-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20287-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20287-70-s8NMpVyKzV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20287 Oliver Behnke <oliver.behnke at aei.mpg.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22461 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22461 [Bug 22461] Regression in #20287: LDAP user replication broken with mapped extended patron attributes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 12:30:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 11:30:15 +0000 Subject: [Koha-bugs] [Bug 11983] Code to select patrons to purge needs to be centralized In-Reply-To: <bug-11983-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11983-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11983-70-yrhy76T9eK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11983 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 12:43:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 11:43:02 +0000 Subject: [Koha-bugs] [Bug 22453] TestBuilder should generate now() using the current timezone In-Reply-To: <bug-22453-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22453-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22453-70-mtBsHj6iVl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22453 --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Hayley Mapley from comment #3) > prove t/db_dependent/Koha/Patrons.t fails before and after applying this > patch - setting to Failed QA. Hello Hayley, thanks for testing! Do you get the same error as in the description or another one? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 12:58:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 11:58:57 +0000 Subject: [Koha-bugs] [Bug 21683] Remove accountlines.accountno In-Reply-To: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21683-70-gUbE2lkE6R@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |kyle at bywatersolutions.com, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 13:05:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 12:05:32 +0000 Subject: [Koha-bugs] [Bug 21683] Remove accountlines.accountno In-Reply-To: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21683-70-SR8eMWLbgG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #21 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Shouldn't we use accountline_id for the proccode parameter in UpdateStats? I'm getting failures in all tests that set statistics. To reproduce: $ dbic $ updatedatabase $ kshell k$ prove t/db_dependent/Accounts.t \ t/db_dependent/Circ* \ t/db_dependent/Koha/Account* => FAIL: Lots of errors like this: DBD::mysql::st execute failed: Column count doesn't match value count at row 1 [for Statement "INSERT INTO statistics (datetime, branch, type, value, other, itemnumber, itemtype, location, borrowernumber, proccode, ccode) VALUES (now(),?,?,?,?,?,?,?,?,?)" with ParamValues: 0='VBVsbXZxI', 1='payment', 2=150, 3='', 4=undef, 5='', 6=undef, 7='205', 8=''] at /home/vagrant/kohaclone/C4/Stats.pm line 136. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 13:26:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 12:26:56 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18925-70-QNzke37nAE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #113 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 13:28:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 12:28:34 +0000 Subject: [Koha-bugs] [Bug 22462] New: Crash in patron card printing Message-ID: <bug-22462-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22462 Bug ID: 22462 Summary: Crash in patron card printing Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: christian.stelzenmueller at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Patron card printing: Layout: the entered text in a text field is longer then the possible page height, page width, card height and card width in the template. Result: when running a batch, the created pdf can't be opened, and Koha doesn't respond. It also seems to end in an infinite loop. It also happens if all values in the template are saved with the default values "0". Template: page height: 50 mm page width: 20 mm card heigh: 50 mmm card width: 20 mm Layout: Textfield Text: Libraries are great -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 13:31:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 12:31:04 +0000 Subject: [Koha-bugs] [Bug 21683] Remove accountlines.accountno In-Reply-To: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21683-70-zqzrv4mput@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 --- Comment #22 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- (In reply to Tom?s Cohen Arazi from comment #21) > Shouldn't we use accountline_id for the proccode parameter in UpdateStats? > I'm getting failures in all tests that set statistics. > > To reproduce: > $ dbic > $ updatedatabase > $ kshell > k$ prove t/db_dependent/Accounts.t \ > t/db_dependent/Circ* \ > t/db_dependent/Koha/Account* > => FAIL: Lots of errors like this: > DBD::mysql::st execute failed: Column count doesn't match value count at row > 1 [for Statement "INSERT INTO statistics > (datetime, > branch, type, value, > other, itemnumber, itemtype, location, > borrowernumber, proccode, ccode) > VALUES (now(),?,?,?,?,?,?,?,?,?)" with ParamValues: 0='VBVsbXZxI', > 1='payment', 2=150, 3='', 4=undef, 5='', 6=undef, 7='205', 8=''] at > /home/vagrant/kohaclone/C4/Stats.pm line 136. Reverting the changes in t/db_dependent/Stats.t and C4/Stats.pm fixes the failures. Still not sure what's the best solution. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 13:31:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 12:31:44 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18925-70-HL08q7kq10@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #114 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- (In reply to Nick Clemens from comment #113) > Awesome work all! > > Pushed to master for 19.05 \o/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 13:38:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 12:38:14 +0000 Subject: [Koha-bugs] [Bug 22462] Crash in patron card printing In-Reply-To: <bug-22462-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22462-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22462-70-7yOiM8R7vN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22462 Christian Stelzenm?ller <christian.stelzenmueller at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22429 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22429 [Bug 22429] Infinite loop in patron card printing -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 13:38:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 12:38:14 +0000 Subject: [Koha-bugs] [Bug 22429] Infinite loop in patron card printing In-Reply-To: <bug-22429-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22429-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22429-70-etudcVeFGl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22429 Christian Stelzenm?ller <christian.stelzenmueller at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22462 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22462 [Bug 22462] Crash in patron card printing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 13:39:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 12:39:44 +0000 Subject: [Koha-bugs] [Bug 21683] Remove accountlines.accountno In-Reply-To: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21683-70-iWEy2l8bFC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 --- Comment #23 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- I think the failures must have been introduced by my rebase.. simple mistake on number of `?` chars.. but.. I agree with you.. I 'think' rather that outright removing the link to the accountline here we should probably be recording accountline_id as an alternative... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 13:44:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 12:44:28 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18925-70-eV32AmwYot@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #115 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to Tom?s Cohen Arazi from comment #114) > (In reply to Nick Clemens from comment #113) > > Awesome work all! > > > > Pushed to master for 19.05 > > \o/ \o/ from me as well! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 13:47:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 12:47:54 +0000 Subject: [Koha-bugs] [Bug 20421] Inform staff that patron does have the title checked out during placing hold In-Reply-To: <bug-20421-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20421-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20421-70-gEWuxgoAbP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20421 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76611|0 |1 is obsolete| | --- Comment #7 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86133&action=edit Bug 20421: Inform staff that patron does have the title checked out during placing hold Test plan: 1) Enable the CheckPrevCheckout and DisplayMultiPlaceHold system preferences 2) Have a patron with some checkouts history 3) Try to place hold on one of titles from history for this patron 4) You should see an information at the top of confirm request page, but you still should be able to place a hold 5) Try this with multiple titles - one or more of them should be from history 6) You should see this information in "Information" column 7) There is also new column placed at the beggining with checkbox, you could uncheck it for titles you do not want to place a hold on it 8) Confirm the hold is placed only on checked titles -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 13:49:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 12:49:37 +0000 Subject: [Koha-bugs] [Bug 22462] Crash in patron card printing In-Reply-To: <bug-22462-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22462-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22462-70-T2lZBTu672@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22462 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |cnighswonger at foundations.ed |ity.org |u Component|Tools |Label/patron card printing CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 13:49:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 12:49:48 +0000 Subject: [Koha-bugs] [Bug 22462] Crash in patron card printing In-Reply-To: <bug-22462-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22462-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22462-70-mWbjHtMfWv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22462 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 13:50:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 12:50:15 +0000 Subject: [Koha-bugs] [Bug 22462] Crash in patron card printing In-Reply-To: <bug-22462-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22462-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22462-70-KpYMoybKSP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22462 Christian Stelzenm?ller <christian.stelzenmueller at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22429 Version|17.11 |18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 13:50:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 12:50:15 +0000 Subject: [Koha-bugs] [Bug 22429] Infinite loop in patron card printing In-Reply-To: <bug-22429-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22429-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22429-70-wQMT16Ho5c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22429 Christian Stelzenm?ller <christian.stelzenmueller at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22462 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 13:53:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 12:53:22 +0000 Subject: [Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules In-Reply-To: <bug-18928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18928-70-SppBsh8j5h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85488|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 13:53:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 12:53:25 +0000 Subject: [Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules In-Reply-To: <bug-18928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18928-70-vq0S0Ecw11@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85489|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 13:53:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 12:53:28 +0000 Subject: [Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules In-Reply-To: <bug-18928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18928-70-x645huby0i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85490|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 13:53:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 12:53:31 +0000 Subject: [Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules In-Reply-To: <bug-18928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18928-70-1mwA5fnRNM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85491|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 13:53:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 12:53:33 +0000 Subject: [Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules In-Reply-To: <bug-18928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18928-70-VuuMlFZqau@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85487|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 13:53:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 12:53:19 +0000 Subject: [Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules In-Reply-To: <bug-18928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18928-70-bnjbdqfyCP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 13:54:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 12:54:01 +0000 Subject: [Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules In-Reply-To: <bug-18928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18928-70-vwd5GFJgcA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #18 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 86134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86134&action=edit Bug 18928: Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules Test Plan: 1) Apply dependancies 2) Apply this patch set 3) Run updatedatabase.pl 4) Ensure holdallowed and hold_fulfillment_policy rules behavior remains unchanged Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 13:54:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 12:54:06 +0000 Subject: [Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules In-Reply-To: <bug-18928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18928-70-CfrfQ1KGsx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #19 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 86135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86135&action=edit Bug 18928: Add DB structure changes Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 13:54:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 12:54:10 +0000 Subject: [Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules In-Reply-To: <bug-18928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18928-70-gG1uoZtyGc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #20 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 86136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86136&action=edit Bug 18928: Add missing filters Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 13:54:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 12:54:14 +0000 Subject: [Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules In-Reply-To: <bug-18928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18928-70-acQkBw6ebB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #21 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 86137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86137&action=edit Bug 18928: Update new occurrences Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 13:54:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 12:54:18 +0000 Subject: [Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules In-Reply-To: <bug-18928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18928-70-Novbilrgln@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #22 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 86138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86138&action=edit [DO NOT PUSH] Bug 18928: DBIC schema update Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 13:54:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 12:54:22 +0000 Subject: [Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules In-Reply-To: <bug-18928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18928-70-DorrHH8SXn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 --- Comment #23 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 86139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86139&action=edit Bug 18928: (follow-up) Make DB update idempotent Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 13:54:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 12:54:55 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-dGnJL0wSYa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85543|0 |1 is obsolete| | --- Comment #141 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86140&action=edit Bug 20912: Update database Signed-off-by: Matha Fuerst <mfuerst at hmcpl.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 13:54:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 12:54:59 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-WZKXyEqM7e@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85544|0 |1 is obsolete| | --- Comment #142 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86141&action=edit Bug 20912: Rental Fees based on Time Period Some libraries would like to be able to charge a rental fee based on the number of days an item will be checked out, as opposed to the flat fee currently offered by Koha. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Edit an itemtype, add a daily rental fee of 1.00 4) Check an item of that itemtype out for 7 days 5) Verify the patron now has rental fee of 7.00 Signed-off-by: Matha Fuerst <mfuerst at hmcpl.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 13:55:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 12:55:04 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-UWMjA7HHC8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85545|0 |1 is obsolete| | --- Comment #143 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86142&action=edit Bug 20912: Update schema file Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 13:55:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 12:55:08 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-aEIispHXhK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85546|0 |1 is obsolete| | --- Comment #144 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86143&action=edit Bug 20912: (QA follow-up) Fix number of tests and correct typos Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 13:55:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 12:55:12 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-PWFnxcuRpL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85547|0 |1 is obsolete| | --- Comment #145 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86144&action=edit Bug 20912: (QA follow-up) Set daily charge to 0 for item type not being used for test Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 13:55:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 12:55:16 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-Ivk03lPoUd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85548|0 |1 is obsolete| | --- Comment #146 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86145&action=edit Bug 20912: (QA follow-up) Make unit tests reliable and get rid of perl warnings Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 13:55:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 12:55:21 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-iOdGjWJ4cv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85549|0 |1 is obsolete| | --- Comment #147 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86146&action=edit Bug 20912: Move calculation to Koha::Fees Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 13:55:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 12:55:25 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-FBqUxnudsh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85550|0 |1 is obsolete| | --- Comment #148 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86147&action=edit Bug 20912: (QA follow-up): Fix up Koha::Fees Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 13:55:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 12:55:30 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-QuZGvCU5qR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85551|0 |1 is obsolete| | --- Comment #149 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86148&action=edit Bug 20912: (QA follow-up): Fix up unit tests Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 13:55:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 12:55:34 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-2FLlrmp5Ae@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85552|0 |1 is obsolete| | --- Comment #150 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86149&action=edit Bug 20912: (QA follow-up) Move Fees to Charges:: In preparation for the introduction of Koha::Charges::Fines I have moved this ::Fees class into the Koha::Charges:: namespace Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 13:55:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 12:55:36 +0000 Subject: [Koha-bugs] [Bug 20421] Inform staff that patron does have the title checked out during placing hold In-Reply-To: <bug-20421-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20421-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20421-70-vXBLQXy9oq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20421 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86133|0 |1 is obsolete| | --- Comment #8 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86150&action=edit Bug 20421: Inform staff that patron does have the title checked out during placing hold Test plan: 1) Enable the CheckPrevCheckout and DisplayMultiPlaceHold system preferences 2) Have a patron with some checkouts history 3) Try to place hold on one of titles from history for this patron 4) You should see an information at the top of confirm request page, but you still should be able to place a hold 5) Try this with multiple titles - one or more of them should be from history 6) You should see this information in "Information" column 7) There is also new column placed at the beggining with checkbox, you could uncheck it for titles you do not want to place a hold on it 8) Confirm the hold is placed only on checked titles -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 13:55:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 12:55:38 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-91j8Vwl2Wo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85553|0 |1 is obsolete| | --- Comment #151 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86151&action=edit Bug 20912: (QA follow-up) Test for distinct accountlines Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 13:55:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 12:55:42 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-saNCtMWLBT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85554|0 |1 is obsolete| | --- Comment #152 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86152&action=edit Bug 20912: (QA follow-up) Make DB Update idempotent Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 13:55:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 12:55:47 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-P3Cm0Tnjsh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85555|0 |1 is obsolete| | --- Comment #153 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86153&action=edit Bug 20912: (follow-up) Improve test coverage Increase test coverage for CanBookBeIssued and fix a introduced during the refactoring to Koha::Fees. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 13:55:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 12:55:54 +0000 Subject: [Koha-bugs] [Bug 22462] Crash in patron card printing In-Reply-To: <bug-22462-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22462-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22462-70-8bzEN9J6WC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22462 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- If what Christian describes happens, this brings down the instance until the process is killed (like with a Plack restart) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 13:55:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 12:55:51 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-1qIKSnInUK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85556|0 |1 is obsolete| | --- Comment #154 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86154&action=edit Bug 20912: (follow-up) Add hourly support It seemed strange to only add support for Daily loans in the feature when Koha also support loan periods in hours. This patch adds parallel functionaliy for hourly loan periods. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 13:55:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 12:55:55 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-AZp7dZjl1G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85557|0 |1 is obsolete| | --- Comment #155 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86155&action=edit Bug 20912: (QA follow-up) Fix TestBuilder Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 13:56:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 12:56:00 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-jEsdpMj5kL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85558|0 |1 is obsolete| | --- Comment #156 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86156&action=edit Bug 20912: (QA follow-up) Fix some test failures Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 13:56:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 12:56:04 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-DdgRNPfTKI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85559|0 |1 is obsolete| | --- Comment #157 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86157&action=edit Bug 20912: (QA follow-up) POD fix Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 13:56:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 12:56:08 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-tpCgQszvpj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85560|0 |1 is obsolete| | --- Comment #158 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86158&action=edit Bug 20912: (QA follow-up) The default rule already has renewalsallowed=0 Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 13:56:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 12:56:13 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-E0qotGkWsN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85561|0 |1 is obsolete| | --- Comment #159 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86159&action=edit Bug 20912: (follow-up) Prevent double charging on renewal This patch updates the tests the ensure we do not double charge for renewals that take place before the original due date and fixes the corresponding loging in C4::Circulation::AddRenewal. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 13:56:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 12:56:17 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-Frtl6wWzWc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85631|0 |1 is obsolete| | --- Comment #160 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86160&action=edit Bug 20912: (QA follow-up) Warn patron of daily and hourly renewal fees Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 14:00:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 13:00:25 +0000 Subject: [Koha-bugs] [Bug 20421] Inform staff that patron does have the title checked out during placing hold In-Reply-To: <bug-20421-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20421-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20421-70-s0auO9AcfD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20421 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #9 from Josef Moravec <josef.moravec at gmail.com> --- Rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 14:01:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 13:01:23 +0000 Subject: [Koha-bugs] [Bug 19520] Show more information about rotating collections In-Reply-To: <bug-19520-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19520-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19520-70-mHCGa7Kfit@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19520 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |BLOCKED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 14:04:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 13:04:07 +0000 Subject: [Koha-bugs] [Bug 22355] site can't be reached in koha In-Reply-To: <bug-22355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22355-70-0FaEJog38k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22355 tapu <tapu.b3u at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tapu.b3u at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 14:04:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 13:04:22 +0000 Subject: [Koha-bugs] [Bug 22461] Regression in #20287: LDAP user replication broken with mapped extended patron attributes In-Reply-To: <bug-22461-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22461-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22461-70-7HX77SHoYI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22461 --- Comment #1 from Oliver Behnke <oliver.behnke at aei.mpg.de> --- Update: while adding a filter for the extended attributes at [1] ensures account replication, the newly created account will lack the mapped extended attribute content until a subsequent update (e.g. on the second login). So that's another aspect that needs to be fixed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 14:05:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 13:05:39 +0000 Subject: [Koha-bugs] [Bug 22463] New: site can't be reached in koha Message-ID: <bug-22463-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22463 Bug ID: 22463 Summary: site can't be reached in koha Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: tapu.b3u at gmail.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Created attachment 86161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86161&action=edit site can't be reached in koha site can't be reached in koha -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 14:08:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 13:08:42 +0000 Subject: [Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint In-Reply-To: <bug-22008-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22008-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22008-70-laEOQYrsEm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 14:08:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 13:08:45 +0000 Subject: [Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint In-Reply-To: <bug-22008-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22008-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22008-70-4aDRskZmvN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85767|0 |1 is obsolete| | Attachment #85768|0 |1 is obsolete| | --- Comment #30 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 86162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86162&action=edit Bug 22008: Add tests for new constraints Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 14:09:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 13:09:05 +0000 Subject: [Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint In-Reply-To: <bug-22008-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22008-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22008-70-hWgp3ihaXb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #31 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 86163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86163&action=edit Bug 22008: Add missing constraints Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 14:09:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 13:09:08 +0000 Subject: [Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint In-Reply-To: <bug-22008-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22008-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22008-70-lFIa4USEm7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #32 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 86164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86164&action=edit Bug 22008: Fixes to make unit tests pass Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 14:09:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 13:09:28 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18925-70-xyQkEcfRZq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #116 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 86165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86165&action=edit Bug 18925: (QA follow-up) Remove weird 'Null' values for integer column Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 14:13:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 13:13:01 +0000 Subject: [Koha-bugs] [Bug 7890] Highlight required field in MARC editor In-Reply-To: <bug-7890-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7890-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7890-70-w4pQYnNPKm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7890 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #3 from Owen Leonard <oleonard at myacpl.org> --- (In reply to Cori Lynn Arnold from comment #2) > I got this error below when I tried to import a record ... > Could not compile /kohadevbox/koha/cataloguing/addbiblio.pl: Global symbol > "$tab" requires explicit package name (did you forget to declare "my $tab"?) My patch only changes the template, so I think this error has another cause. Did you apply all the dependencies first? Maybe you need to use the "restart_all" command? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 14:18:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 13:18:44 +0000 Subject: [Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules In-Reply-To: <bug-18928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18928-70-YO1KFS3iTN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #24 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- I've: - Tried setting global and branch-specific rules - Upgrade migrated the rules correctly - Tests pass - QA scripts happy Good job! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 14:29:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 13:29:00 +0000 Subject: [Koha-bugs] [Bug 22355] site can't be reached in koha In-Reply-To: <bug-22355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22355-70-qxhfADNmQz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22355 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** Bug 22463 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 14:29:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 13:29:00 +0000 Subject: [Koha-bugs] [Bug 22463] site can't be reached in koha In-Reply-To: <bug-22463-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22463-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22463-70-BGSEsJ0Ozy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22463 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Please bring this up on the mailnig list - see my commen ton bug 22355. *** This bug has been marked as a duplicate of bug 22355 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 14:33:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 13:33:23 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18925-70-VDP9Xtlj9v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #117 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- 2 new commits added to misc4dev to insert the circ rules correctly: commit 8eb9c2489ce376e719fcc0a9a1549c83207a8a20 Fix insert circ rules since bug 18925 And its followup... commit 02e6701eb923947a3939e27884c354dc4cb05401 (follow-up) Fix insert circ rules since bug 18925 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 14:35:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 13:35:01 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18925-70-T2C1ySZ1OT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #118 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Tom?s Cohen Arazi from comment #116) > Created attachment 86165 [details] [review] > Bug 18925: (QA follow-up) Remove weird 'Null' values for integer column > > Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> As 0 is the default value defined at DBMS level we could have removed the lines :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 14:36:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 13:36:03 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18925-70-xsRP8nsINP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #119 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- (In reply to Jonathan Druart from comment #118) > (In reply to Tom?s Cohen Arazi from comment #116) > > Created attachment 86165 [details] [review] [review] > > Bug 18925: (QA follow-up) Remove weird 'Null' values for integer column > > > > Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> > > As 0 is the default value defined at DBMS level we could have removed the > lines :) Sure, I prefered to make it explicit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 14:36:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 13:36:19 +0000 Subject: [Koha-bugs] [Bug 11969] Show patrons star rating on their reading history In-Reply-To: <bug-11969-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11969-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11969-70-fmpTQDjDaX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11969 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 14:44:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 13:44:03 +0000 Subject: [Koha-bugs] [Bug 22460] Printer doesn't save, when 'paper bin' is left empty In-Reply-To: <bug-22460-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22460-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22460-70-6NXMIIYqZ2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22460 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** This bug has been marked as a duplicate of bug 21052 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 14:44:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 13:44:03 +0000 Subject: [Koha-bugs] [Bug 21052] New patron card printer profile won't save if paper bin is empty In-Reply-To: <bug-21052-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21052-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21052-70-gcfDQ24se3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21052 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** Bug 22460 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 14:44:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 13:44:11 +0000 Subject: [Koha-bugs] [Bug 22429] Infinite loop in patron card printing In-Reply-To: <bug-22429-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22429-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22429-70-EN9bo2f0zJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22429 Christian Stelzenm?ller <christian.stelzenmueller at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21052 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 14:44:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 13:44:11 +0000 Subject: [Koha-bugs] [Bug 21052] New patron card printer profile won't save if paper bin is empty In-Reply-To: <bug-21052-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21052-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21052-70-DDgXGLQtRi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21052 Christian Stelzenm?ller <christian.stelzenmueller at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22429 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 14:44:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 13:44:21 +0000 Subject: [Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function In-Reply-To: <bug-12159-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12159-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12159-70-X2tYHCuT7l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77050|0 |1 is obsolete| | --- Comment #36 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86166&action=edit Bug 12159: Fix getting extended patron attributes for circ-menu Changes: - Replace getting preference ExtendedPatronAttributes by Koha.Preference in templates - Add Koha::Patron->attributes for getting patrons extended attributes - Use this method in circ-menu.inc - Remove getting attributes from members perl scripts Test plan: 0) Apply the patch 1) Add some patron attributes type - with free text, authorised value, limited by libraries... 2) Add some values to this attributes for some patrons 3) Go through as many patron pages as you can and confirm that attributes are shown at side panel when they shoul and are not shown when they should not be shown Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 14:44:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 13:44:29 +0000 Subject: [Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function In-Reply-To: <bug-12159-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12159-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12159-70-08hgH2BJ8N@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77052|0 |1 is obsolete| | --- Comment #38 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86168&action=edit Bug 12159: (QA follow-up) Silencing POD warn from qa tools *** ERROR: Spurious text after =cut at line 954 in file Koha/Patron.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 14:44:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 13:44:25 +0000 Subject: [Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function In-Reply-To: <bug-12159-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12159-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12159-70-ey7zdtpNBF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77051|0 |1 is obsolete| | --- Comment #37 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86167&action=edit Bug 12159: Add tests Test plan: prove t/db_dependent/Koha/Patron/Attributes.t t/db_dependent/Koha/Patrons.t Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 14:45:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 13:45:01 +0000 Subject: [Koha-bugs] [Bug 21052] New patron card printer profile won't save if paper bin is empty In-Reply-To: <bug-21052-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21052-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21052-70-RvM0F0BGcZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21052 --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Katrin Fischer from comment #2) > We've also managed to create a template that takes up 100% CPU and brings > down Koha when trying to print a PDF. But so far have not been able to > figure out how to reproduce it on another system. There are some serious > issues with the forms not checking for good input. We filed bug 22462 for this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 14:49:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 13:49:19 +0000 Subject: [Koha-bugs] [Bug 18930] Move lost item refund rules to circulation_rules table In-Reply-To: <bug-18930-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18930-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18930-70-HBA5ZVAFgc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 14:49:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 13:49:23 +0000 Subject: [Koha-bugs] [Bug 18930] Move lost item refund rules to circulation_rules table In-Reply-To: <bug-18930-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18930-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18930-70-k1YDv8KQVJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85492|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 14:49:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 13:49:25 +0000 Subject: [Koha-bugs] [Bug 18930] Move lost item refund rules to circulation_rules table In-Reply-To: <bug-18930-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18930-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18930-70-T1dNTGa3LQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85493|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 14:50:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 13:50:19 +0000 Subject: [Koha-bugs] [Bug 18930] Move lost item refund rules to circulation_rules table In-Reply-To: <bug-18930-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18930-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18930-70-vTUXNEqVeu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 --- Comment #14 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 86170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86170&action=edit Bug 18930: Do not insert '*' in circulation_rules We must insert NULL instead, otherwise the FK constraint will fail Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 14:50:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 13:50:29 +0000 Subject: [Koha-bugs] [Bug 18930] Move lost item refund rules to circulation_rules table In-Reply-To: <bug-18930-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18930-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18930-70-wX7vuwk27U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 --- Comment #15 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 86171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86171&action=edit Bug 18930: (follow-up) Make DB update idempotent Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 14:50:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 13:50:13 +0000 Subject: [Koha-bugs] [Bug 18930] Move lost item refund rules to circulation_rules table In-Reply-To: <bug-18930-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18930-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18930-70-nPVJGbgt7n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 --- Comment #13 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 86169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86169&action=edit Bug 18930: Move lost item refund rules to circulation_rules table This patch will move the list item refund rules from a dedicated table to the circulation_rules table. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Verify lost item refund rules remain unchanged Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 14:50:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 13:50:47 +0000 Subject: [Koha-bugs] [Bug 22445] Ability to define a url for custom cover images In-Reply-To: <bug-22445-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22445-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22445-70-Vh2C4P1x7o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Hayley Mapley from comment #15) > These patches don't seem to work fully as expected for me, as outlined below. > > When clicking Edit on the bibliographic record details page and uploading a > custom image, all test plans pass except for: > - OPAC reviews (Comment #11 rss - template is still broken it seems), > - OPAC reviews (Comment #10 Recent Comments), > - OPAC user (Comment #12 checkout list). > In the case of the latter two scenarios, instead of displaying the image or > the 'no cover image' placeholder image, a link that says 'Cover image' is > displayed. > > In terms of the url/local path options in the system prefs, is there > anything that needs to be done apart from allowing display, setting the > path/url and ensuring that the biblio has a url that is present in the > path/url? I'm having trouble testing this (I'm pretty new) > > Additionally, in most places where the cover image is displayed (such as the > item detail page, etc.), the 'Cover image' link is also displayed > underneath. I'm assuming this is a bug? Hello Hayley, Did you fill CustomCoverImagesURL in? What value? You are not supposed to attach an image to the record (this is the LocalCoverImages feature) neither add "an url to a biblio" (I did not understand that part in your comment). To test easily you can use "https://covers.openlibrary.org/b/isbn/%isbn%-M.jpg" (and not .jpb as written in the test plan, sorry it's a typo!) Then the feature will behave the same as OpenLibraryCovers (it will pick the same covers). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 14:50:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 13:50:54 +0000 Subject: [Koha-bugs] [Bug 18930] Move lost item refund rules to circulation_rules table In-Reply-To: <bug-18930-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18930-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18930-70-YQQEeir7D3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 15:05:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 14:05:53 +0000 Subject: [Koha-bugs] [Bug 22464] New: Copyright notice does not pass forward request properties Message-ID: <bug-22464-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22464 Bug ID: 22464 Summary: Copyright notice does not pass forward request properties Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs at lists.koha-community.org Reporter: andrew.isherwood at ptfs-europe.com Target Milestone: --- It is possible that request properties have been supplied prior to the copyright notice stage being reached, for example using the OpenURL submission function provided by the FreeForm backend. As such, any request parameters are lost since the "Yes" acceptance button on the copyright notice does not pass any parameters forward. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 15:06:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 14:06:46 +0000 Subject: [Koha-bugs] [Bug 22464] Copyright notice does not pass forward request properties In-Reply-To: <bug-22464-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22464-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22464-70-V2rfhieKWD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22464 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |andrew.isherwood at ptfs-europ |ity.org |e.com Status|NEW |ASSIGNED Depends on| |18589 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 [Bug 18589] Show ILLs as part of patron profile -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 15:06:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 14:06:46 +0000 Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile In-Reply-To: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18589-70-bV1foftXqu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22464 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22464 [Bug 22464] Copyright notice does not pass forward request properties -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 15:08:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 14:08:58 +0000 Subject: [Koha-bugs] [Bug 22023] Further improve responsive layout handling of staff client menu bar In-Reply-To: <bug-22023-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22023-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22023-70-0sUh2j3NDU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22023 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 15:09:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 14:09:01 +0000 Subject: [Koha-bugs] [Bug 22023] Further improve responsive layout handling of staff client menu bar In-Reply-To: <bug-22023-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22023-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22023-70-QHwjh4j4qk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22023 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84727|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 86172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86172&action=edit Bug 22023: Further improve responsive layout handling of staff client menu bar This patch makes a number of changes in order to improve the way the staff client's header menu adjusts at narrower browser widths: - Updated version of Bootstrap 3.3.7 which includes the "collapse" JavaScript plugin. - Modified default Bootstrap CSS using Bootstrap's customization tool. These changes facilitate the removal of some custom CSS (overriding Bootstrap) from staff-global.scss. - Added Bootstrap config file for loading customizations at https://getbootstrap.com/docs/3.3/customize/ - Revised button classes for buttons in Bootstrap-styled toolbars. The modified default CSS resets the base font size in Bootstrap to better match our global CSS. A side-effect of this is that toolbar buttons ended up looking smaller than they should. Changing the button class solves this. - Restructure the header menu in order to allow different rules to govern the appearance of the navigational part of the menu (Circulation, Search, etc) and the user menu (Set library, My account, Log out). - Modify the cart JS to so that the popup works well at narrow widths. To test, apply the patch, regenerate the staff client CSS, and clear your browser cache. - Log in to the staff client and observe the layout of the header menu as you adjust the browser to various widths. - Confirm that sections of the menu "collapse" as the window gets narrower. - Confirm that dropdown menus behave correctly and that links work. - Confirm that the Cart link works as expected when the cart empty and when it has items. - Install and enable multiple translations, including at least one set of sub-languages (e.g. fr-FR and fr-CA). - Test the appearance of the language menus in the footer at various browser widths. - View pages with button toolbars and confirm that they appear unchanged (e.g. biblio detail page, patron detail page). NOTE: While this patch is intended to make improvements to staff client responsiveness, it does so within a limited scope. There are still many pages which do not work well at narrower browser widths. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 15:24:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 14:24:02 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18823-70-rvPB3BIpL1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 --- Comment #67 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 86173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86173&action=edit Bug 21720: Update Tests AddIssuing charge is always called in void context, but the tests checked that the return value was a Koha::Account::Offset and we now return a Koha::Account::Line. This patch changes the test to accept a Koha::Account::Line as returned, adds a test to ensure a Koha::Account::Offset is also created and corrects the logic that tests that only one accountline is added. Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: cori <corilynn.arnold at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 15:24:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 14:24:05 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18823-70-9amy8UKyIg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 --- Comment #68 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 86174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86174&action=edit Bug 21728: (RM follow-up) Add 'Reserve Fee' for new installs Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: cori <corilynn.arnold at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 15:24:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 14:24:08 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18823-70-mkb9fp5Voq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85355|0 |1 is obsolete| | --- Comment #69 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 86175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86175&action=edit Bug 18823: Rancor - add support for editing/searching records rebase. Signed-off-by: cori <corilynn.arnold at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 15:24:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 14:24:14 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18823-70-vatXtsEO5x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85357|0 |1 is obsolete| | --- Comment #71 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 86177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86177&action=edit Bug 18823: Rancor - save override warnings Rebase. Signed-off-by: cori <corilynn.arnold at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 15:24:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 14:24:11 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18823-70-Gj5huoMsBe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85356|0 |1 is obsolete| | --- Comment #70 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 86176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86176&action=edit Bug 18823: Improvements to import batch searching and enabled/disabled Rebase. Signed-off-by: cori <corilynn.arnold at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 15:24:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 14:24:17 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18823-70-Fe3QJkwfhW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85358|0 |1 is obsolete| | --- Comment #72 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 86178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86178&action=edit Bug 18823: Rancor - improve batch search/update ISBN handling Rebase Signed-off-by: cori <corilynn.arnold at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 15:24:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 14:24:20 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18823-70-bfM8dzUijA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85359|0 |1 is obsolete| | --- Comment #73 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 86179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86179&action=edit Bug 18823: Search improvements Search can now find titles and keywords with single quotes i.e. "Time Traveler's Wife" in import batches. Tests: 1) Open advanced cataloging edtior 2) Under settings select 'Import Batches' 3) Create a few import batches, some for searching and some as targets (and some both) 3.a) note that import batches for saving appear on the left side as targets to save 4) Search for a bibliographic record, make changes and apply to an import batch 5) Search for the bibliographic record in the import batch by author, title, isbn 6) Make changes to the import batch records and verify the changes are applied (either through searching again, or through the Staged MARC management page in Tools) Signed-off-by: cori <corilynn.arnold at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 15:24:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 14:24:23 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18823-70-RyPfyBeoOU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85719|0 |1 is obsolete| | --- Comment #74 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 86180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86180&action=edit Bug 18823: Keep Batch selected and remove record backends when needed. Signed-off-by: cori <corilynn.arnold at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 15:24:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 14:24:26 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18823-70-kz7Z2HffAV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85720|0 |1 is obsolete| | --- Comment #75 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 86181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86181&action=edit Bug 18823: Check Batch and Record save target when importing a record from a batch. Signed-off-by: cori <corilynn.arnold at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 15:24:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 14:24:28 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18823-70-XMxKGYTckN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85828|0 |1 is obsolete| | --- Comment #76 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 86182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86182&action=edit Bug 18823: Don't show/check batch that are not enabled for saved targets Signed-off-by: cori <corilynn.arnold at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 15:24:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 14:24:31 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18823-70-sBYnV5LPe3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86087|0 |1 is obsolete| | --- Comment #77 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 86183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86183&action=edit Bug 18823: Fix targets registering Signed-off-by: cori <corilynn.arnold at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 15:25:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 14:25:12 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18823-70-dgSeOCkOSk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Cori Lynn Arnold <carnold at dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #78 from Cori Lynn Arnold <carnold at dgiinc.com> --- Looks great! Worked with it for an hour cataloging :) -cori lynn -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 15:27:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 14:27:28 +0000 Subject: [Koha-bugs] [Bug 22464] Copyright notice does not pass forward request properties In-Reply-To: <bug-22464-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22464-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22464-70-AHqvFDweTh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22464 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 15:27:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 14:27:30 +0000 Subject: [Koha-bugs] [Bug 22464] Copyright notice does not pass forward request properties In-Reply-To: <bug-22464-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22464-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22464-70-OXFCnFkqJe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22464 --- Comment #1 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 86184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86184&action=edit Bug 22464: Pass forward parameters This patch ensures that parameters that are present are passed forward when accepting the copyright notice. Test plan: - Clone the latest version of the FreeForm backend from: https://github.com/PTFS-Europe/koha-ill-freeform - Ensure the ILLModuleCopyrightClearance syspref is populated - Create an OpenURL in order to pre-populate the FreeForm form, a suitable URL would be: <your_koha_instance>/cgi-bin/koha/opac-illrequests.pl?openurl=true&backend=FreeForm&method=create&opac=1&atitle=Theater%20careers.%20%5Belectronic%20resource%5D%20%3A%20a%20realistic%20guide.&aulast=Donahue%2C%20Tim&date=2012&genre=article&isbn=978123123123&issn=1234-5678&issue=34&pages=12-34&sid=EBSCO%3AAthlone%20Institute%20of%20Technology%3Aait.101326&title=article%20title%20here&volume=12 - Log in - Accept the copyright notice => TEST: Observe that the FreeForm form is pre-filled with the metadata supplied in the OpenURL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 15:32:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 14:32:17 +0000 Subject: [Koha-bugs] [Bug 22465] New: PatronSelfRegistrationExpireTemporaryAccountsDelay should recommend cleanup_database.pl Message-ID: <bug-22465-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22465 Bug ID: 22465 Summary: PatronSelfRegistrationExpireTemporaryAccountsDelay should recommend cleanup_database.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Target Milestone: --- The description of the PatronSelfRegistrationExpireTemporaryAccountsDelay syspref says "This system preference requires the <code>misc/cronjobs/delete_expired_opac_registrations.pl</code> cronjob.": http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/opac.pref;h=da1d86540c321260a336867d5518af6bc35f2b1b;hb=HEAD#l741 But if you look at delete_expired_opac_registrations.pl it says: "IMPORTANT: You should no longer call this script. Please use cleanup_database.pl with parameter --del-exp-selfreg.": http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=misc/cronjobs/delete_expired_opac_registrations.pl;h=66f9e165e84be5813f1bd2c1eabe881c156b8d43;hb=HEAD#l44 So the description of PatronSelfRegistrationExpireTemporaryAccountsDelay should refer to cleanup_database.pl, not the obsolete delete_expired_opac_registrations.pl. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 15:34:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 14:34:09 +0000 Subject: [Koha-bugs] [Bug 22461] Regression in #20287: LDAP user replication broken with mapped extended patron attributes In-Reply-To: <bug-22461-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22461-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22461-70-bFVfmDFAVo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22461 --- Comment #2 from Oliver Behnke <oliver.behnke at aei.mpg.de> --- Regarding the missing extended attribute replication: I think the reason is that the original code [1] set $borrowernumber to the newly created value, and the current version's Patron:new()->store() doesn't do that, so $borrowernumber is always 0. This would then cause [3] to never execute, hence the missing update of the mapped extended attributes. FYI, this also causes the setting of the messaging preferences to fail with a foreign key constraint violation at [4]. [3] https://github.com/Koha-Community/Koha/blob/a6059c4d2d43e43aa021069ce97d6424a76c4f41/C4/Auth_with_ldap.pm#L231 [4] https://github.com/Koha-Community/Koha/blob/a6059c4d2d43e43aa021069ce97d6424a76c4f41/C4/Auth_with_ldap.pm#L227 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 15:38:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 14:38:53 +0000 Subject: [Koha-bugs] [Bug 22430] importing from a UNIMARC backup will import biblio records but not items In-Reply-To: <bug-22430-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22430-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22430-70-BIfMk40uyv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22430 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #2 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- (In reply to Giuseppe Ciaccio from comment #0) > So it seems that the UNIMARC item field is correctly fetched when importing > the backup in the stage area, but discarded when the staged records are > pushed in the catalog. I think I found why. The push to catalog is not allowed because the items have the same barcode which must be unique in catalog. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 15:59:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 14:59:12 +0000 Subject: [Koha-bugs] [Bug 21576] Add a developer script to automatically fix missing filters In-Reply-To: <bug-21576-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21576-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21576-70-uXfO8yg0i3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21576 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22466 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22466 [Bug 22466] TT methods must not be escaped -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 15:59:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 14:59:12 +0000 Subject: [Koha-bugs] [Bug 22466] New: TT methods must not be escaped Message-ID: <bug-22466-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22466 Bug ID: 22466 Summary: TT methods must not be escaped Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 21576 Target Milestone: --- They could (it will not break anything) but it does not make sense. So far the QA script is failing if they are not. For instance: [% my_array.push(a_var) %] Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21576 [Bug 21576] Add a developer script to automatically fix missing filters -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 16:00:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 15:00:52 +0000 Subject: [Koha-bugs] [Bug 22466] TT methods must not be escaped In-Reply-To: <bug-22466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22466-70-MDu5jwTppn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22466 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 16:00:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 15:00:59 +0000 Subject: [Koha-bugs] [Bug 22466] TT methods must not be escaped In-Reply-To: <bug-22466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22466-70-AAloEav23o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22466 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86185&action=edit Bug 22466: Add tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 16:01:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 15:01:04 +0000 Subject: [Koha-bugs] [Bug 22466] TT methods must not be escaped In-Reply-To: <bug-22466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22466-70-VSYIKsOZEa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22466 --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86186&action=edit Bug 22466: Do not ask for TT methods to be filtered -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 16:01:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 15:01:10 +0000 Subject: [Koha-bugs] [Bug 22466] TT methods must not be escaped In-Reply-To: <bug-22466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22466-70-LfHQdpPLnz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22466 --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86187&action=edit Bug 22466: Replace existing occurrences -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 16:02:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 15:02:16 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18925-70-VCQ4hxsl7V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22466 --- Comment #120 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Nick Clemens from comment #111) > QA tool complaint: > FAIL koha-tmpl/intranet-tmpl/prog/en/modules/admin/smart-rules.tt > FAIL filters > missing_filter at line 12 ( [% categorycodes.push( pc.id ) %]) > > Is this a false positive? Or how can we filter on pushing to an array? See bug 22466. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 16:02:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 15:02:16 +0000 Subject: [Koha-bugs] [Bug 22466] TT methods must not be escaped In-Reply-To: <bug-22466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22466-70-gzfqCO577r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22466 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18925 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 16:14:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 15:14:06 +0000 Subject: [Koha-bugs] [Bug 22467] New: t/00-valid-xml.t shouldn't fail due to node_modules presence Message-ID: <bug-22467-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22467 Bug ID: 22467 Summary: t/00-valid-xml.t shouldn't fail due to node_modules presence Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Now we have the scss compile step many devs will have an ignored node_modules directory.. we shouldn't run this directory through t/00-valid-xml.t. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 16:15:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 15:15:09 +0000 Subject: [Koha-bugs] [Bug 18837] Add an unmediated Interlibrary Loans workflow In-Reply-To: <bug-18837-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18837-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18837-70-J3snRMbIYm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82508|0 |1 is obsolete| | --- Comment #18 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 86188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86188&action=edit Bug 18837: Add ILL Unmediated syspref stuff This patch adds the syspref requirements for unmediated ILL requests. It is a recreation of https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66628&action=diff which had diverged sufficiently as to make it impossible to apply. * installer/data/mysql/atomicupdate/illunmediated_tables.sql: New file. * installer/data/mysql/sysprefs.sql: Add `ILLModuleUnmediated`. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref: Add `ILLModuleUnmediated` handling. Signed-off-by: Stephen Graham <s.graham4 at herts.ac.uk> Signed-off-by: David Peacock <d.m.peacock at herts.ac.uk> Signed-off-by: Jayne Maisey <j.maisey at herts.ac.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 16:15:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 15:15:12 +0000 Subject: [Koha-bugs] [Bug 18837] Add an unmediated Interlibrary Loans workflow In-Reply-To: <bug-18837-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18837-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18837-70-Z2X4XfeECu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82509|0 |1 is obsolete| | --- Comment #19 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 86189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86189&action=edit Bug 18837: Introduce delegation to backends for unmediated workflows This patch adds support to Illrequest.pm to allow delegation of unmediated requests to happen in backends that support them. It is a recreation of https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66629&action=diff which had diverged sufficiently as to make it impossible to apply Signed-off-by: Stephen Graham <s.graham4 at herts.ac.uk> Signed-off-by: David Peacock <d.m.peacock at herts.ac.uk> Signed-off-by: Jayne Maisey <j.maisey at herts.ac.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 16:15:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 15:15:34 +0000 Subject: [Koha-bugs] [Bug 18837] Add an unmediated Interlibrary Loans workflow In-Reply-To: <bug-18837-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18837-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18837-70-wBRozLbySX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 16:20:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 15:20:25 +0000 Subject: [Koha-bugs] [Bug 21832] Restore is_expired in ILS-DI GetPatronInfo service In-Reply-To: <bug-21832-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21832-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21832-70-Rm3clBBq8w@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21832 --- Comment #16 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- But several portal use it already with this tag. If it does no harm why not keeping it ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 16:26:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 15:26:19 +0000 Subject: [Koha-bugs] [Bug 8775] Add collection code to lost report In-Reply-To: <bug-8775-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8775-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8775-70-PICCpVMu3t@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8775 --- Comment #8 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 86190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86190&action=edit Bug 8775: (follow-up) Change column header to "Collection" This patch changes the table heading for ccode to be "Collection" instead of "Collection code." Current templates vary, but "Collection" is more logical because we show the description, not the code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 16:26:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 15:26:16 +0000 Subject: [Koha-bugs] [Bug 8775] Add collection code to lost report In-Reply-To: <bug-8775-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8775-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8775-70-LuKax8ITS3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8775 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 16:30:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 15:30:48 +0000 Subject: [Koha-bugs] [Bug 22461] Regression in #20287: LDAP user replication broken with mapped extended patron attributes In-Reply-To: <bug-22461-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22461-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22461-70-6PvbGylEbX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22461 Oliver Behnke <oliver.behnke at aei.mpg.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |Authentication |and plumbing | CC| |dpavlin at rot13.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 16:33:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 15:33:40 +0000 Subject: [Koha-bugs] [Bug 11683] Add search by title or callnumber on courses reserves In-Reply-To: <bug-11683-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11683-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11683-70-UWEyyDypsF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11683 Laura Horgan <horganl at middlesex.mass.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |horganl at middlesex.mass.edu Priority|P5 - low |P3 --- Comment #1 from Laura Horgan <horganl at middlesex.mass.edu> --- In our last system, we had the ability to search for the title of a course reserve not just the course name, number, and prof. name. Often the student doesn't have that information and searching for a title could be helpful. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 16:33:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 15:33:57 +0000 Subject: [Koha-bugs] [Bug 22468] New: Standardize on labeling ccode table columns as Collection Message-ID: <bug-22468-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22468 Bug ID: 22468 Summary: Standardize on labeling ccode table columns as Collection Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Depends on: 8775 Target Milestone: --- Currently the templates are split: Some label table columns with items.ccode as "Collection," some as "Collection code." Since we display the description rather than the code itself we should use "Collection" everywhere. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8775 [Bug 8775] Add collection code to lost report -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 16:33:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 15:33:57 +0000 Subject: [Koha-bugs] [Bug 8775] Add collection code to lost report In-Reply-To: <bug-8775-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8775-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8775-70-KPlQWHN3S6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8775 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22468 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22468 [Bug 22468] Standardize on labeling ccode table columns as Collection -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 16:45:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 15:45:55 +0000 Subject: [Koha-bugs] [Bug 21832] Restore is_expired in ILS-DI GetPatronInfo service In-Reply-To: <bug-21832-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21832-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21832-70-HopnRCQcxf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21832 --- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Fridolin SOMERS from comment #16) > But several portal use it already with this tag. > If it does no harm why not keeping it ? Maybe adding it to the doc? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 16:55:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 15:55:05 +0000 Subject: [Koha-bugs] [Bug 22466] TT methods must not be escaped In-Reply-To: <bug-22466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22466-70-BVOsDavOEM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22466 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 16:55:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 15:55:07 +0000 Subject: [Koha-bugs] [Bug 22466] TT methods must not be escaped In-Reply-To: <bug-22466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22466-70-XDVRsSMEKd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22466 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86185|0 |1 is obsolete| | --- Comment #4 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 86191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86191&action=edit Bug 22466: Add tests Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 16:55:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 15:55:10 +0000 Subject: [Koha-bugs] [Bug 22466] TT methods must not be escaped In-Reply-To: <bug-22466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22466-70-645j9Ss3C7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22466 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86186|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 86192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86192&action=edit Bug 22466: Do not ask for TT methods to be filtered Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 16:55:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 15:55:13 +0000 Subject: [Koha-bugs] [Bug 22466] TT methods must not be escaped In-Reply-To: <bug-22466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22466-70-9G8rP3oQeA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22466 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86187|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 86193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86193&action=edit Bug 22466: Replace existing occurrences Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 17:00:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 16:00:22 +0000 Subject: [Koha-bugs] [Bug 22466] TT methods must not be escaped In-Reply-To: <bug-22466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22466-70-KeN19bmKgU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22466 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86192|0 |1 is obsolete| | --- Comment #8 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 86195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86195&action=edit Bug 22466: Do not ask for TT methods to be filtered Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 17:00:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 16:00:28 +0000 Subject: [Koha-bugs] [Bug 22466] TT methods must not be escaped In-Reply-To: <bug-22466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22466-70-dr5G6eK4SY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22466 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86193|0 |1 is obsolete| | --- Comment #9 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 86196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86196&action=edit Bug 22466: Replace existing occurrences Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 17:00:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 16:00:17 +0000 Subject: [Koha-bugs] [Bug 22466] TT methods must not be escaped In-Reply-To: <bug-22466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22466-70-VagVs0EZ70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22466 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86191|0 |1 is obsolete| | --- Comment #7 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 86194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86194&action=edit Bug 22466: Add tests Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 17:00:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 16:00:55 +0000 Subject: [Koha-bugs] [Bug 22466] TT methods must not be escaped In-Reply-To: <bug-22466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22466-70-FrHLktiefX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22466 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 17:02:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 16:02:18 +0000 Subject: [Koha-bugs] [Bug 18837] Add an unmediated Interlibrary Loans workflow In-Reply-To: <bug-18837-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18837-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18837-70-KqgVNlQDzb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 --- Comment #20 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- To test: - Apply patches - Ensure ILL is enabled and you have at least one backend available that supports unmediated requests (currently only the BLDSS backend supports this) - Enable "ILLModuleUnmediated" preference - Ensure you have default delivery formats specified in your koha-conf.xml. These should be placed inside the <interlibrary_loans> block, an example (which specifies the loan should be a paper copy, of standard quality, delivered within 4 days) is below: <default_formats> <format>4</format> <speed>4</speed> <quality>1</quality> </default_formats> - As an OPAC user, navigate to "Your summary" > "Your interlibrary loan requests" - Select "Create a new request" > "BLDSS" - Search for an item and create an interlibrary loan request => TEST: Observe that in the "Your interlibrary loan requests" view, the request now has the status of "Requested" rather than the "New request" status that it would have in an mediated workflow. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 17:22:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 16:22:11 +0000 Subject: [Koha-bugs] [Bug 15911] Use noEnterSubmit CSS class instead of prevent_submit.js In-Reply-To: <bug-15911-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15911-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15911-70-ytDizxKIgn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15911 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I think the following part was important: - && e.target.nodeName == "INPUT" - && e.target.type != "submit" We want to submit form when pressing enter on the submit button, right? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 17:24:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 16:24:18 +0000 Subject: [Koha-bugs] [Bug 15911] Use noEnterSubmit CSS class instead of prevent_submit.js In-Reply-To: <bug-15911-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15911-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15911-70-ykkCUG5FfS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15911 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9507 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 17:24:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 16:24:18 +0000 Subject: [Koha-bugs] [Bug 9507] Some code used to prevent form from being unexpectedly submitted is duplicated In-Reply-To: <bug-9507-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9507-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9507-70-VOPuu9mePO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9507 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15911 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 17:36:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 16:36:25 +0000 Subject: [Koha-bugs] [Bug 8775] Add collection code to lost report In-Reply-To: <bug-8775-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8775-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8775-70-tewYywVwBq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8775 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Failed QA --- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- We should use the more flexible way to retrieve an AV's value: AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.ccode', authorised_value => item.ccode ) That way, if items.ccode is not bind to an AV, or bind to a different one than CCODE, it will display the correct value. I know it's not how we did in all of the places they are displayed, but it should be the correct way to do :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 17:39:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 16:39:13 +0000 Subject: [Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function In-Reply-To: <bug-12159-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12159-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12159-70-2L3gdG2Yso@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #39 from Josef Moravec <josef.moravec at gmail.com> --- Rebased -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 17:41:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 16:41:31 +0000 Subject: [Koha-bugs] [Bug 8775] Add collection code to lost report In-Reply-To: <bug-8775-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8775-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8775-70-qPi5lhKI0C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8775 --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Jonathan Druart from comment #9) > We should use the more flexible way to retrieve an AV's value: > > AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.ccode', > authorised_value => item.ccode ) > > That way, if items.ccode is not bind to an AV, or bind to a different one > than CCODE, it will display the correct value. I know it's not how we did in > all of the places they are displayed, but it should be the correct way to do > :) What happens if it's not mapped? I know the normal plugin outputs the content of the field. If you mapped another category, you are breaking a lot of things. I am not sure if we should start officially supporting this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 17:47:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 16:47:17 +0000 Subject: [Koha-bugs] [Bug 8775] Add collection code to lost report In-Reply-To: <bug-8775-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8775-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8775-70-47wR7OWmlT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8775 --- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #10) > (In reply to Jonathan Druart from comment #9) > > We should use the more flexible way to retrieve an AV's value: > > > > AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.ccode', > > authorised_value => item.ccode ) > > > > That way, if items.ccode is not bind to an AV, or bind to a different one > > than CCODE, it will display the correct value. I know it's not how we did in > > all of the places they are displayed, but it should be the correct way to do > > :) > > What happens if it's not mapped? I know the normal plugin outputs the > content of the field. It should output the value, yes. > If you mapped another category, you are breaking a lot of things. I am not > sure if we should start officially supporting this. Not supporting, but keeping it in mind for new additions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 17:48:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 16:48:10 +0000 Subject: [Koha-bugs] [Bug 22323] Cronjob runreport.pl has a CSV encoding issue In-Reply-To: <bug-22323-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22323-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22323-70-uPyoM0VN4V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22323 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> --- backported to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 17:50:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 16:50:15 +0000 Subject: [Koha-bugs] [Bug 22239] JavaScript error on subscription detail page when there are no orders In-Reply-To: <bug-22239-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22239-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22239-70-TtoUGD5tQN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22239 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> --- missing dependency for 18.05.x, won't backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 17:51:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 16:51:55 +0000 Subject: [Koha-bugs] [Bug 8775] Add collection code to lost report In-Reply-To: <bug-8775-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8775-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8775-70-bqB41fsfYV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8775 --- Comment #12 from Owen Leonard <oleonard at myacpl.org> --- (In reply to Jonathan Druart from comment #9) > We should use the more flexible way to retrieve an AV's value: > > AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.ccode', > authorised_value => item.ccode ) Is this really a blocker for this bug? There are many existing instances of using AuthorisedValues.GetByCode for ccode. If this is a new best practice they could all be fixed in a separate bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 17:52:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 16:52:23 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18736-70-425kmgAMNl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion --- Comment #162 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #161) > Test pass. QA pass. > Hmm. Not wanting to be too precise, but we still have some subtle > differences in some lines of the last patch. The first line rounds at the > unit; with a whole quantity, it will be rounded. The second line is not > rounded since you multiply with tax rate. The algorithm of tax = incl - excl > is only used in the first line. > The third line shows rounding at final stage. > + $order->{tax_value_on_ordering} = ( > get_rounded_price($order->{ecost_tax_included}) - > get_rounded_price($order->{ecost_tax_excluded}) ) * $order->{quantity}; > + $order->{tax_value_on_ordering} = $order->{quantity} * > get_rounded_price($order->{ecost_tax_excluded}) * > $order->{tax_rate_on_ordering}; > > + my $subtotal = get_rounded_price( $left * > $data->{'ecost_tax_included'} ); > > Please explain why you do what you do. The first line is when the user entered prices including tax - so we have to calculate excluding tax(In reply to Marcel de Rooy from comment #161) > Test pass. QA pass. > Hmm. Not wanting to be too precise, but we still have some subtle > differences in some lines of the last patch. The first line rounds at the > unit; with a whole quantity, it will be rounded. The second line is not > rounded since you multiply with tax rate. The algorithm of tax = incl - excl > is only used in the first line. > The third line shows rounding at final stage. > + $order->{tax_value_on_ordering} = ( > get_rounded_price($order->{ecost_tax_included}) - > get_rounded_price($order->{ecost_tax_excluded}) ) * $order->{quantity}; > + $order->{tax_value_on_ordering} = $order->{quantity} * > get_rounded_price($order->{ecost_tax_excluded}) * > $order->{tax_rate_on_ordering}; > > + my $subtotal = get_rounded_price( $left * > $data->{'ecost_tax_included'} ); > > Please explain why you do what you do. In the first line we are looking at prices supplied including tax - I assumed we get a rounded number from the vendor - I also assume they charge the tax to a single item then round - so we need to back calculate the tax, not knowing the unrounded end product - then charge this same amount per item In the second case (lines 2 and 3) we are given prices without tax, so we can calculate it on our own - and I assume they would perform the same caulcation - round discounted price, apply quantity and tax The issue is really that when getting a price including tax I assume we don't have full info, so do my best to calculate what I expect. Can you explain how you would expect to calculate that and what numbers you would expect to see? The tests illustrate that I do expect different numbers in the different scenarios, I honestly don't know what the vendors or librarians expect and would accept any quidance -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 18:02:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 17:02:06 +0000 Subject: [Koha-bugs] [Bug 22351] SCSS conversion broke style on last checked out information In-Reply-To: <bug-22351-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22351-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22351-70-VG91IUuQAu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22351 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> --- this scss isnt in 18.05.x, not backporting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 18:12:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 17:12:24 +0000 Subject: [Koha-bugs] [Bug 22031] C4::Auth->haspermission should allow checking for more than one subpermission In-Reply-To: <bug-22031-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22031-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22031-70-2tnp6gevx9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22031 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83414|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 18:12:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 17:12:27 +0000 Subject: [Koha-bugs] [Bug 12533] Improve authority search result display In-Reply-To: <bug-12533-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12533-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12533-70-MiBAUWfZ5K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12533 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |oleonard at myacpl.org Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 18:12:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 17:12:37 +0000 Subject: [Koha-bugs] [Bug 22031] C4::Auth->haspermission should allow checking for more than one subpermission In-Reply-To: <bug-22031-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22031-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22031-70-dSbGSDyCFV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22031 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83415|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 18:13:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 17:13:21 +0000 Subject: [Koha-bugs] [Bug 22031] C4::Auth->haspermission should allow checking for more than one subpermission In-Reply-To: <bug-22031-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22031-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22031-70-oKBChtDB2I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22031 --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- I think this is fantastic, it will need documentation but should expand ability to use/combine permissions. Excellent work! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 18:13:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 17:13:45 +0000 Subject: [Koha-bugs] [Bug 22031] C4::Auth->haspermission should allow checking for more than one subpermission In-Reply-To: <bug-22031-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22031-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22031-70-y6N7aUBpag@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22031 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83474|0 |1 is obsolete| | --- Comment #7 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 86197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86197&action=edit Bug 22031: Add SQL::Abstract like syntax to haspermission This patch adds an SQL::Abstract inspired query syntax to the haspermission method in C4::Auth. One can now pass Arrayrefs to denote an OR list of flags, a Hashref to denote a AND list of flags. Structures can be nested at arbitrary depth. Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 18:13:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 17:13:43 +0000 Subject: [Koha-bugs] [Bug 22031] C4::Auth->haspermission should allow checking for more than one subpermission In-Reply-To: <bug-22031-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22031-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22031-70-HLNZ4YRw85@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22031 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 18:16:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 17:16:18 +0000 Subject: [Koha-bugs] [Bug 22156] Subscription result list sorts on "checkbox" by default In-Reply-To: <bug-22156-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22156-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22156-70-qAmMyXrgGg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22156 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #13 from Lucas Gass <lucas at bywatersolutions.com> --- backported to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 18:22:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 17:22:02 +0000 Subject: [Koha-bugs] [Bug 20128] Permission for advanced editor In-Reply-To: <bug-20128-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20128-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20128-70-zCq1RqPCGi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20128 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83416|0 |1 is obsolete| | --- Comment #2 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 86198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86198&action=edit Bug 20128: Add permission for advanced cataloging editor To test: 1 - Have a borrower with edit_catalogue permission and one with editcatalogue top level 2 - Confirm they can both access the advanced editor from the 'Cataloguing' home page or from the basic editor 3 - Apply patch 4 - Update database 5 - Confirm borrower with 'edit_catalogue' has 'advanced_editor' permission 6 - Confirm borrowers can access advanced editor as above 7 - Remove 'advanced_editor' permission from borrower 8 - Ensure they cannot access the advanced editor 9 - Ensure links to 'Edit record' from search results go to basic editor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 18:25:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 17:25:40 +0000 Subject: [Koha-bugs] [Bug 21845] Sort of issues in OPAC subscription table In-Reply-To: <bug-21845-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21845-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21845-70-4fgZWwsRdX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21845 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #9 from Lucas Gass <lucas at bywatersolutions.com> --- backported to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 18:32:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 17:32:13 +0000 Subject: [Koha-bugs] [Bug 16497] Add API routes for libraries In-Reply-To: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16497-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16497-70-2x7DffacWq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16497 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #58 from Lucas Gass <lucas at bywatersolutions.com> --- 18.05.x is missing 22125 dependency, won't backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 18:38:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 17:38:30 +0000 Subject: [Koha-bugs] [Bug 8775] Add collection code to lost report In-Reply-To: <bug-8775-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8775-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8775-70-4CiuXL0RPK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8775 --- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- It's a one line fix, I can provide a follow-up later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 18:46:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 17:46:10 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18936-70-Zmj50Bl0p7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://gitlab.com/joubu/Ko | |ha/commits/bug_18936 --- Comment #35 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Remote branch rebased. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 19:02:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 18:02:44 +0000 Subject: [Koha-bugs] [Bug 21966] Fix descriptions of acquisition permissions to be more clear (again) In-Reply-To: <bug-21966-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21966-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21966-70-sAwvpSzBFT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21966 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> --- backported to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 19:17:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 18:17:19 +0000 Subject: [Koha-bugs] [Bug 12533] Improve authority search result display In-Reply-To: <bug-12533-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12533-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12533-70-nWfYdc6ohf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12533 --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 86199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86199&action=edit Bug 12533: Improve authority search result display This patch implements a few changes in the way authority records are displayed in search results. - In most cases heading type is now displayed as a separate column in the table of search results. - The heading itself is now linked rather than a separate "details" link. In the authority search results for MARC editor plugins the heading link triggers a modal with the authority details instead of linking to a separate page. To test, apply the patch and go to Authorities. - Perform an authority search which will return results. - In the search results headings should be linked to the corresponding detail page. - There should be a separate column for heading type. - Go to Cataloging and create a new record using a framework which has a field linked to an authority type (e.g. 100a -> PERSO_NAME ). - Perform a search which will return results. - In the search results, clicking a heading link should trigger a modal window with the authority details. - Test multiple entries in the results and confirm that each time the correct data is loaded into the modal window. - Test the same process for a field which is linked to the unimarc_field_210c.pl plugin. - Go to Tools -> Batch record modification and submit multiple authority record numbers. - In the results list the heading should be linked correctly to the corresponding detail page. Heading type is not present in this view. - Perform the same test with batch record deletion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 19:17:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 18:17:16 +0000 Subject: [Koha-bugs] [Bug 12533] Improve authority search result display In-Reply-To: <bug-12533-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12533-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12533-70-gTDXmkzqWa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12533 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 19:22:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 18:22:27 +0000 Subject: [Koha-bugs] [Bug 8775] Add collection code to lost report In-Reply-To: <bug-8775-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8775-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8775-70-OK8gnlM9BO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8775 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 19:23:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 18:23:05 +0000 Subject: [Koha-bugs] [Bug 8775] Add collection code to lost report In-Reply-To: <bug-8775-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8775-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8775-70-ErVnkdOfli@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8775 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85912|0 |1 is obsolete| | Attachment #86190|0 |1 is obsolete| | --- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86200&action=edit Bug 8775: Add collection code to lost report This patch adds a column for collection code to the lost items report. To test, apply the patch and run the lost items report. You should see a collection code column. Test column configuration for this table: Go to Administration -> Configure columns. Confirm that the "collection_code" column can be configured and that configuration choices are applied correctly. Signed-off-by: Bin Wen <bin.wen at inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 19:23:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 18:23:18 +0000 Subject: [Koha-bugs] [Bug 8775] Add collection code to lost report In-Reply-To: <bug-8775-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8775-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8775-70-ukTVKrq3G8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8775 --- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86201&action=edit Bug 8775: (follow-up) Change column header to "Collection" This patch changes the table heading for ccode to be "Collection" instead of "Collection code." Current templates vary, but "Collection" is more logical because we show the description, not the code. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 19:23:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 18:23:31 +0000 Subject: [Koha-bugs] [Bug 8775] Add collection code to lost report In-Reply-To: <bug-8775-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8775-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8775-70-vgrqm8l9b4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8775 --- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86202&action=edit Bug 8775: Use the AV mapped with items.ccode instead of CCODE Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 19:27:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 18:27:16 +0000 Subject: [Koha-bugs] [Bug 22469] New: Extend Holdings table in Normal View Message-ID: <bug-22469-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22469 Bug ID: 22469 Summary: Extend Holdings table in Normal View Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: chrs.markx86 at gmail.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Created attachment 86203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86203&action=edit MARC View Hello, I need to display an extra field in Holdings table of Normal View. I want either to replace an existent column, or to extend the table with one more column. The field I want to display is being displayed on MARC View (see the MarcView attachment) and is the link for the e-book/audio-book. In this I want to have a clickable field on Normal View so as to download (or redirect to) the media file of the book. I spent a lot of time trying to handle this with custom XSLT, but it seems that it has not to do with XSLT. Any ideas on how I could handle this? Thank you in advance! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 19:37:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 18:37:55 +0000 Subject: [Koha-bugs] [Bug 22031] C4::Auth->haspermission should allow checking for more than one subpermission In-Reply-To: <bug-22031-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22031-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22031-70-fxBjGVE6Vh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22031 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 19:38:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 18:38:13 +0000 Subject: [Koha-bugs] [Bug 22031] C4::Auth->haspermission should allow checking for more than one subpermission In-Reply-To: <bug-22031-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22031-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22031-70-V88pr6jZtJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22031 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86197|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86204&action=edit Bug 22031: Add SQL::Abstract like syntax to haspermission This patch adds an SQL::Abstract inspired query syntax to the haspermission method in C4::Auth. One can now pass Arrayrefs to denote an OR list of flags, a Hashref to denote a AND list of flags. Structures can be nested at arbitrary depth. Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 19:44:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 18:44:33 +0000 Subject: [Koha-bugs] [Bug 15911] Use noEnterSubmit CSS class instead of prevent_submit.js In-Reply-To: <bug-15911-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15911-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15911-70-yvlTdPDDHJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15911 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 19:44:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 18:44:36 +0000 Subject: [Koha-bugs] [Bug 15911] Use noEnterSubmit CSS class instead of prevent_submit.js In-Reply-To: <bug-15911-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15911-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15911-70-q9ft8NR0Vm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15911 --- Comment #4 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 86205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86205&action=edit Bug 15911: (follow-up) Allow enter to submit using the submit button This patch modifies the checkEnter function so that it is possible to submit a form by tabbing to the submit button and hitting ENTER to submit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 19:47:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 18:47:57 +0000 Subject: [Koha-bugs] [Bug 22434] correct item callnumber search link In-Reply-To: <bug-22434-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22434-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22434-70-rwhRn0veaY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22434 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Could you explain the issue you are trying to fix? Without the patch: I have an item with its callnumber set to AAA&1(2)3 I launch a search and see a link /catalogue/search.pl?idx=callnum&q=%22AAA%261(2)3%22 I click on it and I am redirected to the bibliographic detail page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 19:50:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 18:50:13 +0000 Subject: [Koha-bugs] [Bug 22434] correct item callnumber search link In-Reply-To: <bug-22434-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22434-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22434-70-sL2PCRSmoz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22434 --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Hayley Mapley from comment #2) > Hi, > > I've tested up until Step 7, all looks fine. Would you mind explaining what > you mean in Step 7 when you say 'group search'? > > Cheers, > Hayley Hayley, you need to create a library group (Home ? Administration ? Library groups) with the "Use for staff search groups" feature, then on the advanced search form you will see it at the bottom of the page ("Groups of libraries"). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 19:57:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 18:57:51 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18925-70-wiV2Ph99FO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #121 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 86206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86206&action=edit Bug 18925: (RM follow-up) Remove schema files for deletedtables Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 19:57:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 18:57:55 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18925-70-Xow4AtzCxA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 --- Comment #122 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 86207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86207&action=edit Bug 18925: (RM follow-up) Remove maxissueqty from issuingrule in SIP tests Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 20:01:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 19:01:17 +0000 Subject: [Koha-bugs] [Bug 22444] currencies_manage permission doesn't provide link to manage currencies when selected alone In-Reply-To: <bug-22444-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22444-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22444-70-DR0HPuUZlg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22444 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.11 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 20:08:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 19:08:45 +0000 Subject: [Koha-bugs] [Bug 20128] Permission for advanced editor In-Reply-To: <bug-20128-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20128-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20128-70-ez05gEf7Vl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20128 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 20:08:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 19:08:48 +0000 Subject: [Koha-bugs] [Bug 20128] Permission for advanced editor In-Reply-To: <bug-20128-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20128-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20128-70-1Qios0LDXH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20128 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86198|0 |1 is obsolete| | --- Comment #3 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86208&action=edit Bug 20128: Add permission for advanced cataloging editor To test: 1 - Have a borrower with edit_catalogue permission and one with editcatalogue top level 2 - Confirm they can both access the advanced editor from the 'Cataloguing' home page or from the basic editor 3 - Apply patch 4 - Update database 5 - Confirm borrower with 'edit_catalogue' has 'advanced_editor' permission 6 - Confirm borrowers can access advanced editor as above 7 - Remove 'advanced_editor' permission from borrower 8 - Ensure they cannot access the advanced editor 9 - Ensure links to 'Edit record' from search results go to basic editor Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 20:09:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 19:09:52 +0000 Subject: [Koha-bugs] [Bug 21953] Term "Lost item" untranslatable In-Reply-To: <bug-21953-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21953-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21953-70-Rt5mH8D0DF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 20:09:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 19:09:58 +0000 Subject: [Koha-bugs] [Bug 21953] Term "Lost item" untranslatable In-Reply-To: <bug-21953-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21953-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21953-70-MUaF4W8b4k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83439|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86209&action=edit Bug 21953: Term 'Lost item' untranslatable This patch removes the hardcoded untranslatable string 'Lost item' from C4/Circulation.pm. To test: 1) Make sure the system preference WhenLostChargeReplacementFee is set to Charge 2) Optional: in Administration > Item types, add a default replacement cost to the item type you plan to use 3) Loan an item out to a patron (If there is no default replacement cost, make sure the item has a replacement price) 4) In the patron's account > Details > Loans, click on the item's barcode 5) Set the lost status to Lost 6) Go back to the patron's account > Fines 7) Notice it is written 'Lost item , Lost item title barcode (title)' 8) If you have another language installed, switch to the other language and notice the second Lost item is still in English 9) Apply the patch 10) Redo steps 3-6 11) Notice it is written 'Lost item, title barcode (title)' 12) Optional: switch to another language, notice there is no English string Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 20:10:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 19:10:03 +0000 Subject: [Koha-bugs] [Bug 21953] Term "Lost item" untranslatable In-Reply-To: <bug-21953-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21953-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21953-70-mHsJ5AwrCL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 --- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86210&action=edit Bug 21953: Add tests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 20:10:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 19:10:08 +0000 Subject: [Koha-bugs] [Bug 21953] Term "Lost item" untranslatable In-Reply-To: <bug-21953-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21953-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21953-70-nmz6X8n6nr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 --- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86211&action=edit Bug 21953: Update existing rows in DB -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 20:10:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 19:10:38 +0000 Subject: [Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status In-Reply-To: <bug-17168-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17168-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17168-70-EHdSGC3CJ3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168 --- Comment #38 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Jonathan Druart from comment #37) > It seems that the code in Koha::Patrons->update_category_to must be the same > as what is done in members/update-child.pl and so moved to Koha::Patron. Do > not you think? I agree on that, but I think that would be better handled on its own bug to decide whether it is always done (on store) or should be optional There is work to allow adults to have guarantors (bug 12446) or multiple guarantors (bug 14570) so want to work nicely with those -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 20:10:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 19:10:36 +0000 Subject: [Koha-bugs] [Bug 21953] Term "Lost item" untranslatable In-Reply-To: <bug-21953-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21953-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21953-70-WfJAoq0G21@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |caroline.cyr-la-rose at inlibr |ity.org |o.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 20:13:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 19:13:12 +0000 Subject: [Koha-bugs] [Bug 22444] currencies_manage permission doesn't provide link to manage currencies when selected alone In-Reply-To: <bug-22444-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22444-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22444-70-5dcWDhvM7m@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22444 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 20:13:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 19:13:15 +0000 Subject: [Koha-bugs] [Bug 22444] currencies_manage permission doesn't provide link to manage currencies when selected alone In-Reply-To: <bug-22444-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22444-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22444-70-PRxVfUtJj7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22444 --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 86212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86212&action=edit Bug 22444: currencies_manage permission doesn't provide link to manage currencies when selected alone This patch modifies the acquisitions sidebar menu so that it checks properly for the currencies_manage permission. This patch also removes the menu link directly to the administration home page. Since we're removing the check on the general "CAN_user_parameters" permission it doesn't make sense to assume the page is accessible. To test, apply the patch and modifiy a staff user so that they have no "parameters" permissions but do have "currencies_manage" permission. Go to the Acquisitions home page. There should be a link to currencies management in the sidebar menu. Perform the same test with a user who has "parameters" permissions but not "currencies_manage" permission. There should be no link to currencies in the acquisitions sidebar menu. The user should have access to the administrative home page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 20:17:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 19:17:11 +0000 Subject: [Koha-bugs] [Bug 22444] currencies_manage permission doesn't provide link to manage currencies when selected alone In-Reply-To: <bug-22444-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22444-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22444-70-7DTezzvsng@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22444 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | --- Comment #3 from Owen Leonard <oleonard at myacpl.org> --- (In reply to Andrew from comment #0) > Administration doesn't appear on the home page or the More menu Since all acquisitions-related management pages can be accessed from the acquisitions home page I don't think it's necessary to be concerned about the lack of a link to the administration home page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 20:44:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 19:44:54 +0000 Subject: [Koha-bugs] [Bug 16251] Material type is not correctly set for Rancor 008 widget In-Reply-To: <bug-16251-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16251-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16251-70-xOFVMldNH2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16251 Michal Denar <black23 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 20:44:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 19:44:58 +0000 Subject: [Koha-bugs] [Bug 16251] Material type is not correctly set for Rancor 008 widget In-Reply-To: <bug-16251-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16251-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16251-70-d6Oi74XozE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16251 Michal Denar <black23 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86130|0 |1 is obsolete| | --- Comment #3 from Michal Denar <black23 at gmail.com> --- Created attachment 86213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86213&action=edit Bug 16251: Fix value of material select for Rancor 008 widget The material type is selected in accordance with the leader (06-07) Test plan: 1. Create a new record using the advanced editor 2. Set the leader 6th position to 'c' 3. Save the record and reload the page 4. 'Music' should be automatically selected for 008 5. Try other values for the leader 6th and 7th positions See comment 0 of this bug for the complete mapping Signed-off-by: Michal Denar <black23 at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 20:58:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 19:58:13 +0000 Subject: [Koha-bugs] [Bug 22464] Copyright notice does not pass forward request properties In-Reply-To: <bug-22464-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22464-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22464-70-DLPkCcUrya@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22464 Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mkstephens at lancasterseminar | |y.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 21:01:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 20:01:03 +0000 Subject: [Koha-bugs] [Bug 22453] TestBuilder should generate now() using the current timezone In-Reply-To: <bug-22453-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22453-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22453-70-1MfWeJD3JO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22453 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #5 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- (In reply to Jonathan Druart from comment #4) > (In reply to Hayley Mapley from comment #3) > > prove t/db_dependent/Koha/Patrons.t fails before and after applying this > > patch - setting to Failed QA. > > Hello Hayley, thanks for testing! > > Do you get the same error as in the description or another one? Actually, I don't know what I was doing yesterday which caused failure both times, but today the test passes before and after the patch is applied, so I guess we need to wait for someone who fails the test? Sorry for the confusion/noise! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 21:14:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 20:14:15 +0000 Subject: [Koha-bugs] [Bug 22452] 'Caracters' is typo In-Reply-To: <bug-22452-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22452-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22452-70-dFvaWKjcbG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22452 Michal Denar <black23 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com --- Comment #2 from Michal Denar <black23 at gmail.com> --- HI Josef, patch works like charm. But what about typo "commment". Please make fix for this. http://prntscr.com/mu94gv Thank you -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 21:22:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 20:22:47 +0000 Subject: [Koha-bugs] [Bug 22445] Ability to define a url for custom cover images In-Reply-To: <bug-22445-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22445-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22445-70-B3b8eyLFtA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #18 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- (In reply to Jonathan Druart from comment #17) > (In reply to Hayley Mapley from comment #15) > > These patches don't seem to work fully as expected for me, as outlined below. > > > > When clicking Edit on the bibliographic record details page and uploading a > > custom image, all test plans pass except for: > > - OPAC reviews (Comment #11 rss - template is still broken it seems), > > - OPAC reviews (Comment #10 Recent Comments), > > - OPAC user (Comment #12 checkout list). > > In the case of the latter two scenarios, instead of displaying the image or > > the 'no cover image' placeholder image, a link that says 'Cover image' is > > displayed. > > > > In terms of the url/local path options in the system prefs, is there > > anything that needs to be done apart from allowing display, setting the > > path/url and ensuring that the biblio has a url that is present in the > > path/url? I'm having trouble testing this (I'm pretty new) > > > > Additionally, in most places where the cover image is displayed (such as the > > item detail page, etc.), the 'Cover image' link is also displayed > > underneath. I'm assuming this is a bug? > > Hello Hayley, > Did you fill CustomCoverImagesURL in? What value? > You are not supposed to attach an image to the record (this is the > LocalCoverImages feature) neither add "an url to a biblio" (I did not > understand that part in your comment). > > To test easily you can use > "https://covers.openlibrary.org/b/isbn/%isbn%-M.jpg" > (and not .jpb as written in the test plan, sorry it's a typo!) > > Then the feature will behave the same as OpenLibraryCovers (it will pick the > same covers). Gah! As confusingly written as my comment was (and excluding the fact that I was mistakenly also testing the local cover images), I was simply missing the -M part of that URL which was stopping it from working. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 21:25:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 20:25:15 +0000 Subject: [Koha-bugs] [Bug 22445] Ability to define a url for custom cover images In-Reply-To: <bug-22445-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22445-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22445-70-HFcPmzuuz7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 21:25:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 20:25:18 +0000 Subject: [Koha-bugs] [Bug 22445] Ability to define a url for custom cover images In-Reply-To: <bug-22445-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22445-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22445-70-tWCZQDkDmU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85938|0 |1 is obsolete| | --- Comment #19 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Created attachment 86214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86214&action=edit Bug 22445: Custom cover images - search resulta (staff) Test plan: Search for bibliographic records, the custom covers should be displayed. Sponsored-by: Orex Digital Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz> All test plans pass using URL in CustomcoverImages syspref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 21:37:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 20:37:45 +0000 Subject: [Koha-bugs] [Bug 21987] Local cover 'thumbnail' size is bigger than 'imagefile' size in biblioimages table In-Reply-To: <bug-21987-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21987-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21987-70-T8NkXljXsy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21987 Michal Denar <black23 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 21:37:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 20:37:49 +0000 Subject: [Koha-bugs] [Bug 21987] Local cover 'thumbnail' size is bigger than 'imagefile' size in biblioimages table In-Reply-To: <bug-21987-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21987-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21987-70-451NNmcg1q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21987 Michal Denar <black23 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83370|0 |1 is obsolete| | --- Comment #5 from Michal Denar <black23 at gmail.com> --- Created attachment 86215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86215&action=edit Bug 21987: Do not generate true color thumbnails if not needed If the original image is not a true color image we should not generate a true color thumbnail. Signed-off-by: Michal Denar <black23 at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 21:39:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 20:39:32 +0000 Subject: [Koha-bugs] [Bug 22430] importing from a UNIMARC backup will import biblio records but not items In-Reply-To: <bug-22430-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22430-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22430-70-72utL80XU2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22430 --- Comment #3 from Giuseppe Ciaccio <giuseppe.ciaccio at unige.it> --- Created attachment 86216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86216&action=edit a test backup containing 10 bibliorecords and 21 items (UNIMARC) Try with these records. On my koha installs (two ones at the moment, a 17.11 and a 18.11), importing this batch results into 10 records in the catalog but no items. The batch however contains 21 items, and these are visible in the record copies left in the stage area. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 21:59:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 20:59:22 +0000 Subject: [Koha-bugs] [Bug 22430] importing from a UNIMARC backup will import biblio records but not items In-Reply-To: <bug-22430-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22430-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22430-70-ISO0XOMpZP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22430 --- Comment #4 from Giuseppe Ciaccio <giuseppe.ciaccio at unige.it> --- (In reply to Jonathan Druart from comment #1) > What is a backup in this context? Backup is: saving data away, and use them to restore a service after a catastrophic failure. In koha I would export records to a file, and import them again in case the original archive is lost. > I have exported the records then imported them in a fresh DB. > I got: > MARC staging results : > Processing bibliographic records > 1 records in file > 0 records not staged because of MARC error > 1 records staged > Did not check for matches with existing records in catalog > 5 item records found and staged > > then: > MariaDB [koha_kohadev]> select count(*) from items; > +----------+ > | count(*) | > +----------+ > | 5 | > +----------+ > > All looks good for me (items are displayed on the detail page of the > bibliographic record). > > Tested with UNIMARC. Could you also search the OPAC interface and see the items from there too? I tried the import of the UNIMARC batch now attached to this bugreport. From the admin interface, Home -> Tools -> Stage MARC records for import. Leaving all settings to default. Output is: MARC staging results : Processing bibliographic records 10 records in file 0 records not staged because of MARC error 10 records staged Did not check for matches with existing records in catalog 21 item records found and staged (consistent with the content of batch) Then I click on "Manage staged records" and, in the subsequent page, leave all settings to default and click on "Import this batch into the catalog". Output is: Completed import of records Number of records added 10 Number of records updated 0 Number of records ignored 0 Number of items added 0 Number of items replaced 0 Number of items ignored because of duplicate barcode 0 Clearly the items have been ignored; confirmed by searching the OPAC: it finds the biblio records but no items. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 22:13:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 21:13:53 +0000 Subject: [Koha-bugs] [Bug 22023] Further improve responsive layout handling of staff client menu bar In-Reply-To: <bug-22023-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22023-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22023-70-eQytVfTvx9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22023 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 22:13:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 21:13:56 +0000 Subject: [Koha-bugs] [Bug 22023] Further improve responsive layout handling of staff client menu bar In-Reply-To: <bug-22023-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22023-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22023-70-L8v58EYQjk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22023 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86172|0 |1 is obsolete| | --- Comment #6 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Created attachment 86217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86217&action=edit Bug 22023: Further improve responsive layout handling of staff client menu bar This patch makes a number of changes in order to improve the way the staff client's header menu adjusts at narrower browser widths: - Updated version of Bootstrap 3.3.7 which includes the "collapse" JavaScript plugin. - Modified default Bootstrap CSS using Bootstrap's customization tool. These changes facilitate the removal of some custom CSS (overriding Bootstrap) from staff-global.scss. - Added Bootstrap config file for loading customizations at https://getbootstrap.com/docs/3.3/customize/ - Revised button classes for buttons in Bootstrap-styled toolbars. The modified default CSS resets the base font size in Bootstrap to better match our global CSS. A side-effect of this is that toolbar buttons ended up looking smaller than they should. Changing the button class solves this. - Restructure the header menu in order to allow different rules to govern the appearance of the navigational part of the menu (Circulation, Search, etc) and the user menu (Set library, My account, Log out). - Modify the cart JS to so that the popup works well at narrow widths. To test, apply the patch, regenerate the staff client CSS, and clear your browser cache. - Log in to the staff client and observe the layout of the header menu as you adjust the browser to various widths. - Confirm that sections of the menu "collapse" as the window gets narrower. - Confirm that dropdown menus behave correctly and that links work. - Confirm that the Cart link works as expected when the cart empty and when it has items. - Install and enable multiple translations, including at least one set of sub-languages (e.g. fr-FR and fr-CA). - Test the appearance of the language menus in the footer at various browser widths. - View pages with button toolbars and confirm that they appear unchanged (e.g. biblio detail page, patron detail page). NOTE: While this patch is intended to make improvements to staff client responsiveness, it does so within a limited scope. There are still many pages which do not work well at narrower browser widths. Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 22:24:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 21:24:37 +0000 Subject: [Koha-bugs] [Bug 21049] Rancor 007 field does not retain value In-Reply-To: <bug-21049-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21049-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21049-70-INLT6mCyjq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21049 Michal Denar <black23 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 22:24:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 21:24:40 +0000 Subject: [Koha-bugs] [Bug 21049] Rancor 007 field does not retain value In-Reply-To: <bug-21049-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21049-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21049-70-8xSr6uXJe5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21049 Michal Denar <black23 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86131|0 |1 is obsolete| | --- Comment #2 from Michal Denar <black23 at gmail.com> --- Created attachment 86218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86218&action=edit Bug 21049: Fix value of material select for Rancor 007 widget The material type is selected in accordance with position 0 of 007 Test plan: 1. Create a new record using the advanced editor 2. Select a material type for field 007 and set at least the position 0 of this field 3. Save the record and reload the page 4. The material type should remain selected 5. Try with all available material types Signed-off-by: Michal Denar <black23 at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 22:25:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 21:25:05 +0000 Subject: [Koha-bugs] [Bug 22434] correct item callnumber search link In-Reply-To: <bug-22434-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22434-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22434-70-qgXT6I7nYK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22434 --- Comment #8 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- (In reply to Jonathan Druart from comment #7) > (In reply to Hayley Mapley from comment #2) > > Hi, > > > > I've tested up until Step 7, all looks fine. Would you mind explaining what > > you mean in Step 7 when you say 'group search'? > > > > Cheers, > > Hayley > > Hayley, you need to create a library group (Home ? Administration ? Library > groups) with the "Use for staff search groups" feature, then on the advanced > search form you will see it at the bottom of the page ("Groups of > libraries"). Thanks for letting me know Jonathan! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 22:44:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 21:44:46 +0000 Subject: [Koha-bugs] [Bug 22147] Hide 'Batch modify' button when printing reports In-Reply-To: <bug-22147-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22147-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22147-70-xZlMIaubDO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22147 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> --- backported to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 23:12:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 22:12:27 +0000 Subject: [Koha-bugs] [Bug 7133] received items could stand out more In-Reply-To: <bug-7133-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7133-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7133-70-jpUEeX4YdL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7133 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Owen, could you maybe take a look here? I was going to add a class to the template, but I am a bit stuck on a nice standard design for (rcvd). -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 23:12:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 22:12:44 +0000 Subject: [Koha-bugs] [Bug 7133] received items could stand out more In-Reply-To: <bug-7133-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7133-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7133-70-d7jGFgruaf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7133 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 23:13:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 22:13:07 +0000 Subject: [Koha-bugs] [Bug 7133] Received items should stand out more In-Reply-To: <bug-7133-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7133-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7133-70-a4im2Lk9lC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7133 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|received items could stand |Received items should stand |out more |out more -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 23:48:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 22:48:03 +0000 Subject: [Koha-bugs] [Bug 18143] Silence floody MARC framework export In-Reply-To: <bug-18143-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18143-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18143-70-p315iLEsWm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18143 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #9 from Lucas Gass <lucas at bywatersolutions.com> --- backported to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 6 23:49:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 22:49:22 +0000 Subject: [Koha-bugs] [Bug 22388] svc/split_callnumbers should have execute flag set In-Reply-To: <bug-22388-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22388-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22388-70-FO5jco9B5G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22388 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> --- 18.05.x is missing 15837 dependency, wont backport. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 00:24:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 23:24:07 +0000 Subject: [Koha-bugs] [Bug 22389] Classification splitting sources regex - cannot consistentlyadd/delete In-Reply-To: <bug-22389-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22389-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22389-70-LpbYmZO18X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22389 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> --- 18.05.x is missing the 15836 dependency, won't backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 00:39:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 23:39:17 +0000 Subject: [Koha-bugs] [Bug 22386] Importing using attributes as matchpoint broken In-Reply-To: <bug-22386-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22386-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22386-70-5ko5yyVkpA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22386 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #11 from Lucas Gass <lucas at bywatersolutions.com> --- backported to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 00:43:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Mar 2019 23:43:45 +0000 Subject: [Koha-bugs] [Bug 21622] Incorrect GROUP BY clause in acqui/ scripts In-Reply-To: <bug-21622-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21622-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21622-70-CRkapJAmRl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21622 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #16 from Lucas Gass <lucas at bywatersolutions.com> --- this one fails qa tool in 18.05.x AND i cannot successfully run through the test plan. not backporting to 18.05.x. let me know if it is needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 01:49:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 00:49:13 +0000 Subject: [Koha-bugs] [Bug 21003] Don't show warning when editing a reserve item In-Reply-To: <bug-21003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21003-70-9jsgqqTvJL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21003 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|kyle at bywatersolutions.com |hayleymapley at catalyst.net.n | |z CC| |hayleymapley at catalyst.net.n | |z Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 04:08:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 03:08:52 +0000 Subject: [Koha-bugs] [Bug 21003] Don't show warning when editing a reserve item In-Reply-To: <bug-21003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21003-70-vDD1ZG7lPc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21003 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 04:08:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 03:08:55 +0000 Subject: [Koha-bugs] [Bug 21003] Don't show warning when editing a reserve item In-Reply-To: <bug-21003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21003-70-jfAxgEslAa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21003 --- Comment #1 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Created attachment 86219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86219&action=edit Bug 21003: Removed warning and changed wording on add_items-step2.tt When editing an item in a Course Reserve, the page displayed is the same that is displayed when adding an item to a Course Reserve. This patch removes the warning 'This course already has this item on reserve' when the item is being edited, as well as changes the title, breadcrumbs, and header of the div. This patch also Changes the header of the div to say 'Edit 'book_name' in 'course_name'' instead of 'Add 'book_name' to 'course_name'' when adding items to a course reserve if the item is already present. To test: 1) Create a new course in Course Reserves (you will need Course Reserves enabled in syspref) 2) Add an item by clicking the Add reserves button 3) Click the edit button on the right hand side of the item listing under the Reserves heading 4) Observe that the warning 'The course already has this item on reserve' appears, and that the title, breadcrumbs and header of the div all say Add/Reserve 5) Apply the patch 6) Repeat step 3 and observe that the title, breadcrumbs and header of the div now say Edit 7) Also verify that when adding a reserve with a barcode that does not yet exist in the course reserves that the warning 'The course already...' is not displayed and that the header of the div says Add 8) Finally verify that when adding a reserve with a barcode that DOES exist in the course reserves that the warning 'The course already...' IS displayed and the header of the div says Edit 9) Sign off! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 05:46:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 04:46:50 +0000 Subject: [Koha-bugs] [Bug 18401] Add the Koha::Checkout->patron method In-Reply-To: <bug-18401-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18401-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18401-70-tETevu6B4b@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18401 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #7 from David Cook <dcook at prosentient.com.au> --- Found a bug with this when the checkout has a null borrowernumber. Will spin out a new report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 05:50:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 04:50:29 +0000 Subject: [Koha-bugs] [Bug 21432] Internal Server Error in Checkout History In-Reply-To: <bug-21432-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21432-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21432-70-4YVsFRp55M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21432 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 05:50:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 04:50:06 +0000 Subject: [Koha-bugs] [Bug 18401] Add the Koha::Checkout->patron method In-Reply-To: <bug-18401-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18401-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18401-70-eX1elVtLTC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18401 --- Comment #8 from David Cook <dcook at prosentient.com.au> --- (In reply to David Cook from comment #7) > Found a bug with this when the checkout has a null borrowernumber. Will spin > out a new report. Nevermind. It's fixed by #21432. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 08:26:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 07:26:16 +0000 Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha namespace In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20443-70-ScsgoOocvN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443 --- Comment #10 from Josef Moravec <josef.moravec at gmail.com> --- I just rebased this on top of current code in bug 12159, see https://gitlab.com/josef.moravec/Koha/tree/bug_20443 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 08:27:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 07:27:33 +0000 Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha namespace In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20443-70-M0WK6Elnl4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443 --- Comment #11 from Josef Moravec <josef.moravec at gmail.com> --- Tests not passing (at least): t/db_dependent/Koha/Patrons/Import.t t/db_dependent/Auth_with_ldap.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 08:32:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 07:32:20 +0000 Subject: [Koha-bugs] [Bug 22452] 'Caracters' is typo In-Reply-To: <bug-22452-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22452-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22452-70-tJbzUMY13V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22452 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 08:32:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 07:32:23 +0000 Subject: [Koha-bugs] [Bug 22452] 'Caracters' is typo In-Reply-To: <bug-22452-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22452-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22452-70-5V8URim2JY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22452 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86029|0 |1 is obsolete| | --- Comment #3 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86220&action=edit Bug 22452: Fix typos in add mana comment modals There are typos in modal where you can add a comment to mana: 'caracters' should be 'characters' 'commment' should be 'comment' Test plan: 1) Create subscription from Mana 2) On subscription detail page: report mistake > other a modal is shown --> without patch it reads 'Please enter a new commment (max 35 caracters)' --> with patch it reads 'Please enter a new comment (max 35 characters)' 3) The same in mana search resultss and in reports -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 08:32:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 07:32:59 +0000 Subject: [Koha-bugs] [Bug 22452] Typos in add a comment to Mana modal In-Reply-To: <bug-22452-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22452-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22452-70-uBJ4hR47uT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22452 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|'Caracters' is typo |Typos in add a comment to | |Mana modal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 08:59:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 07:59:00 +0000 Subject: [Koha-bugs] [Bug 21683] Remove accountlines.accountno In-Reply-To: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21683-70-5N4sL0kEwH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85535|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86221&action=edit Bug 21683: Database update Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 08:59:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 07:59:04 +0000 Subject: [Koha-bugs] [Bug 21683] Remove accountlines.accountno In-Reply-To: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21683-70-RT750TKIo5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85536|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86222&action=edit Bug 21683: Remove accountlines.accountno Test plan: 1) Play with fines, should work OK 2) Try to print receipts on fines - prinfeercpt.pl, printinvoice.pl 3) git grep getnextacctno -> no occurences 4) git grep accountno should return only: installer/data/mysql/atomicupdate/bug_21683_remove_column_accountno.perl installer/data/mysql/update22to30.pl misc/release_notes/release_notes_3_10_0.txt misc/release_notes/release_notes_3_22_0.txt 5) prove t/db_dependent/Accounts.t t/db_dependent/ILSDI_Services.t t/db_dependent/Stats.t t/db_dependent/Koha/Account.t Rescued-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 08:59:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 07:59:07 +0000 Subject: [Koha-bugs] [Bug 21683] Remove accountlines.accountno In-Reply-To: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21683-70-0AkvWasGeQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85537|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86223&action=edit Bug 21683: (follow-up) Polish the change - based on feedback Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 08:59:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 07:59:10 +0000 Subject: [Koha-bugs] [Bug 21683] Remove accountlines.accountno In-Reply-To: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21683-70-7NlwhkgnJ4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85538|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86224&action=edit Bug 21683: (QA follow-up) Koha::Account::Line rebase fix Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 09:09:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 08:09:11 +0000 Subject: [Koha-bugs] [Bug 21683] Remove accountlines.accountno In-Reply-To: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21683-70-s8V7wmIIbX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 --- Comment #28 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- I've now uploaded a correctly rebased patchset so the tests should all now be passing. Having discussed this with Josef in IRC we are both in agreement that statistucs.proccode should be removed as is. I've looked through the SQL Reports library on the wiki and can't find a single mention of it's use and neither of us could work out a consistent and correct way to report against it which remained accurate. We also couldn't work out any form of migration path from accountno to accountline_id. So.. I believe this patchset is now sound, although I would like one minor followup which actually removed the field from the statistics table too. I believe if we do decide we want a link to accountlines in this table we should treat that as a separate issue. I'll add the followup to remove the field from the database. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 09:14:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 08:14:07 +0000 Subject: [Koha-bugs] [Bug 21683] Remove accountlines.accountno In-Reply-To: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21683-70-7pzxfIwKVw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86221|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86225&action=edit Bug 21683: Database update Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 09:14:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 08:14:10 +0000 Subject: [Koha-bugs] [Bug 21683] Remove accountlines.accountno In-Reply-To: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21683-70-kPqyNTqOAo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86222|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86226&action=edit Bug 21683: Remove accountlines.accountno Test plan: 1) Play with fines, should work OK 2) Try to print receipts on fines - prinfeercpt.pl, printinvoice.pl 3) git grep getnextacctno -> no occurences 4) git grep accountno should return only: installer/data/mysql/atomicupdate/bug_21683_remove_column_accountno.perl installer/data/mysql/update22to30.pl misc/release_notes/release_notes_3_10_0.txt misc/release_notes/release_notes_3_22_0.txt 5) prove t/db_dependent/Accounts.t t/db_dependent/ILSDI_Services.t t/db_dependent/Stats.t t/db_dependent/Koha/Account.t Rescued-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 09:14:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 08:14:14 +0000 Subject: [Koha-bugs] [Bug 21683] Remove accountlines.accountno In-Reply-To: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21683-70-zI9o6sceBg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86223|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86227&action=edit Bug 21683: (follow-up) Polish the change - based on feedback Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 09:14:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 08:14:17 +0000 Subject: [Koha-bugs] [Bug 21683] Remove accountlines.accountno In-Reply-To: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21683-70-IEAbnjxsOU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86224|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86228&action=edit Bug 21683: (QA follow-up) Koha::Account::Line rebase fix Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 09:14:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 08:14:21 +0000 Subject: [Koha-bugs] [Bug 21683] Remove accountlines.accountno In-Reply-To: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21683-70-ETKAHJjJ3i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 --- Comment #33 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86229&action=edit Bug 21683: (QA follow-up) Drop statistics.proccode Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 09:14:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 08:14:53 +0000 Subject: [Koha-bugs] [Bug 21683] Remove accountlines.accountno In-Reply-To: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21683-70-kw5LgCc2Gv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 09:16:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 08:16:19 +0000 Subject: [Koha-bugs] [Bug 21683] Remove accountlines.accountno In-Reply-To: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21683-70-AMzpoVdrup@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86225|0 |1 is obsolete| | --- Comment #34 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86230&action=edit Bug 21683: Database update Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 09:16:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 08:16:23 +0000 Subject: [Koha-bugs] [Bug 21683] Remove accountlines.accountno In-Reply-To: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21683-70-eOMFQkE6tI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86226|0 |1 is obsolete| | --- Comment #35 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86231&action=edit Bug 21683: Remove accountlines.accountno Test plan: 1) Play with fines, should work OK 2) Try to print receipts on fines - prinfeercpt.pl, printinvoice.pl 3) git grep getnextacctno -> no occurences 4) git grep accountno should return only: installer/data/mysql/atomicupdate/bug_21683_remove_column_accountno.perl installer/data/mysql/update22to30.pl misc/release_notes/release_notes_3_10_0.txt misc/release_notes/release_notes_3_22_0.txt 5) prove t/db_dependent/Accounts.t t/db_dependent/ILSDI_Services.t t/db_dependent/Stats.t t/db_dependent/Koha/Account.t Rescued-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 09:16:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 08:16:26 +0000 Subject: [Koha-bugs] [Bug 21683] Remove accountlines.accountno In-Reply-To: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21683-70-6e9njoNJaC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86227|0 |1 is obsolete| | --- Comment #36 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86232&action=edit Bug 21683: (follow-up) Polish the change - based on feedback Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 09:16:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 08:16:30 +0000 Subject: [Koha-bugs] [Bug 21683] Remove accountlines.accountno In-Reply-To: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21683-70-Wve244TE9u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86228|0 |1 is obsolete| | --- Comment #37 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86233&action=edit Bug 21683: (QA follow-up) Koha::Account::Line rebase fix Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 09:16:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 08:16:33 +0000 Subject: [Koha-bugs] [Bug 21683] Remove accountlines.accountno In-Reply-To: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21683-70-oGq27WgRtu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86229|0 |1 is obsolete| | --- Comment #38 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86234&action=edit Bug 21683: (QA follow-up) Drop statistics.proccode Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 09:18:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 08:18:14 +0000 Subject: [Koha-bugs] [Bug 22323] Cronjob runreport.pl has a CSV encoding issue In-Reply-To: <bug-22323-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22323-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22323-70-UOWqckLUhq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22323 --- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.11.x for 17.11.17 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 09:17:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 08:17:50 +0000 Subject: [Koha-bugs] [Bug 21683] Remove accountlines.accountno In-Reply-To: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21683-70-8qV0nCicnq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 --- Comment #39 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- (In reply to Martin Renvoize from comment #28) > I've now uploaded a correctly rebased patchset so the tests should all now > be passing. > > Having discussed this with Josef in IRC we are both in agreement that > statistucs.proccode should be removed as is. I've looked through the SQL > Reports library on the wiki and can't find a single mention of it's use and > neither of us could work out a consistent and correct way to report against > it which remained accurate. We also couldn't work out any form of migration > path from accountno to accountline_id. > > So.. I believe this patchset is now sound, although I would like one minor > followup which actually removed the field from the statistics table too. > > I believe if we do decide we want a link to accountlines in this table we > should treat that as a separate issue. > > I'll add the followup to remove the field from the database. Back to you Tomas :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 09:33:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 08:33:10 +0000 Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request datatable to be customisable In-Reply-To: <bug-21063-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21063-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21063-70-b2J1lD7kEW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 --- Comment #66 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86235&action=edit Bug 21063: (QA follow-up) Fix test api/v1/illrequest.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 09:46:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 08:46:32 +0000 Subject: [Koha-bugs] [Bug 17229] ILS-DI HoldTitle and HoldItem should check if patron is expired In-Reply-To: <bug-17229-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17229-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17229-70-UU3Jfl9e9g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 --- Comment #32 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- You need to reconsider the unit test patch. Move to t/db_dependent/ILSDI_Services.t maybe. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 09:50:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 08:50:26 +0000 Subject: [Koha-bugs] [Bug 18837] Add an unmediated Interlibrary Loans workflow In-Reply-To: <bug-18837-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18837-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18837-70-Dlgd1AN45W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 --- Comment #21 from Josef Moravec <josef.moravec at gmail.com> --- When the library has missing some data it is shown like this: https://screenshots.firefox.com/R4iMqp2SVyEkh8Qz/localhost But when is missing country, it dies in BLDSS/Base.pm, (but request is still created with status "New") not sure if we could do something with this in Koha... Also, you have ILLOpacbackends in sysprefs and yaml, but not in db update and also not used in code, so probably should be removed When I have all address data OK, I got this message: "Invalid Request: At least one Item Of Interest level piece of metadata is required." Is it possible to show which metadata is missing? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 09:52:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 08:52:16 +0000 Subject: [Koha-bugs] [Bug 18837] Add an unmediated Interlibrary Loans workflow In-Reply-To: <bug-18837-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18837-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18837-70-AFQbYIuY0M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 09:52:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 08:52:18 +0000 Subject: [Koha-bugs] [Bug 22434] correct item callnumber search link In-Reply-To: <bug-22434-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22434-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22434-70-ws3D42ourW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22434 --- Comment #9 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- (In reply to Jonathan Druart from comment #6) > Could you explain the issue you are trying to fix? > > Without the patch: > I have an item with its callnumber set to AAA&1(2)3 > I launch a search and see a link > /catalogue/search.pl?idx=callnum&q=%22AAA%261(2)3%22 > I click on it and I am redirected to the bibliographic detail page. Using idx=callnum will use all search options like the auto-trunction for example, that is useless in this case. Many places like the facets prefer <index>:<query>. This is also good for ES. And some places where missing the double quotes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 09:57:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 08:57:30 +0000 Subject: [Koha-bugs] [Bug 22430] importing from a UNIMARC backup will import biblio records but not items In-Reply-To: <bug-22430-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22430-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22430-70-X4z8IDorvG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22430 --- Comment #5 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- (In reply to Fridolin SOMERS from comment #2) > (In reply to Giuseppe Ciaccio from comment #0) > > So it seems that the UNIMARC item field is correctly fetched when importing > > the backup in the stage area, but discarded when the staged records are > > pushed in the catalog. > > I think I found why. > The push to catalog is not allowed because the items have the same barcode > which must be unique in catalog. Ok it is not that. Does instances A and B have the same branches ? for items homebranch and holdingbranch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 09:58:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 08:58:08 +0000 Subject: [Koha-bugs] [Bug 21832] Restore is_expired in ILS-DI GetPatronInfo service In-Reply-To: <bug-21832-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21832-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21832-70-D9l0d41C7F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21832 --- Comment #18 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- (In reply to Jonathan Druart from comment #17) > (In reply to Fridolin SOMERS from comment #16) > > But several portal use it already with this tag. > > If it does no harm why not keeping it ? > > Maybe adding it to the doc? :) Very good idea, I'm on it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 10:09:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 09:09:52 +0000 Subject: [Koha-bugs] [Bug 18837] Add an unmediated Interlibrary Loans workflow In-Reply-To: <bug-18837-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18837-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18837-70-KLwekFEC51@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86188|0 |1 is obsolete| | --- Comment #22 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 86236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86236&action=edit Bug 18837: Add ILL Unmediated syspref stuff This patch adds the syspref requirements for unmediated ILL requests. It is a recreation of https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66628&action=diff which had diverged sufficiently as to make it impossible to apply. * installer/data/mysql/atomicupdate/illunmediated_tables.sql: New file. * installer/data/mysql/sysprefs.sql: Add `ILLModuleUnmediated`. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref: Add `ILLModuleUnmediated` handling. Signed-off-by: Stephen Graham <s.graham4 at herts.ac.uk> Signed-off-by: David Peacock <d.m.peacock at herts.ac.uk> Signed-off-by: Jayne Maisey <j.maisey at herts.ac.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 10:09:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 09:09:56 +0000 Subject: [Koha-bugs] [Bug 18837] Add an unmediated Interlibrary Loans workflow In-Reply-To: <bug-18837-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18837-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18837-70-89ySG89bQ9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86189|0 |1 is obsolete| | --- Comment #23 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 86237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86237&action=edit Bug 18837: Introduce delegation to backends for unmediated workflows This patch adds support to Illrequest.pm to allow delegation of unmediated requests to happen in backends that support them. It is a recreation of https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66629&action=diff which had diverged sufficiently as to make it impossible to apply Signed-off-by: Stephen Graham <s.graham4 at herts.ac.uk> Signed-off-by: David Peacock <d.m.peacock at herts.ac.uk> Signed-off-by: Jayne Maisey <j.maisey at herts.ac.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 10:09:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 09:09:57 +0000 Subject: [Koha-bugs] [Bug 22470] New: Missing the table name on misc/migration_tools/switch_marc21_series_info.pl Message-ID: <bug-22470-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22470 Bug ID: 22470 Summary: Missing the table name on misc/migration_tools/switch_marc21_series_info.pl Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: gveranis at gmail.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Target Milestone: --- UPDATE marc_subfield_structure SET kohafield='seriestitle' - it's missing the table name it should be $dbh->do( "UPDATE marc_subfield_structure SET kohafield='biblio.seriestitle' WHERE tagfield='490' AND tagsubfield='a'" ); $dbh->do( "UPDATE marc_subfield_structure SET kohafield='biblio.volume' WHERE tagfield='490' AND tagsubfield='v'" ); # empty old koha fields $dbh->do( "UPDATE marc_subfield_structure SET kohafield='' WHERE kohafield='biblio.seriestitle' AND tagfield='440' AND tagsubfield='a'" ); $dbh->do( "UPDATE marc_subfield_structure SET kohafield='' WHERE kohafield='biblio.volume' AND tagfield='440' AND tagsubfield='v'" ); lines 232-249 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 10:10:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 09:10:30 +0000 Subject: [Koha-bugs] [Bug 22470] Missing the table name on misc/migration_tools/switch_marc21_series_info.pl In-Reply-To: <bug-22470-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22470-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22470-70-qEMD8jHdgT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22470 George Veranis <gveranis at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 10:11:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 09:11:32 +0000 Subject: [Koha-bugs] [Bug 20639] Allow setting a default/single backend for OPAC driven requests In-Reply-To: <bug-20639-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20639-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20639-70-vfLh3E6AT6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- CC| |josef.moravec at gmail.com Status|RESOLVED |REOPENED --- Comment #22 from Josef Moravec <josef.moravec at gmail.com> --- This should be in master, but it looks like it is not pushed! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 10:11:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 09:11:33 +0000 Subject: [Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events In-Reply-To: <bug-20750-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20750-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20750-70-4bYp5ltFhl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750 Bug 20750 depends on bug 20639, which changed state. Bug 20639 Summary: Allow setting a default/single backend for OPAC driven requests https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 10:12:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 09:12:39 +0000 Subject: [Koha-bugs] [Bug 18837] Add an unmediated Interlibrary Loans workflow In-Reply-To: <bug-18837-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18837-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18837-70-na4ivQxcP4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #24 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- (In reply to Josef Moravec from comment #21) > When the library has missing some data it is shown like this: > https://screenshots.firefox.com/R4iMqp2SVyEkh8Qz/localhost > > But when is missing country, it dies in BLDSS/Base.pm, (but request is still > created with status "New") not sure if we could do something with this in > Koha... Yes, I'll create a bug report on the BLDSS Github site so we can get it fixed. > Also, you have ILLOpacbackends in sysprefs and yaml, but not in db update > and also not used in code, so probably should be removed Updated patches attached > When I have all address data OK, I got this message: "Invalid Request: At > least one Item Of Interest level piece of metadata is required." > Is it possible to show which metadata is missing? Sadly not, that error is coming back from the BLDSS service, it's not very helpful, I agree! :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 10:20:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 09:20:02 +0000 Subject: [Koha-bugs] [Bug 22470] Missing the table name on misc/migration_tools/switch_marc21_series_info.pl In-Reply-To: <bug-22470-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22470-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22470-70-rIHSa3KHmM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22470 --- Comment #1 from George Veranis <gveranis at gmail.com> --- $dbh->do( "UPDATE marc_subfield_structure SET kohafield='biblio.seriestitle' WHERE tagfield='490' AND tagsubfield='a'" ); $dbh->do( "UPDATE marc_subfield_structure SET kohafield='biblioitems.volume' WHERE tagfield='490' AND tagsubfield='v'" ); # empty old koha fields $dbh->do( "UPDATE marc_subfield_structure SET kohafield='' WHERE kohafield='biblio.seriestitle' AND tagfield='440' AND tagsubfield='a'" ); $dbh->do( "UPDATE marc_subfield_structure SET kohafield='' WHERE kohafield='biblioitems.volume' AND tagfield='440' AND tagsubfield='v'" ); lines 232-249 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 10:21:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 09:21:29 +0000 Subject: [Koha-bugs] [Bug 18837] Add an unmediated Interlibrary Loans workflow In-Reply-To: <bug-18837-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18837-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18837-70-nSohlS5aYH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |josef.moravec at gmail.com --- Comment #25 from Josef Moravec <josef.moravec at gmail.com> --- (In reply to Andrew Isherwood from comment #24) > (In reply to Josef Moravec from comment #21) > > When the library has missing some data it is shown like this: > > https://screenshots.firefox.com/R4iMqp2SVyEkh8Qz/localhost > > > > But when is missing country, it dies in BLDSS/Base.pm, (but request is still > > created with status "New") not sure if we could do something with this in > > Koha... > > Yes, I'll create a bug report on the BLDSS Github site so we can get it > fixed. > > > Also, you have ILLOpacbackends in sysprefs and yaml, but not in db update > > and also not used in code, so probably should be removed > > Updated patches attached > > > When I have all address data OK, I got this message: "Invalid Request: At > > least one Item Of Interest level piece of metadata is required." > > Is it possible to show which metadata is missing? > > Sadly not, that error is coming back from the BLDSS service, it's not very > helpful, I agree! :( Thanks for answers and quick rebase! I am continuing here... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 11:10:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 10:10:46 +0000 Subject: [Koha-bugs] [Bug 22470] Missing the table name on misc/migration_tools/switch_marc21_series_info.pl In-Reply-To: <bug-22470-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22470-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22470-70-YogZBOW8Vt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22470 --- Comment #2 from George Veranis <gveranis at gmail.com> --- also add $dbh->do( "UPDATE marc_subfield_structure SET kohafield='' WHERE kohafield='biblioitems.number' AND tagfield='440' AND tagsubfield='n'" ); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 12:27:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 11:27:12 +0000 Subject: [Koha-bugs] [Bug 18837] Add an unmediated Interlibrary Loans workflow In-Reply-To: <bug-18837-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18837-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18837-70-DCalMcSqc9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 --- Comment #26 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86238&action=edit Bug 18837: (QA follow-up) Update system preference desciprition -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 12:41:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 11:41:58 +0000 Subject: [Koha-bugs] [Bug 17015] New Koha Calendar In-Reply-To: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17015-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17015-70-qBBCsJl0NS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17015 Janet McGowan <janet.mcgowan at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 12:42:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 11:42:32 +0000 Subject: [Koha-bugs] [Bug 21829] Date displays as a datetime in notices In-Reply-To: <bug-21829-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21829-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21829-70-jKFLVX7Dfr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21829 Janet McGowan <janet.mcgowan at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 12:42:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 11:42:42 +0000 Subject: [Koha-bugs] [Bug 16251] Material type is not correctly set for Rancor 008 widget In-Reply-To: <bug-16251-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16251-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16251-70-RUjNK0eMZP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16251 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 12:42:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 11:42:45 +0000 Subject: [Koha-bugs] [Bug 16251] Material type is not correctly set for Rancor 008 widget In-Reply-To: <bug-16251-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16251-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16251-70-pIRN3evetI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16251 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86213|0 |1 is obsolete| | --- Comment #4 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86239&action=edit Bug 16251: Fix value of material select for Rancor 008 widget The material type is selected in accordance with the leader (06-07) Test plan: 1. Create a new record using the advanced editor 2. Set the leader 6th position to 'c' 3. Save the record and reload the page 4. 'Music' should be automatically selected for 008 5. Try other values for the leader 6th and 7th positions See comment 0 of this bug for the complete mapping Signed-off-by: Michal Denar <black23 at gmail.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 12:42:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 11:42:56 +0000 Subject: [Koha-bugs] [Bug 16251] Material type is not correctly set for Rancor 008 widget In-Reply-To: <bug-16251-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16251-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16251-70-Lrofy2WywE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16251 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 12:52:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 11:52:19 +0000 Subject: [Koha-bugs] [Bug 22429] Infinite loop in patron card printing In-Reply-To: <bug-22429-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22429-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22429-70-hMHMmaaBJ7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22429 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |victor.grousset at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 13:11:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 12:11:10 +0000 Subject: [Koha-bugs] [Bug 22471] New: Default Finnish values for web installer Message-ID: <bug-22471-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22471 Bug ID: 22471 Summary: Default Finnish values for web installer Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: lari.taskula at hypernova.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Target Milestone: --- Add default Finnish values for web installer. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 13:13:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 12:13:44 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18936-70-XUxYkhu6IM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22472 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 13:13:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 12:13:44 +0000 Subject: [Koha-bugs] [Bug 22472] New: Should column_exists explode if the table does not exist? Message-ID: <bug-22472-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22472 Bug ID: 22472 Summary: Should column_exists explode if the table does not exist? Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Target Milestone: --- See bug 18936 comment 33. If C4::Installer::column_exists is called with a table that has been removed, the methods will print an error. I think it should early return if the table does not exist (not an exception, we do not want to make more complex the update DB script) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 13:14:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 12:14:12 +0000 Subject: [Koha-bugs] [Bug 22471] Default Finnish values for web installer In-Reply-To: <bug-22471-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22471-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22471-70-bT67jhsoZP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22471 Lari Taskula <lari.taskula at hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lari.taskula at hypernova.fi |ity.org | Status|NEW |ASSIGNED Patch complexity|--- |Trivial patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 13:23:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 12:23:41 +0000 Subject: [Koha-bugs] [Bug 22473] New: Use koha-conf.xml modification time as cache key Message-ID: <bug-22473-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22473 Bug ID: 22473 Summary: Use koha-conf.xml modification time as cache key Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: robin at kallisti.net.nz QA Contact: testopia at bugs.koha-community.org Target Milestone: --- >From this IRC conversation: <fridolin> rkrimme1: did you flush memcached ? <magnuse> can't hurt :-) <magnuse> and yeah, i think you have to, for changes to koha-conf.xml to be picked up if this is the case, when creating and accessing memcached for koha-conf values, the actual modification time of the koha-conf should be appended to the key values. This means that if the file is updated, the cache is automatically invalid. It requires running stat on each request, but as the koha-conf file isn't actually being opened and parsed, this will be very fast. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 13:24:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 12:24:59 +0000 Subject: [Koha-bugs] [Bug 22473] Use koha-conf.xml modification time as cache key In-Reply-To: <bug-22473-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22473-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22473-70-7QM2LjO2Yn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22473 Robin Sheat <robin at kallisti.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 13:27:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 12:27:28 +0000 Subject: [Koha-bugs] [Bug 22472] Should column_exists explode if the table does not exist? In-Reply-To: <bug-22472-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22472-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22472-70-SzIGormtf1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22472 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 13:27:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 12:27:33 +0000 Subject: [Koha-bugs] [Bug 22472] Should column_exists explode if the table does not exist? In-Reply-To: <bug-22472-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22472-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22472-70-WRJdQ4x3lp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22472 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86240&action=edit Bug 22472: Add tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 13:27:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 12:27:39 +0000 Subject: [Koha-bugs] [Bug 22472] Should column_exists explode if the table does not exist? In-Reply-To: <bug-22472-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22472-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22472-70-20odFR2uW7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22472 --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86241&action=edit Bug 22472: Make column_exists early return if the table does not exist On the way we move TableExists to C4::Installer, where it belongs to. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 13:32:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 12:32:05 +0000 Subject: [Koha-bugs] [Bug 22472] Should column_exists explode if the table does not exist? In-Reply-To: <bug-22472-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22472-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22472-70-aB83stleN7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22472 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 13:37:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 12:37:10 +0000 Subject: [Koha-bugs] [Bug 22474] New: Authority and biblio field mapping improperly shared Message-ID: <bug-22474-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22474 Bug ID: 22474 Summary: Authority and biblio field mapping improperly shared Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: ere.maijala at helsinki.fi Target Milestone: --- Reading field mappings uses the general config as the base for both, which makes them accidentally share the field mappings. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 13:37:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 12:37:22 +0000 Subject: [Koha-bugs] [Bug 22474] Authority and biblio field mapping improperly shared In-Reply-To: <bug-22474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22474-70-VxbxYUvNnQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22474 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Priority|P5 - low |P3 Assignee|koha-bugs at lists.koha-commun |ere.maijala at helsinki.fi |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 14:19:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 13:19:52 +0000 Subject: [Koha-bugs] [Bug 22371] MARC bibliographic framework plugin to generate Cutter-Sanborn In-Reply-To: <bug-22371-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22371-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22371-70-XN8aQEBux4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22371 --- Comment #5 from ?talo <italo.barbosa.brasileiro at gmail.com> --- (In reply to Cori Lynn Arnold from comment #2) > I'm trying to test this functionality. Can you explain this step in more > detail: > > To use the plugin, it is necessary to associate it with the Cutter field in > the framework. > > Thanks! > -cori lynn Hello Cori! To associate the plugin with the cutter field, you must set the 'cutter.pl' plugin in your MARC framework. this can be done through the following steps: 1. Navigate to More > Administration > MARC bibliographic framework; 2. On the framework which you want to use de plugin, click on Action > MARC Structure; 3. On the field to be associated with the plugin, click on Actions > Subfields; 4. Select the tab corresponding to the cutter subfield; 5. On the "Other options (choose one)" panel, select "cutter.pl" in "Plugin" dropdown menu, and save changes. Hope it works! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 14:40:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 13:40:56 +0000 Subject: [Koha-bugs] [Bug 22452] Typos in add a comment to Mana modal In-Reply-To: <bug-22452-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22452-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22452-70-q9AKHqu33v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22452 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 14:40:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 13:40:58 +0000 Subject: [Koha-bugs] [Bug 22452] Typos in add a comment to Mana modal In-Reply-To: <bug-22452-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22452-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22452-70-IY4s3cVCkt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22452 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86220|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 86242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86242&action=edit Bug 22452: Fix typos in add mana comment modals There are typos in modal where you can add a comment to mana: 'caracters' should be 'characters' 'commment' should be 'comment' Test plan: 1) Create subscription from Mana 2) On subscription detail page: report mistake > other a modal is shown --> without patch it reads 'Please enter a new commment (max 35 caracters)' --> with patch it reads 'Please enter a new comment (max 35 characters)' 3) The same in mana search resultss and in reports Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 14:48:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 13:48:14 +0000 Subject: [Koha-bugs] [Bug 21832] Restore is_expired in ILS-DI GetPatronInfo service In-Reply-To: <bug-21832-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21832-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21832-70-NjVneW6ReD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21832 --- Comment #19 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Created attachment 86243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86243&action=edit Bug 21832: add is_expired to ILS-DI example Test plan : 1) Apply patch 2) Enable ILS-DI 3) Go to <opac URL>/cgi-bin/koha/ilsdi.pl?service=Describe&verb=GetPatronInfo 4) Check you see is_expired in example response -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 14:48:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 13:48:31 +0000 Subject: [Koha-bugs] [Bug 21832] Restore is_expired in ILS-DI GetPatronInfo service In-Reply-To: <bug-21832-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21832-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21832-70-btVy6mAMCX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21832 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:00:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 14:00:09 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-mxPzJTxOaW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86141|0 |1 is obsolete| | --- Comment #162 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86245&action=edit Bug 20912: Rental Fees based on Time Period Some libraries would like to be able to charge a rental fee based on the number of days an item will be checked out, as opposed to the flat fee currently offered by Koha. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Edit an itemtype, add a daily rental fee of 1.00 4) Check an item of that itemtype out for 7 days 5) Verify the patron now has rental fee of 7.00 Signed-off-by: Matha Fuerst <mfuerst at hmcpl.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:00:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 14:00:14 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-orjewyVceq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86142|0 |1 is obsolete| | --- Comment #163 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86246&action=edit Bug 20912: Update schema file Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:00:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 14:00:18 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-3HaJUCOlSn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86143|0 |1 is obsolete| | --- Comment #164 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86247&action=edit Bug 20912: (QA follow-up) Fix number of tests and correct typos Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:00:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 14:00:23 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-SPjUGF58oS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86144|0 |1 is obsolete| | --- Comment #165 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86248&action=edit Bug 20912: (QA follow-up) Set daily charge to 0 for item type not being used for test Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:00:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 14:00:04 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-N0kaUXTfW4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86140|0 |1 is obsolete| | --- Comment #161 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86244&action=edit Bug 20912: Update database Signed-off-by: Matha Fuerst <mfuerst at hmcpl.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:00:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 14:00:27 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-4h4y42wzA8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86145|0 |1 is obsolete| | --- Comment #166 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86249&action=edit Bug 20912: (QA follow-up) Make unit tests reliable and get rid of perl warnings Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:00:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 14:00:36 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-8upbOQumO4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86147|0 |1 is obsolete| | --- Comment #168 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86251&action=edit Bug 20912: (QA follow-up): Fix up Koha::Fees Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:00:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 14:00:32 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-LkPI0rK53r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86146|0 |1 is obsolete| | --- Comment #167 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86250&action=edit Bug 20912: Move calculation to Koha::Fees Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:00:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 14:00:41 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-lh9y1vhq4k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86148|0 |1 is obsolete| | --- Comment #169 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86252&action=edit Bug 20912: (QA follow-up): Fix up unit tests Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:00:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 14:00:45 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-4dW3gEsgph@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86149|0 |1 is obsolete| | --- Comment #170 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86253&action=edit Bug 20912: (QA follow-up) Move Fees to Charges:: In preparation for the introduction of Koha::Charges::Fines I have moved this ::Fees class into the Koha::Charges:: namespace Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:00:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 14:00:50 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-JKs5FPRz2o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86151|0 |1 is obsolete| | --- Comment #171 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86254&action=edit Bug 20912: (QA follow-up) Test for distinct accountlines Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:00:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 14:00:54 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-ZHS73qqqpm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86152|0 |1 is obsolete| | --- Comment #172 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86255&action=edit Bug 20912: (QA follow-up) Make DB Update idempotent Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:01:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 14:01:03 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-gOP5wZGq8O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86154|0 |1 is obsolete| | --- Comment #174 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86257&action=edit Bug 20912: (follow-up) Add hourly support It seemed strange to only add support for Daily loans in the feature when Koha also support loan periods in hours. This patch adds parallel functionaliy for hourly loan periods. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:00:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 14:00:59 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-K1mQm6XU0U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86153|0 |1 is obsolete| | --- Comment #173 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86256&action=edit Bug 20912: (follow-up) Improve test coverage Increase test coverage for CanBookBeIssued and fix a introduced during the refactoring to Koha::Fees. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:01:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 14:01:08 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-MIamHxDggm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86155|0 |1 is obsolete| | --- Comment #175 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86258&action=edit Bug 20912: (QA follow-up) Fix TestBuilder Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:01:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 14:01:12 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-EAZCAEtDdU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86156|0 |1 is obsolete| | --- Comment #176 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86259&action=edit Bug 20912: (QA follow-up) Fix some test failures Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:01:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 14:01:16 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-uSvRgRYo64@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86157|0 |1 is obsolete| | --- Comment #177 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86260&action=edit Bug 20912: (QA follow-up) POD fix Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:01:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 14:01:21 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-FPfKtf67g3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86158|0 |1 is obsolete| | --- Comment #178 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86261&action=edit Bug 20912: (QA follow-up) The default rule already has renewalsallowed=0 Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:01:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 14:01:25 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-McBa8Gh95C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86159|0 |1 is obsolete| | --- Comment #179 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86262&action=edit Bug 20912: (follow-up) Prevent double charging on renewal This patch updates the tests the ensure we do not double charge for renewals that take place before the original due date and fixes the corresponding loging in C4::Circulation::AddRenewal. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:01:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 14:01:30 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-kj9Jc62tnF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86160|0 |1 is obsolete| | --- Comment #180 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86263&action=edit Bug 20912: (QA follow-up) Warn patron of daily and hourly renewal fees Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:01:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 14:01:34 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-pysVXeUgcn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #181 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86264&action=edit Bug 20912: (QA follow-up) Rebase error corrections The automatic rebase after bug 21206 required a helping hand. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:02:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 14:02:28 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-UYv3pjmE82@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #182 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Fresh rebase, should all be working again now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:06:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 14:06:55 +0000 Subject: [Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead) In-Reply-To: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21756-70-6EMQgcXRIU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85654|0 |1 is obsolete| | --- Comment #89 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86265&action=edit Bug 21756: Remove use of manualinvoice from Koha::Patron Known Side Effect: Prior to this patch enrolment fees were not recorded in the FinesLog. After this patch, if the FinesLog is enabled then the 'action' will be recorded as `create_account`. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:06:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 14:06:58 +0000 Subject: [Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead) In-Reply-To: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21756-70-PSCZJUWH9E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85655|0 |1 is obsolete| | --- Comment #90 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86266&action=edit Bug 21756: Remove use of manualinvoice from Koha::Hold Known Side Effect: Prior to this patch hold cancellation fees were not recorded in the FinesLog. After this patch, if the FinesLog is enabled then the 'action' will be recorded as `create_hold_expiration`. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:07:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 14:07:02 +0000 Subject: [Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead) In-Reply-To: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21756-70-YlhrO8Gga2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85656|0 |1 is obsolete| | --- Comment #91 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86267&action=edit Bug 21756: Replace manualinvoice with add_debit in tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:07:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 14:07:06 +0000 Subject: [Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead) In-Reply-To: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21756-70-mJ0Itlk9OJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85657|0 |1 is obsolete| | --- Comment #92 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86268&action=edit Bug 21756: Add deprecation warning to manualinvoice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:07:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 14:07:09 +0000 Subject: [Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead) In-Reply-To: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21756-70-QFQOhnOjpH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85658|0 |1 is obsolete| | --- Comment #93 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86269&action=edit Bug 21756: (QA follow-up) Fix for 'Spurious text after =cut' Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:07:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 14:07:13 +0000 Subject: [Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead) In-Reply-To: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21756-70-onxKPqC1G2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85659|0 |1 is obsolete| | --- Comment #94 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86270&action=edit Bug 21756: (QA follow-up) Correct the test for 'Lost Item' offsets Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:07:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 14:07:17 +0000 Subject: [Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead) In-Reply-To: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21756-70-TaxxU5tigZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85660|0 |1 is obsolete| | --- Comment #95 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86271&action=edit Bug 21756: (QA follow-up) Fix Circulation.t Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:07:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 14:07:20 +0000 Subject: [Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead) In-Reply-To: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21756-70-oIPAoXjPt2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85661|0 |1 is obsolete| | --- Comment #96 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86272&action=edit Bug 21756: (follow-up) Add test for deprecation warning Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:07:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 14:07:24 +0000 Subject: [Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead) In-Reply-To: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21756-70-xr8sklDXdj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85662|0 |1 is obsolete| | --- Comment #97 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86273&action=edit Bug 21756: (follow-up) Replace newly introduced manualinvoice call Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:07:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 14:07:28 +0000 Subject: [Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead) In-Reply-To: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21756-70-L71vmEBucd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85663|0 |1 is obsolete| | --- Comment #98 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86274&action=edit Bug 21756: (QA follow-up) Add `Account Fee` mapping Required for add_enrolement_fee_if_needed within Koha::Patron Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:07:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 14:07:31 +0000 Subject: [Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead) In-Reply-To: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21756-70-gKT30PrI8o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85664|0 |1 is obsolete| | --- Comment #99 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86275&action=edit Bug 21756: (QA follow-up) Add offset_types to database Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:07:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 14:07:35 +0000 Subject: [Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead) In-Reply-To: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21756-70-iB43vLRw4A@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #100 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86276&action=edit Bug 21756: (QA follow-up) Add offest types to installer file Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:08:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 14:08:54 +0000 Subject: [Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead) In-Reply-To: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21756-70-U42CqFdz5J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #101 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Freshly rebased -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:08:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 14:08:41 +0000 Subject: [Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead) In-Reply-To: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21756-70-D4vpKNsTQM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85665|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:11:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 14:11:22 +0000 Subject: [Koha-bugs] [Bug 22371] MARC bibliographic framework plugin to generate Cutter-Sanborn In-Reply-To: <bug-22371-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22371-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22371-70-ssz7kG3Fcr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22371 --- Comment #6 from ?talo <italo.barbosa.brasileiro at gmail.com> --- Created attachment 86277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86277&action=edit Plugin with comments in english -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:13:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 14:13:42 +0000 Subject: [Koha-bugs] [Bug 22371] MARC bibliographic framework plugin to generate Cutter-Sanborn In-Reply-To: <bug-22371-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22371-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22371-70-zz5yknOCMN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22371 --- Comment #7 from ?talo <italo.barbosa.brasileiro at gmail.com> --- (In reply to paxed from comment #3) > Any chance of converting the comments in the plugin to english? Paxed, I inserted a new attachment named 'Plugin with comments in english'. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:34:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 14:34:24 +0000 Subject: [Koha-bugs] [Bug 3766] Cities/Towns and Road Types only on one address In-Reply-To: <bug-3766-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-3766-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3766-70-cSLWxTqHGR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3766 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:36:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 14:36:14 +0000 Subject: [Koha-bugs] [Bug 22474] Authority and biblio field mapping improperly shared In-Reply-To: <bug-22474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22474-70-aYwRbfrjQm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22474 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 15:36:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 14:36:17 +0000 Subject: [Koha-bugs] [Bug 22474] Authority and biblio field mapping improperly shared In-Reply-To: <bug-22474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22474-70-6SJbClUuNC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22474 --- Comment #1 from Ere Maijala <ere.maijala at helsinki.fi> --- Created attachment 86278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86278&action=edit Bug 22474: Clone field config before adding fields to it Test plain: 1. Reindex both authorities and biblios with the -d flag to recreate the index, e.g. "perl misc/search_tools/rebuild_elastic_search.pl -v -d" 2. Check that authorities only contains authority-specific fields in Elasticsearch e.g. by fetching http://localhost:9200/koha_dev_authorities/_mappings 3. Reindex both without the -d flag and verify it works, e.g. "perl misc/search_tools/rebuild_elastic_search.pl -v" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 16:03:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 15:03:45 +0000 Subject: [Koha-bugs] [Bug 21070] request.pl details links to biblio instead of moredetail.pl for that item In-Reply-To: <bug-21070-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21070-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21070-70-Ck3Uwr7LfO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21070 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Version|17.11 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 16:10:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 15:10:24 +0000 Subject: [Koha-bugs] [Bug 21070] request.pl details links to biblio instead of moredetail.pl for that item In-Reply-To: <bug-21070-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21070-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21070-70-cJuJ3BfbkO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21070 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 16:10:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 15:10:26 +0000 Subject: [Koha-bugs] [Bug 21070] request.pl details links to biblio instead of moredetail.pl for that item In-Reply-To: <bug-21070-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21070-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21070-70-kfbU2rhRGR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21070 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 86279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86279&action=edit Bug 21070: request.pl details links to biblio instead of moredetail.pl for that item This patch alters the hold summary page so that links to records with item-level holds go to the item detail page instead of the bibliographic detail page. There is already a link to the bibliographic detail page in the page heading. To test, apply the patch and place or locate an item-level hold. In the list of existing holds for that record, the linked barcode on the item-level hold should take you to the corresponding item detail page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:00:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 16:00:26 +0000 Subject: [Koha-bugs] [Bug 22274] Self-checkout/checkin pages not covered by OPAC CSS changes In-Reply-To: <bug-22274-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22274-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22274-70-k8nZYjeL2Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22274 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor.grousset at biblibre.co | |m --- Comment #3 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Hi, Thanks for the finding this and working on it. Do you seek tester on this patch? Or do you still need to work on it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:02:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 16:02:18 +0000 Subject: [Koha-bugs] [Bug 22422] improve item location display with class "shelvingloc" In-Reply-To: <bug-22422-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22422-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22422-70-6FMYGW4KZ5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22422 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:02:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 16:02:20 +0000 Subject: [Koha-bugs] [Bug 22422] improve item location display with class "shelvingloc" In-Reply-To: <bug-22422-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22422-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22422-70-KKyTVhKebQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22422 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85861|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 86280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86280&action=edit Bug 22422: improve item location display with class "shelvingloc" In record detail page, item location is displayed with CSS using class "shelvingloc". Many many places at intranet and OPAC can use this class. It allows to change display in all places using CSS customisation. This patch removes the CSS "display:block" for class "shelvingloc". Some places where using "inline" to correct the display. I think the display should not be managed in template. So it will be inline by default and it can be changed by custom CSS, on all places or depending on a selctor. Test plan : 1) Compile SCSS to CSS 2) Add to preferences IntranetUserCSS and OPACUserCSS : .shelvingloc { color:red } 3) Go to pages impacted by patch, be sure to look at cart with "more details" 4) You see item location italic and red Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:03:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 16:03:50 +0000 Subject: [Koha-bugs] [Bug 22475] New: Shelving location doesn't appear on tags list view Message-ID: <bug-22475-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22475 Bug ID: 22475 Summary: Shelving location doesn't appear on tags list view Change sponsored?: --- Product: Koha Version: master Hardware: All URL: /cgi-bin/koha/tags/list.pl?tag=foo OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Depends on: 22422 Target Milestone: --- In the staff client, when viewing a list of titles with a particular tag, shelving location is supposed to appear but doesn't. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22422 [Bug 22422] improve item location display with class "shelvingloc" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:03:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 16:03:50 +0000 Subject: [Koha-bugs] [Bug 22422] improve item location display with class "shelvingloc" In-Reply-To: <bug-22422-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22422-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22422-70-tuDZvlXflA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22422 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22475 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22475 [Bug 22475] Shelving location doesn't appear on tags list view -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:09:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 16:09:28 +0000 Subject: [Koha-bugs] [Bug 22475] Shelving location doesn't appear on tags list view In-Reply-To: <bug-22475-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22475-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22475-70-5IkWIxgftd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22475 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:09:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 16:09:30 +0000 Subject: [Koha-bugs] [Bug 22475] Shelving location doesn't appear on tags list view In-Reply-To: <bug-22475-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22475-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22475-70-vmorYGF9H4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22475 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 86281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86281&action=edit Bug 22475: Shelving location doesn't appear on tags list view This patch corrects the tags list view so that shelving location appears correctly. Previously the template tried to display a variable which was empty. To test, apply the patch and locate an title which has both a tag applied to it and a shelving location defined for one or more items. Go to Tools -> Tags and click the tag to view titles with that tag. In the location column of the table the shelving location should appear along with library and call number. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:16:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 16:16:54 +0000 Subject: [Koha-bugs] [Bug 22274] Self-checkout/checkin pages not covered by OPAC CSS changes In-Reply-To: <bug-22274-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22274-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22274-70-M0oyPI9vvs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22274 --- Comment #4 from Oliver Behnke <oliver.behnke at aei.mpg.de> --- Hi Victor, I just uploaded a *crude* patch that was simply meant as a workaround for others having the same problem. It's just a hack that I did to quickly fix our production site. I was hoping that those people responsible for the CSS changes in #20554 or those who developed the SCO/SCI layout would take of this problem and fix it "the right way". That said, I took that patch as far as I could but I wouldn't move that into testing before someone knowledgeable in the area signed off on it, or ideally, fixed/streamlined it first. For instance, I'm not using SCSS which bloats the code and shouldn't be committed that way. Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:36:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 16:36:46 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-7LwBNtU1Go@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86245|0 |1 is obsolete| | --- Comment #184 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86283&action=edit Bug 20912: Rental Fees based on Time Period Some libraries would like to be able to charge a rental fee based on the number of days an item will be checked out, as opposed to the flat fee currently offered by Koha. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Edit an itemtype, add a daily rental fee of 1.00 4) Check an item of that itemtype out for 7 days 5) Verify the patron now has rental fee of 7.00 Signed-off-by: Matha Fuerst <mfuerst at hmcpl.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:36:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 16:36:51 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-cLWzhZenvA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86246|0 |1 is obsolete| | --- Comment #185 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86284&action=edit Bug 20912: Update schema file Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:36:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 16:36:55 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-93MBNWnXN3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86247|0 |1 is obsolete| | --- Comment #186 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86285&action=edit Bug 20912: (QA follow-up) Fix number of tests and correct typos Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:37:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 16:37:00 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-Q1xWe1geK0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86248|0 |1 is obsolete| | --- Comment #187 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86286&action=edit Bug 20912: (QA follow-up) Set daily charge to 0 for item type not being used for test Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:37:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 16:37:04 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-MnXh78R01T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86249|0 |1 is obsolete| | --- Comment #188 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86287&action=edit Bug 20912: (QA follow-up) Make unit tests reliable and get rid of perl warnings Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:37:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 16:37:09 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-nn3CcdAhIW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86250|0 |1 is obsolete| | --- Comment #189 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86288&action=edit Bug 20912: Move calculation to Koha::Fees Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:36:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 16:36:42 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-uoCbHnOdft@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86244|0 |1 is obsolete| | --- Comment #183 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86282&action=edit Bug 20912: Update database Signed-off-by: Matha Fuerst <mfuerst at hmcpl.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:37:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 16:37:14 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-BpjXXR3MdD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86251|0 |1 is obsolete| | --- Comment #190 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86289&action=edit Bug 20912: (QA follow-up): Fix up Koha::Fees Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:37:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 16:37:18 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-XzQLwrAXTD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86252|0 |1 is obsolete| | --- Comment #191 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86290&action=edit Bug 20912: (QA follow-up): Fix up unit tests Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:37:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 16:37:23 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-WqsbrHiyQn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86253|0 |1 is obsolete| | --- Comment #192 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86291&action=edit Bug 20912: (QA follow-up) Move Fees to Charges:: In preparation for the introduction of Koha::Charges::Fines I have moved this ::Fees class into the Koha::Charges:: namespace Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:37:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 16:37:27 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-RlMTwxD05r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86254|0 |1 is obsolete| | --- Comment #193 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86292&action=edit Bug 20912: (QA follow-up) Test for distinct accountlines Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:37:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 16:37:32 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-yPDV8yg00t@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86255|0 |1 is obsolete| | --- Comment #194 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86293&action=edit Bug 20912: (QA follow-up) Make DB Update idempotent Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:37:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 16:37:41 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-fLgWg0YpUk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86257|0 |1 is obsolete| | --- Comment #196 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86295&action=edit Bug 20912: (follow-up) Add hourly support It seemed strange to only add support for Daily loans in the feature when Koha also support loan periods in hours. This patch adds parallel functionaliy for hourly loan periods. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:37:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 16:37:37 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-K26Qg3chzA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86256|0 |1 is obsolete| | --- Comment #195 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86294&action=edit Bug 20912: (follow-up) Improve test coverage Increase test coverage for CanBookBeIssued and fix a introduced during the refactoring to Koha::Fees. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:37:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 16:37:46 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-Gl0N0QmoJK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86258|0 |1 is obsolete| | --- Comment #197 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86296&action=edit Bug 20912: (QA follow-up) Fix TestBuilder Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:37:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 16:37:50 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-Gzbk2voIdK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86259|0 |1 is obsolete| | --- Comment #198 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86297&action=edit Bug 20912: (QA follow-up) Fix some test failures Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:37:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 16:37:55 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-Z2QZPnhrNV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86260|0 |1 is obsolete| | --- Comment #199 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86298&action=edit Bug 20912: (QA follow-up) POD fix Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:37:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 16:37:59 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-FMNRNtTJ7X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86261|0 |1 is obsolete| | --- Comment #200 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86299&action=edit Bug 20912: (QA follow-up) The default rule already has renewalsallowed=0 Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:38:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 16:38:04 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-hCIpstIyxG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86262|0 |1 is obsolete| | --- Comment #201 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86300&action=edit Bug 20912: (follow-up) Prevent double charging on renewal This patch updates the tests the ensure we do not double charge for renewals that take place before the original due date and fixes the corresponding loging in C4::Circulation::AddRenewal. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:38:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 16:38:09 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-wJuOXfgwtH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86263|0 |1 is obsolete| | --- Comment #202 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86301&action=edit Bug 20912: (QA follow-up) Warn patron of daily and hourly renewal fees Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:38:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 16:38:14 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-pE1t6yH38g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86264|0 |1 is obsolete| | --- Comment #203 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86302&action=edit Bug 20912: (QA follow-up) Rebase error corrections The automatic rebase after bug 21206 required a helping hand. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:43:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 16:43:11 +0000 Subject: [Koha-bugs] [Bug 22476] New: MarkLostItemsAsReturned has wrong defaults for new installs Message-ID: <bug-22476-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22476 Bug ID: 22476 Summary: MarkLostItemsAsReturned has wrong defaults for new installs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Database Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- bug 19287 added 'pendingreserves' as an option for MarkLostItemsAsReturned, but did not add it to the options for the syspref in sysprefs.sql Additionally, the values should be comma separated, not pipe -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:43:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 16:43:20 +0000 Subject: [Koha-bugs] [Bug 22476] MarkLostItemsAsReturned has wrong defaults for new installs In-Reply-To: <bug-22476-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22476-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22476-70-3tXsIq7Zg7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22476 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19287 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287 [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:43:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 16:43:20 +0000 Subject: [Koha-bugs] [Bug 19287] Add ability to mark an item 'Lost' from 'Holds to pull' list In-Reply-To: <bug-19287-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19287-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19287-70-nfeS91MnV8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19287 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22476 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22476 [Bug 22476] MarkLostItemsAsReturned has wrong defaults for new installs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:43:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 16:43:27 +0000 Subject: [Koha-bugs] [Bug 7088] Cannot renew items on hold even with override In-Reply-To: <bug-7088-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7088-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7088-70-T5tN2xPjRF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 --- Comment #40 from Owen Leonard <oleonard at myacpl.org> --- What about changing the label to "Due date for on hold items" ? I think having the second date picker is something which looks to me like clutter but I assume that those who want to use the feature will appreciate it. I do have one issue: The new date picker should be hidden initially, correct? For me it isn't. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:49:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 16:49:53 +0000 Subject: [Koha-bugs] [Bug 22476] MarkLostItemsAsReturned has wrong defaults for new installs In-Reply-To: <bug-22476-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22476-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22476-70-v65ikFi3Av@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22476 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:49:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 16:49:55 +0000 Subject: [Koha-bugs] [Bug 22476] MarkLostItemsAsReturned has wrong defaults for new installs In-Reply-To: <bug-22476-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22476-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22476-70-GecxbFZnFq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22476 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 86303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86303&action=edit Bug 22476: Correct default for MarkLostItemsAsReturned To test: Install a new db (reset_all) Verify the sysprefs is set as expected -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:50:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 16:50:07 +0000 Subject: [Koha-bugs] [Bug 22476] MarkLostItemsAsReturned has wrong defaults for new installs In-Reply-To: <bug-22476-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22476-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22476-70-Z7lVZA8pPN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22476 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:50:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 16:50:30 +0000 Subject: [Koha-bugs] [Bug 7088] Cannot renew items on hold even with override In-Reply-To: <bug-7088-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7088-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7088-70-1Rlt2Y54li@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 --- Comment #41 from Owen Leonard <oleonard at myacpl.org> --- (In reply to Owen Leonard from comment #40) > I do have one issue: The new date picker should be hidden initially, > correct? For me it isn't. Sorry, my mistake -- I didn't rebuild CSS. I think this can be put back to "Signed off" unless someone wants to suggest a label change. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:51:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 16:51:29 +0000 Subject: [Koha-bugs] [Bug 7088] Cannot renew items on hold even with override In-Reply-To: <bug-7088-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7088-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7088-70-nAVO4hQzmI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7088 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:52:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 16:52:36 +0000 Subject: [Koha-bugs] [Bug 22371] MARC bibliographic framework plugin to generate Cutter-Sanborn In-Reply-To: <bug-22371-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22371-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22371-70-A9K0ggocKQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22371 ?talo <italo.barbosa.brasileiro at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85466|0 |1 is obsolete| | Attachment #86277|0 |1 is obsolete| | --- Comment #8 from ?talo <italo.barbosa.brasileiro at gmail.com> --- Created attachment 86304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86304&action=edit Updated plugin code, using String.prototype.normalize() -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 17:55:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 16:55:12 +0000 Subject: [Koha-bugs] [Bug 22371] MARC bibliographic framework plugin to generate Cutter-Sanborn In-Reply-To: <bug-22371-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22371-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22371-70-XKCGrMnorp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22371 --- Comment #9 from ?talo <italo.barbosa.brasileiro at gmail.com> --- (In reply to paxed from comment #4) > Should also perhaps use String.prototype.normalize() if it's available Paxed, the new attachment ('Updated plugin code, using String.prototype.normalize()') was done with normalize(). Thanks for the suggestion! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 18:17:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 17:17:00 +0000 Subject: [Koha-bugs] [Bug 21943] Clean up holds template In-Reply-To: <bug-21943-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21943-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21943-70-d5bBeVoVeQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21943 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #2 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86305&action=edit Screenshot of responsive view Hi, Sorry the responsive view doesn't look quite right. Have a look? Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 18:20:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 17:20:19 +0000 Subject: [Koha-bugs] [Bug 22476] MarkLostItemsAsReturned has wrong defaults for new installs In-Reply-To: <bug-22476-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22476-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22476-70-NpBY1JGfSR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22476 Margaret <margaret at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |margaret at bywatersolutions.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 18:20:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 17:20:51 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-Z5j4H6FhNw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86282|0 |1 is obsolete| | --- Comment #204 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86306&action=edit Bug 20912: Update database Signed-off-by: Matha Fuerst <mfuerst at hmcpl.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 18:20:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 17:20:56 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-YkG8vC6kUe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86283|0 |1 is obsolete| | --- Comment #205 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86307&action=edit Bug 20912: Rental Fees based on Time Period Some libraries would like to be able to charge a rental fee based on the number of days an item will be checked out, as opposed to the flat fee currently offered by Koha. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Edit an itemtype, add a daily rental fee of 1.00 4) Check an item of that itemtype out for 7 days 5) Verify the patron now has rental fee of 7.00 Signed-off-by: Matha Fuerst <mfuerst at hmcpl.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 18:21:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 17:21:00 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-fePNA85zrj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86284|0 |1 is obsolete| | --- Comment #206 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86308&action=edit Bug 20912: Update schema file Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 18:21:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 17:21:05 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-ygfvBsyCO4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86285|0 |1 is obsolete| | --- Comment #207 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86309&action=edit Bug 20912: (QA follow-up) Fix number of tests and correct typos Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 18:21:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 17:21:10 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-QwV7jTR8oD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86286|0 |1 is obsolete| | --- Comment #208 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86310&action=edit Bug 20912: (QA follow-up) Set daily charge to 0 for item type not being used for test Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 18:21:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 17:21:14 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-IKa2sxtMLt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86287|0 |1 is obsolete| | --- Comment #209 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86311&action=edit Bug 20912: (QA follow-up) Make unit tests reliable and get rid of perl warnings Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 18:21:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 17:21:19 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-iTNdoclfBc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86288|0 |1 is obsolete| | --- Comment #210 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86312&action=edit Bug 20912: Move calculation to Koha::Fees Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 18:21:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 17:21:24 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-bTv0NqnjdS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86289|0 |1 is obsolete| | --- Comment #211 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86313&action=edit Bug 20912: (QA follow-up): Fix up Koha::Fees Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 18:21:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 17:21:28 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-SDtIrF5e7g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86290|0 |1 is obsolete| | --- Comment #212 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86314&action=edit Bug 20912: (QA follow-up): Fix up unit tests Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 18:21:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 17:21:33 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-pus9cs3QFV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86291|0 |1 is obsolete| | --- Comment #213 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86315&action=edit Bug 20912: (QA follow-up) Move Fees to Charges:: In preparation for the introduction of Koha::Charges::Fines I have moved this ::Fees class into the Koha::Charges:: namespace Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 18:21:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 17:21:37 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-yBQhg3z7Gi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86292|0 |1 is obsolete| | --- Comment #214 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86316&action=edit Bug 20912: (QA follow-up) Test for distinct accountlines Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 18:21:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 17:21:40 +0000 Subject: [Koha-bugs] [Bug 21943] Clean up holds template In-Reply-To: <bug-21943-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21943-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21943-70-m91yafFpQp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21943 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 18:21:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 17:21:43 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-XHxOuuWZQ4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86293|0 |1 is obsolete| | --- Comment #215 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86317&action=edit Bug 20912: (QA follow-up) Make DB Update idempotent Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 18:21:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 17:21:47 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-GoAtS4TYNJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86294|0 |1 is obsolete| | --- Comment #216 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86318&action=edit Bug 20912: (follow-up) Improve test coverage Increase test coverage for CanBookBeIssued and fix a introduced during the refactoring to Koha::Fees. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 18:21:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 17:21:52 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-iOhQmggjbi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86295|0 |1 is obsolete| | --- Comment #217 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86319&action=edit Bug 20912: (follow-up) Add hourly support It seemed strange to only add support for Daily loans in the feature when Koha also support loan periods in hours. This patch adds parallel functionaliy for hourly loan periods. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 18:21:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 17:21:57 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-8ayVkYAlXS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86296|0 |1 is obsolete| | --- Comment #218 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86320&action=edit Bug 20912: (QA follow-up) Fix TestBuilder Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 18:22:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 17:22:01 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-1jX0CMroRU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86297|0 |1 is obsolete| | --- Comment #219 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86321&action=edit Bug 20912: (QA follow-up) Fix some test failures Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 18:22:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 17:22:07 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-GOI4x0bWRI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86298|0 |1 is obsolete| | --- Comment #220 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86322&action=edit Bug 20912: (QA follow-up) POD fix Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 18:22:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 17:22:11 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-vNcaj8u2Gl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86299|0 |1 is obsolete| | --- Comment #221 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86323&action=edit Bug 20912: (QA follow-up) The default rule already has renewalsallowed=0 Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 18:22:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 17:22:16 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-DFmlv1tM78@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86300|0 |1 is obsolete| | --- Comment #222 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86324&action=edit Bug 20912: (follow-up) Prevent double charging on renewal This patch updates the tests the ensure we do not double charge for renewals that take place before the original due date and fixes the corresponding loging in C4::Circulation::AddRenewal. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 18:22:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 17:22:21 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-y5CUqjkZkd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86301|0 |1 is obsolete| | --- Comment #223 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86325&action=edit Bug 20912: (QA follow-up) Warn patron of daily and hourly renewal fees Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 18:22:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 17:22:25 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-w3Agk0dcmb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86302|0 |1 is obsolete| | --- Comment #224 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86326&action=edit Bug 20912: (QA follow-up) Rebase error corrections The automatic rebase after bug 21206 required a helping hand. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 18:22:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 17:22:30 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-8AtSibew9j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 --- Comment #225 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86327&action=edit Bug 20912: (QA follow-up) Add on_editing to $Price filter Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 18:24:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 17:24:37 +0000 Subject: [Koha-bugs] [Bug 22430] importing from a UNIMARC backup will import biblio records but not items In-Reply-To: <bug-22430-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22430-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22430-70-NXGH7wxisd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22430 --- Comment #6 from Giuseppe Ciaccio <giuseppe.ciaccio at unige.it> --- (In reply to Fridolin SOMERS from comment #5) > (In reply to Fridolin SOMERS from comment #2) > > (In reply to Giuseppe Ciaccio from comment #0) > > > So it seems that the UNIMARC item field is correctly fetched when importing > > > the backup in the stage area, but discarded when the staged records are > > > pushed in the catalog. > > > > I think I found why. > > The push to catalog is not allowed because the items have the same barcode > > which must be unique in catalog. > > Ok it is not that. > Does instances A and B have the same branches ? > for items homebranch and holdingbranch Bingo! The two instances A and B have different branchcode and it seems that instance A refuses to import items whose branchcode does not match. Verified by manually editing subfields 995$b and 995$c -- replacing some of the original branchcodes with the one of instance A, then A will import only those items with matching branchcodes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 18:34:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 17:34:03 +0000 Subject: [Koha-bugs] [Bug 22477] New: Missing DataTables configuration when searching patrons for holds Message-ID: <bug-22477-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22477 Bug ID: 22477 Summary: Missing DataTables configuration when searching patrons for holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Target Milestone: --- When placing a hold, if the page displays patron search results there is a JavaScript error in the console complaining that KohaTable is not defined. The patron search results table is supposed to be a DataTable with columns configuration but request.tt doesn't provide any column configuration. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 18:39:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 17:39:33 +0000 Subject: [Koha-bugs] [Bug 22477] Missing DataTables configuration when searching patrons for holds In-Reply-To: <bug-22477-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22477-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22477-70-zzWvnfKXpG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22477 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 18:39:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 17:39:35 +0000 Subject: [Koha-bugs] [Bug 22477] Missing DataTables configuration when searching patrons for holds In-Reply-To: <bug-22477-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22477-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22477-70-XKBWvU3dPc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22477 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 86328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86328&action=edit Bug 22477: Missing DataTables configuration when searching patrons for holds This patch adds columns configuration to the holds request page to fix a JavaScript error in the console and to allow the patron search results table to be enabled as a DataTable. To reproduce: Place a hold on a title in the staff client. When prompted for a patron, perform a search which will return multiple results. The patron search results will appear in an unsortable table. A JS error can be seen in the browser console. To test, apply the patch and repeat the steps above. The patron search results table should be sortable and there should be no JS error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 18:41:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 17:41:10 +0000 Subject: [Koha-bugs] [Bug 21721] Update C4::Circulation::AddRenewal to use Koha::Account->add_debit In-Reply-To: <bug-21721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21721-70-KLIJF3HJvy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21721 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 18:40:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 17:40:55 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-cW4zF0N6Cm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #226 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 19:48:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 18:48:34 +0000 Subject: [Koha-bugs] [Bug 22377] Lost fines may not be refunded if another patron has a writeoff for the same item In-Reply-To: <bug-22377-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22377-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22377-70-pkaTQErwHm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22377 --- Comment #2 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Jonathan Druart from comment #1) > Do you have the rule defined? It seems that it is not created on install. Which rule? I believe the problem is in the code for _FixAccountForLostAndReturned my $accountlines = Koha::Account::Lines->search( { itemnumber => $itemnumber, accounttype => { -in => [ 'L', 'Rep', 'W' ] }, }, { order_by => { -desc => [ 'date', 'accountno' ] } } ); We order by date and accountno - so a more recent writeoff will be found insetad of the lost fine -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 20:08:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 19:08:04 +0000 Subject: [Koha-bugs] [Bug 21070] request.pl details links to biblio instead of moredetail.pl for that item In-Reply-To: <bug-21070-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21070-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21070-70-HEw3Pm03uZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21070 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86279|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 86329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86329&action=edit Bug 21070: request.pl details links to biblio instead of moredetail.pl for that item This patch alters the hold summary page so that links to records with item-level holds go to the item detail page instead of the bibliographic detail page. There is already a link to the bibliographic detail page in the page heading. To test, apply the patch and place or locate an item-level hold. In the list of existing holds for that record, the linked barcode on the item-level hold should take you to the corresponding item detail page. Signed-off-by: Lisette <lisettes at latahlibrary.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 20:08:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 19:08:29 +0000 Subject: [Koha-bugs] [Bug 21070] request.pl details links to biblio instead of moredetail.pl for that item In-Reply-To: <bug-21070-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21070-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21070-70-FeQuebjjgH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21070 Lisette Scheer <lisetteslatah at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 20:15:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 19:15:03 +0000 Subject: [Koha-bugs] [Bug 19747] Clicking 'Help' on request-article.pl yields no help page. In-Reply-To: <bug-19747-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19747-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19747-70-5YpLj7Sp7l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19747 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|17.05 |17.11 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Switching version to 17.11 since the problem is in that version too and 17.05 is no longer maintained. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 20:18:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 19:18:21 +0000 Subject: [Koha-bugs] [Bug 18091] No documentation for SMS via email in 16.05 or 16.11 documentation In-Reply-To: <bug-18091-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18091-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18091-70-0a3M1goQDL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18091 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #4 from Owen Leonard <oleonard at myacpl.org> --- I think this is resolved for newer versions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 20:22:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 19:22:58 +0000 Subject: [Koha-bugs] [Bug 18303] Release team omnibus In-Reply-To: <bug-18303-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18303-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18303-70-7FzXzb8o38@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18303 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Is this bug still valid? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 20:23:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 19:23:48 +0000 Subject: [Koha-bugs] [Bug 21925] Unable to Remove or Suspend Holds In-Reply-To: <bug-21925-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21925-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21925-70-Qxm7rgglDk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21925 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 20:26:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 19:26:32 +0000 Subject: [Koha-bugs] [Bug 14669] Search orders by branch In-Reply-To: <bug-14669-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14669-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14669-70-P1DHV1aeS0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14669 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|search by branch |Search orders by branch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 20:41:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 19:41:45 +0000 Subject: [Koha-bugs] [Bug 21003] Don't show warning when editing a reserve item In-Reply-To: <bug-21003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21003-70-aN2xXDsSgw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21003 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- > 8) Finally verify that when adding a reserve with a barcode that DOES > exist in the course reserves that the warning 'The course already...' IS > displayed and the header of the div says Edit At this step I notice some inconsistency: The page title is "Course reserves >Add items" but the <legend> uses "Edit." Also note the missing space before "Add" in the page title. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 20:43:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 19:43:48 +0000 Subject: [Koha-bugs] [Bug 6775] Add option to use authorized values as reasons for restrictions In-Reply-To: <bug-6775-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6775-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6775-70-yvU0lCiV4F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6775 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|shinoy.m at osslabs.biz |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 20:45:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 19:45:23 +0000 Subject: [Koha-bugs] [Bug 20136] Test Bug In-Reply-To: <bug-20136-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20136-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20136-70-5sbRWJ7sDY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20136 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 20:50:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 19:50:50 +0000 Subject: [Koha-bugs] [Bug 11908] update22to30.pl falls to create `labels` table In-Reply-To: <bug-11908-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11908-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11908-70-3SnSPHhGXY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11908 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Can this bug be closed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 20:53:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 19:53:25 +0000 Subject: [Koha-bugs] [Bug 17598] Make use of itemtypes.summary In-Reply-To: <bug-17598-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17598-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17598-70-X9w9kdWeFb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17598 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Do we have a good reason to start making use of itemtypes.summary or should we drop it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 20:54:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 19:54:38 +0000 Subject: [Koha-bugs] [Bug 17598] Make use of itemtypes.summary In-Reply-To: <bug-17598-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17598-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17598-70-YCyYbBv4Rz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17598 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m, | |katrin.fischer at bsz-bw.de, | |victor.grousset at biblibre.co | |m --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think it was once explained as a UNIMARC feature to me. Adding Frido and Victor - maybe one of them knows. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 20:59:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 19:59:26 +0000 Subject: [Koha-bugs] [Bug 19282] Add the copy, print and export DataTables buttons on all koha tables In-Reply-To: <bug-19282-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19282-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19282-70-x7O19wziOQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19282 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20350, 19902, 21409, 20966, | |15668, 21785, 22190, 22191, | |21852 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15668 [Bug 15668] Add column configuration to the items table in staff detail pages https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19902 [Bug 19902] Add column configuration to bibliographic record checkouts history table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20350 [Bug 20350] Add column configuration to table of saved reports https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20966 [Bug 20966] Add column configuration to table of orders in a basket https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21409 [Bug 21409] Add column configuration to course reserves https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21785 [Bug 21785] Add column configuration to hold ratios report https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 [Bug 21852] Add more columns and column configuration to overdues report https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22190 [Bug 22190] Add column configuration to patron category administration https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22191 [Bug 22191] Add column configuration to libraries administration -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 20:59:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 19:59:26 +0000 Subject: [Koha-bugs] [Bug 15668] Add column configuration to the items table in staff detail pages In-Reply-To: <bug-15668-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15668-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15668-70-5ABl0wBEBF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15668 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19282 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19282 [Bug 19282] Add the copy, print and export DataTables buttons on all koha tables -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 20:59:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 19:59:26 +0000 Subject: [Koha-bugs] [Bug 19902] Add column configuration to bibliographic record checkouts history table In-Reply-To: <bug-19902-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19902-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19902-70-dsLlx6v2Pk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19902 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19282 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19282 [Bug 19282] Add the copy, print and export DataTables buttons on all koha tables -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 20:59:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 19:59:26 +0000 Subject: [Koha-bugs] [Bug 20350] Add column configuration to table of saved reports In-Reply-To: <bug-20350-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20350-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20350-70-LcpNRnWKUA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20350 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19282 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19282 [Bug 19282] Add the copy, print and export DataTables buttons on all koha tables -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 20:59:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 19:59:26 +0000 Subject: [Koha-bugs] [Bug 20966] Add column configuration to table of orders in a basket In-Reply-To: <bug-20966-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20966-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20966-70-yRgtVR6Dfc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20966 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19282 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19282 [Bug 19282] Add the copy, print and export DataTables buttons on all koha tables -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 20:59:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 19:59:26 +0000 Subject: [Koha-bugs] [Bug 21409] Add column configuration to course reserves In-Reply-To: <bug-21409-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21409-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21409-70-MCawLa2p8F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21409 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19282 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19282 [Bug 19282] Add the copy, print and export DataTables buttons on all koha tables -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 20:59:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 19:59:26 +0000 Subject: [Koha-bugs] [Bug 21785] Add column configuration to hold ratios report In-Reply-To: <bug-21785-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21785-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21785-70-D3EepphyEM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21785 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19282 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19282 [Bug 19282] Add the copy, print and export DataTables buttons on all koha tables -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 20:59:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 19:59:26 +0000 Subject: [Koha-bugs] [Bug 21852] Add more columns and column configuration to overdues report In-Reply-To: <bug-21852-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21852-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21852-70-tHocBEIw97@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19282 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19282 [Bug 19282] Add the copy, print and export DataTables buttons on all koha tables -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 20:59:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 19:59:26 +0000 Subject: [Koha-bugs] [Bug 22190] Add column configuration to patron category administration In-Reply-To: <bug-22190-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22190-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22190-70-eBlaVEAIYr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22190 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19282 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19282 [Bug 19282] Add the copy, print and export DataTables buttons on all koha tables -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 20:59:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 19:59:26 +0000 Subject: [Koha-bugs] [Bug 22191] Add column configuration to libraries administration In-Reply-To: <bug-22191-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22191-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22191-70-LZ6js202jC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22191 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19282 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19282 [Bug 19282] Add the copy, print and export DataTables buttons on all koha tables -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 21:00:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 20:00:27 +0000 Subject: [Koha-bugs] [Bug 21772] Add holds information tab to the SCO module In-Reply-To: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21772-70-cJgT7D1DwF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 21:00:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 20:00:41 +0000 Subject: [Koha-bugs] [Bug 21772] Add holds information tab to the SCO module In-Reply-To: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21772-70-MJDe7k0CXN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 21:18:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 20:18:06 +0000 Subject: [Koha-bugs] [Bug 21003] Don't show warning when editing a reserve item In-Reply-To: <bug-21003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21003-70-uRs4WdOWer@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21003 --- Comment #3 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Hi, The reason for this is that I figured that if someone wanted to add a book into the course reserves that already existed that we would want them to know that they are actually editing the item rather than adding it, but also that they are in the same place as they were trying to get to (in reference to the breadcrumbs, and title). This was intentional, however I will change it if you think it is better in this case to have all keywords as Edit instead of Add in this case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 21:20:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 20:20:30 +0000 Subject: [Koha-bugs] [Bug 22173] Search Groups broken by change in expected structure In-Reply-To: <bug-22173-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22173-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22173-70-f8SzKr36Ye@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22173 Lisette Scheer <lisetteslatah at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 21:32:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 20:32:23 +0000 Subject: [Koha-bugs] [Bug 21003] Don't show warning when editing a reserve item In-Reply-To: <bug-21003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21003-70-wHJPEmJlUm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21003 --- Comment #4 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Created attachment 86330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86330&action=edit Bug 21003: Made Edit keywords more consistent in add_items-step2.tt When adding a course reserve with a barcode that already exists, the title, breadcrumbs, and legend of the form all specify that the user is editing, and not adding, the book. Test plan: Same as comment 1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 21:32:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 20:32:20 +0000 Subject: [Koha-bugs] [Bug 21003] Don't show warning when editing a reserve item In-Reply-To: <bug-21003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21003-70-mfkhZmETQE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21003 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 21:41:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 20:41:57 +0000 Subject: [Koha-bugs] [Bug 22374] Circulation.t noisy since Bug 21753 was pushed In-Reply-To: <bug-22374-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22374-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22374-70-eVN6eoMyQf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22374 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 21:50:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 20:50:51 +0000 Subject: [Koha-bugs] [Bug 22466] TT methods must not be escaped In-Reply-To: <bug-22466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22466-70-kHK0W8dtjd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22466 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #10 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 21:58:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 20:58:43 +0000 Subject: [Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead) In-Reply-To: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21756-70-6shb7FQrQc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #102 from Nick Clemens <nick at bywatersolutions.com> --- Looks like we lost the sign off lines on the latest patches. I also only see Josef, did these skip SO and go straight to QA? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 21:59:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 20:59:05 +0000 Subject: [Koha-bugs] [Bug 17179] Advanced editor: Add keyboard shortcuts to repeat (duplicate) a field, and cut text In-Reply-To: <bug-17179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17179-70-bDNCRk7WTu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #11 from Liz Rea <wizzyrea at gmail.com> --- Firefox claims so many key combinations :( I had trouble with ctrl-p (print menu every single time - usability nightmare if it's intermittent), ctrl-l (selects address bar text), ctrl-i (page info, another you have to have the cursor in just the right spot), shift-ctrl-c (inspector). The one good thing is that with the 21411 bug, you can remap all of the keys to whatever you want. The bad thing is that at least in Firefox, there aren't many key combos left to use that don't have a Firefox feature associated, and often you have to be really careful about where the cursor is when you use them. It could be really, really frustrating for users. Much more frustrating than say, using MARCEdit or some other tool to write your record and then importing the record. I'm not sure what to do here, none of the options seem perfect. I suppose you could get the cataloguers who use this to install something like https://www.ghacks.net/2016/12/24/disable-keyboard-shortcuts-in-firefox/ so as to unbind and free up a few, but I hate to make people have Firefox addons for what ought to be core features. The use case outlineed in the article there seems very similar to what we are dealing with: an editor window that uses a key binding that also is one that Firefox claims. If we are going to say "yes, use this plugin for firefox with the advanced editor" then I think I'm ok to let this through basically as is after a bit of retesting with the plugin. But we also need to be aware that not every IT department will allow the usage of Firefox plugins, and that those users will have a sub optimal experience. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 22:09:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 21:09:09 +0000 Subject: [Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead) In-Reply-To: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21756-70-axi0VGY5X2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #103 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Ooh, I thought Tomas was doing a final QA as both Josef and I worked on it and in effect signed off each others work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 22:19:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 21:19:42 +0000 Subject: [Koha-bugs] [Bug 15774] Additional fields for baskets In-Reply-To: <bug-15774-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15774-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15774-70-fBYN3NOefO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed by Module Maintainer --- Comment #157 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 22:19:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 21:19:53 +0000 Subject: [Koha-bugs] [Bug 16251] Material type is not correctly set for Rancor 008 widget In-Reply-To: <bug-16251-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16251-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16251-70-NpCqCmXMHc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16251 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 22:20:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 21:20:04 +0000 Subject: [Koha-bugs] [Bug 20535] ModZebra called with $record with items stripped in ModBiblioMarc In-Reply-To: <bug-20535-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20535-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20535-70-voz5f36keo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20535 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 22:20:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 21:20:43 +0000 Subject: [Koha-bugs] [Bug 20639] Allow setting a default/single backend for OPAC driven requests In-Reply-To: <bug-20639-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20639-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20639-70-f6pbK1nK6U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639 --- Comment #23 from Nick Clemens <nick at bywatersolutions.com> --- Oops! Actually , pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 22:20:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 21:20:54 +0000 Subject: [Koha-bugs] [Bug 22031] C4::Auth->haspermission should allow checking for more than one subpermission In-Reply-To: <bug-22031-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22031-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22031-70-ttnmaQBF3V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22031 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 22:21:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 21:21:30 +0000 Subject: [Koha-bugs] [Bug 22303] Wrong bottom in virtualshelves/addbybiblionumber.tt In-Reply-To: <bug-22303-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22303-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22303-70-zz2AcAUiZk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22303 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #8 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 22:21:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 21:21:44 +0000 Subject: [Koha-bugs] [Bug 22416] Search.t tests need adjustment for EasyAnalyticRecords syspref In-Reply-To: <bug-22416-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22416-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22416-70-QwI6aYKyqV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22416 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #3 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 22:21:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 21:21:17 +0000 Subject: [Koha-bugs] [Bug 22275] 18.06.00.060 DB update fails (incomplete/incorrect defaults) In-Reply-To: <bug-22275-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22275-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22275-70-XcursKUdGB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22275 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #17 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 22:22:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 21:22:18 +0000 Subject: [Koha-bugs] [Bug 22419] Removing multiple records from intranet cart causes browser timeout In-Reply-To: <bug-22419-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22419-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22419-70-qxqbjk0n3E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22419 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 22:23:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 21:23:01 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18235-70-deZO29pAXQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #71 from Nick Clemens <nick at bywatersolutions.com> --- Conflict in the mappings file, please rebase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 22:23:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 21:23:20 +0000 Subject: [Koha-bugs] [Bug 22246] Elasticsearch indexing needs a maximum length for __sort fields In-Reply-To: <bug-22246-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22246-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22246-70-hIZ8wg4x3t@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22246 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 22:25:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 21:25:59 +0000 Subject: [Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead) In-Reply-To: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21756-70-AgZKaVbpxx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off --- Comment #104 from Nick Clemens <nick at bywatersolutions.com> --- Setting to SO for final QA pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 22:25:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 21:25:34 +0000 Subject: [Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead) In-Reply-To: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21756-70-MvHu4TkmOE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|josef.moravec at gmail.com |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 22:30:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 21:30:08 +0000 Subject: [Koha-bugs] [Bug 15774] Additional fields for baskets In-Reply-To: <bug-15774-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15774-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15774-70-6JxiM2LNlr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 22:34:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 21:34:35 +0000 Subject: [Koha-bugs] [Bug 22056] Remove test/search.pl In-Reply-To: <bug-22056-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22056-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22056-70-n2uEulo1lt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22056 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z Assignee|katrin.fischer at bsz-bw.de |hayleymapley at catalyst.net.n | |z Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 22:41:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 21:41:45 +0000 Subject: [Koha-bugs] [Bug 22056] Remove test/search.pl In-Reply-To: <bug-22056-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22056-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22056-70-Mvi7D8IYXf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22056 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW Assignee|hayleymapley at catalyst.net.n |koha-bugs at lists.koha-commun |z |ity.org --- Comment #1 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- sorry for the noise, mistake -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 22:59:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 21:59:44 +0000 Subject: [Koha-bugs] [Bug 15774] Additional fields for baskets In-Reply-To: <bug-15774-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15774-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15774-70-UOoRrEWmMM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed by Module Maintainer |Pushed to Master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 23:15:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 22:15:09 +0000 Subject: [Koha-bugs] [Bug 22423] Delete button for circulation note in Details screen In-Reply-To: <bug-22423-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22423-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22423-70-s3ZHJuc9YK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22423 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|17.11 |master CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 23:24:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 22:24:41 +0000 Subject: [Koha-bugs] [Bug 14672] Payment is not able to done, when the patron has credit balance In-Reply-To: <bug-14672-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14672-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14672-70-5qK8kZQNLN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14672 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Component|Patrons |Fines and fees --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think this issue might have been fixed as part of the Accounts work. Adding Martin to confirm. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 23:26:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 22:26:37 +0000 Subject: [Koha-bugs] [Bug 3607] Lost item returned credit to borrower - but can't resolve credit In-Reply-To: <bug-3607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-3607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3607-70-FqE9VTccFM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3607 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I believe this has been fixed in recent versions (check AccountAutoReconcile system preference). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 23:26:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 22:26:49 +0000 Subject: [Koha-bugs] [Bug 3607] Lost item returned credit to borrower - but can't resolve credit In-Reply-To: <bug-3607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-3607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3607-70-oyAwajRWIy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3607 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Circulation |Fines and fees -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 23:33:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 22:33:03 +0000 Subject: [Koha-bugs] [Bug 20890] Can't locate Koha/Template/Plugin/String.pm error In-Reply-To: <bug-20890-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20890-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20890-70-dfj7RSoXKx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20890 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- There is not enough information here to reproduce the error and provide a fix. Closing, please reopen with more information if problem still exists. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 23:36:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 22:36:29 +0000 Subject: [Koha-bugs] [Bug 8613] Patron Messaging Preferences Template falsely states that Category Level Preferences are Applied to Patron In-Reply-To: <bug-8613-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8613-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8613-70-D6ol0wlaOm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8613 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I can't find a message like this in current versions. I assume this has been fixed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 23:40:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 22:40:11 +0000 Subject: [Koha-bugs] [Bug 8450] IndependantBranches prevents superlibrarians from checking in transfers In-Reply-To: <bug-8450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8450-70-121TfwMsNj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8450 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- David, is this a duplicate of the newer bug 10300? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 7 23:43:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 22:43:51 +0000 Subject: [Koha-bugs] [Bug 21997] SIP patron information requests can lock patron out of account In-Reply-To: <bug-21997-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21997-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21997-70-IlrVxJRoQM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21997 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #14 from Lucas Gass <lucas at bywatersolutions.com> --- backported to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 00:08:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 23:08:53 +0000 Subject: [Koha-bugs] [Bug 21772] Add holds information tab to the SCO module In-Reply-To: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21772-70-vPKZlkkh4Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 --- Comment #2 from Agust?n Moyano <agustinmoyano at theke.io> --- Created attachment 86332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86332&action=edit Bug 21772: (follow-up) QA failed because old bootstrap button class -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 00:08:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 23:08:56 +0000 Subject: [Koha-bugs] [Bug 21772] Add holds information tab to the SCO module In-Reply-To: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21772-70-OpmiM6wc8I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 --- Comment #3 from Agust?n Moyano <agustinmoyano at theke.io> --- Created attachment 86333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86333&action=edit Bug 21772: Add holds and account information to SCO This patch introduces holds and account information to the SCO page. It uses the introduced include files that are also used in OPAC (opac-user.pl and opac-account.pl). To test: 1) Have a patron that has holds and account lines 2) Enable the SCO module 3) Use the patron's cardnumber to get to its details => SUCCESS: New tabs are presented, and they display holds and account information as expected 4) Sign off :-D Sponsored-by: City of Portsmouth Public Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 00:09:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 23:09:00 +0000 Subject: [Koha-bugs] [Bug 21772] Add holds information tab to the SCO module In-Reply-To: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21772-70-LXwfxp7VH4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 --- Comment #4 from Agust?n Moyano <agustinmoyano at theke.io> --- Created attachment 86334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86334&action=edit Bug 21772: (follow-up) Remove redundant variable Sponsored-by: City of Portsmouth Public Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 00:08:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 23:08:50 +0000 Subject: [Koha-bugs] [Bug 21772] Add holds information tab to the SCO module In-Reply-To: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21772-70-3k3xhcwLwE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 --- Comment #1 from Agust?n Moyano <agustinmoyano at theke.io> --- Created attachment 86331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86331&action=edit Bug 21772: Move OPAC holds and account tables into .inc This patch moves the code to render the account and holds information for the patron into include files. They are loaded in the opac-user.tt and opac-account.tt templates respectively. To test: 1) Have a patron with account lines and holds 2) Notice they are displayed in the patron's detail section in the OPAC 3) Apply this patch 4) Reload the patron's detail page => SUCESS: Everything looks the same, no behaviuor or layout change. 5) Sign off Sponsored-by: City of Portsmouth Public Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 00:12:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 23:12:39 +0000 Subject: [Koha-bugs] [Bug 21772] Add holds information tab to the SCO module In-Reply-To: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21772-70-DPf1YjEsYT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 Agust?n Moyano <agustinmoyano at theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 00:14:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 23:14:42 +0000 Subject: [Koha-bugs] [Bug 21772] Add holds information tab to the SCO module In-Reply-To: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21772-70-HynLwuqSA2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 Agust?n Moyano <agustinmoyano at theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 00:23:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 23:23:11 +0000 Subject: [Koha-bugs] [Bug 21692] Koha::Account->new has no tests In-Reply-To: <bug-21692-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21692-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21692-70-CNHkKGj74p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21692 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #12 from Lucas Gass <lucas at bywatersolutions.com> --- backported to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 00:49:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Mar 2019 23:49:47 +0000 Subject: [Koha-bugs] [Bug 22479] New: Unnecessary translation occurs when adding a new serial subscription Message-ID: <bug-22479-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22479 Bug ID: 22479 Summary: Unnecessary translation occurs when adding a new serial subscription Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: hayleymapley at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Target Milestone: --- In the staff client, Home > Serials > New subscription - Add a new subscription (2/2), the Frequency dropdown lists Annuel as an option - this should be spelt Annual. Further down in the same form, Ann?e is written. I have fr-FR and fr-CA translations enabled, but the language is currently set to English and the rest of the page is in English. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 01:43:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 00:43:57 +0000 Subject: [Koha-bugs] [Bug 21953] Term "Lost item" untranslatable In-Reply-To: <bug-21953-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21953-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21953-70-pTzt1yNZlX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |hayleymapley at catalyst.net.n | |z --- Comment #10 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Patch doesn't apply. Applying: Bug 21953: Term 'Lost item' untranslatable Applying: Bug 21953: Add tests Using index info to reconstruct a base tree... M t/db_dependent/Circulation.t Falling back to patching base and 3-way merge... Auto-merging t/db_dependent/Circulation.t CONFLICT (content): Merge conflict in t/db_dependent/Circulation.t error: Failed to merge in the changes. Patch failed at 0001 Bug 21953: Add tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 01:52:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 00:52:26 +0000 Subject: [Koha-bugs] [Bug 19938] C4::Overdues::checkoverdues has inconsistent return type In-Reply-To: <bug-19938-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19938-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19938-70-E0ooezJUCK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19938 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |hayleymapley at catalyst.net.n | |z --- Comment #29 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- t/db_dependent/www/search_utf8.t failed - t/db_dependent/www/search_utf8.t .. Warning: <retrieval> element has non-unique value in 'name' key attribute: F at t/db_dependent/www/search_utf8.t line 43. Warning: <retrieval> element has non-unique value in 'name' key attribute: B at t/db_dependent/www/search_utf8.t line 43. t/db_dependent/www/search_utf8.t .. 1/99 Link not found at t/db_dependent/www/search_utf8.t line 145. # Looks like your test exited with 255 just after 3. t/db_dependent/www/search_utf8.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 96/99 subtests Test Summary Report ------------------- t/db_dependent/www/search_utf8.t (Wstat: 65280 Tests: 3 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 99 tests but ran 3. Files=1, Tests=3, 4 wallclock secs ( 0.01 usr 0.00 sys + 0.83 cusr 0.10 csys = 0.94 CPU) Result: FAIL As this test passing is part of the outlined test plan, I have marked as Failed QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 02:05:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 01:05:21 +0000 Subject: [Koha-bugs] [Bug 20357] Pod Coverage checking for no public subs In-Reply-To: <bug-20357-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20357-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20357-70-kNABG3OEUJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20357 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z --- Comment #6 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- It looks like this isn't necessary anymore, at step 2 of the test plan the tests did not fail. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 02:07:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 01:07:01 +0000 Subject: [Koha-bugs] [Bug 20357] Pod Coverage checking for no public subs In-Reply-To: <bug-20357-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20357-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20357-70-w32XiCjGor@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20357 --- Comment #7 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- (In reply to Hayley Mapley from comment #6) > It looks like this isn't necessary anymore, at step 2 of the test plan the > tests did not fail. Actually, on second look the first patch of 19929 did not apply cleanly. I'll request a rebase and then test this again if you deem it still necessary. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 02:08:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 01:08:13 +0000 Subject: [Koha-bugs] [Bug 20357] Pod Coverage checking for no public subs In-Reply-To: <bug-20357-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20357-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20357-70-uFloQgT9ux@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20357 --- Comment #8 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- (In reply to Hayley Mapley from comment #6) > It looks like this isn't necessary anymore, at step 2 of the test plan the > tests did not fail. Actually, on second look the first patch of 19929 did not apply cleanly. I'll request a rebase and then test this again if you deem it still necessary.(In reply to Hayley Mapley from comment #7) > (In reply to Hayley Mapley from comment #6) > > It looks like this isn't necessary anymore, at step 2 of the test plan the > > tests did not fail. > > Actually, on second look the first patch of 19929 did not apply cleanly. > I'll request a rebase and then test this again if you deem it still > necessary. I now see that it's been pushed to master, so nevermind. Sorry for the noise everyone. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 02:40:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 01:40:06 +0000 Subject: [Koha-bugs] [Bug 22385] Itemslost report does not sort date properly in uk format (dd/mm/yyyy) In-Reply-To: <bug-22385-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22385-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22385-70-ktuKLhDIY7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22385 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z Status|Needs Signoff |Failed QA --- Comment #2 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- When I do steps 1-3 the dates appear to be in the correct order. Are you sure this patch is needed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 02:51:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 01:51:44 +0000 Subject: [Koha-bugs] [Bug 20971] additem Corrupted storable string In-Reply-To: <bug-20971-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20971-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20971-70-dcCmDeAdsr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20971 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z --- Comment #4 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Bump, any test plan to follow for this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 03:19:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 02:19:55 +0000 Subject: [Koha-bugs] [Bug 17236] Add minute and hours to last checked out item display for hourly loans In-Reply-To: <bug-17236-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17236-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17236-70-NCiEnlHnWd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17236 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> --- backported to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 03:22:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 02:22:14 +0000 Subject: [Koha-bugs] [Bug 16276] When automatically deleting expired borrowers, make sure they didn't log in recently In-Reply-To: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16276-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16276-70-u5nxugwVNN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16276 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #50 from Lucas Gass <lucas at bywatersolutions.com> --- skipping enhancement for 18.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 03:25:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 02:25:16 +0000 Subject: [Koha-bugs] [Bug 21263] Pickup library not set correctly when using Default holds policy by item type In-Reply-To: <bug-21263-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21263-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21263-70-5eDHeEOYiM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21263 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84846|0 |1 is obsolete| | --- Comment #2 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Created attachment 86335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86335&action=edit Bug 21263: Pickup library not set correctly when using Default holds policy In the case of a specific item hold, it can only be fulfilled if the pickup library matches the hold fulfillment policy. Therefore, if OPACAllowUserToChooseBranch is set to don't allow, the pickup library should correspond to the policy. In case of hold that does not specify an item, the homebranch or holdingbranch can't be determined at this time, so the pickup library still defaults to the homebranch of the borrower. Same if there is no policy or it states 'any'. To test: - Make sure OPACAllowUserToChooseBranch is set to don't allow - Make sure you have two branches A and B - Have one item whose homebranch is B - Have one user whose homebranch is A - Make sure the circulation rules allow the user to reserve the item's item type 1. Go to Administration > Circulation and fines rules 2. Create a Default holds policy by item type for that item type - Item type = item's item type - Hold policy = From any library - Hold pickup library match = item's home library - Return policy = item returns home 3. Go to the OPAC and log in with the user's credentials 4. Search for the item 5. Click on "Place hold" 6. Select a specific item and confirm hold 7. In the user's file on the OPAC and check the reservation's pickup library. It should be the item's homebranch You can then repeat the steps for 'item's holding library' or 'any library' as the Hold pickup library match. It should also work the same way if there is no 'Default holds policy by item type' for this item type but a 'Default checkout, hold and return policy' set. Finally, check that placing a hold without selecting a specific item still defaults the pickup library to the borrower's homebranch. Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 03:25:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 02:25:13 +0000 Subject: [Koha-bugs] [Bug 21263] Pickup library not set correctly when using Default holds policy by item type In-Reply-To: <bug-21263-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21263-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21263-70-2CQs6IkioY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21263 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 03:28:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 02:28:31 +0000 Subject: [Koha-bugs] [Bug 21530] overdue_notices.pl aborting because error is not caught In-Reply-To: <bug-21530-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21530-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21530-70-svO9LoKEck@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21530 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z --- Comment #2 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- (In reply to Colin Campbell from comment #1) > Created attachment 80326 [details] [review] > Patch to test a valid object returned > > Adds a run-time test to ensure the assumption of the following code is true. > Without the patch process aborts on call to branchemail method. > > With patch applied if find fails to return a valid library we skip to the > next and issue an error listing the problematic branchcode > > As we dont live in the "best of all possible worlds" code should be more > pessimistic and test for unexpected results Hi, is there some test plan for this patch? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 03:31:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 02:31:50 +0000 Subject: [Koha-bugs] [Bug 21580] Order creation for edifact vendor fails In-Reply-To: <bug-21580-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21580-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21580-70-EdH19GqTM1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21580 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z --- Comment #3 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- (In reply to Colin Campbell from comment #2) > Created attachment 80663 [details] [review] > pass the buyer_ean to order routine > > Call of the subroutine now matchs documentation and passes parameter > validation Hi, is there a test plan for this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 03:39:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 02:39:26 +0000 Subject: [Koha-bugs] [Bug 18738] Koha_Elasticsearch_Indexer.t fails if Elasticsearch is configured but not running In-Reply-To: <bug-18738-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18738-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18738-70-kNZItNW1q7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18738 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 03:39:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 02:39:14 +0000 Subject: [Koha-bugs] [Bug 18738] Koha_Elasticsearch_Indexer.t fails if Elasticsearch is configured but not running In-Reply-To: <bug-18738-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18738-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18738-70-In54RHJY13@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18738 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z --- Comment #3 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Patch doesn't apply Applying: Bug 18738: Improve failure cases to skip better Using index info to reconstruct a base tree... A t/db_dependent/Koha_Elasticsearch_Indexer.t Falling back to patching base and 3-way merge... CONFLICT (modify/delete): t/db_dependent/Koha_Elasticsearch_Indexer.t deleted in HEAD and modified in Bug 18738: Improve failure cases to skip better. Version Bug 18738: Improve failure cases to skip better of t/db_dependent/Koha_Elasticsearch_Indexer.t left in tree. error: Failed to merge in the changes. Patch failed at 0001 Bug 18738: Improve failure cases to skip better -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 06:51:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 05:51:18 +0000 Subject: [Koha-bugs] [Bug 8613] Patron Messaging Preferences Template falsely states that Category Level Preferences are Applied to Patron In-Reply-To: <bug-8613-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8613-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8613-70-RZ7fPx7JUD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8613 --- Comment #2 from David Cook <dcook at prosentient.com.au> --- (In reply to Katrin Fischer from comment #1) > I can't find a message like this in current versions. I assume this has been > fixed. It's been a long time since I looked so you're probably right -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 07:17:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 06:17:47 +0000 Subject: [Koha-bugs] [Bug 21683] Remove accountlines.accountno In-Reply-To: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21683-70-dRM2Ehpcjq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #40 from Josef Moravec <josef.moravec at gmail.com> --- It is not finished yet, the last follow-up is not enough, there is occurence of proccode in: koha-tmpl/intranet-tmpl/prog/en/columns.def t/db_dependent/Stats.t - test if proccode is undef could be removed i think -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 07:25:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 06:25:32 +0000 Subject: [Koha-bugs] [Bug 21683] Remove accountlines.accountno In-Reply-To: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21683-70-DUKBS5KcTu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 --- Comment #41 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86336&action=edit Bug 21683: (follow-up) Remove last occurences of statistics.proccode columns.def is used to define descriptions of db columns in guided reports test is not useful anymore IMO -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 07:28:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 06:28:07 +0000 Subject: [Koha-bugs] [Bug 21683] Remove accountlines.accountno In-Reply-To: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21683-70-nMz1QPXYlB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 07:31:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 06:31:38 +0000 Subject: [Koha-bugs] [Bug 22274] Self-checkout/checkin pages not covered by OPAC CSS changes In-Reply-To: <bug-22274-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22274-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22274-70-FIPMUSDOy9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22274 --- Comment #5 from Claire Gravely <claire_gravely at hotmail.com> --- Hi, sorry, it is on my to do list. I was on leave and have a busy couple of weeks coming up but will try and get it done ASAP! Thanks for pointing it out! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 07:34:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 06:34:24 +0000 Subject: [Koha-bugs] [Bug 18303] Release team omnibus In-Reply-To: <bug-18303-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18303-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18303-70-grzLzYLC4m@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18303 --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Owen Leonard from comment #1) > Is this bug still valid? Yes. It is an omnibus. I attach a new one for each release team. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 07:54:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 06:54:17 +0000 Subject: [Koha-bugs] [Bug 18738] Koha_Elasticsearch_Indexer.t fails if Elasticsearch is configured but not running In-Reply-To: <bug-18738-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18738-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18738-70-LBjOaSsA0r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18738 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Hayley, if a patch doesn't apply, you can use the status "Patch doesn't apply" . Thx for your testing! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 08:00:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 07:00:17 +0000 Subject: [Koha-bugs] [Bug 22385] Itemslost report does not sort date properly in uk format (dd/mm/yyyy) In-Reply-To: <bug-22385-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22385-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22385-70-YVUhGdzFlj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22385 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |FIXED CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- It appears this has already been fixed on master! <th class="title-string">Date last seen</th> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 08:04:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 07:04:59 +0000 Subject: [Koha-bugs] [Bug 22479] Unnecessary translation occurs when adding a new serial subscription In-Reply-To: <bug-22479-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22479-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22479-70-GWoUZHdSvj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22479 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Hayley, I think these come from your database. Check serials > Manage frequencies. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 08:08:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 07:08:02 +0000 Subject: [Koha-bugs] [Bug 20639] Allow setting a default/single backend for OPAC driven requests In-Reply-To: <bug-20639-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20639-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20639-70-4tFOuQQFeY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 08:08:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 07:08:15 +0000 Subject: [Koha-bugs] [Bug 20639] Allow setting a default/single backend for OPAC driven requests In-Reply-To: <bug-20639-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20639-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20639-70-WVNi7cygpL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 08:08:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 07:08:59 +0000 Subject: [Koha-bugs] [Bug 20639] Allow setting a default/single backend for OPAC driven requests In-Reply-To: <bug-20639-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20639-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20639-70-DZ8pnIezgX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 08:09:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 07:09:00 +0000 Subject: [Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events In-Reply-To: <bug-20750-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20750-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20750-70-nNHWmvHbHs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750 Bug 20750 depends on bug 20639, which changed state. Bug 20639 Summary: Allow setting a default/single backend for OPAC driven requests https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639 What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 08:09:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 07:09:39 +0000 Subject: [Koha-bugs] [Bug 22442] Item search CSV export broken In-Reply-To: <bug-22442-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22442-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22442-70-dgoVAF9ioy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22442 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 08:09:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 07:09:42 +0000 Subject: [Koha-bugs] [Bug 22442] Item search CSV export broken In-Reply-To: <bug-22442-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22442-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22442-70-ASImZmrdbV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22442 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86026|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 86337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86337&action=edit Bug 22442: (bug 13618 follow-up) Fix item search CSV export We must not filter assignements statements. Test plan: Export item search result as CSV Without this patch the biblio and biblioitem values are not displayed. With this patch applied everything is displayed correctly Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 08:14:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 07:14:17 +0000 Subject: [Koha-bugs] [Bug 21049] Rancor 007 field does not retain value In-Reply-To: <bug-21049-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21049-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21049-70-wopkJ8270q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21049 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|17.11 |master Status|Signed Off |Failed QA Severity|normal |major --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I am sorry Julian, but this doesn't appear to work for me. - Open Advanced catalog editor - Select first value of 007 (ER) - Try to save (error about missing mandatory) - 007 is reset to BKS Updating severity of this bug - data loss. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 08:18:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 07:18:31 +0000 Subject: [Koha-bugs] [Bug 22422] improve item location display with class "shelvingloc" In-Reply-To: <bug-22422-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22422-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22422-70-X0YWVPTKMx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22422 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 08:18:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 07:18:35 +0000 Subject: [Koha-bugs] [Bug 22422] improve item location display with class "shelvingloc" In-Reply-To: <bug-22422-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22422-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22422-70-rbn28YFb8F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22422 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86280|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 86338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86338&action=edit Bug 22422: improve item location display with class "shelvingloc" In record detail page, item location is displayed with CSS using class "shelvingloc". Many many places at intranet and OPAC can use this class. It allows to change display in all places using CSS customisation. This patch removes the CSS "display:block" for class "shelvingloc". Some places where using "inline" to correct the display. I think the display should not be managed in template. So it will be inline by default and it can be changed by custom CSS, on all places or depending on a selctor. Test plan : 1) Compile SCSS to CSS 2) Add to preferences IntranetUserCSS and OPACUserCSS : .shelvingloc { color:red } 3) Go to pages impacted by patch, be sure to look at cart with "more details" 4) You see item location italic and red Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 08:22:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 07:22:13 +0000 Subject: [Koha-bugs] [Bug 22452] Typos in add a comment to Mana modal In-Reply-To: <bug-22452-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22452-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22452-70-GWexVel3uX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22452 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 08:22:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 07:22:16 +0000 Subject: [Koha-bugs] [Bug 22452] Typos in add a comment to Mana modal In-Reply-To: <bug-22452-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22452-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22452-70-Y3Sj5LX3RP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22452 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86242|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 86339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86339&action=edit Bug 22452: Fix typos in add mana comment modals There are typos in modal where you can add a comment to mana: 'caracters' should be 'characters' 'commment' should be 'comment' Test plan: 1) Create subscription from Mana 2) On subscription detail page: report mistake > other a modal is shown --> without patch it reads 'Please enter a new commment (max 35 caracters)' --> with patch it reads 'Please enter a new comment (max 35 characters)' 3) The same in mana search resultss and in reports Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 08:23:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 07:23:36 +0000 Subject: [Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images In-Reply-To: <bug-22445-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22445-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22445-70-tHe6F6hItl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Ability to define a url for |Ability to define a URL for |custom cover images |custom cover images -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 08:29:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 07:29:55 +0000 Subject: [Koha-bugs] [Bug 21354] When a serial issue is changed from arrived to expected, it remains as received in Brief history In-Reply-To: <bug-21354-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21354-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21354-70-AfYRdXDS5M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21354 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Inconsistent display of |When a serial issue is |available serials in OPAC |changed from arrived to |after changing received |expected, it remains as |status |received in Brief history Severity|enhancement |normal --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I can confirm the problem still appears. The information shown on the 'more details' page is stored in subscriptionhistory.recievedlist (typo included). Not sure how to fix this. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 08:37:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 07:37:06 +0000 Subject: [Koha-bugs] [Bug 22357] Every run of runreport.pl with --store-results creates a new row in saved reports In-Reply-To: <bug-22357-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22357-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22357-70-VBAdloIVic@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22357 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I suspect a problem with the group by somewhere. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 09:10:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 08:10:03 +0000 Subject: [Koha-bugs] [Bug 22480] New: itemtype/itype is used to join allot of tables, but often isn't defined as a key Message-ID: <bug-22480-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22480 Bug ID: 22480 Summary: itemtype/itype is used to join allot of tables, but often isn't defined as a key Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- The itype and itemtype fields in many tables refer to the itemtypes table but are not defined as foreign keys.. they should be to prevent data corruption. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 09:10:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 08:10:13 +0000 Subject: [Koha-bugs] [Bug 5334] add explicit foreign key constraints In-Reply-To: <bug-5334-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-5334-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5334-70-ChpvYq2YKd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22480 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22480 [Bug 22480] itemtype/itype is used to join allot of tables, but often isn't defined as a key -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 09:10:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 08:10:13 +0000 Subject: [Koha-bugs] [Bug 22480] itemtype/itype is used to join allot of tables, but often isn't defined as a key In-Reply-To: <bug-22480-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22480-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22480-70-1C1q5gxUOK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22480 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |5334 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 [Bug 5334] add explicit foreign key constraints -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 09:10:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 08:10:55 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18235-70-U707TH17jq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85983|0 |1 is obsolete| | Attachment #85984|0 |1 is obsolete| | Attachment #85985|0 |1 is obsolete| | Attachment #85986|0 |1 is obsolete| | Attachment #85987|0 |1 is obsolete| | Attachment #85988|0 |1 is obsolete| | Attachment #85989|0 |1 is obsolete| | Attachment #85990|0 |1 is obsolete| | Attachment #85991|0 |1 is obsolete| | Attachment #85992|0 |1 is obsolete| | --- Comment #72 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86340&action=edit Bug 18235: ES - Facets configurable This patch adds a new section 'Facet order' in the Biblio tab of the 'Search engine configuration' admin page of the Elastic mappings. The idea is to let the librarians define the facet to display and order them as their needs. The ergonomic is not perfect and I am open to any suggestions. Test plan: Move up and down the field list to order the facets Hide/show some facets Rebuild index At the OPAC and the staff interface you should see the changes on the search result page. Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 09:11:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 08:11:06 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18235-70-JgzOSylThn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #74 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86342&action=edit Bug 18235: DB changes Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 09:11:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 08:11:11 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18235-70-IY6q4nhvwt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #75 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86343&action=edit Bug 18235: Add unit tests for get_facetable_fields Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 09:11:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 08:11:16 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18235-70-msNEaXJepp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #76 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86344&action=edit Bug 18235: DBIx schema changes Fresh changes for SearchField, facet_order. Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 09:11:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 08:11:21 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18235-70-YVBYlKXAvD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #77 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86345&action=edit Bug 18235: (QA follow-up) Fix POD Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 09:11:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 08:11:26 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18235-70-FjfxKfOIQl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #78 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86346&action=edit Bug 18235: (QA follow-up) Add missing filters Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 09:11:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 08:11:01 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18235-70-sNhhtlCGJI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #73 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86341&action=edit Bug 18235: Add missing POD to get_facetable_fields Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 09:11:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 08:11:31 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18235-70-7lmfTZ6cYn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #79 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86347&action=edit Bug 18235: Update facet_order default value in atomic update Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 09:11:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 08:11:36 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18235-70-RQn0jBxhAn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #80 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86348&action=edit Bug 18235: Do not call get_facetable_fields excessively Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 09:11:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 08:11:41 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18235-70-kII1UNPcSk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #81 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86349&action=edit Bug 18235: (QA follow-up) Make db update idempotent Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 09:11:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 08:11:46 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18235-70-eRUAWuqWoY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #82 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86350&action=edit Bug 18235: (QA follow-up) Series facet name after rebase Bug 19575 changes many field names so "se" facet field became "title-series" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 09:20:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 08:20:01 +0000 Subject: [Koha-bugs] [Bug 22031] C4::Auth->haspermission should allow checking for more than one subpermission In-Reply-To: <bug-22031-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22031-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22031-70-cRQfo6u4Xw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22031 --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Hi Nick, Wow, really pleased to see this one going through.. I thought it might come up against a bit more opposition :). So.. you mention additional documentation.. did you have any thoughts on what you might like.. some examples in the POD perhaps or were you thinking something on the wiki? I'm happy to oblige. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 09:40:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 08:40:31 +0000 Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve aliased fields In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19575-70-R63bS1eHAS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com --- Comment #96 from Josef Moravec <josef.moravec at gmail.com> --- Why was su-geo facet field removed by this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 09:41:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 08:41:23 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18235-70-gswHX10nz7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |BLOCKED --- Comment #83 from Josef Moravec <josef.moravec at gmail.com> --- I rebased it and add a follow-up to adapt to 19575, just not sure what to do, with su-geo, look like it was removed in bug 1957... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 09:56:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 08:56:52 +0000 Subject: [Koha-bugs] [Bug 22275] 18.06.00.060 DB update fails (incomplete/incorrect defaults) In-Reply-To: <bug-22275-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22275-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22275-70-785NKDZpQK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22275 --- Comment #18 from Oliver Behnke <oliver.behnke at aei.mpg.de> --- Just to make sure: is this going to be pushed to 18.11 as well? I think it has to be. Thanks everyone! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 09:57:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 08:57:26 +0000 Subject: [Koha-bugs] [Bug 5334] Add explicit foreign key constraints In-Reply-To: <bug-5334-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-5334-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5334-70-hbKB7e3ENz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|add explicit foreign key |Add explicit foreign key |constraints |constraints -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 09:59:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 08:59:32 +0000 Subject: [Koha-bugs] [Bug 22274] Self-checkout/checkin pages not covered by OPAC CSS changes In-Reply-To: <bug-22274-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22274-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22274-70-6P9i2BSASb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22274 --- Comment #6 from Oliver Behnke <oliver.behnke at aei.mpg.de> --- Hi Claire, I didn't mean to be pushy if I came across like that. Just wanted to clarify any potential misunderstandings :-) Glad to have you back! Cheers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 10:03:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 09:03:56 +0000 Subject: [Koha-bugs] [Bug 14672] Payment is not able to done, when the patron has credit balance In-Reply-To: <bug-14672-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14672-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14672-70-ASY8g2GnGz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14672 --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Correct, I believe this is resolved as part of the accounts work. I'll dig out which bug and mark it as a duplicate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 10:05:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 09:05:32 +0000 Subject: [Koha-bugs] [Bug 14672] Payment is not able to done, when the patron has credit balance In-Reply-To: <bug-14672-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14672-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14672-70-qhmezLDUXF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14672 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Failed QA |RESOLVED --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- *** This bug has been marked as a duplicate of bug 18805 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 10:05:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 09:05:32 +0000 Subject: [Koha-bugs] [Bug 18805] Currently it is impossible to apply credits against debits in patron accounts In-Reply-To: <bug-18805-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18805-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18805-70-TmK7BWULbW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18805 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |deepakkv10 at gmail.com --- Comment #31 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- *** Bug 14672 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 10:18:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 09:18:49 +0000 Subject: [Koha-bugs] [Bug 22275] 18.06.00.060 DB update fails (incomplete/incorrect defaults) In-Reply-To: <bug-22275-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22275-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22275-70-noZ4dE4pux@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22275 --- Comment #19 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Oliver Behnke from comment #18) > Just to make sure: is this going to be pushed to 18.11 as well? I think it > has to be. > > Thanks everyone! RMaints have the final decision, but since this is marked as a major bug and appears int he older versions, this will be considered (all bugs usually are, while enhancements are not). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 10:19:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 09:19:34 +0000 Subject: [Koha-bugs] [Bug 22481] New: Koha::Uploader does not work under Plack Message-ID: <bug-22481-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22481 Bug ID: 22481 Summary: Koha::Uploader does not work under Plack Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- The use of Plack reveled that the use of CGI hook is not allowed, see Bug 15218. Looks like this is used by Koha::Uploader::cgi() : my $query = CGI::->new( sub { $self->_hook(@_); }, {}, 0 ); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 10:19:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 09:19:56 +0000 Subject: [Koha-bugs] [Bug 21772] Add holds and account information tab to the SCO module In-Reply-To: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21772-70-GZq8lePigo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add holds information tab |Add holds and account |to the SCO module |information tab to the SCO | |module -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 10:20:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 09:20:33 +0000 Subject: [Koha-bugs] [Bug 21049] Rancor 007 field does not retain value In-Reply-To: <bug-21049-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21049-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21049-70-NgzfKiWdFg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21049 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86218|0 |1 is obsolete| | --- Comment #4 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 86351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86351&action=edit Bug 21049: Fix value of material select for Rancor 007 widget The material type is selected in accordance with position 0 of 007 Test plan: 1. Create a new record using the advanced editor 2. Select a material type for field 007 and set at least the position 0 of this field 3. Save the record and reload the page 4. The material type should remain selected 5. Try with all available material types -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 10:20:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 09:20:36 +0000 Subject: [Koha-bugs] [Bug 21049] Rancor 007 field does not retain value In-Reply-To: <bug-21049-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21049-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21049-70-ky4xWM4OgW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21049 --- Comment #5 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 86352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86352&action=edit Bug 21049: Set 007/00 when selecting material type (Rancor) There is a 1-1 relationship between the material type values and the position 00 of 007 field. Selecting a material type should set this position's value. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 10:28:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 09:28:42 +0000 Subject: [Koha-bugs] [Bug 21049] Rancor 007 field does not retain value In-Reply-To: <bug-21049-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21049-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21049-70-zU5VJHJJtb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21049 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> --- (In reply to Katrin Fischer from comment #3) > I am sorry Julian, but this doesn't appear to work for me. > > - Open Advanced catalog editor > - Select first value of 007 (ER) > - Try to save (error about missing mandatory) > - 007 is reset to BKS > > Updating severity of this bug - data loss. If I understand correctly, you didn't set manually the position 0 of field 007 (the first select is not bound to any MARC data, it just modifies the editor line display). I added a patch that automatically set position 0 automatically, so this should work as expected now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 10:33:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 09:33:30 +0000 Subject: [Koha-bugs] [Bug 22481] Koha::Uploader does not work under Plack In-Reply-To: <bug-22481-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22481-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22481-70-iOyXnJ8Qpr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22481 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15218 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 10:33:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 09:33:30 +0000 Subject: [Koha-bugs] [Bug 15218] Make processes that rely on background jobs run in CGI mode In-Reply-To: <bug-15218-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15218-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15218-70-ffrnY7UsH0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15218 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22481 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 10:38:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 09:38:50 +0000 Subject: [Koha-bugs] [Bug 22420] Tag cloud feature broken In-Reply-To: <bug-22420-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22420-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22420-70-gF8jg1i62O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22420 --- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- (In reply to Jonathan Druart from comment #5) > What you are suggesting is temporary and must be fixed, right? After looking at this and having feedback on koha-devel I can say the 'feature' of hiding tags for hidden bibliographic records (due to OpacHiddenItems modulo OpacHiddenExceptions) is broken altogether. i.e. The calculation is wrong anyway and the loop doesn't generate a suitable data structure either. I prefer my approach to solve the immediate issue (no tags are hidden anyway, just wrongly displayed), and file a separate bug for the leakage bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 10:39:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 09:39:42 +0000 Subject: [Koha-bugs] [Bug 22023] Further improve responsive layout handling of staff client menu bar In-Reply-To: <bug-22023-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22023-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22023-70-o39gFM0gAw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22023 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | --- Comment #7 from Josef Moravec <josef.moravec at gmail.com> --- Owen, this looks great. But i found some issues when switched to rtl language: the menu and menu button (on smaller screen) is rendered over user menu. also, koha logo does not change position to center as when using ltr language. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 10:41:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 09:41:02 +0000 Subject: [Koha-bugs] [Bug 22481] Koha::Uploader does not work under Plack In-Reply-To: <bug-22481-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22481-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22481-70-hjy7RpaDCa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22481 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22417 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 10:41:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 09:41:02 +0000 Subject: [Koha-bugs] [Bug 22417] Delegate background jobs execution In-Reply-To: <bug-22417-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22417-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22417-70-3DM9zgmhcV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22481 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 10:42:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 09:42:23 +0000 Subject: [Koha-bugs] [Bug 22481] Koha::Uploader does not work under Plack In-Reply-To: <bug-22481-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22481-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22481-70-0egvwGFZYJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22481 --- Comment #1 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- I must say failure is random on file upload. Large files seams to make it worth. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 10:54:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 09:54:36 +0000 Subject: [Koha-bugs] [Bug 21772] Add holds and account information tab to the SCO module In-Reply-To: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21772-70-XFDsOH8CPm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- *** Bug 9047 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 10:54:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 09:54:36 +0000 Subject: [Koha-bugs] [Bug 9047] show hold info on self check out In-Reply-To: <bug-9047-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9047-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9047-70-9xZPKbeQjE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9047 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- *** This bug has been marked as a duplicate of bug 21772 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 11:10:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 10:10:44 +0000 Subject: [Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13937-70-e1D9YqZ1Ta@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84062|0 |1 is obsolete| | --- Comment #121 from Ere Maijala <ere.maijala at helsinki.fi> --- Created attachment 86353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86353&action=edit Bug 13937: Add a Z39.50 daemon that can inject item status MARC subfields This creates a new daemon, misc/z3950_responder.pl, which can respond to Z39.50 requests. By default, it just proxies searches to Zebra. If desired, however, it can also add a subfield to the item tags on outgoing records with a textual description of the item's status (checked out, lost, etc.). This is useful for certain ILL systems. These strings can be translated using the 'Z3950_STATUS' authorized value. Test plan: 1) Start the Z39.50 server using `perl misc/z3950_responder.pl`. 2) Connect to the server using `yaz-client 127.0.0.1:9999/biblios`. 3) Run a search, such as `find @attr 1=1016 book`. 4) Fetch the results both one at a time with `show 1` and in a batch using `show 1+5`. 5) Turn on MARCXML using `format xml` and `elements marcxml`, and verify that the records are still correctly fetched. 6) Enable the item status subfield by restarting the server with the option `--add-item-status=k`. 7) Search for and fetch records, and verify that a $k subfield is added to the item tags as appropriate. It should show some combination of "Checked Out", "Lost", "Not For Loan", "Damaged", "Withdrawn", "In Transit", or "On Hold" as appropriate, or "Available". 8) Add an authorized value named "Z3950_STATUS" with any of the keys "AVAILABLE", "CHECKED_OUT", "LOST", "NOT_FOR_LOAN", "DAMAGED", "WITHDRAWN", "IN_TRANSIT" or "ON_HOLD", and verify that their descriptions are used instead of the default values above. Signed-off-by: George Williams <george at nekls.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 11:10:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 10:10:50 +0000 Subject: [Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13937-70-UGlzQvhTJJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84063|0 |1 is obsolete| | --- Comment #122 from Ere Maijala <ere.maijala at helsinki.fi> --- Created attachment 86354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86354&action=edit Bug 13937: (follow-up) Remove reference to sub _prefetch_records Remove reference to sub _prefetch_records It appears this sub is built into fetch and this call is a duplicate Signed-off-by: George Williams <george at nekls.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 11:10:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 10:10:55 +0000 Subject: [Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13937-70-XMwZOmYfAi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84064|0 |1 is obsolete| | --- Comment #123 from Ere Maijala <ere.maijala at helsinki.fi> --- Created attachment 86355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86355&action=edit Bug 13937: (follow-up) Correct error call to use self -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 11:11:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 10:11:01 +0000 Subject: [Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13937-70-VSI69A1zKJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84065|0 |1 is obsolete| | --- Comment #124 from Ere Maijala <ere.maijala at helsinki.fi> --- Created attachment 86356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86356&action=edit Bug 13937: Add unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 11:11:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 10:11:07 +0000 Subject: [Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13937-70-YVDbPQdn4A@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84066|0 |1 is obsolete| | --- Comment #125 from Ere Maijala <ere.maijala at helsinki.fi> --- Created attachment 86357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86357&action=edit Bug 13937: (follow-up) Pass through yaz switches and don't ignore case -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 11:11:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 10:11:12 +0000 Subject: [Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13937-70-Q11nPPlGjp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84067|0 |1 is obsolete| | --- Comment #126 from Ere Maijala <ere.maijala at helsinki.fi> --- Created attachment 86358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86358&action=edit Bug 13937: Fix issues found in QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 11:11:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 10:11:18 +0000 Subject: [Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13937-70-ZbcUWc23m3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84068|0 |1 is obsolete| | --- Comment #127 from Ere Maijala <ere.maijala at helsinki.fi> --- Created attachment 86359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86359&action=edit Bug 13937: Add support for SRU and Elasticsearch Splits Session to GenericSession and ZebraSession where Generic supports any search backend via the SearchEngine classes and Zebra maintains the direct channel to the Zebra server. Adds config files required for mapping BIB-1 attributes to Koha search fields and SRU indexes to BIB-1 attributes. Adds PODs. Sponsored-by: National Library of Finland -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 11:11:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 10:11:24 +0000 Subject: [Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13937-70-9mlSBd4qsz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84069|0 |1 is obsolete| | --- Comment #128 from Ere Maijala <ere.maijala at helsinki.fi> --- Created attachment 86360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86360&action=edit Bug 13937: Add tests for search and retrieval Sponsored-by: National Library of Finland -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 11:11:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 10:11:30 +0000 Subject: [Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13937-70-7hnEHCBx88@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84072|0 |1 is obsolete| | --- Comment #129 from Ere Maijala <ere.maijala at helsinki.fi> --- Created attachment 86361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86361&action=edit Bug 13937: Fix RPN conversion Fixes handling of parenthesis and removes unused quote handling. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 11:11:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 10:11:35 +0000 Subject: [Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13937-70-FN9EVi4MNQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84073|0 |1 is obsolete| | --- Comment #130 from Ere Maijala <ere.maijala at helsinki.fi> --- Created attachment 86362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86362&action=edit Bug 13937: Add support for Z39.50 responder to the Debian scripts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 11:11:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 10:11:41 +0000 Subject: [Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13937-70-ji9cWa169v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 --- Comment #131 from Ere Maijala <ere.maijala at helsinki.fi> --- Created attachment 86363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86363&action=edit Bug 13937: Fix the daemon log path. directory _LOG_DIR_/logs does't exists. All other log4perl -logs are out to _LOG_DIR_ Thank you for the good work Ere! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 11:11:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 10:11:47 +0000 Subject: [Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13937-70-0yNnRosxy7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 --- Comment #132 from Ere Maijala <ere.maijala at helsinki.fi> --- Created attachment 86364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86364&action=edit Bug 13937: Switch from GetItem() to Koha::Items->find() -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 11:12:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 10:12:34 +0000 Subject: [Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13937-70-U9MPUUqtDx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #133 from Ere Maijala <ere.maijala at helsinki.fi> --- Fixed the GetItem issue and a couple of pod errors. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 11:12:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 10:12:34 +0000 Subject: [Koha-bugs] [Bug 17509] Notify patrons to return items requested on hold by another person In-Reply-To: <bug-17509-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17509-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17509-70-tRufISIUKI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80452|0 |1 is obsolete| | Attachment #80453|0 |1 is obsolete| | Attachment #80454|0 |1 is obsolete| | Attachment #80455|0 |1 is obsolete| | Attachment #80456|0 |1 is obsolete| | Attachment #80457|0 |1 is obsolete| | Attachment #80458|0 |1 is obsolete| | Attachment #80459|0 |1 is obsolete| | Attachment #80460|0 |1 is obsolete| | Attachment #80461|0 |1 is obsolete| | --- Comment #55 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86365&action=edit Bug 17509: Added NotifyToReturnItemWhenHoldIsPlaced syspref This system preference will allow to ask patrons to return items whenever a new hold is placed on them Test plan: 1) Open System preferences / Circulation / Holds Policy 2) Change value from Enable to Don't enable and vice versa 3) Check NotifyToReturnItemWhenHoldIsPlaced is changed in database 4) change which patrons will be contacted 5) compare your change against database value NotifyToReturnItemFromLibrary Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 11:12:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 10:12:39 +0000 Subject: [Koha-bugs] [Bug 17509] Notify patrons to return items requested on hold by another person In-Reply-To: <bug-17509-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17509-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17509-70-sAoK291evK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #56 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86366&action=edit Bug 17509: Added notification letter HOLDPLACED_CONTACT Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 11:12:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 10:12:44 +0000 Subject: [Koha-bugs] [Bug 17509] Notify patrons to return items requested on hold by another person In-Reply-To: <bug-17509-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17509-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17509-70-seceDeyo9T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #57 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86367&action=edit Bug 17509: notify patrons to return an item whenever a hold is placed on it Test plan: 1) apply patch 2) run database update 3) enable sending an email to the patrons to return an item whenever a hold request is placed on it 4) place a hold 5) patrons having checked-out the item on hold are notified by email (see HOLDPLACED_CONTACT letter) Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 11:12:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 10:12:48 +0000 Subject: [Koha-bugs] [Bug 17509] Notify patrons to return items requested on hold by another person In-Reply-To: <bug-17509-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17509-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17509-70-BT6zlzFyAI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #58 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86368&action=edit Bug 17509: Added tests prove t/db_dependent/Reserves/Notification.t Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Test pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 11:12:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 10:12:52 +0000 Subject: [Koha-bugs] [Bug 17509] Notify patrons to return items requested on hold by another person In-Reply-To: <bug-17509-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17509-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17509-70-fy01bjioba@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #59 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86369&action=edit Bug 17509: (follow-up) Logic moved from C4 to Koha namespace This patch simplifies logic by using Koha objects. Automated test has been moved from t/db_dependent/Reserves to t/db_dependent/Holds. Test plan: 1) apply patch 2) run database update 3) enable sending an email to the patrons to return an item whenever a hold request is placed on it (NotifyToReturnItemFromLibrary) 4) place a hold 5) patrons having checked-out the item on hold are notified by email (see HOLDPLACED_CONTACT letter) Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 11:14:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 10:14:36 +0000 Subject: [Koha-bugs] [Bug 17598] Make use of itemtypes.summary In-Reply-To: <bug-17598-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17598-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17598-70-Lrzu32RoVy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17598 --- Comment #3 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Oh looks like its an old trick to customize search results : https://gitlab.com/koha-community/Koha/blob/fcd6bdc5b8ed5cd48b19d03a86e2ab9aaa0b0626/C4/Search.pm#L1963 This is useless with XSLT display. I think it can be removed from db and item types configuration page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 11:19:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 10:19:49 +0000 Subject: [Koha-bugs] [Bug 22481] Koha::Uploader does not work under Plack In-Reply-To: <bug-22481-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22481-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22481-70-h2CLvBg7b2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22481 --- Comment #2 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- A quick dirty fix is in Koha/Uploader.pm use constant BYTES_DIGEST => 2048; Change 2048 with a huge number, upload will not need hook. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 11:25:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 10:25:19 +0000 Subject: [Koha-bugs] [Bug 22412] Elasticsearch - Second term of a boolean research is lost after applying a facet In-Reply-To: <bug-22412-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22412-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22412-70-X524Aig6jF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22412 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |BLOCKED Depends on| |22413 --- Comment #1 from Ere Maijala <ere.maijala at helsinki.fi> --- The fix for bug 22413 should also fix this one. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22413 [Bug 22413] Elasticsearch - Index title is lost after sorting -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 11:25:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 10:25:19 +0000 Subject: [Koha-bugs] [Bug 22413] Elasticsearch - Index title is lost after sorting In-Reply-To: <bug-22413-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22413-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22413-70-5obs0Q8DSk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22413 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22412 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22412 [Bug 22412] Elasticsearch - Second term of a boolean research is lost after applying a facet -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 11:27:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 10:27:37 +0000 Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve aliased fields In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19575-70-Z16RdX5jup@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575 --- Comment #97 from David Gustafsson <glasklas at gmail.com> --- That might have been a mistake. The mappings where generated from this script from Zebra mapping definitions: https://github.com/ub-digit/koha-indexdefs-to-mappings-yaml/blob/master/mappings.rb but su-geo is in the source mappings as far as I can see and should not have been removed. I also manually rebased mappings.yaml a couple of times after upstream changes, don't know if made some mistake there. Since I seems to have commented out the alias ('su-geo' => 'subject') in the patch, it seams like I expected the field to exist, so I probably did not remove it intentionally and it should be re-added. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 11:50:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 10:50:00 +0000 Subject: [Koha-bugs] [Bug 22274] Self-checkout/checkin pages not covered by OPAC CSS changes In-Reply-To: <bug-22274-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22274-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22274-70-04JyzDk0jl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22274 --- Comment #7 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Thanks for the clarifications, the "new" status with a patch made me fear that there was a risk being forgotten during many months. But it turns out it's in good hands :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 11:55:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 10:55:31 +0000 Subject: [Koha-bugs] [Bug 22482] New: Some characters are not escaped in translated file. Message-ID: <bug-22482-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22482 Bug ID: 22482 Summary: Some characters are not escaped in translated file. Change sponsored?: --- Product: Koha Version: 18.11 Hardware: Other OS: Linux Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: bastien.gonckel at progilone.fr QA Contact: testopia at bugs.koha-community.org Target Milestone: --- It seems that the file fr-FR-staff-prog.po contain character that are not escaped on line 17596. In the template memberentrygen.tt, line 1195 the string MSG_MESSAGING_DFEAULTS (I assume it was supposed to be MSG_MESSAGING_DEFAULTS) contain double quote, but these double quote are escaped in the .po file. With this unescapped character, the javascript fail, and I can't use the save button for saving user. Work fine in english. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 12:01:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 11:01:36 +0000 Subject: [Koha-bugs] [Bug 13911] Add support for Internet Archive BookReader In-Reply-To: <bug-13911-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13911-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13911-70-CpHEnEOSOz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13911 Jerwyn <os.jerwynfernandez at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion CC| |os.jerwynfernandez at gmail.co | |m --- Comment #3 from Jerwyn <os.jerwynfernandez at gmail.com> --- Hi Indranil, I emailed you regarding with this, maybe you overlook my email. Good thing there is a development on this use case that we need also, plus is it possible only patrons that are log-in to Koha can see the BookReader if they are not log-in to the OPAC the viewing will be restricted. Probably I could help to raise a fund in sponsoring this project, how much funding do we need to make this project working? Looking forward to this! Thank you and best regards, -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 12:05:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 11:05:16 +0000 Subject: [Koha-bugs] [Bug 22413] Elasticsearch - Index title is lost after sorting In-Reply-To: <bug-22413-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22413-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22413-70-kdaQA7kEuk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22413 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #5 from Ere Maijala <ere.maijala at helsinki.fi> --- *** Bug 18319 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 12:05:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 11:05:16 +0000 Subject: [Koha-bugs] [Bug 18319] Elasticsearch Advanced search breadcrumbs broken In-Reply-To: <bug-18319-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18319-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18319-70-JwYnH66vuH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18319 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Ere Maijala <ere.maijala at helsinki.fi> --- *** This bug has been marked as a duplicate of bug 22413 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 12:06:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 11:06:44 +0000 Subject: [Koha-bugs] [Bug 22295] Elasticsearch - Advanced search should group terms entered in a single input In-Reply-To: <bug-22295-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22295-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22295-70-azDQbRX0vH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22295 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |ere.maijala at helsinki.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 12:17:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 11:17:58 +0000 Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve aliased fields In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19575-70-nRE7PKU7KX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575 --- Comment #98 from David Gustafsson <glasklas at gmail.com> --- I had a look at the script again and now remembered it does not migrate zebra facets declared in biblio-koha-indexdefs.xml, that might be the reason it got dropped. The other facet fields are present in mappings.yaml though. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 12:28:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 11:28:13 +0000 Subject: [Koha-bugs] [Bug 22295] Elasticsearch - Advanced search should group terms entered in a single input In-Reply-To: <bug-22295-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22295-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22295-70-kWysQDLT05@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22295 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 12:28:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 11:28:16 +0000 Subject: [Koha-bugs] [Bug 22295] Elasticsearch - Advanced search should group terms entered in a single input In-Reply-To: <bug-22295-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22295-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22295-70-m5lmK7uOwz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22295 --- Comment #1 from Ere Maijala <ere.maijala at helsinki.fi> --- Created attachment 86370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86370&action=edit Bug 22295: Make Elasticsearch query builder group multi-term queries Test plan: 1. Do an advanced search for Title = new AND Title = york 2. Verify that the results match an advanced search for: Title = new york 3. Verify that tests in t/db_dependent/Koha/SearchEngine/Elasticsearch still pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 12:29:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 11:29:02 +0000 Subject: [Koha-bugs] [Bug 22413] Elasticsearch - Index title is lost after sorting In-Reply-To: <bug-22413-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22413-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22413-70-VJZAMCuLly@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22413 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22295 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 12:29:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 11:29:02 +0000 Subject: [Koha-bugs] [Bug 22295] Elasticsearch - Advanced search should group terms entered in a single input In-Reply-To: <bug-22295-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22295-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22295-70-n4jeuNQgzS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22295 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22413 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 12:30:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 11:30:12 +0000 Subject: [Koha-bugs] [Bug 18837] Add an unmediated Interlibrary Loans workflow In-Reply-To: <bug-18837-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18837-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18837-70-jMyzJweY4g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 --- Comment #27 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 86371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86371&action=edit Bug 18837: (follow-up) Add additional tests As requested by Josef on IRC, we now mock the unmediated_ill backend method and ensure it is called when the ILLModuleUnmediated syspref is enabled and ensure it is not called when the syspref is disabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 12:35:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 11:35:43 +0000 Subject: [Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13937-70-Dbi3MxkYPF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Stefan Berndtsson <stefan.berndtsson at ub.gu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stefan.berndtsson at ub.gu.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 12:38:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 11:38:02 +0000 Subject: [Koha-bugs] [Bug 18837] Add an unmediated Interlibrary Loans workflow In-Reply-To: <bug-18837-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18837-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18837-70-WDr8EiOR4p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86236|0 |1 is obsolete| | --- Comment #28 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 86372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86372&action=edit Bug 18837: Add ILL Unmediated syspref stuff This patch adds the syspref requirements for unmediated ILL requests. It is a recreation of https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66628&action=diff which had diverged sufficiently as to make it impossible to apply. * installer/data/mysql/atomicupdate/illunmediated_tables.sql: New file. * installer/data/mysql/sysprefs.sql: Add `ILLModuleUnmediated`. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref: Add `ILLModuleUnmediated` handling. Signed-off-by: Stephen Graham <s.graham4 at herts.ac.uk> Signed-off-by: David Peacock <d.m.peacock at herts.ac.uk> Signed-off-by: Jayne Maisey <j.maisey at herts.ac.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 12:38:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 11:38:05 +0000 Subject: [Koha-bugs] [Bug 18837] Add an unmediated Interlibrary Loans workflow In-Reply-To: <bug-18837-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18837-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18837-70-YaqXofy1w2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86237|0 |1 is obsolete| | --- Comment #29 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 86373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86373&action=edit Bug 18837: Introduce delegation to backends for unmediated workflows This patch adds support to Illrequest.pm to allow delegation of unmediated requests to happen in backends that support them. It is a recreation of https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66629&action=diff which had diverged sufficiently as to make it impossible to apply Signed-off-by: Stephen Graham <s.graham4 at herts.ac.uk> Signed-off-by: David Peacock <d.m.peacock at herts.ac.uk> Signed-off-by: Jayne Maisey <j.maisey at herts.ac.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 12:38:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 11:38:08 +0000 Subject: [Koha-bugs] [Bug 18837] Add an unmediated Interlibrary Loans workflow In-Reply-To: <bug-18837-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18837-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18837-70-4gJfxiuOGj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86238|0 |1 is obsolete| | --- Comment #30 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 86374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86374&action=edit Bug 18837: (QA follow-up) Update system preference desciprition -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 12:38:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 11:38:11 +0000 Subject: [Koha-bugs] [Bug 18837] Add an unmediated Interlibrary Loans workflow In-Reply-To: <bug-18837-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18837-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18837-70-c0tCCl4hnr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86371|0 |1 is obsolete| | --- Comment #31 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 86375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86375&action=edit Bug 18837: (follow-up) Add additional tests As requested by Josef on IRC, we now mock the unmediated_ill backend method and ensure it is called when the ILLModuleUnmediated syspref is enabled and ensure it is not called when the syspref is disabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 12:43:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 11:43:41 +0000 Subject: [Koha-bugs] [Bug 20563] ILL request list gives no indication of source and/or target In-Reply-To: <bug-20563-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20563-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20563-70-7SeLxBG3ZV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20563 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84696|0 |1 is obsolete| | --- Comment #25 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 86376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86376&action=edit Bug 20563: (follow-up) Add unit test Test that requested partners are returned in API response when requested -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 12:43:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 11:43:44 +0000 Subject: [Koha-bugs] [Bug 20563] ILL request list gives no indication of source and/or target In-Reply-To: <bug-20563-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20563-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20563-70-BYR38CIPJ2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20563 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84697|0 |1 is obsolete| | --- Comment #26 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 86377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86377&action=edit Bug 20563: (follow-up) Fix rebasing bug Fix erroneous curly brackets -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 12:43:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 11:43:47 +0000 Subject: [Koha-bugs] [Bug 20563] ILL request list gives no indication of source and/or target In-Reply-To: <bug-20563-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20563-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20563-70-v46CGzoJ7g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20563 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84698|0 |1 is obsolete| | --- Comment #27 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 86378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86378&action=edit Bug 20563: Allow display of requested partners This patch adds the display of requested partner email addresses when an ILL backend provides the ability to send requests to partners. Partner email addresses are displayed in the illlist and illview displays, they are also included in the 'illrequests' API response. * api/v1/swagger/paths/illrequests.json: - Add 'requested_partners' as an 'embed' enum * Koha/Illrequest.pm: - Add 'requested_partners' accessor calling optional backend 'get_requested_partners' method. - Store requested partners upon email send, calling optional backend 'set_requested_partners' method. - Add 'requested_parners' embed to overloaded TO_JSON method. * koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt: - Add 'requested_partners' embed to illrequests API call - Add render function for "Additional status" datatables column - Add display of requested partner email addresses to illlist table - Add display of requested partner email addresses to illview display To test: 1) Enable Interlibrary loans 2) Add a backend that supports sending requests to partners, e.g. FreeForm 3) Set up at least one partner 4) Create an ILL request 5) Send request to partner(s) 6) Observe partner(s) email address(es) are displayed in "View ILL requests" view 7) Observe partner(s) email address(es) are displayed in "Manage ILL request" view Signed-off-by: mmg at interleaf.ie https://bugs.koha-community.org/show_bug.cgi?id=20653 Bug 20563: (follow-up) Fix requested partners As per: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20563#c10 Thanks for the suggestion on merging the "Status" and "Additional status" columns, looks much better! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 13:11:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 12:11:51 +0000 Subject: [Koha-bugs] [Bug 22371] MARC bibliographic framework plugin to generate Cutter-Sanborn In-Reply-To: <bug-22371-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22371-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22371-70-udiXxDA0zS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22371 --- Comment #10 from paxed <pasi.kallinen at koha-suomi.fi> --- (In reply to ?talo from comment #9) > (In reply to paxed from comment #4) > > Should also perhaps use String.prototype.normalize() if it's available > > Paxed, the new attachment ('Updated plugin code, using > String.prototype.normalize()') was done with normalize(). > Thanks for the suggestion! You probably shouldn't split the string into character array (and then join it later), but use the normalize directly on the string and remove the combining diacritics (eg. with a regular expression). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 13:23:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 12:23:40 +0000 Subject: [Koha-bugs] [Bug 22483] New: haspermissions used to support passing 'undef' for $flagsrequired Message-ID: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Bug ID: 22483 Summary: haspermissions used to support passing 'undef' for $flagsrequired Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Bug 22031 inadvertently prevents passing 'undef' (or not passing $flagsrequired at all) to mean "pass if I have ANY permission on anything". This functionality was in use in two places. /svc/members/search and /Koha/REST/V1/Auth.pm. We do support passing `*` to mean the same thing (and this can also be used at arbitrary depth in the structure to mean `any subpermission`. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 13:23:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 12:23:49 +0000 Subject: [Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired In-Reply-To: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22483-70-5JSmhv1DKp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 13:25:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 12:25:13 +0000 Subject: [Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired In-Reply-To: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22483-70-jMqztHaqnW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22031 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22031 [Bug 22031] C4::Auth->haspermission should allow checking for more than one subpermission -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 13:25:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 12:25:13 +0000 Subject: [Koha-bugs] [Bug 22031] C4::Auth->haspermission should allow checking for more than one subpermission In-Reply-To: <bug-22031-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22031-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22031-70-Ba6zoiAQvc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22031 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22483 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 13:31:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 12:31:24 +0000 Subject: [Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired In-Reply-To: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22483-70-7gFQqszwe8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86379&action=edit Bug 22483: Explicitly ban 'undef' as a valid $flagsrequired Before bug 22031 the haspermission subroutine signature allowed for passing 'undef' to mean 'any permission' in $flagsrequired. This feels like a mistake and was only in practical use in two places in the codebase. This patch explicitly forbids this practice (`*` may be used to the same result and is more explicit in it's nature) and replaces the two instances of it's use. Test Plan 1. Before this patch, the API tests are all failing with authentication errors 2. After this patch the API tests should now all pass. 3. t/db_dependent/Auth/haspermission.t should continue to pass (with one addition subtest added herin) 3. /svc/members/search is not unit tested. Please check that patron searching still yields results in the UI after this patch. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 13:31:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 12:31:45 +0000 Subject: [Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired In-Reply-To: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22483-70-FDZm8RAjEk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 13:32:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 12:32:05 +0000 Subject: [Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired In-Reply-To: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22483-70-59ymi9hf7I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |nick at bywatersolutions.com, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 13:32:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 12:32:14 +0000 Subject: [Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired In-Reply-To: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22483-70-vQgCzPi9zF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 13:34:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 12:34:41 +0000 Subject: [Koha-bugs] [Bug 22484] New: /svc/members/search has no tests Message-ID: <bug-22484-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22484 Bug ID: 22484 Summary: /svc/members/search has no tests Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- I may be missing them somehow, but I can't find any tests for /svc/members/search. As an important part of Koha I feel this script should be tested (I inadvertently broke it with bug 22031 for example) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 13:35:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 12:35:12 +0000 Subject: [Koha-bugs] [Bug 22484] /svc/members/search has no tests In-Reply-To: <bug-22484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22484-70-R2uofRwnxv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22484 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22483 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 13:35:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 12:35:12 +0000 Subject: [Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired In-Reply-To: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22483-70-MTyg1yOuju@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22484 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 13:35:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 12:35:21 +0000 Subject: [Koha-bugs] [Bug 22031] C4::Auth->haspermission should allow checking for more than one subpermission In-Reply-To: <bug-22031-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22031-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22031-70-Q8Ge2DJYyS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22031 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22484 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 13:35:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 12:35:21 +0000 Subject: [Koha-bugs] [Bug 22484] /svc/members/search has no tests In-Reply-To: <bug-22484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22484-70-eYjSHtsR2M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22484 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22031 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 13:45:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 12:45:48 +0000 Subject: [Koha-bugs] [Bug 22485] New: Add randomly generated password suggestion to add/modify patron form Message-ID: <bug-22485-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22485 Bug ID: 22485 Summary: Add randomly generated password suggestion to add/modify patron form Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: emma.perks at heartofengland.nhs.uk QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Target Milestone: --- We would like to add the randomly generated password feature from member-password.tt to the OPAC/Staff login section on memberentry.pl. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 13:51:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 12:51:49 +0000 Subject: [Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired In-Reply-To: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22483-70-9JqgOVnAZK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86380&action=edit Bug 22483: (follow-up) Improve POD as requested in bug 22031 Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 14:01:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 13:01:25 +0000 Subject: [Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch In-Reply-To: <bug-20478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20478-70-FGGA5rtHSV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80901|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86381 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86381&action=edit Bug 20478: Add unit test for advance_notices.pl cronjob. Signed-off-by: Magnus Enger <magnus at libriotech.no> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 14:01:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 13:01:28 +0000 Subject: [Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch In-Reply-To: <bug-20478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20478-70-kW9KH9w9vO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80902|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86382 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86382&action=edit Bug 20478: Refactor to remove code duplication. Signed-off-by: Magnus Enger <magnus at libriotech.no> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 14:01:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 13:01:35 +0000 Subject: [Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch In-Reply-To: <bug-20478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20478-70-BsSJNIhS1K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 --- Comment #22 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86384 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86384&action=edit Bug 20478: (QA follow-up) Make test more standard Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 14:01:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 13:01:31 +0000 Subject: [Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch In-Reply-To: <bug-20478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20478-70-CV20sNtWex@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80903|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86383 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86383&action=edit Bug 20478: Have the cronjob script advance_notices.pl send digest messages per branch. Desired behavior of the script advance_notices.pl is that the sender address on the notice message is that of the branch of the issues in question. Thus, the solution is to generate digest messages per branch. To test: 1) Inspect unit test in t/db_dependent/cronjobs/advance_notices_digest.t and note that: - There are three libraries - There is a borrower - The borrower is registered at library1 - The borrower has message preference wants_digest set to 1 - The borrower has message preference days_in_advance set to 1 - The content of the letter PREDUEDGST is '<<count>> <<branches.branchname>>' - There are three items - There is one issue per item - There is one issues at library2 - There are two issues at library3 - The date_due of the issues are set to tomorrow - For the default case (no -digest-per-message) - It is asserted that there is one message in the message queue after running the script - It is asserted that there are three items in the message. - It is asserted that the branchname is that of the borrower's home library. - For the case where -digest-per-message is enabled - It is asserted that there are two messages in the message queue after running the script - It is asserted that the item count of the message corresponding to library2 is 1 - It is asserted that the item count of the message corresponding to library3 is 2 - It is asserted that the branchnames are correct. 2) Run unit test: prove t/db_dependent/cronjobs/advance_notices_digest.t Sponsored-By: Bibliotek Mellansj?, which is a cooperation between Sponsored-By: Gullsp?ngs kommunbibliotek Sponsored-By: Hjo stadsbibliotek Sponsored-By: Karlsborgs bibliotek Sponsored-By: Mariestads stadsbibliotek Sponsored-By: Sk?vde stadsbibliotek Sponsored-By: Tibro bibliotek Sponsored-By: Tidaholms stadsbibliotek Sponsored-By: T?reboda kommunbibliotek Signed-off-by: Andreas Jonsson <andreas.jonsson at kreablo.se> Signed-off-by: Magnus Enger <magnus at libriotech.no> Adding the --digest-per-branch switch turns the digest into one digest per library. I think it makes perfect sense to keep the default behaviour and hide this new functionality behind a command line switch. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 14:04:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 13:04:46 +0000 Subject: [Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch In-Reply-To: <bug-20478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20478-70-dJWHeHhCIW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #23 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- (In reply to Jonathan Druart from comment #18) > Great to see tests for this code, even if done in an unusual way. > > Some quick remarks: > 1. Transactions must be done using txn_begin (also note that you are setting > AutoCommit off in the sub and rollback at the end => no sense) > > 2. $ENV{"OVERRIDE_SYSPREF_dateformat"} = 'metric'; > Why not set_preference? Note that for test we usually use mock_preference > (from t::lib::Mocks) to avoid to mess with the cache. > > 3. You could use build_sample_item from bug 21971 to simplify the objects > creation (not pushed yet) > > 4. use Koha::DateUtils instead of DateTime directly > > 5. You could use File::Slurp::read_file to simplify a bit the code > > I would have preferred to see the code moved to a module. It would have > eased the write of the tests and made the code reusable. > > Keeping the SO status to get other QA opinions. I've cleaned up the test a little to make it a bit more 'koha', but I've not gone as far as Jonathan suggests above.. I feel these additional clean ups could be handled separately, like the factoring out of code into a module for example. Code works and passes all tests.. It's also great to see a cronscript with tests. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 14:04:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 13:04:54 +0000 Subject: [Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch In-Reply-To: <bug-20478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20478-70-p1nAL1kfin@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 14:12:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 13:12:54 +0000 Subject: [Koha-bugs] [Bug 22462] Crash in patron card printing In-Reply-To: <bug-22462-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22462-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22462-70-VJOakva0Kh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22462 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cecile.joyet at biblibre.com, | |victor.grousset at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 14:18:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 13:18:30 +0000 Subject: [Koha-bugs] [Bug 22480] itemtype/itype is used to join allot of tables, but often isn't defined as a key In-Reply-To: <bug-22480-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22480-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22480-70-MRlG2FiBr0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22480 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 14:25:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 13:25:28 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18736-70-2KXyosjbnF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #163 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- I think I'm happy with Nicks logic here.. Unfortunately, as we store calculated values we're open to having issues like this. EDI for example can often give you both tax inclusive and tax exclusive values and pretty often the rounding math at their end will be different from at our end and so yield different results. I think this patch improves the situation a fair amount and is a good compromise given our existing codebase.. perhaps it's the foundations for more work in a followup bug but I don't think that should hold up this work any longer really.. Did you have any more specific issues Marcel, that Nick could go on for keeping this moving? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 14:26:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 13:26:28 +0000 Subject: [Koha-bugs] [Bug 21683] Remove accountlines.accountno In-Reply-To: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21683-70-e7c6tIVM6a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 --- Comment #42 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Agreed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 14:56:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 13:56:14 +0000 Subject: [Koha-bugs] [Bug 19265] Advanced Editor - Rancor - Add ability to export selected records from and import records into an import batch In-Reply-To: <bug-19265-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19265-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19265-70-maZ4RTF7on@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19265 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 15:22:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 14:22:27 +0000 Subject: [Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired In-Reply-To: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22483-70-48SVTmbV5g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86385 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86385&action=edit Bug 22483: (QA follow-up) Corrections to logic in check_cookie_auth check_cookie_auth needs to allow for cases where we wish to check for ANY permission and cases where we wish to skip the permissions check entirely and just authenticate the session. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 15:23:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 14:23:46 +0000 Subject: [Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired In-Reply-To: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22483-70-lag2YGiG8G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- One step closer.. still another followup required to correct the logic for the /public endpoints where we are still inadvertently passing 'undef' to haspermission -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 15:42:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 14:42:20 +0000 Subject: [Koha-bugs] [Bug 21187] GDPR: Force patrons password renew In-Reply-To: <bug-21187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21187-70-rIxik1RZ2s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21187 claire.hernandez at biblibre.com <claire.hernandez at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez at biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 16:06:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 15:06:32 +0000 Subject: [Koha-bugs] [Bug 20208] Custom file upload paths In-Reply-To: <bug-20208-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20208-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20208-70-hVvv3HjunW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20208 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #7 from Liz Rea <wizzyrea at gmail.com> --- I was unable to get this to work, I think I need some additional information regarding setup parameters. Namely: Where do the paths to be input into the authorised velue start from, / or /var/lib/koha/<instance>/uploads or somewhere else? This needs documentation at least. I was expecting to be able to get to the hashless files by going to them at http://host/uploads/custom/path/file.jpg type of URL, but this didn't work that I could see. It could be related to the above question. The files did seem to get uploaded to the directory, but I was unable to retrieve them with a reasonable URL. I believe that's what the requester is probably looking for. The interface for finding uploaded files needs a LOT of work, though technically that is independent of this development (but actually, it's kinda not!). Users will have to be very disciplined with file names and potentially have external documentation to have a hope of finding files using a search only. I think this interface needs rework urgently to have either a gallery style or directory hierarchy style display. Even a link to "list all files" with their web URL and/or file system path (as security allows) would be a huge improvement. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 16:10:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 15:10:47 +0000 Subject: [Koha-bugs] [Bug 22450] Show if due date or return date has been changed from circ rules In-Reply-To: <bug-22450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22450-70-6q0mmO9a0k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22450 Chris Slone <cslone at camdencountylibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cslone at camdencountylibrary. | |org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 16:11:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 15:11:13 +0000 Subject: [Koha-bugs] [Bug 3342] Changes to holds priority list should be logged for accountability In-Reply-To: <bug-3342-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-3342-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3342-70-78R6P6BBA1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3342 Jessie Zairo <jzairo at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 16:11:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 15:11:51 +0000 Subject: [Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired In-Reply-To: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22483-70-cUt33W7Oyl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86386&action=edit Bug 22483: (QA follow-up) Tweaking call to haspermission This patch tweaks the logic to check the permissions is defined before passing to haspermission. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 16:13:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 15:13:38 +0000 Subject: [Koha-bugs] [Bug 16440] Update report parameters In-Reply-To: <bug-16440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16440-70-xjnIXNKa28@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16440 Chris Slone <cslone at camdencountylibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cslone at camdencountylibrary. | |org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 16:21:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 15:21:09 +0000 Subject: [Koha-bugs] [Bug 22413] Elasticsearch - Index title is lost after sorting In-Reply-To: <bug-22413-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22413-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22413-70-oYTM46ZO8Q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22413 Margaret <margaret at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |margaret at bywatersolutions.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 16:23:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 15:23:04 +0000 Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile In-Reply-To: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18589-70-qo1Dchd3kw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Chris Slone <cslone at camdencountylibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cslone at camdencountylibrary. | |org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 16:24:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 15:24:49 +0000 Subject: [Koha-bugs] [Bug 17509] Notify patrons to return items requested on hold by another person In-Reply-To: <bug-17509-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17509-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17509-70-PvBTLgfwtD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Chris Slone <cslone at camdencountylibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cslone at camdencountylibrary. | |org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 16:26:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 15:26:53 +0000 Subject: [Koha-bugs] [Bug 18064] Long overdue cronjob does not follow the library's calendar and skip closed days In-Reply-To: <bug-18064-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18064-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18064-70-KW82jlKOwU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18064 Chris Slone <cslone at camdencountylibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cslone at camdencountylibrary. | |org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 16:27:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 15:27:04 +0000 Subject: [Koha-bugs] [Bug 20563] ILL request list gives no indication of source and/or target In-Reply-To: <bug-20563-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20563-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20563-70-umlrtC50kX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20563 Chris Slone <cslone at camdencountylibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cslone at camdencountylibrary. | |org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 16:27:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 15:27:21 +0000 Subject: [Koha-bugs] [Bug 19266] Add ability to update 005 during import of records and check 001 uniqueness on save to batch In-Reply-To: <bug-19266-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19266-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19266-70-KxWaP9n4wS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19266 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77905|0 |1 is obsolete| | --- Comment #4 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 86387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86387&action=edit Bug 19266: Allow 001 checking on save to batch and 005 update on import of records To test: 1 - Export a set of records with control numbers from your system 2 - Stage those records 3 - Note during staging a new option to update the 005 4 - Check records after staging 5 - Note 005 is updated or not as the option is selected 6 - Open the advanced cataloging editor 7 - Under settings choose Import Batches 8 - Set the batch you just imported as a save target 9 - Select that batch only as save target 10 - Create a new record, give it the control number of a record in the batch 11 - Attempt to save to the batch 12 - You get an error 13 - Save overriding warnings 14 - The record is then added to the batch Rebased-on 2019-03-08 (alex.arnaud at biblibre.com) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 16:28:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 15:28:00 +0000 Subject: [Koha-bugs] [Bug 16149] Generate and send custom notices based on report output In-Reply-To: <bug-16149-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16149-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16149-70-NKZFz5oeel@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16149 Chris Slone <cslone at camdencountylibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cslone at camdencountylibrary. | |org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 16:28:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 15:28:43 +0000 Subject: [Koha-bugs] [Bug 22023] Further improve responsive layout handling of staff client menu bar In-Reply-To: <bug-22023-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22023-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22023-70-ajRgh62rKw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22023 Chris Slone <cslone at camdencountylibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cslone at camdencountylibrary. | |org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 16:30:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 15:30:18 +0000 Subject: [Koha-bugs] [Bug 22287] Correct new charts CSS In-Reply-To: <bug-22287-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22287-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22287-70-ghdKFFnjYV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22287 Chris Slone <cslone at camdencountylibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cslone at camdencountylibrary. | |org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 16:31:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 15:31:20 +0000 Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request datatable to be customisable In-Reply-To: <bug-21063-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21063-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21063-70-dRo1f5JdPD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 Chris Slone <cslone at camdencountylibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cslone at camdencountylibrary. | |org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 16:43:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 15:43:49 +0000 Subject: [Koha-bugs] [Bug 21198] authenticate_api_request should stash the reason access is granted In-Reply-To: <bug-21198-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21198-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21198-70-z29Owu3ova@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21198 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|Failed QA |RESOLVED --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- At this point I'm not sure this really serves any purpose.. I'm going to mark it as invalid for now. We can always revisit it in the future should we choose to do so. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 16:47:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 15:47:01 +0000 Subject: [Koha-bugs] [Bug 21198] authenticate_api_request should stash the reason access is granted In-Reply-To: <bug-21198-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21198-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21198-70-ZnjxWrKZLS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21198 --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- In reality, what I believe would be considerably more useful is for us to implement the FIXME in C4::Auth->haspermission `#FIXME - This fcn should return the failed permission so a suitable error msg can be delivered.` Passing back the permission one is missing, perhaps as a catch-able Koha::Exception or something would be a distinctly more useful pattern. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 17:02:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 16:02:09 +0000 Subject: [Koha-bugs] [Bug 18166] Show internal and vendor notes for received orders In-Reply-To: <bug-18166-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18166-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18166-70-S09t6HGaYA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18166 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> --- backported to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 17:35:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 16:35:11 +0000 Subject: [Koha-bugs] [Bug 21335] Remove redundant includes of right-to-left.css In-Reply-To: <bug-21335-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21335-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21335-70-gjXCgHqOq0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21335 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #8 from Lucas Gass <lucas at bywatersolutions.com> --- i cant rebase this in 18.05.x and pass the qa tool: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/cataloguing/editor.tt SKIP filters OK forbidden patterns OK git manipulation OK js_in_body OK spelling OK tt_valid FAIL valid_template : filter not found skipping unless needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 17:41:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 16:41:51 +0000 Subject: [Koha-bugs] [Bug 22080] Easier translation of ElasticSearch mappings page In-Reply-To: <bug-22080-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22080-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22080-70-3pE0UF21OK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22080 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #17 from Lucas Gass <lucas at bywatersolutions.com> --- skipping this ES patch in 18.05.x, if I am wrong let me know -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 17:46:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 16:46:32 +0000 Subject: [Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired In-Reply-To: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22483-70-hVE38QuJzG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 --- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 86388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86388&action=edit Bug 22483: (follow-up) Fix wrong tests higlighted by bug Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 17:54:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 16:54:14 +0000 Subject: [Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired In-Reply-To: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22483-70-1MqSbEnEoN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86389&action=edit Bug 22483: Restore undef behaviour Turns out that we rely heavily on the side effect that passing undef to haspermission would always return true no matter what permissions or lack of permissions you had. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 17:55:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 16:55:22 +0000 Subject: [Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired In-Reply-To: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22483-70-gH3GHsAHIW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 18:04:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 17:04:41 +0000 Subject: [Koha-bugs] [Bug 22130] Batch checkout: authorized value description is never shown with notforloan status In-Reply-To: <bug-22130-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22130-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22130-70-N47rSFAsrB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22130 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #13 from Lucas Gass <lucas at bywatersolutions.com> --- backported to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 18:15:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 17:15:24 +0000 Subject: [Koha-bugs] [Bug 22170] Library group description input field should be longer In-Reply-To: <bug-22170-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22170-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22170-70-0zw2YbEC4A@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22170 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #10 from Lucas Gass <lucas at bywatersolutions.com> --- backported to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 18:43:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 17:43:15 +0000 Subject: [Koha-bugs] [Bug 22396] koha-sip script does not start the server correctly In-Reply-To: <bug-22396-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22396-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22396-70-YngeSDCJVh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22396 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #8 from Lucas Gass <lucas at bywatersolutions.com> --- missing 18562 dependency for 18.05.x, wont backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 19:15:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 18:15:04 +0000 Subject: [Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired In-Reply-To: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22483-70-lrq9f3YlKm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86379|0 |1 is obsolete| | Attachment #86380|0 |1 is obsolete| | Attachment #86385|0 |1 is obsolete| | Attachment #86386|0 |1 is obsolete| | Attachment #86388|0 |1 is obsolete| | Attachment #86389|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 86390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86390&action=edit Bug 22483: Explicitly ban 'undef' as a valid $flagsrequired Before bug 22031 the haspermission subroutine signature allowed for passing 'undef' to mean 'any permission' in $flagsrequired. This feels like a mistake and was only in practical use in two places in the codebase. This patch explicitly forbids this practice (`*` may be used to the same result and is more explicit in it's nature) and replaces the two instances of it's use. Test Plan 1. Before this patch, the API tests are all failing with authentication errors 2. After this patch the API tests should now all pass. 3. t/db_dependent/Auth/haspermission.t should continue to pass (with one addition subtest added herin) 3. /svc/members/search is not unit tested. Please check that patron searching still yields results in the UI after this patch. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 19:15:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 18:15:14 +0000 Subject: [Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired In-Reply-To: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22483-70-9Kb3ljUswk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 --- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 86391 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86391&action=edit Bug 22483: (follow-up) Improve POD as requested in bug 22031 Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 19:15:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 18:15:17 +0000 Subject: [Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired In-Reply-To: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22483-70-YX6oVevIXE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 --- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 86392 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86392&action=edit Bug 22483: (QA follow-up) Corrections to logic in check_cookie_auth check_cookie_auth needs to allow for cases where we wish to check for ANY permission and cases where we wish to skip the permissions check entirely and just authenticate the session. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 19:15:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 18:15:19 +0000 Subject: [Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired In-Reply-To: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22483-70-ue0E7VoRP3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 --- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 86393 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86393&action=edit Bug 22483: (QA follow-up) Tweaking call to haspermission This patch tweaks the logic to check the permissions is defined before passing to haspermission. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 19:15:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 18:15:22 +0000 Subject: [Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired In-Reply-To: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22483-70-ZY3Fvcso1J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 --- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 86394 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86394&action=edit Bug 22483: (follow-up) Fix wrong tests higlighted by bug Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 19:15:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 18:15:00 +0000 Subject: [Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired In-Reply-To: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22483-70-aeEYwZmFjd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 19:15:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 18:15:25 +0000 Subject: [Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired In-Reply-To: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22483-70-SB3GaDy1wc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 --- Comment #13 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 86395 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86395&action=edit Bug 22483: Restore undef behaviour Turns out that we rely heavily on the side effect that passing undef to haspermission would always return true no matter what permissions or lack of permissions you had. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 19:22:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 18:22:58 +0000 Subject: [Koha-bugs] [Bug 22222] Mana subscription search always returns all results In-Reply-To: <bug-22222-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22222-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22222-70-EmPq3RElTg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22222 Michal Denar <black23 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 19:23:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 18:23:02 +0000 Subject: [Koha-bugs] [Bug 22222] Mana subscription search always returns all results In-Reply-To: <bug-22222-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22222-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22222-70-ojMnjchO4t@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22222 Michal Denar <black23 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86043|0 |1 is obsolete| | --- Comment #2 from Michal Denar <black23 at gmail.com> --- Created attachment 86396 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86396&action=edit Bug 22222: Don't send empty params to mana service Test plan: 0) Do not apply the patch 1) Go to serials > Search on Mana 2) Insert some value into the form 3) Submit -> you get many (3000+) results 4) Apply the patch and restart_all 5) Repeat, now, you get only the subscription matching your query Signed-off-by: Michal Denar <black23 at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 19:26:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 18:26:51 +0000 Subject: [Koha-bugs] [Bug 22486] New: Limit Patron expiry notices by category Message-ID: <bug-22486-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22486 Bug ID: 22486 Summary: Limit Patron expiry notices by category Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Target Milestone: --- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 19:30:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 18:30:07 +0000 Subject: [Koha-bugs] [Bug 17510] marc modification templates ignore subfield $0 In-Reply-To: <bug-17510-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17510-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17510-70-Jn9Oattg6h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17510 Sarah Cornell <sbcornell at cityofportsmouth.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbcornell at cityofportsmouth. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 19:34:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 18:34:11 +0000 Subject: [Koha-bugs] [Bug 14850] Funds from inactive budgets appear in 'Funds' dropdown on acqui/invoice.pl In-Reply-To: <bug-14850-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14850-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14850-70-58atnCLWTW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14850 Jesse Maseto <jesse at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |jesse at bywatersolutions.com Status|Pushed to Stable |RESOLVED --- Comment #21 from Jesse Maseto <jesse at bywatersolutions.com> --- Did not apply to 18.05.x. Please rebase to 18.05.x if needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 19:34:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 18:34:13 +0000 Subject: [Koha-bugs] [Bug 22405] Funds from inactive budgets appear in 'Funds' dropdown on acqui/orderreceive.pl In-Reply-To: <bug-22405-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22405-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22405-70-kp6HUyTQbJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22405 Bug 22405 depends on bug 14850, which changed state. Bug 14850 Summary: Funds from inactive budgets appear in 'Funds' dropdown on acqui/invoice.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14850 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 19:40:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 18:40:20 +0000 Subject: [Koha-bugs] [Bug 18957] Item renewed online does not show the time of renewal In-Reply-To: <bug-18957-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18957-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18957-70-NaqrMiSGpE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18957 Jesse Maseto <jesse at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |jesse at bywatersolutions.com Status|Pushed to Stable |RESOLVED --- Comment #16 from Jesse Maseto <jesse at bywatersolutions.com> --- Doesn't apply cleanly to 18.05.x. Please rebase to 18.05.x if needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 19:42:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 18:42:15 +0000 Subject: [Koha-bugs] [Bug 22250] Clean up Mana KB integration with serials and reports In-Reply-To: <bug-22250-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22250-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22250-70-aag5chszMD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22250 Michal Denar <black23 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 19:42:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 18:42:19 +0000 Subject: [Koha-bugs] [Bug 22250] Clean up Mana KB integration with serials and reports In-Reply-To: <bug-22250-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22250-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22250-70-IZkS9AlbNz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22250 Michal Denar <black23 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85784|0 |1 is obsolete| | --- Comment #4 from Michal Denar <black23 at gmail.com> --- Created attachment 86397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86397&action=edit Bug 22250: Clean up Mana KB integration with serials and reports This patch makes many changes to templates and JavaScript related to the integration of Mana with serials reports: - Many incorrect uses of the raw filter with html - Corrections to Bootstrap modal markup - Untranslatable strings moved out of JavaScript - Removed markup and JavaScript related to reports comments, a feature which doesn't exist in this version. New include file: mana/mana-comment-status.inc This file contains hidden-by-default messages which are shown during the process of submitting a comment on a subscription. New include file: mana/mana-share-report.inc This file contains the "Share report" modal markup formerly in guided_reports_start.tt New JavaScript file: mana.js Previously mana.inc, an include file containing only JavaScript which didn't include any template processing. Changed: mana/mana-report-search-result.inc This include file is now a full template so that jQuery's load() function can be used to pull its contents into the reports search modal. Changed: svc/mana/search This script was returning json-encoded HTML. Now it returns regular HTML. To test you must have Mana configured and enabled. Apply the patch and go to Reports -> Saved reports. - Choose New report -> New SQL from Mana. A "Mana search" modal should appear. - Perform a search which will return results, e.g. "circulation." - A "Loading" indicator should appear while the results are being retrieved. It should disappear when results appear. - Results should appear in the DataTable with sorting, paging, and search options. - In the "Notes" column, notes longer than 200 characters should be truncated with a "Show more" link. Clicking it should expand the comment and reveal a "Show less" link in its place. - Click the "Import" button (previously "Use"). The button icon should change to a loading indicator. - When the import is complete you should be redirected to a view of your new report. Go to Serials and click the "Search on Mana" link in the sidebar. - Perform a search for a serial - Results should appear in a DataTable with sorting, paging, and search options. - Sorting by title should ignore articles "a," "an," and "the." Create a new subscription or edit an existing subscription which will match a record in Mana. - On the second step of adding/editing the subscription a message should appear at the top of the form, "Searching for subscription in Mana Knowledge Base," with a loading icon. - When searching has completed a "Show Mana results" link should appear. - Clicking the link should trigger a modal showing search results which match your subscription, displayed in a DataTable with sorting, paging, and search options. - The last column of the table should contain "Import" and "Report" buttons. - Clicking the "Report" button should trigger a menu. Any existing comments will be listed as well as a "New comment" item. - Clicking an existing comment should cause the menu to close and a "Submitting comment" message to appear. It should be shortly replaced with a "Your comment has been submitted" message. - Clicking "New comment" should reveal a comment form. - It should not be possible to submit an empty comment. - Clicking the "cancel" link should redisplay the search results. - Submitting a new comment should trigger a "Submitting comment" message followed by a "Your comment has been submitted" message. - In the table of search results, click the "Import" button (previously "Use"). The button icon should change to a loading indicator. - The modal should close and the data from Mana should be loaded into the subscription entry form. View the detail page of a subscription which has saved with Mana data. - There should be a "Report mistake" button in the toolbar. Clicking it should reveal a menu of comments like the one you saw previously. - Clicking an existing comment should cause the menu to close and a "Submitting comment" message to appear. It should be shortly replaced with a "Your comment has been submitted" message. - Clicking "New comment" should reveal a comment form modal. - It should not be possible to submit an empty comment. - Clicking the "cancel" link should hide the modal. - Submitting a new comment should trigger a "Submitting comment" message followed by a "Your comment has been submitted" message. Signed-off-by: Michal Denar <black23 at gmail.com> -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 19:47:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 18:47:25 +0000 Subject: [Koha-bugs] [Bug 15149] Serials: Test prediction pattern does not consider Subscription start and end date In-Reply-To: <bug-15149-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15149-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15149-70-P3qJ5z03mF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15149 Jesse Maseto <jesse at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse at bywatersolutions.com --- Comment #11 from Jesse Maseto <jesse at bywatersolutions.com> --- Pushed to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 19:54:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 18:54:23 +0000 Subject: [Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired In-Reply-To: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22483-70-94ORuexyWb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86390|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 19:54:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 18:54:25 +0000 Subject: [Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired In-Reply-To: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22483-70-D8D6D9CP9x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86391|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 19:54:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 18:54:27 +0000 Subject: [Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired In-Reply-To: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22483-70-bgaO5DCO6d@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86392|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 19:54:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 18:54:29 +0000 Subject: [Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired In-Reply-To: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22483-70-oA0TMtVGf3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86393|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 19:54:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 18:54:31 +0000 Subject: [Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired In-Reply-To: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22483-70-uJREQxfwL7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86394|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 19:54:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 18:54:33 +0000 Subject: [Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired In-Reply-To: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22483-70-ioR12saqmz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86395|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 19:54:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 18:54:20 +0000 Subject: [Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired In-Reply-To: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22483-70-HSTwyZ0yO6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 19:55:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 18:55:22 +0000 Subject: [Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired In-Reply-To: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22483-70-I0LufqXLwS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #14 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Patches pushed to master for 19.05 Thanks all! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 19:56:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 18:56:54 +0000 Subject: [Koha-bugs] [Bug 22411] Dates in log viewer not formatted correctly In-Reply-To: <bug-22411-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22411-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22411-70-jxgAb0ZKoe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22411 Jesse Maseto <jesse at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse at bywatersolutions.com --- Comment #6 from Jesse Maseto <jesse at bywatersolutions.com> --- Pushed to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 19:57:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 18:57:43 +0000 Subject: [Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired In-Reply-To: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22483-70-xrgaOTxIIg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | Target Milestone|--- |19.05 --- Comment #15 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- I've pushed this follow-up bug that restores the previous behavior for haspermission regarding undef. It highlighted "interesting" bugs and flawed design in our mixed up authentication-authorization methods. Specially how the rest of the code adapts to those side effects. We will certainly file new bugs for things that where raised. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 19:59:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 18:59:05 +0000 Subject: [Koha-bugs] [Bug 22378] Fix sound alerts on SCO In-Reply-To: <bug-22378-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22378-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22378-70-vFc1zz3Z6D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22378 Jesse Maseto <jesse at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED CC| |jesse at bywatersolutions.com --- Comment #6 from Jesse Maseto <jesse at bywatersolutions.com> --- Patch doesn't apply cleanly. Please rebase if needed for 18.05.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 19:59:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 18:59:06 +0000 Subject: [Koha-bugs] [Bug 22441] SCO sound alerts need a selenium test In-Reply-To: <bug-22441-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22441-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22441-70-KQvjKbPtpK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22441 Bug 22441 depends on bug 22378, which changed state. Bug 22378 Summary: Fix sound alerts on SCO https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22378 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 19:59:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 18:59:06 +0000 Subject: [Koha-bugs] [Bug 18251] SCO alerts - need a trigger for successful checkouts In-Reply-To: <bug-18251-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18251-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18251-70-4VlnorhoJw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18251 Bug 18251 depends on bug 22378, which changed state. Bug 22378 Summary: Fix sound alerts on SCO https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22378 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 20:07:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 19:07:35 +0000 Subject: [Koha-bugs] [Bug 22477] Missing DataTables configuration when searching patrons for holds In-Reply-To: <bug-22477-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22477-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22477-70-6eR3Hhc8qC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22477 Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre-marc.thibault at inlibr | |o.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 20:07:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 19:07:20 +0000 Subject: [Koha-bugs] [Bug 22477] Missing DataTables configuration when searching patrons for holds In-Reply-To: <bug-22477-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22477-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22477-70-fAKpuZlNMC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22477 Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86328|0 |1 is obsolete| | --- Comment #2 from Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> --- Created attachment 86398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86398&action=edit Bug 22477: Missing DataTables configuration when searching patrons for holds This patch adds columns configuration to the holds request page to fix a JavaScript error in the console and to allow the patron search results table to be enabled as a DataTable. To reproduce: Place a hold on a title in the staff client. When prompted for a patron, perform a search which will return multiple results. The patron search results will appear in an unsortable table. A JS error can be seen in the browser console. To test, apply the patch and repeat the steps above. The patron search results table should be sortable and there should be no JS error. Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 20:15:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 19:15:18 +0000 Subject: [Koha-bugs] [Bug 22397] Wrong message in koha-sip --start In-Reply-To: <bug-22397-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22397-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22397-70-qq3TMFFtz9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22397 Jesse Maseto <jesse at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse at bywatersolutions.com Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #6 from Jesse Maseto <jesse at bywatersolutions.com> --- Patch not needed for 18.05.x. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 20:18:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 19:18:20 +0000 Subject: [Koha-bugs] [Bug 21765] AutoUnsuspendReserves manually sets holds fields instead of calling ->resume In-Reply-To: <bug-21765-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21765-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21765-70-3NURTQpYQK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21765 Jesse Maseto <jesse at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse at bywatersolutions.com --- Comment #10 from Jesse Maseto <jesse at bywatersolutions.com> --- Pushed to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 20:23:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 19:23:38 +0000 Subject: [Koha-bugs] [Bug 22477] Missing DataTables configuration when searching patrons for holds In-Reply-To: <bug-22477-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22477-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22477-70-n79Renr3nq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22477 Bin <bin.wen at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86398|0 |1 is obsolete| | --- Comment #3 from Bin <bin.wen at inlibro.com> --- Created attachment 86399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86399&action=edit Bug 22477: Missing DataTables configuration when searching patrons for holds This patch adds columns configuration to the holds request page to fix a JavaScript error in the console and to allow the patron search results table to be enabled as a DataTable. To reproduce: Place a hold on a title in the staff client. When prompted for a patron, perform a search which will return multiple results. The patron search results will appear in an unsortable table. A JS error can be seen in the browser console. To test, apply the patch and repeat the steps above. The patron search results table should be sortable and there should be no JS error. Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com> Signed-off-by: Bin Wen <bin.wen at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 20:27:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 19:27:45 +0000 Subject: [Koha-bugs] [Bug 22475] Shelving location doesn't appear on tags list view In-Reply-To: <bug-22475-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22475-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22475-70-MoaQSXgcbT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22475 Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> --- When I try to apply the patch, I have an error message : Applying: Bug 22475: Shelving location doesn't appear on tags list view fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/tags/list.tt). error: could not build fake ancestor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 20:36:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 19:36:14 +0000 Subject: [Koha-bugs] [Bug 22084] Plugin upgrade method and database plugin version storage will never be triggered for existing installs In-Reply-To: <bug-22084-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22084-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22084-70-5UXtaoG1Zy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22084 Jesse Maseto <jesse at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse at bywatersolutions.com --- Comment #10 from Jesse Maseto <jesse at bywatersolutions.com> --- Pushed to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 20:41:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 19:41:07 +0000 Subject: [Koha-bugs] [Bug 22300] Staff search results: Opt groups in 'sort' pull down are not well formatted In-Reply-To: <bug-22300-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22300-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22300-70-811FHCTbGZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22300 Jesse Maseto <jesse at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |jesse at bywatersolutions.com Status|Pushed to Stable |RESOLVED --- Comment #8 from Jesse Maseto <jesse at bywatersolutions.com> --- Patch doesn't apply cleanly. Please rebase if needed for 18.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 20:47:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 19:47:24 +0000 Subject: [Koha-bugs] [Bug 20830] Make sure a fund is selected when ordering from staged file In-Reply-To: <bug-20830-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20830-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20830-70-WkaM6QzdP8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20830 Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre-marc.thibault at inlibr | |o.com Status|Needs Signoff |Patch doesn't apply --- Comment #6 from Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> --- When I try to apply, I have this error message : Applying: Bug 20830: Make sure a fund is selected when ordering from staged file Using index info to reconstruct a base tree... M koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/addorderiso2709.tt error: Failed to merge in the changes. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 20:56:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 19:56:46 +0000 Subject: [Koha-bugs] [Bug 21030] Date widget on suspend modal not working correctly In-Reply-To: <bug-21030-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21030-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21030-70-A10IbvUn72@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21030 Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86111|0 |1 is obsolete| | --- Comment #5 from Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> --- Created attachment 86400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86400&action=edit Bug 21030: Date widget on suspend modal not working correctly This patch makes a change to the suspend hold modal markup in order to allow the datepicker <selects> to work properly. To test, apply the patch and locate a patron in the staff client who has holds. - On the checkout or patron detail page, open the holds tab. - Click the "Suspend" button for one of the holds. - In the modal, trigger the date picker and confirm that the dropdowns for selecting month and year work correctly. Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 20:57:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 19:57:17 +0000 Subject: [Koha-bugs] [Bug 21030] Date widget on suspend modal not working correctly In-Reply-To: <bug-21030-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21030-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21030-70-MU2a0MjtOO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21030 Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 21:10:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 20:10:26 +0000 Subject: [Koha-bugs] [Bug 19046] IntranetCatalogSearchPulldown doesn't retain last selection In-Reply-To: <bug-19046-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19046-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19046-70-UDkCzpkDAI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19046 Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86024|0 |1 is obsolete| | --- Comment #5 from Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> --- Created attachment 86401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86401&action=edit Bug 19046: Make seach pulldown to retain index selection This patch also fixes add the term in the search input Test plan: Enable IntranetCatalogSearchPulldown Search for a term using the search input in the header (simple search) Re-do selecting different indices The selection must retain on the search result page. Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 21:10:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 20:10:42 +0000 Subject: [Koha-bugs] [Bug 19046] IntranetCatalogSearchPulldown doesn't retain last selection In-Reply-To: <bug-19046-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19046-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19046-70-2XKO6oLpBD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19046 Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre-marc.thibault at inlibr | |o.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 21:33:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 20:33:36 +0000 Subject: [Koha-bugs] [Bug 22219] C4::Biblio->GetItemsForInventory can return wrong count / duplicated items when skipping waiting holds In-Reply-To: <bug-22219-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22219-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22219-70-jhEXcHxVcD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22219 Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86030|0 |1 is obsolete| | --- Comment #3 from Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> --- Created attachment 86402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86402&action=edit Bug 22219: Add tests Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 21:33:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 20:33:53 +0000 Subject: [Koha-bugs] [Bug 22219] C4::Biblio->GetItemsForInventory can return wrong count / duplicated items when skipping waiting holds In-Reply-To: <bug-22219-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22219-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22219-70-aEILveywLf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22219 Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86031|0 |1 is obsolete| | --- Comment #4 from Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> --- Created attachment 86403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86403&action=edit Bug 22219: Remove duplicated items in inventory (when skipping waiting holds) Test plan: 0/ Do not apply this patch 1/ Place several holds on a given item 2/ Use the inventory with the "skip waiting holds" option to list this item. It will be displayed several times 3/ Apply this patch and confirm that the item is now only displayed once Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 21:34:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 20:34:14 +0000 Subject: [Koha-bugs] [Bug 22219] C4::Biblio->GetItemsForInventory can return wrong count / duplicated items when skipping waiting holds In-Reply-To: <bug-22219-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22219-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22219-70-t8avcaiqgR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22219 Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |pierre-marc.thibault at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 21:43:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 20:43:39 +0000 Subject: [Koha-bugs] [Bug 22476] MarkLostItemsAsReturned has wrong defaults for new installs In-Reply-To: <bug-22476-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22476-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22476-70-m49AQxWQgL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22476 Bin <bin.wen at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86303|0 |1 is obsolete| | --- Comment #2 from Bin <bin.wen at inlibro.com> --- Created attachment 86404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86404&action=edit Bug 22476: Correct default for MarkLostItemsAsReturned Signed-off-by: Bin Wen <bin.wen at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 22:38:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 21:38:33 +0000 Subject: [Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired In-Reply-To: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22483-70-rVvIP2iZXA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Login at the OPAC is impossible: Can't use string ("1") as a HASH ref while "strict refs" in use at /home/vagrant/kohaclone/C4/Auth.pm line 202. at /home/vagrant/kohaclone/C4/Auth.pm line 192 Caught by t/db_dependent/selenium/authentication.t, always good to run those tests to make sure there are no obvious regressions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 22:44:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 21:44:47 +0000 Subject: [Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired In-Reply-To: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22483-70-e5gyMqBU7I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre-marc.thibault at inlibr | |o.com --- Comment #17 from Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> --- I found a bug related to this bugzilla. When one tries to create a course reserve, a software error occurs with the following message : Can't use string ("1") as a HASH ref while "strict refs" in use at /C4/Auth.pm line 302. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 22:49:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 21:49:40 +0000 Subject: [Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired In-Reply-To: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22483-70-DlhYaZiZkm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 --- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- 2087 return 1 unless defined($flagsrequired); # This is horrifying but restores behaviour prior to bug 22031 Are you sure about that? I do not see any situations where is returned 1 before 22031. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 22:52:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 21:52:44 +0000 Subject: [Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired In-Reply-To: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22483-70-mqRugOLyv5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|pierre-marc.thibault at inlibr | |o.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 22:53:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 21:53:07 +0000 Subject: [Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired In-Reply-To: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22483-70-6CQ9GFM5te@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 --- Comment #19 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Martin Renvoize from comment #0) > This functionality was in use in two places. /svc/members/search and > /Koha/REST/V1/Auth.pm. About /svc/members/search: at first glance I think we should rewrite this code to adapt it, not the other way around. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 22:55:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 21:55:46 +0000 Subject: [Koha-bugs] [Bug 21953] Term "Lost item" untranslatable In-Reply-To: <bug-21953-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21953-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21953-70-dXuH3a1u08@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86210|0 |1 is obsolete| | Attachment #86211|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86405&action=edit Bug 21953: Add tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 22:55:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 21:55:50 +0000 Subject: [Koha-bugs] [Bug 21953] Term "Lost item" untranslatable In-Reply-To: <bug-21953-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21953-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21953-70-AgZITc6Lcr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 --- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86406&action=edit Bug 21953: Update existing rows in DB -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 22:55:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 21:55:42 +0000 Subject: [Koha-bugs] [Bug 21953] Term "Lost item" untranslatable In-Reply-To: <bug-21953-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21953-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21953-70-dewqvfU3OO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 23:14:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 22:14:38 +0000 Subject: [Koha-bugs] [Bug 22480] itemtype/itype is used to join allot of tables, but often isn't defined as a key In-Reply-To: <bug-22480-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22480-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22480-70-PnSF9tvGRF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22480 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21150, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21842 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 23:14:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 22:14:38 +0000 Subject: [Koha-bugs] [Bug 21150] Data inconsistencies - item types In-Reply-To: <bug-21150-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21150-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21150-70-uR4AXoG9d6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21150 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22480 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 23:14:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 22:14:38 +0000 Subject: [Koha-bugs] [Bug 21842] always test Koha::ItemType in defined In-Reply-To: <bug-21842-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21842-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21842-70-1bxQsH380j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21842 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22480 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 23:22:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 22:22:15 +0000 Subject: [Koha-bugs] [Bug 8437] Large database backups and large exports from export.pl fail under plack In-Reply-To: <bug-8437-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8437-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8437-70-3iZ6VbYteB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22481 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 23:22:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 22:22:15 +0000 Subject: [Koha-bugs] [Bug 22481] Koha::Uploader does not work under Plack In-Reply-To: <bug-22481-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22481-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22481-70-WUNK761Yak@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22481 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=8437 CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 8 23:35:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Mar 2019 22:35:05 +0000 Subject: [Koha-bugs] [Bug 20357] Pod Coverage checking for no public subs In-Reply-To: <bug-20357-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20357-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20357-70-eGQ7Lahg3v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20357 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Please provide tests Mark. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 9 09:14:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Mar 2019 08:14:37 +0000 Subject: [Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired In-Reply-To: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22483-70-o6e9ayPooX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 --- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86407&action=edit Bug 22483: Restore exact behaviour of undef Passing undef (or nothing) as $flagsrequired to haspermission simply returned the return from fetchrow prior to this patch. Restoring that behaviour. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 9 09:16:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Mar 2019 08:16:13 +0000 Subject: [Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired In-Reply-To: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22483-70-gj0trT5yTo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 --- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86408&action=edit Bug 22483: Restore svc/members/search This script used to pass 'undef' to haspermission, this patch restores that behaviour. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 9 09:30:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Mar 2019 08:30:14 +0000 Subject: [Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired In-Reply-To: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22483-70-J57VGcLHlm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86408|0 |1 is obsolete| | --- Comment #23 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 86410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86410&action=edit Bug 22483: Restore svc/members/search This script used to pass 'undef' to haspermission, this patch restores that behaviour. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 9 09:30:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Mar 2019 08:30:08 +0000 Subject: [Koha-bugs] [Bug 22483] haspermissions used to support passing 'undef' for $flagsrequired In-Reply-To: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22483-70-tcdscnwgrs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86407|0 |1 is obsolete| | --- Comment #22 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 86409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86409&action=edit Bug 22483: Restore exact behaviour of undef Passing undef (or nothing) as $flagsrequired to haspermission simply returned the return from fetchrow prior to this patch. Restoring that behaviour. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 9 09:42:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Mar 2019 08:42:21 +0000 Subject: [Koha-bugs] [Bug 15774] Additional fields for baskets In-Reply-To: <bug-15774-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15774-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15774-70-nvJrH0T216@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 --- Comment #158 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 86411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86411&action=edit Bug 15774: (follow-up) Fix TestBuilder.t so it doesn't catch wrong classes Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 9 21:33:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Mar 2019 20:33:00 +0000 Subject: [Koha-bugs] [Bug 15911] Use noEnterSubmit CSS class instead of prevent_submit.js In-Reply-To: <bug-15911-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15911-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15911-70-MkWAct3KUa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15911 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 9 21:33:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Mar 2019 20:33:04 +0000 Subject: [Koha-bugs] [Bug 15911] Use noEnterSubmit CSS class instead of prevent_submit.js In-Reply-To: <bug-15911-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15911-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15911-70-PhjQVndXnt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15911 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86046|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 86412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86412&action=edit Bug 15911: Use noEnterSubmit CSS class instead of prevent_submit.js This patch removes the use of a separate js file, prevent_submit.js, in favor of using a CSS class to trigger the same functionality in staff-global.js. To test, apply the patch and test the following pages to confirm that pressing "Enter" when the cursor is in any field in the main form does not submit the form. - In Acquisitions, add to a basket from a new (empty) record - In Acquisitions, receive an order line - In Serials, locate a subscription and open the "Edit serials" page from the "Serial collection" page. Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 9 21:33:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Mar 2019 20:33:07 +0000 Subject: [Koha-bugs] [Bug 15911] Use noEnterSubmit CSS class instead of prevent_submit.js In-Reply-To: <bug-15911-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15911-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15911-70-QlzRlxhon1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15911 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86205|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 86413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86413&action=edit Bug 15911: (follow-up) Allow enter to submit using the submit button This patch modifies the checkEnter function so that it is possible to submit a form by tabbing to the submit button and hitting ENTER to submit. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 9 21:38:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Mar 2019 20:38:57 +0000 Subject: [Koha-bugs] [Bug 22477] Missing DataTables configuration when searching patrons for holds In-Reply-To: <bug-22477-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22477-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22477-70-8yBNni9ltr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22477 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Should the columns be configurable? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 9 21:41:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Mar 2019 20:41:29 +0000 Subject: [Koha-bugs] [Bug 21030] Date widget on suspend modal not working correctly In-Reply-To: <bug-21030-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21030-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21030-70-nREW97hugM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21030 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 9 21:41:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Mar 2019 20:41:32 +0000 Subject: [Koha-bugs] [Bug 21030] Date widget on suspend modal not working correctly In-Reply-To: <bug-21030-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21030-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21030-70-uAs8Wkl8jl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21030 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86400|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 86414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86414&action=edit Bug 21030: Date widget on suspend modal not working correctly This patch makes a change to the suspend hold modal markup in order to allow the datepicker <selects> to work properly. To test, apply the patch and locate a patron in the staff client who has holds. - On the checkout or patron detail page, open the holds tab. - Click the "Suspend" button for one of the holds. - In the modal, trigger the date picker and confirm that the dropdowns for selecting month and year work correctly. Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 9 21:44:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Mar 2019 20:44:42 +0000 Subject: [Koha-bugs] [Bug 21070] request.pl details links to biblio instead of moredetail.pl for that item In-Reply-To: <bug-21070-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21070-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21070-70-ja91e5u73U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21070 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 9 21:44:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Mar 2019 20:44:45 +0000 Subject: [Koha-bugs] [Bug 21070] request.pl details links to biblio instead of moredetail.pl for that item In-Reply-To: <bug-21070-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21070-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21070-70-G8oXzTV5BA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21070 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86329|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 86415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86415&action=edit Bug 21070: request.pl details links to biblio instead of moredetail.pl for that item This patch alters the hold summary page so that links to records with item-level holds go to the item detail page instead of the bibliographic detail page. There is already a link to the bibliographic detail page in the page heading. To test, apply the patch and place or locate an item-level hold. In the list of existing holds for that record, the linked barcode on the item-level hold should take you to the corresponding item detail page. Signed-off-by: Lisette <lisettes at latahlibrary.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 9 21:45:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Mar 2019 20:45:33 +0000 Subject: [Koha-bugs] [Bug 21070] request.pl details links to biblio instead of moredetail.pl for that item In-Reply-To: <bug-21070-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21070-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21070-70-Ybu0Ag8GDZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21070 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I like this change. Can we do the same for the holds tab on details and checkouts tabs in the patron account? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 9 21:50:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Mar 2019 20:50:42 +0000 Subject: [Koha-bugs] [Bug 19046] IntranetCatalogSearchPulldown doesn't retain last selection In-Reply-To: <bug-19046-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19046-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19046-70-J8KKyaAknk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19046 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 9 21:50:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Mar 2019 20:50:49 +0000 Subject: [Koha-bugs] [Bug 19046] IntranetCatalogSearchPulldown doesn't retain last selection In-Reply-To: <bug-19046-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19046-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19046-70-MHnow1QFTF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19046 --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 86417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86417&action=edit Bug 19046: (QA follow-up) Remove doubled up 'Title as phrase' One search option was doubled up by accident. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 9 21:50:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Mar 2019 20:50:45 +0000 Subject: [Koha-bugs] [Bug 19046] IntranetCatalogSearchPulldown doesn't retain last selection In-Reply-To: <bug-19046-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19046-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19046-70-Xyp2kGt7u9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19046 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86401|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 86416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86416&action=edit Bug 19046: Make seach pulldown to retain index selection This patch also fixes add the term in the search input Test plan: Enable IntranetCatalogSearchPulldown Search for a term using the search input in the header (simple search) Re-do selecting different indices The selection must retain on the search result page. Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 9 21:57:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Mar 2019 20:57:09 +0000 Subject: [Koha-bugs] [Bug 22487] New: Add Mana and Bugzilla components on bugzilla Message-ID: <bug-22487-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22487 Bug ID: 22487 Summary: Add Mana and Bugzilla components on bugzilla Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Release tools Assignee: jonathan.druart at bugs.koha-community.org Reporter: katrin.fischer at bsz-bw.de Target Milestone: --- In order to be able to report bugs against Mana and Bugzilla, it would be nice if this components could be added. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 9 21:59:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Mar 2019 20:59:12 +0000 Subject: [Koha-bugs] [Bug 22488] New: Mana: Improve confirmation email text and formatting Message-ID: <bug-22488-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22488 Bug ID: 22488 Summary: Mana: Improve confirmation email text and formatting Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Project website Assignee: wizzyrea at gmail.com Reporter: katrin.fischer at bsz-bw.de Depends on: 17047 Target Milestone: --- The formatting and phrasing of the Mana confirmation email could be improved: Hello Katrin Fischer, Someone asked on 2019-03-09 for an authentication on the Mana KB webservice. To activate your account definitively, please click on the following link and follow the instruction https://ui.mana-kb.koha-community.org/registration?id=bvzIiflELChxfKWK6H8RDUV4wICub0Ov Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 [Bug 17047] Mana Knowledge Base : share data -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 9 21:59:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Mar 2019 20:59:12 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17047-70-4pufaCUztq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22488 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22488 [Bug 22488] Mana: Improve confirmation email text and formatting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 9 22:04:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Mar 2019 21:04:12 +0000 Subject: [Koha-bugs] [Bug 22237] Subscriptions are not linked to Mana upon edit In-Reply-To: <bug-22237-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22237-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22237-70-zhz3niapRX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22237 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- How can I find an existing pattern on Mana for testing? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 10 06:40:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Mar 2019 05:40:22 +0000 Subject: [Koha-bugs] [Bug 21003] Don't show warning when editing a reserve item In-Reply-To: <bug-21003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21003-70-NEkRFcJ2qW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21003 Alex Buckley <alexbuckley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 10 18:16:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Mar 2019 17:16:04 +0000 Subject: [Koha-bugs] [Bug 22487] Add Mana and Bugzilla components on bugzilla In-Reply-To: <bug-22487-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22487-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22487-70-Rhf4PgD1ln@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22487 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- About Bugzilla: "Project infrastructure > Bugzilla" ? About Mana: "Koha > Mana" (i.e. Mana code integreated to Koha) or you are talking about the server code? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 10 20:43:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Mar 2019 19:43:48 +0000 Subject: [Koha-bugs] [Bug 22487] Add Mana and Bugzilla components on bugzilla In-Reply-To: <bug-22487-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22487-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22487-70-OAlbd8rpQq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22487 --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Jonathan, yes, Project infrastructure > Bugzilla For Mana I was thinking of the code outside of Koha. Not sure how to handle that best. I wanted to report 'improve the email sent by Mana' (bug 22488) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 10 22:06:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Mar 2019 21:06:57 +0000 Subject: [Koha-bugs] [Bug 21953] Term "Lost item" untranslatable In-Reply-To: <bug-21953-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21953-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21953-70-TSAyOi84Mi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86406|0 |1 is obsolete| | --- Comment #13 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Created attachment 86418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86418&action=edit Bug 21953: Update existing rows in DB Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz> Test plan passes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 10 22:08:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Mar 2019 21:08:18 +0000 Subject: [Koha-bugs] [Bug 21953] Term "Lost item" untranslatable In-Reply-To: <bug-21953-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21953-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21953-70-56wyFA004U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 10 22:12:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Mar 2019 21:12:44 +0000 Subject: [Koha-bugs] [Bug 22479] Unnecessary translation occurs when adding a new serial subscription In-Reply-To: <bug-22479-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22479-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22479-70-v9NFfn272j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22479 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #2 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- (In reply to Katrin Fischer from comment #1) > Hi Hayley, I think these come from your database. Check serials > Manage > frequencies. Thanks Katrin, they are indeed coming from my database. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Mar 10 22:44:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Mar 2019 21:44:48 +0000 Subject: [Koha-bugs] [Bug 21985] Test t/db_dependent/Circulation.t fails if SearchEngine is set to elasticsearch In-Reply-To: <bug-21985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21985-70-2NoguwaYCF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21985 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z --- Comment #2 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- (In reply to Jonathan Druart from comment #1) > Created attachment 83254 [details] [review] > Bug 21985: Fix Circulation tests when ES it set, by using build_sample_item > > We should use build_sample item (from bug 21971) to create items, > otherwise we may not have a valid biblioitem and/or MARC record. > > Test plan: > Set SearchEngine to ES > prove that the tests in Circulation.t now pass Hi, could you please provide a more detailed description for the test step 'set SearchEngine to ES'? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 10 22:50:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Mar 2019 21:50:00 +0000 Subject: [Koha-bugs] [Bug 21658] Renew requests fail if a fee attached In-Reply-To: <bug-21658-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21658-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21658-70-HUrbqom5k2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21658 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z --- Comment #7 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Hi, is there a test plan for this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 10 23:49:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Mar 2019 22:49:05 +0000 Subject: [Koha-bugs] [Bug 22188] Use publication date as numbering pattern In-Reply-To: <bug-22188-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22188-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22188-70-Un6rUg9FFG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 10 23:49:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Mar 2019 22:49:09 +0000 Subject: [Koha-bugs] [Bug 22188] Use publication date as numbering pattern In-Reply-To: <bug-22188-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22188-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22188-70-IkLERo7bwS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 --- Comment #9 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 86419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86419&action=edit Bug 22188: (follow-up) Introducing dateformat field and other fixes To test with this patch, please update the database and update the schema. With this patch, you can now choose the dateformat of the date pattern by editing the subscription. This information is now saved in the DB subscription table. This patch also fixes previous problems with receiving and generating the next serial. Sponsored-by: Brimbank Libraries Australia -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 10 23:50:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Mar 2019 22:50:13 +0000 Subject: [Koha-bugs] [Bug 22188] Use publication date as numbering pattern In-Reply-To: <bug-22188-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22188-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22188-70-0gmN4kkK8Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 --- Comment #10 from Aleisha Amohia <aleisha at catalyst.net.nz> --- (In reply to S?verine Queune from comment #5) > > 9) You should now be on the subscription detail page for your new > > subscription. Go to the Planning tab and confirm that it says 'uses > > publication date' under Number pattern and that there is now table > > saying 'Starting with' and 'Rollover' > > Ok for 'Number pattern: Uses publication date', but I don't see the table. > Sorry I forgot to fix my test plan - this table does not show if using publication date pattern. It will show for all other number patterns. This should be ready to test again now! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 10 23:58:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Mar 2019 22:58:21 +0000 Subject: [Koha-bugs] [Bug 21985] Test t/db_dependent/Circulation.t fails if SearchEngine is set to elasticsearch In-Reply-To: <bug-21985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21985-70-rrq6t9FFQ6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21985 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Hayley, there is a system preference SearchEngine you can switch between Zebra and Elasticsearch. Depending on what you use for testing there might be more steps needed, in a kohadevbox you should be ok with switching the pref and doing a reindex. The script for reindexing Elasticsearch can be run using koha-shell and is in misc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 10 23:59:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Mar 2019 22:59:20 +0000 Subject: [Koha-bugs] [Bug 22188] Use publication date as numbering pattern In-Reply-To: <bug-22188-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22188-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22188-70-58kh9jSica@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22188 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 00:03:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Mar 2019 23:03:46 +0000 Subject: [Koha-bugs] [Bug 22481] Koha::Uploader does not work under Plack In-Reply-To: <bug-22481-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22481-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22481-70-1ZhM37t0uq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22481 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 00:52:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Mar 2019 23:52:10 +0000 Subject: [Koha-bugs] [Bug 18645] Creation of Koha feature release change tool displayed after running Koha update In-Reply-To: <bug-18645-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18645-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18645-70-dXBeKUefr7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18645 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aleisha at catalyst.net.nz Status|Failed QA |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 01:07:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 00:07:56 +0000 Subject: [Koha-bugs] [Bug 18645] Creation of Koha feature release change tool displayed after running Koha update In-Reply-To: <bug-18645-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18645-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18645-70-okiaY9HM76@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18645 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #69471|0 |1 is obsolete| | --- Comment #18 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 86420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86420&action=edit Bug 18645: Koha feature release change tool This tool is displayed at the end of the update process to display all the new system preferences added during the update so that the administrator can view and modify their default values if neccessary The administrator also has the ability to skip the feature release tool on the update process and it will be displayed to the next superlibrarian user that logs in. Because librarian staff are likely to be more familiar with the system preference settings that a library would want to set than an IT support administrator Test plan: 1. Go to Administrator->global system preferences->Local use 2. Set the version number to 16.120033 (Note: only 1 decimal place) and save 3. Go through the update process and notice that after submitting the 'Update database structure' page you are prompted to login and the main page appears if you logged in with the correct credentials 4. Apply patch 5. Repeat steps 1 and 2 6. Notice the button text on the 'Update database structure' page has changed and now it says 'Continue to feature release tool' 7. Notice there is also a skip button. Click the skip button and notice you are redirected to the staff intranet login page. 8. Login with the Koha db administrator credentials and notice that the Koha main page is displayed 9. Logout and enter superlibrarian user credentials and submit the login form 10. Notice you are redirected to the Koha web installer login page 11. Login with the Koha db administrator credentials 12. Notice the feature release change tool is displayed 13. Alter the NumSavedReports and the TalkingTechItivaPhoneNotification values and select the 'Save all preferences' button 14. Query the values of these two sysprefs in the systempreferences database table and notice they have been changed to what you submitted 15. Click the 'Log into Koha staff intranet' button 16. Notice the intranet login page appears 17. Login and the main page will be displayed 18. Repeat steps 1,2 and click the 'Continue to feature release tool' button 19. Notice the feature release tool is displayed and repeat steps 13 and 14 20. Click the 'Log into Koha staff intranet' button, login as either Koha db administrator or as a superlibrarian (it doesn't matter which you log in as) and the Koha staff intranet mainpage will be displayed 21. Log out and then log back in again and notice the staff intranet is still displayed. Note you are not redirected to the Koha web installer login page to go through the feature release change tool because you have already gone through it Sponsored-By: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 01:08:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 00:08:23 +0000 Subject: [Koha-bugs] [Bug 18645] Creation of Koha feature release change tool displayed after running Koha update In-Reply-To: <bug-18645-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18645-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18645-70-GtJocaiUtk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18645 --- Comment #19 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Fixed merge conflicts, now looking at Comment 17 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 03:26:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 02:26:50 +0000 Subject: [Koha-bugs] [Bug 21985] Test t/db_dependent/Circulation.t fails if SearchEngine is set to elasticsearch In-Reply-To: <bug-21985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21985-70-PosevjAgKB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21985 --- Comment #4 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- (In reply to Katrin Fischer from comment #3) > Hi Hayley, there is a system preference SearchEngine you can switch between > Zebra and Elasticsearch. Depending on what you use for testing there might > be more steps needed, in a kohadevbox you should be ok with switching the > pref and doing a reindex. The script for reindexing Elasticsearch can be run > using koha-shell and is in misc. Thank you Katrin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 04:33:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 03:33:51 +0000 Subject: [Koha-bugs] [Bug 21130] Detail XSLT produces translatable HTML class In-Reply-To: <bug-21130-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21130-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21130-70-2n1w8CAQ1x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21130 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 04:33:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 03:33:54 +0000 Subject: [Koha-bugs] [Bug 21130] Detail XSLT produces translatable HTML class In-Reply-To: <bug-21130-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21130-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21130-70-fexm3xOyvz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21130 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79110|0 |1 is obsolete| | --- Comment #9 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Created attachment 86421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86421&action=edit Bug 21130: (Follow up OPAC Results) Prevent HTML class from being translated This fixes the same issue where "title" is being translated (in fr-CA at least) and thus break the javascript impacting the result display in the OPAC Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 04:40:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 03:40:30 +0000 Subject: [Koha-bugs] [Bug 21985] Test t/db_dependent/Circulation.t fails if SearchEngine is set to elasticsearch In-Reply-To: <bug-21985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21985-70-Cv3SCnX8OM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21985 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #5 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Before applying the patch, I get this error when trying to prove those tests: t/db_dependent/Circulation.t .. 61/126 DBD::mysql::st execute failed: Duplicate entry '10' for key 'PRIMARY' [for Statement "INSERT INTO `old_issues` ( `auto_renew`, `auto_renew_error`, `borrowernumber`, `branchcode`, `date_due`, `issue_id`, `issuedate`, `itemnumber`, `lastreneweddate`, `note`, `notedate`, `noteseen`, `onsite_checkout`, `renewals`, `returndate`, `timestamp`) VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )" with ParamValues: 0=0, 1=undef, 2=54, 3='bWmeAOZip', 4='2019-03-25 23:59:00', 5=10, 6='2019-03-11 03:36:44', 7=991, 8=undef, 9=undef, 10=undef, 11=undef, 12=0, 13=undef, 14='2019-03-11 03:36:47', 15='2019-03-11 03:36:47'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. {UNKNOWN}: Can't locate object method "rethrow" via package "DBD::mysql::st execute failed: Duplicate entry '10' for key 'PRIMARY' [for Statement "INSERT INTO `old_issues` ( `auto_renew`, `auto_renew_error`, `borrowernumber`, `branchcode`, `date_due`, `issue_id`, `issuedate`, `itemnumber`, `lastreneweddate`, `note`, `notedate`, `noteseen`, `onsite_checkout`, `renewals`, `returndate`, `timestamp`) VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )" with ParamValues: 0=0, 1=undef, 2=54, 3='bWmeAOZip', 4='2019-03-25 23:59:00', 5=10, 6='2019-03-11 03:36:44', 7=991, 8=undef, 9=undef, 10=undef, 11=undef, 12=0, 13=undef, 14='2019-03-11 03:36:47', 15='2019-03-11 03:36:47'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. " (perhaps you forgot to load "DBD::mysql::st execute failed: Duplicate entry '10' for key 'PRIMARY' [for Statement "INSERT INTO `old_issues` ( `auto_renew`, `auto_renew_error`, `borrowernumber`, `branchcode`, `date_due`, `issue_id`, `issuedate`, `itemnumber`, `lastreneweddate`, `note`, `notedate`, `noteseen`, `onsite_checkout`, `renewals`, `returndate`, `timestamp`) VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )" with ParamValues: 0=0, 1=undef, 2=54, 3='bWmeAOZip', 4='2019-03-25 23:59:00', 5=10, 6='2019-03-11 03:36:44', 7=991, 8=undef, 9=undef, 10=undef, 11=undef, 12=0, 13=undef, 14='2019-03-11 03:36:47', 15='2019-03-11 03:36:47'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. "?) at /home/vagrant/kohaclone/Koha/Object.pm line 185. at /home/vagrant/kohaclone/C4/Circulation.pm line 2206 # Looks like your test exited with 255 just after 71. t/db_dependent/Circulation.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 55/126 subtests Test Summary Report ------------------- t/db_dependent/Circulation.t (Wstat: 65280 Tests: 71 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 126 tests but ran 71. Files=1, Tests=71, 7 wallclock secs ( 0.03 usr 0.01 sys + 3.42 cusr 0.38 csys = 3.84 CPU) Result: FAIL And the patch does not apply: Applying: Bug 21985: Fix Circulation tests when ES it set, by using build_sample_item error: sha1 information is lacking or useless (t/db_dependent/Circulation.t). error: could not build fake ancestor Patch failed at 0001 Bug 21985: Fix Circulation tests when ES it set, by using build_sample_item -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 04:46:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 03:46:00 +0000 Subject: [Koha-bugs] [Bug 21985] Test t/db_dependent/Circulation.t fails if SearchEngine is set to elasticsearch In-Reply-To: <bug-21985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21985-70-zeeNiaX8Qh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21985 --- Comment #6 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- (In reply to Hayley Mapley from comment #5) > Before applying the patch, I get this error when trying to prove those tests: > > t/db_dependent/Circulation.t .. 61/126 DBD::mysql::st execute failed: > Duplicate entry '10' for key 'PRIMARY' [for Statement "INSERT INTO > `old_issues` ( `auto_renew`, `auto_renew_error`, `borrowernumber`, > `branchcode`, `date_due`, `issue_id`, `issuedate`, `itemnumber`, > `lastreneweddate`, `note`, `notedate`, `noteseen`, `onsite_checkout`, > `renewals`, `returndate`, `timestamp`) VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ?, > ?, ?, ?, ?, ?, ?, ? )" with ParamValues: 0=0, 1=undef, 2=54, 3='bWmeAOZip', > 4='2019-03-25 23:59:00', 5=10, 6='2019-03-11 03:36:44', 7=991, 8=undef, > 9=undef, 10=undef, 11=undef, 12=0, 13=undef, 14='2019-03-11 03:36:47', > 15='2019-03-11 03:36:47'] at /usr/share/perl5/DBIx/Class/Storage/DBI.pm line > 1836. > {UNKNOWN}: Can't locate object method "rethrow" via package "DBD::mysql::st > execute failed: Duplicate entry '10' for key 'PRIMARY' [for Statement > "INSERT INTO `old_issues` ( `auto_renew`, `auto_renew_error`, > `borrowernumber`, `branchcode`, `date_due`, `issue_id`, `issuedate`, > `itemnumber`, `lastreneweddate`, `note`, `notedate`, `noteseen`, > `onsite_checkout`, `renewals`, `returndate`, `timestamp`) VALUES ( ?, ?, ?, > ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )" with ParamValues: 0=0, 1=undef, > 2=54, 3='bWmeAOZip', 4='2019-03-25 23:59:00', 5=10, 6='2019-03-11 03:36:44', > 7=991, 8=undef, 9=undef, 10=undef, 11=undef, 12=0, 13=undef, 14='2019-03-11 > 03:36:47', 15='2019-03-11 03:36:47'] at > /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. > " (perhaps you forgot to load "DBD::mysql::st execute failed: Duplicate > entry '10' for key 'PRIMARY' [for Statement "INSERT INTO `old_issues` ( > `auto_renew`, `auto_renew_error`, `borrowernumber`, `branchcode`, > `date_due`, `issue_id`, `issuedate`, `itemnumber`, `lastreneweddate`, > `note`, `notedate`, `noteseen`, `onsite_checkout`, `renewals`, `returndate`, > `timestamp`) VALUES ( ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ?, ? )" with > ParamValues: 0=0, 1=undef, 2=54, 3='bWmeAOZip', 4='2019-03-25 23:59:00', > 5=10, 6='2019-03-11 03:36:44', 7=991, 8=undef, 9=undef, 10=undef, 11=undef, > 12=0, 13=undef, 14='2019-03-11 03:36:47', 15='2019-03-11 03:36:47'] at > /usr/share/perl5/DBIx/Class/Storage/DBI.pm line 1836. > "?) at /home/vagrant/kohaclone/Koha/Object.pm line 185. at > /home/vagrant/kohaclone/C4/Circulation.pm line 2206 > # Looks like your test exited with 255 just after 71. > t/db_dependent/Circulation.t .. Dubious, test returned 255 (wstat 65280, > 0xff00) > Failed 55/126 subtests > > Test Summary Report > ------------------- > t/db_dependent/Circulation.t (Wstat: 65280 Tests: 71 Failed: 0) > Non-zero exit status: 255 > Parse errors: Bad plan. You planned 126 tests but ran 71. > Files=1, Tests=71, 7 wallclock secs ( 0.03 usr 0.01 sys + 3.42 cusr 0.38 > csys = 3.84 CPU) > Result: FAIL > > And the patch does not apply: > Applying: Bug 21985: Fix Circulation tests when ES it set, by using > build_sample_item > error: sha1 information is lacking or useless (t/db_dependent/Circulation.t). > error: could not build fake ancestor > Patch failed at 0001 Bug 21985: Fix Circulation tests when ES it set, by > using build_sample_item Actually reading this error, I see that it's an issue with the DB, which I will fix and then try again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 06:24:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 05:24:32 +0000 Subject: [Koha-bugs] [Bug 22489] New: Onboarding tool fails due to inserting maxissueqty into IssuingRule Message-ID: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22489 Bug ID: 22489 Summary: Onboarding tool fails due to inserting maxissueqty into IssuingRule Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: hayleymapley at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Target Milestone: --- When going through the onboarding process, the tool fails on submit of Step 5 - creating an issuing rule. This is due to the maxissueqty column having been removed from the IssuingRules table and added to the CirculationRules table but redundant code still exists in onboarding.pl. As you can see below the maxissueqty variable is being added to the params hash which is used to make the new issuing rule. if ( $step == 5 ) { if ( $op eq 'add_validate_circ_rule' ) { #If no libraries exist then set the $branch value to * my $branch = $input->param('branch') || '*'; my $type = $input->param('type'); my $branchcode = $input->param('branch'); my $categorycode = $input->param('categorycode'); my $itemtype = $input->param('itemtype'); my $maxissueqty = $input->param('maxissueqty'); my $issuelength = $input->param('issuelength'); my $lengthunit = $input->param('lengthunit'); my $renewalsallowed = $input->param('renewalsallowed'); my $renewalperiod = $input->param('renewalperiod'); my $onshelfholds = $input->param('onshelfholds') || 0; $maxissueqty =~ s/\s//g; $maxissueqty = undef if $maxissueqty !~ /^\d+/; $issuelength = $issuelength eq q{} ? undef : $issuelength; my $params = { branchcode => $branchcode, categorycode => $categorycode, itemtype => $itemtype, maxissueqty => $maxissueqty, renewalsallowed => $renewalsallowed, renewalperiod => $renewalperiod, issuelength => $issuelength, lengthunit => $lengthunit, onshelfholds => $onshelfholds, }; my $issuingrule = Koha::IssuingRule->new($params); eval { $issuingrule->store; }; -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 06:24:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 05:24:57 +0000 Subject: [Koha-bugs] [Bug 22489] Onboarding tool fails due to inserting maxissueqty into IssuingRule In-Reply-To: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22489-70-gU2q0ZmaXX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22489 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |hayleymapley at catalyst.net.n |ity.org |z -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 07:45:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 06:45:38 +0000 Subject: [Koha-bugs] [Bug 10300] Allow transferring of items to be have separate IndependentBranches syspref In-Reply-To: <bug-10300-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10300-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10300-70-cIXJfcEuQP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10300 --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I wonder if this can still be considered a major bug after 6 years? Maybe it could be seen as an enh at this point? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 07:51:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 06:51:54 +0000 Subject: [Koha-bugs] [Bug 22489] Onboarding tool fails due to inserting maxissueqty into IssuingRule In-Reply-To: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22489-70-dlnpkLdHEM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22489 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18925 CC| |katrin.fischer at bsz-bw.de Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 07:51:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 06:51:54 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18925-70-NAQyPohVTq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22489 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22489 [Bug 22489] Onboarding tool fails due to inserting maxissueqty into IssuingRule -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 07:53:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 06:53:10 +0000 Subject: [Koha-bugs] [Bug 22237] Subscriptions are not linked to Mana upon edit In-Reply-To: <bug-22237-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22237-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22237-70-tK48h3TKt4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22237 --- Comment #4 from Josef Moravec <josef.moravec at gmail.com> --- (In reply to Katrin Fischer from comment #3) > How can I find an existing pattern on Mana for testing? Hi Katrin, you can find subscriptions using subscriptions mana search from main serial module page - it could be accessed from left menu. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 08:27:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 07:27:56 +0000 Subject: [Koha-bugs] [Bug 22489] Onboarding tool fails due to inserting maxissueqty into IssuingRule In-Reply-To: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22489-70-BdBOheheH1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22489 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 09:22:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 08:22:50 +0000 Subject: [Koha-bugs] [Bug 18837] Add an unmediated Interlibrary Loans workflow In-Reply-To: <bug-18837-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18837-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18837-70-Grv4fpRmKG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 09:22:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 08:22:54 +0000 Subject: [Koha-bugs] [Bug 18837] Add an unmediated Interlibrary Loans workflow In-Reply-To: <bug-18837-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18837-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18837-70-AwPBYhWboi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86372|0 |1 is obsolete| | Attachment #86373|0 |1 is obsolete| | Attachment #86374|0 |1 is obsolete| | Attachment #86375|0 |1 is obsolete| | --- Comment #32 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86422&action=edit Bug 18837: Add ILL Unmediated syspref stuff This patch adds the syspref requirements for unmediated ILL requests. It is a recreation of https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66628&action=diff which had diverged sufficiently as to make it impossible to apply. * installer/data/mysql/atomicupdate/illunmediated_tables.sql: New file. * installer/data/mysql/sysprefs.sql: Add `ILLModuleUnmediated`. * koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/admin.pref: Add `ILLModuleUnmediated` handling. Signed-off-by: Stephen Graham <s.graham4 at herts.ac.uk> Signed-off-by: David Peacock <d.m.peacock at herts.ac.uk> Signed-off-by: Jayne Maisey <j.maisey at herts.ac.uk> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 09:22:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 08:22:57 +0000 Subject: [Koha-bugs] [Bug 18837] Add an unmediated Interlibrary Loans workflow In-Reply-To: <bug-18837-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18837-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18837-70-pwa7yQfmqc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 --- Comment #33 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86423&action=edit Bug 18837: Introduce delegation to backends for unmediated workflows This patch adds support to Illrequest.pm to allow delegation of unmediated requests to happen in backends that support them. It is a recreation of https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=66629&action=diff which had diverged sufficiently as to make it impossible to apply Signed-off-by: Stephen Graham <s.graham4 at herts.ac.uk> Signed-off-by: David Peacock <d.m.peacock at herts.ac.uk> Signed-off-by: Jayne Maisey <j.maisey at herts.ac.uk> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 09:23:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 08:23:01 +0000 Subject: [Koha-bugs] [Bug 18837] Add an unmediated Interlibrary Loans workflow In-Reply-To: <bug-18837-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18837-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18837-70-qQePdWD6vj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 --- Comment #34 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86424&action=edit Bug 18837: (QA follow-up) Update system preference desciprition Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 09:23:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 08:23:05 +0000 Subject: [Koha-bugs] [Bug 18837] Add an unmediated Interlibrary Loans workflow In-Reply-To: <bug-18837-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18837-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18837-70-ZVK2ar8kpG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 --- Comment #35 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86425&action=edit Bug 18837: (follow-up) Add additional tests As requested by Josef on IRC, we now mock the unmediated_ill backend method and ensure it is called when the ILLModuleUnmediated syspref is enabled and ensure it is not called when the syspref is disabled Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 09:23:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 08:23:09 +0000 Subject: [Koha-bugs] [Bug 18837] Add an unmediated Interlibrary Loans workflow In-Reply-To: <bug-18837-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18837-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18837-70-a9lLUWWEa3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 --- Comment #36 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86426&action=edit Bug 18837: (QA follow-up) Fix order of sysprefa.sql Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 09:49:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 08:49:53 +0000 Subject: [Koha-bugs] [Bug 20563] ILL request list gives no indication of source and/or target In-Reply-To: <bug-20563-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20563-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20563-70-CX4LCe1hgh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20563 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86376|0 |1 is obsolete| | Attachment #86377|0 |1 is obsolete| | Attachment #86378|0 |1 is obsolete| | --- Comment #28 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86427&action=edit Bug 20563: (follow-up) Add unit test Test that requested partners are returned in API response when requested Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 09:49:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 08:49:56 +0000 Subject: [Koha-bugs] [Bug 20563] ILL request list gives no indication of source and/or target In-Reply-To: <bug-20563-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20563-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20563-70-bXhu4QAjlR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20563 --- Comment #29 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86428&action=edit Bug 20563: (follow-up) Fix rebasing bug Fix erroneous curly brackets Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 09:50:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 08:50:00 +0000 Subject: [Koha-bugs] [Bug 20563] ILL request list gives no indication of source and/or target In-Reply-To: <bug-20563-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20563-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20563-70-2gGf02vosX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20563 --- Comment #30 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86429&action=edit Bug 20563: Allow display of requested partners This patch adds the display of requested partner email addresses when an ILL backend provides the ability to send requests to partners. Partner email addresses are displayed in the illlist and illview displays, they are also included in the 'illrequests' API response. * api/v1/swagger/paths/illrequests.json: - Add 'requested_partners' as an 'embed' enum * Koha/Illrequest.pm: - Add 'requested_partners' accessor calling optional backend 'get_requested_partners' method. - Store requested partners upon email send, calling optional backend 'set_requested_partners' method. - Add 'requested_parners' embed to overloaded TO_JSON method. * koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt: - Add 'requested_partners' embed to illrequests API call - Add render function for "Additional status" datatables column - Add display of requested partner email addresses to illlist table - Add display of requested partner email addresses to illview display To test: 1) Enable Interlibrary loans 2) Add a backend that supports sending requests to partners, e.g. FreeForm 3) Set up at least one partner 4) Create an ILL request 5) Send request to partner(s) 6) Observe partner(s) email address(es) are displayed in "View ILL requests" view 7) Observe partner(s) email address(es) are displayed in "Manage ILL request" view Signed-off-by: mmg at interleaf.ie https://bugs.koha-community.org/show_bug.cgi?id=20653 Bug 20563: (follow-up) Fix requested partners As per: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20563#c10 Thanks for the suggestion on merging the "Status" and "Additional status" columns, looks much better! Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 09:50:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 08:50:04 +0000 Subject: [Koha-bugs] [Bug 20563] ILL request list gives no indication of source and/or target In-Reply-To: <bug-20563-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20563-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20563-70-HQZqkQlIRj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20563 --- Comment #31 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86430&action=edit Bug 20563: (QA follow-up) Fix number of tests in api/v1/illrequests.t Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 09:50:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 08:50:08 +0000 Subject: [Koha-bugs] [Bug 20563] ILL request list gives no indication of source and/or target In-Reply-To: <bug-20563-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20563-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20563-70-bnXaouEOz5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20563 --- Comment #32 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86431&action=edit Bug 20563: (QA follow-up) Get requested_partners from api Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 09:50:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 08:50:51 +0000 Subject: [Koha-bugs] [Bug 20563] ILL request list gives no indication of source and/or target In-Reply-To: <bug-20563-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20563-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20563-70-U7tSW6qEg8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20563 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 09:52:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 08:52:30 +0000 Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile In-Reply-To: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18589-70-0mSlVJnb5K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 10:13:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 09:13:16 +0000 Subject: [Koha-bugs] [Bug 22440] ILL API response objects inconsistent with other endpoints In-Reply-To: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22440-70-NKfMDGYf2z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 --- Comment #1 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Further suggestions from Josef to bring this endpoint into line. We should follow the convention illustrated here: https://github.com/Koha-Community/Koha/blob/master/Koha/REST/V1/Library.pm#L46 This automagically looks at the parameters passed in the request and, if they match parameters described in the OpenAPI spec and, if they match, uses their values as filters. The _to_api & _to_model methods will allow us to carry out the property name consistency described in the bug description -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 10:18:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 09:18:41 +0000 Subject: [Koha-bugs] [Bug 22489] Onboarding tool fails due to inserting maxissueqty into IssuingRule In-Reply-To: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22489-70-q79lgtt6xu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22489 Alex Buckley <alexbuckley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 11:04:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 10:04:36 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13952-70-SxOqIdhgxk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | Status|Signed Off |Patch doesn't apply --- Comment #93 from Josef Moravec <josef.moravec at gmail.com> --- sorry, i got error: sha1 information is lacking or useless (C4/ImportExportFramework.pm). error: could not build fake ancestor on last patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 11:21:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 10:21:27 +0000 Subject: [Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13937-70-2uE24DrbCe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 --- Comment #134 from Stefan Berndtsson <stefan.berndtsson at ub.gu.se> --- This patch does not apply for me, with the following error: Applying: Bug 13937: Add a Z39.50 daemon that can inject item status MARC subfields. Fix log path. error: sha1 information is lacking or useless (etc/log4perl.conf). error: could not build fake ancestor Patch failed at 0001 Bug 13937: Add a Z39.50 daemon that can inject item status MARC subfields. Fix log path. Use 'git am --show-current-patch' to see the failed patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/11---Bug-13937-Add-a-Z3950-daemon-that-can-inject--6jqZ05.patch Why are both the first and the second to last patch doing the same change? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 11:29:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 10:29:48 +0000 Subject: [Koha-bugs] [Bug 22457] OpacHiddenItemsExceptions should be moved to a category attribute In-Reply-To: <bug-22457-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22457-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22457-70-lvlLJjoAwQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22457 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 11:30:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 10:30:09 +0000 Subject: [Koha-bugs] [Bug 22454] Add Koha::Item::hidden_in_opac method In-Reply-To: <bug-22454-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22454-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22454-70-6p7CG7CFc8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22454 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 11:30:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 10:30:17 +0000 Subject: [Koha-bugs] [Bug 22455] Add Koha::Biblio::hidden_in_opac method In-Reply-To: <bug-22455-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22455-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22455-70-PX69dQJMBa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22455 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 11:31:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 10:31:48 +0000 Subject: [Koha-bugs] [Bug 22468] Standardize on labeling ccode table columns as Collection In-Reply-To: <bug-22468-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22468-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22468-70-uE0YtdWtpw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22468 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 11:49:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 10:49:19 +0000 Subject: [Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13937-70-HczII2CNjt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85112|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 11:50:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 10:50:15 +0000 Subject: [Koha-bugs] [Bug 22374] Circulation.t noisy since Bug 21753 was pushed In-Reply-To: <bug-22374-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22374-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22374-70-cqFmXpbtYb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22374 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- Bug 21747 removed this code, is this still needed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 11:52:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 10:52:09 +0000 Subject: [Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13937-70-FKv6CfWw3t@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 --- Comment #135 from Ere Maijala <ere.maijala at helsinki.fi> --- Oops, the first patch was accidentally left over from previous iteration. Should be fixed now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 12:20:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 11:20:14 +0000 Subject: [Koha-bugs] [Bug 22490] New: Some strings in javascript files are untranslatable Message-ID: <bug-22490-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22490 Bug ID: 22490 Summary: Some strings in javascript files are untranslatable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: josef.moravec at gmail.com QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Target Milestone: --- You can find them easily with these commands: git grep "_(" koha-tmpl/intranet-tmpl/prog/js git grep "_(" koha-tmpl/opac-tmpl/bootstrap/js They should be fixed, see https://wiki.koha-community.org/wiki/Coding_Guidelines#JS5:_Enabling_translation_of_language_strings_in_linked_JavaScript -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 12:42:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 11:42:03 +0000 Subject: [Koha-bugs] [Bug 22374] Circulation.t noisy since Bug 21753 was pushed In-Reply-To: <bug-22374-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22374-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22374-70-1MJ1MFPy4E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22374 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Patch doesn't apply |RESOLVED --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- The call to logaction moves to Koha::Account::Line->adjust and it is already set to 'UPDATE' there.. This patch is no longer needed :) *** This bug has been marked as a duplicate of bug 21747 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 12:42:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 11:42:03 +0000 Subject: [Koha-bugs] [Bug 21747] Update C4::Overdues::UpdateFine to use Koha::Account->add_debit and Koha::Account::Line->adjust In-Reply-To: <bug-21747-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21747-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21747-70-QOhA13GOFt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21747 --- Comment #25 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- *** Bug 22374 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 12:43:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 11:43:17 +0000 Subject: [Koha-bugs] [Bug 22483] haspermissions previously supported passing 'undef' for $flagsrequired In-Reply-To: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22483-70-RrjuqI8tul@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|haspermissions used to |haspermissions previously |support passing 'undef' for |supported passing 'undef' |$flagsrequired |for $flagsrequired -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 12:55:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 11:55:36 +0000 Subject: [Koha-bugs] [Bug 11375] Improve patrons permissions display In-Reply-To: <bug-11375-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11375-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11375-70-Kaj608IR6e@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 12:58:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 11:58:32 +0000 Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile In-Reply-To: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18589-70-icjP8Jt6a4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 12:58:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 11:58:35 +0000 Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile In-Reply-To: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18589-70-9FSdAOG8CV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84796|0 |1 is obsolete| | --- Comment #14 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 86432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86432&action=edit Bug 18589: Show ILLs as part of patron profile This patch moves the display of a patron's ILL requests to be inline in the Patron Profile page, as per all other patron information. It includes a substantial refactor of koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt in that it moves the display of the illlist table (which is populated by an API request) into it's own separate include file. It also moves the datatable related Javascript for this table into it's own JS file. Doing this allows us to reuse both in both the new members/ill-requests.tt template and the pre-existing ill/ill-requests.tt template. To test: 1) Ensure ILL is enabled and your user has sufficient permissions 2) Ensure your user has some ILL requests 3) Navigate to the user's patron profile page 4) Click on the "Interlibrary loans" tab 5) Observe that the requests table is displayed inline 6) Observe that only your user's requests are displayed Signed-off-by: Niamh.Walker-Headon at it-tallaght.ie Bug 18589: (follow-up) Fix QA error Bug 18589: (follow-up) Fix QA failure This patch removes the id and class attributes on the body tag in: koha-tmpl/intranet-tmpl/prog/en/modules/members/ill-requests.tt To test: - Apply the patch - Run the QA tools - Note that the "Failed test '<body> tag with id and class attributes'" no longer is reported Bug 18589: (follow-up) Fix QA errors This patch fixes the "missing_filter" QA errors Bug 18589: (follow-up) Fix rebase errors Minor rebase errors Bug 18589: (follow-up) More merge errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 13:00:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 12:00:33 +0000 Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile In-Reply-To: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18589-70-WOIBlFGH1M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86432|0 |1 is obsolete| | --- Comment #15 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 86433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86433&action=edit Bug 18589: Show ILLs as part of patron profile This patch moves the display of a patron's ILL requests to be inline in the Patron Profile page, as per all other patron information. It includes a substantial refactor of koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt in that it moves the display of the illlist table (which is populated by an API request) into it's own separate include file. It also moves the datatable related Javascript for this table into it's own JS file. Doing this allows us to reuse both in both the new members/ill-requests.tt template and the pre-existing ill/ill-requests.tt template. To test: 1) Ensure ILL is enabled and your user has sufficient permissions 2) Ensure your user has some ILL requests 3) Navigate to the user's patron profile page 4) Click on the "Interlibrary loans" tab 5) Observe that the requests table is displayed inline 6) Observe that only your user's requests are displayed Signed-off-by: Niamh.Walker-Headon at it-tallaght.ie This is essentially a reimplementation of attachment 84796 to take into account all changes that had happened beneath this bug and also to ensure JS strings are translatable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 13:10:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 12:10:43 +0000 Subject: [Koha-bugs] [Bug 22486] Limit Patron expiry notices by category In-Reply-To: <bug-22486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22486-70-OwPGVTetS7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22486 Kelly McElligott <kelly at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly at bywatersolutions.com --- Comment #1 from Kelly McElligott <kelly at bywatersolutions.com> --- For example, libraries would like to be able to send Account Expiry to a group of patrons and not all the patrons that have account. Overdue notices are an excellent example of how Koha does this per patron category, however, the other notices - this can not be done. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 13:22:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 12:22:51 +0000 Subject: [Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events In-Reply-To: <bug-20750-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20750-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20750-70-mnKUlbdMBl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85829|0 |1 is obsolete| | Attachment #85830|0 |1 is obsolete| | Attachment #85831|0 |1 is obsolete| | Attachment #85832|0 |1 is obsolete| | Attachment #85833|0 |1 is obsolete| | Attachment #85834|0 |1 is obsolete| | Attachment #85835|0 |1 is obsolete| | Attachment #85836|0 |1 is obsolete| | Attachment #85837|0 |1 is obsolete| | Attachment #85838|0 |1 is obsolete| | Attachment #85839|0 |1 is obsolete| | Attachment #85840|0 |1 is obsolete| | Attachment #85841|0 |1 is obsolete| | Attachment #85842|0 |1 is obsolete| | Attachment #85843|0 |1 is obsolete| | Attachment #85844|0 |1 is obsolete| | Attachment #85845|0 |1 is obsolete| | Attachment #85846|0 |1 is obsolete| | Attachment #85847|0 |1 is obsolete| | Attachment #85848|0 |1 is obsolete| | --- Comment #135 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86434&action=edit Bug 20750: Allow logging of arbitrary actions This patch allows logging of arbitrary actions on request objects. A chronological summary of these actions can then be displayed when viewing a request. This patch also adds logging of request status changes. Additional work has been done on the BLDSS backend to log requests to the BLDSS request status check API. To test: - Apply patch - Ensure the Illlog logging preference is turned on - Create an ILL request and perform actions on it that change it's status. - Navigate to the "Manage ILL request" screen - Click the "Display request log" button - Observe that a modal opens displaying a summary of the status changes. Signed-off-by: Niamh Walker <Niamh.Walker-Headon at it-tallaght.ie> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Since this bug now is dependent on Bug 20581, it should be aware of the custom statuses provided in 20581. This patch enables logging of request statuses being changed to custom ones. As such the test plan is modified: To test: - Apply patch - Ensure the Illlog logging preference is turned on - Ensure you have some custom request statuses defined in the Authorised Values ILLSTATUS category - Create an ILL request and perform actions on it that change it's status. - Edit the request and change status to a custom one - Navigate to the "Manage ILL request" screen - Click the "Display request log" button - Observe that a modal opens displaying a summary of the status changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 13:22:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 12:22:56 +0000 Subject: [Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events In-Reply-To: <bug-20750-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20750-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20750-70-wuzFWSjdAj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750 --- Comment #136 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86435&action=edit Bug 20750: Add unit tests Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Bug 20750: (follow-up) Remove status_alias test This test is now redundant. We can't test the return of $req->status_alias against the value of $req->{status_alias} any more since we've overloaded the status_alias method and it won't always return the value of the object's property. We test the functionality of the status_alias method elsewhere so we're still covered. Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 13:23:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 12:23:00 +0000 Subject: [Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events In-Reply-To: <bug-20750-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20750-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20750-70-NTXNQmTv2H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750 --- Comment #137 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86436&action=edit Bug 20750: (QA follow-up) Fix templates Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 13:24:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 12:24:04 +0000 Subject: [Koha-bugs] [Bug 22477] Missing DataTables configuration when searching patrons for holds In-Reply-To: <bug-22477-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22477-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22477-70-RI1NQdVTO3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22477 --- Comment #5 from Owen Leonard <oleonard at myacpl.org> --- (In reply to Katrin Fischer from comment #4) > Should the columns be configurable? Maybe, but I think that would be a different bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 13:31:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 12:31:02 +0000 Subject: [Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events In-Reply-To: <bug-20750-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20750-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20750-70-Rwfne7TWxE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off --- Comment #138 from Josef Moravec <josef.moravec at gmail.com> --- Setting back to signed off, would be nice to have another QA team member look. Katrin? ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 13:36:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 12:36:05 +0000 Subject: [Koha-bugs] [Bug 22491] New: Borrowers should be searchable by surname Message-ID: <bug-22491-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22491 Bug ID: 22491 Summary: Borrowers should be searchable by surname Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs at lists.koha-community.org Reporter: andrew.isherwood at ptfs-europe.com Target Milestone: --- When creating an ILL request, it is currently possible to search for borrowers by cardnumber and username. There is a requirement for them to be searchable by surname -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 13:36:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 12:36:20 +0000 Subject: [Koha-bugs] [Bug 22491] Borrowers should be searchable by surname In-Reply-To: <bug-22491-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22491-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22491-70-YuLfCfMbiE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22491 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18589 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 [Bug 18589] Show ILLs as part of patron profile -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 13:36:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 12:36:20 +0000 Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile In-Reply-To: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18589-70-Hr48K1mHBc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22491 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22491 [Bug 22491] Borrowers should be searchable by surname -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 13:38:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 12:38:29 +0000 Subject: [Koha-bugs] [Bug 11375] Improve patrons permissions display In-Reply-To: <bug-11375-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11375-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11375-70-C7FU7xxitY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 13:38:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 12:38:37 +0000 Subject: [Koha-bugs] [Bug 11375] Improve patrons permissions display In-Reply-To: <bug-11375-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11375-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11375-70-GjKAjTluxM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 --- Comment #35 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86438&action=edit Bug 11375: (follow-up) Add links to show all/hide all This patch adds links in the toolbar to show or hide all sub-permissions. To test, apply the patch and view the permissions page for a patron. Clicking the "Show all" or "Hide all" links should work to show or hide all sub-permissions. The corresponding "Show details" and "Hide details" links for each permission set should be correctly toggled. Signed-off-by: Maryse Simard <maryse.simard at inlibro.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 13:38:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 12:38:41 +0000 Subject: [Koha-bugs] [Bug 11375] Improve patrons permissions display In-Reply-To: <bug-11375-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11375-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11375-70-ZfcZfgKoAh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 --- Comment #36 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86439&action=edit Bug 11375: (QA follow-up) Fix typo Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 13:38:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 12:38:45 +0000 Subject: [Koha-bugs] [Bug 11375] Improve patrons permissions display In-Reply-To: <bug-11375-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11375-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11375-70-QpioDJJPDJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 --- Comment #37 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86440&action=edit Bug 11375: (QA follow-up) Remove some more treeview occurences Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 13:38:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 12:38:33 +0000 Subject: [Koha-bugs] [Bug 11375] Improve patrons permissions display In-Reply-To: <bug-11375-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11375-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11375-70-Ehu9VPANyS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85622|0 |1 is obsolete| | Attachment #85623|0 |1 is obsolete| | Attachment #85624|0 |1 is obsolete| | Attachment #85625|0 |1 is obsolete| | --- Comment #34 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86437&action=edit Bug 11375: Improve patrons permissions display This patch updates the patron permissions interface in order to emphasize permission descriptions (which can be translated) over permission code (which cannot). The tree structure (and jQuery plugin) is removed, and permissions are displayed in a table-like way. Sub-permissions are shown or hidden with a link. A free-text filter is added to the top for narrowing the list by keyword. Save and cancel buttons are now in a floating toolbar. To test, apply the patch, regenerate the staff client CSS, and clear your browser cache if necessary. - Open the "Set permissions" page for any patron. - Confirm that the filter works correctly to show only lines which match your entry - Note that the superlibrarian line stays visible all the time. This is to make it clearer that sub-permissions cannot be selected if superlibrarian is checked. - Check the superlibrarain "hint" text for clarity. - Test the show/hide controls. - Test that checking a "parent" permission displays the sub-permissions. - Test that the toolbar with Save and Cancel floats when scrolling. - Test that changing and saving permissions works correctly. Signed-off-by: Maryse Simard <maryse.simard at inlibro.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 13:40:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 12:40:25 +0000 Subject: [Koha-bugs] [Bug 11375] Improve patrons permissions display In-Reply-To: <bug-11375-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11375-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11375-70-XdWoBO8OtL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 --- Comment #38 from Josef Moravec <josef.moravec at gmail.com> --- Rebased, conflict with bug 15774, which added new permission manage_additional_field -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 13:44:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 12:44:52 +0000 Subject: [Koha-bugs] [Bug 22475] Shelving location doesn't appear on tags list view In-Reply-To: <bug-22475-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22475-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22475-70-HOf4agPt9P@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22475 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #3 from Owen Leonard <oleonard at myacpl.org> --- Did you apply the patch for Bug 22422 first? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 14:10:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 13:10:16 +0000 Subject: [Koha-bugs] [Bug 11375] Improve patrons permissions display In-Reply-To: <bug-11375-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11375-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11375-70-L8OO2Lazik@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #39 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 14:10:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 13:10:49 +0000 Subject: [Koha-bugs] [Bug 19046] IntranetCatalogSearchPulldown doesn't retain last selection In-Reply-To: <bug-19046-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19046-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19046-70-vNMtBMsNeM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19046 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 14:10:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 13:10:28 +0000 Subject: [Koha-bugs] [Bug 17496] install-CPAN.pl documentation/removal In-Reply-To: <bug-17496-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17496-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17496-70-o5yXC6ICSW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17496 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 14:11:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 13:11:02 +0000 Subject: [Koha-bugs] [Bug 19489] Detailed description of charges on Accounting tab In-Reply-To: <bug-19489-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19489-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19489-70-gT23eqltz1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #58 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 14:11:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 13:11:16 +0000 Subject: [Koha-bugs] [Bug 21030] Date widget on suspend modal not working correctly In-Reply-To: <bug-21030-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21030-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21030-70-mzf2i8hycu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21030 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #7 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 14:11:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 13:11:49 +0000 Subject: [Koha-bugs] [Bug 21091] Move add item template JavaScript to a separate file In-Reply-To: <bug-21091-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21091-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21091-70-BaCrCqH4U6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21091 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #19 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 14:12:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 13:12:05 +0000 Subject: [Koha-bugs] [Bug 22045] Cataloging UX enhancement - Improve access to tabs In-Reply-To: <bug-22045-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22045-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22045-70-hvPuMrOHys@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #32 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 14:12:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 13:12:50 +0000 Subject: [Koha-bugs] [Bug 22363] Move C4::Logs::GetLogs to Koha namespace In-Reply-To: <bug-22363-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22363-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22363-70-qkbJAcsEfF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #26 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 14:13:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 13:13:10 +0000 Subject: [Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints In-Reply-To: <bug-22368-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22368-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22368-70-GTie8eeGe9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #50 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 14:13:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 13:13:25 +0000 Subject: [Koha-bugs] [Bug 22392] TestBuilder::build_sample_item should allow defining barcode In-Reply-To: <bug-22392-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22392-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22392-70-GeEYNtzbOT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22392 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 14:13:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 13:13:40 +0000 Subject: [Koha-bugs] [Bug 22422] improve item location display with class "shelvingloc" In-Reply-To: <bug-22422-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22422-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22422-70-w1gFybXcyC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22422 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 14:13:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 13:13:52 +0000 Subject: [Koha-bugs] [Bug 22442] Item search CSV export broken In-Reply-To: <bug-22442-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22442-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22442-70-u4QNNXwzag@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22442 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #4 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 14:14:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 13:14:06 +0000 Subject: [Koha-bugs] [Bug 22452] Typos in add a comment to Mana modal In-Reply-To: <bug-22452-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22452-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22452-70-xTVx89eaT0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22452 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 14:21:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 13:21:58 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18736-70-6TR6BEOgIK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #164 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Martin Renvoize from comment #163) > I think I'm happy with Nicks logic here.. > > Unfortunately, as we store calculated values we're open to having issues > like this. EDI for example can often give you both tax inclusive and tax > exclusive values and pretty often the rounding math at their end will be > different from at our end and so yield different results. > > I think this patch improves the situation a fair amount and is a good > compromise given our existing codebase.. perhaps it's the foundations for > more work in a followup bug but I don't think that should hold up this work > any longer really.. > > Did you have any more specific issues Marcel, that Nick could go on for > keeping this moving? Will have a look this week -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 14:26:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 13:26:52 +0000 Subject: [Koha-bugs] [Bug 2500] Standing enhancement request for adding/updating call number splitting algorithms in C4/Labels.pm In-Reply-To: <bug-2500-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-2500-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2500-70-QIWjDcDDVZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2500 ?talo <italo.barbosa.brasileiro at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |italo.barbosa.brasileiro at gm | |ail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 14:32:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 13:32:29 +0000 Subject: [Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead) In-Reply-To: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21756-70-DOJRJYnx26@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 14:32:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 13:32:33 +0000 Subject: [Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead) In-Reply-To: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21756-70-keuvQZBe1D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86265|0 |1 is obsolete| | Attachment #86266|0 |1 is obsolete| | Attachment #86267|0 |1 is obsolete| | Attachment #86268|0 |1 is obsolete| | Attachment #86269|0 |1 is obsolete| | Attachment #86270|0 |1 is obsolete| | Attachment #86271|0 |1 is obsolete| | Attachment #86272|0 |1 is obsolete| | Attachment #86273|0 |1 is obsolete| | Attachment #86274|0 |1 is obsolete| | Attachment #86275|0 |1 is obsolete| | Attachment #86276|0 |1 is obsolete| | --- Comment #105 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 86441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86441&action=edit Bug 21756: Remove use of manualinvoice from Koha::Patron Known Side Effect: Prior to this patch enrolment fees were not recorded in the FinesLog. After this patch, if the FinesLog is enabled then the 'action' will be recorded as `create_account`. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 14:32:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 13:32:56 +0000 Subject: [Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead) In-Reply-To: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21756-70-1ibr6SJeE5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #107 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 86443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86443&action=edit Bug 21756: Replace manualinvoice with add_debit in tests Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 14:33:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 13:33:00 +0000 Subject: [Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead) In-Reply-To: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21756-70-bruSb0T0PY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #108 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 86444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86444&action=edit Bug 21756: Add deprecation warning to manualinvoice https://bugs.koha-community.org/show_bug.cgi?id=21756 Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 14:33:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 13:33:03 +0000 Subject: [Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead) In-Reply-To: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21756-70-wa2Gn0uckc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #109 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 86445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86445&action=edit Bug 21756: (QA follow-up) Fix for 'Spurious text after =cut' Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 14:33:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 13:33:07 +0000 Subject: [Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead) In-Reply-To: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21756-70-M1acoTSAJ4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #110 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 86446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86446&action=edit Bug 21756: (QA follow-up) Correct the test for 'Lost Item' offsets Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 14:33:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 13:33:10 +0000 Subject: [Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead) In-Reply-To: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21756-70-JNTiwz4vIR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #111 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 86447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86447&action=edit Bug 21756: (QA follow-up) Fix Circulation.t Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 14:32:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 13:32:53 +0000 Subject: [Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead) In-Reply-To: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21756-70-f8zeS2IQcx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #106 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 86442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86442&action=edit Bug 21756: Remove use of manualinvoice from Koha::Hold Known Side Effect: Prior to this patch hold cancellation fees were not recorded in the FinesLog. After this patch, if the FinesLog is enabled then the 'action' will be recorded as `create_hold_expiration`. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 14:33:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 13:33:14 +0000 Subject: [Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead) In-Reply-To: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21756-70-fri3CWK8jE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #112 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 86448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86448&action=edit Bug 21756: (follow-up) Add test for deprecation warning Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 14:33:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 13:33:17 +0000 Subject: [Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead) In-Reply-To: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21756-70-c1yj0nWuLK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #113 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 86449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86449&action=edit Bug 21756: (follow-up) Replace newly introduced manualinvoice call Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 14:33:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 13:33:20 +0000 Subject: [Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead) In-Reply-To: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21756-70-5S4qdWIc59@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #114 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 86450 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86450&action=edit Bug 21756: (QA follow-up) Add `Account Fee` mapping Required for add_enrolement_fee_if_needed within Koha::Patron Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 14:33:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 13:33:24 +0000 Subject: [Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead) In-Reply-To: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21756-70-ueraIaTgRX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #115 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 86451 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86451&action=edit Bug 21756: (QA follow-up) Add offset_types to database Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 14:33:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 13:33:27 +0000 Subject: [Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead) In-Reply-To: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21756-70-ZzJZTOfiAU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 --- Comment #116 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 86452 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86452&action=edit Bug 21756: (QA follow-up) Add offest types to installer file Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 14:42:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 13:42:29 +0000 Subject: [Koha-bugs] [Bug 22491] Borrowers should be searchable by surname In-Reply-To: <bug-22491-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22491-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22491-70-OeJ9gIsAum@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22491 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Andrew, maybe you could use the existing pattern for patron searching? Examples: - Searching for a patron to add to routing lists - Searching for patrons to add to orders (inform on receive) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 14:42:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 13:42:47 +0000 Subject: [Koha-bugs] [Bug 22491] Patrons should be searchable by surname In-Reply-To: <bug-22491-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22491-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22491-70-RhRgLhTLwT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22491 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Borrowers should be |Patrons should be |searchable by surname |searchable by surname -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 14:49:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 13:49:03 +0000 Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC In-Reply-To: <bug-14567-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14567-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14567-70-5K4FTf6fnk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 14:49:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 13:49:06 +0000 Subject: [Koha-bugs] [Bug 14567] Browse interface for OPAC In-Reply-To: <bug-14567-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14567-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14567-70-usqwjROJ0D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14567 --- Comment #52 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 86453 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86453&action=edit Bug 14567: (follow-up) Rename pref and move to Opac section -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 14:50:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 13:50:27 +0000 Subject: [Koha-bugs] [Bug 21943] Clean up holds template In-Reply-To: <bug-21943-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21943-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21943-70-VerXfXqOCC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21943 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 14:50:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 13:50:29 +0000 Subject: [Koha-bugs] [Bug 21943] Clean up holds template In-Reply-To: <bug-21943-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21943-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21943-70-6mIefEmwAx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21943 --- Comment #3 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 86454 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86454&action=edit Bug 21943: (follow-up) Fix float error with sidebar menu This patch makes a minor change to the staff client CSS to fix a float clearing problem when the <main> element contains only a floated element like <fieldset>. It is a global change, but shouldn't cause unwanted effects because a non-clearing <main> isn't used in any float-dependent layouts. To test, apply the patch and regenerate the staff client CSS. View the place hold screen and confirm that the sidebar menu looks correct at narrower browser widths. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 15:06:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 14:06:37 +0000 Subject: [Koha-bugs] [Bug 20830] Make sure a fund is selected when ordering from staged file In-Reply-To: <bug-20830-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20830-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20830-70-WoOw4FIla0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20830 --- Comment #7 from Koha Team Lyon 3 <koha at univ-lyon3.fr> --- Created attachment 86455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86455&action=edit Bug 20830 : Make sure a fund is selected (master) patch done for master. previous one apply to 17.11.13 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 15:07:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 14:07:12 +0000 Subject: [Koha-bugs] [Bug 20830] Make sure a fund is selected when ordering from staged file In-Reply-To: <bug-20830-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20830-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20830-70-NINknX7F18@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20830 Koha Team Lyon 3 <koha at univ-lyon3.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 15:20:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 14:20:23 +0000 Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile In-Reply-To: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18589-70-dAyp8eXOsB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 --- Comment #16 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 86456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86456&action=edit Bug 18589: (follow-up) Remove redundant-ness Following feedback from Josef via IRC, removing redundant code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 15:30:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 14:30:09 +0000 Subject: [Koha-bugs] [Bug 22492] New: Advanced editor - Rancor - AdditionalFieldsInZ3950ResultSearch Message-ID: <bug-22492-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22492 Bug ID: 22492 Summary: Advanced editor - Rancor - AdditionalFieldsInZ3950ResultSearch Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: jzairo at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Target Milestone: --- With Bug 12747 we added the AdditionalFieldsInZ3950ResultSearch. This currently works in the z39.50 search for the basic editor and in the z39.50 search in acquisitions, but does not work when starting the z39.50 search in the advanced editor for cataloging. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 15:30:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 14:30:22 +0000 Subject: [Koha-bugs] [Bug 22492] Advanced editor - Rancor - AdditionalFieldsInZ3950ResultSearch In-Reply-To: <bug-22492-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22492-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22492-70-mvVbzIpyBb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22492 Jessie Zairo <jzairo at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 15:30:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 14:30:34 +0000 Subject: [Koha-bugs] [Bug 15400] Display patron age in useful places In-Reply-To: <bug-15400-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15400-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15400-70-8HNF8lLEaS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 15:30:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 14:30:36 +0000 Subject: [Koha-bugs] [Bug 22492] Advanced editor - Rancor - AdditionalFieldsInZ3950ResultSearch In-Reply-To: <bug-22492-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22492-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22492-70-qnJ9JFu1bl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22492 Jessie Zairo <jzairo at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12747 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 15:30:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 14:30:36 +0000 Subject: [Koha-bugs] [Bug 12747] Add configurable extra column in Z3950 search result In-Reply-To: <bug-12747-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12747-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12747-70-7d0wTflFHp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12747 Jessie Zairo <jzairo at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22492 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 15:30:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 14:30:42 +0000 Subject: [Koha-bugs] [Bug 15400] Display patron age in useful places In-Reply-To: <bug-15400-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15400-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15400-70-i7pnMhuqNK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 --- Comment #26 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86458&action=edit Bug 15400: (follow-up) Updating text display Now shows as 'Born: [date of birth] (age)' in circ sidebar menu and search results Sponsored-by: Catalyst IT Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 15:30:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 14:30:38 +0000 Subject: [Koha-bugs] [Bug 15400] Display patron age in useful places In-Reply-To: <bug-15400-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15400-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15400-70-23pE2ElHjG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85495|0 |1 is obsolete| | Attachment #85496|0 |1 is obsolete| | Attachment #85497|0 |1 is obsolete| | --- Comment #25 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86457&action=edit Bug 15400: Display date of birth and age more consistantly Test plan: 0) Apply the patch 1) Go to all of these pages Patron detail Other patron pages - look on the left side (circ-menu) Patron search Guarantor search ( go to child patron -> edit -> in guarantor section click "Set to patron" Search through "Check out" (in the header) 2) Confirm that does show date of birth and date consistantly, try it on patrons with and without date of birth set to find possible reggressions Signed-off-by: Aleisha Amohia <aleishaamohia at hotmail.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 15:30:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 14:30:46 +0000 Subject: [Koha-bugs] [Bug 15400] Display patron age in useful places In-Reply-To: <bug-15400-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15400-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15400-70-kioyrOoeQu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 --- Comment #27 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86459&action=edit Bug 15400: (follow-up) Adding age to check out search dropdown Confirm age shows in the suggestions dropdown when using the checkout search in header (if user set DOB). Confirm 'Age unknown' shows if no DOB set. Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr> Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 15:30:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 14:30:50 +0000 Subject: [Koha-bugs] [Bug 15400] Display patron age in useful places In-Reply-To: <bug-15400-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15400-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15400-70-3IflHOTpjg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 --- Comment #28 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86460&action=edit Bug 15400: (follow-up) Restore 'years' string, remove untranslatable string -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 15:46:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 14:46:26 +0000 Subject: [Koha-bugs] [Bug 22493] New: DecreaseLoanHighHolds.t creates some items/patrons with set values Message-ID: <bug-22493-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22493 Bug ID: 22493 Summary: DecreaseLoanHighHolds.t creates some items/patrons with set values Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- We have been getting some random failures here. We are setting some barcodes and cardnumbers by hand as well as deleting lots of data. We should clean this up to see if it helps. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 15:48:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 14:48:20 +0000 Subject: [Koha-bugs] [Bug 22493] DecreaseLoanHighHolds.t creates some items/patrons with set values In-Reply-To: <bug-22493-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22493-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22493-70-a7pTRDdLRs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22493 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 15:48:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 14:48:22 +0000 Subject: [Koha-bugs] [Bug 22493] DecreaseLoanHighHolds.t creates some items/patrons with set values In-Reply-To: <bug-22493-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22493-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22493-70-ECtYsYglDT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22493 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 86461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86461&action=edit Bug 22493: Clean up DecreaseLoanHighHolds.t To test: 1 - prove -v t/db_dependent/DecreaseLoanHighHolds.t 2 - should pass 3 - read code, confirm changes make sense -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 15:49:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 14:49:01 +0000 Subject: [Koha-bugs] [Bug 22493] DecreaseLoanHighHolds.t creates some items/patrons with set values In-Reply-To: <bug-22493-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22493-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22493-70-0fvXyhCPk1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22493 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |martin.renvoize at ptfs-europe | |.com Assignee|chris at bigballofwax.co.nz |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 15:51:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 14:51:05 +0000 Subject: [Koha-bugs] [Bug 21307] Switch two-column templates to Bootstrap grid: Cataloging In-Reply-To: <bug-21307-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21307-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21307-70-hLKTphqgS7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21307 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 15:51:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 14:51:08 +0000 Subject: [Koha-bugs] [Bug 21307] Switch two-column templates to Bootstrap grid: Cataloging In-Reply-To: <bug-21307-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21307-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21307-70-FMFHxso74p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21307 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86085|0 |1 is obsolete| | Attachment #86086|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 86462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86462&action=edit Bug 21307: Switch two-column templates to Bootstrap grid: Cataloging This patch modifies two cataloging templates to use the Bootstrap grid instead of YUI. To test, apply the patch and view the following pages, confirming that they look correct at various browser widths: - Cataloging -> Edit record using the advanced editor - Cataloging -> Edit items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 15:51:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 14:51:12 +0000 Subject: [Koha-bugs] [Bug 21307] Switch two-column templates to Bootstrap grid: Cataloging In-Reply-To: <bug-21307-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21307-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21307-70-LGI6U0nwKO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21307 --- Comment #9 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 86463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86463&action=edit Bug 21307: (follow-up) Change the way Codemirror height is calculated This follow-up changes the way the height of the Codemirror editor is calculated. Using offset() instead of position() returns the correct values with the changed markup. To test, apply the patch and load the advanced MARC editor. The "status bar" should display correctly a the bottom of the editor and there should be no double scrollbar. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 15:51:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 14:51:16 +0000 Subject: [Koha-bugs] [Bug 21307] Switch two-column templates to Bootstrap grid: Cataloging In-Reply-To: <bug-21307-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21307-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21307-70-4pt42DXVZD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21307 --- Comment #10 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 86464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86464&action=edit Bug 21307: (follow-up) QA fixes This patch corrects a couple of issues discovered by QA: Removed markup copy-and-paste error; Add some CSS to help the responsive behavior of the advanced editor controls at smaller browser widths. To test, apply the patch and open the advanced MARC editor. Test the appearance of the page at various browser widths. At narrower widths the status bar and search fields should behave well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 16:08:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 15:08:57 +0000 Subject: [Koha-bugs] [Bug 20384] Elastic rebuild script improvements - options for indexing In-Reply-To: <bug-20384-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20384-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20384-70-170ixUYAC7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20384 dominique.rouger at univ-st-etienne.fr changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dominique.rouger at univ-st-et | |ienne.fr --- Comment #1 from dominique.rouger at univ-st-etienne.fr --- It could also be useful to have an option to launch an indexing by decrementing the record number -w "100,2" index 2 biblio with biblionumber after 100th (101 and 102) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 16:13:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 15:13:21 +0000 Subject: [Koha-bugs] [Bug 20384] Elastic rebuild script improvements - options for indexing In-Reply-To: <bug-20384-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20384-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20384-70-dcVUzqD9An@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20384 --- Comment #2 from dominique.rouger at univ-st-etienne.fr --- It could also be useful to have an option to launch an indexing by decrementing the record number -w "100,2" index 2 biblio with biblionumber after 100th (101 and 102) and -w "100,-2" index 2 biblio with biblionumber before 100th (99 and 98) This allows the highest biblionumbers, i.e. the most recent records, to be indexed first. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 16:37:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 15:37:25 +0000 Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile In-Reply-To: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18589-70-Jtzsf2GQlc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #17 from Josef Moravec <josef.moravec at gmail.com> --- Andrew, thanks for quick rebase. I just run QA test tools and they are not happy: FAIL koha-tmpl/intranet-tmpl/prog/en/includes/ill-list-table-strings.inc FAIL forbidden patterns forbidden pattern: simple-quote string (line 2) forbidden pattern: simple-quote string (line 3) forbidden pattern: simple-quote string (line 5) forbidden pattern: simple-quote string (line 6) forbidden pattern: simple-quote string (line 7) forbidden pattern: simple-quote string (line 8) forbidden pattern: simple-quote string (line 9) forbidden pattern: simple-quote string (line 10) forbidden pattern: simple-quote string (line 11) forbidden pattern: simple-quote string (line 12) forbidden pattern: simple-quote string (line 14) forbidden pattern: simple-quote string (line 16) forbidden pattern: simple-quote string (line 17) FAIL koha-tmpl/intranet-tmpl/prog/en/includes/ill-list-table.inc FAIL forbidden patterns forbidden pattern: tab char (line 2) forbidden pattern: tab char (line 3) forbidden pattern: tab char (line 4) forbidden pattern: tab char (line 5) forbidden pattern: tab char (line 6) forbidden pattern: tab char (line 7) forbidden pattern: tab char (line 8) forbidden pattern: tab char (line 9) forbidden pattern: tab char (line 10) forbidden pattern: tab char (line 11) forbidden pattern: tab char (line 12) forbidden pattern: tab char (line 13) forbidden pattern: tab char (line 14) forbidden pattern: tab char (line 15) forbidden pattern: tab char (line 16) forbidden pattern: tab char (line 17) forbidden pattern: tab char (line 18) forbidden pattern: tab char (line 19) forbidden pattern: tab char (line 20) forbidden pattern: tab char (line 21) forbidden pattern: tab char (line 22) forbidden pattern: tab char (line 23) forbidden pattern: tab char (line 24) forbidden pattern: tab char (line 25) forbidden pattern: tab char (line 26) forbidden pattern: tab char (line 27) forbidden pattern: tab char (line 28) forbidden pattern: tab char (line 29) forbidden pattern: tab char (line 30) forbidden pattern: tab char (line 31) forbidden pattern: tab char (line 32) forbidden pattern: tab char (line 33) forbidden pattern: tab char (line 34) forbidden pattern: tab char (line 35) forbidden pattern: tab char (line 36) forbidden pattern: tab char (line 37) forbidden pattern: tab char (line 38) forbidden pattern: tab char (line 39) forbidden pattern: tab char (line 40) forbidden pattern: tab char (line 41) FAIL koha-tmpl/intranet-tmpl/prog/en/modules/members/ill-requests.tt FAIL forbidden patterns forbidden pattern: tab char (line 16) forbidden pattern: tab char (line 17) forbidden pattern: tab char (line 19) forbidden pattern: tab char (line 20) forbidden pattern: tab char (line 21) forbidden pattern: tab char (line 22) forbidden pattern: tab char (line 23) forbidden pattern: tab char (line 25) forbidden pattern: tab char (line 27) forbidden pattern: tab char (line 28) forbidden pattern: tab char (line 29) forbidden pattern: tab char (line 30) forbidden pattern: tab char (line 31) forbidden pattern: tab char (line 32) forbidden pattern: tab char (line 33) forbidden pattern: tab char (line 34) forbidden pattern: tab char (line 35) forbidden pattern: tab char (line 36) forbidden pattern: tab char (line 37) forbidden pattern: tab char (line 38) forbidden pattern: tab char (line 39) forbidden pattern: tab char (line 41) forbidden pattern: tab char (line 42) forbidden pattern: tab char (line 43) forbidden pattern: tab char (line 44) forbidden pattern: tab char (line 45) forbidden pattern: tab char (line 46) forbidden pattern: tab char (line 47) forbidden pattern: tab char (line 48) forbidden pattern: tab char (line 49) forbidden pattern: tab char (line 50) forbidden pattern: tab char (line 51) forbidden pattern: tab char (line 52) forbidden pattern: tab char (line 53) forbidden pattern: tab char (line 54) forbidden pattern: tab char (line 55) forbidden pattern: tab char (line 56) forbidden pattern: tab char (line 57) forbidden pattern: tab char (line 58) forbidden pattern: tab char (line 60) forbidden pattern: tab char (line 61) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 16:38:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 15:38:26 +0000 Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile In-Reply-To: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18589-70-aGR74mEQlR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 --- Comment #18 from Josef Moravec <josef.moravec at gmail.com> --- Also, it would be nice to have test for changes in Koha/REST/V1/Illrequests.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 17:01:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 16:01:15 +0000 Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile In-Reply-To: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18589-70-dD5xidg4zZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 17:01:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 16:01:33 +0000 Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile In-Reply-To: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18589-70-31CO1Lz5co@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 17:01:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 16:01:04 +0000 Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile In-Reply-To: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18589-70-CqavOF2l0O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 --- Comment #19 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 86465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86465&action=edit Bug 18589: (follow-up) Fix QA tool failures As per comment #17: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589#c17 Sorry Josef, I honestly have no idea where those tabs came from :( Every once in a while my copy of Vim decides to embarass me and stick in tabs instead of spaces... <shakes fist at screen> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 17:06:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 16:06:10 +0000 Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile In-Reply-To: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18589-70-sSJUz0LYaV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 --- Comment #20 from Josef Moravec <josef.moravec at gmail.com> --- 1) You are setting dateFormat on two places, but not use it anywhere. 2) In the ill requests list tables (both, in ill module and patron ill view) are shown columns placed_unformatted and updated_unformatted, only data, table header is blank. 3) There is error in js console, when load the ill request lista table in ill module ill-list-table_18.1200024.js:242 Uncaught TypeError: Cannot read property 'hasOwnProperty' of undefined at getStatusName (ill-list-table_18.1200024.js:242) at ill-list-table_18.1200024.js:34 at Array.forEach (<anonymous>) at Object.prep (ill-list-table_18.1200024.js:29) at a.fn.init.initComplete (ill-list-table_18.1200024.js:460) at jquery.dataTables.min_18.1200024.js:75 at Function.map (jquery-2.2.3.min_18.1200024.js:2) at v (jquery.dataTables.min_18.1200024.js:75) at ta (jquery.dataTables.min_18.1200024.js:49) at ia (jquery.dataTables.min_18.1200024.js:48) 3) when trying to filter by date placed, there is one more error in console: ill-list-table_18.1200024.js:519 Uncaught TypeError: Cannot read property 'api' of undefined at HTMLFormElement.<anonymous> (ill-list-table_18.1200024.js:519) at HTMLFormElement.dispatch (jquery-2.2.3.min_18.1200024.js:3) at HTMLFormElement.r.handle (jquery-2.2.3.min_18.1200024.js:3) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 17:10:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 16:10:02 +0000 Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile In-Reply-To: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18589-70-sD01IQfrL9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 --- Comment #21 from Josef Moravec <josef.moravec at gmail.com> --- (In reply to Josef Moravec from comment #18) > Also, it would be nice to have test for changes in > Koha/REST/V1/Illrequests.pm Test in this attachmend of 21460 is exactly what I mean: https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83184&action=diff we could move it here maybe... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 17:11:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 16:11:09 +0000 Subject: [Koha-bugs] [Bug 22023] Further improve responsive layout handling of staff client menu bar In-Reply-To: <bug-22023-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22023-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22023-70-c5RPABJbdh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22023 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 17:11:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 16:11:12 +0000 Subject: [Koha-bugs] [Bug 22023] Further improve responsive layout handling of staff client menu bar In-Reply-To: <bug-22023-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22023-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22023-70-6inePySHT8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22023 --- Comment #8 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 86466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86466&action=edit Bug 22023: (follow-up) Right-to-left layout improvements This patch makes some corrections to accommodate right-to-left layouts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 17:26:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 16:26:24 +0000 Subject: [Koha-bugs] [Bug 22477] Missing DataTables configuration when searching patrons for holds In-Reply-To: <bug-22477-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22477-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22477-70-ZjkuPe03Dq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22477 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86399|0 |1 is obsolete| | --- Comment #6 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86467&action=edit Bug 22477: Missing DataTables configuration when searching patrons for holds This patch adds columns configuration to the holds request page to fix a JavaScript error in the console and to allow the patron search results table to be enabled as a DataTable. To reproduce: Place a hold on a title in the staff client. When prompted for a patron, perform a search which will return multiple results. The patron search results will appear in an unsortable table. A JS error can be seen in the browser console. To test, apply the patch and repeat the steps above. The patron search results table should be sortable and there should be no JS error. Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com> Signed-off-by: Bin Wen <bin.wen at inlibro.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 17:27:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 16:27:28 +0000 Subject: [Koha-bugs] [Bug 22477] Missing DataTables configuration when searching patrons for holds In-Reply-To: <bug-22477-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22477-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22477-70-S42AIDCduN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22477 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | CC| |josef.moravec at gmail.com Status|Signed Off |Passed QA --- Comment #7 from Josef Moravec <josef.moravec at gmail.com> --- (In reply to Owen Leonard from comment #5) > (In reply to Katrin Fischer from comment #4) > > Should the columns be configurable? > > Maybe, but I think that would be a different bug. I agree, this patch fixes bug, enhancement could be done on another report -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 17:45:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 16:45:19 +0000 Subject: [Koha-bugs] [Bug 22219] C4::Biblio->GetItemsForInventory can return wrong count / duplicated items when skipping waiting holds In-Reply-To: <bug-22219-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22219-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22219-70-sDEf1qJc6k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22219 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 17:45:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 16:45:26 +0000 Subject: [Koha-bugs] [Bug 22219] C4::Biblio->GetItemsForInventory can return wrong count / duplicated items when skipping waiting holds In-Reply-To: <bug-22219-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22219-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22219-70-dDPFmbtAab@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22219 --- Comment #6 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86469&action=edit Bug 22219: Remove duplicated items in inventory (when skipping waiting holds) Test plan: 0/ Do not apply this patch 1/ Place several holds on a given item 2/ Use the inventory with the "skip waiting holds" option to list this item. It will be displayed several times 3/ Apply this patch and confirm that the item is now only displayed once Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 17:45:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 16:45:22 +0000 Subject: [Koha-bugs] [Bug 22219] C4::Biblio->GetItemsForInventory can return wrong count / duplicated items when skipping waiting holds In-Reply-To: <bug-22219-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22219-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22219-70-9tnVRJCxX6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22219 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86402|0 |1 is obsolete| | Attachment #86403|0 |1 is obsolete| | --- Comment #5 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86468&action=edit Bug 22219: Add tests Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 17:45:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 16:45:45 +0000 Subject: [Koha-bugs] [Bug 22219] C4::Biblio->GetItemsForInventory can return wrong count / duplicated items when skipping waiting holds In-Reply-To: <bug-22219-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22219-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22219-70-Cbtzh0mFZw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22219 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 18:16:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 17:16:56 +0000 Subject: [Koha-bugs] [Bug 22023] Further improve responsive layout handling of staff client menu bar In-Reply-To: <bug-22023-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22023-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22023-70-7EJQNLqIGV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22023 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Josef Moravec <josef.moravec at gmail.com> --- Owen, thanks for quick follow-up, but I still have some minor issues with this: https://screenshots.firefox.com/VWFAQUJcL2Jg9RAi/localhost -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 18:19:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 17:19:05 +0000 Subject: [Koha-bugs] [Bug 21683] Remove accountlines.accountno In-Reply-To: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21683-70-173IwELmSW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 18:19:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 17:19:11 +0000 Subject: [Koha-bugs] [Bug 21683] Remove accountlines.accountno In-Reply-To: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21683-70-CnuVvufIj5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86230|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 18:19:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 17:19:08 +0000 Subject: [Koha-bugs] [Bug 21683] Remove accountlines.accountno In-Reply-To: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21683-70-tugVnQj5JE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86336|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 18:19:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 17:19:13 +0000 Subject: [Koha-bugs] [Bug 21683] Remove accountlines.accountno In-Reply-To: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21683-70-yEVmaKsHVG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86231|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 18:19:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 17:19:16 +0000 Subject: [Koha-bugs] [Bug 21683] Remove accountlines.accountno In-Reply-To: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21683-70-hybRrjt1k8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86232|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 18:19:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 17:19:18 +0000 Subject: [Koha-bugs] [Bug 21683] Remove accountlines.accountno In-Reply-To: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21683-70-mNAsLob4QQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86233|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 18:19:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 17:19:21 +0000 Subject: [Koha-bugs] [Bug 21683] Remove accountlines.accountno In-Reply-To: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21683-70-gunZAj4Tuy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86234|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 18:20:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 17:20:02 +0000 Subject: [Koha-bugs] [Bug 21683] Remove accountlines.accountno In-Reply-To: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21683-70-QIiUEBdgdt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 --- Comment #43 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 86470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86470&action=edit Bug 21683: Database update Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 18:20:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 17:20:12 +0000 Subject: [Koha-bugs] [Bug 21683] Remove accountlines.accountno In-Reply-To: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21683-70-mIWQsr9fCZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 --- Comment #45 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 86472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86472&action=edit Bug 21683: (follow-up) Polish the change - based on feedback Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 18:20:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 17:20:16 +0000 Subject: [Koha-bugs] [Bug 21683] Remove accountlines.accountno In-Reply-To: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21683-70-1iYz5hmBeh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 --- Comment #46 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 86473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86473&action=edit Bug 21683: (QA follow-up) Koha::Account::Line rebase fix Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 18:20:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 17:20:20 +0000 Subject: [Koha-bugs] [Bug 21683] Remove accountlines.accountno In-Reply-To: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21683-70-gMGcKMH7D6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 --- Comment #47 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 86474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86474&action=edit Bug 21683: (QA follow-up) Drop statistics.proccode Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 18:20:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 17:20:24 +0000 Subject: [Koha-bugs] [Bug 21683] Remove accountlines.accountno In-Reply-To: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21683-70-258ebrpNFj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 --- Comment #48 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 86475 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86475&action=edit Bug 21683: (follow-up) Remove last occurences of statistics.proccode columns.def is used to define descriptions of db columns in guided reports test is not useful anymore IMO Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 18:20:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 17:20:07 +0000 Subject: [Koha-bugs] [Bug 21683] Remove accountlines.accountno In-Reply-To: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21683-70-C4m4Oey8nj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 --- Comment #44 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 86471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86471&action=edit Bug 21683: Remove accountlines.accountno Test plan: 1) Play with fines, should work OK 2) Try to print receipts on fines - prinfeercpt.pl, printinvoice.pl 3) git grep getnextacctno -> no occurences 4) git grep accountno should return only: installer/data/mysql/atomicupdate/bug_21683_remove_column_accountno.perl installer/data/mysql/update22to30.pl misc/release_notes/release_notes_3_10_0.txt misc/release_notes/release_notes_3_22_0.txt 5) prove t/db_dependent/Accounts.t t/db_dependent/ILSDI_Services.t t/db_dependent/Stats.t t/db_dependent/Koha/Account.t Rescued-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 18:29:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 17:29:39 +0000 Subject: [Koha-bugs] [Bug 22493] DecreaseLoanHighHolds.t creates some items/patrons with set values In-Reply-To: <bug-22493-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22493-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22493-70-nBxEv07F9F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22493 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 18:29:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 17:29:41 +0000 Subject: [Koha-bugs] [Bug 22493] DecreaseLoanHighHolds.t creates some items/patrons with set values In-Reply-To: <bug-22493-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22493-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22493-70-60xTyKtvhi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22493 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86461|0 |1 is obsolete| | --- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 86476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86476&action=edit Bug 22493: Clean up DecreaseLoanHighHolds.t To test: 1 - prove -v t/db_dependent/DecreaseLoanHighHolds.t 2 - should pass 3 - read code, confirm changes make sense Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 18:59:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 17:59:25 +0000 Subject: [Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel In-Reply-To: <bug-20959-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20959-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20959-70-i39kwgjzft@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82995|0 |1 is obsolete| | Attachment #82996|0 |1 is obsolete| | Attachment #82997|0 |1 is obsolete| | Attachment #83180|0 |1 is obsolete| | Attachment #83772|0 |1 is obsolete| | --- Comment #33 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 86477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86477&action=edit Bug 20959: Style checkin form more like the checkout form, with collapsed settings panel This patch modifies the structure of the checkin form so that settings (Specify return date, book drop mode, forgive overdue charges) are in a collapsed panel when inactive. The style of the barcode field and the mode notification messages has been changed to reduce the vertical motion of the form when selecting options. Some class names have been changed in circulation.tt and circulation.js to make them appropriate for use on both forms. To test, apply the patch and clear your browser cache if necessary. - View the checkin page. The "checkin settings" panel should be collapsed by default. - Confirm that the settings panel collapses and expands as it should. - Confirm that selecting "Forgive overdue charges" or "Book drop mode" trigger the display of the correct message and that the style of the barcode field is changed. - Confirm that after submitting a barcode for check-in, the settings panel stays open and your selected settings are still selected. - Test with CircSidebar enabled and disabled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 18:59:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 17:59:22 +0000 Subject: [Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel In-Reply-To: <bug-20959-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20959-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20959-70-3LChU0vbmt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 19:01:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 18:01:01 +0000 Subject: [Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel In-Reply-To: <bug-20959-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20959-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20959-70-jdHd3d0Tzy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 --- Comment #34 from Owen Leonard <oleonard at myacpl.org> --- The rebase for this was tedious enough that I think it could use another look in the form of a signoff. Please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 19:18:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 18:18:21 +0000 Subject: [Koha-bugs] [Bug 22023] Further improve responsive layout handling of staff client menu bar In-Reply-To: <bug-22023-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22023-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22023-70-xbH59MBkCa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22023 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 19:18:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 18:18:24 +0000 Subject: [Koha-bugs] [Bug 22023] Further improve responsive layout handling of staff client menu bar In-Reply-To: <bug-22023-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22023-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22023-70-SynEO1y9WG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22023 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86466|0 |1 is obsolete| | --- Comment #10 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 86478 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86478&action=edit Bug 22023: (follow-up) Right-to-left layout improvements This patch makes some corrections to accommodate right-to-left layouts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 19:27:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 18:27:11 +0000 Subject: [Koha-bugs] [Bug 22330] Transfer limits should be respected for placing holds in staff interface and APIs In-Reply-To: <bug-22330-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22330-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22330-70-gHbg6dsz3v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22330 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85067|0 |1 is obsolete| | Attachment #85068|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 86479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86479&action=edit Bug 22330: Transfer limits should be respected for placing holds in staff interface and APIs Branch transfer limits are respected for placing holds in the OPAC but nowhere else. This should be remedied. Test Plan: 1) Set up a branch transfer limit from Library A to Library B 2) Verify you cannot set up a hold for an item from Library A for pickup at Library B from the staff interface ( without overriding ) 3) Verify you cannot place that hold via ILS-DI 4) Verify you cannot place that hold via SIP 4) Verify a forced hold from Library A to Library B will not show up in the holds queue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 19:32:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 18:32:02 +0000 Subject: [Koha-bugs] [Bug 22004] When decreaseLoanHighHolds is set to Enable, suspended holds still count in the number of holds In-Reply-To: <bug-22004-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22004-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22004-70-mHsu0c0lyX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22004 Christofer <christofer.zorn at ajaxlibrary.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christofer.zorn at ajaxlibrary | |.ca --- Comment #1 from Christofer <christofer.zorn at ajaxlibrary.ca> --- We had the same issue where a patron was trying to check out their own hold, on a book with a suspended hold. The system reduced the loan period as it saw two holds on the account, when in actuality there was really only one active hold. Could this be changed to only count active holds as we have many people place a hold on an item and then suspend the hold for months. Thanks Christofer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 19:36:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 18:36:35 +0000 Subject: [Koha-bugs] [Bug 21772] Add holds and account information tab to the SCO module In-Reply-To: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21772-70-15S5p4VD2O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 Sarah Cornell <sbcornell at cityofportsmouth.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbcornell at cityofportsmouth. | |com --- Comment #6 from Sarah Cornell <sbcornell at cityofportsmouth.com> --- Agust?n, I tested the patch and the functionality works. Is it possible to include more information in the tab labels in SCO, as it is displayed in opac-user.pl? Such as: Checkouts (0) Holds (1) Fines and charges (16.99) Thanks, Sarah -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 19:37:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 18:37:12 +0000 Subject: [Koha-bugs] [Bug 22330] Transfer limits should be respected for placing holds in staff interface and APIs In-Reply-To: <bug-22330-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22330-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22330-70-xNExPCbrxO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22330 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86479|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 86480 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86480&action=edit Bug 22330: Transfer limits should be respected for placing holds in staff interface and APIs Branch transfer limits are respected for placing holds in the OPAC but nowhere else. This should be remedied. Test Plan: 1) Set up a branch transfer limit from Library A to Library B 2) Verify you cannot set up a hold for an item from Library A for pickup at Library B from the staff interface ( without overriding ) 3) Verify you cannot place that hold via ILS-DI 4) Verify you cannot place that hold via SIP 4) Verify a forced hold from Library A to Library B will not show up in the holds queue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 19:37:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 18:37:21 +0000 Subject: [Koha-bugs] [Bug 22330] Transfer limits should be respected for placing holds in staff interface and APIs In-Reply-To: <bug-22330-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22330-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22330-70-esyQS4FEyt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22330 --- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 86481 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86481&action=edit Bug 22330: Cache item and library objects when building the holds queue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 19:37:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 18:37:23 +0000 Subject: [Koha-bugs] [Bug 22330] Transfer limits should be respected for placing holds in staff interface and APIs In-Reply-To: <bug-22330-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22330-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22330-70-jnY11zoIN7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22330 --- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 86482 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86482&action=edit Bug 22330: (QA follow-up) Remove duplicate use lines, combine and sort remaning lines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 19:56:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 18:56:11 +0000 Subject: [Koha-bugs] [Bug 22476] MarkLostItemsAsReturned has wrong defaults for new installs In-Reply-To: <bug-22476-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22476-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22476-70-oCRZt0c2oK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22476 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 20:02:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 19:02:16 +0000 Subject: [Koha-bugs] [Bug 21846] Using emoji as tags doesn't discriminate between emoji when calculating weights or searching In-Reply-To: <bug-21846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21846-70-IflGYbvaGK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #42 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- This looks solid to me and seems to work.. can this go to PQA Josef.. or are you waiting on some further feedback here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 20:24:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 19:24:01 +0000 Subject: [Koha-bugs] [Bug 22477] Missing DataTables configuration when searching patrons for holds In-Reply-To: <bug-22477-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22477-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22477-70-Vn5X1d1hbf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22477 --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I agree too - looking at the change I was just wondering, if it should be: columns_settings_borrowers_table = [% ColumnsSettings.GetColumns( 'circ', 'circulation', 'table_borrowers', 'json' ) | $raw %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 20:47:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 19:47:35 +0000 Subject: [Koha-bugs] [Bug 22489] Onboarding tool fails due to inserting maxissueqty into IssuingRule In-Reply-To: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22489-70-qmkqwu4NZ5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22489 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P2 CC| |wizzyrea at gmail.com Severity|major |blocker --- Comment #1 from Liz Rea <wizzyrea at gmail.com> --- We can't have a release with this broken. Thanks for filing the bug, I spotted this too. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 21:19:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 20:19:13 +0000 Subject: [Koha-bugs] [Bug 21846] Using emoji as tags doesn't discriminate between emoji when calculating weights or searching In-Reply-To: <bug-21846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21846-70-ULgi9WMjhw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #43 from Josef Moravec <josef.moravec at gmail.com> --- I agree with Tomas, we should fix bug 22420 independently. This patchset works, code is OK and fixes the described bug, so setting PQA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 21:46:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 20:46:35 +0000 Subject: [Koha-bugs] [Bug 15985] Include transacting library in fines In-Reply-To: <bug-15985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15985-70-xgFpAKFp0Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15985 --- Comment #11 from Josef Moravec <josef.moravec at gmail.com> --- This should be rebased and adapted on top of bug 19489 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 22:17:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 21:17:36 +0000 Subject: [Koha-bugs] [Bug 15860] Alias missing for /plugin on packages In-Reply-To: <bug-15860-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15860-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15860-70-yqFt0uyjV4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15860 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Tomas, I am not good with Apache, but I remember seeing broken images. Could we fix this? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 22:18:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 21:18:34 +0000 Subject: [Koha-bugs] [Bug 21779] Holds history doesn't show where hold placed In-Reply-To: <bug-21779-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21779-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21779-70-JmhmkRrthN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21779 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|17.11 |master CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 22:25:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 21:25:43 +0000 Subject: [Koha-bugs] [Bug 21779] Holds history doesn't show where hold placed In-Reply-To: <bug-21779-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21779-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21779-70-zmvwvtOdpY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21779 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- The log viewer uses the action_logs table, the holds history uses data from reserves and old_reserves. The action_logs table has the column 'interface' which can be used to determine where the hold was placed. This information is not available form the *reserves tables. Strangely, it doesn't look like we are logging the reserve_id - so there is no safe way to tell which line in action_logs corresponds to an entry in *reserves :( -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 22:27:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 21:27:36 +0000 Subject: [Koha-bugs] [Bug 21779] Holds history doesn't show where hold placed In-Reply-To: <bug-21779-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21779-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21779-70-wN7fjuNFPC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21779 --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Katrin Fischer from comment #1) > The log viewer uses the action_logs table, the holds history uses data from > reserves and old_reserves. The action_logs table has the column 'interface' > which can be used to determine where the hold was placed. This information > is not available form the *reserves tables. > > Strangely, it doesn't look like we are logging the reserve_id - so there is > no safe way to tell which line in action_logs corresponds to an entry in > *reserves :( I was wrong, I was looking at old incomplete entires - reserve_id is logged now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 22:30:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 21:30:03 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8995-70-NtVQ6gVaXr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64532|0 |1 is obsolete| | Attachment #64533|0 |1 is obsolete| | Attachment #64534|0 |1 is obsolete| | Attachment #64535|0 |1 is obsolete| | Attachment #64536|0 |1 is obsolete| | Attachment #64537|0 |1 is obsolete| | Attachment #64538|0 |1 is obsolete| | --- Comment #85 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86483 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86483&action=edit Bug 8995: Show OpenURL links in OPAC search results This patch use GetCOinS sub to provide an OpenURL link in OPAC search results. It uses 4 new system preferences: - OpenURLinOPACResults: enable or disable this feature - OpenURLResolverURL: url of the openURL resolver - OpenURLText: text of the link - OpenURLImageLocation: image of the link Link is displayed as an image if OpenURLImageLocation is defined, and as text otherwise. It works both with and without XSLT enabled. Changes made to GetCOinSBiblio: For 'journal': - Title should be in rft.jtitle instead of rft.title - rft.date, rft.aulast, rft.aufirst, rft.au, rft.pub and rft.pages have no meaning for a subscription, so they are simply removed from URL This patch refactors GetCOinSBiblio, so the construction of URL is done only at the end. This way we do not have ugly $var .= "&$value" in the function body. Also use URI::Escape instead of custom regexps. This development consider the value of syspref OPACURLOpenInNewWindow when building the link. Test plan: 1/ Enable syspref OPACShowOpenURL and put your OpenURL resolver URL in OpenURLResolverURL syspref (if you don't have one, just fill it with some fake URL, you'll have to check if OpenURL links are correct) 2/ If you want, set the other sysprefs OpenURLImageLocation and OpenURLText 3/ Fill syspref OPACOpenURLItemTypes with some (not all) of your item types. 4/ Empty sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay 5/ Go to OPAC and launch a search. 6/ Check you have in the results (near the title) the OpenURL link (only for itemtypes that are in OPACOpenURLItemTypes). Toggle OPACURLOpenInNewWindow syspref and check that the behaviour of the link is correct. 7/ Go to the detail page of one of those and check you have the OpenURL link too. (Above tags) Toggle OPACURLOpenInNewWindow syspref and check that the behaviour of the link is correct. 8/ Set sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay to "default" and repeat steps 5 to 7 Signed-off-by: Paola Rossi <paola.rossi at cineca.it> Signed-off-by: Magnus Enger <magnus at libriotech.no> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 22:30:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 21:30:11 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8995-70-L0jmvhXUBg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #86 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86484 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86484&action=edit Bug 8995: Remove useless code OpenURL link display is done in XSLT only, so this code is now useless Signed-off-by: Magnus Enger <magnus at libriotech.no> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 22:30:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 21:30:17 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8995-70-pmBUnmq0bR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #87 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86485 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86485&action=edit Bug 8995: Fix URL generation when the URL in syspref has a query part Signed-off-by: Magnus Enger <magnus at libriotech.no> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 22:30:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 21:30:24 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8995-70-aFWRUPK88n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #88 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86486&action=edit Bug 8995: Tell about the new sysprefs in COinSinOPACResults description Signed-off-by: Magnus Enger <magnus at libriotech.no> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 22:30:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 21:30:32 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8995-70-Xy4bJDpqzB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #89 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86487&action=edit Bug 8995: Fix and simplify usage of syspref OpenURLImageLocation There were still references to the OPAC 'prog' theme in XSL files Now, when using a relative URL, we have to give the full path Signed-off-by: Magnus Enger <magnus at libriotech.no> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 22:30:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 21:30:38 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8995-70-bE7o8WEvR1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #90 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86488&action=edit Bug 8995: Add IGNORE to the INSERT statement Signed-off-by: Magnus Enger <magnus at libriotech.no> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 22:30:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 21:30:46 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8995-70-4cWt5BUIIT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #91 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86489&action=edit Bug 8995: (follow-up) Adapt to current codebase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 22:41:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 21:41:50 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8995-70-O43od7N9al@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #93 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86491&action=edit Bug 8995: Add IGNORE to the INSERT statement Signed-off-by: Magnus Enger <magnus at libriotech.no> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 22:41:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 21:41:41 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8995-70-SBwED6wBVg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86483|0 |1 is obsolete| | Attachment #86484|0 |1 is obsolete| | Attachment #86485|0 |1 is obsolete| | Attachment #86486|0 |1 is obsolete| | Attachment #86487|0 |1 is obsolete| | Attachment #86488|0 |1 is obsolete| | Attachment #86489|0 |1 is obsolete| | --- Comment #92 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86490&action=edit Bug 8995: Show OpenURL links in OPAC search results This patch use GetCOinS sub to provide an OpenURL link in OPAC search results. It uses 4 new system preferences: - OpenURLinOPACResults: enable or disable this feature - OpenURLResolverURL: url of the openURL resolver - OpenURLText: text of the link - OpenURLImageLocation: image of the link Link is displayed as an image if OpenURLImageLocation is defined, and as text otherwise. It works both with and without XSLT enabled. Changes made to GetCOinSBiblio: For 'journal': - Title should be in rft.jtitle instead of rft.title - rft.date, rft.aulast, rft.aufirst, rft.au, rft.pub and rft.pages have no meaning for a subscription, so they are simply removed from URL This patch refactors GetCOinSBiblio, so the construction of URL is done only at the end. This way we do not have ugly $var .= "&$value" in the function body. Also use URI::Escape instead of custom regexps. This development consider the value of syspref OPACURLOpenInNewWindow when building the link. Test plan: 1/ Enable syspref OPACShowOpenURL and put your OpenURL resolver URL in OpenURLResolverURL syspref (if you don't have one, just fill it with some fake URL, you'll have to check if OpenURL links are correct) 2/ If you want, set the other sysprefs OpenURLImageLocation and OpenURLText 3/ Fill syspref OPACOpenURLItemTypes with some (not all) of your item types. 4/ Empty sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay 5/ Go to OPAC and launch a search. 6/ Check you have in the results (near the title) the OpenURL link (only for itemtypes that are in OPACOpenURLItemTypes). Toggle OPACURLOpenInNewWindow syspref and check that the behaviour of the link is correct. 7/ Go to the detail page of one of those and check you have the OpenURL link too. (Above tags) Toggle OPACURLOpenInNewWindow syspref and check that the behaviour of the link is correct. 8/ Set sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay to "default" and repeat steps 5 to 7 Signed-off-by: Paola Rossi <paola.rossi at cineca.it> Signed-off-by: Magnus Enger <magnus at libriotech.no> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 22:41:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 21:41:56 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8995-70-pWZhDpnKLN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #94 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86492&action=edit Bug 8995: (follow-up) Adapt to current codebase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 22:46:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 21:46:02 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8995-70-X8aHEfF7SS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Failed QA --- Comment #95 from Josef Moravec <josef.moravec at gmail.com> --- I rebased and squashed the patches a bit. To pass QA there are at least missing tests for GetOpenURLResolverURL. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 22:49:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 21:49:51 +0000 Subject: [Koha-bugs] [Bug 16785] Autocomplete broken on overdues report In-Reply-To: <bug-16785-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16785-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16785-70-QOEOjzq3xL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16785 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- This appears to still be broken - even more than when reported. It appears now that the pull down with options never loads. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 23:03:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 22:03:45 +0000 Subject: [Koha-bugs] [Bug 16785] Autocomplete broken on overdues report In-Reply-To: <bug-16785-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16785-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16785-70-9WlTQ9eYtW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16785 --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- eferenceError: create_auto_completion_responder is not defined[Learn More] overdue.pl:486:1 -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 23:07:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 22:07:04 +0000 Subject: [Koha-bugs] [Bug 22494] New: When adding a library group with an already existing name, an ugly error is displayed Message-ID: <bug-22494-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22494 Bug ID: 22494 Summary: When adding a library group with an already existing name, an ugly error is displayed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Target Milestone: --- Duplicate ID at /usr/share/perl5/Exception/Class/Base.pm line 88 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 23:10:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 22:10:09 +0000 Subject: [Koha-bugs] [Bug 14396] library groups are allowed to have same codes as branches In-Reply-To: <bug-14396-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14396-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14396-70-JkxCNgqDpj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14396 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Tested on current master and the bug reported appears to have been fixed with the new library group system. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 23:16:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 22:16:22 +0000 Subject: [Koha-bugs] [Bug 22360] On order information missing in OPAC normal display In-Reply-To: <bug-22360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22360-70-dCuxxED9gX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22360 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #15 from Lucas Gass <lucas at bywatersolutions.com> --- missing dependency for 18.05.x. not backporting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 23:18:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 22:18:43 +0000 Subject: [Koha-bugs] [Bug 8506] return date of lost items recorded wrong In-Reply-To: <bug-8506-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8506-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8506-70-nlQzpqWeXl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8506 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I can't replicate this issue on current master. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 23:18:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 22:18:54 +0000 Subject: [Koha-bugs] [Bug 22420] Tag cloud feature broken In-Reply-To: <bug-22420-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22420-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22420-70-FxacOq5MLI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22420 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 11 23:22:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 22:22:53 +0000 Subject: [Koha-bugs] [Bug 9983] printable fines page should include name/barcode In-Reply-To: <bug-9983-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9983-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9983-70-nhurIUoxo0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9983 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |WORKSFORME --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- The current print version of this page is not very nice, but it includes the left column with the patron information. As others have said, we need a nice way to print fines, as a customizable slip. Original bug is 'fixed' tho. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 00:11:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 23:11:59 +0000 Subject: [Koha-bugs] [Bug 4833] show all fields when ordering from suggestion In-Reply-To: <bug-4833-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-4833-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4833-70-YcSSwnghT9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4833 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 00:12:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 23:12:03 +0000 Subject: [Koha-bugs] [Bug 4833] show all fields when ordering from suggestion In-Reply-To: <bug-4833-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-4833-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4833-70-QRgrPm4phr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4833 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 86493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86493&action=edit Bug 4833: Show acq information when selecting suggestion for order When adding an order line to a basket using the 'from a suggestion' feature, the list of accepted suggestions doesn't show any information from the acquisition are of the suggestions. This patch adds new columns to the list for: - library - fund - price - quantity - total To test: - Create several suggestions with - Empty acq values - A specific library, any library - Set acq values (fund, price, quantity) - Accept your suggestions - Create a new basket/order - Add an order line from accepted suggestions - Verify the list displays nicely with the new columns - Verify filters etc. still work ok -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 00:12:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 23:12:22 +0000 Subject: [Koha-bugs] [Bug 4833] Show acquisition information when ordering from suggestion In-Reply-To: <bug-4833-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-4833-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4833-70-6DW8MV0hEr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4833 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | Summary|show all fields when |Show acquisition |ordering from suggestion |information when ordering | |from suggestion -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 00:28:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 23:28:20 +0000 Subject: [Koha-bugs] [Bug 12628] reports/cat_issues_top.pl incorrect checkout range query In-Reply-To: <bug-12628-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12628-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12628-70-SO2OzaeVC9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12628 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|unspecified |master --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Marc V?ron from comment #1) > Still valid? It looks like it is, but there are even more occurrences of timestamp in the file. The attached file is also not a valid patch format, still needs some work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 00:45:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 23:45:11 +0000 Subject: [Koha-bugs] [Bug 13094] Make it easy to hide 'Cancel all' button on holds over report In-Reply-To: <bug-13094-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13094-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13094-70-1fovLPYncm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13094 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Make it easy to hide |Make it easy to hide |'Cancel all holds' button |'Cancel all' button on |on holds over report |holds over report -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 00:45:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 23:45:47 +0000 Subject: [Koha-bugs] [Bug 13094] Make it easy to hide 'Cancel all' button on holds over report In-Reply-To: <bug-13094-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13094-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13094-70-eHySVN1k0b@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13094 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 00:45:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 23:45:50 +0000 Subject: [Koha-bugs] [Bug 13094] Make it easy to hide 'Cancel all' button on holds over report In-Reply-To: <bug-13094-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13094-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13094-70-jtQTPxrv2v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13094 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 86494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86494&action=edit Bug 13094: Make it easy to hide 'Cancel all' button on holds over report This patch makes some small modifications to the 'Holds awaiting pickup' report: - Fixes typo sypref - Fixes 'Home branch' to 'Home library' - Adds a span to easily hide the cancel all button with CSS To test: - Make sure you have a hold appearing on the awaiting pickup list second tab: Holds waiting over... - Verify the 'cancel all' button on top shows - Verify syspref and Home library changes mentioned above - Add #holdsover-cancel-all { display:none; } to IntrentUserCSS - Verify that the button and the text have vanished Note: If the text doesn't display next to the button, try toggling the TransferWhenCancelAllWaitingHolds system preference. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 00:45:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 23:45:58 +0000 Subject: [Koha-bugs] [Bug 13094] Make it easy to hide 'Cancel all' button on holds over report In-Reply-To: <bug-13094-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13094-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13094-70-cIqFLnRefe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13094 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 00:56:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Mar 2019 23:56:56 +0000 Subject: [Koha-bugs] [Bug 18994] Show the branch name where checkin occurred on a title's Checkout History display In-Reply-To: <bug-18994-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18994-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18994-70-tCAYmLX5Mt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18994 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I am not sure how to achieve this. Currently all information is pulled from the issues and old_issues tables, but the information about the checkin branch is not recorded there. We'd need statistics, but we don't record the issue_id there. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 01:07:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 00:07:29 +0000 Subject: [Koha-bugs] [Bug 12806] Adding 'Koha as a CMS' to the OPAC In-Reply-To: <bug-12806-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12806-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12806-70-8Xfguv3W2m@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12806 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|ASSIGNED |RESOLVED Resolution|--- |DUPLICATE --- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- A slightly different approach, using the news system istead of system preferences: bug 15326 *** This bug has been marked as a duplicate of bug 15326 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 01:07:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 00:07:29 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15326-70-7Dd3I1HEHJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |indradg at l2c2.co.in --- Comment #80 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** Bug 12806 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 01:07:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 00:07:31 +0000 Subject: [Koha-bugs] [Bug 7840] Remove from manual Koha as a CMS (or add it to master) In-Reply-To: <bug-7840-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7840-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7840-70-YHrgabHeMn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7840 Bug 7840 depends on bug 12806, which changed state. Bug 12806 Summary: Adding 'Koha as a CMS' to the OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12806 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 01:23:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 00:23:01 +0000 Subject: [Koha-bugs] [Bug 8369] default_branch_circ_rule and default_circ_rules tables useless In-Reply-To: <bug-8369-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8369-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8369-70-VVRNAZRdyI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8369 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z Assignee|koha-bugs at lists.koha-commun |hayleymapley at catalyst.net.n |ity.org |z -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 02:59:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 01:59:00 +0000 Subject: [Koha-bugs] [Bug 21772] Add holds and account information tab to the SCO module In-Reply-To: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21772-70-gJPuHIUJEx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 --- Comment #7 from Agust?n Moyano <agustinmoyano at theke.io> --- Created attachment 86495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86495&action=edit Bug 21772: (follow-up) Included more information on tab label for SCO -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 04:09:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 03:09:55 +0000 Subject: [Koha-bugs] [Bug 22489] Onboarding tool fails due to inserting maxissueqty into IssuingRule In-Reply-To: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22489-70-RQVlp2f8jy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22489 --- Comment #2 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Created attachment 86496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86496&action=edit Bug 22489: Fixed issue with onboarding tool failing at step 5 When going through the onboarding process, the tool fails on submit of step 5, due to changes made in the database structure and rule definitions. This patch fixes this, adding code that creates a circulation rule where an issuing rule is also created in onboarding.pl. It removes maxissueqty from being sent with params to make an issuing rule, and adds it instead to the params to make a circulation rule, to reflect the changes that have been made in the database. Test plan: 1) Drop and recreate your database 2) Reload the staff client and follow the installer and onboarding process 3) Confirm that the process finishes without errors -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 04:10:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 03:10:28 +0000 Subject: [Koha-bugs] [Bug 22489] Onboarding tool fails due to inserting maxissueqty into IssuingRule In-Reply-To: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22489-70-E6uzfQQUaM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22489 --- Comment #3 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Created attachment 86497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86497&action=edit Modified to pass QA tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 04:10:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 03:10:55 +0000 Subject: [Koha-bugs] [Bug 22489] Onboarding tool fails due to inserting maxissueqty into IssuingRule In-Reply-To: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22489-70-7XdtvNfML6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22489 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 04:44:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 03:44:44 +0000 Subject: [Koha-bugs] [Bug 21985] Test t/db_dependent/Circulation.t fails if SearchEngine is set to elasticsearch In-Reply-To: <bug-21985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21985-70-fjiph5KA2s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21985 --- Comment #7 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Test fails with the following error: t/db_dependent/Circulation.t .. 122/126 # No tests run! t/db_dependent/Circulation.t .. 123/126 # Failed test 'No tests run for subtest "AddRenewal and AddIssuingCharge tests"' # at t/db_dependent/Circulation.t line 2948. Can't call method "lengthunit" on an undefined value at /home/vagrant/kohaclone/Koha/Charges/Fees.pm line 101. # Looks like your test exited with 11 just after 123. t/db_dependent/Circulation.t .. Dubious, test returned 11 (wstat 2816, 0xb00) Failed 4/126 subtests Test Summary Report ------------------- t/db_dependent/Circulation.t (Wstat: 2816 Tests: 123 Failed: 1) Failed test: 123 Non-zero exit status: 11 Parse errors: Bad plan. You planned 126 tests but ran 123. Files=1, Tests=123, 38 wallclock secs ( 0.07 usr 0.01 sys + 18.59 cusr 3.22 csys = 21.89 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 04:45:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 03:45:31 +0000 Subject: [Koha-bugs] [Bug 22333] Replace duplicated code in CanBookBeRenewed with GetSoonestRenewDate In-Reply-To: <bug-22333-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22333-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22333-70-hEeRSkJr5w@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22333 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |hayleymapley at catalyst.net.n | |z --- Comment #5 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Test fails with the following error: t/db_dependent/Circulation.t .. 122/126 # No tests run! t/db_dependent/Circulation.t .. 123/126 # Failed test 'No tests run for subtest "AddRenewal and AddIssuingCharge tests"' # at t/db_dependent/Circulation.t line 2948. Can't call method "lengthunit" on an undefined value at /home/vagrant/kohaclone/Koha/Charges/Fees.pm line 101. # Looks like your test exited with 11 just after 123. t/db_dependent/Circulation.t .. Dubious, test returned 11 (wstat 2816, 0xb00) Failed 4/126 subtests Test Summary Report ------------------- t/db_dependent/Circulation.t (Wstat: 2816 Tests: 123 Failed: 1) Failed test: 123 Non-zero exit status: 11 Parse errors: Bad plan. You planned 126 tests but ran 123. Files=1, Tests=123, 38 wallclock secs ( 0.07 usr 0.01 sys + 18.59 cusr 3.22 csys = 21.89 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 04:51:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 03:51:59 +0000 Subject: [Koha-bugs] [Bug 8369] default_branch_circ_rule and default_circ_rules tables useless In-Reply-To: <bug-8369-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8369-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8369-70-gS1pMSQ1au@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8369 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion --- Comment #30 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- It appears that the default_circ_rules table is no longer used in the current development version. Should this table be removed from the database? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 05:16:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 04:16:15 +0000 Subject: [Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation In-Reply-To: <bug-20844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20844-70-BO1nvPakD3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844 Alex Buckley <alexbuckley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|alexbuckley at catalyst.net.nz |aleisha at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 07:14:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 06:14:18 +0000 Subject: [Koha-bugs] [Bug 22023] Further improve responsive layout handling of staff client menu bar In-Reply-To: <bug-22023-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22023-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22023-70-96OVUelQu6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22023 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 07:14:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 06:14:23 +0000 Subject: [Koha-bugs] [Bug 22023] Further improve responsive layout handling of staff client menu bar In-Reply-To: <bug-22023-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22023-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22023-70-MFokT4DRYb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22023 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86217|0 |1 is obsolete| | Attachment #86478|0 |1 is obsolete| | --- Comment #11 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86498&action=edit Bug 22023: Further improve responsive layout handling of staff client menu bar This patch makes a number of changes in order to improve the way the staff client's header menu adjusts at narrower browser widths: - Updated version of Bootstrap 3.3.7 which includes the "collapse" JavaScript plugin. - Modified default Bootstrap CSS using Bootstrap's customization tool. These changes facilitate the removal of some custom CSS (overriding Bootstrap) from staff-global.scss. - Added Bootstrap config file for loading customizations at https://getbootstrap.com/docs/3.3/customize/ - Revised button classes for buttons in Bootstrap-styled toolbars. The modified default CSS resets the base font size in Bootstrap to better match our global CSS. A side-effect of this is that toolbar buttons ended up looking smaller than they should. Changing the button class solves this. - Restructure the header menu in order to allow different rules to govern the appearance of the navigational part of the menu (Circulation, Search, etc) and the user menu (Set library, My account, Log out). - Modify the cart JS to so that the popup works well at narrow widths. To test, apply the patch, regenerate the staff client CSS, and clear your browser cache. - Log in to the staff client and observe the layout of the header menu as you adjust the browser to various widths. - Confirm that sections of the menu "collapse" as the window gets narrower. - Confirm that dropdown menus behave correctly and that links work. - Confirm that the Cart link works as expected when the cart empty and when it has items. - Install and enable multiple translations, including at least one set of sub-languages (e.g. fr-FR and fr-CA). - Test the appearance of the language menus in the footer at various browser widths. - View pages with button toolbars and confirm that they appear unchanged (e.g. biblio detail page, patron detail page). NOTE: While this patch is intended to make improvements to staff client responsiveness, it does so within a limited scope. There are still many pages which do not work well at narrower browser widths. Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 07:14:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 06:14:27 +0000 Subject: [Koha-bugs] [Bug 22023] Further improve responsive layout handling of staff client menu bar In-Reply-To: <bug-22023-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22023-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22023-70-RbghSVD046@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22023 --- Comment #12 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86499&action=edit Bug 22023: (follow-up) Right-to-left layout improvements This patch makes some corrections to accommodate right-to-left layouts. Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 07:14:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 06:14:30 +0000 Subject: [Koha-bugs] [Bug 22023] Further improve responsive layout handling of staff client menu bar In-Reply-To: <bug-22023-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22023-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22023-70-rksO7lG6Lh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22023 --- Comment #13 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86500&action=edit Bug 22023: (QA follow-up) Remove console.log used for debugging Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 08:07:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 07:07:24 +0000 Subject: [Koha-bugs] [Bug 18398] CHECKIN/CHECKOUT/RENEWAL don't use AutoEmailPrimaryAddress but first valid e-mail In-Reply-To: <bug-18398-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18398-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18398-70-r0mi78nY7L@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18398 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|3.22 |master --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Still valid, especially since bug 12802 is currently sitting in FQA. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 08:10:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 07:10:13 +0000 Subject: [Koha-bugs] [Bug 16831] Patron List is not generated at the time of filtered search In-Reply-To: <bug-16831-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16831-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16831-70-iLfkTsN1iH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16831 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I am sorry, but there is not enough information here to determine what the problem is and the version 16.05 is very old and no longer maintained. I am closing this WONTFIX. Please feel free to reopen with more information if the problem still exists in current versions. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 08:15:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 07:15:10 +0000 Subject: [Koha-bugs] [Bug 7717] Multiple Identical Holds In-Reply-To: <bug-7717-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7717-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7717-70-JuS20Sj5VX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7717 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|ASSIGNED |RESOLVED CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think this has been fixed, multiple holds are possible now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 08:21:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 07:21:07 +0000 Subject: [Koha-bugs] [Bug 19202] SPAM In-Reply-To: <bug-19202-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19202-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19202-70-cDEclBjLH7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19202 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Summary|Koha |SPAM CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 08:31:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 07:31:03 +0000 Subject: [Koha-bugs] [Bug 21659] Acquisitions Receipt summary Basket group links missing params In-Reply-To: <bug-21659-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21659-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21659-70-lRWC3O2rBn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21659 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 08:31:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 07:31:19 +0000 Subject: [Koha-bugs] [Bug 21659] Link to basket groups from order receive page are broken In-Reply-To: <bug-21659-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21659-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21659-70-NJ0pGI2uVE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21659 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Acquisitions Receipt |Link to basket groups from |summary Basket group links |order receive page are |missing params |broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 08:31:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 07:31:40 +0000 Subject: [Koha-bugs] [Bug 21659] Link to basket groups from order receive page are broken In-Reply-To: <bug-21659-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21659-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21659-70-jmQ8RIXtmL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21659 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |ASSIGNED --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Have the patch almost ready, will finish here later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 09:07:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 08:07:11 +0000 Subject: [Koha-bugs] [Bug 13515] Table messages is missing FK constraints and is never cleaned up In-Reply-To: <bug-13515-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13515-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13515-70-KZCHokCyXK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #18 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 18.05.x for 18.05.10 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 09:08:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 08:08:38 +0000 Subject: [Koha-bugs] [Bug 13515] Table messages is missing FK constraints and is never cleaned up In-Reply-To: <bug-13515-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13515-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13515-70-BSmVpRAosa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #19 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- I prefer not to impact 17.11.x database structure. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 09:08:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 08:08:39 +0000 Subject: [Koha-bugs] [Bug 5334] Add explicit foreign key constraints In-Reply-To: <bug-5334-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-5334-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5334-70-HYLxcSUDTf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 Bug 5334 depends on bug 13515, which changed state. Bug 13515 Summary: Table messages is missing FK constraints and is never cleaned up https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13515 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 09:17:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 08:17:18 +0000 Subject: [Koha-bugs] [Bug 18143] Silence floody MARC framework export In-Reply-To: <bug-18143-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18143-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18143-70-ToZROUjKzQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18143 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to Stable |RESOLVED Resolution|--- |FIXED --- Comment #10 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.11.x for 17.11.17 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 09:18:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 08:18:45 +0000 Subject: [Koha-bugs] [Bug 22386] Importing using attributes as matchpoint broken In-Reply-To: <bug-22386-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22386-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22386-70-XynviShyrO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22386 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED CC| |fridolin.somers at biblibre.co | |m Resolution|--- |FIXED --- Comment #12 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Depends on Bug 19936 not in 17.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 09:33:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 08:33:17 +0000 Subject: [Koha-bugs] [Bug 18925] Move maxissueqty and maxonsiteissueqty to circulation_rules In-Reply-To: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18925-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18925-70-OCFRkDcqan@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |martin.renvoize at ptfs-europe | |.com --- Comment #123 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 09:33:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 08:33:18 +0000 Subject: [Koha-bugs] [Bug 18928] Move holdallowed, hold_fulfillment_policy, returnbranch to circulation_rules In-Reply-To: <bug-18928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18928-70-Jri5dmBuo3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Bug 18928 depends on bug 18925, which changed state. Bug 18925 Summary: Move maxissueqty and maxonsiteissueqty to circulation_rules https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 09:33:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 08:33:18 +0000 Subject: [Koha-bugs] [Bug 22489] Onboarding tool fails due to inserting maxissueqty into IssuingRule In-Reply-To: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22489-70-yPodfP2gAV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22489 Bug 22489 depends on bug 18925, which changed state. Bug 18925 Summary: Move maxissueqty and maxonsiteissueqty to circulation_rules https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18925 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 09:34:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 08:34:00 +0000 Subject: [Koha-bugs] [Bug 21721] Update C4::Circulation::AddRenewal to use Koha::Account->add_debit In-Reply-To: <bug-21721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21721-70-prNcXOW6Yp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21721 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 09:34:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 08:34:00 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-d8u6uuwe5J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Bug 20912 depends on bug 21721, which changed state. Bug 21721 Summary: Update C4::Circulation::AddRenewal to use Koha::Account->add_debit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21721 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 09:34:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 08:34:01 +0000 Subject: [Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead) In-Reply-To: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21756-70-3KbTOnH5MW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Bug 21756 depends on bug 21721, which changed state. Bug 21721 Summary: Update C4::Circulation::AddRenewal to use Koha::Account->add_debit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21721 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 09:34:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 08:34:30 +0000 Subject: [Koha-bugs] [Bug 21443] Add ability to exclude holidays when calculating rentals fees by time period In-Reply-To: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21443-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21443-70-vJOnqUYEIV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21443 Bug 21443 depends on bug 20912, which changed state. Bug 20912 Summary: Rental fees based on time period https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 09:34:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 08:34:29 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-kwGPF1r0O0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #227 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 09:36:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 08:36:31 +0000 Subject: [Koha-bugs] [Bug 22466] TT methods must not be escaped In-Reply-To: <bug-22466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22466-70-tjcodUi8Fb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22466 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 09:36:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 08:36:56 +0000 Subject: [Koha-bugs] [Bug 15774] Additional fields for baskets In-Reply-To: <bug-15774-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15774-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15774-70-Esf7l1x7wx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #159 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- New feature will not be backported to 18.11.x series -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 09:36:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 08:36:58 +0000 Subject: [Koha-bugs] [Bug 11844] Additional fields for order lines In-Reply-To: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11844-70-VcFmwAEWmu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11844 Bug 11844 depends on bug 15774, which changed state. Bug 15774 Summary: Additional fields for baskets https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 09:37:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 08:37:47 +0000 Subject: [Koha-bugs] [Bug 20912] Rental fees based on time period In-Reply-To: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20912-70-ZtJ3Nk0xH7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20912 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 09:39:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 08:39:22 +0000 Subject: [Koha-bugs] [Bug 16251] Material type is not correctly set for Rancor 008 widget In-Reply-To: <bug-16251-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16251-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16251-70-2NPtZfGFVJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16251 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 09:40:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 08:40:35 +0000 Subject: [Koha-bugs] [Bug 20535] ModZebra called with $record with items stripped in ModBiblioMarc In-Reply-To: <bug-20535-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20535-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20535-70-aNTcqxrv7V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20535 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 09:42:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 08:42:04 +0000 Subject: [Koha-bugs] [Bug 22275] 18.06.00.060 DB update fails (incomplete/incorrect defaults) In-Reply-To: <bug-22275-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22275-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22275-70-lADD3F8KpM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22275 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 09:42:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 08:42:54 +0000 Subject: [Koha-bugs] [Bug 22031] C4::Auth->haspermission should allow checking for more than one subpermission In-Reply-To: <bug-22031-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22031-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22031-70-aHc7QeHeaK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22031 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED Severity|normal |enhancement --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 09:42:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 08:42:55 +0000 Subject: [Koha-bugs] [Bug 20128] Permission for advanced editor In-Reply-To: <bug-20128-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20128-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20128-70-t5j3Iq4skU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20128 Bug 20128 depends on bug 22031, which changed state. Bug 22031 Summary: C4::Auth->haspermission should allow checking for more than one subpermission https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22031 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 09:42:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 08:42:55 +0000 Subject: [Koha-bugs] [Bug 22483] haspermissions previously supported passing 'undef' for $flagsrequired In-Reply-To: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22483-70-eUORHdlKPG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Bug 22483 depends on bug 22031, which changed state. Bug 22031 Summary: C4::Auth->haspermission should allow checking for more than one subpermission https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22031 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 09:43:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 08:43:39 +0000 Subject: [Koha-bugs] [Bug 20639] Allow setting a default/single backend for OPAC driven requests In-Reply-To: <bug-20639-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20639-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20639-70-hwx43wb7PI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20639 --- Comment #24 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 09:44:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 08:44:47 +0000 Subject: [Koha-bugs] [Bug 22419] Removing multiple records from intranet cart causes browser timeout In-Reply-To: <bug-22419-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22419-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22419-70-aRXhgNEZj6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22419 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize at ptfs-europe | |.com --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 09:46:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 08:46:25 +0000 Subject: [Koha-bugs] [Bug 22416] Search.t tests need adjustment for EasyAnalyticRecords syspref In-Reply-To: <bug-22416-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22416-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22416-70-1UiK3CaXvZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22416 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize at ptfs-europe | |.com --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 09:47:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 08:47:18 +0000 Subject: [Koha-bugs] [Bug 22246] Elasticsearch indexing needs a maximum length for __sort fields In-Reply-To: <bug-22246-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22246-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22246-70-YwTaNOackK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22246 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize at ptfs-europe | |.com --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 09:48:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 08:48:07 +0000 Subject: [Koha-bugs] [Bug 22303] Wrong bottom in virtualshelves/addbybiblionumber.tt In-Reply-To: <bug-22303-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22303-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22303-70-IBfUpQfDmt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22303 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize at ptfs-europe | |.com --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 09:48:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 08:48:40 +0000 Subject: [Koha-bugs] [Bug 22483] haspermissions previously supported passing 'undef' for $flagsrequired In-Reply-To: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22483-70-O7k1KJAlbk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #24 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Followup to enhancement not pushed to 18.11.x series -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 09:50:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 08:50:18 +0000 Subject: [Koha-bugs] [Bug 22442] Item search CSV export broken In-Reply-To: <bug-22442-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22442-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22442-70-SM1z4j4Dkp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22442 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 09:51:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 08:51:38 +0000 Subject: [Koha-bugs] [Bug 19046] IntranetCatalogSearchPulldown doesn't retain last selection In-Reply-To: <bug-19046-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19046-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19046-70-GrpUE5L6db@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19046 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 09:55:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 08:55:07 +0000 Subject: [Koha-bugs] [Bug 22454] Add Koha::Item::hidden_in_opac method In-Reply-To: <bug-22454-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22454-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22454-70-iVtbSIchqB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22454 Michal Denar <black23 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 09:55:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 08:55:10 +0000 Subject: [Koha-bugs] [Bug 22454] Add Koha::Item::hidden_in_opac method In-Reply-To: <bug-22454-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22454-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22454-70-a4MMXKjsFY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22454 --- Comment #3 from Michal Denar <black23 at gmail.com> --- Created attachment 86501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86501&action=edit Bug 22454: Add Koha::Item::hidden_in_opac method This patch adds a hidden_in_opac method that does the same calculation done in GetHiddenItemnumbers, but for a single item, and doesn't get the OpacHiddenItems syspref, but expects them to be passed as parameters (to avoid multiple reads). To test: - Apply this patches - Run: $ kshell k$ prove t/db_dependent/Koha/Item.t => SUCCESS: Tests pass! Signed-off-by: Michal Denar <black23 at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 10:01:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 09:01:13 +0000 Subject: [Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13937-70-jH2jDXR0Hb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 --- Comment #136 from Stefan Berndtsson <stefan.berndtsson at ub.gu.se> --- (In reply to Ere Maijala from comment #135) > Oops, the first patch was accidentally left over from previous iteration. > Should be fixed now. Figured is was something like that. It applies fine now. A couple of notes. The test plan says port 9999, but the config file has changed that to 2100. Also, the test plan doesn't mention anything about the location of the config, nor the location of the pqf.properties (referred to relatively in the config.xml). It wasn't hard to figure out what to do about it, so no worries there, just thought I'd mention it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 10:06:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 09:06:54 +0000 Subject: [Koha-bugs] [Bug 22455] Add Koha::Biblio::hidden_in_opac method In-Reply-To: <bug-22455-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22455-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22455-70-A0eEG1tv3U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22455 Michal Denar <black23 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 10:07:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 09:07:04 +0000 Subject: [Koha-bugs] [Bug 22455] Add Koha::Biblio::hidden_in_opac method In-Reply-To: <bug-22455-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22455-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22455-70-XO8oruhhZd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22455 --- Comment #3 from Michal Denar <black23 at gmail.com> --- Created attachment 86502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86502&action=edit Bug 22455: Unit tests Signed-off-by: Michal Denar <black23 at gmail.com> Signed-off-by: Michal Denar <black23 at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 10:07:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 09:07:26 +0000 Subject: [Koha-bugs] [Bug 22455] Add Koha::Biblio::hidden_in_opac method In-Reply-To: <bug-22455-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22455-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22455-70-Vcv8uJRlJn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22455 Michal Denar <black23 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86067|0 |1 is obsolete| | --- Comment #4 from Michal Denar <black23 at gmail.com> --- Created attachment 86503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86503&action=edit Bug 22455: Add Koha::Biblio::hidden_in_opac method This patch adds a hidden_in_opac method that does the same calculation done in places like opac-tags.pl. The condition that is checked is that all items belonging to the biblio are hidden. This is the current behaviour in the code. To test: - Apply this patches - Run: $ kshell k$ prove t/db_dependent/Koha/Biblio.t => SUCCESS: Tests pass! Signed-off-by: Michal Denar <black23 at gmail.com> Signed-off-by: Michal Denar <black23 at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 10:13:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 09:13:51 +0000 Subject: [Koha-bugs] [Bug 22495] Restore su-geo field in Elasticsearch mappings In-Reply-To: <bug-22495-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22495-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22495-70-JTxnTNq5AG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22495 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |ere.maijala at helsinki.fi |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 10:13:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 09:13:58 +0000 Subject: [Koha-bugs] [Bug 22495] Restore su-geo field in Elasticsearch mappings In-Reply-To: <bug-22495-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22495-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22495-70-7FegXlv4Pz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22495 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19575 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 10:13:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 09:13:58 +0000 Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve aliased fields In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19575-70-CIKiqn2fwZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22495 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 10:13:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 09:13:40 +0000 Subject: [Koha-bugs] [Bug 22495] New: Restore su-geo field in Elasticsearch mappings Message-ID: <bug-22495-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22495 Bug ID: 22495 Summary: Restore su-geo field in Elasticsearch mappings Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: ere.maijala at helsinki.fi Target Milestone: --- Mapping for su-geo was accidentally dropped in Bug 19575 and needs to be restored. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 10:14:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 09:14:44 +0000 Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve aliased fields In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19575-70-t3glqJ0Ust@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575 --- Comment #99 from Ere Maijala <ere.maijala at helsinki.fi> --- I filed bug 22495 for the su-geo fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 10:19:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 09:19:09 +0000 Subject: [Koha-bugs] [Bug 21030] Date widget on suspend modal not working correctly In-Reply-To: <bug-21030-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21030-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21030-70-lQZ4yitRxF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21030 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 10:20:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 09:20:09 +0000 Subject: [Koha-bugs] [Bug 22422] improve item location display with class "shelvingloc" In-Reply-To: <bug-22422-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22422-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22422-70-c8TlbTK0Dz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22422 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize at ptfs-europe | |.com --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 10:20:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 09:20:33 +0000 Subject: [Koha-bugs] [Bug 22455] Add Koha::Biblio::hidden_in_opac method In-Reply-To: <bug-22455-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22455-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22455-70-eX7Q1Nn493@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22455 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86066|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 10:21:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 09:21:13 +0000 Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile In-Reply-To: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18589-70-CnYsy3xXN6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 --- Comment #22 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 86504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86504&action=edit Bug 18589: (follow-up) Add borrowernumber test As per comment #21: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589#c21 We now test borrowernumber filter works. This test has come from https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83184&action=diff and will be removed from that bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 10:22:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 09:22:12 +0000 Subject: [Koha-bugs] [Bug 22454] Add Koha::Item::hidden_in_opac method In-Reply-To: <bug-22454-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22454-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22454-70-IevsOLXONs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22454 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86062|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 10:22:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 09:22:44 +0000 Subject: [Koha-bugs] [Bug 22452] Typos in add a comment to Mana modal In-Reply-To: <bug-22452-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22452-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22452-70-SSgrmosGTd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22452 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17047 CC| |martin.renvoize at ptfs-europe | |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 [Bug 17047] Mana Knowledge Base : share data -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 10:22:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 09:22:44 +0000 Subject: [Koha-bugs] [Bug 17047] Mana Knowledge Base : share data In-Reply-To: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17047-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17047-70-c8tYW5NmDs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17047 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22452 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22452 [Bug 22452] Typos in add a comment to Mana modal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 10:23:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 09:23:10 +0000 Subject: [Koha-bugs] [Bug 22452] Typos in add a comment to Mana modal In-Reply-To: <bug-22452-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22452-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22452-70-L7v52xpbFf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22452 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- New feature not in 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 10:24:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 09:24:27 +0000 Subject: [Koha-bugs] [Bug 17496] install-CPAN.pl documentation/removal In-Reply-To: <bug-17496-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17496-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17496-70-4yS96S2lUg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17496 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 10:25:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 09:25:09 +0000 Subject: [Koha-bugs] [Bug 22363] Move C4::Logs::GetLogs to Koha namespace In-Reply-To: <bug-22363-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22363-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22363-70-ODac2gwvGu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |martin.renvoize at ptfs-europe | |.com --- Comment #27 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 10:25:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 09:25:09 +0000 Subject: [Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events In-Reply-To: <bug-20750-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20750-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20750-70-y9JMVacff2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750 Bug 20750 depends on bug 22363, which changed state. Bug 22363 Summary: Move C4::Logs::GetLogs to Koha namespace https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22363 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 10:25:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 09:25:42 +0000 Subject: [Koha-bugs] [Bug 21091] Move add item template JavaScript to a separate file In-Reply-To: <bug-21091-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21091-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21091-70-yTQgqnTleQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21091 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |martin.renvoize at ptfs-europe | |.com Resolution|--- |FIXED --- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 10:28:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 09:28:11 +0000 Subject: [Koha-bugs] [Bug 22045] Cataloging UX enhancement - Improve access to tabs In-Reply-To: <bug-22045-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22045-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22045-70-YJxa0dfwb3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |RESOLVED --- Comment #33 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 10:28:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 09:28:12 +0000 Subject: [Koha-bugs] [Bug 22399] Improve responsive behavior of the basic marc editor In-Reply-To: <bug-22399-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22399-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22399-70-U8ODtOlE1h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Bug 22399 depends on bug 22045, which changed state. Bug 22045 Summary: Cataloging UX enhancement - Improve access to tabs https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 10:30:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 09:30:21 +0000 Subject: [Koha-bugs] [Bug 22495] Restore su-geo field in Elasticsearch mappings In-Reply-To: <bug-22495-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22495-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22495-70-Q0c3uMEtba@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22495 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 10:30:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 09:30:23 +0000 Subject: [Koha-bugs] [Bug 22495] Restore su-geo field in Elasticsearch mappings In-Reply-To: <bug-22495-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22495-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22495-70-rPhXWjKdDw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22495 --- Comment #1 from Ere Maijala <ere.maijala at helsinki.fi> --- Created attachment 86505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86505&action=edit Bug 22495: Restore Elasticsearch mapping for su-geo Test plan: 1. Reset mappings 2. Run perl misc/search_tools/rebuild_elastic_search.pl -d -b -v 3. Do a search and verify that the Places facet works -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 10:31:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 09:31:12 +0000 Subject: [Koha-bugs] [Bug 22392] TestBuilder::build_sample_item should allow defining barcode In-Reply-To: <bug-22392-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22392-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22392-70-nHNmzon8dA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22392 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Enhancement not backported to 18.11.x series -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 10:31:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 09:31:12 +0000 Subject: [Koha-bugs] [Bug 22348] Koha::EDI has no tests In-Reply-To: <bug-22348-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22348-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22348-70-C1qjwTLWzv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22348 Bug 22348 depends on bug 22392, which changed state. Bug 22392 Summary: TestBuilder::build_sample_item should allow defining barcode https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22392 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 10:36:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 09:36:07 +0000 Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile In-Reply-To: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18589-70-XeK4p27EMw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 --- Comment #23 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 86506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86506&action=edit Bug 18589: (follow-up) Fix merge problem Date format setting got lost in the merge As per item 1) in comment #20: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589#c20 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 10:36:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 09:36:46 +0000 Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve aliased fields In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19575-70-1Aza8Vl2hd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575 --- Comment #100 from Ere Maijala <ere.maijala at helsinki.fi> --- Looks to me like the original confusion might stem from the fact that queryparser.yaml defines su-geo as an alias for subject. I think that might be a mistake in queryparser.yaml. It was added in bug 9828 that improved UNIMARC support. I suspect there wasn't proper su-geo field in UNIMARC mappings, and the alias would make sense, but only for UNIMARC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 10:40:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 09:40:56 +0000 Subject: [Koha-bugs] [Bug 19489] Detailed description of charges on Accounting tab In-Reply-To: <bug-19489-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19489-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19489-70-nS0UmMLYPT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #59 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 10:40:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 09:40:57 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14825-70-quT8LdCph7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Bug 14825 depends on bug 19489, which changed state. Bug 19489 Summary: Detailed description of charges on Accounting tab https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 10:40:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 09:40:58 +0000 Subject: [Koha-bugs] [Bug 21879] Code cleaning in printinvoice.pl In-Reply-To: <bug-21879-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21879-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21879-70-HyzWhbbfIm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21879 Bug 21879 depends on bug 19489, which changed state. Bug 19489 Summary: Detailed description of charges on Accounting tab https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19489 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 10:41:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 09:41:45 +0000 Subject: [Koha-bugs] [Bug 22368] Table suggestions lacks foreign key constraints In-Reply-To: <bug-22368-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22368-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22368-70-YaBJyhVufS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #51 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 10:41:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 09:41:46 +0000 Subject: [Koha-bugs] [Bug 5334] Add explicit foreign key constraints In-Reply-To: <bug-5334-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-5334-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5334-70-NiDQqUrI05@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5334 Bug 5334 depends on bug 22368, which changed state. Bug 22368 Summary: Table suggestions lacks foreign key constraints https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 10:41:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 09:41:46 +0000 Subject: [Koha-bugs] [Bug 7811] borrowers.borrowernumber should be a foreign key for 8 tables In-Reply-To: <bug-7811-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7811-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7811-70-LEnMGwJEz5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7811 Bug 7811 depends on bug 22368, which changed state. Bug 22368 Summary: Table suggestions lacks foreign key constraints https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 10:41:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 09:41:46 +0000 Subject: [Koha-bugs] [Bug 22348] Koha::EDI has no tests In-Reply-To: <bug-22348-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22348-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22348-70-mVmTO90NqC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22348 Bug 22348 depends on bug 22368, which changed state. Bug 22368 Summary: Table suggestions lacks foreign key constraints https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22368 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 10:42:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 09:42:19 +0000 Subject: [Koha-bugs] [Bug 11375] Improve patrons permissions display In-Reply-To: <bug-11375-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11375-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11375-70-H9RQF3gDRn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED CC| |martin.renvoize at ptfs-europe | |.com Resolution|--- |FIXED --- Comment #40 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 10:43:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 09:43:31 +0000 Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile In-Reply-To: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18589-70-VvYqYQpDYh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86506|0 |1 is obsolete| | --- Comment #24 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 86507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86507&action=edit Bug 18589: (follow-up) Fix merge problem Bug in passing row to getStatusName As per item 3) in comment #20: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589#c20 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 10:43:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 09:43:38 +0000 Subject: [Koha-bugs] [Bug 22222] Mana subscription search always returns all results In-Reply-To: <bug-22222-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22222-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22222-70-Vh3RxInzH2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22222 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86396|0 |1 is obsolete| | --- Comment #3 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 86508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86508&action=edit Bug 22222: Don't send empty params to mana service Test plan: 0) Do not apply the patch 1) Go to serials > Search on Mana 2) Insert some value into the form 3) Submit -> you get many (3000+) results 4) Apply the patch and restart_all 5) Repeat, now, you get only the subscription matching your query Signed-off-by: Michal Denar <black23 at gmail.com> Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 10:44:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 09:44:11 +0000 Subject: [Koha-bugs] [Bug 22222] Mana subscription search always returns all results In-Reply-To: <bug-22222-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22222-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22222-70-2Wtt0QKKFd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22222 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA QA Contact|testopia at bugs.koha-communit |alex.arnaud at biblibre.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 10:44:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 09:44:30 +0000 Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile In-Reply-To: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18589-70-wdjueJX4xc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86506|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 10:47:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 09:47:02 +0000 Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile In-Reply-To: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18589-70-m4DKufiISb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #25 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- (In reply to Josef Moravec from comment #20) > 1) You are setting dateFormat on two places, but not use it anywhere. Good spot, this was a merge error, fixed in https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86506 > 2) In the ill requests list tables (both, in ill module and patron ill view) > are shown columns placed_unformatted and updated_unformatted, only data, > table header is blank. These are used for sorting. This is a technique I observed was used elsewhere. Since the formatted dates don't always work well for sorting, hidden unformatted date columns that are used for sorting are used instead. > 3) There is error in js console, when load the ill request lista table in > ill module > ill-list-table_18.1200024.js:242 Uncaught TypeError: Cannot read property > 'hasOwnProperty' of undefined Another merge error, fixed in https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86507 > 3) when trying to filter by date placed, there is one more error in console: > ill-list-table_18.1200024.js:519 Uncaught TypeError: Cannot read property > 'api' of undefined > at HTMLFormElement.<anonymous> (ill-list-table_18.1200024.js:519) > at HTMLFormElement.dispatch (jquery-2.2.3.min_18.1200024.js:3) > at HTMLFormElement.r.handle (jquery-2.2.3.min_18.1200024.js:3) I can't replicate this. Can you make sure you do a hard refresh and try again? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 10:49:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 09:49:30 +0000 Subject: [Koha-bugs] [Bug 22496] New: Add new index on 003 Message-ID: <bug-22496-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22496 Bug ID: 22496 Summary: Add new index on 003 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Zebra Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de Target Milestone: --- In order to be able to match on 001 in combination with 003, 003 needs to be indexed in Zebra. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 11:12:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 10:12:53 +0000 Subject: [Koha-bugs] [Bug 22454] Add Koha::Item::hidden_in_opac method In-Reply-To: <bug-22454-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22454-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22454-70-HjXh2rxTsr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22454 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 11:12:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 10:12:56 +0000 Subject: [Koha-bugs] [Bug 22454] Add Koha::Item::hidden_in_opac method In-Reply-To: <bug-22454-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22454-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22454-70-pB2dHe0FUT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22454 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86061|0 |1 is obsolete| | Attachment #86501|0 |1 is obsolete| | --- Comment #4 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86509&action=edit Bug 22454: Unit tests Signed-off-by: Michal Denar <black23 at gmail.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 11:12:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 10:12:59 +0000 Subject: [Koha-bugs] [Bug 22454] Add Koha::Item::hidden_in_opac method In-Reply-To: <bug-22454-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22454-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22454-70-znKSS8iSw8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22454 --- Comment #5 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86510&action=edit Bug 22454: Add Koha::Item::hidden_in_opac method This patch adds a hidden_in_opac method that does the same calculation done in GetHiddenItemnumbers, but for a single item, and doesn't get the OpacHiddenItems syspref, but expects them to be passed as parameters (to avoid multiple reads). To test: - Apply this patches - Run: $ kshell k$ prove t/db_dependent/Koha/Item.t => SUCCESS: Tests pass! Signed-off-by: Michal Denar <black23 at gmail.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 11:17:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 10:17:12 +0000 Subject: [Koha-bugs] [Bug 22222] Mana subscription search always returns all results In-Reply-To: <bug-22222-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22222-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22222-70-9To6TAZydG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22222 --- Comment #4 from Josef Moravec <josef.moravec at gmail.com> --- (In reply to Alex Arnaud from comment #3) > Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com> Thanks Alex -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 11:18:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 10:18:14 +0000 Subject: [Koha-bugs] [Bug 22455] Add Koha::Biblio::hidden_in_opac method In-Reply-To: <bug-22455-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22455-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22455-70-z4ecglGueu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22455 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86502|0 |1 is obsolete| | Attachment #86503|0 |1 is obsolete| | --- Comment #5 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86511&action=edit Bug 22455: Unit tests Signed-off-by: Michal Denar <black23 at gmail.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 11:18:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 10:18:11 +0000 Subject: [Koha-bugs] [Bug 22455] Add Koha::Biblio::hidden_in_opac method In-Reply-To: <bug-22455-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22455-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22455-70-b1gKpRmIM9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22455 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 11:18:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 10:18:17 +0000 Subject: [Koha-bugs] [Bug 22455] Add Koha::Biblio::hidden_in_opac method In-Reply-To: <bug-22455-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22455-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22455-70-Fpo9ATX8te@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22455 --- Comment #6 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86512&action=edit Bug 22455: Add Koha::Biblio::hidden_in_opac method This patch adds a hidden_in_opac method that does the same calculation done in places like opac-tags.pl. The condition that is checked is that all items belonging to the biblio are hidden. This is the current behaviour in the code. To test: - Apply this patches - Run: $ kshell k$ prove t/db_dependent/Koha/Biblio.t => SUCCESS: Tests pass! Signed-off-by: Michal Denar <black23 at gmail.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 11:58:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 10:58:09 +0000 Subject: [Koha-bugs] [Bug 10260] Enter a note when writing off all or pay selected In-Reply-To: <bug-10260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10260-70-6TTGYxt91k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10260 Janet McGowan <janet.mcgowan at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 12:00:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 11:00:38 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14957-70-dA95Jgw11v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 Frank Hansen <frank.hansen at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 12:02:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 11:02:32 +0000 Subject: [Koha-bugs] [Bug 8137] Checkout limit by patron category for all libraries In-Reply-To: <bug-8137-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8137-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8137-70-yEAEKtJ1kf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8137 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #30 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Are you still hoping to move this one forward Alex.. trying to ascertain the current state. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 12:27:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 11:27:16 +0000 Subject: [Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images In-Reply-To: <bug-22445-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22445-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22445-70-U4Nsm7VP5L@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Hugo Agud <hagud at orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hagud at orex.es --- Comment #20 from Hugo Agud <hagud at orex.es> --- I have checked all test plan and it works fine, JUST the image size is the original image size, then if the thumbnail is bigger the image appear big... it can be fixed by css for sure.. but perhaps some kind of code limitation? it is just a suggestions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 12:49:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 11:49:40 +0000 Subject: [Koha-bugs] [Bug 22367] Editing a record has quotes changed to " In-Reply-To: <bug-22367-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22367-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22367-70-vNfB57MlNi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22367 --- Comment #2 from b.pastern4k at gmail.com --- I had 18.11.00, updated it and all works like charm. Thanks for the help! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 13:12:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 12:12:11 +0000 Subject: [Koha-bugs] [Bug 21974] cxn_pool must be configurable In-Reply-To: <bug-21974-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21974-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21974-70-XJlgxxQyVY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21974 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Failed QA --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- No tests here.. and we've snuck in configuration of not just cxn_pool, but also a couple of other variables. I'd also like to see these newly exposed variables documented somewhere.. Failing QA for now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 13:12:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 12:12:28 +0000 Subject: [Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library In-Reply-To: <bug-21886-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21886-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21886-70-VBdeKZc2bV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 Bj?rn Nyl?n <bjorn.nylen at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82668|0 |1 is obsolete| | --- Comment #3 from Bj?rn Nyl?n <bjorn.nylen at ub.lu.se> --- Created attachment 86513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86513&action=edit Bug 21886: Add option to send notices from owning library instead of issuing library The provided patch adds the following functionality: * Add --owning to both advance_notice.pl and overdue_notice.pl * Add --library to advance_notice.pl like the way overdue_notice.pl already works When specifying "--owning" both scripts will use items.homebranch instead of issues.branchcode to determine sending library. For advance_notice.pl this affects non-digest DUE and PREDUE, but not digest notices. To test: 1. Have a patron who wants advance notices as email with 2 days in advance (not digest) 2. Have the first overdue date set 3 days past due date 3. Have issue for that patron where date_due is 2 days away where the item homebranch differs from the issuing branch 4. Have issue for that patron where date_due is 3 days old 5. Run advance_notices.pl without --owning 6. Run overdue_notices.pl without --owning 7. Confirm that two messages were created for that patron with the sender being the issuing branch 8. Delete messages or create two more issues according to (3) and (4) 9. Run advance_notices.pl with --owning 10. Run overdue_notices.pl with --owning 11. Confirm that the two messages created has the item homebranch as sender Extra feature for advance_notices.pl is that it adds a "--library" the same way overdue_notices.pl has. Adding variants of that flag in steps (5) and (9) above can confirm this option as well. Sponsored-by: Gothenburg University Library Signed-off-by: Bj?rn Nyl?n <bjorn.nylen at ub.lu.se> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 13:13:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 12:13:15 +0000 Subject: [Koha-bugs] [Bug 21886] Add option to send notices from owning library instead of issuing library In-Reply-To: <bug-21886-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21886-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21886-70-usCPh0bm19@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21886 Bj?rn Nyl?n <bjorn.nylen at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |bjorn.nylen at ub.lu.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 13:13:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 12:13:55 +0000 Subject: [Koha-bugs] [Bug 22476] MarkLostItemsAsReturned has wrong defaults for new installs In-Reply-To: <bug-22476-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22476-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22476-70-2xZI1rMgrn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22476 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Trivial patch, Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 13:14:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 12:14:00 +0000 Subject: [Koha-bugs] [Bug 22476] MarkLostItemsAsReturned has wrong defaults for new installs In-Reply-To: <bug-22476-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22476-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22476-70-58bPQsI9nS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22476 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 13:13:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 12:13:36 +0000 Subject: [Koha-bugs] [Bug 22476] MarkLostItemsAsReturned has wrong defaults for new installs In-Reply-To: <bug-22476-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22476-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22476-70-wu6uzbKarO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22476 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86404|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86514&action=edit Bug 22476: Correct default for MarkLostItemsAsReturned Signed-off-by: Bin Wen <bin.wen at inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 13:14:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 12:14:03 +0000 Subject: [Koha-bugs] [Bug 22476] MarkLostItemsAsReturned has wrong defaults for new installs In-Reply-To: <bug-22476-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22476-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22476-70-HXonZ9nsU5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22476 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 13:17:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 12:17:30 +0000 Subject: [Koha-bugs] [Bug 21974] cxn_pool must be configurable In-Reply-To: <bug-21974-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21974-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21974-70-Ot9Bgeu9Tv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21974 --- Comment #4 from Ere Maijala <ere.maijala at helsinki.fi> --- Documentation is one thing and I can take care of it. I'm not sure how to write any meaningful tests for this, however. Note that in practice the configurability changes nothing unless you actually add the settings to koha-conf.xml. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 13:18:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 12:18:15 +0000 Subject: [Koha-bugs] [Bug 21560] Optimize ODS exports In-Reply-To: <bug-21560-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21560-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21560-70-Z4UEnccomN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21560 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84693|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86515&action=edit Bug 21560: report ODS export optimization SQL reports can be exported with CSV, TSV of ODS format. When report has thousands of rows, using ODS format is around 10 times longer than other formats. It also loads CPU and RAM a lot. The longest call is expandTable(). I found that the call on OpenOffice-OODoc lib can be optimized. Based on https://grep.metacpan.org/search?qci=&q=expandTable&qft=&qd=OpenOffice-OODoc&f=examples%2Ftext2table Test plan : 1) Don't apply patch yet 2) Create a new SQL report : Home > Reports > Create from SQL 3) Enter a SQL that will return thousands of results 4) Run report 5) Click Download > Semicolon separated text (.csv), look execution time 6) Click Download > Open Document Spreadsheet, look execution time 7) Apply patch 8) Redo 5) and 6) and compare times, CSV export should be the same but ODS export should be better My tests shows 1,5 seconds for CSV export. And for ODS export : 18 seconds without patch and 8 seconds with patch. Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Chris Cormack <chrisc at catalyst.net.nz> Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 13:18:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 12:18:19 +0000 Subject: [Koha-bugs] [Bug 21560] Optimize ODS exports In-Reply-To: <bug-21560-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21560-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21560-70-gBdvUXUIaR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21560 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84694|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86516&action=edit Bug 21560: Optimize ODS export of gather_print_notices.pl Like previous patch, the call on OpenOffice-OODoc lib can be optimized. Based on https://grep.metacpan.org/search?qci=&q=expandTable&qft=&qd=OpenOffice-OODoc&f=examples%2Ftext2table Test plan inspired from Bug 11679. Test plan: - define your ODUE notice for the print template as: cardnumber:patron:email:item <<borrowers.cardnumber>>:<<borrowers.firstname>> <<borrowers.surname>>:<<borrowers.email>>:<item><<items.barcode>></item> - define overdues rules for a patron category - check-out 2 items using a due date in order to generate the overdue notices - check-in these 2 items - launch the script /misc/cronjobs/overdue_notices.pl - the 'message_queue' table should now contain 2 new entries - launch the gather_print_notices cronjob : perl misc/cronjobs/gather_print_notices.pl /tmp/test --ods --letter_code=OVERDUE -d=: - A ods file should be generated in your /tmp/test directory - Compare times with and without patch Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 13:18:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 12:18:22 +0000 Subject: [Koha-bugs] [Bug 21560] Optimize ODS exports In-Reply-To: <bug-21560-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21560-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21560-70-t2rpI1jZUE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21560 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85264|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86517&action=edit Bug 21560: create Koha::Util::OpenDocument with subroutine for ODS generation There is nearly the same code in misc/cronjobs/gather_print_notices.pl and reports/guided_reports.pl. This patch creates a new module with subroutine called by both scripts. If file path or content is undefined, subroutine will just return undef. If content is an empty arrayref, empty ods file is still generated. Unicode encoding is kept outisde because it may not be necessary. Note that for print notices the first line of message is always the column names so it is extracted only from first message. Test plan : Run previous patches test plans and check ODS files are the same. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 13:18:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 12:18:26 +0000 Subject: [Koha-bugs] [Bug 21560] Optimize ODS exports In-Reply-To: <bug-21560-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21560-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21560-70-ab6Xi4RUN1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21560 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85265|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86518&action=edit Bug 21560: Unit test for Koha::Util::OpenDocument Run prove t/Koha/Util/OpenDocument.t Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 13:18:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 12:18:29 +0000 Subject: [Koha-bugs] [Bug 21560] Optimize ODS exports In-Reply-To: <bug-21560-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21560-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21560-70-VSLLCGCm2H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21560 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86084|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86519&action=edit Bug 21560: (follow-up) move use at the top Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 13:19:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 12:19:38 +0000 Subject: [Koha-bugs] [Bug 21560] Optimize ODS exports In-Reply-To: <bug-21560-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21560-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21560-70-5J1TlEINWo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21560 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #31 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice lot of tidying and optimising here.. going back to PQA after the cleanups.. Thanks Fridolin! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 13:19:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 12:19:44 +0000 Subject: [Koha-bugs] [Bug 21560] Optimize ODS exports In-Reply-To: <bug-21560-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21560-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21560-70-rqxfaVBgKd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21560 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 13:19:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 12:19:48 +0000 Subject: [Koha-bugs] [Bug 21560] Optimize ODS exports In-Reply-To: <bug-21560-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21560-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21560-70-a5OIR4A9QV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21560 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 13:28:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 12:28:45 +0000 Subject: [Koha-bugs] [Bug 22429] Infinite loop in patron card printing In-Reply-To: <bug-22429-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22429-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22429-70-mHgU8tGIHc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22429 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85972|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86520&action=edit Bug 22429: Infinite loop in patron card printing Text fields in Patron Card Text Layouts can contain regular expression metacharacters, which - instead of being treated as literal values - are interpreted and prevent line wrapping. This causes the process to get stuck in an infinite loop, which keeps running even after the web server has timed out (at least when using CGI). This patch escapes the relevant input from the text field so the regular expression substitution treats characters as literals instead of as metacharacters. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 13:29:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 12:29:30 +0000 Subject: [Koha-bugs] [Bug 22429] Infinite loop in patron card printing In-Reply-To: <bug-22429-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22429-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22429-70-BFdaYMvT4J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22429 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize at ptfs-europe | |.com --- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- I agree that the other issues should be opened as a distinct bug and as such having testing this code I'm signing off on it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 13:30:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 12:30:56 +0000 Subject: [Koha-bugs] [Bug 22497] New: '0' width can lead to an infinite loop. Message-ID: <bug-22497-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22497 Bug ID: 22497 Summary: '0' width can lead to an infinite loop. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- > > "Aha... it's the parentheses which are the problem. They're being interpreted as > > regex metacharacters and not literal values!" > > We noticed that there seems to be an infinite loop if the template has some > or all entries with "0" in it (like in default when creating a new > template). Could this be the same cause? Sorry, I just realized that you were referring to the template rather than the layout. Yes, it would be a related problem, but a separate issue. If 'label_width' is 0, then $self->{'width'} will be 0. That means that this condition will be triggered: if (($string_width + $text_attribs->{'llx'}) > $self->{'width'}) And because $self->{'width'} is 0, then the following condition would never feasibly be triggered: if (($string_width + $text_attribs->{'llx'}) < $self->{'width'}) And this condition is the only thing that can stop the infinite loop. Really the line wrapping code looks like it would benefit from a re-write. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 13:31:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 12:31:14 +0000 Subject: [Koha-bugs] [Bug 22497] '0' width can lead to an infinite loop. In-Reply-To: <bug-22497-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22497-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22497-70-ZaMiPAa8sy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22497 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22429 Depends on| |22429 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22429 [Bug 22429] Infinite loop in patron card printing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 13:31:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 12:31:14 +0000 Subject: [Koha-bugs] [Bug 22429] Infinite loop in patron card printing In-Reply-To: <bug-22429-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22429-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22429-70-H0yF7dDqwZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22429 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22497 See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22497 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22497 [Bug 22497] '0' width can lead to an infinite loop. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 13:31:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 12:31:30 +0000 Subject: [Koha-bugs] [Bug 22497] '0' width can lead to an infinite loop. In-Reply-To: <bug-22497-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22497-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22497-70-SXpNAETKA7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22497 --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- See bug 22429 for context -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 13:32:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 12:32:16 +0000 Subject: [Koha-bugs] [Bug 22497] '0' width can lead to an infinite loop. In-Reply-To: <bug-22497-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22497-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22497-70-KB7IYycEpK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22497 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|22429 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22429 [Bug 22429] Infinite loop in patron card printing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 13:32:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 12:32:16 +0000 Subject: [Koha-bugs] [Bug 22429] Infinite loop in patron card printing In-Reply-To: <bug-22429-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22429-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22429-70-7HrrD1WODY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22429 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Blocks|22497 | --- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Trivial fix.. I've decide to go straight for QA Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22497 [Bug 22497] '0' width can lead to an infinite loop. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 13:32:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 12:32:55 +0000 Subject: [Koha-bugs] [Bug 22497] '0' width can lead to an infinite loop. In-Reply-To: <bug-22497-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22497-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22497-70-PczxsAI0k5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22497 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22429 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22429 [Bug 22429] Infinite loop in patron card printing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 13:32:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 12:32:55 +0000 Subject: [Koha-bugs] [Bug 22429] Infinite loop in patron card printing In-Reply-To: <bug-22429-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22429-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22429-70-aGvoErRZKT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22429 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22497 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22497 [Bug 22497] '0' width can lead to an infinite loop. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 13:39:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 12:39:29 +0000 Subject: [Koha-bugs] [Bug 10300] Allow transferring of items to be have separate IndependentBranches syspref In-Reply-To: <bug-10300-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10300-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10300-70-H0jdIdHU9u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10300 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- I agree, this is an enhancement at this point in reality. It does appear to work so I'm going to SO too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 13:41:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 12:41:07 +0000 Subject: [Koha-bugs] [Bug 10300] Allow transferring of items to be have separate IndependentBranches syspref In-Reply-To: <bug-10300-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10300-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10300-70-tj82uYGnOw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10300 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85880|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86521&action=edit Bug 10300: Allow transferring of items to be have separate IndependentBranches syspref Some libraries want to have IndependentBranches enabled, but still be able to transfer items between themselves. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Enable IndpendentBranches and IndependentBranchesTransfers 4) Log in as a super librarian 5) Note you can transfer items 6) Log in as a non-super librarian 7) Note you cannot transfer items 8) Disable IndependentBranchesTransfers 9) Note you can now transfer items Signed-off-by: Maribeth Shafer <mshafer at ckls.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 13:41:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 12:41:22 +0000 Subject: [Koha-bugs] [Bug 10300] Allow transferring of items to be have separate IndependentBranches syspref In-Reply-To: <bug-10300-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10300-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10300-70-uDvJaq0R6F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10300 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 13:41:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 12:41:28 +0000 Subject: [Koha-bugs] [Bug 10300] Allow transferring of items to be have separate IndependentBranches syspref In-Reply-To: <bug-10300-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10300-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10300-70-O9Ns0IYsru@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10300 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 13:41:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 12:41:10 +0000 Subject: [Koha-bugs] [Bug 10300] Allow transferring of items to be have separate IndependentBranches syspref In-Reply-To: <bug-10300-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10300-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10300-70-iaT9o5vM2T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10300 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85881|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86522&action=edit Bug 10300: (follow-up) add controls on transfers page This patch moves the check of IndependentBranchesTransfers pref to templates and adds permission test inside branchtransfers.pl. It also corrects the libraries combobox in branchtransfers.tt, this list can contain all libraries, it is the access to the page that may be protected. Additions to test plan : 1) 1.1) Enable CircSidebar 1.2) In circulation home page check the effect of IndependentBranchesTransfers on "Transfer" link 1.3) Go to return page and check then effect of IndependentBranchesTransfers on "Transfer" link 2) 2.1) In circ/branchtransfers.pl, with and without IndependentBranches you see all libraries are in combobox 3) 3.1) Set IndependentBranchesTransfers to no and go to circ/branchtransfers.pl 3.2) You are redirected to page 403 unless you are superlibarian Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 13:45:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 12:45:45 +0000 Subject: [Koha-bugs] [Bug 22390] When duplicating existing order lines new items are not created In-Reply-To: <bug-22390-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22390-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22390-70-UAKHm4AaCL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22390 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85473|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86523&action=edit Bug 22390: (bug 15184 follow-up) Use aqorders.subscriptionid instead of biblio.serial It seems that we made a wrong assumption on bug 15184, see commit d658cb6f7ecb18845a78d4708ee63ad1126f220f Bug 15184: Do copy items for not a serial OR if items are created on ordering To know if an order has been created from a subscription we should check $order->subscriptionid instead of the $biblio->serial flag Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 13:45:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 12:45:48 +0000 Subject: [Koha-bugs] [Bug 22390] When duplicating existing order lines new items are not created In-Reply-To: <bug-22390-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22390-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22390-70-MXtvyCye2h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22390 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86027|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86524&action=edit Bug 22390: Never copy items if original order has been created from a subscription Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 13:46:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 12:46:39 +0000 Subject: [Koha-bugs] [Bug 22390] When duplicating existing order lines new items are not created In-Reply-To: <bug-22390-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22390-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22390-70-psb2052LFZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22390 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice catch and followup. Signing Off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 14:01:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 13:01:24 +0000 Subject: [Koha-bugs] [Bug 21987] Local cover 'thumbnail' size is bigger than 'imagefile' size in biblioimages table In-Reply-To: <bug-21987-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21987-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21987-70-eikZQoZuXj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21987 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83369|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86525&action=edit Bug 21987: Add tests Signed-off-by: Michal Denar <black23 at gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 14:01:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 13:01:27 +0000 Subject: [Koha-bugs] [Bug 21987] Local cover 'thumbnail' size is bigger than 'imagefile' size in biblioimages table In-Reply-To: <bug-21987-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21987-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21987-70-oq0AtpWdKH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21987 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86215|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86526&action=edit Bug 21987: Do not generate true color thumbnails if not needed If the original image is not a true color image we should not generate a true color thumbnail. Signed-off-by: Michal Denar <black23 at gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 14:01:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 13:01:48 +0000 Subject: [Koha-bugs] [Bug 21987] Local cover 'thumbnail' size is bigger than 'imagefile' size in biblioimages table In-Reply-To: <bug-21987-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21987-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21987-70-voIK9IXC3B@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21987 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 14:02:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 13:02:02 +0000 Subject: [Koha-bugs] [Bug 21987] Local cover 'thumbnail' size is bigger than 'imagefile' size in biblioimages table In-Reply-To: <bug-21987-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21987-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21987-70-F9q8BNXJVp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21987 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- All works here, Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 14:07:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 13:07:24 +0000 Subject: [Koha-bugs] [Bug 22493] DecreaseLoanHighHolds.t creates some items/patrons with set values In-Reply-To: <bug-22493-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22493-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22493-70-FGkBWrZWWx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22493 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86476|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86527&action=edit Bug 22493: Clean up DecreaseLoanHighHolds.t To test: 1 - prove -v t/db_dependent/DecreaseLoanHighHolds.t 2 - should pass 3 - read code, confirm changes make sense Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 14:07:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 13:07:50 +0000 Subject: [Koha-bugs] [Bug 22493] DecreaseLoanHighHolds.t creates some items/patrons with set values In-Reply-To: <bug-22493-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22493-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22493-70-q0MTIGkcpK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22493 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Eminently sane, Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 14:14:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 13:14:55 +0000 Subject: [Koha-bugs] [Bug 22498] New: Can not select any funds for invoice adjustments Message-ID: <bug-22498-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22498 Bug ID: 22498 Summary: Can not select any funds for invoice adjustments Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Bug 14850 renamed budgets_loop to budgets but did not update the variables for invoice adjustments -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 14:15:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 13:15:05 +0000 Subject: [Koha-bugs] [Bug 22499] New: Itemcallnumber "0" not displayed Message-ID: <bug-22499-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22499 Bug ID: 22499 Summary: Itemcallnumber "0" not displayed Change sponsored?: --- Product: Koha Version: 17.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: rbit at rbit.cz QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Target Milestone: --- If there is "0" (just zero) as an itemcallnumber, it's not displayed in Holdings tab in /cgi-bin/koha/catalogue/detail.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 14:15:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 13:15:31 +0000 Subject: [Koha-bugs] [Bug 19417] Improve display of errors from background job during stage for import In-Reply-To: <bug-19417-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19417-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19417-70-313JE4XBDD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19417 --- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86529&action=edit Bug 19417: Make error just a wee more human Small follow up to make the text explicitly say "Import of records failed" instead of "Failed to submit form" Users don't even know that they're submitting a form, what they think they're doing is uploading records. Let's use their words instead of developer words. Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 14:15:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 13:15:28 +0000 Subject: [Koha-bugs] [Bug 19417] Improve display of errors from background job during stage for import In-Reply-To: <bug-19417-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19417-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19417-70-3rB05Ug63e@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19417 --- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86528&action=edit Bug 19417: Display full error text when problem importing records To test: 1 - Upload a file to stage 2 - Select your import options 3 - Delete the file from the server, example: sudo rm /tmp/koha_kohadev_uploads/ 4 - 'Click stage for import' 5 - Get an alert 'Failed to submit form: error' 6 - Apply patches 7 - Repeat 1-4 8 - Get a pretty error with additional info Signed-off-by: Liz Rea <wizzyrea at gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 14:15:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 13:15:34 +0000 Subject: [Koha-bugs] [Bug 19417] Improve display of errors from background job during stage for import In-Reply-To: <bug-19417-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19417-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19417-70-CCNzaP8N3p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19417 --- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86530&action=edit Bug 19417: (QA follow-up) Fix missing $raw filter Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 14:15:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 13:15:52 +0000 Subject: [Koha-bugs] [Bug 19417] Improve display of errors from background job during stage for import In-Reply-To: <bug-19417-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19417-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19417-70-GAzuxO4C3k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19417 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Attachment #86042|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 14:16:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 13:16:04 +0000 Subject: [Koha-bugs] [Bug 19417] Improve display of errors from background job during stage for import In-Reply-To: <bug-19417-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19417-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19417-70-gFdCbaWYKE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19417 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86038|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 14:16:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 13:16:47 +0000 Subject: [Koha-bugs] [Bug 22300] Staff search results: Opt groups in 'sort' pull down are not well formatted In-Reply-To: <bug-22300-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22300-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22300-70-jW22aQM1Ro@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22300 --- Comment #9 from Owen Leonard <oleonard at myacpl.org> --- (In reply to Jesse Maseto from comment #8) > Patch doesn't apply cleanly. Please rebase if needed for 18.05.x It is not needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 14:17:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 13:17:37 +0000 Subject: [Koha-bugs] [Bug 19417] Improve display of errors from background job during stage for import In-Reply-To: <bug-19417-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19417-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19417-70-OZVka6Jllp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19417 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Made a few minor corrections to make the QA scripts happy. Otherwise, a nice improvement which I think considerably improves feedback to the end user. I don't believe we can easily translate these error messages and do believe it's better to display them than to not display them so I'm Passing QA here even though it's untranslatable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 14:17:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 13:17:45 +0000 Subject: [Koha-bugs] [Bug 19417] Improve display of errors from background job during stage for import In-Reply-To: <bug-19417-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19417-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19417-70-pJotGkquBj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19417 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 14:18:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 13:18:10 +0000 Subject: [Koha-bugs] [Bug 20607] Elasticsearch - ability to add a relevancy weight in mappings.yaml file In-Reply-To: <bug-20607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20607-70-wpdpVv3yy1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20607 Bj?rn Nyl?n <bjorn.nylen at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bjorn.nylen at ub.lu.se --- Comment #3 from Bj?rn Nyl?n <bjorn.nylen at ub.lu.se> --- The functionality works but the tests fail due to the weight is beeing returned as a decimal number. # Failed test 'Match search field is weighted with 15' # at t/db_dependent/Koha/SearchEngine/Elasticsearch/Reset.t line 61. # got: '15.00' # expected: '15' # Failed test 'Title search field is weighted with 20' # at t/db_dependent/Koha/SearchEngine/Elasticsearch/Reset.t line 64. # got: '20.00' # expected: '20' # Looks like you failed 2 tests of 4. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 14:24:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 13:24:42 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14957-70-Klf3V6mw0s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #138 from Frank Hansen <frank.hansen at ub.lu.se> --- The patch is tested and works fine. Nice work! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 14:26:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 13:26:16 +0000 Subject: [Koha-bugs] [Bug 22498] Can not select any funds for invoice adjustments In-Reply-To: <bug-22498-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22498-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22498-70-JP70bSVEZb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22498 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 14:26:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 13:26:18 +0000 Subject: [Koha-bugs] [Bug 22498] Can not select any funds for invoice adjustments In-Reply-To: <bug-22498-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22498-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22498-70-uOwSlKqD6I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22498 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 86531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86531&action=edit Bug 22498: Rename variable for budgets loop for invoice adjustments To test: 1 - Try to add some adjustments to an invoice (receive shipments, create invoice, click 'finish receiving') 2 - Note the fund dropdown has only 'No fund' 3 - Apply patch 4 - Refresh page 5 - Note you can now select funds, hooray! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 14:26:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 13:26:29 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14957-70-X8uovLTxf7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #139 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Frank! Can you please add a sign-off line to the patch too? This can be done for example by using the sandboxes: https://wiki.koha-community.org/wiki/Sandboxes If you can't that's ok, we can also fix it in the QA step. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 14:26:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 13:26:54 +0000 Subject: [Koha-bugs] [Bug 22498] Can not select any funds for invoice adjustments In-Reply-To: <bug-22498-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22498-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22498-70-K0XrJyTaFb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22498 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | Depends on| |14850 Blocks| |22296 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14850 [Bug 14850] Funds from inactive budgets appear in 'Funds' dropdown on acqui/invoice.pl https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22296 [Bug 22296] Invoice adjustments are not populating to budget views -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 14:26:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 13:26:54 +0000 Subject: [Koha-bugs] [Bug 14850] Funds from inactive budgets appear in 'Funds' dropdown on acqui/invoice.pl In-Reply-To: <bug-14850-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14850-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14850-70-rbIPrYKrve@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14850 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22498 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22498 [Bug 22498] Can not select any funds for invoice adjustments -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 14:26:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 13:26:54 +0000 Subject: [Koha-bugs] [Bug 22296] Invoice adjustments are not populating to budget views In-Reply-To: <bug-22296-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22296-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22296-70-ogIWMeSyda@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22296 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22498 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22498 [Bug 22498] Can not select any funds for invoice adjustments -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 14:27:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 13:27:36 +0000 Subject: [Koha-bugs] [Bug 22296] Invoice adjustments are not populating to budget views In-Reply-To: <bug-22296-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22296-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22296-70-B0eqZ0j4Hx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22296 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84900|0 |1 is obsolete| | --- Comment #2 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 86532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86532&action=edit Bug 22296: Add Invoice Adjustments to GetBudgetHierarchy To test: 1 - prove -v t/db_dependent/Budgets.t 2 - Create some invoices on a single budget Invoice 1: add a non-encumbered adjustment for 1 add an encumbered adjustment 2 leave open Invoice 2: add a non-encumbered adjustment for 4 add an encumbered adjustment for 8 3 - View acq home page, should see 2 order and 12 spent for the budget 4 - View the spent and ordered pages, they should show the correct amounts 5 - Add more orders etc and confirm things total correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 14:27:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 13:27:33 +0000 Subject: [Koha-bugs] [Bug 22296] Invoice adjustments are not populating to budget views In-Reply-To: <bug-22296-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22296-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22296-70-rgFrc3PlAR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22296 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 14:28:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 13:28:26 +0000 Subject: [Koha-bugs] [Bug 20823] UNIMARC XSLT does not display 604$t In-Reply-To: <bug-20823-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20823-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20823-70-ATJdl4bp0C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20823 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85771|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86533&action=edit Bug 20823: UNIMARC XSLT add subfield t for subjects In UNIMARC, 604 contains subfield t, see http://multimedia.bnf.fr/unimarcb_trad/B604-6-2011.pdf. Actual XSLT files use template tag_subject for 604, it does not use t subfield. This patch adds subfield t to tag_subject and tag_onesubject templates in intranet and OPAC XSLT files. Test plan : 1) In UNIMARC catalog edit a biblio record to add 604$t 2) Use default XSLT files in sysprefs 2) Go to catalogue details page of this record using default XSLT files 3) Check $t is displayed at OPAC and intranet Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 14:28:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 13:28:49 +0000 Subject: [Koha-bugs] [Bug 20823] UNIMARC XSLT does not display 604$t In-Reply-To: <bug-20823-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20823-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20823-70-1FFUrZ9gqo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20823 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Trivial patch that does what it says on the tin.. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 14:28:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 13:28:55 +0000 Subject: [Koha-bugs] [Bug 20823] UNIMARC XSLT does not display 604$t In-Reply-To: <bug-20823-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20823-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20823-70-XkaJaNw7Y5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20823 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 14:29:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 13:29:50 +0000 Subject: [Koha-bugs] [Bug 19661] Add routes for funds In-Reply-To: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19661-70-2gRo1gBuiw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com QA Contact| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 14:30:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 13:30:44 +0000 Subject: [Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events In-Reply-To: <bug-20750-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20750-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20750-70-iZt23CXaA9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 14:30:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 13:30:48 +0000 Subject: [Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events In-Reply-To: <bug-20750-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20750-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20750-70-EFD5d4KB4L@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86434|0 |1 is obsolete| | Attachment #86435|0 |1 is obsolete| | Attachment #86436|0 |1 is obsolete| | --- Comment #139 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 86534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86534&action=edit Bug 20750: Allow logging of arbitrary actions This patch allows logging of arbitrary actions on request objects. A chronological summary of these actions can then be displayed when viewing a request. This patch also adds logging of request status changes. Additional work has been done on the BLDSS backend to log requests to the BLDSS request status check API. To test: - Apply patch - Ensure the Illlog logging preference is turned on - Create an ILL request and perform actions on it that change it's status. - Navigate to the "Manage ILL request" screen - Click the "Display request log" button - Observe that a modal opens displaying a summary of the status changes. Signed-off-by: Niamh Walker <Niamh.Walker-Headon at it-tallaght.ie> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Since this bug now is dependent on Bug 20581, it should be aware of the custom statuses provided in 20581. This patch enables logging of request statuses being changed to custom ones. As such the test plan is modified: To test: - Apply patch - Ensure the Illlog logging preference is turned on - Ensure you have some custom request statuses defined in the Authorised Values ILLSTATUS category - Create an ILL request and perform actions on it that change it's status. - Edit the request and change status to a custom one - Navigate to the "Manage ILL request" screen - Click the "Display request log" button - Observe that a modal opens displaying a summary of the status changes. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 14:32:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 13:32:00 +0000 Subject: [Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events In-Reply-To: <bug-20750-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20750-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20750-70-sgbZ2NVxgn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750 --- Comment #141 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 86536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86536&action=edit Bug 20750: (QA follow-up) Fix templates Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 14:31:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 13:31:56 +0000 Subject: [Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events In-Reply-To: <bug-20750-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20750-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20750-70-MCjxmZr7oc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750 --- Comment #140 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 86535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86535&action=edit Bug 20750: Add unit tests Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Bug 20750: (follow-up) Remove status_alias test This test is now redundant. We can't test the return of $req->status_alias against the value of $req->{status_alias} any more since we've overloaded the status_alias method and it won't always return the value of the object's property. We test the functionality of the status_alias method elsewhere so we're still covered. Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 14:33:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 13:33:38 +0000 Subject: [Koha-bugs] [Bug 19661] Add routes for funds In-Reply-To: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19661-70-6aHR2NSHX8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85693|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86537&action=edit Bug 19661: REST API - Funds Endpoint This patch adds a new route to the REST api: /api/v1/acquisitions/funds/ Signed-off-by: David Bourgault <david.bourgault at inlibro.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 14:33:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 13:33:42 +0000 Subject: [Koha-bugs] [Bug 19661] Add routes for funds In-Reply-To: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19661-70-iwp8hHnunT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85694|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86538&action=edit Bug 19661: Use Koha::Acquisition::Funds instead of C4::Budgets Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 14:33:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 13:33:45 +0000 Subject: [Koha-bugs] [Bug 19661] Add routes for funds In-Reply-To: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19661-70-bGfW0ladvi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85695|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86539&action=edit Bug 19661: Add and change properties and parameters to conform to the funds RFC. Also, perform an exact search when searching on the fund owner id. Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 14:33:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 13:33:48 +0000 Subject: [Koha-bugs] [Bug 19661] Add routes for funds In-Reply-To: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19661-70-aKn6u0rrac@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85696|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86540&action=edit Bug 19661: (follow-up) Use Basic auth in tests Test plan: prove t/db_dependent/api/v1/acquisitions_funds.t Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 14:34:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 13:34:47 +0000 Subject: [Koha-bugs] [Bug 19661] Add routes for funds In-Reply-To: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19661-70-Apwiq7dI4C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #22 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Thanks Matthias, All works well, no QA Script failures and as a new route there's no regressions.. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 14:50:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 13:50:25 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8995-70-2unac41E16@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 14:50:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 13:50:34 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8995-70-lh01ISIkyE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #97 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86542&action=edit Bug 8995: (follow-up) Add POD for GetOpenURLResolverURL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 14:50:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 13:50:29 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8995-70-xFd14FVMob@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #96 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86541&action=edit Bug 8995: (follow-up) Added test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 14:52:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 13:52:40 +0000 Subject: [Koha-bugs] [Bug 20128] Permission for advanced editor In-Reply-To: <bug-20128-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20128-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20128-70-3Nr6DB4874@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20128 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86208|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86543&action=edit Bug 20128: Add permission for advanced cataloging editor To test: 1 - Have a borrower with edit_catalogue permission and one with editcatalogue top level 2 - Confirm they can both access the advanced editor from the 'Cataloguing' home page or from the basic editor 3 - Apply patch 4 - Update database 5 - Confirm borrower with 'edit_catalogue' has 'advanced_editor' permission 6 - Confirm borrowers can access advanced editor as above 7 - Remove 'advanced_editor' permission from borrower 8 - Ensure they cannot access the advanced editor 9 - Ensure links to 'Edit record' from search results go to basic editor Signed-off-by: Liz Rea <wizzyrea at gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 14:53:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 13:53:38 +0000 Subject: [Koha-bugs] [Bug 20128] Permission for advanced editor In-Reply-To: <bug-20128-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20128-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20128-70-MmhQjwOIK2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20128 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Yeay for bug 22031 and it's first real use here :) All works as expected.. I had to do a minor rebase to get it to apply again. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 15:14:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 14:14:45 +0000 Subject: [Koha-bugs] [Bug 21953] Term "Lost item" untranslatable In-Reply-To: <bug-21953-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21953-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21953-70-L8Z7XNBHA7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Failed QA --- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Sorry Caroline but... There's a weird case here where a Lost item could receive two types of charge depending on what system preferences were in play. One with the code 'PF' for "Processing Fee" and another with the code "L" for Lost Item.. The DB update needs to catch both before I can PQA the bug.. Also, do we need to somehow distinguish that the Processing Fee line is attributed to the Lost item? With this patch we're losing that I think. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 15:16:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 14:16:22 +0000 Subject: [Koha-bugs] [Bug 21953] Term "Lost item" untranslatable In-Reply-To: <bug-21953-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21953-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21953-70-fwNYssepPA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|tomascohen at gmail.com |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 15:20:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 14:20:16 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14957-70-pOpzgKH8Er@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #140 from Frank Hansen <frank.hansen at ub.lu.se> --- Katrin, I have already signed off the patches from a sandbox. I'm getting: koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc: needs merge Guess, I don't have a change to do that. The sandbox is here: http://sb1.sandboxes.bywatersolutions.com if somebody want to try. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 15:34:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 14:34:35 +0000 Subject: [Koha-bugs] [Bug 14957] Write protecting MARC fields based on source of import In-Reply-To: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14957-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14957-70-knpgQA0gBG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14957 --- Comment #141 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Frank Hansen from comment #140) > Katrin, I have already signed off the patches from a sandbox. I'm getting: > koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc: needs merge > > Guess, I don't have a change to do that. > > The sandbox is here: http://sb1.sandboxes.bywatersolutions.com if somebody > want to try. Hi Frank, looks like we might need a rebase - master is changing fast and sometimes there are conflicts in files changed by different patches. We will fix it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 15:40:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 14:40:51 +0000 Subject: [Koha-bugs] [Bug 21953] Term "Lost item" is untranslatable In-Reply-To: <bug-21953-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21953-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21953-70-rsJepgWRPM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21953 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Term "Lost item" |Term "Lost item" is |untranslatable |untranslatable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 15:43:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 14:43:16 +0000 Subject: [Koha-bugs] [Bug 22249] Error when submitting Mana comment In-Reply-To: <bug-22249-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22249-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22249-70-iYp5KWQjdW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22249 Jon Knight <J.P.Knight at lboro.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |J.P.Knight at lboro.ac.uk --- Comment #1 from Jon Knight <J.P.Knight at lboro.ac.uk> --- Not tackling the cause of this directly (ie why is it requesting a module that doesn't exist and hasn't be loaded into the code) but what about having something like this before line 89: my $loaded = $packages->VERSION; if(!$loaded) { eval('use '.$packages); if(!$packages->VERSION) { warn "Can't load package $packages: $!\n"; } } -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 16:45:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 15:45:05 +0000 Subject: [Koha-bugs] [Bug 22489] Onboarding tool fails due to inserting maxissueqty into IssuingRule In-Reply-To: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22489-70-OTnDmucXKQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22489 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Liz Rea <wizzyrea at gmail.com> --- Hi Hayley, Thank you for the quick turnaround, however there is a QA fail: installer/onboarding.pl: Found use of Switch. This module is deprecated by the Perl 5 Porters at line 35, column 1. Find an alternative module. (Severity: 5) I suspect you will want to find a different solution for this. Thanks for keeping after it! Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 16:54:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 15:54:46 +0000 Subject: [Koha-bugs] [Bug 22489] Onboarding tool fails due to inserting maxissueqty into IssuingRule In-Reply-To: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22489-70-VUWnahnoxK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22489 --- Comment #5 from Liz Rea <wizzyrea at gmail.com> --- Oh also you left in some warns - it would be good to tidy those up. :) Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 17:40:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 16:40:10 +0000 Subject: [Koha-bugs] [Bug 18187] finishreceive.pl: Save bookseller name into items acquisition source field In-Reply-To: <bug-18187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18187-70-1uuvKVK4fW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18187 Serhij Dubyk <dubyk at ukr.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dubyk at ukr.net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 17:46:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 16:46:16 +0000 Subject: [Koha-bugs] [Bug 7890] Highlight required field in MARC editor In-Reply-To: <bug-7890-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7890-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7890-70-9vFNZEIsHs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7890 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86112|0 |1 is obsolete| | --- Comment #4 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 86544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86544&action=edit Bug 7890: Highlight required field in MARC editor This patch modifies the basic MARC editor so that required fields have the standard "Required" label on them instead of a small red asterisk. To test, apply the patch and create a new record in the basic MARC editor. Tags which are marked mandatory in your selected MARC bibliographic framework should be labeled "Required." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 17:46:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 16:46:44 +0000 Subject: [Koha-bugs] [Bug 22296] Invoice adjustments are not populating to budget views In-Reply-To: <bug-22296-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22296-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22296-70-yQ4Uw9se4l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22296 --- Comment #3 from Janet McGowan <janet.mcgowan at ptfs-europe.com> --- Hi Nick, Testing on our sandbox I'm seeing a problem in that after adding the initial adjustment, every time you subsequently click Update Adjustments it changes the Fund that you want to debit or credit back to No Fund. This means I can't really test properly as I can't add a 2nd adjustment line without it changing the Fund to No Fund! Do you need any more info? many thanks Janet -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 17:48:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 16:48:37 +0000 Subject: [Koha-bugs] [Bug 14438] RTF / CSV /ODS format in Download cart option In-Reply-To: <bug-14438-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14438-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14438-70-qWNLlSDymr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14438 Kelly McElligott <kelly at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly at bywatersolutions.com --- Comment #2 from Kelly McElligott <kelly at bywatersolutions.com> --- Created attachment 86545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86545&action=edit CSV profile -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 17:50:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 16:50:05 +0000 Subject: [Koha-bugs] [Bug 14438] RTF / CSV /ODS format in Download cart option In-Reply-To: <bug-14438-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14438-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14438-70-Gzi55Bqd9t@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14438 --- Comment #3 from Kelly McElligott <kelly at bywatersolutions.com> --- Katrin, I posted an attachment - has Koha changed? Now, when a CSV profile is created, there is a dropdown menu of 3 options where these profiles will display- and these profiles no longer display in the Download cart/list feature. The manual does not match what I current see on the Koha version 18.05.08. Kelly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 18:03:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 17:03:17 +0000 Subject: [Koha-bugs] [Bug 22498] Can not select any funds for invoice adjustments In-Reply-To: <bug-22498-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22498-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22498-70-sJcsoD2biG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22498 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86531|0 |1 is obsolete| | --- Comment #2 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 86546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86546&action=edit Bug 22498: Rename variable for budgets loop for invoice adjustments To test: 1 - Try to add some adjustments to an invoice (receive shipments, create invoice, click 'finish receiving') 2 - Note the fund dropdown has only 'No fund' 3 - Apply patch 4 - Refresh page 5 - Note you can now select funds, hooray! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 18:03:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 17:03:46 +0000 Subject: [Koha-bugs] [Bug 22296] Invoice adjustments are not populating to budget views In-Reply-To: <bug-22296-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22296-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22296-70-eQxMXlWa1j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22296 --- Comment #4 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Janet McGowan from comment #3) > Hi Nick, > Testing on our sandbox I'm seeing a problem in that after adding the initial > adjustment, every time you subsequently click Update Adjustments it changes > the Fund that you want to debit or credit back to No Fund. > This means I can't really test properly as I can't add a 2nd adjustment line > without it changing the Fund to No Fund! > Do you need any more info? > many thanks > Janet Looks like I missed updating one variable on the dependent bug 22498 - new patch attached there -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 18:07:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 17:07:31 +0000 Subject: [Koha-bugs] [Bug 22489] Onboarding tool fails due to inserting maxissueqty into IssuingRule In-Reply-To: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22489-70-4JQn6v8Znh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22489 --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Comment on attachment 86496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86496 Bug 22489: Fixed issue with onboarding tool failing at step 5 Review of attachment 86496: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=22489&attachment=86496) ----------------------------------------------------------------- Sorry.. I think there's a bit more work to do here I'm afraid. ::: admin/smart-rules.pl @@ +223,5 @@ > } > > + warn $bor; > + warn $itemtype; > + warn $br; Cleaning up the warnings again would be great ;) @@ +302,5 @@ > $sth_insert->execute($branch, $holdallowed, $hold_fulfillment_policy, $returnbranch); > } > > + warn $branch; > + warn $categorycode; More warnings ;) ::: installer/onboarding.pl @@ +31,5 @@ > use Koha::Patron::Categories; > use Koha::ItemTypes; > use Koha::IssuingRules; > +use Koha::CirculationRules; > +use Switch; Switch is recommended against... and doesn't appear to be used anywhere either. @@ +258,5 @@ > issuelength => $issuelength, > lengthunit => $lengthunit, > onshelfholds => $onshelfholds, > }; > + $branchcode = $branchcode if $branchcode ne '*'; Erm.. this doesn't make sense "Set branchcode to branchcode if branchcode not equal to '*'".. What were you intending here? @@ +260,5 @@ > onshelfholds => $onshelfholds, > }; > + $branchcode = $branchcode if $branchcode ne '*'; > + $branchcode = undef if $branchcode eq '*'; > + $categorycode = $categorycode if $categorycode ne '*'; As above.. I'm confused as to what the intention is here? @@ +262,5 @@ > + $branchcode = $branchcode if $branchcode ne '*'; > + $branchcode = undef if $branchcode eq '*'; > + $categorycode = $categorycode if $categorycode ne '*'; > + $categorycode = undef if $categorycode eq '*'; > + $itemtype = $itemtype if $itemtype ne '*'; and again.. @@ +278,4 @@ > eval { $issuingrule->store; }; > > + my $circulationrule = Koha::CirculationRule->new($circulationruleparams); > + eval { $circulationrule->store; }; New eval, but we're no longer catching errors for the first insert.. we'd need to catch errors above this line too.. @@ +287,4 @@ > push @messages, { code => 'error_on_insert_circ_rule' }; > } > } > + warn Koha::CirculationRules->count; Another warn ;) ::: koha-tmpl/intranet-tmpl/prog/en/modules/onboarding/onboardingstep5.tt @@ +98,5 @@ > + <label for="maxissueqty" class="required">Current checkouts allowed: </label> > + <input type="number" min="0" name="maxissueqty" id="maxissueqty" size="10" value="50" class="required" required="required" /> > + <span class="required">Required</span> > + </li> > + <li> This looks to me as though it's just been moved.. not sure why yet as I've not actually inspected the new UI layout.. perhaps it makes good sense to move it.. perhaps not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 18:24:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 17:24:11 +0000 Subject: [Koha-bugs] [Bug 22489] Onboarding tool fails due to inserting maxissueqty into IssuingRule In-Reply-To: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22489-70-WnnDH3VF92@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22489 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- I'd take a look around line 225 of admin/smart-rules.pl to see how the new maxissue stuff works.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 18:33:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 17:33:56 +0000 Subject: [Koha-bugs] [Bug 22489] Onboarding tool fails due to inserting maxissueqty into IssuingRule In-Reply-To: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22489-70-CKAkpnk4UI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22489 --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86547&action=edit Bug 22489: Update onboarding tool for bug 18925 When going through the onboarding process, the tool fails on submit of step 5, due to changes made in the database structure and rule definitions by bug 18925. This patch fixes this, adding code that creates a circulation rule where an issuing rule is also created in onboarding.pl. It removes maxissueqty from being sent with params to make an issuing rule, and adds it instead to the params to make a circulation rule, to reflect the changes that have been made in the database. Test plan: 1) Drop and recreate your database 2) Reload the staff client and follow the installer and onboarding process 3) Confirm that the process finishes without errors Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 18:34:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 17:34:23 +0000 Subject: [Koha-bugs] [Bug 22489] Onboarding tool fails due to inserting maxissueqty into IssuingRule In-Reply-To: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22489-70-4Kdxu1Tjwn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22489 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86496|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 18:34:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 17:34:33 +0000 Subject: [Koha-bugs] [Bug 22489] Onboarding tool fails due to inserting maxissueqty into IssuingRule In-Reply-To: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22489-70-MQm7spyuUv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22489 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86497|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 18:35:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 17:35:44 +0000 Subject: [Koha-bugs] [Bug 22489] Onboarding tool fails due to inserting maxissueqty into IssuingRule In-Reply-To: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22489-70-9qEcOn9sT9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22489 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- I felt mean asking Hayley to change so much.. so I've done a cleaned up patch myself.. I'd really appreciate your testing though Heyley, thanks for reporting it and having a first crack, you've saved me considerable time digging to work out the cause and fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 19:19:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 18:19:20 +0000 Subject: [Koha-bugs] [Bug 19619] Add support for SIP2 field CM ( Hold Pickup Date ) to Koha In-Reply-To: <bug-19619-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19619-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19619-70-7a5na54JMu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19619 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 19:19:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 18:19:23 +0000 Subject: [Koha-bugs] [Bug 19619] Add support for SIP2 field CM ( Hold Pickup Date ) to Koha In-Reply-To: <bug-19619-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19619-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19619-70-J5ncVJ5T3M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19619 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83716|0 |1 is obsolete| | --- Comment #2 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86548&action=edit Bug 19619: Add support for SIP2 field CM ( Hold Pickup Date ) to Koha The CM field was all set up for implementation, but never completed. We should fully implement the CM ( Hold Pickup Date ), which according to the SIP2 protocol specification is "The date that the hold expires". Test Plan: 1) Set up a waiting hold for an item 2) Using the sip cli emulator, send an item information request for that item 3) Note the CM field does not show up 4) Apply this patch 5) Restart all the things! 6) Repeat the item information request 7) Note the CM field is now transmitted! Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 19:27:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 18:27:55 +0000 Subject: [Koha-bugs] [Bug 22500] New: Patron Self Registration Verify by email does not work with display and prefill option Message-ID: <bug-22500-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22500 Bug ID: 22500 Summary: Patron Self Registration Verify by email does not work with display and prefill option Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: bwsdonna at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Target Milestone: --- When using sys pref PatronSelfRegistrationVerifyByEmail,sys pref PatronSelfRegistrationPrefillForm Display and Prefill does not work. Clicking on the verification link in the email takes patron to the correct page (PatronSelfRegistrationAdditionalInstructions), but the library card number and password are not displayed or prefilled in the login box. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 19:57:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 18:57:29 +0000 Subject: [Koha-bugs] [Bug 21890] Patron password reset by category In-Reply-To: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21890-70-BS7dKX4r2N@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com Status|Needs Signoff |Failed QA --- Comment #26 from Liz Rea <wizzyrea at gmail.com> --- Hi Tomas, I can't seem to get these to apply on latest master: error: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/admin/categories.tt). error: could not build fake ancestor Patch failed at 0001 Bug 21890: Allow restricting password resets by patron category Sorry :( Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 20:12:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 19:12:07 +0000 Subject: [Koha-bugs] [Bug 22501] New: OPAC course reserves notes should allow html links Message-ID: <bug-22501-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501 Bug ID: 22501 Summary: OPAC course reserves notes should allow html links Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Some libraries have been using the public notes field to point to electronic resources, this functionality has been removed by HTML filtering the content. We should allow the use of a $raw filter on these fields as they can only be entered by staff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 20:36:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 19:36:48 +0000 Subject: [Koha-bugs] [Bug 22501] OPAC course reserves notes should allow html links In-Reply-To: <bug-22501-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22501-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22501-70-beVG40KU4r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 20:43:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 19:43:37 +0000 Subject: [Koha-bugs] [Bug 22489] Onboarding tool fails due to inserting maxissueqty into IssuingRule In-Reply-To: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22489-70-JpOllgP67C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22489 --- Comment #10 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- (In reply to Martin Renvoize from comment #9) > I felt mean asking Hayley to change so much.. so I've done a cleaned up > patch myself.. I'd really appreciate your testing though Heyley, thanks for > reporting it and having a first crack, you've saved me considerable time > digging to work out the cause and fix. Sorry for all the mistakes there Martin and Katrin, I was working on this with someone else and I forgot that they had added all those warns. I appreciate having someone more experienced than me to make a follow up, so thank you for that. I will test your patch now :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 20:57:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 19:57:53 +0000 Subject: [Koha-bugs] [Bug 22501] OPAC course reserves notes should allow html links In-Reply-To: <bug-22501-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22501-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22501-70-W5cfvzt7Uv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501 Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mkstephens at lancasterseminar | |y.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 20:58:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 19:58:06 +0000 Subject: [Koha-bugs] [Bug 22410] Software error while adding order on a MARC file record without an author In-Reply-To: <bug-22410-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22410-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22410-70-4xX0EMXnsU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22410 Devinim <kohadevinim at devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kohadevinim at devinim.com.tr --- Comment #2 from Devinim <kohadevinim at devinim.com.tr> --- Hi Pierre-Marc, We have followed your steps. However we didn't get any error as you mentioned in step 7. The MARC file without tag 100 inserted into the system without any error. Devinim Koha Team -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 21:22:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 20:22:21 +0000 Subject: [Koha-bugs] [Bug 18011] Enrollment period date on patron category can be set in the past without any error/warning messages In-Reply-To: <bug-18011-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18011-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18011-70-552ijQSOO7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18011 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|alexbuckley at catalyst.net.nz |hayleymapley at catalyst.net.n | |z CC| |hayleymapley at catalyst.net.n | |z -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 21:27:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 20:27:37 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13952-70-DjU4smzuQW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85073|0 |1 is obsolete| | --- Comment #94 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 86549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86549&action=edit Bug 13952: (follow-up) Tests Run: prove -v t/db_dependent/ImportExportFramework.t and confirm all tests pass. I've also added a fix to remove the warns when exporting in ODS format. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 21:27:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 20:27:31 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13952-70-r752EGGACe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 21:29:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 20:29:41 +0000 Subject: [Koha-bugs] [Bug 22489] Onboarding tool fails due to inserting maxissueqty into IssuingRule In-Reply-To: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22489-70-rh9oO3XHlw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22489 --- Comment #11 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- All looks good Martin, the only issue (and it's a small one) is that the alert on the final page of the onboarding 'Circulation rule created' appears twice which may be confusing to users. I haven't found the cause of this yet, but it doesn't appear to be an issue with the database as there are no duplicates of the rules I created during onboarding. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 21:31:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 20:31:35 +0000 Subject: [Koha-bugs] [Bug 22502] New: Auto Complete not working when Placing Holds Message-ID: <bug-22502-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22502 Bug ID: 22502 Summary: Auto Complete not working when Placing Holds Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Target Milestone: --- Prior to Koha version, 18.05.10, if a library has the CIRCAUTOCOMPL system preference set to TRY, Koha would attempt to search for the patrons name during checkout (circulation.pl) or when placing holds for a patron (reserves.pl). In Koha 18.05.10, Koha is still attempting to complete the patron's name when using the checkout feature, but not when placing holds for patrons. The spinning thing does not appear when starting to type the patrons name on the reserves.pl page but does continue to work in the circulation.pl page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 21:35:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 20:35:06 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13952-70-r6E9iOilfr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Michal Denar <black23 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 21:35:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 20:35:10 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13952-70-Eit9lvJ0R7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Michal Denar <black23 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83024|0 |1 is obsolete| | Attachment #83025|0 |1 is obsolete| | Attachment #83026|0 |1 is obsolete| | Attachment #83027|0 |1 is obsolete| | Attachment #83028|0 |1 is obsolete| | Attachment #86549|0 |1 is obsolete| | --- Comment #95 from Michal Denar <black23 at gmail.com> --- Created attachment 86550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86550&action=edit Bug 13952: Import and export authority types This patch amends C4::ImportExportFramework to work for authority types as well as MARC frameworks. New file: admin/import_export_authtype.pl Update: Ensuring we are passing the right column to the right tables. Update2: Making the error messages the same to be consistent with patch on Bug 15665 Update3: Fixing merge conflicts Update4: Fixing merge conflicts and removing tabs Update5: Getting rid of warns, making sure Import and Export of default authority will work Update6: Merge conflicts and making sure export of default auth type works Update7: Fixing merge conflicts and updating buttons to bootstrap3 To test: 1) Go to Admin -> Authority types 2) Confirm there are two new columns 'Export' and 'Import' in the table 3) Click 'Export' on an existing authority type and choose a file type, click 'Export' 4) Confirm that the authority type is exported as your chosen file type. Save the file 5) Create a new authority type 6) Import into your new authority type using the file you just exported 7) Confirm you are taken to auth_tag_structure.pl 8) Go back to Authority types 9) Export your new authority type. View the exported file and confirm the authtypecode has been updated to match the code you set for the new auth type 10) Click 'Import' next to any existing authority type and attempt to import a file that is not XML, CSV or ODS. Confirm that this fails and you are asked to import a file of the correct file type 11) Confirm Export and Import work for the Default authority type 12) Go to Admin -> MARC bibliographic framework 13) Confirm that the 'Export' and 'Import' functions still work here as well Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Michal Denar <black23 at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 21:35:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 20:35:15 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13952-70-nZz2CJtOAb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #96 from Michal Denar <black23 at gmail.com> --- Created attachment 86551 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86551&action=edit Bug 13952: (follow-up) Fixing authority type import This patch fixes the comments from Comment 29 and the import functionality. You should now be able to import an exported file without editing the file at all and the authority type code will be overwritten in the file (same behaviour as biblio frameworks). Sponsored-by: Catalyst IT Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Michal Denar <black23 at gmail.com> Signed-off-by: Michal Denar <black23 at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 21:35:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 20:35:20 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13952-70-9PbcOsR0np@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #97 from Michal Denar <black23 at gmail.com> --- Created attachment 86552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86552&action=edit Bug 13952: (follow-up) Fixing import for default auth type Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Michal Denar <black23 at gmail.com> Signed-off-by: Michal Denar <black23 at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 21:35:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 20:35:25 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13952-70-2hzNVV0fR7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #98 from Michal Denar <black23 at gmail.com> --- Created attachment 86553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86553&action=edit Bug 13952: (follow-up) Fixing export on default biblio framework Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Michal Denar <black23 at gmail.com> Signed-off-by: Michal Denar <black23 at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 21:35:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 20:35:30 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13952-70-x0qw44ckD3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #99 from Michal Denar <black23 at gmail.com> --- Created attachment 86554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86554&action=edit Bug 13952: (follow-up) template filters, moving js to separate file This patch adds filters to the template file and moves the JS into a separate file. Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Michal Denar <black23 at gmail.com> Signed-off-by: Michal Denar <black23 at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 21:35:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 20:35:35 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13952-70-mAL2epEOLb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #100 from Michal Denar <black23 at gmail.com> --- Created attachment 86555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86555&action=edit Bug 13952: (follow-up) Tests Run: prove -v t/db_dependent/ImportExportFramework.t and confirm all tests pass. I've also added a fix to remove the warns when exporting in ODS format. Signed-off-by: Michal Denar <black23 at gmail.com> Signed-off-by: Michal Denar <black23 at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 22:28:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 21:28:08 +0000 Subject: [Koha-bugs] [Bug 21772] Add holds and account information tab to the SCO module In-Reply-To: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21772-70-BwVSmZCW7x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 --- Comment #8 from Sarah Cornell <sbcornell at cityofportsmouth.com> --- The tabs look good. I'm almost ready to sign off. At some point in my testing the SCO shut down. I think it was because the SCO was trying to edit an item as part of the normal process. I reproduced the shutdown when I tried to edit an item in the intranet. This is one of the last lines of the plack log when it shuts down: Use of uninitialized value $searchid in concatenation (.) or string at /kohadevbox/koha/cataloguing/addbiblio.pl line 853. 2019/03/12-19:48:38 Server closing! I don't see why it would be related but I'm new to testing on the sandboxes so I have to ask! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 23:55:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 22:55:44 +0000 Subject: [Koha-bugs] [Bug 21659] Link to basket groups from order receive page are broken In-Reply-To: <bug-21659-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21659-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21659-70-gLiJL8yu8O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21659 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 23:55:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 22:55:47 +0000 Subject: [Koha-bugs] [Bug 21659] Link to basket groups from order receive page are broken In-Reply-To: <bug-21659-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21659-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21659-70-YB5Ne0pAm7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21659 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81129|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 86556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86556&action=edit Bug 21659: Fix links to basket groups from order receive page Fixes a problem with the template variables on the order receive page, so that the links to basket groups work correctly again. To test: - Create some orders with and without basket groups - Receive shipment - Verify that the basket group links for pending orders work right - Receive an order line - Verify that the basket group links for received orders work right -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 12 23:56:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 22:56:21 +0000 Subject: [Koha-bugs] [Bug 21659] Link to basket groups from order receive page are broken In-Reply-To: <bug-21659-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21659-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21659-70-tphk3RoOCi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21659 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Dobrica, hope it's ok I stole this one. Fixed it a little differently to your patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 00:01:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 23:01:50 +0000 Subject: [Koha-bugs] [Bug 17832] arl (accelerated reading level) and ard (? -- Title point value) searches do not return results In-Reply-To: <bug-17832-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17832-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17832-70-3rNHY10lcQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17832 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** This bug has been marked as a duplicate of bug 20078 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 00:01:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 23:01:50 +0000 Subject: [Koha-bugs] [Bug 20078] Indexes 'arl' (Accelerated reading level) and 'arp' (Accelerated reading point) not usable in search menus In-Reply-To: <bug-20078-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20078-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20078-70-yUwDNkr1ep@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20078 --- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** Bug 17832 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 00:05:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 23:05:03 +0000 Subject: [Koha-bugs] [Bug 16924] Add Search by Accelerated Reading Level Range In-Reply-To: <bug-16924-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16924-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16924-70-9CR5kQ2Bq7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16924 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- bug 20078 has some sample jQuery to add the serach filters to advanced search. *** This bug has been marked as a duplicate of bug 20078 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 00:05:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 23:05:03 +0000 Subject: [Koha-bugs] [Bug 20078] Indexes 'arl' (Accelerated reading level) and 'arp' (Accelerated reading point) not usable in search menus In-Reply-To: <bug-20078-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20078-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20078-70-aRblQMfmsj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20078 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** Bug 16924 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 00:06:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 23:06:19 +0000 Subject: [Koha-bugs] [Bug 16915] Integrate OMDb in to Koha In-Reply-To: <bug-16915-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16915-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16915-70-1wEMGsciv3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16915 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|OPAC |Web services Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 00:12:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 23:12:21 +0000 Subject: [Koha-bugs] [Bug 6615] Add shelving location option to transfers page In-Reply-To: <bug-6615-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6615-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6615-70-fiuqBVQcIf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6615 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Owen, is this resolved with the item batch edit features? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 00:29:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 23:29:13 +0000 Subject: [Koha-bugs] [Bug 6625] Allow Koha to use Openlibrary subject API In-Reply-To: <bug-6625-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6625-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6625-70-MFmWYeXPgE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6625 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow Koha to use |Allow Koha to use |Openlibrary subject api |Openlibrary subject API CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- API is still marked as experimental, last change was: October 12, 2010 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 00:32:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 23:32:08 +0000 Subject: [Koha-bugs] [Bug 6659] Show OpacNav and OpacNavBottom on the login page In-Reply-To: <bug-6659-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6659-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6659-70-iuvdPlNRNN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6659 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|show opacnav on the log in |Show OpacNav and |page |OpacNavBottom on the login | |page --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Katrin Fischer from comment #1) > Still valid, but maybe by intention? For libraries not allowing OPAC > searches until after you have logged in, this might be the desired behaviour. Maybe it could also be tied to the OpacPublic system preference, only showing navigation, if the OPAC is public. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 00:34:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 23:34:20 +0000 Subject: [Koha-bugs] [Bug 6664] Allow to set a weekly holiday for a given data range In-Reply-To: <bug-6664-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6664-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6664-70-GoK7ad4Gik@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6664 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|enhancements to repeatable |Allow to set a weekly |holidays |holiday for a given data | |range CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 00:35:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 23:35:56 +0000 Subject: [Koha-bugs] [Bug 6705] Hide withdrawn items in OPAC In-Reply-To: <bug-6705-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6705-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6705-70-lCLYcyz4CY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6705 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED Summary|hide withdrawn items |Hide withdrawn items in | |OPAC Resolution|--- |FIXED --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Withdrawn items can be hidden using the OpacHiddenItems system preference, marking RESOLVED FIXED. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 00:38:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Mar 2019 23:38:42 +0000 Subject: [Koha-bugs] [Bug 6710] (Optionally) sort lists in OPAC pull down alphabetically instead of ordering by last changed In-Reply-To: <bug-6710-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6710-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6710-70-Pm2v7LDfsJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6710 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|lists of lists in Alpha |(Optionally) sort lists in |order |OPAC pull down | |alphabetically instead of | |ordering by last changed CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 01:42:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 00:42:13 +0000 Subject: [Koha-bugs] [Bug 18889] Add barcode to 'Pay Fines' tab in patrons payment page In-Reply-To: <bug-18889-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18889-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18889-70-S1B2oj7Ueb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z --- Comment #17 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- (In reply to Jonathan Druart from comment #16) > 1. Please adjust commit title and body > 2. Table footer is broken - > https://screenshots.firefox.com/26EsdTn15j1x9k4R/pro.kohadev.org > 3. Why a new column? Maybe it would make more sense to have it in the first > column, close to the biblio's title? > > Failing QA for 1 and 2, Discussion for 3. The current master has a barcode column in the Patrons 'Make a payment' tab. Does anything need to be done further for this bug or shall I mark it resolved? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 02:03:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 01:03:46 +0000 Subject: [Koha-bugs] [Bug 22333] Replace duplicated code in CanBookBeRenewed with GetSoonestRenewDate In-Reply-To: <bug-22333-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22333-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22333-70-1JbPbcFEMO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22333 --- Comment #6 from David Cook <dcook at prosentient.com.au> --- (In reply to Hayley Mapley from comment #5) > Test fails with the following error: > > t/db_dependent/Circulation.t .. 122/126 # No tests run! > t/db_dependent/Circulation.t .. 123/126 > # Failed test 'No tests run for subtest "AddRenewal and AddIssuingCharge > tests"' > # at t/db_dependent/Circulation.t line 2948. > Can't call method "lengthunit" on an undefined value at > /home/vagrant/kohaclone/Koha/Charges/Fees.pm line 101. > # Looks like your test exited with 11 just after 123. > t/db_dependent/Circulation.t .. Dubious, test returned 11 (wstat 2816, 0xb00) > Failed 4/126 subtests > > Test Summary Report > ------------------- > t/db_dependent/Circulation.t (Wstat: 2816 Tests: 123 Failed: 1) > Failed test: 123 > Non-zero exit status: 11 > Parse errors: Bad plan. You planned 126 tests but ran 123. > Files=1, Tests=123, 38 wallclock secs ( 0.07 usr 0.01 sys + 18.59 cusr > 3.22 csys = 21.89 CPU) > Result: FAIL Thanks, Hayley! I'm guessing this highlights a problem with that test rather than this patch though. Hmm. What are your thoughts, Tomas? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 04:27:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 03:27:18 +0000 Subject: [Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice In-Reply-To: <bug-15529-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15529-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15529-70-h6QO4UXGgv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z Status|Failed QA |Patch doesn't apply --- Comment #45 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Patch no longer applies - is somebody able to rebase? Applying: Bug 15529 - Locking process_message_queue.pl cron whilst it is running Applying: Bug 15529 - Wrapping email sending up in the verbose flag error: sha1 information is lacking or useless (misc/cronjobs/process_message_queue.pl). error: could not build fake ancestor Patch failed at 0001 Bug 15529 - Wrapping email sending up in the verbose flag -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 05:03:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 04:03:48 +0000 Subject: [Koha-bugs] [Bug 15529] Process Message Queue may send duplicate emails if process is launched twice In-Reply-To: <bug-15529-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15529-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15529-70-6WhPIZRe7t@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15529 --- Comment #46 from David Cook <dcook at prosentient.com.au> --- Comment on attachment 80256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=80256 Bug 15529: Altered logic for lockfile creation Review of attachment 80256: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=15529&attachment=80256) ----------------------------------------------------------------- ::: misc/cronjobs/process_message_queue.pl @@ +89,5 @@ > +foreach ( > + C4::Context->config("cron_lockdir"), > + '/var/lock/cron_' . C4::Context->config('database'), > + '/tmp/cron_' . C4::Context->config('database') > +) { This seems excessive and process_message_queue.pl doesn't seem like the place you'd want to do it anyway. This seems pretty generic and like it could be used by other scripts. @@ +98,5 @@ > +if( !defined $LockFH ) { > + print "WARNING: Could not create lock file $lockfile: $!\n"; > + print "Please check your koha-conf.xml for ZEBRA_LOCKDIR.\n"; > + print "Verify file permissions for it too.\n"; > + $use_flock = 0; # we disable file locking now and will continue Yeah, I'd say mandate that locks must be used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 08:01:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 07:01:26 +0000 Subject: [Koha-bugs] [Bug 18889] Add barcode to 'Pay Fines' tab in patrons payment page In-Reply-To: <bug-18889-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18889-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18889-70-mXwl2BmYM2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |katrin.fischer at bsz-bw.de Status|Failed QA |RESOLVED --- Comment #18 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Hayley Mapley from comment #17) > (In reply to Jonathan Druart from comment #16) > > 1. Please adjust commit title and body > > 2. Table footer is broken - > > https://screenshots.firefox.com/26EsdTn15j1x9k4R/pro.kohadev.org > > 3. Why a new column? Maybe it would make more sense to have it in the first > > column, close to the biblio's title? > > > > Failing QA for 1 and 2, Discussion for 3. > > The current master has a barcode column in the Patrons 'Make a payment' tab. > Does anything need to be done further for this bug or shall I mark it > resolved? You are right, it looks like it has been resolved already. It's also visible on the transactions tab. In this case you can mark "RESOLVED FIXED". If you are aware of the other bug that fixed it, you could also link them or 'Mark as duplicate'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 08:05:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 07:05:02 +0000 Subject: [Koha-bugs] [Bug 6846] Don't allow staff to change their own permissions In-Reply-To: <bug-6846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6846-70-JjShSSdrav@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6846 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- There is also the ProtectSuperlibrarianPrivileges system preference now, but I am not sure how to resolve the scenario Marc has pointed out. I think the only solution is to only give 'permissions' to users you trust. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 08:10:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 07:10:40 +0000 Subject: [Koha-bugs] [Bug 6845] Add default date (today) to view log In-Reply-To: <bug-6845-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6845-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6845-70-0MmpYm1FTU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6845 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|ASSIGNED |NEW Assignee|sagar.br at osslabs.biz |koha-bugs at lists.koha-commun | |ity.org --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Resetting to NEW and removing assignee as this hasn't been touched in 3 years. The log viewer has no default date at the moment. As we haven't had reports about any issues with the log viewer and server load, I am not sure if limiting to 1 day would not annoy more people than be helpful. If we would be doing this, I'd recommend to leave the link from the patron account (modification log) as is, as it's already limiting to the user. Maybe we could display a warning if you want to send the form without changing any of the filters instead? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 08:15:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 07:15:26 +0000 Subject: [Koha-bugs] [Bug 6819] Don't offer cancel order links for received order lines on basket summary In-Reply-To: <bug-6819-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6819-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6819-70-YO0BSsBvv9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6819 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Don't offer delete links |Don't offer cancel order |for received order lines on |links for received order |basket summary |lines on basket summary --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Nicole C. Engard from comment #5) > While I say it's required and you all think it's required - Koha does not > require it. I have received many thing when the basket was still open. > Also, you can reopen a basket and delete something you have received. So > there are multiple ways to accidentally delete something you have received. Apart from standing-order orders it is now required to close the basket in order to receive something from it. You can reopen the basket and cancel something, but it's more secure than it used to be. That said, I agree that cancelling an order should not be possible for received items. The way should be: undo receive > cancel order. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 08:16:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 07:16:42 +0000 Subject: [Koha-bugs] [Bug 6816] Capture member signature In-Reply-To: <bug-6816-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6816-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6816-70-BeKSdbTJvu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6816 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- There has not been any comment on this in 8 years, is this still a feature that would be needed? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 08:18:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 07:18:51 +0000 Subject: [Koha-bugs] [Bug 6812] Configure enrollment, renewal, duplicate card, hold fees by branch and patron category In-Reply-To: <bug-6812-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6812-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6812-70-z694OAui2p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6812 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Set up enrollment, renewal, |Configure enrollment, |duplicate card, hold fees |renewal, duplicate card, |by branch and memberhip |hold fees by branch and |category |patron category CC| |katrin.fischer at bsz-bw.de Version|unspecified |master --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Still valid, although it might make sense to split some of this up into separate bugs: - Move hold fee and enrollment fee to circulation rules page - Add new types of fees -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 08:22:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 07:22:19 +0000 Subject: [Koha-bugs] [Bug 6796] Overnight checkouts taking into account opening and closing hours In-Reply-To: <bug-6796-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6796-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6796-70-YTvaaV74gg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6796 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Overnight circulation of |Overnight checkouts taking |reference books |into account opening and | |closing hours Status|REOPENED |NEW -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 08:28:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 07:28:47 +0000 Subject: [Koha-bugs] [Bug 6795] Branch-specific OPAC preferences In-Reply-To: <bug-6795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6795-70-3ewDFOj22U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6795 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|koha.sekjal at gmail.com |koha-bugs at lists.koha-commun | |ity.org --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Currently one option to achieve this is overwriting system preferences from Apache. I am not sure if the 'contextual preferences engine' is going to happen at this point in time, as the developer has left. Maybe we could reuse this bug to improve the 'different OPAC views' idea, that can currently be only achieved with Apache settings. I think we need a concept for this, before moving the preferences makes sense. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 08:28:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 07:28:56 +0000 Subject: [Koha-bugs] [Bug 6795] Library-specific OPAC preferences In-Reply-To: <bug-6795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6795-70-j5QnnYXbqE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6795 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Branch-specific OPAC |Library-specific OPAC |preferences |preferences -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 08:33:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 07:33:40 +0000 Subject: [Koha-bugs] [Bug 6779] Don't allow patron renewal x days before expiry In-Reply-To: <bug-6779-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6779-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6779-70-VtLrEDJzhI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6779 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW Assignee|meenakshi.r at osslabs.biz |koha-bugs at lists.koha-commun | |ity.org --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Marc V?ron from comment #1) > Related to syspref 'ReturnBeforeExpiry' : > [Require / Don't require] patrons to return books before their accounts > expire (by restricting due dates to before the patron's expiration date). If you charge for renewals (rental fee) the ReturnBeforeExpiry might not have the desirable effect - the user would pay the same, but get less loan extension. Removing assignee as there has been no patch provided in years. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 09:13:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 08:13:09 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8995-70-WPTV4bDi7H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #98 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86557&action=edit Bug 8995: (follow-up) Move GetOpenURLResolverURL to Koha::Biblio->get_openurl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 09:13:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 08:13:14 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8995-70-RvCswuVmDV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #99 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86558&action=edit Bug 8995: (follow-up) Move GetCOinSBiblio to Koha::Biblio->get_coins Test plan: 1) Ensure the COinS span tag is still included on this pages. You need to look into html source and search for span tag with class 'Z3988', which has COinS string in title. Staff client: catalogue -> ISBDdetail catalogue -> MARCdetail catalogue -> detail virtualshelves -> shelves OPAC (you should have COinSinOPACResults system preference enabled): opac detail opac search opac shelves 2) Run tests: prove t/Biblio.t t/db_dependent/Biblio.t t/db_dependent/Koha/Biblio.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 09:31:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 08:31:22 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8995-70-U0RyybEGsf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #100 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86559&action=edit Bug 8995: (follow-up) Add one more test fot get_openurl Test plan: prove t/db_dependent/Koha/Biblio.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 09:31:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 08:31:56 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8995-70-9jH6UXLwu1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|josef.moravec at gmail.com |testopia at bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 09:59:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 08:59:46 +0000 Subject: [Koha-bugs] [Bug 8402] generate 'install_misc/debian.packages' file from debian/control file In-Reply-To: <bug-8402-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8402-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8402-70-nEuwiXroux@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8402 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Status|Failed QA |RESOLVED Resolution|--- |FIXED --- Comment #15 from Josef Moravec <josef.moravec at gmail.com> --- install_misc directory was removed, so I think this is not valid anymore -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 10:05:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 09:05:12 +0000 Subject: [Koha-bugs] [Bug 22503] New: DeathLocked'Gans Message-ID: <bug-22503-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22503 Bug ID: 22503 Summary: DeathLocked'Gans Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: alqiyaramdana123 at gmail.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Created attachment 86560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86560&action=edit Bug Dark Side Team -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 10:11:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 09:11:43 +0000 Subject: [Koha-bugs] [Bug 22503] SPAM In-Reply-To: <bug-22503-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22503-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22503-70-ZBIeozWsl6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22503 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Summary|DeathLocked'Gans |SPAM CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 10:39:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 09:39:24 +0000 Subject: [Koha-bugs] [Bug 22489] Onboarding tool fails due to inserting maxissueqty into IssuingRule In-Reply-To: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22489-70-boVrrLbsLQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22489 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86547|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86561&action=edit Bug 22489: Update onboarding tool for bug 18925 When going through the onboarding process, the tool fails on submit of step 5, due to changes made in the database structure and rule definitions by bug 18925. This patch fixes this, adding code that creates a circulation rule where an issuing rule is also created in onboarding.pl. It removes maxissueqty from being sent with params to make an issuing rule, and adds it instead to the params to make a circulation rule, to reflect the changes that have been made in the database. Test plan: 1) Drop and recreate your database 2) Reload the staff client and follow the installer and onboarding process 3) Confirm that the process finishes without errors Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 10:39:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 09:39:28 +0000 Subject: [Koha-bugs] [Bug 22489] Onboarding tool fails due to inserting maxissueqty into IssuingRule In-Reply-To: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22489-70-dbBwrQXVpD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22489 --- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86562&action=edit Bug 22489: (follow-up) Correctly set success messages The original patch was duplicating the success message upon successful circ rule insertion. This corrects that. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 10:41:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 09:41:53 +0000 Subject: [Koha-bugs] [Bug 22489] Onboarding tool fails due to inserting maxissueqty into IssuingRule In-Reply-To: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22489-70-mKF7Pr8YK0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22489 --- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- (In reply to Hayley Mapley from comment #11) > All looks good Martin, the only issue (and it's a small one) is that the > alert on the final page of the onboarding 'Circulation rule created' appears > twice which may be confusing to users. I haven't found the cause of this > yet, but it doesn't appear to be an issue with the database as there are no > duplicates of the rules I created during onboarding. Thanks for testing Hayley :). I hope I didn't come across too scary with my comments, it's great to have you onboard. I've now added a followup which should clean up the double messages. Many thanks, Martin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 10:42:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 09:42:22 +0000 Subject: [Koha-bugs] [Bug 22489] Onboarding tool fails due to inserting maxissueqty into IssuingRule In-Reply-To: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22489-70-1zBqbwXQCB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22489 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 10:58:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 09:58:09 +0000 Subject: [Koha-bugs] [Bug 21988] Add SMSSendFrom system preference for specifying a source number for SMS messages In-Reply-To: <bug-21988-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21988-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21988-70-ASZ7KQoSyJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21988 --- Comment #15 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- We've decided that we're going to abandon this as it's replicating functionality that already exists. It's true that moving it to a syspref makes it more user friendly, but it also introduces a migration path that we don't have the time to tackle. Leaving as "In discussion" in case anyone at any point in the future thinks it's worth tackling. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 11:05:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 10:05:54 +0000 Subject: [Koha-bugs] [Bug 9821] Zebra indexes useless subfields in UNIMARC 5XX In-Reply-To: <bug-9821-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9821-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9821-70-KzlPIdIWR9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9821 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|In Discussion |RESOLVED Resolution|--- |WONTFIX --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- I think we can safely kill this one off.. it's not been looked at for 5 years! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 11:11:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 10:11:47 +0000 Subject: [Koha-bugs] [Bug 22485] Add randomly generated password suggestion to add/modify patron form In-Reply-To: <bug-22485-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22485-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22485-70-BKInPbpIjN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22485 BASE Library Consortium <baselibrary.consortium at nhs.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baselibrary.consortium at nhs. | |net Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from BASE Library Consortium <baselibrary.consortium at nhs.net> --- This has been resolved thanks to Jason Robb at https://wiki.koha-community.org/wiki/JQuery_Library#Add_password_randomizer_to_memberentry -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 11:35:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 10:35:11 +0000 Subject: [Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior In-Reply-To: <bug-10577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10577-70-9JO1Vhl8UD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|In Discussion |Needs Signoff --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- This is still the case but I think the issue with it that Katrin found was resolved in bug 11578, setting back to NSO -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 11:38:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 10:38:16 +0000 Subject: [Koha-bugs] [Bug 22495] Restore su-geo field in Elasticsearch mappings In-Reply-To: <bug-22495-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22495-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22495-70-Mq4nKttNAU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22495 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18235 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 [Bug 18235] Elastic search - Configurable facets -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 11:38:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 10:38:16 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18235-70-8Y8C2rwPA4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22495 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22495 [Bug 22495] Restore su-geo field in Elasticsearch mappings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 11:39:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 10:39:34 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18235-70-r9S4itWRh7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #84 from Josef Moravec <josef.moravec at gmail.com> --- Bug 22495 is going to restore su-geo, so I think we should wait with this again :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 11:43:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 10:43:21 +0000 Subject: [Koha-bugs] [Bug 22504] New: Memcached not active but well configured to Message-ID: <bug-22504-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22504 Bug ID: 22504 Summary: Memcached not active but well configured to Change sponsored?: --- Product: Koha Version: 18.11 Hardware: PC OS: Linux Status: NEW Severity: major Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: ducry.remy at gmail.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Good morning, everyone, We are facing a problem related to Memcached. Here are the details of the installation: Koha Version 18.11.02.02.02.02.02.000 Ubuntu Server version 18.04 Installed under Linux server information and memcached status: http://51.75.27.51/pref-sys.png We have looked in the conf files and Memcached seems well configured but does not work as you can see in the screenshot. Feel free to ask me for more details if necessary, have a great day. Translated with www.DeepL.com/Translator -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 11:51:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 10:51:27 +0000 Subject: [Koha-bugs] [Bug 17371] Add routes for biblios In-Reply-To: <bug-17371-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17371-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17371-70-AwIwYTNuAc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 claire.hernandez at biblibre.com <claire.hernandez at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez at biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 11:53:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 10:53:35 +0000 Subject: [Koha-bugs] [Bug 22296] Invoice adjustments are not populating to budget views In-Reply-To: <bug-22296-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22296-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22296-70-RtJ7FhOOgC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22296 Janet McGowan <janet.mcgowan at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from Janet McGowan <janet.mcgowan at ptfs-europe.com> --- On our sandbox I've tested 22498 and 22296 together following the test plan for 22296 and all work together successfully. N.B As well as positive amounts I've also tested using minus sign on amounts to apply credits to a fund and this also works. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 12:17:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 11:17:45 +0000 Subject: [Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior In-Reply-To: <bug-10577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10577-70-X9DSty3Lwe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #19578|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86563 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86563&action=edit bug 10577: improve semantics of GetBudgetPeriod() Remove the option to pass zero to this function in order to get "the" active budget. This was a problem in three ways: - Koha doesn't require that there be only one active budget at a time, so the concept of "the" active budget doesn't make sense. - Having the single parameter be either an ID or a flag based on its value is poor function design. - No callers of GetBudgetPeriod() were actually using this modality. This patch also improves the DB-dependent tests for budgets by - wrapping the test in a transaction - counting budgets correctly To test: [1] Apply the patch. [2] Verify that prove -v t/db_dependent/Budgets.t passes [3] Verify in the staff interface that: - the budget hierarchy displays correctly - you can add and modify a budget Signed-off-by: Galen Charlton <gmc at esilibrary.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 12:17:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 11:17:48 +0000 Subject: [Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior In-Reply-To: <bug-10577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10577-70-3iLAtMrWAt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86564 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86564&action=edit Bug 10577: (QA follow-up) Remove bad call signature Whilst working through this patch for signoff I found a case where the calling signature of GetBudgetPeriod was incorrect. I removed the superflous passed parameter in this followup Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 12:18:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 11:18:22 +0000 Subject: [Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior In-Reply-To: <bug-10577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10577-70-OKBJEHV96g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Patch rescued and tested.. Signing off. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 12:18:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 11:18:26 +0000 Subject: [Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior In-Reply-To: <bug-10577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10577-70-k2hrT0fqQA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 12:19:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 11:19:23 +0000 Subject: [Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior In-Reply-To: <bug-10577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10577-70-IOMKjBpvQq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86565&action=edit Bug 10577: Improve semantics of GetBudgetPeriod() Remove the option to pass zero to this function in order to get "the" active budget. This was a problem in three ways: - Koha doesn't require that there be only one active budget at a time, so the concept of "the" active budget doesn't make sense. - Having the single parameter be either an ID or a flag based on its value is poor function design. - No callers of GetBudgetPeriod() were actually using this modality. This patch also improves the DB-dependent tests for budgets by - wrapping the test in a transaction - counting budgets correctly To test: [1] Apply the patch. [2] Verify that prove -v t/db_dependent/Budgets.t passes [3] Verify in the staff interface that: - the budget hierarchy displays correctly - you can add and modify a budget Signed-off-by: Galen Charlton <gmc at esilibrary.com> Rescued-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 12:19:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 11:19:26 +0000 Subject: [Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior In-Reply-To: <bug-10577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10577-70-mMyjJ20oHy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86564|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86566&action=edit Bug 10577: (QA follow-up) Remove bad call signature Whilst working through this patch for signoff I found a case where the calling signature of GetBudgetPeriod was incorrect. I removed the superflous passed parameter in this followup Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 12:19:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 11:19:43 +0000 Subject: [Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior In-Reply-To: <bug-10577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10577-70-IgSZHFBiBH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86563|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 12:23:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 11:23:27 +0000 Subject: [Koha-bugs] [Bug 22498] Can not select any funds for invoice adjustments In-Reply-To: <bug-22498-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22498-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22498-70-762huKN4u6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22498 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86546|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86567&action=edit Bug 22498: Rename variable for budgets loop for invoice adjustments To test: 1 - Try to add some adjustments to an invoice (receive shipments, create invoice, click 'finish receiving') 2 - Note the fund dropdown has only 'No fund' 3 - Apply patch 4 - Refresh page 5 - Note you can now select funds, hooray! Signed-off-by: Janet McGowan <janet.mcgowan at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 12:23:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 11:23:51 +0000 Subject: [Koha-bugs] [Bug 22296] Invoice adjustments are not populating to budget views In-Reply-To: <bug-22296-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22296-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22296-70-9GWE15wqGv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22296 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86532|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86568&action=edit Bug 22296: Add Invoice Adjustments to GetBudgetHierarchy To test: 1 - prove -v t/db_dependent/Budgets.t 2 - Create some invoices on a single budget Invoice 1: add a non-encumbered adjustment for 1 add an encumbered adjustment 2 leave open Invoice 2: add a non-encumbered adjustment for 4 add an encumbered adjustment for 8 3 - View acq home page, should see 2 order and 12 spent for the budget 4 - View the spent and ordered pages, they should show the correct amounts 5 - Add more orders etc and confirm things total correctly https://bugs.koha-community.org/show_bug.cgi?id=22296 Signed-off-by: Janet McGowan <janet.mcgowan at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 12:25:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 11:25:05 +0000 Subject: [Koha-bugs] [Bug 22296] Invoice adjustments are not populating to budget views In-Reply-To: <bug-22296-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22296-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22296-70-Qu1SwyOYUy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22296 --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Just doing the honours of uploading Janets signed patch for her.. sandboxes don't like signing of dependants. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 12:24:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 11:24:44 +0000 Subject: [Koha-bugs] [Bug 22498] Can not select any funds for invoice adjustments In-Reply-To: <bug-22498-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22498-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22498-70-jKwc5AhWiz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22498 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Just doing the honours of uploading Janets signed patch for her.. sandboxes don't like signing of dependants. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 12:25:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 11:25:25 +0000 Subject: [Koha-bugs] [Bug 22498] Can not select any funds for invoice adjustments In-Reply-To: <bug-22498-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22498-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22498-70-0DbnAhU5NU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22498 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 12:31:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 11:31:43 +0000 Subject: [Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior In-Reply-To: <bug-10577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10577-70-JLCkVYaeGk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=11578 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 12:31:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 11:31:43 +0000 Subject: [Koha-bugs] [Bug 11578] Improvement of the funds list view In-Reply-To: <bug-11578-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11578-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11578-70-J5BenqrfYI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11578 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10577 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 12:38:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 11:38:42 +0000 Subject: [Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking In-Reply-To: <bug-14457-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14457-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14457-70-s78vJpWbl1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 --- Comment #32 from Bj?rn Nyl?n <bjorn.nylen at ub.lu.se> --- Created attachment 86569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86569&action=edit Bug 14457 - QA follow up Pod coverage for 'NAME'. Moved sysprefs in order and moved semicolon to last line. Replaced tab indentation with spaces. Added "Swedish service for spellchecking" to the syspref description. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 12:43:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 11:43:05 +0000 Subject: [Koha-bugs] [Bug 14457] Integrate LIBRIS spellchecking In-Reply-To: <bug-14457-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14457-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14457-70-0e7MElGROW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14457 Bj?rn Nyl?n <bjorn.nylen at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bjorn.nylen at ub.lu.se --- Comment #33 from Bj?rn Nyl?n <bjorn.nylen at ub.lu.se> --- Tried to fix the QA-stuff. Firs time so be nice. We've been using this patch in production for almost a year now so it'd be nice to have it in the community code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 12:49:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 11:49:33 +0000 Subject: [Koha-bugs] [Bug 21974] cxn_pool must be configurable In-Reply-To: <bug-21974-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21974-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21974-70-kTShWchcdu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21974 --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Interesting.. I can't find tests for this module at all.. only the sub-modules. Perhaps I'm missing something.. Either way.. lets see some minimal documentation added and we can get this moving again. Thanks Ere. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 13:18:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 12:18:13 +0000 Subject: [Koha-bugs] [Bug 16882] Circ restrictions caused by long overdue should be removed when the offending item is returned In-Reply-To: <bug-16882-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16882-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16882-70-gAatG4PyHq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16882 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #1 from Magnus Enger <magnus at libriotech.no> --- I agree it would make sense to be able to tie a restriction to a specific on loan item, and then remove that specific restriction when the item is returned. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 13:19:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 12:19:49 +0000 Subject: [Koha-bugs] [Bug 21974] cxn_pool must be configurable In-Reply-To: <bug-21974-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21974-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21974-70-cpTj7C2tMb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21974 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #6 from Ere Maijala <ere.maijala at helsinki.fi> --- I've now added a bit of documentation: https://wiki.koha-community.org/wiki/Elasticsearch#Advanced_Connection_Settings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 13:51:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 12:51:58 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13952-70-5PU6i6eDJB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 --- Comment #101 from Josef Moravec <josef.moravec at gmail.com> --- Sorry, but still not ready, Export looks OK, but import not. When I try to import xml or ods, i end up with all fields deleted When I try to import CSV I see error message, that framework could not be imported. But automated test pass... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 13:52:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 12:52:12 +0000 Subject: [Koha-bugs] [Bug 13952] Import and export of authority types In-Reply-To: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13952-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13952-70-Xip6ctzfhM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13952 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 14:05:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 13:05:07 +0000 Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values In-Reply-To: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20307-70-apKrLRFUko@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307 Stefan Berndtsson <stefan.berndtsson at ub.gu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stefan.berndtsson at ub.gu.se --- Comment #7 from Stefan Berndtsson <stefan.berndtsson at ub.gu.se> --- (In reply to Jonathan Druart from comment #5) > Should we continue on the same way of item types (translation from the UI), > or extract the strings from the DB then use the new Koha::I18 module > (translation from POs)? I think going the item type route is the proper way to do it. Doing it through PO:s wouldn't really work. Libraries within the same language area (sv-SE in my case) will not use the same names for values like LOC, and most likely not have the same values at all, and you can't have locally edited PO files for each library. Translations for item types should be fairly similar to translations for authorised values. Patron categories and library names should also benefit from such a system. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 14:12:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 13:12:39 +0000 Subject: [Koha-bugs] [Bug 21860] Marc modification templates cannot check or change indicators In-Reply-To: <bug-21860-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21860-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21860-70-QYe2iw4X7C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21860 Kelly McElligott <kelly at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly at bywatersolutions.com --- Comment #1 from Kelly McElligott <kelly at bywatersolutions.com> --- As an enhancement to Koha's Marc Modification Template, it would be extremely helpful to include indicators as part of this process. A lot of libraries would like an easy way to remove their 7 indicators in 650 tags. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 14:12:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 13:12:49 +0000 Subject: [Koha-bugs] [Bug 21036] Fix a bunch of older warnings In-Reply-To: <bug-21036-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21036-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21036-70-PKSO1mGLdr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21036 Kelly McElligott <kelly at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 14:45:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 13:45:42 +0000 Subject: [Koha-bugs] [Bug 22505] New: Add column configuration to patron list table Message-ID: <bug-22505-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22505 Bug ID: 22505 Summary: Add column configuration to patron list table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Target Milestone: --- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 14:46:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 13:46:21 +0000 Subject: [Koha-bugs] [Bug 22505] Add column configuration to patron list table In-Reply-To: <bug-22505-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22505-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22505-70-qdX40t3Qe5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22505 --- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 86570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86570&action=edit Bug 22505: Add column configuration to patron list table Test plan: 1. Create a list of patrons 2. Add some patrons to this list 3. Go to this patron list (/cgi-bin/koha/patron_lists/list.pl?patron_list_id=XXX) 4. Verify that you can show/hide all columns except the one containing the checkbox 5. Verify that you can export the table data using the Export menu 6. Go to admin/columns_settings.pl, and verify that the configuration works for table 'patron-list-table' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 14:46:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 13:46:38 +0000 Subject: [Koha-bugs] [Bug 22505] Add column configuration to patron list table In-Reply-To: <bug-22505-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22505-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22505-70-qYgtfBDiOu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22505 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 15:17:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 14:17:34 +0000 Subject: [Koha-bugs] [Bug 22358] Add POD to Koha::SharedContent In-Reply-To: <bug-22358-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22358-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22358-70-vNIeIDasqG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22358 --- Comment #1 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 86571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86571&action=edit Bug 22358: Add POD to Koha::SharedContent -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 15:17:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 14:17:51 +0000 Subject: [Koha-bugs] [Bug 22358] Add POD to Koha::SharedContent In-Reply-To: <bug-22358-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22358-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22358-70-oK3aSc4393@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22358 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alex.arnaud at biblibre.com Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |alex.arnaud at biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 15:36:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 14:36:46 +0000 Subject: [Koha-bugs] [Bug 22339] Elasticsearch - fixed field mappings should match MARC ranges In-Reply-To: <bug-22339-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22339-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22339-70-IIbns6J7Dy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22339 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |ere.maijala at helsinki.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 16:31:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 15:31:44 +0000 Subject: [Koha-bugs] [Bug 21892] Robin Sheat is not a typo In-Reply-To: <bug-21892-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21892-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21892-70-55MFUhge0i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21892 --- Comment #15 from M. Tompsett <mtompset at hotmail.com> --- Created attachment 86572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86572&action=edit Bug 21892: Add prompt for CodeSpell update TEST PLAN --------- Now you can say no, get the spelling error. Say yes, and the spelling error goes away. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 16:33:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 15:33:42 +0000 Subject: [Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive In-Reply-To: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18723-70-izGqXQuMBl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86082|0 |1 is patch| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 16:49:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 15:49:17 +0000 Subject: [Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2 In-Reply-To: <bug-15253-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15253-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15253-70-XOoLigdfDx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74947|0 |1 is obsolete| | --- Comment #35 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86573&action=edit Bug 15253: Add Koha::Logger based logging for SIP2 Now that we have Koha::Logger, we should use it in our SIP server. This has the potential to make debugging SIP issue much easier. We should add the userid for the sipuser to the namespace so we can allow for separate files per sip user if wanted. Also modifies the log4perl.conf to lazy-open filehandles to log files, so the same config can be used with log-files needing different permissions. Test Plan: 1) Apply this patch set 2) Update the modififed log4perl.conf to your system 3) Restart your sip server 4) Tail your sip2.log, run some queries 5) Note you still get the same output messages as before, with the addition of the ip address and username ( if available ) prefixing the message. Based on original patches by Kyle Hall and additions by Olli-Antti Kivilahti. Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 16:49:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 15:49:34 +0000 Subject: [Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2 In-Reply-To: <bug-15253-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15253-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15253-70-Ty4C93Xgzq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #36 from Liz Rea <wizzyrea at gmail.com> --- Having had to struggle myself with the SIP logs and train others on how to find and use them in the past, I think this is a great improvement over the old system and we should make this change. If you want to change the hard coded values, please supply a patch to do so, I think this is fine to go in the way it is. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 16:50:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 15:50:05 +0000 Subject: [Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2 In-Reply-To: <bug-15253-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15253-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15253-70-DXATany6r1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 16:50:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 15:50:09 +0000 Subject: [Koha-bugs] [Bug 15253] Add Koha::Logger based logging for SIP2 In-Reply-To: <bug-15253-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15253-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15253-70-UkalIIvb30@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15253 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86573|0 |1 is obsolete| | --- Comment #37 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86574 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86574&action=edit Bug 15253: Add Koha::Logger based logging for SIP2 Now that we have Koha::Logger, we should use it in our SIP server. This has the potential to make debugging SIP issue much easier. We should add the userid for the sipuser to the namespace so we can allow for separate files per sip user if wanted. Also modifies the log4perl.conf to lazy-open filehandles to log files, so the same config can be used with log-files needing different permissions. Test Plan: 1) Apply this patch set 2) Update the modififed log4perl.conf to your system 3) Restart your sip server 4) Tail your sip2.log, run some queries 5) Note you still get the same output messages as before, with the addition of the ip address and username ( if available ) prefixing the message. Based on original patches by Kyle Hall and additions by Olli-Antti Kivilahti. Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 16:56:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 15:56:28 +0000 Subject: [Koha-bugs] [Bug 22237] Subscriptions are not linked to Mana upon edit In-Reply-To: <bug-22237-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22237-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22237-70-a2EVjCjGev@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22237 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86028|0 |1 is obsolete| | --- Comment #5 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 86575 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86575&action=edit Bug 22237: Subscriptions are not linked to Mana upon edit This patch modifies C4/Serials.pm so that during the process of editing a subscription a link to Mana can be created. To test, apply the patch and go to Serials. - Locate a subscription which was not created using Mana data but which can be found in Mana. - Edit the subscription, skipping to the second page. - View the results returned by Mana and select one. - Save the subscription. - Upon being redirected to the subscription detail page you should see a "Report mistake" button. This shows that the subscription has been linked to Mana successfully. Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Alex Arnaud <alex.arnaud at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 16:56:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 15:56:41 +0000 Subject: [Koha-bugs] [Bug 22237] Subscriptions are not linked to Mana upon edit In-Reply-To: <bug-22237-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22237-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22237-70-1djWllA9IA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22237 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |alex.arnaud at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 17:00:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 16:00:33 +0000 Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve aliased fields In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19575-70-SDtaorZW3g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #101 from Lucas Gass <lucas at bywatersolutions.com> --- not backporting this to 18.05x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 17:04:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 16:04:22 +0000 Subject: [Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13895-70-XBe6UV9mUb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 --- Comment #69 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86576 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86576&action=edit Bug 13895: Adapt naming according to voted RFC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 17:04:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 16:04:38 +0000 Subject: [Koha-bugs] [Bug 22489] Onboarding tool fails due to inserting maxissueqty into IssuingRule In-Reply-To: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22489-70-GGhjyRbqro@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22489 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 17:04:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 16:04:44 +0000 Subject: [Koha-bugs] [Bug 22489] Onboarding tool fails due to inserting maxissueqty into IssuingRule In-Reply-To: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22489-70-8ZUTWNid8Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22489 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86561|0 |1 is obsolete| | Attachment #86562|0 |1 is obsolete| | --- Comment #15 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86577 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86577&action=edit Bug 22489: Update onboarding tool for bug 18925 When going through the onboarding process, the tool fails on submit of step 5, due to changes made in the database structure and rule definitions by bug 18925. This patch fixes this, adding code that creates a circulation rule where an issuing rule is also created in onboarding.pl. It removes maxissueqty from being sent with params to make an issuing rule, and adds it instead to the params to make a circulation rule, to reflect the changes that have been made in the database. Test plan: 1) Drop and recreate your database 2) Reload the staff client and follow the installer and onboarding process 3) Confirm that the process finishes without errors Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 17:04:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 16:04:51 +0000 Subject: [Koha-bugs] [Bug 22489] Onboarding tool fails due to inserting maxissueqty into IssuingRule In-Reply-To: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22489-70-y7ToeDrfxE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22489 --- Comment #16 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86578&action=edit Bug 22489: (follow-up) Correctly set success messages The original patch was duplicating the success message upon successful circ rule insertion. This corrects that. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 17:09:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 16:09:55 +0000 Subject: [Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13895-70-djS5NvUSkq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86576|0 |1 is obsolete| | --- Comment #70 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86579&action=edit Bug 13895: Adapt naming according to voted RFC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 17:13:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 16:13:56 +0000 Subject: [Koha-bugs] [Bug 22228] Elasticsearch - standalone colons should be escaped when performing a search In-Reply-To: <bug-22228-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22228-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22228-70-3xiVjtPZDf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22228 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> --- not backporting this to the 18.05.x series -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 17:26:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 16:26:27 +0000 Subject: [Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13895-70-EYJxhzAPHV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 --- Comment #71 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86580&action=edit Bug 13895: Fix test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 17:31:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 16:31:42 +0000 Subject: [Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron" In-Reply-To: <bug-19919-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19919-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19919-70-K1nmXq3lIr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Christopher Brannon <cbrannon at cdalibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cbrannon at cdalibrary.org --- Comment #7 from Christopher Brannon <cbrannon at cdalibrary.org> --- (In reply to Katrin Fischer from comment #6) > (In reply to Magnus Enger from comment #5) > > Storing this info on the item level is also problematic in light of GDPR. > > > > Can anyone describe a use case for storing this info in items.paidfor? > > Good point, totally agree. We should not store patron information like names > in item data ever, there is too much risk in exporting the data in some way > or making it accidentally visible in the OPAC. > > I'd vote for removing it. +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 17:36:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 16:36:09 +0000 Subject: [Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive In-Reply-To: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18723-70-rgJqc1y6A8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 --- Comment #43 from Lucas Gass <lucas at bywatersolutions.com> --- Thanks Victor, backported to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 17:47:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 16:47:59 +0000 Subject: [Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive In-Reply-To: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18723-70-vgJdMKvu5b@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 --- Comment #44 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.11.x for 17.11.17 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 17:54:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 16:54:58 +0000 Subject: [Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive In-Reply-To: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18723-70-5c0yHq3Pxq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 --- Comment #45 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Thanks Lucas and Fridolin! :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 18:15:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 17:15:43 +0000 Subject: [Koha-bugs] [Bug 22311] Add a SysPref to allow adding content to the #moresearches div in the opac In-Reply-To: <bug-22311-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22311-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22311-70-x30i7pDXZR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22311 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 18:15:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 17:15:46 +0000 Subject: [Koha-bugs] [Bug 22311] Add a SysPref to allow adding content to the #moresearches div in the opac In-Reply-To: <bug-22311-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22311-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22311-70-kzmfMNCSNB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22311 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85524|0 |1 is obsolete| | --- Comment #5 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86581&action=edit Bug 22311 - Add a SysPref to allow adding content to the #moresearches div in the opac The idea of this development would be to match the syspref 'OPACSearchForTitleIn' but for populating the search headers (#moresearches) on the opac page to allow staff to easily add links without jQuery. Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Update the new OpacMoreSearches system preference to include the following line: <li><a href="https://duckduckgo.com/">Duck Duck Go</a></li> 4) Browse to the OPAC 5) Note your new link displays in the "moresearches" area of the OPAC. Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 18:20:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 17:20:30 +0000 Subject: [Koha-bugs] [Bug 20713] Add Russian UNIMARC authority structures In-Reply-To: <bug-20713-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20713-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20713-70-awV35rNpUv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20713 --- Comment #5 from M. Tompsett <mtompset at hotmail.com> --- Comment on attachment 75101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=75101 [PATCH 2/2] Remove old Russian UNIMARC authority structures Review of attachment 75101: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20713&attachment=75101) ----------------------------------------------------------------- UPDATE auth_subfield_structure SET hidden=1 WHERE hidden<>0 -- This would affect ALL entries, should there not be an "AND authtypecode=" type clause for each of these? could there not be other auth type codes other than the ones coded? If so, this would edit them, even though they are not updated here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 18:24:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 17:24:02 +0000 Subject: [Koha-bugs] [Bug 20713] Add Russian UNIMARC authority structures In-Reply-To: <bug-20713-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20713-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20713-70-d2PURGMQ9T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20713 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |mtompset at hotmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 18:38:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 17:38:59 +0000 Subject: [Koha-bugs] [Bug 22506] New: Transfer Slip does not populate on branchtransfers.pl Message-ID: <bug-22506-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22506 Bug ID: 22506 Summary: Transfer Slip does not populate on branchtransfers.pl Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: jzairo at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Target Milestone: --- It would be beneficial for some libraries who are transferring items from branch A to branch B to have a transfer slip to include with the transfer. Currently when a user is on branchtransfers.pl and enters a barcode to transfer an item to another branch, no transfer slip populates. It would be great to have the TRANSFERSLIP populate and have the option to print. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 18:45:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 17:45:44 +0000 Subject: [Koha-bugs] [Bug 13420] Holdings table sorting on volume information incorrect In-Reply-To: <bug-13420-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13420-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13420-70-Ko97aBL5Pc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13420 Laura Horgan <horganl at middlesex.mass.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |horganl at middlesex.mass.edu --- Comment #14 from Laura Horgan <horganl at middlesex.mass.edu> --- We would be interested in a sort by published date as we do not enter volumes or issues as finding that information too way to long for our staff. Fewer items are claimed these days and very few people ever come to us looking for a specific volume/issue of a periodical. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 18:54:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 17:54:33 +0000 Subject: [Koha-bugs] [Bug 16588] Remove the Readonly dependency (again) In-Reply-To: <bug-16588-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16588-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16588-70-uOynBrZpBG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16588 M. Tompsett <mtompset at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #46 from M. Tompsett <mtompset at hotmail.com> --- I was hoping for a sign off on my follow up. Now this needs a rebase, and it's messy. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 18:55:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 17:55:42 +0000 Subject: [Koha-bugs] [Bug 22507] New: Modification of the Holds Slip Message-ID: <bug-22507-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22507 Bug ID: 22507 Summary: Modification of the Holds Slip Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: jzairo at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Target Milestone: --- Some libraries have expressed wanting to change the format of how the hold slip prints for multi branch systems. Currently, when you check an item in, and a hold is triggered, when you print the hold slip you get a message at the top of the slip indicating "Transfer to/Hold in <<branches.branchname>>". If the item is not at the final location of the patron pickup, it is transferred to the branch pick up location. Once the item arrives, the staff member again checks the item in, a hold is triggered, when you print the hold slip you get the same message "Transfer to/Hold in <<branches.branchname>>". Multi branch libraries would like to have an option to either split this slip so staff can easily identify that it is a transfer or it is a hold awaiting pickup. Having "Transfer to/Hold in <<branches.branchname>>" at the top of the slip (even though it is at the final destination for hold pickup, is causing confusion for staff. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 18:58:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 17:58:14 +0000 Subject: [Koha-bugs] [Bug 15505] Mark Hold Items 'On hold' instead of 'Available' In-Reply-To: <bug-15505-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15505-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15505-70-b3Z0kC6T1k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15505 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com Status|Needs Signoff |Failed QA --- Comment #14 from Liz Rea <wizzyrea at gmail.com> --- Hi Nick, This one seems to cause searches in the OPAC to fail with Undefined subroutine &C4::Search::XSLTParse4Display called at /home/vagrant/kohaclone/C4/Search.pm line 2255. at /home/vagrant/kohaclone/C4/Search.pm line 2254 Please have a look! Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 19:31:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 18:31:48 +0000 Subject: [Koha-bugs] [Bug 21422] Create logging for any action triggered by a staff override In-Reply-To: <bug-21422-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21422-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21422-70-zHGlym3oMM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21422 Margaret <margaret at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |margaret at bywatersolutions.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 19:48:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 18:48:24 +0000 Subject: [Koha-bugs] [Bug 22505] Add column configuration to patron list table In-Reply-To: <bug-22505-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22505-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22505-70-bn4MDjZC1J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22505 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 19:48:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 18:48:27 +0000 Subject: [Koha-bugs] [Bug 22505] Add column configuration to patron list table In-Reply-To: <bug-22505-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22505-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22505-70-HdPm7N65nJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22505 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86570|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 86582 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86582&action=edit Bug 22505: Add column configuration to patron list table Test plan: 1. Create a list of patrons 2. Add some patrons to this list 3. Go to this patron list (/cgi-bin/koha/patron_lists/list.pl?patron_list_id=XXX) 4. Verify that you can show/hide all columns except the one containing the checkbox 5. Verify that you can export the table data using the Export menu 6. Go to admin/columns_settings.pl, and verify that the configuration works for table 'patron-list-table' Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 19:50:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 18:50:01 +0000 Subject: [Koha-bugs] [Bug 22507] Modification of the Holds Slip In-Reply-To: <bug-22507-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22507-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22507-70-mbKXDBf2oe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22507 robbinsk at middlesex.mass.edu changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robbinsk at middlesex.mass.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 20:22:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 19:22:59 +0000 Subject: [Koha-bugs] [Bug 22508] New: Add the ability to prefill 856$u with the direct URL of the file Message-ID: <bug-22508-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508 Bug ID: 22508 Summary: Add the ability to prefill 856$u with the direct URL of the file Change sponsored?: Sponsored Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Target Milestone: --- Currently the cataloguing plugin upload.pl prefill 856$u (or any other fields linked with the plugin) with something like: OPACBaseURL/cgi-bin/koha/opac-retrieve-file.pl?id=$hash In some cases we would like to have the link of the uploaded file directly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 20:25:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 19:25:47 +0000 Subject: [Koha-bugs] [Bug 22508] Add the ability to prefill 856$u with the direct URL of the file In-Reply-To: <bug-22508-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22508-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22508-70-8EXsvulNy7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86583&action=edit Bug 22508: Add upload_public_path to config -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 20:26:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 19:26:04 +0000 Subject: [Koha-bugs] [Bug 22508] Add the ability to prefill 856$u with the direct URL of the file In-Reply-To: <bug-22508-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22508-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22508-70-itsxTV3H4J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508 --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86584&action=edit Bug 22508: Add upload_public_url to config -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 20:26:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 19:26:18 +0000 Subject: [Koha-bugs] [Bug 22508] Add the ability to prefill 856$u with the direct URL of the file In-Reply-To: <bug-22508-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22508-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22508-70-x6aayhjDnq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508 --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86585&action=edit Bug 22508: Add the ability to prefill 856$u with the direct URL of the file When uploading a file using the cataloguing plugin, the current value used to fill 856$u (or others) in is OPACBaseURL/cgi-bin/koha/opac-retrieve-file.pl?id=a-big-hash This patch add the ability to define a custom and direct URL to this file. To accomplish that we need 2 new entries in our config file: * upload_public_path * upload_public_url The first one will be the local path where the files will be stored, that will be publicly accessible. The second one is the root of the URL which links to ths public dir path. Test plan: 0. Define the 2 new config entries, like: <upload_public_path>/home/vagrant/kohaclone/koha-tmpl/public_path</upload_public_path> <upload_public_url>http://catalogue.kohadev.org/public_path</upload_public_url> Then restart memcached+plack to take into account the changes 1. Link the cataloguing plugin 'upload.pl' to 856$u 2. Edit a record, 856$u > click the plugin link 3. A new "Use a public path:" appears if the config is set, tick it and upload a file 4. Pick "Choose the direct url" 5. 856$u will be prefilled with http://catalogue.kohadev.org/public_path/$hash_value instead of the usual http://catalogue.kohadev.org/cgi-bin/koha/opac-retrieve-file.pl?id=$hash_value 6. Use the link and confirm that you can access the file. Note: This patch is not ready for inclusion yet and is published to get feedback. There are several things that will block its inclusion: * TODO: "Delete" button must delete the file * See TODO and FIXME in the patch * Tests and POD for new methods are missing * Variable naming is not perfect * In discussion - what about the upload of files from outside of the cataloguing plugin? * TODO: add check to the about page (?) * FIXME: in upload_public_path the files are not suffixed by the filename as it is for upload_path. We certainly want to be consistent here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 20:30:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 19:30:52 +0000 Subject: [Koha-bugs] [Bug 22508] Add the ability to prefill 856$u with the direct URL of the file In-Reply-To: <bug-22508-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22508-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22508-70-nf2A1ZDYCh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion CC| |hagud at orex.es -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 20:32:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 19:32:39 +0000 Subject: [Koha-bugs] [Bug 22509] New: Add a script to generate MARC fields containing date formatted strings Message-ID: <bug-22509-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22509 Bug ID: 22509 Summary: Add a script to generate MARC fields containing date formatted strings Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Target Milestone: --- This will add a simple script to add MARC fields to bibliographic records with date information. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 20:37:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 19:37:49 +0000 Subject: [Koha-bugs] [Bug 22509] Add a script to generate MARC fields containing date formatted strings In-Reply-To: <bug-22509-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22509-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22509-70-YGoqd3Hsxn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22509 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 20:37:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 19:37:54 +0000 Subject: [Koha-bugs] [Bug 22509] Add a script to generate MARC fields containing date formatted strings In-Reply-To: <bug-22509-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22509-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22509-70-s04m6mLYFP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22509 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86586&action=edit Bug 22509: Add new script to add MARC fields with date formatted stringsto bib records Say you want to add, into a new MARC fields, the following string: 2/2019/Mar-03/13 Depending on today's date. Test plan: Use the script after with the different options (see --help option for the list) Sponsored-by: Orex Digital -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 20:38:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 19:38:49 +0000 Subject: [Koha-bugs] [Bug 22509] Add a script to generate MARC fields containing date formatted strings In-Reply-To: <bug-22509-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22509-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22509-70-moOritHKm4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22509 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hagud at orex.es -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 21:02:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 20:02:36 +0000 Subject: [Koha-bugs] [Bug 18889] Add barcode to 'Pay Fines' tab in patrons payment page In-Reply-To: <bug-18889-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18889-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18889-70-gEEos108jN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889 --- Comment #19 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- (In reply to Katrin Fischer from comment #18) > (In reply to Hayley Mapley from comment #17) > > (In reply to Jonathan Druart from comment #16) > > > 1. Please adjust commit title and body > > > 2. Table footer is broken - > > > https://screenshots.firefox.com/26EsdTn15j1x9k4R/pro.kohadev.org > > > 3. Why a new column? Maybe it would make more sense to have it in the first > > > column, close to the biblio's title? > > > > > > Failing QA for 1 and 2, Discussion for 3. > > > > The current master has a barcode column in the Patrons 'Make a payment' tab. > > Does anything need to be done further for this bug or shall I mark it > > resolved? > > You are right, it looks like it has been resolved already. It's also visible > on the transactions tab. In this case you can mark "RESOLVED FIXED". If you > are aware of the other bug that fixed it, you could also link them or 'Mark > as duplicate'. Thank you for all of your help Katrin on the various bugs you've commented on, it's very useful as a newbie to learn the best practices for the process :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 22:47:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 21:47:35 +0000 Subject: [Koha-bugs] [Bug 18889] Add barcode to 'Pay Fines' tab in patrons payment page In-Reply-To: <bug-18889-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18889-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18889-70-nS9ijFGwhS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18889 --- Comment #20 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- > > Thank you for all of your help Katrin on the various bugs you've commented > on, it's very useful as a newbie to learn the best practices for the process > :) Please feel free to catch me on IRC too if there are any questions! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 13 22:51:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 21:51:40 +0000 Subject: [Koha-bugs] [Bug 22199] Planning Budget does not retain values In-Reply-To: <bug-22199-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22199-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22199-70-KQQaa3lxdH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22199 rkuiper at roundrocktexas.gov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rkuiper at roundrocktexas.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 00:32:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 23:32:03 +0000 Subject: [Koha-bugs] [Bug 22404] Some labels in subscription add form has wrong parameter "for" In-Reply-To: <bug-22404-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22404-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22404-70-AvnNWKwIrh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22404 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #8 from Lucas Gass <lucas at bywatersolutions.com> --- this is not broken in 18.05 but I assumed having the labels correct named could be helpful in the future. backported to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 00:34:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Mar 2019 23:34:56 +0000 Subject: [Koha-bugs] [Bug 22466] TT methods must not be escaped In-Reply-To: <bug-22466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22466-70-8nPRhuNTWr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22466 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #12 from Lucas Gass <lucas at bywatersolutions.com> --- missing 21576 dependency for 18.05.x. wont backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 03:47:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 02:47:55 +0000 Subject: [Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits In-Reply-To: <bug-18450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18450-70-aUN0CfZq4t@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 --- Comment #26 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Created attachment 86587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86587&action=edit Bug 18450: Mades changes for QA test tool and old code missed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 03:49:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 02:49:21 +0000 Subject: [Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits In-Reply-To: <bug-18450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18450-70-uRH0MVIdxe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 03:49:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 02:49:26 +0000 Subject: [Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits In-Reply-To: <bug-18450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18450-70-ZoGYrZxmfV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72835|0 |1 is obsolete| | Attachment #72836|0 |1 is obsolete| | --- Comment #27 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Created attachment 86588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86588&action=edit Bug 18450: (Follow up) Only show Override button for renewals according to relevant sysprefs This patch is a follow up which corrects the conditional that uses the system preferences AllowRenewalIfOtherItemsAvailable and AllowRenewalLimitOverridecontrols to control the display of the 'Override and renew' button, in addition to the 'Continue without renewing' button, when renewing an item that has been placed on hold. This patch also adjusts the expected results for each step in the test plan outlined in the previous patches to align better with the system preferences. Test plan: --NOTE-- The following renewals must be completed in Circulation->Renew 1) Apply the patch, and ensure the following steps work as described 2) In More->Administration->Global system preferences ensure that both the AllowRenewalLimitOverride and AllowRenewalIfOtherItemsAvaliable preferences are both set to 'Don't allow' 3) Item Level/Only one available item: Try to renew an item (with item level hold on it) which belongs to a biblio with only one item. Note the only button in the yellow message box displayed is 'Continue without renewing' 4) Record Level/Only one available item: Try to renew an item (this time with a 'Next Available' hold on the record) which belongs to a biblio with only one item. Note the only button in the yellow message box displayed is 'Continue without renewing' 5) Item Level/Multiple available items: Try to renew an item (with item level hold on it) which belongs to a biblio with multiple available items of it in the catalogue. Note only the 'Continue without renewing' button is displayed 6) Record Level/Multiple available items: Try to renew an item (this time with a 'Next Available' hold on the record) which belongs to a biblio with multiple available items of it in the catalogue. Note only the 'Continue without renewing' button is displayed 7) Set both AllowRenewalLimitOverride and AllowRenewalIfOtherItemsAvaliable system preferences to 'Allow' 8) Repeat step 3, and note only the 'Continue without renewing' button is displayed in the yellow message box 9) Repeat step 4, and note the only button in the yellow message box displayed is 'Continue without renewing' 10) Repeat step 5, note only the 'Continue without renewing' button is displayed (because the hold is for that specific item) 11) Repeat step 6, note the item is immediately renewed and the yellow message box is not displayed 12) Set the AllowRenewalIfOtheritemsAvailable to 'Don't Allow' and repeat steps 3-6, and note that only the 'Continue without renewing' button is displayed 13) Set the AllowRenewalIfOtherItemsAvailable system preference back to 'Allow' and AllowRenewalLimitOverride syspref to 'Don't Allow', and repeat steps 3-5 and note only the 'Continue without renewal' button is displayed. 14) Repeat step 6 and note that the item is immediately renewed with no yellow warning box. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 03:50:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 02:50:40 +0000 Subject: [Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits In-Reply-To: <bug-18450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18450-70-6ag71HiS70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 --- Comment #28 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Created attachment 86589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86589&action=edit Bug 18450: Mades changes for QA test tool and old code missed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 03:51:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 02:51:43 +0000 Subject: [Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits In-Reply-To: <bug-18450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18450-70-BmbtP6Njtr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z Attachment #86587|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 04:03:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 03:03:34 +0000 Subject: [Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits In-Reply-To: <bug-18450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18450-70-detuBjUK2d@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86588|0 |1 is obsolete| | Attachment #86589|0 |1 is obsolete| | --- Comment #29 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Created attachment 86590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86590&action=edit Bug 18450: Only show Override button for renewals according to relevant sysprefs This patch is a follow up which corrects the conditional that uses the system preferences AllowRenewalIfOtherItemsAvailable and AllowRenewalLimitOverridecontrols to control the display of the 'Override and renew' button, in addition to the 'Continue without renewing' button, when renewing an item that has been placed on hold. This patch also adjusts the expected results for each step in the test plan outlined in the previous patches to align better with the system preferences. Test plan: --NOTE-- The following renewals must be completed in Circulation->Renew 1) Apply the patch, and ensure the following steps work as described 2) In More->Administration->Global system preferences ensure that both the AllowRenewalLimitOverride and AllowRenewalIfOtherItemsAvaliable preferences are both set to 'Don't allow' 3) Item Level/Only one available item: Try to renew an item (with item level hold on it) which belongs to a biblio with only one item. Note the only button in the yellow message box displayed is 'Continue without renewing' 4) Record Level/Only one available item: Try to renew an item (this time with a 'Next Available' hold on the record) which belongs to a biblio with only one item. Note the only button in the yellow message box displayed is 'Continue without renewing' 5) Item Level/Multiple available items: Try to renew an item (with item level hold on it) which belongs to a biblio with multiple available items of it in the catalogue. Note only the 'Continue without renewing' button is displayed 6) Record Level/Multiple available items: Try to renew an item (this time with a 'Next Available' hold on the record) which belongs to a biblio with multiple available items of it in the catalogue. Note only the 'Continue without renewing' button is displayed 7) Set both AllowRenewalLimitOverride and AllowRenewalIfOtherItemsAvaliable system preferences to 'Allow' 8) Repeat step 3, and note only the 'Continue without renewing' button is displayed in the yellow message box 9) Repeat step 4, and note the only button in the yellow message box displayed is 'Continue without renewing' 10) Repeat step 5, note only the 'Continue without renewing' button is displayed (because the hold is for that specific item) 11) Repeat step 6, note the item is immediately renewed and the yellow message box is not displayed 12) Set the AllowRenewalIfOtheritemsAvailable to 'Don't Allow' and repeat steps 3-6, and note that only the 'Continue without renewing' button is displayed 13) Set the AllowRenewalIfOtherItemsAvailable system preference back to 'Allow' and AllowRenewalLimitOverride syspref to 'Don't Allow', and repeat steps 3-5 and note only the 'Continue without renewal' button is displayed. 14) Repeat step 6 and note that the item is immediately renewed with no yellow warning box. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 04:04:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 03:04:39 +0000 Subject: [Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits In-Reply-To: <bug-18450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18450-70-W4yye4R7ml@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 --- Comment #30 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Created attachment 86591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86591&action=edit Bug 18450: Mades changes for QA test tool and old code missed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 04:10:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 03:10:58 +0000 Subject: [Koha-bugs] [Bug 18450] Renew in header bypasses hold block and renewal limits In-Reply-To: <bug-18450-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18450-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18450-70-POTHEdejl5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18450 Alex Buckley <alexbuckley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|alexbuckley at catalyst.net.nz |hayleymapley at catalyst.net.n | |z -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 04:26:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 03:26:13 +0000 Subject: [Koha-bugs] [Bug 18888] Include the definition of currency in onboarding tool In-Reply-To: <bug-18888-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18888-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18888-70-G4UZ09m990@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18888 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z --- Comment #6 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- (In reply to Jonathan Druart from comment #3) > Maybe this patch should take into account the new fields that will be added > by bug 4078. Hello, please can you outline exactly what is needed to move this patch forward? a column needs to be added to the currency table? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 04:31:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 03:31:17 +0000 Subject: [Koha-bugs] [Bug 19630] "Hold is suspended" message appears in barcode field in holds table In-Reply-To: <bug-19630-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19630-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19630-70-uYi1p6hh9v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19630 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z --- Comment #2 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- (In reply to Katrin Fischer from comment #1) > The barcode and callnumber are only visilble, when the hold is waiting or > when it's an item level hold. I think the barcode column is misused for > status messages - it also shows when the item is waiting. > > Maybe a separate status column would be better? Hi, could you please specify which Holds table you are talking about? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 04:54:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 03:54:09 +0000 Subject: [Koha-bugs] [Bug 12441] search.pl has incorrect reference to OPACdefaultSortField and OPACdefaultSortOrder In-Reply-To: <bug-12441-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12441-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12441-70-rLplztVty2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12441 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 04:54:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 03:54:12 +0000 Subject: [Koha-bugs] [Bug 12441] search.pl has incorrect reference to OPACdefaultSortField and OPACdefaultSortOrder In-Reply-To: <bug-12441-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12441-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12441-70-krUNiBP0kd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12441 --- Comment #2 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Created attachment 86592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86592&action=edit Bug 12441: Search.pl conditional checks and displays using same syspref Script search.pl checks OPACdefaultSortField and OPACdefaultSortOrder, but shows defaultSortField and defaultSortOrder when using Advanced Search in the staff client. Test plan: Apply the patch and then check that the Advanced Search uses defaultSortOrder and defaultSortField sysprefs instead of the OPAC sysprefs in the conditional. Check that sort behaviour in Advanced Search still functions as expected. (It should do - this doesn't change what displays, just improves consistency). Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 04:54:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 03:54:33 +0000 Subject: [Koha-bugs] [Bug 12441] search.pl has incorrect reference to OPACdefaultSortField and OPACdefaultSortOrder In-Reply-To: <bug-12441-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12441-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12441-70-VUI7KrPbk4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12441 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |hayleymapley at catalyst.net.n | |z CC| |hayleymapley at catalyst.net.n | |z -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 05:24:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 04:24:17 +0000 Subject: [Koha-bugs] [Bug 19497] Translatability: Get rid of "Edit [% field.name |html %] field" In-Reply-To: <bug-19497-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19497-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19497-70-WMOL6LAoG7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19497 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 05:24:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 04:24:21 +0000 Subject: [Koha-bugs] [Bug 19497] Translatability: Get rid of "Edit [% field.name |html %] field" In-Reply-To: <bug-19497-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19497-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19497-70-vJMVKybch0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19497 --- Comment #3 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Created attachment 86593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86593&action=edit Bug 19497: Removed title (tooltip) from Edit button in items_search_fields.tt This patch removes the tooltip that appears when hovering over the Edit button of Item Search Fields in the staff client. This was done for consistency reasons, including that this tooltip is not translated and tooltips do not appear to be on the majority of buttons in the staff client. Test plan: 1) In Home->Administration->Item search fields create a new search field if you haven't got any already 2) Observe the tooltip that appears when hovering over the Edit button in the Item serach fields table. 3) Apply the patch and observe that the tool tip no longer appears. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 05:24:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 04:24:59 +0000 Subject: [Koha-bugs] [Bug 19497] Translatability: Get rid of "Edit [% field.name |html %] field" In-Reply-To: <bug-19497-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19497-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19497-70-73e46A0ECa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19497 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 05:25:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 04:25:08 +0000 Subject: [Koha-bugs] [Bug 19497] Translatability: Get rid of "Edit [% field.name |html %] field" In-Reply-To: <bug-19497-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19497-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19497-70-p6TAxcVCvp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19497 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |hayleymapley at catalyst.net.n |ity.org |z -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 05:52:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 04:52:29 +0000 Subject: [Koha-bugs] [Bug 13763] Renew feature does not check for the BarcodeInputFilter option In-Reply-To: <bug-13763-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13763-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13763-70-l89HKpCVYo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13763 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |hayleymapley at catalyst.net.n |ity.org |z Status|NEW |ASSIGNED CC| |hayleymapley at catalyst.net.n | |z -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 06:08:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 05:08:43 +0000 Subject: [Koha-bugs] [Bug 13763] Renew feature does not check for the BarcodeInputFilter option In-Reply-To: <bug-13763-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13763-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13763-70-gdD1aY1l2N@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13763 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 06:08:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 05:08:46 +0000 Subject: [Koha-bugs] [Bug 13763] Renew feature does not check for the BarcodeInputFilter option In-Reply-To: <bug-13763-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13763-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13763-70-nnHTeksFm7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13763 --- Comment #2 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Created attachment 86594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86594&action=edit Bug 13763: Added check for filter syspref in renew.pl In Circulation->Renew, the renew feature does not check the system preference itemBarcodeFilter to see whether the barcode needs to be converted. This patch fixes this, adding a check for the system pref and applying it accordingly to convert the barcode if it is needed. Test plan: 1) In Circulation->Renew, enter a barcode that you know exists in the catalogue but add extra spaces, breaking up the barcode. Note that this fails with a warning that says 'No item matches this barcode' 2) In system Preferences, set the itemBarcodeFilter pref to Remove spaces and repeat step1. Note that the result is the same as in step 1 3) Apply the patch 4) Repeat step 1, and note that the filter removes the spaces and the item is renewed (or gives an error that indicates it recognises the barcode) Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 07:30:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 06:30:56 +0000 Subject: [Koha-bugs] [Bug 19746] Debug statements are left in returns.pl In-Reply-To: <bug-19746-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19746-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19746-70-ccg0kMekIS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19746 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 07:44:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 06:44:45 +0000 Subject: [Koha-bugs] [Bug 19630] "Hold is suspended" message appears in barcode field in holds table In-Reply-To: <bug-19630-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19630-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19630-70-ujMitPMxSS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19630 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Hayley, it's the holds table in the patrons's account in staff (look at details and checkouts tabs) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 07:46:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 06:46:59 +0000 Subject: [Koha-bugs] [Bug 18888] Include the definition of currency in onboarding tool In-Reply-To: <bug-18888-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18888-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18888-70-RxxxkZTpqH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18888 --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Hayley, new options were added to the currency definition in Koha since this patch has been written, so it needs to catch up to those changes. Namely: Space separation between symbol and value. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 08:08:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 07:08:04 +0000 Subject: [Koha-bugs] [Bug 7074] keyword mapping on checkin and checkout screen In-Reply-To: <bug-7074-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7074-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7074-70-fgMe2rtJ0S@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7074 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11529 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- The patches from 11529 might make this more feasable performance wise. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 [Bug 11529] Add subtitle, medium and part fields to biblio table -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 08:08:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 07:08:04 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11529-70-SdFRyXyQu5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7074 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7074 [Bug 7074] keyword mapping on checkin and checkout screen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 08:11:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 07:11:38 +0000 Subject: [Koha-bugs] [Bug 7183] consistency of displays In-Reply-To: <bug-7183-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7183-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7183-70-mdme1wmpei@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7183 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** This bug has been marked as a duplicate of bug 22279 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 08:11:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 07:11:38 +0000 Subject: [Koha-bugs] [Bug 7119] general code-cleaning, tidy/whitespace omnibus In-Reply-To: <bug-7119-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7119-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7119-70-46vrt5xqVz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7119 Bug 7119 depends on bug 7183, which changed state. Bug 7183 Summary: consistency of displays https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7183 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 08:11:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 07:11:38 +0000 Subject: [Koha-bugs] [Bug 22279] Unify patron name display In-Reply-To: <bug-22279-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22279-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22279-70-lT1FBYHCxs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22279 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.poulain at biblibre.com --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** Bug 7183 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 08:15:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 07:15:49 +0000 Subject: [Koha-bugs] [Bug 7754] Displaying the number of days an item is late on checkin In-Reply-To: <bug-7754-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7754-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7754-70-P3SrH7PV0b@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7754 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|displaying the number of |Displaying the number of |days a document is late |days an item is late on | |checkin CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Still valid, also like Owen's mock-up. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 08:19:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 07:19:00 +0000 Subject: [Koha-bugs] [Bug 7782] Replace yes/no for cancelling holds with checkboxes and add delete link in patron account In-Reply-To: <bug-7782-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7782-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7782-70-tlmSEDPSYq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7782 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Inconsistency in management |Replace yes/no for |of holds on checkout, |cancelling holds with |patron detail, and holds |checkboxes and add delete |pages |link in patron account --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I still really like the idea of replacing the 'yes/no' pull down with a more standard checkbox and have an additional delete link too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 08:22:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 07:22:20 +0000 Subject: [Koha-bugs] [Bug 7812] Add markup to staff client templates to increase customization options In-Reply-To: <bug-7812-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7812-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7812-70-7ckHatVvFF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7812 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Owen, is this still something we should work towards too? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 08:22:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 07:22:31 +0000 Subject: [Koha-bugs] [Bug 22508] Add the ability to prefill 856$u with the direct URL of the file In-Reply-To: <bug-22508-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22508-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22508-70-KEluPxp6uR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508 --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #3) > * In discussion - what about the upload of files from outside of the > cataloguing plugin? Never seen Tools: Upload ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 08:24:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 07:24:26 +0000 Subject: [Koha-bugs] [Bug 7840] Remove from manual Koha as a CMS (or add it to master) In-Reply-To: <bug-7840-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7840-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7840-70-fkRnh2D0Ub@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7840 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|12806 |15326 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12806 [Bug 12806] Adding 'Koha as a CMS' to the OPAC https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 [Bug 15326] Add CMS feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 08:24:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 07:24:26 +0000 Subject: [Koha-bugs] [Bug 12806] Adding 'Koha as a CMS' to the OPAC In-Reply-To: <bug-12806-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12806-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12806-70-KZKBD0Asmq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12806 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|7840 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7840 [Bug 7840] Remove from manual Koha as a CMS (or add it to master) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 08:24:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 07:24:26 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15326-70-BWZHUWvRrI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |7840 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7840 [Bug 7840] Remove from manual Koha as a CMS (or add it to master) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 08:28:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 07:28:17 +0000 Subject: [Koha-bugs] [Bug 7881] display additional fields in the staff client In-Reply-To: <bug-7881-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7881-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7881-70-7YHTYwFvHv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7881 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |MOVED --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I have a feeling that this bug is too general and should actually be multiple bugs. The issue with dates is related to the fact that when we pull the date from copyrightdate or publicationyear it might be incomplete/normalized - which helps sorting. The point about full 245 is kind of related to bug 11529 replacing Keyword-to-MARC mappings. Closing this MOVED. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 08:30:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 07:30:28 +0000 Subject: [Koha-bugs] [Bug 7914] Easy printing of barcode label from catalog detail page In-Reply-To: <bug-7914-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7914-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7914-70-RxqMOFLbZ2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7914 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- There is SpineLabelShowPrintOnBibDetails which allows printing from the detail page. I feel this resolves this bug. Please reopen with more information if necessary. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 08:33:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 07:33:09 +0000 Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations In-Reply-To: <bug-19817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19817-70-g1dvh9AOR6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=7920 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 08:33:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 07:33:09 +0000 Subject: [Koha-bugs] [Bug 7920] Establish style guide for Koha help pages In-Reply-To: <bug-7920-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7920-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7920-70-tWAQ3FTQCA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7920 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19817 Resolution|--- |INVALID CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- We have removed the help pages in favor of links to the manual since, making this bug obsolete: bug 19817 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 08:36:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 07:36:23 +0000 Subject: [Koha-bugs] [Bug 7971] basket export only includes replacement price In-Reply-To: <bug-7971-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7971-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7971-70-2rumc2GLOs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7971 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Basekt export in acq is now fully customizable using CSV profiles -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 09:55:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 08:55:18 +0000 Subject: [Koha-bugs] [Bug 22510] New: 'accountlines.accounttype' should never be set directly, rather is should be change via Koha::Account et al. Message-ID: <bug-22510-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22510 Bug ID: 22510 Summary: 'accountlines.accounttype' should never be set directly, rather is should be change via Koha::Account et al. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Koha::Account lists valid value for accounttypes which can be added via the methods add_debit and add_credit. However, we're still setting accounttype in a number of places outside of this module and in many cases the values we're using do not correspond to the enum list in Koha::Account. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 09:55:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 08:55:33 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14825-70-Iy8CpkrKcT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22510 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22510 [Bug 22510] 'accountlines.accounttype' should never be set directly, rather is should be change via Koha::Account et al. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 09:55:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 08:55:39 +0000 Subject: [Koha-bugs] [Bug 22510] 'accountlines.accounttype' should never be set directly, rather is should be change via Koha::Account et al. In-Reply-To: <bug-22510-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22510-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22510-70-Wa1LCHqPOz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22510 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 09:55:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 08:55:33 +0000 Subject: [Koha-bugs] [Bug 22510] 'accountlines.accounttype' should never be set directly, rather is should be change via Koha::Account et al. In-Reply-To: <bug-22510-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22510-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22510-70-YZeiqtcTK1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22510 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 09:56:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 08:56:40 +0000 Subject: [Koha-bugs] [Bug 22510] 'accountlines.accounttype' should never be set directly, rather is should be change via Koha::Account et al. In-Reply-To: <bug-22510-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22510-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22510-70-yIiw5qMtWn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22510 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14825 |17702 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 [Bug 17702] Create configuration for account types -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 09:56:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 08:56:40 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14825-70-UthsidWLbl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|22510 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22510 [Bug 22510] 'accountlines.accounttype' should never be set directly, rather is should be change via Koha::Account et al. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 09:56:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 08:56:40 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account types In-Reply-To: <bug-17702-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17702-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17702-70-1U8R9DGucU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22510 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22510 [Bug 22510] 'accountlines.accounttype' should never be set directly, rather is should be change via Koha::Account et al. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 10:35:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 09:35:25 +0000 Subject: [Koha-bugs] [Bug 22504] Memcached not active but well configured to In-Reply-To: <bug-22504-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22504-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22504-70-IuIAEDCvAs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22504 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com --- Comment #1 from Josef Moravec <josef.moravec at gmail.com> --- what does this command return? service memcached status -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 10:43:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 09:43:09 +0000 Subject: [Koha-bugs] [Bug 22510] 'accountlines.accounttype' should never be set directly, rather is should be change via Koha::Account et al. In-Reply-To: <bug-22510-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22510-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22510-70-8fmhuCF55j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22510 --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- * C4::Circulation::__FixOverduesOnReturn "FU/U" -> "FFOR/F" * C4::Circulation::_FixAccountForLostAndReturned "L/Rep/W" -> "LR" Those are all the cases I can find so far.. looks like at least the first case is already in discussion on other bugs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 11:10:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 10:10:47 +0000 Subject: [Koha-bugs] [Bug 22498] Can not select any funds for invoice adjustments In-Reply-To: <bug-22498-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22498-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22498-70-aH7GfeVLAh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22498 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 11:10:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 10:10:51 +0000 Subject: [Koha-bugs] [Bug 22296] Invoice adjustments are not populating to budget views In-Reply-To: <bug-22296-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22296-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22296-70-k4xgYM6duN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22296 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 11:12:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 10:12:06 +0000 Subject: [Koha-bugs] [Bug 22511] New: Koha::Account::Line->void is not limited to 'payments' Message-ID: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Bug ID: 22511 Summary: Koha::Account::Line->void is not limited to 'payments' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- The `void` routine in Koha::Account::Lines does restrict one to only being able to void a 'credit' accountline, however it does not distinguish between accounttypes. We do however, change the accounttype as part of the void routine to VOID and as such we may be loosing data, and thus audit trail, here. Credits can take the form of 'Payment', 'Writeoff', 'Lost Item Return', 'Fine Forgiven', 'Forgiven' and finally 'Credit'. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 11:14:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 10:14:04 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void is not limited to 'payments' In-Reply-To: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22511-70-LM9tKuMQo1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18790 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790 [Bug 18790] Add ability to void payments -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 11:14:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 10:14:04 +0000 Subject: [Koha-bugs] [Bug 18790] Add ability to void payments In-Reply-To: <bug-18790-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18790-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18790-70-P57UizBwXD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18790 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22511 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 [Bug 22511] Koha::Account::Line->void is not limited to 'payments' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 11:14:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 10:14:31 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14825-70-1FgsFrSBOU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22511 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 [Bug 22511] Koha::Account::Line->void is not limited to 'payments' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 11:14:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 10:14:31 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void is not limited to 'payments' In-Reply-To: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22511-70-fOla0kgcMV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 11:14:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 10:14:53 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void is not limited to 'payments' In-Reply-To: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22511-70-tVeuQXI9S6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com, | |martin.renvoize at ptfs-europe | |.com, tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 11:22:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 10:22:23 +0000 Subject: [Koha-bugs] [Bug 22510] 'accountlines.accounttype' should never be set directly, rather is should be changed via Koha::Account et al. In-Reply-To: <bug-22510-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22510-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22510-70-K3lLeDKuGO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22510 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|'accountlines.accounttype' |'accountlines.accounttype' |should never be set |should never be set |directly, rather is should |directly, rather is should |be change via Koha::Account |be changed via |et al. |Koha::Account et al. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 11:28:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 10:28:49 +0000 Subject: [Koha-bugs] [Bug 22498] Can not select any funds for invoice adjustments In-Reply-To: <bug-22498-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22498-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22498-70-lCbziLewss@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22498 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86567|0 |1 is obsolete| | --- Comment #5 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86595&action=edit Bug 22498: Rename variable for budgets loop for invoice adjustments To test: 1 - Try to add some adjustments to an invoice (receive shipments, create invoice, click 'finish receiving') 2 - Note the fund dropdown has only 'No fund' 3 - Apply patch 4 - Refresh page 5 - Note you can now select funds, hooray! Signed-off-by: Janet McGowan <janet.mcgowan at ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 11:29:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 10:29:26 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void is not limited to 'payments' In-Reply-To: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22511-70-R09AmkyT7X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Actually.. we should be able to get to this original data via the offsets, walking backwards to find the first 'creation' offset... we don't however do that as yet and as such always display "Payment, voided" to the borrower for all such transactions.. this could be confusing to the end user? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 11:29:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 10:29:39 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void is not limited to 'payments' In-Reply-To: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22511-70-xBvA569U50@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 11:29:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 10:29:30 +0000 Subject: [Koha-bugs] [Bug 22498] Can not select any funds for invoice adjustments In-Reply-To: <bug-22498-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22498-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22498-70-yXMpXGbzB1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22498 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 11:29:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 10:29:48 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void is not limited to 'payments' In-Reply-To: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22511-70-OJ0FExQhAo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 11:34:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 10:34:27 +0000 Subject: [Koha-bugs] [Bug 22296] Invoice adjustments are not populating to budget views In-Reply-To: <bug-22296-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22296-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22296-70-3Y4ttbic5v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22296 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86568|0 |1 is obsolete| | --- Comment #8 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86596&action=edit Bug 22296: Add Invoice Adjustments to GetBudgetHierarchy To test: 1 - prove -v t/db_dependent/Budgets.t 2 - Create some invoices on a single budget Invoice 1: add a non-encumbered adjustment for 1 add an encumbered adjustment 2 leave open Invoice 2: add a non-encumbered adjustment for 4 add an encumbered adjustment for 8 3 - View acq home page, should see 2 order and 12 spent for the budget 4 - View the spent and ordered pages, they should show the correct amounts 5 - Add more orders etc and confirm things total correctly https://bugs.koha-community.org/show_bug.cgi?id=22296 Signed-off-by: Janet McGowan <janet.mcgowan at ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 11:35:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 10:35:13 +0000 Subject: [Koha-bugs] [Bug 22296] Invoice adjustments are not populating to budget views In-Reply-To: <bug-22296-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22296-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22296-70-tGtjMTbxcg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22296 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 11:44:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 10:44:10 +0000 Subject: [Koha-bugs] [Bug 21772] Add holds and account information tab to the SCO module In-Reply-To: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21772-70-Z3OJM6wH1W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 --- Comment #9 from Agust?n Moyano <agustinmoyano at theke.io> --- Hello Sarah, I believe that behaviour isn't related with this bug. I think somehow SCO and intranet are overwritting the others browser cookies. Please try opening each one in different browsers, or one in incognito mode. Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 12:02:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 11:02:33 +0000 Subject: [Koha-bugs] [Bug 14239] Bibframe support in Koha In-Reply-To: <bug-14239-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14239-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14239-70-35MoB4P6hA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14239 Carolina Andreu <carolina.andreu at metricsalad.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carolina.andreu at metricsalad | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 12:13:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 11:13:59 +0000 Subject: [Koha-bugs] [Bug 22512] accountlines.accountype mixes 'state' and 'type' In-Reply-To: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22512-70-rZ1pt8HydC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 12:14:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 11:14:08 +0000 Subject: [Koha-bugs] [Bug 22512] accountlines.accountype mixes 'state' and 'type' In-Reply-To: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22512-70-23fkuuKzhg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17702 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 [Bug 17702] Create configuration for account types -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 12:14:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 11:14:08 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account types In-Reply-To: <bug-17702-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17702-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17702-70-IeljDl1I1o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22512 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 [Bug 22512] accountlines.accountype mixes 'state' and 'type' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 12:13:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 11:13:48 +0000 Subject: [Koha-bugs] [Bug 22512] New: accountlines.accountype mixes 'state' and 'type' Message-ID: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 Bug ID: 22512 Summary: accountlines.accountype mixes 'state' and 'type' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Currently the accountlines.accounttype field is used to denote both the 'type' of a credit or debit and often mixes in it's 'state'. This is bad design and leads to superflous 'types' in reality. Examples: * 'FU' (fine "updating") becomes 'F' (fine) once it's 'fixed'. * 'FU' (fine "updating") may become 'FFOR' (fine "forgiven"). * 'L' (lost item) may become 'LR' (lost returned). * 'Rep' (replaced?) may become 'LR' (lost returned). * 'W' (writeoff) may become 'LR' (lost returned). These type+state mixes can lead to confusion in both code and end user facing messages. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 12:14:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 11:14:29 +0000 Subject: [Koha-bugs] [Bug 22512] accountlines.accountype mixes 'state' and 'type' In-Reply-To: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22512-70-y6cjzIgLb4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|17702 |22510 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 [Bug 17702] Create configuration for account types https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22510 [Bug 22510] 'accountlines.accounttype' should never be set directly, rather is should be changed via Koha::Account et al. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 12:14:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 11:14:29 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account types In-Reply-To: <bug-17702-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17702-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17702-70-Ld0qw6GKLF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|22512 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 [Bug 22512] accountlines.accountype mixes 'state' and 'type' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 12:14:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 11:14:29 +0000 Subject: [Koha-bugs] [Bug 22510] 'accountlines.accounttype' should never be set directly, rather is should be changed via Koha::Account et al. In-Reply-To: <bug-22510-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22510-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22510-70-tKYOOd1TLO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22510 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22512 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 [Bug 22512] accountlines.accountype mixes 'state' and 'type' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 12:17:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 11:17:17 +0000 Subject: [Koha-bugs] [Bug 22510] 'accountlines.accounttype' should never be set directly, rather is should be changed via Koha::Account et al. In-Reply-To: <bug-22510-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22510-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22510-70-WuPqRRhH5q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22510 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14591 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 12:17:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 11:17:17 +0000 Subject: [Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines In-Reply-To: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14591-70-xUlj8bSrOl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22510 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 12:17:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 11:17:30 +0000 Subject: [Koha-bugs] [Bug 13044] Deprecate old book drop mode In-Reply-To: <bug-13044-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13044-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13044-70-tNeIkXzD9o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13044 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22510 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 12:17:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 11:17:30 +0000 Subject: [Koha-bugs] [Bug 22510] 'accountlines.accounttype' should never be set directly, rather is should be changed via Koha::Account et al. In-Reply-To: <bug-22510-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22510-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22510-70-mhDQ95AzeF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22510 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13044 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 12:24:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 11:24:00 +0000 Subject: [Koha-bugs] [Bug 22512] accountlines.accountype mixes 'state' and 'type' In-Reply-To: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22512-70-K5IDTkRNfm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com, | |katrin.fischer at bsz-bw.de, | |kyle at bywatersolutions.com, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 12:24:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 11:24:11 +0000 Subject: [Koha-bugs] [Bug 22256] llength mapping wrong in default Elasticsearch mappings In-Reply-To: <bug-22256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22256-70-MNIA8kkxsJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22256 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|Signed Off |RESOLVED --- Comment #4 from Ere Maijala <ere.maijala at helsinki.fi> --- I'm incorporating this to other similar fixes in bug 22339, which also gets an update script. *** This bug has been marked as a duplicate of bug 22339 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 12:24:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 11:24:11 +0000 Subject: [Koha-bugs] [Bug 22339] Elasticsearch - fixed field mappings should match MARC ranges In-Reply-To: <bug-22339-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22339-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22339-70-Wx0GxXhjrn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22339 --- Comment #1 from Ere Maijala <ere.maijala at helsinki.fi> --- *** Bug 22256 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 12:30:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 11:30:32 +0000 Subject: [Koha-bugs] [Bug 22512] accountlines.accountype mixes 'state' and 'type' In-Reply-To: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22512-70-xLf2dkf6es@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- As bug 22511 also highlights.. this state mixing is also present for all the 'credit' types as they can go from any type to 'VOID' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 12:37:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 11:37:25 +0000 Subject: [Koha-bugs] [Bug 22339] Elasticsearch - fixed field mappings should match MARC ranges In-Reply-To: <bug-22339-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22339-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22339-70-zoOBq9r1bm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22339 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 12:37:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 11:37:28 +0000 Subject: [Koha-bugs] [Bug 22339] Elasticsearch - fixed field mappings should match MARC ranges In-Reply-To: <bug-22339-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22339-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22339-70-f4SqT7jp1y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22339 --- Comment #2 from Ere Maijala <ere.maijala at helsinki.fi> --- Created attachment 86597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86597&action=edit Bug 22339: Fix search field mappings of MARC fixed fields Fixes handling of /0 selector in addition to several fixed field positions. Note that ff7-01-02 is in fact 00-01 in Zebra and that has been replicated here. Test plan: 1. Before applying a patch, check from Elasticsearch (e.g. localhost:9200/koha_biblios/_search?q=_id:123) what is indexed in Elasticsearch for a record for date-entered-on-file, ff7-00, ff7-01, ff7-02 and lleader. 2. Apply the patch, update database and save the record again. 3. Verify that the contents of the forementioned fields is now correct in Elasticsearch. 4. Verify that tests pass: prove -v t/Koha/SearchEngine/Elasticsearch.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 12:38:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 11:38:36 +0000 Subject: [Koha-bugs] [Bug 22339] Elasticsearch - fixed field mappings should match MARC ranges In-Reply-To: <bug-22339-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22339-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22339-70-mH0FEIY2kb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22339 --- Comment #3 from Ere Maijala <ere.maijala at helsinki.fi> --- Note that it seems ff7-01-02 was misnamed in Zebra, and that is reflected here. It contains positions 00-01. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 12:40:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 11:40:10 +0000 Subject: [Koha-bugs] [Bug 22504] Memcached not active but well configured to In-Reply-To: <bug-22504-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22504-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22504-70-X3wDPBChd8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22504 --- Comment #2 from ducry.remy at gmail.com --- Hi Josef ! the command return : Connection to the memcached servers '127.0.0.1:11211' failed. Are the unix socket permissions set properly? Is the host reachable? If you ignore this warning, you will face performance issues -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 12:46:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 11:46:43 +0000 Subject: [Koha-bugs] [Bug 22504] Memcached not active but well configured to In-Reply-To: <bug-22504-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22504-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22504-70-5Rr5OKAtgn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22504 --- Comment #3 from Josef Moravec <josef.moravec at gmail.com> --- (In reply to ducry.remy from comment #2) > Hi Josef ! > > the command return : > Connection to the memcached servers '127.0.0.1:11211' failed. Are the unix > socket permissions set properly? Is the host reachable? > If you ignore this warning, you will face performance issues I don't think it is return of service status command - it should say if service is running, and what was the run command, and so on.... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 12:47:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 11:47:15 +0000 Subject: [Koha-bugs] [Bug 22339] Elasticsearch - fixed field mappings should match MARC ranges In-Reply-To: <bug-22339-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22339-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22339-70-BGa2N3T7r7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22339 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 12:47:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 11:47:52 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void is not limited to 'payments' In-Reply-To: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22511-70-RaYctVdxji@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 13:10:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 12:10:04 +0000 Subject: [Koha-bugs] [Bug 20421] Apply CheckPrevIssue logic when placing a hold on the staff client In-Reply-To: <bug-20421-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20421-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20421-70-iArzP7MU8z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20421 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Inform staff that patron |Apply CheckPrevIssue logic |does have the title checked |when placing a hold on the |out during placing hold |staff client CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 13:19:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 12:19:02 +0000 Subject: [Koha-bugs] [Bug 22513] New: Anonymize old ILL requests Message-ID: <bug-22513-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22513 Bug ID: 22513 Summary: Anonymize old ILL requests Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: ILL Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no Target Milestone: --- I don't think this has been mentioned anywhere else? We should probably replace illrequests.borrowernumber with the value from the AnonymousPatron syspref at some point after the request is "done". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 13:21:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 12:21:21 +0000 Subject: [Koha-bugs] [Bug 19670] search_marc_map.marc_field should have COLLATE=utf8_bin In-Reply-To: <bug-19670-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19670-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19670-70-ECUW5QS3cI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19670 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |ere.maijala at helsinki.fi |ity.org | --- Comment #2 from Ere Maijala <ere.maijala at helsinki.fi> --- I'd say yes. Patch coming up.. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 13:26:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 12:26:22 +0000 Subject: [Koha-bugs] [Bug 20421] Apply CheckPrevIssue logic when placing a hold on the staff client In-Reply-To: <bug-20421-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20421-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20421-70-hRtL7yNH0a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20421 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86150|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86598&action=edit Bug 20421: Inform staff that patron does have the title checked out during placing hold Test plan: 1) Enable the CheckPrevCheckout and DisplayMultiPlaceHold system preferences 2) Have a patron with some checkouts history 3) Try to place hold on one of titles from history for this patron 4) You should see an information at the top of confirm request page, but you still should be able to place a hold 5) Try this with multiple titles - one or more of them should be from history 6) You should see this information in "Information" column 7) There is also new column placed at the beggining with checkbox, you could uncheck it for titles you do not want to place a hold on it 8) Confirm the hold is placed only on checked titles Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 13:26:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 12:26:54 +0000 Subject: [Koha-bugs] [Bug 20421] Apply CheckPrevIssue logic when placing a hold on the staff client In-Reply-To: <bug-20421-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20421-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20421-70-zmCQLoAmeg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20421 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Works as described, signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 13:32:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 12:32:06 +0000 Subject: [Koha-bugs] [Bug 22514] New: Hardcoded value of 10 for return hour when calculating hourly loans affected by holidays Message-ID: <bug-22514-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22514 Bug ID: 22514 Summary: Hardcoded value of 10 for return hour when calculating hourly loans affected by holidays Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Target Milestone: --- >From Koha/Calendar.pm: if ( $unit eq 'hours' ) { # Fixed for legacy support. Should be set as a branch parameter my $return_by_hour = 10; $dt = $self->addHours($startdate, $add_duration, $return_by_hour); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 13:34:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 12:34:09 +0000 Subject: [Koha-bugs] [Bug 19670] search_marc_map.marc_field should have COLLATE=utf8_bin In-Reply-To: <bug-19670-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19670-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19670-70-YJHoglYjbx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19670 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 13:34:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 12:34:12 +0000 Subject: [Koha-bugs] [Bug 19670] search_marc_map.marc_field should have COLLATE=utf8_bin In-Reply-To: <bug-19670-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19670-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19670-70-Yf91j0i8ys@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19670 --- Comment #3 from Ere Maijala <ere.maijala at helsinki.fi> --- Created attachment 86599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86599&action=edit Bug 19670: Change Collation of marc_field to allow mixed case mappings Test plan: 1. Apply patch and update database 2. Verify that you can add a search field mapping for both 100a and 100A. 3. Verify that the above also works with a newly-created database. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 13:40:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 12:40:10 +0000 Subject: [Koha-bugs] [Bug 18978] Amazon returns 1x1 pixel image on shelf browse, preventing the "no cover image" image from showing In-Reply-To: <bug-18978-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18978-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18978-70-AHmvp84QQK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18978 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- This bug doesn't appear to be valid in master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 13:47:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 12:47:36 +0000 Subject: [Koha-bugs] [Bug 22504] Memcached not active but well configured to In-Reply-To: <bug-22504-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22504-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22504-70-BtDHmCMpTJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22504 --- Comment #4 from ducry.remy at gmail.com --- A colleague computer scientist came to our rescue, we disabled in the memcached configuration the -P option, it solved our problem. We have a legal problem with the socket but it's not blocking for Koha. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 13:54:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 12:54:22 +0000 Subject: [Koha-bugs] [Bug 5627] lock symbol even on not locked fields In-Reply-To: <bug-5627-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-5627-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5627-70-GoWqf6Khgb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5627 --- Comment #4 from Owen Leonard <oleonard at myacpl.org> --- Does anyone know if this bug is still valid? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 14:01:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 13:01:54 +0000 Subject: [Koha-bugs] [Bug 21013] Missing itemtype for checkut makes patron summary print explode In-Reply-To: <bug-21013-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21013-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21013-70-p20wXSn2Qx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21013 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 14:13:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 13:13:33 +0000 Subject: [Koha-bugs] [Bug 22504] Memcached not active but well configured to In-Reply-To: <bug-22504-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22504-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22504-70-q5pKLeZYVG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22504 ducry.remy at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 14:18:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 13:18:43 +0000 Subject: [Koha-bugs] [Bug 21013] Missing itemtype for checkut makes patron summary print explode In-Reply-To: <bug-21013-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21013-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21013-70-kVEtC7btVo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21013 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 14:18:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 13:18:46 +0000 Subject: [Koha-bugs] [Bug 21013] Missing itemtype for checkut makes patron summary print explode In-Reply-To: <bug-21013-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21013-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21013-70-AvRc3bJTHx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21013 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 86600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86600&action=edit Bug 21013: Missing itemtype for checkut makes patron summary print explode This patch moves retrieval of the item type description from the script to the template using the ItemTypes template plugin. To test, apply the patch and locate an item which is checked out to someone. Modify the database record for that item to remove the item type (items.itype). View the print summary for the patron who has that item checked out. The page should display correctly. Checked-out items which have an item type should show that item type description correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 14:24:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 13:24:53 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8995-70-wvldKEvGTl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 --- Comment #101 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86601&action=edit Bug 8995: (follow-up) Tak system preference item-level_itypes into account -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 14:36:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 13:36:59 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8995-70-61y0GwfOEM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 14:37:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 13:37:04 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8995-70-YqCEoTQqfe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86490|0 |1 is obsolete| | --- Comment #102 from Magnus Enger <magnus at libriotech.no> --- Created attachment 86602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86602&action=edit Bug 8995: Show OpenURL links in OPAC search results This patch use GetCOinS sub to provide an OpenURL link in OPAC search results. It uses 4 new system preferences: - OpenURLinOPACResults: enable or disable this feature - OpenURLResolverURL: url of the openURL resolver - OpenURLText: text of the link - OpenURLImageLocation: image of the link Link is displayed as an image if OpenURLImageLocation is defined, and as text otherwise. It works both with and without XSLT enabled. Changes made to GetCOinSBiblio: For 'journal': - Title should be in rft.jtitle instead of rft.title - rft.date, rft.aulast, rft.aufirst, rft.au, rft.pub and rft.pages have no meaning for a subscription, so they are simply removed from URL This patch refactors GetCOinSBiblio, so the construction of URL is done only at the end. This way we do not have ugly $var .= "&$value" in the function body. Also use URI::Escape instead of custom regexps. This development consider the value of syspref OPACURLOpenInNewWindow when building the link. Test plan: 1/ Enable syspref OPACShowOpenURL and put your OpenURL resolver URL in OpenURLResolverURL syspref (if you don't have one, just fill it with some fake URL, you'll have to check if OpenURL links are correct) 2/ If you want, set the other sysprefs OpenURLImageLocation and OpenURLText 3/ Fill syspref OPACOpenURLItemTypes with some (not all) of your item types. 4/ Empty sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay 5/ Go to OPAC and launch a search. 6/ Check you have in the results (near the title) the OpenURL link (only for itemtypes that are in OPACOpenURLItemTypes). Toggle OPACURLOpenInNewWindow syspref and check that the behaviour of the link is correct. 7/ Go to the detail page of one of those and check you have the OpenURL link too. (Above tags) Toggle OPACURLOpenInNewWindow syspref and check that the behaviour of the link is correct. 8/ Set sysprefs OPACXSLTDetailsDisplay and OPACXSLTResultsDisplay to "default" and repeat steps 5 to 7 Signed-off-by: Paola Rossi <paola.rossi at cineca.it> Signed-off-by: Magnus Enger <magnus at libriotech.no> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 14:37:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 13:37:10 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8995-70-OF8xfbSygh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86491|0 |1 is obsolete| | --- Comment #103 from Magnus Enger <magnus at libriotech.no> --- Created attachment 86603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86603&action=edit Bug 8995: Add IGNORE to the INSERT statement Signed-off-by: Magnus Enger <magnus at libriotech.no> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 14:37:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 13:37:23 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8995-70-D7FdWOJ8cc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86541|0 |1 is obsolete| | --- Comment #105 from Magnus Enger <magnus at libriotech.no> --- Created attachment 86605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86605&action=edit Bug 8995: (follow-up) Added test Signed-off-by: Magnus Enger <magnus at libriotech.no> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 14:37:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 13:37:29 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8995-70-Eb9KTF16E7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86542|0 |1 is obsolete| | --- Comment #106 from Magnus Enger <magnus at libriotech.no> --- Created attachment 86606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86606&action=edit Bug 8995: (follow-up) Add POD for GetOpenURLResolverURL Signed-off-by: Magnus Enger <magnus at libriotech.no> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 14:37:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 13:37:16 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8995-70-Dx0Q2roDfP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86492|0 |1 is obsolete| | --- Comment #104 from Magnus Enger <magnus at libriotech.no> --- Created attachment 86604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86604&action=edit Bug 8995: (follow-up) Adapt to current codebase Signed-off-by: Magnus Enger <magnus at libriotech.no> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 14:37:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 13:37:35 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8995-70-tWAPWnCqJx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86557|0 |1 is obsolete| | --- Comment #107 from Magnus Enger <magnus at libriotech.no> --- Created attachment 86607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86607&action=edit Bug 8995: (follow-up) Move GetOpenURLResolverURL to Koha::Biblio->get_openurl Signed-off-by: Magnus Enger <magnus at libriotech.no> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 14:37:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 13:37:41 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8995-70-hEIl8vevlM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86558|0 |1 is obsolete| | --- Comment #108 from Magnus Enger <magnus at libriotech.no> --- Created attachment 86608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86608&action=edit Bug 8995: (follow-up) Move GetCOinSBiblio to Koha::Biblio->get_coins Test plan: 1) Ensure the COinS span tag is still included on this pages. You need to look into html source and search for span tag with class 'Z3988', which has COinS string in title. Staff client: catalogue -> ISBDdetail catalogue -> MARCdetail catalogue -> detail virtualshelves -> shelves OPAC (you should have COinSinOPACResults system preference enabled): opac detail opac search opac shelves 2) Run tests: prove t/Biblio.t t/db_dependent/Biblio.t t/db_dependent/Koha/Biblio.t Signed-off-by: Magnus Enger <magnus at libriotech.no> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 14:37:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 13:37:47 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8995-70-nUupoAlKB1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86559|0 |1 is obsolete| | --- Comment #109 from Magnus Enger <magnus at libriotech.no> --- Created attachment 86609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86609&action=edit Bug 8995: (follow-up) Add one more test fot get_openurl Test plan: prove t/db_dependent/Koha/Biblio.t Signed-off-by: Magnus Enger <magnus at libriotech.no> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 14:37:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 13:37:54 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8995-70-aCXVsA6zxC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86601|0 |1 is obsolete| | --- Comment #110 from Magnus Enger <magnus at libriotech.no> --- Created attachment 86610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86610&action=edit Bug 8995: (follow-up) Tak system preference item-level_itypes into account Signed-off-by: Magnus Enger <magnus at libriotech.no> Tested with all 9 current patches. Works as advertised, including OPACURLOpenInNewWindow. If a record has no items, no OpenURL link is displayed. All the suggested tests pass. I did not test with XSLT turned off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 15:02:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 14:02:28 +0000 Subject: [Koha-bugs] [Bug 21772] Add holds and account information tab to the SCO module In-Reply-To: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21772-70-Oo6cJm1sST@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 Sarah Cornell <sbcornell at cityofportsmouth.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #10 from Sarah Cornell <sbcornell at cityofportsmouth.com> --- I got the same behavior (tab closes when invoking additem.pl) when testing another bug in the sandboxes, even after clearing cookies and only using the intranet. So I guess it is unrelated to this bug. I'm signing off because your patches work. If this isn't the right thing to do, I'm sure someone will let me know! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 15:03:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 14:03:29 +0000 Subject: [Koha-bugs] [Bug 22325] Elasticsearch - two letter field name are not searchable In-Reply-To: <bug-22325-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22325-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22325-70-Dw4CpFvzdc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22325 --- Comment #1 from Ere Maijala <ere.maijala at helsinki.fi> --- In master, I can't see anything wrong with 'an' at the moment. It's an alias for koha-auth-number and search seems to be working great. Nick, do you still have trouble with it? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 15:13:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 14:13:58 +0000 Subject: [Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page In-Reply-To: <bug-12502-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12502-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12502-70-W8C68KZC8v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 Janet McGowan <janet.mcgowan at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 15:43:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 14:43:38 +0000 Subject: [Koha-bugs] [Bug 21772] Add holds and account information tab to the SCO module In-Reply-To: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21772-70-GlNwSZZ8lW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 15:44:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 14:44:03 +0000 Subject: [Koha-bugs] [Bug 22515] New: OPACViewOthersSuggestions if set to Show will only show when patron has made a suggestion Message-ID: <bug-22515-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22515 Bug ID: 22515 Summary: OPACViewOthersSuggestions if set to Show will only show when patron has made a suggestion Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- If a library is allowing Purchase Suggestions and they also have the system preference OPACViewOthersSuggestions set to show- a patron can only see other patron's purchase suggestions if they have submitted a purchase suggestion of their own. If that patron has not submitted a purchase suggestion, then the opac-suggestion.pl page is blank and does not provide a way to see other suggestions. This defeats the purpose of this system preference. If a library has this set to show, they would like other patrons to see that the newest book by James Patterson has been suggested by another patron and to not create a second purchase suggestion when it is not needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 16:28:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 15:28:59 +0000 Subject: [Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines In-Reply-To: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14591-70-3UbWnZLNdU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 16:29:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 15:29:13 +0000 Subject: [Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines In-Reply-To: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14591-70-OfXNdy1omd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 --- Comment #12 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 86612 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86612&action=edit Bug 14591: Update other calls to AddReturn -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 16:29:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 15:29:16 +0000 Subject: [Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines In-Reply-To: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14591-70-dohUT0JrbF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 --- Comment #13 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 86613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86613&action=edit Bug 14591: Update unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 16:29:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 15:29:02 +0000 Subject: [Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines In-Reply-To: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14591-70-vcanmq0YJe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 --- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 86611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86611&action=edit Bug 14591: book drop / drop box mode incorrectly decrements accrued overdue fines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 16:39:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 15:39:33 +0000 Subject: [Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines In-Reply-To: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14591-70-Hc0WMJWuAM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 --- Comment #15 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 86615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86615&action=edit Bug 14591: Update other calls to AddReturn -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 16:39:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 15:39:36 +0000 Subject: [Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines In-Reply-To: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14591-70-Bvqwu9FXW0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 --- Comment #16 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 86616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86616&action=edit Bug 14591: Update unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 16:39:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 15:39:21 +0000 Subject: [Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines In-Reply-To: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14591-70-SUghUU0520@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86611|0 |1 is obsolete| | Attachment #86612|0 |1 is obsolete| | Attachment #86613|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 86614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86614&action=edit Bug 14591: book drop / drop box mode incorrectly decrements accrued overdue fines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 17:01:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 16:01:52 +0000 Subject: [Koha-bugs] [Bug 17628] Move bibliographic related code to Koha::Biblio In-Reply-To: <bug-17628-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17628-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17628-70-Hmuj3vB1GS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17628 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor.grousset at biblibre.co | |m --- Comment #9 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Hi. This can be closed right? Or is there still more bibliographic related code in the wild? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 17:04:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 16:04:07 +0000 Subject: [Koha-bugs] [Bug 18138] Use MARC modification template when adding/updating bibliographic records In-Reply-To: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18138-70-d5GCf7OcPD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82783|0 |1 is obsolete| | --- Comment #7 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 86617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86617&action=edit Bug 18138: Use MARC modification template when adding/updating bibliographic records Add a preference that enables a specific marc modification template to be applied on bibliographic records saved using simple or advanced MARC editor or the HTTP API. To test: 1) Create a MARC modification template containg one or more actions. 2) Under "Global system preferences" and "Cataloging" set the "EditBiblioMarcModificationTemplate" preference to the name of the previously created template. 3) Edit (or create) a bibliographic record using either the simple or advanced MARC editor. 4) Save the record. 5) Verify that the action(s) have been applied. Sponsored-by: Gothenburg University Library Signed-off-by: Frank Hansen <frank.hansen at ub.lu.se> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 17:06:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 16:06:34 +0000 Subject: [Koha-bugs] [Bug 18253] Remove C4::Items::GetItemsByBiblioitemnumber In-Reply-To: <bug-18253-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18253-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18253-70-MYjNMrCs7k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18253 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED CC| |victor.grousset at biblibre.co | |m Resolution|--- |FIXED --- Comment #2 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- GetItemsByBiblioitemnumber can't be found in master anymore. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 17:06:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 16:06:35 +0000 Subject: [Koha-bugs] [Bug 18252] Move C4::Items code to the Koha namespace In-Reply-To: <bug-18252-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18252-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18252-70-ejag5oGnDd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18252 Bug 18252 depends on bug 18253, which changed state. Bug 18253 Summary: Remove C4::Items::GetItemsByBiblioitemnumber https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18253 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 17:57:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 16:57:11 +0000 Subject: [Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines In-Reply-To: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14591-70-G9YyWp48NG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86615|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86619&action=edit Bug 14591: Update other calls to AddReturn Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 17:57:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 16:57:15 +0000 Subject: [Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines In-Reply-To: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14591-70-mXNF27apFE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86616|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86620&action=edit Bug 14591: Update unit tests Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 17:57:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 16:57:19 +0000 Subject: [Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines In-Reply-To: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14591-70-Ls8cDfKBHV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 --- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86621&action=edit Bug 14591: (QA follow-up) Optimize DateTime passing We were passing around possibly undefined $return_date variables from AddReturn and then instantiating a new DateTime object as a default for each routine. This followup sets the default higher up the stack within AddReturn which provider clearer logic and a small performance improvment. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 17:57:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 16:57:07 +0000 Subject: [Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines In-Reply-To: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14591-70-iB9s9LYeA3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86614|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86618&action=edit Bug 14591: book drop / drop box mode incorrectly decrements accrued overdue fines Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 18:04:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 17:04:31 +0000 Subject: [Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines In-Reply-To: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14591-70-LprSqS5FHO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- I really like this solution! It tidies up the code significantly and corrects the logic considerably! Signing off as it all works in testing as described... Some QA comments for the next in line however. * Can we/Should we remove the 'lastincrement' field here as I believe this was the only use case for it? * The logic here puts 'dropboxmode/dropboxdate' in precidence to any specified return date.. I think we perhaps need a bit more in this regard, but perhaps that can be done within bug 13044 as there's a fair bit of contextual conversation over there around this issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 18:07:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 17:07:53 +0000 Subject: [Koha-bugs] [Bug 22516] New: accountlines.lastincrement should be removed Message-ID: <bug-22516-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22516 Bug ID: 22516 Summary: accountlines.lastincrement should be removed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Bug 14591 will remove the last use case for 'lastincrement', we should remove this field from the database once that bug is pushed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 18:08:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 17:08:04 +0000 Subject: [Koha-bugs] [Bug 22516] accountlines.lastincrement should be removed In-Reply-To: <bug-22516-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22516-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22516-70-4XNvjea2eH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22516 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14591 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 18:08:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 17:08:04 +0000 Subject: [Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines In-Reply-To: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14591-70-LF5rB5pFh5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22516 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22516 [Bug 22516] accountlines.lastincrement should be removed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 18:08:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 17:08:19 +0000 Subject: [Koha-bugs] [Bug 22516] accountlines.lastincrement should be removed In-Reply-To: <bug-22516-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22516-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22516-70-b3qb5EkxLc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22516 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 18:08:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 17:08:19 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14825-70-pyknKMeZev@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22516 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22516 [Bug 22516] accountlines.lastincrement should be removed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 18:08:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 17:08:33 +0000 Subject: [Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines In-Reply-To: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14591-70-FwJBxjhbFJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14825 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 18:08:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 17:08:33 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14825-70-wioLfcoEae@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|14591 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 18:10:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 17:10:45 +0000 Subject: [Koha-bugs] [Bug 22516] accountlines.lastincrement should be removed In-Reply-To: <bug-22516-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22516-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22516-70-OYNrSzS4Hb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22516 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 18:10:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 17:10:55 +0000 Subject: [Koha-bugs] [Bug 22516] accountlines.lastincrement can be removed In-Reply-To: <bug-22516-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22516-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22516-70-5lI5LsMHBy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22516 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|accountlines.lastincrement |accountlines.lastincrement |should be removed |can be removed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 18:12:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 17:12:01 +0000 Subject: [Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines In-Reply-To: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14591-70-6OqkuxaefL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 --- Comment #22 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- See bug 22516 for the removal of lastincrement.. I decided to leave that as a followup bug to keep this bug simple. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 18:58:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 17:58:18 +0000 Subject: [Koha-bugs] [Bug 17628] Move bibliographic related code to Koha::Biblio In-Reply-To: <bug-17628-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17628-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17628-70-oqcDmLE4nV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17628 --- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- % git grep -c '^sub' C4/Biblio.pm C4/Biblio.pm:63 Still a lot :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 19:00:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 18:00:52 +0000 Subject: [Koha-bugs] [Bug 18253] Remove C4::Items::GetItemsByBiblioitemnumber In-Reply-To: <bug-18253-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18253-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18253-70-uc8B0ISYTh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18253 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |DUPLICATE --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- *** This bug has been marked as a duplicate of bug 21202 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 19:00:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 18:00:52 +0000 Subject: [Koha-bugs] [Bug 21202] C4::Items - Remove GetItemsByBiblioitemnumber In-Reply-To: <bug-21202-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21202-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21202-70-iyC6MfbpEo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21202 --- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- *** Bug 18253 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 19:02:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 18:02:20 +0000 Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values In-Reply-To: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20307-70-EfyepSQlee@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307 --- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86622&action=edit Bug 20307: Add DB column localization.interface -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 19:02:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 18:02:25 +0000 Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values In-Reply-To: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20307-70-5PhRDPjlVc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307 --- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86623&action=edit Bug 20307: DBIC Schema changes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 19:02:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 18:02:29 +0000 Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values In-Reply-To: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20307-70-qUcs31BIbA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307 --- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86624&action=edit Bug 20307: Update the localization unique key -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 19:02:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 18:02:35 +0000 Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values In-Reply-To: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20307-70-bB7vKukw1z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307 --- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86625&action=edit Bug 20307: DBIC Schema changes 2 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 19:02:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 18:02:41 +0000 Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values In-Reply-To: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20307-70-VRH8CwzdCl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307 --- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86626&action=edit Bug 20307: Language overlay for authorised values -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 19:02:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 18:02:45 +0000 Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values In-Reply-To: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20307-70-0aIUDKAAFd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307 --- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86627&action=edit Bug 20307: Some more fixes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 19:06:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 18:06:16 +0000 Subject: [Koha-bugs] [Bug 20307] Language overlay for authorized values In-Reply-To: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20307-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20307-70-WXT17rvqg1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20307 --- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I have cleaned and rebased my local patches, as well as fixing obvious problems. I have no idea how big is the remaining work to make it ready to be pushed. However it can be tested and having a list of what is ok and what is not will help (and motivate) me to finish this enhancement. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 19:30:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 18:30:35 +0000 Subject: [Koha-bugs] [Bug 22473] Use koha-conf.xml modification time as cache key In-Reply-To: <bug-22473-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22473-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22473-70-e8s5GRXW1E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22473 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86628&action=edit Bug 22473: flush in psgi - V1 Here we are checking on each request That could work, but do not feel robust Moreover it will not affect scripts outside of plack -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 19:30:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 18:30:48 +0000 Subject: [Koha-bugs] [Bug 22473] Use koha-conf.xml modification time as cache key In-Reply-To: <bug-22473-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22473-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22473-70-DmbEisBKt3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22473 --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86629&action=edit Bug 22473: Two other places that do not work - V2 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 19:51:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 18:51:20 +0000 Subject: [Koha-bugs] [Bug 22473] Use koha-conf.xml modification time as cache key In-Reply-To: <bug-22473-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22473-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22473-70-3ZLzKAeOcK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22473 --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86630&action=edit Bug 22473: Handle config expiration in C4::Context->new - V3 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 20:06:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 19:06:45 +0000 Subject: [Koha-bugs] [Bug 22473] Use koha-conf.xml modification time as cache key In-Reply-To: <bug-22473-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22473-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22473-70-wEZij1YmAE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22473 --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86631&action=edit Bug 22473: Example of watcher to invalidate config cache - V4 Test plan: perl watchfile.pl then update the config Note that we do not handle everything, for instance the DB credentials will not be taken into account. I guess we could call C4::Context->dbh({ new => 1 }) as well. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 20:11:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 19:11:05 +0000 Subject: [Koha-bugs] [Bug 22473] Use koha-conf.xml modification time as cache key In-Reply-To: <bug-22473-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22473-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22473-70-g9RysSzMfH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22473 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion CC| |tomascohen at gmail.com --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Here are 4 versions (to apply and test separately) that could work. Only the last one (V4) is, in my opinion, viable. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 20:13:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 19:13:45 +0000 Subject: [Koha-bugs] [Bug 22508] Add the ability to prefill 856$u with the direct URL of the file In-Reply-To: <bug-22508-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22508-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22508-70-NfJnJOpd5w@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508 --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #4) > (In reply to Jonathan Druart from comment #3) > > * In discussion - what about the upload of files from outside of the > > cataloguing plugin? > > Never seen Tools: Upload ? Hello Marcel, This is exactly what I meant with this comment: this patch does not affect the uploads made outside of the cataloguing plugin. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 20:44:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 19:44:18 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void is not limited to 'payments' In-Reply-To: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22511-70-kGSGWwy9Tb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- I actually consider this a feature. It's always possible that something like a writeoff was done accidentally and needs to be voided. The rest of the credit types could be argued, but I don't since great utility in preventing them from being voided. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 22:15:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 21:15:03 +0000 Subject: [Koha-bugs] [Bug 22489] Onboarding tool fails due to inserting maxissueqty into IssuingRule In-Reply-To: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22489-70-IFNOnViZOT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22489 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 22:15:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 21:15:11 +0000 Subject: [Koha-bugs] [Bug 22489] Onboarding tool fails due to inserting maxissueqty into IssuingRule In-Reply-To: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22489-70-2reGsAxZF5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22489 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86577|0 |1 is obsolete| | Attachment #86578|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86632&action=edit Bug 22489: Update onboarding tool for bug 18925 When going through the onboarding process, the tool fails on submit of step 5, due to changes made in the database structure and rule definitions by bug 18925. This patch fixes this, adding code that creates a circulation rule where an issuing rule is also created in onboarding.pl. It removes maxissueqty from being sent with params to make an issuing rule, and adds it instead to the params to make a circulation rule, to reflect the changes that have been made in the database. Test plan: 1) Drop and recreate your database 2) Reload the staff client and follow the installer and onboarding process 3) Confirm that the process finishes without errors Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Liz Rea <wizzyrea at gmail.com> Bug 22489: (follow-up) Correctly set success messages The original patch was duplicating the success message upon successful circ rule insertion. This corrects that. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Liz Rea <wizzyrea at gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Patches squashed for readability -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 22:29:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 21:29:43 +0000 Subject: [Koha-bugs] [Bug 19630] "Hold is suspended" message appears in barcode field in holds table In-Reply-To: <bug-19630-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19630-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19630-70-K6JogAu0F6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19630 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |hayleymapley at catalyst.net.n |ity.org |z -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 22:33:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 21:33:33 +0000 Subject: [Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron" In-Reply-To: <bug-19919-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19919-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19919-70-x4uDDi5bLs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 --- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Magnus Enger from comment #5) > Can anyone describe a use case for storing this info in items.paidfor? I found that: 2001-05-17 15:36 rangi * database.mysql: Changed the interim field in the items table, to be paidfor The horowhenua librarians wanted a place to store information when a lost item was paid for. The information is removed if the item is ever returned. The interim field was a hangover from the previous system and wasnt be used so I stole it :-) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 22:34:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 21:34:46 +0000 Subject: [Koha-bugs] [Bug 12817] Remove internal item field paidfor from MARC structure In-Reply-To: <bug-12817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12817-70-gQ9w9Ru4XZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12817 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19919 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 22:34:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 21:34:46 +0000 Subject: [Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron" In-Reply-To: <bug-19919-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19919-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19919-70-jw4cHj8hs9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12817 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 22:37:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 21:37:11 +0000 Subject: [Koha-bugs] [Bug 22507] Modification of the Holds Slip In-Reply-To: <bug-22507-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22507-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22507-70-oo1kvKa7X5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22507 AspenCat Team <aspencatteam at clicweb.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aspencatteam at clicweb.org --- Comment #1 from AspenCat Team <aspencatteam at clicweb.org> --- We would very much like to have the option to have the hold slip split into a sending slip and a receiving slip. There are two reasons for this. The first is that it is just more clear what the slip is being used for. The second reason has to do with privacy. When a library is placing an item on their hold shelf awaiting to be picked up they need to know information about the patron that could include a phone number or an email if that is how they contact them. When the item is in transit, it is a huge privacy concern to be including private information on a hold slip that can be seen by both a library that the requesting patron is not a member of and non library staff involved in the transporting of these materials. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 22:41:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 21:41:15 +0000 Subject: [Koha-bugs] [Bug 21378] Add filters in reserve/request.pl In-Reply-To: <bug-21378-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21378-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21378-70-az72vP0fh8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21378 Lisette Scheer <lisetteslatah at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com --- Comment #1 from Lisette Scheer <lisetteslatah at gmail.com> --- +1 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 22:51:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 21:51:49 +0000 Subject: [Koha-bugs] [Bug 19630] "Hold is suspended" message appears in barcode field in holds table In-Reply-To: <bug-19630-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19630-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19630-70-QO9LlQDH2U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19630 --- Comment #4 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Created attachment 86633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86633&action=edit Bug 19630: Added Status column to Patron Holds table When a hold has been suspended or is waiting, the status message appears in the Barcode column of the Holds table. This patch fixes this by adding a separate Status column which details the status of the Hold, whether it has been suspended, or is in transit, etc. Test plan: 1) Place an item level hold and a 'Next Available' record level hold for a patron. 2) View the holds in Patrons->Patron details for that Patron in the Check out and Details tabs 3) Suspend one of the holds, and note that the status appears in the barcode column 4) Set a hold to be waiting for pickup, and note the status appears in the barcode column 5) Apply the patch 6) Check the same holds and note that the statuses now appear in the new column called Status, and note that if a hold has status effect that the row reads "Hold has been placed" 7) Verify that this is the case in both the Holds tables (in Check out tab and Details tab) Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 22:51:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 21:51:46 +0000 Subject: [Koha-bugs] [Bug 19630] "Hold is suspended" message appears in barcode field in holds table In-Reply-To: <bug-19630-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19630-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19630-70-Lax8FGzBbG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19630 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 22:52:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 21:52:23 +0000 Subject: [Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images In-Reply-To: <bug-22445-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22445-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22445-70-BgbFHJzLG1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #21 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Hugo Agud from comment #20) > I have checked all test plan and it works fine, JUST the image size is the > original image size, then if the thumbnail is bigger the image appear big... > it can be fixed by css for sure.. but perhaps some kind of code limitation? > > it is just a suggestions It seems that there is no homogeneity in the different image covers. At first glance it seems that the size is not taken into account for others either, except for adlibris. We should deal with that problem globally, but on a separate bug report of course as it will complexity this patch set a lot. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 22:53:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 21:53:47 +0000 Subject: [Koha-bugs] [Bug 19630] "Hold is suspended" message appears in barcode field in holds table In-Reply-To: <bug-19630-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19630-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19630-70-XzU2GbjgsY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19630 --- Comment #5 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- (In reply to Hayley Mapley from comment #4) > Created attachment 86633 [details] [review] > Bug 19630: Added Status column to Patron Holds table > > When a hold has been suspended or is waiting, the status > message appears in the Barcode column of the Holds table. This patch > fixes this by adding a separate Status column which details the status > of the Hold, whether it has been suspended, or is in transit, etc. > > Test plan: > 1) Place an item level hold and a 'Next Available' record level hold for > a patron. > 2) View the holds in Patrons->Patron details for that Patron in the Check > out and Details tabs > 3) Suspend one of the holds, and note that the status appears in the > barcode column > 4) Set a hold to be waiting for pickup, and note the status appears in > the barcode column > 5) Apply the patch > 6) Check the same holds and note that the statuses now appear in the new > column called Status, and note that if a hold has status effect that the > row reads "Hold has been placed" > 7) Verify that this is the case in both the Holds tables (in Check out > tab and Details tab) > > Sponsored-by: Catalyst IT Note: Step 6 should read "note that id a hold has no status effect", meaning it is not suspended or waiting, etc,. but instead just exists as a hold. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 22:58:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 21:58:10 +0000 Subject: [Koha-bugs] [Bug 22489] Onboarding tool fails due to inserting maxissueqty into IssuingRule In-Reply-To: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22489-70-Z3enrfiQ5M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22489 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I should add that this regression would have been caught with bug 19185 ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 23:11:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 22:11:53 +0000 Subject: [Koha-bugs] [Bug 7181] Template indentation In-Reply-To: <bug-7181-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7181-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7181-70-Zm9O2KDvwm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7181 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED CC| |hayleymapley at catalyst.net.n | |z --- Comment #2 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- This appears to be fixed. Changing status to Resolved. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 23:11:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 22:11:53 +0000 Subject: [Koha-bugs] [Bug 7119] general code-cleaning, tidy/whitespace omnibus In-Reply-To: <bug-7119-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7119-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7119-70-2cj5f9AlMw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7119 Bug 7119 depends on bug 7181, which changed state. Bug 7181 Summary: Template indentation https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7181 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 23:20:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 22:20:10 +0000 Subject: [Koha-bugs] [Bug 21985] Test t/db_dependent/Circulation.t fails if SearchEngine is set to elasticsearch In-Reply-To: <bug-21985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21985-70-V6hSvx6UXz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21985 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83254|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86634&action=edit Bug 21985: Fix Circulation tests when ES it set, by using build_sample_item We should use build_sample item (from bug 21971) to create items, otherwise we may not have a valid biblioitem and/or MARC record. Test plan: Set SearchEngine to ES prove that the tests in Circulation.t now pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 23:20:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 22:20:15 +0000 Subject: [Koha-bugs] [Bug 21985] Test t/db_dependent/Circulation.t fails if SearchEngine is set to elasticsearch In-Reply-To: <bug-21985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21985-70-mQ5yoBIlwD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21985 --- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86635&action=edit Bug 21985: Trying to fix the next failure -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 23:21:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 22:21:48 +0000 Subject: [Koha-bugs] [Bug 21985] Test t/db_dependent/Circulation.t fails if SearchEngine is set to elasticsearch In-Reply-To: <bug-21985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21985-70-vNELTh3qYI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21985 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Failed QA Assignee|jonathan.druart at bugs.koha-c |chris at bigballofwax.co.nz |ommunity.org | --- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Hayley, you do not have all the sample data. You must have them into your DB to have the tests running correctly. However there is an error, but another one: t/db_dependent/Circulation.t .. 114/126 # Failed test 'Lost item with cancelled hold has holding branch equallying the transfers source branch' # at t/db_dependent/Circulation.t line 2441. # got: 'XX_vS1zKTd' # expected: 'KazYKXl' # Looks like you failed 1 test of 5. t/db_dependent/Circulation.t .. 117/126 # Failed test 'Cancel transfers on lost items' I am not able to fix it. Could someone else have a try? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 23:22:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 22:22:52 +0000 Subject: [Koha-bugs] [Bug 21985] Test t/db_dependent/Circulation.t fails if SearchEngine is set to elasticsearch In-Reply-To: <bug-21985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21985-70-E5PD5MGE6D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21985 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major CC| |nick at bywatersolutions.com --- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Nick, I am raising the severity of this one. Since I have written the patch we have added new occurrences of the problematic pattern. We must have this one included into master to prevent further regressions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 23:48:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 22:48:13 +0000 Subject: [Koha-bugs] [Bug 13618] Add additional template filter methods and a filter presence test to Koha In-Reply-To: <bug-13618-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13618-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13618-70-pTofPeo2Zo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22478 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 23:51:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 22:51:10 +0000 Subject: [Koha-bugs] [Bug 8115] DOM indexing configuration should compute totalissues from items.issues In-Reply-To: <bug-8115-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8115-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8115-70-CnG0mB4lYa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8115 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jcamins at cpbibliography.com |koha-bugs at lists.koha-commun | |ity.org Status|ASSIGNED |NEW --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Resetting to NEW and removing asignee as there has been no activity in a long time. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 23:52:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 22:52:30 +0000 Subject: [Koha-bugs] [Bug 8212] Omnibus bug report for C & P authority developments In-Reply-To: <bug-8212-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8212-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8212-70-Fm8pIjidBp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8212 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|ASSIGNED |RESOLVED Resolution|--- |WONTFIX --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Closing the omnibus as there has been no action in more than 8 years. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 14 23:59:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 22:59:43 +0000 Subject: [Koha-bugs] [Bug 10140] Add UNIMARC tests to t/db_dependent/Record/Record.t In-Reply-To: <bug-10140-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10140-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10140-70-puk0OPnE97@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10140 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|gmcharlt at gmail.com |chris at bigballofwax.co.nz Summary|add UNIMARC tests to |Add UNIMARC tests to |t/db_dependent/Record/Recor |t/db_dependent/Record/Recor |d.t |d.t --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Still valid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 00:08:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 23:08:11 +0000 Subject: [Koha-bugs] [Bug 10137] a followup of Bogue 8620 (Barcode searching not working correctly) is needed for UNIMARC In-Reply-To: <bug-10137-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10137-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10137-70-N55ro0RTsn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10137 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I've verified the changes made on bug 8620 are also present in nowadays UNIMARC file. Closing RESOLVED FIXED. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 00:09:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 23:09:23 +0000 Subject: [Koha-bugs] [Bug 10123] Way to accept donations for purchase suggestions In-Reply-To: <bug-10123-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10123-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10123-70-OfqPzcjp7G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10123 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|way to accept donations |Way to accept donations for | |purchase suggestions CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 00:11:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 23:11:33 +0000 Subject: [Koha-bugs] [Bug 10121] Unhighlight doesn't carry over to other pages In-Reply-To: <bug-10121-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10121-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10121-70-9B3VWP2fek@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10121 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|unhighlight doesn't carry |Unhighlight doesn't carry |over to other pages |over to other pages CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Still valid. I think instead of new search having it remember for the current session (until browser is closed) would be good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 00:18:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 23:18:25 +0000 Subject: [Koha-bugs] [Bug 8179] Receiving multiple order lines at once In-Reply-To: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8179-70-wTXSAW9EfQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8179 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10087 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 00:18:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 23:18:25 +0000 Subject: [Koha-bugs] [Bug 10087] Way to receive easily documents from a specific basket In-Reply-To: <bug-10087-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10087-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10087-70-H9wzhocYT0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10087 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=8179 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 00:22:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 23:22:48 +0000 Subject: [Koha-bugs] [Bug 10077] Pass extended patron attributes via Borrower SIP protocol In-Reply-To: <bug-10077-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10077-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10077-70-CeoqkO6tIS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10077 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** This bug has been marked as a duplicate of bug 17826 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 00:22:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 23:22:48 +0000 Subject: [Koha-bugs] [Bug 17826] Allow extended patron attributes to be sent in arbitrary SIP2 fields In-Reply-To: <bug-17826-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17826-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17826-70-Fj9FGvYCdW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17826 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |melia at bywatersolutions.com --- Comment #18 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** Bug 10077 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 00:25:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 23:25:34 +0000 Subject: [Koha-bugs] [Bug 10035] Move or copy hard due date to be by patron category In-Reply-To: <bug-10035-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10035-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10035-70-bwUI7BSdlX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10035 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|move or copy hard due date |Move or copy hard due date |to be by patron category |to be by patron category --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I am not sure if this should be implemented as suggested. Maybe something like inheritance or batche editing circ rules would be better? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 00:29:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 23:29:40 +0000 Subject: [Koha-bugs] [Bug 10208] The ability to order multiple copies of the same title In-Reply-To: <bug-10208-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10208-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10208-70-DJT3QcU6R2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10208 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- This has been added a while ago. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 00:31:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 23:31:20 +0000 Subject: [Koha-bugs] [Bug 10232] Permission check for editing help files is broken In-Reply-To: <bug-10232-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10232-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10232-70-DKi5avu2w3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10232 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|NEW |RESOLVED --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Editing the help files is currently no longer possible, resolving this bug. See bug 19817. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 00:46:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 23:46:44 +0000 Subject: [Koha-bugs] [Bug 16486] Display the TIME a fine was collected/written off In-Reply-To: <bug-16486-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16486-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16486-70-zfJMXqXTS4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16486 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #44 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** Bug 2601 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 00:46:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Mar 2019 23:46:44 +0000 Subject: [Koha-bugs] [Bug 2601] Order fines by date and time In-Reply-To: <bug-2601-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-2601-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-2601-70-aYuFlkAfxX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2601 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** This bug has been marked as a duplicate of bug 16486 *** -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 02:02:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 01:02:40 +0000 Subject: [Koha-bugs] [Bug 10087] Way to receive easily documents from a specific basket In-Reply-To: <bug-10087-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10087-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10087-70-wwpyqomhhA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10087 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 06:08:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 05:08:22 +0000 Subject: [Koha-bugs] [Bug 22517] New: Circulation report Message-ID: <bug-22517-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22517 Bug ID: 22517 Summary: Circulation report Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: br541814 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Target Milestone: --- I am using KOHA version: 16.05.02.000. I am looking to prepare a circulation report of the items which are checked out. I want to calculate and see the description of the items status with checked out. I want to differentiate the holding and checked out items please help. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 08:00:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 07:00:57 +0000 Subject: [Koha-bugs] [Bug 22508] Add the ability to prefill 856$u with the direct URL of the file In-Reply-To: <bug-22508-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22508-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22508-70-mqrvCs63WU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508 --- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #5) > (In reply to Marcel de Rooy from comment #4) > > (In reply to Jonathan Druart from comment #3) > > > * In discussion - what about the upload of files from outside of the > > > cataloguing plugin? > > > > Never seen Tools: Upload ? > > Hello Marcel, > This is exactly what I meant with this comment: this patch does not affect > the uploads made outside of the cataloguing plugin. Great. Just read it diagonally.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 08:23:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 07:23:26 +0000 Subject: [Koha-bugs] [Bug 22517] Circulation report In-Reply-To: <bug-22517-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22517-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22517-70-WbrZhFnkjh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22517 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- This sounds like a support request rather than a bug. Also the version you use is no longer maintained. Please ask questions about how to use Koha on the Koha mailing list (http://koha-community.org/support/koha-mailing-lists/) or in the #koha IRC channel (http://koha-community.org/get-involved/irc/). Hopefully you've already seen the Koha documentation: http://koha-community.org/documentation/ You can also find options for paid support here: https://koha-community.org/support/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 08:30:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 07:30:15 +0000 Subject: [Koha-bugs] [Bug 3484] Break down fee display by types on checkout tab In-Reply-To: <bug-3484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-3484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3484-70-K1MhkkXEn9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3484 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Patrons |Circulation Summary|Break down fee display on |Break down fee display by |checkout tab |types on checkout tab Status|ASSIGNED |NEW Assignee|jwagner at ptfs.com |koha-bugs at lists.koha-commun | |ity.org CC| |gmcharlt at gmail.com, | |kyle.m.hall at gmail.com --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I still like the idea of this. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 08:35:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 07:35:20 +0000 Subject: [Koha-bugs] [Bug 20421] Apply CheckPrevCheckout logic when placing a hold on the staff client In-Reply-To: <bug-20421-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20421-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20421-70-31kWDOXXVp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20421 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Apply CheckPrevIssue logic |Apply CheckPrevCheckout |when placing a hold on the |logic when placing a hold |staff client |on the staff client -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 08:35:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 07:35:38 +0000 Subject: [Koha-bugs] [Bug 20421] Apply CheckPrevCheckout logic when placing a hold on the staff client In-Reply-To: <bug-20421-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20421-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20421-70-oVgM1JxW42@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20421 --- Comment #12 from Josef Moravec <josef.moravec at gmail.com> --- (In reply to Martin Renvoize from comment #11) > Works as described, signing off. Thanks Martin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 09:24:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 08:24:19 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void is not limited to 'payments' In-Reply-To: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22511-70-0KTJQpcjvt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- I don't think I gave this a good title.. I'll change it. I didn't really mean that's it's a bad thing that one can void all the different types of credit, but more that it's a bad thing that you loose the information as to what type of credit you have voided. In my opinion 'void' is a valid 'state' of any credit (and for that matter, I don't see why one shouldn't be able to void a debit too). See bug 22512 for more explanation, I may mark this bug as a duplicate at some point, or use to to encapsulate the corresponding work for the void part of adding states. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 09:43:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 08:43:55 +0000 Subject: [Koha-bugs] [Bug 22516] accountlines.lastincrement can be removed In-Reply-To: <bug-22516-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22516-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22516-70-8pFGbNnivv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22516 --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86637&action=edit Bug 22516: Remove remaining calls to lastincrement A few places still set lastincrement and the tests still checked for correct values. But nowhere in the code still uses lastincrement for anything meaningful. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 09:43:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 08:43:58 +0000 Subject: [Koha-bugs] [Bug 22516] accountlines.lastincrement can be removed In-Reply-To: <bug-22516-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22516-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22516-70-vuGZZt89mT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22516 --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86638&action=edit Bug 22516: Database update Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 09:44:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 08:44:13 +0000 Subject: [Koha-bugs] [Bug 22516] accountlines.lastincrement can be removed In-Reply-To: <bug-22516-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22516-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22516-70-DosAgSvEqL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22516 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 09:45:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 08:45:19 +0000 Subject: [Koha-bugs] [Bug 22516] accountlines.lastincrement can be removed In-Reply-To: <bug-22516-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22516-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22516-70-AWn54sl2of@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22516 --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Test plan.. in reality this shouldn't affect anything as the real testing of functionality will have happened in bug 14591. So.. test plan is to simply run the affected tests and make sure they are still passing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 09:45:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 08:45:26 +0000 Subject: [Koha-bugs] [Bug 22516] accountlines.lastincrement can be removed In-Reply-To: <bug-22516-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22516-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22516-70-zWskrcRdBM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22516 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 09:45:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 08:45:47 +0000 Subject: [Koha-bugs] [Bug 22516] accountlines.lastincrement can be removed In-Reply-To: <bug-22516-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22516-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22516-70-JguF2EfZl4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22516 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 09:47:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 08:47:39 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18736-70-8UbCSoGvjI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |BLOCKED --- Comment #165 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Back here again ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 10:46:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 09:46:14 +0000 Subject: [Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines In-Reply-To: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14591-70-AS4IkhOIgf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 10:45:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 09:45:44 +0000 Subject: [Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines In-Reply-To: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14591-70-mnHg5XBGPo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | --- Comment #23 from Josef Moravec <josef.moravec at gmail.com> --- (In reply to Martin Renvoize from comment #21) > I really like this solution! It tidies up the code significantly and > corrects the logic considerably! > > Signing off as it all works in testing as described... > > Some QA comments for the next in line however. > > * Can we/Should we remove the 'lastincrement' field here as I believe this > was the only use case for it? > * The logic here puts 'dropboxmode/dropboxdate' in precidence to any > specified return date.. I think we perhaps need a bit more in this regard, > but perhaps that can be done within bug 13044 as there's a fair bit of > contextual conversation over there around this issue. I agree to continue on these two points on other reports, as this patchset is ok and fixes the bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 10:46:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 09:46:21 +0000 Subject: [Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines In-Reply-To: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14591-70-TAeqGYXzYk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 --- Comment #25 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86640&action=edit Bug 14591: Update other calls to AddReturn Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 10:46:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 09:46:17 +0000 Subject: [Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines In-Reply-To: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14591-70-TH58trxnVQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86618|0 |1 is obsolete| | Attachment #86619|0 |1 is obsolete| | Attachment #86620|0 |1 is obsolete| | Attachment #86621|0 |1 is obsolete| | --- Comment #24 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86639&action=edit Bug 14591: book drop / drop box mode incorrectly decrements accrued overdue fines Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 10:46:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 09:46:28 +0000 Subject: [Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines In-Reply-To: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14591-70-Qx382vE3u0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 --- Comment #27 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86642&action=edit Bug 14591: (QA follow-up) Optimize DateTime passing We were passing around possibly undefined $return_date variables from AddReturn and then instantiating a new DateTime object as a default for each routine. This followup sets the default higher up the stack within AddReturn which provider clearer logic and a small performance improvment. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 10:46:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 09:46:25 +0000 Subject: [Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines In-Reply-To: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14591-70-0KiUvib9Yx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 --- Comment #26 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86641&action=edit Bug 14591: Update unit tests Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 10:46:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 09:46:32 +0000 Subject: [Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines In-Reply-To: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14591-70-ok7GGE4LTv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 --- Comment #28 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86643&action=edit Bug 14591: (QA follow-up) Fix AddReturn call in Circulation/issue.t Test plan: prove t/db_dependent/Circulation/issue.t Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 10:55:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 09:55:54 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14825-70-plMGpIHvP9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Janet McGowan <janet.mcgowan at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 11:01:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 10:01:46 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: <bug-6473-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6473-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6473-70-9hkwjTM61e@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #221 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 86644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86644&action=edit Bug 18736: Calculate tax depending on rounding Marcel's comments pointed out that while I tried to avoid storing rounded values it is required for tax generation. This patch makes that change and adds test coverage and POD for populate_order_with_prices To test: Follow plan on other patches, ensure that orders and totals match on the basket, invoice, and budget pages prove -v t/db_dependent/Acquisition/populate_order_with_prices.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 11:02:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 10:02:14 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: <bug-6473-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6473-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6473-70-SrqECoaAVh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86644|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 11:03:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 10:03:53 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: <bug-6473-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6473-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6473-70-nmuXCw6oiV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #222 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 86645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86645&action=edit Bug 18736: Calculate tax depending on rounding Marcel's comments pointed out that while I tried to avoid storing rounded values it is required for tax generation. This patch makes that change and adds test coverage and POD for populate_order_with_prices To test: Follow plan on other patches, ensure that orders and totals match on the basket, invoice, and budget pages prove -v t/db_dependent/Acquisition/populate_order_with_prices.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 11:04:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 10:04:24 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: <bug-6473-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6473-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6473-70-t0c5ZhggGB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86645|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 11:04:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 10:04:56 +0000 Subject: [Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint In-Reply-To: <bug-22008-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22008-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22008-70-t69uwYi99V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 11:05:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 10:05:09 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18736-70-9ylRrpz1OK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83973|0 |1 is obsolete| | --- Comment #166 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 86646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86646&action=edit Bug 18736: Add OrderPriceRounding syspref Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 11:05:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 10:05:17 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18736-70-Eo0c4P0Lji@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83974|0 |1 is obsolete| | --- Comment #167 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 86647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86647&action=edit Bug 18736: Use rounding syspref to determine correct prices in calculations To test: Place an order (no tax just for simplicity) listprice/rrp = 16.99 discount = 42% quantity = 8 estimated calculated at 9.85 but order total is 78.83, but 8 times 9.85 = 78.80 Apply patches, set OrderPriceRounding syspref to 'Nearest cent' Not order total is now as expected View ordered.pl and confirm values are correct Complete order, view invoice and confirm values View spent.pl and confirm values Go through acquisitions module and confirm prices throughout are correct. Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 11:05:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 10:05:24 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18736-70-nYti5ylPEQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83975|0 |1 is obsolete| | --- Comment #168 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 86648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86648&action=edit Bug 18736: Unit tests for rounding Unit tests to highlight the issue To test: Prove t/db_dependent/Budgets.t prove t/Acquisition.t Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 11:05:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 10:05:31 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18736-70-QhW9vttTMU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83976|0 |1 is obsolete| | --- Comment #169 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 86649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86649&action=edit Bug 18736: (follow-up) Add tests and FIXME for GetbudgetsPlanCell prove t/db_dependent/Budgets.t Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 11:05:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 10:05:38 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18736-70-p0wNTnSIpk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83977|0 |1 is obsolete| | --- Comment #170 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 86650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86650&action=edit Bug 18736: (follow-up) Add missing test cases We now fully cover GetBudgetsPlanCell in these tests Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 11:05:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 10:05:44 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18736-70-zw8jF8hwtA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83978|0 |1 is obsolete| | --- Comment #171 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 86651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86651&action=edit Bug 18736: (follow-up) Fix missing rounding and bad formatting This patch: Adds a missing use Uses 'Koha::Number::Price->round()' instead of 'format()' to ensure numeric returns Ensures too big numbers don't crash round() Uses syspref in 'GetBudgetHierarchy' To test: Follow previous test plan Check values on admin/aqbudgets.pl are affected by syspref Ensure values throughout acquisitions are correctly calculated/displayed (even when greater than 1,000) Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 11:05:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 10:05:51 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18736-70-xFbLe9uEfN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83979|0 |1 is obsolete| | --- Comment #172 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 86652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86652&action=edit Bug 18736: Unit tests for GetBudgetHierarchy prove -v t/db_dependent/Budgets.t Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 11:05:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 10:05:58 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18736-70-3VRXAzFXJj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83980|0 |1 is obsolete| | --- Comment #173 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 86653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86653&action=edit Bug 18736: (follow-up) cast as UNSIGNED instead of INTEGER More recent MySql versions require the use of SIGNED or UNSIGNED rather than INTEGER. UNSIGNED will still work in older installs Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 11:06:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 10:06:04 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18736-70-L8vxuRsRKX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83981|0 |1 is obsolete| | --- Comment #174 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 86654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86654&action=edit Bug 18736: (follow-up) Remove duplicate code and adjust tests Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 11:06:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 10:06:17 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18736-70-Ha1rScQDvj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83983|0 |1 is obsolete| | --- Comment #176 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 86656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86656&action=edit Bug 18736: (QA follow-up) Change to signed, add large int test [1] Add trivial subtest in t/Number/Price.t Checking a negative number and a large number for the MAX_INT change. Note: Confusing to have t/Prices.t too. [2] Change UNSIGNED to SIGNED in get_rounding_sql. Although I did not spot problems with negative prices, we theoretically could while casting. cast(-2 as unsigned) == 18446744073709551614 Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 11:06:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 10:06:24 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18736-70-44Z4iLLaG5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83984|0 |1 is obsolete| | --- Comment #177 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 86657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86657&action=edit Bug 18736: (QA follow-up) Resolve uninitialized warn from Biblio.pm L3334 Running t/db/Budgets.t: Use of uninitialized value in join or string at C4/Biblio.pm line 3334. Test plan: Run again. Verify no warnings left. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 11:06:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 10:06:31 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18736-70-G3WEXiLts5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83985|0 |1 is obsolete| | --- Comment #178 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 86658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86658&action=edit Bug 18736: Calculate tax depending on rounding Marcel's comments pointed out that while I tried to avoid storing rounded values it is required for tax generation. This patch makes that change and adds test coverage and POD for populate_order_with_prices To test: Follow plan on other patches, ensure that orders and totals match on the basket, invoice, and budget pages prove -v t/db_dependent/Acquisition/populate_order_with_prices.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 11:06:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 10:06:11 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18736-70-qZt16Thk6j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83982|0 |1 is obsolete| | --- Comment #175 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 86655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86655&action=edit Bug 18736: (QA follow-up) Cosmetic changes [1] Resolve warnings like: Use of uninitialized value $rounding_pref in string eq at /usr/share/koha/devclone/C4/Acquisition.pm line 2040. [2] Fixing unusual use of whitespace too. [3] Remove list operator from get_rounding_sql return. Only used in scalar context. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 11:08:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 10:08:19 +0000 Subject: [Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint In-Reply-To: <bug-22008-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22008-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22008-70-RDTFlSqLIE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86162|0 |1 is obsolete| | Attachment #86163|0 |1 is obsolete| | Attachment #86164|0 |1 is obsolete| | --- Comment #33 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86659&action=edit Bug 22008: Add tests for new constraints Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 11:08:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 10:08:23 +0000 Subject: [Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint In-Reply-To: <bug-22008-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22008-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22008-70-HMTJMxLYYc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #34 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86660&action=edit Bug 22008: Add missing constraints Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 11:08:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 10:08:27 +0000 Subject: [Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint In-Reply-To: <bug-22008-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22008-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22008-70-8vROtJ7NE5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #35 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86661&action=edit Bug 22008: Fixes to make unit tests pass Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 11:08:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 10:08:16 +0000 Subject: [Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint In-Reply-To: <bug-22008-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22008-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22008-70-sgFuEF3rLC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 11:15:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 10:15:22 +0000 Subject: [Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint In-Reply-To: <bug-22421-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22421-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22421-70-iZ8KKZtqxc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #5 from Josef Moravec <josef.moravec at gmail.com> --- Sorry, can't apply: Applying: Bug 22421: Add tests for new constraints error: sha1 information is lacking or useless (t/db_dependent/Koha/Account/Lines.t). There are also some templates referencing issue_id, it should be fixed, and Koha::Accout::Line->checkout should be adjusted too... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 11:17:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 10:17:38 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void is not limited to 'payments' In-Reply-To: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22511-70-1FsDUNTrSc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 --- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to Martin Renvoize from comment #3) > I don't think I gave this a good title.. I'll change it. > > I didn't really mean that's it's a bad thing that one can void all the > different types of credit, but more that it's a bad thing that you loose the > information as to what type of credit you have voided. > > In my opinion 'void' is a valid 'state' of any credit (and for that matter, > I don't see why one shouldn't be able to void a debit too). > > See bug 22512 for more explanation, I may mark this bug as a duplicate at > some point, or use to to encapsulate the corresponding work for the void > part of adding states. Yes, I agree completely. It would make more sense to have a 'voided' column, or a 'status' column that could have the state 'voided'. Are there other states we should consider for payments? A 'state' column could be re-used for 22512 which cuts now on the number of additional columns needed. What do you think? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 11:24:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 10:24:03 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18736-70-az6JelxAI7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA --- Comment #179 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- QA Comment: I re-entered the example with 8 * 16,99 and 42% discount, 19.45% tax. With the following results when patches applied: OrderPriceRounding=Dont Basket page 78,83 + 15,33 tax. == 94,16 Fund page 94,17 => No match between basket and fund ! OrderPriceRounding=Nearest cent Basket page: 78,80 + 15,33 tax == 94,13 Fund page: 94,16 => No match either between basket and fund ! And without these patches: Basket page 78,83 + 15,33 tax. == 94,16 Fund page: 94,17 => No match either. Conclusion: Please see also my previous comments. I am not repeating them here. With the default setting of Don't round we make no difference in this example; so no behavior change.. The Nearest cent choice does not resolve the discrepancy between basket and fund, as noted before. As already mentioned, I do not object to push this patch set. But this simple exercise already shows that we did not solve the rounding issues. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 11:25:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 10:25:55 +0000 Subject: [Koha-bugs] [Bug 21683] Remove accountlines.accountno In-Reply-To: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21683-70-aDf6sTgOGf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22516 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22516 [Bug 22516] accountlines.lastincrement can be removed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 11:25:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 10:25:55 +0000 Subject: [Koha-bugs] [Bug 22516] accountlines.lastincrement can be removed In-Reply-To: <bug-22516-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22516-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22516-70-QDVq5D6gPw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22516 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21683 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 [Bug 21683] Remove accountlines.accountno -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 11:35:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 10:35:28 +0000 Subject: [Koha-bugs] [Bug 22516] accountlines.lastincrement can be removed In-Reply-To: <bug-22516-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22516-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22516-70-Ca46iRZV0I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22516 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86637|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86662&action=edit Bug 22516: Remove remaining calls to lastincrement A few places still set lastincrement and the tests still checked for correct values. But nowhere in the code still uses lastincrement for anything meaningful. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 11:35:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 10:35:31 +0000 Subject: [Koha-bugs] [Bug 22516] accountlines.lastincrement can be removed In-Reply-To: <bug-22516-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22516-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22516-70-yXTtSQJy23@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22516 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86638|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86663&action=edit Bug 22516: Database update Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 11:39:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 10:39:21 +0000 Subject: [Koha-bugs] [Bug 22474] Authority and biblio field mapping improperly shared In-Reply-To: <bug-22474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22474-70-tPW1LZWo7G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22474 Bj?rn Nyl?n <bjorn.nylen at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 11:39:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 10:39:24 +0000 Subject: [Koha-bugs] [Bug 22474] Authority and biblio field mapping improperly shared In-Reply-To: <bug-22474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22474-70-f0llTBNEIY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22474 Bj?rn Nyl?n <bjorn.nylen at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86278|0 |1 is obsolete| | --- Comment #2 from Bj?rn Nyl?n <bjorn.nylen at ub.lu.se> --- Created attachment 86664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86664&action=edit Bug 22474: Clone field config before adding fields to it Test plain: 1. Reindex both authorities and biblios with the -d flag to recreate the index, e.g. "perl misc/search_tools/rebuild_elastic_search.pl -v -d" 2. Check that authorities only contains authority-specific fields in Elasticsearch e.g. by fetching http://localhost:9200/koha_dev_authorities/_mappings 3. Reindex both without the -d flag and verify it works, e.g. "perl misc/search_tools/rebuild_elastic_search.pl -v" Signed-off-by: Bj?rn Nyl?n <bjorn.nylen at ub.lu.se> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 11:42:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 10:42:52 +0000 Subject: [Koha-bugs] [Bug 18948] Reindexing should use aliases to avoid down time In-Reply-To: <bug-18948-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18948-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18948-70-ryqcZOzg3v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18948 claire.hernandez at biblibre.com <claire.hernandez at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez at biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 11:48:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 10:48:57 +0000 Subject: [Koha-bugs] [Bug 18948] Reindexing should use aliases to avoid down time In-Reply-To: <bug-18948-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18948-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18948-70-Evb2KxB4lm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18948 --- Comment #13 from claire.hernandez at biblibre.com <claire.hernandez at biblibre.com> --- +1 it would be great to use alias for not loosing search results during full reindexing \o/ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 11:53:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 10:53:11 +0000 Subject: [Koha-bugs] [Bug 21998] Add pattern parameter in Koha::Token In-Reply-To: <bug-21998-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21998-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21998-70-lAoeMrj0jq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21998 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83347|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86665&action=edit Bug 21998: Add pattern parameter in Koha::Token Allow a pattern too in Koha::Token->generate. Only supported length. Does not affect CSRF calls. So tiny change without further impact. Test plan: Run t/Token.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 11:53:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 10:53:14 +0000 Subject: [Koha-bugs] [Bug 21998] Add pattern parameter in Koha::Token In-Reply-To: <bug-21998-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21998-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21998-70-jrmlNzl01H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21998 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84401|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86666&action=edit Bug 21998: Throw exception on bad pattern Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 11:53:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 10:53:17 +0000 Subject: [Koha-bugs] [Bug 21998] Add pattern parameter in Koha::Token In-Reply-To: <bug-21998-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21998-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21998-70-sAvz31WABo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21998 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85791|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86667&action=edit Bug 21998: Silent tests Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 12:00:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 11:00:24 +0000 Subject: [Koha-bugs] [Bug 21998] Add pattern parameter in Koha::Token In-Reply-To: <bug-21998-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21998-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21998-70-bT7aXzNfoZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21998 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Small enhancement with no noticeable effects and no regressions. False positive in the QA scripts about POD missing. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 12:06:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 11:06:13 +0000 Subject: [Koha-bugs] [Bug 22043] SIP Checkin Response alert flag set to often set to Y incorrectly In-Reply-To: <bug-22043-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22043-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22043-70-6PL2bFTBYc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22043 --- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 86669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86669&action=edit Bug 22043: (QA follow-up) Add parameter to control behavior Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 12:06:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 11:06:27 +0000 Subject: [Koha-bugs] [Bug 22043] SIP Checkin Response alert flag set to often set to Y incorrectly In-Reply-To: <bug-22043-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22043-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22043-70-tDS1dyNWOL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22043 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 12:06:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 11:06:35 +0000 Subject: [Koha-bugs] [Bug 22043] SIP Checkin Response alert flag set to often set to Y incorrectly In-Reply-To: <bug-22043-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22043-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22043-70-gBbnV2mrrg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22043 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 12:06:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 11:06:08 +0000 Subject: [Koha-bugs] [Bug 22043] SIP Checkin Response alert flag set to often set to Y incorrectly In-Reply-To: <bug-22043-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22043-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22043-70-e4PhZqgevY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22043 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83578|0 |1 is obsolete| | Attachment #85897|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 86668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86668&action=edit Bug 22043: SIP Checkin Response alert flag set to often set to Y incorrectly If a checkin has any messages at all, even informational like LocalUse, the alert flag ( 4th character of the response ) will be set to Y, even if we do not prove a corresponding alert code in the CV field. We should only set the alert flag if we are going to send a value in the CV field.If a checkin has any messages at all, even informational like LocalUse, the alert flag ( 4th character of the response ) will be set to Y, even if we do not prove a corresponding alert code in the CV field. We should only set the alert flag if we are going to send a value in the CV field. Test Plan: 1) Set the checked_in_ok sip account flag to 1 for an account 2) Check in an already checked in item via SIP 3) Note the alert flag is set to Y 4) Apply this patch 5) Restart SIP 6) Check the item in again 7) Note the alert flag is set to N Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Jill Kleven <jill.kleven at pueblolibrary.org> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 12:06:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 11:06:50 +0000 Subject: [Koha-bugs] [Bug 22043] SIP Checkin Response alert flag set to often set to Y incorrectly In-Reply-To: <bug-22043-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22043-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22043-70-gnZcCHWMPI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22043 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 12:07:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 11:07:43 +0000 Subject: [Koha-bugs] [Bug 22043] SIP Checkin Response alert flag set to often set to Y incorrectly In-Reply-To: <bug-22043-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22043-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22043-70-H8SqulyP3Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22043 --- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- t/db_dependent/SIP/Message.t | 21 ++++++++++++++++++++- Great ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 12:10:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 11:10:21 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit In-Reply-To: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22511-70-yASsJuaJ4O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Koha::Account::Line->void |Koha::Account::Line->void |is not limited to |loses the original type of |'payments' |the credit -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 12:26:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 11:26:20 +0000 Subject: [Koha-bugs] [Bug 16413] Prototype for GetLatestAutoRenewDate and GetSoonestRenewDate should be changed In-Reply-To: <bug-16413-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16413-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16413-70-wwNNhHQ4n0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16413 Janet McGowan <janet.mcgowan at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 13:22:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 12:22:03 +0000 Subject: [Koha-bugs] [Bug 22249] Error when submitting Mana comment In-Reply-To: <bug-22249-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22249-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22249-70-JAoQGRr8ox@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22249 --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Jon Knight from comment #1) > Not tackling the cause of this directly (ie why is it requesting a module > that doesn't exist and hasn't be loaded into the code) but what about having > something like this before line 89: > > my $loaded = $packages->VERSION; > if(!$loaded) { > eval('use '.$packages); > if(!$packages->VERSION) { > warn "Can't load package $packages: $!\n"; > } > } We usually use Module::Load::Conditional, but yes it is the same idea. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 13:29:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 12:29:35 +0000 Subject: [Koha-bugs] [Bug 21985] Test t/db_dependent/Circulation.t fails if SearchEngine is set to elasticsearch In-Reply-To: <bug-21985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21985-70-MpS6MoIzyw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21985 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 13:40:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 12:40:23 +0000 Subject: [Koha-bugs] [Bug 22518] New: accounttype 'O' is still referred to but is never set Message-ID: <bug-22518-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22518 Bug ID: 22518 Summary: accounttype 'O' is still referred to but is never set Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- The 'O' accounttype has not been set in Koha for some time and it should now be safe to remove all references to it. History: 'O' used to mean 'Overdue' and was at some point used. However, for some time the codes 'FU' (Fine Unreturned/Updating) in combination with 'F' (Fine) have been used instead. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 13:40:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 12:40:50 +0000 Subject: [Koha-bugs] [Bug 22518] accounttype 'O' is still referred to but is never set In-Reply-To: <bug-22518-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22518-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22518-70-IQIi8NG2sx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22518 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22512 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 [Bug 22512] accountlines.accountype mixes 'state' and 'type' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 13:40:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 12:40:50 +0000 Subject: [Koha-bugs] [Bug 22512] accountlines.accountype mixes 'state' and 'type' In-Reply-To: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22512-70-h4WlO622Iy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22518 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22518 [Bug 22518] accounttype 'O' is still referred to but is never set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 13:46:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 12:46:01 +0000 Subject: [Koha-bugs] [Bug 21357] Filter elisions from index and search terms in Elasticsearch In-Reply-To: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21357-70-YVK3zm4XNk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357 Bj?rn Nyl?n <bjorn.nylen at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 13:46:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 12:46:05 +0000 Subject: [Koha-bugs] [Bug 21357] Filter elisions from index and search terms in Elasticsearch In-Reply-To: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21357-70-ApN99H96tD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357 Bj?rn Nyl?n <bjorn.nylen at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79375|0 |1 is obsolete| | --- Comment #20 from Bj?rn Nyl?n <bjorn.nylen at ub.lu.se> --- Created attachment 86670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86670&action=edit Bug 21357: Add elision filtering to default ES index config To test: 1. Rebuild Elasticsearch index with the new config 2. Add a record with "l'avion" in the title 3. Verify that the record can be found with both "l'avion" and "avion" Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr> Signed-off-by: Bj?rn Nyl?n <bjorn.nylen at ub.lu.se> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 13:46:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 12:46:49 +0000 Subject: [Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines In-Reply-To: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14591-70-fB1lGHKNTa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #29 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 13:47:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 12:47:00 +0000 Subject: [Koha-bugs] [Bug 20823] UNIMARC XSLT does not display 604$t In-Reply-To: <bug-20823-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20823-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20823-70-hKUC33vYww@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20823 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #11 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 13:47:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 12:47:26 +0000 Subject: [Koha-bugs] [Bug 21846] Using emoji as tags doesn't discriminate between emoji when calculating weights or searching In-Reply-To: <bug-21846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21846-70-QU3wFBcS0h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #44 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 13:47:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 12:47:40 +0000 Subject: [Koha-bugs] [Bug 21987] Local cover 'thumbnail' size is bigger than 'imagefile' size in biblioimages table In-Reply-To: <bug-21987-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21987-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21987-70-JjUcZSEew8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21987 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #9 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 13:47:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 12:47:15 +0000 Subject: [Koha-bugs] [Bug 21560] Optimize ODS exports In-Reply-To: <bug-21560-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21560-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21560-70-sE474H0YyP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21560 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #32 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 13:47:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 12:47:55 +0000 Subject: [Koha-bugs] [Bug 21357] Filter elisions from index and search terms in Elasticsearch In-Reply-To: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21357-70-V7xu2DiIPU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357 Bj?rn Nyl?n <bjorn.nylen at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bjorn.nylen at ub.lu.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 13:47:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 12:47:55 +0000 Subject: [Koha-bugs] [Bug 22043] SIP Checkin Response alert flag set to often set to Y incorrectly In-Reply-To: <bug-22043-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22043-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22043-70-vZ3HloTuuQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22043 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #12 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 13:48:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 12:48:07 +0000 Subject: [Koha-bugs] [Bug 22219] C4::Biblio->GetItemsForInventory can return wrong count / duplicated items when skipping waiting holds In-Reply-To: <bug-22219-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22219-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22219-70-zvY9m4MiYA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22219 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #7 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 13:48:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 12:48:18 +0000 Subject: [Koha-bugs] [Bug 22222] Mana subscription search always returns all results In-Reply-To: <bug-22222-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22222-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22222-70-fVdHdjk28L@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22222 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 13:48:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 12:48:31 +0000 Subject: [Koha-bugs] [Bug 22237] Subscriptions are not linked to Mana upon edit In-Reply-To: <bug-22237-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22237-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22237-70-lDVSfOCjau@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22237 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 13:48:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 12:48:46 +0000 Subject: [Koha-bugs] [Bug 22296] Invoice adjustments are not populating to budget views In-Reply-To: <bug-22296-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22296-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22296-70-U96aLMENib@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22296 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #9 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 13:49:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 12:49:30 +0000 Subject: [Koha-bugs] [Bug 22476] MarkLostItemsAsReturned has wrong defaults for new installs In-Reply-To: <bug-22476-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22476-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22476-70-Lgsx4Eb56Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22476 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 13:49:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 12:49:09 +0000 Subject: [Koha-bugs] [Bug 22429] Infinite loop in patron card printing In-Reply-To: <bug-22429-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22429-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22429-70-NwPNvNgcJ3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22429 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #15 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 13:49:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 12:49:41 +0000 Subject: [Koha-bugs] [Bug 22477] Missing DataTables configuration when searching patrons for holds In-Reply-To: <bug-22477-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22477-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22477-70-EwWJypHNRI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22477 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #9 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 13:49:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 12:49:56 +0000 Subject: [Koha-bugs] [Bug 22489] Onboarding tool fails due to inserting maxissueqty into IssuingRule In-Reply-To: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22489-70-bHFPxAhCpD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22489 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #19 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 13:50:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 12:50:11 +0000 Subject: [Koha-bugs] [Bug 22493] DecreaseLoanHighHolds.t creates some items/patrons with set values In-Reply-To: <bug-22493-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22493-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22493-70-dgJ8u4Wc6B@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22493 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 13:50:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 12:50:21 +0000 Subject: [Koha-bugs] [Bug 22498] Can not select any funds for invoice adjustments In-Reply-To: <bug-22498-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22498-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22498-70-MisbyuedT9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22498 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 13:51:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 12:51:47 +0000 Subject: [Koha-bugs] [Bug 21357] Filter elisions from index and search terms in Elasticsearch In-Reply-To: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21357-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21357-70-Nc6cdtWVMp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21357 --- Comment #21 from Bj?rn Nyl?n <bjorn.nylen at ub.lu.se> --- We signed off this bug as we think it's a good feature as is. We just recently had a coworker noting this behaviour. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 13:52:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 12:52:19 +0000 Subject: [Koha-bugs] [Bug 22519] New: We have two accounttypes for "forgiven", 'FOR' and 'FFOR' Message-ID: <bug-22519-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22519 Bug ID: 22519 Summary: We have two accounttypes for "forgiven", 'FOR' and 'FFOR' Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- We have two separate accounttype codes denoting 'forgiven'.. this is confusing for the end user and developer alike. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 13:52:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 12:52:38 +0000 Subject: [Koha-bugs] [Bug 22512] accountlines.accountype mixes 'state' and 'type' In-Reply-To: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22512-70-Bx00Cywtdw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22519 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22519 [Bug 22519] We have two accounttypes for "forgiven", 'FOR' and 'FFOR' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 13:52:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 12:52:38 +0000 Subject: [Koha-bugs] [Bug 22519] We have two accounttypes for "forgiven", 'FOR' and 'FFOR' In-Reply-To: <bug-22519-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22519-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22519-70-F0X3QQF0zH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22519 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22512 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 [Bug 22512] accountlines.accountype mixes 'state' and 'type' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 13:59:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 12:59:36 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit In-Reply-To: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22511-70-zG26vsplok@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22512 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 [Bug 22512] accountlines.accountype mixes 'state' and 'type' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 13:59:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 12:59:36 +0000 Subject: [Koha-bugs] [Bug 22512] accountlines.accountype mixes 'state' and 'type' In-Reply-To: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22512-70-28jNnWHzm2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22511 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 [Bug 22511] Koha::Account::Line->void loses the original type of the credit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 14:26:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 13:26:49 +0000 Subject: [Koha-bugs] [Bug 18645] Creation of Koha feature release change tool displayed after running Koha update In-Reply-To: <bug-18645-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18645-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18645-70-c7vgpmofhG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18645 --- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I had a very quick look at the patch and eyeballed: 1. Do not include css/staff-global.css but css/src/staff-global.scss instead 2. +# warn user if they are using mysql/admin login => This is no longer possible 3. Koha::Patron should not contain raw SQL queries. sub check_if_patrons_have_flags should be replaced with "filter_by_with_flags" (or filter_by_something) and looks like: my $patron_without_flags = $self->search({ flags => undef })->count; I let you do the logic for the return value ;) 4. in admin/preferences.pl you are replacing 4 spaces indent with 3 spaces. It's against the coding guidelines and will add merge conflicts. Not a good idea :) There is also debug statements (warn) and empty spaces changes. 5. Is team.inc a copy of about.tt? Also not a good idea, we should have this list only once (we already have it twice actually docs/history.txt and about.tt) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 14:32:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 13:32:34 +0000 Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI In-Reply-To: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20388-70-mn717xm71L@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Bj?rn Nyl?n <bjorn.nylen at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bjorn.nylen at ub.lu.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 14:46:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 13:46:43 +0000 Subject: [Koha-bugs] [Bug 22518] accounttype 'O' is still referred to but is never set In-Reply-To: <bug-22518-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22518-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22518-70-OZqLEpemG2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22518 --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86671&action=edit Bug 22518: Remove references to 'O' accounttype I went back over 12 years to and still only found "FIXME: What are these accounttypes" concerning the 'O' type and I couldn't find anywhere where it was being set. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 14:46:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 13:46:46 +0000 Subject: [Koha-bugs] [Bug 22518] accounttype 'O' is still referred to but is never set In-Reply-To: <bug-22518-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22518-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22518-70-gPYeZAGGJ9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22518 --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86672&action=edit Bug 22518: Add database update 'just in case' All cases I could find where 'O' was referenced it was referenced alongside 'FU'.. as such I've written this DB update to case any last cases of 'O' and update them to 'FU' "just in case" Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 14:47:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 13:47:00 +0000 Subject: [Koha-bugs] [Bug 22518] accounttype 'O' is still referred to but is never set In-Reply-To: <bug-22518-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22518-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22518-70-IWhaXgBU4O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22518 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 14:47:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 13:47:29 +0000 Subject: [Koha-bugs] [Bug 22518] accounttype 'O' is still referred to but is never set In-Reply-To: <bug-22518-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22518-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22518-70-kk41CYnvOj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22518 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz, | |katrin.fischer at bsz-bw.de, | |kyle at bywatersolutions.com, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 14:48:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 13:48:41 +0000 Subject: [Koha-bugs] [Bug 22518] accounttype 'O' is still referred to but is never set In-Reply-To: <bug-22518-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22518-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22518-70-z5YZhKQ5Hn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22518 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 14:52:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 13:52:23 +0000 Subject: [Koha-bugs] [Bug 22518] accounttype 'O' is still referred to but is never set In-Reply-To: <bug-22518-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22518-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22518-70-Eo79MVvef0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22518 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 14:55:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 13:55:24 +0000 Subject: [Koha-bugs] [Bug 22512] accountlines.accountype mixes 'state' and 'type' In-Reply-To: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22512-70-ZKjxbM2aCw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86673&action=edit Bug 22512: Add status field to accountlines Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 14:55:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 13:55:42 +0000 Subject: [Koha-bugs] [Bug 22512] accountlines.accountype mixes 'state' and 'type' In-Reply-To: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22512-70-gXAGkeyBLQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 14:56:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 13:56:20 +0000 Subject: [Koha-bugs] [Bug 18138] Use MARC modification template when adding/updating bibliographic records In-Reply-To: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18138-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18138-70-XUz1AWGD1Q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18138 Frank Hansen <frank.hansen at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #8 from Frank Hansen <frank.hansen at ub.lu.se> --- Signed off after testing that it works for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 15:10:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 14:10:49 +0000 Subject: [Koha-bugs] [Bug 22318] Extend Koha news feature to include other content areas In-Reply-To: <bug-22318-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22318-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22318-70-zHNG7JukEu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Michal Denar <black23 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |black23 at gmail.com --- Comment #6 from Michal Denar <black23 at gmail.com> --- Hi, I tested patches on current master and get this errors: Falling back to patching base and 3-way merge... No changes -- Patch already applied. Applying: Bug 22318: Example implementation: OpacNavRight system preference Using index info to reconstruct a base tree... M installer/data/mysql/sysprefs.sql M koha-tmpl/intranet-tmpl/prog/en/modules/tools/koha-news.tt M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt M opac/opac-main.pl Falling back to patching base and 3-way merge... Auto-merging opac/opac-main.pl CONFLICT (content): Merge conflict in opac/opac-main.pl Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-main.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/tools/koha-news.tt Auto-merging installer/data/mysql/sysprefs.sql error: Failed to merge in the changes. Owen, can you rebase patches na master? Thank you -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 15:14:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 14:14:22 +0000 Subject: [Koha-bugs] [Bug 21983] Deleting a bib does not delete a request's link to it - missing foreign key In-Reply-To: <bug-21983-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21983-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21983-70-ZMOqvp2fyK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 Michal Denar <black23 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |black23 at gmail.com --- Comment #3 from Michal Denar <black23 at gmail.com> --- Please rebase on master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 15:16:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 14:16:53 +0000 Subject: [Koha-bugs] [Bug 22358] Add POD to Koha::SharedContent In-Reply-To: <bug-22358-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22358-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22358-70-G5y1c1Qria@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22358 Michal Denar <black23 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com --- Comment #2 from Michal Denar <black23 at gmail.com> --- Hi, any test plan? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 15:20:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 14:20:01 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit In-Reply-To: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22511-70-fgBjTai2jF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86674&action=edit Bug 22511: Update void method to use status We added a 'status' field to 'accountlines' in bug 22512 to allow for more fined grained control over 'types' and 'states'. This patch updates the void method to utilise this new field so we may keep the original credit type for later auditing should it be required. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 15:20:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 14:20:05 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit In-Reply-To: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22511-70-Zav2X2guAk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86675&action=edit Bug 22511: Update tests Updated tests to check for 'status' change and fixed 'accounttype' and moved from t/db_dependent/Accounts.t to the more appropriate t/db_dependent/Koha/Account/Lines.t Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 15:20:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 14:20:36 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit In-Reply-To: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22511-70-znZmL4mee1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 15:20:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 14:20:26 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit In-Reply-To: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22511-70-QCwG6lzTrc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 15:21:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 14:21:52 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit In-Reply-To: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22511-70-wSpdqCbQxx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- I'm not also wondering about the logic of updating both 'amount' and 'amountoutstanding' here.. shouldn't we perhaps keep the 'amount' as the original value so one can see not only 'What' was voided but also 'How much'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 15:23:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 14:23:23 +0000 Subject: [Koha-bugs] [Bug 22516] accountlines.lastincrement can be removed In-Reply-To: <bug-22516-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22516-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22516-70-BP1uyqki3o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22516 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com, | |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 15:25:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 14:25:21 +0000 Subject: [Koha-bugs] [Bug 22518] accounttype 'O' is still referred to but is never set In-Reply-To: <bug-22518-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22518-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22518-70-idoYTEMYJP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22518 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22512 |14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 [Bug 22512] accountlines.accountype mixes 'state' and 'type' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 15:25:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 14:25:21 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14825-70-pOYAsRazN6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22518 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22518 [Bug 22518] accounttype 'O' is still referred to but is never set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 15:25:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 14:25:21 +0000 Subject: [Koha-bugs] [Bug 22512] accountlines.accountype mixes 'state' and 'type' In-Reply-To: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22512-70-O5vaR73JPt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|22518 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22518 [Bug 22518] accounttype 'O' is still referred to but is never set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 15:32:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 14:32:28 +0000 Subject: [Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines In-Reply-To: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14591-70-8Qq5RRAFaC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 --- Comment #30 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 86676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86676&action=edit Bug 14591: (QA follow-up) Fix call to AddReturn for SIP -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 15:32:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 14:32:52 +0000 Subject: [Koha-bugs] [Bug 21712] Report anonymized patron records In-Reply-To: <bug-21712-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21712-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21712-70-gcnlyzIn6D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21712 --- Comment #8 from Michal Denar <black23 at gmail.com> --- I want to take this back to movement. If we want to make anon process automatic and need to destroy paper contracts too, procees should be: - automatic anon - some kind of log with relevant info for search of paper contracts - some trigger that destroy log if all papers contracts from bach was destroyed. Any ideas how to handle it? Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 15:36:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 14:36:28 +0000 Subject: [Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines In-Reply-To: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14591-70-5IVqyN2AqT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 --- Comment #31 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Kyle M Hall from comment #30) > Created attachment 86676 [details] [review] > Bug 14591: (QA follow-up) Fix call to AddReturn for SIP Followup pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 15:37:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 14:37:19 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11529-70-kWTONRxgYj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Michal Denar <black23 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com --- Comment #60 from Michal Denar <black23 at gmail.com> --- Hi Ere, i tested patches i get this error: Falling back to patching base and 3-way merge... Removing Koha/Schema/Result/Fieldmapping.pm Auto-merging Koha/Schema/Result/Biblio.pm CONFLICT (content): Merge conflict in Koha/Schema/Result/Biblio.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 11529: DBIx schema changes Can you rebase? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 15:38:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 14:38:07 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit In-Reply-To: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22511-70-FIODnhaHIU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14825 |17702 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 [Bug 17702] Create configuration for account types -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 15:38:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 14:38:07 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14825-70-UjxxE45hib@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|22511 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 [Bug 22511] Koha::Account::Line->void loses the original type of the credit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 15:38:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 14:38:07 +0000 Subject: [Koha-bugs] [Bug 8995] Show OpenURL links in OPAC search results In-Reply-To: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8995-70-TPQzxViaoq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8995 Joy Nelson <joy at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 15:38:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 14:38:07 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account types In-Reply-To: <bug-17702-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17702-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17702-70-lveiZKi9H8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22511 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 [Bug 22511] Koha::Account::Line->void loses the original type of the credit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 15:38:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 14:38:53 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account types In-Reply-To: <bug-17702-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17702-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17702-70-sYhwSiGOIe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21739 Depends on|21739 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21739 [Bug 21739] 'Copier fees' should not be used as accounttype on maninvoice.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 15:38:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 14:38:53 +0000 Subject: [Koha-bugs] [Bug 21739] 'Copier fees' should not be used as accounttype on maninvoice.pl In-Reply-To: <bug-21739-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21739-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21739-70-KK16PhhUjO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21739 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17702 Blocks|17702 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 [Bug 17702] Create configuration for account types -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 15:44:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 14:44:31 +0000 Subject: [Koha-bugs] [Bug 22520] New: Be Elastic compliant 7.x and 8.x (_doc) Message-ID: <bug-22520-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22520 Bug ID: 22520 Summary: Be Elastic compliant 7.x and 8.x (_doc) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: claire.hernandez at biblibre.com Target Milestone: --- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 15:44:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 14:44:36 +0000 Subject: [Koha-bugs] [Bug 22520] Be Elastic compliant 7.x and 8.x (_doc) In-Reply-To: <bug-22520-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22520-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22520-70-vomZqByldF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22520 --- Comment #1 from claire.hernandez at biblibre.com <claire.hernandez at biblibre.com> --- Using "_doc" despite "data" in Elastic index. (_doc is not allowed in 5.x version (but we need to have 6.x elastic asap)...) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 15:47:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 14:47:49 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11529-70-cZmxoUoNDh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85587|0 |1 is obsolete| | --- Comment #61 from Ere Maijala <ere.maijala at helsinki.fi> --- Created attachment 86677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86677&action=edit Bug 11529: Add new fields to biblio table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 15:47:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 14:47:54 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11529-70-bsggDEZQjM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85588|0 |1 is obsolete| | --- Comment #62 from Ere Maijala <ere.maijala at helsinki.fi> --- Created attachment 86678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86678&action=edit Bug 11529: Use new biblio fields whenever possible -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 15:47:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 14:47:57 +0000 Subject: [Koha-bugs] [Bug 22521] New: Convert fines handling to use 'status' instead of two accounttypes Message-ID: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Bug ID: 22521 Summary: Convert fines handling to use 'status' instead of two accounttypes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Bug 22512 introduces a new field for tracking the 'state' of various accounttypes; We should convert the current fine handling from using `FU` (denoting "fine unreturned/updating") in combination with `F` (denoting fine "fixed"). This will clarify the logic and also pave the way to having a more user definable accounttype configuration. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 15:48:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 14:48:00 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11529-70-JKVl7o4bzU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85589|0 |1 is obsolete| | --- Comment #63 from Ere Maijala <ere.maijala at helsinki.fi> --- Created attachment 86679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86679&action=edit Bug 11529: Simplify and optimize batchRebuildBiblioTables.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 15:48:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 14:48:10 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11529-70-KZRx4G5NiE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85591|0 |1 is obsolete| | --- Comment #65 from Ere Maijala <ere.maijala at helsinki.fi> --- Created attachment 86681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86681&action=edit Bug 11529: Remove field mapping table and admin page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 15:48:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 14:48:05 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11529-70-rCAyxkp4YX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85590|0 |1 is obsolete| | --- Comment #64 from Ere Maijala <ere.maijala at helsinki.fi> --- Created attachment 86680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86680&action=edit Bug 11529: Clean up subtitle usage Unify and clean up subtitle usage so that it's always used as a simple array and not the old hash structure. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 15:48:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 14:48:15 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11529-70-Jx2P2t53fS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85592|0 |1 is obsolete| | --- Comment #66 from Ere Maijala <ere.maijala at helsinki.fi> --- Created attachment 86682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86682&action=edit Bug 11529: DBIx schema changes Updates to Biblio schema and removal of FieldMapping schema. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 15:48:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 14:48:20 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-uI6A27Gc7b@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22512 Blocks| |17702 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 [Bug 17702] Create configuration for account types https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 [Bug 22512] accountlines.accountype mixes 'state' and 'type' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 15:48:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 14:48:20 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account types In-Reply-To: <bug-17702-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17702-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17702-70-eAUvkEB9Sv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22521 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 15:48:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 14:48:20 +0000 Subject: [Koha-bugs] [Bug 22512] accountlines.accountype mixes 'state' and 'type' In-Reply-To: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22512-70-p7KQWSkQ6Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22521 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 15:48:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 14:48:45 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11529-70-2PM5YrwyAf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 --- Comment #67 from Ere Maijala <ere.maijala at helsinki.fi> --- Thanks Michal, now rebased. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 15:49:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 14:49:36 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-CQvbKfkY6t@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 15:50:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 14:50:37 +0000 Subject: [Koha-bugs] [Bug 22518] accounttype 'O' is still referred to but is never set In-Reply-To: <bug-22518-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22518-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22518-70-xCoOQckWDz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22518 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14825 |22521 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 15:50:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 14:50:37 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14825-70-S6hHxbwhW3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|22518 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22518 [Bug 22518] accounttype 'O' is still referred to but is never set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 15:50:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 14:50:37 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-LPgJmkurid@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22518 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22518 [Bug 22518] accounttype 'O' is still referred to but is never set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 15:52:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 14:52:16 +0000 Subject: [Koha-bugs] [Bug 22512] accountlines.accountype mixes 'state' and 'type' In-Reply-To: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22512-70-XJK6t8tihL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- *** Bug 22510 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 15:52:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 14:52:16 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account types In-Reply-To: <bug-17702-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17702-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17702-70-E29CYe2PDl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Bug 17702 depends on bug 22510, which changed state. Bug 22510 Summary: 'accountlines.accounttype' should never be set directly, rather is should be changed via Koha::Account et al. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22510 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 15:52:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 14:52:37 +0000 Subject: [Koha-bugs] [Bug 22510] 'accountlines.accounttype' should never be set directly, rather is should be changed via Koha::Account et al. In-Reply-To: <bug-22510-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22510-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22510-70-kBfPU1kPcK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22510 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|22512 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 [Bug 22512] accountlines.accountype mixes 'state' and 'type' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 15:52:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 14:52:37 +0000 Subject: [Koha-bugs] [Bug 22512] accountlines.accountype mixes 'state' and 'type' In-Reply-To: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22512-70-tVISNz2wJM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22510 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22510 [Bug 22510] 'accountlines.accounttype' should never be set directly, rather is should be changed via Koha::Account et al. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 15:52:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 14:52:16 +0000 Subject: [Koha-bugs] [Bug 22510] 'accountlines.accounttype' should never be set directly, rather is should be changed via Koha::Account et al. In-Reply-To: <bug-22510-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22510-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22510-70-YqDaBb8acC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22510 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- *** This bug has been marked as a duplicate of bug 22512 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 15:54:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 14:54:35 +0000 Subject: [Koha-bugs] [Bug 22510] 'accountlines.accounttype' should never be set directly, rather is should be changed via Koha::Account et al. In-Reply-To: <bug-22510-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22510-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22510-70-qlE7GR8YJP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22510 --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- This is in effect a duplicate of bug 22512 at this point.. I believe once an accountype is 'set' during it's initial creation it should remain static and rather if it's "state" needs to be tracked we should use a specific field to track it as introduced in the above bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 16:15:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 15:15:04 +0000 Subject: [Koha-bugs] [Bug 22522] New: ILL API breaks with updated Mojolicious version Message-ID: <bug-22522-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522 Bug ID: 22522 Summary: ILL API breaks with updated Mojolicious version Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: Linux Status: NEW Severity: normal Priority: P5 - low Component: ILL Assignee: koha-bugs at lists.koha-community.org Reporter: jose-mario.monteiro-santos at inlibro.com CC: andrew.isherwood at ptfs-europe.com, philippe.blouin at inlibro.com Target Milestone: --- When we tried to setup the ILL module using FreeForm as its backend, the ILL requests page in our staff client would not load any of the requests. We would get an error message saying that there was a problem with missing content in the Datable. Upon investigation, we discovered that the calls made to the API were returning "Malformed query" errors. When validating the query, Auth.pm checks for authorized parameters in openapi.op_spec, which wasn't defined anywhere in our case. After a quick discussion with Andrew Isherwood on IRC, we downgraded Mojolicious (from 8.02 to 7.21), JSON::Validator (from 3.02 to 0.97) and Mojolicious::Plugin::OpenAPI (from 2.08 to 1.15) and everything worked. Isn't this problematic ? If these modules aren't installed or don't meet the minimum version required by Koha, cpan will install the most recent versions and the API won't work. While this was experienced with the ILL module, I assume that other API calls can and will break in the same way. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 16:38:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 15:38:35 +0000 Subject: [Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron" In-Reply-To: <bug-19919-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19919-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19919-70-La6wyOn4On@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 --- Comment #9 from George Williams (NEKLS) <george at nekls.org> --- I'm in favor of removing this altogether if it's not needed. If it is needed, then I'd like to see the patron information stored as the patron's borrowernumber of barcode number rather than as their name. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 16:42:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 15:42:37 +0000 Subject: [Koha-bugs] [Bug 22523] New: Are we safe to remove `misc/maintenance/fix_accountlines_date.pl` Message-ID: <bug-22523-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22523 Bug ID: 22523 Summary: Are we safe to remove `misc/maintenance/fix_accountlines_date.pl` Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- I believe this maintenance script harks back to the days when migrating from Koha pre 3.0 to Koha post 3.0 was common place. Hopefully that's now somewhat of a distant memory for most and as such this script can be removed. I have my doubts that anyone in this position would think to look for it anyway. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 16:43:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 15:43:06 +0000 Subject: [Koha-bugs] [Bug 22523] Are we safe to remove `misc/maintenance/fix_accountlines_date.pl` In-Reply-To: <bug-22523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22523-70-YuLEGOvZiy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22523 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 16:42:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 15:42:57 +0000 Subject: [Koha-bugs] [Bug 22523] Are we safe to remove `misc/maintenance/fix_accountlines_date.pl` In-Reply-To: <bug-22523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22523-70-FPe1YhcRD6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22523 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz, | |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 17:10:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 16:10:37 +0000 Subject: [Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron" In-Reply-To: <bug-19919-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19919-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19919-70-kfiPLtvPoe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 --- Comment #10 from Christopher Brannon <cbrannon at cdalibrary.org> --- (In reply to George Williams (NEKLS) from comment #9) > I'm in favor of removing this altogether if it's not needed. > > If it is needed, then I'd like to see the patron information stored as the > patron's borrowernumber of barcode number rather than as their name. Never a barcode. It should be the borrowernumber. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 17:33:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 16:33:09 +0000 Subject: [Koha-bugs] [Bug 18666] Update 16.06.00.028 failing because of missing no_auto_renewal_after In-Reply-To: <bug-18666-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18666-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18666-70-8FLaiJmWF9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18666 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- /me wonders if this can be close and 'RESOLVED WONTFIX' at this point? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 17:37:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 16:37:09 +0000 Subject: [Koha-bugs] [Bug 22522] ILL API breaks with updated Mojolicious version In-Reply-To: <bug-22522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22522-70-shMfyfaniK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |katrin.fischer at bsz-bw.de --- Comment #1 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- I agree with Jos?-Mario, if Mojolicious is introducing breaking changes like this we should be pinning the version to be installed. Looking at the release changelog (https://github.com/mojolicious/mojo/blob/master/Changes) 7.21 is now over two years old, so we should probably be making gradual moves forward on that too. It seems to be a very fast moving project, so pinning the max version is probably the best thing to do in the short term. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 17:38:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 16:38:03 +0000 Subject: [Koha-bugs] [Bug 22522] API authentication breaks with updated Mojolicious version In-Reply-To: <bug-22522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22522-70-0xw60XuRV9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ILL API breaks with updated |API authentication breaks |Mojolicious version |with updated Mojolicious | |version -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 17:40:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 16:40:21 +0000 Subject: [Koha-bugs] [Bug 14390] Fine not updated from 'FU' to 'F' on renewal In-Reply-To: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14390-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14390-70-dSc9iUtgue@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14390 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22521 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 17:40:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 16:40:21 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-ZS3WPLeADO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14390 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 17:49:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 16:49:16 +0000 Subject: [Koha-bugs] [Bug 16251] Material type is not correctly set for Rancor 008 widget In-Reply-To: <bug-16251-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16251-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16251-70-yPFCYHHtr7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16251 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> --- backported to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 17:52:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 16:52:10 +0000 Subject: [Koha-bugs] [Bug 22275] 18.06.00.060 DB update fails (incomplete/incorrect defaults) In-Reply-To: <bug-22275-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22275-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22275-70-AjN96OUg5H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22275 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #21 from Lucas Gass <lucas at bywatersolutions.com> --- missing 15836 dependency, not backporting to 18.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 18:03:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 17:03:08 +0000 Subject: [Koha-bugs] [Bug 20535] ModZebra called with $record with items stripped in ModBiblioMarc In-Reply-To: <bug-20535-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20535-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20535-70-h9K5DfkcTg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20535 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #9 from Lucas Gass <lucas at bywatersolutions.com> --- not backporting to 18.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 18:09:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 17:09:57 +0000 Subject: [Koha-bugs] [Bug 22419] Removing multiple records from intranet cart causes browser timeout In-Reply-To: <bug-22419-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22419-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22419-70-TMKjV9QHWi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22419 --- Comment #8 from Lucas Gass <lucas at bywatersolutions.com> --- backported to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 18:18:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 17:18:57 +0000 Subject: [Koha-bugs] [Bug 22416] Search.t tests need adjustment for EasyAnalyticRecords syspref In-Reply-To: <bug-22416-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22416-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22416-70-gXlJERaXuq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22416 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #5 from Lucas Gass <lucas at bywatersolutions.com> --- I did not backport 22140, not backing porting this one either since 18.05.x is missing the dependency. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 18:19:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 17:19:32 +0000 Subject: [Koha-bugs] [Bug 22246] Elasticsearch indexing needs a maximum length for __sort fields In-Reply-To: <bug-22246-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22246-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22246-70-F0o0JWHYiN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22246 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #10 from Lucas Gass <lucas at bywatersolutions.com> --- not backporting to 18.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 18:24:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 17:24:22 +0000 Subject: [Koha-bugs] [Bug 22303] Wrong bottom in virtualshelves/addbybiblionumber.tt In-Reply-To: <bug-22303-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22303-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22303-70-RWNB214rsF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22303 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #10 from Lucas Gass <lucas at bywatersolutions.com> --- backported to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 18:26:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 17:26:46 +0000 Subject: [Koha-bugs] [Bug 22442] Item search CSV export broken In-Reply-To: <bug-22442-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22442-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22442-70-mLOpQBQ8if@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22442 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> --- not backporting to 18.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 18:31:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 17:31:02 +0000 Subject: [Koha-bugs] [Bug 19046] IntranetCatalogSearchPulldown doesn't retain last selection In-Reply-To: <bug-19046-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19046-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19046-70-ZWZk4DfhM7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19046 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #10 from Lucas Gass <lucas at bywatersolutions.com> --- backported to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 18:53:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 17:53:14 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit In-Reply-To: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22511-70-h29nc03w1d@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 --- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to Martin Renvoize from comment #7) > I'm not also wondering about the logic of updating both 'amount' and > 'amountoutstanding' here.. shouldn't we perhaps keep the 'amount' as the > original value so one can see not only 'What' was voided but also 'How much'. The logic behind the current behavior is to avoid the need to specifically remove VOIDs from reports when summing amounts. That data should be available the account offsets table. That being said, I'm not opposed to a change in this behavior. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 18:56:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 17:56:43 +0000 Subject: [Koha-bugs] [Bug 22512] accountlines.accountype mixes 'state' and 'type' In-Reply-To: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22512-70-4l2cfdEWnx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 18:56:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 17:56:46 +0000 Subject: [Koha-bugs] [Bug 22512] accountlines.accountype mixes 'state' and 'type' In-Reply-To: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22512-70-6fNBFSdW83@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86673|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 86684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86684&action=edit Bug 22512: Add status field to accountlines Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 19:06:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 18:06:32 +0000 Subject: [Koha-bugs] [Bug 22524] New: Elasticsearch - Date range in advanced search Message-ID: <bug-22524-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22524 Bug ID: 22524 Summary: Elasticsearch - Date range in advanced search Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: marjorie.barry-vila at collecto.ca Target Milestone: --- Hi, There is a problem with date range search in advanced search with ES. Search "2001-2010" will give a list of results with 2001-2010 entered in marc field like 260$c2001-2010 or 264$2001-2010 Records with just 2001 in marc field will not be displayed in search results. Maybe it's just a bad configuration in searchengine/elasticsearch/mappings.pl? Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 19:20:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 18:20:25 +0000 Subject: [Koha-bugs] [Bug 22505] Add column configuration to patron list table In-Reply-To: <bug-22505-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22505-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22505-70-NBD1yXhXoC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22505 Bin <bin.wen at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86582|0 |1 is obsolete| | --- Comment #3 from Bin <bin.wen at inlibro.com> --- Created attachment 86685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86685&action=edit Bug 22505: Add column configuration to patron list table Test plan: 1. Create a list of patrons 2. Add some patrons to this list 3. Go to this patron list (/cgi-bin/koha/patron_lists/list.pl?patron_list_id=XXX) 4. Verify that you can show/hide all columns except the one containing the checkbox 5. Verify that you can export the table data using the Export menu 6. Go to admin/columns_settings.pl, and verify that the configuration works for table 'patron-list-table' Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Bin Wen <bin.wen at inlibro.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 19:24:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 18:24:47 +0000 Subject: [Koha-bugs] [Bug 22505] Add column configuration to patron list table In-Reply-To: <bug-22505-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22505-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22505-70-OwCwB7DlII@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22505 Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86685|0 |1 is obsolete| | --- Comment #4 from Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> --- Created attachment 86686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86686&action=edit Bug 22505: Add column configuration to patron list table Test plan: 1. Create a list of patrons 2. Add some patrons to this list 3. Go to this patron list (/cgi-bin/koha/patron_lists/list.pl?patron_list_id=XXX) 4. Verify that you can show/hide all columns except the one containing the checkbox 5. Verify that you can export the table data using the Export menu 6. Go to admin/columns_settings.pl, and verify that the configuration works for table 'patron-list-table' Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos at inLibro.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 19:37:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 18:37:36 +0000 Subject: [Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch In-Reply-To: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17674-70-nMU4fiWQqj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #115 from Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> --- I am not able to reproduce the problem. I will reupload the patch with a better test plan that will make sure there is no problem with the enumchron. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 19:55:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 18:55:17 +0000 Subject: [Koha-bugs] [Bug 19630] "Hold is suspended" message appears in barcode field in holds table In-Reply-To: <bug-19630-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19630-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19630-70-1a5Ymf2YN8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19630 Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86633|0 |1 is obsolete| | --- Comment #6 from Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> --- Created attachment 86687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86687&action=edit Bug 19630: Added Status column to Patron Holds table When a hold has been suspended or is waiting, the status message appears in the Barcode column of the Holds table. This patch fixes this by adding a separate Status column which details the status of the Hold, whether it has been suspended, or is in transit, etc. Test plan: 1) Place an item level hold and a 'Next Available' record level hold for a patron. 2) View the holds in Patrons->Patron details for that Patron in the Check out and Details tabs 3) Suspend one of the holds, and note that the status appears in the barcode column 4) Set a hold to be waiting for pickup, and note the status appears in the barcode column 5) Apply the patch 6) Check the same holds and note that the statuses now appear in the new column called Status, and note that if a hold has status effect that the row reads "Hold has been placed" 7) Verify that this is the case in both the Holds tables (in Check out tab and Details tab) Sponsored-by: Catalyst IT Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos at inLibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 19:55:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 18:55:51 +0000 Subject: [Koha-bugs] [Bug 19630] "Hold is suspended" message appears in barcode field in holds table In-Reply-To: <bug-19630-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19630-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19630-70-5jOyXGcHEN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19630 Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jose-mario.monteiro-santos@ | |inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 20:06:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 19:06:15 +0000 Subject: [Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch In-Reply-To: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17674-70-4I0IQjSdNM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 --- Comment #116 from Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> --- So... I find out when a serial is deleted with and without the patch, the enumchron lost only the date part. Maybe that was the observed problem, because otherwise the enumcron is not emptied. I will therefore proceed with the clearer test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 20:18:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 19:18:05 +0000 Subject: [Koha-bugs] [Bug 21659] Link to basket groups from order receive page are broken In-Reply-To: <bug-21659-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21659-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21659-70-zGl8kjII7i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21659 Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86556|0 |1 is obsolete| | --- Comment #6 from Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> --- Created attachment 86688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86688&action=edit Bug 21659: Fix links to basket groups from order receive page Fixes a problem with the template variables on the order receive page, so that the links to basket groups work correctly again. To test: - Create some orders with and without basket groups - Receive shipment - Verify that the basket group links for pending orders work right - Receive an order line - Verify that the basket group links for received orders work right Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos at inLibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 20:21:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 19:21:46 +0000 Subject: [Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch In-Reply-To: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17674-70-n8x3C7WOwZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82237|0 |1 is obsolete| | --- Comment #117 from Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> --- Created attachment 86689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86689&action=edit Bug 17674: Allow UI to delete serials in batch This new feature allows for batch deletion of serials through the UI. The current usage is a one-by-one long game. Test plan : - Apply patch. - Create at least four serials with items. - Notice that new items have a numbering pattern and a date in the enumchron field. - Use the button Delete selected issues for the following steps. - Delete a serial and its associated item. - Confirm the serial and item are gone. - Delete a serial and not its item. - Confirm the serial is gone. - Confirm the item is still there and the date part in the enumchron field is gone. - Delete the two lasts serials. - Confirm they are gone. Sponsored by : CCSR -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 20:22:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 19:22:43 +0000 Subject: [Koha-bugs] [Bug 21659] Link to basket groups from order receive page are broken In-Reply-To: <bug-21659-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21659-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21659-70-90sgqTzG5N@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21659 Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jose-mario.monteiro-santos@ | |inlibro.com --- Comment #7 from Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> --- I've signed it off because the links actually work now, but I wonder if the additional "&basketgroupid=X" parameter in the url does anything. When I tested, including it in the url or not brought me to the same page both times (all basket groups for that vendor) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 20:22:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 19:22:44 +0000 Subject: [Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch In-Reply-To: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17674-70-fkSo0PIlCd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #118 from Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> --- So... I find out when a serial is deleted with and without the patch, the enumchron lost only the date part. Maybe that was the observed problem, because otherwise the enumcron is not emptied. I will therefore proceed with the clearer test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 20:40:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 19:40:33 +0000 Subject: [Koha-bugs] [Bug 12656] Send a notice to patrons when their hold was cancelled In-Reply-To: <bug-12656-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12656-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12656-70-ekg5Rg6bNB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12656 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 20:40:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 19:40:55 +0000 Subject: [Koha-bugs] [Bug 20453] Send notification when hold is cancelled by librarian In-Reply-To: <bug-20453-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20453-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20453-70-5wRbB1Rxef@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20453 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 20:46:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 19:46:15 +0000 Subject: [Koha-bugs] [Bug 19685] Canceling a hold from the Hold Found popup does not alert librarian about next hold In-Reply-To: <bug-19685-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19685-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19685-70-DLr8eSb6z8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19685 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 20:46:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 19:46:49 +0000 Subject: [Koha-bugs] [Bug 13978] Hold notification e-mails In-Reply-To: <bug-13978-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13978-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13978-70-Y335NSn2VH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13978 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 20:49:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 19:49:36 +0000 Subject: [Koha-bugs] [Bug 21638] Allow reporting of holds cancelled by cancel_expired_holds.pl and ExpireReservesMaxPickUpDelay In-Reply-To: <bug-21638-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21638-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21638-70-t4Dkwu1eiP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21638 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 20:56:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 19:56:40 +0000 Subject: [Koha-bugs] [Bug 18837] Add an unmediated Interlibrary Loans workflow In-Reply-To: <bug-18837-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18837-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18837-70-O08ACwlVcN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #37 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 20:56:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 19:56:55 +0000 Subject: [Koha-bugs] [Bug 18952] Show internal note in acquisitions details tab In-Reply-To: <bug-18952-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18952-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18952-70-PmVUctqtLu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18952 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #11 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 20:57:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 19:57:08 +0000 Subject: [Koha-bugs] [Bug 20006] Adapt /v1/holds to new naming guidelines In-Reply-To: <bug-20006-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20006-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20006-70-ClTx144Fth@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20006 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #27 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 20:57:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 19:57:29 +0000 Subject: [Koha-bugs] [Bug 20563] ILL request list gives no indication of source and/or target In-Reply-To: <bug-20563-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20563-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20563-70-fhR9JFr2sF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20563 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #33 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 20:57:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 19:57:44 +0000 Subject: [Koha-bugs] [Bug 20658] Move template JavaScript to the footer: Installer and onboarding In-Reply-To: <bug-20658-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20658-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20658-70-wGWW2rDSxN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #16 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 20:57:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 19:57:57 +0000 Subject: [Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events In-Reply-To: <bug-20750-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20750-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20750-70-dQIH4tfEaD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #142 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 20:58:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 19:58:16 +0000 Subject: [Koha-bugs] [Bug 20782] EDI: Clicking the 'Invoice' link on the 'EDI Messages' page does not take you directly to the corresponding invoice In-Reply-To: <bug-20782-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20782-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20782-70-CsbJICFRTo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20782 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 20:58:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 19:58:25 +0000 Subject: [Koha-bugs] [Bug 14669] Search orders by branch In-Reply-To: <bug-14669-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14669-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14669-70-OhlL912QfO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14669 Laura Horgan <horganl at middlesex.mass.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |horganl at middlesex.mass.edu --- Comment #1 from Laura Horgan <horganl at middlesex.mass.edu> --- We have several funds and accounts and would also be interested in a search by branch as we are a multicampus library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 20:59:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 19:59:18 +0000 Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request datatable to be customisable In-Reply-To: <bug-21063-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21063-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21063-70-lpHmoOm83m@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #67 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed (squashed) to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 20:59:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 19:59:42 +0000 Subject: [Koha-bugs] [Bug 22206] Add route to handle holds suspensions In-Reply-To: <bug-22206-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22206-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22206-70-tHwKr3N5Hz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #20 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 20:59:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 19:59:59 +0000 Subject: [Koha-bugs] [Bug 22502] Auto Complete not working when Placing Holds In-Reply-To: <bug-22502-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22502-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22502-70-THf12SBD0c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22502 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> --- this was a result of a Rmain mistake in 18.05.x commit daac05e506efdb6038dd9978aa3f55911c97bf3a fixes it and is backported to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 21:00:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 20:00:16 +0000 Subject: [Koha-bugs] [Bug 22502] Auto Complete not working when Placing Holds In-Reply-To: <bug-22502-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22502-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22502-70-QhUFJUlhak@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22502 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 21:00:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 20:00:37 +0000 Subject: [Koha-bugs] [Bug 22525] New: Navigation arrows on the bottom of Cataloging search pages Message-ID: <bug-22525-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22525 Bug ID: 22525 Summary: Navigation arrows on the bottom of Cataloging search pages Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: alexandre.breton at ccsr.qc.ca QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Target Milestone: --- Created attachment 86690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86690&action=edit No arrows on the bottom of the list As title said, it will be usefull to have the same arrows as on the upper part of the list pointing on following and previous page when doing a search on cataloging search because results pages can be very long. Thanks, ALexandre -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 21:02:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 20:02:00 +0000 Subject: [Koha-bugs] [Bug 22399] Improve responsive behavior of the basic marc editor In-Reply-To: <bug-22399-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22399-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22399-70-2pZUI6PM8p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 21:04:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 20:04:33 +0000 Subject: [Koha-bugs] [Bug 20421] Apply CheckPrevCheckout logic when placing a hold on the staff client In-Reply-To: <bug-20421-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20421-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20421-70-d5Nn1RVbTf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20421 Bin <bin.wen at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86598|0 |1 is obsolete| | --- Comment #13 from Bin <bin.wen at inlibro.com> --- Created attachment 86691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86691&action=edit Bug 20421: Inform staff that patron does have the title checked out during placing hold Test plan: 1) Enable the CheckPrevCheckout and DisplayMultiPlaceHold system preferences 2) Have a patron with some checkouts history 3) Try to place hold on one of titles from history for this patron 4) You should see an information at the top of confirm request page, but you still should be able to place a hold 5) Try this with multiple titles - one or more of them should be from history 6) You should see this information in "Information" column 7) There is also new column placed at the beggining with checkbox, you could uncheck it for titles you do not want to place a hold on it 8) Confirm the hold is placed only on checked titles Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Bin Wen <bin.wen at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 21:06:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 20:06:31 +0000 Subject: [Koha-bugs] [Bug 21030] Date widget on suspend modal not working correctly In-Reply-To: <bug-21030-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21030-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21030-70-YGqWNtV6bu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21030 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #9 from Lucas Gass <lucas at bywatersolutions.com> --- backported to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 21:12:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 20:12:10 +0000 Subject: [Koha-bugs] [Bug 22422] improve item location display with class "shelvingloc" In-Reply-To: <bug-22422-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22422-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22422-70-mlzxHZ2rdN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22422 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> --- cant rebase for 18.05.x deleted by us: ../../../css/src/staff-global.scss ../../../../../opac-tmpl/bootstrap/css/src/opac.scss -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 21:15:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 20:15:31 +0000 Subject: [Koha-bugs] [Bug 17496] install-CPAN.pl documentation/removal In-Reply-To: <bug-17496-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17496-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17496-70-eSfs5sTSPO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17496 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #9 from Lucas Gass <lucas at bywatersolutions.com> --- backported to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 21:44:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 20:44:59 +0000 Subject: [Koha-bugs] [Bug 13763] Renew feature does not check for the BarcodeInputFilter option In-Reply-To: <bug-13763-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13763-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13763-70-BeIcpN0oS7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13763 Bin <bin.wen at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bin.wen at inlibro.com --- Comment #3 from Bin <bin.wen at inlibro.com> --- After applying the patch, it is still invalid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 21:45:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 20:45:55 +0000 Subject: [Koha-bugs] [Bug 13763] Renew feature does not check for the BarcodeInputFilter option In-Reply-To: <bug-13763-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13763-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13763-70-Jl200e8tdJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13763 --- Comment #4 from Bin <bin.wen at inlibro.com> --- After applying the patch, it is still invalid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 22:45:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 21:45:38 +0000 Subject: [Koha-bugs] [Bug 22526] New: The circulation rules table does not exist Message-ID: <bug-22526-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22526 Bug ID: 22526 Summary: The circulation rules table does not exist Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: Linux Status: NEW Severity: minor Priority: P5 - low Component: Continuous Integration Assignee: tomascohen at gmail.com Reporter: leonardo.collas at gmail.com Target Milestone: --- Created attachment 86692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86692&action=edit Software error In the update of koha 16.11 to the stable version 18.11 of my server, the circulation rules table does not exist and it does not allow me to manage the circulation rules of the libraries or generate book reservations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 23:07:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 22:07:44 +0000 Subject: [Koha-bugs] [Bug 22487] Add Mana and Bugzilla components on bugzilla In-Reply-To: <bug-22487-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22487-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22487-70-8miCUPln9a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22487 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Release tools |Bugzilla --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #2) > yes, Project infrastructure > Bugzilla Done! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 23:09:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 22:09:08 +0000 Subject: [Koha-bugs] [Bug 22487] Add Mana and Bugzilla components on bugzilla In-Reply-To: <bug-22487-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22487-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22487-70-4sTRdRgoNe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22487 --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #2) > For Mana I was thinking of the code outside of Koha. Not sure how to handle > that best. I wanted to report 'improve the email sent by Mana' (bug 22488) The code is at https://git.biblibre.com/biblibre/koha-mana and, I think, should be moved to gitlab. And so we would use the bug tracker of the project. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 23:09:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 22:09:27 +0000 Subject: [Koha-bugs] [Bug 22526] The circulation rules table does not exist In-Reply-To: <bug-22526-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22526-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22526-70-ssrFLdRiMJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22526 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |testopia at bugs.koha-communit | |y.org Product|Project Infrastructure |Koha Component|Continuous Integration |Installation and upgrade | |(command-line installer) Assignee|tomascohen at gmail.com |koha-bugs at lists.koha-commun | |ity.org CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Leonardo, please check your version on About.pl - there is no table circulation_rules in 18.11 as this will be a new feature in the yet to be released 19.05. How did you install? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 23:13:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 22:13:05 +0000 Subject: [Koha-bugs] [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules In-Reply-To: <bug-18887-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18887-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18887-70-uBtZTwSBz1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22526 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22526 [Bug 22526] The circulation rules table does not exist -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 23:13:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 22:13:05 +0000 Subject: [Koha-bugs] [Bug 22526] The circulation rules table does not exist In-Reply-To: <bug-22526-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22526-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22526-70-1v5phEjxxF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22526 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18887 Version|unspecified |18.11 --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I am sorry, I was wrong - it should exist (see bug 18887). Please still answer how you installed Koha (packages or another way?) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18887 [Bug 18887] Introduce new table 'circulation_rules', use for 'max_holds' rules -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 23:25:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 22:25:42 +0000 Subject: [Koha-bugs] [Bug 22526] The circulation rules table does not exist In-Reply-To: <bug-22526-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22526-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22526-70-9i03L8AFKO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22526 --- Comment #3 from Leonardo <leonardo.collas at gmail.com> --- The installation I did through this manual https://wiki.koha-community.org/wiki/Koha_on_Debian -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 23:41:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 22:41:31 +0000 Subject: [Koha-bugs] [Bug 20728] Remove subroutines GetLastOrder* In-Reply-To: <bug-20728-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20728-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20728-70-rYZuYy5L3P@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20728 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 23:41:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 22:41:39 +0000 Subject: [Koha-bugs] [Bug 20728] Remove subroutines GetLastOrder* In-Reply-To: <bug-20728-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20728-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20728-70-I9rwQCi65P@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20728 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86693&action=edit Bug 20728: Proof that there is no cheating -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 23:41:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 22:41:46 +0000 Subject: [Koha-bugs] [Bug 20728] Remove subroutines GetLastOrder* In-Reply-To: <bug-20728-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20728-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20728-70-W3oMw0irbM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20728 --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86694&action=edit Bug 20728: Replace the calls by their Koha::Acq::Orders->search equivalent -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 23:41:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 22:41:53 +0000 Subject: [Koha-bugs] [Bug 20728] Remove subroutines GetLastOrder* In-Reply-To: <bug-20728-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20728-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20728-70-iZAQXrF0jd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20728 --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86695&action=edit Bug 20728: Remove the 2 GetLastOrder* subroutines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 23:49:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 22:49:51 +0000 Subject: [Koha-bugs] [Bug 22526] The circulation rules table does not exist In-Reply-To: <bug-22526-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22526-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22526-70-aclH7fFtgR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22526 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Hi Leonardo, it should have been added by 18.06.00.036 Do you remember any errors during the ugrade process? If you upgraded from the interface you can find the log in /var/log/koha/library/updatedatabase_*.log -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 23:54:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 22:54:10 +0000 Subject: [Koha-bugs] [Bug 15734] Audio Alerts broken In-Reply-To: <bug-15734-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15734-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15734-70-7seXRgs3H5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15734 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22378 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 23:54:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 22:54:10 +0000 Subject: [Koha-bugs] [Bug 22378] Fix sound alerts on SCO In-Reply-To: <bug-22378-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22378-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22378-70-CQP5Vp6MO7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22378 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15734 CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 15 23:57:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 22:57:01 +0000 Subject: [Koha-bugs] [Bug 22441] SCO sound alerts need a selenium test In-Reply-To: <bug-22441-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22441-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22441-70-4WXEeWNZNI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22441 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Not really, there was bug 15734 that fixed staff side, but it forgot the other occurrence, at the OPAC. Not sure it is worth spending time on it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 00:00:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 23:00:07 +0000 Subject: [Koha-bugs] [Bug 19102] XSS Flaws in circulation.pl - routing-lists.pl - readingrec.pl - notices.pl - maninvoice.pl - boraccount.pl - mancredit.pl In-Reply-To: <bug-19102-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19102-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19102-70-85MoLOXoiJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19102 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |testopia at bugs.koha-communit | |y.org Product|Koha security |Koha Component|Koha |Architecture, internals, | |and plumbing Group|Koha security | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 00:00:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 23:00:29 +0000 Subject: [Koha-bugs] [Bug 19089] XSS issue in supplier.pl page In-Reply-To: <bug-19089-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19089-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19089-70-Cy2q44hPgW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19089 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Koha |Architecture, internals, | |and plumbing QA Contact| |testopia at bugs.koha-communit | |y.org Product|Koha security |Koha Group|Koha security | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 00:19:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 23:19:27 +0000 Subject: [Koha-bugs] [Bug 22461] Regression in #20287: LDAP user replication broken with mapped extended patron attributes In-Reply-To: <bug-22461-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22461-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22461-70-WvdBCAdNbr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22461 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 00:19:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 23:19:35 +0000 Subject: [Koha-bugs] [Bug 22461] Regression in #20287: LDAP user replication broken with mapped extended patron attributes In-Reply-To: <bug-22461-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22461-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22461-70-uMckJ1BDuh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22461 --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86696&action=edit Bug 22461: Fix LDAP user replication >From bug 20287: - $borrowernumber = C4::Members::AddMember(%borrower) or die "AddMember failed"; + Koha::Patron->new( \%borrower )->store; C4::Members::Messaging::SetMessagingPreferencesFromDefaults( { borrowernumber => $borrowernumber, categorycode => $borrower{'categorycode'} } ); $borrowernumber is not updated with the value of the newly created patron This patch restores the previous behavior (as well as the die) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 00:20:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 23:20:26 +0000 Subject: [Koha-bugs] [Bug 22461] Regression in #20287: LDAP user replication broken with mapped extended patron attributes In-Reply-To: <bug-22461-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22461-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22461-70-AoQnLMmWmX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22461 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86696|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86697&action=edit Bug 22461: Fix LDAP user replication >From bug 20287: - $borrowernumber = C4::Members::AddMember(%borrower) or die "AddMember failed"; + Koha::Patron->new( \%borrower )->store; C4::Members::Messaging::SetMessagingPreferencesFromDefaults( { borrowernumber => $borrowernumber, categorycode => $borrower{'categorycode'} } ); $borrowernumber is not updated with the value of the newly created patron This patch restores the previous behavior (as well as the die) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 00:21:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Mar 2019 23:21:49 +0000 Subject: [Koha-bugs] [Bug 22461] Regression in #20287: LDAP user replication broken with mapped extended patron attributes In-Reply-To: <bug-22461-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22461-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22461-70-h1zm7vIadu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22461 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.11 |master Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Sorry about that Oliver, it's a silly mistake. I did not test that patch but it seems that it will restore the behavior. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 01:00:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 00:00:22 +0000 Subject: [Koha-bugs] [Bug 22527] New: Web installer links to wrong database manual when database user doesn't have required privileges Message-ID: <bug-22527-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22527 Bug ID: 22527 Summary: Web installer links to wrong database manual when database user doesn't have required privileges Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: lari.taskula at hypernova.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Target Milestone: --- To reproduce: 1. Use MySQL or MariaDB for your Koha installation 2. Create an empty database and point $KOHA_CONF to this database name. 3. Grant SELECT privilege to your database user, e.g. grant select on koha3.* to 'koha'@'%' identified by 'koha'; 4. Go to step 2 of web installer where it checks database connection 5. Observe the following message User koha doesn't have enough privilege on database koha. Ask for or make a change in the user's privileges. User koha must have USAGE, INSERT, UPDATE, DELETE, DROP and CREATE privileges on database koha2. Need help? See manual for PostgreSQL 6. Note "See manual for PostgreSQL" is wrong. Should be "See manual for MySQL". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 01:16:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 00:16:55 +0000 Subject: [Koha-bugs] [Bug 22527] Web installer links to wrong database manual when database user doesn't have required privileges In-Reply-To: <bug-22527-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22527-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22527-70-aJYqXAam81@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22527 --- Comment #1 from Lari Taskula <lari.taskula at hypernova.fi> --- Created attachment 86698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86698&action=edit Bug 22527: Fix link to wrong database manual in web installer To reproduce: 1. Use MySQL or MariaDB for your Koha installation 2. Create an empty database and point $KOHA_CONF to this database name. 3. Grant SELECT privilege to your database user, e.g. grant select on koha3.* to 'koha'@'%' identified by 'koha'; 4. Go to step 2 of web installer where it checks database connection 5. Observe the following message User koha doesn't have enough privilege on database koha. Ask for or make a change in the user's privileges. User koha must have USAGE, INSERT, UPDATE, DELETE, DROP and CREATE privileges on database koha2. Need help? See manual for PostgreSQL 6. Note "See manual for PostgreSQL" is wrong. Should be "See manual for MySQL". 7. Apply patch 8. Refresh page and observe it now displays correct link Sponsored-by: Hypernova Oy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 01:18:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 00:18:16 +0000 Subject: [Koha-bugs] [Bug 22527] Web installer links to wrong database manual when database user doesn't have required privileges In-Reply-To: <bug-22527-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22527-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22527-70-SQ8fFbbj1Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22527 Lari Taskula <lari.taskula at hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 01:18:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 00:18:18 +0000 Subject: [Koha-bugs] [Bug 22527] Web installer links to wrong database manual when database user doesn't have required privileges In-Reply-To: <bug-22527-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22527-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22527-70-0QQFh2D3Gn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22527 --- Comment #2 from Lari Taskula <lari.taskula at hypernova.fi> --- Created attachment 86699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86699&action=edit Bug 22527: Enhance visibility of error message Place database user privilege issue into a yellow box to enhance visilibty. Sponsored-by: Hypernova Oy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 01:18:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 00:18:50 +0000 Subject: [Koha-bugs] [Bug 22527] Web installer links to wrong database manual when database user doesn't have required privileges In-Reply-To: <bug-22527-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22527-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22527-70-G6VIVW12kD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22527 Lari Taskula <lari.taskula at hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lari.taskula at hypernova.fi |ity.org | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 01:20:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 00:20:02 +0000 Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap grid: Catalog In-Reply-To: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21304-70-jz21cyieli@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Failed QA --- Comment #27 from Nick Clemens <nick at bywatersolutions.com> --- After applying I get a JS error on search results: TypeError: c is null[Learn More] hc-sticky_18.1200027.js:11:4777 And I have no button to select records in the search results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 01:22:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 00:22:41 +0000 Subject: [Koha-bugs] [Bug 22077] Uncaught JS Console errors In-Reply-To: <bug-22077-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22077-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22077-70-0sM1CkbXVp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22077 --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86700&action=edit Bug 22077: Make sure there were not JS errors on running selenium tests We could move that code to t::lib::Selenium and add the subtest to all our selenium/*.t files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 01:25:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 00:25:26 +0000 Subject: [Koha-bugs] [Bug 22077] Uncaught JS Console errors In-Reply-To: <bug-22077-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22077-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22077-70-pWyENPkFUQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22077 --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- However https://github.com/mozilla/geckodriver/issues/284 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 01:29:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 00:29:14 +0000 Subject: [Koha-bugs] [Bug 22430] importing from a UNIMARC backup will import biblio records but not items In-Reply-To: <bug-22430-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22430-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22430-70-XEntHoIR0j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22430 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 01:32:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 00:32:44 +0000 Subject: [Koha-bugs] [Bug 21832] Restore is_expired in ILS-DI GetPatronInfo service In-Reply-To: <bug-21832-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21832-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21832-70-j94WRDEN2T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21832 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 01:32:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 00:32:50 +0000 Subject: [Koha-bugs] [Bug 21832] Restore is_expired in ILS-DI GetPatronInfo service In-Reply-To: <bug-21832-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21832-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21832-70-0K1kB4SqeA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21832 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86243|0 |1 is obsolete| | --- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86701&action=edit Bug 21832: add is_expired to ILS-DI example Test plan : 1) Apply patch 2) Enable ILS-DI 3) Go to <opac URL>/cgi-bin/koha/ilsdi.pl?service=Describe&verb=GetPatronInfo 4) Check you see is_expired in example response Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 01:33:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 00:33:06 +0000 Subject: [Koha-bugs] [Bug 21832] Restore is_expired in ILS-DI GetPatronInfo service In-Reply-To: <bug-21832-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21832-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21832-70-qOhgE81t71@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21832 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 01:40:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 00:40:04 +0000 Subject: [Koha-bugs] [Bug 8775] Add collection code to lost report In-Reply-To: <bug-8775-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8775-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8775-70-NQx7rNKSjq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8775 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #17 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Jonathan Druart from comment #16) > Created attachment 86202 [details] [review] > Bug 8775: Use the AV mapped with items.ccode instead of CCODE > > Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> The newer method (GetDescriptionBYKOhaField) is nice because it caches, however, it does not currently return a value when the code does not match an authorised value. This patch also repeats the code and description when a description is found: [% item.ccode%][% AuthorisedValues.GetDescriptionByKohaField( kohafield => 'items.ccode', authorised_value => item.ccode ) | html %] Obsoleting the last patch here, please address using the new method and returning the code if no value found on another bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 01:40:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 00:40:35 +0000 Subject: [Koha-bugs] [Bug 8775] Add collection code to lost report In-Reply-To: <bug-8775-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8775-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8775-70-0GbvN0H8T4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8775 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86202|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 02:10:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 01:10:53 +0000 Subject: [Koha-bugs] [Bug 8775] Add collection code to lost report In-Reply-To: <bug-8775-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8775-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8775-70-k7hj7oqDtt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8775 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #18 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 02:11:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 01:11:09 +0000 Subject: [Koha-bugs] [Bug 15911] Use noEnterSubmit CSS class instead of prevent_submit.js In-Reply-To: <bug-15911-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15911-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15911-70-l8s1qYRhFv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15911 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #7 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 02:11:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 01:11:28 +0000 Subject: [Koha-bugs] [Bug 21070] request.pl details links to biblio instead of moredetail.pl for that item In-Reply-To: <bug-21070-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21070-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21070-70-PwLaasoR2M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21070 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 10:16:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 09:16:53 +0000 Subject: [Koha-bugs] [Bug 21983] Deleting a bib does not delete a request's link to it - missing foreign key In-Reply-To: <bug-21983-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21983-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21983-70-Sgq34yZbe0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I am not sure about this one, as we have deleted_biblio that is often useful for reporting. I imagine some libraries will want to remove ILL records from the catalog once the request is finished, but might still want to have the bibliographic information for reporting. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 10:25:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 09:25:15 +0000 Subject: [Koha-bugs] [Bug 22487] Add Mana and Bugzilla components on bugzilla In-Reply-To: <bug-22487-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22487-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22487-70-y6oVCaiZx8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22487 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Jonathan Druart from comment #4) > (In reply to Katrin Fischer from comment #2) > > For Mana I was thinking of the code outside of Koha. Not sure how to handle > > that best. I wanted to report 'improve the email sent by Mana' (bug 22488) > > The code is at https://git.biblibre.com/biblibre/koha-mana and, I think, > should be moved to gitlab. And so we would use the bug tracker of the > project. Agreed, we should move it to the central repository as a community project. I'd be ok with using the issue tracker too, but in the past we have made a point about not forcing users to have many accounts. Keeping an option to report here too might be in line with that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 10:35:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 09:35:24 +0000 Subject: [Koha-bugs] [Bug 18666] Update 16.06.00.028 failing because of missing no_auto_renewal_after In-Reply-To: <bug-18666-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18666-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18666-70-Nev17MGVEd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18666 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WONTFIX --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- We should have fixed it... but we haven't. I think closing now as WONTFIX makes sense as the versions affected are no longer maintained. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 10:49:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 09:49:58 +0000 Subject: [Koha-bugs] [Bug 3561] add ISSN to New Order Catalogue Details input In-Reply-To: <bug-3561-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-3561-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3561-70-OKZexsi5SZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3561 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- This can be achieved now with the UseACQFrameworkForBiblioRecords and MARC framework configuration. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 10:53:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 09:53:47 +0000 Subject: [Koha-bugs] [Bug 3707] Add system preference for customization of the OPAC login page In-Reply-To: <bug-3707-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-3707-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3707-70-9SePSWvSWQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3707 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think this was resolved by adding OpacLoginInstructions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 10:56:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 09:56:25 +0000 Subject: [Koha-bugs] [Bug 6533] Option to exclude cover images when printing lists In-Reply-To: <bug-6533-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6533-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6533-70-qsnTP0tzcH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6533 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Enhancement: Printer |Option to exclude cover |Friendly Lists |images when printing lists -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 10:57:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 09:57:59 +0000 Subject: [Koha-bugs] [Bug 6532] Way to move items to another record in batches In-Reply-To: <bug-6532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6532-70-vrgJM4fUEo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6532 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|way to move items to |Way to move items to |another record in batches |another record in batches --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Still valid. At the moment there is no batch process for moving items. What would be the use cases? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 11:04:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 10:04:06 +0000 Subject: [Koha-bugs] [Bug 6508] Enhancement: Additional Information on the Fines & Charges Tab in the Patron Details of Staff Client In-Reply-To: <bug-6508-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6508-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6508-70-xgTw34XyqZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Component|Staff Client |Fines and fees --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I really like Hene's idea of having the amount on the tab or at least some sign of existing fines as that would match the other tabs. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 11:04:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 10:04:53 +0000 Subject: [Koha-bugs] [Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name In-Reply-To: <bug-6508-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6508-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6508-70-W3M0NeZbcH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Enhancement: Additional |Show indication of existing |Information on the Fines & |'Fines & Charges' on tab of |Charges Tab in the Patron |the same name |Details of Staff Client | -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 11:09:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 10:09:14 +0000 Subject: [Koha-bugs] [Bug 6507] 'Renew all' from self checkout In-Reply-To: <bug-6507-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6507-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6507-70-xIp1Nw6Qmu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6507 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Renew ALL from self |'Renew all' from self |checkout |checkout CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Still valid. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 11:12:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 10:12:13 +0000 Subject: [Koha-bugs] [Bug 7224] Allow patrons to pick their own preferred language In-Reply-To: <bug-7224-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7224-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7224-70-zl7omilAGl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7224 Bug 7224 depends on bug 6481, which changed state. Bug 6481 Summary: Koha doesn't have a way to set a preferred language from system https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6481 What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 11:12:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 10:12:13 +0000 Subject: [Koha-bugs] [Bug 6481] Koha doesn't have a way to set a preferred language from system In-Reply-To: <bug-6481-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6481-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6481-70-U9hGa1EfCF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6481 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- >The explanation of those two variable tells they set a default, but how can they >claim to set a default language if 'value' holds a list of possibilities and >there is no way to arrange it's order? It's possible now to change the order with simple drag and drop. I think this resolves the issue of picking the default as it will be the first language in the list. Please reopen, if I am missing something. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 11:15:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 10:15:32 +0000 Subject: [Koha-bugs] [Bug 6456] Display of barcode in search results in staff client In-Reply-To: <bug-6456-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6456-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6456-70-mkcqubWYqn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6456 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Display of barcode in |Display of barcode in |search result in staff |search results in staff |client |client --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- The link to the screenshot is broken. We currently don't display the barcode in a lot of places. Most of the time the callnumber is displayed which helps identify items in most libraries sufficiently. I think displaying more information on the result list in staff might make the list harder to read - maybe this could be a configuration option where you pick what to display for each item? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 11:23:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 10:23:21 +0000 Subject: [Koha-bugs] [Bug 6424] Configure default sorting of result lists by material type In-Reply-To: <bug-6424-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6424-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6424-70-Us2ZS9eTgO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6424 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|would be nice if there were |Configure default sorting |a way to have searches for |of result lists by material |diff materials do diff |type |things | --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I am not sure how this one could be done. I guess this would not work for 'mixed' result lists, but only if you manage a search that brings up only one sort of material. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 11:25:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 10:25:18 +0000 Subject: [Koha-bugs] [Bug 6423] Add permission for editing other library's items In-Reply-To: <bug-6423-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6423-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6423-70-0OmD6SGOOX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6423 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Permission for editing |Add permission for editing |other library's stuff |other library's items --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- As this talks about cataloguing I think what was meant is something like edit_items_all. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 11:27:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 10:27:08 +0000 Subject: [Koha-bugs] [Bug 6422] Editable help files for OPAC In-Reply-To: <bug-6422-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6422-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6422-70-aHQjwHeRSO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6422 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15326 Summary|help files for the OPAC |Editable help files for | |OPAC CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Bug 15326 allowing to add additional pages to the OPAC might be helpful here. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 11:27:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 10:27:08 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15326-70-B5zNaN5OMY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=6422 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 11:32:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 10:32:04 +0000 Subject: [Koha-bugs] [Bug 6421] ability to have different opac styles for different libraries In-Reply-To: <bug-6421-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6421-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6421-70-7CXs2S9qsk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6421 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Reading through the bug comments this appears to be resolved by different options to add CSS that is different depending on the library. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 11:32:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 10:32:15 +0000 Subject: [Koha-bugs] [Bug 6421] ability to have different opac styles for different libraries In-Reply-To: <bug-6421-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6421-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6421-70-UiNGOZ0r0K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6421 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=6795 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 11:32:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 10:32:15 +0000 Subject: [Koha-bugs] [Bug 6795] Library-specific OPAC preferences In-Reply-To: <bug-6795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6795-70-ZjkH6Gujcw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6795 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=6421 -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 11:33:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 10:33:50 +0000 Subject: [Koha-bugs] [Bug 6419] Add customizable areas to serials and acq start pages In-Reply-To: <bug-6419-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6419-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6419-70-jbbvU8H0PW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6419 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|link to reports from other |Add customizable areas to |pages |serials and acq start pages -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 11:35:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 10:35:59 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18823-70-gAN2uncl5v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=6393 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 11:35:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 10:35:59 +0000 Subject: [Koha-bugs] [Bug 6393] Ability to pick which records to import from staged record lists In-Reply-To: <bug-6393-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6393-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6393-70-YA8QmgXGvg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6393 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=18823 Summary|ability to edit staged |Ability to pick which |records |records to import from | |staged record lists CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- This suggests 2 things: Allow editing of staged records: Will be resolved by bug 18823. Ability to pick records to import: Changing bug title to cover this. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 11:37:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 10:37:33 +0000 Subject: [Koha-bugs] [Bug 6383] itemnumber not stored when a lost item is returned and credited to account In-Reply-To: <bug-6383-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6383-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6383-70-SUAgGKNdeL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6383 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Component|Circulation |Fines and fees -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 11:39:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 10:39:56 +0000 Subject: [Koha-bugs] [Bug 6381] Add script to populate 856$q field based on contents of 856$u In-Reply-To: <bug-6381-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6381-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6381-70-TEIsL5LzNN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6381 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|New script needed to |Add script to populate |populate 856$q field based |856$q field based on |on contents of 856$u |contents of 856$u CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Wondering if this would be useful as a catalouging plugin/value builder too. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 11:42:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 10:42:09 +0000 Subject: [Koha-bugs] [Bug 6354] Show MARC labels on a per user basis while cataloguing In-Reply-To: <bug-6354-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6354-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6354-70-yPBIGnbA07@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6354 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|show marc labels on a per |Show MARC labels on a per |user basis |user basis while | |cataloguing --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I wonder if this could be closed not that we also have the advanced cataloguing editor as an option? -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 11:44:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 10:44:28 +0000 Subject: [Koha-bugs] [Bug 6344] Hold priority displayed incorrectly when "Toggle Lowest Priority" option is used In-Reply-To: <bug-6344-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6344-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6344-70-ZrN1eAuAf0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6344 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- This appears to have been fixed! -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 11:45:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 10:45:48 +0000 Subject: [Koha-bugs] [Bug 6341] Allow use of other non-Gregorian calendars In-Reply-To: <bug-6341-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6341-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6341-70-T29G1qd62e@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6341 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Request for multiple |Allow use of other |calendar support option |non-Gregorian calendars -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 11:47:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 10:47:25 +0000 Subject: [Koha-bugs] [Bug 6339] ExtendedPatronAttributes to allow for fields of date type In-Reply-To: <bug-6339-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6339-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6339-70-b8z75zEn15@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6339 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ExtendedPatronAttributes to |ExtendedPatronAttributes to |allow for a DatePicker (JS |allow for fields of date |Calendar) style field |type -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 11:49:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 10:49:33 +0000 Subject: [Koha-bugs] [Bug 6252] Patron import tool should let you set messaging preferences In-Reply-To: <bug-6252-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6252-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6252-70-3w2FiCfvUA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6252 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Currently the import script will use the defaults from the patron category of the imported patron. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 11:52:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 10:52:09 +0000 Subject: [Koha-bugs] [Bug 6204] "Latest Issues" ordering In-Reply-To: <bug-6204-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6204-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6204-70-kE5GgkZ16I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6204 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |WORKSFORME --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I am assuming that this refers to serial issues and how they are displayed in the OPAC. Recently there was a change there about the sorting and in my testing it shows like described below, in my case: 4 3 2 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 11:57:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 10:57:09 +0000 Subject: [Koha-bugs] [Bug 21983] Deleting a bib does not delete a request's link to it - missing foreign key In-Reply-To: <bug-21983-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21983-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21983-70-dDk3CxGyzj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 --- Comment #5 from Magnus Enger <magnus at libriotech.no> --- (In reply to Katrin Fischer from comment #4) > I am not sure about this one, as we have deleted_biblio that is often useful > for reporting. I imagine some libraries will want to remove ILL records from > the catalog once the request is finished, but might still want to have the > bibliographic information for reporting. I can confirm that this is indeed very true, yes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 11:59:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 10:59:10 +0000 Subject: [Koha-bugs] [Bug 6175] Mismatch between auth_subfield_structure and authorised_values data type - varchar(32) vs. varchar(10) In-Reply-To: <bug-6175-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6175-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6175-70-urLN6xkv5U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6175 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Mismatch between |Mismatch between |marc_subfield_structure and |auth_subfield_structure and |authorised_values tables |authorised_values data type | | - varchar(32) vs. | |varchar(10) --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- marc_subfield_structure `authorised_value` varchar(32) COLLATE utf8mb4_unicode_ci DEFAULT NULL, auth_subfield_structure `authorised_value` varchar(10) COLLATE utf8mb4_unicode_ci DEFAULT NULL, authorised_value_categories `category_name` varchar(32) COLLATE utf8mb4_unicode_ci NOT NULL DEFAULT '', authorised_values `category` varchar(32) COLLATE utf8mb4_unicode_ci NOT NULL DEFAULT '', I think there is still a issue for the auth_subfield_structure. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 12:06:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 11:06:29 +0000 Subject: [Koha-bugs] [Bug 6509] Display information on when an item was marked lost on checkout history page In-Reply-To: <bug-6509-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6509-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6509-70-QmbUrUxInP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6509 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Enhancement: More |Display information on when |Information on Patron Fines |an item was marked lost on |Tab in Staff Client |checkout history page CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- > 1. List the due date anywhere on the patrons fine info for an item, > perhaps as a distinct column or just in the description of charges? (see > screenshot PatronFinesTab for current display) The due date now has it's own sortable columnon this view. > 2. In the Item Checkout History, "Checkin on" is not specific enough as a > descriptor since it could refer to either when an item was checked in or > when it was marked lost. An additional column could indicate the > circumstance under which this date occurred. (see screenshot) I tested this and there is no indicator on the page that the item was lost. I am changing the bug title to reflect this. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 12:11:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 11:11:14 +0000 Subject: [Koha-bugs] [Bug 5591] marc 530$u should be a link In-Reply-To: <bug-5591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-5591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5591-70-0x4bJyEToo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5591 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- This has been fixed, all MARC notes fields with $u now show with working links on the description tab. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 12:13:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 11:13:15 +0000 Subject: [Koha-bugs] [Bug 5592] circ rule cloning can be dangerous In-Reply-To: <bug-5592-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-5592-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5592-70-goDmxiKoER@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5592 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |MOVED Status|NEW |RESOLVED --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- - confirmation step has been added - Bug 16544 - Changes to circ rules should be logged deals with logging/backup Closing this as RESOLVED MOVED. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 12:15:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 11:15:03 +0000 Subject: [Koha-bugs] [Bug 5539] Add suggestion emails to messaging preferences In-Reply-To: <bug-5539-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-5539-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5539-70-YvAeVwm92L@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5539 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Options for Suggestion |Add suggestion emails to |Emails |messaging preferences -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 12:32:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 11:32:07 +0000 Subject: [Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines In-Reply-To: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14591-70-hSchEzgp8I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 --- Comment #32 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Where is the test plan here? I am trying to determine if this will also help fixing: Bug 12144 - Book drop mode mode erasing fine when CalculateFinesOnReturn is enabled Bug 8338 - fines not cleared with dropbox mode -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 12:33:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 11:33:20 +0000 Subject: [Koha-bugs] [Bug 13044] Deprecate old book drop mode In-Reply-To: <bug-13044-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13044-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13044-70-jclA81IsvA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13044 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=8338, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9800, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14516, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19930 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 12:33:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 11:33:20 +0000 Subject: [Koha-bugs] [Bug 8338] fines not cleared with dropbox mode In-Reply-To: <bug-8338-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8338-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8338-70-hCnx7VwZ3z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8338 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13044 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 12:33:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 11:33:20 +0000 Subject: [Koha-bugs] [Bug 9800] way to suppress alerts in dropbox mode In-Reply-To: <bug-9800-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9800-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9800-70-f8XUGtIVqZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9800 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13044 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 12:33:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 11:33:20 +0000 Subject: [Koha-bugs] [Bug 14516] Dropbox mode barcode input has odd coloring (alert class css) In-Reply-To: <bug-14516-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14516-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14516-70-4yYTypQAvs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14516 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13044 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 12:33:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 11:33:20 +0000 Subject: [Koha-bugs] [Bug 19930] Dropbox mode statistical report In-Reply-To: <bug-19930-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19930-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19930-70-5dHLf8hVqk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19930 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13044 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 12:38:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 11:38:34 +0000 Subject: [Koha-bugs] [Bug 19745] Add Edit button for all the areas in circulation and fines rules In-Reply-To: <bug-19745-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19745-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19745-70-oAE8c45221@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19745 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|unspecified |master Summary|Add Edit button for all the |Add Edit button for all the |boards in circulation and |areas in circulation and |fines rules |fines rules --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- +1 Some only allow overwriting and that will require multiple fields to be reentered even if you only want to change one value. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 12:38:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 11:38:53 +0000 Subject: [Koha-bugs] [Bug 19745] Add Edit button for all the areas in circulation and fines rules In-Reply-To: <bug-19745-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19745-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19745-70-IWn23P5ZHX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19745 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Circulation |System Administration -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 12:41:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 11:41:33 +0000 Subject: [Koha-bugs] [Bug 19747] No help page linked for article requests In-Reply-To: <bug-19747-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19747-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19747-70-GwFOW2nZUU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19747 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Clicking 'Help' on |No help page linked for |request-article.pl yields |article requests |no help page. | --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- We could link to this page now: https://koha-community.org/manual//18.11/en/html/circulation.html#article-requests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 12:45:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 11:45:10 +0000 Subject: [Koha-bugs] [Bug 14516] Dropbox mode barcode input has odd coloring (alert class css) In-Reply-To: <bug-14516-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14516-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14516-70-osvAQD1bei@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14516 --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Owen, could you take a look here maybe? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 12:45:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 11:45:30 +0000 Subject: [Koha-bugs] [Bug 14516] Dropbox mode barcode input has odd coloring (alert class css) In-Reply-To: <bug-14516-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14516-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14516-70-GevVrb390y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14516 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |oleonard at myacpl.org Component|Circulation |Templates Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 12:54:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 11:54:25 +0000 Subject: [Koha-bugs] [Bug 19747] No help page linked for article requests In-Reply-To: <bug-19747-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19747-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19747-70-ojIZk1OQKc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19747 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | Version|17.11 |master Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 12:55:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 11:55:52 +0000 Subject: [Koha-bugs] [Bug 19747] No help page linked for article requests In-Reply-To: <bug-19747-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19747-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19747-70-ktaxSzIQH7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19747 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 12:55:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 11:55:55 +0000 Subject: [Koha-bugs] [Bug 19747] No help page linked for article requests In-Reply-To: <bug-19747-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19747-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19747-70-7exGNpm5wf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19747 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 86702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86702&action=edit Bug 19747: Add link to article requests help page Newer manuals contain information about article requests. This patch adds the link to the article request section in the manual. To test: - Activate ArticleRequests system preference - Go to Circulation > Article requests - Click on Help - Verify that you end up in the proper section of the manual -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 12:59:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 11:59:44 +0000 Subject: [Koha-bugs] [Bug 22174] Add link to help page for API key management In-Reply-To: <bug-22174-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22174-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22174-70-nsJwZ5vtLW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22174 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add specific help link to |Add link to help page for |/cgi-bin/koha/members/apike |API key management |ys.pl | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 12:59:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 11:59:54 +0000 Subject: [Koha-bugs] [Bug 22174] Add link to help page for API key management In-Reply-To: <bug-22174-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22174-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22174-70-JRw32skdMc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22174 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 13:04:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 12:04:06 +0000 Subject: [Koha-bugs] [Bug 22174] Add link to help page for API key management In-Reply-To: <bug-22174-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22174-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22174-70-cwhcSsVBe4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22174 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 13:04:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 12:04:09 +0000 Subject: [Koha-bugs] [Bug 22174] Add link to help page for API key management In-Reply-To: <bug-22174-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22174-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22174-70-dfGp5skkgE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22174 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 86703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86703&action=edit Bug 22174: Add link to help page for API key management Makes the help link on the API key management page point to the proper section in the Koha manual. To test: - Activate RESTOAuth2ClientCredentials system preference - Go to any patron account - Go to More > Manage API keys - Click on the Help link in top right corner - Verify that the right section of the Koha manual displays -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 13:24:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 12:24:49 +0000 Subject: [Koha-bugs] [Bug 8701] Help for OpacHiddenItems pref should not point to text in install directory In-Reply-To: <bug-8701-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8701-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8701-70-tO8xqfOkAA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8701 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 13:24:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 12:24:52 +0000 Subject: [Koha-bugs] [Bug 8701] Help for OpacHiddenItems pref should not point to text in install directory In-Reply-To: <bug-8701-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8701-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8701-70-s37Fsos817@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8701 --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 86704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86704&action=edit Bug 8701: Remove links to OpacHiddenItems.txt in favor of wiki page Removes the OpacHiddenItems.txt file from Koha as this is not accessible for most people and replaces it with links to the wiki page like it's already done from the system preference editor. For reporting and the initial patch Thanks-to: Jane Sandberg <sandbej at linnbenton.edu> To test: - Changes are invisible from the GUI - Apply patch and run database update - SELECT * FROM systempreferences WHERE variable = "OpacHiddenItems"; - Verify the description has the wiki link - Verify that docs/opac/OpacHiddenItems.txt has been removed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 13:28:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 12:28:05 +0000 Subject: [Koha-bugs] [Bug 8701] Help for OpacHiddenItems pref should not point to text in install directory In-Reply-To: <bug-8701-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8701-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8701-70-gZlnxR8y9N@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8701 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86704|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 86705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86705&action=edit Bug 8701: Remove links to OpacHiddenItems.txt in favor of wiki page Removes the OpacHiddenItems.txt file from Koha as this is not accessible for most people and replaces it with links to the wiki page like it's already done from the system preference editor. For reporting and the initial patch Thanks-to: Jane Sandberg <sandbej at linnbenton.edu> To test: - Changes are invisible from the GUI - Apply patch and run database update - SELECT * FROM systempreferences WHERE variable = "OpacHiddenItems"; - Verify the description has the wiki link - Verify that docs/opac/OpacHiddenItems.txt has been removed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 13:28:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 12:28:18 +0000 Subject: [Koha-bugs] [Bug 8701] Help for OpacHiddenItems pref should not point to text in install directory In-Reply-To: <bug-8701-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8701-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8701-70-dKazNW7pDI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8701 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | CC| |katrin.fischer at bsz-bw.de --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- The system preference text has been fixed, there are only some occurences in dev type documentation now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 13:30:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 12:30:12 +0000 Subject: [Koha-bugs] [Bug 19842] help files on 17.05 point to http://manual.koha-community.org/, not https://koha-community.org/manual/17.05/html/ In-Reply-To: <bug-19842-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19842-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19842-70-m4r1GBI301@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19842 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 14:45:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 13:45:51 +0000 Subject: [Koha-bugs] [Bug 20128] Permission for advanced editor In-Reply-To: <bug-20128-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20128-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20128-70-cDTe8FyW6G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20128 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86543|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 86706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86706&action=edit Bug 20128: Add permission for advanced cataloging editor To test: 1 - Have a borrower with edit_catalogue permission and one with editcatalogue top level 2 - Confirm they can both access the advanced editor from the 'Cataloguing' home page or from the basic editor 3 - Apply patch 4 - Update database 5 - Confirm borrower with 'edit_catalogue' has 'advanced_editor' permission 6 - Confirm borrowers can access advanced editor as above 7 - Remove 'advanced_editor' permission from borrower 8 - Ensure they cannot access the advanced editor 9 - Ensure links to 'Edit record' from search results go to basic editor Signed-off-by: Liz Rea <wizzyrea at gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 14:45:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 13:45:54 +0000 Subject: [Koha-bugs] [Bug 20128] Permission for advanced editor In-Reply-To: <bug-20128-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20128-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20128-70-xTPaH46n4n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20128 --- Comment #7 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 86707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86707&action=edit Bug 20128: Problem when checking individual perms where borrower has top level -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 14:47:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 13:47:08 +0000 Subject: [Koha-bugs] [Bug 20128] Permission for advanced editor In-Reply-To: <bug-20128-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20128-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20128-70-2idTrWbY6N@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20128 --- Comment #8 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Nick Clemens from comment #7) > Created attachment 86707 [details] [review] > Bug 20128: Problem when checking individual perms where borrower has top > level Martin, can you look here, I added a test to highlight the problem. If the user has all 'Edit catalogue' permissions then we get an error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 14:54:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 13:54:16 +0000 Subject: [Koha-bugs] [Bug 21832] Restore is_expired in ILS-DI GetPatronInfo service In-Reply-To: <bug-21832-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21832-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21832-70-ur0LJRwhGn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21832 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #21 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 14:54:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 13:54:36 +0000 Subject: [Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead) In-Reply-To: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21756-70-DfMduRI1zu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #117 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 14:54:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 13:54:59 +0000 Subject: [Koha-bugs] [Bug 22023] Further improve responsive layout handling of staff client menu bar In-Reply-To: <bug-22023-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22023-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22023-70-q8kNK3IWiT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22023 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #14 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 14:55:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 13:55:15 +0000 Subject: [Koha-bugs] [Bug 22454] Add Koha::Item::hidden_in_opac method In-Reply-To: <bug-22454-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22454-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22454-70-JRMjRGoJFk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22454 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 14:55:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 13:55:50 +0000 Subject: [Koha-bugs] [Bug 19417] Improve display of errors from background job during stage for import In-Reply-To: <bug-19417-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19417-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19417-70-0hJ1OFs2Qh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19417 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #16 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 16 14:55:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Mar 2019 13:55:32 +0000 Subject: [Koha-bugs] [Bug 22455] Add Koha::Biblio::hidden_in_opac method In-Reply-To: <bug-22455-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22455-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22455-70-Hbt3LFKDwq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22455 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #7 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 17 10:15:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Mar 2019 09:15:50 +0000 Subject: [Koha-bugs] [Bug 21003] Don't show warning when editing a reserve item In-Reply-To: <bug-21003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21003-70-NljgWiyQy5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21003 Devinim <kohadevinim at devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 17 10:15:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Mar 2019 09:15:53 +0000 Subject: [Koha-bugs] [Bug 21003] Don't show warning when editing a reserve item In-Reply-To: <bug-21003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21003-70-C6sYjm80FB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21003 Devinim <kohadevinim at devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86330|0 |1 is obsolete| | --- Comment #5 from Devinim <kohadevinim at devinim.com.tr> --- Created attachment 86708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86708&action=edit Bug 21003: Made Edit keywords more consistent in add_items-step2.tt When adding a course reserve with a barcode that already exists, the title, breadcrumbs, and legend of the form all specify that the user is editing, and not adding, the book. Test plan: Same as comment 1 Signed-off-by: Devinim <kohadevinim at devinim.com.tr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 17 12:03:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Mar 2019 11:03:29 +0000 Subject: [Koha-bugs] [Bug 20786] process_message_queue.pl and cron.hourly - multiple subroutine redefined errors In-Reply-To: <bug-20786-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20786-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20786-70-8hLvTdjW5g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20786 --- Comment #3 from mjnkml at gmail.com --- (In reply to Katrin Fischer from comment #2) > Hi, you are missing the --chdir on your cronjob definition, see bug 17717 or > here: > > http://git.koha-community.org/gitweb/?p=koha.git;a=commitdiff; > h=6db09ad3b070845539994ff4f1f8b9f7d6d2dfc8 > > *** This bug has been marked as a duplicate of bug 17717 *** Hi Katrin, I have chdir, but still get the noise: -----Original Message----- From: Cron Daemon Sent: Sunday, 17 March 2019 10:00 PM To: Me Subject: Cron <root at koha> koha-foreach --chdir --enabled --email /usr/share/koha/bin/cronjobs/process_message_queue.pl Subroutine _ATTRIBUTES redefined at /usr/share/perl5/Authen/CAS/Client/Response/Failure.pm line 13. Subroutine new redefined at /usr/share/perl5/Authen/CAS/Client/Response/Failure.pm line 15. Subroutine code redefined at /usr/share/perl5/Authen/CAS/Client/Response/Failure.pm line 17. Subroutine message redefined at /usr/share/perl5/Authen/CAS/Client/Response/Failure.pm line 18. Subroutine new redefined at /usr/share/perl5/Authen/CAS/Client/Response/Success.pm line 13. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 17 21:04:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Mar 2019 20:04:54 +0000 Subject: [Koha-bugs] [Bug 13763] Renew feature does not check for the BarcodeInputFilter option In-Reply-To: <bug-13763-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13763-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13763-70-aR0aNw150D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13763 --- Comment #5 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- (In reply to Bin from comment #4) > After applying the patch, it is still invalid Hi Bin, Can you please describe what you did, and what was the result? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 17 21:56:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Mar 2019 20:56:53 +0000 Subject: [Koha-bugs] [Bug 20929] koha-dump should not pass a --password argument to mysqldump In-Reply-To: <bug-20929-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20929-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20929-70-nxUgb1c4QO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20929 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #7 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- I prefer the simplicity of using ENV. If I was to use the .cnf file I would touch and chmod before putting information there just in case something goes wrong before the chmod. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 17 22:02:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Mar 2019 21:02:53 +0000 Subject: [Koha-bugs] [Bug 16817] Apply hold fee on collection not application In-Reply-To: <bug-16817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16817-70-gFUeE2ua7M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16817 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- HoldFeeMode can be set to "Charge hold fee 'anytime a hold is collected'". -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 17 22:10:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Mar 2019 21:10:29 +0000 Subject: [Koha-bugs] [Bug 19220] Allow XSLT processing for Z39.50 authority targets like for bibliographic targets In-Reply-To: <bug-19220-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19220-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19220-70-KMASXfb1GL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19220 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow XSLT procsessing for |Allow XSLT processing for |Z39.50 authority targets |Z39.50 authority targets |like for bibliographic |like for bibliographic |targets |targets -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 17 22:10:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Mar 2019 21:10:36 +0000 Subject: [Koha-bugs] [Bug 20431] Z3950ServerAuth does not contain code for add_xslt In-Reply-To: <bug-20431-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20431-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20431-70-FmbfGbQLJc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20431 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** This bug has been marked as a duplicate of bug 19220 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Mar 17 22:10:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Mar 2019 21:10:36 +0000 Subject: [Koha-bugs] [Bug 19220] Allow XSLT processing for Z39.50 authority targets like for bibliographic targets In-Reply-To: <bug-19220-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19220-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19220-70-8zGPYTPYo0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19220 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** Bug 20431 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Mar 17 22:14:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Mar 2019 21:14:52 +0000 Subject: [Koha-bugs] [Bug 13978] Add cancellation link to hold notification e-mails In-Reply-To: <bug-13978-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13978-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13978-70-OFT0zMxrfF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13978 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Hold notification e-mails |Add cancellation link to | |hold notification e-mails CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 17 22:14:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Mar 2019 21:14:58 +0000 Subject: [Koha-bugs] [Bug 12656] Send a notice to patrons when their hold was cancelled because it was not picked up In-Reply-To: <bug-12656-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12656-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12656-70-B0GLlWLVEe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12656 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Send a notice to patrons |Send a notice to patrons |when their hold was |when their hold was |cancelled |cancelled because it was | |not picked up -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 17 22:15:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Mar 2019 21:15:17 +0000 Subject: [Koha-bugs] [Bug 12656] Send a notice to patrons when their hold was cancelled because it was not picked up In-Reply-To: <bug-12656-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12656-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12656-70-QhKQKCnhjf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12656 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20453 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Mar 17 22:15:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Mar 2019 21:15:17 +0000 Subject: [Koha-bugs] [Bug 20453] Send notification when hold is cancelled by librarian In-Reply-To: <bug-20453-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20453-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20453-70-3qfn8wi24l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20453 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12656 CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 17 22:35:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Mar 2019 21:35:26 +0000 Subject: [Koha-bugs] [Bug 14576] Allow automatic update of location on checkin In-Reply-To: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14576-70-xIfIzE7iv0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Michal Denar <black23 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com --- Comment #110 from Michal Denar <black23 at gmail.com> --- Nick, can you rebase it again? I get: Patch failed at 0001 Bug 14576: Allow arbitrary automatic update of location on checkin The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-14576-Allow-arbitrary-automatic-update-of-loca-9ePdA7.patch Thank you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 17 23:03:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Mar 2019 22:03:46 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18235-70-kEpHBQIWVi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 02:17:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 01:17:23 +0000 Subject: [Koha-bugs] [Bug 18888] Include the definition of currency in onboarding tool In-Reply-To: <bug-18888-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18888-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18888-70-QZ93aY7SmZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18888 --- Comment #8 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Created attachment 86709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86709&action=edit Bug 18888: (follow-up) Updated Currency onboarding step to match DB Between the time that this patch was originally created and now, a field has been added to the currency table which allows the user to specify whether the currency should appear with a space between the symbol and value. This patch updates the onboarding tool to accommodate that option, as well as cleans up some issues with script tags and duplicate entries to the DB. Test plan: 1) Drop and recreate your database, then restart_all 2) Go through the web installer and install all data except the currencies 3) Go through the onboarding tool and note that when you get to the currency page that there is no option for setting there to be a space between symbol and value 4) Apply the patch, and repeat step 1 and 2 5) Go through the onboarding tool again and this time note that on the currency page there is an option to set there to be a space between symbol and value - check this box. 6) Continue on to Koha 7) Apply a fine to a patron, log in as that patron, and verify that the currency is displayed with a space between the symbol and the value in the OPAC 8) Also verify that there is only one currency (the one you created) in the currency table in your database Note: This patch may fail the QA tools due to Asset not working with the installer. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 02:18:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 01:18:17 +0000 Subject: [Koha-bugs] [Bug 18888] Include the definition of currency in onboarding tool In-Reply-To: <bug-18888-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18888-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18888-70-o2i1LDsDZe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18888 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 02:18:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 01:18:20 +0000 Subject: [Koha-bugs] [Bug 18888] Include the definition of currency in onboarding tool In-Reply-To: <bug-18888-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18888-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18888-70-lHpmIpNtPN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18888 --- Comment #9 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Created attachment 86710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86710&action=edit Bug 18888: (follow-up) Fixed script tag for QA tools Removed type reference in the script tag in onboardingstep6.tt - Note: the QA tools will still fail this tag for using a full path rather than Asset. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 05:04:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 04:04:01 +0000 Subject: [Koha-bugs] [Bug 15794] Add emoji picker to tag entry in OPAC In-Reply-To: <bug-15794-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15794-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15794-70-WK3f1BZ2eZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #19 from David Cook <dcook at prosentient.com.au> --- The emoji picker is causing script errors when using Koha in Endnote X9. I think Endnote X9 uses an (old) embedded version of Internet Explorer, and I think that's why it's happening. Investigating ways of fixing it, but I think I might just send a follow-up about using a system preference to disable the emoji picker. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 06:48:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 05:48:17 +0000 Subject: [Koha-bugs] [Bug 15704] Split up 264 index In-Reply-To: <bug-15704-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15704-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15704-70-FE4fGcfczE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15704 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|split up 264 index |Split up 264 index -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 06:53:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 05:53:02 +0000 Subject: [Koha-bugs] [Bug 18205] REST interface to Koha::Logger In-Reply-To: <bug-18205-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18205-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18205-70-AuPDkDVIMo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18205 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit | |y.org | Component|Web services |REST api CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 06:53:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 05:53:45 +0000 Subject: [Koha-bugs] [Bug 19619] Add support for SIP2 field CM ( Hold Pickup Date ) to Koha In-Reply-To: <bug-19619-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19619-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19619-70-q3zyAIm9aH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19619 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell at ptfs-europe. | |com, | |katrin.fischer at bsz-bw.de Component|Architecture, internals, |SIP2 |and plumbing | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 06:54:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 05:54:31 +0000 Subject: [Koha-bugs] [Bug 20292] Filter/censor info sent via SIP In-Reply-To: <bug-20292-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20292-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20292-70-tYolJwT4bC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20292 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |colin.campbell at ptfs-europe. | |com, | |katrin.fischer at bsz-bw.de Component|Architecture, internals, |SIP2 |and plumbing | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 09:08:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 08:08:12 +0000 Subject: [Koha-bugs] [Bug 22497] '0' width can lead to an infinite loop. In-Reply-To: <bug-22497-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22497-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22497-70-LZinNGEFrN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22497 Christian Stelzenm?ller <christian.stelzenmueller at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christian.stelzenmueller at bs | |z-bw.de See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22462 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 09:08:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 08:08:12 +0000 Subject: [Koha-bugs] [Bug 22462] Crash in patron card printing In-Reply-To: <bug-22462-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22462-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22462-70-5BuvljONBF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22462 Christian Stelzenm?ller <christian.stelzenmueller at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22497 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 09:19:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 08:19:08 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20817-70-kdnKhyKcGl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Devinim <kohadevinim at devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 09:19:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 08:19:14 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20817-70-H8g5KzUKqT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Devinim <kohadevinim at devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80537|0 |1 is obsolete| | --- Comment #7 from Devinim <kohadevinim at devinim.com.tr> --- Created attachment 86711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86711&action=edit Bug 20817: Add ability to retain 9xx fields when adding on order item to existing record -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 10:01:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 09:01:03 +0000 Subject: [Koha-bugs] [Bug 22528] New: Add tab with current/active ILL requests to patron circulation page Message-ID: <bug-22528-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22528 Bug ID: 22528 Summary: Add tab with current/active ILL requests to patron circulation page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs at lists.koha-community.org Reporter: josef.moravec at gmail.com Target Milestone: --- Bug 18589 added ILL requests history page to patron account, it would be great to have access to current (not completed) ILL requests on circulation page as another tab - the same way we have access to holds and relatives checkouts. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 10:01:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 09:01:13 +0000 Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile In-Reply-To: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18589-70-VdHB2YYMVJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22528 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22528 [Bug 22528] Add tab with current/active ILL requests to patron circulation page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 10:01:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 09:01:13 +0000 Subject: [Koha-bugs] [Bug 22528] Add tab with current/active ILL requests to patron circulation page In-Reply-To: <bug-22528-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22528-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22528-70-SA1EHGPXPC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22528 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18589 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 [Bug 18589] Show ILLs as part of patron profile -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 10:35:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 09:35:19 +0000 Subject: [Koha-bugs] [Bug 21983] Deleting a bib does not delete a request's link to it - missing foreign key In-Reply-To: <bug-21983-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21983-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21983-70-qiXn1x0fLA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |In Discussion --- Comment #6 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- But it's just a foreign key to the (now deleted) bib ID, is that useful information that needs preserving? Sorry, genuine question, I'm not being facetious :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 11:05:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 10:05:19 +0000 Subject: [Koha-bugs] [Bug 22529] New: /svc/members/search relies on quirks of haspermission Message-ID: <bug-22529-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22529 Bug ID: 22529 Summary: /svc/members/search relies on quirks of haspermission Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Just parking this one here so we don't lose the comment from a closed bug 22483 >(In reply to Martin Renvoize from comment #0) >> This functionality was in use in two places. /svc/members/search and >> /Koha/REST/V1/Auth.pm. > > >About /svc/members/search: at first glance I think we should rewrite this code to adapt it, not the other way around. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 11:08:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 10:08:21 +0000 Subject: [Koha-bugs] [Bug 20786] process_message_queue.pl and cron.hourly - multiple subroutine redefined errors In-Reply-To: <bug-20786-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20786-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20786-70-IxIo22t3eI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20786 mjnkml at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|DUPLICATE |--- Status|RESOLVED |REOPENED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 11:33:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 10:33:10 +0000 Subject: [Koha-bugs] [Bug 17509] Notify patrons to return items requested on hold by another person In-Reply-To: <bug-17509-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17509-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17509-70-HXul93VCBP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 --- Comment #60 from Josef Moravec <josef.moravec at gmail.com> --- Comment on attachment 86369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86369 Bug 17509: (follow-up) Logic moved from C4 to Koha namespace Review of attachment 86369: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=17509&attachment=86369) ----------------------------------------------------------------- ::: C4/Reserves.pm @@ +268,2 @@ > foreach my $borrower (@borrowers) { > + if ( !$borrower->email ) { should be ->first_valid_email_address @@ +292,3 @@ > message_transport_type => 'email', > from_address => $admin_email_address, > + to_address => $borrower->email, should be ->first_valid_email_address ::: Koha/Hold.pm @@ +330,5 @@ > +Returns Koha::Patron objects able to return item to satisfy this Hold > + > +=cut > + > +sub borrowers_to_satisfy { Should be called "patrons_..." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 11:34:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 10:34:48 +0000 Subject: [Koha-bugs] [Bug 22491] Patrons should be searchable by surname In-Reply-To: <bug-22491-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22491-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22491-70-Fx19z7Oy3r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22491 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 11:54:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 10:54:41 +0000 Subject: [Koha-bugs] [Bug 22492] Advanced editor - Rancor - AdditionalFieldsInZ3950ResultSearch In-Reply-To: <bug-22492-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22492-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22492-70-HSEYe3YSV3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22492 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 11:54:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 10:54:53 +0000 Subject: [Koha-bugs] [Bug 22494] When adding a library group with an already existing name, an ugly error is displayed In-Reply-To: <bug-22494-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22494-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22494-70-twz34ESSfy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22494 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 11:59:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 10:59:38 +0000 Subject: [Koha-bugs] [Bug 22499] Itemcallnumber "0" not displayed In-Reply-To: <bug-22499-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22499-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22499-70-KlRvrd6vnM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22499 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Version|17.11 |master --- Comment #1 from Josef Moravec <josef.moravec at gmail.com> --- In current master it is even worse - "0" is not saved in item record -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 12:05:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 11:05:55 +0000 Subject: [Koha-bugs] [Bug 22513] Anonymize old ILL requests In-Reply-To: <bug-22513-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22513-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22513-70-dV6g65fQst@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22513 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 12:06:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 11:06:16 +0000 Subject: [Koha-bugs] [Bug 22514] Hardcoded value of 10 for return hour when calculating hourly loans affected by holidays In-Reply-To: <bug-22514-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22514-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22514-70-rwNWCYtpiy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22514 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 12:10:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 11:10:29 +0000 Subject: [Koha-bugs] [Bug 22507] Modification of the Holds Slip In-Reply-To: <bug-22507-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22507-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22507-70-ujFzFMlX44@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22507 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com --- Comment #2 from Josef Moravec <josef.moravec at gmail.com> --- I do think you can do much with setting HOLD_SLIP notices. Give a try to this: https://wiki.koha-community.org/wiki/Notices_and_Slips_Library#Hold_slip_using_only_Template_Toolkit -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 12:12:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 11:12:38 +0000 Subject: [Koha-bugs] [Bug 22522] API authentication breaks with updated Mojolicious version In-Reply-To: <bug-22522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22522-70-9hB9SRK0VT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 12:14:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 11:14:08 +0000 Subject: [Koha-bugs] [Bug 22529] /svc/members/search relies on quirks of haspermission In-Reply-To: <bug-22529-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22529-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22529-70-BW3IcroOIJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22529 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 12:45:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 11:45:58 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit In-Reply-To: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22511-70-B9lZXGkx0X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> --- This needs a bit of UI logic so new voided payments and old VOID types look the same in the UI. In addition, it would make sends to update accoulines with an accounttype of VOID to also have a status of VOID. Since future voided payments will retain the original accountype, it would be reasonable for Koha to show the original account type *and* show that it was voided. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 12:56:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 11:56:11 +0000 Subject: [Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines In-Reply-To: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14591-70-NEWTFYdDly@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 --- Comment #33 from Kyle M Hall <kyle at bywatersolutions.com> --- Yes, I do believe both of those can be closed in some form ( duplicates? ). This bug fixes the issues related to those two bugs. (In reply to Katrin Fischer from comment #32) > Where is the test plan here? > > I am trying to determine if this will also help fixing: > > Bug 12144 - Book drop mode mode erasing fine when CalculateFinesOnReturn is > enabled > Bug 8338 - fines not cleared with dropbox mode -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 13:26:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 12:26:29 +0000 Subject: [Koha-bugs] [Bug 13763] Renew feature does not check for the BarcodeInputFilter option In-Reply-To: <bug-13763-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13763-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13763-70-WKzET7A8Xi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13763 --- Comment #6 from Bin <bin.wen at inlibro.com> --- (In reply to Hayley Mapley from comment #5) > (In reply to Bin from comment #4) > > After applying the patch, it is still invalid > > Hi Bin, > > Can you please describe what you did, and what was the result? I followed the test plan: Test plan: 1) In Circulation->Renew, enter a barcode that you know exists in the catalogue but add extra spaces, breaking up the barcode. Note that this fails with a warning that says 'No item matches this barcode' 2) In system Preferences, set the itemBarcodeFilter pref to Remove spaces and repeat step1. Note that the result is the same as in step 1 3) Apply the patch but still failed with a warning that said 'No item matches this barcode' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 13:43:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 12:43:14 +0000 Subject: [Koha-bugs] [Bug 22516] accountlines.lastincrement can be removed In-Reply-To: <bug-22516-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22516-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22516-70-tcSQJFoh36@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22516 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 13:43:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 12:43:17 +0000 Subject: [Koha-bugs] [Bug 22516] accountlines.lastincrement can be removed In-Reply-To: <bug-22516-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22516-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22516-70-qM7zHZ56uS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22516 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86662|0 |1 is obsolete| | Attachment #86663|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 86712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86712&action=edit Bug 22516: Remove remaining calls to lastincrement A few places still set lastincrement and the tests still checked for correct values. But nowhere in the code still uses lastincrement for anything meaningful. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 13:43:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 12:43:26 +0000 Subject: [Koha-bugs] [Bug 22516] accountlines.lastincrement can be removed In-Reply-To: <bug-22516-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22516-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22516-70-Tfh8Tuv3Rn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22516 --- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 86713 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86713&action=edit Bug 22516: Database update Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 13:50:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 12:50:26 +0000 Subject: [Koha-bugs] [Bug 7812] Add markup to staff client templates to increase customization options In-Reply-To: <bug-7812-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7812-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7812-70-lkUqe24vdh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7812 --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- I can tell by the screenshot and the fact that I don't remember this bug that it was filed a while ago! It is still valid, and it's unfortunate I didn't take it into account while doing the Bootstrap grid upgrades :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 14:02:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 13:02:42 +0000 Subject: [Koha-bugs] [Bug 20360] Auto-Renew notices send in advance of No Renewal Before period In-Reply-To: <bug-20360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20360-70-J8FB9qwGDw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20360 Bj?rn Nyl?n <bjorn.nylen at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bjorn.nylen at ub.lu.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 14:11:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 13:11:21 +0000 Subject: [Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future In-Reply-To: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19014-70-bSIXzRyALf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Bj?rn Nyl?n <bjorn.nylen at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bjorn.nylen at ub.lu.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 14:10:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 13:10:58 +0000 Subject: [Koha-bugs] [Bug 20360] Auto-Renew notices send in advance of No Renewal Before period In-Reply-To: <bug-20360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20360-70-V9daIcwEEJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20360 --- Comment #7 from Bj?rn Nyl?n <bjorn.nylen at ub.lu.se> --- (In reply to David Cook from comment #6) > I have a solution which will live in the automatic_renewals.pl script. > > It'll essentially borrow the code from #22333 but put it into > automatic_renewals.pl wrapped with a system preference so that the first > thing automatic_renewals.pl does is check if it's too early to renew (ie > consult No Renewal Before or fallback to checking if it's before the due > date). > > I think this should be a good solution. > > Just trialing it locally first. Hi David! This is how we would like it to work too. (We = Lund university :) ) We'd be happy to test your patch when you think it's ready! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 14:34:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 13:34:32 +0000 Subject: [Koha-bugs] [Bug 22530] New: Koha::Charges::Fees-?accumulate_rentalcharge dies if no issuingrule is found Message-ID: <bug-22530-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22530 Bug ID: 22530 Summary: Koha::Charges::Fees-?accumulate_rentalcharge dies if no issuingrule is found Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- We are checking to see the rental fee for an item, but assume that a rule was found 101 my $units = $issuing_rule->lengthunit; 102 my $rentalcharge_increment = ( $units eq 'days' ) ? $itemtype->rentalcharge_daily : $itemtype->rentalcharge_hourly; we should set the unit to 'days' if no rule found or simply return 0 (no charge if you aren't allowed to issue) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 14:34:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 13:34:40 +0000 Subject: [Koha-bugs] [Bug 22530] Koha::Charges::Fees-?accumulate_rentalcharge dies if no issuingrule is found In-Reply-To: <bug-22530-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22530-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22530-70-PIM5n7P8Ih@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22530 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 14:46:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 13:46:54 +0000 Subject: [Koha-bugs] [Bug 14293] Error in the calculation of the suspension of users per day In-Reply-To: <bug-14293-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14293-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14293-70-JIIVf6NNbJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14293 --- Comment #27 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- (In reply to Katrin Fischer from comment #26) > I think we could use the "when to charge" parameter for this as it's the > same problem as with fines. It allows to charge at the beginning of the > interval (charge first day) or at the end (charge after 2 days). This way > the behavior would be configurable and we even have the option already. > > What do you think? Agreed :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 14:49:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 13:49:40 +0000 Subject: [Koha-bugs] [Bug 22526] The circulation rules table does not exist In-Reply-To: <bug-22526-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22526-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22526-70-xHUgN4fasv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22526 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #5 from Owen Leonard <oleonard at myacpl.org> --- This sounds like a support request rather than a bug. Questions about Koha should be asked on the Koha mailing list (http://koha-community.org/support/koha-mailing-lists/) or in the #koha IRC channel (http://koha-community.org/get-involved/irc/). Hopefully you've already seen the Koha documentation: http://koha-community.org/documentation/ You can also find options for paid support here: https://koha-community.org/support/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 15:11:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 14:11:39 +0000 Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile In-Reply-To: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18589-70-cOhqj33RhA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 --- Comment #27 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86715&action=edit Bug 18589: (follow-up) Remove redundant-ness Following feedback from Josef via IRC, removing redundant code Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 15:11:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 14:11:43 +0000 Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile In-Reply-To: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18589-70-tFVwJDYRQb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 --- Comment #28 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86716&action=edit Bug 18589: (follow-up) Fix QA tool failures As per comment #17: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589#c17 Sorry Josef, I honestly have no idea where those tabs came from :( Every once in a while my copy of Vim decides to embarass me and stick in tabs instead of spaces... <shakes fist at screen> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 15:11:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 14:11:47 +0000 Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile In-Reply-To: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18589-70-9LEHGLDx8Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 --- Comment #29 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86717&action=edit Bug 18589: (follow-up) Add borrowernumber test As per comment #21: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589#c21 We now test borrowernumber filter works. This test has come from https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=83184&action=diff and will be removed from that bug Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 15:11:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 14:11:51 +0000 Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile In-Reply-To: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18589-70-WCEeU2OrMP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 --- Comment #30 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86718&action=edit Bug 18589: (follow-up) Fix merge problem Date format setting got lost in the merge As per item 1) in comment #20: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589#c20 Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 15:11:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 14:11:55 +0000 Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile In-Reply-To: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18589-70-Ahnu8CpR4S@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 --- Comment #31 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86719&action=edit Bug 18589: (follow-up) Fix merge problem Bug in passing row to getStatusName As per item 3) in comment #20: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589#c20 Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 15:11:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 14:11:35 +0000 Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile In-Reply-To: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18589-70-QHPfuHNaiZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86433|0 |1 is obsolete| | Attachment #86456|0 |1 is obsolete| | Attachment #86465|0 |1 is obsolete| | Attachment #86504|0 |1 is obsolete| | Attachment #86506|0 |1 is obsolete| | Attachment #86507|0 |1 is obsolete| | --- Comment #26 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86714 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86714&action=edit Bug 18589: Show ILLs as part of patron profile This patch moves the display of a patron's ILL requests to be inline in the Patron Profile page, as per all other patron information. It includes a substantial refactor of koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt in that it moves the display of the illlist table (which is populated by an API request) into it's own separate include file. It also moves the datatable related Javascript for this table into it's own JS file. Doing this allows us to reuse both in both the new members/ill-requests.tt template and the pre-existing ill/ill-requests.tt template. To test: 1) Ensure ILL is enabled and your user has sufficient permissions 2) Ensure your user has some ILL requests 3) Navigate to the user's patron profile page 4) Click on the "Interlibrary loans" tab 5) Observe that the requests table is displayed inline 6) Observe that only your user's requests are displayed Signed-off-by: Niamh.Walker-Headon at it-tallaght.ie This is essentially a reimplementation of attachment 84796 to take into account all changes that had happened beneath this bug and also to ensure JS strings are translatable. Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 15:11:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 14:11:59 +0000 Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile In-Reply-To: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18589-70-Ga3Ah2O5uX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 --- Comment #32 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86720&action=edit Bug 18589: (QA follow-up) Rename page to "ILL requests history" for consistancy Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 15:12:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 14:12:03 +0000 Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile In-Reply-To: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18589-70-di4lsfDfiT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 --- Comment #33 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86721&action=edit Bug 18589: (QA follow-up) Move template to bootstrap grid Test plan: Go to patrons Ill request history page and ensure the layout is not broken and is consistant with other patron pages (except Circulation and Details pages) Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 15:20:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 14:20:08 +0000 Subject: [Koha-bugs] [Bug 22531] New: Allow for multiple requests to partners and display partners in audit log Message-ID: <bug-22531-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Bug ID: 22531 Summary: Allow for multiple requests to partners and display partners in audit log Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs at lists.koha-community.org Reporter: andrew.isherwood at ptfs-europe.com Target Milestone: --- Currently, when an ILL request is sent to partners it is not possible to send to further partners, should the first partner not be able to fulfil the request. A better approach would be to allow the "Place request with partners" option to be selected even when this action has already taken place. This will allow the user to try multiple partners subsequently. As such, we should log which partners a request has been sent to and this information should be displayed in the "Display request log" functionality added in Bug 20750 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 15:20:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 14:20:32 +0000 Subject: [Koha-bugs] [Bug 22531] Allow for multiple requests to partners and display partners in audit log In-Reply-To: <bug-22531-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22531-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22531-70-vzA8NUBAsD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |andrew.isherwood at ptfs-europ |ity.org |e.com Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 15:21:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 14:21:31 +0000 Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile In-Reply-To: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18589-70-ITeFAJNYim@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86718|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 15:25:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 14:25:18 +0000 Subject: [Koha-bugs] [Bug 22531] Allow for multiple requests to partners and display partners in audit log In-Reply-To: <bug-22531-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22531-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22531-70-VyjUbqALyA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18589 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 [Bug 18589] Show ILLs as part of patron profile -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 15:25:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 14:25:18 +0000 Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile In-Reply-To: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18589-70-QF19XF5EZ6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22531 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 [Bug 22531] Allow for multiple requests to partners and display partners in audit log -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 15:44:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 14:44:38 +0000 Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile In-Reply-To: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18589-70-nxb5leACyL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 --- Comment #34 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86722&action=edit Bug 18589: (QA follow-up) Remove dateFormat from javascript on ill requests pages. This is not needed, the right formatting is done in calendar.inc Test plan: Use datepickers on ILL requests list page and ensure they work as expected and the list is right filterred Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 15:49:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 14:49:02 +0000 Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile In-Reply-To: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18589-70-yiquqEFXAs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 --- Comment #35 from Josef Moravec <josef.moravec at gmail.com> --- Ad changes in Koha/REST/V1/Illrequests.pm: Working with parameters should use objects search plugin and patron_id instead of borrowernumber. But such changes are out of scope of this bug and will be done on bug 22440 and after ILL request api rfc is voted. So, I would consider this as Passed QA Just would like somebody to test and sign off on my three follow-ups -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 15:52:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 14:52:32 +0000 Subject: [Koha-bugs] [Bug 22525] Navigation arrows on the bottom of Cataloging search pages In-Reply-To: <bug-22525-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22525-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22525-70-BbiiClTFmw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22525 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 16:57:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 15:57:29 +0000 Subject: [Koha-bugs] [Bug 22532] New: Remove "random" from Z39.50 Message-ID: <bug-22532-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22532 Bug ID: 22532 Summary: Remove "random" from Z39.50 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: josef.moravec at gmail.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Bug 10462 removes random parameter from Z39.50 biblio search, but it is still used authority search. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 16:57:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 15:57:39 +0000 Subject: [Koha-bugs] [Bug 22532] Remove "random" from Z39.50 In-Reply-To: <bug-22532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22532-70-aJeXuTJAzF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22532 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |10462 Blocks| |19220 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10462 [Bug 10462] Some optimizations in Z3950 search paving the way for enhancements https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19220 [Bug 19220] Allow XSLT processing for Z39.50 authority targets like for bibliographic targets -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 16:57:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 15:57:39 +0000 Subject: [Koha-bugs] [Bug 19220] Allow XSLT processing for Z39.50 authority targets like for bibliographic targets In-Reply-To: <bug-19220-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19220-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19220-70-Q4AgOxmWwv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19220 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22532 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22532 [Bug 22532] Remove "random" from Z39.50 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 16:57:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 15:57:39 +0000 Subject: [Koha-bugs] [Bug 10462] Some optimizations in Z3950 search paving the way for enhancements In-Reply-To: <bug-10462-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10462-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10462-70-oQoRH70km0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10462 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22532 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22532 [Bug 22532] Remove "random" from Z39.50 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 17:04:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 16:04:07 +0000 Subject: [Koha-bugs] [Bug 22532] Remove "random" from Z39.50 In-Reply-To: <bug-22532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22532-70-HTJa3gvmLi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22532 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |josef.moravec at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 17:06:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 16:06:09 +0000 Subject: [Koha-bugs] [Bug 15794] Add emoji picker to tag entry in OPAC In-Reply-To: <bug-15794-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15794-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15794-70-AV5U6P0KlA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 --- Comment #20 from Owen Leonard <oleonard at myacpl.org> --- (In reply to David Cook from comment #19) > I think Endnote X9 uses an (old) embedded version of Internet Explorer A scary Halloween short story as told by David. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 17:29:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 16:29:23 +0000 Subject: [Koha-bugs] [Bug 15794] Add emoji picker to tag entry in OPAC In-Reply-To: <bug-15794-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15794-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15794-70-A0uxmtDHyv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 --- Comment #21 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- (In reply to David Cook from comment #19) > The emoji picker is causing script errors when using Koha in Endnote X9. > > I think Endnote X9 uses an (old) embedded version of Internet Explorer, and > I think that's why it's happening. > > Investigating ways of fixing it, but I think I might just send a follow-up > about using a system preference to disable the emoji picker. +1 for a syspref. Or better find a more compatible emoji picker. Anyways, please default to enabled to keep the current behavior. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 17:34:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 16:34:42 +0000 Subject: [Koha-bugs] [Bug 22531] Allow for multiple requests to partners and display partners in audit log In-Reply-To: <bug-22531-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22531-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22531-70-HLNI357T1e@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 --- Comment #1 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 86723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86723&action=edit Bug 22531: Add logging & display of req partners This patch adds: - The ability to send request to partners multiple times. - Logging of requested partners - Display of requested partners in "ILL Request Log" display -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 17:49:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 16:49:57 +0000 Subject: [Koha-bugs] [Bug 22532] Remove "random" from Z39.50 In-Reply-To: <bug-22532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22532-70-wP7HgFtO8H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22532 --- Comment #1 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86724&action=edit Bug 22532: Remove Z39.50 random Test plan: Try to search, preview and import authority from Z39.50, everything should work as expected Test plan: Try to search, preview and import authority from Z39.50, everything should work as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 17:50:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 16:50:00 +0000 Subject: [Koha-bugs] [Bug 22532] Remove "random" from Z39.50 In-Reply-To: <bug-22532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22532-70-NEAYYrlIR6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22532 --- Comment #2 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86725&action=edit Bug 22532: Database update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 17:50:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 16:50:17 +0000 Subject: [Koha-bugs] [Bug 22532] Remove "random" from Z39.50 In-Reply-To: <bug-22532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22532-70-2wRUnaNigc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22532 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 18:22:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 17:22:40 +0000 Subject: [Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images In-Reply-To: <bug-22445-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22445-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22445-70-vMSwLQ5pxk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #22 from Owen Leonard <oleonard at myacpl.org> --- (In reply to Jonathan Druart from comment #21) > We should deal with that problem globally, but on a separate bug report of > course as it will complexity this patch set a lot. All other cover image sources provide a generally-acceptable image size for all cover images. With local cover images, we provide the option for users to upload images but then we have Koha generate a thumbnail. For this feature to all any size image to be displayed is inconsistent with what we have now. I'm going to submit patches to add classes to the display of cover images and add CSS to specify a maximum width for these covers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 18:31:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 17:31:20 +0000 Subject: [Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images In-Reply-To: <bug-22445-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22445-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22445-70-XXeP65vW7T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 18:31:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 17:31:23 +0000 Subject: [Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images In-Reply-To: <bug-22445-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22445-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22445-70-iF656XjJyo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #23 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 86726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86726&action=edit Bug 22455: (follow-up) Use CSS to set a max-width for images - OPAC This patch adds some CSS and markup to OPAC templates so that custom cover images have a maximum width of 140px (to match the width of generated local cover image thumbnails). This prevents oversized images from displaying inconsistently compared to images from other services. To test, apply the patch and regenerate the OPAC CSS. Post an oversized image which corresponds to a record in your OPAC which can be added to a user's checkouts and to a list. View the following pages to confirm that the image displays well: - OPAC search results - Bibliographic detail page - Shelf browser - List contents - Recent comments - "Your summary" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 18:36:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 17:36:17 +0000 Subject: [Koha-bugs] [Bug 22533] New: maninvoice.pl is using deprecated maininvoice() method Message-ID: <bug-22533-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22533 Bug ID: 22533 Summary: maninvoice.pl is using deprecated maininvoice() method Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 18:36:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 17:36:33 +0000 Subject: [Koha-bugs] [Bug 22533] maninvoice.pl is using deprecated maininvoice() method In-Reply-To: <bug-22533-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22533-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22533-70-V3917Im1Er@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22533 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com, tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 18:51:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 17:51:05 +0000 Subject: [Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images In-Reply-To: <bug-22445-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22445-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22445-70-5Xk0J6I6Ts@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #24 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 86727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86727&action=edit Bug 22455: (follow-up) Use CSS to set a max-width for images - Staff client This patch adds some CSS and markup to staff client templates so that custom cover images have a maximum width of 140px (to match the width of generated local cover image thumbnails). This prevents oversized images from displaying inconsistently compared to images from other services. This patch also adds a missing </a> to fix display problems. To test, apply the patch and regenerate the staff client CSS. Post an oversized image which corresponds to a record in your catalog. View the following pages to confirm that the image displays well: - Catalog search results - Bibliographic detail page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 19:25:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 18:25:57 +0000 Subject: [Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images In-Reply-To: <bug-22445-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22445-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22445-70-zNj2TIuNb3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #25 from Owen Leonard <oleonard at myacpl.org> --- I have a concern which I think may be a blocker for this feature: All other cover image sources use a "normalized_isbn" variable which is provided to the templates. This feature doesn't use a normalized ISBN, so a library might upload an image file with a name like this: "0553573403.png" ...and find that Koha is trying to load an image with this file name: "0553573403 | 9780553573404 (pbk.).png" I think it would be more consistent to have custom cover images use a normalized ISBN too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 19:26:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 18:26:36 +0000 Subject: [Koha-bugs] [Bug 22318] Extend Koha news feature to include other content areas In-Reply-To: <bug-22318-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22318-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22318-70-cDOr1hdVgz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 19:26:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 18:26:38 +0000 Subject: [Koha-bugs] [Bug 22318] Extend Koha news feature to include other content areas In-Reply-To: <bug-22318-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22318-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22318-70-p6xpjCcCEu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85133|0 |1 is obsolete| | --- Comment #7 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 86728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86728&action=edit Bug 22318: Example implementation: OpacNavRight system preference This patch implements a Koha news system replacement of the OpacNavRight system preference. The changes to koha-news.tt enable the selection of "OpacNavRight" as a location for the content. opac-main.pl is modified to ensure that the user's selected language is passed to the template for use by the KohaNews plugin. The database update process takes the contents of Koha's OpacNavRight system preference and adds it to the Koha news system. The OpacNavRight system preference is then removed from the database. When the new entry is added to Koha news, the language is set based on the top selected language in the "opaclanguages" preference. The entry is added to "All libraries" without an author, title, or expiration date. Note that this patch doesn't change the way OPAC news is displayed. I think it's best to keep existing markup and code for that since it handles details like branch selection and RSS. To test, apply the patch and run the database update. - In the staff client go to Tools -> News and confirm that there is now an entry with the location "OpacNavRight_en" (assuming an "en" English interface). - Confirm that the previous contents of OpacNavRight were added correctly. - Go to Administration -> System preferences -> OPAC and verify that the OpacNavRight preference has been removed. - In the OPAC, confirm that the correct content is displayed in the region previously defined in the OpacNavRight system preference. - Test that the language and library-specific nature of news items is reflected in the behavior of this content area: - Define different text based on language and location. Confirm that switching translations and logging in to the OPAC both trigger the correct display of different content. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 19:27:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 18:27:42 +0000 Subject: [Koha-bugs] [Bug 22318] Extend Koha news feature to include other content areas In-Reply-To: <bug-22318-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22318-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22318-70-u4Xua5BSnZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 --- Comment #8 from Owen Leonard <oleonard at myacpl.org> --- Rebased on top of Bug 14272. Thanks for testing! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 19:44:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 18:44:27 +0000 Subject: [Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel In-Reply-To: <bug-20959-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20959-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20959-70-ho8NFB13gE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86477|0 |1 is obsolete| | --- Comment #35 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 86729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86729&action=edit Bug 20959: Style checkin form more like the checkout form, with collapsed settings panel This patch modifies the structure of the checkin form so that settings (Specify return date, book drop mode, forgive overdue charges) are in a collapsed panel when inactive. The style of the barcode field and the mode notification messages has been changed to reduce the vertical motion of the form when selecting options. Some class names have been changed in circulation.tt and circulation.js to make them appropriate for use on both forms. To test, apply the patch and clear your browser cache if necessary. - View the checkin page. The "checkin settings" panel should be collapsed by default. - Confirm that the settings panel collapses and expands as it should. - Confirm that selecting "Forgive overdue charges" or "Book drop mode" trigger the display of the correct message and that the style of the barcode field is changed. - Confirm that after submitting a barcode for check-in, the settings panel stays open and your selected settings are still selected. - Test with CircSidebar enabled and disabled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 19:45:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 18:45:20 +0000 Subject: [Koha-bugs] [Bug 14516] Dropbox mode barcode input has odd coloring (alert class css) In-Reply-To: <bug-14516-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14516-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14516-70-M66Bzycl32@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14516 --- Comment #3 from Owen Leonard <oleonard at myacpl.org> --- This would be fixed by Bug 20959 if anyone is interested in moving that one along -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 19:54:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 18:54:11 +0000 Subject: [Koha-bugs] [Bug 16461] Add some information (branch and barcode) in fine description for overdue In-Reply-To: <bug-16461-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16461-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16461-70-hkHGv9cZkr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16461 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 19:58:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 18:58:19 +0000 Subject: [Koha-bugs] [Bug 22525] Navigation arrows on the bottom of Cataloging search pages In-Reply-To: <bug-22525-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22525-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22525-70-lTXcFHFLZn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22525 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 20:01:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 19:01:37 +0000 Subject: [Koha-bugs] [Bug 9975] tracking branches in fines better In-Reply-To: <bug-9975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9975-70-Lx9mnSwu7Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9975 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 20:05:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 19:05:44 +0000 Subject: [Koha-bugs] [Bug 19066] Add branchcode to accountlines In-Reply-To: <bug-19066-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19066-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19066-70-oPjS21ojCr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19066 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 20:23:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 19:23:21 +0000 Subject: [Koha-bugs] [Bug 16440] Update report parameters In-Reply-To: <bug-16440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16440-70-00o2EkEdjW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16440 --- Comment #6 from Owen Leonard <oleonard at myacpl.org> --- I think the sidebar is the right place for this. It's basically the same as the various kinds of "filter" forms we show in the sidebar. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 20:23:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 19:23:36 +0000 Subject: [Koha-bugs] [Bug 16440] Update report parameters In-Reply-To: <bug-16440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16440-70-5clya0gcBI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16440 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|oleonard at myacpl.org | Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 20:39:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 19:39:52 +0000 Subject: [Koha-bugs] [Bug 10532] koha-run-backups option --output doesn't work In-Reply-To: <bug-10532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10532-70-OwgssMOEiH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10532 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #5 from Magnus Enger <magnus at libriotech.no> --- Still a problem on 18.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 21:03:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 20:03:04 +0000 Subject: [Koha-bugs] [Bug 14678] Update Koha language codes to ISO 639-2 spec In-Reply-To: <bug-14678-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14678-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14678-70-Q5jUbUV64Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14678 Kelly McElligott <kelly at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly at bywatersolutions.com --- Comment #3 from Kelly McElligott <kelly at bywatersolutions.com> --- This is a concern with a Nunavut library moving over to Koha. Over half their collection is in the Inuktitut language, however, currently, this language is not searchable with the language feature. Inuktitut is included in the ISO 639-2 Language Code list, therefore, can it be included in the Koha dropdown list of languages? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 21:17:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 20:17:22 +0000 Subject: [Koha-bugs] [Bug 22534] New: Add ability to choose which fields are copied from guarantor to guarantee Message-ID: <bug-22534-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534 Bug ID: 22534 Summary: Add ability to choose which fields are copied from guarantor to guarantee Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: genevieve.beaudry at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Target Milestone: --- When linking a guarantee to a guarantor, some fields are automatically copied, such as the address, the phone number, etc. I suggest that a system preference be added so that the system administration can choose which fields they want to be copied. By default, it can stay address and phone number, but they would have the possibility to remove those. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 21:19:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 20:19:13 +0000 Subject: [Koha-bugs] [Bug 22534] Add ability to choose which fields are copied from guarantor to guarantee In-Reply-To: <bug-22534-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22534-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22534-70-mUXeNj9zNs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22534 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Oops, I reported this. I just forgot to log out of Genevi?ve's bz account first. Sorry! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 21:19:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 20:19:38 +0000 Subject: [Koha-bugs] [Bug 15400] Display patron age in useful places In-Reply-To: <bug-15400-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15400-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15400-70-1iGcdpW1tC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15400 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 21:45:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 20:45:05 +0000 Subject: [Koha-bugs] [Bug 14678] Update Koha language codes to ISO 639-2 spec In-Reply-To: <bug-14678-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14678-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14678-70-a0oP7bPxKx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14678 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Kelly, it looks like bug 15067 will take care of Inuktitut. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 21:49:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 20:49:55 +0000 Subject: [Koha-bugs] [Bug 14516] Dropbox mode barcode input has odd coloring (alert class css) In-Reply-To: <bug-14516-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14516-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14516-70-pDzwcoY7nj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14516 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- We'll just mark it as a duplicate then :) *** This bug has been marked as a duplicate of bug 20959 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 21:49:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 20:49:55 +0000 Subject: [Koha-bugs] [Bug 20959] Style checkin form more like the checkout form, with collapsed settings panel In-Reply-To: <bug-20959-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20959-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20959-70-hUeoe3gqnn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20959 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #36 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** Bug 14516 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 22:07:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 21:07:37 +0000 Subject: [Koha-bugs] [Bug 22318] Extend Koha news feature to include other content areas In-Reply-To: <bug-22318-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22318-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22318-70-8SvBrC52xU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Michal Denar <black23 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 22:07:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 21:07:40 +0000 Subject: [Koha-bugs] [Bug 22318] Extend Koha news feature to include other content areas In-Reply-To: <bug-22318-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22318-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22318-70-4QzSV0PprL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Michal Denar <black23 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85132|0 |1 is obsolete| | Attachment #86728|0 |1 is obsolete| | --- Comment #9 from Michal Denar <black23 at gmail.com> --- Created attachment 86730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86730&action=edit Bug 22318: Extend Koha news feature to include other content areas This patch lays the groundwork for using the Koha news tool to replace OPAC system preferences which embed HTML content in the Koha interface. This will allow multiple translations of these content blocks to be created. This adds a new template plugin, KohaNews. It has a single subroutine, get(), which takes three parameters: - "location" -- the area of the template where the content will appear. This will correspond to the system preference it replaces: OpacMainUserBlock, OpacNavRight, etc. - "lang" -- the user's currently-selected language. - "library" -- the user's home library (if they are logged in) A new "koha_news_block" block is added to the OPAC templates' html_helpers include. The content area is activated in the template using this syntax: [% PROCESS koha_news_block news => KohaNews.get( location => "OpacNavRight", lang => news_lang, library => branchcode ) %] Signed-off-by: Michal Denar <black23 at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 22:07:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 21:07:43 +0000 Subject: [Koha-bugs] [Bug 22318] Extend Koha news feature to include other content areas In-Reply-To: <bug-22318-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22318-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22318-70-eoZLJMg8xZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 --- Comment #10 from Michal Denar <black23 at gmail.com> --- Created attachment 86731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86731&action=edit Bug 22318: Example implementation: OpacNavRight system preference This patch implements a Koha news system replacement of the OpacNavRight system preference. The changes to koha-news.tt enable the selection of "OpacNavRight" as a location for the content. opac-main.pl is modified to ensure that the user's selected language is passed to the template for use by the KohaNews plugin. The database update process takes the contents of Koha's OpacNavRight system preference and adds it to the Koha news system. The OpacNavRight system preference is then removed from the database. When the new entry is added to Koha news, the language is set based on the top selected language in the "opaclanguages" preference. The entry is added to "All libraries" without an author, title, or expiration date. Note that this patch doesn't change the way OPAC news is displayed. I think it's best to keep existing markup and code for that since it handles details like branch selection and RSS. To test, apply the patch and run the database update. - In the staff client go to Tools -> News and confirm that there is now an entry with the location "OpacNavRight_en" (assuming an "en" English interface). - Confirm that the previous contents of OpacNavRight were added correctly. - Go to Administration -> System preferences -> OPAC and verify that the OpacNavRight preference has been removed. - In the OPAC, confirm that the correct content is displayed in the region previously defined in the OpacNavRight system preference. - Test that the language and library-specific nature of news items is reflected in the behavior of this content area: - Define different text based on language and location. Confirm that switching translations and logging in to the OPAC both trigger the correct display of different content. Signed-off-by: Michal Denar <black23 at gmail.com> Signed-off-by: Michal Denar <black23 at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 22:14:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 21:14:21 +0000 Subject: [Koha-bugs] [Bug 14678] Update Koha language codes to ISO 639-2 spec In-Reply-To: <bug-14678-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14678-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14678-70-WmUb3qz6mQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14678 --- Comment #5 from Kelly McElligott <kelly at bywatersolutions.com> --- Thanks Katrin, yes found the other bug 15067. Thanks for such a quick response! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 22:15:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 21:15:22 +0000 Subject: [Koha-bugs] [Bug 22522] API authentication breaks with updated Mojolicious version In-Reply-To: <bug-22522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22522-70-znWSKWesBI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522 --- Comment #2 from Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> --- I've noticed today that with newer Mojolicious versions, the authentication is basically skipped as x-koha-authorization is never defined. It seems that this makes it so all endpoints do not require authorization to be accessed. This is a major security flaw, since anybody can for example access patron's information. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 22:24:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 21:24:00 +0000 Subject: [Koha-bugs] [Bug 22535] New: Use Link Shortcuts when creating reports Message-ID: <bug-22535-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22535 Bug ID: 22535 Summary: Use Link Shortcuts when creating reports Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: joy at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- The syntax to create links in SQL reports is cumbersome. The below link, as example, often gets typos and then fails to work when run. CONCAT('<a href=\"/cgi-bin/koha/cataloguing/addbiblio.pl?' , 'biblionumber=' , biblionumber , '\">' , biblionumber , '</a>'), AS 'biblionumber', Koha needs a way to allow the user to enter a 'shorthand' or alias in the sql query that is then replaced by the URL. For example: SELECT biblionumber|link_detail from biblio would resolve to SELECT CONCAT('<a href=\"/cgi-bin/koha/cataloguing/addbiblio.pl?' , 'biblionumber=' , biblionumber , '\">' , biblionumber , '</a>'), AS 'biblionumber' from biblio List of current links documented on the wiki that could use aliases: https://wiki.koha-community.org/wiki/SQL_Reports_Library#Links -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 23:26:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 22:26:14 +0000 Subject: [Koha-bugs] [Bug 13763] Renew feature does not check for the BarcodeInputFilter option In-Reply-To: <bug-13763-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13763-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13763-70-LR6J2jHry5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13763 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #7 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- (In reply to Bin from comment #6) > (In reply to Hayley Mapley from comment #5) > > (In reply to Bin from comment #4) > > > After applying the patch, it is still invalid > > > > Hi Bin, > > > > Can you please describe what you did, and what was the result? > > I followed the test plan: > > Test plan: > 1) In Circulation->Renew, enter a barcode that you know exists in the > catalogue but add extra spaces, breaking up the barcode. Note that this > fails with a warning that says 'No item matches this barcode' > > 2) In system Preferences, set the itemBarcodeFilter pref to Remove > spaces and repeat step1. Note that the result is the same as in step 1 > > 3) Apply the patch > > but still failed with a warning that said 'No item matches this barcode' Thanks for testing! It still works for me, would you mind verifying that after applying the patch you restarted memcached and plack (I use restart_all) and that the barcode you are trying to test actually exists? For example, my test barcode was TEST11111 and I entered it as 'TE ST 11 111' with the system preference set to 'Remove spaces from'. This worked for me, I'm just trying to understand why it hasn't worked for you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 18 23:50:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Mar 2019 22:50:01 +0000 Subject: [Koha-bugs] [Bug 22536] New: Display problem in Holds to Pull report Message-ID: <bug-22536-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22536 Bug ID: 22536 Summary: Display problem in Holds to Pull report Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: david.roberts at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Target Milestone: --- Created attachment 86732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86732&action=edit Screenshot In 18.11, the holds to pull screen displays <br/> in the table when an bibliographic record has more than one copy (see attached screenshot). This seems to be related to the template: </td> <td><p>[% reserveloo.itemcallnumber | html %]</p></td> <td><p>[% reserveloo.copyno | html %]</p></td> <td><p>[% reserveloo.enumchron | html %]</p></td> <td> Removing the html part of the line fixes the problem, but isn't a very secure long-term solution. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 09:05:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 08:05:29 +0000 Subject: [Koha-bugs] [Bug 19962] Introduce koha-sip to replace koha-*-sip In-Reply-To: <bug-19962-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19962-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19962-70-5Oc6rj4oqF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19962 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no Resolution|--- |DUPLICATE Status|Needs Signoff |RESOLVED --- Comment #4 from Magnus Enger <magnus at libriotech.no> --- A koha-sip script has already been pushed to master as part of bug 18562. *** This bug has been marked as a duplicate of bug 18562 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 09:05:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 08:05:29 +0000 Subject: [Koha-bugs] [Bug 18562] Add koha-sip script to handle SIP servers for instances In-Reply-To: <bug-18562-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18562-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18562-70-dNeWrKXvID@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18562 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pongtawat at punsarn.asia --- Comment #18 from Magnus Enger <magnus at libriotech.no> --- *** Bug 19962 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 09:29:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 08:29:53 +0000 Subject: [Koha-bugs] [Bug 22318] Extend Koha news feature to include other content areas In-Reply-To: <bug-22318-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22318-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22318-70-NjbFG9jt0G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 09:29:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 08:29:55 +0000 Subject: [Koha-bugs] [Bug 22318] Extend Koha news feature to include other content areas In-Reply-To: <bug-22318-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22318-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22318-70-YPB2PIO67I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86730|0 |1 is obsolete| | --- Comment #11 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86733&action=edit Bug 22318: Extend Koha news feature to include other content areas This patch lays the groundwork for using the Koha news tool to replace OPAC system preferences which embed HTML content in the Koha interface. This will allow multiple translations of these content blocks to be created. This adds a new template plugin, KohaNews. It has a single subroutine, get(), which takes three parameters: - "location" -- the area of the template where the content will appear. This will correspond to the system preference it replaces: OpacMainUserBlock, OpacNavRight, etc. - "lang" -- the user's currently-selected language. - "library" -- the user's home library (if they are logged in) A new "koha_news_block" block is added to the OPAC templates' html_helpers include. The content area is activated in the template using this syntax: [% PROCESS koha_news_block news => KohaNews.get( location => "OpacNavRight", lang => news_lang, library => branchcode ) %] Signed-off-by: Michal Denar <black23 at gmail.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 09:29:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 08:29:58 +0000 Subject: [Koha-bugs] [Bug 22318] Extend Koha news feature to include other content areas In-Reply-To: <bug-22318-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22318-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22318-70-L8fEJ4q8Uh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86731|0 |1 is obsolete| | --- Comment #12 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86734&action=edit Bug 22318: Example implementation: OpacNavRight system preference This patch implements a Koha news system replacement of the OpacNavRight system preference. The changes to koha-news.tt enable the selection of "OpacNavRight" as a location for the content. opac-main.pl is modified to ensure that the user's selected language is passed to the template for use by the KohaNews plugin. The database update process takes the contents of Koha's OpacNavRight system preference and adds it to the Koha news system. The OpacNavRight system preference is then removed from the database. When the new entry is added to Koha news, the language is set based on the top selected language in the "opaclanguages" preference. The entry is added to "All libraries" without an author, title, or expiration date. Note that this patch doesn't change the way OPAC news is displayed. I think it's best to keep existing markup and code for that since it handles details like branch selection and RSS. To test, apply the patch and run the database update. - In the staff client go to Tools -> News and confirm that there is now an entry with the location "OpacNavRight_en" (assuming an "en" English interface). - Confirm that the previous contents of OpacNavRight were added correctly. - Go to Administration -> System preferences -> OPAC and verify that the OpacNavRight preference has been removed. - In the OPAC, confirm that the correct content is displayed in the region previously defined in the OpacNavRight system preference. - Test that the language and library-specific nature of news items is reflected in the behavior of this content area: - Define different text based on language and location. Confirm that switching translations and logging in to the OPAC both trigger the correct display of different content. Signed-off-by: Michal Denar <black23 at gmail.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 09:30:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 08:30:17 +0000 Subject: [Koha-bugs] [Bug 22318] Extend Koha news feature to include other content areas In-Reply-To: <bug-22318-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22318-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22318-70-FuIyrTHgF2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 10:02:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 09:02:14 +0000 Subject: [Koha-bugs] [Bug 22379] ILS-DI Method "CancelHold" don't check CanReserveBeCanceledFromOpac In-Reply-To: <bug-22379-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22379-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22379-70-FJUjQWxuib@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22379 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 10:06:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 09:06:38 +0000 Subject: [Koha-bugs] [Bug 22379] ILS-DI Method "CancelHold" don't check CanReserveBeCanceledFromOpac In-Reply-To: <bug-22379-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22379-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22379-70-sWQDLigPIE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22379 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 10:18:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 09:18:38 +0000 Subject: [Koha-bugs] [Bug 22483] haspermissions previously supported passing 'undef' for $flagsrequired In-Reply-To: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22483-70-QqKHf84pa6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22529 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22529 [Bug 22529] /svc/members/search relies on quirks of haspermission -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 10:18:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 09:18:52 +0000 Subject: [Koha-bugs] [Bug 22529] /svc/members/search relies on quirks of haspermission In-Reply-To: <bug-22529-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22529-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22529-70-9ttJZyRIOr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22529 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22483 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 10:18:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 09:18:52 +0000 Subject: [Koha-bugs] [Bug 22483] haspermissions previously supported passing 'undef' for $flagsrequired In-Reply-To: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22483-70-NoAYlyLeWY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22529 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 10:18:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 09:18:38 +0000 Subject: [Koha-bugs] [Bug 22529] /svc/members/search relies on quirks of haspermission In-Reply-To: <bug-22529-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22529-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22529-70-xGMxe4fCbI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22529 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22483 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 [Bug 22483] haspermissions previously supported passing 'undef' for $flagsrequired -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 10:19:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 09:19:13 +0000 Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile In-Reply-To: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18589-70-ZuXO6TAhrs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86721|0 |1 is obsolete| | --- Comment #37 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 86736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86736&action=edit Bug 18589: (QA follow-up) Move template to bootstrap grid Test plan: Go to patrons Ill request history page and ensure the layout is not broken and is consistant with other patron pages (except Circulation and Details pages) Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 10:19:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 09:19:17 +0000 Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile In-Reply-To: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18589-70-ZCXReJtKxg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86722|0 |1 is obsolete| | --- Comment #38 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 86737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86737&action=edit Bug 18589: (QA follow-up) Remove dateFormat from javascript on ill requests pages. This is not needed, the right formatting is done in calendar.inc Test plan: Use datepickers on ILL requests list page and ensure they work as expected and the list is right filterred Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 10:19:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 09:19:09 +0000 Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile In-Reply-To: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18589-70-ENIMvOKDPb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86720|0 |1 is obsolete| | --- Comment #36 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 86735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86735&action=edit Bug 18589: (QA follow-up) Rename page to "ILL requests history" for consistancy Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 10:26:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 09:26:19 +0000 Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile In-Reply-To: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18589-70-G1JBYH9CSA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |josef.moravec at gmail.com Status|Signed Off |Passed QA --- Comment #39 from Josef Moravec <josef.moravec at gmail.com> --- > Signed-off-by: Andrew Isherwood <andrew.isherwood at ptfs-europe.com> Thanks Andrew, so now I am passing it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 10:26:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 09:26:40 +0000 Subject: [Koha-bugs] [Bug 22489] Onboarding tool fails due to inserting maxissueqty into IssuingRule In-Reply-To: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22489-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22489-70-9jZXDC9Bzx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22489 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Bug with enhancement not backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 10:30:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 09:30:35 +0000 Subject: [Koha-bugs] [Bug 22498] Can not select any funds for invoice adjustments In-Reply-To: <bug-22498-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22498-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22498-70-aUz7IVkr9G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22498 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 10:32:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 09:32:00 +0000 Subject: [Koha-bugs] [Bug 20375] Add a new permission for managing invoices In-Reply-To: <bug-20375-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20375-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20375-70-rpnWyEyxwM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20375 Janet McGowan <janet.mcgowan at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 10:33:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 09:33:22 +0000 Subject: [Koha-bugs] [Bug 22237] Subscriptions are not linked to Mana upon edit In-Reply-To: <bug-22237-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22237-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22237-70-191K0BVZeL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22237 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED CC| |martin.renvoize at ptfs-europe | |.com --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Bug on enhancement not in 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 10:33:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 09:33:22 +0000 Subject: [Koha-bugs] [Bug 22250] Clean up Mana KB integration with serials and reports In-Reply-To: <bug-22250-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22250-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22250-70-MbPdnn87j9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22250 Bug 22250 depends on bug 22237, which changed state. Bug 22237 Summary: Subscriptions are not linked to Mana upon edit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22237 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 10:34:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 09:34:11 +0000 Subject: [Koha-bugs] [Bug 22429] Infinite loop in patron card printing In-Reply-To: <bug-22429-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22429-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22429-70-gtJTlBUpiK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22429 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 10:37:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 09:37:18 +0000 Subject: [Koha-bugs] [Bug 21560] Optimize ODS exports In-Reply-To: <bug-21560-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21560-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21560-70-835q6zUHkJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21560 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #33 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 10:40:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 09:40:18 +0000 Subject: [Koha-bugs] [Bug 22476] MarkLostItemsAsReturned has wrong defaults for new installs In-Reply-To: <bug-22476-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22476-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22476-70-Qzmzi3krt1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22476 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 10:42:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 09:42:31 +0000 Subject: [Koha-bugs] [Bug 22222] Mana subscription search always returns all results In-Reply-To: <bug-22222-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22222-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22222-70-GpQj45Wc2J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22222 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Bug with enhancement not in 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 10:51:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 09:51:55 +0000 Subject: [Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines In-Reply-To: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14591-70-jge291xsGC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #34 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Bug with enhancement not in 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 10:51:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 09:51:56 +0000 Subject: [Koha-bugs] [Bug 22516] accountlines.lastincrement can be removed In-Reply-To: <bug-22516-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22516-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22516-70-hLigKYegSs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22516 Bug 22516 depends on bug 14591, which changed state. Bug 14591 Summary: book drop / drop box mode incorrectly decrements accrued overdue fines https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 10:53:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 09:53:34 +0000 Subject: [Koha-bugs] [Bug 22493] DecreaseLoanHighHolds.t creates some items/patrons with set values In-Reply-To: <bug-22493-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22493-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22493-70-G7zqJ3VqEI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22493 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 10:55:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 09:55:37 +0000 Subject: [Koha-bugs] [Bug 21987] Local cover 'thumbnail' size is bigger than 'imagefile' size in biblioimages table In-Reply-To: <bug-21987-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21987-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21987-70-umxuuEW9kz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21987 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 11:04:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 10:04:01 +0000 Subject: [Koha-bugs] [Bug 21846] Using emoji as tags doesn't discriminate between emoji when calculating weights or searching In-Reply-To: <bug-21846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21846-70-evuUQoKhYT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #45 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 11:05:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 10:05:28 +0000 Subject: [Koha-bugs] [Bug 21846] Using emoji as tags doesn't discriminate between emoji when calculating weights or searching In-Reply-To: <bug-21846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21846-70-XTItlfTx8f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Please note, this patch release notes| |fixes issues going forward. | |It includes a maintenance | |script to allow you to fix | |any possible existing | |cases. Please see bugzilla | |for details. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 11:07:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 10:07:46 +0000 Subject: [Koha-bugs] [Bug 22043] SIP Checkin Response alert flag set to often set to Y incorrectly In-Reply-To: <bug-22043-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22043-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22043-70-epL8tgIAag@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22043 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |martin.renvoize at ptfs-europe | |.com --- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Bug with enhancement not in 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 11:20:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 10:20:17 +0000 Subject: [Koha-bugs] [Bug 22318] Extend Koha news feature to include other content areas In-Reply-To: <bug-22318-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22318-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22318-70-zH7vAr8eW4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Failed QA --- Comment #13 from Josef Moravec <josef.moravec at gmail.com> --- Sorry, I found one issue here: On news list page, the filter above datatable does not contain OpacNavRight location. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 11:40:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 10:40:27 +0000 Subject: [Koha-bugs] [Bug 22477] Missing DataTables configuration when searching patrons for holds In-Reply-To: <bug-22477-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22477-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22477-70-wVi2xvZrk8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22477 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize at ptfs-europe | |.com --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 11:41:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 10:41:41 +0000 Subject: [Koha-bugs] [Bug 22219] C4::Biblio->GetItemsForInventory can return wrong count / duplicated items when skipping waiting holds In-Reply-To: <bug-22219-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22219-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22219-70-GqQQcgTd81@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22219 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 11:42:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 10:42:34 +0000 Subject: [Koha-bugs] [Bug 20823] UNIMARC XSLT does not display 604$t In-Reply-To: <bug-20823-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20823-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20823-70-fHmqsjlrqA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20823 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 11:43:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 10:43:54 +0000 Subject: [Koha-bugs] [Bug 20750] Allow timestamped auditing of ILL request events In-Reply-To: <bug-20750-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20750-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20750-70-GgvKCQM4RB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #143 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 11:43:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 10:43:55 +0000 Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request datatable to be customisable In-Reply-To: <bug-21063-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21063-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21063-70-gVoa7KqGYa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 Bug 21063 depends on bug 20750, which changed state. Bug 20750 Summary: Allow timestamped auditing of ILL request events https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20750 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 11:44:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 10:44:21 +0000 Subject: [Koha-bugs] [Bug 21063] Allow columns in intranet ILL request datatable to be customisable In-Reply-To: <bug-21063-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21063-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21063-70-J6hxPuk4bF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #68 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 11:44:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 10:44:22 +0000 Subject: [Koha-bugs] [Bug 18837] Add an unmediated Interlibrary Loans workflow In-Reply-To: <bug-18837-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18837-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18837-70-OJLaiRgo4y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Bug 18837 depends on bug 21063, which changed state. Bug 21063 Summary: Allow columns in intranet ILL request datatable to be customisable https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21063 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 11:45:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 10:45:39 +0000 Subject: [Koha-bugs] [Bug 18837] Add an unmediated Interlibrary Loans workflow In-Reply-To: <bug-18837-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18837-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18837-70-dHBQM8Yo9T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #38 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 11:45:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 10:45:40 +0000 Subject: [Koha-bugs] [Bug 20563] ILL request list gives no indication of source and/or target In-Reply-To: <bug-20563-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20563-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20563-70-d8gH20bj8Q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20563 Bug 20563 depends on bug 18837, which changed state. Bug 18837 Summary: Add an unmediated Interlibrary Loans workflow https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18837 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 11:46:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 10:46:05 +0000 Subject: [Koha-bugs] [Bug 20563] ILL request list gives no indication of source and/or target In-Reply-To: <bug-20563-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20563-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20563-70-SiV7w4OSFF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20563 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #34 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 11:46:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 10:46:06 +0000 Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile In-Reply-To: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18589-70-seS3gospOi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Bug 18589 depends on bug 20563, which changed state. Bug 20563 Summary: ILL request list gives no indication of source and/or target https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20563 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 11:47:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 10:47:23 +0000 Subject: [Koha-bugs] [Bug 20006] Adapt /v1/holds to new naming guidelines In-Reply-To: <bug-20006-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20006-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20006-70-MChgkdAtDP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20006 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #28 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Enhancement with breaking changes.. will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 11:47:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 10:47:24 +0000 Subject: [Koha-bugs] [Bug 19774] Adapt existing endpoints to new naming guidelines OMNIBUS In-Reply-To: <bug-19774-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19774-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19774-70-6SQF1jwT34@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19774 Bug 19774 depends on bug 20006, which changed state. Bug 20006 Summary: Adapt /v1/holds to new naming guidelines https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20006 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 11:47:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 10:47:24 +0000 Subject: [Koha-bugs] [Bug 22206] Add route to handle holds suspensions In-Reply-To: <bug-22206-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22206-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22206-70-B0QgRdMqpl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 Bug 22206 depends on bug 20006, which changed state. Bug 20006 Summary: Adapt /v1/holds to new naming guidelines https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20006 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 11:47:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 10:47:25 +0000 Subject: [Koha-bugs] [Bug 22218] Make endpoints not in /public require privileged credentials [OMNIBUS] In-Reply-To: <bug-22218-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22218-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22218-70-OGt6RmGQ4H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22218 Bug 22218 depends on bug 20006, which changed state. Bug 20006 Summary: Adapt /v1/holds to new naming guidelines https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20006 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 11:52:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 10:52:43 +0000 Subject: [Koha-bugs] [Bug 20006] Adapt /v1/holds to new naming guidelines In-Reply-To: <bug-20006-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20006-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20006-70-yxIxFovTm7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20006 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 11:52:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 10:52:43 +0000 Subject: [Koha-bugs] [Bug 19774] Adapt existing endpoints to new naming guidelines OMNIBUS In-Reply-To: <bug-19774-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19774-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19774-70-lSYREwbO2f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19774 Bug 19774 depends on bug 20006, which changed state. Bug 20006 Summary: Adapt /v1/holds to new naming guidelines https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20006 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 11:52:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 10:52:44 +0000 Subject: [Koha-bugs] [Bug 22206] Add route to handle holds suspensions In-Reply-To: <bug-22206-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22206-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22206-70-YKPa66tkK4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 Bug 22206 depends on bug 20006, which changed state. Bug 20006 Summary: Adapt /v1/holds to new naming guidelines https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20006 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 11:52:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 10:52:44 +0000 Subject: [Koha-bugs] [Bug 22218] Make endpoints not in /public require privileged credentials [OMNIBUS] In-Reply-To: <bug-22218-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22218-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22218-70-xaft0ig8R6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22218 Bug 22218 depends on bug 20006, which changed state. Bug 20006 Summary: Adapt /v1/holds to new naming guidelines https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20006 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 11:52:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 10:52:51 +0000 Subject: [Koha-bugs] [Bug 20006] Adapt /v1/holds to new naming guidelines In-Reply-To: <bug-20006-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20006-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20006-70-ZJk24cQ82A@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20006 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 11:52:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 10:52:57 +0000 Subject: [Koha-bugs] [Bug 20006] Adapt /v1/holds to new naming guidelines In-Reply-To: <bug-20006-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20006-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20006-70-CmbSSh5j4w@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20006 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 11:53:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 10:53:03 +0000 Subject: [Koha-bugs] [Bug 20006] Adapt /v1/holds to new naming guidelines In-Reply-To: <bug-20006-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20006-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20006-70-sSJ7UwjugX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20006 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 11:54:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 10:54:38 +0000 Subject: [Koha-bugs] [Bug 20006] Adapt /v1/holds to new naming guidelines In-Reply-To: <bug-20006-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20006-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20006-70-DE3082U87b@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20006 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Stable --- Comment #29 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- I decided to backport this in the end. As per my policy of backporting new/enhanced API endpoints where it's simple to do so. I believe, although this is a breaking change, it's better to get this change in early and people less people to adapt to it now rather than leave it to be adapted later once more people are using the API's. Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 11:55:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 10:55:11 +0000 Subject: [Koha-bugs] [Bug 22206] Add route to handle holds suspensions In-Reply-To: <bug-22206-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22206-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22206-70-2AvGXoeijo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- As per my policy of backporting new API routes, Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 11:55:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 10:55:38 +0000 Subject: [Koha-bugs] [Bug 20782] EDI: Clicking the 'Invoice' link on the 'EDI Messages' page does not take you directly to the corresponding invoice In-Reply-To: <bug-20782-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20782-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20782-70-y85PRRM82a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20782 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 11:55:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 10:55:53 +0000 Subject: [Koha-bugs] [Bug 20782] EDI: Clicking the 'Invoice' link on the 'EDI Messages' page does not take you directly to the corresponding invoice In-Reply-To: <bug-20782-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20782-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20782-70-USKtH2d7KH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20782 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 11:56:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 10:56:20 +0000 Subject: [Koha-bugs] [Bug 20782] EDI: Clicking the 'Invoice' link on the 'EDI Messages' page does not take you directly to the corresponding invoice In-Reply-To: <bug-20782-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20782-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20782-70-IplRBm791a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20782 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 11:57:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 10:57:59 +0000 Subject: [Koha-bugs] [Bug 18952] Show internal note in acquisitions details tab In-Reply-To: <bug-18952-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18952-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18952-70-YMVLz7tR4v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18952 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |RESOLVED --- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 11:59:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 10:59:47 +0000 Subject: [Koha-bugs] [Bug 20658] Move template JavaScript to the footer: Installer and onboarding In-Reply-To: <bug-20658-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20658-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20658-70-KILXXQTSEv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Severity|enhancement |trivial Status|Pushed to Master |Pushed to Stable --- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 12:00:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 11:00:26 +0000 Subject: [Koha-bugs] [Bug 22399] Improve responsive behavior of the basic marc editor In-Reply-To: <bug-22399-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22399-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22399-70-sV6tKHBNUp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 12:00:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 11:00:27 +0000 Subject: [Koha-bugs] [Bug 7890] Highlight required field in MARC editor In-Reply-To: <bug-7890-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7890-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7890-70-yJcaQj2WEP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7890 Bug 7890 depends on bug 22399, which changed state. Bug 22399 Summary: Improve responsive behavior of the basic marc editor https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 12:00:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 11:00:57 +0000 Subject: [Koha-bugs] [Bug 8775] Add collection code to lost report In-Reply-To: <bug-8775-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8775-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8775-70-cVQ2xVcn0j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8775 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |martin.renvoize at ptfs-europe | |.com --- Comment #19 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 12:00:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 11:00:58 +0000 Subject: [Koha-bugs] [Bug 22468] Standardize on labeling ccode table columns as Collection In-Reply-To: <bug-22468-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22468-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22468-70-jlJujOv9lR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22468 Bug 22468 depends on bug 8775, which changed state. Bug 8775 Summary: Add collection code to lost report https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8775 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 12:01:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 11:01:21 +0000 Subject: [Koha-bugs] [Bug 15911] Use noEnterSubmit CSS class instead of prevent_submit.js In-Reply-To: <bug-15911-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15911-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15911-70-35AiZQF59M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15911 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Enhancement, will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 12:02:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 11:02:34 +0000 Subject: [Koha-bugs] [Bug 22461] Regression in #20287: LDAP user replication broken with mapped extended patron attributes In-Reply-To: <bug-22461-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22461-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22461-70-gZXc4lHXOF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22461 Oliver Behnke <oliver.behnke at aei.mpg.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #6 from Oliver Behnke <oliver.behnke at aei.mpg.de> --- Hi Jonathan, thanks for the patch which should fix what I described in comments 1 and 2. What it doesn't resolve, though, is what's stated in the original bug description (see "presumed cause"), so the reported error persists. Oliver -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 12:02:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 11:02:58 +0000 Subject: [Koha-bugs] [Bug 21070] request.pl details links to biblio instead of moredetail.pl for that item In-Reply-To: <bug-21070-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21070-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21070-70-beoApskppa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21070 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |martin.renvoize at ptfs-europe | |.com --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Enhancement, will not be backported to 18.11.x series. I like this change too.. be great to see the other templates Katrin mentions done for the 19.05 release :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 12:05:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 11:05:14 +0000 Subject: [Koha-bugs] [Bug 21832] Restore is_expired in ILS-DI GetPatronInfo service In-Reply-To: <bug-21832-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21832-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21832-70-Ct26pC9IDq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21832 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #22 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 12:06:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 11:06:12 +0000 Subject: [Koha-bugs] [Bug 21756] Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead) In-Reply-To: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21756-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21756-70-2VkJNpI2s9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #118 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 12:06:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 11:06:12 +0000 Subject: [Koha-bugs] [Bug 21683] Remove accountlines.accountno In-Reply-To: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21683-70-mThMf1TSzo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Bug 21683 depends on bug 21756, which changed state. Bug 21756 Summary: Deprecate C4::Accounts::manualinvoice (use Koha::Account->add_debit instead) https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21756 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 12:06:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 11:06:45 +0000 Subject: [Koha-bugs] [Bug 22023] Further improve responsive layout handling of staff client menu bar In-Reply-To: <bug-22023-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22023-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22023-70-1mhkAZLDYE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22023 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |RESOLVED --- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 12:06:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 11:06:46 +0000 Subject: [Koha-bugs] [Bug 14546] Make staff client templates responsive In-Reply-To: <bug-14546-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14546-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14546-70-fRp6rllrdh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14546 Bug 14546 depends on bug 22023, which changed state. Bug 22023 Summary: Further improve responsive layout handling of staff client menu bar https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22023 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 12:07:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 11:07:20 +0000 Subject: [Koha-bugs] [Bug 22454] Add Koha::Item::hidden_in_opac method In-Reply-To: <bug-22454-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22454-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22454-70-VGojOD5O4D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22454 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |RESOLVED --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 12:07:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 11:07:43 +0000 Subject: [Koha-bugs] [Bug 22455] Add Koha::Biblio::hidden_in_opac method In-Reply-To: <bug-22455-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22455-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22455-70-TxOzPNBgvc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22455 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 12:07:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 11:07:21 +0000 Subject: [Koha-bugs] [Bug 22455] Add Koha::Biblio::hidden_in_opac method In-Reply-To: <bug-22455-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22455-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22455-70-3d4pC4sMNN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22455 Bug 22455 depends on bug 22454, which changed state. Bug 22454 Summary: Add Koha::Item::hidden_in_opac method https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22454 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 12:08:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 11:08:52 +0000 Subject: [Koha-bugs] [Bug 19417] Improve display of errors from background job during stage for import In-Reply-To: <bug-19417-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19417-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19417-70-57d1nKCyuP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19417 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to Master |RESOLVED --- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 12:14:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 11:14:35 +0000 Subject: [Koha-bugs] [Bug 22440] ILL API response objects inconsistent with other endpoints In-Reply-To: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22440-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22440-70-YsFjlGttfp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19774 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19774 [Bug 19774] Adapt existing endpoints to new naming guidelines OMNIBUS -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 12:14:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 11:14:35 +0000 Subject: [Koha-bugs] [Bug 19774] Adapt existing endpoints to new naming guidelines OMNIBUS In-Reply-To: <bug-19774-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19774-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19774-70-YUU5BF9ePP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19774 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22440 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440 [Bug 22440] ILL API response objects inconsistent with other endpoints -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 12:30:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 11:30:25 +0000 Subject: [Koha-bugs] [Bug 22536] Display problem in Holds to Pull report In-Reply-To: <bug-22536-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22536-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22536-70-ikbiqE6HuU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22536 Fiona Borthwick <fiona.borthwick at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 13:23:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 12:23:28 +0000 Subject: [Koha-bugs] [Bug 22536] Display problem in Holds to Pull report In-Reply-To: <bug-22536-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22536-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22536-70-759UqTr17k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22536 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Status|NEW |ASSIGNED Version|18.11 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 13:54:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 12:54:09 +0000 Subject: [Koha-bugs] [Bug 22536] Display problem in Holds to Pull report In-Reply-To: <bug-22536-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22536-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22536-70-Cj4eftIKPl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22536 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 86738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86738&action=edit Bug 22536: Display problem in Holds to Pull report This patch modifies the display of several values in the holds to pull report so that they can be displayed as lists instead of as chunks of HTML generated in SQL. This patch modifies the SQL in pendingreserves.pl so that values can be formatted in the same way that holding branch is. The better long-term solution is to remove SQL from pendingreserves.pl altogether, but this is a quick fix. This patch also makes a couple of minor markup changes to fix validation. To test, apply the patch and go to Circulation -> Holds to pull. To see the changes the patch makes your holds to pull list should have titles with multiple items at multiple branches, with call number, copy number, and enumeration data. These values should all be displayed in bulleted lists. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 13:54:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 12:54:06 +0000 Subject: [Koha-bugs] [Bug 22536] Display problem in Holds to Pull report In-Reply-To: <bug-22536-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22536-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22536-70-RbTsBd1Gu5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22536 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 14:10:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 13:10:08 +0000 Subject: [Koha-bugs] [Bug 22032] Improve local cover image tab on detail page In-Reply-To: <bug-22032-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22032-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22032-70-pid2gTTGL5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22032 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86128|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 86739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86739&action=edit Bug 22032: Improve local cover image tab on detail page This patch makes a variety of improvements to the images tab of the staff client's bibliographic detail page. To test, apply the patch and regenerate the staff client CSS. - Enable the LocalCoverImages system preference. - Locate a bibliographic record which has no images attached. - There should be a "no images" message and an upload button. - Upload an image and return to the detail page. - The "Images" tab should have a nicely-styled thumbnail of the image you uploaded. - Test the "Delete image" link: It should ask for a confirmation. If you confirm, the image should disappear and a "loading" spinner should appear. - When the image has been deleted the thumbnail container should disappear and the "no images" message should reappear. - Test this process with AllowMultipleCovers enabled and disabled. Extra credit: Modify the AJAX url in the removeLocalImage function in detail.tt. After misspelling a parameter name or the URL path, clicking the "Delete image" link should trigger an alert and re-show the image thumbnail. Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 14:17:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 13:17:09 +0000 Subject: [Koha-bugs] [Bug 19380] Add transfer informations in ILS-DI GetRecords response In-Reply-To: <bug-19380-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19380-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19380-70-AoVcTIIAf7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19380 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #67577|0 |1 is obsolete| | --- Comment #5 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 86740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86740&action=edit Bug 19380: Add transfer informations in ILS-DI GetRecords response Test plan: 1. Put an item into a 'transfer' state a. Place a hold on an item in branch A for a patron of branch B b. Check in this item in branch A and confirm transfer 2. Go to http://opac/cgi-bin/koha/ilsdi.pl?service=GetRecords&id=XXX where XXX is the biblionumber of the biblio the item belongs to. 3. Verify you have a new <transfer> element inside //record/items/item that contains <datesent>, <frombranch> and <tobranch> 4. Check in the same item in branch B, so that the item is not flagged as being transferred 5. Repeat 2 6. Verify that the <transfer> element is not there. 7. prove t/db_dependent/ILSDI_Services.t Followed test plan, patch worked as described. Also ran QA test tools and modified files passed Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 14:17:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 13:17:13 +0000 Subject: [Koha-bugs] [Bug 19380] Add transfer informations in ILS-DI GetRecords response In-Reply-To: <bug-19380-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19380-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19380-70-5EbIyUv6Ci@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19380 --- Comment #6 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 86741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86741&action=edit Bug 19380: Use Koha::Item::get_transfer instead of GetTransfers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 14:18:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 13:18:09 +0000 Subject: [Koha-bugs] [Bug 19380] Add transfer informations in ILS-DI GetRecords response In-Reply-To: <bug-19380-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19380-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19380-70-HUDNWlJ0i6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19380 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #7 from Julian Maurice <julian.maurice at biblibre.com> --- Patch rebased on master + comment 3 addressed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 14:22:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 13:22:36 +0000 Subject: [Koha-bugs] [Bug 17851] Add elasticsearch config to koha-conf.xml In-Reply-To: <bug-17851-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17851-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17851-70-ve45fmmRGc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17851 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED QA Contact|tomascohen at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 14:22:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 13:22:45 +0000 Subject: [Koha-bugs] [Bug 17851] Add elasticsearch config to koha-conf.xml In-Reply-To: <bug-17851-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17851-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17851-70-0O954IG700@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17851 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 14:22:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 13:22:54 +0000 Subject: [Koha-bugs] [Bug 17851] Add elasticsearch config to koha-conf.xml In-Reply-To: <bug-17851-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17851-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17851-70-QLmbdFdx2Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17851 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 14:23:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 13:23:35 +0000 Subject: [Koha-bugs] [Bug 17851] Add elasticsearch config to koha-conf.xml In-Reply-To: <bug-17851-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17851-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17851-70-kBhZwOPmL1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17851 --- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- There's already <elasticsearch> in the koha-conf.xml* files. But you should recover the changes to Makefile.PL on this patchset, Olli. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 14:24:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 13:24:18 +0000 Subject: [Koha-bugs] [Bug 19670] search_marc_map.marc_field should have COLLATE= utf8mb4_bin In-Reply-To: <bug-19670-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19670-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19670-70-DXvkDygElY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19670 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|search_marc_map.marc_field |search_marc_map.marc_field |should have |should have COLLATE= |COLLATE=utf8_bin |utf8mb4_bin CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 14:38:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 13:38:26 +0000 Subject: [Koha-bugs] [Bug 18306] "Renew selected" and "renew all" in OPAC can be confusing for users not allowed to do it In-Reply-To: <bug-18306-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18306-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18306-70-AVNttjM1wc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18306 --- Comment #8 from Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> --- Still valid in 18.05 Marjorie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 14:44:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 13:44:51 +0000 Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference In-Reply-To: <bug-18532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18532-70-jP4TMmzsJp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Catherine E. Ingram <catherine.ingram at cedarparktexas.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |catherine.ingram at cedarparkt | |exas.gov --- Comment #2 from Catherine E. Ingram <catherine.ingram at cedarparktexas.gov> --- Please please please make it so patrons can Digest the auto renew emails. When you get 30 or more emails in one day it is obnoxious. I get MANY patron complaints about this. Is there any development on this? We could maybe help out with that financially. Catherine Ingram Cedar Park Public Library, TX -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 14:44:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 13:44:58 +0000 Subject: [Koha-bugs] [Bug 19736] Add a digest option for AUTO_RENEWALS Notice In-Reply-To: <bug-19736-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19736-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19736-70-d20VDAEPjp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19736 Catherine E. Ingram <catherine.ingram at cedarparktexas.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |catherine.ingram at cedarparkt | |exas.gov --- Comment #2 from Catherine E. Ingram <catherine.ingram at cedarparktexas.gov> --- Please please please make it so patrons can Digest the auto renew emails. When you get 30 or more emails in one day it is obnoxious. I get MANY patron complaints about this. Is there any development on this? We could maybe help out with that financially. Catherine Ingram Cedar Park Public Library, TX -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 14:58:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 13:58:53 +0000 Subject: [Koha-bugs] [Bug 22537] New: Suspend all hold button appears even if the hold can no longer be suspended. Message-ID: <bug-22537-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22537 Bug ID: 22537 Summary: Suspend all hold button appears even if the hold can no longer be suspended. Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: marjorie.barry-vila at collecto.ca QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Created attachment 86742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86742&action=edit suspend_hold Hi, I understand that a hold can not be suspended when it is awaiting for pickup. This is why the Suspend column is empty in the opac user's account. However, "Suspend all holds" button still appears and causes misunderstanding. Nothing happens when you click on the button but the user thinks that his hold has been suspended. See image attached. Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 14:59:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 13:59:14 +0000 Subject: [Koha-bugs] [Bug 22537] Suspend all hold button appears even if the hold can no longer be suspended. In-Reply-To: <bug-22537-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22537-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22537-70-3dPhbnsVqg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22537 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 15:03:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 14:03:57 +0000 Subject: [Koha-bugs] [Bug 22318] Extend Koha news feature to include other content areas In-Reply-To: <bug-22318-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22318-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22318-70-ZRM2Ki1GZV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 15:04:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 14:04:00 +0000 Subject: [Koha-bugs] [Bug 22318] Extend Koha news feature to include other content areas In-Reply-To: <bug-22318-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22318-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22318-70-nZyrFmtDe9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 --- Comment #14 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 86743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86743&action=edit Bug 22318: (follow-up) Add new options to new table filter form This patch adds the new language/location options to the form for filtering entries in the table of news items. Since this markup is duplicated twice in the template, its contents have been moved to a BLOCK. To test, apply the patch and go to Tools -> News. At the top of the table of news items the "Display location" form should show all options including OpacNavRight for all your enabled languages. Confirm that location/language selection still works correctly upon adding and editing news items. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 15:05:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 14:05:04 +0000 Subject: [Koha-bugs] [Bug 22538] New: Add a noticeable alert about waiting holds Message-ID: <bug-22538-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22538 Bug ID: 22538 Summary: Add a noticeable alert about waiting holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Self checkout Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Work to be done: - Add an alert red symbol to the holds tab in SCO (maybe <i class="fas fa-exclamation"></i>) if there are waiting holds. - Inside the holds tab, mark somehow those waiting holds in a noticeable way. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 15:06:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 14:06:22 +0000 Subject: [Koha-bugs] [Bug 22538] Add a noticeable alert about waiting holds In-Reply-To: <bug-22538-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22538-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22538-70-DyzXaoQ0ke@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22538 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored Depends on| |21772 Assignee|koha-bugs at lists.koha-commun |agustinmoyano at theke.io |ity.org | CC| |joy at bywatersolutions.com, | |wizzyrea at gmail.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 [Bug 21772] Add holds and account information tab to the SCO module -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 15:06:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 14:06:22 +0000 Subject: [Koha-bugs] [Bug 21772] Add holds and account information tab to the SCO module In-Reply-To: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21772-70-oJ2cx87uNx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22538 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22538 [Bug 22538] Add a noticeable alert about waiting holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 15:06:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 14:06:31 +0000 Subject: [Koha-bugs] [Bug 22538] Add a noticeable alert about waiting holds In-Reply-To: <bug-22538-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22538-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22538-70-XAssEnoMne@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22538 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 15:12:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 14:12:44 +0000 Subject: [Koha-bugs] [Bug 20551] Add option for including deleted records in export_records.pl In-Reply-To: <bug-20551-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20551-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20551-70-KybhNOptlA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20551 Frank Hansen <frank.hansen at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frank.hansen at ub.lu.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 15:17:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 14:17:05 +0000 Subject: [Koha-bugs] [Bug 22531] Allow for multiple requests to partners and display partners in audit log In-Reply-To: <bug-22531-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22531-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22531-70-d6AwAkE9Vg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 --- Comment #2 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 86744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86744&action=edit Bug 22531: Add unit tests Add tests for new and modified methods -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 15:16:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 14:16:38 +0000 Subject: [Koha-bugs] [Bug 13763] Renew feature does not check for the BarcodeInputFilter option In-Reply-To: <bug-13763-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13763-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13763-70-P8tZCdTGME@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13763 Bin <bin.wen at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #8 from Bin <bin.wen at inlibro.com> --- Sorry, I found that I made a wrong step in my understanding. There is no problem with the patch and test plan, which worked well? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 15:18:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 14:18:56 +0000 Subject: [Koha-bugs] [Bug 13763] Renew feature does not check for the BarcodeInputFilter option In-Reply-To: <bug-13763-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13763-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13763-70-bkgYZ6h0PB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13763 Bin <bin.wen at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86594|0 |1 is obsolete| | --- Comment #9 from Bin <bin.wen at inlibro.com> --- Created attachment 86745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86745&action=edit Bug 13763: Added check for filter syspref in renew.pl In Circulation->Renew, the renew feature does not check the system preference itemBarcodeFilter to see whether the barcode needs to be converted. This patch fixes this, adding a check for the system pref and applying it accordingly to convert the barcode if it is needed. Test plan: 1) In Circulation->Renew, enter a barcode that you know exists in the catalogue but add extra spaces, breaking up the barcode. Note that this fails with a warning that says 'No item matches this barcode' 2) In system Preferences, set the itemBarcodeInputFilter pref to Remove spaces and repeat step1. Note that the result is the same as in step 1 3) Apply the patch 4) Repeat step 1, and note that the filter removes the spaces and the item is renewed (or gives an error that indicates it recognises the barcode) Sponsored-by: Catalyst IT Signed-off-by: Bin Wen <bin.wen at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 15:19:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 14:19:18 +0000 Subject: [Koha-bugs] [Bug 22539] New: Fines charged on back-dated checkin when item has been renewed Message-ID: <bug-22539-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22539 Bug ID: 22539 Summary: Fines charged on back-dated checkin when item has been renewed Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- In a certain niche situation, a patron can end up with an unexpected fine due to renewing a book just prior to returning it. Here's the situation: - Patron has a book due on a Saturday and doesn't return it - On Sunday, the library is closed - Early Sunday morning, the fines cron generates an accruing fine on the item - Patron puts the item in the bookdrop on Sunday - Patron renews the item via the OPAC on Sunday - At renewal, the fine changes from FU to F - Monday morning, the item is checked in via bookdrop mode, which back-dates the checkin to Saturday According to the old_issues table, the item was checked in before any fine was charged, but the fine remains on the patron's account. If the patron had not renewed the item, the fine would have remained FU and would have been forgiven on checkin. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 15:20:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 14:20:30 +0000 Subject: [Koha-bugs] [Bug 22539] Fines charged on back-dated checkin when item has been renewed In-Reply-To: <bug-22539-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22539-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22539-70-E2hZgUENwB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22539 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com, | |nick at bywatersolutions.com, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 15:21:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 14:21:14 +0000 Subject: [Koha-bugs] [Bug 22456] Customers Cancelling their Pending Holds In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22456-70-LEZbkpFyXF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 15:23:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 14:23:51 +0000 Subject: [Koha-bugs] [Bug 22538] Add a noticeable alert about waiting holds In-Reply-To: <bug-22538-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22538-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22538-70-16WVCq4ix5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22538 Sarah Cornell <sbcornell at cityofportsmouth.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbcornell at cityofportsmouth. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 15:25:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 14:25:27 +0000 Subject: [Koha-bugs] [Bug 22531] Allow for multiple requests to partners and display partners in audit log In-Reply-To: <bug-22531-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22531-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22531-70-TirD4s0gMR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #3 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Test plan: - Ensure you have at least two "partners" set up. These are patrons in the category defined in <interlibrary_loans> -> <partner_code> in koha-conf.xml, the patrons must also have a primary email address defined. - Create an ILL request using the FreeForm backend - From the "Manage ILL request" screen, select "Place request with partners" - In "Select partner libraries" choose one partner library, then click "Send email" - From the "Manage ILL request" screen, select "ILL request log" => TEST: Observe that the status was changed *to* "Requested from partners (first_partner_email_address_here) - From the "Manage ILL request" screen, select "Place request with partners" - In "Select partner libraries" choose a different partner library, then click "Send email" - From the "Manage ILL request" screen, select "ILL request log" => TEST: Observe that the status was changed *from* "Requested from partners (first_partner_email_address_here) => TEST: Observe that the status was changed *TO* "Requested from partners (second_partner_email_address_here) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 15:28:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 14:28:18 +0000 Subject: [Koha-bugs] [Bug 22531] Allow for multiple requests to partners and display partners in audit log In-Reply-To: <bug-22531-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22531-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22531-70-qremCAQqzd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531 --- Comment #4 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Test plan: (ignore the plan in comment #3) - Ensure you have at least two "partners" set up. These are patrons in the category defined in <interlibrary_loans> -> <partner_code> in koha-conf.xml, the patrons must also have a primary email address defined. - Create an ILL request using the FreeForm backend - From the "Manage ILL request" screen, select "Place request with partners" - In "Select partner libraries" choose one partner library, then click "Send email" - Go to the "Manage ILL request" screen => TEST: Observe that the request "Status" is "Requested from partners : first_partner_email_address_here" => TEST: Observe that the first_partner_email_address links to the appropriate patron screen - From the "Manage ILL request" screen, select "ILL request log" => TEST: Observe that the status was changed *to* "Requested from partners (first_partner_email_address_here) - From the "Manage ILL request" screen, select "Place request with partners" - In "Select partner libraries" choose a different partner library, then click "Send email" - From the "Manage ILL request" screen, select "ILL request log" => TEST: Observe that the status was changed *from* "Requested from partners (first_partner_email_address_here) => TEST: Observe that the status was changed *TO* "Requested from partners (second_partner_email_address_here) => TEST: Observe that the email addresses displayed link to the appropriate patron page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 15:39:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 14:39:27 +0000 Subject: [Koha-bugs] [Bug 20360] Auto-Renew notices send in advance of No Renewal Before period In-Reply-To: <bug-20360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20360-70-GrK8YuWn06@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20360 Ray Delahunty <r.delahunty at arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty at arts.ac.uk --- Comment #8 from Ray Delahunty <r.delahunty at arts.ac.uk> --- Almost 3 years after going live with auto-renewals, including our workaround to deal with bug 19014 we have this very day found that the RenewalPeriodBase was set wrongly (left set the "current date", which was sensible for a manual renewal environment, but is I think NOT sensible for an auto-renewal one). This variable has had an impact on renewal timings and renewal outcomes. Our calendar has Sa/Su as closed days, items being 7 day loans, the No Renewal Before set to 1, and auto-renewal running at 10pm Mo-Su. These variables coupled with the wrong RenewalBasePeriod has seen the loan period on renewal drop a day, until the Monday is reached and then the Sunday closure is seen and items renew every Monday for 7 days from then on. So many variables interact with auto-renewal functionality it is challenging to get then all "right". We are about to look at 18.11 to see how many bug fixes have made it there, up from our 17.05 version (especially bug 19014). But if unexpected timing puzzles are happening, it might be worthwhile checking the RenewalBasePeriod setting to see if it is set correctly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 15:41:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 14:41:26 +0000 Subject: [Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future In-Reply-To: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19014-70-wYGSFZfRrT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 --- Comment #21 from Ray Delahunty <r.delahunty at arts.ac.uk> --- Almost 3 years after going live with auto-renewals, including our workaround to deal with this bug we have this very day found that the RenewalPeriodBase was set wrongly (left set the "current date", which was sensible for a manual renewal environment, but is I think NOT sensible for an auto-renewal one). This variable has had an impact on renewal timings and renewal outcomes. Our calendar has Sa/Su as closed days, items being 7 day loans, the No Renewal Before set to 1, and auto-renewal running at 10pm Mo-Su. These variables coupled with the wrong RenewalBasePeriod has seen the loan period on renewal drop a day, until the Monday is reached and then the Sunday closure is seen and items renew every Monday for 7 days from then on. So many variables interact with auto-renewal functionality it is challenging to get then all "right". We are about to look at 18.11 to see how many bug fixes have made it there, up from our 17.05 version. But if unexpected timing puzzles are happening, it might be worthwhile checking the RenewalBasePeriod setting to see if it is set correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 15:47:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 14:47:17 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20817-70-gl5NEqEcOE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 15:47:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 14:47:20 +0000 Subject: [Koha-bugs] [Bug 20817] Add ability to retain 9xx fields when adding on order item to existing record In-Reply-To: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20817-70-PNzRPSUy1R@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20817 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86711|0 |1 is obsolete| | --- Comment #8 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86746&action=edit Bug 20817: Add ability to retain 9xx fields when adding on order item to existing record Signed-off-by: Liz Rea <wizzyrea at gmail.com> https://bugs.koha-community.org/show_bug.cgi?id=20187 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 15:50:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 14:50:40 +0000 Subject: [Koha-bugs] [Bug 22537] Suspend all hold button appears even if the hold can no longer be suspended. In-Reply-To: <bug-22537-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22537-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22537-70-NW5cKhjZGI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22537 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 15:50:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 14:50:43 +0000 Subject: [Koha-bugs] [Bug 22537] Suspend all hold button appears even if the hold can no longer be suspended. In-Reply-To: <bug-22537-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22537-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22537-70-x5YWLsBegf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22537 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 86747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86747&action=edit Bug 22537: Suspend all hold button appears even if the hold can no longer be suspended. This patch adds to the user summary page in the OPAC a check for waiting or in-transit holds. If all holds are waiting or in transit the "Suspend all" controls will be hidden. This patch also adds a missing $KohaDates filter to the "suspended until" date. To test, apply the patch and log in to the OPAC as a patron with holds. Test these conditions: - All holds are waiting and/or in transit - The "Suspend holds" controls at the bottom of the page should not appear. - Some holds are waiting and/or in transit - The "Suspend holds" controls should appear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 15:50:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 14:50:55 +0000 Subject: [Koha-bugs] [Bug 22537] Suspend all hold button appears even if the hold can no longer be suspended. In-Reply-To: <bug-22537-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22537-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22537-70-AjXZsKMTzh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22537 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.05 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 15:56:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 14:56:03 +0000 Subject: [Koha-bugs] [Bug 22456] Customers Cancelling their Pending Holds In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22456-70-MsWSJiJZW7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Sally Healey <sally.healey at cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 16:01:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 15:01:48 +0000 Subject: [Koha-bugs] [Bug 22203] Holds modal no longer links to patron In-Reply-To: <bug-22203-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22203-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22203-70-zRbVvgIc2L@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22203 Lisette Scheer <lisetteslatah at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 16:21:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 15:21:15 +0000 Subject: [Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future In-Reply-To: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19014-70-yHj7ea6PK2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #22 from Liz Rea <wizzyrea at gmail.com> --- I'd like to test what's here, but don't want to waste the time if it's just going to be superceded. If no one is going to submit a counterpatch in the very near term, this looks like it will be an improvement and the patch probably needs attention so as not to waste Jonathan's work. For the record, it still applies and I plan to test it in the very near term, unless someone says "no here is my go at fixing this." Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 16:25:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 15:25:36 +0000 Subject: [Koha-bugs] [Bug 22540] New: Add ability to place holds using SIP CLI emulator Message-ID: <bug-22540-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22540 Bug ID: 22540 Summary: Add ability to place holds using SIP CLI emulator Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: SIP2 Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Target Milestone: --- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 16:26:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 15:26:11 +0000 Subject: [Koha-bugs] [Bug 22540] Add ability to place holds using SIP CLI emulator In-Reply-To: <bug-22540-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22540-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22540-70-GG9srlmkaP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22540 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 16:26:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 15:26:14 +0000 Subject: [Koha-bugs] [Bug 22540] Add ability to place holds using SIP CLI emulator In-Reply-To: <bug-22540-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22540-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22540-70-MYiJfEY4zU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22540 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 86748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86748&action=edit Bug 22540 - Add ability to place holds using SIP CLI emulator Test Plan: 1) Place a hold using the following arguments: sip_cli_emulator.pl -a <address> -p <port> -su <sip_user> -sp <sip_password> -l <location_code> --patron <cardnumber> --item <barcode> -m hold 2) Note the hold was placed in Koha -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 16:26:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 15:26:20 +0000 Subject: [Koha-bugs] [Bug 22540] Add ability to place holds using SIP CLI emulator In-Reply-To: <bug-22540-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22540-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22540-70-WtQ8TLU71a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22540 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 16:27:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 15:27:27 +0000 Subject: [Koha-bugs] [Bug 22537] Suspend all hold button appears even if the hold can no longer be suspended. In-Reply-To: <bug-22537-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22537-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22537-70-7OhwoXeodA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22537 sandboxes at biblibre.com <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86747|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 16:27:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 15:27:35 +0000 Subject: [Koha-bugs] [Bug 22537] Suspend all hold button appears even if the hold can no longer be suspended. In-Reply-To: <bug-22537-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22537-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22537-70-KRR2TuqSL1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22537 --- Comment #3 from sandboxes at biblibre.com <sandboxes at biblibre.com> --- Created attachment 86749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86749&action=edit Bug 22537: Suspend all hold button appears even if the hold can no longer be suspended. This patch adds to the user summary page in the OPAC a check for waiting or in-transit holds. If all holds are waiting or in transit the "Suspend all" controls will be hidden. This patch also adds a missing $KohaDates filter to the "suspended until" date. To test, apply the patch and log in to the OPAC as a patron with holds. Test these conditions: - All holds are waiting and/or in transit - The "Suspend holds" controls at the bottom of the page should not appear. - Some holds are waiting and/or in transit - The "Suspend holds" controls should appear. Signed-off-by: Marjorie <marjorie.barry-vila at collecto.ca> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 16:27:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 15:27:11 +0000 Subject: [Koha-bugs] [Bug 22537] Suspend all hold button appears even if the hold can no longer be suspended. In-Reply-To: <bug-22537-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22537-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22537-70-XkgMsoJOvU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22537 sandboxes at biblibre.com <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |sandboxes at biblibre.com --- Comment #2 from sandboxes at biblibre.com <sandboxes at biblibre.com> --- Patch tested with a sandbox, by Marjorie <marjorie.barry-vila at collecto.ca> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 16:28:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 15:28:26 +0000 Subject: [Koha-bugs] [Bug 22540] Add ability to place holds using SIP CLI emulator In-Reply-To: <bug-22540-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22540-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22540-70-ohLS2W1Zh2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22540 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86748|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 86750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86750&action=edit Bug 22540 - Add ability to place holds using SIP CLI emulator Test Plan: 1) Place a hold using the following arguments: sip_cli_emulator.pl -a <address> -p <port> -su <sip_user> -sp <sip_password> -l <location_code> --patron <cardnumber> --item <barcode> -m hold 2) Note the hold was placed in Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 16:29:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 15:29:55 +0000 Subject: [Koha-bugs] [Bug 22540] Add ability to place holds using SIP CLI emulator In-Reply-To: <bug-22540-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22540-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22540-70-xbdXjiMfz0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22540 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86750|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 86751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86751&action=edit Bug 22540 - Add ability to place holds using SIP CLI emulator Test Plan: 1) Place a hold using the following arguments: sip_cli_emulator.pl -a <address> -p <port> -su <sip_user> -sp <sip_password> -l <location_code> --patron <cardnumber> --item <barcode> -m hold 2) Note the hold was placed in Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 16:38:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 15:38:56 +0000 Subject: [Koha-bugs] [Bug 22250] Clean up Mana KB integration with serials and reports In-Reply-To: <bug-22250-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22250-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22250-70-wTb2i2HTxs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22250 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86397|0 |1 is obsolete| | --- Comment #5 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 86752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86752&action=edit Bug 22250: Clean up Mana KB integration with serials and reports This patch makes many changes to templates and JavaScript related to the integration of Mana with serials reports: - Many incorrect uses of the raw filter with html - Corrections to Bootstrap modal markup - Untranslatable strings moved out of JavaScript - Removed markup and JavaScript related to reports comments, a feature which doesn't exist in this version. New include file: mana/mana-comment-status.inc This file contains hidden-by-default messages which are shown during the process of submitting a comment on a subscription. New include file: mana/mana-share-report.inc This file contains the "Share report" modal markup formerly in guided_reports_start.tt New JavaScript file: mana.js Previously mana.inc, an include file containing only JavaScript which didn't include any template processing. Changed: mana/mana-report-search-result.inc This include file is now a full template so that jQuery's load() function can be used to pull its contents into the reports search modal. Changed: svc/mana/search This script was returning json-encoded HTML. Now it returns regular HTML. To test you must have Mana configured and enabled. Apply the patch and go to Reports -> Saved reports. - Choose New report -> New SQL from Mana. A "Mana search" modal should appear. - Perform a search which will return results, e.g. "circulation." - A "Loading" indicator should appear while the results are being retrieved. It should disappear when results appear. - Results should appear in the DataTable with sorting, paging, and search options. - In the "Notes" column, notes longer than 200 characters should be truncated with a "Show more" link. Clicking it should expand the comment and reveal a "Show less" link in its place. - Click the "Import" button (previously "Use"). The button icon should change to a loading indicator. - When the import is complete you should be redirected to a view of your new report. Go to Serials and click the "Search on Mana" link in the sidebar. - Perform a search for a serial - Results should appear in a DataTable with sorting, paging, and search options. - Sorting by title should ignore articles "a," "an," and "the." Create a new subscription or edit an existing subscription which will match a record in Mana. - On the second step of adding/editing the subscription a message should appear at the top of the form, "Searching for subscription in Mana Knowledge Base," with a loading icon. - When searching has completed a "Show Mana results" link should appear. - Clicking the link should trigger a modal showing search results which match your subscription, displayed in a DataTable with sorting, paging, and search options. - The last column of the table should contain "Import" and "Report" buttons. - Clicking the "Report" button should trigger a menu. Any existing comments will be listed as well as a "New comment" item. - Clicking an existing comment should cause the menu to close and a "Submitting comment" message to appear. It should be shortly replaced with a "Your comment has been submitted" message. - Clicking "New comment" should reveal a comment form. - It should not be possible to submit an empty comment. - Clicking the "cancel" link should redisplay the search results. - Submitting a new comment should trigger a "Submitting comment" message followed by a "Your comment has been submitted" message. - In the table of search results, click the "Import" button (previously "Use"). The button icon should change to a loading indicator. - The modal should close and the data from Mana should be loaded into the subscription entry form. View the detail page of a subscription which has saved with Mana data. - There should be a "Report mistake" button in the toolbar. Clicking it should reveal a menu of comments like the one you saw previously. - Clicking an existing comment should cause the menu to close and a "Submitting comment" message to appear. It should be shortly replaced with a "Your comment has been submitted" message. - Clicking "New comment" should reveal a comment form modal. - It should not be possible to submit an empty comment. - Clicking the "cancel" link should hide the modal. - Submitting a new comment should trigger a "Submitting comment" message followed by a "Your comment has been submitted" message. Signed-off-by: Michal Denar <black23 at gmail.com> -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 16:40:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 15:40:24 +0000 Subject: [Koha-bugs] [Bug 22250] Clean up Mana KB integration with serials and reports In-Reply-To: <bug-22250-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22250-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22250-70-UCxLHLqlhL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22250 --- Comment #6 from Owen Leonard <oleonard at myacpl.org> --- Rebased. -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 16:52:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 15:52:06 +0000 Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap grid: Catalog In-Reply-To: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21304-70-XZNIbXALJa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 --- Comment #28 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 86753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86753&action=edit Bug 21304: (follow-up) Correct hc-sticky configuration This patch corrects the element passed to the hc-sticky plugin to define which element the floating toolbar sticks to. To test, apply the patch and perform a search in the staff client which will return multiple results. Confirm that scrolling down the page triggers the floating toolbar. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 16:52:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 15:52:02 +0000 Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap grid: Catalog In-Reply-To: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21304-70-Khk77AkuxU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 16:54:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 15:54:28 +0000 Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22456-70-rc4fIrilaG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.05 |master Summary|Customers Cancelling their |Allow patrons to cancel |Pending Holds |their waiting holds Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 17:08:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 16:08:48 +0000 Subject: [Koha-bugs] [Bug 22525] Navigation arrows on the bottom of Cataloging search pages In-Reply-To: <bug-22525-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22525-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22525-70-uQt1sQlGom@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22525 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 17:08:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 16:08:51 +0000 Subject: [Koha-bugs] [Bug 22525] Navigation arrows on the bottom of Cataloging search pages In-Reply-To: <bug-22525-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22525-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22525-70-exzYCWbbz2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22525 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 86754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86754&action=edit Bug 22525: Navigation arrows on the bottom of Cataloging search pages This patch adds a second set of pagination links to the cataloging search result page, at the bottom of the first set of search results. Also added is a horizontal rule after the second set of links in order to make it clearer that the links are for the search results above. To test, apply the patch and go to Cataloging. Perform a search which will return multiple pages of results. Confirm that the links work correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 17:17:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 16:17:10 +0000 Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22456-70-wEdmiVFkcn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Margaret <margaret at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |margaret at bywatersolutions.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 18:08:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 17:08:04 +0000 Subject: [Koha-bugs] [Bug 22203] Holds modal no longer links to patron In-Reply-To: <bug-22203-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22203-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22203-70-tRZRw2hnur@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22203 --- Comment #10 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Jonathan Druart from comment #9) > Nick, why did you set hide_patron_infos_if_needed=1? This was a copy/paste - reviewing how it works, this modal now respects the HidePatronName syspref - so while a change in behavior I think it should stand but am noting that effect here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 18:22:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 17:22:11 +0000 Subject: [Koha-bugs] [Bug 22525] Navigation arrows on the bottom of Cataloging search pages In-Reply-To: <bug-22525-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22525-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22525-70-jEveCjqIY0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22525 sandboxes at biblibre.com <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes at biblibre.com Status|Needs Signoff |Signed Off --- Comment #2 from sandboxes at biblibre.com <sandboxes at biblibre.com> --- Patch tested with a sandbox, by Marjorie <marjorie.barry-vila at collecto.ca> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 18:22:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 17:22:38 +0000 Subject: [Koha-bugs] [Bug 22525] Navigation arrows on the bottom of Cataloging search pages In-Reply-To: <bug-22525-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22525-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22525-70-nOCfCiRA90@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22525 --- Comment #3 from sandboxes at biblibre.com <sandboxes at biblibre.com> --- Created attachment 86755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86755&action=edit Bug 22525: Navigation arrows on the bottom of Cataloging search pages This patch adds a second set of pagination links to the cataloging search result page, at the bottom of the first set of search results. Also added is a horizontal rule after the second set of links in order to make it clearer that the links are for the search results above. To test, apply the patch and go to Cataloging. Perform a search which will return multiple pages of results. Confirm that the links work correctly. Signed-off-by: Marjorie <marjorie.barry-vila at collecto.ca> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 18:22:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 17:22:29 +0000 Subject: [Koha-bugs] [Bug 22525] Navigation arrows on the bottom of Cataloging search pages In-Reply-To: <bug-22525-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22525-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22525-70-GtDVj0KSW7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22525 sandboxes at biblibre.com <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86754|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 18:43:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 17:43:29 +0000 Subject: [Koha-bugs] [Bug 22533] maninvoice.pl is using deprecated maininvoice() method In-Reply-To: <bug-22533-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22533-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22533-70-j7KodJhbU3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22533 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |critical -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 18:44:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 17:44:44 +0000 Subject: [Koha-bugs] [Bug 22533] maninvoice.pl is using deprecated maininvoice() method In-Reply-To: <bug-22533-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22533-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22533-70-xj7NwbVFUu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22533 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com Severity|critical |blocker -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 18:51:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 17:51:47 +0000 Subject: [Koha-bugs] [Bug 22522] API authentication breaks with updated Mojolicious version In-Reply-To: <bug-22522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22522-70-YKVgPCkLIS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522 --- Comment #3 from Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> --- Created attachment 86756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86756&action=edit Bug 22522 - Update API specs' access in Auth.pm With newer versions of Mojolicious and its plugins, endpoints' specs could no longer be accessed, thus bypassing authorization checks and failing to validate query parameters. Test plan: 1. Without being logged in to Koha, access an endpoint directly (such as /api/v1/patrons/{patron_id}) 2. Notice results are received (which is bad since we're not authenticated) 3. Try again with an endpoint that accepts query parameters (such as /api/v1/patrons?firstname=something) 4. Notice that the query is not accepted (even with correct parameters) 5. Apply the patch 6. Repeat step 1 7. Notice that the access is denied 8. Login as a user with proper access rights 9. Repeat step 1 10. Notice that you can now get results 11. Repeat step 3 12. Notice that the query is now accepted 13. Repeat step 3 but with an absurd parameter 14. Notice the query is correctly rejected 15. Ideally, check if other API calls were not broken -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 18:53:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 17:53:53 +0000 Subject: [Koha-bugs] [Bug 22522] API authentication breaks with updated Mojolicious version In-Reply-To: <bug-22522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22522-70-Dl5XNI5HVd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522 Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86756|Bug 22522 - Update API |Fix for newer description|specs' access in Auth.pm |Mojolicious/OpenAPI | |versions --- Comment #4 from Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> --- Comment on attachment 86756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86756 Fix for newer Mojolicious/OpenAPI versions >From 9398e9ce1ddb545b031c4accad4148f743eddadd Mon Sep 17 00:00:00 2001 >From: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos at inLibro.com> >Date: Tue, 19 Mar 2019 11:55:45 -0400 >Subject: [PATCH] Bug 22522 - Update API specs' access in Auth.pm > >With newer versions of Mojolicious and its plugins, endpoints' specs >could no longer be accessed, thus bypassing authorization checks >and failing to validate query parameters. > >Test plan: >1. Without being logged in to Koha, access an endpoint directly > (such as /api/v1/patrons/{patron_id}) >2. Notice results are received (which is bad since we're not authenticated) >3. Try again with an endpoint that accepts query parameters > (such as /api/v1/patrons?firstname=something) >4. Notice that the query is not accepted (even with correct parameters) > >5. Apply the patch > >6. Repeat step 1 >7. Notice that the access is denied >8. Login as a user with proper access rights >9. Repeat step 1 >10. Notice that you can now get results >11. Repeat step 3 >12. Notice that the query is now accepted >13. Repeat step 3 but with an absurd parameter >14. Notice the query is correctly rejected > >15. Ideally, check if other API calls were not broken >--- > Koha/REST/V1/Auth.pm | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > >diff --git a/Koha/REST/V1/Auth.pm b/Koha/REST/V1/Auth.pm >index 53c6bac..d0ecd13 100644 >--- a/Koha/REST/V1/Auth.pm >+++ b/Koha/REST/V1/Auth.pm >@@ -130,7 +130,7 @@ sub authenticate_api_request { > > my $user; > >- my $spec = $c->match->endpoint->pattern->defaults->{'openapi.op_spec'}; >+ my $spec = $c->openapi->spec; > my $authorization = $spec->{'x-koha-authorization'}; > > my $authorization_header = $c->req->headers->authorization; >-- >2.7.4 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 18:55:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 17:55:33 +0000 Subject: [Koha-bugs] [Bug 22533] maninvoice.pl is using deprecated maininvoice() method In-Reply-To: <bug-22533-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22533-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22533-70-HBDdRvwpcK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22533 --- Comment #1 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86757&action=edit Bug 22533: maninvoice.pl is using deprecated maininvoice() method To test: Attempt to create a manual fine from the patron accounting page, it should fail. Apply this patch, restart the things Attempt to create a manual fine from the patron accounting page, it should succeed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 18:55:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 17:55:31 +0000 Subject: [Koha-bugs] [Bug 22533] maninvoice.pl is using deprecated maininvoice() method In-Reply-To: <bug-22533-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22533-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22533-70-y62DkzWSdn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22533 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 18:57:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 17:57:45 +0000 Subject: [Koha-bugs] [Bug 22522] API authentication breaks with updated Mojolicious version In-Reply-To: <bug-22522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22522-70-srpXveFFnD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22522 --- Comment #5 from Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> --- Slightly modifying Auth.pm restores the original functionnality. It may be useful as a temporary fix for those who have this problem. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 19:32:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 18:32:54 +0000 Subject: [Koha-bugs] [Bug 22330] Transfer limits should be respected for placing holds in staff interface and APIs In-Reply-To: <bug-22330-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22330-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22330-70-jqY1i6tCG0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22330 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 19:32:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 18:32:57 +0000 Subject: [Koha-bugs] [Bug 22330] Transfer limits should be respected for placing holds in staff interface and APIs In-Reply-To: <bug-22330-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22330-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22330-70-wpLoWHw8wp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22330 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86480|0 |1 is obsolete| | Attachment #86481|0 |1 is obsolete| | Attachment #86482|0 |1 is obsolete| | --- Comment #12 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86758&action=edit Bug 22330: Transfer limits should be respected for placing holds in staff interface and APIs Branch transfer limits are respected for placing holds in the OPAC but nowhere else. This should be remedied. Test Plan: 1) Set up a branch transfer limit from Library A to Library B 2) Verify you cannot set up a hold for an item from Library A for pickup at Library B from the staff interface ( without overriding ) 3) Verify you cannot place that hold via ILS-DI 4) Verify you cannot place that hold via SIP 4) Verify a forced hold from Library A to Library B will not show up in the holds queue Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 19:33:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 18:33:00 +0000 Subject: [Koha-bugs] [Bug 22330] Transfer limits should be respected for placing holds in staff interface and APIs In-Reply-To: <bug-22330-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22330-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22330-70-NbpjUQBbkc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22330 --- Comment #13 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86759&action=edit Bug 22330: Cache item and library objects when building the holds queue Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 19:33:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 18:33:03 +0000 Subject: [Koha-bugs] [Bug 22330] Transfer limits should be respected for placing holds in staff interface and APIs In-Reply-To: <bug-22330-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22330-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22330-70-ayQhN1fqzs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22330 --- Comment #14 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86760&action=edit Bug 22330: (QA follow-up) Remove duplicate use lines, combine and sort remaning lines Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 19:40:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 18:40:21 +0000 Subject: [Koha-bugs] [Bug 13763] Renew feature does not check for the BarcodeInputFilter option In-Reply-To: <bug-13763-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13763-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13763-70-MRmQYTJXEN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13763 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Signed Off --- Comment #10 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- (In reply to Bin from comment #9) > Created attachment 86745 [details] [review] > Bug 13763: Added check for filter syspref in renew.pl > > In Circulation->Renew, the renew feature does not check the system > preference itemBarcodeFilter to see whether the barcode needs to be > converted. This patch fixes this, adding a check for the system pref and > applying it accordingly to convert the barcode if it is needed. > > Test plan: > 1) In Circulation->Renew, enter a barcode that you know exists in the > catalogue but add extra spaces, breaking up the barcode. Note that this > fails with a warning that says 'No item matches this barcode' > > 2) In system Preferences, set the itemBarcodeInputFilter pref to Remove > spaces and repeat step1. Note that the result is the same as in step 1 > > 3) Apply the patch > > 4) Repeat step 1, and note that the filter removes the spaces and the > item is renewed (or gives an error that indicates it recognises the > barcode) > > Sponsored-by: Catalyst IT > Signed-off-by: Bin Wen <bin.wen at inlibro.com> Thanks again for testing! I'll change the status to Signed Off so it'll get picked up by the QA team :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 19:41:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 18:41:01 +0000 Subject: [Koha-bugs] [Bug 21122] Make check-url-quick.pl handle utf8 characters in urls gracefuly In-Reply-To: <bug-21122-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21122-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21122-70-8Va61tIVVA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21122 Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jose-mario.monteiro-santos@ | |inlibro.com --- Comment #10 from Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> --- I'm not quite sure if I can ask about this here, but I've been having problems when urls contain characters such as ? or ?. I understand that this patch makes it so check-url-quick doesn't explode when it encounters such characters, but when the http request is sent they're encoded differently and are marked as broken links (? turns into ?? for example). Is this related to this bug ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 19:46:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 18:46:50 +0000 Subject: [Koha-bugs] [Bug 22330] Transfer limits should be respected for placing holds in staff interface and APIs In-Reply-To: <bug-22330-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22330-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22330-70-MpU2tH1fjF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22330 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #15 from Liz Rea <wizzyrea at gmail.com> --- I realised half a second too late that there was a QA tool fail here, but I'm not 100% sure it's not a false positive, and no one was around to ask. Anyway, here's what it was: FAIL koha-tmpl/intranet-tmpl/prog/en/modules/reserve/request.tt FAIL filters missing_filter at line 666 ( var biblionumber = "[% biblionumber %]";) missing_filter at line 667 ( var borrowernumber = "[% patron.borrowernumber %]";) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 20:55:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 19:55:50 +0000 Subject: [Koha-bugs] [Bug 22541] New: Invoice adjustments should show invoice number and include link on ordered.pl and spent.pl Message-ID: <bug-22541-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22541 Bug ID: 22541 Summary: Invoice adjustments should show invoice number and include link on ordered.pl and spent.pl Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- On ordered.pl and spent.pl, invoice adjustments are shown with a label that gives the invoiceid rather than the invoicenumber. For consistency and clarity, these should show the invoicenumber and link to the invoice page, just like the entries in the Invoice column in the table on these pages. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 20:56:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 19:56:07 +0000 Subject: [Koha-bugs] [Bug 22541] Invoice adjustments should show invoice number and include link on ordered.pl and spent.pl In-Reply-To: <bug-22541-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22541-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22541-70-SN1tnUrIA0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22541 Andrew <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 23:21:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 22:21:32 +0000 Subject: [Koha-bugs] [Bug 20769] Duplicate fine generated when lost item is returned with BlockReturnOfLostItems activated In-Reply-To: <bug-20769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20769-70-FdZVilJASt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20769 Lisette Scheer <lisetteslatah at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com --- Comment #3 from Lisette Scheer <lisetteslatah at gmail.com> --- This is happening for us as well and our settings are: BlockReturnofLostItems to Not Block. Lisette -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 23:48:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 22:48:09 +0000 Subject: [Koha-bugs] [Bug 22002] Each message_transport_type in the letters table is showing as a separate notice in Tools > Notices and slips In-Reply-To: <bug-22002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22002-70-EEcICNEi1K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22002 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #12 from Lucas Gass <lucas at bywatersolutions.com> --- backported to 18.05.x for 18.05.11 Thanks everyone! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 23:56:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 22:56:00 +0000 Subject: [Koha-bugs] [Bug 22498] Can not select any funds for invoice adjustments In-Reply-To: <bug-22498-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22498-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22498-70-soGOx1R3ow@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22498 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #8 from Lucas Gass <lucas at bywatersolutions.com> --- 18.05.x is missing 14850 dependency. won't backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 19 23:57:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 22:57:01 +0000 Subject: [Koha-bugs] [Bug 22296] Invoice adjustments are not populating to budget views In-Reply-To: <bug-22296-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22296-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22296-70-c4rGuI2msp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22296 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #10 from Lucas Gass <lucas at bywatersolutions.com> --- missing dependency, won't back port to 18.05.x series -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 00:08:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 23:08:14 +0000 Subject: [Koha-bugs] [Bug 22429] Infinite loop in patron card printing In-Reply-To: <bug-22429-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22429-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22429-70-zI6eEBbU81@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22429 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #17 from Lucas Gass <lucas at bywatersolutions.com> --- backported to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 00:15:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 23:15:26 +0000 Subject: [Koha-bugs] [Bug 21560] Optimize ODS exports In-Reply-To: <bug-21560-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21560-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21560-70-WJIuSInJjx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21560 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #34 from Lucas Gass <lucas at bywatersolutions.com> --- backported to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 00:19:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 23:19:20 +0000 Subject: [Koha-bugs] [Bug 22476] MarkLostItemsAsReturned has wrong defaults for new installs In-Reply-To: <bug-22476-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22476-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22476-70-KcF8OLrJwv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22476 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> --- backported to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 00:23:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 23:23:05 +0000 Subject: [Koha-bugs] [Bug 22493] DecreaseLoanHighHolds.t creates some items/patrons with set values In-Reply-To: <bug-22493-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22493-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22493-70-0AF9Rrk8Sy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22493 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> --- can't prove t/db_dependent/DecreaseLoanHighHolds.t in 18.05.x 1..17 ok 1 - userenv set Can't locate object method "build_sample_biblio" via package "t::lib::TestBuilder" at t/db_dependent/DecreaseLoanHighHolds.t line 74. # Looks like your test exited with 255 just after 1. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 16/17 subtests Test Summary Report ------------------- t/db_dependent/DecreaseLoanHighHolds.t (Wstat: 65280 Tests: 1 Failed: 0) Non-zero exit status: 255 Parse errors: Bad plan. You planned 17 tests but ran 1. Files=1, Tests=1, 1 wallclock secs ( 0.02 usr 0.00 sys + 1.18 cusr 0.16 csys = 1.36 CPU) Result: FAIL not backporting to 18.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 00:26:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 23:26:42 +0000 Subject: [Koha-bugs] [Bug 20816] add user expiration date to SIP2 message In-Reply-To: <bug-20816-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20816-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20816-70-NNkNz3IWBT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20816 Joy Nelson <joy at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Assignee|kyle at bywatersolutions.com |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 00:30:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 23:30:16 +0000 Subject: [Koha-bugs] [Bug 21987] Local cover 'thumbnail' size is bigger than 'imagefile' size in biblioimages table In-Reply-To: <bug-21987-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21987-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21987-70-DmWAjoYKjk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21987 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #11 from Lucas Gass <lucas at bywatersolutions.com> --- backported to 18.05.x for 18.05.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 00:36:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Mar 2019 23:36:41 +0000 Subject: [Koha-bugs] [Bug 20256] Development: Limit view/edit of items to home library In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20256-70-Z5MW79uUzW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Joy Nelson <joy at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com Assignee|jesse at bywatersolutions.com |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 01:43:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 00:43:55 +0000 Subject: [Koha-bugs] [Bug 22471] Default Finnish values for web installer In-Reply-To: <bug-22471-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22471-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22471-70-8G5dx9YGyo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22471 --- Comment #1 from Lari Taskula <lari.taskula at hypernova.fi> --- Created attachment 86761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86761&action=edit Bug 22471: Add installer/data/mysql/fi-FI (1/2) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 01:44:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 00:44:07 +0000 Subject: [Koha-bugs] [Bug 22471] Default Finnish values for web installer In-Reply-To: <bug-22471-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22471-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22471-70-ewPlyi6iF9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22471 --- Comment #2 from Lari Taskula <lari.taskula at hypernova.fi> --- Created attachment 86762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86762&action=edit Bug 22471: Add installer/data/mysql/fi-FI (2/2) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 01:44:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 00:44:20 +0000 Subject: [Koha-bugs] [Bug 22471] Default Finnish values for web installer In-Reply-To: <bug-22471-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22471-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22471-70-SoPwbuA9pK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22471 --- Comment #3 from Lari Taskula <lari.taskula at hypernova.fi> --- Created attachment 86763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86763&action=edit Bug 22471: Mandatory Finnish installer values Sponsored-by: Hypernova Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 01:44:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 00:44:31 +0000 Subject: [Koha-bugs] [Bug 22471] Default Finnish values for web installer In-Reply-To: <bug-22471-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22471-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22471-70-l1HEmdtKyi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22471 --- Comment #4 from Lari Taskula <lari.taskula at hypernova.fi> --- Created attachment 86764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86764&action=edit Bug 22471: Optional Finnish installer values Sponsored-by: Hypernova Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 01:45:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 00:45:24 +0000 Subject: [Koha-bugs] [Bug 22471] Default Finnish values for web installer In-Reply-To: <bug-22471-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22471-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22471-70-bHPjgAGwBN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22471 --- Comment #5 from Lari Taskula <lari.taskula at hypernova.fi> --- Created attachment 86765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86765&action=edit Bug 22471: Add system preferences for Finnish installer To test: 1. Apply all patches in this Bug 2. Create an empty database. Make sure database user has permissions to it and $KOHA_CONF is pointing to the correct database. 3. Add Finnish translation, for help, see: https://wiki.koha-community.org/wiki/Installation_of_additional_languages_for_OPAC_and_INTRANET_staff_client 4. Run web installer and select fi-FI as installer language 5. Select all mandatory and optional default values 6. Finish installation and make sure you get no SQL errors Sponsored-by: Hypernova Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 01:46:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 00:46:53 +0000 Subject: [Koha-bugs] [Bug 22471] Default Finnish values for web installer In-Reply-To: <bug-22471-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22471-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22471-70-GbgOOAUZ6z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22471 Lari Taskula <lari.taskula at hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86761|0 |1 is obsolete| | Attachment #86762|0 |1 is obsolete| | --- Comment #6 from Lari Taskula <lari.taskula at hypernova.fi> --- Created attachment 86766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86766&action=edit Bug 22471: Add installer/data/mysql/fi-FI This patch adds a direct copy of installer/data/mysql/en. No translations provided in this patch! Sponsored-by: Hypernova Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 01:47:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 00:47:08 +0000 Subject: [Koha-bugs] [Bug 22471] Default Finnish values for web installer In-Reply-To: <bug-22471-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22471-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22471-70-Rik9ggqL2U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22471 Lari Taskula <lari.taskula at hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86763|0 |1 is obsolete| | --- Comment #7 from Lari Taskula <lari.taskula at hypernova.fi> --- Created attachment 86767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86767&action=edit Bug 22471: Mandatory Finnish installer values Sponsored-by: Hypernova Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 01:47:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 00:47:41 +0000 Subject: [Koha-bugs] [Bug 22471] Default Finnish values for web installer In-Reply-To: <bug-22471-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22471-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22471-70-pF82iqUOJK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22471 Lari Taskula <lari.taskula at hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86764|0 |1 is obsolete| | --- Comment #8 from Lari Taskula <lari.taskula at hypernova.fi> --- Created attachment 86768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86768&action=edit Bug 22471: Optional Finnish installer values Sponsored-by: Hypernova Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 01:47:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 00:47:54 +0000 Subject: [Koha-bugs] [Bug 22471] Default Finnish values for web installer In-Reply-To: <bug-22471-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22471-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22471-70-3yCT0rvEUZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22471 Lari Taskula <lari.taskula at hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86765|0 |1 is obsolete| | --- Comment #9 from Lari Taskula <lari.taskula at hypernova.fi> --- Created attachment 86769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86769&action=edit Bug 22471: Add system preferences for Finnish installer To test: 1. Apply all patches in this Bug 2. Create an empty database. Make sure database user has permissions to it and $KOHA_CONF is pointing to the correct database. 3. Add Finnish translation, for help, see: https://wiki.koha-community.org/wiki/Installation_of_additional_languages_for_OPAC_and_INTRANET_staff_client 4. Run web installer and select fi-FI as installer language 5. Select all mandatory and optional default values 6. Finish installation and make sure you get no SQL errors Sponsored-by: Hypernova Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 05:19:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 04:19:01 +0000 Subject: [Koha-bugs] [Bug 22538] Add a noticeable alert about waiting holds In-Reply-To: <bug-22538-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22538-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22538-70-b37qr0bIGH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22538 --- Comment #1 from Agust?n Moyano <agustinmoyano at theke.io> --- Created attachment 86770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86770&action=edit Bug 22538: Add a noticeable alert about waiting holds In SCO, bug 21772 introduced holds information, but it lacked the capability to attract atention when any of those holds was in waiting status. Because SCO and opac-user uses the same include file for holds table, this bug applies to both modules. To test: 1) Have a patron with holds in waiting status and pending status. 2) Enable SCO module. 3) Holds tab label contains holds count, but doesn't inform that there is something that requires attention. 5) Holds tab content has no visual aid to recognize without reading effort which holds are in waiting status. 6) Apply this patch => SUCCESS: Holds tab label has a visual aid to indicate that something requires attention, and in holds table it's easy to recognize waiting holds without reading effort. 7) Sign off Sponsored-by: Pasco County Libraries -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 05:20:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 04:20:29 +0000 Subject: [Koha-bugs] [Bug 22538] Add a noticeable alert about waiting holds In-Reply-To: <bug-22538-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22538-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22538-70-0T8zNCEhJO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22538 Agust?n Moyano <agustinmoyano at theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 05:21:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 04:21:03 +0000 Subject: [Koha-bugs] [Bug 22538] Add a noticeable alert about waiting holds In-Reply-To: <bug-22538-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22538-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22538-70-qPjCWlidUv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22538 Agust?n Moyano <agustinmoyano at theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 08:42:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 07:42:07 +0000 Subject: [Koha-bugs] [Bug 22318] Extend Koha news feature to include other content areas In-Reply-To: <bug-22318-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22318-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22318-70-q3nIUIlckP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86743|0 |1 is obsolete| | --- Comment #15 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86771&action=edit Bug 22318: (follow-up) Add new options to new table filter form This patch adds the new language/location options to the form for filtering entries in the table of news items. Since this markup is duplicated twice in the template, its contents have been moved to a BLOCK. To test, apply the patch and go to Tools -> News. At the top of the table of news items the "Display location" form should show all options including OpacNavRight for all your enabled languages. Confirm that location/language selection still works correctly upon adding and editing news items. Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 08:43:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 07:43:28 +0000 Subject: [Koha-bugs] [Bug 22318] Extend Koha news feature to include other content areas In-Reply-To: <bug-22318-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22318-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22318-70-SuG7iTHfBb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #16 from Josef Moravec <josef.moravec at gmail.com> --- (In reply to Owen Leonard from comment #14) > Created attachment 86743 [details] [review] > Bug 22318: (follow-up) Add new options to new table filter form > Thanks for quick and nice follow-up Owen. Looking good. Passing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 08:44:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 07:44:11 +0000 Subject: [Koha-bugs] [Bug 22544] New: Move C4:.NewsChannels to Koha namespace Message-ID: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Bug ID: 22544 Summary: Move C4:.NewsChannels to Koha namespace Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: josef.moravec at gmail.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 08:44:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 07:44:20 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:.NewsChannels to Koha namespace In-Reply-To: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22544-70-Ye36BUsRBZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22318 Blocks| |15449 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 [Bug 15449] Move stuffs to the Koha namespace https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 [Bug 22318] Extend Koha news feature to include other content areas -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 08:44:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 07:44:20 +0000 Subject: [Koha-bugs] [Bug 15449] Move stuffs to the Koha namespace In-Reply-To: <bug-15449-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15449-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15449-70-6e5Xi4jbiL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22544 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 [Bug 22544] Move C4:.NewsChannels to Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 08:44:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 07:44:20 +0000 Subject: [Koha-bugs] [Bug 22318] Extend Koha news feature to include other content areas In-Reply-To: <bug-22318-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22318-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22318-70-ptPAz00rDl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22544 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 [Bug 22544] Move C4:.NewsChannels to Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 08:47:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 07:47:16 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:.NewsChannels to Koha namespace In-Reply-To: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22544-70-gWG6eAmceu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |josef.moravec at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 08:48:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 07:48:54 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:.NewsChannels to Koha namespace In-Reply-To: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22544-70-lPubX23t7e@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #1 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86772&action=edit Bug 22544: Move get_opac_new to Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 08:49:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 07:49:00 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:.NewsChannels to Koha namespace In-Reply-To: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22544-70-5dJLUZkZps@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #3 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86774&action=edit Bug 22544: Move del_opac_new to Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 08:48:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 07:48:57 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:.NewsChannels to Koha namespace In-Reply-To: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22544-70-r9OTFmoEH8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #2 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86773&action=edit Bug 22544: Move get_opac_news to Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 08:49:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 07:49:02 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:.NewsChannels to Koha namespace In-Reply-To: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22544-70-jvltIY9Usx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #4 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86775&action=edit Bug 22544: Move upd_opac_new to Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 08:49:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 07:49:05 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:.NewsChannels to Koha namespace In-Reply-To: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22544-70-fjl5Ar5PvS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #5 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86776&action=edit Bug 22544: Move add_opac_item to Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 08:49:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 07:49:08 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:.NewsChannels to Koha namespace In-Reply-To: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22544-70-9kmACScLPN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #6 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86777&action=edit Bug 22544: Move GetNewsToDisplay to Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 10:43:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 09:43:59 +0000 Subject: [Koha-bugs] [Bug 22545] New: C4::Matcher::get_matches aggressive isbn and issn search don't give any results with ES Message-ID: <bug-22545-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22545 Bug ID: 22545 Summary: C4::Matcher::get_matches aggressive isbn and issn search don't give any results with ES Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Bibliographic record staging/import Assignee: koha-bugs at lists.koha-community.org Reporter: johanna.raisa at koha-suomi.fi QA Contact: testopia at bugs.koha-community.org Target Milestone: --- When using AggressiveMatchOnISBN or AggressiveMatchOnISSN preferences instead of UseQueryParser the search for duplicates fails. ES don't give any results, it seems that the problem is the query string. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 11:32:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 10:32:24 +0000 Subject: [Koha-bugs] [Bug 22546] New: MaxFine is not recorded in HEA Message-ID: <bug-22546-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22546 Bug ID: 22546 Summary: MaxFine is not recorded in HEA Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Websites, Mailing Lists, etc Assignee: wizzyrea at gmail.com Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- I'm not sure how the whitelist of prefs being sent to HEA was constructed and whether there's anything in place to maintain it :( But, I'd be really interested to see what the usage of the MaxFine preference is in the wild. The code that implements it is somewhat confusing but it's nature and appears to take into account non-fine amounts which I would not have expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 11:32:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 10:32:44 +0000 Subject: [Koha-bugs] [Bug 10030] MaxFines checks against amount, not amount outstanding In-Reply-To: <bug-10030-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10030-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10030-70-4u6qNqbcZf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10030 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22546 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 11:32:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 10:32:44 +0000 Subject: [Koha-bugs] [Bug 22546] MaxFine is not recorded in HEA In-Reply-To: <bug-22546-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22546-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22546-70-PF3k5XFMtU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22546 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10030 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 11:36:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 10:36:18 +0000 Subject: [Koha-bugs] [Bug 22546] MaxFine is not recorded in HEA In-Reply-To: <bug-22546-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22546-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22546-70-yAcz3fzTAU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22546 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 11:51:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 10:51:59 +0000 Subject: [Koha-bugs] [Bug 22545] C4::Matcher::get_matches aggressive isbn and issn search don't give any results with ES In-Reply-To: <bug-22545-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22545-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22545-70-ACLOMJ1DSP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22545 Johanna R?is? <johanna.raisa at koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |johanna.raisa at koha-suomi.fi --- Comment #1 from Johanna R?is? <johanna.raisa at koha-suomi.fi> --- Created attachment 86778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86778&action=edit Elastic fix for matching records -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 11:52:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 10:52:29 +0000 Subject: [Koha-bugs] [Bug 22545] C4::Matcher::get_matches aggressive isbn and issn search don't give any results with ES In-Reply-To: <bug-22545-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22545-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22545-70-JFBAINh9EL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22545 Johanna R?is? <johanna.raisa at koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 11:56:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 10:56:45 +0000 Subject: [Koha-bugs] [Bug 22545] C4::Matcher::get_matches aggressive isbn and issn search don't give any results with ES In-Reply-To: <bug-22545-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22545-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22545-70-kTEG0bOfjn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22545 Johanna R?is? <johanna.raisa at koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch Assignee|koha-bugs at lists.koha-commun |johanna.raisa at koha-suomi.fi |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 12:08:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 11:08:28 +0000 Subject: [Koha-bugs] [Bug 22330] Transfer limits should be respected for placing holds in staff interface and APIs In-Reply-To: <bug-22330-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22330-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22330-70-EzOiSo0ecM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22330 --- Comment #16 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 86779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86779&action=edit Bug 22330: (QA follow-up) Fix QA script failure -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 12:20:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 11:20:50 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:.NewsChannels to Koha namespace In-Reply-To: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22544-70-whTOlBQ7nA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #7 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86780&action=edit Bug 22544: Add tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 12:20:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 11:20:52 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:.NewsChannels to Koha namespace In-Reply-To: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22544-70-TB3LP4WymG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #8 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86781&action=edit Bug 22544: Refactor searching of news items Test plan: 1) Go to tools and define some news 2) Try different parameters, try to edit new items, and delete some 3) Go to all places where news are presented and ensure that there are the right ones shown: opac main page - based on language opac righ column (formerly syspref OpacNavRight) - based on language opac news rss feed circulation slip (not quick slip) intranet main page 4) run tests: prove t/db_dependent/Koha/News.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 12:22:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 11:22:36 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:.NewsChannels to Koha namespace In-Reply-To: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22544-70-7uWudMZwWu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 12:25:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 11:25:52 +0000 Subject: [Koha-bugs] [Bug 22535] Use Link Shortcuts when creating reports In-Reply-To: <bug-22535-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22535-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22535-70-wH0HFGn8LX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22535 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 12:48:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 11:48:57 +0000 Subject: [Koha-bugs] [Bug 22547] New: C4::Overdues - UpdateFine is untested Message-ID: <bug-22547-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22547 Bug ID: 22547 Summary: C4::Overdues - UpdateFine is untested Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- UpdateFine is not tested at the unit level, it should be to help prevent regressions (and to allow more confidence in refactoring efforts). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 12:49:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 11:49:04 +0000 Subject: [Koha-bugs] [Bug 22547] C4::Overdues - UpdateFine is untested In-Reply-To: <bug-22547-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22547-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22547-70-N3k4NuygPj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22547 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 12:51:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 11:51:04 +0000 Subject: [Koha-bugs] [Bug 22547] C4::Overdues - UpdateFine is untested In-Reply-To: <bug-22547-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22547-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22547-70-4t5xNo2Dbz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22547 --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86782&action=edit Bug 22547: Add tests for C4::Overdues->UpdateFine Add tests for UpdateFine, in particular testing the functionality of MaxFine. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 13:01:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 12:01:03 +0000 Subject: [Koha-bugs] [Bug 22538] Add a noticeable alert about waiting holds In-Reply-To: <bug-22538-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22538-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22538-70-Qp4rmosUtI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22538 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86770|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 86783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86783&action=edit Bug 22538: Add a noticeable alert about waiting holds In SCO, bug 21772 introduced holds information, but it lacked the capability to attract atention when any of those holds was in waiting status. Because SCO and opac-user uses the same include file for holds table, this bug applies to both modules. To test: 1) Have a patron with holds in waiting status and pending status. 2) Enable SCO module. 3) Holds tab label contains holds count, but doesn't inform that there is something that requires attention. 5) Holds tab content has no visual aid to recognize without reading effort which holds are in waiting status. 6) Apply this patch => SUCCESS: Holds tab label has a visual aid to indicate that something requires attention, and in holds table it's easy to recognize waiting holds without reading effort. 7) Sign off Sponsored-by: Pasco County Libraries Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 13:01:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 12:01:00 +0000 Subject: [Koha-bugs] [Bug 22538] Add a noticeable alert about waiting holds In-Reply-To: <bug-22538-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22538-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22538-70-ljpv9J5GyL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22538 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 13:06:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 12:06:45 +0000 Subject: [Koha-bugs] [Bug 17511] Authority linking subfield In-Reply-To: <bug-17511-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17511-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17511-70-unTMoHrvki@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17511 Johanna R?is? <johanna.raisa at koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |johanna.raisa at koha-suomi.fi --- Comment #9 from Johanna R?is? <johanna.raisa at koha-suomi.fi> --- We are having issues with this in Finland. My opinion is that the authority linking should be changed to $0 permanently. I have some code for it and also script to change the old subfields. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 13:13:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 12:13:04 +0000 Subject: [Koha-bugs] [Bug 22547] C4::Overdues - UpdateFine is untested In-Reply-To: <bug-22547-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22547-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22547-70-CR38YQnoP9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22547 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |katrin.fischer at bsz-bw.de, | |kyle at bywatersolutions.com, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 13:19:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 12:19:14 +0000 Subject: [Koha-bugs] [Bug 22547] C4::Overdues - UpdateFine is untested In-Reply-To: <bug-22547-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22547-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22547-70-yFatg6ui9D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22547 --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Question here.. should I write the tests to test all the current behaviour or write them to test what I believe the behaviour should be.. Example questions raised: 1) Should we really be counting 'Sundry'/'Manual Invoice' in the total fines amount outstanding? 2) If the above is correct, should we be counting other fee's in the total fines amount outstanding calculation? 3) We don't explicitly order the accountlines lookup, as such we can't be sure we're actually updating the correct fine for the renewals case... Should I test for this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 13:21:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 12:21:48 +0000 Subject: [Koha-bugs] [Bug 22547] C4::Overdues - UpdateFine is untested In-Reply-To: <bug-22547-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22547-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22547-70-UkuYVDu8F8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22547 --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- That final one.. actually I don't think we record distinct fines after renewal any more.. this was an inadvertent change of functionality at some point I believe... maybe I'm reading the code wrong. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 13:50:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 12:50:36 +0000 Subject: [Koha-bugs] [Bug 20935] Redesign system preferences interface In-Reply-To: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20935-70-umQWTzGf2B@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82884|0 |1 is obsolete| | Attachment #82885|0 |1 is obsolete| | Attachment #82886|0 |1 is obsolete| | Attachment #82887|0 |1 is obsolete| | Attachment #82888|0 |1 is obsolete| | --- Comment #45 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 86784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86784&action=edit Bug 20935: Redesign system preferences interface This patch proposes a new interface for system preferences. The goal is to make the interface more readable and to give the user additional options for finding what they need. - Restructures the preferences list as a <dl>, with the preference name as the <dt> and the description as the <dd>. - Add a JS filter library (mark.js) to do live filtering of the page and add search term highlighting. - When the user has searched, show links to the sections in which results were returned. To test, apply the patch and go to Administration -> System preferences. - Test the functionality of setting various kinds of preferences, including multi-selects, textareas, WYSIWYG editors, etc. - Test the filter form at the top of the page for narrowing in-page results. - Test both successful and unsuccessful filters. - Perform a system preference search. - Test the in-page links to the different sections. - Test that in-page filtering works in this case too. - View the licenses tab of the "About" page and check that the information about mark.js looks correct. Followed test plan and pleased to say everything worked as expected. Looking forward to this enhancement. Signed-off-by: Dilan Johnpull? <dilan at calyx.net.au> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 13:50:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 12:50:40 +0000 Subject: [Koha-bugs] [Bug 20935] Redesign system preferences interface In-Reply-To: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20935-70-BV39OiYrS4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #46 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 86785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86785&action=edit Bug 20935: Remove "Click to" from some links Changes "Click to edit" and "Click to collapse" to just "Edit" and "Collapse" as the "Click to" appears not necessary for elements formatted as links. Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 13:50:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 12:50:44 +0000 Subject: [Koha-bugs] [Bug 20935] Redesign system preferences interface In-Reply-To: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20935-70-5HN0nmOr1Q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #47 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 86786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86786&action=edit Bug 20935: Remove 'no match' box when it does Test plan: Hit /cgi-bin/koha/admin/preferences.pl Search for "AcqCreateX" => You get "No matching terms were found on this page" Remove the last X => Without this patch the "no matching" box is still displayed Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 13:50:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 12:50:48 +0000 Subject: [Koha-bugs] [Bug 20935] Redesign system preferences interface In-Reply-To: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20935-70-6AWYVa3m0s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #48 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 86787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86787&action=edit Bug 20935: Add in-page links to the sidebar This patch adds links to the sidebar menu which allow the user to jump to a section within the page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 13:50:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 12:50:51 +0000 Subject: [Koha-bugs] [Bug 20935] Redesign system preferences interface In-Reply-To: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20935-70-XRNcSF0GLM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #49 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 86788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86788&action=edit Bug 20935: Add missing html filter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 13:52:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 12:52:11 +0000 Subject: [Koha-bugs] [Bug 20935] Redesign system preferences interface In-Reply-To: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20935-70-6d2cIwuGNg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #50 from Owen Leonard <oleonard at myacpl.org> --- Rebase only. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 14:03:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 13:03:47 +0000 Subject: [Koha-bugs] [Bug 21783] Reindent admin/columns_settings.tt In-Reply-To: <bug-21783-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21783-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21783-70-MbFPagCT82@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21783 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #82045|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 86789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86789&action=edit Bug 21783: Reindent admin/columns_settings.tt This patch reindents admin/columns_settings.tt to use four spaces instead of two for indentation, following coding guidelines. To test, apply the patch and compare the file to master using the -w flag to ignore whitespace. The only changes should appear where lines were added during indentation. Go to Admin -> Columns settings and confirm that everything works correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 14:21:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 13:21:53 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18823-70-puaKDUZOQC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86174|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 14:22:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 13:22:12 +0000 Subject: [Koha-bugs] [Bug 22548] New: Z39.50/SRU search replaces existing biblios Message-ID: <bug-22548-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22548 Bug ID: 22548 Summary: Z39.50/SRU search replaces existing biblios Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: rudolfbyker at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Target Milestone: --- Possibly related, but not the same: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15360 Reproducing: - Search for a book under "Search the catalog", e.g. /cgi-bin/koha/catalogue/search.pl?q=movement - Note the biblionumber of the last book of the first page of the search results. It's 10624 in my case, and the title is "A political history of early Christianity". - Now click "Z39.50/SRU search" in the toolbar (between "Place hold" and "Sort"). - Click search in the popup window and wait for results. - Choose any book from the results and click "Actions" -> "Import". In my case I'm picking a book called "Against capital punishment". - The popup closes, and the catalog search results tab is directed to /cgi-bin/koha/cataloguing/addbiblio.pl?biblionumber=10624&z3950=1&breedingid=411522 Expected behaviour: - The title of the addbiblio.pl page should be "Add MARC record". - Clicking "Save" should add a new record to the catalog. Current behaviour: - The title of the addbiblio.pl page is "Editing Against capital punishment [electronic resource] : the anti-death penalty movement in America, 1972-1994 / Herbert H. Haines. (Record number 10624)". Note that this is the biblionumber of an existing book. More specifically, the last one from the first page of the search results mentioned above. - Clicking "Save" replaces "A political history of early Christianity" with "Against capital punishment". Additional information: Following the same process, but starting on "Cataloging Search" at /cgi-bin/koha/cataloguing/addbooks.pl instead of "Search the catalog" does NOT cause this problem, but causes a the MARC record to be imported as a NEW biblio, as expected. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 14:22:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 13:22:16 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18823-70-us7gd2pnN3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86173|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 14:22:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 13:22:35 +0000 Subject: [Koha-bugs] [Bug 22548] Z39.50/SRU search replaces existing biblios In-Reply-To: <bug-22548-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22548-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22548-70-duWib9Zcn2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22548 Rudolf Byker <rudolfbyker at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rudolfbyker at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 14:25:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 13:25:04 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18823-70-Erz7C5axan@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 --- Comment #79 from Alex Arnaud <alex.arnaud at biblibre.com> --- Bug 21720: Update Tests Bug 21728: (RM follow-up) Add 'Reserve Fee' for new installs Make these two patches obsolete since they're not part of this enhancement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 14:32:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 13:32:09 +0000 Subject: [Koha-bugs] [Bug 20935] Redesign system preferences interface In-Reply-To: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20935-70-npFawIelDK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 14:33:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 13:33:23 +0000 Subject: [Koha-bugs] [Bug 22547] C4::Overdues - UpdateFine is untested In-Reply-To: <bug-22547-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22547-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22547-70-X6czVKleKW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22547 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86782|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86790&action=edit Bug 22547: Add tests for C4::Overdues->UpdateFine Add tests for UpdateFine, in particular testing the functionality of MaxFine. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 14:34:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 13:34:04 +0000 Subject: [Koha-bugs] [Bug 22547] C4::Overdues - UpdateFine is untested In-Reply-To: <bug-22547-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22547-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22547-70-qw9uJpJYkw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22547 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Test Plan: * Read the test and confirm it all makes sense.. run the test and confirm it passes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 14:34:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 13:34:59 +0000 Subject: [Koha-bugs] [Bug 22547] C4::Overdues - UpdateFine is untested In-Reply-To: <bug-22547-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22547-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22547-70-fEVbmvKNNv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22547 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10030 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 14:34:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 13:34:59 +0000 Subject: [Koha-bugs] [Bug 10030] MaxFines checks against amount, not amount outstanding In-Reply-To: <bug-10030-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10030-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10030-70-Lh4DhpOAEW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10030 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22547 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 14:38:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 13:38:08 +0000 Subject: [Koha-bugs] [Bug 22547] C4::Overdues - UpdateFine is untested In-Reply-To: <bug-22547-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22547-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22547-70-oY4JQVz9RQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22547 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22521 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 14:38:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 13:38:08 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-Tpi6NG5X9C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22547 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22547 [Bug 22547] C4::Overdues - UpdateFine is untested -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 14:39:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 13:39:30 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit In-Reply-To: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22511-70-u4pExFLgmZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Totally agree.. I wasn't fully ready for testing yet.. my bad for setting it to NSO.. I meant to leave it as NEW until I'd done more here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 14:47:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 13:47:14 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit In-Reply-To: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22511-70-41ml1QZWpG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to Martin Renvoize from comment #10) > Totally agree.. I wasn't fully ready for testing yet.. my bad for setting it > to NSO.. I meant to leave it as NEW until I'd done more here. NP! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 14:47:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 13:47:14 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18823-70-uJbESTNtGZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86175|0 |1 is obsolete| | --- Comment #80 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 86791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86791&action=edit Bug 18823: Rancor - add support for editing/searching records rebase. Signed-off-by: cori <corilynn.arnold at gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 14:47:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 13:47:18 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18823-70-RNQDh1a0rZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86176|0 |1 is obsolete| | --- Comment #81 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 86792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86792&action=edit Bug 18823: Improvements to import batch searching and enabled/disabled Rebase. Signed-off-by: cori <corilynn.arnold at gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 14:47:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 13:47:22 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18823-70-bcKkZ6TxIN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86177|0 |1 is obsolete| | --- Comment #82 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 86793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86793&action=edit Bug 18823: Rancor - save override warnings Rebase. Signed-off-by: cori <corilynn.arnold at gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 14:47:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 13:47:26 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18823-70-m1YaDCCOQX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86178|0 |1 is obsolete| | --- Comment #83 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 86794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86794&action=edit Bug 18823: Rancor - improve batch search/update ISBN handling Rebase Signed-off-by: cori <corilynn.arnold at gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 14:47:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 13:47:30 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18823-70-73UyDgD0PG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86179|0 |1 is obsolete| | --- Comment #84 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 86795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86795&action=edit Bug 18823: Search improvements Search can now find titles and keywords with single quotes i.e. "Time Traveler's Wife" in import batches. Tests: 1) Open advanced cataloging edtior 2) Under settings select 'Import Batches' 3) Create a few import batches, some for searching and some as targets (and some both) 3.a) note that import batches for saving appear on the left side as targets to save 4) Search for a bibliographic record, make changes and apply to an import batch 5) Search for the bibliographic record in the import batch by author, title, isbn 6) Make changes to the import batch records and verify the changes are applied (either through searching again, or through the Staged MARC management page in Tools) Signed-off-by: cori <corilynn.arnold at gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 14:47:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 13:47:33 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18823-70-dlzuVAPSz3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86180|0 |1 is obsolete| | --- Comment #85 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 86796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86796&action=edit Bug 18823: Keep Batch selected and remove record backends when needed. Signed-off-by: cori <corilynn.arnold at gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 14:47:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 13:47:37 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18823-70-izaIFaAjNh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86181|0 |1 is obsolete| | --- Comment #86 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 86797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86797&action=edit Bug 18823: Check Batch and Record save target when importing a record from a batch. Signed-off-by: cori <corilynn.arnold at gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 14:47:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 13:47:41 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18823-70-GSYuQ8RI6J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86182|0 |1 is obsolete| | --- Comment #87 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 86798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86798&action=edit Bug 18823: Don't show/check batch that are not enabled for saved targets Signed-off-by: cori <corilynn.arnold at gmail.com> Rebased-on: 2019-03-20 Alex Arnaud <alex.arnaud at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 14:47:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 13:47:45 +0000 Subject: [Koha-bugs] [Bug 18823] Advanced editor - Rancor - add ability to edit records in import batches In-Reply-To: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18823-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18823-70-PgIAYmc7p9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18823 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86183|0 |1 is obsolete| | --- Comment #88 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 86799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86799&action=edit Bug 18823: Fix targets registering Signed-off-by: cori <corilynn.arnold at gmail.com> ebased-on: 2019-03-20 Alex Arnaud <alex.arnaud at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 14:51:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 13:51:46 +0000 Subject: [Koha-bugs] [Bug 19380] Add transfer informations in ILS-DI GetRecords response In-Reply-To: <bug-19380-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19380-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19380-70-eBdAztn2SF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19380 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 14:51:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 13:51:49 +0000 Subject: [Koha-bugs] [Bug 19380] Add transfer informations in ILS-DI GetRecords response In-Reply-To: <bug-19380-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19380-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19380-70-iiXuZY7Kd6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19380 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86740|0 |1 is obsolete| | Attachment #86741|0 |1 is obsolete| | --- Comment #8 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86800&action=edit Bug 19380: Add transfer informations in ILS-DI GetRecords response Test plan: 1. Put an item into a 'transfer' state a. Place a hold on an item in branch A for a patron of branch B b. Check in this item in branch A and confirm transfer 2. Go to http://opac/cgi-bin/koha/ilsdi.pl?service=GetRecords&id=XXX where XXX is the biblionumber of the biblio the item belongs to. 3. Verify you have a new <transfer> element inside //record/items/item that contains <datesent>, <frombranch> and <tobranch> 4. Check in the same item in branch B, so that the item is not flagged as being transferred 5. Repeat 2 6. Verify that the <transfer> element is not there. 7. prove t/db_dependent/ILSDI_Services.t Followed test plan, patch worked as described. Also ran QA test tools and modified files passed Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 14:51:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 13:51:52 +0000 Subject: [Koha-bugs] [Bug 19380] Add transfer informations in ILS-DI GetRecords response In-Reply-To: <bug-19380-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19380-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19380-70-ES2u9rEH1g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19380 --- Comment #9 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86801&action=edit Bug 19380: Use Koha::Item::get_transfer instead of GetTransfers Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 14:54:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 13:54:10 +0000 Subject: [Koha-bugs] [Bug 19265] Advanced Editor - Rancor - Add ability to export selected records from and import records into an import batch In-Reply-To: <bug-19265-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19265-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19265-70-tdOuJJaocY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19265 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 15:12:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 14:12:26 +0000 Subject: [Koha-bugs] [Bug 22549] New: We should really leverage the power of DBIx::Class::ResultSetColumn in Koha::Objects Message-ID: <bug-22549-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22549 Bug ID: 22549 Summary: We should really leverage the power of DBIx::Class::ResultSetColumn in Koha::Objects Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- calling get_column on a Koha::Objects object, we currently throw away the ResultSetColumn object and instead call ->all upon it internally to return a simple array of values instead of giving us a ResultSetColumn object back. We're then forced to do calculations either in perl or be working around the lack of ResultSetColumn. I've seen cases for 'min', 'max', 'sum' and 'as_query' at the very least. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 15:37:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 14:37:40 +0000 Subject: [Koha-bugs] [Bug 22330] Transfer limits should be respected for placing holds in staff interface and APIs In-Reply-To: <bug-22330-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22330-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22330-70-6rYKuu4WR2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22330 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86759|0 |1 is obsolete| | --- Comment #18 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86803&action=edit Bug 22330: Cache item and library objects when building the holds queue Signed-off-by: Liz Rea <wizzyrea at gmail.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 15:37:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 14:37:44 +0000 Subject: [Koha-bugs] [Bug 22330] Transfer limits should be respected for placing holds in staff interface and APIs In-Reply-To: <bug-22330-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22330-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22330-70-J3whtm6rh2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22330 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86760|0 |1 is obsolete| | --- Comment #19 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86804&action=edit Bug 22330: (QA follow-up) Remove duplicate use lines, combine and sort remaning lines Signed-off-by: Liz Rea <wizzyrea at gmail.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 15:37:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 14:37:47 +0000 Subject: [Koha-bugs] [Bug 22330] Transfer limits should be respected for placing holds in staff interface and APIs In-Reply-To: <bug-22330-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22330-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22330-70-Az56zzb1iA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22330 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86779|0 |1 is obsolete| | --- Comment #20 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86805&action=edit Bug 22330: (QA follow-up) Fix QA script failure Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 15:37:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 14:37:51 +0000 Subject: [Koha-bugs] [Bug 22330] Transfer limits should be respected for placing holds in staff interface and APIs In-Reply-To: <bug-22330-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22330-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22330-70-iPj3R5j9Z3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22330 --- Comment #21 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86806&action=edit Bug 22330: (QA follow-up) Enable datatable in patron search Test plan: Try to search patron for circulation (or for creating hold), when there are more than 1 patron, you should see a table with patrons found. --> without this patch, the datatable is not created (for example sorting the table by clicking to column heading does not work) --> with this patch, the datatable works Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 15:37:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 14:37:54 +0000 Subject: [Koha-bugs] [Bug 22330] Transfer limits should be respected for placing holds in staff interface and APIs In-Reply-To: <bug-22330-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22330-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22330-70-Us7Kh4JYNv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22330 --- Comment #22 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86807&action=edit Bug 22330: (QA follow-up) Fix number of tests in Reserves.t Test plan: prove t/db_dependent/Reserves.t Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 15:37:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 14:37:37 +0000 Subject: [Koha-bugs] [Bug 22330] Transfer limits should be respected for placing holds in staff interface and APIs In-Reply-To: <bug-22330-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22330-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22330-70-2Dw7hSzgJT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22330 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86758|0 |1 is obsolete| | --- Comment #17 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86802&action=edit Bug 22330: Transfer limits should be respected for placing holds in staff interface and APIs Branch transfer limits are respected for placing holds in the OPAC but nowhere else. This should be remedied. Test Plan: 1) Set up a branch transfer limit from Library A to Library B 2) Verify you cannot set up a hold for an item from Library A for pickup at Library B from the staff interface ( without overriding ) 3) Verify you cannot place that hold via ILS-DI 4) Verify you cannot place that hold via SIP 4) Verify a forced hold from Library A to Library B will not show up in the holds queue Signed-off-by: Liz Rea <wizzyrea at gmail.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 15:43:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 14:43:03 +0000 Subject: [Koha-bugs] [Bug 22330] Transfer limits should be respected for placing holds in staff interface and APIs In-Reply-To: <bug-22330-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22330-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22330-70-MLxPKBkmQP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22330 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Status|Signed Off |Passed QA QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | --- Comment #23 from Josef Moravec <josef.moravec at gmail.com> --- I removed schema files changes accidentally added to third patch and added two small fixes - number of test, that is obvious - activate again the commented out javascript for creating datatable when searching for patron to circulate/create hold -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 15:49:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 14:49:30 +0000 Subject: [Koha-bugs] [Bug 14364] Allow automatically canceled expired waiting holds to fill the next hold In-Reply-To: <bug-14364-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14364-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14364-70-GzsNS1Omg1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14364 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #32 from Liz Rea <wizzyrea at gmail.com> --- I just tested this, and it doesn't fail in this way any more, but the feature doesn't work either - please have another look! Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 15:59:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 14:59:58 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-NevLcn1MP1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86808&action=edit Bug 22521: Update fines handling to use accountline.status Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 16:00:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 15:00:45 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-oLv4QxWxOt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Not ready for testing yet.. UI side still needs a patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 16:32:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 15:32:13 +0000 Subject: [Koha-bugs] [Bug 12166] Improve display of Reserve charges in patron account In-Reply-To: <bug-12166-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12166-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12166-70-LpmMthNqRe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12166 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 16:35:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 15:35:04 +0000 Subject: [Koha-bugs] [Bug 13795] Delete unused columns from statistics table. In-Reply-To: <bug-13795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13795-70-68lDC8efDO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com Assignee|nengard at gmail.com |josef.moravec at gmail.com Depends on| |21683 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 [Bug 21683] Remove accountlines.accountno -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 16:35:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 15:35:04 +0000 Subject: [Koha-bugs] [Bug 21683] Remove accountlines.accountno In-Reply-To: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21683-70-jaYpU7amGA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13795 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795 [Bug 13795] Delete unused columns from statistics table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 16:36:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 15:36:46 +0000 Subject: [Koha-bugs] [Bug 13795] Delete unused columns from statistics table. In-Reply-To: <bug-13795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13795-70-qs5ZVnNnvJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 16:36:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 15:36:49 +0000 Subject: [Koha-bugs] [Bug 13795] Delete unused columns from statistics table. In-Reply-To: <bug-13795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13795-70-S3bBdeiaEW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #47555|0 |1 is obsolete| | --- Comment #9 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86809&action=edit Bug 13795: Delete unused columns from statistics table The following 2 fields are never used in the statistics table: associatedborrower usercode This patch removes them. To test: * check the database and make sure columns are gone -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 16:36:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 15:36:52 +0000 Subject: [Koha-bugs] [Bug 13795] Delete unused columns from statistics table. In-Reply-To: <bug-13795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13795-70-resfuBXonn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795 --- Comment #10 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86810&action=edit Bug 13795: Make database update idempotent -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 16:36:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 15:36:56 +0000 Subject: [Koha-bugs] [Bug 13795] Delete unused columns from statistics table. In-Reply-To: <bug-13795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13795-70-Qi8xCGysTF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795 --- Comment #11 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86811&action=edit Bug 13795: Remove occurences of unused columns in code These patch removes these two columns from backfill_statstics script and from columns.def - this file is used to create description in guided reports Test plan: 1. Run installer/data/mysql/backfull_statistics.pl --> without this patch, there are associatedborrower and usercode errors reported --> with patch, these two columns are not reported -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 16:47:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 15:47:32 +0000 Subject: [Koha-bugs] [Bug 14576] Allow automatic update of location on checkin In-Reply-To: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14576-70-yN2DQbqMox@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85850|0 |1 is obsolete| | --- Comment #111 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 86812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86812&action=edit Bug 14576: Allow arbitrary automatic update of location on checkin This patch adds a new syspref "UpdateItemLocationOnCheckin" which accepts pairs of shelving locations. On check-in the items location is compared ot the location on the left and, if it matches, is updated to the location on the left. This preference replaces ReturnToShelvingCart and InProcessingToShelvingCart preferences. The update statement should insert values that replciate these functions. Note existing functionality of all items in PROC location being returned to permanent_location is preserved by default. Also, any items issued from CART location will be returned to their permanent location on issue (if it differs) Special values for this pref are: _ALL_ - used on left side only to affect all items _BLANK_ - used on either side to match on/set to blank (actual blanks will work, but this is an easier to read option) _PERM_ - used on right side only to return items to permanent location Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Set the new system preference UpdateitemLocationOnCheckin to the following (assuming sample data): NEW: FIC FIC: GEN 4) Create an item, set its location to NEW 5) Check in the item, note its location is now FIC 6) Check in the item again, note its location is now GEN 7) Check in the item again, note its location remains GEN 8) Test using _ALL_, _BLANK_ and _PERM_ for updates 9) Try entering various incorrect syntax in the pref and note you are warned Sponsored by: Arcadia Public Library (http://library.ci.arcadia.ca.us/) Middletown Township Public Library (http://www.mtpl.org/) Round Rock Public Library (https://www.roundrocktexas.gov/departments/library/) Signed-off-by: Michal Denar <black23 at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 16:47:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 15:47:37 +0000 Subject: [Koha-bugs] [Bug 14576] Allow automatic update of location on checkin In-Reply-To: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14576-70-yej92OfpOB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85851|0 |1 is obsolete| | --- Comment #112 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 86813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86813&action=edit Bug 14576: Unit tests To test: 1 - prove -v t/db_dependent/Circulation/Returns.t 2 - prove -v t/db_dependent/Circulation/issue.t 3 - prove -v t/db_dependent/UsageStats.t 4 - All should pass Signed-off-by: Michal Denar <black23 at gmail.com> Signed-off-by: Michal Denar <black23 at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 16:47:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 15:47:42 +0000 Subject: [Koha-bugs] [Bug 14576] Allow automatic update of location on checkin In-Reply-To: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14576-70-1blYVRrbSs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85852|0 |1 is obsolete| | --- Comment #113 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 86814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86814&action=edit Bug 14576: Update to use get_yaml_pref_hash -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 16:47:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 15:47:47 +0000 Subject: [Koha-bugs] [Bug 14576] Allow automatic update of location on checkin In-Reply-To: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14576-70-v8avVgR0ic@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85853|0 |1 is obsolete| | --- Comment #114 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 86815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86815&action=edit Bug 14576: (follow-up) fix some typos and style -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 16:47:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 15:47:52 +0000 Subject: [Koha-bugs] [Bug 14576] Allow automatic update of location on checkin In-Reply-To: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14576-70-Idu9xzx9zC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 --- Comment #115 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 86816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86816&action=edit Bug 14576: Rebase fixes Fix test Rebase code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 16:54:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 15:54:17 +0000 Subject: [Koha-bugs] [Bug 13763] Renew feature does not check for the BarcodeInputFilter option In-Reply-To: <bug-13763-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13763-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13763-70-fEq93JNO1r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13763 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 16:54:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 15:54:39 +0000 Subject: [Koha-bugs] [Bug 15505] Mark Hold Items 'On hold' instead of 'Available' In-Reply-To: <bug-15505-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15505-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15505-70-NHl059p1EJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15505 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 16:54:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 15:54:41 +0000 Subject: [Koha-bugs] [Bug 13763] Renew feature does not check for the BarcodeInputFilter option In-Reply-To: <bug-13763-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13763-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13763-70-28y0GC5Oo3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13763 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 16:54:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 15:54:43 +0000 Subject: [Koha-bugs] [Bug 15505] Mark Hold Items 'On hold' instead of 'Available' In-Reply-To: <bug-15505-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15505-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15505-70-GqYPPWLW6s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15505 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85349|0 |1 is obsolete| | --- Comment #15 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 86817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86817&action=edit Bug 15505 - Mark Hold Items 'On hold' instead of 'Available' This patch adds a 'pending hold' column to C4::Items:GetItemsInfo to allow for displaying status of an item when it has been selected for a hold by the holdsqueue and AllowItemsOnHoldCheckout is set to 'Don't allow' To test: 00 - Set AllowItemsOnHoldCheckout to 'Allow' 01 - Place a hold on an item 02 - Build the holdsqueue (kohadevbox example below) sudo koha-shell kohadev perl misc/cronjobs/holds/build_holds_queue.pl 03 - Search for the item on the OPAC 04 - Note item shows as 'Available' in results and details 05 - Toggle AllowItemsOnHOldCheckout to 'Don't allow' 06 - Repeat search, note there is no change 06 - Apply Patch 07 - Search for the item on the OPAC 08 - Note that item now shows as 'Pending hold' 09 - Toggle AllowItemsOnHoldCheckout to Allow 10 - Note item shows as available 11 - prove -v t/db_dependent/Items.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 16:54:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 15:54:48 +0000 Subject: [Koha-bugs] [Bug 13763] Renew feature does not check for the BarcodeInputFilter option In-Reply-To: <bug-13763-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13763-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13763-70-ktucmRZ73h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13763 --- Comment #12 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86819&action=edit Bug 13763: (follow-up) Strip leading whitespace characters from input barcode this makes the work with barcodes from input consistant on checking out, checking in and renewing Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 16:54:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 15:54:45 +0000 Subject: [Koha-bugs] [Bug 13763] Renew feature does not check for the BarcodeInputFilter option In-Reply-To: <bug-13763-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13763-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13763-70-kE2mxpMVtS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13763 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86745|0 |1 is obsolete| | --- Comment #11 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86818&action=edit Bug 13763: Added check for filter syspref in renew.pl In Circulation->Renew, the renew feature does not check the system preference itemBarcodeFilter to see whether the barcode needs to be converted. This patch fixes this, adding a check for the system pref and applying it accordingly to convert the barcode if it is needed. Test plan: 1) In Circulation->Renew, enter a barcode that you know exists in the catalogue but add extra spaces, breaking up the barcode. Note that this fails with a warning that says 'No item matches this barcode' 2) In system Preferences, set the itemBarcodeInputFilter pref to Remove spaces and repeat step1. Note that the result is the same as in step 1 3) Apply the patch 4) Repeat step 1, and note that the filter removes the spaces and the item is renewed (or gives an error that indicates it recognises the barcode) Sponsored-by: Catalyst IT Signed-off-by: Bin Wen <bin.wen at inlibro.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 16:59:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 15:59:23 +0000 Subject: [Koha-bugs] [Bug 19270] Advanced Editor - Rancor - Add ability to search batches on arbitrary marc fields In-Reply-To: <bug-19270-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19270-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19270-70-Jo3Pwr0UAZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19270 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77912|0 |1 is obsolete| | --- Comment #5 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 86820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86820&action=edit Bug 19270: Rancor - add ability to search batches by arbitrary marc fields To test: 1 - Open advanced cataloging editor 2 - In settings->import batches enable some batches for searching 3 - Click 'Advanced' in the search box 4 - Check an import batch, note a 'MARC field' searchbox appears 5 - Enter some test searches (use '*' as wildcard - add it to both ends of value unless you want exact search) 6 - Note results appear as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 16:59:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 15:59:33 +0000 Subject: [Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron" In-Reply-To: <bug-19919-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19919-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19919-70-ApROnC1lAe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 robbinsk at middlesex.mass.edu changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robbinsk at middlesex.mass.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 17:09:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 16:09:28 +0000 Subject: [Koha-bugs] [Bug 16882] Circ restrictions caused by long overdue should be removed when the offending item is returned In-Reply-To: <bug-16882-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16882-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16882-70-NLEio8YxX9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16882 robbinsk at middlesex.mass.edu changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robbinsk at middlesex.mass.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 17:13:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 16:13:14 +0000 Subject: [Koha-bugs] [Bug 16882] Circ restrictions caused by long overdue should be removed when the offending item is returned In-Reply-To: <bug-16882-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16882-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16882-70-EkfOVDYy22@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16882 --- Comment #2 from robbinsk at middlesex.mass.edu --- We encountered this issue yesterday. Patron returned a long overdue item but the restriction was not removed because she had another item out that was one day overdue. I think the restriction should be removed as long as all of the patron's long overdue items have been returned. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 17:16:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 16:16:08 +0000 Subject: [Koha-bugs] [Bug 22550] New: OPAC suggestion form doesn't require mandatory fields Message-ID: <bug-22550-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22550 Bug ID: 22550 Summary: OPAC suggestion form doesn't require mandatory fields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Depends on: 13618 Target Milestone: --- The OPAC suggestion form requires JavaScript to perform validation of mandatory fields. The configuration of required fields is incorrectly escaped with the html filter and thus breaks, breaking validation. The $raw filter should be used instead. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 [Bug 13618] Add additional template filter methods and a filter presence test to Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 17:16:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 16:16:08 +0000 Subject: [Koha-bugs] [Bug 13618] Add additional template filter methods and a filter presence test to Koha In-Reply-To: <bug-13618-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13618-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13618-70-CB1YDXKlpB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22550 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22550 [Bug 22550] OPAC suggestion form doesn't require mandatory fields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 17:17:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 16:17:51 +0000 Subject: [Koha-bugs] [Bug 22547] C4::Overdues - UpdateFine is barely tested In-Reply-To: <bug-22547-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22547-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22547-70-MO9OXoBUtm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22547 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|C4::Overdues - UpdateFine |C4::Overdues - UpdateFine |is untested |is barely tested -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 17:18:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 16:18:05 +0000 Subject: [Koha-bugs] [Bug 15505] Mark Hold Items 'On hold' instead of 'Available' In-Reply-To: <bug-15505-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15505-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15505-70-03zeLkntB8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15505 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 17:18:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 16:18:10 +0000 Subject: [Koha-bugs] [Bug 15505] Mark Hold Items 'On hold' instead of 'Available' In-Reply-To: <bug-15505-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15505-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15505-70-4M4aW0aNQk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15505 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86817|0 |1 is obsolete| | --- Comment #16 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86821&action=edit Bug 15505: Mark Hold Items 'On hold' instead of 'Available' This patch adds a 'pending hold' column to C4::Items:GetItemsInfo to allow for displaying status of an item when it has been selected for a hold by the holdsqueue and AllowItemsOnHoldCheckout is set to 'Don't allow' To test: 00 - Set AllowItemsOnHoldCheckout to 'Allow' 01 - Place a hold on an item 02 - Build the holdsqueue (kohadevbox example below) sudo koha-shell kohadev perl misc/cronjobs/holds/build_holds_queue.pl 03 - Search for the item on the OPAC 04 - Note item shows as 'Available' in results and details 05 - Toggle AllowItemsOnHOldCheckout to 'Don't allow' 06 - Repeat search, note there is no change 06 - Apply Patch 07 - Search for the item on the OPAC 08 - Note that item now shows as 'Pending hold' 09 - Toggle AllowItemsOnHoldCheckout to Allow 10 - Note item shows as available 11 - prove -v t/db_dependent/Items.t Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 17:33:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 16:33:36 +0000 Subject: [Koha-bugs] [Bug 22551] New: Stray "//" appears at bottom of opac-detail.tt Message-ID: <bug-22551-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22551 Bug ID: 22551 Summary: Stray "//" appears at bottom of opac-detail.tt Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: ephetteplace at cca.edu QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Created attachment 86822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86822&action=edit screenshot of stray characters In the "SocialNetworks" JavaScript area of the OPAC display, there's this code (currently lines 1390-1393 of opac-detail.tt): //<![CDATA[ {lang: '[% lang | html %]'} //]]> </script> It seems like an opening <script> tag is missing (the closing one is orphaned) which results in the "//" characters displaying on the page towards the very bottom (see screenshot). It's not 100% clear to me what this code was intended to do but I think it was meant to be part of the old Google+ (removed from Koha earlier this year) script tag like this: <script src="https://apis.google.com/js/plusone.js" type="text/javascript"> //<![CDATA[ {"lang":"en-US"} //]]> </script> However, right now it's only effect is the stray "//"?the JS code is commented out and even if it wasn't I don't think declaring {"lang": "en-US"} as an object literal unassigned to any variable has any effect. I can make a patch for this shortly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 17:34:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 16:34:33 +0000 Subject: [Koha-bugs] [Bug 22551] Stray "//" appears at bottom of opac-detail.tt In-Reply-To: <bug-22551-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22551-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22551-70-YihyIC1ooW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22551 Eric Phetteplace <ephetteplace at cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |ephetteplace at cca.edu Patch complexity|--- |Trivial patch CC| |ephetteplace at cca.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 17:35:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 16:35:12 +0000 Subject: [Koha-bugs] [Bug 22550] OPAC suggestion form doesn't require mandatory fields In-Reply-To: <bug-22550-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22550-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22550-70-vKq5saU10d@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22550 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 17:35:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 16:35:14 +0000 Subject: [Koha-bugs] [Bug 22550] OPAC suggestion form doesn't require mandatory fields In-Reply-To: <bug-22550-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22550-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22550-70-wnd81UEiiB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22550 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 86823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86823&action=edit Bug 22550: OPAC suggestion form doesn't require mandatory fields This patch changes the template filter on the [% mandatoryfields %] template variable. The variable outputs JSON, so it should have the $raw filter. To test suggestions must be enabled in the OPAC. Apply the patch and go to Purchase suggestions -> New suggestion. In the form, required fields should be labeled in red. It should not be possible to submit the form without filling in these fields. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 17:50:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 16:50:02 +0000 Subject: [Koha-bugs] [Bug 22540] Add ability to place holds using SIP CLI emulator In-Reply-To: <bug-22540-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22540-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22540-70-AC3CXkzfn6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22540 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com Status|Needs Signoff |Failed QA --- Comment #4 from Liz Rea <wizzyrea at gmail.com> --- The vars that didn't get declared aside (I fixed those ones) - this seems to create a string that the sip server sees as a disconnect, so doesn't quite work. It'll be really really good to have this in the emulator though. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 17:52:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 16:52:06 +0000 Subject: [Koha-bugs] [Bug 22540] Add ability to place holds using SIP CLI emulator In-Reply-To: <bug-22540-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22540-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22540-70-PmBskXER7n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22540 --- Comment #5 from Liz Rea <wizzyrea at gmail.com> --- kohadev-koha at kohadevbox:/home/vagrant/kohaclone/misc$ perl sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su=kohasip -sp=Koha1 -l LIB --item=TEST1111 --patron=23529000139858 -m hold Attempting socket connection to 127.0.0.1:6001...connected! SEND: 9300CNkohasip|COKoha1|CPLIB| READ: 941 Trying 'hold' SEND: 15+20190320 165132AOLIB|AA23529000139858|ABTEST1111|ACKoha1|BON| Use of uninitialized value $data in concatenation (.) or string at sip_cli_emulator.pl line 342, <GEN0> chunk 1. READ: Here is the result :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 18:02:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 17:02:05 +0000 Subject: [Koha-bugs] [Bug 22540] Add ability to place holds using SIP CLI emulator In-Reply-To: <bug-22540-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22540-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22540-70-PYG1xaQ1EH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22540 --- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> --- ./misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su koha -sp koha -l LIB --item TEST1111 --patron 23529000139858 -m hold Attempting socket connection to 127.0.0.1:6001...connected! SEND: 9300CNkoha|COkoha|CPLIB| READ: 941 Trying 'hold' SEND: 15+20190320 165942AOLIB|AA23529000139858|ABTEST1111|ACkoha|BON| READ: 160N20190320 165944AA23529000139858|AOkohalibrary|AFNo such item.| Works when the item is missing ;) I'll dig deeper. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 18:05:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 17:05:19 +0000 Subject: [Koha-bugs] [Bug 22551] Stray "//" appears at bottom of opac-detail.tt In-Reply-To: <bug-22551-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22551-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22551-70-5BXBVBnwM9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22551 --- Comment #1 from Eric Phetteplace <ephetteplace at cca.edu> --- Created attachment 86824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86824&action=edit patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 18:05:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 17:05:45 +0000 Subject: [Koha-bugs] [Bug 22551] Stray "//" appears at bottom of opac-detail.tt In-Reply-To: <bug-22551-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22551-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22551-70-TBsDjBtKqT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22551 Eric Phetteplace <ephetteplace at cca.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 18:25:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 17:25:18 +0000 Subject: [Koha-bugs] [Bug 22540] Add ability to place holds using SIP CLI emulator In-Reply-To: <bug-22540-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22540-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22540-70-mEgVGyokxi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22540 --- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 86825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86825&action=edit Bug 22540: (QA Follow-up) borrowernumber is not an accessor for C4::SIP::ILS::Patron, access is via hashref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 18:25:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 17:25:15 +0000 Subject: [Koha-bugs] [Bug 22540] Add ability to place holds using SIP CLI emulator In-Reply-To: <bug-22540-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22540-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22540-70-6Kji0172tM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22540 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 18:32:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 17:32:24 +0000 Subject: [Koha-bugs] [Bug 22540] Add ability to place holds using SIP CLI emulator In-Reply-To: <bug-22540-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22540-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22540-70-3sf8sxrq6K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22540 --- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 86826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86826&action=edit Bug 22540: (QA Follow-up) Add ability to specify the pickup location using a command line parameter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 18:46:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 17:46:06 +0000 Subject: [Koha-bugs] [Bug 22540] Add ability to place holds using SIP CLI emulator In-Reply-To: <bug-22540-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22540-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22540-70-C6FYcvOTUQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22540 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 18:46:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 17:46:09 +0000 Subject: [Koha-bugs] [Bug 22540] Add ability to place holds using SIP CLI emulator In-Reply-To: <bug-22540-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22540-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22540-70-FtMd8KdhsG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22540 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86751|0 |1 is obsolete| | Attachment #86825|0 |1 is obsolete| | Attachment #86826|0 |1 is obsolete| | --- Comment #9 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86827&action=edit Bug 22540: Add ability to place holds using SIP CLI emulator Test Plan: 1) Place a hold using the following arguments: sip_cli_emulator.pl -a <address> -p <port> -su <sip_user> -sp <sip_password> -l <location_code> --patron <cardnumber> --item <barcode> --pickup-location <location_code> -m hold 2) Note the hold was placed in Koha Signed-off-by: Liz Rea <wizzyrea at gmail.com> https://bugs.koha-community.org/show_bug.cgi?id=22330 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 18:46:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 17:46:12 +0000 Subject: [Koha-bugs] [Bug 22540] Add ability to place holds using SIP CLI emulator In-Reply-To: <bug-22540-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22540-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22540-70-XgjlU225AY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22540 --- Comment #10 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86828&action=edit Bug 22540: (QA follow-up) fixes borrowernumber is not an accessor for C4::SIP::ILS::Patron, access is via hashref Add ability to specify the pickup location using a command line parameter Signed-off-by: Liz Rea <wizzyrea at gmail.com> https://bugs.koha-community.org/show_bug.cgi?id=22330 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 19:27:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 18:27:28 +0000 Subject: [Koha-bugs] [Bug 17978] Include 'Next available'/title level holds in holds count when placing holds (opac and staff) In-Reply-To: <bug-17978-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17978-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17978-70-Q32EU21q6c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17978 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 19:27:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 18:27:31 +0000 Subject: [Koha-bugs] [Bug 17978] Include 'Next available'/title level holds in holds count when placing holds (opac and staff) In-Reply-To: <bug-17978-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17978-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17978-70-9ZW0vhpPPq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17978 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73161|0 |1 is obsolete| | Attachment #83476|0 |1 is obsolete| | Attachment #83477|0 |1 is obsolete| | --- Comment #21 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86829&action=edit Bug 17978 - Circ rules will not limit holds The crux of this issue is that all those holds are unfilled record level holds. The code that checks for the number of holds the user already has *always* uses a branchcode of some form. Because of this, any open record level holds are completely ignored for this purpose. Test Plan: 1) Set ReservesControlBranch to "item's home library" 2) Set an All libraries/All Patrons/All itemtypes rules limiting a patron to 2 holds 3) Place 3 record level holds, you can but you should not be able to! 4) Delete the holds 5) Apply this patch 6) Attempt to place 3 record level holds 7) Note that you cannot! Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 19:27:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 18:27:35 +0000 Subject: [Koha-bugs] [Bug 17978] Include 'Next available'/title level holds in holds count when placing holds (opac and staff) In-Reply-To: <bug-17978-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17978-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17978-70-QvUHqsrCmC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17978 --- Comment #22 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86830&action=edit Bug 17978: Check if hold can be placed before placing on placerequest.pl To test: 1 - Set an All/All/All rule with reserves limited 2 to 2 - Search in the staff side 3 - Select all records (or more than 2) from the results 4 - Click 'Place hold' 5 - Find a patron, place holds 6 - You get more holds than you should 7 - Delete those holds 8 - Apply patch 9 - Search and select more than 2 records 10 - Find patron, place holds 11 - Only 2 holds are placed Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 19:27:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 18:27:39 +0000 Subject: [Koha-bugs] [Bug 17978] Include 'Next available'/title level holds in holds count when placing holds (opac and staff) In-Reply-To: <bug-17978-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17978-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17978-70-opZhjCjj6c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17978 --- Comment #23 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86831&action=edit Bug 17978: Unit tests for changes Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 19:57:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 18:57:18 +0000 Subject: [Koha-bugs] [Bug 11340] Make the 'print summary' a custom slip/notice In-Reply-To: <bug-11340-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11340-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11340-70-UsQXLkmgd5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11340 George Williams (NEKLS) <george at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org --- Comment #5 from George Williams (NEKLS) <george at nekls.org> --- +1 Yes. This would be awfully useful. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 20:02:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 19:02:10 +0000 Subject: [Koha-bugs] [Bug 20954] Add ability to set syspref overrides in SIP as we can in apache In-Reply-To: <bug-20954-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20954-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20954-70-OxsALte4wb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20954 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 20:02:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 19:02:12 +0000 Subject: [Koha-bugs] [Bug 20954] Add ability to set syspref overrides in SIP as we can in apache In-Reply-To: <bug-20954-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20954-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20954-70-6S3rWXEaTy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20954 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #76103|0 |1 is obsolete| | --- Comment #3 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86832&action=edit Bug 20954: Add ability to set syspref overrides in SIP as we can in apache We should be able to set system preference overrides for SIP in a similar manner that we do in Apache. It would be great if we could specify those overrides on both a config level, and login level basis. Test Plan: 1) Apply this patch 2) Start your SIP server 3) Enable the syspref AllFinesNeedOverride 4) Find or create a patron with a small fine ( less than noissuescharge ) 5) Attempt to check out an item to the patron, it should fail 6) Add the global syspref override from the bottom of the example SIP config file 7) Restart your SIP server 8) Attempt to check out an item to the patron again, this time it should work 9) Now, add the login level syspref override section as it appears in the eaxmple SIP config file. Make sure to add it to the login you are using 10) Attempt to check out another item to the patron, this time is should again fail Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 20:08:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 19:08:54 +0000 Subject: [Koha-bugs] [Bug 8778] Add "Phrase" Searching to OPAC Search In-Reply-To: <bug-8778-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8778-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8778-70-zKhn7CJF6J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8778 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 20:39:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 19:39:23 +0000 Subject: [Koha-bugs] [Bug 22552] New: Adding users to serials routing search requires edit_borrowers permission Message-ID: <bug-22552-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22552 Bug ID: 22552 Summary: Adding users to serials routing search requires edit_borrowers permission Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Target Milestone: --- TO recreate: Create a staff with only catalogue and routing_list permissions Have a serial existing (or create with a staff who has permission) Login as new staff Find the serial Click 'Create routing list' (should say add to/view?) Try to search for patrons Processing appears indefinitely Sign out, give that staff edit_borrowers permission All works?!? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 20:39:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 19:39:31 +0000 Subject: [Koha-bugs] [Bug 22552] Adding users to serials routing search requires edit_borrowers permission In-Reply-To: <bug-22552-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22552-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22552-70-eEgnEpGWlR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22552 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 20:42:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 19:42:24 +0000 Subject: [Koha-bugs] [Bug 22553] New: Unchecking a subpermission does not uncheck the top level permission Message-ID: <bug-22553-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22553 Bug ID: 22553 Summary: Unchecking a subpermission does not uncheck the top level permission Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Target Milestone: --- To recreate: 1 - Edit permissions for a user 2 - Check a top level permission 3 - Uncheck some sub permissions 4 - Note the top level is still checked 5 - Save 6 - Edit the permissions agin 7 - User has top level permission -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 20:42:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 19:42:42 +0000 Subject: [Koha-bugs] [Bug 22553] Unchecking a subpermission does not uncheck the top level permission In-Reply-To: <bug-22553-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22553-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22553-70-EB2prKTz8Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22553 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Depends on| |11375 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 [Bug 11375] Improve patrons permissions display -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 20:42:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 19:42:42 +0000 Subject: [Koha-bugs] [Bug 11375] Improve patrons permissions display In-Reply-To: <bug-11375-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11375-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11375-70-qTlcHVapGH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11375 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22553 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22553 [Bug 22553] Unchecking a subpermission does not uncheck the top level permission -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 21:20:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 20:20:31 +0000 Subject: [Koha-bugs] [Bug 22554] New: Koha failed to cancel order for deleted bib Message-ID: <bug-22554-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22554 Bug ID: 22554 Summary: Koha failed to cancel order for deleted bib Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- When attempting to cancel an order for a bib that has been deleted, DelOrder tries to cancel an order for which biblionumber="". However, the database shows NULL for aqorders.biblionumber when a bib has been deleted. Consequently, the cancellation fails. Adding to confusion, Koha doesn't give any indication of an error. The system gives a message that the order was cancelled but then, on returning to the basket, the order is still there. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 21:20:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 20:20:47 +0000 Subject: [Koha-bugs] [Bug 22554] Koha failed to cancel order for deleted bib In-Reply-To: <bug-22554-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22554-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22554-70-jyw76jY5K8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22554 Andrew <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 21:35:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 20:35:19 +0000 Subject: [Koha-bugs] [Bug 20935] Redesign system preferences interface In-Reply-To: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20935-70-9MA69pKJ7C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Michal Denar <black23 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 21:35:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 20:35:23 +0000 Subject: [Koha-bugs] [Bug 20935] Redesign system preferences interface In-Reply-To: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20935-70-MXsGzcdUW1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Michal Denar <black23 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86784|0 |1 is obsolete| | Attachment #86785|0 |1 is obsolete| | Attachment #86786|0 |1 is obsolete| | Attachment #86787|0 |1 is obsolete| | Attachment #86788|0 |1 is obsolete| | --- Comment #51 from Michal Denar <black23 at gmail.com> --- Created attachment 86833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86833&action=edit Bug 20935: Redesign system preferences interface This patch proposes a new interface for system preferences. The goal is to make the interface more readable and to give the user additional options for finding what they need. - Restructures the preferences list as a <dl>, with the preference name as the <dt> and the description as the <dd>. - Add a JS filter library (mark.js) to do live filtering of the page and add search term highlighting. - When the user has searched, show links to the sections in which results were returned. To test, apply the patch and go to Administration -> System preferences. - Test the functionality of setting various kinds of preferences, including multi-selects, textareas, WYSIWYG editors, etc. - Test the filter form at the top of the page for narrowing in-page results. - Test both successful and unsuccessful filters. - Perform a system preference search. - Test the in-page links to the different sections. - Test that in-page filtering works in this case too. - View the licenses tab of the "About" page and check that the information about mark.js looks correct. Followed test plan and pleased to say everything worked as expected. Looking forward to this enhancement. Signed-off-by: Dilan Johnpull? <dilan at calyx.net.au> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Michal Denar <black23 at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 21:35:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 20:35:28 +0000 Subject: [Koha-bugs] [Bug 20935] Redesign system preferences interface In-Reply-To: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20935-70-qksMtgwLWr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #52 from Michal Denar <black23 at gmail.com> --- Created attachment 86834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86834&action=edit Bug 20935: Remove "Click to" from some links Changes "Click to edit" and "Click to collapse" to just "Edit" and "Collapse" as the "Click to" appears not necessary for elements formatted as links. Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Michal Denar <black23 at gmail.com> Signed-off-by: Michal Denar <black23 at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 21:35:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 20:35:33 +0000 Subject: [Koha-bugs] [Bug 20935] Redesign system preferences interface In-Reply-To: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20935-70-VP9W2lA9vx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #53 from Michal Denar <black23 at gmail.com> --- Created attachment 86835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86835&action=edit Bug 20935: Remove 'no match' box when it does Test plan: Hit /cgi-bin/koha/admin/preferences.pl Search for "AcqCreateX" => You get "No matching terms were found on this page" Remove the last X => Without this patch the "no matching" box is still displayed Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Michal Denar <black23 at gmail.com> Signed-off-by: Michal Denar <black23 at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 21:35:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 20:35:37 +0000 Subject: [Koha-bugs] [Bug 20935] Redesign system preferences interface In-Reply-To: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20935-70-XYYtD5lEYy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #54 from Michal Denar <black23 at gmail.com> --- Created attachment 86836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86836&action=edit Bug 20935: Add in-page links to the sidebar This patch adds links to the sidebar menu which allow the user to jump to a section within the page. Signed-off-by: Michal Denar <black23 at gmail.com> Signed-off-by: Michal Denar <black23 at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 21:35:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 20:35:41 +0000 Subject: [Koha-bugs] [Bug 20935] Redesign system preferences interface In-Reply-To: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20935-70-FpJoCyf9uo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #55 from Michal Denar <black23 at gmail.com> --- Created attachment 86837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86837&action=edit Bug 20935: Add missing html filter Signed-off-by: Michal Denar <black23 at gmail.com> Signed-off-by: Michal Denar <black23 at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 20 23:42:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Mar 2019 22:42:53 +0000 Subject: [Koha-bugs] [Bug 22099] "List requests" button displays when listing requests In-Reply-To: <bug-22099-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22099-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22099-70-tUjYBrSvgv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22099 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |hayleymapley at catalyst.net.n | |z Assignee|koha-bugs at lists.koha-commun |hayleymapley at catalyst.net.n |ity.org |z -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 01:33:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 00:33:01 +0000 Subject: [Koha-bugs] [Bug 22555] New: Subscriptions page doesn't show subscriptions on load of Serials page Message-ID: <bug-22555-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22555 Bug ID: 22555 Summary: Subscriptions page doesn't show subscriptions on load of Serials page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: hayleymapley at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Target Milestone: --- At present, when clicking onto the Serials page the available options are to Search subscriptions or add a new subscription. It would be useful if clicking onto the Serials page showed the list of Serial subscriptions, rather than having to submit an empty search to see them all. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 01:41:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 00:41:14 +0000 Subject: [Koha-bugs] [Bug 22555] Serials page doesn't show subscriptions on page load In-Reply-To: <bug-22555-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22555-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22555-70-KXKlyTcoxV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22555 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Subscriptions page doesn't |Serials page doesn't show |show subscriptions on load |subscriptions on page load |of Serials page | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 01:41:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 00:41:31 +0000 Subject: [Koha-bugs] [Bug 22555] Serials page doesn't show subscriptions on page load In-Reply-To: <bug-22555-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22555-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22555-70-bulsT4BRyf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22555 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |hayleymapley at catalyst.net.n |ity.org |z Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 02:14:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 01:14:40 +0000 Subject: [Koha-bugs] [Bug 22533] maninvoice.pl is using deprecated maininvoice() method In-Reply-To: <bug-22533-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22533-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22533-70-WPacJ784uY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22533 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 02:14:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 01:14:43 +0000 Subject: [Koha-bugs] [Bug 22533] maninvoice.pl is using deprecated maininvoice() method In-Reply-To: <bug-22533-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22533-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22533-70-Pwk8YNwZbf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22533 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86757|0 |1 is obsolete| | --- Comment #2 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Created attachment 86838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86838&action=edit Bug 22533: maninvoice.pl is using deprecated maininvoice() method To test: Attempt to create a manual fine from the patron accounting page, it should fail. Apply this patch, restart the things Attempt to create a manual fine from the patron accounting page, it should succeed. Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 02:54:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 01:54:39 +0000 Subject: [Koha-bugs] [Bug 22099] "List requests" button displays when listing requests In-Reply-To: <bug-22099-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22099-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22099-70-AbPqg7XVm4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22099 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 02:54:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 01:54:41 +0000 Subject: [Koha-bugs] [Bug 22099] "List requests" button displays when listing requests In-Reply-To: <bug-22099-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22099-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22099-70-HyXlABE1Yo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22099 --- Comment #2 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Created attachment 86839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86839&action=edit Bug 22099: Fixed ILL toolbar to say Refresh when displaying requests On the ILL requests page that lists all requests, the List Request button is displayed as part of the ILL toolbar. This patch fixes this by instead changing the wording of the button to Refresh when on the main page. Test plan: 1) More -> ILL Requests, note that the List Requests button displays while all the requests are already displayed 2) Apply the patch and restart things 3) More -> ILL Requests, note that the button now says Refresh, and clicking it refreshes the page 4) Check that on all the other functions of the ILLs the button says List Requests 5) Sign off! Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 02:58:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 01:58:03 +0000 Subject: [Koha-bugs] [Bug 22099] "List requests" button displays when listing requests In-Reply-To: <bug-22099-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22099-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22099-70-hYWB4Uc6p7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22099 Alex Buckley <alexbuckley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 02:59:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 01:59:38 +0000 Subject: [Koha-bugs] [Bug 22451] Asset plugin is using the version from the DB In-Reply-To: <bug-22451-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22451-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22451-70-Wu6YinK0Hs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22451 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 06:05:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 05:05:05 +0000 Subject: [Koha-bugs] [Bug 18645] Creation of Koha feature release change tool displayed after running Koha update In-Reply-To: <bug-18645-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18645-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18645-70-M1ylKy2BhE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18645 Alex Buckley <alexbuckley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|alexbuckley at catalyst.net.nz |aleisha at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 06:06:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 05:06:36 +0000 Subject: [Koha-bugs] [Bug 19780] Actual price is not updated after it has been amended post receiving an order In-Reply-To: <bug-19780-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19780-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19780-70-M0JT2IXI0D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19780 Alex Buckley <alexbuckley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|alexbuckley at catalyst.net.nz |hayleymapley at catalyst.net.n | |z -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 06:08:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 05:08:39 +0000 Subject: [Koha-bugs] [Bug 21266] Missing doc-head-close and cssinclude in sco-main.tt In-Reply-To: <bug-21266-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21266-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21266-70-xHXb4sHr8e@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21266 Alex Buckley <alexbuckley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|alexbuckley at catalyst.net.nz |aleisha at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 06:12:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 05:12:17 +0000 Subject: [Koha-bugs] [Bug 18888] Include the definition of currency in onboarding tool In-Reply-To: <bug-18888-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18888-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18888-70-YaBdPcWAdy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18888 Alex Buckley <alexbuckley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|alexbuckley at catalyst.net.nz |hayleymapley at catalyst.net.n | |z -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 06:13:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 05:13:18 +0000 Subject: [Koha-bugs] [Bug 19189] Reserving and renewing item in OPAC selenium test In-Reply-To: <bug-19189-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19189-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19189-70-5yr0C1Tf6z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19189 Alex Buckley <alexbuckley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |koha-bugs at lists.koha-commun |y.org |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 06:14:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 05:14:08 +0000 Subject: [Koha-bugs] [Bug 19189] Reserving and renewing item in OPAC selenium test In-Reply-To: <bug-19189-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19189-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19189-70-g8Do3y98oy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19189 Alex Buckley <alexbuckley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|koha-bugs at lists.koha-commun |testopia at bugs.koha-communit |ity.org |y.org Assignee|alexbuckley at catalyst.net.nz |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 06:15:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 05:15:09 +0000 Subject: [Koha-bugs] [Bug 21265] Additional step at end of onboarder to enable HEA In-Reply-To: <bug-21265-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21265-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21265-70-3oFIcn7Dim@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21265 Alex Buckley <alexbuckley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|alexbuckley at catalyst.net.nz |hayleymapley at catalyst.net.n | |z Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 06:17:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 05:17:05 +0000 Subject: [Koha-bugs] [Bug 19394] Add ability for IT administrators to skip onboarding tool, and then display the tool to superlibrarians when they first log in In-Reply-To: <bug-19394-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19394-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19394-70-X4sqK1pWuw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19394 Alex Buckley <alexbuckley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|alexbuckley at catalyst.net.nz |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 06:19:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 05:19:26 +0000 Subject: [Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased In-Reply-To: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18308-70-eTvtRwcQHX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308 Alex Buckley <alexbuckley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|alexbuckley at catalyst.net.nz |hayleymapley at catalyst.net.n | |z -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 06:22:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 05:22:17 +0000 Subject: [Koha-bugs] [Bug 19360] Give items URL a link text In-Reply-To: <bug-19360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19360-70-FenFNV19td@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19360 Alex Buckley <alexbuckley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |ASSIGNED Assignee|alexbuckley at catalyst.net.nz |hayleymapley at catalyst.net.n | |z -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 06:23:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 05:23:14 +0000 Subject: [Koha-bugs] [Bug 18060] Add onboarding functionality to guide users through setting up labels for the first time In-Reply-To: <bug-18060-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18060-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18060-70-zvYevtuZUN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18060 Alex Buckley <alexbuckley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|alexbuckley at catalyst.net.nz |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 06:23:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 05:23:52 +0000 Subject: [Koha-bugs] [Bug 19330] Selenium test for Tool module functionality In-Reply-To: <bug-19330-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19330-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19330-70-Di7XdW4SBY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19330 Alex Buckley <alexbuckley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|alexbuckley at catalyst.net.nz |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 06:25:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 05:25:22 +0000 Subject: [Koha-bugs] [Bug 18212] Move SQL code from aqplan.pl administrative script into Koha directory perl modules In-Reply-To: <bug-18212-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18212-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18212-70-m7hbt3yyTU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18212 Alex Buckley <alexbuckley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|alexbuckley at catalyst.net.nz |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 06:27:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 05:27:24 +0000 Subject: [Koha-bugs] [Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values In-Reply-To: <bug-21159-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21159-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21159-70-LaY6xXbVbN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Alex Buckley <alexbuckley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|alexbuckley at catalyst.net.nz |hayleymapley at catalyst.net.n | |z -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 08:40:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 07:40:27 +0000 Subject: [Koha-bugs] [Bug 20128] Permission for advanced editor In-Reply-To: <bug-20128-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20128-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20128-70-cZ15jvtv7c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20128 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |ASSIGNED --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Sorry Nick, I hadn't spotted this.. I'm in meetings all day today but will hit it as my first priority on Friday. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 08:40:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 07:40:33 +0000 Subject: [Koha-bugs] [Bug 20128] Permission for advanced editor In-Reply-To: <bug-20128-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20128-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20128-70-wyWkzmovyK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20128 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 09:01:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 08:01:30 +0000 Subject: [Koha-bugs] [Bug 20935] Redesign system preferences interface In-Reply-To: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20935-70-FjufPxBoIw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 --- Comment #56 from Josef Moravec <josef.moravec at gmail.com> --- Comment on attachment 86837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86837 Bug 20935: Add missing html filter Review of attachment 86837: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20935&attachment=86837) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences.tt @@ +38,4 @@ > <div id="toolbar"> > Results in sections: > [% FOREACH TAB IN TABS %] > + <a href="#[% TAB.tab_title | url %]">[% TAB.tab_title | html %]</a>[% UNLESS ( loop.last ) %] • [% END %] In fragment you should use uri filter, not url. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 09:03:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 08:03:23 +0000 Subject: [Koha-bugs] [Bug 20935] Redesign system preferences interface In-Reply-To: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20935-70-HKl3eiX4Zg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #57 from Josef Moravec <josef.moravec at gmail.com> --- I have question about multiselect fields: - Should the text be blue? I think we could stay with black here - The width of multiselect field is set bad, so there is scrollbar at the bottom, is it possible to do something with that? See screenshot: https://prnt.sc/n0u6ji Marking Failed QA means I need answer here. Otherwise it is looking good. (Just the small issue with uri/url filter) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 09:03:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 08:03:34 +0000 Subject: [Koha-bugs] [Bug 20935] Redesign system preferences interface In-Reply-To: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20935-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20935-70-bVP1uyT5nc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20935 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 09:49:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 08:49:13 +0000 Subject: [Koha-bugs] [Bug 19294] ILS-DI: HoldTitle and HoldItem don't consider "on shelf holds allowed" setting In-Reply-To: <bug-19294-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19294-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19294-70-FssUVt6gh1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19294 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21300 CC| |arthur.suzuki at biblibre.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21300 [Bug 21300] Restriction of ILS-DI webservice to 1st and 2d level by default -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 09:49:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 08:49:13 +0000 Subject: [Koha-bugs] [Bug 21300] Restriction of ILS-DI webservice to 1st and 2d level by default In-Reply-To: <bug-21300-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21300-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21300-70-DaPkAwxFwN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21300 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19294 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19294 [Bug 19294] ILS-DI: HoldTitle and HoldItem don't consider "on shelf holds allowed" setting -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 09:48:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 08:48:53 +0000 Subject: [Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy In-Reply-To: <bug-20985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20985-70-FMjHIdykLf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com --- Comment #1 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- Isn't this a duplicate of 19294 since HoldTitle and HoldItem calls CanBookBeReserved and CanItemBeReserved to check if reference can be reserved? Or does it solves 19294? -> I guess so. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 09:50:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 08:50:05 +0000 Subject: [Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy In-Reply-To: <bug-20985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20985-70-KiqLGbvR1l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |19294 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19294 [Bug 19294] ILS-DI: HoldTitle and HoldItem don't consider "on shelf holds allowed" setting -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 09:50:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 08:50:05 +0000 Subject: [Koha-bugs] [Bug 21300] Restriction of ILS-DI webservice to 1st and 2d level by default In-Reply-To: <bug-21300-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21300-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21300-70-3NIt5olTr6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21300 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|19294 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19294 [Bug 19294] ILS-DI: HoldTitle and HoldItem don't consider "on shelf holds allowed" setting -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 09:50:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 08:50:05 +0000 Subject: [Koha-bugs] [Bug 19294] ILS-DI: HoldTitle and HoldItem don't consider "on shelf holds allowed" setting In-Reply-To: <bug-19294-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19294-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19294-70-FuL246WKpu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19294 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|21300 |20985 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21300 [Bug 21300] Restriction of ILS-DI webservice to 1st and 2d level by default -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 11:20:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 10:20:35 +0000 Subject: [Koha-bugs] [Bug 20128] Permission for advanced editor In-Reply-To: <bug-20128-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20128-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20128-70-YjeZE2YlLR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20128 --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86840&action=edit Bug 20128: (QA Follow-up) Corrections to haspermission The haspermission routine wrongly assumed that get_user_subpermissions would return a list of all subpermissions if the user had the top level permission, but instead if just returns 1. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 11:26:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 10:26:47 +0000 Subject: [Koha-bugs] [Bug 20128] Permission for advanced editor In-Reply-To: <bug-20128-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20128-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20128-70-9PBU4xLIwU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20128 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- OK, I found a moment at the beginning of my meeting ;) I've uploaded one option which uses the existing structure created by get_user_subpermissions, however there is an alternate option we could follow of adapting getuserpermissions to return all subpermissions in a hash if the top level flag is set rather than just returning the boolean 1. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 11:27:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 10:27:02 +0000 Subject: [Koha-bugs] [Bug 20128] Permission for advanced editor In-Reply-To: <bug-20128-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20128-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20128-70-zG63O3KNhd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20128 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 11:28:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 10:28:43 +0000 Subject: [Koha-bugs] [Bug 20128] Permission for advanced editor In-Reply-To: <bug-20128-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20128-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20128-70-WOaE4GviJr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20128 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 11:29:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 10:29:01 +0000 Subject: [Koha-bugs] [Bug 20128] Permission for advanced editor In-Reply-To: <bug-20128-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20128-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20128-70-5GaSJZetOo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20128 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 11:33:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 10:33:17 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15326-70-N4dYGJNeRD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Janet McGowan <janet.mcgowan at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 11:40:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 10:40:44 +0000 Subject: [Koha-bugs] [Bug 22556] New: Add ability to quickly filter funds/budgets by library on the Acquisitions home page Message-ID: <bug-22556-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22556 Bug ID: 22556 Summary: Add ability to quickly filter funds/budgets by library on the Acquisitions home page Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Some librarians would like to have a quick pulldown selector to filter budgets and funds by library on the acquisitions home page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 11:41:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 10:41:12 +0000 Subject: [Koha-bugs] [Bug 22556] Add ability to quickly filter funds/budgets by library on the Acquisitions home page In-Reply-To: <bug-22556-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22556-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22556-70-6XygcsLrXc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22556 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- *** Bug 20574 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 11:41:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 10:41:12 +0000 Subject: [Koha-bugs] [Bug 20574] Acquisitions Views In-Reply-To: <bug-20574-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20574-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20574-70-Rbe6PSZe7F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20574 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- *** This bug has been marked as a duplicate of bug 22556 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 11:42:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 10:42:30 +0000 Subject: [Koha-bugs] [Bug 22556] Add ability to quickly filter funds/budgets by library on the Acquisitions home page In-Reply-To: <bug-22556-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22556-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22556-70-qJvridA4LC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22556 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 11:45:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 10:45:48 +0000 Subject: [Koha-bugs] [Bug 22556] Add ability to quickly filter funds/budgets by library on the Acquisitions home page In-Reply-To: <bug-22556-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22556-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22556-70-d2hy1Dww92@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22556 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 11:45:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 10:45:50 +0000 Subject: [Koha-bugs] [Bug 22556] Add ability to quickly filter funds/budgets by library on the Acquisitions home page In-Reply-To: <bug-22556-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22556-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22556-70-NSgcE05uYb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22556 --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 86841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86841&action=edit Bug 22556: Add ability to quickly filter funds/budgets by library on the Acquisitions home page Some librarians would like to have a quick pulldown selector to filter budgets and funds by library on the acquisitions home page. Test Plan: 1) Apply this patch 2) Navigate to the Acquisitions home page 3) Notice the new pulldown on the budgets table labeled "Filter by library" 4) Select a library that has one or more budgets/funds 5) Note only budgets/funds from that library now display! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 12:10:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 11:10:42 +0000 Subject: [Koha-bugs] [Bug 22533] maninvoice.pl is using deprecated maininvoice() method In-Reply-To: <bug-22533-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22533-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22533-70-4NgHjRfLWk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22533 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- While this fixes a bug, we should move forward with bug 22393, which completely removes the use of manualinvoice. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 12:10:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 11:10:50 +0000 Subject: [Koha-bugs] [Bug 22393] Remove last remaining manualinvoice use In-Reply-To: <bug-22393-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22393-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22393-70-pFOXU9q3gl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22393 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22533 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 12:10:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 11:10:50 +0000 Subject: [Koha-bugs] [Bug 22533] maninvoice.pl is using deprecated maininvoice() method In-Reply-To: <bug-22533-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22533-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22533-70-asPVa3lCOO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22533 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22393 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 12:12:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 11:12:21 +0000 Subject: [Koha-bugs] [Bug 22393] Remove last remaining manualinvoice use In-Reply-To: <bug-22393-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22393-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22393-70-DPLbeGjtGa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22393 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|NEW |Needs Signoff Target Milestone|--- |19.05 Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 12:13:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 11:13:14 +0000 Subject: [Koha-bugs] [Bug 22393] Remove last remaining manualinvoice use In-Reply-To: <bug-22393-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22393-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22393-70-oFG8iRfAAe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22393 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 12:22:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 11:22:16 +0000 Subject: [Koha-bugs] [Bug 22533] maninvoice.pl is using deprecated maininvoice() method In-Reply-To: <bug-22533-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22533-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22533-70-8HBOfmf9ao@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22533 --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Sorry, I'd been meaning to get to this one. I think this is a reasonable temporary fix to get master happy again.. bug 22393 isn't ready for testing as is yet.. unfortunately it turned into a bit of a monster (see the dependency tree above it) which I'm working my way through presently. I actually think this bug is also somewhat mis-described, it's a circular dependency issue if I'm reading it right. Which I believe was introduced by the re-arrangement of use statements in the new overdues work bu (sorry, I missed it during QA :( ). In short.. I'd say go for this one whilst I continue to get the tree for 22393 into a good state for testing and qa. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 12:25:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 11:25:09 +0000 Subject: [Koha-bugs] [Bug 22533] maninvoice.pl is using deprecated maininvoice() method In-Reply-To: <bug-22533-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22533-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22533-70-uKYXO8D3LY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22533 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 12:25:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 11:25:14 +0000 Subject: [Koha-bugs] [Bug 7187] Prioritize cover image sources such as Amazon, Google and add fail over i.e. if first source fails, go to next In-Reply-To: <bug-7187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7187-70-PP1g15eOi1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187 George Veranis <gveranis at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gveranis at gmail.com --- Comment #51 from George Veranis <gveranis at gmail.com> --- Someone who solved by js https://catalog.sll.texas.gov/opac-tmpl/bootstrap/js/localcovers_18.0510000.js -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 12:25:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 11:25:01 +0000 Subject: [Koha-bugs] [Bug 22533] maninvoice.pl is using deprecated maininvoice() method In-Reply-To: <bug-22533-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22533-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22533-70-JZESAdVntv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22533 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | Assignee|koha-bugs at lists.koha-commun |wizzyrea at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 12:28:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 11:28:12 +0000 Subject: [Koha-bugs] [Bug 7187] Prioritize cover image sources such as Amazon, Google and add fail over i.e. if first source fails, go to next In-Reply-To: <bug-7187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7187-70-S0hsZ4TzYg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187 --- Comment #52 from George Veranis <gveranis at gmail.com> --- sorry mistake, wrong reply (In reply to George Veranis from comment #51) > Someone who solved by js > > https://catalog.sll.texas.gov/opac-tmpl/bootstrap/js/localcovers_18.0510000. > js -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 12:30:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 11:30:29 +0000 Subject: [Koha-bugs] [Bug 22393] Remove last remaining manualinvoice use In-Reply-To: <bug-22393-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22393-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22393-70-ThZcqpSglm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22393 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 12:34:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 11:34:51 +0000 Subject: [Koha-bugs] [Bug 22545] C4::Matcher::get_matches aggressive isbn and issn search don't give any results with ES In-Reply-To: <bug-22545-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22545-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22545-70-HIYwBGZV3D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22545 --- Comment #2 from Johanna R?is? <johanna.raisa at koha-suomi.fi> --- Bug 22545: C4::Matcher::get_matches aggressive isbn and issn search don't give any results with ES TEST PLAN: - Use Elastic as search engine - Turn off UseQueryParser systempreference - Turn on AggressiveMatchOnISBN systempreference - Stage records with ISBN rule - See that there are no matches - Apply the patch - Stage records again - See that matches are found -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 12:35:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 11:35:19 +0000 Subject: [Koha-bugs] [Bug 7187] Prioritize cover image sources such as Amazon, Google and add fail over i.e. if first source fails, go to next In-Reply-To: <bug-7187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7187-70-P1QNS6SmP2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7187 Zeno Tajoli <ztajoli at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|ztajoli at gmail.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 12:37:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 11:37:31 +0000 Subject: [Koha-bugs] [Bug 12087] Improve purge of suggestions: to delete only suggestions with specified status In-Reply-To: <bug-12087-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12087-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12087-70-RMdO8jfifx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12087 Zeno Tajoli <ztajoli at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 12:38:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 11:38:14 +0000 Subject: [Koha-bugs] [Bug 13698] A template for linking almost MARC21 linking fields (76x-78x) In-Reply-To: <bug-13698-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13698-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13698-70-XNhvxncQMY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13698 Zeno Tajoli <ztajoli at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|ASSIGNED |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 13:33:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 12:33:17 +0000 Subject: [Koha-bugs] [Bug 22541] Invoice adjustments should show invoice number and include link on ordered.pl and spent.pl In-Reply-To: <bug-22541-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22541-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22541-70-U6VbvCtcNF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22541 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 13:33:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 12:33:19 +0000 Subject: [Koha-bugs] [Bug 22541] Invoice adjustments should show invoice number and include link on ordered.pl and spent.pl In-Reply-To: <bug-22541-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22541-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22541-70-TVPND8LoYX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22541 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 86842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86842&action=edit Bug 22541: Use invoicenumber and link to invoice on spent and ordered pages To test: 1 - Find a vendor in acquisitions 2 - Click 'receive shipment' 3 - Create an invoice 4 - Click 'Finish receiving' 5 - Add an adjustment that encumbers while open and update adjustments 6 - Go to acqui-home and click on the ordered total for the fund with the adjustment 7 - Note the invoice adjustment shows the invoice id and does not link 8 - Add another invoice and another adjustment, but close the invoice this time 9 - Go to acqui-home and click on the spent total for the fund with the adjustment 10 - Note the invoice adjustment shows the invoice id and does not link 11 - Apply patch 12 - Visit the spent and ordered pages and note the adjustments show invoicenumber and are links 13 - prove -v t/db_dependent/Koha/Acquisition/Invoice/Adjustments.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 13:33:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 12:33:54 +0000 Subject: [Koha-bugs] [Bug 22541] Invoice adjustments should show invoice number and include link on ordered.pl and spent.pl In-Reply-To: <bug-22541-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22541-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22541-70-bUsl58ljfW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22541 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | Version|18.11 |master Severity|minor |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 14:46:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 13:46:35 +0000 Subject: [Koha-bugs] [Bug 22296] Invoice adjustments are not populating to budget views In-Reply-To: <bug-22296-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22296-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22296-70-9TmtUMZdKL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22296 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Pushed to 18.11.x for 18.11.04.. seems I forgot to update bugzilla at the time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 15:17:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 14:17:49 +0000 Subject: [Koha-bugs] [Bug 21890] Patron password reset by category In-Reply-To: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21890-70-gjX7HSv868@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85006|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 15:22:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 14:22:39 +0000 Subject: [Koha-bugs] [Bug 21890] Patron password reset by category In-Reply-To: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21890-70-E9ZgdmvEuj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 15:22:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 14:22:45 +0000 Subject: [Koha-bugs] [Bug 21890] Patron password reset by category In-Reply-To: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21890-70-H8oAxJL1SR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85001|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 15:22:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 14:22:48 +0000 Subject: [Koha-bugs] [Bug 21890] Patron password reset by category In-Reply-To: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21890-70-SKCNtscyfh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85002|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 15:22:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 14:22:50 +0000 Subject: [Koha-bugs] [Bug 21890] Patron password reset by category In-Reply-To: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21890-70-0znKagNmZP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85003|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 15:22:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 14:22:53 +0000 Subject: [Koha-bugs] [Bug 21890] Patron password reset by category In-Reply-To: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21890-70-QoTLl845E2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85004|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 15:22:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 14:22:56 +0000 Subject: [Koha-bugs] [Bug 21890] Patron password reset by category In-Reply-To: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21890-70-buUKFXHmUv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85005|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 15:23:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 14:23:42 +0000 Subject: [Koha-bugs] [Bug 21890] Patron password reset by category In-Reply-To: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21890-70-QboSWAu9MX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890 --- Comment #27 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 86843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86843&action=edit Bug 21890: DB updates This patch adds a new column to the categories table: 'reset_password' which is a boolean, and represents, well... that. The value itself is nullable. The idea is that OpacResetPassword governs the general behaviour, and this can be overriden at category-level. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 15:23:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 14:23:48 +0000 Subject: [Koha-bugs] [Bug 21890] Patron password reset by category In-Reply-To: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21890-70-x88uvrwROl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890 --- Comment #28 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 86844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86844&action=edit Bug 21890: Handle can_reset_password on the staff interface This patch makes the staff interface handle the new flag when editing the categories. I didn't add the flag to the list of categories table because it makes it too big, but can be easily added if required by users or QA. To test: - Along with other patches from this bug, edit patron categories => SUCCESS: Notice the changes are correctly stored - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 15:23:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 14:23:54 +0000 Subject: [Koha-bugs] [Bug 21890] Patron password reset by category In-Reply-To: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21890-70-2a35C5Ghyh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890 --- Comment #29 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 86845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86845&action=edit Bug 21890: Add Koha::Patron::Category->effective_reset_password method This method checks wether the local $self->reset_password is set to override the OpacResetPassword syspref (i.e. if it is set to a bool) or undef, in which case if falls back to the value of the syspref. To test: - Apply this patches - Make sure the DB is updated: $ updatedatabase - Update the schema files: $ dbic - Run: $ kshell k$ prove t/db_dependent/Koha/Patron/Category.t => SUCCESS: Tests pass! - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 15:23:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 14:23:59 +0000 Subject: [Koha-bugs] [Bug 21890] Patron password reset by category In-Reply-To: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21890-70-3O98hdt33i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890 --- Comment #30 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 86846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86846&action=edit Bug 21890: Add can_any_reset_password() to the Categories TT plugin This patch introduces a method to the Koha::Template::Plugin::Categories TT plugin. This methods queries for categories filtering them by effective_reset_password flag set, and returns a boolean representing the fact that there's at least one category allowed. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Template/Plugin/Categories.t => SUCCESS: Tests pass! - Sign off :-D Caveat: this patch/tests require the schema to be updated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 15:24:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 14:24:04 +0000 Subject: [Koha-bugs] [Bug 21890] Patron password reset by category In-Reply-To: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21890-70-fZTpnsyCzB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890 --- Comment #31 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 86847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86847&action=edit Bug 21890: Allow restricting password resets by patron category This patch makes the templates relying on the OpacResetPassword syspref use the introduced TT plugin method instead by changing: [% IF Koha.Preference('OpacResetPassword') %] => [% IF Categories.can_any_reset_password %] To test: - Verify that all the places in which the 'forgot password' link is displayed in OPAC keep working, provided there's at least one category that has the flag set - Attempt to recover the password for a patron that belong to a valid category (i.e. that has the flag set) => SUCCESS: You can go through the normal process - Attempt to recover the password for a patron that belongs to a category with the flag unset. => SUCCESS: Once Koha identifies your category, you are told you are not allowed to do it - Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 15:25:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 14:25:18 +0000 Subject: [Koha-bugs] [Bug 21890] Patron password reset by category In-Reply-To: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21890-70-vo7bHvAGY8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890 --- Comment #32 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- I resubmitted after checking some merge conflicts. I removed the DBIC update so run: $ dbic on kohadevbox to regenerate them on testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 15:27:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 14:27:05 +0000 Subject: [Koha-bugs] [Bug 10796] Allow OpacPasswordChange to be set by category type In-Reply-To: <bug-10796-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10796-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10796-70-6a2EgUeS1w@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10796 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85393|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 15:27:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 14:27:24 +0000 Subject: [Koha-bugs] [Bug 10796] Allow OpacPasswordChange to be set by category type In-Reply-To: <bug-10796-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10796-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10796-70-XNk3m3jcWK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10796 --- Comment #6 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Obsoleted the DBIC update as well, as it is counter-productive. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 15:29:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 14:29:37 +0000 Subject: [Koha-bugs] [Bug 22554] Koha failed to cancel order for deleted bib In-Reply-To: <bug-22554-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22554-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22554-70-1AXVJ6TiRe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22554 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- *** This bug has been marked as a duplicate of bug 10869 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 15:29:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 14:29:37 +0000 Subject: [Koha-bugs] [Bug 10869] Can't delete order line if title deleted In-Reply-To: <bug-10869-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10869-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10869-70-ynWVVoTp7A@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #89 from Nick Clemens <nick at bywatersolutions.com> --- *** Bug 22554 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 15:29:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 14:29:59 +0000 Subject: [Koha-bugs] [Bug 13978] Add cancellation link to hold notification e-mails In-Reply-To: <bug-13978-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13978-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13978-70-8sIyFwvlOm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13978 Sally Healey <sally.healey at cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 15:30:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 14:30:35 +0000 Subject: [Koha-bugs] [Bug 10869] Can't cancel order line if title deleted In-Reply-To: <bug-10869-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10869-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10869-70-Yv6QAEWeuD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10869 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Can't delete order line if |Can't cancel order line if |title deleted |title deleted CC| |nick at bywatersolutions.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10984 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 15:30:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 14:30:35 +0000 Subject: [Koha-bugs] [Bug 10984] Cannot cancel received order if the parent order is deleted In-Reply-To: <bug-10984-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10984-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10984-70-ctMAn6mPCb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10984 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10869 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 15:34:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 14:34:17 +0000 Subject: [Koha-bugs] [Bug 21049] Rancor 007 field does not retain value In-Reply-To: <bug-21049-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21049-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21049-70-9XP0YPOKwA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21049 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #7 from Liz Rea <wizzyrea at gmail.com> --- This fixes the 007, howver while testing this I discovered the same issue happens on the 008. Will check for a bug for that, and if none will file one. Signing off on this fix for the 007. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 15:35:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 14:35:26 +0000 Subject: [Koha-bugs] [Bug 21049] Rancor 007 field does not retain value In-Reply-To: <bug-21049-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21049-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21049-70-5Gj6zm31Cc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21049 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 15:35:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 14:35:29 +0000 Subject: [Koha-bugs] [Bug 21049] Rancor 007 field does not retain value In-Reply-To: <bug-21049-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21049-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21049-70-Re1rYz1Cg4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21049 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86351|0 |1 is obsolete| | Attachment #86352|0 |1 is obsolete| | --- Comment #8 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86848&action=edit Bug 21049: Fix value of material select for Rancor 007 widget The material type is selected in accordance with position 0 of 007 Test plan: 1. Create a new record using the advanced editor 2. Select a material type for field 007 and set at least the position 0 of this field 3. Save the record and reload the page 4. The material type should remain selected 5. Try with all available material types Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 15:35:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 14:35:32 +0000 Subject: [Koha-bugs] [Bug 21049] Rancor 007 field does not retain value In-Reply-To: <bug-21049-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21049-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21049-70-xQzQdaiF8F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21049 --- Comment #9 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86849&action=edit Bug 21049: Set 007/00 when selecting material type (Rancor) There is a 1-1 relationship between the material type values and the position 00 of 007 field. Selecting a material type should set this position's value. Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 16:00:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 15:00:46 +0000 Subject: [Koha-bugs] [Bug 22556] Add ability to quickly filter funds/budgets by library on the Acquisitions home page In-Reply-To: <bug-22556-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22556-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22556-70-UCrcCBUSjv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22556 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 16:00:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 15:00:49 +0000 Subject: [Koha-bugs] [Bug 22556] Add ability to quickly filter funds/budgets by library on the Acquisitions home page In-Reply-To: <bug-22556-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22556-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22556-70-gK16v0L0Tl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22556 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86841|0 |1 is obsolete| | --- Comment #3 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86850&action=edit Bug 22556: Add ability to quickly filter funds/budgets by library on the Acquisitions home page Some librarians would like to have a quick pulldown selector to filter budgets and funds by library on the acquisitions home page. Test Plan: 1) Apply this patch 2) Navigate to the Acquisitions home page 3) Notice the new pulldown on the budgets table labeled "Filter by library" 4) Select a library that has one or more budgets/funds 5) Note only budgets/funds from that library now display! Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 16:02:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 15:02:21 +0000 Subject: [Koha-bugs] [Bug 22533] Cannot create manual invoices In-Reply-To: <bug-22533-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22533-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22533-70-9M0rjdFE8Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22533 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|maninvoice.pl is using |Cannot create manual |deprecated maininvoice() |invoices |method | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 16:04:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 15:04:33 +0000 Subject: [Koha-bugs] [Bug 22533] Cannot create manual invoices In-Reply-To: <bug-22533-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22533-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22533-70-HaxVw2pM5L@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22533 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86838|0 |1 is obsolete| | --- Comment #5 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86851&action=edit Bug 22533: Fix manual invoices from patron accounting To test: Attempt to create a manual fine from the patron accounting page, it should fail. Apply this patch, restart the things Attempt to create a manual fine from the patron accounting page, it should succeed. Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 16:16:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 15:16:47 +0000 Subject: [Koha-bugs] [Bug 22557] New: Delayed authority merges looses the user in the action_logs Message-ID: <bug-22557-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22557 Bug ID: 22557 Summary: Delayed authority merges looses the user in the action_logs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 16:35:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 15:35:41 +0000 Subject: [Koha-bugs] [Bug 22557] Delayed authority merges looses the user in the action_logs In-Reply-To: <bug-22557-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22557-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22557-70-xkSI0RrfVX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22557 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 16:36:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 15:36:35 +0000 Subject: [Koha-bugs] [Bug 22557] Delayed authority merges looses the user in the action_logs In-Reply-To: <bug-22557-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22557-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22557-70-rj8tGLETqn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22557 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9988 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 [Bug 9988] Leave larger authority merges to merge_authorities cronjob (pref AuthorityMergeLimit) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 16:36:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 15:36:35 +0000 Subject: [Koha-bugs] [Bug 9988] Leave larger authority merges to merge_authorities cronjob (pref AuthorityMergeLimit) In-Reply-To: <bug-9988-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9988-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9988-70-wa5F7MwRiz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9988 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22557 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22557 [Bug 22557] Delayed authority merges looses the user in the action_logs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 16:45:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 15:45:07 +0000 Subject: [Koha-bugs] [Bug 22558] New: Report does not come out Message-ID: <bug-22558-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22558 Bug ID: 22558 Summary: Report does not come out Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: federicoantoniopaiz at gmail.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Created attachment 86852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86852&action=edit Catalog by item type The report, which is on the other lapel, Catalog by item type, does not return anything, as you can moficar so that it can work, we have the query -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 16:48:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 15:48:36 +0000 Subject: [Koha-bugs] [Bug 22558] Report does not come out In-Reply-To: <bug-22558-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22558-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22558-70-QbwSD6KBNM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22558 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- This sounds like a support request rather than a bug. Questions about Koha should be asked on the Koha mailing list (http://koha-community.org/support/koha-mailing-lists/) or in the #koha IRC channel (http://koha-community.org/get-involved/irc/). Hopefully you've already seen the Koha documentation: http://koha-community.org/documentation/ You can also find options for paid support here: https://koha-community.org/support/ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 17:12:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 16:12:38 +0000 Subject: [Koha-bugs] [Bug 22557] Delayed authority merges looses the user in the action_logs In-Reply-To: <bug-22557-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22557-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22557-70-3bVMsc9nOv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22557 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|tomascohen at gmail.com |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 17:24:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 16:24:58 +0000 Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI In-Reply-To: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20388-70-oAcRs6UuLK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #38 from Alex Arnaud <alex.arnaud at biblibre.com> --- (In reply to Josef Moravec from comment #37) > (In reply to Alex Arnaud from comment #34) > > Created attachment 78659 [details] [review] [review] > > Bug 20388 - Keep data consistency when adding/removing mapping > > > > Test plan: > > - create a new search field, save, > > - create a mapping using it (don't save), > > - check that you can't delete the search field. > > > > - delete all the mapping related to a search field (biblios and > > authorities), don't save, > > - check that you can delete this search field. > > > > This does not work, first part is OK, but in second one, I still can't > remove the searchfield... Hello, You mean you deleted all mapping related to a search field and you can delete it ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 17:28:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 16:28:51 +0000 Subject: [Koha-bugs] [Bug 18314] Account lockout In-Reply-To: <bug-18314-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18314-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18314-70-UBOIM1FNUP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18314 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21311 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21311 [Bug 21311] Remove locked message from opac-auth.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 17:28:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 16:28:51 +0000 Subject: [Koha-bugs] [Bug 21311] Remove locked message from opac-auth.tt In-Reply-To: <bug-21311-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21311-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21311-70-8jc5lC1c9Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21311 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18314 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18314 [Bug 18314] Account lockout -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 17:31:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 16:31:00 +0000 Subject: [Koha-bugs] [Bug 14784] Missing checkin message for debarred patrons when issuing rules 'fine days = 0' In-Reply-To: <bug-14784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14784-70-HmRMDhehx7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14784 Niamh <niamh.walker-headon at it-tallaght.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |niamh.walker-headon at it-tall | |aght.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 17:34:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 16:34:52 +0000 Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI In-Reply-To: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20388-70-LNPYw43hhq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #39 from Alex Arnaud <alex.arnaud at biblibre.com> --- (In reply to Alex Arnaud from comment #38) > (In reply to Josef Moravec from comment #37) > > (In reply to Alex Arnaud from comment #34) > > > Created attachment 78659 [details] [review] [review] [review] > > > Bug 20388 - Keep data consistency when adding/removing mapping > > > > > > Test plan: > > > - create a new search field, save, > > > - create a mapping using it (don't save), > > > - check that you can't delete the search field. > > > > > > - delete all the mapping related to a search field (biblios and > > > authorities), don't save, > > > - check that you can delete this search field. > > > > > > > This does not work, first part is OK, but in second one, I still can't > > remove the searchfield... > > Hello, > > You mean you deleted all mapping related to a search field and you can > delete it ? Works for me... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 17:41:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 16:41:07 +0000 Subject: [Koha-bugs] [Bug 22559] New: OPAC Forgotten password functionality not working Message-ID: <bug-22559-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22559 Bug ID: 22559 Summary: OPAC Forgotten password functionality not working Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: wizzyrea at gmail.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Trying to reset a password using the forgotten password OPAC functionality seems to fail with one of a couple of messages: Can't call method "catch" without a package or object reference at /home/vagrant/kohaclone/opac/opac-password-recovery.pl line 158 or Can't call method "isa" on an undefined value at /home/vagrant/kohaclone/opac/opac-password-recovery.pl line 159 This seems to happen after commit f822dee088b86edecd5d5c73718ad9f8a04c0664 To reproduce: Enable OpacResetPassword Create a borrower with a username and password Go to the OPAC, try to reset the password (I always get the reset link out of the message_queue in the database rather than worry about receiving the actual email. You do you.) Go to the link provided. Attempt to set a password, this should fail. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 17:49:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 16:49:53 +0000 Subject: [Koha-bugs] [Bug 18306] "Renew selected" and "renew all" in OPAC can be confusing for users not allowed to do it In-Reply-To: <bug-18306-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18306-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18306-70-AfQ5aFfvLr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18306 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 17:49:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 16:49:56 +0000 Subject: [Koha-bugs] [Bug 18306] "Renew selected" and "renew all" in OPAC can be confusing for users not allowed to do it In-Reply-To: <bug-18306-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18306-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18306-70-jGw98tF0SY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18306 --- Comment #9 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 86853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86853&action=edit Bug 18306: "Renew selected" and "renew all" in OPAC can be confusing for users not allowed to do it This patch add additional checks to opac-user.pl defining the ability to renew some or all items. The template can now better check whether it should show the renewal controls. To test, apply the patch and log in to the OPAC as a user with multiple checkouts. Test the following conditions: - All checkouts can be renewed - "Renew selected" and "Renew all" should appear at the top and bottom of the table of checkouts. - No checkouts can be renewed - No renewal controls should appear. - Some checkouts can be renewed - "Renew selected" should appear but not "Renew all" Test with various settings of the OverduesBlockRenewing system preference. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 18:05:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 17:05:47 +0000 Subject: [Koha-bugs] [Bug 21834] Display illrequests.orderid in the table of ILL requests In-Reply-To: <bug-21834-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21834-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21834-70-RhQw822Wl2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21834 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Magnus Enger <magnus at libriotech.no> --- Looks like this is fixed by bug 21063 which shows all columns from the illrequests table, and makes it possible to hide them. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 18:13:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 17:13:24 +0000 Subject: [Koha-bugs] [Bug 22559] OPAC Forgotten password functionality not working In-Reply-To: <bug-22559-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22559-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22559-70-IfNt2cZkLy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22559 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 18:13:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 17:13:26 +0000 Subject: [Koha-bugs] [Bug 22559] OPAC Forgotten password functionality not working In-Reply-To: <bug-22559-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22559-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22559-70-gp2Kd95qH4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22559 --- Comment #1 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86854&action=edit Bug 22559: Restore OPAC forgotten password functionality To test: Enable OpacResetPassword Create a borrower with a username and password Go to the OPAC, try to reset the password (I always get the reset link token out of the message_queue in the database rather than worry about receiving the actual email. You do you.) Go to the link provided. Attempt to set a password, this should fail. Apply this patch, restart the things Go through the process again, password should be reset. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 18:19:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 17:19:54 +0000 Subject: [Koha-bugs] [Bug 18306] "Renew selected" and "renew all" in OPAC can be confusing for users not allowed to do it In-Reply-To: <bug-18306-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18306-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18306-70-R7gd5NcOBJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18306 --- Comment #10 from Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> --- (In reply to Owen Leonard from comment #9) > Created attachment 86853 [details] [review] > Bug 18306: "Renew selected" and "renew all" in OPAC can be confusing for > users not allowed to do it > > This patch add additional checks to opac-user.pl defining the ability to > renew some or all items. The template can now better check whether it > should show the renewal controls. > > To test, apply the patch and log in to the OPAC as a user with multiple > checkouts. Test the following conditions: > > - All checkouts can be renewed > - "Renew selected" and "Renew all" should appear at the top and > bottom of the table of checkouts. > - No checkouts can be renewed > - No renewal controls should appear. > - Some checkouts can be renewed > - "Renew selected" should appear but not "Renew all" > > Test with various settings of the OverduesBlockRenewing system > preference. Hi Owen, I tested it on sandbox http://catalogue.user05-koha.sandbox.biblibre.eu/cgi-bin/koha/opac-user.pl and link Renew selected still appears even if all my checkout are not renewable. OverduesBlockRenewing is set on allow renewing Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 18:20:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 17:20:44 +0000 Subject: [Koha-bugs] [Bug 18306] "Renew selected" and "renew all" in OPAC can be confusing for users not allowed to do it In-Reply-To: <bug-18306-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18306-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18306-70-HasiNVqK3O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18306 --- Comment #11 from Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> --- Created attachment 86855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86855&action=edit not renewable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 18:22:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 17:22:12 +0000 Subject: [Koha-bugs] [Bug 22461] Regression in #20287: LDAP user replication broken with mapped extended patron attributes In-Reply-To: <bug-22461-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22461-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22461-70-0RkAIo0Bgg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22461 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 18:22:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 17:22:18 +0000 Subject: [Koha-bugs] [Bug 22461] Regression in #20287: LDAP user replication broken with mapped extended patron attributes In-Reply-To: <bug-22461-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22461-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22461-70-yzdZCfCQ1C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22461 --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86856&action=edit Bug 22461: Filter ldap mapping before inserting patron's info -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 18:25:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 17:25:31 +0000 Subject: [Koha-bugs] [Bug 22559] OPAC Forgotten password functionality not working In-Reply-To: <bug-22559-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22559-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22559-70-6OPjOvCfav@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22559 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 18:25:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 17:25:35 +0000 Subject: [Koha-bugs] [Bug 22559] OPAC Forgotten password functionality not working In-Reply-To: <bug-22559-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22559-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22559-70-uSYkRo9aam@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22559 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86854|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86857&action=edit Bug 22559: Restore OPAC forgotten password functionality To test: Enable OpacResetPassword Create a borrower with a username and password Go to the OPAC, try to reset the password (I always get the reset link token out of the message_queue in the database rather than worry about receiving the actual email. You do you.) Go to the link provided. Attempt to set a password, this should fail. Apply this patch Go through the process again, password should be reset. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 18:26:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 17:26:23 +0000 Subject: [Koha-bugs] [Bug 22559] OPAC Forgotten password functionality not working In-Reply-To: <bug-22559-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22559-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22559-70-6rwMYqYXSP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22559 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22048 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22048 [Bug 22048] Use set_password instead of update_password in the codebase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 18:26:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 17:26:23 +0000 Subject: [Koha-bugs] [Bug 22048] Use set_password instead of update_password in the codebase In-Reply-To: <bug-22048-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22048-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22048-70-ac7BSZcfXN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22048 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22559 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22559 [Bug 22559] OPAC Forgotten password functionality not working -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 18:26:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 17:26:41 +0000 Subject: [Koha-bugs] [Bug 22559] OPAC Forgotten password functionality not working In-Reply-To: <bug-22559-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22559-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22559-70-OEylmbaeF7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22559 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |wizzyrea at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 18:37:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 17:37:13 +0000 Subject: [Koha-bugs] [Bug 18306] "Renew selected" and "renew all" in OPAC can be confusing for users not allowed to do it In-Reply-To: <bug-18306-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18306-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18306-70-qKEfVIehNV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18306 --- Comment #12 from Owen Leonard <oleonard at myacpl.org> --- (In reply to Marjorie Barry-Vila from comment #10) > even if all my checkout are not renewable. Why are your checkouts not renewable? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 18:53:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 17:53:13 +0000 Subject: [Koha-bugs] [Bug 22546] MaxFine is not recorded in HEA In-Reply-To: <bug-22546-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22546-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22546-70-1oBOq1UjSJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22546 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #1 from Liz Rea <wizzyrea at gmail.com> --- Hm, I'm not sure who maintains this whitelist, maybe Paul knows? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 18:55:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 17:55:36 +0000 Subject: [Koha-bugs] [Bug 5371] Back-button in OPAC shows previous user's details, after logout In-Reply-To: <bug-5371-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-5371-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5371-70-81U1eBMd8c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5371 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22542 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 19:03:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 18:03:09 +0000 Subject: [Koha-bugs] [Bug 18306] "Renew selected" and "renew all" in OPAC can be confusing for users not allowed to do it In-Reply-To: <bug-18306-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18306-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18306-70-zpgq2744Av@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18306 --- Comment #13 from Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> --- (In reply to Owen Leonard from comment #12) > (In reply to Marjorie Barry-Vila from comment #10) > > > even if all my checkout are not renewable. > > Why are your checkouts not renewable? I used all the renewals available according to the circulation rules. Marjorie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 19:17:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 18:17:28 +0000 Subject: [Koha-bugs] [Bug 22559] OPAC Forgotten password functionality not working In-Reply-To: <bug-22559-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22559-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22559-70-iOCACstwHJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22559 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 19:17:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 18:17:32 +0000 Subject: [Koha-bugs] [Bug 22559] OPAC Forgotten password functionality not working In-Reply-To: <bug-22559-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22559-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22559-70-sVAjwJDDm2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22559 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86857|0 |1 is obsolete| | --- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 86859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86859&action=edit Bug 22559: Restore OPAC forgotten password functionality To test: Enable OpacResetPassword Create a borrower with a username and password Go to the OPAC, try to reset the password (I always get the reset link token out of the message_queue in the database rather than worry about receiving the actual email. You do you.) Go to the link provided. Attempt to set a password, this should fail. Apply this patch Go through the process again, password should be reset. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 19:18:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 18:18:30 +0000 Subject: [Koha-bugs] [Bug 22546] MaxFine is not recorded in HEA In-Reply-To: <bug-22546-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22546-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22546-70-QlxK4eMs53@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22546 --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- The list is in C4/UsageStats.pm There is much more than MaxFine missing, we should add it to the QA/RM check list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 19:24:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 18:24:35 +0000 Subject: [Koha-bugs] [Bug 22559] OPAC Forgotten password functionality not working In-Reply-To: <bug-22559-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22559-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22559-70-ZkbnVp8eoF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22559 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 19:26:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 18:26:46 +0000 Subject: [Koha-bugs] [Bug 22495] Restore su-geo field in Elasticsearch mappings In-Reply-To: <bug-22495-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22495-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22495-70-O8H1u5BL75@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22495 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19575 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575 [Bug 19575] Use canonical field names and resolve aliased fields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 19:26:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 18:26:46 +0000 Subject: [Koha-bugs] [Bug 19575] Use canonical field names and resolve aliased fields In-Reply-To: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19575-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19575-70-taa4Va10tk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19575 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22495 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22495 [Bug 22495] Restore su-geo field in Elasticsearch mappings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 19:28:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 18:28:50 +0000 Subject: [Koha-bugs] [Bug 22546] MaxFine is not recorded in HEA In-Reply-To: <bug-22546-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22546-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22546-70-WxHipr7wRL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22546 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think we might have left it out because it would not be so interesting. With different currencies we get a wide range of amounts there and what would it tell us? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 19:30:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 18:30:29 +0000 Subject: [Koha-bugs] [Bug 22555] Serials page doesn't show subscriptions on page load In-Reply-To: <bug-22555-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22555-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22555-70-CIpDrNVHxY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22555 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- There are libraries with tons of subscriptions so it makes a lot of sense to me to start with a search as showing them all might potentially slow down the page quite a bit. If you look at other places in Koha (invoices, baskets) it would be quite unusual too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 19:31:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 18:31:06 +0000 Subject: [Koha-bugs] [Bug 22546] MaxFine is not recorded in HEA In-Reply-To: <bug-22546-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22546-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22546-70-MH3imQIMyB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22546 --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- It would tell us the important metric of whether it's in use or not ?. 0 is 0 whatever currency it's in and 0 means 'disabled'. If there was an overwhelming disablement of it that would mean we could remove it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 19:32:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 18:32:20 +0000 Subject: [Koha-bugs] [Bug 22546] MaxFine is not recorded in HEA In-Reply-To: <bug-22546-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22546-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22546-70-4Wyh8g3WQt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22546 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I know that we use it, if that helps ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 19:32:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 18:32:39 +0000 Subject: [Koha-bugs] [Bug 22330] Transfer limits should be respected for placing holds in staff interface and APIs In-Reply-To: <bug-22330-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22330-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22330-70-YaRYU8bnKu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22330 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #24 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 19:32:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 18:32:52 +0000 Subject: [Koha-bugs] [Bug 21683] Remove accountlines.accountno In-Reply-To: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21683-70-Y9nRWFZgd3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #49 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 19:33:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 18:33:25 +0000 Subject: [Koha-bugs] [Bug 19469] Add ability to split view of holds view on record by pickup library and/or itemtype In-Reply-To: <bug-19469-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19469-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19469-70-7IFPlB1CVE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469 --- Comment #56 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Jonathan Druart from comment #55) > Created attachment 81829 [details] [review] > Bug 19469: Fix record links on multi holds Follow-up pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 19:34:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 18:34:29 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18736-70-CWqr7eKcSt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #180 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 19:35:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 18:35:52 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18736-70-ghVM1Iafe0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 --- Comment #181 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #179) > QA Comment: > I re-entered the example with 8 * 16,99 and 42% discount, 19.45% tax. > > With the following results when patches applied: > OrderPriceRounding=Dont > Basket page 78,83 + 15,33 tax. == 94,16 > Fund page 94,17 > => No match between basket and fund ! > > OrderPriceRounding=Nearest cent > Basket page: 78,80 + 15,33 tax == 94,13 > Fund page: 94,16 > => No match either between basket and fund ! > > And without these patches: > Basket page 78,83 + 15,33 tax. == 94,16 > Fund page: 94,17 > => No match either. > > Conclusion: Please see also my previous comments. I am not repeating them > here. With the default setting of Don't round we make no difference in this > example; so no behavior change.. The Nearest cent choice does not resolve > the discrepancy between basket and fund, as noted before. > > As already mentioned, I do not object to push this patch set. But this > simple exercise already shows that we did not solve the rounding issues. > > Passed QA You are right :-) I talked to others though and general consensus was this is a big change and should tackle issues raised on follow-ups. I think this does some good things and paves the way for more work forward so pushed. Thanks Marcel -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 19:36:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 18:36:19 +0000 Subject: [Koha-bugs] [Bug 13763] Renew feature does not check for the BarcodeInputFilter option In-Reply-To: <bug-13763-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13763-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13763-70-jzLxCZhjsH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13763 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #13 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 19:37:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 18:37:14 +0000 Subject: [Koha-bugs] [Bug 22495] Restore su-geo field in Elasticsearch mappings In-Reply-To: <bug-22495-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22495-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22495-70-Z7oTuEaXDg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22495 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 19:36:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 18:36:57 +0000 Subject: [Koha-bugs] [Bug 22495] Restore su-geo field in Elasticsearch mappings In-Reply-To: <bug-22495-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22495-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22495-70-ljkBTjcIVc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22495 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86505|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 86860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86860&action=edit Bug 22495: Restore Elasticsearch mapping for su-geo Test plan: 1. Reset mappings 2. Run perl misc/search_tools/rebuild_elastic_search.pl -d -b -v 3. Do a search and verify that the Places facet works Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 19:38:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 18:38:05 +0000 Subject: [Koha-bugs] [Bug 22560] New: Forgotten password "token expired" page still shows boxes to reset password Message-ID: <bug-22560-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22560 Bug ID: 22560 Summary: Forgotten password "token expired" page still shows boxes to reset password Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: wizzyrea at gmail.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- To replicate: Create a user with a username, password, and email defined Attempt to do a forgotten password recovery Munge your token link in whatever way you like (?uniqueKey=$2a$08$B9szbC5lwJd.mh.QznRHZu for example - this one should be invalid in your DB) Note that a yellow "This link is expired" box is shown, but the two password boxes are still there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 19:53:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 18:53:42 +0000 Subject: [Koha-bugs] [Bug 22561] New: Forgotten password "password requirements" box doesn't list all of the rules that are in effect for new passwords Message-ID: <bug-22561-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22561 Bug ID: 22561 Summary: Forgotten password "password requirements" box doesn't list all of the rules that are in effect for new passwords Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: wizzyrea at gmail.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- The blue box on the password recovery page that tells users what requirements new passwords must have doesn't show all of the rules that might be in effect. The infobox currently only shows the length requirements and should show the requirements enacted by RequireStrongPassword, if that is set. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 19:57:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 18:57:18 +0000 Subject: [Koha-bugs] [Bug 16882] Circ restrictions caused by long overdue should be removed when the offending item is returned In-Reply-To: <bug-16882-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16882-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16882-70-pdGLFnBSix@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16882 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- The ODUE restriction is set by sending out a notice x days after due date. I think we could check the due dates of the other items on lifting the restriction maybe. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 20:27:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 19:27:37 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: <bug-8000-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8000-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8000-70-jZzcH9B7Ad@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 20:27:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 19:27:43 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: <bug-8000-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8000-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8000-70-Iayeo2rIrH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84801|0 |1 is obsolete| | Attachment #84802|0 |1 is obsolete| | Attachment #84803|0 |1 is obsolete| | Attachment #84804|0 |1 is obsolete| | Attachment #84805|0 |1 is obsolete| | --- Comment #164 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86861&action=edit Bug 8000: Redirect all emails to SendAllEmailsTo Rebased and squashed after changes to master. Only difference from previous patches are small adjustements to conflicts in t/db_dependent/Letters.t Test plan: 1) Apply path 2) Run updatedatabase.pl 3) Clear all SendAllEmailsTo system preference 4) Send mail to a patron of your choosing, email will go to patron's email address as usual. 5) Set SendAllEmailsTo to a test email address 6) Send mail to the patron, email will be redirected to the email set in the systempreference. 7) Run prove -v t/db_dependent/Letters.t It does not affect messages in the message_queue. This patch obsoletes previous patches, because it achieves the same functionality in a much more centralized way. (4 lines of code!) Signed-off-by: Ed Veal <eveal at mckinneytexas.org> Signed-off-by: BWS Sandboxes <ByWaterSandboxes at gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 20:27:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 19:27:51 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: <bug-8000-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8000-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8000-70-0xBRJtFItd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #165 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86862&action=edit Bug 8000: (QA follow-up) Centralise Bcc too Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 20:27:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 19:27:57 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: <bug-8000-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8000-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8000-70-m6DhsuGejf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #166 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86863&action=edit Bug 8000: (QA follow-up) Fix accidently edited sysprefs.sql file Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 20:28:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 19:28:04 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: <bug-8000-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8000-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8000-70-suV2rCDHyQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #167 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86864&action=edit Bug 8000: (QA follow-up) Update the to_address in the message queue Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 20:28:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 19:28:11 +0000 Subject: [Koha-bugs] [Bug 8000] Test mode for notices In-Reply-To: <bug-8000-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8000-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8000-70-SszKZiVqeA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8000 --- Comment #168 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86865&action=edit Bug 8000: (QA follow-up) Add email validation to system preferences This patch uses the JQuery validator plugin to add validation to preferences of class email in the system preferences page. A field containing an invalid value (even if not modified) should prevent saving. To test, confirm that when entering an invalid email address in the SendAllEmailsTo field, an error message appears and saving is prevented. Correcting the value should hide the message and let you save as normal. Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 20:51:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 19:51:03 +0000 Subject: [Koha-bugs] [Bug 21890] Patron password reset by category In-Reply-To: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21890-70-lOPGyyuUGB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 20:51:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 19:51:06 +0000 Subject: [Koha-bugs] [Bug 21890] Patron password reset by category In-Reply-To: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21890-70-EoWwL7Ylek@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86843|0 |1 is obsolete| | Attachment #86844|0 |1 is obsolete| | Attachment #86845|0 |1 is obsolete| | Attachment #86846|0 |1 is obsolete| | Attachment #86847|0 |1 is obsolete| | --- Comment #33 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86866&action=edit Bug 21890: DB updates This patch adds a new column to the categories table: 'reset_password' which is a boolean, and represents, well... that. The value itself is nullable. The idea is that OpacResetPassword governs the general behaviour, and this can be overriden at category-level. Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 20:51:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 19:51:09 +0000 Subject: [Koha-bugs] [Bug 21890] Patron password reset by category In-Reply-To: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21890-70-usCvpH0w56@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890 --- Comment #34 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86867&action=edit Bug 21890: Handle can_reset_password on the staff interface This patch makes the staff interface handle the new flag when editing the categories. I didn't add the flag to the list of categories table because it makes it too big, but can be easily added if required by users or QA. To test: - Along with other patches from this bug, edit patron categories => SUCCESS: Notice the changes are correctly stored - Sign off :-D Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 20:51:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 19:51:13 +0000 Subject: [Koha-bugs] [Bug 21890] Patron password reset by category In-Reply-To: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21890-70-GrDLPyGYVa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890 --- Comment #35 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86868&action=edit Bug 21890: Add Koha::Patron::Category->effective_reset_password method This method checks wether the local $self->reset_password is set to override the OpacResetPassword syspref (i.e. if it is set to a bool) or undef, in which case if falls back to the value of the syspref. To test: - Apply this patches - Make sure the DB is updated: $ updatedatabase - Update the schema files: $ dbic - Run: $ kshell k$ prove t/db_dependent/Koha/Patron/Category.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 20:51:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 19:51:16 +0000 Subject: [Koha-bugs] [Bug 21890] Patron password reset by category In-Reply-To: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21890-70-j2H10d07in@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890 --- Comment #36 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86869&action=edit Bug 21890: Add can_any_reset_password() to the Categories TT plugin This patch introduces a method to the Koha::Template::Plugin::Categories TT plugin. This methods queries for categories filtering them by effective_reset_password flag set, and returns a boolean representing the fact that there's at least one category allowed. To test: - Apply this patch - Run: $ kshell k$ prove t/db_dependent/Template/Plugin/Categories.t => SUCCESS: Tests pass! - Sign off :-D Caveat: this patch/tests require the schema to be updated Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 20:51:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 19:51:19 +0000 Subject: [Koha-bugs] [Bug 21890] Patron password reset by category In-Reply-To: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21890-70-gzJwcdjNPV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890 --- Comment #37 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86870&action=edit Bug 21890: Allow restricting password resets by patron category This patch makes the templates relying on the OpacResetPassword syspref use the introduced TT plugin method instead by changing: [% IF Koha.Preference('OpacResetPassword') %] => [% IF Categories.can_any_reset_password %] To test: - Verify that all the places in which the 'forgot password' link is displayed in OPAC keep working, provided there's at least one category that has the flag set - Attempt to recover the password for a patron that belong to a valid category (i.e. that has the flag set) => SUCCESS: You can go through the normal process - Attempt to recover the password for a patron that belongs to a category with the flag unset. => SUCCESS: Once Koha identifies your category, you are told you are not allowed to do it - Sign off :-D Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 20:52:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 19:52:58 +0000 Subject: [Koha-bugs] [Bug 21890] Patron password reset by category In-Reply-To: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21890-70-PEspPdKLAa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890 --- Comment #38 from Liz Rea <wizzyrea at gmail.com> --- Hi, Quick caveat on the testing here, bug 22559 had to be applied before I could test this properly, and my signoff is dependent on that. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 22:54:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 21:54:50 +0000 Subject: [Koha-bugs] [Bug 22541] Invoice adjustments should show invoice number and include link on ordered.pl and spent.pl In-Reply-To: <bug-22541-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22541-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22541-70-DWpNVFqHDQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22541 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 21 22:54:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Mar 2019 21:54:53 +0000 Subject: [Koha-bugs] [Bug 22541] Invoice adjustments should show invoice number and include link on ordered.pl and spent.pl In-Reply-To: <bug-22541-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22541-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22541-70-NaGzLDgsPv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22541 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86842|0 |1 is obsolete| | --- Comment #2 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86871&action=edit Bug 22541: Use invoicenumber and link to invoice on spent and ordered pages To test: 1 - Find a vendor in acquisitions 2 - Click 'receive shipment' 3 - Create an invoice 4 - Click 'Finish receiving' 5 - Add an adjustment that encumbers while open and update adjustments 6 - Go to acqui-home and click on the ordered total for the fund with the adjustment 7 - Note the invoice adjustment shows the invoice id and does not link 8 - Add another invoice and another adjustment, but close the invoice this time 9 - Go to acqui-home and click on the spent total for the fund with the adjustment 10 - Note the invoice adjustment shows the invoice id and does not link 11 - Apply patch 12 - Visit the spent and ordered pages and note the adjustments show invoicenumber and are links 13 - prove -v t/db_dependent/Koha/Acquisition/Invoice/Adjustments.t Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 01:13:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 00:13:10 +0000 Subject: [Koha-bugs] [Bug 22536] Display problem in Holds to Pull report In-Reply-To: <bug-22536-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22536-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22536-70-MMjR7uWMpq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22536 sandboxes at biblibre.com <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes at biblibre.com Status|Needs Signoff |Signed Off --- Comment #2 from sandboxes at biblibre.com <sandboxes at biblibre.com> --- Patch tested with a sandbox, by David Roberts <david.roberts at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 01:13:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 00:13:27 +0000 Subject: [Koha-bugs] [Bug 22536] Display problem in Holds to Pull report In-Reply-To: <bug-22536-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22536-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22536-70-9BVmNQI5la@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22536 sandboxes at biblibre.com <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86738|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 01:13:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 00:13:35 +0000 Subject: [Koha-bugs] [Bug 22536] Display problem in Holds to Pull report In-Reply-To: <bug-22536-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22536-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22536-70-3lRVWY6LNz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22536 --- Comment #3 from sandboxes at biblibre.com <sandboxes at biblibre.com> --- Created attachment 86872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86872&action=edit Bug 22536: Display problem in Holds to Pull report This patch modifies the display of several values in the holds to pull report so that they can be displayed as lists instead of as chunks of HTML generated in SQL. This patch modifies the SQL in pendingreserves.pl so that values can be formatted in the same way that holding branch is. The better long-term solution is to remove SQL from pendingreserves.pl altogether, but this is a quick fix. This patch also makes a couple of minor markup changes to fix validation. To test, apply the patch and go to Circulation -> Holds to pull. To see the changes the patch makes your holds to pull list should have titles with multiple items at multiple branches, with call number, copy number, and enumeration data. These values should all be displayed in bulleted lists. Signed-off-by: David Roberts <david.roberts at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 01:14:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 00:14:43 +0000 Subject: [Koha-bugs] [Bug 22536] Display problem in Holds to Pull report In-Reply-To: <bug-22536-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22536-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22536-70-37xYoqblk8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22536 --- Comment #4 from David Roberts <david.roberts at ptfs-europe.com> --- As far as I can tell with the limited data and config on the sandboxes, this seems to work correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 07:44:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 06:44:24 +0000 Subject: [Koha-bugs] [Bug 15326] Add CMS feature In-Reply-To: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15326-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15326-70-LMl282V7Si@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15326 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #81 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Applying: Bug 15326: Add CMS feature .git/rebase-apply/patch:191: tab in indent. -asc => [qw/parent location branchcode lang sortorder/] .git/rebase-apply/patch:241: tab in indent. my ( $self, $id ) = @_; .git/rebase-apply/patch:243: tab in indent. carp( 'Missing CMS page id parameter in Koha::Pages::page' ) unless defined $id; .git/rebase-apply/patch:245: tab in indent. # Probably want to merge these to a single query: .git/rebase-apply/patch:246: tab in indent. my $top_links = $self->_resultset()->search( warning: squelched 77 whitespace errors warning: 82 lines add whitespace errors. Using index info to reconstruct a base tree... M installer/data/mysql/kohastructure.sql M installer/data/mysql/userpermissions.sql M koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc M koha-tmpl/intranet-tmpl/prog/en/modules/tools/tools-home.tt M opac/opac-main.pl .git/rebase-apply/patch:191: tab in indent. -asc => [qw/parent location branchcode lang sortorder/] .git/rebase-apply/patch:241: tab in indent. my ( $self, $id ) = @_; .git/rebase-apply/patch:243: tab in indent. carp( 'Missing CMS page id parameter in Koha::Pages::page' ) unless defined $id; .git/rebase-apply/patch:245: tab in indent. # Probably want to merge these to a single query: .git/rebase-apply/patch:246: tab in indent. my $top_links = $self->_resultset()->search( warning: squelched 77 whitespace errors warning: 82 lines applied after fixing whitespace errors. CONFLICT (content): Merge conflict in opac/opac-main.pl CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/includes/permissions.inc Patch failed at 0001 Bug 15326: Add CMS feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 07:53:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 06:53:19 +0000 Subject: [Koha-bugs] [Bug 22533] Cannot create manual invoices In-Reply-To: <bug-22533-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22533-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22533-70-Qq8kmzVjLN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22533 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 07:53:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 06:53:22 +0000 Subject: [Koha-bugs] [Bug 22533] Cannot create manual invoices In-Reply-To: <bug-22533-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22533-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22533-70-i8K0NZLs7n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22533 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86851|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 86873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86873&action=edit Bug 22533: Fix manual invoices from patron accounting To test: Attempt to create a manual fine from the patron accounting page, it should fail. Apply this patch, restart the things Attempt to create a manual fine from the patron accounting page, it should succeed. Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 07:53:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 06:53:47 +0000 Subject: [Koha-bugs] [Bug 22533] Cannot create manual invoices In-Reply-To: <bug-22533-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22533-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22533-70-GuttHuRgEt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22533 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|tomascohen at gmail.com |m.de.rooy at rijksmuseum.nl CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 08:08:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 07:08:17 +0000 Subject: [Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy In-Reply-To: <bug-20985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20985-70-fGY0O3zvmM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 --- Comment #2 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- Created attachment 86874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86874&action=edit Bug 20985 : Add OnShelfHoldsAllowed checks to CanItemBeReserved Test plan : 1 / Check that default circulation have OnShelfHoldsAllowed to Yes 2 / Place a hold on a book with a single item, item being available for loan, verify that hold can be placed. 3 / Set OnShelfHoldsAllowed to any other value, verify that hold cannot be placed for reason "onShelfHoldsNotAllowed" (shown in the item table). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 08:08:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 07:08:49 +0000 Subject: [Koha-bugs] [Bug 20985] CanBookBeReserved and CanItemBeReserved should check 'On shelf holds allowed' policy In-Reply-To: <bug-20985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20985-70-X8juJGo0yj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20985 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |arthur.suzuki at biblibre.com |ity.org | Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 08:29:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 07:29:14 +0000 Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI In-Reply-To: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20388-70-AtrpKlq70h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #40 from Bj?rn Nyl?n <bjorn.nylen at ub.lu.se> --- Hi! We also tested the patch and can't remove the search field according to your instructions. If I save the mappings first it works ok. Tested in FF and Chrome After a quick look it seems the newly created mappings is missing the onclick event to enable the delete button on the search field-tab. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 08:42:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 07:42:58 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17385-70-zgpI5l5NiS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #33 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- QA: Looking here now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 08:49:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 07:49:44 +0000 Subject: [Koha-bugs] [Bug 22533] Cannot create manual invoices In-Reply-To: <bug-22533-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22533-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22533-70-L1gswqQO4x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22533 --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Thanks Marcel, I just didn't get a chance to do the final qa on this yesterday with meetings.. nice to come to it this morning and see you've stepped into the breach.. Go Team! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 10:02:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 09:02:40 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17385-70-noBJeMpxhE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84389|0 |1 is obsolete| | --- Comment #34 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 86875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86875&action=edit Bug 17385: Add custom export XSLT Patch was corrected and rebased after QA feedback. Previous patches where combined into this one. - Empty READMEs have been deleted - Whitespaces changes to unrelated code have been undone * CustomXSLTExportList now uses LibXML to figure out the title and output * The custom export XSLT's title should be an attribute to the root node, otherwise it will default to filename - Duplicate $xslFile param was removed from XSLTParse4Display * Improvment to code structure in XSLTParse4Display * Some fixes to calls to AddBiblio() Test case: - Apply patch - Visit an item's detail page in the OPAC or the staff interface - Click save and you found Simple Export. - Click Simple Export and you have a file.html, it contain informations returned by the xslt file. - It work correctly in basket and lists. The patch comes with sample XSLT files for Intranet the xsl file is : koha-tmpl/intranet-tmpl/prog/en/xslt/biblioexport/MARC21_simple_export.xsl for opac the xsl file is : koha-tmpl/opac-tmpl/bootstrap/en/xslt/biblioexport/MARC21_simple_export.xsl Followed test plan, patch works as described. Also ran QA test tools and modified files pass Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz> Signed-off-by: Cori Lynn Arnold <carnold at dgiinc.com> https://bugs.koha-community.org/show_bug.cgi?id=17835 Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 10:02:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 09:02:46 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17385-70-kvHa0CuC7a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84390|0 |1 is obsolete| | --- Comment #35 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 86876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86876&action=edit Bug 17385: Add tests for CustomXSLTExportList + Added tests for CustomXSLTExportList to C4::XSLT + Added an eval block in CustomXSLTExportList to handle invalid XML. * Removed Opac parameter, but now handle "OPACXSLTCustomExport" as equivalent + Added "Custom" option to OPACExportOptions preference. Tested with invalid XML (not originally on purpose, but...) and then added a new field to add to the simple export. Walked through the testing steps. Question: should this also apply to the cataloging page as an export option? It doesn't now. Signed-off-by: Cori Lynn Arnold <carnold at dgiinc.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 10:02:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 09:02:51 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17385-70-7bqyzWFoUT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 --- Comment #36 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 86877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86877&action=edit Bug 17385: (QA follow-up) Do not needlessly scan biblioexport folder Performance: We need to return an empty list if OpacExportOptions does not contain Custom. No need to scan the directory for custom files, if we are not using them at all. Test plan: Run t/db_dependent/XSLT.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 10:02:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 09:02:56 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17385-70-ONvi4r8oGd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 --- Comment #37 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 86878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86878&action=edit Bug 17385: (QA follow-up) Add caching Performance: We should add caching in CustomXSLTExportList. Test plan: Run t/db_dependent/XSLT.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 10:11:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 09:11:27 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17385-70-8dpKJLmaKl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA --- Comment #38 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- QA Comment: Thanks for your perseverance, guys. This took quite some time. Since the Custom option is not checked by default, I do not see a problem pushing this in its current form. [1] We need to return an empty list if OpacExportOptions does not contain Custom. No need to scan the directory for custom files, if we are not using them at all. => See follow-up. [2] We should add caching in CustomXSLTExportList. => See second follow-up. [3] The example xslt perhaps should be renamed (as mentioned before earlier). If you would only check for the .xsl extension, we could add a README and rename the extension of the simple export sample. Since it is pref controlled now, this may be done later imo. No blocker for me. [4] t/XSLT.t depends on a pref, so on the database. Should imo be moved to dependent. Removing Test::DBIx::Class :) No blocker, maybe later ? [5] I personally do not like using LibXML to parse the filename and format from the xsl file. And was just thinking about adding a small json or yaml file to do the same? No blocker, maybe later.. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 10:14:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 09:14:22 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17385-70-Ohjdhg1IFA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |BLOCKED --- Comment #39 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Hmm. One small thing still.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 10:52:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 09:52:57 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17385-70-2UNDNin3Y4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86877|0 |1 is obsolete| | --- Comment #40 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 86879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86879&action=edit Bug 17385: (QA follow-up) Do not needlessly scan biblioexport folder Performance: We need to return an empty list if OpacExportOptions does not contain Custom. No need to scan the directory for custom files, if we are not using them at all. Note: The test only pertains to OPAC now, since the pref should not control intranet behavior. We have no intranet counterpart. See further next follow-up. Test plan: Run t/db_dependent/XSLT.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 10:53:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 09:53:03 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17385-70-ci9m2Ipi57@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86878|0 |1 is obsolete| | --- Comment #41 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 86880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86880&action=edit Bug 17385: (QA follow-up) Add caching Performance: We should add caching in CustomXSLTExportList. Note: This resolves the lack of an intranet test in the former patch too. Test plan: Run t/db_dependent/XSLT.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 10:53:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 09:53:39 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17385-70-UTnE6c2cKh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA --- Comment #42 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Obviously, we needed two cache keys. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 11:01:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 10:01:08 +0000 Subject: [Koha-bugs] [Bug 13735] Item form in serials module doesn't respect max length set in the frameworks In-Reply-To: <bug-13735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13735-70-vRG4wB9vFr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13735 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Martin Renvoize from comment #6) > With my QA hat on.. I don't think we should require a test here.. the code > is hideously integrated and a test would end up being more complicated than > the fix itself.. When it comes to refactoring this into Koha:: we will need > lots of tests to cover these routines, spreading from integrations ui tests > down to module unit tests. > > Just my opinion for the next QAer to come along. Yeah, no problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 11:01:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 10:01:18 +0000 Subject: [Koha-bugs] [Bug 13735] Item form in serials module doesn't respect max length set in the frameworks In-Reply-To: <bug-13735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13735-70-MsENrR19mx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13735 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 11:01:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 10:01:30 +0000 Subject: [Koha-bugs] [Bug 13735] Item form in serials module doesn't respect max length set in the frameworks In-Reply-To: <bug-13735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13735-70-QN4fmae5xh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13735 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 11:03:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 10:03:33 +0000 Subject: [Koha-bugs] [Bug 13735] Item form in serials module doesn't respect max length set in the frameworks In-Reply-To: <bug-13735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13735-70-Sz4EtV5Ygt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13735 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 11:03:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 10:03:36 +0000 Subject: [Koha-bugs] [Bug 13735] Item form in serials module doesn't respect max length set in the frameworks In-Reply-To: <bug-13735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13735-70-0tENZT17Wf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13735 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85019|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 86881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86881&action=edit Bug 13735: Update PrepareItemrecordDisplay to use maxlength The PrepareItemrecordDisplay method used to generate the item display on receiving serials was using a hardcoded maxlength of 255 on input fields. This patch updates it to use the maxlength defined in the frameworks instead as the normal item form does. To test: - Create or reuse an existing subscription - Make note of the framework the record uses - Add an item on receive - Check the maxlength on the various fields is set to 255 (check source code or use developer tools) - You can also verify that by adding a long note to one of the note fields - Apply patch - Repeat tests, the maxlength should now be 9999 - In your framework settings, change the length of one of the subfields to another value - Verify that the item form reflects the change Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 11:05:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 10:05:50 +0000 Subject: [Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function In-Reply-To: <bug-12159-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12159-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12159-70-5VhDC9xK31@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 11:06:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 10:06:13 +0000 Subject: [Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function In-Reply-To: <bug-12159-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12159-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12159-70-trP1Acl4lv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86168|0 |1 is obsolete| | --- Comment #40 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Comment on attachment 86168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86168 Bug 12159: (QA follow-up) Silencing POD warn from qa tools No longer needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 11:05:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 10:05:59 +0000 Subject: [Koha-bugs] [Bug 22461] Regression in #20287: LDAP user replication broken with mapped extended patron attributes In-Reply-To: <bug-22461-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22461-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22461-70-fmwlmMIgER@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22461 Oliver Behnke <oliver.behnke at aei.mpg.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #8 from Oliver Behnke <oliver.behnke at aei.mpg.de> --- Almost: "Global symbol "%data" requires explicit package name (did you forget to declare "my %data"?) at /usr/share/koha/lib/C4/Auth_with_ldap.pm line 228" The original indeed declares that at [5] and adding that line right above "my @columns" does work for me. But I'm no perl expert, so I have to leave the fix to you. That aside, it seems the patch isn't yet complete as I get the following error when replicating a new user from LDAP: "{UNKNOWN}: DBIC result _type isn't of the _type Category at /usr/share/perl5/DBIx/Class/Storage/BlockRunner.pm line 130. at /usr/share/koha/lib/Koha/Patron.pm line 288" Cheers FWIW, I propose to remove line 449 at [6] (or replace it with a more suitable comment) as we now know that, yes, that check is indeed vital :-) [5] https://github.com/Koha-Community/Koha/blob/1b13c453e20e47c5e25bd946b50dd3838e29c3ce/C4/Members.pm#L396 [6] https://github.com/Koha-Community/Koha/blob/1b13c453e20e47c5e25bd946b50dd3838e29c3ce/C4/Members.pm#L449 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 11:33:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 10:33:53 +0000 Subject: [Koha-bugs] [Bug 19588] There is no ILL requests history In-Reply-To: <bug-19588-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19588-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19588-70-iFQ0e6v4zP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19588 C Hofstede <chloe.hofstede at educampus.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chloe.hofstede at educampus.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 12:06:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 11:06:07 +0000 Subject: [Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function In-Reply-To: <bug-12159-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12159-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12159-70-RRUYyo0r64@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 --- Comment #41 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- QA Comment: Saw this warning once: Argument "" isn't numeric in numeric gt (>) at /usr/share/koha/koha-tmpl/intranet-tmpl/prog/en/includes/members-toolbar.inc line 84. False warning from qa tools: Koha/Patron/Attribute.pm critic/forbidden patterns: forbidden pattern: Warning: The 'sub type' may be wrong is declared in a Koha::* package (see bug 15446) (line 127) A dumb question: + return Koha::Patron::Attributes->search({ + borrowernumber => $self->borrowernumber, + branchcode => $self->branchcode, + }); => Is the branchcode needed? Koha/Patron/Attribute.pm L114 return $av->next->lib if $av->count Amended: adding a semicolon for future ease. Koha/Schema/Result/BorrowerAttribute.pm => Please do not add DBIx schema files in a regular patch. I removed it now. Btw it seems no longer necessary if we rename the relation in the Koha object. See follow-up. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 12:06:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 11:06:33 +0000 Subject: [Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function In-Reply-To: <bug-12159-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12159-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12159-70-Gt8AcEnQ1U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86166|0 |1 is obsolete| | --- Comment #42 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 86882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86882&action=edit Bug 12159: Fix getting extended patron attributes for circ-menu Changes: - Replace getting preference ExtendedPatronAttributes by Koha.Preference in templates - Add Koha::Patron->attributes for getting patrons extended attributes - Use this method in circ-menu.inc - Remove getting attributes from members perl scripts Test plan: 0) Apply the patch 1) Add some patron attributes type - with free text, authorised value, limited by libraries... 2) Add some values to this attributes for some patrons 3) Go through as many patron pages as you can and confirm that attributes are shown at side panel when they shoul and are not shown when they should not be shown Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> [EDIT] Removed Koha/Schema/Result/BorrowerAttribute.pm [EDIT] Added missing semicolon on L114 in Koha/Patron/Attribute.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 12:06:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 11:06:38 +0000 Subject: [Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function In-Reply-To: <bug-12159-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12159-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12159-70-6qTbvADUyU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86167|0 |1 is obsolete| | --- Comment #43 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 86883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86883&action=edit Bug 12159: Add tests Test plan: prove t/db_dependent/Koha/Patron/Attributes.t t/db_dependent/Koha/Patrons.t Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 12:06:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 11:06:42 +0000 Subject: [Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function In-Reply-To: <bug-12159-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12159-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12159-70-UX2WisOG6A@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 --- Comment #44 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 86884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86884&action=edit Bug 12159: (QA follow-up) Rename relation in Patron::Attributes It seems that we do not need the extra belongs_to in the schema result files if we rename the relation to code. Test plan: Run t/db_dependent/Koha/Patrons.t Run t/db_dependent/Koha/Patron/Attributes.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 12:06:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 11:06:47 +0000 Subject: [Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function In-Reply-To: <bug-12159-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12159-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12159-70-PoyyNKmA3s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 --- Comment #45 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 86885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86885&action=edit Bug 12159: (QA follow-up) Remove double use module Speaks for itself. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 12:07:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 11:07:06 +0000 Subject: [Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function In-Reply-To: <bug-12159-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12159-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12159-70-4NJ5LwDfJ5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 12:15:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 11:15:49 +0000 Subject: [Koha-bugs] [Bug 21130] Detail XSLT produces translatable HTML class In-Reply-To: <bug-21130-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21130-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21130-70-XPZDJ7FZHL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21130 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 12:15:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 11:15:52 +0000 Subject: [Koha-bugs] [Bug 21130] Detail XSLT produces translatable HTML class In-Reply-To: <bug-21130-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21130-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21130-70-G7mYOiryGZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21130 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77321|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 86886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86886&action=edit Bug 21130: Prevent HTML class from being translated Adds a xsl:value-of tag to prevent the value from being translated. TEST PLAN 0) Apply patch 1) Translate 2) In the opac, div.record has not changed NOTE: I don't know if this bug affects all translations, I noticed it when translating to fr-CA. The fix will work for all languages. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 12:15:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 11:15:57 +0000 Subject: [Koha-bugs] [Bug 21130] Detail XSLT produces translatable HTML class In-Reply-To: <bug-21130-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21130-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21130-70-cEsG6zZTQ3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21130 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86421|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 86887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86887&action=edit Bug 21130: (Follow up OPAC Results) Prevent HTML class from being translated This fixes the same issue where "title" is being translated (in fr-CA at least) and thus break the javascript impacting the result display in the OPAC Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 12:16:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 11:16:06 +0000 Subject: [Koha-bugs] [Bug 21130] Detail XSLT produces translatable HTML class In-Reply-To: <bug-21130-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21130-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21130-70-WOmxvaWOdd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21130 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 12:18:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 11:18:48 +0000 Subject: [Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior In-Reply-To: <bug-10577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10577-70-Qpn42zCy0c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 12:26:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 11:26:17 +0000 Subject: [Koha-bugs] [Bug 22516] accountlines.lastincrement can be removed In-Reply-To: <bug-22516-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22516-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22516-70-6qEc1JoZk9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22516 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86712|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 86888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86888&action=edit Bug 22516: Remove remaining calls to lastincrement A few places still set lastincrement and the tests still checked for correct values. But nowhere in the code still uses lastincrement for anything meaningful. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 12:26:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 11:26:21 +0000 Subject: [Koha-bugs] [Bug 22516] accountlines.lastincrement can be removed In-Reply-To: <bug-22516-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22516-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22516-70-fId95OWepm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22516 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86713|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 86889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86889&action=edit Bug 22516: Database update Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 12:26:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 11:26:14 +0000 Subject: [Koha-bugs] [Bug 22516] accountlines.lastincrement can be removed In-Reply-To: <bug-22516-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22516-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22516-70-mcJINb86jn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22516 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Trivial patch |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 12:26:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 11:26:55 +0000 Subject: [Koha-bugs] [Bug 22516] accountlines.lastincrement can be removed In-Reply-To: <bug-22516-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22516-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22516-70-feqMalAiLM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22516 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 12:27:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 11:27:22 +0000 Subject: [Koha-bugs] [Bug 22516] accountlines.lastincrement can be removed In-Reply-To: <bug-22516-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22516-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22516-70-5WnbT4DQYn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22516 --- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- @RM: DBIx update ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 12:34:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 11:34:17 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-oWBrr262QK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86808|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86890&action=edit Bug 22521: Update fines handling to use accountline.status Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 12:34:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 11:34:19 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-uC8e5g0iR5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86891&action=edit Bug 22521: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 12:35:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 11:35:55 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit In-Reply-To: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22511-70-14DgHL6YRO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22521 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 12:35:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 11:35:55 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-lhQgi0qAP2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22511 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 [Bug 22511] Koha::Account::Line->void loses the original type of the credit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 12:40:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 11:40:34 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-zX4qijPxAy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86892&action=edit Bug 22521: Increase varchar size for accounttype accountlines.accounttype is currently a short varchar(5) field for to store accounttype codes. Koha is moving towards more descriptive codes which require a larger capacity varchar(16). Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 12:40:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 11:40:40 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-axHyy610Le@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86891|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86894 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86894&action=edit Bug 22521: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 12:40:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 11:40:37 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-CNOjern47X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86890|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86893 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86893&action=edit Bug 22521: Update fines handling to use accountline.status Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 12:48:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 11:48:15 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-UtDWcfAMuk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86892|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86895 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86895&action=edit Bug 22521: Increase varchar size for accounttype accountlines.accounttype is currently a short varchar(5) field for to store accounttype codes. Koha is moving towards more descriptive codes which require a larger capacity varchar(16). Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 12:48:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 11:48:18 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-OQkQopBIV1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86893|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86896 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86896&action=edit Bug 22521: Update fines handling to use accountline.status Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 12:48:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 11:48:21 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-y4QdtkjcCp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86894|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86897 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86897&action=edit Bug 22521: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 12:48:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 11:48:24 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-fwB0aIEt2S@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86898 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86898&action=edit Bug 22521: Update existing accounttypes Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 12:48:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 11:48:42 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-OV55VrUWqU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 12:50:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 11:50:41 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-DdK4B4kYC9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Test Plan 1) Apply patch and ensure updated tests still pass 2) Run DB updates and ensure the display of status's makes sense on all pages that display accountline details (account summary, print and payment pages on staff and the user account fines page on the opac) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 12:51:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 11:51:11 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-1G9GFYKc1b@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com, | |kyle at bywatersolutions.com, | |martin.renvoize at ptfs-europe | |.com, tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 13:02:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 12:02:31 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-ZUBFdIOnjS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86895|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86899 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86899&action=edit Bug 22521: Increase varchar size for accounttype accountlines.accounttype is currently a short varchar(5) field for to store accounttype codes. Koha is moving towards more descriptive codes which require a larger capacity varchar(16). Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 13:02:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 12:02:34 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-PasxWI4aDC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86896|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86900 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86900&action=edit Bug 22521: Update fines handling to use accountline.status Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 13:02:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 12:02:37 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-I5Dql4QVRo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86897|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86901 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86901&action=edit Bug 22521: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 13:02:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 12:02:40 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-db2i5NYMRa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86898|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86902 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86902&action=edit Bug 22521: Update existing accounttypes Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 13:04:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 12:04:05 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit In-Reply-To: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22511-70-eqbPccCGvr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86674|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86904 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86904&action=edit Bug 22511: Update void method to use status We added a 'status' field to 'accountlines' in bug 22512 to allow for more fined grained control over 'types' and 'states'. This patch updates the void method to utilise this new field so we may keep the original credit type for later auditing should it be required. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 13:04:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 12:04:09 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit In-Reply-To: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22511-70-tjZWhgexDM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 --- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86905 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86905&action=edit Bug 22511: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 13:04:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 12:04:02 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit In-Reply-To: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22511-70-Bem04l7wJN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86675|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86903 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86903&action=edit Bug 22511: Update tests Updated tests to check for 'status' change and fixed 'accounttype' and moved from t/db_dependent/Accounts.t to the more appropriate t/db_dependent/Koha/Account/Lines.t Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 13:04:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 12:04:52 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit In-Reply-To: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22511-70-DpGialGdci@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 13:06:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 12:06:40 +0000 Subject: [Koha-bugs] [Bug 22512] accountlines.accountype mixes 'state' and 'type' In-Reply-To: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22512-70-Y2PnHonkzt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|22519 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22519 [Bug 22519] We have two accounttypes for "forgiven", 'FOR' and 'FFOR' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 13:06:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 12:06:40 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-Xi12RFEnaI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22519 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22519 [Bug 22519] We have two accounttypes for "forgiven", 'FOR' and 'FFOR' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 13:06:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 12:06:40 +0000 Subject: [Koha-bugs] [Bug 22519] We have two accounttypes for "forgiven", 'FOR' and 'FFOR' In-Reply-To: <bug-22519-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22519-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22519-70-zMSyPHCALm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22519 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22521 Blocks|22512 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 [Bug 22512] accountlines.accountype mixes 'state' and 'type' https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 13:07:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 12:07:13 +0000 Subject: [Koha-bugs] [Bug 22519] We have two accounttypes for "forgiven", 'FOR' and 'FFOR' In-Reply-To: <bug-22519-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22519-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22519-70-mhQGBFQUAl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22519 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |MOVED Status|NEW |RESOLVED --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- This is cleaned up by bug 22521 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 13:08:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 12:08:12 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit In-Reply-To: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22511-70-ppQDWDtBsa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|22512 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 [Bug 22512] accountlines.accountype mixes 'state' and 'type' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 13:08:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 12:08:12 +0000 Subject: [Koha-bugs] [Bug 22512] accountlines.accountype mixes 'state' and 'type' In-Reply-To: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22512-70-zGwcsiEMcR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22511 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 [Bug 22511] Koha::Account::Line->void loses the original type of the credit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 13:08:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 12:08:49 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-KXXZj0KvDo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|17702 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 [Bug 17702] Create configuration for account types -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 13:08:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 12:08:49 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account types In-Reply-To: <bug-17702-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17702-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17702-70-yc8Kn6jwQo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|22521 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 13:31:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 12:31:47 +0000 Subject: [Koha-bugs] [Bug 22562] New: Add ItemHoldingLibrary to ReservesControlBranch Message-ID: <bug-22562-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22562 Bug ID: 22562 Summary: Add ItemHoldingLibrary to ReservesControlBranch Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Target Milestone: --- -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 13:34:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 12:34:14 +0000 Subject: [Koha-bugs] [Bug 22562] Add ItemHoldingLibrary to ReservesControlBranch In-Reply-To: <bug-22562-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22562-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22562-70-IYaFJebGGS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22562 --- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 86906 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86906&action=edit Bug 22562: Add option ItemHoldingLibrary to ReservesControlBranch Test plan: 1. Apply patch 2. Run updatedatabase 3. Set syspref ReservesControlBranch to "item's holding library" 4. Create biblios, items, patrons on different libraries and define circulation (hold) rules for them 5. Verify that these rules are taken into account and that they use the holding library 6. Verify that the behaviour for other values of ReservesControlBranch still work as expected. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 13:34:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 12:34:32 +0000 Subject: [Koha-bugs] [Bug 22562] Add option ItemHoldingLibrary to ReservesControlBranch In-Reply-To: <bug-22562-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22562-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22562-70-CrbEhq5E9l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22562 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add ItemHoldingLibrary to |Add option |ReservesControlBranch |ItemHoldingLibrary to | |ReservesControlBranch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 13:34:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 12:34:41 +0000 Subject: [Koha-bugs] [Bug 22562] Add option ItemHoldingLibrary to ReservesControlBranch In-Reply-To: <bug-22562-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22562-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22562-70-zzZH9afXY9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22562 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 13:47:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 12:47:24 +0000 Subject: [Koha-bugs] [Bug 22561] Forgotten password "password requirements" box doesn't list all of the rules that are in effect for new passwords In-Reply-To: <bug-22561-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22561-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22561-70-r6HpwCcN5y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22561 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 13:58:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 12:58:22 +0000 Subject: [Koha-bugs] [Bug 22561] Forgotten password requirements hint doesn't list all rules for new passwords In-Reply-To: <bug-22561-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22561-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22561-70-t4xG74jlT4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22561 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Forgotten password |Forgotten password |"password requirements" box |requirements hint doesn't |doesn't list all of the |list all rules for new |rules that are in effect |passwords |for new passwords | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 13:58:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 12:58:43 +0000 Subject: [Koha-bugs] [Bug 20457] Overdue and pre-overdue cronjobs not skipping phone notices In-Reply-To: <bug-20457-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20457-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20457-70-ABXJO0rr75@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20457 Danielle Elder <danielle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |danielle at bywatersolutions.c | |om --- Comment #3 from Danielle Elder <danielle at bywatersolutions.com> --- This is still an issue, and it confusing to many library staff to see these notices in the message queue. It also makes support for the Talking Tech integration with Koha a bit more complicated to sort through. I volunteer as tribute to test/sign off on any patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 14:01:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 13:01:43 +0000 Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI In-Reply-To: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20388-70-EanQikrjPM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 14:10:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 13:10:54 +0000 Subject: [Koha-bugs] [Bug 22561] Forgotten password requirements hint doesn't list all rules for new passwords In-Reply-To: <bug-22561-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22561-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22561-70-0Hc8QO83hj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22561 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 14:10:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 13:10:56 +0000 Subject: [Koha-bugs] [Bug 22561] Forgotten password requirements hint doesn't list all rules for new passwords In-Reply-To: <bug-22561-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22561-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22561-70-lmXz2bGO8D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22561 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 86907 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86907&action=edit Bug 22561: Forgotten password requirements hint doesn't list all rules for new passwords This patch modifies a few templates in the OPAC so that all available information on password requirements is displayed for each case where the patron is setting a password: - If the RequireStrongPassword system preference is set, a message should appear listing strong password requirements and minimum password length. - If RequireStrongPassword is not set, the message should only ask for a minimum password length. To test, apply the patch and enable the PatronSelfRegistration and OpacResetPassword preferences. On the following pages, test with RequireStrongPassword both on and off. The correct messages should appear. - OPAC -> Forgot password. Follow the process to reset your password until you reach the step where you are entering the new password. - OPAC -> Register here. Check the password section of the registration form. - OPAC -> Log in -> Change your password. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 14:17:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 13:17:56 +0000 Subject: [Koha-bugs] [Bug 22560] Forgotten password "token expired" page still shows boxes to reset password In-Reply-To: <bug-22560-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22560-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22560-70-Kv8cFGcCQ1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22560 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22561 Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22561 [Bug 22561] Forgotten password requirements hint doesn't list all rules for new passwords -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 14:17:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 13:17:56 +0000 Subject: [Koha-bugs] [Bug 22561] Forgotten password requirements hint doesn't list all rules for new passwords In-Reply-To: <bug-22561-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22561-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22561-70-BrqdCg35s5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22561 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22560 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22560 [Bug 22560] Forgotten password "token expired" page still shows boxes to reset password -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 14:27:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 13:27:13 +0000 Subject: [Koha-bugs] [Bug 22520] Be Elastic compliant 7.x and 8.x (_doc) In-Reply-To: <bug-22520-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22520-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22520-70-BxJF2T8J9F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22520 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 14:27:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 13:27:15 +0000 Subject: [Koha-bugs] [Bug 22520] Be Elastic compliant 7.x and 8.x (_doc) In-Reply-To: <bug-22520-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22520-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22520-70-5jLCzFOFoq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22520 --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 86908 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86908&action=edit Bug 22560: Forgotten password "token expired" page still shows boxes to reset password This patch modifies the OPAC password recovery template so that the new password entry form doesn't appear if the patron has followed an invalid or expired link. This patch also corrects the markup in the page title. To test, apply the patch and follow the process for resetting a forgotten password. When you follow the password recovery link, modify the URL so that the "uniqueKey" parameter is different. The page should show an error message. The password entry form should not appear. Check the page title in the browser's title bar. It should look correct. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 14:27:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 13:27:46 +0000 Subject: [Koha-bugs] [Bug 22520] Be Elastic compliant 7.x and 8.x (_doc) In-Reply-To: <bug-22520-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22520-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22520-70-YOx37xr69B@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22520 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86908|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 14:28:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 13:28:17 +0000 Subject: [Koha-bugs] [Bug 22520] Be Elastic compliant 7.x and 8.x (_doc) In-Reply-To: <bug-22520-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22520-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22520-70-1frUaDht4t@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22520 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #3 from Owen Leonard <oleonard at myacpl.org> --- (In reply to Owen Leonard from comment #2) > Created attachment 86908 [details] [review] Sorry, wrong bug number! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 14:28:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 13:28:33 +0000 Subject: [Koha-bugs] [Bug 22520] Be Elastic compliant 7.x and 8.x (_doc) In-Reply-To: <bug-22520-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22520-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22520-70-Bmkg19EGIg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22520 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 14:29:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 13:29:04 +0000 Subject: [Koha-bugs] [Bug 22560] Forgotten password "token expired" page still shows boxes to reset password In-Reply-To: <bug-22560-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22560-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22560-70-BlqYDHKUFp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22560 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 14:29:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 13:29:06 +0000 Subject: [Koha-bugs] [Bug 22560] Forgotten password "token expired" page still shows boxes to reset password In-Reply-To: <bug-22560-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22560-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22560-70-3X4hUkySSv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22560 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 86909 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86909&action=edit Bug 22560: Forgotten password "token expired" page still shows boxes to reset password This patch modifies the OPAC password recovery template so that the new password entry form doesn't appear if the patron has followed an invalid or expired link. This patch also corrects the markup in the page title. To test, apply the patch and follow the process for resetting a forgotten password. When you follow the password recovery link, modify the URL so that the "uniqueKey" parameter is different. The page should show an error message. The password entry form should not appear. Check the page title in the browser's title bar. It should look correct. https://bugs.koha-community.org/show_bug.cgi?id=22520 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 14:34:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 13:34:50 +0000 Subject: [Koha-bugs] [Bug 22545] C4::Matcher::get_matches aggressive isbn and issn search don't give any results with ES In-Reply-To: <bug-22545-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22545-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22545-70-Z4IS7afnwc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22545 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ere.maijala at helsinki.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 14:35:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 13:35:33 +0000 Subject: [Koha-bugs] [Bug 22560] Forgotten password "token expired" page still shows boxes to reset password In-Reply-To: <bug-22560-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22560-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22560-70-285XgWArP8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22560 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 14:52:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 13:52:19 +0000 Subject: [Koha-bugs] [Bug 19980] Omnibus: Update single-column templates to use Bootstrap grid In-Reply-To: <bug-19980-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19980-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19980-70-xH5zc8IoEN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 14:52:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 13:52:20 +0000 Subject: [Koha-bugs] [Bug 14546] Make staff client templates responsive In-Reply-To: <bug-14546-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14546-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14546-70-q85D9qngwQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14546 Bug 14546 depends on bug 19980, which changed state. Bug 19980 Summary: Omnibus: Update single-column templates to use Bootstrap grid https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19980 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 15:07:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 14:07:11 +0000 Subject: [Koha-bugs] [Bug 21735] Update Sys Pref : MarkLostItemsAsReturned In-Reply-To: <bug-21735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21735-70-xclq5yrKqh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21735 Kelly McElligott <kelly at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 15:11:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 14:11:11 +0000 Subject: [Koha-bugs] [Bug 22512] accountlines.accountype mixes 'state' and 'type' In-Reply-To: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22512-70-gUZX7GoKsc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 15:11:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 14:11:16 +0000 Subject: [Koha-bugs] [Bug 22512] accountlines.accountype mixes 'state' and 'type' In-Reply-To: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22512-70-dQuNIBiPHX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86684|0 |1 is obsolete| | --- Comment #5 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 86910 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86910&action=edit Bug 22512: Add status field to accountlines Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 15:13:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 14:13:17 +0000 Subject: [Koha-bugs] [Bug 22512] accountlines.accountype mixes 'state' and 'type' In-Reply-To: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22512-70-i9nHmgv7Aq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 15:22:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 14:22:16 +0000 Subject: [Koha-bugs] [Bug 21890] Patron password reset by category In-Reply-To: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21890-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21890-70-WWXKH9lIOI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21890 --- Comment #39 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 86911 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86911&action=edit Bug 21890: Wrap message in span Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 15:31:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 14:31:12 +0000 Subject: [Koha-bugs] [Bug 13735] Item form in serials module doesn't respect max length set in the frameworks In-Reply-To: <bug-13735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13735-70-xWORkREua3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13735 --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Ultimately... we should use the same code for generating the form here that we use in catalouging as there are other issues (missing select2 functionality is an example) - but that will go way beyond this bug fix :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 15:31:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 14:31:23 +0000 Subject: [Koha-bugs] [Bug 13735] Item form in serials module doesn't respect max length set in the frameworks In-Reply-To: <bug-13735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13735-70-QsMRfPnyBH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13735 --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Thx for QA! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 15:37:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 14:37:02 +0000 Subject: [Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22563-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22563-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22563-70-0jtS1turOj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22512 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 [Bug 22512] accountlines.accountype mixes 'state' and 'type' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 15:37:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 14:37:02 +0000 Subject: [Koha-bugs] [Bug 22512] accountlines.accountype mixes 'state' and 'type' In-Reply-To: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22512-70-4gmn1xq4AL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22563 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 [Bug 22563] Convert lost handling to use 'status' instead of two accounttypes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 15:36:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 14:36:40 +0000 Subject: [Koha-bugs] [Bug 22563] New: Convert lost handling to use 'status' instead of two accounttypes Message-ID: <bug-22563-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Bug ID: 22563 Summary: Convert lost handling to use 'status' instead of two accounttypes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Bug 22512 introduces a new field for tracking the 'state' of various accounttypes; We should convert the current lost handling from using `L`,`Rep`,`W` (denoting "Lost", "Replaced" and "Written Off") in combination with `LR` (denoting fine "Lost Returned"). This will clarify the logic and also pave the way to having a more user definable accounttype configuration. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 15:37:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 14:37:06 +0000 Subject: [Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22563-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22563-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22563-70-U6nyJnOyth@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 16:38:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 15:38:13 +0000 Subject: [Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes In-Reply-To: <bug-22563-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22563-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22563-70-kyWD0yWFYe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Convert lost handling to |Convert lost handling to |use 'status' instead of two |use 'status' instead of |accounttypes |multiple accounttypes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 16:38:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 15:38:53 +0000 Subject: [Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes In-Reply-To: <bug-22563-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22563-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22563-70-qWe0BrPPK5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17702 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 [Bug 17702] Create configuration for account types -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 16:38:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 15:38:53 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account types In-Reply-To: <bug-17702-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17702-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17702-70-qktZAYjL8z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22563 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 16:39:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 15:39:52 +0000 Subject: [Koha-bugs] [Bug 22512] accountlines.accountype mixes 'state' and 'type' In-Reply-To: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22512-70-vFnEZxrzWI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22563 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 16:39:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 15:39:52 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-WBJpQrN62i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22563 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 16:39:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 15:39:52 +0000 Subject: [Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes In-Reply-To: <bug-22563-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22563-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22563-70-Rj4a9qxajp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|22512 |22521 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 [Bug 22512] accountlines.accountype mixes 'state' and 'type' https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 16:42:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 15:42:41 +0000 Subject: [Koha-bugs] [Bug 22564] New: accounttype 'Rep' is still referred to but is never set Message-ID: <bug-22564-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564 Bug ID: 22564 Summary: accounttype 'Rep' is still referred to but is never set Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- The 'Rep' accounttype has not been set in Koha for some time and it should now be safe to remove all references to it. History: 'Rep' used to mean 'Replaced' and at some point may have been used to denote when a lost book had been replaced. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 16:43:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 15:43:37 +0000 Subject: [Koha-bugs] [Bug 22564] accounttype 'Rep' is still referred to but is never set In-Reply-To: <bug-22564-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22564-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22564-70-hNIyGZLfPL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22521 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 16:43:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 15:43:37 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-ZZysusuw7T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22564 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564 [Bug 22564] accounttype 'Rep' is still referred to but is never set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 16:43:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 15:43:59 +0000 Subject: [Koha-bugs] [Bug 22564] accounttype 'Rep' is still referred to but is never set In-Reply-To: <bug-22564-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22564-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22564-70-EWII0gvbic@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22563 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 16:43:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 15:43:59 +0000 Subject: [Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes In-Reply-To: <bug-22563-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22563-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22563-70-Byynwgbdma@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22564 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564 [Bug 22564] accounttype 'Rep' is still referred to but is never set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 16:45:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 15:45:10 +0000 Subject: [Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes In-Reply-To: <bug-22563-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22563-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22563-70-eav9CcQ3Xm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|22521 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 16:45:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 15:45:10 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-QF4CZzXYwG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22563 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 17:11:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 16:11:50 +0000 Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI In-Reply-To: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20388-70-AVBGvCbuP6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 --- Comment #41 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 86912 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86912&action=edit Bug 20388: Use live handler for deleting elements -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 17:12:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 16:12:11 +0000 Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI In-Reply-To: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20388-70-0EGnZiE9nQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 17:14:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 16:14:32 +0000 Subject: [Koha-bugs] [Bug 22565] New: Partially receiving order and adding internal note on invoice updates note on every order on the system Message-ID: <bug-22565-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22565 Bug ID: 22565 Summary: Partially receiving order and adding internal note on invoice updates note on every order on the system Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: janet.mcgowan at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Tested on 18.11.01 and 18.11.03 If you have an order for multiple copies and only receipt one or more of those copies but not the entire number, and edit the internal note field on the invoice screen, the internal note field then updates every order on the system. The internal note is applied to all orders but also it overwrites any other note that was there. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 17:35:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 16:35:26 +0000 Subject: [Koha-bugs] [Bug 22565] Partially receiving order and adding internal note on invoice updates note on every order on the system In-Reply-To: <bug-22565-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22565-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22565-70-LTjPQJcNQR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22565 Fiona Borthwick <fiona.borthwick at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fiona.borthwick at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 17:39:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 16:39:32 +0000 Subject: [Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes In-Reply-To: <bug-22563-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22563-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22563-70-e8uFg8VJSc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22521 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 17:39:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 16:39:32 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-XK9HwkNN19@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22563 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 17:39:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 16:39:43 +0000 Subject: [Koha-bugs] [Bug 22564] accounttype 'Rep' is still referred to but is never set In-Reply-To: <bug-22564-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22564-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22564-70-QzI6wtqE0w@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|22521 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 17:39:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 16:39:43 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-xi1WcKQdxS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22564 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564 [Bug 22564] accounttype 'Rep' is still referred to but is never set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 17:43:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 16:43:43 +0000 Subject: [Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes In-Reply-To: <bug-22563-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22563-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22563-70-Ti8JCp7w7Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86913 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86913&action=edit Bug 22563: Be more descriptive with accountypes Convert 'L' to 'LOST' to become more descriptive in it's use. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 17:43:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 16:43:45 +0000 Subject: [Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes In-Reply-To: <bug-22563-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22563-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22563-70-atgFQ4GvX3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86914 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86914&action=edit Bug 22563: Update lost handling to use accountline.status Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 17:43:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 16:43:56 +0000 Subject: [Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes In-Reply-To: <bug-22563-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22563-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22563-70-qJNptITEAV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 17:45:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 16:45:37 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit In-Reply-To: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22511-70-MHhDQ9ynRb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86903|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86915 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86915&action=edit Bug 22511: Update tests Updated tests to check for 'status' change and fixed 'accounttype' and moved from t/db_dependent/Accounts.t to the more appropriate t/db_dependent/Koha/Account/Lines.t Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 17:45:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 16:45:40 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit In-Reply-To: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22511-70-MUDeg0YV4x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86904|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86916 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86916&action=edit Bug 22511: Update void method to use status We added a 'status' field to 'accountlines' in bug 22512 to allow for more fined grained control over 'types' and 'states'. This patch updates the void method to utilise this new field so we may keep the original credit type for later auditing should it be required. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 17:45:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 16:45:43 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit In-Reply-To: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22511-70-qaM0DV0hTw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86905|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86917 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86917&action=edit Bug 22511: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 17:46:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 16:46:47 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-fCRSjddwcq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86899|0 |1 is obsolete| | --- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86918 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86918&action=edit Bug 22521: Increase varchar size for accounttype accountlines.accounttype is currently a short varchar(5) field for to store accounttype codes. Koha is moving towards more descriptive codes which require a larger capacity varchar(16). Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 17:46:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 16:46:50 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-szbsVztCpW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86900|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86919&action=edit Bug 22521: Update fines handling to use accountline.status Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 17:46:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 16:46:54 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-8l9yGo8Cbq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86901|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86920 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86920&action=edit Bug 22521: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 17:46:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 16:46:57 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-zL8Qm3MAPu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86902|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86921 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86921&action=edit Bug 22521: Update existing accounttypes Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 17:48:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 16:48:34 +0000 Subject: [Koha-bugs] [Bug 22564] accounttype 'Rep' is still referred to but is never set In-Reply-To: <bug-22564-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22564-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22564-70-o4ZgCqLYAg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 17:48:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 16:48:24 +0000 Subject: [Koha-bugs] [Bug 22564] accounttype 'Rep' is still referred to but is never set In-Reply-To: <bug-22564-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22564-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22564-70-tv5tAuMxSr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564 --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86922 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86922&action=edit Bug 22564: Remove references to 'Rep' accounttype Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 17:54:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 16:54:54 +0000 Subject: [Koha-bugs] [Bug 22539] Fines charged on back-dated checkin when item has been renewed In-Reply-To: <bug-22539-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22539-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22539-70-bKlyecr5Kz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22539 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 17:55:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 16:55:09 +0000 Subject: [Koha-bugs] [Bug 22539] Fines charged on back-dated checkin when item has been renewed In-Reply-To: <bug-22539-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22539-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22539-70-YS8RbNGT97@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22539 --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Fun.. I'll take a deeper look at this on Monday. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 18:17:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 17:17:32 +0000 Subject: [Koha-bugs] [Bug 22566] New: Stock rotation cronjob reporting has issues Message-ID: <bug-22566-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22566 Bug ID: 22566 Summary: Stock rotation cronjob reporting has issues Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Target Milestone: --- Trying to test this today we found that some of the reporting features of the cronjob seem to be problematic: To recreate: 1 - Create some rotas 2 - Add some items 3 - run cronjob with -x 4 - in sql UPDATE branchtransfers SET datearrived=DATE_SUB(CURDATE(), INTERVAL 1 DAY) WHERE comments like '%rota%' 5 - run the cornjob without -x: perl misc/cronjobs/stockrotation.pl -r full 6 - get an error about undefined emails 7 - run it for branch emails perl misc/cronjobs/stockrotation.pl -r email 8 - get an error about odd numebr of elements in hash -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 18:24:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 17:24:14 +0000 Subject: [Koha-bugs] [Bug 22565] Partially receiving order and adding internal note on invoice updates note on every order on the system In-Reply-To: <bug-22565-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22565-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22565-70-KgK8u66pM7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22565 Janet McGowan <janet.mcgowan at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan at ptfs-europe.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 18:24:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 17:24:49 +0000 Subject: [Koha-bugs] [Bug 22566] Stock rotation cronjob reporting has issues In-Reply-To: <bug-22566-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22566-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22566-70-jayJOaEPK8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22566 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 86923 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86923&action=edit Bug 22566: Fix some problems -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 18:24:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 17:24:51 +0000 Subject: [Koha-bugs] [Bug 22539] Fines charged on back-dated checkin when item has been renewed In-Reply-To: <bug-22539-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22539-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22539-70-hQWPGC4d1u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22539 --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- Honestly, I'm not positive I'd call this a bug. It sounds like Koha is behaving correctly and the patron is not ;) Maybe it would be possible to look at the latest fine related to a checkin since we have issue_id's for them, and see if the return date falls *after* the backdated return date, and adjust the fine accordingly? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 18:25:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 17:25:08 +0000 Subject: [Koha-bugs] [Bug 22566] Stock rotation cronjob reporting has issues In-Reply-To: <bug-22566-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22566-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22566-70-iCz421RAHC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22566 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 18:26:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 17:26:28 +0000 Subject: [Koha-bugs] [Bug 22566] Stock rotation cronjob reporting has issues In-Reply-To: <bug-22566-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22566-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22566-70-FMLnD9uEXg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22566 --- Comment #2 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Nick Clemens from comment #1) > Created attachment 86923 [details] [review] > Bug 22566: Fix some problems After this patch you shoudl eb able to get some output with -r full, however, -r email says no branches have actionable items - the GetPreparedLetter call seems wrong, we aren't passing substitutions I think, but I am not sure exactly what we must pass here -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 18:37:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 17:37:19 +0000 Subject: [Koha-bugs] [Bug 22567] New: Stock rotation manage rotas should show items currrent and desired locations Message-ID: <bug-22567-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22567 Bug ID: 22567 Summary: Stock rotation manage rotas should show items currrent and desired locations Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Target Milestone: --- Right now an item just says in-transit:yes/no - it should specify where it is and where it is going -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 18:38:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 17:38:12 +0000 Subject: [Koha-bugs] [Bug 22568] New: Replace RSS icon in the OPAC with Font Awesome Message-ID: <bug-22568-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22568 Bug ID: 22568 Summary: Replace RSS icon in the OPAC with Font Awesome Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Target Milestone: --- I propose that we replace the RSS icon image in the OPAC with a styled Font Awesome RSS icon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 18:39:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 17:39:09 +0000 Subject: [Koha-bugs] [Bug 22539] Fines charged on back-dated checkin when item has been renewed In-Reply-To: <bug-22539-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22539-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22539-70-uc2EaPoqTU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22539 --- Comment #3 from Andrew <andrew at bywatersolutions.com> --- You're not wrong, Kyle. This is Koha doing just what it's told, following the letter of the law. But I'd hate to be the librarian who has to explain to a patron that they got a fine because they renewed something :) Adjusting fines generated after the backdated return date seems like a good solution to me. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 18:46:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 17:46:41 +0000 Subject: [Koha-bugs] [Bug 22567] Stock rotation manage rotas should show items currrent and desired locations In-Reply-To: <bug-22567-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22567-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22567-70-Z9lw8M93J6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22567 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 18:48:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 17:48:53 +0000 Subject: [Koha-bugs] [Bug 22568] Replace RSS icon in the OPAC with Font Awesome In-Reply-To: <bug-22568-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22568-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22568-70-R0YsXkA2AJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22568 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 18:48:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 17:48:56 +0000 Subject: [Koha-bugs] [Bug 22568] Replace RSS icon in the OPAC with Font Awesome In-Reply-To: <bug-22568-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22568-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22568-70-67em7SGr64@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22568 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 86924 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86924&action=edit Bug 22568: Replace RSS icon in the OPAC with Font Awesome This patch removes the RSS icon image (feed-icon-16x16.png) from the OPAC and replaces it with Font Awesome icons styled to match. To test, apply the patch and regenerate the OPAC CSS. View the following pages, confirming that the RSS icon looks correct: - OPAC home page (RSS news icon) - Search results page (Subscribe to search) - Recent comments - Search history - Lists -> View list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 18:49:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 17:49:52 +0000 Subject: [Koha-bugs] [Bug 22569] New: Stock rotation: need transfer reports Message-ID: <bug-22569-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Bug ID: 22569 Summary: Stock rotation: need transfer reports Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Target Milestone: --- The cronjob provides a report email tot he branch, however, there is no way on the staff client to view current items needing checked in/advanced at the current branch. Perhaps a 'transfers to send' report like 'transfers to receive' -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 18:51:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 17:51:17 +0000 Subject: [Koha-bugs] [Bug 22569] Stock rotation: need transfer reports In-Reply-To: <bug-22569-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22569-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22569-70-qtwdDpUqg6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 19:31:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 18:31:08 +0000 Subject: [Koha-bugs] [Bug 22556] Add ability to quickly filter funds/budgets by library on the Acquisitions home page In-Reply-To: <bug-22556-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22556-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22556-70-G2DZz67Ggb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22556 Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jose-mario.monteiro-santos@ | |inlibro.com --- Comment #4 from Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> --- If a sub-fund assigned to a specific library is collapsed, it is not shown in the results when the table is filtered. I can understand if this is an acceptable behavior, but personally I expected all related funds to be shown when filtering by library. In a similar fashion, if a "main" fund is assigned to a library but its sub-funds are not, the main fund has the collapse/expand arrow even though there is nothing else to show. (I'm not sure how often that would happen in real production servers though) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 19:32:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 18:32:22 +0000 Subject: [Koha-bugs] [Bug 18895] Lost Items Not Removed From Patron's Account When Charge is Paid In-Reply-To: <bug-18895-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18895-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18895-70-CF1jFaXaaA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18895 Kelly McElligott <kelly at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 19:39:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 18:39:31 +0000 Subject: [Koha-bugs] [Bug 22410] Software error while adding order on a MARC file record without an author In-Reply-To: <bug-22410-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22410-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22410-70-MtnPuQldbU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22410 --- Comment #3 from Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> --- This is strange because I get it consistently. On my own side, I create MARC files with records without tag 100 by going to "tools > Export data" and I can confirm there are no tags 100 in records before the software error with the MARC link after step 5. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 19:52:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 18:52:34 +0000 Subject: [Koha-bugs] [Bug 13782] RSS for news needs a bit of styling In-Reply-To: <bug-13782-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13782-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13782-70-IvgZqStUmL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13782 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22568 Status|NEW |ASSIGNED Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22568 [Bug 22568] Replace RSS icon in the OPAC with Font Awesome -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 19:52:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 18:52:34 +0000 Subject: [Koha-bugs] [Bug 22568] Replace RSS icon in the OPAC with Font Awesome In-Reply-To: <bug-22568-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22568-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22568-70-spvu9KvyxM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22568 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13782 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13782 [Bug 13782] RSS for news needs a bit of styling -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 19:58:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 18:58:04 +0000 Subject: [Koha-bugs] [Bug 13782] RSS for news needs a bit of styling In-Reply-To: <bug-13782-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13782-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13782-70-iyPoRCnY9T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13782 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 19:58:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 18:58:06 +0000 Subject: [Koha-bugs] [Bug 13782] RSS for news needs a bit of styling In-Reply-To: <bug-13782-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13782-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13782-70-h85sKjVR8n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13782 --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 86925 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86925&action=edit Bug 13782: RSS for news needs a bit of styling This patch makes a number of updates to the display of news in the OPAC. I hope that this makes OPAC news nicer/easier to read. It includes style changes to make the RSS link look better too. To test, apply the patch and regenerate the OPAC CSS. You should have multiple active news items. View the OPAC news with varied values of NewsAuthorDisplay and OpacNewsLibrarySelect. Test the single news item view. Test with Quotes on and off, and with OpacMainUserBlock populated or not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 20:05:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 19:05:19 +0000 Subject: [Koha-bugs] [Bug 22550] OPAC suggestion form doesn't require mandatory fields In-Reply-To: <bug-22550-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22550-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22550-70-z8u5l9dcpt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22550 Bin <bin.wen at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86823|0 |1 is obsolete| | --- Comment #2 from Bin <bin.wen at inlibro.com> --- Created attachment 86926 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86926&action=edit Bug 22550: OPAC suggestion form doesn't require mandatory fields Test plan: 1. OPAC->login->your purchase suggestions->New purchase suggestion 2. Click button "Submit your suggestion" directly without filling in any field. Empty suggestion record was added succeffully. 3. Apply the patch. 4. Click button "Submit your suggestion" directly without filling in any field. The required fields should be labeled in red. (you can change the mandatory fields by preference 'OPACSuggestionMandatoryFields') Signed-off-by: Bin Wen <bin.wen at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 20:19:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 19:19:59 +0000 Subject: [Koha-bugs] [Bug 22536] Display problem in Holds to Pull report In-Reply-To: <bug-22536-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22536-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22536-70-gc5nwRnmt2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22536 Bin <bin.wen at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86872|0 |1 is obsolete| | --- Comment #5 from Bin <bin.wen at inlibro.com> --- Created attachment 86927 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86927&action=edit Bug 22536: Display problem in Holds to Pull report This patch modifies the display of several values in the holds to pull report so that they can be displayed as lists instead of as chunks of HTML generated in SQL. This patch modifies the SQL in pendingreserves.pl so that values can be formatted in the same way that holding branch is. The better long-term solution is to remove SQL from pendingreserves.pl altogether, but this is a quick fix. This patch also makes a couple of minor markup changes to fix validation. To test, apply the patch and go to Circulation -> Holds to pull. To see the changes the patch makes your holds to pull list should have titles with multiple items at multiple branches, with call number, copy number, and enumeration data. These values should all be displayed in bulleted lists. Signed-off-by: David Roberts <david.roberts at ptfs-europe.com> Signed-off-by: Bin Wen <bin.wen at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 20:39:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 19:39:09 +0000 Subject: [Koha-bugs] [Bug 22525] Navigation arrows on the bottom of Cataloging search pages In-Reply-To: <bug-22525-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22525-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22525-70-zaBltNFEw5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22525 Bin <bin.wen at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86755|0 |1 is obsolete| | --- Comment #4 from Bin <bin.wen at inlibro.com> --- Created attachment 86928 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86928&action=edit Bug 22525: Navigation arrows on the bottom of Cataloging search pages This patch adds a second set of pagination links to the cataloging search result page, at the bottom of the first set of search results. Also added is a horizontal rule after the second set of links in order to make it clearer that the links are for the search results above. To test, apply the patch and go to Cataloging. Perform a search which will return multiple pages of results. Confirm that the links work correctly. Signed-off-by: Marjorie <marjorie.barry-vila at collecto.ca> Signed-off-by: Bin Wen <bin.wen at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 20:42:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 19:42:30 +0000 Subject: [Koha-bugs] [Bug 22556] Add ability to quickly filter funds/budgets by library on the Acquisitions home page In-Reply-To: <bug-22556-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22556-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22556-70-mubfbqiAr6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22556 Bin <bin.wen at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86850|0 |1 is obsolete| | --- Comment #5 from Bin <bin.wen at inlibro.com> --- Created attachment 86929 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86929&action=edit Bug 22556: Add ability to quickly filter funds/budgets by library on the Acquisitions home page Some librarians would like to have a quick pulldown selector to filter budgets and funds by library on the acquisitions home page. Test Plan: 1) Apply this patch 2) Navigate to the Acquisitions home page 3) Notice the new pulldown on the budgets table labeled "Filter by library" 4) Select a library that has one or more budgets/funds 5) Note only budgets/funds from that library now display! Signed-off-by: Liz Rea <wizzyrea at gmail.com> Signed-off-by: Bin Wen <bin.wen at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 20:54:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 19:54:19 +0000 Subject: [Koha-bugs] [Bug 22053] Ability to disable some plugins In-Reply-To: <bug-22053-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22053-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22053-70-70XDoSOjoo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jose-mario.monteiro-santos@ | |inlibro.com Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 20:59:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 19:59:19 +0000 Subject: [Koha-bugs] [Bug 22556] Add ability to quickly filter funds/budgets by library on the Acquisitions home page In-Reply-To: <bug-22556-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22556-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22556-70-QA3iA5RH4Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22556 Bin <bin.wen at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bin.wen at inlibro.com --- Comment #6 from Bin <bin.wen at inlibro.com> --- It is ok to follow the test plan, I saw Jos?-Mario's comment and added sub-fund to main fund. It is true that sub-fund is not shown after filtering, which is indeed a problem in my opinion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 21:21:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 20:21:04 +0000 Subject: [Koha-bugs] [Bug 21003] Don't show warning when editing a reserve item In-Reply-To: <bug-21003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21003-70-pDzuH1P2Kg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21003 Bin <bin.wen at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86708|0 |1 is obsolete| | --- Comment #6 from Bin <bin.wen at inlibro.com> --- Created attachment 86930 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86930&action=edit Bug 21003: Made Edit keywords more consistent in add_items-step2.tt When adding a course reserve with a barcode that already exists, the title, breadcrumbs, and legend of the form all specify that the user is editing, and not adding, the book. Test plan: Same as comment 1 Signed-off-by: Devinim <kohadevinim at devinim.com.tr> Signed-off-by: Bin Wen <bin.wen at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 21:27:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 20:27:17 +0000 Subject: [Koha-bugs] [Bug 22372] Add available location to Holds awaiting pickup In-Reply-To: <bug-22372-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22372-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22372-70-0NmlyeDFed@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22372 Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85285|0 |1 is obsolete| | --- Comment #5 from Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> --- Created attachment 86931 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86931&action=edit Bug 22372 - Add available location to Holds awaiting pickup Test plan: - Go to Circulation, Holds awaiting pickup (circ/waitingreserves.pl) - Note the additional column for available location. Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos at inLibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 21:27:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 20:27:31 +0000 Subject: [Koha-bugs] [Bug 22372] Add available location to Holds awaiting pickup In-Reply-To: <bug-22372-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22372-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22372-70-XorDNdeYQS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22372 Jos?-Mario Monteiro-Santos <jose-mario.monteiro-santos at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jose-mario.monteiro-santos@ | |inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 21:34:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 20:34:38 +0000 Subject: [Koha-bugs] [Bug 22559] OPAC Forgotten password functionality not working In-Reply-To: <bug-22559-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22559-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22559-70-bjrAgkrlng@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22559 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #4 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 21:35:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 20:35:00 +0000 Subject: [Koha-bugs] [Bug 22533] Cannot create manual invoices In-Reply-To: <bug-22533-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22533-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22533-70-oL6yjtw2dz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22533 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #8 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 21:35:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 20:35:19 +0000 Subject: [Koha-bugs] [Bug 21130] Detail XSLT produces translatable HTML class In-Reply-To: <bug-21130-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21130-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21130-70-knvmhjQlCO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21130 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #12 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 21:35:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 20:35:29 +0000 Subject: [Koha-bugs] [Bug 13735] Item form in serials module doesn't respect max length set in the frameworks In-Reply-To: <bug-13735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13735-70-O2GeDVDeNu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13735 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #11 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 21:35:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 20:35:48 +0000 Subject: [Koha-bugs] [Bug 21304] Update two-column templates with Bootstrap grid: Catalog In-Reply-To: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21304-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21304-70-hs1AcHlveJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21304 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #29 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 21:36:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 20:36:04 +0000 Subject: [Koha-bugs] [Bug 21948] Clean up style of item detail page In-Reply-To: <bug-21948-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21948-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21948-70-ExwDFCQ0kY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21948 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #9 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 21:36:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 20:36:28 +0000 Subject: [Koha-bugs] [Bug 19661] Add routes for funds In-Reply-To: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19661-70-9v0gG2tOC1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #23 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 21:36:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 20:36:57 +0000 Subject: [Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch In-Reply-To: <bug-20478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20478-70-41HHOqxJmN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #24 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 21:37:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 20:37:17 +0000 Subject: [Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint In-Reply-To: <bug-22008-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22008-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22008-70-UsatbMdx0h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #36 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 21:37:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 20:37:34 +0000 Subject: [Koha-bugs] [Bug 21998] Add pattern parameter in Koha::Token In-Reply-To: <bug-21998-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21998-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21998-70-AJsSKSa4Aw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21998 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #14 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 21:37:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 20:37:51 +0000 Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile In-Reply-To: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18589-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18589-70-chDWFuoUDI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #40 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 22 21:38:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Mar 2019 20:38:13 +0000 Subject: [Koha-bugs] [Bug 22032] Improve local cover image tab on detail page In-Reply-To: <bug-22032-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22032-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22032-70-XUSOyp5KUS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22032 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #7 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 23 01:50:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Mar 2019 00:50:41 +0000 Subject: [Koha-bugs] [Bug 15261] Verify if checkouts or reserves requests periods overlap with existing reserves In-Reply-To: <bug-15261-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15261-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15261-70-SQ3IyHRtJP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15261 daveppub at asu.edu changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |daveppub at asu.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 23 02:42:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Mar 2019 01:42:03 +0000 Subject: [Koha-bugs] [Bug 20457] Overdue and pre-overdue cronjobs not skipping phone notices In-Reply-To: <bug-20457-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20457-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20457-70-qqcOZvJQEi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20457 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |wizzyrea at gmail.com --- Comment #4 from Liz Rea <wizzyrea at gmail.com> --- Hi, This doesn't seem to apply at the moment: CONFLICT (content): Merge conflict in misc/cronjobs/advance_notices.pl error: Failed to merge in the changes. Patch failed at 0001 Bug 20457: Overdue and pre-overdue cronjobs not skipping phone notices Sorry :( Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 23 02:52:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Mar 2019 01:52:30 +0000 Subject: [Koha-bugs] [Bug 17746] koha-reset-passwd should use Koha::Patron->set_password In-Reply-To: <bug-17746-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17746-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17746-70-w0d3pH64Hb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17746 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84798|0 |1 is obsolete| | Attachment #84899|0 |1 is obsolete| | Attachment #85363|0 |1 is obsolete| | --- Comment #19 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86932 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86932&action=edit Bug 17746: Make koha-reset-passwd user set_password.pl Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 23 02:52:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Mar 2019 01:52:33 +0000 Subject: [Koha-bugs] [Bug 17746] koha-reset-passwd should use Koha::Patron->set_password In-Reply-To: <bug-17746-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17746-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17746-70-53E1gF8oM7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17746 --- Comment #20 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86933&action=edit Bug 17746: Add misc/admin/set_password.pl script This patch introduces a script that allows changing a patron's password. The change overrides the defined password enforcement policy. If multiple conditions are passed to match on the patron, they all need to match. Otherwise an error message is printed. Attributes to search the patron on: - cardnumber - patron_id (a.k.a. borrowernumber) - userid we usually know some of them, but if we specify more than one, they need to match a patron, together. To test: 1) Apply this patch 2) Have a known patron (i.e. you know the cardnumber, the borrowernumber and the userid). 3) Run: $ kshell k$ perl misc/admin/set_password.pl --cardnumber <the_card_number> \ --password a_password 4) Verify you can login with the new password 5) Repeat 3) through 5) with --patron_id and --userid => SUCCESS: You can login in all cases 6) Try combining some or all the parameters => SUCCESS: It fails when it should, it succeeds when it should 7) Sign off :-D Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com> Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 23 02:52:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Mar 2019 01:52:37 +0000 Subject: [Koha-bugs] [Bug 17746] koha-reset-passwd should use Koha::Patron->set_password In-Reply-To: <bug-17746-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17746-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17746-70-4BplIbpMfo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17746 --- Comment #21 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86934&action=edit Bug 17746: (QA follow-up) Make set_password.pl generate a password if required This patch makes the set_password.pl script generate the password if it is not passed as an argument. It also changes the behaviour of set_password.pl: it will now print the userid and password (generated or not) to mimick the behaviour from koha-reset-passwd. The koha-reset-passwd gets simplified as it doesn't generate the random password anymore, it passes the responsability to set_password.pl To test: - Follow the steps from the original platch - Verify all behaves as expected Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 23 02:52:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Mar 2019 01:52:26 +0000 Subject: [Koha-bugs] [Bug 17746] koha-reset-passwd should use Koha::Patron->set_password In-Reply-To: <bug-17746-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17746-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17746-70-0froyUo4ky@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17746 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 23 09:27:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Mar 2019 08:27:37 +0000 Subject: [Koha-bugs] [Bug 21049] Rancor 007 field does not retain value In-Reply-To: <bug-21049-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21049-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21049-70-5Ov3oFWcut@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21049 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 23 09:27:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Mar 2019 08:27:40 +0000 Subject: [Koha-bugs] [Bug 21049] Rancor 007 field does not retain value In-Reply-To: <bug-21049-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21049-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21049-70-NmGlcLJWsx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21049 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86848|0 |1 is obsolete| | Attachment #86849|0 |1 is obsolete| | --- Comment #10 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86935 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86935&action=edit Bug 21049: Fix value of material select for Rancor 007 widget The material type is selected in accordance with position 0 of 007 Test plan: 1. Create a new record using the advanced editor 2. Select a material type for field 007 and set at least the position 0 of this field 3. Save the record and reload the page 4. The material type should remain selected 5. Try with all available material types Signed-off-by: Liz Rea <wizzyrea at gmail.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 23 09:27:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Mar 2019 08:27:43 +0000 Subject: [Koha-bugs] [Bug 21049] Rancor 007 field does not retain value In-Reply-To: <bug-21049-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21049-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21049-70-npfP3WPES6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21049 --- Comment #11 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86936 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86936&action=edit Bug 21049: Set 007/00 when selecting material type (Rancor) There is a 1-1 relationship between the material type values and the position 00 of 007 field. Selecting a material type should set this position's value. Signed-off-by: Liz Rea <wizzyrea at gmail.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 23 09:55:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Mar 2019 08:55:48 +0000 Subject: [Koha-bugs] [Bug 17746] koha-reset-passwd should use Koha::Patron->set_password In-Reply-To: <bug-17746-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17746-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17746-70-USiYYwmx9U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17746 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 23 09:55:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Mar 2019 08:55:52 +0000 Subject: [Koha-bugs] [Bug 17746] koha-reset-passwd should use Koha::Patron->set_password In-Reply-To: <bug-17746-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17746-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17746-70-i5wEBzuGiU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17746 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86932|0 |1 is obsolete| | Attachment #86933|0 |1 is obsolete| | Attachment #86934|0 |1 is obsolete| | --- Comment #22 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86937&action=edit Bug 17746: Make koha-reset-passwd user set_password.pl Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Liz Rea <wizzyrea at gmail.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 23 09:55:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Mar 2019 08:55:56 +0000 Subject: [Koha-bugs] [Bug 17746] koha-reset-passwd should use Koha::Patron->set_password In-Reply-To: <bug-17746-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17746-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17746-70-mvdeF10dBe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17746 --- Comment #23 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86938&action=edit Bug 17746: Add misc/admin/set_password.pl script This patch introduces a script that allows changing a patron's password. The change overrides the defined password enforcement policy. If multiple conditions are passed to match on the patron, they all need to match. Otherwise an error message is printed. Attributes to search the patron on: - cardnumber - patron_id (a.k.a. borrowernumber) - userid we usually know some of them, but if we specify more than one, they need to match a patron, together. To test: 1) Apply this patch 2) Have a known patron (i.e. you know the cardnumber, the borrowernumber and the userid). 3) Run: $ kshell k$ perl misc/admin/set_password.pl --cardnumber <the_card_number> \ --password a_password 4) Verify you can login with the new password 5) Repeat 3) through 5) with --patron_id and --userid => SUCCESS: You can login in all cases 6) Try combining some or all the parameters => SUCCESS: It fails when it should, it succeeds when it should 7) Sign off :-D Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com> Signed-off-by: Liz Rea <wizzyrea at gmail.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 23 09:56:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Mar 2019 08:56:00 +0000 Subject: [Koha-bugs] [Bug 17746] koha-reset-passwd should use Koha::Patron->set_password In-Reply-To: <bug-17746-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17746-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17746-70-dEtBSQ42g7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17746 --- Comment #24 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86939&action=edit Bug 17746: (QA follow-up) Make set_password.pl generate a password if required This patch makes the set_password.pl script generate the password if it is not passed as an argument. It also changes the behaviour of set_password.pl: it will now print the userid and password (generated or not) to mimick the behaviour from koha-reset-passwd. The koha-reset-passwd gets simplified as it doesn't generate the random password anymore, it passes the responsability to set_password.pl To test: - Follow the steps from the original platch - Verify all behaves as expected Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Liz Rea <wizzyrea at gmail.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 23 09:56:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Mar 2019 08:56:11 +0000 Subject: [Koha-bugs] [Bug 17746] koha-reset-passwd should use Koha::Patron->set_password In-Reply-To: <bug-17746-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17746-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17746-70-aEYepfgWum@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17746 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 23 10:05:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Mar 2019 09:05:57 +0000 Subject: [Koha-bugs] [Bug 22536] Display problem in Holds to Pull report In-Reply-To: <bug-22536-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22536-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22536-70-H3AvTzZmoX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22536 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 23 10:06:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Mar 2019 09:06:00 +0000 Subject: [Koha-bugs] [Bug 22536] Display problem in Holds to Pull report In-Reply-To: <bug-22536-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22536-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22536-70-rHx3TkvyCW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22536 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86927|0 |1 is obsolete| | --- Comment #6 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86940&action=edit Bug 22536: Display problem in Holds to Pull report This patch modifies the display of several values in the holds to pull report so that they can be displayed as lists instead of as chunks of HTML generated in SQL. This patch modifies the SQL in pendingreserves.pl so that values can be formatted in the same way that holding branch is. The better long-term solution is to remove SQL from pendingreserves.pl altogether, but this is a quick fix. This patch also makes a couple of minor markup changes to fix validation. To test, apply the patch and go to Circulation -> Holds to pull. To see the changes the patch makes your holds to pull list should have titles with multiple items at multiple branches, with call number, copy number, and enumeration data. These values should all be displayed in bulleted lists. Signed-off-by: David Roberts <david.roberts at ptfs-europe.com> Signed-off-by: Bin Wen <bin.wen at inlibro.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 23 10:08:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Mar 2019 09:08:32 +0000 Subject: [Koha-bugs] [Bug 22536] Display problem in Holds to Pull report In-Reply-To: <bug-22536-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22536-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22536-70-i6VnwGTOKK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22536 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 23 10:24:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Mar 2019 09:24:28 +0000 Subject: [Koha-bugs] [Bug 22495] Restore su-geo field in Elasticsearch mappings In-Reply-To: <bug-22495-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22495-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22495-70-FmC7eyXTCz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22495 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 23 10:24:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Mar 2019 09:24:31 +0000 Subject: [Koha-bugs] [Bug 22495] Restore su-geo field in Elasticsearch mappings In-Reply-To: <bug-22495-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22495-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22495-70-WCEjZtYvYb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22495 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86860|0 |1 is obsolete| | --- Comment #3 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86941&action=edit Bug 22495: Restore Elasticsearch mapping for su-geo Test plan: 1. Reset mappings 2. Run perl misc/search_tools/rebuild_elastic_search.pl -d -b -v 3. Do a search and verify that the Places facet works Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 23 10:24:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Mar 2019 09:24:40 +0000 Subject: [Koha-bugs] [Bug 22495] Restore su-geo field in Elasticsearch mappings In-Reply-To: <bug-22495-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22495-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22495-70-nA5qmV1Dhe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22495 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com QA Contact| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 23 10:32:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Mar 2019 09:32:20 +0000 Subject: [Koha-bugs] [Bug 22550] OPAC suggestion form doesn't require mandatory fields In-Reply-To: <bug-22550-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22550-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22550-70-TMaeacZFju@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22550 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86926|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 86942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86942&action=edit Bug 22550: OPAC suggestion form doesn't require mandatory fields Test plan: 1. OPAC->login->your purchase suggestions->New purchase suggestion 2. Click button "Submit your suggestion" directly without filling in any field. Empty suggestion record was added succeffully. 3. Apply the patch. 4. Click button "Submit your suggestion" directly without filling in any field. The required fields should be labeled in red. (you can change the mandatory fields by preference 'OPACSuggestionMandatoryFields') Signed-off-by: Bin Wen <bin.wen at inlibro.com> Signed-off-by: Jogiraju,T. <rajujogi.t at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 23 10:39:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Mar 2019 09:39:38 +0000 Subject: [Koha-bugs] [Bug 22550] OPAC suggestion form doesn't require mandatory fields In-Reply-To: <bug-22550-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22550-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22550-70-I6DLtsjhMk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22550 T. Jogi Raju <rajujogi.t at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |rajujogi.t at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 23 10:39:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Mar 2019 09:39:05 +0000 Subject: [Koha-bugs] [Bug 22550] OPAC suggestion form doesn't require mandatory fields In-Reply-To: <bug-22550-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22550-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22550-70-ebAf9Tu3Xx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22550 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86942|0 |1 is obsolete| | --- Comment #4 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 86943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86943&action=edit Bug 22550: OPAC suggestion form doesn't require mandatory fields Test plan: 1. OPAC->login->your purchase suggestions->New purchase suggestion 2. Click button "Submit your suggestion" directly without filling in any field. Empty suggestion record was added succeffully. 3. Apply the patch. 4. Click button "Submit your suggestion" directly without filling in any field. The required fields should be labeled in red. (you can change the mandatory fields by preference 'OPACSuggestionMandatoryFields') Signed-off-by: Bin Wen <bin.wen at inlibro.com> Signed-off-by: Jogiraju,T. <rajujogi.t at gmail.com> Signed-off-by: Jogiraju,T. <rajujogi.t at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 23 10:44:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Mar 2019 09:44:07 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18235-70-xs3iRN6L6g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86341|0 |1 is obsolete| | --- Comment #86 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86945&action=edit Bug 18235: Add missing POD to get_facetable_fields Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 23 10:44:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Mar 2019 09:44:12 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18235-70-MVJ88xVTnC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86342|0 |1 is obsolete| | --- Comment #87 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86946&action=edit Bug 18235: DB changes Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 23 10:44:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Mar 2019 09:44:17 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18235-70-zLRIl7V2Ef@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86343|0 |1 is obsolete| | --- Comment #88 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86947&action=edit Bug 18235: Add unit tests for get_facetable_fields Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 23 10:44:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Mar 2019 09:44:22 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18235-70-Ees2sfXDjL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86344|0 |1 is obsolete| | --- Comment #89 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86948&action=edit Bug 18235: DBIx schema changes Fresh changes for SearchField, facet_order. Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 23 10:44:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Mar 2019 09:44:02 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18235-70-FkZZwIGZ8n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86340|0 |1 is obsolete| | --- Comment #85 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86944&action=edit Bug 18235: ES - Facets configurable This patch adds a new section 'Facet order' in the Biblio tab of the 'Search engine configuration' admin page of the Elastic mappings. The idea is to let the librarians define the facet to display and order them as their needs. The ergonomic is not perfect and I am open to any suggestions. Test plan: Move up and down the field list to order the facets Hide/show some facets Rebuild index At the OPAC and the staff interface you should see the changes on the search result page. Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 23 10:44:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Mar 2019 09:44:27 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18235-70-uhViTlftXn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86345|0 |1 is obsolete| | --- Comment #90 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86949&action=edit Bug 18235: (QA follow-up) Fix POD Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 23 10:44:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Mar 2019 09:44:32 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18235-70-x4KC6IIt9Q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86346|0 |1 is obsolete| | --- Comment #91 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86950&action=edit Bug 18235: (QA follow-up) Add missing filters Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 23 10:44:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Mar 2019 09:44:37 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18235-70-1Or5l1edEC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86347|0 |1 is obsolete| | --- Comment #92 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86951&action=edit Bug 18235: Update facet_order default value in atomic update Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 23 10:44:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Mar 2019 09:44:42 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18235-70-3PfUM4DQnT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86348|0 |1 is obsolete| | --- Comment #93 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86952&action=edit Bug 18235: Do not call get_facetable_fields excessively Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 23 10:44:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Mar 2019 09:44:47 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18235-70-UN7n5pMENl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86349|0 |1 is obsolete| | --- Comment #94 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86953&action=edit Bug 18235: (QA follow-up) Make db update idempotent Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 23 10:44:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Mar 2019 09:44:53 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18235-70-fG2vB6etf4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86350|0 |1 is obsolete| | --- Comment #95 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86954&action=edit Bug 18235: (QA follow-up) Series facet name after rebase Bug 19575 changes many field names so "se" facet field became "title-series" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 23 10:44:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Mar 2019 09:44:58 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18235-70-qMxOMFp1yc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #96 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86955&action=edit Bug 18253: (QA follow-up) Restore facet_order for su-geo field in mappings file Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 23 10:46:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Mar 2019 09:46:07 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18235-70-kS0brDk7kJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86955|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 23 10:45:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Mar 2019 09:45:48 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18235-70-ezUJHznWg1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #97 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86956&action=edit Bug 18235: (QA follow-up) Restore facet_order for su-geo field in mappings file Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 23 10:46:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Mar 2019 09:46:43 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18235-70-XwdFAcjAcN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA --- Comment #98 from Josef Moravec <josef.moravec at gmail.com> --- Rebased and adapted to bug 22495. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 24 06:06:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Mar 2019 05:06:57 +0000 Subject: [Koha-bugs] [Bug 22570] New: csrf auth token failure in displaying patron image in SCO Message-ID: <bug-22570-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22570 Bug ID: 22570 Summary: csrf auth token failure in displaying patron image in SCO Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Self checkout Assignee: koha-bugs at lists.koha-community.org Reporter: rajujogi.t at gmail.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- CSRF token seems to be not generated correctly and the URL to display patron image in Self Check-out screen is failing with Authentication error. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 24 13:18:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Mar 2019 12:18:11 +0000 Subject: [Koha-bugs] [Bug 22565] Partially receiving order and adding internal note on invoice updates note on every order on the system In-Reply-To: <bug-22565-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22565-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22565-70-4S3Uib7pMc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22565 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |blocker CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Data loss bug - updating severity. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 24 14:44:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Mar 2019 13:44:10 +0000 Subject: [Koha-bugs] [Bug 22505] Add column configuration to patron list table In-Reply-To: <bug-22505-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22505-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22505-70-gbchgzVt50@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22505 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Mar 24 14:44:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Mar 2019 13:44:13 +0000 Subject: [Koha-bugs] [Bug 22505] Add column configuration to patron list table In-Reply-To: <bug-22505-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22505-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22505-70-yDRUuw2CnX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22505 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86686|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 86957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86957&action=edit Bug 22505: Add column configuration to patron list table Test plan: 1. Create a list of patrons 2. Add some patrons to this list 3. Go to this patron list (/cgi-bin/koha/patron_lists/list.pl?patron_list_id=XXX) 4. Verify that you can show/hide all columns except the one containing the checkbox 5. Verify that you can export the table data using the Export menu 6. Go to admin/columns_settings.pl, and verify that the configuration works for table 'patron-list-table' Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Jose-Mario Monteiro-Santos <jose-mario.monteiro-santos at inLibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Mar 24 14:47:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Mar 2019 13:47:25 +0000 Subject: [Koha-bugs] [Bug 22525] Navigation arrows on the bottom of Cataloging search pages In-Reply-To: <bug-22525-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22525-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22525-70-kSGHMkuT87@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22525 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 24 14:47:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Mar 2019 13:47:28 +0000 Subject: [Koha-bugs] [Bug 22525] Navigation arrows on the bottom of Cataloging search pages In-Reply-To: <bug-22525-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22525-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22525-70-nqNhnTxKtq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22525 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86928|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 86958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86958&action=edit Bug 22525: Navigation arrows on the bottom of Cataloging search pages This patch adds a second set of pagination links to the cataloging search result page, at the bottom of the first set of search results. Also added is a horizontal rule after the second set of links in order to make it clearer that the links are for the search results above. To test, apply the patch and go to Cataloging. Perform a search which will return multiple pages of results. Confirm that the links work correctly. Signed-off-by: Marjorie <marjorie.barry-vila at collecto.ca> Signed-off-by: Bin Wen <bin.wen at inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 24 15:51:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Mar 2019 14:51:06 +0000 Subject: [Koha-bugs] [Bug 22541] Invoice adjustments should show invoice number and include link on ordered.pl and spent.pl In-Reply-To: <bug-22541-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22541-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22541-70-52lPs45vEz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22541 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Comment on attachment 86871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86871 Bug 22541: Use invoicenumber and link to invoice on spent and ordered pages Review of attachment 86871: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=22541&attachment=86871) ----------------------------------------------------------------- Hi Nick, can you take a look at the code comments please? Thx! ::: acqui/ordered.pl @@ +77,4 @@ > (quantity > quantityreceived OR quantityreceived IS NULL) > GROUP BY aqorders.biblionumber, aqorders.basketno, aqorders.ordernumber, > tleft, > + ecost_tax_included, budgetdate, entrydate, While this change appears to make sense, it seems totally unrelated to the patch. Can you please explain? Related to: http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=9d595e36a7844f99fa5d74aad418717d12eeae37 ? ::: acqui/spent.pl @@ +93,4 @@ > aqorders.invoiceid, > aqinvoices.invoicenumber, > quantityreceived, > + unitprice_tax_included, Same here as for ordered.pl ::: circ/ysearch.pl @@ +40,4 @@ > print $input->header( -type => 'text/plain', -charset => 'UTF-8' ); > > my ( $auth_status, $sessionID ) = check_cookie_auth( $input->cookie('CGISESSID'), { catalogue => '1' } ); > +warn "$auth_status is what?"; Quite sure this should not be here. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 24 15:51:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Mar 2019 14:51:18 +0000 Subject: [Koha-bugs] [Bug 22541] Invoice adjustments should show invoice number and include link on ordered.pl and spent.pl In-Reply-To: <bug-22541-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22541-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22541-70-RB0qsgxNMc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22541 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 24 16:20:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Mar 2019 15:20:18 +0000 Subject: [Koha-bugs] [Bug 22550] OPAC suggestion form doesn't require mandatory fields In-Reply-To: <bug-22550-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22550-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22550-70-6ABukM5LY5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22550 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 24 16:20:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Mar 2019 15:20:21 +0000 Subject: [Koha-bugs] [Bug 22550] OPAC suggestion form doesn't require mandatory fields In-Reply-To: <bug-22550-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22550-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22550-70-TlDlypeK8H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22550 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86943|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 86959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86959&action=edit Bug 22550: OPAC suggestion form doesn't require mandatory fields Test plan: 1. OPAC->login->your purchase suggestions->New purchase suggestion 2. Click button "Submit your suggestion" directly without filling in any field. Empty suggestion record was added succeffully. 3. Apply the patch. 4. Click button "Submit your suggestion" directly without filling in any field. The required fields should be labeled in red. (you can change the mandatory fields by preference 'OPACSuggestionMandatoryFields') Signed-off-by: Bin Wen <bin.wen at inlibro.com> Signed-off-by: Jogiraju,T. <rajujogi.t at gmail.com> Signed-off-by: Jogiraju,T. <rajujogi.t at gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 24 20:48:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Mar 2019 19:48:56 +0000 Subject: [Koha-bugs] [Bug 22571] New: Bug in Perl module "Koha::SimpleMARC::field_equals" Message-ID: <bug-22571-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22571 Bug ID: 22571 Summary: Bug in Perl module "Koha::SimpleMARC::field_equals" Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: mik at adminkuhn.ch QA Contact: testopia at bugs.koha-community.org Target Milestone: --- After successfully creating a MARC modification template in Koha menu "Tools > Batch record modification" with the following action: Add new field 041$a with value ger if 008 matches RegEx m/^...................................ger..$/ the action is run over a given record and Koha says that the bibliographic record has successfully been modified - but in fact nothing has changed, thus no new MARC 041$a is created. According to Jonathan Druart (in mailinglist "Koha", 21.03.2019 17:12) this is a bug in Perl module "Koha::SimpleMARC::field_equals". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Mar 24 22:04:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Mar 2019 21:04:34 +0000 Subject: [Koha-bugs] [Bug 22572] New: Garbled content of MARC control fields in MARC view Message-ID: <bug-22572-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22572 Bug ID: 22572 Summary: Garbled content of MARC control fields in MARC view Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: mik at adminkuhn.ch QA Contact: testopia at bugs.koha-community.org Target Milestone: --- MARC control fields consist of a fix number of positions that can contain blanks. The "MARC view" in the Koha staff client and the Koha OPAC garbles the content of such fields when the field contains more than one consecutive blank - in this case more than one consecutive blank is automatically collapsed down by the webbrowser to just one. Additionally blanks may be trimmed at the end of the content of a field. For example MARC 008 does and must consist of exactly 40 positions, thus a line like the following (as shown via webbrowser in the MARC view) is always wrong: 800422s1978 sz a 1 ger In fact the correct content of MARC 008 would look like the following 800422s1978 sz a 1 ger Or better visible, when using # instead of blanks: 800422s1978####sz########a#####1###ger## Seemingly, this applies to all MARC control fields: 006 (fix length 18 positions), 007 (variable length of up to 23 positions), 008 (fix length of 40 positions). In the database the content of these fields is correct. Maybe before showing the blank character in the "MARC view" it should be coded as HTML entity   so the webbrowser doesn't collapse it. Also it may be a good idea to show the beginning and the end of such fields because otherwise (like in the above example) it is not visible that the field does contain two positions with blanks at the end. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 03:33:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 02:33:54 +0000 Subject: [Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future In-Reply-To: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19014-70-DyMhQWXTPp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 --- Comment #23 from David Cook <dcook at prosentient.com.au> --- (In reply to Liz Rea from comment #22) > I'd like to test what's here, but don't want to waste the time if it's just > going to be superceded. If no one is going to submit a counterpatch in the > very near term, this looks like it will be an improvement and the patch > probably needs attention so as not to waste Jonathan's work. > > For the record, it still applies and I plan to test it in the very near > term, unless someone says "no here is my go at fixing this." > > Liz Thanks, Liz. I do have a counterpatch which I've been using locally for one client... I'll post it here. It's actually not too dissimilar from Jonathan's patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 04:48:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 03:48:49 +0000 Subject: [Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future In-Reply-To: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19014-70-kOfCXu26vF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 --- Comment #24 from David Cook <dcook at prosentient.com.au> --- Created attachment 86960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86960&action=edit [Alternate patch] Bug 19014: Do not try to autorenew an item too early There are a number of conditions which can cause autorenewals to send out confusing notifications to patrons far before the due date of an item. These may be exceeding the max number of renewals or checkouts, a hold on the item, etc. If an item has a hold, we don't want to tell the patron they can't autorenew the item until the earliest renewal date or the due date of the item. Test plan: 1) Check out an item with a due date 2 business days in the future 2) Place a hold on this item 3) Execute the cronjob - Without the patch, an email notification is generated for the patron - With the patch, no email notification is generated 4) Set norenewalbefore in the Circulation and Fines rules to 2 5) Execute the cronjob - Without the patch, an email notification is generated for the person - With the patch, an email notification is generated for the person 6) Set norenewalbefore in the Circulation and Fines rules to 3 7) Execute the cronjob - Without the patch, an email notification is generated for the patron - With the patch, no email notification is generated 8) Clear norenewalbefore in the Circulation and Fines rules 9) Change item due date (in database) to a date/time prior to now 10) Execute the cronjob - Without the patch, an email notification is generated for the person - With the patch, an email notification is generated for the person -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 04:49:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 03:49:38 +0000 Subject: [Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future In-Reply-To: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19014-70-1dnZDsC3yn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 --- Comment #25 from David Cook <dcook at prosentient.com.au> --- (In reply to David Cook from comment #24) > Created attachment 86960 [details] [review] > [Alternate patch] Bug 19014: Do not try to autorenew an item too early > I think this emulates the behaviour of other current LMSes/LSPs that use automatic renewal, and is what patrons would expect. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 04:50:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 03:50:41 +0000 Subject: [Koha-bugs] [Bug 20360] Auto-Renew notices send in advance of No Renewal Before period In-Reply-To: <bug-20360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20360-70-wTBClcpT0S@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20360 --- Comment #9 from David Cook <dcook at prosentient.com.au> --- Letting folks know that I have a patch for this issue at https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 04:52:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 03:52:18 +0000 Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference In-Reply-To: <bug-18532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18532-70-8HjMeidbvI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #3 from David Cook <dcook at prosentient.com.au> --- (In reply to Catherine E. Ingram from comment #2) > Please please please make it so patrons can Digest the auto renew emails. > When you get 30 or more emails in one day it is obnoxious. I get MANY > patron complaints about this. > > Is there any development on this? We could maybe help out with that > financially. > > Catherine Ingram > Cedar Park Public Library, TX I get clients complaining about their patrons complaining about this as well. I haven't done any development on this, but it's been more of a question of time than money, as I've been busy with other projects. But there might be someone else able to do it for money. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 04:59:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 03:59:53 +0000 Subject: [Koha-bugs] [Bug 15794] Add emoji picker to tag entry in OPAC In-Reply-To: <bug-15794-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15794-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15794-70-lrH1SJo4zT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 --- Comment #22 from David Cook <dcook at prosentient.com.au> --- (In reply to Owen Leonard from comment #20) > (In reply to David Cook from comment #19) > > > I think Endnote X9 uses an (old) embedded version of Internet Explorer > > A scary Halloween short story as told by David. ? I love you, Owen. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 05:01:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 04:01:10 +0000 Subject: [Koha-bugs] [Bug 15794] Add emoji picker to tag entry in OPAC In-Reply-To: <bug-15794-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15794-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15794-70-tDgaTIbvE6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15794 --- Comment #23 from David Cook <dcook at prosentient.com.au> --- (In reply to Tom?s Cohen Arazi from comment #21) > > +1 for a syspref. Or better find a more compatible emoji picker. > > Anyways, please default to enabled to keep the current behavior. Sounds good to me. For now, we've just hacked it away, but I'll keep this in the back of my mind. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 05:03:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 04:03:41 +0000 Subject: [Koha-bugs] [Bug 22497] '0' width can lead to an infinite loop. In-Reply-To: <bug-22497-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22497-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22497-70-8NQvE4bPre@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22497 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 05:04:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 04:04:54 +0000 Subject: [Koha-bugs] [Bug 22333] Replace duplicated code in CanBookBeRenewed with GetSoonestRenewDate In-Reply-To: <bug-22333-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22333-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22333-70-7tqxINOhvN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22333 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from David Cook <dcook at prosentient.com.au> --- I'm going to reset this one to needs signoff, as I think the problem is with the tests rather than the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 05:06:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 04:06:32 +0000 Subject: [Koha-bugs] [Bug 22417] Delegate background jobs execution In-Reply-To: <bug-22417-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22417-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22417-70-iPWhDBp5mr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22417 --- Comment #19 from David Cook <dcook at prosentient.com.au> --- I was thinking about this work this morning. I'm really busy at the moment, but still think this is a good thing to be working on. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 05:07:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 04:07:49 +0000 Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client In-Reply-To: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10662-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10662-70-LMXajbAfbX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662 --- Comment #265 from David Cook <dcook at prosentient.com.au> --- (In reply to Josef Moravec from comment #264) > I tested again. I have to say it is looking good. So there is the only last > thing, but big one: the tests... Awesome! I am very busy at the moment, but I'll get to the tests when I have some time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 09:30:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 08:30:09 +0000 Subject: [Koha-bugs] [Bug 22372] Add available location to Holds awaiting pickup In-Reply-To: <bug-22372-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22372-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22372-70-YPtsGLu0x4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22372 Matthias Meusburger <matthias.meusburger at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 10:02:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 09:02:36 +0000 Subject: [Koha-bugs] [Bug 22053] Ability to disable some plugins In-Reply-To: <bug-22053-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22053-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22053-70-J621Cn9ZPl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83537|0 |1 is obsolete| | --- Comment #11 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 86961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86961&action=edit Bug 22053: create unit tests Rebased-on: 2019-03-25 Alex Arnaud <alex.arnaud at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 10:02:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 09:02:47 +0000 Subject: [Koha-bugs] [Bug 22053] Ability to disable some plugins In-Reply-To: <bug-22053-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22053-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22053-70-S5NG2GHSdM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83538|0 |1 is obsolete| | --- Comment #12 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 86962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86962&action=edit Bug 22053: ability to enable/disable some plugins Test plan: - apply this patch(es), - launch an updatedabase, - go to plugins/plugins-home.pl and deal with enable/disable method - install a plugin like KitchenSink https://github.com/bywatersolutions/koha-plugin-kitchen-sink - once installed, the plugin change the background color of the staff client to orange. - disable the plugin, - background color should be set back to the original one Rebased-on: 2019-03-25 Alex Arnaud <alex.arnaud at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 10:02:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 09:02:59 +0000 Subject: [Koha-bugs] [Bug 22053] Ability to disable some plugins In-Reply-To: <bug-22053-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22053-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22053-70-UORnGkJTHs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83539|0 |1 is obsolete| | --- Comment #13 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 86963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86963&action=edit Bug 22053: update database Rebased-on: 2019-03-25 Alex Arnaud <alex.arnaud at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 10:03:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 09:03:33 +0000 Subject: [Koha-bugs] [Bug 22053] Ability to disable some plugins In-Reply-To: <bug-22053-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22053-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22053-70-wlttqD9jBz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83540|0 |1 is obsolete| | --- Comment #14 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 86964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86964&action=edit [DO NOT PUSH] Bug 22053: provide staff-global.css Rebased-on: 2019-03-25 Alex Arnaud <alex.arnaud at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 10:04:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 09:04:08 +0000 Subject: [Koha-bugs] [Bug 22053] Ability to disable some plugins In-Reply-To: <bug-22053-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22053-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22053-70-767KBNzxnw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22053 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 11:42:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 10:42:29 +0000 Subject: [Koha-bugs] [Bug 21467] Allow several receipts for a given subscription In-Reply-To: <bug-21467-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21467-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21467-70-5FENawI7wx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22565 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22565 [Bug 22565] Partially receiving order and adding internal note on invoice updates note on every order on the system -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 11:42:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 10:42:29 +0000 Subject: [Koha-bugs] [Bug 22565] Partially receiving order and adding internal note on invoice updates note on every order on the system In-Reply-To: <bug-22565-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22565-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22565-70-KoonPbuUBf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22565 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Depends on| |21467 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21467 [Bug 21467] Allow several receipts for a given subscription -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 11:43:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 10:43:12 +0000 Subject: [Koha-bugs] [Bug 22565] Partially receiving order and adding internal note on invoice updates note on every order on the system In-Reply-To: <bug-22565-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22565-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22565-70-GTabmkBwsY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22565 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 11:43:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 10:43:08 +0000 Subject: [Koha-bugs] [Bug 22565] Partially receiving order and adding internal note on invoice updates note on every order on the system In-Reply-To: <bug-22565-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22565-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22565-70-Sjrq2xdbXx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22565 --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Looks like this was caused by bug 21467. There's a really clear mistake in the Update statement that's called in that it's missing a WHERE clause... Ooops. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 11:52:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 10:52:49 +0000 Subject: [Koha-bugs] [Bug 22565] Partially receiving order and adding internal note on invoice updates note on every order on the system In-Reply-To: <bug-22565-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22565-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22565-70-xvtGci9HIW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22565 --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86965&action=edit Bug 22565: Do NOT replace all internalnote's on receive Bug 21467 introduced a but whereby setting any order_internalnote on receive one would end up setting all orders to have that internalnote. This patch adds the missing WHERE clause to the database query which was likely lost during a rebase? Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 11:53:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 10:53:25 +0000 Subject: [Koha-bugs] [Bug 22565] Partially receiving order and adding internal note on invoice updates note on every order on the system In-Reply-To: <bug-22565-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22565-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22565-70-TO5I6p0yOe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22565 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 12:06:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 11:06:09 +0000 Subject: [Koha-bugs] [Bug 22565] Partially receiving order and adding internal note on invoice updates note on every order on the system In-Reply-To: <bug-22565-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22565-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22565-70-3P01Ax75JF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22565 --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86966&action=edit Bug 22565: Add test for ModReceiveOrder regression This test checks that order_internalnote is only updated for the given orderline in ModReceiveOrder. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 12:08:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 11:08:02 +0000 Subject: [Koha-bugs] [Bug 22565] Partially receiving order and adding internal note on invoice updates note on every order on the system In-Reply-To: <bug-22565-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22565-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22565-70-iMNwcJxky8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22565 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 12:24:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 11:24:01 +0000 Subject: [Koha-bugs] [Bug 22565] Partially receiving order and adding internal note on invoice updates note on every order on the system In-Reply-To: <bug-22565-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22565-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22565-70-yBItd9QSju@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22565 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 12:25:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 11:25:38 +0000 Subject: [Koha-bugs] [Bug 22565] Partially receiving order and adding internal note on invoice updates note on every order on the system In-Reply-To: <bug-22565-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22565-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22565-70-xr89Quo6k2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22565 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86965|0 |1 is obsolete| | Attachment #86966|0 |1 is obsolete| | --- Comment #5 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86967&action=edit Bug 22565: Do NOT replace all internalnote's on receive Bug 21467 introduced a but whereby setting any order_internalnote on receive one would end up setting all orders to have that internalnote. This patch adds the missing WHERE clause to the database query which was likely lost during a rebase? Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 12:25:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 11:25:41 +0000 Subject: [Koha-bugs] [Bug 22565] Partially receiving order and adding internal note on invoice updates note on every order on the system In-Reply-To: <bug-22565-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22565-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22565-70-2OeCNT7xm0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22565 --- Comment #6 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86968&action=edit Bug 22565: Add test for ModReceiveOrder regression This test checks that order_internalnote is only updated for the given orderline in ModReceiveOrder. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 12:25:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 11:25:44 +0000 Subject: [Koha-bugs] [Bug 22565] Partially receiving order and adding internal note on invoice updates note on every order on the system In-Reply-To: <bug-22565-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22565-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22565-70-auUDxkZ30P@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22565 --- Comment #7 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 86969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86969&action=edit Bug 22565: (QA follow-up) Fix test Acquisition.t Test plan: prove t/db_dependent/Acquisition.t should pass Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 12:26:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 11:26:19 +0000 Subject: [Koha-bugs] [Bug 22565] Partially receiving order and adding internal note on invoice updates note on every order on the system In-Reply-To: <bug-22565-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22565-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22565-70-2zUFBES72h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22565 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 12:55:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 11:55:03 +0000 Subject: [Koha-bugs] [Bug 22565] Partially receiving order and adding internal note on invoice updates note on every order on the system In-Reply-To: <bug-22565-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22565-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22565-70-I5Uu47Trgz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22565 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86969|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86970&action=edit Bug 22565: (QA follow-up) Fix test Acquisition.t Test plan: prove t/db_dependent/Acquisition.t should pass Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 12:56:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 11:56:12 +0000 Subject: [Koha-bugs] [Bug 22565] Partially receiving order and adding internal note on invoice updates note on every order on the system In-Reply-To: <bug-22565-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22565-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22565-70-EmiT6jKz4B@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22565 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Thanks Josef, looking good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 12:58:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 11:58:47 +0000 Subject: [Koha-bugs] [Bug 17746] koha-reset-passwd should use Koha::Patron->set_password In-Reply-To: <bug-17746-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17746-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17746-70-3pEp2sQ545@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17746 Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|pierre-marc.thibault at inlibr | |o.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 13:14:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 12:14:16 +0000 Subject: [Koha-bugs] [Bug 22565] Partially receiving order and adding internal note on invoice updates note on every order on the system In-Reply-To: <bug-22565-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22565-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22565-70-ei4dvedTP6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22565 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #10 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 13:21:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 12:21:09 +0000 Subject: [Koha-bugs] [Bug 20954] Add ability to set syspref overrides in SIP as we can in apache In-Reply-To: <bug-20954-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20954-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20954-70-5MvlCOLKWB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20954 --- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 86971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86971&action=edit Bug 20954: (QA Follow-up) Rename syspref-overrides to syspref_overrides to maintain existing convention Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 13:56:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 12:56:35 +0000 Subject: [Koha-bugs] [Bug 22541] Invoice adjustments should show invoice number and include link on ordered.pl and spent.pl In-Reply-To: <bug-22541-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22541-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22541-70-Gw3E0k6iD3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22541 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 13:56:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 12:56:37 +0000 Subject: [Koha-bugs] [Bug 22541] Invoice adjustments should show invoice number and include link on ordered.pl and spent.pl In-Reply-To: <bug-22541-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22541-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22541-70-7ZHV45EbjR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22541 --- Comment #4 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 86972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86972&action=edit Bug 22541: Invoice adjustments should show invoice number and include link on ordered.pl and spent.pl To test: 1 - Find a vendor in acquisitions 2 - Click 'receive shipment' 3 - Create an invoice 4 - Click 'Finish receiving' 5 - Add an adjustment that encumbers while open and update adjustments 6 - Go to acqui-home and click on the ordered total for the fund with the adjustment 7 - Note the invoice adjustment shows the invoice id and does not link 8 - Add another invoice and another adjustment, but close the invoice this time 9 - Go to acqui-home and click on the spent total for the fund with the adjustment 10 - Note the invoice adjustment shows the invoice id and does not link 11 - Apply patch 12 - Visit the spent and ordered pages and note the adjustments show invoicenumber and are links 13 - prove -v t/db_dependent/Koha/Acquisition/Invoice/Adjustments.t Signed-off-by: Liz Rea <wizzyrea at gmail.com> bsoletes: 86871 - Bug 22541: Use invoicenumber and link to invoice on spent and ordered pages -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 13:59:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 12:59:37 +0000 Subject: [Koha-bugs] [Bug 21622] Incorrect GROUP BY clause in acqui/ scripts In-Reply-To: <bug-21622-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21622-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21622-70-jnDmG491f4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21622 --- Comment #17 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 86973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86973&action=edit Bug 21622: (RM follow-up) adjust for changes from bug 21282 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 14:05:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 13:05:28 +0000 Subject: [Koha-bugs] [Bug 21622] Incorrect GROUP BY clause in acqui/ scripts In-Reply-To: <bug-21622-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21622-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21622-70-q3JPAMU69t@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21622 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86973|0 |1 is obsolete| | --- Comment #18 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 86974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86974&action=edit Bug 21622: (RM follow-up) adjust for changes from bug 21282 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 14:07:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 13:07:33 +0000 Subject: [Koha-bugs] [Bug 22541] Invoice adjustments should show invoice number and include link on ordered.pl and spent.pl In-Reply-To: <bug-22541-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22541-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22541-70-akuxNUd4ck@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22541 --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Katrin Fischer from comment #3) Bad use of -a :-) Removed the ysearch change, oops Moved the spent/ordered changes to a followup on 21622 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 14:24:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 13:24:51 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX) In-Reply-To: <bug-11299-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11299-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11299-70-jN9gTku3Mm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 --- Comment #99 from Michal Denar <black23 at gmail.com> --- Hi, any progress on this bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 14:29:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 13:29:09 +0000 Subject: [Koha-bugs] [Bug 22573] New: Hold expiration date could be in the past Message-ID: <bug-22573-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22573 Bug ID: 22573 Summary: Hold expiration date could be in the past Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: sophie.meynieux at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Target Milestone: --- When an item is returned, if it was reserved, reservation status is set to W and expiration date is calculated. But if the hold already had an expiration date, this one is kept (why ?) if it is prior to the one calculated, without controlling if it is already past. This can lead to have an expiration date prior to waiting date. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 14:50:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 13:50:38 +0000 Subject: [Koha-bugs] [Bug 22571] Bug in Perl module "Koha::SimpleMARC::field_equals" In-Reply-To: <bug-22571-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22571-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22571-70-jXYc8banbe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22571 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 14:59:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 13:59:26 +0000 Subject: [Koha-bugs] [Bug 22539] Fines charged on back-dated checkin when item has been renewed In-Reply-To: <bug-22539-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22539-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22539-70-i2fKYzf3K6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22539 --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- So.. are we saying the Fine should not have been added in the first place (or rather, it should wait until the next non-closed day to start the fines accrual) Or.. are we saying the Fine should be entirely removed on return. Or.. are we saying the Fine should be set to Zero on return. And.. should we taking account of 'CalculateFinesOnReturn' syspref. The more I dug into how to fix this, the more questions it raised for me.. currently I have a patch that would reset the fine to accruing if we find a backdated return date that's prior to the lastreneweddate on the issue.. this then lets all the normal handling take place if CalculateFinesOnReturn is enabled (i.e. the fine will be updated to correctly reflect either 0 or the reduced fine amount).. but it won't be deleted entirely and it won't work for systems where CalculateFinesOnReturn is not enabled (about 10% of Koha's if HEA is to be believed!) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 15:02:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 14:02:35 +0000 Subject: [Koha-bugs] [Bug 22539] Fines charged on back-dated checkin when item has been renewed In-Reply-To: <bug-22539-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22539-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22539-70-WOguIxsxtY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22539 --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86975&action=edit Bug 22539: Reset fines for backdated returns Fixed fines should be 'unfixed' for backdated returns that specify a return date prior to the lastreneweddate. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 15:02:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 14:02:50 +0000 Subject: [Koha-bugs] [Bug 22539] Fines charged on back-dated checkin when item has been renewed In-Reply-To: <bug-22539-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22539-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22539-70-0bqCDl1QGr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22539 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 15:03:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 14:03:21 +0000 Subject: [Koha-bugs] [Bug 21646] Clean up Overdrive template In-Reply-To: <bug-21646-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21646-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21646-70-Mfwu30FkUN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21646 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81079|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 86976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86976&action=edit Bug 21646: Clean up Overdrive template This patch modifies the OverDrive administration page to correct some markup issues: - Switch to Bootstrap grid - Add missing header search box - Add missing DataTable configuration - Remove unnecessary fieldset To test you do not need to have OverDrive credentials. Apply the patch and go to System preferences -> Enhanced content -> OverDrive. In the description of the "OverDriveAuthName" preference, follow the link to manage "individual branch authnames." - Confirm that the page looks correct, including the header search box, page title, and breadcrumbs - Confirm that the page adjusts well to various browser window sizes. - Confirm that the DataTable works correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 15:03:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 14:03:52 +0000 Subject: [Koha-bugs] [Bug 22574] MarcFieldDocURL: paramether for biblio and authority fields In-Reply-To: <bug-22574-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22574-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22574-70-1FuUB6Y5yr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22574 Michal Denar <black23 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 15:04:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 14:04:07 +0000 Subject: [Koha-bugs] [Bug 22574] MarcFieldDocURL: paramether for biblio and authority fields In-Reply-To: <bug-22574-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22574-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22574-70-qUOkYp13Yc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22574 Michal Denar <black23 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 15:03:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 14:03:39 +0000 Subject: [Koha-bugs] [Bug 22574] New: MarcFieldDocURL: paramether for biblio and authority fields Message-ID: <bug-22574-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22574 Bug ID: 22574 Summary: MarcFieldDocURL: paramether for biblio and authority fields Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs at lists.koha-community.org Reporter: black23 at gmail.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- MarcFieldDocURL is really great feature. In this time we hasn't linked help for authorities, just for bibliographics records. So, if we add some kind of paramether based on type of records (like b=biblio, or a=authorities) we can link LOC or other online help for fields. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 15:09:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 14:09:31 +0000 Subject: [Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future In-Reply-To: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19014-70-FcSa7bg5SX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Andrew <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #26 from Andrew <andrew at bywatersolutions.com> --- Apologies for pushing for greater complexity on this, but I'm not sure about this approach. If we make auto-renew notices only send on the day the item is renewed or on the day it's due, we've not solved the problem so much as inverted it -- some libraries will like it, some libraries will be ambivalent, and some libraries will feel strongly that we're sending notices too late. I'd like to see this either as a switch (Send notice on status change / Send notice at due date & renewal) or as a configurable preference like a No Notice Before value. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 15:13:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 14:13:45 +0000 Subject: [Koha-bugs] [Bug 22274] Self-checkout/checkin pages not covered by OPAC CSS changes In-Reply-To: <bug-22274-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22274-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22274-70-GGyTSqU2wj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22274 Claire Gravely <claire_gravely at hotmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 15:23:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 14:23:13 +0000 Subject: [Koha-bugs] [Bug 22557] Delayed authority merges looses the user in the action_logs In-Reply-To: <bug-22557-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22557-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22557-70-6YoS1xUyLM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22557 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 15:27:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 14:27:52 +0000 Subject: [Koha-bugs] [Bug 22330] Transfer limits should be respected for placing holds in staff interface and APIs In-Reply-To: <bug-22330-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22330-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22330-70-RRTcz8rVFQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22330 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #25 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- This is proving non-trivial to backport. Kyle, do you feel this should make the cut to 18.11? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 15:34:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 14:34:56 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18736-70-itC1ZaB4eg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #182 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Pushed to 18.11.x for 18.11.04! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 15:35:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 14:35:32 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18736-70-Bl69cwkcGu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 15:35:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 14:35:44 +0000 Subject: [Koha-bugs] [Bug 22568] Replace RSS icon in the OPAC with Font Awesome In-Reply-To: <bug-22568-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22568-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22568-70-i7M9g6VwgQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22568 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 15:35:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 14:35:17 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18736-70-ZUe2o1Tjiw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 15:35:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 14:35:46 +0000 Subject: [Koha-bugs] [Bug 22568] Replace RSS icon in the OPAC with Font Awesome In-Reply-To: <bug-22568-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22568-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22568-70-Us7aD107km@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22568 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86924|0 |1 is obsolete| | --- Comment #2 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86977&action=edit Bug 22568: Replace RSS icon in the OPAC with Font Awesome This patch removes the RSS icon image (feed-icon-16x16.png) from the OPAC and replaces it with Font Awesome icons styled to match. To test, apply the patch and regenerate the OPAC CSS. View the following pages, confirming that the RSS icon looks correct: - OPAC home page (RSS news icon) - Search results page (Subscribe to search) - Recent comments - Search history - Lists -> View list Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 15:38:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 14:38:06 +0000 Subject: [Koha-bugs] [Bug 13763] Renew feature does not check for the BarcodeInputFilter option In-Reply-To: <bug-13763-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13763-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13763-70-LcQmNy4SBL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13763 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Pushed to Master |Pushed to Stable --- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 15:38:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 14:38:46 +0000 Subject: [Koha-bugs] [Bug 21683] Remove accountlines.accountno In-Reply-To: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21683-70-NNTlhOp17A@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #50 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Enhancement will not be backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 15:38:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 14:38:46 +0000 Subject: [Koha-bugs] [Bug 13795] Delete unused columns from statistics table. In-Reply-To: <bug-13795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13795-70-T10fTQLkg5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13795 Bug 13795 depends on bug 21683, which changed state. Bug 21683 Summary: Remove accountlines.accountno https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 15:38:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 14:38:47 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account types In-Reply-To: <bug-17702-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17702-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17702-70-mSkGOYWVzy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Bug 17702 depends on bug 21683, which changed state. Bug 21683 Summary: Remove accountlines.accountno https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 15:38:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 14:38:47 +0000 Subject: [Koha-bugs] [Bug 22516] accountlines.lastincrement can be removed In-Reply-To: <bug-22516-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22516-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22516-70-k23oTKTOou@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22516 Bug 22516 depends on bug 21683, which changed state. Bug 21683 Summary: Remove accountlines.accountno https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 15:40:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 14:40:36 +0000 Subject: [Koha-bugs] [Bug 20841] Barcode and description are needed in payment details In-Reply-To: <bug-20841-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20841-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20841-70-2LhTQj7pbs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20841 Jessie Zairo <jzairo at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 15:40:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 14:40:59 +0000 Subject: [Koha-bugs] [Bug 22559] OPAC Forgotten password functionality not working In-Reply-To: <bug-22559-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22559-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22559-70-fDjjGTWALO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22559 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED CC| |martin.renvoize at ptfs-europe | |.com --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- The enhancement that caused this was not backported to 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 15:40:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 14:40:50 +0000 Subject: [Koha-bugs] [Bug 20841] Barcode and description are needed in payment details In-Reply-To: <bug-20841-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20841-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20841-70-Mexij1x59y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20841 Jessie Zairo <jzairo at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 15:42:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 14:42:06 +0000 Subject: [Koha-bugs] [Bug 22561] Forgotten password requirements hint doesn't list all rules for new passwords In-Reply-To: <bug-22561-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22561-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22561-70-Q3KYyUcaoC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22561 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 15:42:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 14:42:09 +0000 Subject: [Koha-bugs] [Bug 22561] Forgotten password requirements hint doesn't list all rules for new passwords In-Reply-To: <bug-22561-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22561-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22561-70-wmtsR2Y3sF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22561 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86907|0 |1 is obsolete| | --- Comment #2 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86978&action=edit Bug 22561: Forgotten password requirements hint doesn't list all rules for new passwords This patch modifies a few templates in the OPAC so that all available information on password requirements is displayed for each case where the patron is setting a password: - If the RequireStrongPassword system preference is set, a message should appear listing strong password requirements and minimum password length. - If RequireStrongPassword is not set, the message should only ask for a minimum password length. To test, apply the patch and enable the PatronSelfRegistration and OpacResetPassword preferences. On the following pages, test with RequireStrongPassword both on and off. The correct messages should appear. - OPAC -> Forgot password. Follow the process to reset your password until you reach the step where you are entering the new password. - OPAC -> Register here. Check the password section of the registration form. - OPAC -> Log in -> Change your password. Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 15:46:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 14:46:10 +0000 Subject: [Koha-bugs] [Bug 22560] Forgotten password "token expired" page still shows boxes to reset password In-Reply-To: <bug-22560-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22560-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22560-70-aiScX1fLJM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22560 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 15:46:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 14:46:13 +0000 Subject: [Koha-bugs] [Bug 22560] Forgotten password "token expired" page still shows boxes to reset password In-Reply-To: <bug-22560-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22560-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22560-70-MXoXt8Uwkg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22560 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86909|0 |1 is obsolete| | --- Comment #2 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86979&action=edit Bug 22560: Forgotten password "token expired" page still shows boxes to reset password This patch modifies the OPAC password recovery template so that the new password entry form doesn't appear if the patron has followed an invalid or expired link. This patch also corrects the markup in the page title. To test, apply the patch and follow the process for resetting a forgotten password. When you follow the password recovery link, modify the URL so that the "uniqueKey" parameter is different. The page should show an error message. The password entry form should not appear. Check the page title in the browser's title bar. It should look correct. https://bugs.koha-community.org/show_bug.cgi?id=22520 Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 15:46:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 14:46:40 +0000 Subject: [Koha-bugs] [Bug 22533] Cannot create manual invoices In-Reply-To: <bug-22533-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22533-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22533-70-uk0LQeD9A1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22533 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14591 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 15:46:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 14:46:40 +0000 Subject: [Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines In-Reply-To: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14591-70-hrOCcYkkLC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22533 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22533 [Bug 22533] Cannot create manual invoices -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 15:47:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 14:47:08 +0000 Subject: [Koha-bugs] [Bug 22533] Cannot create manual invoices In-Reply-To: <bug-22533-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22533-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22533-70-jPKxOYj535@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22533 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |RESOLVED Resolution|--- |FIXED --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Causation bug not in 18.11.x series. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 15:47:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 14:47:40 +0000 Subject: [Koha-bugs] [Bug 22539] Fines charged on back-dated checkin when item has been renewed In-Reply-To: <bug-22539-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22539-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22539-70-ndC3wNyoM2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22539 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14591 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 15:47:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 14:47:40 +0000 Subject: [Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines In-Reply-To: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14591-70-mUcfI9uOHH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22539 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22539 [Bug 22539] Fines charged on back-dated checkin when item has been renewed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 15:50:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 14:50:25 +0000 Subject: [Koha-bugs] [Bug 22561] Forgotten password requirements hint doesn't list all rules for new passwords In-Reply-To: <bug-22561-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22561-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22561-70-M0OmV290sh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22561 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 15:50:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 14:50:27 +0000 Subject: [Koha-bugs] [Bug 22561] Forgotten password requirements hint doesn't list all rules for new passwords In-Reply-To: <bug-22561-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22561-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22561-70-BS4OeAIbLc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22561 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86978|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 15:50:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 14:50:51 +0000 Subject: [Koha-bugs] [Bug 22561] Forgotten password requirements hint doesn't list all rules for new passwords In-Reply-To: <bug-22561-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22561-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22561-70-uU5JeX2yzO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22561 --- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 86980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86980&action=edit Bug 22561: Forgotten password requirements hint doesn't list all rules for new passwords This patch modifies a few templates in the OPAC so that all available information on password requirements is displayed for each case where the patron is setting a password: - If the RequireStrongPassword system preference is set, a message should appear listing strong password requirements and minimum password length. - If RequireStrongPassword is not set, the message should only ask for a minimum password length. To test, apply the patch and enable the PatronSelfRegistration and OpacResetPassword preferences. On the following pages, test with RequireStrongPassword both on and off. The correct messages should appear. - OPAC -> Forgot password. Follow the process to reset your password until you reach the step where you are entering the new password. - OPAC -> Register here. Check the password section of the registration form. - OPAC -> Log in -> Change your password. Signed-off-by: Liz Rea <wizzyrea at gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 15:51:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 14:51:46 +0000 Subject: [Koha-bugs] [Bug 22560] Forgotten password "token expired" page still shows boxes to reset password In-Reply-To: <bug-22560-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22560-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22560-70-VYS0yE5YNV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22560 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 15:51:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 14:51:48 +0000 Subject: [Koha-bugs] [Bug 22560] Forgotten password "token expired" page still shows boxes to reset password In-Reply-To: <bug-22560-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22560-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22560-70-bJJl5kwI4q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22560 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86979|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 15:52:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 14:52:32 +0000 Subject: [Koha-bugs] [Bug 22560] Forgotten password "token expired" page still shows boxes to reset password In-Reply-To: <bug-22560-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22560-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22560-70-tBibeGneNm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22560 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86979|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 15:53:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 14:53:48 +0000 Subject: [Koha-bugs] [Bug 22560] Forgotten password "token expired" page still shows boxes to reset password In-Reply-To: <bug-22560-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22560-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22560-70-2Nmhs1qPqS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22560 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86979|0 |1 is obsolete| | --- Comment #3 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 86981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86981&action=edit Bug 22560: Forgotten password "token expired" page still shows boxes to reset password This patch modifies the OPAC password recovery template so that the new password entry form doesn't appear if the patron has followed an invalid or expired link. This patch also corrects the markup in the page title. To test, apply the patch and follow the process for resetting a forgotten password. When you follow the password recovery link, modify the URL so that the "uniqueKey" parameter is different. The page should show an error message. The password entry form should not appear. Check the page title in the browser's title bar. It should look correct. https://bugs.koha-community.org/show_bug.cgi?id=22520 Signed-off-by: Liz Rea <wizzyrea at gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 15:55:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 14:55:09 +0000 Subject: [Koha-bugs] [Bug 22560] Forgotten password "token expired" page still shows boxes to reset password In-Reply-To: <bug-22560-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22560-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22560-70-YiHtyetZ0Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22560 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 15:55:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 14:55:28 +0000 Subject: [Koha-bugs] [Bug 22561] Forgotten password requirements hint doesn't list all rules for new passwords In-Reply-To: <bug-22561-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22561-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22561-70-BDO8GUUJzR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22561 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 16:03:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 15:03:35 +0000 Subject: [Koha-bugs] [Bug 21130] Detail XSLT produces translatable HTML class In-Reply-To: <bug-21130-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21130-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21130-70-AadCS4Nr0J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21130 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable CC| |martin.renvoize at ptfs-europe | |.com --- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 16:04:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 15:04:39 +0000 Subject: [Koha-bugs] [Bug 13735] Item form in serials module doesn't respect max length set in the frameworks In-Reply-To: <bug-13735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13735-70-kMZSyqUMy1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13735 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 16:09:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 15:09:43 +0000 Subject: [Koha-bugs] [Bug 22565] Partially receiving order and adding internal note on invoice updates note on every order on the system In-Reply-To: <bug-22565-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22565-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22565-70-s3OL6cvSxh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22565 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Master |Pushed to Stable --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Pushed to 18.11.x for 18.11.04 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 16:11:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 15:11:14 +0000 Subject: [Koha-bugs] [Bug 22572] Garbled content of MARC control fields in MARC view In-Reply-To: <bug-22572-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22572-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22572-70-eMTgxXNdZE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22572 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- I'm thinking we could do something like this in the template: [% subfiel.marc_value | replace(' ', ' ') | $raw %] ...which would convert spaces to   for ALL output of MARC data, on the assumption that it doesn't hurt to do so with fields which don't rely on character position. I don't think there's a good way to change the style of the output of just those fields, since there's nothing in the framework which specifies that those tags are "positionally defined." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 16:11:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 15:11:43 +0000 Subject: [Koha-bugs] [Bug 21646] Clean up Overdrive template In-Reply-To: <bug-21646-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21646-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21646-70-a2HPuXWDO9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21646 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 16:11:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 15:11:45 +0000 Subject: [Koha-bugs] [Bug 21646] Clean up Overdrive template In-Reply-To: <bug-21646-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21646-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21646-70-QRX8mzdJ6f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21646 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86976|0 |1 is obsolete| | --- Comment #3 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86982&action=edit Bug 21646: Clean up Overdrive template This patch modifies the OverDrive administration page to correct some markup issues: - Switch to Bootstrap grid - Add missing header search box - Add missing DataTable configuration - Remove unnecessary fieldset To test you do not need to have OverDrive credentials. Apply the patch and go to System preferences -> Enhanced content -> OverDrive. In the description of the "OverDriveAuthName" preference, follow the link to manage "individual branch authnames." - Confirm that the page looks correct, including the header search box, page title, and breadcrumbs - Confirm that the page adjusts well to various browser window sizes. - Confirm that the DataTable works correctly. Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 16:13:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 15:13:30 +0000 Subject: [Koha-bugs] [Bug 18344] Allow overdue fines cap at replacement price, and cap by amount to work together In-Reply-To: <bug-18344-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18344-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18344-70-hjuLTWrv99@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18344 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 16:15:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 15:15:05 +0000 Subject: [Koha-bugs] [Bug 18344] Allow overdue fines cap at replacement price, and cap by amount to work together In-Reply-To: <bug-18344-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18344-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18344-70-PsObypd5D9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18344 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #6 from Liz Rea <wizzyrea at gmail.com> --- *sadface* doesn't apply anymore -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 16:17:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 15:17:23 +0000 Subject: [Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint In-Reply-To: <bug-22008-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22008-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22008-70-dP4pEcgZMW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #37 from Nick Clemens <nick at bywatersolutions.com> --- There is an issue here. Currently we use 0 to indicate an action performed by command line scripts (userenv is undef, default to 0) With this patch we must have a real borrowernumber. If we simply default to 'NULL' we will no longer be able to differentiate fines from command line from those of deleted users -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 16:19:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 15:19:12 +0000 Subject: [Koha-bugs] [Bug 15969] Allow use of Template Toolkit syntax for Phone Notices In-Reply-To: <bug-15969-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15969-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15969-70-Ha9jyRerST@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15969 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Patch doesn't apply CC| |wizzyrea at gmail.com --- Comment #38 from Liz Rea <wizzyrea at gmail.com> --- Patch does not apply anymore sorry :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 16:27:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 15:27:14 +0000 Subject: [Koha-bugs] [Bug 13961] Option to include patron's total amount of fines in notices In-Reply-To: <bug-13961-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13961-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13961-70-4e2NxrycL9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13961 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com --- Comment #19 from Josef Moravec <josef.moravec at gmail.com> --- In ISSUESLIP ans ISSUEQSLIP is possible to do this: [% USE Price %] # your normal issue slip content [% SET balance = borrower.account.balance %] [% IF balance > 0 %] Patron has debit of [% balance | $Price %]. [% END %] [% IF balance < 0 %] Patron has credit of [% balance | $Price %]. [% END %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 16:39:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 15:39:37 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: <bug-14570-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14570-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14570-70-nj8x0SZgiP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Benjamin Daeuber <bdaeuber at cityoffargo.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdaeuber at cityoffargo.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 16:56:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 15:56:57 +0000 Subject: [Koha-bugs] [Bug 20436] Add ability to specify itemtypes for longoverdue.pl In-Reply-To: <bug-20436-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20436-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20436-70-DaJjyHjCRj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20436 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #9 from Liz Rea <wizzyrea at gmail.com> --- Just noting that this still applies and only needs attention to QA concerns. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 16:59:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 15:59:05 +0000 Subject: [Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future In-Reply-To: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19014-70-grJmrWfcQ4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Joy Nelson <joy at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com --- Comment #27 from Joy Nelson <joy at bywatersolutions.com> --- It seems logical that the autorenewal process should only be looking at issues at the time specified for autorenewal. i.e. Only try to renew items on the 'No renewals before" duedate value. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 17:06:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 16:06:43 +0000 Subject: [Koha-bugs] [Bug 22515] OPACViewOthersSuggestions if set to Show will only show when patron has made a suggestion In-Reply-To: <bug-22515-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22515-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22515-70-fIrGZZtFBu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22515 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Version|18.05 |master Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 17:11:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 16:11:37 +0000 Subject: [Koha-bugs] [Bug 20436] Add ability to specify itemtypes for longoverdue.pl In-Reply-To: <bug-20436-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20436-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20436-70-UDPUgOlLjU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20436 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 17:11:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 16:11:40 +0000 Subject: [Koha-bugs] [Bug 20436] Add ability to specify itemtypes for longoverdue.pl In-Reply-To: <bug-20436-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20436-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20436-70-WmxsiqVoLK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20436 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #81024|0 |1 is obsolete| | --- Comment #10 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86983&action=edit Bug 20436: Add ability to specify itemtypes for longoverdue.pl It would be nice if we could filter long overdues based on itemtype the same way we can already filter based on borrower category code. Test Plan: 1) Set up a number of overdues of various itemtypes 2) Run longoverdue.pl with --list-itemtypes to show itemtypes 3) Run longoverdue.pl with --itemtype to verify it only operates on that itemtype 4) Run longoverdue.pl with multiple --itemtype switches, verify it only operates on those itemtypes 5) Run longoverdue.pl with --skip-itemtype to verify it does not operate on that itemtype 6) Run longoverdue.pl with multiple --skip-itemtype switches, verify that it does not operate on those itemtypes Signed-off-by: Jesse Maseto <jesse at bywatersolution.com> Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 17:11:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 16:11:43 +0000 Subject: [Koha-bugs] [Bug 20436] Add ability to specify itemtypes for longoverdue.pl In-Reply-To: <bug-20436-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20436-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20436-70-oLdnvnU1ip@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20436 --- Comment #11 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86984&action=edit Bug 20436: (QA follow up) - reference and typo fixes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 17:13:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 16:13:45 +0000 Subject: [Koha-bugs] [Bug 20436] Add ability to specify itemtypes for longoverdue.pl In-Reply-To: <bug-20436-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20436-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20436-70-EQBX2jA0ql@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20436 --- Comment #12 from Liz Rea <wizzyrea at gmail.com> --- Fixed commit headlines on original patch, and addressed the reference and typo concerns. I leave the last one "+=item B<--list-itemtypes> + +List itemtypes available for use by B<--itemtype> or +B<--skip-itemtype>, and exit. I am not a fan of such options. There are better ways to list them. One is already in and I would rather remove it." for Kyle. Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 17:33:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 16:33:32 +0000 Subject: [Koha-bugs] [Bug 22574] MarcFieldDocURL: paramether for biblio and authority fields In-Reply-To: <bug-22574-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22574-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22574-70-9TXXNNU5C9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22574 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |11674 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11674 [Bug 11674] Configuration for MARC field doc URLs -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 17:33:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 16:33:32 +0000 Subject: [Koha-bugs] [Bug 11674] Configuration for MARC field doc URLs In-Reply-To: <bug-11674-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11674-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11674-70-ELX7MycxOl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11674 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22574 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22574 [Bug 22574] MarcFieldDocURL: paramether for biblio and authority fields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 18:01:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 17:01:30 +0000 Subject: [Koha-bugs] [Bug 22575] New: Item type administration uses invalid error class for dialog Message-ID: <bug-22575-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22575 Bug ID: 22575 Summary: Item type administration uses invalid error class for dialog Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: System Administration Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Target Milestone: --- If you try to delete an item type which is in use, the error message you get is displayed in a white dialog with red text. This happens because the message "type" passed from the script is "error," a CSS class which is undefined. The script should send "alert" instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 18:01:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 17:01:51 +0000 Subject: [Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors) In-Reply-To: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18736-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18736-70-OL6xpXHa6j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patch introduces to release notes| |new system preference to | |govern how rounding is | |applied to values in | |acquisitions. It defaults | |to the american practice of | |rounding to the nearest | |'cent' but future options | |should become available as | |we start to understand how | |other nations round for | |accounting purposes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 18:15:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 17:15:03 +0000 Subject: [Koha-bugs] [Bug 22246] Elasticsearch indexing needs a maximum length for `__sort` fields In-Reply-To: <bug-22246-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22246-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22246-70-JKGgqKdS9g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22246 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Elasticsearch indexing |Elasticsearch indexing |needs a maximum length for |needs a maximum length for |__sort fields |`__sort` fields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 18:30:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 17:30:33 +0000 Subject: [Koha-bugs] [Bug 22539] Fines charged on back-dated checkin when item has been renewed In-Reply-To: <bug-22539-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22539-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22539-70-pr71Sf7hNE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22539 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86975|0 |1 is obsolete| | --- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 86985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86985&action=edit Bug 22539: Reset fines for backdated returns Fixed fines should be 'unfixed' for backdated returns that specify a return date prior to the lastreneweddate. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 18:30:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 17:30:47 +0000 Subject: [Koha-bugs] [Bug 22539] Fines charged on back-dated checkin when item has been renewed In-Reply-To: <bug-22539-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22539-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22539-70-fjtUTWpCxg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22539 --- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 86986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86986&action=edit Bug 22539: Always recalculate fines when a return date is specified -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 18:44:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 17:44:32 +0000 Subject: [Koha-bugs] [Bug 22576] New: OPAC password change text changes Message-ID: <bug-22576-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22576 Bug ID: 22576 Summary: OPAC password change text changes Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: wizzyrea at gmail.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- A borrower changing their password from the logged in password change functionality might see some awkward text messages, specifically: - "Return to your record" after changing the password, I propose "Return to my account" (since that's what the borrower probably wants to do). - "Submit changes" to change the password should be "Change password" just to be really clear about what is going to happen when the button is clicked. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 18:48:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 17:48:06 +0000 Subject: [Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl In-Reply-To: <bug-20837-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20837-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20837-70-J8daD24ULa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 18:49:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 17:49:55 +0000 Subject: [Koha-bugs] [Bug 22576] OPAC password change text changes In-Reply-To: <bug-22576-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22576-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22576-70-WvlAyAMQTI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22576 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 18:49:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 17:49:57 +0000 Subject: [Koha-bugs] [Bug 22576] OPAC password change text changes In-Reply-To: <bug-22576-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22576-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22576-70-4O2QpwJxK6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22576 --- Comment #1 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86987&action=edit Bug 22576: OPAC password text refresh To test: Create a patron with a username and password Make sure that password resets on OPAC are allowed in your system preferences (OpacPasswordChange -> Allow) Log into the OPAC with this patron Click the "Change password" tab Change the password - notice that the button to submit the changes says "Submit Changes" and also that the success page says "Return to my record" Apply this patch Reset the password again, noticing that the button to submit the new password says "Change password" and the success page says "Return to my account" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 18:55:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 17:55:05 +0000 Subject: [Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all In-Reply-To: <bug-20589-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20589-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20589-70-CatuMlPrPI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 18:55:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 17:55:56 +0000 Subject: [Koha-bugs] [Bug 18344] Allow overdue fines cap at replacement price, and cap by amount to work together In-Reply-To: <bug-18344-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18344-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18344-70-7UpvJ9C9j0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18344 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 18:55:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 17:55:59 +0000 Subject: [Koha-bugs] [Bug 18344] Allow overdue fines cap at replacement price, and cap by amount to work together In-Reply-To: <bug-18344-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18344-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18344-70-9zIZBZHyFQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18344 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65493|0 |1 is obsolete| | --- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 86988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86988&action=edit Bug 18344 - Allow overdue fines cap at replacement price, and cap by amount to work together There is no reason that a library shouldn't be able to use the monetary fines cap and the replacement price cap at the same time. The code is written in such a way that they already work harmoniously. We have librarians who wish to use both so they can set a high cap of $10.00 but also use the replacement price cap so that a $20.00 book would only get a fine of $10.00, but a $5.00 paperback will only get a fine of $5.00 Test Plan: 1) Apply this patch 2) Create a rule with a fines cap of $10, *and* a cap at replacement price, and a daily fine of $1 3) Create two items, one with a replacement price of $5 and one with a replacement price of $15 4) Check out these items to a patron, backdate the checkouts so they are already overdue by a couple months 5) Check the items in ( make sure calc fine at checkin is enabled for you ) 6) Note the one item has a fine of $5 and the other has a fine of $10! Signed-off-by: David Kuhn <techservspec at gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 18:56:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 17:56:10 +0000 Subject: [Koha-bugs] [Bug 18344] Allow overdue fines cap at replacement price, and cap by amount to work together In-Reply-To: <bug-18344-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18344-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18344-70-8YaWwMWF9Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18344 --- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 86989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86989&action=edit Bug 18344 - Unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 19:04:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 18:04:05 +0000 Subject: [Koha-bugs] [Bug 20457] Overdue and pre-overdue cronjobs not skipping phone notices In-Reply-To: <bug-20457-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20457-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20457-70-PQWOwkOGB7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20457 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73141|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 86990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86990&action=edit Bug 20457: Overdue and pre-overdue cronjobs not skipping phone notices The overdue and pre-overdue cron scripts are not skipping the generation of phone notices. This causes many phone notices to be created that will always be left at 'pending' as the Talking Tech outbound script creates its own phone notices and puts them in the message queue. Test Plan: 1) Enable Talking Tech 2) Enable predue and overdue notice phone transports for a patron 3) Generate overdues and predues, notice phone notices are generated 4) Apply the patch 5) Repeat steps 2-3 6) Note phone notices are not generated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 19:04:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 18:04:02 +0000 Subject: [Koha-bugs] [Bug 20457] Overdue and pre-overdue cronjobs not skipping phone notices In-Reply-To: <bug-20457-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20457-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20457-70-Oo9nVR2tK4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20457 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 19:09:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 18:09:19 +0000 Subject: [Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl In-Reply-To: <bug-20837-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20837-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20837-70-EuqYi2enHE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |wizzyrea at gmail.com --- Comment #4 from Liz Rea <wizzyrea at gmail.com> --- Hi Nick, Terribly sorry, the patches don't seem to apply: CONFLICT (content): Merge conflict in t/db_dependent/Holds.t error: Failed to merge in the changes. - This was a conflict on number of tests, easy to resolve so I did that, HOWEVER have also got... Applying: Bug 20837: Use ReservesControlBranch to determine holdability of items error: sha1 information is lacking or useless (C4/Reserves.pm). error: could not build fake ancestor A new patch set would be nice. :) Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 19:24:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 18:24:30 +0000 Subject: [Koha-bugs] [Bug 22578] New: calendar options for every other week closings Message-ID: <bug-22578-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22578 Bug ID: 22578 Summary: calendar options for every other week closings Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: bwsdonna at gmail.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- There are libraries that are closed one day every other week (such as every other Saturday) and currently each closed day has to entered manually. It would be helpful to have the option to set a holiday that occurs biweekly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 19:24:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 18:24:24 +0000 Subject: [Koha-bugs] [Bug 22577] New: Cronjobs (and other scripts) should be attributed to a 'real' user Message-ID: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 Bug ID: 22577 Summary: Cronjobs (and other scripts) should be attributed to a 'real' user Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Currently the userenv for cronjobs is set to '0' for the userid. This user does not exist and breaks/prevents foreign key constraints from working as expected. We should really add a hard coded default user to identify such actions. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 19:24:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 18:24:41 +0000 Subject: [Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint In-Reply-To: <bug-22008-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22008-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22008-70-DGjaEcOjc9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22577 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 19:24:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 18:24:48 +0000 Subject: [Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user In-Reply-To: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22577-70-XPywQ3CAmo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22008 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 19:24:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 18:24:48 +0000 Subject: [Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint In-Reply-To: <bug-22008-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22008-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22008-70-9KLFKQN5II@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22577 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 19:24:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 18:24:54 +0000 Subject: [Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user In-Reply-To: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22577-70-XtFQUpYzRG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 19:24:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 18:24:41 +0000 Subject: [Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user In-Reply-To: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22577-70-ZhEEfSP2CU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22008 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 [Bug 22008] accountlines.manager_id is missing a foreign key constraint -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 20:05:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 19:05:41 +0000 Subject: [Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user In-Reply-To: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22577-70-5VX1Sln3yL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86992&action=edit Bug 22577: Add 'cron' system user -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 20:05:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 19:05:44 +0000 Subject: [Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user In-Reply-To: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22577-70-MKrN5rFedx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86993&action=edit Bug 22577: Set 'cron' user for fines job -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 20:05:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 19:05:39 +0000 Subject: [Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user In-Reply-To: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22577-70-yW4qaC4FgC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86991&action=edit Bug 22577: Prevent deletion of system users -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 20:33:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 19:33:42 +0000 Subject: [Koha-bugs] [Bug 17661] Differences in field ending (whitespace, punctuation) cause duplicate facets In-Reply-To: <bug-17661-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17661-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17661-70-WbSZn89CUl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17661 --- Comment #4 from Sarah Cornell <sbcornell at cityofportsmouth.com> --- Correcting this display problem would really improve user experience. Currently users need to discover by trial and error that the two entries "Brunkus, Denise," and Brunkus, Denise." run the same search. Our librarians assume they run different searches, and it makes them distrust the catalog. This affects all facets that come from MARC: authors, series, places, topics. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 20:34:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 19:34:32 +0000 Subject: [Koha-bugs] [Bug 15544] Zebra facets must be managed from the intranet In-Reply-To: <bug-15544-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15544-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15544-70-gpHRMPTbub@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15544 Sarah Cornell <sbcornell at cityofportsmouth.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sbcornell at cityofportsmouth. | |com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 20:36:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 19:36:21 +0000 Subject: [Koha-bugs] [Bug 15544] Zebra facets must be managed from the intranet In-Reply-To: <bug-15544-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15544-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15544-70-3qE7PpoOdg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15544 Sarah Cornell <sbcornell at cityofportsmouth.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|sbcornell at cityofportsmouth. | |com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 20:39:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 19:39:05 +0000 Subject: [Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint In-Reply-To: <bug-22008-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22008-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22008-70-Q2M8TzcLSX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #38 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 86994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86994&action=edit Bug 22008: Fix failing tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 20:41:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 19:41:31 +0000 Subject: [Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint In-Reply-To: <bug-22008-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22008-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22008-70-6n33KwajGA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86994|0 |1 is obsolete| | --- Comment #39 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 86995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86995&action=edit Bug 22008: Fix failing tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 20:41:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 19:41:57 +0000 Subject: [Koha-bugs] [Bug 22453] TestBuilder should generate now() using the current timezone In-Reply-To: <bug-22453-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22453-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22453-70-0rtf0RakXi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22453 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #6 from Liz Rea <wizzyrea at gmail.com> --- Hi, I'm wondering if this manifests when the datetime of your virtualbox is out of sync with the current date, such as what could happen on a laptop if you sleep the box while devbox is running? This was debian 9, ftr: kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Koha/Patrons.t t/db_dependent/Koha/Patrons.t .. 26/33 # Failed test 'With BorrowerLogs and TrackLastPatronActivity we should not spam the logs' # at t/db_dependent/Koha/Patrons.t line 1421. # got: '2' # expected: '1' # Looks like you failed 1 test of 4. t/db_dependent/Koha/Patrons.t .. 30/33 # Failed test 'BorrowersLog tests' # at t/db_dependent/Koha/Patrons.t line 1422. t/db_dependent/Koha/Patrons.t .. 32/33 # Looks like you failed 1 test of 33. t/db_dependent/Koha/Patrons.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/33 subtests Test Summary Report ------------------- t/db_dependent/Koha/Patrons.t (Wstat: 256 Tests: 33 Failed: 1) Failed test: 30 Non-zero exit status: 1 Files=1, Tests=33, 47 wallclock secs ( 0.10 usr 0.00 sys + 36.20 cusr 8.52 csys = 44.82 CPU) Result: FAIL kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ date Thu Mar 21 19:54:59 GMT 2019 ^^ that is very much not today's date. A Vagrant reload might fix the tests when they're failing? Maybe your ubuntu box has a bad date and your debian one didn't? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 20:45:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 19:45:35 +0000 Subject: [Koha-bugs] [Bug 22453] TestBuilder should generate now() using the current timezone In-Reply-To: <bug-22453-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22453-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22453-70-M7MYlnVEpi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22453 --- Comment #7 from Liz Rea <wizzyrea at gmail.com> --- That must be it - I just did a "vagrant reload" on my debian 9, and without the patch I got: kohadev-koha at kohadevbox:/home/vagrant/kohaclone$ prove t/db_dependent/Koha/Patrons.t t/db_dependent/Koha/Patrons.t .. ok All tests successful. Files=1, Tests=33, 46 wallclock secs ( 0.09 usr 0.01 sys + 33.53 cusr 8.94 csys = 42.57 CPU) Result: PASS Maybe we don't need to patch it at all? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 20:45:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 19:45:56 +0000 Subject: [Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user In-Reply-To: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22577-70-imBKMtTbXS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #4 from Nick Clemens <nick at bywatersolutions.com> --- t/lib/Mocks.pm:sub mock_userenv should probably be set to default to 0 instead of 51 - or create it's own user? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 20:47:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 19:47:01 +0000 Subject: [Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user In-Reply-To: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22577-70-S5ubRORuS1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |blocker --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- raising severity as some crons are currently broken by this (longoverdue for example) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 20:57:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 19:57:47 +0000 Subject: [Koha-bugs] [Bug 22410] Software error while adding order on a MARC file record without an author In-Reply-To: <bug-22410-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22410-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22410-70-6REkUNXdDj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22410 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #4 from Liz Rea <wizzyrea at gmail.com> --- Hi Pierre, Are you cataloguing in UNIMARC? Could you provide some UNIMARC import files for us to test with, if so? Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 21:01:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 20:01:31 +0000 Subject: [Koha-bugs] [Bug 22358] Add POD to Koha::SharedContent In-Reply-To: <bug-22358-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22358-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22358-70-TVjwa9hck2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22358 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 21:01:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 20:01:34 +0000 Subject: [Koha-bugs] [Bug 22358] Add POD to Koha::SharedContent In-Reply-To: <bug-22358-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22358-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22358-70-cnvCOGHH3a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22358 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86571|0 |1 is obsolete| | --- Comment #3 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 86996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86996&action=edit Bug 22358: Add POD to Koha::SharedContent Signed-off-by: Liz Rea <wizzyrea at gmail.com> QA tool checks out, perldoc Koha/SharedContent.pm looks ok to me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Mar 25 21:03:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Mar 2019 20:03:14 +0000 Subject: [Koha-bugs] [Bug 17661] Differences in field ending (whitespace, punctuation) cause duplicate facets In-Reply-To: <bug-17661-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17661-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17661-70-S5v019EsyD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17661 Tami Wilkerson <twilkerson at critfc.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |twilkerson at critfc.org --- Comment #5 from Tami Wilkerson <twilkerson at critfc.org> --- (In reply to Sarah Cornell from comment #4) > Correcting this display problem would really improve user experience. > > Currently users need to discover by trial and error that the two entries > "Brunkus, Denise," and Brunkus, Denise." run the same search. Our > librarians assume they run different searches, and it makes them distrust > the catalog. > > This affects all facets that come from MARC: authors, series, places, topics. I completely agree with Sarah. The duplication pushes other authors, series, places, topics, etc. further down the list and users have to click "Show Me More" to see them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 01:06:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 00:06:45 +0000 Subject: [Koha-bugs] [Bug 21976] koha-reset-passwd does not deal with password restrictions In-Reply-To: <bug-21976-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21976-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21976-70-2PpldT6EtE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21976 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com Status|Needs Signoff |Patch doesn't apply --- Comment #6 from Liz Rea <wizzyrea at gmail.com> --- Hi, This patch fails to apply with Auto-merging misc/admin/set_password.pl Auto-merging debian/scripts/koha-reset-passwd CONFLICT (content): Merge conflict in debian/scripts/koha-reset-passwd Sorry :( Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 01:14:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 00:14:40 +0000 Subject: [Koha-bugs] [Bug 21716] Item Search hangs when \ exists in MARC fields In-Reply-To: <bug-21716-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21716-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21716-70-eIJgAPHEYz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21716 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com Status|Needs Signoff |Failed QA --- Comment #11 from Liz Rea <wizzyrea at gmail.com> --- Hi, I've just checked this patch, and it seems that the hang doesn't occur on current master, but it is broken again without the patch (infinite processing). Is this still needed? It appears to me that it isn't. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 01:49:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 00:49:23 +0000 Subject: [Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future In-Reply-To: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19014-70-h5IoZGfdCJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 --- Comment #28 from David Cook <dcook at prosentient.com.au> --- (In reply to Andrew from comment #26) > Apologies for pushing for greater complexity on this, but I'm not sure about > this approach. If we make auto-renew notices only send on the day the item > is renewed or on the day it's due, we've not solved the problem so much as > inverted it -- some libraries will like it, some libraries will be > ambivalent, and some libraries will feel strongly that we're sending notices > too late. > > I'd like to see this either as a switch (Send notice on status change / Send > notice at due date & renewal) or as a configurable preference like a No > Notice Before value. Andrew, I don't understand what you're trying to say here. The auto-renew notices will be queued up when the renewal is processed. I don't see any other logical way of handling the notices. Are you meaning you want to change the timing of the renewals (and thus the notices associated with them)? If so, my patch allows you to use the "No Renewal Before" rule in Circulation and Fines Rules to specify that no renewal can happen until N days before the due date. My local public library (which doesn't use Koha) seems to have set "4 days before the due date", which means that if there are no restrictions on the item, it will autorenew 4 days before the due date and it will promptly send me an email notification to indicate this. I can't really see any other logical way of it working? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 01:50:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 00:50:20 +0000 Subject: [Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future In-Reply-To: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19014-70-tAxN5DmRXT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 --- Comment #29 from David Cook <dcook at prosentient.com.au> --- (In reply to Joy Nelson from comment #27) > It seems logical that the autorenewal process should only be looking at > issues at the time specified for autorenewal. i.e. Only try to renew items > on the 'No renewals before" duedate value. I agree. I think it's both logical and it seems to be the way that other library systems do it as well, which suggests to me that is what patrons would expect as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 02:12:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 01:12:54 +0000 Subject: [Koha-bugs] [Bug 22579] New: Add syspref to toggle expanding Actions dropdown menu in Z39.50 search to decrease clicks Message-ID: <bug-22579-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579 Bug ID: 22579 Summary: Add syspref to toggle expanding Actions dropdown menu in Z39.50 search to decrease clicks Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: hayleymapley at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Target Milestone: --- An enhancement included in master from Bug 15952 moved the Actions in the Cataloging Z39.50 search results into a dropdown. We have a library who uses the Card preview and MARC preview from this search to quickly ascertain whether a record is the one they were looking for, and would like to decrease the number of clicks it takes to execute this option from 2 to 1. We propose to allow the user to switch these options from a dropdown to expanded links within the action column, toggleable via a system preference. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 02:13:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 01:13:10 +0000 Subject: [Koha-bugs] [Bug 22579] Add syspref to toggle expanding Actions dropdown menu in Z39.50 search to decrease clicks In-Reply-To: <bug-22579-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22579-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22579-70-rGbVhvqWLG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |hayleymapley at catalyst.net.n |ity.org |z Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 02:33:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 01:33:51 +0000 Subject: [Koha-bugs] [Bug 22579] Add syspref to toggle expanding Actions dropdown menu in Z39.50 search to decrease clicks In-Reply-To: <bug-22579-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22579-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22579-70-EGgEebsbNL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 02:33:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 01:33:54 +0000 Subject: [Koha-bugs] [Bug 22579] Add syspref to toggle expanding Actions dropdown menu in Z39.50 search to decrease clicks In-Reply-To: <bug-22579-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22579-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22579-70-DDGfRmvNIP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579 --- Comment #1 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Created attachment 86997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86997&action=edit Bug 22579: Add syspref to toggle dropdown/links in Z39.50 search results This patch reduces the number of clicks to use 'Card preview' functionality without removing the work done to condense the three links into a menu in Bug 19939 which is displayed by default (and when the syspref is disabled). Test plan: 1) Apply the patch 2) In Cataloging click the New from Z39.50/SRU button and search for a term that will produce results 3) In the results window, note that the actions column contains a dropdown for each row which contains three links. 4) Change the Replacez3950CatalogingActionMenuWithLinks to 'Do' 5) Complete step 2 again, and instead note that the actions column now contains three links, Card preview, MARC preview, Import 6) Verify that each of the links work as expected 7) Sign off! Sponsored-by: Horowhenua Library Trust -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 02:34:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 01:34:56 +0000 Subject: [Koha-bugs] [Bug 22579] Add syspref to toggle expanding Actions dropdown menu in Z39.50 search to decrease clicks In-Reply-To: <bug-22579-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22579-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22579-70-3gr3TqIx76@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexbuckley at catalyst.net.nz | |, | |hayleymapley at catalyst.net.n | |z -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 04:21:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 03:21:19 +0000 Subject: [Koha-bugs] [Bug 22414] Discrepancy in serials-edit.pl url when receiving serial subscription issues In-Reply-To: <bug-22414-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22414-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22414-70-bxm5x7Ar7M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22414 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z Status|NEW |In Discussion --- Comment #1 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- I've traced this back to 2009 where these statuses were first added to the code base. It looks like these numbers can affect the status of the subscriptions on the receive page, but it also looks like these numbers could be done without. I'd be keen to get a second opinion on this though! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 05:11:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 04:11:26 +0000 Subject: [Koha-bugs] [Bug 22570] csrf auth token failure in displaying patron image in SCO In-Reply-To: <bug-22570-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22570-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22570-70-ib3MahQkhV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22570 --- Comment #1 from T. Jogi Raju <rajujogi.t at gmail.com> --- Patron image is not been displayed when the web-based self checkout system is configured to automatically login with this staff login. When a real staff user login credentials are used to initiate the SCO it is working correctly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 05:55:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 04:55:09 +0000 Subject: [Koha-bugs] [Bug 22555] Serials page doesn't show subscriptions on page load In-Reply-To: <bug-22555-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22555-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22555-70-M8uqAztzo8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22555 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion --- Comment #2 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- (In reply to Katrin Fischer from comment #1) > There are libraries with tons of subscriptions so it makes a lot of sense to > me to start with a search as showing them all might potentially slow down > the page quite a bit. If you look at other places in Koha (invoices, > baskets) it would be quite unusual too. I see. It struck me as something that isn't particularly first-time-user friendly. Clicking on the subscriptions page, I would expect to see my subscriptions. I'm wondering if you think it would be a good idea to implement a paginator to control the amount of entries on the page, or even easier, add a message that indicates that there are subscriptions and how to see them, or that there are not yet any subscriptions. Adding a friendly message could be done to the other places that you mentioned also. Let me know what you think! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 07:08:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 06:08:19 +0000 Subject: [Koha-bugs] [Bug 22539] Fines charged on back-dated checkin when item has been renewed In-Reply-To: <bug-22539-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22539-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22539-70-dxmWj7nDin@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22539 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 07:08:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 06:08:28 +0000 Subject: [Koha-bugs] [Bug 22539] Fines charged on back-dated checkin when item has been renewed In-Reply-To: <bug-22539-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22539-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22539-70-dYlvgZoGpG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22539 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 07:10:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 06:10:23 +0000 Subject: [Koha-bugs] [Bug 22539] Fines charged on back-dated checkin when item has been renewed In-Reply-To: <bug-22539-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22539-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22539-70-gnbHfBkFsv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22539 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86985|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86998&action=edit Bug 22539: Reset fines for backdated returns Fixed fines should be 'unfixed' for backdated returns that specify a return date prior to the lastreneweddate. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 07:10:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 06:10:26 +0000 Subject: [Koha-bugs] [Bug 22539] Fines charged on back-dated checkin when item has been renewed In-Reply-To: <bug-22539-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22539-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22539-70-nduckrDQBQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22539 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86986|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 86999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86999&action=edit Bug 22539: Always recalculate fines when a return date is specified Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 07:11:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 06:11:00 +0000 Subject: [Koha-bugs] [Bug 22539] Fines charged on back-dated checkin when item has been renewed In-Reply-To: <bug-22539-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22539-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22539-70-KxUJRpKJF1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22539 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 07:12:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 06:12:30 +0000 Subject: [Koha-bugs] [Bug 22539] Fines charged on back-dated checkin when item has been renewed In-Reply-To: <bug-22539-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22539-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22539-70-cX9fiqtuB9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22539 --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- This will need some tests before QA.. I'll try to get to those today as we seem to be happy with this path. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 07:23:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 06:23:51 +0000 Subject: [Koha-bugs] [Bug 16251] Material type is not correctly set for Rancor 008 widget In-Reply-To: <bug-16251-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16251-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16251-70-tuISF1VXnu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16251 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #8 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.11.x for 17.11.17 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 07:24:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 06:24:58 +0000 Subject: [Koha-bugs] [Bug 22476] MarkLostItemsAsReturned has wrong defaults for new installs In-Reply-To: <bug-22476-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22476-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22476-70-uKK4vKO4Vb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22476 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED CC| |fridolin.somers at biblibre.co | |m Resolution|--- |FIXED --- Comment #8 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Depends on Bug 19287 not in 17.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 07:27:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 06:27:01 +0000 Subject: [Koha-bugs] [Bug 22429] Infinite loop in patron card printing In-Reply-To: <bug-22429-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22429-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22429-70-TYORg3tJTi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22429 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #18 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.11.x for 17.11.17 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 07:27:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 06:27:48 +0000 Subject: [Koha-bugs] [Bug 22360] On order information missing in OPAC normal display In-Reply-To: <bug-22360-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22360-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22360-70-RNxQ0S3TYC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22360 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to Stable |RESOLVED CC| |fridolin.somers at biblibre.co | |m Resolution|--- |FIXED --- Comment #16 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Depends on Bug 21205 not in 17.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 07:28:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 06:28:46 +0000 Subject: [Koha-bugs] [Bug 22386] Importing using attributes as matchpoint broken In-Reply-To: <bug-22386-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22386-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22386-70-NbWkHXM30O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22386 --- Comment #13 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Depends on Bug 19936 not in 17.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 07:31:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 06:31:17 +0000 Subject: [Koha-bugs] [Bug 21560] Optimize ODS exports In-Reply-To: <bug-21560-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21560-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21560-70-EYMvHL98lj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21560 --- Comment #35 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 17.11.x for 17.11.17 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 07:33:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 06:33:17 +0000 Subject: [Koha-bugs] [Bug 22555] Serials page doesn't show subscriptions on page load In-Reply-To: <bug-22555-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22555-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22555-70-5sOJFJiQ8n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22555 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Maybe we need to get some more opinions on this. The page is already paginated, although I think not server side, but client side (might be mistaken). It hasn't come up in training as an issue. The most common workflow in serials I think is receiving an issue. I think libraries would still use the search in this case, as it's unlikely that the subscription would be on the first page. But I am not working daily with the module - training and explaining is different. Getting a few more views would not hurt. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 08:12:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 07:12:46 +0000 Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation' (bug 11373) In-Reply-To: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22359-70-n4f2geRKat@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- I totally agree here, I just haven't had a moment to comment before now.. I'd really like this functionality cleaned up.. I think I even put a mockup screenshot in the original bug if I remember correctly with how I perceived it looking. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 08:17:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 07:17:50 +0000 Subject: [Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok in checkin response In-Reply-To: <bug-22076-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22076-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22076-70-CF1MhTySZn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076 --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87001&action=edit Bug 22076: Fix the same situation for lost items Signed-off-by: Geeta Halley <ghalley at roundrocktexas.gov> Rescued-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 08:17:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 07:17:53 +0000 Subject: [Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok in checkin response In-Reply-To: <bug-22076-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22076-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22076-70-aQyEc26OSi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076 --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87002&action=edit Bug 22076: Add missing whitespace on if statments Rescued-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 08:17:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 07:17:46 +0000 Subject: [Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok in checkin response In-Reply-To: <bug-22076-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22076-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22076-70-X2il3Ptzux@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076 --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87000&action=edit Bug 22076: SIP checkin for withdrawn item returns ok in checkin response If an item that is withdrawn is checked in via SIP2, Koha does not process the checkin, but still indicates the checkin succeeded via the ok flag in the checkin response message. To recreate: 1 - Mark an item withdrawn 2 - Set up sip server: https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup 3 - Set 'BlockReturnOfWithdrawnItems' to block 4 - Use the sip_cli_emulator to checkin the withdrawn item 5 - There is no error in the checkin Test Plan: 1) Mark an item withdrawn 2) Set BlockReturnOfWithdrawnItems to block 3) Use the sip cli emulator to checkin the withdrawn item 4) Note the response begins with 101 5) Apply this patch 6) Restart all the things ( including SIP server ) 7) Repeat checkin with sip cli emulator 8) Note the checkin now beings with 100 Signed-off-by: Geeta Halley <ghalley at roundrocktexas.gov> Rescued-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 08:19:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 07:19:23 +0000 Subject: [Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok in checkin response In-Reply-To: <bug-22076-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22076-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22076-70-po6XT9TsRL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87001|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87004&action=edit Bug 22076: Fix the same situation for lost items Signed-off-by: Geeta Halley <ghalley at roundrocktexas.gov> Rescued-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 08:19:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 07:19:26 +0000 Subject: [Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok in checkin response In-Reply-To: <bug-22076-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22076-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22076-70-nFFI8kLwg5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87002|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87005&action=edit Bug 22076: Add missing whitespace on if statments Rescued-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 08:19:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 07:19:44 +0000 Subject: [Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok in checkin response In-Reply-To: <bug-22076-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22076-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22076-70-AgSm6fJWBd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83739|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 08:19:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 07:19:19 +0000 Subject: [Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok in checkin response In-Reply-To: <bug-22076-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22076-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22076-70-MS9E3KHxwP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87000|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87003&action=edit Bug 22076: SIP checkin for withdrawn item returns ok in checkin response If an item that is withdrawn is checked in via SIP2, Koha does not process the checkin, but still indicates the checkin succeeded via the ok flag in the checkin response message. To recreate: 1 - Mark an item withdrawn 2 - Set up sip server: https://wiki.koha-community.org/wiki/Koha_SIP2_server_setup 3 - Set 'BlockReturnOfWithdrawnItems' to block 4 - Use the sip_cli_emulator to checkin the withdrawn item 5 - There is no error in the checkin Test Plan: 1) Mark an item withdrawn 2) Set BlockReturnOfWithdrawnItems to block 3) Use the sip cli emulator to checkin the withdrawn item 4) Note the response begins with 101 5) Apply this patch 6) Restart all the things ( including SIP server ) 7) Repeat checkin with sip cli emulator 8) Note the checkin now beings with 100 Signed-off-by: Geeta Halley <ghalley at roundrocktexas.gov> Rescued-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 08:19:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 07:19:55 +0000 Subject: [Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok in checkin response In-Reply-To: <bug-22076-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22076-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22076-70-OSjdTCU4mi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83738|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 08:20:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 07:20:04 +0000 Subject: [Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok in checkin response In-Reply-To: <bug-22076-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22076-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22076-70-7iDy7GsY1v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83737|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 08:20:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 07:20:22 +0000 Subject: [Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok in checkin response In-Reply-To: <bug-22076-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22076-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22076-70-y3GtAHDtxW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA --- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Patches rescued and QA run done.. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 08:20:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 07:20:27 +0000 Subject: [Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok in checkin response In-Reply-To: <bug-22076-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22076-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22076-70-bpOis00AXc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 08:50:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 07:50:17 +0000 Subject: [Koha-bugs] [Bug 22432] Star ratings plugin replacement missing from a couple pages In-Reply-To: <bug-22432-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22432-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22432-70-oDHeWV4yjr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22432 --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Any movement on this one Owen? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 08:57:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 07:57:34 +0000 Subject: [Koha-bugs] [Bug 21974] cxn_pool must be configurable In-Reply-To: <bug-21974-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21974-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21974-70-1SX9qNgfMn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21974 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86052|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87006&action=edit Bug 21974: Make Elasticsearch connection settings configurable Default settings are appended in get_elasticsearch_params so that there's a central place for them. Defaults can be overridden in koha-conf.xml. Test plan: 1. Verify that searches still work with the patch applied. 2. Verify that search fails after adding the following under <elasticsearch> in koha-conf.xml: <cxn_pool>Static</cxn_pool> 3. Verify that search fails after adding the following under <elasticsearch> in koha-conf.xml: <cxn_pool>FOO</cxn_pool> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 08:59:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 07:59:05 +0000 Subject: [Koha-bugs] [Bug 21974] cxn_pool must be configurable In-Reply-To: <bug-21974-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21974-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21974-70-C8lp7SUjl9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21974 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- OK, So I'm yielding a bit on the tests requirement here as there's not a precedent I can find for testing config checks. Thanks for the documentation and my apologies for not getting back to this sooner. Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 08:59:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 07:59:12 +0000 Subject: [Koha-bugs] [Bug 21974] cxn_pool must be configurable In-Reply-To: <bug-21974-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21974-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21974-70-CBaGEsfSsQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21974 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 09:00:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 08:00:10 +0000 Subject: [Koha-bugs] [Bug 22473] Use koha-conf.xml modification time as cache key In-Reply-To: <bug-22473-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22473-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22473-70-kFfBakZ42K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22473 --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Not forgotten about this, it's just in a long queue to take a look.. Thanks for all the alternations to look at Jonathan.. I hope to come back to this soon and take a proper look :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 09:24:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 08:24:15 +0000 Subject: [Koha-bugs] [Bug 22545] C4::Matcher::get_matches aggressive isbn and issn search don't give any results with ES In-Reply-To: <bug-22545-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22545-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22545-70-n4YlctYRNa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22545 Joonas Kylm?l? <joonas.kylmala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at helsinki.fi --- Comment #3 from Joonas Kylm?l? <joonas.kylmala at helsinki.fi> --- How does the fix work? The patch commit doesn't explain it, could you add a short description there, too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 09:54:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 08:54:12 +0000 Subject: [Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user In-Reply-To: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22577-70-ig53ehK8GX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 09:54:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 08:54:23 +0000 Subject: [Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user In-Reply-To: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22577-70-CJ23MpEzTt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com, | |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 10:36:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 09:36:25 +0000 Subject: [Koha-bugs] [Bug 22580] New: Remove misc/cronjobs/delete_expired_opac_registrations.pl Message-ID: <bug-22580-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22580 Bug ID: 22580 Summary: Remove misc/cronjobs/delete_expired_opac_registrations.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- misc/cronjobs/delete_expired_opac_registrations.pl states within it that the script is deprecated in favour of using clean_database.pl with a flag. The deprecation message was added back in October 2014.. I think sufficient time has passed such that we can remove this script now ;) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 10:36:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 09:36:31 +0000 Subject: [Koha-bugs] [Bug 22580] Remove misc/cronjobs/delete_expired_opac_registrations.pl In-Reply-To: <bug-22580-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22580-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22580-70-qLE7CZUzWq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22580 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 10:36:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 09:36:45 +0000 Subject: [Koha-bugs] [Bug 22580] Remove misc/cronjobs/delete_expired_opac_registrations.pl In-Reply-To: <bug-22580-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22580-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22580-70-H7eL24wSjm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22580 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22465 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22465 [Bug 22465] PatronSelfRegistrationExpireTemporaryAccountsDelay should recommend cleanup_database.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 10:36:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 09:36:45 +0000 Subject: [Koha-bugs] [Bug 22465] PatronSelfRegistrationExpireTemporaryAccountsDelay should recommend cleanup_database.pl In-Reply-To: <bug-22465-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22465-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22465-70-TmqPEkTzFP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22465 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22580 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22580 [Bug 22580] Remove misc/cronjobs/delete_expired_opac_registrations.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 10:37:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 09:37:13 +0000 Subject: [Koha-bugs] [Bug 22465] PatronSelfRegistrationExpireTemporaryAccountsDelay should recommend cleanup_database.pl In-Reply-To: <bug-22465-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22465-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22465-70-sBPr7F5z49@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22465 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Patch complexity|--- |String patch Keywords| |Academy, Manual -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 10:37:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 09:37:31 +0000 Subject: [Koha-bugs] [Bug 22580] Remove misc/cronjobs/delete_expired_opac_registrations.pl In-Reply-To: <bug-22580-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22580-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22580-70-mPD6W8iERh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22580 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 10:37:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 09:37:45 +0000 Subject: [Koha-bugs] [Bug 22580] Remove misc/cronjobs/delete_expired_opac_registrations.pl In-Reply-To: <bug-22580-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22580-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22580-70-vwl5aW0RPw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22580 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 11:12:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 10:12:40 +0000 Subject: [Koha-bugs] [Bug 22545] C4::Matcher::get_matches aggressive isbn and issn search don't give any results with ES In-Reply-To: <bug-22545-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22545-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22545-70-3RynB59iFO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22545 --- Comment #4 from Johanna R?is? <johanna.raisa at koha-suomi.fi> --- (In reply to Joonas Kylm?l? from comment #3) > How does the fix work? The patch commit doesn't explain it, could you add a > short description there, too. When using Elastic the get_matches uses the same search terms as query parser since the Elastic CCL support is lacking. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 11:18:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 10:18:12 +0000 Subject: [Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user In-Reply-To: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22577-70-jBkFea6SSx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87007&action=edit Bug 22577: Update cronjobs to set userenv -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 11:42:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 10:42:42 +0000 Subject: [Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user In-Reply-To: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22577-70-hcfQcPK2CK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Question time.. I've added a 'CRON' user account at borrowernumber '-1' and updated all the relevant scripts in /misc/cronjobs. I'm now wondering about the other scripts in that directory.. they're a mishmash of things.. should we have a 'command line' user to assign these to or use the cron user again? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 12:17:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 11:17:36 +0000 Subject: [Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user In-Reply-To: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22577-70-FyHtFuwJ8j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87008&action=edit Bug 22577: Retrospectively assign '-1' for cronscripts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 12:19:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 11:19:55 +0000 Subject: [Koha-bugs] [Bug 22422] improve item location display with class "shelvingloc" In-Reply-To: <bug-22422-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22422-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22422-70-5sJd9hr3gz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22422 --- Comment #8 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- (In reply to Lucas Gass from comment #7) > cant rebase for 18.05.x > > deleted by us: ../../../css/src/staff-global.scss > ../../../../../opac-tmpl/bootstrap/css/src/opac.scss Ah indeed, use of SCSS is new. I think its not worth creating a rebased patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 12:34:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 11:34:12 +0000 Subject: [Koha-bugs] [Bug 21280] Unify MARC editor in biblios and authorities In-Reply-To: <bug-21280-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21280-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21280-70-PyvlsQa51R@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21280 --- Comment #11 from Josef Moravec <josef.moravec at gmail.com> --- Comment on attachment 85517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=85517 Bug 21280: Move MARC editor code to a common class Review of attachment 85517: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=21280&attachment=85517) ----------------------------------------------------------------- I just quickly go through code and found only small issues, great job Ere. ::: Koha/MarcEditor.pm @@ +22,5 @@ > +use Modern::Perl; > + > +use Readonly; > + > +use C4::ClassSource; use Koha::ClassSources instead @@ +31,5 @@ > +use base qw(Class::Accessor); > + > +# Constants to refer to the standard editor types > +Readonly our $EDITOR_BIBLIO => 'biblio'; > +Readonly our $EDITOR_AUTHORITY => 'authority'; use constant instead of Readonly. See https://wiki.koha-community.org/wiki/Coding_Guidelines#PERL25:_Read_only_variables @@ +347,5 @@ > + } > + elsif ( $self->{tags}->{$tag}->{$subfield}->{authorised_value} eq "cn_source" ) { > + push @authorised_values, ""; > + > + my $class_sources = GetClassSources(); Could be easily replaced by Koha::ClassSource->search @@ +377,5 @@ > + $query = "SELECT authorised_value,lib > + FROM authorised_values > + WHERE category=? ORDER BY lib"; > + } > + my $authorised_values_sth = C4::Context->dbh->prepare( $query ); It would be better to use Koha::AuthorizedValues module -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 12:40:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 11:40:54 +0000 Subject: [Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior In-Reply-To: <bug-10577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10577-70-Jlc2wb6zn6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86565|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87009&action=edit Bug 10577: Improve semantics of GetBudgetPeriod() Remove the option to pass zero to this function in order to get "the" active budget. This was a problem in three ways: - Koha doesn't require that there be only one active budget at a time, so the concept of "the" active budget doesn't make sense. - Having the single parameter be either an ID or a flag based on its value is poor function design. - No callers of GetBudgetPeriod() were actually using this modality. This patch also improves the DB-dependent tests for budgets by - wrapping the test in a transaction - counting budgets correctly To test: [1] Apply the patch. [2] Verify that prove -v t/db_dependent/Budgets.t passes [3] Verify in the staff interface that: - the budget hierarchy displays correctly - you can add and modify a budget Signed-off-by: Galen Charlton <gmc at esilibrary.com> Rescued-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 12:40:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 11:40:58 +0000 Subject: [Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior In-Reply-To: <bug-10577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10577-70-MKgg4lnNVY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86566|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87010&action=edit Bug 10577: (QA follow-up) Remove bad call signature Whilst working through this patch for signoff I found a case where the calling signature of GetBudgetPeriod was incorrect. I removed the superflous passed parameter in this followup Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 12:41:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 11:41:17 +0000 Subject: [Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior In-Reply-To: <bug-10577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10577-70-OU8aJju0Qy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 12:44:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 11:44:08 +0000 Subject: [Koha-bugs] [Bug 21280] Unify MARC editor in biblios and authorities In-Reply-To: <bug-21280-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21280-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21280-70-I6lBOPithQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21280 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |josef.moravec at gmail.com --- Comment #12 from Josef Moravec <josef.moravec at gmail.com> --- There is conflict with master, probably because of bug 22399 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 12:44:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 11:44:53 +0000 Subject: [Koha-bugs] [Bug 22574] MarcFieldDocURL: paramether for biblio and authority fields In-Reply-To: <bug-22574-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22574-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22574-70-xAT7dmquJz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22574 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Josef Moravec <josef.moravec at gmail.com> --- Bug 21280 does add exactly this in its patchset *** This bug has been marked as a duplicate of bug 21280 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 12:44:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 11:44:53 +0000 Subject: [Koha-bugs] [Bug 21280] Unify MARC editor in biblios and authorities In-Reply-To: <bug-21280-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21280-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21280-70-B9q2bXZrKS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21280 --- Comment #13 from Josef Moravec <josef.moravec at gmail.com> --- *** Bug 22574 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 12:47:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 11:47:25 +0000 Subject: [Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user In-Reply-To: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22577-70-sKPGfqG5SN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- (In reply to Nick Clemens from comment #4) > t/lib/Mocks.pm:sub mock_userenv should probably be set to default to 0 > instead of 51 - or create it's own user? As much as I agree to this.. as there's a user added in that slot by default for Jenkins in the default data we're OK without it being done here.. perhaps we could add that to a further bug which works towards having the ability to run tests without that default data? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 12:50:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 11:50:01 +0000 Subject: [Koha-bugs] [Bug 22579] Add syspref to toggle expanding Actions dropdown menu in Z39.50 search to decrease clicks In-Reply-To: <bug-22579-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22579-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22579-70-EdoLyYqQ1h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579 --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Do they know they can click anywhere in the row to trigger the menu? A system preference seems like overkill to me, but that's certainly an opinion informed by a different workflow. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 13:14:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 12:14:52 +0000 Subject: [Koha-bugs] [Bug 22581] New: Include the Verovio library to show musical incipits Message-ID: <bug-22581-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581 Bug ID: 22581 Summary: Include the Verovio library to show musical incipits Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: verolencinas at yahoo.com.ar QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Marc tag 031 includes the musical incipit (first compases of a melody) as code. Musical catalogs such as MUSCAT (http://muscat-project.org) use this information to display the incipit in musical code and to allow to search for incipits. Since it is possible to export MUSCAT data and import it in Koha, for music libraries it would be very helpful to display the incipit in the OPAC. MUSCAT uses an external libray, Verovio (https://www.verovio.org/) to do this. If the tag 031 is present, Verovio should be used to show the incipit in musical notation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 13:17:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 12:17:03 +0000 Subject: [Koha-bugs] [Bug 22545] C4::Matcher::get_matches aggressive isbn and issn search don't give any results with ES In-Reply-To: <bug-22545-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22545-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22545-70-IMaJnGff3p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22545 --- Comment #5 from Joonas Kylm?l? <joonas.kylmala at helsinki.fi> --- What about fixing this part of Elasticsearch CCL support in Koha? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 13:18:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 12:18:09 +0000 Subject: [Koha-bugs] [Bug 22432] Star ratings plugin replacement missing from a couple pages In-Reply-To: <bug-22432-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22432-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22432-70-JeTytqjfRS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22432 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 13:18:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 12:18:13 +0000 Subject: [Koha-bugs] [Bug 22432] Star ratings plugin replacement missing from a couple pages In-Reply-To: <bug-22432-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22432-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22432-70-7fQFzT1mCE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22432 --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 87011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87011&action=edit Bug 22432: Star ratings plugin replacement missing from a couple pages This patch modifies two templates to conform to the change to the start ratings plugin: Overdrive search results and RecordedBooks search results. On the Overdrive page, the star ratings are now correctly displayed using the new plugin. On the RecordedBooks page, star ratings code has been removed because it is unused. RecordedBooks doesn't provide ratings information in their API. To test you need credentials for both Overdrive and RecordedBooks. Apply the patch and enable both services. - In the OPAC, perform a search that will return results from Overdrive and RecordedBooks. - Open the search results for each of those services. - On the Overdrive search results page, star ratings should appear correctly (in read-only mode). - On the RecordedBooks page everything should look the same. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 13:19:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 12:19:25 +0000 Subject: [Koha-bugs] [Bug 22410] Software error while adding order on a MARC file record without an author In-Reply-To: <bug-22410-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22410-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22410-70-r4r60Fnngj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22410 --- Comment #5 from Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> --- (In reply to Liz Rea from comment #4) > Are you cataloguing in UNIMARC? Could you provide some UNIMARC import files > for us to test with, if so? If I check my preference marcflavour which is set at MARC21, I don't think so, but either way I will add my test file so I can have more feedback if it doesn't work, which I don't hope. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 13:23:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 12:23:53 +0000 Subject: [Koha-bugs] [Bug 22410] Software error while adding order on a MARC file record without an author In-Reply-To: <bug-22410-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22410-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22410-70-9kKjLXmRfx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22410 --- Comment #6 from Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> --- Created attachment 87012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87012&action=edit MARC file test To use since test plan is not always reproductible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 13:39:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 12:39:13 +0000 Subject: [Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user In-Reply-To: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22577-70-d0bjshe3pM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87013&action=edit Bug 22577: Less typing is good! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 13:40:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 12:40:27 +0000 Subject: [Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user In-Reply-To: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22577-70-sYLkFeLaWd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- I'm working on a branch here: https://github.com/PTFS-Europe/koha/compare/master...PTFS-Europe:bug_22577 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 13:41:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 12:41:32 +0000 Subject: [Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user In-Reply-To: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22577-70-YneOIiQB9e@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 13:44:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 12:44:06 +0000 Subject: [Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user In-Reply-To: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22577-70-7eGMb6XtN0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87013|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87014&action=edit Bug 22577: Less typing is good! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 13:47:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 12:47:34 +0000 Subject: [Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user In-Reply-To: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22577-70-2Mi8xztLd4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87014|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87015&action=edit Bug 22577: Less typing is good! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 14:15:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 13:15:38 +0000 Subject: [Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future In-Reply-To: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19014-70-6NlqfI7fpf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 --- Comment #30 from Andrew <andrew at bywatersolutions.com> --- Sorry, David, my response was based on some misunderstanding of your patch. I thought you were tying the notice solely to the due date. If it's sending renewal failure notices at the renewal attempt as determined by the No Renewal Before value, then that seems reasonable. Libraries that want to give their patrons some padding between renewal attempt and due date can set No Renewal Before to a larger number. Thanks for clarifying! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 14:56:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 13:56:59 +0000 Subject: [Koha-bugs] [Bug 11969] Show patrons star rating on their reading history In-Reply-To: <bug-11969-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11969-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11969-70-C9Co6DKrsD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11969 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 14:57:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 13:57:02 +0000 Subject: [Koha-bugs] [Bug 11969] Show patrons star rating on their reading history In-Reply-To: <bug-11969-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11969-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11969-70-fQvwWXHqNV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11969 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86047|0 |1 is obsolete| | --- Comment #6 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 87016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87016&action=edit Bug 11969: Show patrons star rating on their reading history This patch adds display of a user's ratings to their reading history in the OPAC. Also changed: Removed obsolete "border" attribute from the template, and removed obsolete JavaScript include from opac-results.tt To test, apply the patch and rebuild the OPAC CSS. OpacStarRatings should be set to all (results and details). - Log in to the OPAC as a user with a reading history and titles in that history which have ratings. - Under the "your reading history" tab, your ratings should show under rated titles with the date of the rating. - Test also with OpacStarRatings set to a value other than "all." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 15:01:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 14:01:28 +0000 Subject: [Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user In-Reply-To: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22577-70-YYGUfbX4Uj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 --- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87017&action=edit Bug 22577: Add test for Koha::Cron base class -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 15:03:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 14:03:46 +0000 Subject: [Koha-bugs] [Bug 11969] Show patrons star rating on their reading history In-Reply-To: <bug-11969-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11969-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11969-70-bC8nfHZZ9C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11969 --- Comment #7 from Owen Leonard <oleonard at myacpl.org> --- (In reply to Katrin Fischer from comment #5) > > +for(qw(OPACAmazonCoverImages GoogleJackets SyndeticsCoverImages)) { # BakerTaylorEnabled handled above > > Why this change? I accidentally included in my patch some unrelated changes I was testing. I've redone the patch without those changes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 15:21:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 14:21:38 +0000 Subject: [Koha-bugs] [Bug 22518] accounttype 'O' is still referred to but is never set In-Reply-To: <bug-22518-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22518-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22518-70-Smuxjx1ROu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22518 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://wiki.koha-community | |.org/wiki/Hard_Coded_Values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 15:21:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 14:21:41 +0000 Subject: [Koha-bugs] [Bug 22575] Item type administration uses invalid error class for dialog In-Reply-To: <bug-22575-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22575-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22575-70-JcOfV6Dqfi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22575 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 15:21:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 14:21:45 +0000 Subject: [Koha-bugs] [Bug 22575] Item type administration uses invalid error class for dialog In-Reply-To: <bug-22575-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22575-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22575-70-a8NYIwtjGI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22575 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 87018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87018&action=edit Bug 22575: Item type administration uses invalid error class for dialog This patch modifies the item types administration script so that it passes a valid message type to the template, where the type is used as a CSS class. "Error" is a nonexistent dialog class. It should be "alert." To test, apply the patch and go to Administration -> Item types. - Try to delete an item type which is in use. The style of the error dialog should be correct. - Try to add an item type using a code which already exists. The error should look correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 15:23:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 14:23:40 +0000 Subject: [Koha-bugs] [Bug 22518] accounttype 'O' is still referred to but is never set In-Reply-To: <bug-22518-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22518-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22518-70-oknBE4Qb9W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22518 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86671|0 |1 is obsolete| | --- Comment #3 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 87019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87019&action=edit Bug 22518: Remove references to 'O' accounttype I went back over 12 years to and still only found "FIXME: What are these accounttypes" concerning the 'O' type and I couldn't find anywhere where it was being set. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 15:23:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 14:23:44 +0000 Subject: [Koha-bugs] [Bug 22518] accounttype 'O' is still referred to but is never set In-Reply-To: <bug-22518-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22518-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22518-70-T3uYZdwAeg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22518 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86672|0 |1 is obsolete| | --- Comment #4 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 87020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87020&action=edit Bug 22518: Add database update 'just in case' All cases I could find where 'O' was referenced it was referenced alongside 'FU'.. as such I've written this DB update to case any last cases of 'O' and update them to 'FU' "just in case" Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 15:23:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 14:23:56 +0000 Subject: [Koha-bugs] [Bug 22518] accounttype 'O' is still referred to but is never set In-Reply-To: <bug-22518-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22518-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22518-70-7TSEEYUPwX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22518 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 15:42:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 14:42:26 +0000 Subject: [Koha-bugs] [Bug 20747] Allow LocalHoldsPriority to fill by hierarchical groups system rather than individual library In-Reply-To: <bug-20747-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20747-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20747-70-Tjy8hy0Zwb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 Joy Nelson <joy at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joy at bywatersolutions.com --- Comment #3 from Joy Nelson <joy at bywatersolutions.com> --- Lisette- The way that Bug 22284 would work includes functionality for 'non local/group' holds to be filled after all the local holds have been satisfied. joy > I may have it wrong, but it looks like bug 22284 would prevent the holds > from going out of the groups? That isn't what we would want, as we still > want our items to be able to go out of the district once holds for our > district have been filled. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 15:52:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 14:52:15 +0000 Subject: [Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl In-Reply-To: <bug-20837-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20837-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20837-70-hqHwhrj1vC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75684|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 87021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87021&action=edit Bug 20837: Unit tests To test: prove -v t/db_dependent/Holds.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 15:52:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 14:52:18 +0000 Subject: [Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl In-Reply-To: <bug-20837-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20837-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20837-70-7QOpwo9Dkk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75685|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 87022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87022&action=edit Bug 20837: Use ReservesControlBranch to determine holdability of items To test: 1 - Set a default holds plicy for an item type as 'from home library' 2 - Set CircControl to 'logged in library' 3 - Log in as staff from a library without the rule set 4 - Note you can set holds for patrons of any library on items of type above 5 - Toggle ReservesControlBranch and note that nothing changes 6 - Toggle CircControl and note some combinations don't allow holds 7 - Apply patch 8 - Toggle ReservesControlBranch and note that holdability is affected 9 - Toggle CircControl and note holdability does not change 10 - Read the note on admin/smartrules.pl and confirm it makes sense -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 15:52:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 14:52:21 +0000 Subject: [Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl In-Reply-To: <bug-20837-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20837-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20837-70-wTkN6TPjbw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 --- Comment #7 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 87023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87023&action=edit Bug 20837: Unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 15:52:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 14:52:24 +0000 Subject: [Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl In-Reply-To: <bug-20837-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20837-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20837-70-OYX4pgJTc7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 --- Comment #8 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 87024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87024&action=edit Bug 20837: Alter IsAvailableForItemForItemLevelRequest to use ReservesControlBranch Also use Koha objects for fetching itemtype info To test: Same test plan as above, ensure item availability is affected the the system preference prove t/db_dependent/Holds/DisallowHoldIfItemsAvailable.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 15:52:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 14:52:11 +0000 Subject: [Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl In-Reply-To: <bug-20837-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20837-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20837-70-nbQMvjev6b@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 15:53:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 14:53:26 +0000 Subject: [Koha-bugs] [Bug 22539] Fines charged on back-dated checkin when item has been renewed In-Reply-To: <bug-22539-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22539-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22539-70-QqxH1W4QoV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22539 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=12144 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 15:53:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 14:53:26 +0000 Subject: [Koha-bugs] [Bug 12144] Book drop mode mode erasing fine when CalculateFinesOnReturn is enabled In-Reply-To: <bug-12144-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12144-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12144-70-FHIsENqSYX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12144 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22539 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 15:54:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 14:54:26 +0000 Subject: [Koha-bugs] [Bug 20837] CanItemBeReserved should follow ReservesControlBranch and not CircControl In-Reply-To: <bug-20837-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20837-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20837-70-Z9p9oCNJ57@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20837 --- Comment #9 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 87025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87025&action=edit Bug 20837: (follow-up) Rename variables -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 16:02:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 15:02:38 +0000 Subject: [Koha-bugs] [Bug 22581] Include the Verovio library to show musical incipits In-Reply-To: <bug-22581-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22581-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22581-70-zc39mkdgc5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- A while back I was looking into something similar.. `Plaine and Easie` rings a bell - https://www.iaml.info/plaine-easie-code -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 16:06:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 15:06:07 +0000 Subject: [Koha-bugs] [Bug 22581] Include the Verovio library to show musical incipits In-Reply-To: <bug-22581-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22581-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22581-70-fKSIVMjCDJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581 --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Cool, looks like Verovio support it :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 16:23:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 15:23:57 +0000 Subject: [Koha-bugs] [Bug 18950] Elasticsearch - Add password access for admin functions In-Reply-To: <bug-18950-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18950-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18950-70-iUgKToPAvM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18950 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED Assignee|nick at bywatersolutions.com |koha-bugs at lists.koha-commun | |ity.org --- Comment #4 from Nick Clemens <nick at bywatersolutions.com> --- Not working on this one -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 16:40:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 15:40:11 +0000 Subject: [Koha-bugs] [Bug 22413] Elasticsearch - Index title is lost after sorting In-Reply-To: <bug-22413-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22413-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22413-70-1xNWNOCHwJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22413 sandboxes at biblibre.com <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sandboxes at biblibre.com --- Comment #6 from sandboxes at biblibre.com <sandboxes at biblibre.com> --- Patch tested with a sandbox, by Marjorie <marjorie.barry-vila at collecto.ca> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 16:40:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 15:40:25 +0000 Subject: [Koha-bugs] [Bug 22413] Elasticsearch - Index title is lost after sorting In-Reply-To: <bug-22413-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22413-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22413-70-H0zT6mj7HQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22413 sandboxes at biblibre.com <sandboxes at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86059|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 16:40:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 15:40:34 +0000 Subject: [Koha-bugs] [Bug 22413] Elasticsearch - Index title is lost after sorting In-Reply-To: <bug-22413-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22413-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22413-70-31U6DpTXYS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22413 --- Comment #7 from sandboxes at biblibre.com <sandboxes at biblibre.com> --- Created attachment 87026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87026&action=edit Bug 22413: Improve query string and desc creation for Elasticsearch Test plan: After each of the following steps, verify that the results and query description looks ok. 1. Do a simple keyword query 2. Change sort order 3. Click a facet 4. Do an advanced search with title and author 5. Change sort order 6. Click a facet Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Marjorie <marjorie.barry-vila at collecto.ca> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 16:57:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 15:57:58 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20447-70-8MdFyk7fRM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #111 from Michal Denar <black23 at gmail.com> --- Ere, please rebase on master. Thank you. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 17:00:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 16:00:08 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20447-70-SFKg1KJ5Qo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #112 from Michal Denar <black23 at gmail.com> --- Auto-merging Koha/Schema/Result/Branch.pm CONFLICT (content): Merge conflict in Koha/Schema/Result/Branch.pm Auto-merging Koha/Schema/Result/Biblio.pm CONFLICT (content): Merge conflict in Koha/Schema/Result/Biblio.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 20447: DBIX schema changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 17:13:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 16:13:54 +0000 Subject: [Koha-bugs] [Bug 22127] Update dateaccessioned value builder In-Reply-To: <bug-22127-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22127-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22127-70-7yvsvzumUy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22127 Michal Denar <black23 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 17:13:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 16:13:57 +0000 Subject: [Koha-bugs] [Bug 22127] Update dateaccessioned value builder In-Reply-To: <bug-22127-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22127-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22127-70-yPcrYakqwS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22127 Michal Denar <black23 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83885|0 |1 is obsolete| | --- Comment #2 from Michal Denar <black23 at gmail.com> --- Created attachment 87027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87027&action=edit Bug 22127: Update date accessioned plugin - remove unused routine Test plan: 1) Apply the patch 2) Have set dateaccessioned plugin to an item subfield (it is set on 952$d by default) 3) Confirm the functionality of this plugin is same as before patch Signed-off-by: Michal Denar <black23 at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 17:18:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 16:18:29 +0000 Subject: [Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user In-Reply-To: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22577-70-rYe19Q8UIg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 17:33:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 16:33:39 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20447-70-L8aiMzYimp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 --- Comment #113 from Josef Moravec <josef.moravec at gmail.com> --- (In reply to Michal Denar from comment #112) > Auto-merging Koha/Schema/Result/Branch.pm > CONFLICT (content): Merge conflict in Koha/Schema/Result/Branch.pm > Auto-merging Koha/Schema/Result/Biblio.pm > CONFLICT (content): Merge conflict in Koha/Schema/Result/Biblio.pm > error: Failed to merge in the changes. > Patch failed at 0001 Bug 20447: DBIX schema changes Mike, these files could be easily regeneretad, just omit this one patch and run command 'dbic' on kohadevbox -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 17:37:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 16:37:23 +0000 Subject: [Koha-bugs] [Bug 22127] Update dateaccessioned value builder In-Reply-To: <bug-22127-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22127-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22127-70-9duP5TrzBC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22127 --- Comment #3 from Josef Moravec <josef.moravec at gmail.com> --- > Signed-off-by: Michal Denar <black23 at gmail.com> Thanks for testing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 17:49:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 16:49:24 +0000 Subject: [Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user In-Reply-To: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22577-70-6bqeBDBXfh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86991|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 17:49:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 16:49:33 +0000 Subject: [Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user In-Reply-To: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22577-70-aG6Pm4SeU1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86992|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 17:49:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 16:49:41 +0000 Subject: [Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user In-Reply-To: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22577-70-jQortffxBF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86993|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 17:49:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 16:49:49 +0000 Subject: [Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user In-Reply-To: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22577-70-LEkwTEwnlx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87007|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 17:49:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 16:49:57 +0000 Subject: [Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user In-Reply-To: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22577-70-I7lRnyZbYf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87008|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 17:50:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 16:50:05 +0000 Subject: [Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user In-Reply-To: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22577-70-S3qr7Ajig6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87015|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 17:50:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 16:50:13 +0000 Subject: [Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user In-Reply-To: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22577-70-5wfbYRTEqv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87017|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 17:50:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 16:50:44 +0000 Subject: [Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user In-Reply-To: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22577-70-RLldVWyzO9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 --- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87028&action=edit Bug 22577: Prevent deletion of system users -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 17:50:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 16:50:47 +0000 Subject: [Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user In-Reply-To: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22577-70-VpUnvHnPH7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 --- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87029&action=edit Bug 22577: Add 'cron' system user -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 17:50:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 16:50:50 +0000 Subject: [Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user In-Reply-To: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22577-70-mVIqTQKudj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 --- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87030&action=edit Bug 22577: Set 'cron' user for cron scripts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 17:50:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 16:50:56 +0000 Subject: [Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user In-Reply-To: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22577-70-pdMpcJZoKw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 --- Comment #19 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87032&action=edit Bug 22577: Retrospectively assign '-1' for cronscripts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 17:50:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 16:50:53 +0000 Subject: [Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user In-Reply-To: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22577-70-4GRM7W7hpp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 --- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87031&action=edit Bug 22577: Add test for Koha::Cron base class -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 17:55:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 16:55:52 +0000 Subject: [Koha-bugs] [Bug 20324] Fund Warnings do not occur when importing records from a staged file In-Reply-To: <bug-20324-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20324-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20324-70-YRYPKGINiy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20324 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 17:59:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 16:59:12 +0000 Subject: [Koha-bugs] [Bug 17661] Differences in field ending (whitespace, punctuation) cause duplicate facets In-Reply-To: <bug-17661-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17661-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17661-70-R6l0cueSE2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17661 Jess Tobin <lara005 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lara005 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 17:59:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 16:59:44 +0000 Subject: [Koha-bugs] [Bug 22199] Planning Budget does not retain values In-Reply-To: <bug-22199-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22199-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22199-70-cKjgX7201S@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22199 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 18:31:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 17:31:27 +0000 Subject: [Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user In-Reply-To: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22577-70-Y7PBLdgWzc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 19:06:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 18:06:52 +0000 Subject: [Koha-bugs] [Bug 21534] ElasticSearch - Dash is considered like a boolean operator In-Reply-To: <bug-21534-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21534-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21534-70-8RxXdzSttW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21534 --- Comment #2 from Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> --- (In reply to Nick Clemens from comment #1) > I tested this on master and cannot recreate. > > According to the docs: > https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl- > query-string-query.html > > Hyphen is considered a boolean 'not' operator > > in testing though it seems to work as long as there is no space Hi Nick, Do you think my bug is a duplicate of https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 Regards Marjorie -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 19:16:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 18:16:30 +0000 Subject: [Koha-bugs] [Bug 22582] New: Authority plugin link broken by Bug 22045 Message-ID: <bug-22582-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22582 Bug ID: 22582 Summary: Authority plugin link broken by Bug 22045 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: major Priority: P5 - low Component: Cataloging Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Depends on: 22045 Target Milestone: --- The plugin link in the basic MARC editor has an onclick attribute which an element-relative selector to correctly run. The change in HTML structure made by Bug 22045 broke this selection. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 [Bug 22045] Cataloging UX enhancement - Improve access to tabs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 19:16:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 18:16:30 +0000 Subject: [Koha-bugs] [Bug 22045] Cataloging UX enhancement - Improve access to tabs In-Reply-To: <bug-22045-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22045-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22045-70-V0iHMOZkJH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22582 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22582 [Bug 22582] Authority plugin link broken by Bug 22045 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 19:24:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 18:24:15 +0000 Subject: [Koha-bugs] [Bug 22578] calendar options for every other week closings In-Reply-To: <bug-22578-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22578-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22578-70-mOipPFWrsR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22578 benjamin.r.philbrook at lmco.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |benjamin.r.philbrook at lmco.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 19:53:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 18:53:28 +0000 Subject: [Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13895-70-BVMJChwYAl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 20:50:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 19:50:48 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: <bug-22284-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22284-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22284-70-GeOx4A5cbr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Lisette Scheer <lisetteslatah at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 20:52:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 19:52:13 +0000 Subject: [Koha-bugs] [Bug 20747] Allow LocalHoldsPriority to fill by hierarchical groups system rather than individual library In-Reply-To: <bug-20747-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20747-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20747-70-ag8e0gW2fa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20747 --- Comment #4 from Lisette Scheer <lisetteslatah at gmail.com> --- Joy, In that case, it looks like bug 22284 would work for our purposes here at Valnet. Thanks for the clarification! Lisette (In reply to Joy Nelson from comment #3) > Lisette- > The way that Bug 22284 would work includes functionality for 'non > local/group' holds to be filled after all the local holds have been > satisfied. > > joy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 20:54:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 19:54:03 +0000 Subject: [Koha-bugs] [Bug 22258] Elasticsearch - full record is not indexed in plain text In-Reply-To: <bug-22258-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22258-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22258-70-djf2MEy2Y7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22258 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 21:04:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 20:04:36 +0000 Subject: [Koha-bugs] [Bug 22579] Add syspref to toggle expanding Actions dropdown menu in Z39.50 search to decrease clicks In-Reply-To: <bug-22579-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22579-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22579-70-PzxFbw5ZUV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579 --- Comment #3 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- (In reply to Owen Leonard from comment #2) > Do they know they can click anywhere in the row to trigger the menu? A > system preference seems like overkill to me, but that's certainly an opinion > informed by a different workflow. I think the problem is less with the placement of the menu, rather the fact that they now have to trigger it before they can access their most commonly used option when they didn't have to before. We didn't want to revert the change that was made, so we decided that a system preference would be the easiest way to include this fix, and make life easier for the library. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 21:23:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 20:23:09 +0000 Subject: [Koha-bugs] [Bug 19722] Add a MaxItemsToDisplayForBatchMod preference In-Reply-To: <bug-19722-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19722-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19722-70-dyi40jOQMl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19722 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 21:23:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 20:23:12 +0000 Subject: [Koha-bugs] [Bug 19722] Add a MaxItemsToDisplayForBatchMod preference In-Reply-To: <bug-19722-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19722-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19722-70-8Qqm6yRAFF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19722 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #74682|0 |1 is obsolete| | --- Comment #13 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 87033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87033&action=edit Bug 19722 - Add MaxItemsToDisplayForBatchMod systempreference To test: 1 - Get a list of itemnumbers or barcodes 2 - Set MaxItemsToProcessForBatchMod to less than this number of items 3 - Attempt to batch edit, you arent allowed 4 - Set MaxItemsToProcessForBatchMod to some hugh number like 60000 5 - Try a list of as many items as possible 30000 was good for me (they should exist in your system) 6 - Try to batch edit, system will timeout on displaying these items 7 - Apply patch, update database 8 - Set MaxItemsToDisplayForBatchMod to 1000 (default) 9 - Try large file again, should not display items, but allow modification, wait for this to finish 10 - SetMaxItemsToProcessForBatchMod to 1000 and try large file again 11 - Should be prohibited as before Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 21:23:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 20:23:15 +0000 Subject: [Koha-bugs] [Bug 19722] Add a MaxItemsToDisplayForBatchMod preference In-Reply-To: <bug-19722-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19722-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19722-70-1LJ5UURMsM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19722 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77020|0 |1 is obsolete| | --- Comment #14 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 87034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87034&action=edit Bug 19722: (follow-up) Adjust template parameters Before we passed 'too_many_items' this was renamed to 'too_many_items_display' but deletion template lacked changes To test: 1 - Test a batch deletion by list and file 2 - Test with deleting biblios and without 3 - Results should be as expected -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 21:23:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 20:23:18 +0000 Subject: [Koha-bugs] [Bug 19722] Add a MaxItemsToDisplayForBatchMod preference In-Reply-To: <bug-19722-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19722-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19722-70-ljY0mcLh1J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19722 --- Comment #15 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 87035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87035&action=edit Bug 19722: Don't show items at job completion if over pref To test: 1 - Set MaxItemsToDisplayForBatchMod to some number 2 - Modify less items than that 3 - Note they show a - Note if over 1000 they show in a simple display 4 - Modify more items 5 - Note they do not show and you see a note -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 21:27:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 20:27:43 +0000 Subject: [Koha-bugs] [Bug 22583] New: Clicking on 'spent' amounts on acqui-home.pl causes internal server error. Message-ID: <bug-22583-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22583 Bug ID: 22583 Summary: Clicking on 'spent' amounts on acqui-home.pl causes internal server error. Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: barton at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- This is not a problem in master. To replicate: 1) Go to Home > Acquisitions 2) Click on an amount in the 'Spent' column. This will trigger an internal server error with the following error in the logs: DBD::mysql::st execute failed: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'FROM (aqorders, aqbasket) LEFT JOIN biblio ON biblio.biblionumber=aqorders.b' at line 14 [for Statement "SELECT aqorders.biblionumber, aqorders.basketno, aqorders.ordernumber, quantity-quantityreceived AS tleft, budgetdate, entrydate, aqbasket.booksellerid, itype, title, aqorders.invoiceid, aqinvoices.invoicenumber, quantityreceived, unitprice_tax_included, datereceived, aqbooksellers.name as vendorname, tax_rate_on_receiving, FROM (aqorders, aqbasket) LEFT JOIN biblio ON biblio.biblionumber=aqorders.biblionumber LEFT JOIN aqorders_items ON aqorders.ordernumber = aqorders_items.ordernumber LEFT JOIN items ON aqorders_items.itemnumber = items.itemnumber LEFT JOIN aqinvoices ON aqorders.invoiceid = aqinvoices.invoiceid LEFT JOIN aqbooksellers ON aqbasket.booksellerid = aqbooksellers.id WHERE aqorders.basketno=aqbasket.basketno AND budget_id=? AND (datecancellationprinted IS NULL OR datecancellationprinted='0000-00-00') AND datereceived IS NOT NULL GROUP BY aqorders.ordernumber " with ParamValues: 0="51"] at /usr/share/koha/intranet/cgi-bin/acqui/spent.pl line 89. An error occurred fetching records: You have an error in your SQL syntax; check the manual that corresponds to your MariaDB server version for the right syntax to use near 'FROM (aqorders, aqbasket) LEFT JOIN biblio ON biblio.biblionumber=aqorders.b' at line 14 at /usr/share/koha/intranet/cgi-bin/acqui/spent.pl line 91. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 21:28:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 20:28:16 +0000 Subject: [Koha-bugs] [Bug 22583] Clicking on 'spent' amounts on acqui-home.pl causes internal server error. In-Reply-To: <bug-22583-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22583-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22583-70-TpEvzBoGdk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22583 Barton Chittenden <barton at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 21:35:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 20:35:02 +0000 Subject: [Koha-bugs] [Bug 22584] New: Add YAML support for Codemirror Message-ID: <bug-22584-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22584 Bug ID: 22584 Summary: Add YAML support for Codemirror Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- It would be great if YAML syntax support was available as we use it in a couple places, specially in plugin configurations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 21:35:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 20:35:59 +0000 Subject: [Koha-bugs] [Bug 22583] Clicking on 'spent' amounts on acqui-home.pl causes internal server error. In-Reply-To: <bug-22583-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22583-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22583-70-HRu5tz7WDK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22583 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID CC| |nick at bywatersolutions.com --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- caused by custom code on one of our branches -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 21:56:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 20:56:44 +0000 Subject: [Koha-bugs] [Bug 22585] New: CAS login link for staff intranet is double-escaped Message-ID: <bug-22585-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22585 Bug ID: 22585 Summary: CAS login link for staff intranet is double-escaped Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Authentication Assignee: koha-bugs at lists.koha-community.org Reporter: jrittenh at nd.edu QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org Target Milestone: --- Created attachment 87036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87036&action=edit remove double-escape for CAS URL The return URL that is part of the link to CAS login is double-escaped on the staff login page. This means that %3A%2F%2F is converted to %253A%252F%252F. It appears that this is the same issue as bug 21973 but in the staff intranet template. I have attached an identical patch for the intranet auth.tt file. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 22:12:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 21:12:07 +0000 Subject: [Koha-bugs] [Bug 22535] Use Link Shortcuts when creating reports In-Reply-To: <bug-22535-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22535-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22535-70-F6hkRFv7nY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22535 Barton Chittenden <barton at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com --- Comment #1 from Barton Chittenden <barton at bywatersolutions.com> --- More possible links from wiki: https://wiki.koha-community.org/wiki/Permalinks -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 22:23:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 21:23:43 +0000 Subject: [Koha-bugs] [Bug 22586] New: IntranetReportsHomeHTML no longer renders as HTML on reports-home.pl Message-ID: <bug-22586-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22586 Bug ID: 22586 Summary: IntranetReportsHomeHTML no longer renders as HTML on reports-home.pl Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- As of 18.11 the IntranetReportsHomeHTML syspref no longer renders HTML on report-home.pl. I think this is being filtered wrong in the template. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 22:24:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 21:24:19 +0000 Subject: [Koha-bugs] [Bug 22586] IntranetReportsHomeHTML no longer renders as HTML on reports-home.pl In-Reply-To: <bug-22586-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22586-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22586-70-KSySMYjoBA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22586 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 22:31:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 21:31:07 +0000 Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22456-70-Ye2PDC2E2S@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #1 from Margaret <margaret at bywatersolutions.com> --- Hi Chris, You should know that this enhancement runs counter to this other recently resolved bug: Bug 18856 - "Cancel Waiting Hold in OPAC does not give useful message". The functionality you are asking for was recently removed due to its tendency to leave items stranded. So, would how you like this to work? Would this be a new system pref? How would the staff side work once the hold has been canceled by the patron? How would you be alerted to this newly canceled hold? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 22:47:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 21:47:26 +0000 Subject: [Koha-bugs] [Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values In-Reply-To: <bug-21159-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21159-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21159-70-6MnSjQ3xU3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80894|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 22:47:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 21:47:38 +0000 Subject: [Koha-bugs] [Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values In-Reply-To: <bug-21159-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21159-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21159-70-WaZ8hgHiXT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80895|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 22:50:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 21:50:12 +0000 Subject: [Koha-bugs] [Bug 22587] New: Test Message-ID: <bug-22587-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22587 Bug ID: 22587 Summary: Test Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: hayleymapley at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Target Milestone: --- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 22:58:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 21:58:14 +0000 Subject: [Koha-bugs] [Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values In-Reply-To: <bug-21159-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21159-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21159-70-3mZvw7Lfh7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 --- Comment #21 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Created attachment 87037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87037&action=edit Bug 21159 - Implementing 2 sysprefs to enable blanking location This patch introduces two new system preferences: BlankingShelvingLocationOnIssue and BlankingShelvingLocationOnReturn. By default both are off. If BlankingShelvingLocationOnIssue is enabled then when an item is issued it's shelving location 952$c field will be set to '' in C4::Items->BlankShelvingLocation() If BlankingShelvingLocationOnReturn is enabled then when an item is returned it's shelving location field will be set to '' in C4::Items->BlankShelvingLocation(). t/db_dependent/Circulation/issue.t contains tests for BlankShelvingLocationOnIssue t/db_dependen/Circulation/Returns.t contains tests for BlankShelvingLocationOnReturn Test plan: 1. Create a new biblio and associated item and set the value of the shelving location for the item to 'CART' 2. Checkout the item to a user and notice that the status does not change 3. Apply patch, and run ./updatedatabase.pl inside the koha shell 4. Now return the checked out item (when you updated the database you added two new sysprefs: BlankShelvingLocationOnIssue and BlankShelvingLocationOnReturn both of which are off by default) 5. Notice the shelving location has not changed, showing with the BlankShelvingLocationOnReturn syspref not enabled the shelving location is not changed upon return 6. Check the item out again and notice the shelving location is not changed, showing that when the BlankShelvingLocationOnIssue is not enabled the shelving location is not changed upon issue. 7. Enable both aforementioned sysprefs in the Administration->Global system preferences->Circulation interface 8. Return the item and notice the Shelving location has changed from 'Cart' to no value, showing when the BlankShelvingLocationOnReturn syspref is enabled it blanks the shelving location value on the return of the item 9. Edit the item changing the shelving location back to 'Shelving Trolley'(CART) 10. Check out the item and notice the shelving location is changed to no value, showing when the BlankShelvingLocationOnIssue syspref is enabled it blanks the shelving location on the issue of an item. 11. Run t/db_dependent/Circulation/Returns.t 12. Run t/db_dependent/Circulation/issue.t Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 22:59:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 21:59:25 +0000 Subject: [Koha-bugs] [Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values In-Reply-To: <bug-21159-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21159-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21159-70-LU2D6na9eE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 --- Comment #22 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Created attachment 87038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87038&action=edit Bug 21159 - Corrected typo Same test plan as first patch. Sponsored-By: Toi Ohomai Institute of Technology, New Zealand -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 23:04:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 22:04:07 +0000 Subject: [Koha-bugs] [Bug 18645] Creation of Koha feature release change tool displayed after running Koha update In-Reply-To: <bug-18645-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18645-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18645-70-od3i5kDfZ5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18645 --- Comment #21 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 87039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87039&action=edit Bug 18645: (follow-up) Making feature release tool work with all syspref types This patch is a work in progress. I've separated the template code into an include for the preferences page and feature release page. Am now working on making the feature release perl code work with this template. Struggling to avoid duplicating code. If anyone has a suggestion on a good way to use essentially all the methods in admin/preferences.pl again in installer/featurereleasetool.pl without repeating them, I'd appreciate hearing them. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 23:21:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 22:21:44 +0000 Subject: [Koha-bugs] [Bug 14576] Allow automatic update of location on checkin In-Reply-To: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14576-70-uGZbCUZbcd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |hayleymapley at catalyst.net.n | |z --- Comment #116 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- This patch fails when checking in an item, due to use of a deprecated method GetItem (removed in patch 21206) in C4/Items.pm. This method is also called in C4/Reserves.pm. This should be changed to Koha::Items->find function. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Mar 26 23:24:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 22:24:00 +0000 Subject: [Koha-bugs] [Bug 22587] Test In-Reply-To: <bug-22587-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22587-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22587-70-iFiHKRKxtX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22587 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #1 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Used to troubleshoot problems with git bz. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 00:24:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 23:24:52 +0000 Subject: [Koha-bugs] [Bug 14576] Allow automatic update of location on checkin In-Reply-To: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14576-70-1aTYY2DjD3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 00:24:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 23:24:56 +0000 Subject: [Koha-bugs] [Bug 14576] Allow automatic update of location on checkin In-Reply-To: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14576-70-8nAXjinnyZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 --- Comment #117 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Created attachment 87040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87040&action=edit Bug 14576: Replaced calls using deprecated method GetItem with Koha::Items->find Test plan: 1) Apply all patches except this one 2) Checkout out an item to a patron 3) Check the item in - note that this will fail 4) Apply this patch, and repeat steps 1-3, noting instead that the the check is instead successful 5) Verify also that reserves act as expected 5) Sign off Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 00:27:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 23:27:05 +0000 Subject: [Koha-bugs] [Bug 21846] Using emoji as tags doesn't discriminate between emoji when calculating weights or searching In-Reply-To: <bug-21846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21846-70-ni3dCQJjyq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21846 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #46 from Lucas Gass <lucas at bywatersolutions.com> --- not backporting to 18.05.x series -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 00:29:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 23:29:04 +0000 Subject: [Koha-bugs] [Bug 22219] C4::Biblio->GetItemsForInventory can return wrong count / duplicated items when skipping waiting holds In-Reply-To: <bug-22219-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22219-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22219-70-OY7LOMaEzt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22219 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #9 from Lucas Gass <lucas at bywatersolutions.com> --- missing dependency for 18.05.x not backporting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 00:31:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 23:31:39 +0000 Subject: [Koha-bugs] [Bug 20823] UNIMARC XSLT does not display 604$t In-Reply-To: <bug-20823-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20823-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20823-70-y3vaTh89pY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20823 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #13 from Lucas Gass <lucas at bywatersolutions.com> --- backported to 18.05.x for 18.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 00:36:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 23:36:40 +0000 Subject: [Koha-bugs] [Bug 20006] Adapt /v1/holds to new naming guidelines In-Reply-To: <bug-20006-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20006-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20006-70-tCRTEQxIzx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20006 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #30 from Lucas Gass <lucas at bywatersolutions.com> --- enhancment not backporting to 18.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 00:37:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 23:37:51 +0000 Subject: [Koha-bugs] [Bug 22206] Add route to handle holds suspensions In-Reply-To: <bug-22206-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22206-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22206-70-JnhZipllzr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22206 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #22 from Lucas Gass <lucas at bywatersolutions.com> --- not backporting to 18.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 00:42:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 23:42:19 +0000 Subject: [Koha-bugs] [Bug 20782] EDI: Clicking the 'Invoice' link on the 'EDI Messages' page does not take you directly to the corresponding invoice In-Reply-To: <bug-20782-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20782-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20782-70-XbCusieq8D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20782 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #8 from Lucas Gass <lucas at bywatersolutions.com> --- backported to 18.05.x for 18.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 00:47:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 23:47:24 +0000 Subject: [Koha-bugs] [Bug 20658] Move template JavaScript to the footer: Installer and onboarding In-Reply-To: <bug-20658-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20658-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20658-70-q3de6gv3bS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #18 from Lucas Gass <lucas at bywatersolutions.com> --- cant apply to 18.05.x if this is need please rebase. thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 00:55:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Mar 2019 23:55:49 +0000 Subject: [Koha-bugs] [Bug 21832] Restore is_expired in ILS-DI GetPatronInfo service In-Reply-To: <bug-21832-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21832-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21832-70-0r8uLOkMuc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21832 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #23 from Lucas Gass <lucas at bywatersolutions.com> --- backported to 18.05.x for 18.05.12 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 02:12:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 01:12:16 +0000 Subject: [Koha-bugs] [Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values In-Reply-To: <bug-21159-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21159-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21159-70-HTIxQMK6ge@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 --- Comment #23 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Created attachment 87041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87041&action=edit Bug 21159: (follow up) Fixed broken indentation in circulation. pref Test plan: Same as comment 21. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 07:39:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 06:39:06 +0000 Subject: [Koha-bugs] [Bug 22582] Authority plugin link broken by Bug 22045 In-Reply-To: <bug-22582-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22582-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22582-70-N73tXnAExB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22582 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 07:41:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 06:41:01 +0000 Subject: [Koha-bugs] [Bug 22524] Elasticsearch - Date range in advanced search In-Reply-To: <bug-22524-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22524-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22524-70-2X5iqHooqb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22524 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- That sounds like it's not using the controlled date but 260/264. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 07:41:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 06:41:30 +0000 Subject: [Koha-bugs] [Bug 22524] Elasticsearch - Date range in advanced search In-Reply-To: <bug-22524-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22524-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22524-70-MnNkigfEEj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22524 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ere.maijala at helsinki.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 07:47:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 06:47:15 +0000 Subject: [Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user In-Reply-To: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22577-70-B4JLULnLgS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #20 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I wonder if having a real user is the right way to do this. If we don't want to differentiate between cronjob and command line, maybe using NULL could work? I am worried that system users will add a lot of other problems (which branch to assign them to? especially in multi-branch systems with the new 'independent branches' features it seems like it could get confusing really quick) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 07:51:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 06:51:40 +0000 Subject: [Koha-bugs] [Bug 22579] Add syspref to toggle expanding Actions dropdown menu in Z39.50 search to decrease clicks In-Reply-To: <bug-22579-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22579-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22579-70-GO4R1dmRtl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Could we use a split button with import being the default? (like receive in the subscription search list) I also share the feeling that a pref might be a little overkill here when it seems more like a usability issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 07:59:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 06:59:30 +0000 Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22456-70-dTQxwhqPxV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Margaret from comment #1) > Hi Chris, > > You should know that this enhancement runs counter to this other recently > resolved bug: Bug 18856 - "Cancel Waiting Hold in OPAC does not give useful > message". The functionality you are asking for was recently removed due to > its tendency to leave items stranded. > > So, would how you like this to work? Would this be a new system pref? How > would the staff side work once the hold has been canceled by the patron? How > would you be alerted to this newly canceled hold? +1 I think there are libraries that want the current behaviour and we need to think about the workflow. Maybe a pref and a message on pick-up list? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 08:01:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 07:01:35 +0000 Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation' (bug 11373) In-Reply-To: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22359-70-CBTEn8huBt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Not sure how to get this moving, but I feel we should not release with the feature as is. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 08:49:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 07:49:51 +0000 Subject: [Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future In-Reply-To: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19014-70-8LpJTenDUG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 --- Comment #31 from Bj?rn Nyl?n <bjorn.nylen at ub.lu.se> --- >From our perspective Davids patch is the logical way it should function. Don't do anything until it's time to renew. However it does change the behaviour and I guess some libraries might like to keep sending early notices if no further renewal will be possible. Perhaps it's possible to control it with a command line option (eg '--early-notice') to skip the no-renwal-before check?(with the risk of asking for a more complex solution) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 09:24:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 08:24:52 +0000 Subject: [Koha-bugs] [Bug 21772] Add holds and account information tab to the SCO module In-Reply-To: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21772-70-TYUEuY9sBG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 09:26:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 08:26:33 +0000 Subject: [Koha-bugs] [Bug 21772] Add holds and account information tab to the SCO module In-Reply-To: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21772-70-PVa1lcHaNK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86332|0 |1 is obsolete| | --- Comment #11 from Josef Moravec <josef.moravec at gmail.com> --- Comment on attachment 86332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86332 Bug 21772: (follow-up) QA failed because old bootstrap button class This is false positive. In opac, we still use class btn-mini as Bootstrap in opac was not upgraded to version 3 and is still using version 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 09:48:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 08:48:16 +0000 Subject: [Koha-bugs] [Bug 21772] Add holds and account information tab to the SCO module In-Reply-To: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21772-70-l7ixQF6zc8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 09:48:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 08:48:19 +0000 Subject: [Koha-bugs] [Bug 21772] Add holds and account information tab to the SCO module In-Reply-To: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21772-70-TvKZS29rFj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86331|0 |1 is obsolete| | Attachment #86333|0 |1 is obsolete| | Attachment #86334|0 |1 is obsolete| | Attachment #86495|0 |1 is obsolete| | --- Comment #12 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 87042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87042&action=edit Bug 21772: Move OPAC holds and account tables into .inc This patch moves the code to render the account and holds information for the patron into include files. They are loaded in the opac-user.tt and opac-account.tt templates respectively. To test: 1) Have a patron with account lines and holds 2) Notice they are displayed in the patron's detail section in the OPAC 3) Apply this patch 4) Reload the patron's detail page => SUCESS: Everything looks the same, no behaviuor or layout change. 5) Sign off Sponsored-by: City of Portsmouth Public Library Signed-off-by: Sarah Cornell <sbcornell at cityofportsmouth.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 09:48:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 08:48:23 +0000 Subject: [Koha-bugs] [Bug 21772] Add holds and account information tab to the SCO module In-Reply-To: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21772-70-NvY2Yc8hAf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 --- Comment #13 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 87043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87043&action=edit Bug 21772: Add holds and account information to SCO This patch introduces holds and account information to the SCO page. It uses the introduced include files that are also used in OPAC (opac-user.pl and opac-account.pl). To test: 1) Have a patron that has holds and account lines 2) Enable the SCO module 3) Use the patron's cardnumber to get to its details => SUCCESS: New tabs are presented, and they display holds and account information as expected 4) Sign off :-D Sponsored-by: City of Portsmouth Public Library Signed-off-by: Sarah Cornell <sbcornell at cityofportsmouth.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 09:48:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 08:48:26 +0000 Subject: [Koha-bugs] [Bug 21772] Add holds and account information tab to the SCO module In-Reply-To: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21772-70-UP53PDxO0d@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 --- Comment #14 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 87044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87044&action=edit Bug 21772: (follow-up) Remove redundant variable Sponsored-by: City of Portsmouth Public Library Signed-off-by: Sarah Cornell <sbcornell at cityofportsmouth.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 09:48:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 08:48:30 +0000 Subject: [Koha-bugs] [Bug 21772] Add holds and account information tab to the SCO module In-Reply-To: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21772-70-AolH9UOTia@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 --- Comment #15 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 87045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87045&action=edit Bug 21772: (follow-up) Included more information on tab label for SCO Signed-off-by: Sarah Cornell <sbcornell at cityofportsmouth.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 09:48:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 08:48:33 +0000 Subject: [Koha-bugs] [Bug 21772] Add holds and account information tab to the SCO module In-Reply-To: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21772-70-cSY0HbILnX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 --- Comment #16 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 87046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87046&action=edit Bug 21772: (QA follow-up) Hide .tdlabel class in sco for consistancy with opac-user page. Test plan: 1) Compare holds table on selfcheckout and opac-user page, you will see the difference: In self checkout there are labels like Status, Pickup location, and so on in every table cell. 2) Apply the patch, the label in selfcheckout dissappear Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 09:48:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 08:48:36 +0000 Subject: [Koha-bugs] [Bug 21772] Add holds and account information tab to the SCO module In-Reply-To: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21772-70-Cz5xYQR5TY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 --- Comment #17 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 87047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87047&action=edit Bug 21772: (QA follow-up) Fix button class on Cancel hold button Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 09:48:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 08:48:40 +0000 Subject: [Koha-bugs] [Bug 21772] Add holds and account information tab to the SCO module In-Reply-To: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21772-70-WJ5cjlWgY1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 --- Comment #18 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 87048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87048&action=edit Bug 21772: (QA follow-up) Fix setting variables to PROCESS in holds Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 09:50:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 08:50:11 +0000 Subject: [Koha-bugs] [Bug 22588] New: Simplify getting account information in opac and self checkout module Message-ID: <bug-22588-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22588 Bug ID: 22588 Summary: Simplify getting account information in opac and self checkout module Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: josef.moravec at gmail.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 09:50:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 08:50:23 +0000 Subject: [Koha-bugs] [Bug 22588] Simplify getting account information in opac and self checkout module In-Reply-To: <bug-22588-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22588-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22588-70-5guygc4pOR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22588 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |josef.moravec at gmail.com Depends on| |21772 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 [Bug 21772] Add holds and account information tab to the SCO module -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 09:50:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 08:50:23 +0000 Subject: [Koha-bugs] [Bug 21772] Add holds and account information tab to the SCO module In-Reply-To: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21772-70-zBbvTX2AHr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22588 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22588 [Bug 22588] Simplify getting account information in opac and self checkout module -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 10:03:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 09:03:16 +0000 Subject: [Koha-bugs] [Bug 22588] Simplify getting account information in opac and self checkout module In-Reply-To: <bug-22588-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22588-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22588-70-z9LXEDdbPL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22588 --- Comment #1 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 87049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87049&action=edit Bug 22588: Simplify getting fines information in opac and selfcheckout Test plan: 0) Have patron with some fines and credits 1) Go to opac and log in 2) Go to 'your summary' page and confirm it shows the right amount and description for both, credit and debit 3) Go to 'your fines' page and confirm it show right information 4) Go to self checkout page and confirm the fines are right here Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 10:19:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 09:19:06 +0000 Subject: [Koha-bugs] [Bug 22588] Simplify getting account information in opac and self checkout module In-Reply-To: <bug-22588-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22588-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22588-70-z8fIpNKDEp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22588 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 10:37:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 09:37:09 +0000 Subject: [Koha-bugs] [Bug 22589] New: Remove sub C4::Overdues::BorType Message-ID: <bug-22589-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22589 Bug ID: 22589 Summary: Remove sub C4::Overdues::BorType Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: josef.moravec at gmail.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- This sub is barely used and and can be easily changed to Koha::Patrons->find -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 10:37:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 09:37:16 +0000 Subject: [Koha-bugs] [Bug 22589] Remove sub C4::Overdues::BorType In-Reply-To: <bug-22589-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22589-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22589-70-tDPCCa6nAI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22589 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 10:49:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 09:49:13 +0000 Subject: [Koha-bugs] [Bug 22589] Remove sub C4::Overdues::BorType In-Reply-To: <bug-22589-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22589-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22589-70-nJIZRTwXAw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22589 --- Comment #1 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 87050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87050&action=edit Bug 22589: Remove C4::Overdues::BorType Test plan: 0) Apply patch 1) try to run affected scripts and ensure the amounts are corectly calculated for different patron categories: installer/data/mysql/fix_unclosed_nonaccruing_fines_bug17135.pl misc/cronjobs/fines.pl misc/cronjobs/staticfines.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 10:49:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 09:49:10 +0000 Subject: [Koha-bugs] [Bug 22589] Remove sub C4::Overdues::BorType In-Reply-To: <bug-22589-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22589-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22589-70-2vHhEU2dXS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22589 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 10:59:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 09:59:41 +0000 Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation' (bug 11373) In-Reply-To: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22359-70-oL3DRv9ekW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|--- |19.05 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 11:02:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 10:02:15 +0000 Subject: [Koha-bugs] [Bug 22547] C4::Overdues - UpdateFine is barely tested In-Reply-To: <bug-22547-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22547-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22547-70-ST0NEhaxxy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22547 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 11:02:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 10:02:17 +0000 Subject: [Koha-bugs] [Bug 22547] C4::Overdues - UpdateFine is barely tested In-Reply-To: <bug-22547-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22547-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22547-70-cOfxJJYQ8O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22547 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86790|0 |1 is obsolete| | --- Comment #6 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 87051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87051&action=edit Bug 22547: Add tests for C4::Overdues->UpdateFine Add tests for UpdateFine, in particular testing the functionality of MaxFine. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 11:08:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 10:08:16 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-1lrsWtNQmY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #21 from Josef Moravec <josef.moravec at gmail.com> --- Comment on attachment 86919 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86919 Bug 22521: Update fines handling to use accountline.status Review of attachment 86919: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=22521&attachment=86919) ----------------------------------------------------------------- ::: Koha/Account.pm @@ +471,4 @@ > itemnumber => $item_id, > issue_id => $issue_id, > branchcode => $library_id, > + ( $type eq 'overdue' ? ( lastincrement => $amount ) : ()), Does it make sense to you to make this dependent also on 22516, which removes lastincrement column? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 11:12:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 10:12:41 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-0OxSVVCxVj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #22 from Josef Moravec <josef.moravec at gmail.com> --- And the tests are not passing: t/db_dependent/Circulation.t .. 36/126 Type of debit not recognised# Looks like your test exited with 255 just after 37. t/db_dependent/Circulation.t .. Dubious, test returned 255 (wstat 65280, 0xff00) Failed 89/126 subtests t/db_dependent/Overdues.t ..... 4/17 # Looks like you planned 25 tests but ran 1. t/db_dependent/Overdues.t ..... 17/17 # Failed test 'UpdateFine tests' # at t/db_dependent/Overdues.t line 307. Type of debit not recognised# Looks like your test exited with 255 just after 17. t/db_dependent/Overdues.t ..... Dubious, test returned 255 (wstat 65280, 0xff00) Failed 1/17 subtests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 11:19:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 10:19:38 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-u0dMqYX3KW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #23 from Josef Moravec <josef.moravec at gmail.com> --- git grep "fine_update" returns: C4/Overdues.pm: $accountline->adjust({ amount => $amount, type => 'fine_update' }); t/db_dependent/Koha/Account/Lines.t: throws_ok { $debit_1->adjust( { amount => 50, type => 'fine_update' } ) } t/db_dependent/Koha/Account/Lines.t: $debit_2->adjust( { amount => 150, type => 'fine_update' } )->discard_changes; t/db_dependent/Koha/Account/Lines.t: $debit_2->adjust( { amount => 160, type => 'fine_update' } )->discard_changes; t/db_dependent/Koha/Account/Lines.t: $debit_2->adjust( { amount => 50, type => 'fine_update' } )->discard_changes; t/db_dependent/Koha/Account/Lines.t: $debit_2->adjust( { amount => 30, type => 'fine_update' } )->discard_changes; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 11:23:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 10:23:51 +0000 Subject: [Koha-bugs] [Bug 22564] accounttype 'Rep' is still referred to but is never set In-Reply-To: <bug-22564-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22564-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22564-70-xrByRnjC2I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86922|0 |1 is obsolete| | --- Comment #2 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 87052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87052&action=edit Bug 22564: Remove references to 'Rep' accounttype Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 11:23:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 10:23:48 +0000 Subject: [Koha-bugs] [Bug 22564] accounttype 'Rep' is still referred to but is never set In-Reply-To: <bug-22564-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22564-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22564-70-4KemicKJa9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 11:25:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 10:25:19 +0000 Subject: [Koha-bugs] [Bug 22330] Transfer limits should be respected for placing holds in staff interface and APIs In-Reply-To: <bug-22330-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22330-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22330-70-zEhEO0OWvL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22330 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor.grousset at biblibre.co | |m --- Comment #26 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Can someone confirm if this bug encompasses bug 7376? (Transfer limits should be checked at check-in) Because this bug seems to only be about holds. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 11:28:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 10:28:08 +0000 Subject: [Koha-bugs] [Bug 22590] New: Allow batch printing of routing lists Message-ID: <bug-22590-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22590 Bug ID: 22590 Summary: Allow batch printing of routing lists Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Target Milestone: --- For libraries dealing with lots of routing lists it would be nice if they could be printed in batch on demand after receiving several issues. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 11:31:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 10:31:16 +0000 Subject: [Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user In-Reply-To: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22577-70-uNe4h9N9aM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87028|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87053&action=edit Bug 22577: Prevent deletion of system users -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 11:31:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 10:31:19 +0000 Subject: [Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user In-Reply-To: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22577-70-8IzeeahMIA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87029|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87054&action=edit Bug 22577: Add 'cron' system user -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 11:31:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 10:31:22 +0000 Subject: [Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user In-Reply-To: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22577-70-U9dAXAspHD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87032|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87055&action=edit Bug 22577: Retrospectively assign '-1' for cronscripts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 11:31:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 10:31:26 +0000 Subject: [Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user In-Reply-To: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22577-70-5JyGpW5Dkb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87030|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87056&action=edit Bug 22577: Set 'cron' user for cron scripts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 11:31:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 10:31:29 +0000 Subject: [Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user In-Reply-To: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22577-70-LhvjQ8G7cB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87031|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87057&action=edit Bug 22577: Add test for Koha::Cron base class -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 11:31:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 10:31:32 +0000 Subject: [Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user In-Reply-To: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22577-70-aR8MEPXCb1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 --- Comment #26 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87058&action=edit Bug 22577: Test patron delete restriction -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 11:31:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 10:31:38 +0000 Subject: [Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user In-Reply-To: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22577-70-3AUcXUm4bH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 --- Comment #28 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87060&action=edit Bug 22577: Add test for Koha::Patrons->search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 11:31:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 10:31:35 +0000 Subject: [Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user In-Reply-To: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22577-70-FAP1gCJK8n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 --- Comment #27 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87059&action=edit Bug 22577: Prevent system users from returning in searches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 11:33:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 10:33:31 +0000 Subject: [Koha-bugs] [Bug 22591] New: Allow to temporarily exclude patrons from routing lists Message-ID: <bug-22591-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22591 Bug ID: 22591 Summary: Allow to temporarily exclude patrons from routing lists Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Target Milestone: --- At the moment it's not possible to temporarily exclude patrons from routing lists. This would be very handy when patrons like internal research staff are known not to be available for a longer time to receive issues (vacation, sickness, remote research...) It could work similarily to suspending holds where you set a date on which to reactivate the routing list memberships. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 11:57:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 10:57:41 +0000 Subject: [Koha-bugs] [Bug 18969] _all field is deprecated - should use copy_to to prepare for ES6 In-Reply-To: <bug-18969-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18969-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18969-70-RwWdjSoFW0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18969 claire.hernandez at biblibre.com <claire.hernandez at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff --- Comment #29 from claire.hernandez at biblibre.com <claire.hernandez at biblibre.com> --- We really need this patch. It does only what it must do. One bugzilla should do one thing and this one is a good candidate... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 11:58:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 10:58:17 +0000 Subject: [Koha-bugs] [Bug 15516] Allow to place a hold on first available item from a group of titles In-Reply-To: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15516-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15516-70-fc4HY78JZY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15516 --- Comment #117 from Josef Moravec <josef.moravec at gmail.com> --- (In reply to Aleisha Amohia from comment #116) > (In reply to Katrin Fischer from comment #115) > > Aleisha, did you mean to sign-off? > > Oops no was just rebasing. Still working on this Aleisha, what did you want to do with this? Can we make some progress on these long standing patches? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 12:23:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 11:23:17 +0000 Subject: [Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user In-Reply-To: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22577-70-SioL3ptII1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 --- Comment #29 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Katrin Fischer from comment #20) > I wonder if having a real user is the right way to do this. If we don't want > to differentiate between cronjob and command line, maybe using NULL could > work? I am worried that system users will add a lot of other problems (which > branch to assign them to? especially in multi-branch systems with the new > 'independent branches' features it seems like it could get confusing really > quick) An issue with using NULL is that we would then not have a way to distinguish between system/cron and deleted user actions. I added this bug to agenda for next dev meeting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 12:34:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 11:34:00 +0000 Subject: [Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user In-Reply-To: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22577-70-KDAlwlcZVG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 --- Comment #30 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Nick Clemens from comment #29) > (In reply to Katrin Fischer from comment #20) > > I wonder if having a real user is the right way to do this. If we don't want > > to differentiate between cronjob and command line, maybe using NULL could > > work? I am worried that system users will add a lot of other problems (which > > branch to assign them to? especially in multi-branch systems with the new > > 'independent branches' features it seems like it could get confusing really > > quick) > > An issue with using NULL is that we would then not have a way to distinguish > between system/cron and deleted user actions. > > I added this bug to agenda for next dev meeting It just appears to me like thsi approach will open anoher can of worms. - Which homelibrary to use for those users? - Which patron category? - How to keep people from deleting or changing them? - How to prevent that they change statistics in an unwanted way? (if they have a branch and a patron category) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 12:34:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 11:34:58 +0000 Subject: [Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user In-Reply-To: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22577-70-VPn8xooIYP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 --- Comment #31 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- For distinguiging who did something, maybe it would be better to go via interface in the log tables anyway? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 12:37:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 11:37:07 +0000 Subject: [Koha-bugs] [Bug 14576] Allow automatic update of location on checkin In-Reply-To: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14576-70-BvbrnLPxab@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 --- Comment #118 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 87061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87061&action=edit Bug 14576: (follow-up) Using item objects, not hashrefs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 12:50:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 11:50:56 +0000 Subject: [Koha-bugs] [Bug 21534] ElasticSearch - Dash is considered like a boolean operator In-Reply-To: <bug-21534-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21534-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21534-70-fan7ZwfmCd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21534 --- Comment #3 from Nick Clemens <nick at bywatersolutions.com> --- I do (In reply to Marjorie Barry-Vila from comment #2) > (In reply to Nick Clemens from comment #1) > > I tested this on master and cannot recreate. > > > > According to the docs: > > https://www.elastic.co/guide/en/elasticsearch/reference/current/query-dsl- > > query-string-query.html > > > > Hyphen is considered a boolean 'not' operator > > > > in testing though it seems to work as long as there is no space > > Hi Nick, > Do you think my bug is a duplicate of > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20334 > > Regards > Marjorie I do, if you do too you can mark it as a duplicate -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 12:51:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 11:51:27 +0000 Subject: [Koha-bugs] [Bug 20658] Move template JavaScript to the footer: Installer and onboarding In-Reply-To: <bug-20658-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20658-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20658-70-mSBf6Gvx8j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20658 --- Comment #19 from Owen Leonard <oleonard at myacpl.org> --- (In reply to Lucas Gass from comment #18) > cant apply to 18.05.x if this is need please rebase. I don't think it's necessary to backport this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 12:52:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 11:52:14 +0000 Subject: [Koha-bugs] [Bug 22587] Test In-Reply-To: <bug-22587-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22587-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22587-70-NnxWMNimj3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22587 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|INVALID |DUPLICATE --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- *** This bug has been marked as a duplicate of bug 6473 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 12:52:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 11:52:14 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: <bug-6473-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6473-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6473-70-5qbGbTKAet@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hayleymapley at catalyst.net.n | |z --- Comment #223 from Owen Leonard <oleonard at myacpl.org> --- *** Bug 22587 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 12:59:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 11:59:50 +0000 Subject: [Koha-bugs] [Bug 18969] _all field is deprecated - should use copy_to to prepare for ES6 In-Reply-To: <bug-18969-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18969-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18969-70-SD3lUMYDCY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18969 --- Comment #30 from David Gustafsson <glasklas at gmail.com> --- I still think bug 20589 is the way to go instead of this one for the reasons listed above. There is a reason the _all field is deprictated and recreating it only postpones solving the real underlying problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 13:05:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 12:05:39 +0000 Subject: [Koha-bugs] [Bug 22432] Star ratings plugin replacement missing from a couple pages In-Reply-To: <bug-22432-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22432-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22432-70-DJ0108CQmu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22432 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87011|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 87062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87062&action=edit Bug 22432: Star ratings plugin replacement missing from a couple pages This patch modifies two templates to conform to the change to the start ratings plugin: Overdrive search results and RecordedBooks search results. On the Overdrive page, the star ratings are now correctly displayed using the new plugin. On the RecordedBooks page, star ratings code has been removed because it is unused. RecordedBooks doesn't provide ratings information in their API. To test you need credentials for both Overdrive and RecordedBooks. Apply the patch and enable both services. - In the OPAC, perform a search that will return results from Overdrive and RecordedBooks. - Open the search results for each of those services. - On the Overdrive search results page, star ratings should appear correctly (in read-only mode). - On the RecordedBooks page everything should look the same. Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 13:05:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 12:05:36 +0000 Subject: [Koha-bugs] [Bug 22432] Star ratings plugin replacement missing from a couple pages In-Reply-To: <bug-22432-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22432-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22432-70-JjLCwApdlb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22432 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 13:06:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 12:06:12 +0000 Subject: [Koha-bugs] [Bug 22456] Allow patrons to cancel their waiting holds In-Reply-To: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22456-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22456-70-KRbSH4HiSn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22456 --- Comment #3 from Christofer <christofer.zorn at ajaxlibrary.ca> --- Thank you Katrin ... I would see this as a system preference. When enabled it would allow patrons to cancel the waiting hold from the Opac. From my perspective, as long as the reserves / old_reserves table was updated holding the date of the cancellation, we could then run a report that would list the items that were cancelled in the last 24 hours or so. Then staff could pull them from the hold shelf. When the customer cancels the hold the opac display would toggle the button text from "Cancel" to "Cancelled". The item would remain in their queue until the staff pulled the book and checked it in, based on the report. Our Library is new to Koha and what I love is the flexibility (we have done things in this system we could only have dreamed of in our previous one). However, choice is what makes this system great. While I respect that this request runs counter to the most recent change and libraries like the status quo, I feel giving us the option to use the system the way we need to is what Koha is about. Thank you again! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 13:12:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 12:12:12 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-yUxPwRRCz4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #24 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87063&action=edit Bug 22521: (QA follow-up) Corrections to tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 13:27:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 12:27:27 +0000 Subject: [Koha-bugs] [Bug 22592] New: Elasticsearch - Support for index scan Message-ID: <bug-22592-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 Bug ID: 22592 Summary: Elasticsearch - Support for index scan Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: ere.maijala at helsinki.fi Target Milestone: --- We can emulate index scan at least to some extent by using faceting with an include filter. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 13:27:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 12:27:53 +0000 Subject: [Koha-bugs] [Bug 22592] Elasticsearch - Support for index scan In-Reply-To: <bug-22592-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22592-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22592-70-pKp5nKtuwp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22413 Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |ere.maijala at helsinki.fi |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22413 [Bug 22413] Elasticsearch - Index title is lost after sorting -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 13:27:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 12:27:53 +0000 Subject: [Koha-bugs] [Bug 22413] Elasticsearch - Index title is lost after sorting In-Reply-To: <bug-22413-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22413-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22413-70-Lj6npTYT4H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22413 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22592 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 [Bug 22592] Elasticsearch - Support for index scan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 13:28:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 12:28:49 +0000 Subject: [Koha-bugs] [Bug 22592] Elasticsearch - Support for index scan In-Reply-To: <bug-22592-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22592-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22592-70-FhHsfaudI6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 13:34:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 12:34:30 +0000 Subject: [Koha-bugs] [Bug 22593] New: Scripts dealing with accountlines need updating for bug 22008 Message-ID: <bug-22593-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22593 Bug ID: 22593 Summary: Scripts dealing with accountlines need updating for bug 22008 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Target Milestone: --- Currently we use 0 to indicate an action performed by command line scripts (userenv is undef, default to 0) After bug 22008 we must have a real borrowernumber. If we simply default to 'NULL' we will no longer be able to differentiate fines from command line from those of deleted users -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 13:34:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 12:34:43 +0000 Subject: [Koha-bugs] [Bug 22593] Scripts dealing with accountlines need updating for bug 22008 In-Reply-To: <bug-22593-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22593-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22593-70-V4CoB8hlY1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22593 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22008 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 [Bug 22008] accountlines.manager_id is missing a foreign key constraint -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 13:34:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 12:34:56 +0000 Subject: [Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user In-Reply-To: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22577-70-Km0xHgfU0n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|22008 |22593 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 [Bug 22008] accountlines.manager_id is missing a foreign key constraint https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22593 [Bug 22593] Scripts dealing with accountlines need updating for bug 22008 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 13:34:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 12:34:56 +0000 Subject: [Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint In-Reply-To: <bug-22008-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22008-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22008-70-w4Sqo3YR53@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22577 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 13:34:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 12:34:56 +0000 Subject: [Koha-bugs] [Bug 22593] Scripts dealing with accountlines need updating for bug 22008 In-Reply-To: <bug-22593-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22593-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22593-70-RO0eCh0dQt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22593 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22577 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 13:35:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 12:35:03 +0000 Subject: [Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user In-Reply-To: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22577-70-vbA6E7AfNC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|blocker |enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 13:34:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 12:34:43 +0000 Subject: [Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint In-Reply-To: <bug-22008-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22008-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22008-70-G8Ivxydjrx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22593 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22593 [Bug 22593] Scripts dealing with accountlines need updating for bug 22008 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 13:36:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 12:36:45 +0000 Subject: [Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user In-Reply-To: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22577-70-39oCD2l1xR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 13:36:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 12:36:56 +0000 Subject: [Koha-bugs] [Bug 21772] Add holds and account information tab to the SCO module In-Reply-To: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21772-70-akC4l1b9tV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 --- Comment #19 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 87064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87064&action=edit Bug 21772: (follow-up) Minor markup correction and reindentation This patch makes one minor markup correction: In HTML5 <tfoot> must be after <tbody>. Previously the opposite was true. I've also done a little bit of opinionated reindentation. There should be no changes visible to the user from this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 13:37:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 12:37:32 +0000 Subject: [Koha-bugs] [Bug 21772] Add holds and account information tab to the SCO module In-Reply-To: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21772-70-6ftkI3chtN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 --- Comment #20 from Owen Leonard <oleonard at myacpl.org> --- I hope you don't mind the minor follow-up. I can submit on a separate bug if that's better. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 13:37:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 12:37:43 +0000 Subject: [Koha-bugs] [Bug 22593] Scripts dealing with accountlines need updating for bug 22008 In-Reply-To: <bug-22593-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22593-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22593-70-2esv0VnYUD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22593 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 13:37:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 12:37:34 +0000 Subject: [Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint In-Reply-To: <bug-22008-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22008-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22008-70-vt3IYZ0zQa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #40 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Nick Clemens from comment #39) > Created attachment 86995 [details] [review] > Bug 22008: Fix failing tests Followup pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 13:38:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 12:38:19 +0000 Subject: [Koha-bugs] [Bug 22593] Scripts dealing with accountlines need updating for bug 22008 In-Reply-To: <bug-22593-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22593-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22593-70-CszYJPZOWl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22593 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |julian.maurice at biblibre.com | |, katrin.fischer at bsz-bw.de, | |kyle at bywatersolutions.com, | |m.de.rooy at rijksmuseum.nl, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 13:38:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 12:38:20 +0000 Subject: [Koha-bugs] [Bug 22593] Scripts dealing with accountlines need updating for bug 22008 In-Reply-To: <bug-22593-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22593-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22593-70-mzIvCn3Ymn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22593 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 13:42:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 12:42:12 +0000 Subject: [Koha-bugs] [Bug 22588] Simplify getting account information in opac and self checkout module In-Reply-To: <bug-22588-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22588-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22588-70-zMmMex21IE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22588 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 13:42:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 12:42:15 +0000 Subject: [Koha-bugs] [Bug 22588] Simplify getting account information in opac and self checkout module In-Reply-To: <bug-22588-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22588-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22588-70-CERTz9cWBC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22588 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87049|0 |1 is obsolete| | --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 87065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87065&action=edit Bug 22588: Simplify getting fines information in opac and selfcheckout Test plan: 0) Have patron with some fines and credits 1) Go to opac and log in 2) Go to 'your summary' page and confirm it shows the right amount and description for both, credit and debit 3) Go to 'your fines' page and confirm it show right information 4) Go to self checkout page and confirm the fines are right here Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Owen Leonard <oleonard at myacpl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 13:44:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 12:44:31 +0000 Subject: [Koha-bugs] [Bug 18969] _all field is deprecated - should use copy_to to prepare for ES6 In-Reply-To: <bug-18969-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18969-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18969-70-CjI77EJC3n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18969 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ere.maijala at helsinki.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 13:44:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 12:44:40 +0000 Subject: [Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all In-Reply-To: <bug-20589-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20589-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20589-70-BoJtPFg782@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ere.maijala at helsinki.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 13:46:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 12:46:44 +0000 Subject: [Koha-bugs] [Bug 18969] _all field is deprecated - should use copy_to to prepare for ES6 In-Reply-To: <bug-18969-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18969-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18969-70-XDXyx6f1Vf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18969 --- Comment #31 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to David Gustafsson from comment #30) > I still think bug 20589 is the way to go instead of this one for the reasons > listed above. There is a reason the _all field is deprictated and recreating > it only postpones solving the real underlying problem. I added Ere on both of these bugs - I do think 20589 might be the better path forward. After working with a library in production it does seem that searching/relevancy works better when the fields used for searching are limited -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 13:47:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 12:47:49 +0000 Subject: [Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all In-Reply-To: <bug-20589-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20589-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20589-70-MmsYiDO8GN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589 --- Comment #27 from Nick Clemens <nick at bywatersolutions.com> --- David, one request here would be to include the opac/staff columns to the mapping yaml file as well - changes that can be lost on a mapping reload are harder to track and keep in place -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 13:48:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 12:48:15 +0000 Subject: [Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future In-Reply-To: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19014-70-IYyFzRbYCT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 --- Comment #32 from Ray Delahunty <r.delahunty at arts.ac.uk> --- (In reply to Andrew from comment #26) Are we focussing too much on manipulating when the auto-renewal takes place as being the driver of limiting how many people receive renewal-failure emails? I think we need a better driver. Auto-renewing an item earlier than the moment it is due back penalises other users who may want the item. If it has already auto-renewed (early) and they place a reservation / hold on it, they will have to wait longer for it. That is why we have opted for the (admittedly harsh) situation where we only warn users that items have failed auto-renewal when they are overdue. (We use a No Renewal Before value set to zero, but we do use a long grace period.) We have multiple copies of the same item (with various loan periods) out on loan. If a reservation is placed we want to send renewal-failure notification only to users whose copy is due ?soon?, and not to people who have, say, just taken a long-term loan copy out. Native Koha auto-renewal functionality currently sees every holder of the item emailed. But the first copy returned satisfies the reservation. Why pester everyone- we want to better target the email. In comment 26 Andrew mentions what I think could be the ideal solution- a No Notice Before parameter. Rather than this being a system preference I see it better as an additional column in the Circulation & Fine rules. This would be configurable line by line (user category / item type) and allow the Koha library to email as many or as few current holders of the non-renewed items as they wished. Libraries that wanted to be more lenient that us could increase the No Renewal Before to 1, 2, or 3, say, but it would be the wise choice of a No Notice Before value that would be the best driver in targeting users whose items are likely to fulfil the reservation / hold. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 13:53:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 12:53:43 +0000 Subject: [Koha-bugs] [Bug 22592] Elasticsearch - Support for index scan In-Reply-To: <bug-22592-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22592-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22592-70-FKxHKlgqZr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 Stefan Berndtsson <stefan.berndtsson at ub.gu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stefan.berndtsson at ub.gu.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 14:08:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 13:08:04 +0000 Subject: [Koha-bugs] [Bug 22380] DefaultLongOverdueLostValue must consider business days and holidays In-Reply-To: <bug-22380-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22380-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22380-70-fuM408EcP9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22380 --- Comment #1 from Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> --- Hi, It's more related to the DefaultLongOverdueDays system preference, where you can specify a number of days. This one should take into account the calendar set in holidays.pl Regards, Marjorie -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 14:09:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 13:09:00 +0000 Subject: [Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all In-Reply-To: <bug-20589-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20589-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20589-70-5EJWoR8WmG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589 --- Comment #28 from David Gustafsson <glasklas at gmail.com> --- Yes, agree. I had forgotten about that. Should be easy to fix. Might be able to do so Friday or next week. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 14:09:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 13:09:15 +0000 Subject: [Koha-bugs] [Bug 22380] DefaultLongOverdueDays should consider the calendar set in holidays.pl In-Reply-To: <bug-22380-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22380-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22380-70-aQgYTfCeJx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22380 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|DefaultLongOverdueLostValue |DefaultLongOverdueDays |must consider business days |should consider the |and holidays |calendar set in holidays.pl -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 14:11:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 13:11:26 +0000 Subject: [Koha-bugs] [Bug 21582] Use CodeMirror for *UserJS & *UserCSS In-Reply-To: <bug-21582-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21582-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21582-70-Ja28qakQoG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21582 --- Comment #8 from Owen Leonard <oleonard at myacpl.org> --- (In reply to Martin Renvoize from comment #7) > Hmmm... perhaps I should resurrect my branch that did exactly this... Any luck? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 14:11:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 13:11:51 +0000 Subject: [Koha-bugs] [Bug 22588] Simplify getting account information in opac and self checkout module In-Reply-To: <bug-22588-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22588-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22588-70-D3s75rJ6oU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22588 --- Comment #3 from Josef Moravec <josef.moravec at gmail.com> --- > > Signed-off-by: Owen Leonard <oleonard at myacpl.org> Thanks for testing Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 14:14:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 13:14:10 +0000 Subject: [Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint In-Reply-To: <bug-22008-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22008-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22008-70-k2sZ4AaiLt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #41 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 87066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87066&action=edit Bug 22008: (follow-up) Additional test fix and fix typo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 14:15:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 13:15:08 +0000 Subject: [Koha-bugs] [Bug 18969] _all field is deprecated - should use copy_to to prepare for ES6 In-Reply-To: <bug-18969-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18969-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18969-70-0vi3lg5AdS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18969 --- Comment #32 from Ere Maijala <ere.maijala at helsinki.fi> --- I agree that bug 20589 is the proper solution. Note that at least in master include_in_all is no longer used, so the patch here is obsolete. There may be something else not in master yet, but we need at least bug 20589 to be able to configure the ES client version to use. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 14:15:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 13:15:31 +0000 Subject: [Koha-bugs] [Bug 22585] CAS login link for staff intranet is double-escaped In-Reply-To: <bug-22585-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22585-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22585-70-Kc13mYGqNZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22585 Justin Rittenhouse <jrittenh at nd.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 14:18:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 13:18:19 +0000 Subject: [Koha-bugs] [Bug 21772] Add holds and account information tab to the SCO module In-Reply-To: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21772-70-I1Qa01eFFu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87064|0 |1 is obsolete| | --- Comment #21 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 87067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87067&action=edit Bug 21772: (follow-up) Minor markup correction and reindentation This patch makes one minor markup correction: In HTML5 <tfoot> must be after <tbody>. Previously the opposite was true. I've also done a little bit of opinionated reindentation. There should be no changes visible to the user from this patch. Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 14:18:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 13:18:51 +0000 Subject: [Koha-bugs] [Bug 21772] Add holds and account information tab to the SCO module In-Reply-To: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21772-70-Oq9ySgq2KM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 --- Comment #22 from Josef Moravec <josef.moravec at gmail.com> --- (In reply to Owen Leonard from comment #20) > I hope you don't mind the minor follow-up. I can submit on a separate bug if > that's better. That's OK. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 14:51:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 13:51:05 +0000 Subject: [Koha-bugs] [Bug 22594] Validate SMS messaging numbers using the E.164 format In-Reply-To: <bug-22594-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22594-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22594-70-VYtoAjA3zh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22594 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 14:50:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 13:50:59 +0000 Subject: [Koha-bugs] [Bug 22594] New: Validate SMS messaging numbers using the E.164 format Message-ID: <bug-22594-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22594 Bug ID: 22594 Summary: Validate SMS messaging numbers using the E.164 format Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Target Milestone: --- Many SMS messaging services reject numbers that do not conform to the E.164 international public telecommunication numbering plan. On the OPAC we already We already tell patrons on the OPAC "Please enter numbers only. (123) 456-7890 would be entered as 1234567890." but we do not enforce this. We should be validating the patron's SMS number on both the staff side and the patron self-service for updating the SMS number. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 14:54:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 13:54:53 +0000 Subject: [Koha-bugs] [Bug 22593] Cronjobs/Scripts dealing with accountlines need updating for bug 22008 In-Reply-To: <bug-22593-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22593-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22593-70-B3rHXgUFZl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22593 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Scripts dealing with |Cronjobs/Scripts dealing |accountlines need updating |with accountlines need |for bug 22008 |updating for bug 22008 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 14:56:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 13:56:11 +0000 Subject: [Koha-bugs] [Bug 22594] Validate SMS messaging numbers using the E.164 format In-Reply-To: <bug-22594-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22594-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22594-70-oPIVGv2Zoh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22594 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 14:56:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 13:56:13 +0000 Subject: [Koha-bugs] [Bug 22594] Validate SMS messaging numbers using the E.164 format In-Reply-To: <bug-22594-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22594-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22594-70-por85Cge2H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22594 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 87068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87068&action=edit Bug 22594 - Validate SMS messaging numbers using the E.164 format Many SMS messaging services reject numbers that do not conform to the E.164 international public telecommunication numbering plan. We already tell patrons on the OPAC "Please enter numbers only. (123) 456-7890 would be entered as 1234567890." but we do not enforce this. We should be validating the patron's SMS number on both the staff side and the patron self-service for updating the SMS number. Test plan: 1) Apply this patch 2) Enable SMS message ( you can set to Email to enable ) 3) Test entering and updating SMS numbers on the OPAC and staff interfaces. 4) Note you can only enter a 1 to 14 digit number with an optional + sign at the beginning ( used to indicate the number includes a country calling code ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 14:59:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 13:59:11 +0000 Subject: [Koha-bugs] [Bug 22593] Cronjobs/Scripts dealing with accountlines need updating for bug 22008 In-Reply-To: <bug-22593-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22593-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22593-70-xKZimvluf8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22593 --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87069&action=edit Bug 22593: Fix bad ternaries after bug 22008 A series of ternaries were introduced when we moved to add_debit which defaulted to 'user 0' should a userenv not be set. This was incorrect as userenv may well not be set (during cronscript runs for example) and the new constraint would not allow such a default. We switch to 'undef' here to satisfy the constraint. Test plan 1) Ensure you have data in your system that would be caught by the longoverdues cronjob. 2) Ensure you're sysprefs are setup to charge for lost items 3) Run the script and varify it runs to completion without errors Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 14:59:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 13:59:53 +0000 Subject: [Koha-bugs] [Bug 22593] Cronjobs/Scripts dealing with accountlines need updating for bug 22008 In-Reply-To: <bug-22593-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22593-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22593-70-EsfqZw67D6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22593 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 15:02:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 14:02:40 +0000 Subject: [Koha-bugs] [Bug 18064] Long overdue cronjob does not follow the library's calendar and skip closed days In-Reply-To: <bug-18064-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18064-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18064-70-1lnQwmssh0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18064 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 15:04:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 14:04:39 +0000 Subject: [Koha-bugs] [Bug 22380] DefaultLongOverdueDays should consider the calendar set in holidays.pl In-Reply-To: <bug-22380-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22380-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22380-70-m8Hs7Va98V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22380 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #2 from Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> --- *** This bug has been marked as a duplicate of bug 18064 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 15:04:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 14:04:39 +0000 Subject: [Koha-bugs] [Bug 18064] Long overdue cronjob does not follow the library's calendar and skip closed days In-Reply-To: <bug-18064-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18064-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18064-70-VwsJ1p0kNz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18064 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexandre.breton at ccsr.qc.ca --- Comment #7 from Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> --- *** Bug 22380 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 15:07:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 14:07:26 +0000 Subject: [Koha-bugs] [Bug 22595] New: Items search is mixing inputs Message-ID: <bug-22595-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22595 Bug ID: 22595 Summary: Items search is mixing inputs Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Items search is using inputs and selects from search form to create an Ajax call. In this call selects are parsed before inputs. But a custom search field can be used with authorised values and used after a regular search field. In this case the "q" param is not ordered like the "name" param. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 15:08:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 14:08:32 +0000 Subject: [Koha-bugs] [Bug 22594] Validate SMS messaging numbers using the E.164 format In-Reply-To: <bug-22594-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22594-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22594-70-GW1kGZqog4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22594 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jesse at bywatersolutions.com --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- *** Bug 21623 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 15:08:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 14:08:32 +0000 Subject: [Koha-bugs] [Bug 21623] Cron job to fix SMS numbers In-Reply-To: <bug-21623-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21623-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21623-70-4qor3hHI2A@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21623 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Kind of a duplicate but not really. This bug was file for a partner and bug 21623 is the actual solution that was decided upon. *** This bug has been marked as a duplicate of bug 22594 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 15:12:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 14:12:17 +0000 Subject: [Koha-bugs] [Bug 22593] Cronjobs/Scripts dealing with accountlines need updating for bug 22008 In-Reply-To: <bug-22593-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22593-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22593-70-rucvdDpXJt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22593 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 15:12:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 14:12:17 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14825-70-tnApl4b0ZO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22593 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22593 [Bug 22593] Cronjobs/Scripts dealing with accountlines need updating for bug 22008 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 15:16:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 14:16:24 +0000 Subject: [Koha-bugs] [Bug 22594] Validate SMS messaging numbers using the E.164 format In-Reply-To: <bug-22594-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22594-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22594-70-tuwsNuP2uZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22594 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Owen Leonard <oleonard at myacpl.org> --- This looks like it's working well but I think the staff client deserves a friendly hint like the OPAC has. Nobody knows what "E.164 format" means. What about adding this: <div class="hint">SMS number should be in the format 1234567890 or +1234567890</div> ...And changing the validator message to simply "Please enter a valid phone number." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 15:21:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 14:21:22 +0000 Subject: [Koha-bugs] [Bug 22399] Improve responsive behavior of the basic marc editor In-Reply-To: <bug-22399-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22399-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22399-70-rzqsaf4tIr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Dobrica Pavlinusic <dpavlin at rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dpavlin at rot13.org Status|RESOLVED |REOPENED Resolution|FIXED |--- --- Comment #7 from Dobrica Pavlinusic <dpavlin at rot13.org> --- It seems that this patch broke javascript functionality to move subfileds up (implemented in upSubfield inside js/cataloging.js). Seems that <div id="row"> is special to this code, and this patch changes how it's used in semantic markup, this breaking editor. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 15:21:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 14:21:22 +0000 Subject: [Koha-bugs] [Bug 7890] Highlight required field in MARC editor In-Reply-To: <bug-7890-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7890-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7890-70-lbg4JJRnZy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7890 Bug 7890 depends on bug 22399, which changed state. Bug 22399 Summary: Improve responsive behavior of the basic marc editor https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 15:33:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 14:33:56 +0000 Subject: [Koha-bugs] [Bug 14109] ability to do multiple custom field searches on item search In-Reply-To: <bug-14109-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14109-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14109-70-PsfIt489D7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14109 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED CC| |fridolin.somers at biblibre.co | |m --- Comment #1 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Works now, maybe thanks to Bug 18542 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 15:35:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 14:35:45 +0000 Subject: [Koha-bugs] [Bug 22596] New: html TT filter is breaking items search with custom field Message-ID: <bug-22596-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22596 Bug ID: 22596 Summary: html TT filter is breaking items search with custom field Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- When items search is with a custom field using authorised values, html TT filter is breaking the JS, it should use raw. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 15:37:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 14:37:16 +0000 Subject: [Koha-bugs] [Bug 22596] html TT filter is breaking items search with custom field In-Reply-To: <bug-22596-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22596-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22596-70-Iub2HXCLGv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22596 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13618 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 [Bug 13618] Add additional template filter methods and a filter presence test to Koha -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 15:37:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 14:37:16 +0000 Subject: [Koha-bugs] [Bug 13618] Add additional template filter methods and a filter presence test to Koha In-Reply-To: <bug-13618-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13618-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13618-70-96VBVw5F5F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22596 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22596 [Bug 22596] html TT filter is breaking items search with custom field -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 15:37:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 14:37:32 +0000 Subject: [Koha-bugs] [Bug 22596] html TT filter is breaking items search with custom field In-Reply-To: <bug-22596-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22596-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22596-70-7qHzP0F4yh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22596 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 15:40:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 14:40:54 +0000 Subject: [Koha-bugs] [Bug 22593] Cronjobs/Scripts dealing with accountlines need updating for bug 22008 In-Reply-To: <bug-22593-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22593-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22593-70-XuKLjShtEr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22593 --- Comment #2 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Martin Renvoize from comment #0) > Currently we use 0 to indicate an action performed by command line scripts > (userenv is undef, default to 0) > > After bug 22008 we must have a real borrowernumber. > > If we simply default to 'NULL' we will no longer be able to differentiate > fines from command line from those of deleted users I believe that we can differentiate deleted users from cron users by the branchcode of the accountline - branch should remain for deleted user - I think if we deleted a branch we would want to delete the accountlines instead of NULL them also, but that is for elsewhere -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 15:41:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 14:41:57 +0000 Subject: [Koha-bugs] [Bug 22597] New: Remove "more_subfields_xml" from GetPatronInfo response (xml broken) Message-ID: <bug-22597-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22597 Bug ID: 22597 Summary: Remove "more_subfields_xml" from GetPatronInfo response (xml broken) Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Web services Assignee: koha-bugs at lists.koha-community.org Reporter: arthur.suzuki at biblibre.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Created attachment 87070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87070&action=edit BrokenXml returned from GetPatronInfo with show_loans=1 If value in more_subfields_xml contains xml opening and closing tags then xml structure in broken and response cannot be read by the third-party software. I suggest removing <more_subfields_xml> from the response as it is done for GetRecords. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 15:42:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 14:42:00 +0000 Subject: [Koha-bugs] [Bug 22596] html TT filter is breaking items search with custom field In-Reply-To: <bug-22596-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22596-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22596-70-SRvCSD7xsL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22596 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 15:42:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 14:42:03 +0000 Subject: [Koha-bugs] [Bug 22596] html TT filter is breaking items search with custom field In-Reply-To: <bug-22596-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22596-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22596-70-8m7MqCjhzB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22596 --- Comment #1 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Created attachment 87071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87071&action=edit Bug 22596: use raw TT filter in items search with custom field When items search is with a custom field using authorised values, html TT filter is breaking the JS, it should use raw. Test plan : 1) Go to Administration > Item search fields 2) Define a search field with an authorised values category 3) Go to items search 4) Use the "New field" link 5) Check use of custom field is OK -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 15:42:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 14:42:17 +0000 Subject: [Koha-bugs] [Bug 22597] Remove "more_subfields_xml" from GetPatronInfo response (xml broken) In-Reply-To: <bug-22597-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22597-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22597-70-x5f1pJXnBk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22597 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |arthur.suzuki at biblibre.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 15:42:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 14:42:19 +0000 Subject: [Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search In-Reply-To: <bug-20888-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20888-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20888-70-hupntihA85@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Depends on| |22596 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22596 [Bug 22596] html TT filter is breaking items search with custom field -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 15:42:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 14:42:19 +0000 Subject: [Koha-bugs] [Bug 22596] html TT filter is breaking items search with custom field In-Reply-To: <bug-22596-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22596-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22596-70-O1oV3wGyQT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22596 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |20888 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 [Bug 20888] Allow use of boolean operator 'not' in item search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 15:43:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 14:43:21 +0000 Subject: [Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search In-Reply-To: <bug-20888-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20888-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20888-70-siDgp9c35y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- I have created a dedicated bug for raw filter. Please rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 15:43:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 14:43:32 +0000 Subject: [Koha-bugs] [Bug 22595] Items search is mixing inputs In-Reply-To: <bug-22595-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22595-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22595-70-G0AkP7u4eF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22595 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 15:43:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 14:43:44 +0000 Subject: [Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search In-Reply-To: <bug-20888-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20888-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20888-70-yKbdzlB2Qi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22595 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 15:43:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 14:43:44 +0000 Subject: [Koha-bugs] [Bug 22595] Items search is mixing inputs In-Reply-To: <bug-22595-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22595-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22595-70-N1bTGyZJGt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22595 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20888 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 15:44:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 14:44:03 +0000 Subject: [Koha-bugs] [Bug 22595] Items search is mixing inputs In-Reply-To: <bug-22595-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22595-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22595-70-RnIl5H6Y2v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22595 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22596 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22596 [Bug 22596] html TT filter is breaking items search with custom field -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 15:44:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 14:44:03 +0000 Subject: [Koha-bugs] [Bug 22596] html TT filter is breaking items search with custom field In-Reply-To: <bug-22596-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22596-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22596-70-yk6Pd1oyCc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22596 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22595 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22595 [Bug 22595] Items search is mixing inputs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 15:45:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 14:45:32 +0000 Subject: [Koha-bugs] [Bug 22582] Authority plugin link broken by Bug 22399 In-Reply-To: <bug-22582-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22582-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22582-70-9txRsIYjjB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22582 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Authority plugin link |Authority plugin link |broken by Bug 22045 |broken by Bug 22399 Depends on|22045 |22399 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 [Bug 22045] Cataloging UX enhancement - Improve access to tabs https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 [Bug 22399] Improve responsive behavior of the basic marc editor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 15:45:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 14:45:32 +0000 Subject: [Koha-bugs] [Bug 22045] Cataloging UX enhancement - Improve access to tabs In-Reply-To: <bug-22045-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22045-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22045-70-pXo0hh8WTR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22582 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22582 [Bug 22582] Authority plugin link broken by Bug 22399 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 15:45:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 14:45:32 +0000 Subject: [Koha-bugs] [Bug 22399] Improve responsive behavior of the basic marc editor In-Reply-To: <bug-22399-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22399-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22399-70-VHXJT9lffE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22582 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22582 [Bug 22582] Authority plugin link broken by Bug 22399 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 15:48:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 14:48:28 +0000 Subject: [Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint In-Reply-To: <bug-22008-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22008-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22008-70-0w8OIPLvcK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 --- Comment #42 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87072&action=edit Bug 22008: (follow-up) Additional fix for bad test Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 15:50:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 14:50:29 +0000 Subject: [Koha-bugs] [Bug 22594] Validate SMS messaging numbers using the E.164 format In-Reply-To: <bug-22594-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22594-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22594-70-7k8P8UDLkZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22594 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 15:50:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 14:50:32 +0000 Subject: [Koha-bugs] [Bug 22594] Validate SMS messaging numbers using the E.164 format In-Reply-To: <bug-22594-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22594-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22594-70-HUKlVeAPMh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22594 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87068|0 |1 is obsolete| | --- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 87073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87073&action=edit Bug 22594 - Validate SMS messaging numbers using the E.164 format Many SMS messaging services reject numbers that do not conform to the E.164 international public telecommunication numbering plan. We already tell patrons on the OPAC "Please enter numbers only. (123) 456-7890 would be entered as 1234567890." but we do not enforce this. We should be validating the patron's SMS number on both the staff side and the patron self-service for updating the SMS number. Test plan: 1) Apply this patch 2) Enable SMS message ( you can set to Email to enable ) 3) Test entering and updating SMS numbers on the OPAC and staff interfaces. 4) Note you can only enter a 1 to 14 digit number with an optional + sign at the beginning ( used to indicate the number includes a country calling code ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 16:01:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 15:01:48 +0000 Subject: [Koha-bugs] [Bug 22597] Remove "more_subfields_xml" from GetPatronInfo response (xml broken) In-Reply-To: <bug-22597-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22597-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22597-70-odWbznHgWF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22597 --- Comment #1 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- Created attachment 87074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87074&action=edit Bug 22597 : Remove "more_subfields_xml" from GetPatronInfo response Test plan 1/ Set an item with some xml data in more_subfields_xml 2/ Issue this item to a borrower 3/ Query the webservice with GetPatronInfo methods and show_loans=1 params 4/ Check no <more_subfields_xml> tags are returned in the xml response from the webservice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 16:03:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 15:03:57 +0000 Subject: [Koha-bugs] [Bug 22593] Cronjobs/Scripts dealing with accountlines need updating for bug 22008 In-Reply-To: <bug-22593-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22593-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22593-70-lFyfbwYBAP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22593 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 16:04:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 15:04:00 +0000 Subject: [Koha-bugs] [Bug 22593] Cronjobs/Scripts dealing with accountlines need updating for bug 22008 In-Reply-To: <bug-22593-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22593-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22593-70-AtPcSbiEc3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22593 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87069|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 87075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87075&action=edit Bug 22593: Fix bad ternaries after bug 22008 A series of ternaries were introduced when we moved to add_debit which defaulted to 'user 0' should a userenv not be set. This was incorrect as userenv may well not be set (during cronscript runs for example) and the new constraint would not allow such a default. We switch to 'undef' here to satisfy the constraint. Test plan 1) Ensure you have data in your system that would be caught by the longoverdues cronjob. 2) Ensure you're sysprefs are setup to charge for lost items 3) Run the script and varify it runs to completion without errors Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 16:06:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 15:06:10 +0000 Subject: [Koha-bugs] [Bug 21622] Incorrect GROUP BY clause in acqui/ scripts In-Reply-To: <bug-21622-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21622-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21622-70-8zCjYgELZ0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21622 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 16:07:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 15:07:14 +0000 Subject: [Koha-bugs] [Bug 21622] Incorrect GROUP BY clause in acqui/ scripts In-Reply-To: <bug-21622-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21622-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21622-70-Z4ucMAnWEG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21622 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 16:11:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 15:11:48 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20256-70-HM0crjS1F9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Development: Limit |Add ability to limit |view/edit of items to home |editing of items to home |library |library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 16:21:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 15:21:14 +0000 Subject: [Koha-bugs] [Bug 13618] Add additional template filter methods and a filter presence test to Koha In-Reply-To: <bug-13618-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13618-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13618-70-lwUFWY80qd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22586 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22586 [Bug 22586] IntranetReportsHomeHTML no longer renders as HTML on reports-home.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 16:21:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 15:21:14 +0000 Subject: [Koha-bugs] [Bug 22586] IntranetReportsHomeHTML no longer renders as HTML on reports-home.pl In-Reply-To: <bug-22586-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22586-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22586-70-FpxVqIhqz5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22586 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |13618 CC| |nick at bywatersolutions.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 [Bug 13618] Add additional template filter methods and a filter presence test to Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 16:24:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 15:24:29 +0000 Subject: [Koha-bugs] [Bug 22597] Remove "more_subfields_xml" from GetPatronInfo response (xml broken) In-Reply-To: <bug-22597-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22597-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22597-70-RlJlRwR0hq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22597 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 16:31:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 15:31:03 +0000 Subject: [Koha-bugs] [Bug 22595] Items search is mixing inputs In-Reply-To: <bug-22595-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22595-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22595-70-vQiithnOVJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22595 --- Comment #1 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Created attachment 87076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87076&action=edit Bug 22595: Items search is mixing inputs Items search is using inputs and selects from search form to create an Ajax call. In this call selects are parsed before inputs. But a custom search field can be used with authorised values and used after a regular search field. In this case the "q" param is not ordered like the "name" param. Test plan : 1) Go to Administration > Item search fields 2) Define a search field with an authorised values category 3) Go to items search 4) Use a regular filter like call number 5) Click on new field 6) Use custom field with an authorised value 7) Perform search => Without patch you get wrong resuts, authorised value is used as value for first field => You can see this by listening traffic in Firebug, look at params "f" and "q" 8) Check some combinaison of select and input filters -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 16:31:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 15:31:56 +0000 Subject: [Koha-bugs] [Bug 22595] Items search is mixing inputs In-Reply-To: <bug-22595-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22595-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22595-70-Q2EvuqGDNG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22595 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 16:32:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 15:32:18 +0000 Subject: [Koha-bugs] [Bug 22595] Items search is mixing inputs In-Reply-To: <bug-22595-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22595-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22595-70-BERIHepm2Q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22595 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 16:49:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 15:49:27 +0000 Subject: [Koha-bugs] [Bug 19722] Add a MaxItemsToDisplayForBatchMod preference In-Reply-To: <bug-19722-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19722-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19722-70-nnbjnxakwD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19722 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 16:49:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 15:49:55 +0000 Subject: [Koha-bugs] [Bug 19722] Add a MaxItemsToDisplayForBatchMod preference In-Reply-To: <bug-19722-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19722-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19722-70-z1LrXWfwKA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19722 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 16:49:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 15:49:59 +0000 Subject: [Koha-bugs] [Bug 19722] Add a MaxItemsToDisplayForBatchMod preference In-Reply-To: <bug-19722-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19722-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19722-70-3CQifggELg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19722 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87033|0 |1 is obsolete| | Attachment #87034|0 |1 is obsolete| | Attachment #87035|0 |1 is obsolete| | --- Comment #16 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 87077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87077&action=edit Bug 19722: Add MaxItemsToDisplayForBatchMod systempreference To test: 1 - Get a list of itemnumbers or barcodes 2 - Set MaxItemsToProcessForBatchMod to less than this number of items 3 - Attempt to batch edit, you arent allowed 4 - Set MaxItemsToProcessForBatchMod to some hugh number like 60000 5 - Try a list of as many items as possible 30000 was good for me (they should exist in your system) 6 - Try to batch edit, system will timeout on displaying these items 7 - Apply patch, update database 8 - Set MaxItemsToDisplayForBatchMod to 1000 (default) 9 - Try large file again, should not display items, but allow modification, wait for this to finish 10 - SetMaxItemsToProcessForBatchMod to 1000 and try large file again 11 - Should be prohibited as before Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 16:50:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 15:50:03 +0000 Subject: [Koha-bugs] [Bug 19722] Add a MaxItemsToDisplayForBatchMod preference In-Reply-To: <bug-19722-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19722-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19722-70-dyUBV5uB3S@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19722 --- Comment #17 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 87078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87078&action=edit Bug 19722: (follow-up) Adjust template parameters Before we passed 'too_many_items' this was renamed to 'too_many_items_display' but deletion template lacked changes To test: 1 - Test a batch deletion by list and file 2 - Test with deleting biblios and without 3 - Results should be as expected Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 16:50:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 15:50:07 +0000 Subject: [Koha-bugs] [Bug 19722] Add a MaxItemsToDisplayForBatchMod preference In-Reply-To: <bug-19722-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19722-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19722-70-lzXqlauMAE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19722 --- Comment #18 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 87079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87079&action=edit Bug 19722: Don't show items at job completion if over pref To test: 1 - Set MaxItemsToDisplayForBatchMod to some number 2 - Modify less items than that 3 - Note they show a - Note if over 1000 they show in a simple display 4 - Modify more items 5 - Note they do not show and you see a note Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 16:53:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 15:53:26 +0000 Subject: [Koha-bugs] [Bug 22501] OPAC course reserves notes should allow html links In-Reply-To: <bug-22501-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22501-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22501-70-V4AlRzP7DE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |lucas at bywatersolutions.com CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 16:55:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 15:55:53 +0000 Subject: [Koha-bugs] [Bug 22593] Cronjobs/Scripts dealing with accountlines need updating for bug 22008 In-Reply-To: <bug-22593-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22593-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22593-70-7jE1zPNxGn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22593 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14825 |22518, 22512, 22547 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 [Bug 22512] accountlines.accountype mixes 'state' and 'type' https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22518 [Bug 22518] accounttype 'O' is still referred to but is never set https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22547 [Bug 22547] C4::Overdues - UpdateFine is barely tested -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 16:55:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 15:55:53 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14825-70-t1baoD1nUP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|22593 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22593 [Bug 22593] Cronjobs/Scripts dealing with accountlines need updating for bug 22008 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 16:55:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 15:55:53 +0000 Subject: [Koha-bugs] [Bug 22512] accountlines.accountype mixes 'state' and 'type' In-Reply-To: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22512-70-jTB1HJ5tN4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22593 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22593 [Bug 22593] Cronjobs/Scripts dealing with accountlines need updating for bug 22008 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 16:55:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 15:55:53 +0000 Subject: [Koha-bugs] [Bug 22518] accounttype 'O' is still referred to but is never set In-Reply-To: <bug-22518-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22518-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22518-70-QsVkfXqRNU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22518 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22593 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22593 [Bug 22593] Cronjobs/Scripts dealing with accountlines need updating for bug 22008 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 16:55:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 15:55:53 +0000 Subject: [Koha-bugs] [Bug 22547] C4::Overdues - UpdateFine is barely tested In-Reply-To: <bug-22547-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22547-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22547-70-6KdjiEBp3R@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22547 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22593 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22593 [Bug 22593] Cronjobs/Scripts dealing with accountlines need updating for bug 22008 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 16:56:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 15:56:31 +0000 Subject: [Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint In-Reply-To: <bug-22008-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22008-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22008-70-MkLEufTK82@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22421 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 [Bug 22421] accountlines.issue_id is missing a foreign key constraint -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 16:56:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 15:56:31 +0000 Subject: [Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint In-Reply-To: <bug-22421-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22421-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22421-70-WQO28wL8pL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|22008 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 [Bug 22008] accountlines.manager_id is missing a foreign key constraint -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 17:05:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 16:05:16 +0000 Subject: [Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior In-Reply-To: <bug-10577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10577-70-qZzs3p8ezR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87009|0 |1 is obsolete| | --- Comment #12 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 87080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87080&action=edit Bug 10577: Improve semantics of GetBudgetPeriod() Remove the option to pass zero to this function in order to get "the" active budget. This was a problem in three ways: - Koha doesn't require that there be only one active budget at a time, so the concept of "the" active budget doesn't make sense. - Having the single parameter be either an ID or a flag based on its value is poor function design. - No callers of GetBudgetPeriod() were actually using this modality. This patch also improves the DB-dependent tests for budgets by - wrapping the test in a transaction - counting budgets correctly To test: [1] Apply the patch. [2] Verify that prove -v t/db_dependent/Budgets.t passes [3] Verify in the staff interface that: - the budget hierarchy displays correctly - you can add and modify a budget Signed-off-by: Galen Charlton <gmc at esilibrary.com> Rescued-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 17:05:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 16:05:19 +0000 Subject: [Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior In-Reply-To: <bug-10577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10577-70-sPdTGCgHSi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87010|0 |1 is obsolete| | --- Comment #13 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 87081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87081&action=edit Bug 10577: (QA follow-up) Remove bad call signature Whilst working through this patch for signoff I found a case where the calling signature of GetBudgetPeriod was incorrect. I removed the superflous passed parameter in this followup Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 17:05:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 16:05:23 +0000 Subject: [Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior In-Reply-To: <bug-10577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10577-70-Q8Dxdhz3aF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 --- Comment #14 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 87082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87082&action=edit Bug 10577: (QA follow-up) Remove tab chars Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 17:05:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 16:05:54 +0000 Subject: [Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior In-Reply-To: <bug-10577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10577-70-PEWGM9QIwX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com QA Contact| |josef.moravec at gmail.com Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 17:07:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 16:07:50 +0000 Subject: [Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all In-Reply-To: <bug-20589-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20589-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20589-70-KavfPZV95r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 17:16:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 16:16:41 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-BdlYJFEzCi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86918|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87083&action=edit Bug 22521: Increase varchar size for accounttype accountlines.accounttype is currently a short varchar(5) field for to store accounttype codes. Koha is moving towards more descriptive codes which require a larger capacity varchar(16). Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 17:16:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 16:16:47 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-0yOvMnpMAf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86920|0 |1 is obsolete| | --- Comment #27 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87085&action=edit Bug 22521: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 17:16:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 16:16:44 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-2ilibb9wwz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86919|0 |1 is obsolete| | --- Comment #26 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87084&action=edit Bug 22521: Update fines handling to use accountline.status Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 17:16:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 16:16:50 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-OjbLBajOKu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86921|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87086&action=edit Bug 22521: Update existing accounttypes Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 17:16:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 16:16:54 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-VgqqHC8F6g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87063|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87087&action=edit Bug 22521: (QA follow-up) Corrections to tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 17:17:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 16:17:21 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-U2CjGak0YE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 17:18:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 16:18:15 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit In-Reply-To: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22511-70-XBj2gK3DKX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86915|0 |1 is obsolete| | --- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87088&action=edit Bug 22511: Update tests Updated tests to check for 'status' change and fixed 'accounttype' and moved from t/db_dependent/Accounts.t to the more appropriate t/db_dependent/Koha/Account/Lines.t Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 17:18:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 16:18:18 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit In-Reply-To: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22511-70-9Q7AuNUGFT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86916|0 |1 is obsolete| | --- Comment #19 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87089&action=edit Bug 22511: Update void method to use status We added a 'status' field to 'accountlines' in bug 22512 to allow for more fined grained control over 'types' and 'states'. This patch updates the void method to utilise this new field so we may keep the original credit type for later auditing should it be required. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 17:18:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 16:18:21 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit In-Reply-To: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22511-70-UbXo6PY8SQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86917|0 |1 is obsolete| | --- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87090&action=edit Bug 22511: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 17:18:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 16:18:25 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit In-Reply-To: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22511-70-zkZt2EbmYs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 --- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87091&action=edit Bug 22511: (follow-up) Fix test plans Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 17:18:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 16:18:57 +0000 Subject: [Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes In-Reply-To: <bug-22563-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22563-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22563-70-qqJM9YGF4g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86913|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87092&action=edit Bug 22563: Be more descriptive with accountypes Convert 'L' to 'LOST' to become more descriptive in it's use. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 17:19:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 16:19:00 +0000 Subject: [Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes In-Reply-To: <bug-22563-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22563-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22563-70-eNL867o48W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86914|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87093&action=edit Bug 22563: Update lost handling to use accountline.status Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 17:19:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 16:19:03 +0000 Subject: [Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes In-Reply-To: <bug-22563-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22563-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22563-70-KGK3W4po91@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87094&action=edit Bug 22563: (follow-up) Corrections for tests Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 17:27:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 16:27:55 +0000 Subject: [Koha-bugs] [Bug 22598] New: Add support for EDI Claims for Serials (OSTENQ) Message-ID: <bug-22598-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22598 Bug ID: 22598 Summary: Add support for EDI Claims for Serials (OSTENQ) Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.field at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com Target Milestone: --- EBSCO (and potentially other serials vendors) support the receipt of EDIFACT Claims using the OSTENQ format (Order Status Enquiry). https://www.editeur.org/files/EDIfact%20eancom%20pdfs/EDIfact%20Serials/S4%20OSTENQ%20v1.3%20(serials).pdf They require the EBSCO Vendor Order Number in the RFF+SNA segment as the match point to identify the customer order in their system. Volume and Issue details for the items being claimed would also be required. Development to add KOHA as an ILS Vendor for claims would be required on the EBSCO end as well before we could do any testing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 17:31:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 16:31:50 +0000 Subject: [Koha-bugs] [Bug 22586] IntranetReportsHomeHTML no longer renders as HTML on reports-home.pl In-Reply-To: <bug-22586-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22586-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22586-70-GJiQRWmKqf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22586 --- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 87095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87095&action=edit Bug 22586: fix IntranetReportsHomeHTML filter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 17:41:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 16:41:23 +0000 Subject: [Koha-bugs] [Bug 22586] IntranetReportsHomeHTML no longer renders as HTML on reports-home.pl In-Reply-To: <bug-22586-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22586-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22586-70-6ATg4b1ARp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22586 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 17:41:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 16:41:25 +0000 Subject: [Koha-bugs] [Bug 22586] IntranetReportsHomeHTML no longer renders as HTML on reports-home.pl In-Reply-To: <bug-22586-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22586-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22586-70-HKqE14K9gX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22586 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87095|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 87096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87096&action=edit Bug 22586: IntranetReportsHomeHTML no longer renders as HTML on reports-home.pl As of 18.11 the IntranetReportsHomeHTML syspref no longer renders HTML on report-home.pl. I think this is being filtered wrong in the template. Test Plan: 1) Edit IntranetReportsHomeHTML, set to "<p>Test</p>" 2) View a report, note that you see the html p tags are displayed litterly 3) Apply this patch 4) Reload the page 5) Note the p tags are rendered as html -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 17:47:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 16:47:28 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-iyR768wavB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 17:47:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 16:47:31 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-abkeQ5gk9l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87083|0 |1 is obsolete| | Attachment #87084|0 |1 is obsolete| | Attachment #87085|0 |1 is obsolete| | Attachment #87086|0 |1 is obsolete| | Attachment #87087|0 |1 is obsolete| | --- Comment #30 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 87097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87097&action=edit Bug 22521: Increase varchar size for accounttype accountlines.accounttype is currently a short varchar(5) field for to store accounttype codes. Koha is moving towards more descriptive codes which require a larger capacity varchar(16). Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 17:47:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 16:47:34 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-xpYya8p7Gn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #31 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 87098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87098&action=edit Bug 22521: Update fines handling to use accountline.status Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 17:47:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 16:47:38 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-uUTVFj9x79@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #32 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 87099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87099&action=edit Bug 22521: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 17:47:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 16:47:41 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-bJdKtikVbU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #33 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 87100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87100&action=edit Bug 22521: Update existing accounttypes Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 17:47:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 16:47:45 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-kCdHXWJFdt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #34 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 87101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87101&action=edit Bug 22521: (QA follow-up) Corrections to tests Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 17:58:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 16:58:26 +0000 Subject: [Koha-bugs] [Bug 18745] Serial claims: save supplier info on serial-level In-Reply-To: <bug-18745-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18745-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18745-70-OW8OFkFczk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65791|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 17:58:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 16:58:42 +0000 Subject: [Koha-bugs] [Bug 18745] Serial claims: save supplier info on serial-level In-Reply-To: <bug-18745-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18745-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18745-70-II99vlnw2O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #64083|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 18:10:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 17:10:44 +0000 Subject: [Koha-bugs] [Bug 18745] Serial claims: save supplier info on serial-level In-Reply-To: <bug-18745-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18745-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18745-70-Jn4EWiENxz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85240|0 |1 is obsolete| | --- Comment #15 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 87102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87102&action=edit Bug 18745: Serial claims: save supplier info on serial-level This allows to change the subscription's supplier while keeping the info of supplier for previous serials, which allows to claim late/missing serials to the right supplier Test plan: 1. Create 2 suppliers, S1 and S2 2. Create a new subscription with S1 3. Generate some late/missing serials 4. Change supplier to S2 5. Generate some more late/missing serials 6. Go to /cgi-bin/koha/serials/claims.pl and see you have late/missing issues for both suppliers 7. Check that you have the expected issues for each supplier 8. prove t/db_dependent/Serials/Claims.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 18:10:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 17:10:50 +0000 Subject: [Koha-bugs] [Bug 18745] Serial claims: save supplier info on serial-level In-Reply-To: <bug-18745-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18745-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18745-70-zmAGgTOFzO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85241|0 |1 is obsolete| | --- Comment #16 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 87103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87103&action=edit Bug 18745: kohastructure.sql: Move aqbooksellers above serial Otherwise we can't define a foreign key in serial that references aqbooksellers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 18:10:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 17:10:53 +0000 Subject: [Koha-bugs] [Bug 18745] Serial claims: save supplier info on serial-level In-Reply-To: <bug-18745-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18745-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18745-70-uT5UXLMyhv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18745 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85242|0 |1 is obsolete| | --- Comment #17 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 87104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87104&action=edit Bug 18745: Add foreign key constraint on subscription.aqbooksellerid -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 18:23:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 17:23:49 +0000 Subject: [Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13895-70-aA7Q2IyJtU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 18:23:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 17:23:53 +0000 Subject: [Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13895-70-9txAY8ydWQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86120|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 18:23:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 17:23:56 +0000 Subject: [Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13895-70-7eJgkQQoqg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86579|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 18:24:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 17:24:00 +0000 Subject: [Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13895-70-mlw6IQ75NP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85458|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 18:24:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 17:24:04 +0000 Subject: [Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13895-70-8OUIFqhLgF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85459|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 18:24:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 17:24:07 +0000 Subject: [Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13895-70-lV8F8PJRQc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85460|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 18:24:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 17:24:11 +0000 Subject: [Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13895-70-EagiSskDR3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85461|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 18:24:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 17:24:15 +0000 Subject: [Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13895-70-Xhud07fv6j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85462|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 18:24:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 17:24:19 +0000 Subject: [Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13895-70-cqe1xFf3Yq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85463|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 18:24:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 17:24:23 +0000 Subject: [Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13895-70-2LEwNDIifk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85464|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 18:24:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 17:24:27 +0000 Subject: [Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13895-70-Ycsl2jkz3z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86580|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 18:27:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 17:27:11 +0000 Subject: [Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13895-70-FIZEwxuhgj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 --- Comment #72 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 87105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87105&action=edit Bug 13895: Add API routes for checkouts retrieval and renewal GET /checkouts?borrowernumber={borrowernumber} GET /checkouts/{checkout_id} PUT /checkouts/{checkout_id} + unit tests in t/db_dependent/api/v1/checkouts.t Test plan: 1. Open a browser tab on Koha staff and log in (to create CGISESSID cookie). You should have permission circulate_remaining_permissions. 2. Go to http://yourlibrary/api/v1/checkouts?borrowernumber=XXX (replace XXX with a borrowernumber that has checkouts) and check you receive correct data 3. Go to http://yourlibrary/api/v1/checkouts/YYY (replace YYY with an existing checkout id) and check you receive correct data 4. Send PUT requests to http://yourlibrary/api/v1/checkouts/YYY until the maximum number of renewals is reached (you should have a 403 error) 5. Run unit tests in t/db_dependent/api/v1/checkouts.t Depends on bugs 16699 and 14868 Signed-off-by: Benjamin Rokseth <benjamin.rokseth at kul.oslo.kommune.no> Signed-off-by: Lari Taskula <larit at student.uef.fi> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 18:27:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 17:27:17 +0000 Subject: [Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13895-70-dIbEKHbLL5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 --- Comment #73 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 87106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87106&action=edit Bug 13895: (QA follow-up) Adjust OpenAPI definitions for checkouts Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 18:27:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 17:27:23 +0000 Subject: [Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13895-70-JRmJnmyh8Q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 --- Comment #74 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 87107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87107&action=edit Bug 13895: (follow-up) Adapt checkout endpoint to openapi, update terminology -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 18:27:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 17:27:28 +0000 Subject: [Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13895-70-rT4My4WwRD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 --- Comment #75 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 87108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87108&action=edit Bug 13895: Remove the opac checks in privileged endpoint Test plan: prove t/db_dependent/api/v1/checkouts.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 18:27:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 17:27:33 +0000 Subject: [Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13895-70-H6KDABDs41@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 --- Comment #76 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 87109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87109&action=edit Bug 13895: Remove create_item and create_biblio subs from test Test plan: prove t/db_dependent/api/v1/checkouts.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 18:27:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 17:27:38 +0000 Subject: [Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13895-70-fcq34RW4Ex@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 --- Comment #77 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 87110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87110&action=edit Bug 13895: Refactor test using REST Basic auth Test plan: prove t/db_dependent/api/v1/checkouts.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 18:27:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 17:27:43 +0000 Subject: [Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13895-70-22SWvUA1lS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 --- Comment #78 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 87111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87111&action=edit Bug 13895: Change renewal endpoint Instead of PUT on /checkout/{checkout_id} endpoint, you should now call POST on /checkouts/{checkout_id}/renewal Test plan: prove t/db_dependent/api/v1/checkouts.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 18:27:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 17:27:47 +0000 Subject: [Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13895-70-yaygmwyP8E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 --- Comment #79 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 87112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87112&action=edit Bug 13895: (follow-up) Fix POST response Test plan: prove t/db_dependent/api/v1/chcekouts.t Signed-off-by: Michal Denar <black23 at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 18:27:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 17:27:52 +0000 Subject: [Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13895-70-WqzT0lV0D7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 --- Comment #80 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 87113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87113&action=edit Bug 13895: Adapt naming according to voted RFC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 18:27:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 17:27:57 +0000 Subject: [Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13895-70-liSH2AprrQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 --- Comment #81 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 87114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87114&action=edit Bug 13895: Fix test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 18:28:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 17:28:02 +0000 Subject: [Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13895-70-t18FK3Firj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 --- Comment #82 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- Created attachment 87115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87115&action=edit Bug 13895: (QA follow-up) Make the class plural Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 18:38:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 17:38:41 +0000 Subject: [Koha-bugs] [Bug 21772] Add holds and account information tab to the SCO module In-Reply-To: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21772-70-5cFM95bcSC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 --- Comment #23 from Agust?n Moyano <agustinmoyano at theke.io> --- (In reply to Owen Leonard from comment #20) > I hope you don't mind the minor follow-up. I can submit on a separate bug if > that's better. Looks great, thanks :D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 18:51:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 17:51:28 +0000 Subject: [Koha-bugs] [Bug 22588] Simplify getting account information in opac and self checkout module In-Reply-To: <bug-22588-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22588-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22588-70-vDR36aETai@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22588 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #4 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- I like the idea in general but: - shouldn't we be using line.{is_debit|is_credit} instead of comparing line.amount > 0? Keep in mind that we found pathological cases in the wild where the amountoutstanding got flipped. We better rely on the methods we have. - The fact that we aren't using $account->outstanding_debits and $account->outstanding_credits but instead keep searching for all accountlines makes some noise to me. I guess it is not straightforward as we want to display all outstanding debits and credits ordered by date. Just something to think about a bit. Maybe we should add amountountstanding => { '!=' => 0 } to the search line. - We could replace the search with my $account = $patron->account; my $total = $account->balance; my $lines = $account->lines; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 18:59:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 17:59:47 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-6Onyx8YTXm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #35 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- (In reply to Josef Moravec from comment #21) > Comment on attachment 86919 [details] [review] > Bug 22521: Update fines handling to use accountline.status > > Review of attachment 86919 [details] [review]: > ----------------------------------------------------------------- > > ::: Koha/Account.pm > @@ +471,4 @@ > > itemnumber => $item_id, > > issue_id => $issue_id, > > branchcode => $library_id, > > + ( $type eq 'overdue' ? ( lastincrement => $amount ) : ()), > > Does it make sense to you to make this dependent also on 22516, which > removes lastincrement column? Thanks for the quick testing and signoff. Can't believe I let those tests slip through in that state. As for the dependency on bug 22516.. Isort of agree but didn't want to make the tree look too complicated.. hopefully it'll be pushed imminently and it should be a trivial rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 20:24:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 19:24:50 +0000 Subject: [Koha-bugs] [Bug 22586] IntranetReportsHomeHTML no longer renders as HTML on reports-home.pl In-Reply-To: <bug-22586-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22586-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22586-70-O04jyoqvBM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22586 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87096|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 87116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87116&action=edit Bug 22586: IntranetReportsHomeHTML no longer renders as HTML on reports-home.pl As of 18.11 the IntranetReportsHomeHTML syspref no longer renders HTML on report-home.pl. I think this is being filtered wrong in the template. Test Plan: 1) Edit IntranetReportsHomeHTML, set to "<p>Test</p>" 2) View a report, note that you see the html p tags are displayed litterly 3) Apply this patch 4) Reload the page 5) Note the p tags are rendered as html Signed-off-by: George Williams <george at nekls.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 20:28:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 19:28:42 +0000 Subject: [Koha-bugs] [Bug 10796] Allow OpacPasswordChange to be set by category type In-Reply-To: <bug-10796-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10796-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10796-70-x0n7eFsybH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10796 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 20:28:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 19:28:45 +0000 Subject: [Koha-bugs] [Bug 10796] Allow OpacPasswordChange to be set by category type In-Reply-To: <bug-10796-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10796-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10796-70-vkPofRnwhc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10796 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85389|0 |1 is obsolete| | Attachment #85390|0 |1 is obsolete| | Attachment #85391|0 |1 is obsolete| | Attachment #85392|0 |1 is obsolete| | --- Comment #7 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 87117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87117&action=edit Bug 10796: DB update Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 20:28:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 19:28:48 +0000 Subject: [Koha-bugs] [Bug 10796] Allow OpacPasswordChange to be set by category type In-Reply-To: <bug-10796-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10796-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10796-70-GEupU6u2wA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10796 --- Comment #8 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 87118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87118&action=edit Bug 10796: Add Koha::Patron::Category->effective_change_password method This method checks whether the local $self->change_password is set to override the OpacPasswordChange syspref (i.e. if it is set to a bool) or undef, in which case it falls back to the value of the syspref To test: - Apply this patches - Make sure the DB is updated: $ updatedatabase - Update the schema files: $ dbic - Run: $ kshell k$ prove t/db_dependent/Koha/Patron/Category.t => SUCCESS: Tests pass! - Sign off :-D Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 20:28:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 19:28:51 +0000 Subject: [Koha-bugs] [Bug 10796] Allow OpacPasswordChange to be set by category type In-Reply-To: <bug-10796-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10796-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10796-70-ULj39ADa9W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10796 --- Comment #9 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 87119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87119&action=edit Bug 10796: Handle can_change_password on the staff interface This patch makes the staff interface handle the new flag when editing the categories. I didn't add the flag to the list of categories table because it makes it too big, but can be easily added if required by users or QA. To test: - Along with other patches from this bug, edit patron categories => SUCCESS: Notice the changes are correctly stored - Sign off :-D Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 20:28:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 19:28:53 +0000 Subject: [Koha-bugs] [Bug 10796] Allow OpacPasswordChange to be set by category type In-Reply-To: <bug-10796-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10796-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10796-70-JD4XWx6qdB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10796 --- Comment #10 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 87120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87120&action=edit Bug 10796: Use $category->effective_change_password in the OPAC This patch makes the OPAC pages that rely on OpacPasswordChange use the current patron's category to make the decision to allow password change or not. It does so by making sure all the places in which OpacPasswordChange was used, use $logged_in_user->category->effective_change_password instead. Special attention is required on the case of opac-registration-verify.pl in which the use of an unblessed Koha::Patron object is changed in favour of the blessed object, so we can actually use the new method to make a decision on the text to display. To test: - Go through the OPAC pages, check that the password change strings and links are displayed only whne appropriate. - Sign off :-D Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 20:28:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 19:28:56 +0000 Subject: [Koha-bugs] [Bug 10796] Allow OpacPasswordChange to be set by category type In-Reply-To: <bug-10796-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10796-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10796-70-73FzssM4E0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10796 --- Comment #11 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 87121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87121&action=edit Bug 10796: (QA Follow-up) Changing password recovery verbiage for users who are disallowed online password resets -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 20:35:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 19:35:29 +0000 Subject: [Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user In-Reply-To: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22577-70-Xn8WQ7CDs3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 --- Comment #32 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Well, I've de-escalated this one by resolving the constraint problem a simpler way in bug 22593. So, this now serves as proof of concept code which could let us further constrain some things in the database and allow for other uses of system type users (anonymous user seems a good case, splitting up Cron, command line scripts). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 20:37:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 19:37:19 +0000 Subject: [Koha-bugs] [Bug 10796] Allow OpacPasswordChange to be set by category type In-Reply-To: <bug-10796-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10796-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10796-70-HoZ8BMgs4Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10796 --- Comment #12 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- (In reply to Liz Rea from comment #11) > Created attachment 87121 [details] [review] > Bug 10796: (QA Follow-up) Changing password recovery verbiage for users who > are disallowed online password resets Thank you!!! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 20:40:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 19:40:51 +0000 Subject: [Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user In-Reply-To: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22577-70-JAXIEfdh5p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 --- Comment #33 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- (In reply to Katrin Fischer from comment #30) > > It just appears to me like thsi approach will open anoher can of worms. > > - Which homelibrary to use for those users? > - Which patron category? > - How to keep people from deleting or changing them? > - How to prevent that they change statistics in an unwanted way? (if they > have a branch and a patron category) No homelibrary, see patches No categorycode, see patches We can't if they're doing so directly in the db or a home grown script. But the patch does attemp to prevent it if they're using Koha object as they should. We also prevent these users from being searched at a pretty low level in code, see patches. As I saw, this is all now proof of concept code open for opinion and discussion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 20:55:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 19:55:46 +0000 Subject: [Koha-bugs] [Bug 18062] Damaged Status shows unavailable in results In-Reply-To: <bug-18062-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18062-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18062-70-85iRnAviwE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18062 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 21:02:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 20:02:04 +0000 Subject: [Koha-bugs] [Bug 21014] Availability of hidden items showing in OPAC In-Reply-To: <bug-21014-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21014-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21014-70-W8q3jL45vW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21014 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 21:09:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 20:09:21 +0000 Subject: [Koha-bugs] [Bug 21014] Availability of hidden items showing in OPAC In-Reply-To: <bug-21014-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21014-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21014-70-wIuaZp8Gc4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21014 --- Comment #3 from Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> --- Hi, I repeat this problem with the system preference hidelostitems on 18.05, you too? Marjorie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 22:09:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 21:09:04 +0000 Subject: [Koha-bugs] [Bug 22594] Validate SMS messaging numbers using the E.164 format In-Reply-To: <bug-22594-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22594-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22594-70-Ek0s7vJvDF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22594 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 22:09:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 21:09:07 +0000 Subject: [Koha-bugs] [Bug 22594] Validate SMS messaging numbers using the E.164 format In-Reply-To: <bug-22594-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22594-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22594-70-7tYaKUXKYK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22594 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87073|0 |1 is obsolete| | --- Comment #5 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 87122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87122&action=edit Bug 22594: Validate SMS messaging numbers using the E.164 format Many SMS messaging services reject numbers that do not conform to the E.164 international public telecommunication numbering plan. We already tell patrons on the OPAC "Please enter numbers only. (123) 456-7890 would be entered as 1234567890." but we do not enforce this. We should be validating the patron's SMS number on both the staff side and the patron self-service for updating the SMS number. Test plan: 1) Apply this patch 2) Enable SMS message ( you can set to Email to enable ) 3) Test entering and updating SMS numbers on the OPAC and staff interfaces. 4) Note you can only enter a 1 to 14 digit number with an optional + sign at the beginning ( used to indicate the number includes a country calling code ) Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 22:16:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 21:16:35 +0000 Subject: [Koha-bugs] [Bug 22596] html TT filter is breaking items search with custom field In-Reply-To: <bug-22596-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22596-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22596-70-fi1CyxTj2m@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22596 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87071|0 |1 is obsolete| | --- Comment #2 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 87123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87123&action=edit Bug 22596: use raw TT filter in items search with custom field When items search is with a custom field using authorised values, html TT filter is breaking the JS, it should use raw. Test plan : 1) Go to Administration > Item search fields 2) Define a search field with an authorised values category 3) Go to items search 4) Use the "New field" link 5) Check use of custom field is OK Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 22:16:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 21:16:33 +0000 Subject: [Koha-bugs] [Bug 22596] html TT filter is breaking items search with custom field In-Reply-To: <bug-22596-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22596-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22596-70-pGez7LKx6E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22596 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 22:56:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 21:56:31 +0000 Subject: [Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased In-Reply-To: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18308-70-NMoKBvsJGK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308 --- Comment #24 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Created attachment 87124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87124&action=edit Bug 18308: (follow up) Changed order of onboarding steps This patch cleans up the previous patches according to comment 23, fixes various typos, and changes the order of steps in the onboarding so that the setting of minPasswordLength occurs before the admin password is set. Test plan: 1) Drop and recreate your database, and restart_all 2) Go through installation and onboarding 3) Note that the order of steps is: 1 Create a library 2 Create a ptron category 3 Create Koha administrator patron 4 Create a new item type 5 Create a new circulation rule 6 Set minPasswordLength syspref/Complete 4) Repeat steps 1 & 2 5) Note that the order of steps is now: 1 Create a library 2 Create a patron category 3 Set minPasswordLength syspref 4 Create Koha administrator patron 5 Create a new item type 6 Create a new circulation rule/Complete 6) Verify that the minPasswordLength syspref is set to the value from onboarding 7) Verify that the patron, item type, and circulation rule made in the onboarding exist in the administration 8) Sign off! Sponsored-by Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 22:57:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 21:57:20 +0000 Subject: [Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased In-Reply-To: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18308-70-C4Y3J3109l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 22:57:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 21:57:23 +0000 Subject: [Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased In-Reply-To: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18308-70-pkTh63jN1w@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308 --- Comment #25 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Created attachment 87125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87125&action=edit Bug 18308: Fixed whitespace for qa tool Note: This will still fail qa tool due to 'forbidden' javascript fullpath and not use of Asset plugin. Asset plugin cannot be used for onboarding currently. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Mar 27 23:19:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 22:19:53 +0000 Subject: [Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased In-Reply-To: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18308-70-fHcmYfoukC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308 --- Comment #26 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Created attachment 87126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87126&action=edit Bug 18308: Added missing filters Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 00:24:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 23:24:38 +0000 Subject: [Koha-bugs] [Bug 22501] OPAC course reserves notes should allow html links In-Reply-To: <bug-22501-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22501-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22501-70-6ePGX62EXM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501 --- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 87127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87127&action=edit Attachment to Bug 22501 - OPAC course reserves notes should allow html links Bug 22501: OPAC course reserves notes should allow html links Test Plan: 1. Add a new course a put '<a href=""></a>' in the public not field. 2. Go to the course in the OPAC. 3. Notice that the HTML displays literally 4. Apply patch and reload page 5. The <a> tag should render as HTML -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 00:25:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Mar 2019 23:25:16 +0000 Subject: [Koha-bugs] [Bug 22501] OPAC course reserves notes should allow html links In-Reply-To: <bug-22501-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22501-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22501-70-Ms9Ias4TDl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 01:36:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 00:36:29 +0000 Subject: [Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased In-Reply-To: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18308-70-JnXPxTldEp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308 --- Comment #27 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Created attachment 87128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87128&action=edit Bug 18308: Added another filter Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 01:41:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 00:41:31 +0000 Subject: [Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased In-Reply-To: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18308-70-fY3obJoPnJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87125|0 |1 is obsolete| | Attachment #87126|0 |1 is obsolete| | Attachment #87128|0 |1 is obsolete| | --- Comment #28 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Created attachment 87129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87129&action=edit Bug 18308: Fixed whitespace and added filters for qa tools Note: This will still fail qa tool due to 'forbidden' javascript fullpath and not use of Asset plugin. Asset plugin cannot be used for onboarding currently. Sponsored-by: Catalyst IT -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 02:13:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 01:13:57 +0000 Subject: [Koha-bugs] [Bug 22599] New: Items attached to a course reserve but checkout can not be removed from course Message-ID: <bug-22599-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22599 Bug ID: 22599 Summary: Items attached to a course reserve but checkout can not be removed from course Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Course reserves Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Since items that are connected to a course reserve, cannot be removed from that course reserve if it is currently checked out. It would be helpful to show an information bubble when the user is hovering over the greyed out "remove" button. This would let the user know that due to the fact this item is checked out, the item can not be removed and therefore the "remove" button is not available. Add Items to an Existing Course Check out one of those items to a patron Go back to Course and see that the Item's ability to be removed is greyed out. Edit is still an available option, but remove is not. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 02:17:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 01:17:11 +0000 Subject: [Koha-bugs] [Bug 21265] Additional step at end of onboarder to enable HEA In-Reply-To: <bug-21265-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21265-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21265-70-9n7loVtzrf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21265 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18308 --- Comment #2 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- This bug should depend on 18308 as it is part of the onboarding tool. I will fix it to reflect this. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308 [Bug 18308] Default value of minPasswordLength should be increased -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 02:17:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 01:17:11 +0000 Subject: [Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased In-Reply-To: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18308-70-REtH0V9oFO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21265 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21265 [Bug 21265] Additional step at end of onboarder to enable HEA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 02:19:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 01:19:25 +0000 Subject: [Koha-bugs] [Bug 18888] Include the definition of currency in onboarding tool In-Reply-To: <bug-18888-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18888-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18888-70-H1eBRY0u8l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18888 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |18308 --- Comment #10 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- This bug should depend on Bug 18308 as it is part of the onboarding tool. I will fix it to reflect this. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308 [Bug 18308] Default value of minPasswordLength should be increased -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 02:19:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 01:19:25 +0000 Subject: [Koha-bugs] [Bug 18308] Default value of minPasswordLength should be increased In-Reply-To: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18308-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18308-70-3XdlftMKcM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18308 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18888 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18888 [Bug 18888] Include the definition of currency in onboarding tool -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 02:31:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 01:31:13 +0000 Subject: [Koha-bugs] [Bug 16357] Plack error logs are not time stamped In-Reply-To: <bug-16357-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16357-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16357-70-UhD5fr7t0g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #31 from Mason James <mtj at kohaaloha.com> --- I tested this and had a similar error.. Log4perl: Seems like no initialization happened. Forgot to call init()? It seems there is some subtle permission problem with the log file. I experimented with permissions but had no success Przemek or David, can you provide an example of working permission for the log files? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 02:37:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 01:37:40 +0000 Subject: [Koha-bugs] [Bug 16357] Plack error logs are not time stamped In-Reply-To: <bug-16357-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16357-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16357-70-GM6ncIcoWH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #32 from Mason James <mtj at kohaaloha.com> --- (In reply to Mason James from comment #31) > I tested this and had a similar error.. > Log4perl: Seems like no initialization happened. Forgot to call init()? > > It seems there is some subtle permission problem with the log file. I > experimented with permissions but had no success > > Przemek or David, can you provide an example of working permission for the > log files? My hunch is that the original patch works OK, because it uses L4P's 'easy mode', which does some extra permisssion magic?, (just a theory ATM) https://metacpan.org/pod/Log::Log4perl#Easy-Mode -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 02:41:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 01:41:37 +0000 Subject: [Koha-bugs] [Bug 16357] Plack error logs are not time stamped In-Reply-To: <bug-16357-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16357-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16357-70-asYb0lAfu0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #33 from Mason James <mtj at kohaaloha.com> --- (In reply to Mason James from comment #31) > I tested this and had a similar error.. > Log4perl: Seems like no initialization happened. Forgot to call init()? > > It seems there is some subtle permission problem with the log file. I > experimented with permissions but had no success > > Przemek or David, can you provide an example of working permission for the > log files? this seems to be an example of the default permissions... root at server1:/var/log/koha/abc# ls -l *log -rw-r--r-- 1 abc-koha abc-koha 774 Mar 28 05:40 indexer-error.log -rw-r--r-- 1 abc-koha abc-koha 0 Mar 28 05:27 indexer-output.log -rw-r--r-- 1 root root 411998 Mar 28 09:24 intranet-error.log -rw-r--r-- 1 root root 69039 Mar 28 04:28 opac-error.log -rw-r--r-- 1 abc-koha abc-koha 16347161 Mar 28 12:38 plack-error.log -rw-r--r-- 1 abc-koha abc-koha 4288611 Mar 28 12:38 plack.log -rw-r--r-- 1 abc-koha abc-koha 0 Mar 27 05:22 zebra-error.log -rw-r--r-- 1 abc-koha abc-koha 0 Mar 15 04:25 zebra-output.log -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 04:19:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 03:19:57 +0000 Subject: [Koha-bugs] [Bug 22579] Add syspref to toggle expanding Actions dropdown menu in Z39.50 search to decrease clicks In-Reply-To: <bug-22579-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22579-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22579-70-itq2yVGuTK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22579 --- Comment #5 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- (In reply to Katrin Fischer from comment #4) > Could we use a split button with import being the default? (like receive in > the subscription search list) > > I also share the feeling that a pref might be a little overkill here when it > seems more like a usability issue. A split button could work, but the library are wanting Card Preview to be the easiest to access. Would it be acceptable to have Card Preview as the main option, and MARC preview and import be in the dropdown part? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 09:12:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 08:12:03 +0000 Subject: [Koha-bugs] [Bug 22593] Cronjobs/Scripts dealing with accountlines need updating for bug 22008 In-Reply-To: <bug-22593-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22593-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22593-70-tXHj4RmqQX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22593 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87075|0 |1 is obsolete| | --- Comment #4 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 87130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87130&action=edit Bug 22593: Fix bad ternaries after bug 22008 A series of ternaries were introduced when we moved to add_debit which defaulted to 'user 0' should a userenv not be set. This was incorrect as userenv may well not be set (during cronscript runs for example) and the new constraint would not allow such a default. We switch to 'undef' here to satisfy the constraint. Test plan 1) Ensure you have data in your system that would be caught by the longoverdues cronjob. 2) Ensure you're sysprefs are setup to charge for lost items 3) Run the script and varify it runs to completion without errors Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 09:21:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 08:21:00 +0000 Subject: [Koha-bugs] [Bug 22577] Cronjobs (and other scripts) should be attributed to a 'real' user In-Reply-To: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22577-70-ssASD21rCo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22577 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com --- Comment #34 from Josef Moravec <josef.moravec at gmail.com> --- I do like the general idea of Koha::Cron module. What I do not like is using some hardcoded "system" user. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 09:24:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 08:24:15 +0000 Subject: [Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines In-Reply-To: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22600-70-jhsZ5Sv7Ky@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 09:24:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 08:24:17 +0000 Subject: [Koha-bugs] [Bug 22413] Elasticsearch - Index title is lost after sorting In-Reply-To: <bug-22413-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22413-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22413-70-hRDUqZx2r8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22413 Stefan Berndtsson <stefan.berndtsson at ub.gu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |stefan.berndtsson at ub.gu.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 09:24:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 08:24:09 +0000 Subject: [Koha-bugs] [Bug 22600] New: We should add an 'interface' field to accountlines Message-ID: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Bug ID: 22600 Summary: We should add an 'interface' field to accountlines Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Prior to bug 22008 we were defaulting to a manager_id of '0' wherever we found a userenv was not set. This roughly equated to signifying that an action had taken place via a script of cronjob... however I'm not sure I saw this behaviour documented anywhere. With bug 22008 adding constraints to manager_id it highlighted this behaviour and raised the question as to how we should overcome it. I believe the clearest approach to identifying 'where' an action has taken place would be to add an interface field to the accountlines table and set it for any action. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 09:25:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 08:25:45 +0000 Subject: [Koha-bugs] [Bug 22471] Default Finnish values for web installer In-Reply-To: <bug-22471-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22471-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22471-70-MorEQYPBw0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22471 Lari Taskula <lari.taskula at hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 09:26:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 08:26:07 +0000 Subject: [Koha-bugs] [Bug 22593] Cronjobs/Scripts dealing with accountlines need updating for bug 22008 In-Reply-To: <bug-22593-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22593-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22593-70-Pxg0MYUG7G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22593 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22547 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22547 [Bug 22547] C4::Overdues - UpdateFine is barely tested -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 09:26:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 08:26:07 +0000 Subject: [Koha-bugs] [Bug 22547] C4::Overdues - UpdateFine is barely tested In-Reply-To: <bug-22547-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22547-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22547-70-ZLOlwFJG6l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22547 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|22593 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22593 [Bug 22593] Cronjobs/Scripts dealing with accountlines need updating for bug 22008 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 09:27:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 08:27:14 +0000 Subject: [Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines In-Reply-To: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22600-70-WljMAeFKs0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22512 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 [Bug 22512] accountlines.accountype mixes 'state' and 'type' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 09:27:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 08:27:14 +0000 Subject: [Koha-bugs] [Bug 22512] accountlines.accountype mixes 'state' and 'type' In-Reply-To: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22512-70-fyZm7UZS6m@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22600 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 [Bug 22600] We should add an 'interface' field to accountlines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 09:27:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 08:27:31 +0000 Subject: [Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines In-Reply-To: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22600-70-bHS3R5hCrD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22008 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 [Bug 22008] accountlines.manager_id is missing a foreign key constraint -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 09:27:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 08:27:31 +0000 Subject: [Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint In-Reply-To: <bug-22008-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22008-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22008-70-eadpNNmwH8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22600 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 [Bug 22600] We should add an 'interface' field to accountlines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 09:28:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 08:28:29 +0000 Subject: [Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines In-Reply-To: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22600-70-1wuYpyZIcV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|22008 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 [Bug 22008] accountlines.manager_id is missing a foreign key constraint -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 09:28:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 08:28:29 +0000 Subject: [Koha-bugs] [Bug 22008] accountlines.manager_id is missing a foreign key constraint In-Reply-To: <bug-22008-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22008-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22008-70-f9gswLqZ8C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22008 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22600 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 [Bug 22600] We should add an 'interface' field to accountlines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 09:28:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 08:28:36 +0000 Subject: [Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines In-Reply-To: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22600-70-3BjLIEmuBY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |blocker -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 09:47:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 08:47:49 +0000 Subject: [Koha-bugs] [Bug 22601] New: Table filters link cant be translated Message-ID: <bug-22601-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22601 Bug ID: 22601 Summary: Table filters link cant be translated Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Since Bug 9573 patch "Lost items report - Move filters code to a separate js file", the table filters link is not translated anymore. The call remains _("Activate filters") but this works only inside language folders. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 09:48:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 08:48:02 +0000 Subject: [Koha-bugs] [Bug 22601] Table filters link cant be translated In-Reply-To: <bug-22601-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22601-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22601-70-lLyc28MxpG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22601 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |9573 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573 [Bug 9573] Ability to download items lost report -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 09:48:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 08:48:02 +0000 Subject: [Koha-bugs] [Bug 9573] Ability to download items lost report In-Reply-To: <bug-9573-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9573-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9573-70-OxSGmRw76l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9573 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22601 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22601 [Bug 22601] Table filters link cant be translated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 09:56:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 08:56:58 +0000 Subject: [Koha-bugs] [Bug 22601] Table filters link cant be translated In-Reply-To: <bug-22601-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22601-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22601-70-uoI71DDpyV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22601 --- Comment #1 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Looks like there are other cases : git grep '_(' koha-tmpl/intranet-tmpl/prog/js/ koha-tmpl/opac-tmpl/bootstrap/js/ Each js file must have an include ? like : prog/js/catalog.js and prog/en/includes/catalog-strings.inc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 10:00:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 09:00:14 +0000 Subject: [Koha-bugs] [Bug 22588] Simplify getting account information in opac and self checkout module In-Reply-To: <bug-22588-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22588-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22588-70-FviODgJknH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22588 --- Comment #5 from Josef Moravec <josef.moravec at gmail.com> --- (In reply to Tom?s Cohen Arazi from comment #4) > I like the idea in general but: > - shouldn't we be using line.{is_debit|is_credit} instead of comparing > line.amount > 0? Keep in mind that we found pathological cases in the wild > where the amountoutstanding got flipped. We better rely on the methods we > have. Definitely yes, I don't know how could I forget these methods... I'll add a follow-up for this > - The fact that we aren't using $account->outstanding_debits and > $account->outstanding_credits but instead keep searching for all > accountlines makes some noise to me. I guess it is not straightforward as we > want to display all outstanding debits and credits ordered by date. Just > something to think about a bit. Maybe we should add amountountstanding => { > '!=' => 0 } to the search line. Maybe we should think a bit more, what we wan't to show to users in accounts information table - now it is something like cash book, but is that right way of presenting account lines to user? Do they understand it enough? > - We could replace the search with > > my $account = $patron->account; > my $total = $account->balance; > my $lines = $account->lines; Will be done in follow-up -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 10:01:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 09:01:51 +0000 Subject: [Koha-bugs] [Bug 22588] Simplify getting account information in opac and self checkout module In-Reply-To: <bug-22588-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22588-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22588-70-MQvjMgiesF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22588 --- Comment #6 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 87131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87131&action=edit Bug 22588: (follow-up) Simplify getting accounts even more -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 10:04:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 09:04:59 +0000 Subject: [Koha-bugs] [Bug 22601] Table filters link cant be translated In-Reply-To: <bug-22601-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22601-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22601-70-cIpqHj5DEV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22601 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- *** This bug has been marked as a duplicate of bug 22490 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 10:04:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 09:04:59 +0000 Subject: [Koha-bugs] [Bug 22490] Some strings in javascript files are untranslatable In-Reply-To: <bug-22490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22490-70-BJZ7l4NzpC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22490 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #1 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- *** Bug 22601 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 10:06:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 09:06:03 +0000 Subject: [Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines In-Reply-To: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22600-70-K2aiwUTnXo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 11:08:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 10:08:13 +0000 Subject: [Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines In-Reply-To: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22600-70-3d9RRgeF1M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87132&action=edit Bug 22600: Add 'interface' to accountlines This patch adds the 'interface' field to the accountlines table and updates all Koha::Object routines and calls to use it. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 11:08:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 10:08:25 +0000 Subject: [Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines In-Reply-To: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22600-70-vDhWYQtorQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 11:48:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 10:48:53 +0000 Subject: [Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines In-Reply-To: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22600-70-bJcYJREdH6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 --- Comment #2 from Josef Moravec <josef.moravec at gmail.com> --- Comment on attachment 87132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87132 Bug 22600: Add 'interface' to accountlines Review of attachment 87132: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=22600&attachment=87132) ----------------------------------------------------------------- ::: C4/Overdues.pm @@ +599,5 @@ > description => $desc, > note => undef, > user_id => undef, > + interface => C4::Context->interface, > + library_id => undef, #FIXME: Should we grab the checkout or circ-control branch here perhaps? On the first view, I think if the Context is set then we should grab it from context, if not, stay with undef ::: C4/SIP/ILS/Transaction/FeePayment.pm @@ +28,4 @@ > our $debug = 0; > > my %fields = (); > +C4::Context->interface('opac'); Should be 'SIP' I think ::: installer/data/mysql/atomicupdate/bug_22600.perl @@ +2,5 @@ > + > +$DBversion = 'XXX'; # will be replaced by the RM > +if ( CheckVersion($DBversion) ) { > + > + if ( !column_exists( 'accountlines', 'status' ) ) { should be 'interface' instead of 'status' @@ +7,5 @@ > + $dbh->do( > + qq{ > + ALTER TABLE `accountlines` > + ADD > + `interface` varchar(16) DEFAULT 'script' 'script' default is weird here @@ +35,5 @@ > + manager_id != borrowernumber; > + }); > + > + SetVersion($DBversion); > + print "Upgrade to $DBversion done (Bug 22518 - Fix accounttype 'O' to 'FU')\n"; Not right description I think ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 12:11:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 11:11:21 +0000 Subject: [Koha-bugs] [Bug 22490] Some strings in javascript files are untranslatable In-Reply-To: <bug-22490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22490-70-agmUvLckyZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22490 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 12:11:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 11:11:48 +0000 Subject: [Koha-bugs] [Bug 22490] Some strings in javascript files are untranslatable In-Reply-To: <bug-22490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22490-70-ZavV2rKBpg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22490 --- Comment #2 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- I will create a xxx-strings.inc for each js -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 12:36:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 11:36:30 +0000 Subject: [Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines In-Reply-To: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22600-70-s4j4jKnxxc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87132|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87133&action=edit Bug 22600: Add 'interface' to accountlines This patch adds the 'interface' field to the accountlines table and updates all Koha::Object routines and calls to use it. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 12:36:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 11:36:32 +0000 Subject: [Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines In-Reply-To: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22600-70-l2e2r404Qw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87134&action=edit Bug 22600: Add 'api' to interface types and set appropriately This patch adds 'api' as a valid interface and sets it appropriately for both the new REST api and previous /svc/ api's. Handling to keep the interface of a logged in session is included such that if the OPAC or Intranet use the API's internally via a Cookie we will maintain the interface throughout the session. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 12:36:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 11:36:11 +0000 Subject: [Koha-bugs] [Bug 10345] Copy number should be incremented when adding multiple items at once In-Reply-To: <bug-10345-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10345-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10345-70-1RppAgkcPx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10345 Bj?rn Nyl?n <bjorn.nylen at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bjorn.nylen at ub.lu.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 12:36:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 11:36:48 +0000 Subject: [Koha-bugs] [Bug 10345] Copy number should be incremented when adding multiple items at once In-Reply-To: <bug-10345-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10345-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10345-70-J5VOsrNz6H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10345 Frank Hansen <frank.hansen at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frank.hansen at ub.lu.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 12:38:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 11:38:55 +0000 Subject: [Koha-bugs] [Bug 10345] Copy number should be incremented when adding multiple items at once In-Reply-To: <bug-10345-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10345-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10345-70-PSnJS33waZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10345 --- Comment #3 from Bj?rn Nyl?n <bjorn.nylen at ub.lu.se> --- This issue came up at the swedish Koha users hackfest so we made a patch. Will try to submit it shortly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 12:48:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 11:48:06 +0000 Subject: [Koha-bugs] [Bug 22602] New: OverDrive circulation integration is broken when user is referred to Koha from another site Message-ID: <bug-22602-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22602 Bug ID: 22602 Summary: OverDrive circulation integration is broken when user is referred to Koha from another site Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- To recreate: 1 - Have a working OverDrive account and setup 2 - Put a link to your koha site on another site and follow the link to open Koha in a new tab.window 3 - Do an overdrive search 4 - Note that copies listed as available are correct, however, all items only have a place hold button The issue is in the code below - if we came from an outside site we cannot access p and we 'return' which never instantiates checkout_popup which is needed for creating the checkout buttons later 87 var checkout_popup = null; 88 $( document ).ready(function() { 89 var p = window.opener; 90 if (p) { 91 try { cb = p.refresh_overdrive_account_details;} 92 catch(err){ return; } //Catch error if opener is not accessible 93 if (cb) { 94 cb(); 95 } else { 96 p.location.reload(); 97 } 98 window.close(); 99 } 100 checkout_popup = $("#overdrive-checkout"); 101 $("#overdrive-login-form").submit(function(e){ 102 e.preventDefault(); 103 $("#overdrive-login").modal('hide'); 104 var ODpassword = $("input[name='ODpassword']").val(); 105 login( ODpassword ); 106 }); 107 }); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 12:48:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 11:48:17 +0000 Subject: [Koha-bugs] [Bug 22602] OverDrive circulation integration is broken when user is referred to Koha from another site In-Reply-To: <bug-22602-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22602-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22602-70-mqnFryIpWG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22602 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 12:50:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 11:50:58 +0000 Subject: [Koha-bugs] [Bug 22592] Elasticsearch - Support for index scan In-Reply-To: <bug-22592-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22592-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22592-70-uMGuOzawQ5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 12:51:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 11:51:02 +0000 Subject: [Koha-bugs] [Bug 22592] Elasticsearch - Support for index scan In-Reply-To: <bug-22592-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22592-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22592-70-vRZ8QZQW0u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 --- Comment #1 from Ere Maijala <ere.maijala at helsinki.fi> --- Created attachment 87135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87135&action=edit Bug 22592: Add index scan emulation to Elasticsearch Adds support for using the "scan indexes" action in advanced search by using faceting with a prefix filter. Requires that the field be set as facetable for anything to be found. Test plan: 1. Apply patch 2. Go to advanced search and click "More options" 3. Select author as the search field, enter a last name and check "Scan indexes" 4. Perform search and observe the result list resembling scan results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 12:51:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 11:51:05 +0000 Subject: [Koha-bugs] [Bug 22592] Elasticsearch - Support for index scan In-Reply-To: <bug-22592-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22592-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22592-70-d7shMnbC8I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 --- Comment #2 from Ere Maijala <ere.maijala at helsinki.fi> --- Created attachment 87136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87136&action=edit Bug 22592: Fixes to index scan Makes sure the scan term is displayed and redirection to record page is not used with index scan for a single result. Also adds a submit button so that you can submit a change for selected index or term easier. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 13:30:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 12:30:47 +0000 Subject: [Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function In-Reply-To: <bug-12159-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12159-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12159-70-KmToQJBK9s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #46 from Nick Clemens <nick at bywatersolutions.com> --- Discussion is unclear - this now blocks 20443 - do we want these pushed together, or can this one go now and then be followed by 20443 when it is ready? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 13:35:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 12:35:06 +0000 Subject: [Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines In-Reply-To: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22600-70-SjOIEHX7XO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87133|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87137&action=edit Bug 22600: Add 'interface' to accountlines This patch adds the 'interface' field to the accountlines table and updates all Koha::Object routines and calls to use it. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 13:35:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 12:35:09 +0000 Subject: [Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines In-Reply-To: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22600-70-H1giwiaQRt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87134|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87138&action=edit Bug 22600: Add 'api' to interface types and set appropriately This patch adds 'api' as a valid interface and sets it appropriately for both the new REST api and previous /svc/ api's. Handling to keep the interface of a logged in session is included such that if the OPAC or Intranet use the API's internally via a Cookie we will maintain the interface throughout the session. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 13:35:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 12:35:12 +0000 Subject: [Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines In-Reply-To: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22600-70-17ZNYOFpzm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87139&action=edit Bug 22600: Add 'cron' to interface types and set appropriately This patch adds 'cron' as a valid interface and sets it appropriately for existing cron scripts. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 13:35:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 12:35:55 +0000 Subject: [Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines In-Reply-To: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22600-70-zaCW0tPpAI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 13:36:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 12:36:37 +0000 Subject: [Koha-bugs] [Bug 22593] Cronjobs/Scripts dealing with accountlines need updating for bug 22008 In-Reply-To: <bug-22593-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22593-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22593-70-AcWMXzy3Jn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22593 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 13:59:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 12:59:07 +0000 Subject: [Koha-bugs] [Bug 22603] New: Move boilerplate into Koha::Cron class Message-ID: <bug-22603-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22603 Bug ID: 22603 Summary: Move boilerplate into Koha::Cron class Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz Target Milestone: --- There's a bunch of patterns in the koha cron scripts.. we should move some of the boilerplate into the new Koha::Cron base class and make our cron scripts DRYer. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 13:59:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 12:59:17 +0000 Subject: [Koha-bugs] [Bug 22603] Move boilerplate into Koha::Cron class In-Reply-To: <bug-22603-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22603-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22603-70-CZpWzLfyTO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22603 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22600 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 [Bug 22600] We should add an 'interface' field to accountlines -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 13:59:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 12:59:17 +0000 Subject: [Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines In-Reply-To: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22600-70-clUxSZSm2M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22603 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22603 [Bug 22603] Move boilerplate into Koha::Cron class -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 14:00:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 13:00:07 +0000 Subject: [Koha-bugs] [Bug 22593] Cronjobs/Scripts dealing with accountlines need updating for bug 22008 In-Reply-To: <bug-22593-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22593-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22593-70-iTPuWT0W80@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22593 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 14:06:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 13:06:42 +0000 Subject: [Koha-bugs] [Bug 22603] Move boilerplate into Koha::Cron class In-Reply-To: <bug-22603-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22603-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22603-70-PDbVHkJDCU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22603 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 14:11:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 13:11:58 +0000 Subject: [Koha-bugs] [Bug 22603] Move boilerplate into Koha::Cron class In-Reply-To: <bug-22603-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22603-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22603-70-Ud22DRSgHv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22603 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 14:22:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 13:22:42 +0000 Subject: [Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines In-Reply-To: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22600-70-DlUV5A7hHt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 --- Comment #8 from Josef Moravec <josef.moravec at gmail.com> --- Just started testing, but found: prove t/db_dependent/Koha/Account.t Field 'interface' doesn't have a default value -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 14:28:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 13:28:07 +0000 Subject: [Koha-bugs] [Bug 10577] C4::Budgets::GetBudgetPeriod has inappropriate overloading of its behavior In-Reply-To: <bug-10577-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10577-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10577-70-riKDLzWmFd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10577 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #15 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 14:28:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 13:28:32 +0000 Subject: [Koha-bugs] [Bug 17746] koha-reset-passwd should use Koha::Patron->set_password In-Reply-To: <bug-17746-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17746-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17746-70-JXmsFKHbmW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17746 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #25 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 14:28:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 13:28:42 +0000 Subject: [Koha-bugs] [Bug 21974] cxn_pool must be configurable In-Reply-To: <bug-21974-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21974-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21974-70-NTCiYGNPAZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21974 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #9 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 14:28:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 13:28:18 +0000 Subject: [Koha-bugs] [Bug 12159] Duplicate borrower_add_additional_fields function In-Reply-To: <bug-12159-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12159-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12159-70-GY7st2612a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12159 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #47 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 14:28:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 13:28:53 +0000 Subject: [Koha-bugs] [Bug 22076] SIP checkin for withdrawn item returns ok in checkin response In-Reply-To: <bug-22076-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22076-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22076-70-2LJO4J9Tjx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22076 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #15 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 14:29:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 13:29:06 +0000 Subject: [Koha-bugs] [Bug 22495] Restore su-geo field in Elasticsearch mappings In-Reply-To: <bug-22495-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22495-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22495-70-y5nDf3lxPV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22495 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 14:29:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 13:29:27 +0000 Subject: [Koha-bugs] [Bug 22536] Display problem in Holds to Pull report In-Reply-To: <bug-22536-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22536-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22536-70-aln9zRF3PC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22536 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #7 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 14:29:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 13:29:38 +0000 Subject: [Koha-bugs] [Bug 22550] OPAC suggestion form doesn't require mandatory fields In-Reply-To: <bug-22550-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22550-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22550-70-9lR47VPNen@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22550 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 14:29:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 13:29:54 +0000 Subject: [Koha-bugs] [Bug 22560] Forgotten password "token expired" page still shows boxes to reset password In-Reply-To: <bug-22560-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22560-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22560-70-tCrsZhSVjs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22560 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #4 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 14:30:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 13:30:25 +0000 Subject: [Koha-bugs] [Bug 22561] Forgotten password requirements hint doesn't list all rules for new passwords In-Reply-To: <bug-22561-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22561-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22561-70-2xV79bTLhN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22561 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #4 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 14:31:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 13:31:12 +0000 Subject: [Koha-bugs] [Bug 22586] IntranetReportsHomeHTML no longer renders as HTML on reports-home.pl In-Reply-To: <bug-22586-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22586-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22586-70-NcmzBL1tOo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22586 George Williams (NEKLS) <george at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |george at nekls.org --- Comment #4 from George Williams (NEKLS) <george at nekls.org> --- Tested successfully on ByWater sandboxes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 14:31:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 13:31:47 +0000 Subject: [Koha-bugs] [Bug 7890] Highlight required field in MARC editor In-Reply-To: <bug-7890-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7890-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7890-70-yZPRSnkCwe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7890 Bug 7890 depends on bug 22399, which changed state. Bug 22399 Summary: Improve responsive behavior of the basic marc editor https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 14:31:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 13:31:47 +0000 Subject: [Koha-bugs] [Bug 22582] Authority plugin link broken by Bug 22399 In-Reply-To: <bug-22582-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22582-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22582-70-lBdZJmBzb9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22582 Bug 22582 depends on bug 22399, which changed state. Bug 22399 Summary: Improve responsive behavior of the basic marc editor https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 14:31:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 13:31:46 +0000 Subject: [Koha-bugs] [Bug 22399] Improve responsive behavior of the basic marc editor In-Reply-To: <bug-22399-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22399-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22399-70-zJYCBVKKUp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |WONTFIX --- Comment #8 from Nick Clemens <nick at bywatersolutions.com> --- This had unintended consequences that broke other features. Reverted from master a993bd3843fdfcf3a7f2df916299b32d4601b879 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 14:32:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 13:32:16 +0000 Subject: [Koha-bugs] [Bug 22582] Authority plugin link broken by Bug 22399 In-Reply-To: <bug-22582-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22582-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22582-70-9JF6GJiaR7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22582 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |DUPLICATE CC| |nick at bywatersolutions.com --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- *** This bug has been marked as a duplicate of bug 22399 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 14:32:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 13:32:16 +0000 Subject: [Koha-bugs] [Bug 22399] Improve responsive behavior of the basic marc editor In-Reply-To: <bug-22399-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22399-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22399-70-Pj3ijWyLlO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 --- Comment #9 from Nick Clemens <nick at bywatersolutions.com> --- *** Bug 22582 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 14:33:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 13:33:12 +0000 Subject: [Koha-bugs] [Bug 7890] Highlight required field in MARC editor In-Reply-To: <bug-7890-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7890-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7890-70-DXjRFOUbaG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7890 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- Does this one need a rebase because of the reversion of 22399? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 14:35:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 13:35:36 +0000 Subject: [Koha-bugs] [Bug 20196] [Omnibus] Prepare Koha to ElasticSearch6 - ES6 In-Reply-To: <bug-20196-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20196-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20196-70-Zuc0PXUnyu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20196 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 15:00:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 14:00:00 +0000 Subject: [Koha-bugs] [Bug 18969] _all field is deprecated - should use copy_to to prepare for ES6 In-Reply-To: <bug-18969-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18969-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18969-70-xdvGThU2UH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18969 --- Comment #33 from claire.hernandez at biblibre.com <claire.hernandez at biblibre.com> --- Actually, we need a fix that do only ES6 compatibilty. I think we will rebase it anyway :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 15:07:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 14:07:20 +0000 Subject: [Koha-bugs] [Bug 8280] SRU should be filterable by Koha Item Type In-Reply-To: <bug-8280-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8280-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8280-70-4Ixw3tRuQI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8280 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 15:34:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 14:34:09 +0000 Subject: [Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines In-Reply-To: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22600-70-kZorSV5tXT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87140&action=edit Bug 22600: Set 'commandline' interface appropriately This patch change Koha::Cron to be a more generic Koha::Script class and update all commanline driven scripts to use it. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 15:35:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 14:35:24 +0000 Subject: [Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines In-Reply-To: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22600-70-ruxifjvnBK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |kyle at bywatersolutions.com, | |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 15:35:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 14:35:41 +0000 Subject: [Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines In-Reply-To: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22600-70-7s5hYtSycP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 15:43:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 14:43:37 +0000 Subject: [Koha-bugs] [Bug 15331] Sort order breaks at offset=1000 (both OPAC and Intranet) In-Reply-To: <bug-15331-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15331-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15331-70-2Z3DIbvcUi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15331 Paul Thornton <paul.thornton at educampus.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |paul.thornton at educampus.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 15:53:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 14:53:18 +0000 Subject: [Koha-bugs] [Bug 22541] Invoice adjustments should show invoice number and include link on ordered.pl and spent.pl In-Reply-To: <bug-22541-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22541-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22541-70-LSyyp9RfVE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22541 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 16:40:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 15:40:46 +0000 Subject: [Koha-bugs] [Bug 22399] Improve responsive behavior of the basic marc editor In-Reply-To: <bug-22399-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22399-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22399-70-ETkxSuKEyh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22399 Bug 22399 depends on bug 22045, which changed state. Bug 22045 Summary: Cataloging UX enhancement - Improve access to tabs https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 16:40:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 15:40:45 +0000 Subject: [Koha-bugs] [Bug 22045] Cataloging UX enhancement - Improve access to tabs In-Reply-To: <bug-22045-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22045-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22045-70-y2JzQ0hifd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22045 Dobrica Pavlinusic <dpavlin at rot13.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED CC| |dpavlin at rot13.org Resolution|FIXED |--- --- Comment #34 from Dobrica Pavlinusic <dpavlin at rot13.org> --- This bug broke keyboard shortcuts because of following change: --- a/koha-tmpl/intranet-tmpl/prog/js/staff-global.js +++ b/koha-tmpl/intranet-tmpl/prog/js/staff-global.js @@ -31,7 +31,7 @@ $.fn.tabIndex = function () { return $(this).parent().children('div').index(this); }; $.fn.selectTabByID = function (tabID) { - $(this).tabs("option", "active", $(tabID).tabIndex()); + $(this).tabs("option", "active", $( "#" + tabID ).tabIndex()); }; $(document).ready(function() { without modification to calling which also prefix tabID with #, thus creating invalid ##tabID -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 16:45:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 15:45:30 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18235-70-jCQC96CV35@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #99 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 87141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87141&action=edit Bug 18235: (RM follow-up) fix mappings reset Without this we could not recreate mappings as there are no defaults for the additional fields - this restores behavoiur from before patches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 17:00:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 16:00:55 +0000 Subject: [Koha-bugs] [Bug 22593] Cronjobs/Scripts dealing with accountlines need updating for bug 22008 In-Reply-To: <bug-22593-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22593-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22593-70-uEarSbjpZz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22593 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 17:01:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 16:01:18 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18235-70-Z9QOdGaIPc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #100 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 17:01:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 16:01:30 +0000 Subject: [Koha-bugs] [Bug 18213] Add language facets to Elasticsearch In-Reply-To: <bug-18213-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18213-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18213-70-wNQj8Ov9Vd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18213 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #27 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 17:01:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 16:01:47 +0000 Subject: [Koha-bugs] [Bug 21049] Rancor 007 field does not retain value In-Reply-To: <bug-21049-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21049-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21049-70-n20X85HJss@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21049 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #12 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 17:01:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 16:01:48 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18235-70-o9Iu2QYasx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 --- Comment #101 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- (In reply to Nick Clemens from comment #100) > Awesome work all! > > Pushed to master for 19.05 \o/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 17:18:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 16:18:56 +0000 Subject: [Koha-bugs] [Bug 20390] Elasticsearch - Mappings for UNIMARC (updates existing) In-Reply-To: <bug-20390-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20390-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20390-70-bAhlsccHqp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20390 claire.hernandez at biblibre.com <claire.hernandez at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75388|0 |1 is obsolete| | Attachment #85280|0 |1 is obsolete| | Attachment #85284|0 |1 is obsolete| | CC| |claire.hernandez at biblibre.c | |om --- Comment #15 from claire.hernandez at biblibre.com <claire.hernandez at biblibre.com> --- Created attachment 87142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87142&action=edit only one rebased and reviewed Mappings reviewed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 17:41:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 16:41:22 +0000 Subject: [Koha-bugs] [Bug 18969] _all field is deprecated - should use copy_to to prepare for ES6 In-Reply-To: <bug-18969-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18969-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18969-70-pTOXgOe3Ug@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18969 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #73498|0 |1 is obsolete| | --- Comment #34 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 87143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87143&action=edit Bug 18969: ES6 - replace use of _all by our own field -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 17:42:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 16:42:52 +0000 Subject: [Koha-bugs] [Bug 18969] _all field is deprecated - should use copy_to to prepare for ES6 In-Reply-To: <bug-18969-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18969-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18969-70-fq5gnmOnAd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18969 --- Comment #35 from Alex Arnaud <alex.arnaud at biblibre.com> --- Here is a replacement patch for people that want only ES compatibilty -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 17:45:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 16:45:39 +0000 Subject: [Koha-bugs] [Bug 14576] Allow automatic update of location on checkin In-Reply-To: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14576-70-Jam5fVsnzC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 17:45:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 16:45:46 +0000 Subject: [Koha-bugs] [Bug 14576] Allow automatic update of location on checkin In-Reply-To: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14576-70-yYfqkzPYpz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86812|0 |1 is obsolete| | Attachment #86813|0 |1 is obsolete| | Attachment #86814|0 |1 is obsolete| | Attachment #86815|0 |1 is obsolete| | Attachment #86816|0 |1 is obsolete| | Attachment #87040|0 |1 is obsolete| | Attachment #87061|0 |1 is obsolete| | --- Comment #119 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 87144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87144&action=edit Bug 14576: Allow arbitrary automatic update of location on checkin This patch adds a new syspref "UpdateItemLocationOnCheckin" which accepts pairs of shelving locations. On check-in the items location is compared ot the location on the left and, if it matches, is updated to the location on the left. This preference replaces ReturnToShelvingCart and InProcessingToShelvingCart preferences. The update statement should insert values that replciate these functions. Note existing functionality of all items in PROC location being returned to permanent_location is preserved by default. Also, any items issued from CART location will be returned to their permanent location on issue (if it differs) Special values for this pref are: _ALL_ - used on left side only to affect all items _BLANK_ - used on either side to match on/set to blank (actual blanks will work, but this is an easier to read option) _PERM_ - used on right side only to return items to permanent location Test Plan: 1) Apply this patch 2) Run updatedatabase.pl 3) Set the new system preference UpdateitemLocationOnCheckin to the following (assuming sample data): NEW: FIC FIC: GEN 4) Create an item, set its location to NEW 5) Check in the item, note its location is now FIC 6) Check in the item again, note its location is now GEN 7) Check in the item again, note its location remains GEN 8) Test using _ALL_, _BLANK_ and _PERM_ for updates 9) Try entering various incorrect syntax in the pref and note you are warned Sponsored by: Arcadia Public Library (http://library.ci.arcadia.ca.us/) Middletown Township Public Library (http://www.mtpl.org/) Round Rock Public Library (https://www.roundrocktexas.gov/departments/library/) Signed-off-by: Michal Denar <black23 at gmail.com> Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 17:45:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 16:45:52 +0000 Subject: [Koha-bugs] [Bug 14576] Allow automatic update of location on checkin In-Reply-To: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14576-70-TS6aOTDtib@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 --- Comment #120 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 87145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87145&action=edit Bug 14576: Unit tests To test: 1 - prove -v t/db_dependent/Circulation/Returns.t 2 - prove -v t/db_dependent/Circulation/issue.t 3 - prove -v t/db_dependent/UsageStats.t 4 - All should pass Signed-off-by: Michal Denar <black23 at gmail.com> Signed-off-by: Michal Denar <black23 at gmail.com> Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 17:45:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 16:45:58 +0000 Subject: [Koha-bugs] [Bug 14576] Allow automatic update of location on checkin In-Reply-To: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14576-70-MWMhhesKfZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 --- Comment #121 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 87146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87146&action=edit Bug 14576: Update to use get_yaml_pref_hash Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 17:46:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 16:46:05 +0000 Subject: [Koha-bugs] [Bug 14576] Allow automatic update of location on checkin In-Reply-To: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14576-70-qKWjTiunsg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 --- Comment #122 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 87147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87147&action=edit Bug 14576: (follow-up) fix some typos and style Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 17:46:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 16:46:17 +0000 Subject: [Koha-bugs] [Bug 14576] Allow automatic update of location on checkin In-Reply-To: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14576-70-8MlgRZ45gp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 --- Comment #124 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 87149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87149&action=edit Bug 14576: Replaced calls using deprecated method GetItem with Koha::Items->find Test plan: 1) Apply all patches except this one 2) Checkout out an item to a patron 3) Check the item in - note that this will fail 4) Apply this patch, and repeat steps 1-3, noting instead that the the check is instead successful 5) Verify also that reserves act as expected 5) Sign off Sponsored-by: Catalyst IT Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 17:46:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 16:46:10 +0000 Subject: [Koha-bugs] [Bug 14576] Allow automatic update of location on checkin In-Reply-To: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14576-70-eRmQfAXUin@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 --- Comment #123 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 87148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87148&action=edit Bug 14576: Rebase fixes Fix test Rebase code Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 17:46:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 16:46:24 +0000 Subject: [Koha-bugs] [Bug 14576] Allow automatic update of location on checkin In-Reply-To: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14576-70-K9phvgJN4Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 --- Comment #125 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 87150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87150&action=edit Bug 14576: (follow-up) Using item objects, not hashrefs Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 17:46:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 16:46:30 +0000 Subject: [Koha-bugs] [Bug 14576] Allow automatic update of location on checkin In-Reply-To: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14576-70-sBJwg7p1vJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 --- Comment #126 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 87151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87151&action=edit Bug 14576: (QA Follow up) Tidy up feature documentation To test: Apply this patch with all of the others run the updatedatabase, it should work install a new Koha, this pref should be installed and look fine in the interface. Check the syspref, make sure the text looks ok and makes sense. Bonus points: for checking to make sure PROC: _PERM_ appears in the new pereference if InProcessingToShelvingCart was set for checking to make sure _ALL_: CART appears in the new preferenec if ReturnToShelvingCart was previously set. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 17:58:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 16:58:05 +0000 Subject: [Koha-bugs] [Bug 14576] Allow automatic update of location on checkin In-Reply-To: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14576-70-V4Ncea0XLe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #127 from Liz Rea <wizzyrea at gmail.com> --- I note there is a QA tool false positive here: FAIL pod coverage POD coverage was greater before, try perl -MPod::Coverage=PackageName -e666 POD coverage decreased because a sub was removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 18:34:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 17:34:59 +0000 Subject: [Koha-bugs] [Bug 22604] New: "Error : the selected language is not currently available" for French Message-ID: <bug-22604-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22604 Bug ID: 22604 Summary: "Error : the selected language is not currently available" for French Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs at lists.koha-community.org Reporter: houha.khadidja at gmail.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- i have tried to install french language (fr-French). Command line echoes this message: Error : the selected language is not currently available. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 18:49:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 17:49:13 +0000 Subject: [Koha-bugs] [Bug 22318] Extend Koha news feature to include other content areas In-Reply-To: <bug-22318-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22318-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22318-70-Ss25S5GrOV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22318 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m, | |jonathan.druart at bugs.koha-c | |ommunity.org, | |julian.maurice at biblibre.com | |, katrin.fischer at bsz-bw.de, | |m.de.rooy at rijksmuseum.nl, | |martin.renvoize at ptfs-europe | |.com, | |nick at bywatersolutions.com, | |tomascohen at gmail.com --- Comment #17 from Nick Clemens <nick at bywatersolutions.com> --- I like this one, but I just want to make sure it has had enough eyes on it, can I get some more viewpoints on this one? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 18:50:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 17:50:24 +0000 Subject: [Koha-bugs] [Bug 20718] Add ability to have lists that are available to all list editors In-Reply-To: <bug-20718-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20718-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20718-70-uBYAKOYACY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20718 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #11 from Liz Rea <wizzyrea at gmail.com> --- Another thing I noticed was that I couldn't seem to create a list from the search results for a "staff list," only "public" and "private" were options. It seems like that should work? Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 18:51:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 17:51:18 +0000 Subject: [Koha-bugs] [Bug 20718] Add ability to have lists that are available to all list editors In-Reply-To: <bug-20718-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20718-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20718-70-9gdV5njl7q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20718 --- Comment #12 from Liz Rea <wizzyrea at gmail.com> --- (Should add, I was doing this in the staff side, not the OPAC. I wouldn't expect staff lists to be creatable from the OPAC unless it was a staff member logged in and even that's a stretch.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 18:56:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 17:56:17 +0000 Subject: [Koha-bugs] [Bug 19380] Add transfer informations in ILS-DI GetRecords response In-Reply-To: <bug-19380-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19380-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19380-70-rSBcwe5jji@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19380 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Patch doesn't apply CC| |nick at bywatersolutions.com --- Comment #10 from Nick Clemens <nick at bywatersolutions.com> --- tests need a rebase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 19:03:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 18:03:24 +0000 Subject: [Koha-bugs] [Bug 22505] Add column configuration to patron list table In-Reply-To: <bug-22505-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22505-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22505-70-gi4BOnZpof@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22505 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Assignee|koha-bugs at lists.koha-commun |julian.maurice at biblibre.com |ity.org | QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 19:19:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 18:19:07 +0000 Subject: [Koha-bugs] [Bug 19722] Add a MaxItemsToDisplayForBatchMod preference In-Reply-To: <bug-19722-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19722-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19722-70-TqXap1Ql82@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19722 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #19 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 19:19:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 18:19:20 +0000 Subject: [Koha-bugs] [Bug 21772] Add holds and account information tab to the SCO module In-Reply-To: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21772-70-wbyWnMTTcC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #24 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 19:19:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 18:19:34 +0000 Subject: [Koha-bugs] [Bug 22505] Add column configuration to patron list table In-Reply-To: <bug-22505-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22505-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22505-70-4e8aRV6IXG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22505 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 19:19:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 18:19:42 +0000 Subject: [Koha-bugs] [Bug 22516] accountlines.lastincrement can be removed In-Reply-To: <bug-22516-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22516-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22516-70-7vdyUTV19U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22516 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #11 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 19:19:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 18:19:58 +0000 Subject: [Koha-bugs] [Bug 22525] Navigation arrows on the bottom of Cataloging search pages In-Reply-To: <bug-22525-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22525-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22525-70-xawrftTL56@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22525 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 20:35:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 19:35:59 +0000 Subject: [Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records In-Reply-To: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17385-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17385-70-qNlU5N8TYt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Failed QA --- Comment #43 from Nick Clemens <nick at bywatersolutions.com> --- Excellent work, this looks like a great base for future customization. Two things: 1 - Many qa script failures - missing filters and a critic complaint on XSLT: FAIL C4/XSLT.pm FAIL critic # BuiltinFunctions::RequireGlobFunction: Got 1 violation(s). # Variables::ProhibitConditionalDeclarations: Got 1 violation(s). 2 - I don't see the new option in lists - it works on detail and cart -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 20:40:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 19:40:17 +0000 Subject: [Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13895-70-9sljlu2PjR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #83 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 20:44:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 19:44:27 +0000 Subject: [Koha-bugs] [Bug 11220] Patron edit process doesn't remember restriction selections In-Reply-To: <bug-11220-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11220-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11220-70-g6XtYLn1K4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11220 Barton Chittenden <barton at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barton at bywatersolutions.com --- Comment #2 from Barton Chittenden <barton at bywatersolutions.com> --- This is true for other patron fields, e.g. changes to Alternate Address are lost as well. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 20:44:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 19:44:33 +0000 Subject: [Koha-bugs] [Bug 16357] Plack error logs are not time stamped In-Reply-To: <bug-16357-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16357-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16357-70-WCrL2wBUOG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #34 from Liz Rea <wizzyrea at gmail.com> --- Shouldn't the log4perl.conf have the path to the *instance* logs, i.e. the path /var/log/koha/<instance>/plack-error.log Am I reading correctly that it's trying to put them in log4perl.appender.PLACK.filename=/var/log/koha/plack-error.log Moreover, testing with the instructions (copy the files from the debian dir to the /etc/koha/sites location) copy a template file that has __LOG_DIR__ and I feel like that won't work - those would get updated when the instance was installed, but copying them won't cut it, you'll have to fill that in yourself when testing. Updating the log4perl.conf file to have the correct paths to the log files seems to fix this init problem, and ALSO happily, the datetime stamps appear in the log. Can someone else confirm all of that? Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 21:03:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 20:03:35 +0000 Subject: [Koha-bugs] [Bug 22483] haspermissions previously supported passing 'undef' for $flagsrequired In-Reply-To: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22483-70-VCX962g4Jn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22483 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 21:03:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 20:03:56 +0000 Subject: [Koha-bugs] [Bug 19469] Add ability to split view of holds view on record by pickup library and/or itemtype In-Reply-To: <bug-19469-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19469-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19469-70-fNlHnJAZjM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19469 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 21:29:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 20:29:13 +0000 Subject: [Koha-bugs] [Bug 18235] Elastic search - Configurable facets In-Reply-To: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18235-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18235-70-2taqpITkWX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18235 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 21:29:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 20:29:05 +0000 Subject: [Koha-bugs] [Bug 19661] Add routes for funds In-Reply-To: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19661-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19661-70-8k6eTXAJBA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19661 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 21:52:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 20:52:22 +0000 Subject: [Koha-bugs] [Bug 22604] "Error : the selected language is not currently available" for French In-Reply-To: <bug-22604-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22604-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22604-70-9i0L9Cx4cb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22604 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- fr-French is not a correct language code. Try: fr-FR instead. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 21:52:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 20:52:31 +0000 Subject: [Koha-bugs] [Bug 22604] "Error : the selected language is not currently available" for French In-Reply-To: <bug-22604-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22604-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22604-70-XebzywbIus@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22604 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 22:05:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 21:05:27 +0000 Subject: [Koha-bugs] [Bug 22605] New: Adding the option to modify search like in the OPAC (advanced search) Message-ID: <bug-22605-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Bug ID: 22605 Summary: Adding the option to modify search like in the OPAC (advanced search) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: alexandre.breton at ccsr.qc.ca QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Once we did an advanced search in the OPAC, we have have the option to modify the criterias of this last search ("Return to the last advanced search" just on top of the results list). But in the "on site" Koha we don't have this option. Wchich can save a lot of time when we have long and precise searches to do allowing to refine the criterias rather than enter all of them again. Thanks, Alexandre -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 22:32:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 21:32:04 +0000 Subject: [Koha-bugs] [Bug 16357] Plack error logs are not time stamped In-Reply-To: <bug-16357-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16357-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16357-70-tAt7v6Npk4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 --- Comment #35 from Liz Rea <wizzyrea at gmail.com> --- So my test plan was * make sure the modules required were installed Plack::Middleware::LogErrors Plack::Middleware::LogWarn * Copy the files in as before sudo cp debian/templates/plack.psgi /etc/koha/kohadev/plack.psgi sudo cp etc/log4perl.conf /etc/koha/sites/kohadev/log4perl.conf sudo cp debian/templates/log4perl-site.conf.in /etc/koha/log4perl-site.conf.in * EDIT those files once in situ to reflect the paths in your install - for kohadevbox (and any debian instance based test environment) it'll be /var/log/koha/kohadev/plack-error.log * Restart plack (kohadevbox is restart_all) kohadevbox has a way to copy in the debian files but I didn't use that - in the misc4dev there is a "cp_debian_files.pl" which updates the debian files. It might be good to try it. Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 22:36:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 21:36:13 +0000 Subject: [Koha-bugs] [Bug 18888] Include the definition of currency in onboarding tool In-Reply-To: <bug-18888-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18888-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18888-70-970coHwKmV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18888 Hayley Mapley <hayleymapley at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 23:11:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 22:11:47 +0000 Subject: [Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future In-Reply-To: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19014-70-rudQ2uZD8d@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Jess Tobin <lara005 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lara005 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Mar 28 23:26:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Mar 2019 22:26:57 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: <bug-6473-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6473-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6473-70-pXcK2aAtZ8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #224 from Hayley Mapley <hayleymapley at catalyst.net.nz> --- Created attachment 87152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87152&action=edit Bug 18308 - Added step to onboarding tool to set minPasswordLength This patch increases the default minPasswordLength syspref value to 8 characters, for new installations. The final (6th step) of the onboarding tool is now a password length page where the default value of 8 can be altered. There is a security warning in red recommending to the user they keep the minimum length of the password at 8 characters or more. This patch also removes the atomicupdate .sql file to be run in an update to alter the default minPasswordLength value for existing Koha installations, based on tester feedback. Test plan: 1. Create a patron with a password less than 3 characters in length and notice that a red message is displayed by the input telling you that the password must be 3 characters minimum length 2. Query the database "select value from systempreferences where variable="minPasswordLength"; and notice the value is 3 3. Drop and recreate your database and restart memcached 4. Go through the web installer and onboarding tool. Noticing the last step of the onboarding tool is to create a circulation rule 5. Apply patch 6. Repeat step 3 7. Go through the web installer and onboarding tool. Noticing the last step of the onboarding tool is to set the minimum password length, the numerical input element has a default value of 8 and notice that it will go below 3 8. Repeat step 2 and notice the value is 8 9. In the onboarding tool change the minimum password length value to 7 and submit the form 10. Notice the completed page of the onboarding tool is displayed with the message that the minimum password length has been set. 11. Repeat step 2 and notice the value is now 7. 12. Try to create a patron in Intranet and OPAC with a password less than 7 characters and notice that a red message is displayed by the input telling you that the password must be 7 characters minimum length Sponsored-By: Catalyst IT Signed-off-by: David Bourgault <david.bourgault at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 02:05:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 01:05:52 +0000 Subject: [Koha-bugs] [Bug 22605] Adding the option to modify search like in the OPAC (advanced search) In-Reply-To: <bug-22605-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22605-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22605-70-fnrQE0sSMR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 08:50:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 07:50:46 +0000 Subject: [Koha-bugs] [Bug 22606] New: Memcached Issues after Upgrade Message-ID: <bug-22606-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22606 Bug ID: 22606 Summary: Memcached Issues after Upgrade Change sponsored?: --- Product: Koha Version: 18.11 Hardware: PC OS: Linux Status: NEW Severity: normal Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs at lists.koha-community.org Reporter: mehmet.akgul at mirakil.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- After either upgrading to or directly installing Koha ver. 18.xx anytime I try to install a language pack, I get the following error: Connection to the memcached servers '_MEMCACHED_SERVERS_' failed. Are the unix socket permissions set properly? Is the host reachable? If you ignore this warning, you will face performance issues. Use of uninitialized value $pref_name in concatenation (.) or string at /usr/share/koha/misc/translator/LangInstaller.pm line 197. Use of uninitialized value $pref_name in concatenation (.) or string at /usr/share/koha/misc/translator/LangInstaller.pm line 239. On my /etc/apache2/sites-enabled/koha.conf I have set the following lines to opac and intranet, and on the about page it says memcached is running SetEnv MEMCACHED_SERVERS "127.0.0.1:11211" SetEnv MEMCACHED_NAMESPACE "koha" SetEnv MEMCACHED_SERVERS "127.0.0.1:11211" SetEnv MEMCACHED_NAMESPACE "koha-yonetim" I also can not use most of management module and opac module after the upgrade, like borrowing. Below is one such issue. Template process failed: undef error - DBIx::Class::Storage::DBI::_dbh_execute(): Table 'koha_koha.club_enrollments' doesn't exist at /usr/share/koha/lib/Koha/Objects.pm line 269 I had none of these issues in the previous versions. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 08:51:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 07:51:40 +0000 Subject: [Koha-bugs] [Bug 22607] New: Default value in issues.renewals should be '0' not null Message-ID: <bug-22607-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22607 Bug ID: 22607 Summary: Default value in issues.renewals should be '0' not null Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: josef.moravec at gmail.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 08:51:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 07:51:53 +0000 Subject: [Koha-bugs] [Bug 22607] Default value in issues.renewals should be '0' not null In-Reply-To: <bug-22607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22607-70-MRmfuyuwcN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22607 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |josef.moravec at gmail.com |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 08:54:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 07:54:23 +0000 Subject: [Koha-bugs] [Bug 17003] REST API: add route to get checkout's renewability In-Reply-To: <bug-17003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17003-70-ECZjj6sCCf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17003 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://wiki.koha-community | |.org/wiki/Checkouts_endpoin | |t_RFC#Checkout_renewability | |_2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 09:09:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 08:09:44 +0000 Subject: [Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove In-Reply-To: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21336-70-V1D2XBK3rY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 --- Comment #72 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #71) > I am not sure about that, it sounds better to me to have another attribute. I would strongly prefer to do that on another report now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 09:09:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 08:09:43 +0000 Subject: [Koha-bugs] [Bug 10345] Copy number should be incremented when adding multiple items at once In-Reply-To: <bug-10345-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10345-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10345-70-kk49FzvOq4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10345 --- Comment #4 from Bj?rn Nyl?n <bjorn.nylen at ub.lu.se> --- Created attachment 87153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87153&action=edit Bug 10345: Increment copy number when adding multiple copies. To test: 1. Add multiple copies of an item with data in the 'Copy number' field. Note that tha data will be identical for all items. 2. Apply patch. 3. Add multiple copies of an item with a positive integer (ie. only digits) in the 'Copy number' field. Note that the copy number is incremented for each item. 4. Add multiple copies of an item with some other type of data in the 'Copy number' field. Note that the copy number field remains unchanged for the added items. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 09:10:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 08:10:14 +0000 Subject: [Koha-bugs] [Bug 10345] Copy number should be incremented when adding multiple items at once In-Reply-To: <bug-10345-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10345-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10345-70-AIYGwiIuKg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10345 Bj?rn Nyl?n <bjorn.nylen at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |bjorn.nylen at ub.lu.se Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 09:11:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 08:11:17 +0000 Subject: [Koha-bugs] [Bug 10345] Copy number should be incremented when adding multiple items at once In-Reply-To: <bug-10345-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10345-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10345-70-tflr4jTxca@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10345 Bj?rn Nyl?n <bjorn.nylen at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 09:16:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 08:16:50 +0000 Subject: [Koha-bugs] [Bug 22607] Default value in issues.renewals should be '0' not null In-Reply-To: <bug-22607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22607-70-eiiXmkuUAT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22607 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17003 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17003 [Bug 17003] REST API: add route to get checkout's renewability -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 09:16:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 08:16:50 +0000 Subject: [Koha-bugs] [Bug 17003] REST API: add route to get checkout's renewability In-Reply-To: <bug-17003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17003-70-uw7uVzdfAv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17003 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22607 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22607 [Bug 22607] Default value in issues.renewals should be '0' not null -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 09:16:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 08:16:56 +0000 Subject: [Koha-bugs] [Bug 22607] Default value in issues.renewals should be '0' not null In-Reply-To: <bug-22607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22607-70-7kKXyRPeMe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22607 --- Comment #1 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 87154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87154&action=edit Bug 22607: Change default value in issues.renewals to '0'. This patch change renewals column of issues and old_issues tables. Now it is NOT NULL default 0. It does not make sense when number of renewals is undefined, it is always integer with value zero or more -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 09:17:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 08:17:12 +0000 Subject: [Koha-bugs] [Bug 22607] Default value in issues.renewals should be '0' not null In-Reply-To: <bug-22607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22607-70-BjeONMxVeS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22607 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 09:21:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 08:21:57 +0000 Subject: [Koha-bugs] [Bug 17003] REST API: add route to get checkout's renewability In-Reply-To: <bug-17003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17003-70-QvAeWsccBx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17003 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 09:22:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 08:22:00 +0000 Subject: [Koha-bugs] [Bug 17003] REST API: add route to get checkout's renewability In-Reply-To: <bug-17003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17003-70-TALzOCT7jm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17003 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #85475|0 |1 is obsolete| | Attachment #85476|0 |1 is obsolete| | --- Comment #14 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 87155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87155&action=edit Bug 17003: Add API route to get checkout's renewability -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 09:22:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 08:22:04 +0000 Subject: [Koha-bugs] [Bug 17003] REST API: add route to get checkout's renewability In-Reply-To: <bug-17003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17003-70-6e8AumbMRS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17003 --- Comment #15 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 87156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87156&action=edit Bug 17003: Adapt to OpenAPI Test plan: prove t/db_dependent/api/v1/checkouts.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 09:22:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 08:22:07 +0000 Subject: [Koha-bugs] [Bug 17003] REST API: add route to get checkout's renewability In-Reply-To: <bug-17003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17003-70-uEQKf2dIOu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17003 --- Comment #16 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 87157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87157&action=edit Bug 17003: (follow-up) Update definitions according to voted RFC Test plan: 1) Have some patrons with checkouts, some renewable and some not renewable 2) Use your favorite API tester and access GET http://koha.url/api/v1/checkouts/{checkout_id}/allows_renewal 3) Check the response is OK according to voted RFC: https://wiki.koha-community.org/wiki/Checkouts_endpoint_RFC#Checkout_renewability_2 4) prove t/db_dependent/api/v1/checkouts.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 09:22:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 08:22:36 +0000 Subject: [Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove In-Reply-To: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21336-70-XXPq7fhFW7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83202|0 |1 is obsolete| | Attachment #83203|0 |1 is obsolete| | Attachment #83204|0 |1 is obsolete| | Attachment #83205|0 |1 is obsolete| | Attachment #83206|0 |1 is obsolete| | Attachment #83207|0 |1 is obsolete| | Attachment #83208|0 |1 is obsolete| | Attachment #83209|0 |1 is obsolete| | Attachment #83256|0 |1 is obsolete| | --- Comment #73 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 87158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87158&action=edit Bug 21336: Database revision for borrowers.flgAnonymized This new flag should speak for itself ;) Test plan: Run installer or updatedatabase. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 09:22:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 08:22:42 +0000 Subject: [Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove In-Reply-To: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21336-70-F6HSSYYfqV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 --- Comment #74 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 87159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87159&action=edit Bug 21336: Dbrev for new prefs This patch adds three new prefs: - UnsubscribeReflectionDelay - PatronAnonymizeDelay - PatronRemovalDelay Test plan: Run upgrade. Check patrons pref page. Look under Privacy. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 09:22:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 08:22:47 +0000 Subject: [Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove In-Reply-To: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21336-70-20D89uNhSf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 --- Comment #75 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 87160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87160&action=edit Bug 21336: Do not increase login_attempts after locking If an account has been locked, there is no use to keep increasing this number. It is not true too; after the pref number has been reached, we can not really speak of login attempts anymore. The credentials are just ignored. Adding a dbrev to put existing values in line. And a simple test in Auth.t to confirm that login_attempts stop increasing. Note: It feels safe to keep the '>=' condition in account_locked. But it could obviously be changed to '=='. (Added a test for that.) Note: Adding a mock_preference in Auth.t too for GDPR_Policy. Since not all tests will pass when the pref is enabled (though disabled by default). Test plan: Run dbrev with updatedatabase.pl. Run t/db_dependent/Koha/Patrons.t Run t/db_dependent/Auth.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 09:22:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 08:22:52 +0000 Subject: [Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove In-Reply-To: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21336-70-HQbQWimkSZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 --- Comment #76 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 87161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87161&action=edit Bug 21336: Introduce administrative lockout As a preparation for Koha::Patron->lock, we add the concept of administrative lockout. The account is locked just as it would have been by too much failed login attempts. This is handled by a negative value in borrowers.login_attempts. Test plan: Run t/db_dependent/Auth.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 09:22:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 08:22:57 +0000 Subject: [Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove In-Reply-To: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21336-70-yWkppCYZnf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 --- Comment #77 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 87162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87162&action=edit Bug 21336: Search, lock and anonymize methods Add Koha::Patron->lock and anonymize. Add Koha::Patrons methods search_unsubscribed, search_anonymize_candidates and search_anonymized. And wrappers for lock and anonymize. Add unit tests. Test plan: Run t/db_dependent/Koha/Patrons.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 09:23:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 08:23:02 +0000 Subject: [Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove In-Reply-To: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21336-70-tOZQyX9FYQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 --- Comment #78 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 87163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87163&action=edit Bug 21336: Adjust cleanup_database.pl Add the new Patron routines to this cron job. Actions are performed only if preferences are set. Note: No specific command line flags for these actions are added here (and probably not needed too). So no crontab changes too. Test plan: Add a new patron. Enable GDPR_Policy and refuse consent on OPAC for this patron. Set only the first delay to zero (0) for immediate action. Run cleanup_database.pl --logs (or any other flag) for the first time. Check lock and expiration. Set the second delay to zero (0) for immediate action. Run cleanup_database.pl --logs for the second time. Check anonymization. Set the third delay to zero (0) for immediate action. Run cleanup_database.pl --logs for the third time. Check removal. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Amended: Added the warn $@ line in cleanup_database.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 09:23:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 08:23:07 +0000 Subject: [Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove In-Reply-To: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21336-70-rLDJmIAVZX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 --- Comment #79 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 87164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87164&action=edit Bug 21336: (follow-up) Fix last line after PatronRemovalDelay in pref file Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 09:23:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 08:23:12 +0000 Subject: [Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove In-Reply-To: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21336-70-CrT7yL7f24@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 --- Comment #80 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 87165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87165&action=edit Bug 21336: (follow-up) Handle strict SQL mode in _anonymize_column When a field is not nullable we should pass empty string, zero or today to a char, numeric or date column. The mandatory parameter does not refer to a database constraint but a Koha preference. Only for strings we generate a random value. Test plan: Enable strict_sql_modes. Run t/db_dependent/Koha/Patrons.t again. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 09:23:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 08:23:13 +0000 Subject: [Koha-bugs] [Bug 17003] REST API: add route to get checkout's renewability In-Reply-To: <bug-17003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17003-70-0T4xqliKtv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17003 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|lari.taskula at hypernova.fi |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 09:23:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 08:23:18 +0000 Subject: [Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove In-Reply-To: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21336-70-jCpHcWd0zY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 --- Comment #81 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 87166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87166&action=edit Bug 21336: [DO_NOT_PUSH] DBIx changes MariaDB somehow turns current_timestamp into current_timestamp(). The needed change is for column flgAnonymized. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 09:34:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 08:34:16 +0000 Subject: [Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove In-Reply-To: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21336-70-iYBHOXc9gs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87166|0 |1 is obsolete| | --- Comment #82 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 87167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87167&action=edit Bug 21336: (QA follow-up) Add column_exists in db revision As requested by Josef on comment70. Test plan: Run db revision twice. No warnings. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 09:34:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 08:34:23 +0000 Subject: [Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove In-Reply-To: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21336-70-KjzXEIcyuv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 --- Comment #83 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 87168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87168&action=edit Bug 21336: [DO_NOT_PUSH] DBIx changes MariaDB somehow turns current_timestamp into current_timestamp(). The needed change is for column flgAnonymized. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 09:41:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 08:41:01 +0000 Subject: [Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove In-Reply-To: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21336-70-DFtN6bQyDJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #84 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Josef Moravec from comment #70) > Just one small think: > > database update should use column_exists on adding flgAnonymized column > > but otherwise looking good for me... Rebased all stuff. Added a follow-up for the column_exists. Could you add your signoff line please? Hopefully we can get another QAer to have a look in the next weeks. This code runs in production with me for about four months. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 10:01:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 09:01:53 +0000 Subject: [Koha-bugs] [Bug 20664] Optimize retrieval of biblio and item data In-Reply-To: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20664-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20664-70-sK2tiQhsYR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20664 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |In Discussion --- Comment #84 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- + # This is so much faster than using Koha::Items->search that it makes sense even if it's ugly. + my $query = 'SELECT * FROM items WHERE biblionumber = ?'; Patch still applies. If I am reading thru the comments above, the main point of discussion is now: Do we want to return to raw sql in the above lines? It is rather obvious that this is faster than Koha::Object/DBIx. But we made a choice for DBIx and are still wrestling to implement it in the codebase. What would be the decisive reason for making the exception here, and would it be a precedent for doing similar things elsewhere? Also note that although the test plan refers to verifying that things are faster, I do not see any benchmark figures on the report. Moving to discussion and sending mail to QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 10:13:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 09:13:57 +0000 Subject: [Koha-bugs] [Bug 22547] C4::Overdues - UpdateFine is barely tested In-Reply-To: <bug-22547-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22547-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22547-70-vDTKIQqzRQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22547 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |BLOCKED --- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- QA: Looking here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 11:13:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 10:13:47 +0000 Subject: [Koha-bugs] [Bug 22547] C4::Overdues - UpdateFine is barely tested In-Reply-To: <bug-22547-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22547-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22547-70-fb8CS1Lyat@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22547 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA --- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Martin, I am having some doubts about doing these kind of things in the test: $fine->amountoutstanding('50')->store; This obviously is a shortcut for doing the payment via 'nice' Koha calls, but I think it would be better to use the regular calls in order to find integration bugs and not give a false sense of security. I tested a bit with something like: t::lib::Mocks::mock_userenv({ branchcode => $patron->branchcode }); Koha::Account->new({ patron_id => $patron->borrowernumber })->pay({ amount => 50, lines => [ $fine ], }); But it needs more attention.. This is no absolute blocker btw. It is great to have more tests here. But if you could improve now, please do. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 11:18:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 10:18:51 +0000 Subject: [Koha-bugs] [Bug 22586] IntranetReportsHomeHTML no longer renders as HTML on reports-home.pl In-Reply-To: <bug-22586-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22586-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22586-70-RhCXpuoda9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22586 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 11:18:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 10:18:53 +0000 Subject: [Koha-bugs] [Bug 22586] IntranetReportsHomeHTML no longer renders as HTML on reports-home.pl In-Reply-To: <bug-22586-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22586-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22586-70-K3VN44pxCH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22586 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87116|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 87169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87169&action=edit Bug 22586: IntranetReportsHomeHTML no longer renders as HTML on reports-home.pl As of 18.11 the IntranetReportsHomeHTML syspref no longer renders HTML on report-home.pl. I think this is being filtered wrong in the template. Test Plan: 1) Edit IntranetReportsHomeHTML, set to "<p>Test</p>" 2) View a report, note that you see the html p tags are displayed litterly 3) Apply this patch 4) Reload the page 5) Note the p tags are rendered as html Signed-off-by: George Williams <george at nekls.org> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 11:19:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 10:19:22 +0000 Subject: [Koha-bugs] [Bug 22586] IntranetReportsHomeHTML no longer renders as HTML on reports-home.pl In-Reply-To: <bug-22586-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22586-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22586-70-uArTHCUdSy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22586 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Version|18.11 |master QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 11:22:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 10:22:31 +0000 Subject: [Koha-bugs] [Bug 22596] html TT filter is breaking items search with custom field In-Reply-To: <bug-22596-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22596-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22596-70-PifWCPEdZZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22596 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 11:22:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 10:22:34 +0000 Subject: [Koha-bugs] [Bug 22596] html TT filter is breaking items search with custom field In-Reply-To: <bug-22596-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22596-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22596-70-H7RLJpCYTu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22596 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87123|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 87170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87170&action=edit Bug 22596: use raw TT filter in items search with custom field When items search is with a custom field using authorised values, html TT filter is breaking the JS, it should use raw. Test plan : 1) Go to Administration > Item search fields 2) Define a search field with an authorised values category 3) Go to items search 4) Use the "New field" link 5) Check use of custom field is OK Signed-off-by: Liz Rea <wizzyrea at gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 11:22:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 10:22:47 +0000 Subject: [Koha-bugs] [Bug 22596] html TT filter is breaking items search with custom field In-Reply-To: <bug-22596-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22596-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22596-70-ckaapFVVyY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22596 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 11:28:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 10:28:46 +0000 Subject: [Koha-bugs] [Bug 22518] accounttype 'O' is still referred to but is never set In-Reply-To: <bug-22518-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22518-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22518-70-MX6aEMoJtT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22518 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 11:28:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 10:28:49 +0000 Subject: [Koha-bugs] [Bug 22518] accounttype 'O' is still referred to but is never set In-Reply-To: <bug-22518-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22518-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22518-70-hqX6QgJUPL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22518 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87019|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 87171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87171&action=edit Bug 22518: Remove references to 'O' accounttype I went back over 12 years to and still only found "FIXME: What are these accounttypes" concerning the 'O' type and I couldn't find anywhere where it was being set. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 11:28:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 10:28:54 +0000 Subject: [Koha-bugs] [Bug 22518] accounttype 'O' is still referred to but is never set In-Reply-To: <bug-22518-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22518-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22518-70-RPDy2bn9vj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22518 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87020|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 87172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87172&action=edit Bug 22518: Add database update 'just in case' All cases I could find where 'O' was referenced it was referenced alongside 'FU'.. as such I've written this DB update to case any last cases of 'O' and update them to 'FU' "just in case" Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 11:29:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 10:29:28 +0000 Subject: [Koha-bugs] [Bug 22518] accounttype 'O' is still referred to but is never set In-Reply-To: <bug-22518-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22518-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22518-70-o6gdf0IgT2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22518 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | --- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Bonus points for adding the number of changed lines in the dbrev.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 11:34:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 10:34:05 +0000 Subject: [Koha-bugs] [Bug 22564] accounttype 'Rep' is still referred to but is never set In-Reply-To: <bug-22564-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22564-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22564-70-oFJLP36FUi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy at rijksmuseum.nl --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Add a db rev just like the other report? Report changed number ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 11:34:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 10:34:34 +0000 Subject: [Koha-bugs] [Bug 22564] accounttype 'Rep' is still referred to but is never set In-Reply-To: <bug-22564-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22564-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22564-70-gFqjb4XuFK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 11:36:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 10:36:51 +0000 Subject: [Koha-bugs] [Bug 22358] Add POD to Koha::SharedContent In-Reply-To: <bug-22358-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22358-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22358-70-orUQhseUOY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22358 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy at rijksmuseum.nl --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- =head1 SharedContent Koha::SharedContent - Set of methods to quering Mana KB server That is not an expected POD header.. And a typo too (quering) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 11:37:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 10:37:02 +0000 Subject: [Koha-bugs] [Bug 22358] Add POD to Koha::SharedContent In-Reply-To: <bug-22358-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22358-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22358-70-WJP4tEI0pc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22358 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 11:40:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 10:40:59 +0000 Subject: [Koha-bugs] [Bug 22127] Update dateaccessioned value builder In-Reply-To: <bug-22127-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22127-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22127-70-Qelm8dq5qi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22127 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 11:41:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 10:41:02 +0000 Subject: [Koha-bugs] [Bug 22127] Update dateaccessioned value builder In-Reply-To: <bug-22127-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22127-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22127-70-ikMSrgyNlR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22127 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87027|0 |1 is obsolete| | --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 87173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87173&action=edit Bug 22127: Update date accessioned plugin - remove unused routine Test plan: 1) Apply the patch 2) Have set dateaccessioned plugin to an item subfield (it is set on 952$d by default) 3) Confirm the functionality of this plugin is same as before patch Signed-off-by: Michal Denar <black23 at gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 11:42:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 10:42:29 +0000 Subject: [Koha-bugs] [Bug 22127] Update dateaccessioned value builder In-Reply-To: <bug-22127-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22127-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22127-70-rmZLd9knvD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22127 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 11:45:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 10:45:13 +0000 Subject: [Koha-bugs] [Bug 17005] REST API: add routes to list checkouts history In-Reply-To: <bug-17005-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17005-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17005-70-ES2pDT2Orf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17005 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Municipal Libray Ceska | release notes|Trebova | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 11:47:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 10:47:38 +0000 Subject: [Koha-bugs] [Bug 22518] accounttype 'O' is still referred to but is never set In-Reply-To: <bug-22518-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22518-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22518-70-jZvvyrKOXS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22518 --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87174&action=edit Bug 22518: (QA follow-up) Add rows updated to feedback Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 11:49:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 10:49:28 +0000 Subject: [Koha-bugs] [Bug 21646] Clean up Overdrive template In-Reply-To: <bug-21646-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21646-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21646-70-z0MAZ7hy5s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21646 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- OverDrive library authnames : Not the most appealing form title, I guess? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 11:50:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 10:50:59 +0000 Subject: [Koha-bugs] [Bug 21646] Clean up Overdrive template In-Reply-To: <bug-21646-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21646-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21646-70-n0fe36VXuB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21646 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 11:51:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 10:51:02 +0000 Subject: [Koha-bugs] [Bug 21646] Clean up Overdrive template In-Reply-To: <bug-21646-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21646-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21646-70-FkCgismsKW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21646 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86982|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 87175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87175&action=edit Bug 21646: Clean up Overdrive template This patch modifies the OverDrive administration page to correct some markup issues: - Switch to Bootstrap grid - Add missing header search box - Add missing DataTable configuration - Remove unnecessary fieldset To test you do not need to have OverDrive credentials. Apply the patch and go to System preferences -> Enhanced content -> OverDrive. In the description of the "OverDriveAuthName" preference, follow the link to manage "individual branch authnames." - Confirm that the page looks correct, including the header search box, page title, and breadcrumbs - Confirm that the page adjusts well to various browser window sizes. - Confirm that the DataTable works correctly. Signed-off-by: Liz Rea <wizzyrea at gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 11:51:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 10:51:14 +0000 Subject: [Koha-bugs] [Bug 21646] Clean up Overdrive template In-Reply-To: <bug-21646-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21646-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21646-70-jqscZHjR11@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21646 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 11:55:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 10:55:36 +0000 Subject: [Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove In-Reply-To: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21336-70-e9a9Z8iGgY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87158|0 |1 is obsolete| | Attachment #87159|0 |1 is obsolete| | Attachment #87160|0 |1 is obsolete| | Attachment #87161|0 |1 is obsolete| | Attachment #87162|0 |1 is obsolete| | Attachment #87163|0 |1 is obsolete| | Attachment #87164|0 |1 is obsolete| | Attachment #87165|0 |1 is obsolete| | Attachment #87167|0 |1 is obsolete| | Attachment #87168|0 |1 is obsolete| | --- Comment #85 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 87176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87176&action=edit Bug 21336: Database revision for borrowers.flgAnonymized This new flag should speak for itself ;) Test plan: Run installer or updatedatabase. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 11:55:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 10:55:41 +0000 Subject: [Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove In-Reply-To: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21336-70-4yhD1OeLsF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 --- Comment #86 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 87177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87177&action=edit Bug 21336: Dbrev for new prefs This patch adds three new prefs: - UnsubscribeReflectionDelay - PatronAnonymizeDelay - PatronRemovalDelay Test plan: Run upgrade. Check patrons pref page. Look under Privacy. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 11:55:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 10:55:46 +0000 Subject: [Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove In-Reply-To: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21336-70-cuQuj2JRny@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 --- Comment #87 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 87178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87178&action=edit Bug 21336: Do not increase login_attempts after locking If an account has been locked, there is no use to keep increasing this number. It is not true too; after the pref number has been reached, we can not really speak of login attempts anymore. The credentials are just ignored. Adding a dbrev to put existing values in line. And a simple test in Auth.t to confirm that login_attempts stop increasing. Note: It feels safe to keep the '>=' condition in account_locked. But it could obviously be changed to '=='. (Added a test for that.) Note: Adding a mock_preference in Auth.t too for GDPR_Policy. Since not all tests will pass when the pref is enabled (though disabled by default). Test plan: Run dbrev with updatedatabase.pl. Run t/db_dependent/Koha/Patrons.t Run t/db_dependent/Auth.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 11:55:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 10:55:50 +0000 Subject: [Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove In-Reply-To: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21336-70-TbV4qwP7Q3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 --- Comment #88 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 87179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87179&action=edit Bug 21336: Introduce administrative lockout As a preparation for Koha::Patron->lock, we add the concept of administrative lockout. The account is locked just as it would have been by too much failed login attempts. This is handled by a negative value in borrowers.login_attempts. Test plan: Run t/db_dependent/Auth.t Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 11:55:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 10:55:34 +0000 Subject: [Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove In-Reply-To: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21336-70-k9n5SQGpQw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 11:55:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 10:55:55 +0000 Subject: [Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove In-Reply-To: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21336-70-8DeQJCHUbU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 --- Comment #89 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 87180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87180&action=edit Bug 21336: Search, lock and anonymize methods Add Koha::Patron->lock and anonymize. Add Koha::Patrons methods search_unsubscribed, search_anonymize_candidates and search_anonymized. And wrappers for lock and anonymize. Add unit tests. Test plan: Run t/db_dependent/Koha/Patrons.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 11:55:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 10:55:59 +0000 Subject: [Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove In-Reply-To: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21336-70-jJeqhVPuU1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 --- Comment #90 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 87181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87181&action=edit Bug 21336: Adjust cleanup_database.pl Add the new Patron routines to this cron job. Actions are performed only if preferences are set. Note: No specific command line flags for these actions are added here (and probably not needed too). So no crontab changes too. Test plan: Add a new patron. Enable GDPR_Policy and refuse consent on OPAC for this patron. Set only the first delay to zero (0) for immediate action. Run cleanup_database.pl --logs (or any other flag) for the first time. Check lock and expiration. Set the second delay to zero (0) for immediate action. Run cleanup_database.pl --logs for the second time. Check anonymization. Set the third delay to zero (0) for immediate action. Run cleanup_database.pl --logs for the third time. Check removal. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Amended: Added the warn $@ line in cleanup_database.pl Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 11:56:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 10:56:04 +0000 Subject: [Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove In-Reply-To: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21336-70-kse2azHCVZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 --- Comment #91 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 87182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87182&action=edit Bug 21336: (follow-up) Fix last line after PatronRemovalDelay in pref file Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 11:56:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 10:56:09 +0000 Subject: [Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove In-Reply-To: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21336-70-vs8eBkPUGb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 --- Comment #92 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 87183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87183&action=edit Bug 21336: (follow-up) Handle strict SQL mode in _anonymize_column When a field is not nullable we should pass empty string, zero or today to a char, numeric or date column. The mandatory parameter does not refer to a database constraint but a Koha preference. Only for strings we generate a random value. Test plan: Enable strict_sql_modes. Run t/db_dependent/Koha/Patrons.t again. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 11:56:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 10:56:13 +0000 Subject: [Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove In-Reply-To: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21336-70-czn641zJwz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 --- Comment #93 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 87184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87184&action=edit Bug 21336: (QA follow-up) Add column_exists in db revision As requested by Josef on comment70. Test plan: Run db revision twice. No warnings. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 11:56:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 10:56:17 +0000 Subject: [Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove In-Reply-To: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21336-70-qzQner7Ptj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 --- Comment #94 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 87185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87185&action=edit Bug 21336: [DO_NOT_PUSH] DBIx changes MariaDB somehow turns current_timestamp into current_timestamp(). The needed change is for column flgAnonymized. Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 12:00:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 11:00:25 +0000 Subject: [Koha-bugs] [Bug 20447] Add support for MARC holdings records In-Reply-To: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20447-70-3yp6OkLh0W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447 Frank Hansen <frank.hansen at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frank.hansen at ub.lu.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 12:02:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 11:02:34 +0000 Subject: [Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove In-Reply-To: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21336-70-PFPfTnkojl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Small patch |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 12:06:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 11:06:55 +0000 Subject: [Koha-bugs] [Bug 21622] Incorrect GROUP BY clause in acqui/ scripts In-Reply-To: <bug-21622-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21622-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21622-70-cQzZguSQJ6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21622 --- Comment #19 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Nick Clemens from comment #18) > Created attachment 86974 [details] [review] > Bug 21622: (RM follow-up) adjust for changes from bug 21282 Followup pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 12:13:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 11:13:00 +0000 Subject: [Koha-bugs] [Bug 20073] Move Elasticsearch settings to configuration files In-Reply-To: <bug-20073-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20073-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20073-70-puH0xc93m2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20073 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 12:29:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 11:29:31 +0000 Subject: [Koha-bugs] [Bug 22518] accounttype 'O' is still referred to but is never set In-Reply-To: <bug-22518-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22518-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22518-70-9wv2rV73EL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22518 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 12:30:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 11:30:10 +0000 Subject: [Koha-bugs] [Bug 22518] accounttype 'O' is still referred to but is never set In-Reply-To: <bug-22518-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22518-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22518-70-qZ6F0qjQ0Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22518 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87174|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87186&action=edit Bug 22518: (QA follow-up) Add rows updated to feedback Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 12:46:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 11:46:14 +0000 Subject: [Koha-bugs] [Bug 22586] IntranetReportsHomeHTML no longer renders as HTML on reports-home.pl In-Reply-To: <bug-22586-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22586-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22586-70-UjRNvWWFfC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22586 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 12:46:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 11:46:25 +0000 Subject: [Koha-bugs] [Bug 22596] html TT filter is breaking items search with custom field In-Reply-To: <bug-22596-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22596-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22596-70-Latf2rDA8V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22596 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #4 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 12:46:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 11:46:34 +0000 Subject: [Koha-bugs] [Bug 22127] Update dateaccessioned value builder In-Reply-To: <bug-22127-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22127-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22127-70-D2QhypLdT5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22127 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master CC| |nick at bywatersolutions.com --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 12:46:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 11:46:49 +0000 Subject: [Koha-bugs] [Bug 22518] accounttype 'O' is still referred to but is never set In-Reply-To: <bug-22518-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22518-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22518-70-I5U7IhMMdV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22518 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #10 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 12:47:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 11:47:32 +0000 Subject: [Koha-bugs] [Bug 21646] Clean up Overdrive template In-Reply-To: <bug-21646-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21646-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21646-70-khzFnWSCgH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21646 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Status|Passed QA |Pushed to Master --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 12:50:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 11:50:19 +0000 Subject: [Koha-bugs] [Bug 21852] Add more columns and column configuration to overdues report In-Reply-To: <bug-21852-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21852-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21852-70-UrW7pXxShm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21852 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22276 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 12:50:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 11:50:19 +0000 Subject: [Koha-bugs] [Bug 22276] Add client storage of user-selected DataTables configuration In-Reply-To: <bug-22276-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22276-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22276-70-tg9omYJqk1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22276 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21852 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:17:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:17:51 +0000 Subject: [Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes In-Reply-To: <bug-22563-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22563-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22563-70-AoicCDqjBk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22564 Depends on|22564 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564 [Bug 22564] accounttype 'Rep' is still referred to but is never set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:17:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:17:51 +0000 Subject: [Koha-bugs] [Bug 22564] accounttype 'Rep' is still referred to but is never set In-Reply-To: <bug-22564-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22564-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22564-70-Gyv81Gbg29@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22563 Blocks|22563 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:18:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:18:46 +0000 Subject: [Koha-bugs] [Bug 22564] accounttype 'Rep' is still referred to but is never set In-Reply-To: <bug-22564-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22564-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22564-70-ofXRdylxHe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22563 Depends on|22563 |22512 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 [Bug 22512] accountlines.accountype mixes 'state' and 'type' https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:18:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:18:46 +0000 Subject: [Koha-bugs] [Bug 22512] accountlines.accountype mixes 'state' and 'type' In-Reply-To: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22512-70-JSHGM5S8mM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22564 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564 [Bug 22564] accounttype 'Rep' is still referred to but is never set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:18:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:18:46 +0000 Subject: [Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes In-Reply-To: <bug-22563-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22563-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22563-70-yzh1D7xCvf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22564 | Depends on| |22564 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564 [Bug 22564] accounttype 'Rep' is still referred to but is never set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:19:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:19:54 +0000 Subject: [Koha-bugs] [Bug 19380] Add transfer informations in ILS-DI GetRecords response In-Reply-To: <bug-19380-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19380-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19380-70-01oPLIsbx2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19380 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86801|0 |1 is obsolete| | --- Comment #12 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 87188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87188&action=edit Bug 19380: Use Koha::Item::get_transfer instead of GetTransfers Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:19:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:19:42 +0000 Subject: [Koha-bugs] [Bug 19380] Add transfer informations in ILS-DI GetRecords response In-Reply-To: <bug-19380-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19380-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19380-70-Bf294R8DnY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19380 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86800|0 |1 is obsolete| | --- Comment #11 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 87187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87187&action=edit Bug 19380: Add transfer informations in ILS-DI GetRecords response Test plan: 1. Put an item into a 'transfer' state a. Place a hold on an item in branch A for a patron of branch B b. Check in this item in branch A and confirm transfer 2. Go to http://opac/cgi-bin/koha/ilsdi.pl?service=GetRecords&id=XXX where XXX is the biblionumber of the biblio the item belongs to. 3. Verify you have a new <transfer> element inside //record/items/item that contains <datesent>, <frombranch> and <tobranch> 4. Check in the same item in branch B, so that the item is not flagged as being transferred 5. Repeat 2 6. Verify that the <transfer> element is not there. 7. prove t/db_dependent/ILSDI_Services.t Followed test plan, patch worked as described. Also ran QA test tools and modified files passed Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:20:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:20:13 +0000 Subject: [Koha-bugs] [Bug 19380] Add transfer informations in ILS-DI GetRecords response In-Reply-To: <bug-19380-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19380-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19380-70-GfZvJrrqb8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19380 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA --- Comment #13 from Julian Maurice <julian.maurice at biblibre.com> --- Patches rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:25:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:25:16 +0000 Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI In-Reply-To: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20388-70-4MZc3TigJX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Bj?rn Nyl?n <bjorn.nylen at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #42 from Bj?rn Nyl?n <bjorn.nylen at ub.lu.se> --- The patch doesnt apply for me on the current master. Applying: Bug 20388 - Add/delete search fields from search engine configuration page fatal: sha1 information is lacking or useless (admin/searchengine/elasticsearch/mappings.pl). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 20388 - Add/delete search fields from search engine configuration page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:27:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:27:25 +0000 Subject: [Koha-bugs] [Bug 22605] Adding the option to modify search like in the OPAC (advanced search) In-Reply-To: <bug-22605-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22605-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22605-70-FQyqWKT6oV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 Patrick Robitaille <patrick.robitaille at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |patrick.robitaille at collecto | |.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:29:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:29:03 +0000 Subject: [Koha-bugs] [Bug 22512] accountlines.accountype mixes 'state' and 'type' In-Reply-To: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22512-70-lichhUofir@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|22593 |22518 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22518 [Bug 22518] accounttype 'O' is still referred to but is never set https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22593 [Bug 22593] Cronjobs/Scripts dealing with accountlines need updating for bug 22008 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:29:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:29:03 +0000 Subject: [Koha-bugs] [Bug 22518] accounttype 'O' is still referred to but is never set In-Reply-To: <bug-22518-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22518-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22518-70-jPoYjENR1n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22518 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22512 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 [Bug 22512] accountlines.accountype mixes 'state' and 'type' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:29:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:29:03 +0000 Subject: [Koha-bugs] [Bug 22593] Cronjobs/Scripts dealing with accountlines need updating for bug 22008 In-Reply-To: <bug-22593-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22593-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22593-70-1W56AzCewD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22593 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22512 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 [Bug 22512] accountlines.accountype mixes 'state' and 'type' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:30:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:30:51 +0000 Subject: [Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines In-Reply-To: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22600-70-kjorDnRAmC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22564 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564 [Bug 22564] accounttype 'Rep' is still referred to but is never set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:30:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:30:51 +0000 Subject: [Koha-bugs] [Bug 22564] accounttype 'Rep' is still referred to but is never set In-Reply-To: <bug-22564-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22564-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22564-70-03VZxatrct@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22600 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 [Bug 22600] We should add an 'interface' field to accountlines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:31:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:31:42 +0000 Subject: [Koha-bugs] [Bug 22564] accounttype 'Rep' is still referred to but is never set In-Reply-To: <bug-22564-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22564-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22564-70-xgVxOndksl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|22512 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 [Bug 22512] accountlines.accountype mixes 'state' and 'type' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:31:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:31:42 +0000 Subject: [Koha-bugs] [Bug 22512] accountlines.accountype mixes 'state' and 'type' In-Reply-To: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22512-70-Mrvl98FESJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22564 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564 [Bug 22564] accounttype 'Rep' is still referred to but is never set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:32:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:32:40 +0000 Subject: [Koha-bugs] [Bug 22518] accounttype 'O' is still referred to but is never set In-Reply-To: <bug-22518-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22518-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22518-70-WqcCppYDf0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22518 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22521 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:32:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:32:40 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-DPWCXczu0G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|22518 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22518 [Bug 22518] accounttype 'O' is still referred to but is never set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:33:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:33:26 +0000 Subject: [Koha-bugs] [Bug 22547] C4::Overdues - UpdateFine is barely tested In-Reply-To: <bug-22547-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22547-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22547-70-13LDm4YLKH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22547 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22564 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564 [Bug 22564] accounttype 'Rep' is still referred to but is never set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:33:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:33:26 +0000 Subject: [Koha-bugs] [Bug 22564] accounttype 'Rep' is still referred to but is never set In-Reply-To: <bug-22564-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22564-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22564-70-LUcugC8OT6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22547 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22547 [Bug 22547] C4::Overdues - UpdateFine is barely tested -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:34:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:34:47 +0000 Subject: [Koha-bugs] [Bug 22564] accounttype 'Rep' is still referred to but is never set In-Reply-To: <bug-22564-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22564-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22564-70-A5uoyYCYSq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22547 |22521 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22547 [Bug 22547] C4::Overdues - UpdateFine is barely tested -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:34:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:34:47 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-H9jt8xuoEU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22564 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564 [Bug 22564] accounttype 'Rep' is still referred to but is never set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:34:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:34:47 +0000 Subject: [Koha-bugs] [Bug 22547] C4::Overdues - UpdateFine is barely tested In-Reply-To: <bug-22547-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22547-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22547-70-sad8DqcCQw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22547 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|22564 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564 [Bug 22564] accounttype 'Rep' is still referred to but is never set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:35:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:35:23 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-pZ1IwGxcWD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|22512 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 [Bug 22512] accountlines.accountype mixes 'state' and 'type' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:35:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:35:23 +0000 Subject: [Koha-bugs] [Bug 22512] accountlines.accountype mixes 'state' and 'type' In-Reply-To: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22512-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22512-70-bbR7To4F4D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22512 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22521 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:36:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:36:16 +0000 Subject: [Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes In-Reply-To: <bug-22563-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22563-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22563-70-UYg2nKZuvE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|22521 |22511 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 [Bug 22511] Koha::Account::Line->void loses the original type of the credit https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:36:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:36:16 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit In-Reply-To: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22511-70-6mMOXa8Yo6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22563 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:36:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:36:16 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-zdY57OvooY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22563 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:36:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:36:56 +0000 Subject: [Koha-bugs] [Bug 22564] accounttype 'Rep' is still referred to but is never set In-Reply-To: <bug-22564-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22564-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22564-70-DaYbaCcpw9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22563 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:36:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:36:56 +0000 Subject: [Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes In-Reply-To: <bug-22563-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22563-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22563-70-scomKpMmNc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|22564 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564 [Bug 22564] accounttype 'Rep' is still referred to but is never set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:38:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:38:02 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit In-Reply-To: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22511-70-AGKIAz0WEa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|17702 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 [Bug 17702] Create configuration for account types -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:38:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:38:02 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account types In-Reply-To: <bug-17702-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17702-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17702-70-dsQSPb5JoW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|22511 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 [Bug 22511] Koha::Account::Line->void loses the original type of the credit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:39:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:39:18 +0000 Subject: [Koha-bugs] [Bug 20589] Add field boosting and use elastic query fields parameter instead of deprecated _all In-Reply-To: <bug-20589-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20589-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20589-70-PS5XamvEqw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20589 Bj?rn Nyl?n <bjorn.nylen at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bjorn.nylen at ub.lu.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:40:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:40:50 +0000 Subject: [Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines In-Reply-To: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22600-70-ttzLeHgYys@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87137|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87189&action=edit Bug 22600: Add 'interface' to accountlines This patch adds the 'interface' field to the accountlines table and updates all Koha::Object routines and calls to use it. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:40:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:40:54 +0000 Subject: [Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines In-Reply-To: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22600-70-weU8E7RX0A@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87138|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87190&action=edit Bug 22600: Add 'api' to interface types and set appropriately This patch adds 'api' as a valid interface and sets it appropriately for both the new REST api and previous /svc/ api's. Handling to keep the interface of a logged in session is included such that if the OPAC or Intranet use the API's internally via a Cookie we will maintain the interface throughout the session. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:40:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:40:57 +0000 Subject: [Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines In-Reply-To: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22600-70-6IUn17l5qg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87139|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87191&action=edit Bug 22600: Add 'cron' to interface types and set appropriately This patch adds 'cron' as a valid interface and sets it appropriately for existing cron scripts. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:41:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:41:01 +0000 Subject: [Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines In-Reply-To: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22600-70-fqgjuO18qU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87140|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87192&action=edit Bug 22600: Set 'commandline' interface appropriately This patch change Koha::Cron to be a more generic Koha::Script class and update all commanline driven scripts to use it. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:41:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:41:05 +0000 Subject: [Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines In-Reply-To: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22600-70-iGaGbe6D3J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 --- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87193&action=edit Bug 22600: Update Tests adding 'interface' as needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:42:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:42:36 +0000 Subject: [Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines In-Reply-To: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22600-70-g7m4Y2Y9kr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 --- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Hopefully that most recent patchset should address the test failure and your other comments.. back to NSO -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:43:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:43:45 +0000 Subject: [Koha-bugs] [Bug 22564] accounttype 'Rep' is still referred to but is never set In-Reply-To: <bug-22564-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22564-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22564-70-DTzyFFThOe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87052|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87194&action=edit Bug 22564: Remove references to 'Rep' accounttype Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:43:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:43:48 +0000 Subject: [Koha-bugs] [Bug 22564] accounttype 'Rep' is still referred to but is never set In-Reply-To: <bug-22564-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22564-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22564-70-1Pif6motC7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564 --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87195&action=edit Bug 22564: Add database update 'just in case' With the introduction of the 'status' field it's a clear oportunity to convert any last remaining instances of 'Rep' to 'L' + 'REPLACED'. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:45:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:45:50 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-f1zbPeo5Lk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22564 Depends on|22564 |22600 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564 [Bug 22564] accounttype 'Rep' is still referred to but is never set https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 [Bug 22600] We should add an 'interface' field to accountlines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:45:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:45:50 +0000 Subject: [Koha-bugs] [Bug 22564] accounttype 'Rep' is still referred to but is never set In-Reply-To: <bug-22564-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22564-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22564-70-f4HF6obJbb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22521 | Depends on| |22521 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:45:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:45:50 +0000 Subject: [Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines In-Reply-To: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22600-70-RlAYORoB1T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22521 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:46:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:46:19 +0000 Subject: [Koha-bugs] [Bug 22564] accounttype 'Rep' is still referred to but is never set In-Reply-To: <bug-22564-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22564-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22564-70-WFOs6oQYsv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|22600 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 [Bug 22600] We should add an 'interface' field to accountlines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:46:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:46:19 +0000 Subject: [Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines In-Reply-To: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22600-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22600-70-WOZTGuRtAD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22564 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564 [Bug 22564] accounttype 'Rep' is still referred to but is never set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:48:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:48:29 +0000 Subject: [Koha-bugs] [Bug 22564] accounttype 'Rep' is still referred to but is never set In-Reply-To: <bug-22564-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22564-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22564-70-jJ0J0OGJJX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22511 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 [Bug 22511] Koha::Account::Line->void loses the original type of the credit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:48:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:48:29 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit In-Reply-To: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22511-70-u31SqynjnF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22564 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564 [Bug 22564] accounttype 'Rep' is still referred to but is never set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:49:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:49:10 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit In-Reply-To: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22511-70-BP3Kj2H2IF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|22521 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:49:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:49:10 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-yy9LLnJusW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22511 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 [Bug 22511] Koha::Account::Line->void loses the original type of the credit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:53:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:53:21 +0000 Subject: [Koha-bugs] [Bug 20769] Duplicate fine generated when lost item is returned In-Reply-To: <bug-20769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20769-70-GDOOMLSv7F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20769 Donna <bwsdonna at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bwsdonna at gmail.com Summary|Duplicate fine generated |Duplicate fine generated |when lost item is returned |when lost item is returned |with BlockReturnOfLostItems | |activated | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:54:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:54:18 +0000 Subject: [Koha-bugs] [Bug 22339] Elasticsearch - fixed field mappings should match MARC ranges In-Reply-To: <bug-22339-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22339-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22339-70-yFDijSBftQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22339 Frank Hansen <frank.hansen at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frank.hansen at ub.lu.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:57:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:57:53 +0000 Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI In-Reply-To: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20388-70-GsjkSvKrEO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78658|0 |1 is obsolete| | --- Comment #43 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 87196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87196&action=edit Bug 20388 - Add/delete search fields from search engine configuration page Test plan: - apply this patch, - check that SearchEngine system preference is set to Elasticsearch, - go to Admin > Search engine configuration, - on the search fields tab, fill a new line at the bottom of the table (name, label, type) - click on the "Add" button and save, - check that the new search field has been saved, - also test field deletions, - check that you can't delete already mapped fields. Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr> Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:58:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:58:15 +0000 Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI In-Reply-To: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20388-70-cqDamBeIjy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78659|0 |1 is obsolete| | --- Comment #44 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 87197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87197&action=edit Bug 20388 - Keep data consistency when adding/removing mapping Test plan: - create a new search field, save, - create a mapping using it (don't save), - check that you can't delete the search field. - delete all the mapping related to a search field (biblios and authorities), don't save, - check that you can delete this search field. Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:58:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:58:28 +0000 Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI In-Reply-To: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20388-70-i1YqqNKTZt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80709|0 |1 is obsolete| | --- Comment #45 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 87198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87198&action=edit Bug 20388: Prevent user from using a search field for a mapping after removing it Test plan: - add a search field, - save, - remove this search field - check that it has been removed from the mapping lists (bottom select). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:58:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:58:31 +0000 Subject: [Koha-bugs] [Bug 20769] Duplicate fine generated when lost item is returned In-Reply-To: <bug-20769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20769-70-wcJcC5Jzrq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20769 --- Comment #4 from Donna <bwsdonna at gmail.com> --- Another library has reported this also. Item is lost, returned, and charged max fine twice. Settings are Do Not BlockReturnofLostItems and Don't forgive WhenLostForgiveFine. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 13:58:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 12:58:42 +0000 Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI In-Reply-To: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20388-70-k87n7aCYS5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86912|0 |1 is obsolete| | --- Comment #46 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 87199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87199&action=edit Bug 20388: Use live handler for deleting elements -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 14:00:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 13:00:56 +0000 Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI In-Reply-To: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20388-70-bEYy7HY8Lt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 14:04:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 13:04:33 +0000 Subject: [Koha-bugs] [Bug 16357] Plack error logs are not time stamped In-Reply-To: <bug-16357-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16357-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16357-70-xQ3OkeM3WS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16357 Tom?s Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #36 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- (In reply to Liz Rea from comment #35) > So my test plan was > > * make sure the modules required were installed > Plack::Middleware::LogErrors > Plack::Middleware::LogWarn > * Copy the files in as before > sudo cp debian/templates/plack.psgi /etc/koha/kohadev/plack.psgi > sudo cp etc/log4perl.conf /etc/koha/sites/kohadev/log4perl.conf > sudo cp debian/templates/log4perl-site.conf.in > /etc/koha/log4perl-site.conf.in > * EDIT those files once in situ to reflect the paths in your install - for > kohadevbox (and any debian instance based test environment) it'll be > /var/log/koha/kohadev/plack-error.log > * Restart plack (kohadevbox is restart_all) > > kohadevbox has a way to copy in the debian files but I didn't use that - in > the misc4dev there is a "cp_debian_files.pl" which updates the debian files. > It might be good to try it. > > Liz That'd be cp_debian_files.pl plus gitify, or just the reset_all alias. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 14:17:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 13:17:31 +0000 Subject: [Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13895-70-jyArAMwlCf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 --- Comment #84 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 87200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87200&action=edit Bug 13895: (follow-up) Add Modern::Perl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 14:23:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 13:23:40 +0000 Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI In-Reply-To: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20388-70-bFwkLBXKFm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Bj?rn Nyl?n <bjorn.nylen at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87196|0 |1 is obsolete| | --- Comment #47 from Bj?rn Nyl?n <bjorn.nylen at ub.lu.se> --- Created attachment 87201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87201&action=edit Bug 20388 - Add/delete search fields from search engine configuration page Test plan: - apply this patch, - check that SearchEngine system preference is set to Elasticsearch, - go to Admin > Search engine configuration, - on the search fields tab, fill a new line at the bottom of the table (name, label, type) - click on the "Add" button and save, - check that the new search field has been saved, - also test field deletions, - check that you can't delete already mapped fields. Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr> Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Bj?rn Nyl?n <bjorn.nylen at ub.lu.se> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 14:23:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 13:23:45 +0000 Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI In-Reply-To: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20388-70-juc85TAUN6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Bj?rn Nyl?n <bjorn.nylen at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87197|0 |1 is obsolete| | --- Comment #48 from Bj?rn Nyl?n <bjorn.nylen at ub.lu.se> --- Created attachment 87202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87202&action=edit Bug 20388 - Keep data consistency when adding/removing mapping Test plan: - create a new search field, save, - create a mapping using it (don't save), - check that you can't delete the search field. - delete all the mapping related to a search field (biblios and authorities), don't save, - check that you can delete this search field. Signed-off-by: Nicolas Legrand <nicolas.legrand at bulac.fr> Signed-off-by: Bj?rn Nyl?n <bjorn.nylen at ub.lu.se> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 14:23:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 13:23:49 +0000 Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI In-Reply-To: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20388-70-NmLZVdf3uO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Bj?rn Nyl?n <bjorn.nylen at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87198|0 |1 is obsolete| | --- Comment #49 from Bj?rn Nyl?n <bjorn.nylen at ub.lu.se> --- Created attachment 87203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87203&action=edit Bug 20388: Prevent user from using a search field for a mapping after removing it Test plan: - add a search field, - save, - remove this search field - check that it has been removed from the mapping lists (bottom select). Signed-off-by: Bj?rn Nyl?n <bjorn.nylen at ub.lu.se> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 14:23:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 13:23:54 +0000 Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI In-Reply-To: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20388-70-fIKis1PLzT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Bj?rn Nyl?n <bjorn.nylen at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87199|0 |1 is obsolete| | --- Comment #50 from Bj?rn Nyl?n <bjorn.nylen at ub.lu.se> --- Created attachment 87204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87204&action=edit Bug 20388: Use live handler for deleting elements Signed-off-by: Bj?rn Nyl?n <bjorn.nylen at ub.lu.se> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 14:24:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 13:24:34 +0000 Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI In-Reply-To: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20388-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20388-70-svwfOd93jk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Bj?rn Nyl?n <bjorn.nylen at ub.lu.se> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 14:29:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 13:29:09 +0000 Subject: [Koha-bugs] [Bug 20588] Elasticsearch - Apply dataTable on search fields and mapping tables In-Reply-To: <bug-20588-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20588-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20588-70-9ok5J2oaIh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20588 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off --- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Katrin Fischer from comment #14) > BLOCKED by bug 20338 dependency being Needs Signoff. Should be BLOCKED by bug 20388 - which is signed off now, so unlocking. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 14:32:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 13:32:37 +0000 Subject: [Koha-bugs] [Bug 22605] Adding the option to modify search like in the OPAC (advanced search) In-Reply-To: <bug-22605-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22605-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22605-70-54zHva7d6L@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22605 --- Comment #1 from Alexandre <alexandre.breton at ccsr.qc.ca> --- By "on site" I mean staff interface. Thanks, Alexandre -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 14:40:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 13:40:06 +0000 Subject: [Koha-bugs] [Bug 22564] accounttype 'Rep' is still referred to but is never set In-Reply-To: <bug-22564-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22564-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22564-70-rWqL75vFOr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87194|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87205&action=edit Bug 22564: Remove references to 'Rep' accounttype Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 14:40:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 13:40:10 +0000 Subject: [Koha-bugs] [Bug 22564] accounttype 'Rep' is still referred to but is never set In-Reply-To: <bug-22564-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22564-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22564-70-JxXbJURLQm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87195|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87206&action=edit Bug 22564: Add database update 'just in case' With the introduction of the 'status' field it's a clear oportunity to convert any last remaining instances of 'Rep' to 'L' + 'REPLACED'. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 14:40:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 13:40:13 +0000 Subject: [Koha-bugs] [Bug 22564] accounttype 'Rep' is still referred to but is never set In-Reply-To: <bug-22564-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22564-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22564-70-B4EIgFIe77@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564 --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87207&action=edit Bug 22564: Add UI handling for 'Replaced' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 14:41:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 13:41:27 +0000 Subject: [Koha-bugs] [Bug 22564] accounttype 'Rep' is still referred to but is never set In-Reply-To: <bug-22564-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22564-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22564-70-so7MZC5L6L@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22564 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Back to signed off.. I've added the requested DB update (and also added some UI display just in case it actually picks any up).. Might be a useful 'status' in the future anyway. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 14:53:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 13:53:07 +0000 Subject: [Koha-bugs] [Bug 19380] Add transfer informations in ILS-DI GetRecords response In-Reply-To: <bug-19380-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19380-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19380-70-bMcjnuoChB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19380 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to Master --- Comment #14 from Nick Clemens <nick at bywatersolutions.com> --- Awesome work all! Pushed to master for 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 14:53:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 13:53:33 +0000 Subject: [Koha-bugs] [Bug 13895] Add routes for checkouts retrieval and renewal In-Reply-To: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13895-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13895-70-EABNc2xcaI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13895 --- Comment #85 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Nick Clemens from comment #84) > Created attachment 87200 [details] [review] > Bug 13895: (follow-up) Add Modern::Perl Followup pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 14:57:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 13:57:53 +0000 Subject: [Koha-bugs] [Bug 22339] Elasticsearch - fixed field mappings should match MARC ranges In-Reply-To: <bug-22339-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22339-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22339-70-MkbzvwVYaQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22339 --- Comment #4 from Frank Hansen <frank.hansen at ub.lu.se> --- Note that leader-fields should be spelled "LDR". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 15:04:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 14:04:29 +0000 Subject: [Koha-bugs] [Bug 22607] Default value in issues.renewals should be '0' not null In-Reply-To: <bug-22607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22607-70-dquKC4ofWl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22607 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87154|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87208&action=edit Bug 22607: Change default value in issues.renewals to '0'. This patch change renewals column of issues and old_issues tables. Now it is NOT NULL default 0. It does not make sense when number of renewals is undefined, it is always integer with value zero or more Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 15:04:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 14:04:38 +0000 Subject: [Koha-bugs] [Bug 22607] Default value in issues.renewals should be '0' not null In-Reply-To: <bug-22607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22607-70-thSJXIC4Hp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22607 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 15:04:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 14:04:46 +0000 Subject: [Koha-bugs] [Bug 22607] Default value in issues.renewals should be '0' not null In-Reply-To: <bug-22607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22607-70-chxBdO7e6F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22607 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 15:05:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 14:05:07 +0000 Subject: [Koha-bugs] [Bug 22607] Default value in issues.renewals should be '0' not null In-Reply-To: <bug-22607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22607-70-GOXIzPhit8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22607 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Going straight for PQA on this one.. it's tiny and makes complete sense. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 15:05:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 14:05:32 +0000 Subject: [Koha-bugs] [Bug 22607] Default value in issues.renewals should be '0' not null In-Reply-To: <bug-22607-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22607-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22607-70-dOzoZZ4W47@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22607 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Works well, no test failures, no regressions I can see and qa scripts all pass.. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 15:17:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 14:17:42 +0000 Subject: [Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove In-Reply-To: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21336-70-Zx8ab4QSn5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com Status|Signed Off |Failed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #95 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- QA Script is complaining.. though I'm not entirely sure what it means: FAIL Koha/Patron.pm FAIL valid Constant subroutine Koha::Patron::ADMINISTRATIVE_LOCKOUT redefined Any thoughts? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 15:28:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 14:28:32 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-VqyjVxaRpe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87097|0 |1 is obsolete| | --- Comment #36 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87209&action=edit Bug 22521: Increase varchar size for accounttype accountlines.accounttype is currently a short varchar(5) field for to store accounttype codes. Koha is moving towards more descriptive codes which require a larger capacity varchar(16). Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 15:28:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 14:28:35 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-Eu2zftQrem@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87098|0 |1 is obsolete| | --- Comment #37 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87210&action=edit Bug 22521: Update fines handling to use accountline.status Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 15:28:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 14:28:39 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-oPXpEN2PGv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87099|0 |1 is obsolete| | --- Comment #38 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87211&action=edit Bug 22521: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 15:28:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 14:28:43 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-zhAKACf6jI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87100|0 |1 is obsolete| | --- Comment #39 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87212&action=edit Bug 22521: Update existing accounttypes Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 15:28:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 14:28:46 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-PNGZrnsuFW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87101|0 |1 is obsolete| | --- Comment #40 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87213&action=edit Bug 22521: (QA follow-up) Corrections to tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 15:28:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 14:28:50 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-vD1eJlfQXS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #41 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87214&action=edit Bug 22521: (follow-up) Update 'Offsets' test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 15:33:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 14:33:12 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-BESEFO0pwP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87209|0 |1 is obsolete| | --- Comment #42 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87215&action=edit Bug 22521: Increase varchar size for accounttype accountlines.accounttype is currently a short varchar(5) field for to store accounttype codes. Koha is moving towards more descriptive codes which require a larger capacity varchar(16). Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 15:33:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 14:33:15 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-O4weW5G2PF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87210|0 |1 is obsolete| | --- Comment #43 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87216&action=edit Bug 22521: Update fines handling to use accountline.status Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 15:33:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 14:33:19 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-WJGjtSDfV8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87211|0 |1 is obsolete| | --- Comment #44 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87217&action=edit Bug 22521: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 15:33:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 14:33:23 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-k3zdJNaght@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87212|0 |1 is obsolete| | --- Comment #45 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87218&action=edit Bug 22521: Update existing accounttypes Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 15:33:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 14:33:26 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-jSm32uG1eF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87213|0 |1 is obsolete| | --- Comment #46 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87219&action=edit Bug 22521: (QA follow-up) Corrections to tests Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 15:33:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 14:33:32 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-wm3BPmswJr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87214|0 |1 is obsolete| | --- Comment #47 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87220&action=edit Bug 22521: (follow-up) Update 'Offsets' test Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 15:35:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 14:35:09 +0000 Subject: [Koha-bugs] [Bug 22519] We have two accounttypes for "forgiven", 'FOR' and 'FFOR' In-Reply-To: <bug-22519-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22519-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22519-70-G4e7LriYQS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22519 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|MOVED |DUPLICATE --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- *** This bug has been marked as a duplicate of bug 22521 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 15:35:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 14:35:09 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-z33eQFWOno@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 --- Comment #48 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- *** Bug 22519 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 15:35:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 14:35:18 +0000 Subject: [Koha-bugs] [Bug 22519] We have two accounttypes for "forgiven", 'FOR' and 'FFOR' In-Reply-To: <bug-22519-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22519-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22519-70-soCFj05FLI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22519 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 15:46:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 14:46:18 +0000 Subject: [Koha-bugs] [Bug 22608] New: Authentication with Google oAuth does not inherit Default Messaging Preferences from default user category Message-ID: <bug-22608-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22608 Bug ID: 22608 Summary: Authentication with Google oAuth does not inherit Default Messaging Preferences from default user category Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Authentication Assignee: koha-bugs at lists.koha-community.org Reporter: costalc at gmail.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org Target Milestone: --- GoogleOpenIDConnectDefaultCategory defines the category of a new user when it is created after oAuth authentication and GoogleOpenIDConnectAutoRegister is ON (Allow). This procedure should inherit category's Default Messaging Preferences but now it does not. It would be nice if it could. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 15:48:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 14:48:07 +0000 Subject: [Koha-bugs] [Bug 13829] Syntax highlighter on source code textareas In-Reply-To: <bug-13829-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13829-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13829-70-sgcuhKqokz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13829 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #4 from Owen Leonard <oleonard at myacpl.org> --- *** This bug has been marked as a duplicate of bug 21582 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 15:48:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 14:48:07 +0000 Subject: [Koha-bugs] [Bug 21582] Use CodeMirror for *UserJS & *UserCSS In-Reply-To: <bug-21582-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21582-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21582-70-e6rkZDAccZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21582 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pablo.bianchi at gmail.com --- Comment #9 from Owen Leonard <oleonard at myacpl.org> --- *** Bug 13829 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 15:51:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 14:51:35 +0000 Subject: [Koha-bugs] [Bug 14169] Item Search csv export In-Reply-To: <bug-14169-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14169-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14169-70-TAwdBfFFti@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14169 Peggy Thrasher <p.thrasher at dover.nh.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|CLOSED |REOPENED Resolution|INVALID |--- --- Comment #8 from Peggy Thrasher <p.thrasher at dover.nh.gov> --- The issue is the spaces before the double quotes. Original from Koha: "Starry night : Macomber, Debbie.", "2013", "Ballantine Books,", "", "34505003358304" produces these fields (each field in a subsequent column): Starry night : Macomber, Debbie. "2013" "Ballantine Books , ", 34505003358304" Removing spaces before double quotes results in: "Starry night : Macomber, Debbie.","2013","Ballantine Books,","","34505003358304" which produces these fields: Starry night : Macomber, Debbie. 2013 Ballantine Books, 34505003358304 It seems that there isn't a universal standard for CSV files, but https://en.wikipedia.org/wiki/Comma-separated_values says: According to RFC 4180, spaces outside quotes in a field are not allowed; however, the RFC also says that "Spaces are considered part of a field and should not be ignored." and "Implementors should 'be conservative in what you do, be liberal in what you accept from others' (RFC 793, section 2.10) when processing CSV files." 1997, "Ford" ,E350 Reports that are downloaded from Koha in CSV format do not have the extra space. Can this code use the same functions as reports? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 16:05:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 15:05:50 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit In-Reply-To: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22511-70-m1X0ftjchg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87088|0 |1 is obsolete| | --- Comment #22 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87221&action=edit Bug 22511: Update tests Updated tests to check for 'status' change and fixed 'accounttype' and moved from t/db_dependent/Accounts.t to the more appropriate t/db_dependent/Koha/Account/Lines.t Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 16:05:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 15:05:53 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit In-Reply-To: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22511-70-s0qaRmY7h0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87089|0 |1 is obsolete| | --- Comment #23 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87222&action=edit Bug 22511: Update void method to use status We added a 'status' field to 'accountlines' in bug 22512 to allow for more fined grained control over 'types' and 'states'. This patch updates the void method to utilise this new field so we may keep the original credit type for later auditing should it be required. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 16:05:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 15:05:56 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit In-Reply-To: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22511-70-XkRptTLw9d@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87090|0 |1 is obsolete| | --- Comment #24 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87223&action=edit Bug 22511: Update UI to use accountlines.status Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 16:06:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 15:06:00 +0000 Subject: [Koha-bugs] [Bug 22511] Koha::Account::Line->void loses the original type of the credit In-Reply-To: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22511-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22511-70-rCSs6jDOyw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22511 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87091|0 |1 is obsolete| | --- Comment #25 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87224&action=edit Bug 22511: (follow-up) Fix test plans Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 16:52:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 15:52:34 +0000 Subject: [Koha-bugs] [Bug 22609] New: Adding a visual mark on the selected authority Message-ID: <bug-22609-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22609 Bug ID: 22609 Summary: Adding a visual mark on the selected authority Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: alexandre.breton at ccsr.qc.ca QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Target Milestone: --- Once we did a search into authorities (from items or from Authorities module), the last selected authority has no visual mark to identify it in the authorities list. It will be usefull if when we are editing an authority, this authority appears in a different color (from others ones) until an another one was selected. The authorities list can be long and there is no indication where the last ?dited one was when we return on the authorities list. (Similar as bug #7501 for OPAC in 2012 ?) Thanks, Alexandre -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 16:53:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 15:53:03 +0000 Subject: [Koha-bugs] [Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values In-Reply-To: <bug-21159-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21159-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21159-70-RliNowLm3V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #24 from Liz Rea <wizzyrea at gmail.com> --- I'm a little confused - one of Alex's patches builds on bug 14576, but Hayley's seems to want us to test the 2 sysprefs? It looks like it might just be a commit message problem - i.e. we need alex's test plan, and this most recently rebased patch to be put together. Have a look? I'm happy to test this once I know all the bits are in the right order. :) Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 16:55:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 15:55:26 +0000 Subject: [Koha-bugs] [Bug 21159] Blank item shelving location (952$c) on issue and return based on syspref values In-Reply-To: <bug-21159-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21159-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21159-70-ix1X2CFn8S@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21159 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 16:59:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 15:59:14 +0000 Subject: [Koha-bugs] [Bug 22410] Software error while adding order on a MARC file record without an author In-Reply-To: <bug-22410-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22410-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22410-70-3UQyNWf5zJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22410 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion --- Comment #7 from Liz Rea <wizzyrea at gmail.com> --- Ok, Question. z3950NormalizeAuthor z3950AuthorAuthFields (modified) Copy|don't copy authors from the UNIMARC tags (separated by commas) [list of tags] to the correct author tags when importing a record using Z39.50. This feature is UNIMARC only? If your catalogue is MARC21, why would you have this preference set at all? Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 17:35:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 16:35:20 +0000 Subject: [Koha-bugs] [Bug 5620] Capture Mode of payment In-Reply-To: <bug-5620-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-5620-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5620-70-V4E0k8VcVz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|In Discussion |RESOLVED --- Comment #43 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- *** This bug has been marked as a duplicate of bug 18786 *** -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 17:35:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 16:35:20 +0000 Subject: [Koha-bugs] [Bug 18786] Add ability to create custom payment types In-Reply-To: <bug-18786-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18786-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18786-70-QTuZ2GM9ms@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kohapatch at gmail.com --- Comment #57 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- *** Bug 5620 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 17:35:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 16:35:24 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14825-70-n9JNFeKwDP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Bug 14825 depends on bug 5620, which changed state. Bug 5620 Summary: Capture Mode of payment https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620 What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 17:37:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 16:37:56 +0000 Subject: [Koha-bugs] [Bug 22610] New: SIP Payment Types should be moved out of accountype Message-ID: <bug-22610-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Bug ID: 22610 Summary: SIP Payment Types should be moved out of accountype Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Bug 18786 introduced a dedicated payment_type field to the database and an authorized value for it's population.. we should move the SIP payment type appendages from accounttype into this AV list. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 17:38:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 16:38:11 +0000 Subject: [Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype In-Reply-To: <bug-22610-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22610-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22610-70-zCncLl40Mz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17702 Depends on| |18786 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 [Bug 17702] Create configuration for account types https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786 [Bug 18786] Add ability to create custom payment types -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 17:38:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 16:38:11 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account types In-Reply-To: <bug-17702-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17702-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17702-70-WaYUDCztMq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22610 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 [Bug 22610] SIP Payment Types should be moved out of accountype -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 17:38:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 16:38:11 +0000 Subject: [Koha-bugs] [Bug 18786] Add ability to create custom payment types In-Reply-To: <bug-18786-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18786-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18786-70-1kfoSJgirw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18786 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22610 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 [Bug 22610] SIP Payment Types should be moved out of accountype -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 17:45:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 16:45:32 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account types In-Reply-To: <bug-17702-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17702-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17702-70-tZfG8ccK1O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|21683 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 [Bug 21683] Remove accountlines.accountno -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 17:45:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 16:45:32 +0000 Subject: [Koha-bugs] [Bug 21683] Remove accountlines.accountno In-Reply-To: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21683-70-DnBoEkJyd0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|17702 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 [Bug 17702] Create configuration for account types -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 18:07:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 17:07:19 +0000 Subject: [Koha-bugs] [Bug 15685] Allow creation of items (AcqCreateItem) to be customizable per-basket In-Reply-To: <bug-15685-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15685-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15685-70-USnEViZWSe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #87 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- There's a typo in this: Koha/EDI.pm - $basket->effective_create_item (Missing the 's'), which will cause Koha::Objects to throw an 'The method is untested' error whenever his codepath is followed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 18:08:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 17:08:34 +0000 Subject: [Koha-bugs] [Bug 21582] Use CodeMirror for *UserJS & *UserCSS In-Reply-To: <bug-21582-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21582-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21582-70-5InG0NgTap@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21582 --- Comment #10 from Pablo AB <pablo.bianchi at gmail.com> --- On bug 13829 (2015) I was suggesting just syntax highlight. I would prefer just syntax highlight now than an overkill full editor on 2023. The suggestion was not only on *UserJS & *UserCSS but all textareas contain source code: - Reports: SQL textareas - All sysprefs containing HTML, CSS and JS (AFAIK there is no JSON/YAML). Probably a full editor is too much and unnecessary (more risk of compatibility issues...). For major work (with beautify and linting) I would work on a proper text editor. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 18:09:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 17:09:20 +0000 Subject: [Koha-bugs] [Bug 22611] New: Typo introduced into Koha::EDI by bug 15685 Message-ID: <bug-22611-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22611 Bug ID: 22611 Summary: Typo introduced into Koha::EDI by bug 15685 Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Target Milestone: --- Koha/EDI.pm - $basket->effective_create_item (Missing the 's'), which will cause Koha::Objects to throw an 'The method is untested' error whenever his codepath is followed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 18:09:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 17:09:38 +0000 Subject: [Koha-bugs] [Bug 22611] Typo introduced into Koha::EDI by bug 15685 In-Reply-To: <bug-22611-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22611-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22611-70-MFRDSVgO9r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22611 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15685 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 [Bug 15685] Allow creation of items (AcqCreateItem) to be customizable per-basket -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 18:09:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 17:09:38 +0000 Subject: [Koha-bugs] [Bug 15685] Allow creation of items (AcqCreateItem) to be customizable per-basket In-Reply-To: <bug-15685-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15685-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15685-70-KjKfWuptt7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15685 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22611 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22611 [Bug 22611] Typo introduced into Koha::EDI by bug 15685 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 18:13:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 17:13:32 +0000 Subject: [Koha-bugs] [Bug 22611] Typo introduced into Koha::EDI by bug 15685 In-Reply-To: <bug-22611-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22611-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22611-70-UPURZYMAHJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22611 --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 87225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87225&action=edit Bug 22611: Correction for typo in Koha::EDI A typo in Koha::EDI leads to 'The method is not tested' errors to be thrown when the codepath is taken and can lead to subsequent data corruption. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 18:13:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 17:13:58 +0000 Subject: [Koha-bugs] [Bug 22611] Typo introduced into Koha::EDI by bug 15685 In-Reply-To: <bug-22611-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22611-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22611-70-Cx7wdppJ3G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22611 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 18:14:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 17:14:17 +0000 Subject: [Koha-bugs] [Bug 22611] Typo introduced into Koha::EDI by bug 15685 In-Reply-To: <bug-22611-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22611-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22611-70-cnNW0EWU4z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22611 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 18:14:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 17:14:23 +0000 Subject: [Koha-bugs] [Bug 22611] Typo introduced into Koha::EDI by bug 15685 In-Reply-To: <bug-22611-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22611-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22611-70-JS512wXKDZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22611 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 18:33:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 17:33:16 +0000 Subject: [Koha-bugs] [Bug 21582] Use CodeMirror for *UserJS & *UserCSS In-Reply-To: <bug-21582-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21582-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21582-70-w8uYwDjD3i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21582 --- Comment #11 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- (In reply to Pablo AB from comment #10) > On bug 13829 (2015) I was suggesting just syntax highlight. I would prefer > just syntax highlight now than an overkill full editor on 2023. > The suggestion was not only on *UserJS & *UserCSS but all textareas contain > source code: > > - Reports: SQL textareas > - All sysprefs containing HTML, CSS and JS (AFAIK there is no JSON/YAML). > > Probably a full editor is too much and unnecessary (more risk of > compatibility issues...). For major work (with beautify and linting) I would > work on a proper text editor. CodeMirror is already in the codebase. The only difficulty is hooking the initialization in the right templates... and adding the needed syntaxes support (we only have it for SQL). I asked for YAML support on bug 22584. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 18:41:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 17:41:09 +0000 Subject: [Koha-bugs] [Bug 21582] Use CodeMirror for *UserJS & *UserCSS In-Reply-To: <bug-21582-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21582-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21582-70-po6psmmIW7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21582 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 18:46:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 17:46:40 +0000 Subject: [Koha-bugs] [Bug 21582] Use CodeMirror for *UserJS & *UserCSS In-Reply-To: <bug-21582-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21582-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21582-70-HdnHVRoFPt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21582 --- Comment #12 from Magnus Enger <magnus at libriotech.no> --- We already have a wysiwyg editor for sysprefs containing HTML, enabled by UseWYSIWYGinSystemPreferences and added in bug 11584. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 19:01:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 18:01:47 +0000 Subject: [Koha-bugs] [Bug 21582] Use CodeMirror for *UserJS & *UserCSS In-Reply-To: <bug-21582-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21582-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21582-70-Q5BWrzgqIF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21582 --- Comment #13 from Owen Leonard <oleonard at myacpl.org> --- (In reply to Magnus Enger from comment #12) > We already have a wysiwyg editor for sysprefs containing HTML, enabled by > UseWYSIWYGinSystemPreferences My plan is to have CodeMirror handle all textareas which handle any kind of code. If UseWYSIWYGinSystemPreferences is enabled, HTML textareas will be WYSIWYG. Anyone have an opinion on whether ISBD should be handled as HTML? I think yes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 19:09:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 18:09:51 +0000 Subject: [Koha-bugs] [Bug 22604] "Error : the selected language is not currently available" for French In-Reply-To: <bug-22604-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22604-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22604-70-CfGR2aDBlP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22604 --- Comment #2 from houha.khadidja at gmail.com --- thank you its done now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 19:36:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 18:36:32 +0000 Subject: [Koha-bugs] [Bug 21582] Use CodeMirror for *UserJS & *UserCSS In-Reply-To: <bug-21582-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21582-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21582-70-wHIS411eNC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21582 --- Comment #14 from Pablo AB <pablo.bianchi at gmail.com> --- (In reply to Magnus Enger from comment #12) > We already have a wysiwyg editor for sysprefs containing HTML, enabled by > UseWYSIWYGinSystemPreferences Never think about a WYSIWYG editor. Just syntax highlight would be enough (following KISS principle). Considering all the CSS that the HTML code will have over I found this syspref useless, and therefore probably should be removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 19:38:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 18:38:40 +0000 Subject: [Koha-bugs] [Bug 22312] BlockReturnOfLostItems does not prevent lost items filling holds In-Reply-To: <bug-22312-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22312-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22312-70-QphUJonDSs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22312 --- Comment #1 from Phil Ringnalda <phil at chetcolibrary.org> --- Ah, http://git.koha-community.org/gitweb/?p=koha.git;a=blob;f=C4/Circulation.pm;hb=6666918dd661b0207366becefd1480257197a353#l2050 checks for $item->withdrawn, but not for $item->itemlost, before filling holds. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 19:40:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 18:40:01 +0000 Subject: [Koha-bugs] [Bug 21582] Use CodeMirror for *UserJS & *UserCSS In-Reply-To: <bug-21582-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21582-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21582-70-AvJazXvp4s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21582 --- Comment #15 from Owen Leonard <oleonard at myacpl.org> --- (In reply to Pablo AB from comment #14) > Never think about a WYSIWYG editor. I will, because this bug isn't about removing the UseWYSIWYGinSystemPreferences system preference. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 19:58:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 18:58:41 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20256-70-56WOWUK2SI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 19:58:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 18:58:44 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20256-70-lAtGp9Nv1J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 87226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87226&action=edit Bug 20256: Update database -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 19:58:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 18:58:54 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20256-70-Ljh8jsmZ7b@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 87227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87227&action=edit Bug 20256: Add new permission to editor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 19:58:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 18:58:57 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20256-70-dv4bv2dWff@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 87228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87228&action=edit Bug 20256: Refactor subs for rights to view patrons to make them generic for general use -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 19:59:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 18:59:00 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20256-70-FCUUEj4rps@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 87229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87229&action=edit Bug 20256: Add new methods for checking item editing permissions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 19:59:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 18:59:03 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20256-70-l2SvEpnGTJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 87230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87230&action=edit Bug 20256: Update Schema file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 19:59:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 18:59:06 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20256-70-WwhiqdbT0O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 87231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87231&action=edit Bug 20256: Update groups editor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 19:59:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 18:59:10 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20256-70-8bMnbyYyf2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 87232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87232&action=edit Bug 20256: Use new methods -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 19:59:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 18:59:13 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20256-70-t07JKEp4WK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 --- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 87233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87233&action=edit Bug 20256: Add unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 20:00:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 19:00:53 +0000 Subject: [Koha-bugs] [Bug 22575] Item type administration uses invalid error class for dialog In-Reply-To: <bug-22575-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22575-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22575-70-JvO63X6oQ6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22575 Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87018|0 |1 is obsolete| | --- Comment #2 from Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> --- Created attachment 87234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87234&action=edit Bug 22575: Item type administration uses invalid error class for dialog This patch modifies the item types administration script so that it passes a valid message type to the template, where the type is used as a CSS class. "Error" is a nonexistent dialog class. It should be "alert." To test, apply the patch and go to Administration -> Item types. - Try to delete an item type which is in use. The style of the error dialog should be correct. - Try to add an item type using a code which already exists. The error should look correct. Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 20:01:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 19:01:36 +0000 Subject: [Koha-bugs] [Bug 22575] Item type administration uses invalid error class for dialog In-Reply-To: <bug-22575-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22575-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22575-70-8k22uDZ7f7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22575 Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 20:38:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 19:38:48 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20256-70-lXxmAMqDJ5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> --- Needs a test plan... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 20:48:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 19:48:27 +0000 Subject: [Koha-bugs] [Bug 22575] Item type administration uses invalid error class for dialog In-Reply-To: <bug-22575-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22575-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22575-70-QuK6pS4pEC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22575 Bin <bin.wen at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87234|0 |1 is obsolete| | --- Comment #3 from Bin <bin.wen at inlibro.com> --- Created attachment 87235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87235&action=edit Bug 22575: Item type administration uses invalid error class for dialog This patch modifies the item types administration script so that it passes a valid message type to the template, where the type is used as a CSS class. "Error" is a nonexistent dialog class. It should be "alert." To test, apply the patch and go to Administration -> Item types. - Try to delete an item type which is in use. The style of the error dialog should be correct. - Try to add an item type using a code which already exists. The error should look correct. Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com> Signed-off-by: Bin Wen <bin.wen at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 20:57:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 19:57:14 +0000 Subject: [Koha-bugs] [Bug 22410] Software error while adding order on a MARC file record without an author In-Reply-To: <bug-22410-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22410-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22410-70-qozLibYLtZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22410 Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |INVALID --- Comment #8 from Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> --- Hi Liz, I read your last comment and it seems like the patch problem wasn't a problem in the end. By talking with a co-worker, I realize the software error occurred because z3950NormalizeAuthor was set to Copy while marcflavour was at MARC21. I didn't think a configuration problem could lead to this so I tried to make the error disappears with this configuration. I will close this ticket since the problem is irrelevant and I can change z3950NormalizeAuthor to fix my problem. Thank you for your feedback. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 21:11:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 20:11:14 +0000 Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations In-Reply-To: <bug-19817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19817-70-wXu1oAKdQi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 aplicacoes.dmsi at cm-portimao.pt <aplicacoes.dmsi at cm-portimao.pt> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |aplicacoes.dmsi at cm-portimao | |.pt Resolution|FIXED |--- Status|RESOLVED |REOPENED --- Comment #110 from aplicacoes.dmsi at cm-portimao.pt <aplicacoes.dmsi at cm-portimao.pt> --- Setting KohaManualBaseURL to https://koha-community.org/manual and using user interface language pt~PT, the help link is redirected (for example) to https://koha-community.org/manual/18.11/pt_BZ/html/systempreferences.html displaying an error page. I guess its related with a typo on line 22 in the file Manual.pm 22 my @available_languages = qw( en ar cs es fr it pt_BZ tz zh_TW ); Tested replacing the value pt_BZ by pt_BR and the link now works. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 21:11:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 20:11:16 +0000 Subject: [Koha-bugs] [Bug 21481] Translation tool still references to help templates In-Reply-To: <bug-21481-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21481-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21481-70-WAGaM1N0NI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21481 Bug 21481 depends on bug 19817, which changed state. Bug 19817 Summary: Merge local and online documentations https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 21:11:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 20:11:16 +0000 Subject: [Koha-bugs] [Bug 21483] Translate script displays an error about missing "help" directory In-Reply-To: <bug-21483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21483-70-nBCVQMkTk0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21483 Bug 21483 depends on bug 19817, which changed state. Bug 19817 Summary: Merge local and online documentations https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 What |Removed |Added ---------------------------------------------------------------------------- Status|RESOLVED |REOPENED Resolution|FIXED |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 21:21:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 20:21:03 +0000 Subject: [Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page In-Reply-To: <bug-12502-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12502-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12502-70-XEQeCUDa5p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80602|0 |1 is obsolete| | --- Comment #32 from Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> --- Created attachment 87236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87236&action=edit Bug 12502: Add vendor note, internal note, ordernumber and isbn to late orders page Test plan: 0) Make sure you have a late order a) Create a test vendor unless you have one b) Create a test basket unless you have one c) Close the basket to mark the order as late 1) Go to the late orders table Before patch : Orderno, ISBN, vendor notes, internal notes are absent After patch: fields are present 2) Edit the vendor note and/or the internal note 3) Press the save notes button 4) Refresh page and cache (CTRL+F5), if notes have been correctly saved, your modifications should be displayed. Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz> Signed-off-by: S?verine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 21:22:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 20:22:36 +0000 Subject: [Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page In-Reply-To: <bug-12502-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12502-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12502-70-OxUOGHyrlh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 --- Comment #33 from Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> --- Patch rebased. I am still waiting for advises before continuing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 21:55:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 20:55:07 +0000 Subject: [Koha-bugs] [Bug 10345] Copy number should be incremented when adding multiple items at once In-Reply-To: <bug-10345-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10345-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10345-70-EopRpldq9M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10345 Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87153|0 |1 is obsolete| | --- Comment #5 from Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> --- Created attachment 87237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87237&action=edit Bug 10345: Increment copy number when adding multiple copies. To test: 1. Add multiple copies of an item with data in the 'Copy number' field. Note that tha data will be identical for all items. 2. Apply patch. 3. Add multiple copies of an item with a positive integer (ie. only digits) in the 'Copy number' field. Note that the copy number is incremented for each item. 4. Add multiple copies of an item with some other type of data in the 'Copy number' field. Note that the copy number field remains unchanged for the added items. Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 21:55:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 20:55:21 +0000 Subject: [Koha-bugs] [Bug 10345] Copy number should be incremented when adding multiple items at once In-Reply-To: <bug-10345-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10345-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10345-70-kSjC42HI6v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10345 Pierre-Marc Thibault <pierre-marc.thibault at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |pierre-marc.thibault at inlibr | |o.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 23:04:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 22:04:08 +0000 Subject: [Koha-bugs] [Bug 22547] C4::Overdues - UpdateFine is barely tested In-Reply-To: <bug-22547-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22547-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22547-70-BLemeDc6ck@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22547 --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Hmm, I've been debating this a bit today. I think I was really aiming for a strict Unit Test here and as such wanted minimal reliance on thinks like the pay functions. I do agree, we really want to also have a level of integration tests but I'm not sure it's appropriate in this case. I'll ponder how/where to add such an integration tests too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Mar 29 23:12:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Mar 2019 22:12:43 +0000 Subject: [Koha-bugs] [Bug 14576] Allow automatic update of location on checkin In-Reply-To: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14576-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14576-70-G342JQlSck@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14576 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 30 12:13:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 30 Mar 2019 11:13:40 +0000 Subject: [Koha-bugs] [Bug 19817] Merge local and online documentations In-Reply-To: <bug-19817-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19817-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19817-70-prJUKgi64H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19817 --- Comment #111 from Humberto Chula <aplicacoes.dmsi at cm-portimao.pt> --- Created attachment 87238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87238&action=edit Fix Portuguese manual link -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 30 16:16:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 30 Mar 2019 15:16:08 +0000 Subject: [Koha-bugs] [Bug 22584] Add YAML support for Codemirror In-Reply-To: <bug-22584-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22584-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22584-70-fy2a92fB1p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22584 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- I have a patch ready to add support for YAML syntax, but should I also add a patch with an example implementation? If so, what is a good candidate? Are there system preferences which expect YAML? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 30 16:16:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 30 Mar 2019 15:16:24 +0000 Subject: [Koha-bugs] [Bug 21582] Use CodeMirror for *UserJS & *UserCSS In-Reply-To: <bug-21582-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21582-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21582-70-JBt6FI0ljk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21582 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22584 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 30 16:16:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 30 Mar 2019 15:16:24 +0000 Subject: [Koha-bugs] [Bug 22584] Add YAML support for Codemirror In-Reply-To: <bug-22584-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22584-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22584-70-CX1W9AcVr2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22584 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21582 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 30 16:41:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 30 Mar 2019 15:41:58 +0000 Subject: [Koha-bugs] [Bug 22584] Add YAML support for Codemirror In-Reply-To: <bug-22584-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22584-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22584-70-azg5uSPxaI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22584 --- Comment #2 from Tom?s Cohen Arazi <tomascohen at gmail.com> --- OpacHiddenItems is a candidate. The CSV2MARC plugin configuration too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 30 20:09:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 30 Mar 2019 19:09:17 +0000 Subject: [Koha-bugs] [Bug 12441] search.pl has incorrect reference to OPACdefaultSortField and OPACdefaultSortOrder In-Reply-To: <bug-12441-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12441-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12441-70-UJiP8YDOrA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12441 Michal Denar <black23 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86592|0 |1 is obsolete| | --- Comment #3 from Michal Denar <black23 at gmail.com> --- Created attachment 87239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87239&action=edit Bug 12441: Search.pl conditional checks and displays using same syspref Script search.pl checks OPACdefaultSortField and OPACdefaultSortOrder, but shows defaultSortField and defaultSortOrder when using Advanced Search in the staff client. Test plan: Apply the patch and then check that the Advanced Search uses defaultSortOrder and defaultSortField sysprefs instead of the OPAC sysprefs in the conditional. Check that sort behaviour in Advanced Search still functions as expected. (It should do - this doesn't change what displays, just improves consistency). Sponsored-by: Catalyst IT Signed-off-by: Michal Denar <black23 at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 30 20:09:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 30 Mar 2019 19:09:14 +0000 Subject: [Koha-bugs] [Bug 12441] search.pl has incorrect reference to OPACdefaultSortField and OPACdefaultSortOrder In-Reply-To: <bug-12441-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12441-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12441-70-ksOae3EibF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12441 Michal Denar <black23 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 30 21:09:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 30 Mar 2019 20:09:43 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11529-70-GLKu1056mC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 --- Comment #68 from Michal Denar <black23 at gmail.com> --- Hi Ere, I'm not sure about these results: Holds at Borrower detail: see "null" http://prntscr.com/n56znx Holds to Pull: http://prntscr.com/n56xmj Maybe something is wrong with my catalogue template or records. Michal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 30 21:43:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 30 Mar 2019 20:43:02 +0000 Subject: [Koha-bugs] [Bug 19670] search_marc_map.marc_field should have COLLATE= utf8mb4_bin In-Reply-To: <bug-19670-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19670-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19670-70-f0UcGtJ0lB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19670 Michal Denar <black23 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Mar 30 21:43:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 30 Mar 2019 20:43:05 +0000 Subject: [Koha-bugs] [Bug 19670] search_marc_map.marc_field should have COLLATE= utf8mb4_bin In-Reply-To: <bug-19670-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19670-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19670-70-ckghfruXpo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19670 Michal Denar <black23 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86599|0 |1 is obsolete| | --- Comment #4 from Michal Denar <black23 at gmail.com> --- Created attachment 87240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87240&action=edit Bug 19670: Change Collation of marc_field to allow mixed case mappings Test plan: 1. Apply patch and update database 2. Verify that you can add a search field mapping for both 100a and 100A. 3. Verify that the above also works with a newly-created database. Signed-off-by: Michal Denar <black23 at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 31 03:41:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Mar 2019 01:41:01 +0000 Subject: [Koha-bugs] [Bug 20952] Automatic debian/control updates (oldoldstable/17.11.x) In-Reply-To: <bug-20952-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20952-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20952-70-E4WnyxdQEZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20952 --- Comment #13 from Nightly Build Bot <nightly at abunchofthings.net> --- Created attachment 87241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87241&action=edit Bug 20952- Automatic debian/control updates (oldoldstable/17.11.x) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 31 12:24:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Mar 2019 10:24:43 +0000 Subject: [Koha-bugs] [Bug 22537] Suspend all hold button appears even if the hold can no longer be suspended In-Reply-To: <bug-22537-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22537-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22537-70-mRsbNEDqsg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22537 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Suspend all hold button |Suspend all hold button |appears even if the hold |appears even if the hold |can no longer be suspended. |can no longer be suspended CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 31 13:17:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Mar 2019 11:17:45 +0000 Subject: [Koha-bugs] [Bug 20952] Automatic debian/control updates (oldoldstable/17.11.x) In-Reply-To: <bug-20952-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20952-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20952-70-pE56p06QBX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20952 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 31 16:11:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Mar 2019 14:11:11 +0000 Subject: [Koha-bugs] [Bug 20196] [Omnibus] Prepare Koha to ElasticSearch6 - ES6 In-Reply-To: <bug-20196-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20196-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20196-70-nQ85M2nKo6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20196 Michal Denar <black23 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 31 19:17:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Mar 2019 17:17:04 +0000 Subject: [Koha-bugs] [Bug 22537] Suspend all hold button appears even if the hold can no longer be suspended In-Reply-To: <bug-22537-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22537-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22537-70-arjdswtkig@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22537 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Patch does no longer apply cleanly, can you please rebase? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 22537: Suspend all hold button appears even if the hold can no longer be suspended. Using index info to reconstruct a base tree... M koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt CONFLICT (content): Merge conflict in koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-user.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 31 19:20:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Mar 2019 17:20:35 +0000 Subject: [Koha-bugs] [Bug 22432] Star ratings plugin replacement missing from a couple pages In-Reply-To: <bug-22432-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22432-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22432-70-SctjT2buPh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22432 --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I don't think anyone else has credentials to both Overdrive and RecordedBooks (I don't). Patch looks sensible and passes tests. I am inclined to pass QA trusting Nick and Owen. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 31 19:21:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Mar 2019 17:21:37 +0000 Subject: [Koha-bugs] [Bug 22432] Star ratings plugin replacement missing from a couple pages In-Reply-To: <bug-22432-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22432-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22432-70-RcJy72JsUa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22432 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 31 19:21:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Mar 2019 17:21:40 +0000 Subject: [Koha-bugs] [Bug 22432] Star ratings plugin replacement missing from a couple pages In-Reply-To: <bug-22432-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22432-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22432-70-GeyLz67hPm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22432 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87062|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 87242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87242&action=edit Bug 22432: Star ratings plugin replacement missing from a couple pages This patch modifies two templates to conform to the change to the start ratings plugin: Overdrive search results and RecordedBooks search results. On the Overdrive page, the star ratings are now correctly displayed using the new plugin. On the RecordedBooks page, star ratings code has been removed because it is unused. RecordedBooks doesn't provide ratings information in their API. To test you need credentials for both Overdrive and RecordedBooks. Apply the patch and enable both services. - In the OPAC, perform a search that will return results from Overdrive and RecordedBooks. - Open the search results for each of those services. - On the Overdrive search results page, star ratings should appear correctly (in read-only mode). - On the RecordedBooks page everything should look the same. Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 31 19:45:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Mar 2019 17:45:51 +0000 Subject: [Koha-bugs] [Bug 22575] Item type administration uses invalid error class for dialog In-Reply-To: <bug-22575-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22575-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22575-70-2IXObqIfHi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22575 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87235|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 87243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87243&action=edit Bug 22575: Item type administration uses invalid error class for dialog This patch modifies the item types administration script so that it passes a valid message type to the template, where the type is used as a CSS class. "Error" is a nonexistent dialog class. It should be "alert." To test, apply the patch and go to Administration -> Item types. - Try to delete an item type which is in use. The style of the error dialog should be correct. - Try to add an item type using a code which already exists. The error should look correct. Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com> Signed-off-by: Bin Wen <bin.wen at inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 31 19:45:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Mar 2019 17:45:48 +0000 Subject: [Koha-bugs] [Bug 22575] Item type administration uses invalid error class for dialog In-Reply-To: <bug-22575-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22575-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22575-70-ici3NHltKl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22575 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 31 19:53:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Mar 2019 17:53:42 +0000 Subject: [Koha-bugs] [Bug 22568] Replace RSS icon in the OPAC with Font Awesome In-Reply-To: <bug-22568-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22568-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22568-70-FzYXhrIZif@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22568 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 31 19:53:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Mar 2019 17:53:45 +0000 Subject: [Koha-bugs] [Bug 22568] Replace RSS icon in the OPAC with Font Awesome In-Reply-To: <bug-22568-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22568-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22568-70-25OivIEJvP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22568 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86977|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 87244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87244&action=edit Bug 22568: Replace RSS icon in the OPAC with Font Awesome This patch removes the RSS icon image (feed-icon-16x16.png) from the OPAC and replaces it with Font Awesome icons styled to match. To test, apply the patch and regenerate the OPAC CSS. View the following pages, confirming that the RSS icon looks correct: - OPAC home page (RSS news icon) - Search results page (Subscribe to search) - Recent comments - Search history - Lists -> View list Signed-off-by: Liz Rea <wizzyrea at gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 31 22:03:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Mar 2019 20:03:54 +0000 Subject: [Koha-bugs] [Bug 12441] search.pl has incorrect reference to OPACdefaultSortField and OPACdefaultSortOrder In-Reply-To: <bug-12441-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12441-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12441-70-BTvxLvW62v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12441 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87239|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 87245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87245&action=edit Bug 12441: Search.pl conditional checks and displays using same syspref Script search.pl checks OPACdefaultSortField and OPACdefaultSortOrder, but shows defaultSortField and defaultSortOrder when using Advanced Search in the staff client. Test plan: Apply the patch and then check that the Advanced Search uses defaultSortOrder and defaultSortField sysprefs instead of the OPAC sysprefs in the conditional. Check that sort behaviour in Advanced Search still functions as expected. (It should do - this doesn't change what displays, just improves consistency). Sponsored-by: Catalyst IT Signed-off-by: Michal Denar <black23 at gmail.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 31 22:04:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Mar 2019 20:04:14 +0000 Subject: [Koha-bugs] [Bug 12441] search.pl has incorrect reference to OPACdefaultSortField and OPACdefaultSortOrder In-Reply-To: <bug-12441-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12441-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12441-70-coSAV1tngk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12441 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Good catch! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 31 22:03:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Mar 2019 20:03:51 +0000 Subject: [Koha-bugs] [Bug 12441] search.pl has incorrect reference to OPACdefaultSortField and OPACdefaultSortOrder In-Reply-To: <bug-12441-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12441-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12441-70-2pmYmSa3A9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12441 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 31 22:18:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Mar 2019 20:18:34 +0000 Subject: [Koha-bugs] [Bug 21003] Don't show warning when editing a reserve item In-Reply-To: <bug-21003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21003-70-xpuWsSyAan@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21003 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 31 22:18:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Mar 2019 20:18:37 +0000 Subject: [Koha-bugs] [Bug 21003] Don't show warning when editing a reserve item In-Reply-To: <bug-21003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21003-70-cOxkcJr6sh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21003 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86219|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 87246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87246&action=edit Bug 21003: Removed warning and changed wording on add_items-step2.tt When editing an item in a Course Reserve, the page displayed is the same that is displayed when adding an item to a Course Reserve. This patch removes the warning 'This course already has this item on reserve' when the item is being edited, as well as changes the title, breadcrumbs, and header of the div. This patch also Changes the header of the div to say 'Edit 'book_name' in 'course_name'' instead of 'Add 'book_name' to 'course_name'' when adding items to a course reserve if the item is already present. To test: 1) Create a new course in Course Reserves (you will need Course Reserves enabled in syspref) 2) Add an item by clicking the Add reserves button 3) Click the edit button on the right hand side of the item listing under the Reserves heading 4) Observe that the warning 'The course already has this item on reserve' appears, and that the title, breadcrumbs and header of the div all say Add/Reserve 5) Apply the patch 6) Repeat step 3 and observe that the title, breadcrumbs and header of the div now say Edit 7) Also verify that when adding a reserve with a barcode that does not yet exist in the course reserves that the warning 'The course already...' is not displayed and that the header of the div says Add 8) Finally verify that when adding a reserve with a barcode that DOES exist in the course reserves that the warning 'The course already...' IS displayed and the header of the div says Edit 9) Sign off! Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 31 22:18:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Mar 2019 20:18:41 +0000 Subject: [Koha-bugs] [Bug 21003] Don't show warning when editing a reserve item In-Reply-To: <bug-21003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21003-70-oFVtrc1L02@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21003 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86930|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 87247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87247&action=edit Bug 21003: Made Edit keywords more consistent in add_items-step2.tt When adding a course reserve with a barcode that already exists, the title, breadcrumbs, and legend of the form all specify that the user is editing, and not adding, the book. Test plan: Same as comment 1 Signed-off-by: Devinim <kohadevinim at devinim.com.tr> Signed-off-by: Bin Wen <bin.wen at inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Mar 31 22:23:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 31 Mar 2019 20:23:06 +0000 Subject: [Koha-bugs] [Bug 22538] Add a noticeable alert about waiting holds In-Reply-To: <bug-22538-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22538-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22538-70-wDDCMEfghU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22538 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Patch doesn't apply CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Tomas, patch doesn't apply, can you please rebase? Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 22538: Add a noticeable alert about waiting holds error: sha1 information is lacking or useless (koha-tmpl/opac-tmpl/bootstrap/en/includes/holds-table.inc). error: could not build fake ancestor Patch failed at 0001 Bug 22538: Add a noticeable alert about waiting holds The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-22538-Add-a-noticeable-alert-about-waiting-hol-FJ8X3i.patch -- You are receiving this mail because: You are watching all bug changes.