[Koha-bugs] [Bug 20447] Add support for MARC holdings records

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

--- Comment #101 from Ere Maijala <ere.maijala at helsinki.fi> ---
(In reply to Joonas Kylmälä from comment #98)
> Comment on attachment 85994 [details] [review]
> Bug 20447: MARC Holdings support
> 
> Review of attachment 85994 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: C4/Biblio.pm
> @@ +1563,5 @@
> >          }
> >  
> > +        #---- holdings
> > +        if ( $tagslib->{$tag}->{$subfield}->{'authorised_value'} eq "holdings" ) {
> > +            my $holding = Koha::Holdings->find( $value );
> 
> does the find need "deleted_on => undef" as a parameter in order to not care
> about deleted holdings?

It allows one to fetch a holdings record by ID even if it's deleted. I believe
it makes sense since otherwise it would be possible, at least in theory, for an
item to point to a deleted holdings record without it showing.

-- 
You are receiving this mail because:
You are watching all bug changes.