[Koha-bugs] [Bug 20447] Add support for MARC holdings records

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20447

--- Comment #102 from Ere Maijala <ere.maijala at helsinki.fi> ---
(In reply to Joonas Kylmälä from comment #99)
> Comment on attachment 85994 [details] [review]
> Bug 20447: MARC Holdings support
> 
> Review of attachment 85994 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: C4/Items.pm
> @@ +1705,5 @@
> > +                        holdingbranch    => $oldHolding->{'holdingbranch'},
> > +                        location         => $oldHolding->{'location'},
> > +                        callnumber       => $oldHolding->{'callnumber'},
> > +                        suppress         => $oldHolding->{'suppress'},
> > +                        deleted_on       => undef
> 
> if deleted_on is not needed / is undef by default this can be removed

It tries to find an existing holdings record for the item to be attached to.
Deleted holdings do not qualify, so the filter is needed. However, I just
realized that the search terms can match multiple records which would cause
find() to fail. I need to revise that.

-- 
You are receiving this mail because:
You are watching all bug changes.