[Koha-bugs] [Bug 21683] Remove accountlines.accountno

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683

--- Comment #22 from Tomás Cohen Arazi <tomascohen at gmail.com> ---
(In reply to Tomás Cohen Arazi from comment #21)
> Shouldn't we use accountline_id for the proccode parameter in UpdateStats?
> I'm getting failures in all tests that set statistics.
> 
> To reproduce:
>   $ dbic
>   $ updatedatabase
>   $ kshell
>  k$ prove t/db_dependent/Accounts.t \
>           t/db_dependent/Circ* \
>           t/db_dependent/Koha/Account*
> => FAIL: Lots of errors like this:
> DBD::mysql::st execute failed: Column count doesn't match value count at row
> 1 [for Statement "INSERT INTO statistics
>         (datetime,
>          branch,          type,        value,
>          other,           itemnumber,  itemtype, location,
>          borrowernumber,  proccode,    ccode)
>          VALUES (now(),?,?,?,?,?,?,?,?,?)" with ParamValues: 0='VBVsbXZxI',
> 1='payment', 2=150, 3='', 4=undef, 5='', 6=undef, 7='205', 8=''] at
> /home/vagrant/kohaclone/C4/Stats.pm line 136.

Reverting the changes in t/db_dependent/Stats.t and C4/Stats.pm fixes the
failures. Still not sure what's the best solution.

-- 
You are receiving this mail because:
You are watching all bug changes.