[Koha-bugs] [Bug 18589] Show ILLs as part of patron profile

Mon Mar 11 12:58:35 CET 2019

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589

Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #84796|0                           |1
        is obsolete|                            |

--- Comment #14 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> ---
Created attachment 86432
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86432&action=edit
Bug 18589: Show ILLs as part of patron profile

This patch moves the display of a patron's ILL requests to be inline in
the Patron Profile page, as per all other patron information.

It includes a substantial refactor of
koha-tmpl/intranet-tmpl/prog/en/modules/ill/ill-requests.tt in that it
moves the display of the illlist table (which is populated by an API
request) into it's own separate include file. It also moves the
datatable related Javascript for this table into it's own JS file. Doing
this allows us to reuse both in both the new members/ill-requests.tt
template and the pre-existing ill/ill-requests.tt template.

To test:
1) Ensure ILL is enabled and your user has sufficient permissions
2) Ensure your user has some ILL requests
3) Navigate to the user's patron profile page
4) Click on the "Interlibrary loans" tab
5) Observe that the requests table is displayed inline
6) Observe that only your user's requests are displayed

Signed-off-by: Niamh.Walker-Headon at it-tallaght.ie

Bug 18589: (follow-up) Fix QA error

Bug 18589: (follow-up) Fix QA failure

This patch removes the id and class attributes on the body tag in:

koha-tmpl/intranet-tmpl/prog/en/modules/members/ill-requests.tt

To test:
- Apply the patch
- Run the QA tools
- Note that the "Failed test '<body> tag with id and class attributes'"
no longer is reported

Bug 18589: (follow-up) Fix QA errors

This patch fixes the "missing_filter" QA errors

Bug 18589: (follow-up) Fix rebase errors

Minor rebase errors

Bug 18589: (follow-up) More merge errors

-- 
You are receiving this mail because:
You are watching all bug changes.