[Koha-bugs] [Bug 22333] Replace duplicated code in CanBookBeRenewed with GetSoonestRenewDate

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22333

--- Comment #6 from David Cook <dcook at prosentient.com.au> ---
(In reply to Hayley Mapley from comment #5)
> Test fails with the following error:
> 
> t/db_dependent/Circulation.t .. 122/126     # No tests run!
> t/db_dependent/Circulation.t .. 123/126 
> #   Failed test 'No tests run for subtest "AddRenewal and AddIssuingCharge
> tests"'
> #   at t/db_dependent/Circulation.t line 2948.
> Can't call method "lengthunit" on an undefined value at
> /home/vagrant/kohaclone/Koha/Charges/Fees.pm line 101.
> # Looks like your test exited with 11 just after 123.
> t/db_dependent/Circulation.t .. Dubious, test returned 11 (wstat 2816, 0xb00)
> Failed 4/126 subtests 
> 
> Test Summary Report
> -------------------
> t/db_dependent/Circulation.t (Wstat: 2816 Tests: 123 Failed: 1)
>   Failed test:  123
>   Non-zero exit status: 11
>   Parse errors: Bad plan.  You planned 126 tests but ran 123.
> Files=1, Tests=123, 38 wallclock secs ( 0.07 usr  0.01 sys + 18.59 cusr 
> 3.22 csys = 21.89 CPU)
> Result: FAIL

Thanks, Hayley!

I'm guessing this highlights a problem with that test rather than this patch
though. Hmm. What are your thoughts, Tomas?

-- 
You are receiving this mail because:
You are watching all bug changes.