[Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591

Martin Renvoize <martin.renvoize at ptfs-europe.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Needs Signoff               |Signed Off

--- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
I really like this solution! It tidies up the code significantly and corrects
the logic considerably!

Signing off as it all works in testing as described...

Some QA comments for the next in line however.

* Can we/Should we remove the 'lastincrement' field here as I believe this was
the only use case for it?
* The logic here puts 'dropboxmode/dropboxdate' in precidence to any specified
return date.. I think we perhaps need a bit more in this regard, but perhaps
that can be done within bug 13044 as there's a fair bit of contextual
conversation over there around this issue.

-- 
You are receiving this mail because:
You are watching all bug changes.