[Koha-bugs] [Bug 22489] Onboarding tool fails due to inserting maxissueqty into IssuingRule

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22489

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #86577|0                           |1
        is obsolete|                            |
  Attachment #86578|0                           |1
        is obsolete|                            |

--- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Created attachment 86632
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86632&action=edit
Bug 22489: Update onboarding tool for bug 18925

When going through the onboarding process, the tool fails on submit of step 5,
due to changes made in the database structure and rule definitions by bug
18925.

This patch fixes this, adding code that creates a circulation rule where an
issuing rule is also created in onboarding.pl. It removes maxissueqty from
being sent with params to make an issuing rule, and adds it instead to the
params to make a circulation rule, to reflect the changes that have been made
in the database.

Test plan:
1) Drop and recreate your database
2) Reload the staff client and follow the installer and onboarding
process
3) Confirm that the process finishes without errors

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Liz Rea <wizzyrea at gmail.com>

Bug 22489: (follow-up) Correctly set success messages

The original patch was duplicating the success message upon successful
circ rule insertion. This corrects that.

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Liz Rea <wizzyrea at gmail.com>

Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org>
Patches squashed for readability

-- 
You are receiving this mail because:
You are watching all bug changes.