[Koha-bugs] [Bug 18736] Problems in order calculations (rounding errors)
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Fri Mar 15 11:05:44 CET 2019
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18736
Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #83978|0 |1
is obsolete| |
--- Comment #171 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Created attachment 86651
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86651&action=edit
Bug 18736: (follow-up) Fix missing rounding and bad formatting
This patch:
Adds a missing use
Uses 'Koha::Number::Price->round()' instead of 'format()' to ensure numeric
returns
Ensures too big numbers don't crash round()
Uses syspref in 'GetBudgetHierarchy'
To test:
Follow previous test plan
Check values on admin/aqbudgets.pl are affected by syspref
Ensure values throughout acquisitions are correctly calculated/displayed
(even when greater than 1,000)
Signed-off-by: Julian Maurice <julian.maurice at biblibre.com>
Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl>
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list