[Koha-bugs] [Bug 13763] Renew feature does not check for the BarcodeInputFilter option

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13763

Hayley Mapley <hayleymapley at catalyst.net.nz> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|Passed QA                   |Signed Off

--- Comment #10 from Hayley Mapley <hayleymapley at catalyst.net.nz> ---
(In reply to Bin from comment #9)
> Created attachment 86745 [details] [review]
> Bug 13763: Added check for filter syspref in renew.pl
> 
> In Circulation->Renew, the renew feature does not check the system
> preference itemBarcodeFilter to see whether the barcode needs to be
> converted. This patch fixes this, adding a check for the system pref and
> applying it accordingly to convert the barcode if it is needed.
> 
> Test plan:
> 1) In Circulation->Renew, enter a barcode that you know exists in the
> catalogue but add extra spaces, breaking up the barcode. Note that this
> fails with a warning that says 'No item matches this barcode'
> 
> 2) In system Preferences, set the itemBarcodeInputFilter pref to Remove
> spaces and repeat step1. Note that the result is the same as in step 1
> 
> 3) Apply the patch
> 
> 4) Repeat step 1, and note that the filter removes the spaces and the
> item is renewed (or gives an error that indicates it recognises the
> barcode)
> 
> Sponsored-by: Catalyst IT
> Signed-off-by: Bin Wen <bin.wen at inlibro.com>

Thanks again for testing! I'll change the status to Signed Off so it'll get
picked up by the QA team :)

-- 
You are receiving this mail because:
You are watching all bug changes.