[Koha-bugs] [Bug 22547] C4::Overdues - UpdateFine is untested

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed Mar 20 13:19:14 CET 2019


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22547

--- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Question here.. should I write the tests to test all the current behaviour or
write them to test what I believe the behaviour should be..

Example questions raised:
1) Should we really be counting 'Sundry'/'Manual Invoice' in the total fines
amount outstanding?
2) If the above is correct, should we be counting other fee's in the total
fines amount outstanding calculation?
3) We don't explicitly order the accountlines lookup, as such we can't be sure
we're actually updating the correct fine for the renewals case... Should I test
for this.

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list