[Koha-bugs] [Bug 17385] Add custom export formats for bibliographic records

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Fri Mar 22 10:11:27 CET 2019


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17385

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Passed QA

--- Comment #38 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA Comment:
Thanks for your perseverance, guys. This took quite some time.
Since the Custom option is not checked by default, I do not see a problem
pushing this in its current form. 

[1] We need to return an empty list if OpacExportOptions does not contain
Custom.  No need to scan the directory for custom files, if we are not using
them at all.
=> See follow-up.
[2] We should add caching in CustomXSLTExportList.
=> See second follow-up.
[3] The example xslt perhaps should be renamed (as mentioned before earlier).
If you would only check for the .xsl extension, we could add a README and
rename the extension of the simple export sample. Since it is pref controlled
now, this may be done later imo. No blocker for me.
[4] t/XSLT.t depends on a pref, so on the database. Should imo be moved to
dependent. Removing Test::DBIx::Class :) No blocker, maybe later ?
[5] I personally do not like using LibXML to parse the filename and format from
the xsl file. And was just thinking about adding a small json or yaml file to
do the same? No blocker, maybe later..

Passed QA

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list