[Koha-bugs] [Bug 22541] Invoice adjustments should show invoice number and include link on ordered.pl and spent.pl

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22541

--- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Comment on attachment 86871
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86871
Bug 22541: Use invoicenumber and link to invoice on spent and ordered pages

Review of attachment 86871:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=22541&attachment=86871)
-----------------------------------------------------------------

Hi Nick,

can you take a look at the code comments please? Thx!

::: acqui/ordered.pl
@@ +77,4 @@
>      (quantity > quantityreceived OR quantityreceived IS NULL)
>      GROUP BY aqorders.biblionumber, aqorders.basketno, aqorders.ordernumber,
>               tleft,
> +             ecost_tax_included, budgetdate, entrydate,

While this change appears to make sense, it seems totally unrelated to the
patch. Can you please explain?

Related to:
http://git.koha-community.org/gitweb/?p=koha.git;a=commit;h=9d595e36a7844f99fa5d74aad418717d12eeae37
?

::: acqui/spent.pl
@@ +93,4 @@
>               aqorders.invoiceid,
>               aqinvoices.invoicenumber,
>               quantityreceived,
> +             unitprice_tax_included,

Same here as for ordered.pl

::: circ/ysearch.pl
@@ +40,4 @@
>  print $input->header( -type => 'text/plain', -charset => 'UTF-8' );
>  
>  my ( $auth_status, $sessionID ) = check_cookie_auth( $input->cookie('CGISESSID'), { catalogue => '1' } );
> +warn "$auth_status is what?";

Quite sure this should not be here. :)

-- 
You are receiving this mail because:
You are watching all bug changes.