[Koha-bugs] [Bug 19014] Patrons should not get a on_reserve notification if the due date is far into the future

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014

--- Comment #24 from David Cook <dcook at prosentient.com.au> ---
Created attachment 86960
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=86960&action=edit
[Alternate patch] Bug 19014: Do not try to autorenew an item too early

There are a number of conditions which can cause autorenewals
to send out confusing notifications to patrons far before the
due date of an item. These may be exceeding the max number of
renewals or checkouts, a hold on the item, etc.

If an item has a hold, we don't want to tell the patron they
can't autorenew the item until the earliest renewal date or the
due date of the item.

Test plan:

1) Check out an item with a due date 2 business days in the future
2) Place a hold on this item
3) Execute the cronjob
- Without the patch, an email notification is generated for the patron
- With the patch, no email notification is generated
4) Set norenewalbefore in the Circulation and Fines rules to 2
5) Execute the cronjob
- Without the patch, an email notification is generated for the person
- With the patch, an email notification is generated for the person
6) Set norenewalbefore in the Circulation and Fines rules to 3
7) Execute the cronjob
- Without the patch, an email notification is generated for the patron
- With the patch, no email notification is generated
8) Clear norenewalbefore in the Circulation and Fines rules
9) Change item due date (in database) to a date/time prior to now
10) Execute the cronjob
- Without the patch, an email notification is generated for the person
- With the patch, an email notification is generated for the person

-- 
You are receiving this mail because:
You are watching all bug changes.