[Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521

--- Comment #35 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
(In reply to Josef Moravec from comment #21)
> Comment on attachment 86919 [details] [review]
> Bug 22521: Update fines handling to use accountline.status
> 
> Review of attachment 86919 [details] [review]:
> -----------------------------------------------------------------
> 
> ::: Koha/Account.pm
> @@ +471,4 @@
> >                      itemnumber        => $item_id,
> >                      issue_id          => $issue_id,
> >                      branchcode        => $library_id,
> > +                    ( $type eq 'overdue' ? ( lastincrement => $amount ) : ()),
> 
> Does it make sense to you to make this dependent also on 22516, which
> removes lastincrement column?

 Thanks for the quick testing and signoff.  Can't believe I let those tests
slip through in that state.

As for the dependency on bug 22516.. Isort of agree but didn't want to make the
tree look too complicated.. hopefully it'll be pushed imminently and it should
be a trivial rebase.

-- 
You are receiving this mail because:
You are watching all bug changes.