[Koha-bugs] [Bug 22593] Cronjobs/Scripts dealing with accountlines need updating for bug 22008

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Mar 28 09:12:03 CET 2019


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22593

Josef Moravec <josef.moravec at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #87075|0                           |1
        is obsolete|                            |

--- Comment #4 from Josef Moravec <josef.moravec at gmail.com> ---
Created attachment 87130
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87130&action=edit
Bug 22593: Fix bad ternaries after bug 22008

A series of ternaries were introduced when we moved to add_debit which
defaulted to 'user 0' should a userenv not be set.  This was incorrect
as userenv may well not be set (during cronscript runs for example) and
the new constraint would not allow such a default. We switch to 'undef'
here to satisfy the constraint.

Test plan
1) Ensure you have data in your system that would be caught by the
longoverdues cronjob.
2) Ensure you're sysprefs are setup to charge for lost items
3) Run the script and varify it runs to completion without errors

Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com>

Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com>

Signed-off-by: Josef Moravec <josef.moravec at gmail.com>

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list