[Koha-bugs] [Bug 22588] Simplify getting account information in opac and self checkout module

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22588

--- Comment #5 from Josef Moravec <josef.moravec at gmail.com> ---
(In reply to Tomás Cohen Arazi from comment #4)
> I like the idea in general but:
> - shouldn't we be using line.{is_debit|is_credit} instead of comparing
> line.amount > 0? Keep in mind that we found pathological cases in the wild
> where the amountoutstanding got flipped. We better rely on the methods we
> have.

Definitely yes, I don't know how could I forget these methods... I'll add a
follow-up for this

> - The fact that we aren't using $account->outstanding_debits and
> $account->outstanding_credits but instead keep searching for all
> accountlines makes some noise to me. I guess it is not straightforward as we
> want to display all outstanding debits and credits ordered by date. Just
> something to think about a bit. Maybe we should add amountountstanding => {
> '!=' => 0  } to the search line.

Maybe we should think a bit more, what we wan't to show to users in accounts
information table - now it is something like cash book, but is that right way
of presenting account lines to user? Do they understand it enough?

> - We could replace the search with 
> 
>   my $account = $patron->account;
>   my $total   = $account->balance;
>   my $lines   = $account->lines;

Will be done in follow-up

-- 
You are receiving this mail because:
You are watching all bug changes.