[Koha-bugs] [Bug 22600] We should add an 'interface' field to accountlines

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22600

--- Comment #2 from Josef Moravec <josef.moravec at gmail.com> ---
Comment on attachment 87132
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87132
Bug 22600: Add 'interface' to accountlines

Review of attachment 87132:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=22600&attachment=87132)
-----------------------------------------------------------------

::: C4/Overdues.pm
@@ +599,5 @@
>                      description => $desc,
>                      note        => undef,
>                      user_id     => undef,
> +                    interface   => C4::Context->interface,
> +                    library_id  => undef, #FIXME: Should we grab the checkout or circ-control branch here perhaps?

On the first view, I think if the Context is set then we should grab it from
context, if not, stay with undef

::: C4/SIP/ILS/Transaction/FeePayment.pm
@@ +28,4 @@
>  our $debug = 0;
>  
>  my %fields = ();
> +C4::Context->interface('opac');

Should be 'SIP' I think

::: installer/data/mysql/atomicupdate/bug_22600.perl
@@ +2,5 @@
> +
> +$DBversion = 'XXX';    # will be replaced by the RM
> +if ( CheckVersion($DBversion) ) {
> +
> +    if ( !column_exists( 'accountlines', 'status' ) ) {

should be 'interface' instead of 'status'

@@ +7,5 @@
> +        $dbh->do(
> +            qq{
> +            ALTER TABLE `accountlines`
> +            ADD
> +              `interface` varchar(16) DEFAULT 'script'

'script' default is weird here

@@ +35,5 @@
> +          manager_id != borrowernumber;
> +    });
> +
> +    SetVersion($DBversion);
> +    print "Upgrade to $DBversion done (Bug 22518 - Fix accounttype 'O' to 'FU')\n";

Not right description I think ;)

-- 
You are receiving this mail because:
You are watching all bug changes.