[Koha-bugs] [Bug 22602] New: OverDrive circulation integration is broken when user is referred to Koha from another site

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu Mar 28 12:48:06 CET 2019


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22602

            Bug ID: 22602
           Summary: OverDrive circulation integration is broken when user
                    is referred to Koha from another site
 Change sponsored?: ---
           Product: Koha
           Version: unspecified
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: OPAC
          Assignee: oleonard at myacpl.org
          Reporter: nick at bywatersolutions.com
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

To recreate:
1 - Have a working OverDrive account and setup
2 - Put a link to your koha site on another site and follow the link to open
Koha in a new tab.window
3 - Do an overdrive search
4 - Note that copies listed as available are correct, however, all items only
have a place hold button

The issue is in the code below - if we came from an outside site we cannot
access p and we 'return' which never instantiates checkout_popup which is
needed   for creating the checkout buttons later

 87     var checkout_popup = null;
 88     $( document ).ready(function() {
 89         var p = window.opener;
 90         if (p) {
 91             try { cb = p.refresh_overdrive_account_details;}
 92             catch(err){ return; } //Catch error if opener is not accessible
 93             if (cb) {
 94                 cb();
 95             } else {
 96                 p.location.reload();
 97             }
 98             window.close();
 99         }
100         checkout_popup = $("#overdrive-checkout");
101         $("#overdrive-login-form").submit(function(e){
102             e.preventDefault();
103             $("#overdrive-login").modal('hide');
104             var ODpassword = $("input[name='ODpassword']").val();
105             login( ODpassword );
106         });
107     });

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list