[Koha-bugs] [Bug 22547] C4::Overdues - UpdateFine is barely tested

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22547

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Failed QA

--- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Martin,
I am having some doubts about doing these kind of things in the test:
    $fine->amountoutstanding('50')->store;

This obviously is a shortcut for doing the payment via 'nice' Koha calls, but I
think it would be better to use the regular calls in order to find integration
bugs and not give a false sense of security.

I tested a bit with something like:
    t::lib::Mocks::mock_userenv({ branchcode => $patron->branchcode });
    Koha::Account->new({ patron_id => $patron->borrowernumber })->pay({
        amount => 50, lines => [ $fine ],
    });
But it needs more attention..

This is no absolute blocker btw. It is great to have more tests here. But if
you could improve now, please do.

-- 
You are receiving this mail because:
You are watching all bug changes.