From bugzilla-daemon at bugs.koha-community.org Wed May 1 00:51:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Apr 2019 22:51:57 +0000
Subject: [Koha-bugs] [Bug 19062] Don't queue check-in/checkout messages if
patron has no e-mail
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19062
Hayley Mapley changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |hayleymapley at catalyst.net.n
| |z
Status|NEW |In Discussion
--- Comment #2 from Hayley Mapley ---
Is this resolved?
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 00:57:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Apr 2019 22:57:47 +0000
Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284
--- Comment #101 from Liz Rea ---
i'll retest this tomorrow I think
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 01:50:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Apr 2019 23:50:48 +0000
Subject: [Koha-bugs] [Bug 22799] Batch item modification is case sensitive
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22799
--- Comment #6 from Aleisha Amohia ---
(In reply to Josef Moravec from comment #4)
> I don't think so the barcode should be case insensitive - if you refer to
> barcode as main identifier for items, you need to make exact matches -
> taking your examples barcodes "abcde" and "abcDE" will not have same
> graphics represantation - so they are different.
That's fine but that isn't currently the behaviour anywhere in Koha. Everything
(except passwords) is case insensitive because the database does case
insensitive searching.
If you wanted to make the batch item modification tool case sensitive then this
behaviour needs to be made consistent everywhere in Koha. For example,
circulation - issuing with the barcode 'abcde' would check out the same item as
issuing with the barcode 'abcDE'.
I think while the behaviour in Koha is not case sensitive, this patch is still
valid and fixes the current problem.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 01:53:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Tue, 30 Apr 2019 23:53:39 +0000
Subject: [Koha-bugs] [Bug 22799] Batch item modification is case sensitive
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22799
--- Comment #7 from Aleisha Amohia ---
> If you wanted to make the batch item modification tool case sensitive then
> this behaviour needs to be made consistent everywhere in Koha. For example,
> circulation - issuing with the barcode 'abcde' would check out the same item
> as issuing with the barcode 'abcDE'.
In case this wasn't clear, I am describing the current behaviour for
circulation. You can check out an item with the barcode 'abcde' or 'abcDE'
currently.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 02:00:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 00:00:58 +0000
Subject: [Koha-bugs] [Bug 22809] Move "INVOICE" from template to a slip
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22809
Claudio changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |costalc at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 02:26:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 00:26:33 +0000
Subject: [Koha-bugs] [Bug 22803] Set dataTable width issue
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22803
Liz Rea changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 02:26:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 00:26:35 +0000
Subject: [Koha-bugs] [Bug 22803] Set dataTable width issue
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22803
Liz Rea changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #89011|0 |1
is obsolete| |
Attachment #89035|0 |1
is obsolete| |
--- Comment #6 from Liz Rea ---
Created attachment 89157
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89157&action=edit
Bug 22803: (alternate) Set dataTable width issue
This patch sets the "autowidth" option to "false" for the OPAC
subscriptions DataTable on opac-detail.pl. This gives the table a fluid
width rather than having the width be "hard-coded" by DataTables upon
first page render.
To test, apply the patch and view the detail page for a bibliographic
record with a subscription. Under the "Subscriptions" tab, the table of
latest issues should fill the width of the tab container.
Resize the browser window and confirm that the table width adjusts
accordingly.
Signed-off-by: Liz Rea
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 02:28:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 00:28:25 +0000
Subject: [Koha-bugs] [Bug 22816] New: OPAC detail holdings table doesn't
fill it's div
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22816
Bug ID: 22816
Summary: OPAC detail holdings table doesn't fill it's div
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: trivial
Priority: P5 - low
Component: OPAC
Assignee: oleonard at myacpl.org
Reporter: wizzyrea at gmail.com
QA Contact: testopia at bugs.koha-community.org
Target Milestone: ---
it could fit better, so let's make it so.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 02:35:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 00:35:15 +0000
Subject: [Koha-bugs] [Bug 22816] OPAC detail holdings table doesn't fill
it's div
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22816
Liz Rea changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 02:35:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 00:35:17 +0000
Subject: [Koha-bugs] [Bug 22816] OPAC detail holdings table doesn't fill
it's div
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22816
--- Comment #1 from Liz Rea ---
Created attachment 89158
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89158&action=edit
Bug 22816: OPAC detail holdings table should now look a bit better
This patch sets the "autowidth" option to "false" for the OPAC
holdings DataTable on opac-detail.pl. This gives the table a fluid
width rather than having the width be "hard-coded" by DataTables upon
first page render.
To test, apply the patch and view the detail page for a bibliographic
record with some items. Under the "Holdings" tab, the table of
holdings should fill the width of the tab container.
Resize the browser window and confirm that the table width adjusts
accordingly.
thanks to Owen Leonard for the initial fix for the subscriptions table and the
test plan.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 02:35:37 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 00:35:37 +0000
Subject: [Koha-bugs] [Bug 22816] OPAC detail holdings table doesn't fill
it's div
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22816
Liz Rea changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|oleonard at myacpl.org |wizzyrea at gmail.com
CC| |wizzyrea at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 02:35:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 00:35:53 +0000
Subject: [Koha-bugs] [Bug 22816] OPAC detail holdings table doesn't fill
it's container
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22816
Liz Rea changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|OPAC detail holdings table |OPAC detail holdings table
|doesn't fill it's div |doesn't fill it's container
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 04:14:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 02:14:24 +0000
Subject: [Koha-bugs] [Bug 22817] New: Call viewlog.pl using GET rather than
POST
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22817
Bug ID: 22817
Summary: Call viewlog.pl using GET rather than POST
Change sponsored?: ---
Product: Koha
Version: unspecified
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Tools
Assignee: koha-bugs at lists.koha-community.org
Reporter: barton at bywatersolutions.com
QA Contact: testopia at bugs.koha-community.org
Target Milestone: ---
When in the log viewer, the page uses POST rather than GET. This means that the
HTTP params are not viewable in the address bar.
This is very inconvenient from a support standpoint, since you can't then copy
the URL from the address bar in order to show someone what you're seeing in the
logs -- instead, you have to tell them what to look for in the logs, which is
very error prone.
Possibly even better would be a 'Copy URL' button.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 08:00:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 06:00:42 +0000
Subject: [Koha-bugs] [Bug 22812] Cannot add new subscription
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812
Mason James changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |mtj at kohaaloha.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 09:18:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 07:18:12 +0000
Subject: [Koha-bugs] [Bug 22487] Add Mana and Bugzilla components on bugzilla
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22487
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |paul.poulain at biblibre.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 09:40:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 07:40:17 +0000
Subject: [Koha-bugs] [Bug 20310] Article requests: Can we redirect article
records without items to host record?
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |martin.renvoize at ptfs-europe
| |.com
--- Comment #27 from Martin Renvoize ---
I'm starting to look at this with a view to QAing... but, as the conversation
has gone towards how we deal with multi-part records and 773,001,003 handling
it might be helpful to get some peoples thoughts and any updates over on the
Wiki: https://wiki.koha-community.org/wiki/Multipart_Bibliographics. Some time
ago I tried hard to understand it all with a view to trying to get it 'right'
in Koha eventually. It would be lovely for that effort to be picked up again.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 10:47:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 08:47:15 +0000
Subject: [Koha-bugs] [Bug 20310] Article requests: Can we redirect article
records without items to host record?
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310
--- Comment #28 from Martin Renvoize ---
I'm not entirely happy that this is built to only work with biblionumbers in
reality.
I think it would be significantly more adaptable in the future if we add a
field to the database that maps the combination of 003 + 001 into an indexed
unique field and did the find against that. That would mean that if your
library happens to maintain 001 = biblionumber (as is the assumption here I
believe) it'll all still work, but it will also work if your library uses local
001's or remote 001 and 003's. It'll likely need tweaking as we learn of other
schemes but that feels the most forward thinking approach I can come up with.
Thoughts?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 10:50:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 08:50:34 +0000
Subject: [Koha-bugs] [Bug 22799] Batch item modification is case sensitive
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22799
--- Comment #8 from Katrin Fischer ---
Hi Aleisha,
I get your point.
But can't help to wonder if we might have created a possible problem with using
CI on the database tables. If you compare ABC and abc with Perl, they will be
different, if you do a WHERE barcode = "abc" it will return both. But... you
can't add A and a to the database for the same reason (just tested). Not sure
if this is ideal, but probably very hard to fix. And we might have lots of
places where we don't do lc when comparing?
Still the behaviour is definitely wrong here showing the error and the item.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 11:10:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 09:10:07 +0000
Subject: [Koha-bugs] [Bug 20310] Article requests: Can we redirect article
records without items to host record?
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
--- Comment #29 from Katrin Fischer ---
If I understand the code correctly, it assumes the the first $w contains a
valid biblionumber, with or without proper prefix.
I think this assumption can't hold up.
At the moment, we expect in $w a number, that is also in 001 of a matching
record. Ideally with a 003 that has the matching prefix, but this is not
checked. So:
Analytic:
$w(MARCOrgCode)rcn
Host:
001 rcn
003 MARCOrgCode
Actually... we probably should also check 035, but that is a different issue:
035 (MARCOrgCode)rcn
In Koha there is no way to automatically enforce 001 = biblionumber. And if you
want to do it, it's tedious, as you have to save first to create the
biblionumber before you can enter it in 001. There is even a new feature for
Rancor, that allows you to create custom 001, that are not relating to
biblionumber at all.
The risk I see with this feature as is, is that the number from $w might
accidentally match a biblionumber. So we would create unwanted redirects. You
can't turn it off.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 11:11:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 09:11:20 +0000
Subject: [Koha-bugs] [Bug 20310] Article requests: Can we redirect article
records without items to host record?
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310
--- Comment #30 from Martin Renvoize ---
(In reply to Martin Renvoize from comment #28)
> I'm not entirely happy that this is built to only work with biblionumbers in
> reality.
>
> I think it would be significantly more adaptable in the future if we add a
> field to the database that maps the combination of 003 + 001 into an indexed
> unique field and did the find against that. That would mean that if your
> library happens to maintain 001 = biblionumber (as is the assumption here I
> believe) it'll all still work, but it will also work if your library uses
> local 001's or remote 001 and 003's. It'll likely need tweaking as we learn
> of other schemes but that feels the most forward thinking approach I can
> come up with.
>
> Thoughts?
That, or use the search engine to find hosts which is how the xslt's currently
do it I believe
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 11:14:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 09:14:01 +0000
Subject: [Koha-bugs] [Bug 20310] Article requests: Can we redirect article
records without items to host record?
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310
--- Comment #31 from Katrin Fischer ---
Note: If you use the 'addd child record' feature in Koha, it will copy 001 to
$w. While it might not be super fast, maybe we could change the host_record
feature to look for a matching 001 instead of just biblionumber? It would make
this work along the current assumptions.
Also: We should add UNIMARC support.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 11:15:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 09:15:46 +0000
Subject: [Koha-bugs] [Bug 20310] Article requests: Can we redirect article
records without items to host record?
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |carnold at dgiinc.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 11:16:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 09:16:56 +0000
Subject: [Koha-bugs] [Bug 20310] Article requests: Can we redirect article
records without items to host record?
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
|y.org |.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 11:21:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 09:21:01 +0000
Subject: [Koha-bugs] [Bug 22811] Add button to clear DataTables filtering
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22811
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #3 from Katrin Fischer ---
Only thing maybe... I feel the buttons are a little big and the problem and I
am sorry German translations will make it worse (why are our words so loooong?)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 11:21:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 09:21:47 +0000
Subject: [Koha-bugs] [Bug 21533] Do not allow password recovery for
administrative locked patrons (see 21336)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21533
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #88967|0 |1
is obsolete| |
--- Comment #4 from Martin Renvoize ---
Created attachment 89159
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89159&action=edit
Bug 21533: Do not allow password recovery for administrative locked patrons
Depends on bug 21336 for the ADMINISTRATIVE_LOCKOUT constant.
This is a bit lazy solution (but good enough): The account will not be found
when recovering the password. The user should contact the library. Since
the library chose to lock the account, that seems appropriate.
Test plan:
Select a borrower and set login_attempts to -1. Via mysql command line or
with Koha::Patrons->find(borrowernumber)->lock.
Enable password recovery.
Try to recover password from OPAC. You should fail with 'Not found, contact
the library'.
Signed-off-by: Marcel de Rooy
Signed-off-by: Owen Leonard
Signed-off-by: Bouzid Fergani
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 11:21:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 09:21:54 +0000
Subject: [Koha-bugs] [Bug 22811] Add button to clear DataTables filtering
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22811
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 11:21:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 09:21:57 +0000
Subject: [Koha-bugs] [Bug 22811] Add button to clear DataTables filtering
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22811
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #89143|0 |1
is obsolete| |
--- Comment #4 from Katrin Fischer ---
Created attachment 89160
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89160&action=edit
Bug 22811: Add button to clear DataTables filtering
This patch adds a "clear filter" button to the global
DataTables configuration. The button will appear if:
- There is no custom DOM configuration applied to the DataTable
instance.
- The DataTable has the search form enabled.
The new button should be disabled by default. Entering a search term in
the form should enable it.
To test, apply the patch and clear your browser cache if necessary. View
various pages with various DataTables configurations and confirm that
everything looks correct and the new "Clear filter" button doesn't
appear when there is no DataTable search field. For example:
- Administration -> Libraries
- Administration -> Currencies
- Reports -> Saved reports
- Circulation -> Check out
- Tools -> News
Signed-off-by: Liz Rea
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 11:22:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 09:22:15 +0000
Subject: [Koha-bugs] [Bug 21533] Do not allow password recovery for
administrative locked patrons (see 21336)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21533
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
CC| |martin.renvoize at ptfs-europe
| |.com
--- Comment #5 from Martin Renvoize ---
Simple patch that works well. Passing QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 11:25:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 09:25:17 +0000
Subject: [Koha-bugs] [Bug 22808] Move Cache.t to db_dependent
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22808
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
Patch complexity|--- |Trivial patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 11:25:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 09:25:20 +0000
Subject: [Koha-bugs] [Bug 22808] Move Cache.t to db_dependent
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22808
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #89154|0 |1
is obsolete| |
--- Comment #3 from Katrin Fischer ---
Created attachment 89161
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89161&action=edit
Bug 22808: Move Cache.t to db_dependent
Cache.t fails during package build. Moving it to db_dependent fixes
the problem.
Signed-off-by: Liz Rea
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 11:25:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 09:25:54 +0000
Subject: [Koha-bugs] [Bug 21535] Anonymize function in Patron should not
scramble email addresses
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21535
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #88906|0 |1
is obsolete| |
--- Comment #5 from Martin Renvoize ---
Created attachment 89162
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89162&action=edit
Bug 21535: Anonymize function in Patron should not scramble email addresses
Scrambled email addresses will only generate warnings etc.
Clear them although they might be in BorrowerMandatoryField.
Test plan:
Run t/db_dependent/Koha/Patrons.t
Signed-off-by: Marcel de Rooy
Signed-off-by: Owen Leonard
t/db_depepended/Koha/Patrons.t runs with no warnings.
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 11:26:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 09:26:14 +0000
Subject: [Koha-bugs] [Bug 21535] Anonymize function in Patron should not
scramble email addresses
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21535
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |martin.renvoize at ptfs-europe
| |.com
Status|Signed Off |Passed QA
--- Comment #6 from Martin Renvoize ---
No regressions found. Passing QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 11:31:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 09:31:29 +0000
Subject: [Koha-bugs] [Bug 22420] Tag cloud feature broken
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22420
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
Status|Needs Signoff |Signed Off
--- Comment #10 from Katrin Fischer ---
Moving this to signed off as per this comment: bug 22766 comment 5
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 11:37:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 09:37:45 +0000
Subject: [Koha-bugs] [Bug 22420] Tag cloud feature broken
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22420
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
Patch complexity|--- |Small patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 11:37:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 09:37:49 +0000
Subject: [Koha-bugs] [Bug 22420] Tag cloud feature broken
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22420
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #85755|0 |1
is obsolete| |
--- Comment #11 from Katrin Fischer ---
Created attachment 89163
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89163&action=edit
Bug 22420: Remove wrong calculation on approved tags
Before the patch from bug 14385, the passed structure (that is returned
by get_approval_rows() looks like:
\ [
[0] {
approved 1,
approved_by 51,
approved_by_name undef,
date_approved "2019-02-26 15:36:42",
term "another",
weight_total 3
},
[1] {
...
After the introduced 'filtering', we loose the information about the
term weight!:
\ [
[0] {
approved 1,
author "Heylin, Clinton.",
biblionumber 1,
borrowernumber 51,
date_created "2019-02-26 15:36:37",
language undef,
subtitle [],
tag_id 1,
term "word",
time_created_display "15:36:37",
title "E Street shuffle :",
visible 1,
XSLTBloc "
<<>>
...
The code even calls GetMarcBiblio. This needs to be reverted as it is
plain wrong. If it was worth removing *some* biblios from the
weight_total value, then this calculation should be done somewhere else,
without fetching the MARC data again.
Signed-off-by: Claudio
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 11:38:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 09:38:42 +0000
Subject: [Koha-bugs] [Bug 22420] Tag cloud feature broken
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22420
--- Comment #12 from Katrin Fischer ---
Fixes a major regression. I agree if filtering is needed, we should resolve
that separately.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 11:40:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 09:40:50 +0000
Subject: [Koha-bugs] [Bug 21411] Advanced cataloging editor - rancor - Allow
configuration of Keyboard shortcuts
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21411
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
|y.org |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 11:43:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 09:43:17 +0000
Subject: [Koha-bugs] [Bug 21036] Fix a bunch of older warnings
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21036
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #78455|0 |1
is obsolete| |
--- Comment #15 from Martin Renvoize ---
Created attachment 89165
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89165&action=edit
Bug 21036: Fix warnings from C4/Biblio
Use of uninitialized value $isbn in string ne at
/usr/share/koha/prodclone/C4/Biblio.pm line 1794. (16.11 line number)
Trivial edit.
And these warnings from TransformHtmlToXml (with 16.11 line numbers):
Use of uninitialized value in substr at /usr/share/koha/prodclone/C4/Biblio.pm
line 2527.
Use of uninitialized value in substr at /usr/share/koha/prodclone/C4/Biblio.pm
line 2528.
substr outside of string at /usr/share/koha/prodclone/C4/Biblio.pm line 2528.
Indicator in 952 is empty at /usr/share/koha/prodclone/C4/Biblio.pm line 2534.
The last warning is not needed and can be removed.
Note that the code used the construct @$indicator[$j] for $$indicator[$j].
The first is an array slice. This worked in list context. But apparently
the second was meant to be used. And can be rewritten as $indicator->[$j]
which generally is considered more readable.
The code around indicator1/2 and ind1/2 is simplified. This change is applied
twice in the same sub.
Test plan:
Read the changes.
Run t/Biblio/TransformHtmlToXml.t
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 11:43:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 09:43:20 +0000
Subject: [Koha-bugs] [Bug 21036] Fix a bunch of older warnings
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21036
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #88969|0 |1
is obsolete| |
--- Comment #16 from Martin Renvoize ---
Created attachment 89166
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89166&action=edit
Bug 21036: Remove odd number of elements warnings from AuthoritiesMarc.pm
Like this one (16.11 line number):
Odd number of elements in anonymous hash at C4/AuthoritiesMarc.pm line 1070.
We need to add a scalar to some MARC::Field::subfield calls. In list context
an empty list returned affects the hash built around it.
Test plan:
Could reproduce this warning easily from OPAC authority search.
opac-authorities-home.pl calling BuildSummary.
Signed-off-by: Bouzid Fergani
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 11:43:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 09:43:15 +0000
Subject: [Koha-bugs] [Bug 21036] Fix a bunch of older warnings
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21036
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #76689|0 |1
is obsolete| |
--- Comment #14 from Martin Renvoize ---
Created attachment 89164
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89164&action=edit
Bug 21036: Fix uninitialized value within @itemnumber in string ne
Line from 16.11 log:
Use of uninitialized value within @itemnumber in string ne at
/usr/share/koha/prodclone/reserve/modrequest.pl line 70.
Test plan:
Read the change. Not 100% identical (numeric zero) but should be enough.
This line is probably not needed at all.
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 11:45:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 09:45:16 +0000
Subject: [Koha-bugs] [Bug 21036] Fix a bunch of older warnings
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21036
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
CC| |martin.renvoize at ptfs-europe
| |.com
--- Comment #17 from Martin Renvoize ---
Always nice to see a few warning cleared up.. these three patches perform well
for me and I can't find any regressions.
Passing QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 11:45:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 09:45:24 +0000
Subject: [Koha-bugs] [Bug 21036] Fix a bunch of older warnings
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21036
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 12:02:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 10:02:14 +0000
Subject: [Koha-bugs] [Bug 21411] Advanced cataloging editor - rancor - Allow
configuration of Keyboard shortcuts
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21411
--- Comment #22 from Katrin Fischer ---
Suggested follow-ups:
Hide hide the Keyboard settings when Rancor is not activated, similar like
other settings are not visible (Plugins, Search engine configs) without the
pref.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 12:07:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 10:07:35 +0000
Subject: [Koha-bugs] [Bug 21411] Advanced cataloging editor - rancor - Allow
configuration of Keyboard shortcuts
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21411
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
--- Comment #23 from Katrin Fischer ---
Some small stuff:
1) As we moved the sql out of hte en installer, this needs to go too:
installer/data/mysql/en/mandatory/keyboard_shortcuts.txt
2) Do you really want to give liblime copyright?
+-- Default keyboard shortcuts
+-- for Koha.
+--
+-- Copyright (C) 2007 LiblimeA
+-- Copyright 2018 Koha Development Team
3) Needs permission check:
+Redefine shortcuts
4) Hide hide the Keyboard settings when Rancor is not activated, similar like
other settings are not visible (Plugins, Search engine configs) without the
pref.
- Admin menu
- Admin home page
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 12:18:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 10:18:08 +0000
Subject: [Koha-bugs] [Bug 19605] ILL backends should be pluggable through
regular Koha plugins
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
Andrew Isherwood changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |andrew.isherwood at ptfs-europ
| |e.com
Depends on|18589 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589
[Bug 18589] Show ILLs as part of patron profile
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 12:18:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 10:18:14 +0000
Subject: [Koha-bugs] [Bug 22121] Display 'Price paid' on ILL requests
according to CurrencyFormat pref
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22121
Andrew Isherwood changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on|18589 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589
[Bug 18589] Show ILLs as part of patron profile
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 12:18:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 10:18:14 +0000
Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589
Andrew Isherwood changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|22121 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22121
[Bug 22121] Display 'Price paid' on ILL requests according to CurrencyFormat
pref
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 12:18:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 10:18:27 +0000
Subject: [Koha-bugs] [Bug 22440] ILL API response objects inconsistent with
other endpoints
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440
Andrew Isherwood changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on|18589 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589
[Bug 18589] Show ILLs as part of patron profile
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 12:18:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 10:18:27 +0000
Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589
Andrew Isherwood changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|22440 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22440
[Bug 22440] ILL API response objects inconsistent with other endpoints
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 12:18:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 10:18:08 +0000
Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589
Andrew Isherwood changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|19605 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19605
[Bug 19605] ILL backends should be pluggable through regular Koha plugins
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 12:18:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 10:18:32 +0000
Subject: [Koha-bugs] [Bug 22491] Patrons should be searchable by surname
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22491
Andrew Isherwood changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on|18589 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589
[Bug 18589] Show ILLs as part of patron profile
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 12:18:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 10:18:32 +0000
Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589
Andrew Isherwood changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|22491 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22491
[Bug 22491] Patrons should be searchable by surname
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 12:18:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 10:18:39 +0000
Subject: [Koha-bugs] [Bug 22528] Add tab with current/active ILL requests to
patron circulation page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22528
Andrew Isherwood changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |andrew.isherwood at ptfs-europ
| |e.com
Depends on|18589 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589
[Bug 18589] Show ILLs as part of patron profile
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 12:18:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 10:18:39 +0000
Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589
Andrew Isherwood changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|22528 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22528
[Bug 22528] Add tab with current/active ILL requests to patron circulation page
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 12:18:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 10:18:44 +0000
Subject: [Koha-bugs] [Bug 22531] Allow for multiple requests to partners and
display partners in audit log
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531
Andrew Isherwood changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on|18589 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589
[Bug 18589] Show ILLs as part of patron profile
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 12:18:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 10:18:44 +0000
Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589
Andrew Isherwood changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|22531 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22531
[Bug 22531] Allow for multiple requests to partners and display partners in
audit log
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 12:18:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 10:18:50 +0000
Subject: [Koha-bugs] [Bug 21460] Filtering ILL requests on borrowernumber
does not work
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
Andrew Isherwood changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on|18589 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589
[Bug 18589] Show ILLs as part of patron profile
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 12:18:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 10:18:50 +0000
Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589
Andrew Isherwood changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|21460 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21460
[Bug 21460] Filtering ILL requests on borrowernumber does not work
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 12:18:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 10:18:55 +0000
Subject: [Koha-bugs] [Bug 22268] Data displayed in request list datatable is
not sanitized
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22268
Andrew Isherwood changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on|18589 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589
[Bug 18589] Show ILLs as part of patron profile
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 12:18:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 10:18:55 +0000
Subject: [Koha-bugs] [Bug 18589] Show ILLs as part of patron profile
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18589
Andrew Isherwood changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks|22268 |
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22268
[Bug 22268] Data displayed in request list datatable is not sanitized
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 12:23:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 10:23:18 +0000
Subject: [Koha-bugs] [Bug 22818] New: ILL should be able to send notices
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Bug ID: 22818
Summary: ILL should be able to send notices
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: ILL
Assignee: koha-bugs at lists.koha-community.org
Reporter: andrew.isherwood at ptfs-europe.com
Target Milestone: ---
Currently ILL has no ability to send notices. There are a number of events that
would warrant a notice being send out, these include:
To patron:
- Request ready for pickup
- Item requested not available
To staff:
- Request cancelled by patron
- Request modified by patron
To supplier:
- "Request from partner"
The last one, "Request from partner", is currently send via an ad-hoc function,
but would make sense to convert to a notice.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 12:24:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 10:24:13 +0000
Subject: [Koha-bugs] [Bug 22818] ILL should be able to send notices
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Andrew Isherwood changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |andrew.isherwood at ptfs-europ
|ity.org |e.com
Status|NEW |ASSIGNED
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 12:33:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 10:33:23 +0000
Subject: [Koha-bugs] [Bug 11529] Add subtitle,
medium and part fields to biblio table
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529
--- Comment #185 from Katrin Fischer ---
Embarking on my testing journey here... wish me luck!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 12:45:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 10:45:23 +0000
Subject: [Koha-bugs] [Bug 11529] Add subtitle,
medium and part fields to biblio table
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529
--- Comment #186 from Katrin Fischer ---
Patches apply, QA tests pass... more later.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 12:51:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 10:51:47 +0000
Subject: [Koha-bugs] [Bug 21036] Fix a bunch of older warnings
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21036
--- Comment #18 from Marcel de Rooy ---
Thanks Bouzid and Martin
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 12:52:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 10:52:19 +0000
Subject: [Koha-bugs] [Bug 21535] Anonymize function in Patron should not
scramble email addresses
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21535
--- Comment #7 from Marcel de Rooy ---
Thx Owen and Martin !
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 12:53:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 10:53:44 +0000
Subject: [Koha-bugs] [Bug 21533] Do not allow password recovery for
administrative locked patrons (see 21336)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21533
--- Comment #6 from Marcel de Rooy ---
Thx Owen, Bouzid and Martin
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 12:58:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 10:58:44 +0000
Subject: [Koha-bugs] [Bug 20310] Article requests: Can we redirect article
records without items to host record?
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20310
--- Comment #32 from Marcel de Rooy ---
OK Thx for your feedback. This might need more thought about the right
direction for a solution. Will leave it for now, hopefully picking it up
later..
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 13:00:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 11:00:57 +0000
Subject: [Koha-bugs] [Bug 22453] TestBuilder should generate now() using the
current timezone
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22453
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |BLOCKED
--- Comment #13 from Marcel de Rooy ---
QA: Looking here now
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 13:01:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 11:01:38 +0000
Subject: [Koha-bugs] [Bug 22741] Second prove of Koha/Patrons.t fails on
test BorrowerLogs and TrackLastPatronActivity
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22741
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|RESOLVED |REOPENED
Resolution|DUPLICATE |---
--- Comment #5 from Marcel de Rooy ---
Reopening this one since 2253 does not completely resolve the problem.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 13:02:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 11:02:23 +0000
Subject: [Koha-bugs] [Bug 21946] Group circulation by item type
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #88926|0 |1
is obsolete| |
--- Comment #30 from Nick Clemens ---
Created attachment 89167
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89167&action=edit
Bug 21946: Database updates
Signed-off-by: Liz Rea
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 13:01:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 11:01:58 +0000
Subject: [Koha-bugs] [Bug 22741] Second prove of Koha/Patrons.t fails on
test BorrowerLogs and TrackLastPatronActivity
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22741
--- Comment #6 from Marcel de Rooy ---
(In reply to Marcel de Rooy from comment #5)
> Reopening this one since 2253 does not completely resolve the problem.
22453
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 13:02:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 11:02:26 +0000
Subject: [Koha-bugs] [Bug 21946] Group circulation by item type
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #88927|0 |1
is obsolete| |
--- Comment #31 from Nick Clemens ---
Created attachment 89168
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89168&action=edit
Bug 21946: SCHEMA UPDATES DO NOT PUSH
Signed-off-by: Liz Rea
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 13:02:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 11:02:29 +0000
Subject: [Koha-bugs] [Bug 21946] Group circulation by item type
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #88928|0 |1
is obsolete| |
--- Comment #32 from Nick Clemens ---
Created attachment 89169
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89169&action=edit
Bug 21946: Update C4::Circulation->TooMany to check parent itemtypes
To test:
1 - prove -v t/db_dependent/Circulation/TooMany.t
Signed-off-by: Liz Rea
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 13:02:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 11:02:32 +0000
Subject: [Koha-bugs] [Bug 21946] Group circulation by item type
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #88929|0 |1
is obsolete| |
--- Comment #33 from Nick Clemens ---
Created attachment 89170
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89170&action=edit
Bug 21946: Update Administration->Item types to allow for defining parent types
To test:
1 - Browse to Administration -> Item types
2 - Not a new colum for prent type
3 - Edit an existing type and not you can select any type (except the current)
as a parent
4 - Select one
5 - Edit the type you selected as parent
6 - Note it cannot have a parent defined
7 - Edit a new type, note you can select a parent
Signed-off-by: Liz Rea
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 13:02:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 11:02:35 +0000
Subject: [Koha-bugs] [Bug 21946] Group circulation by item type
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #88930|0 |1
is obsolete| |
--- Comment #34 from Nick Clemens ---
Created attachment 89171
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89171&action=edit
Bug 21946: Fix display of parent types
Signed-off-by: Liz Rea
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 13:02:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 11:02:39 +0000
Subject: [Koha-bugs] [Bug 21946] Group circulation by item type
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #88931|0 |1
is obsolete| |
--- Comment #35 from Nick Clemens ---
Created attachment 89172
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89172&action=edit
Bug 21946: Use objects for displaying circulation rules
Signed-off-by: Liz Rea
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 13:02:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 11:02:42 +0000
Subject: [Koha-bugs] [Bug 21946] Group circulation by item type
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #88932|0 |1
is obsolete| |
--- Comment #36 from Nick Clemens ---
Created attachment 89173
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89173&action=edit
Bug 21946: Display parent-child relationship on smart-rules.pl
To test:
1 - Set some itemtypes to have a parent
2 - Browse to Administration -> Circulation and fines rules
3 - Note new description of parent/child relationships at top of page
4 - Note that itemtype dropdown for circ rules shows child types under parents
5 - Set a rule for a child type
6 - Note it displays as Parent->Child
7 - Have three child types under a parent
8 - Set the parent 'Current checkouts allowed' to 3
9 - Set the children 'Current checkouts allowed' to:
type1 = 2
type2 = 1
type3 = 1
10 - Create some items of the type above
11 - Note you can checkout 2 of type 1, and not 3
12 - Note you can checkout 1 of type 2, but not 2
13 - Note that you now cannot checkout any of type3
14 - Note you cannot checkout any of the parent type
15 - Return one of the other items and note you can now checkout an item of
type3
16 - Return another item and note you can checkout an item of the parent type
17 - Return all
18 - Set the parent type to 1
19 - Now note you can only checkout 1 of any of the children
20 - Set the parent to 0
21 - Note you cannot checkout any of the child types
Signed-off-by: Liz Rea
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 13:02:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 11:02:46 +0000
Subject: [Koha-bugs] [Bug 21946] Group circulation by item type
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #88933|0 |1
is obsolete| |
--- Comment #37 from Nick Clemens ---
Created attachment 89174
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89174&action=edit
Bug 21946: (follow-up) Correct dropdown when editing rule
Signed-off-by: Liz Rea
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 13:02:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 11:02:49 +0000
Subject: [Koha-bugs] [Bug 21946] Group circulation by item type
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #88934|0 |1
is obsolete| |
--- Comment #38 from Nick Clemens ---
Created attachment 89175
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89175&action=edit
Bug 21946: (QA follow-up) - remove console.log
To make QA tools happy
Signed-off-by: Liz Rea
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 13:02:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 11:02:52 +0000
Subject: [Koha-bugs] [Bug 21946] Group circulation by item type
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946
--- Comment #39 from Nick Clemens ---
Created attachment 89176
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89176&action=edit
Bug 21946: (follow-up) Address QA concerns
1 - Correct hashref for searching
2 - Correct undef for all (this only simplifies later logic so didn't affect
outcomes)
3 - remove duplicated query
4 - Use get_column instead of loops
5 - Fix typo
6 - Whitespace fixes removed from earlier patches
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 13:13:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 11:13:21 +0000
Subject: [Koha-bugs] [Bug 22453] TestBuilder should generate now() using the
current timezone
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22453
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|BLOCKED |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 13:13:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 11:13:23 +0000
Subject: [Koha-bugs] [Bug 22453] TestBuilder should generate now() using the
current timezone
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22453
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #89149|0 |1
is obsolete| |
--- Comment #14 from Marcel de Rooy ---
Created attachment 89177
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89177&action=edit
Bug 22453: Make TestBuilder generates dates taking into account the timezone
I have no idea why this only appears today but TestBuilder generates dates
using DateTime->now,
which does not take into account the timezone.
It has been highlights by a failing test today on U18.
Why today whereas this patch was pushed few weeks ago?
Why U18 and not D9?
The output of the test is:
koha_1 | # Failed test 'With BorrowerLogs and
TrackLastPatronActivity we should not spam the logs'
koha_1 | # at t/db_dependent/Koha/Patrons.t line 1421.
koha_1 | # got: '2'
koha_1 | # expected: '1'
koha_1 | # Looks like you failed 1 test of 4.
koha_1 |
koha_1 | # Failed test 'BorrowersLog tests'
koha_1 | # at t/db_dependent/Koha/Patrons.t line 1422.
koha_1 | # Looks like you failed 1 test of 33.
koha_1 | [19:51:44] t/db_dependent/Koha/Patrons.t
Actually there are 2 logs, one for the cardnumber that is expected, and on for
updated_on:
"updated_on" : {
"after" : "2019-03-04 21:10:00",
"before" : "2019-03-04 18:10:00"
}
Apart from the fact that we may want to remove this updated_on field from
MODIFY,
the before/after dates differ from 3 hours.
Here it's currently 18:10 and in UTC-3
To prevent such behaviors in tests (create stuffs in the future...), we should
use our Koha::DateUtils::dt_from_string method that takes care of the timezone
used in other places of Koha.
Test plan:
prove t/db_dependent/Koha/Patrons.t
May fail without this patch.
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Marcel de Rooy
This patch is fine in itself, but there may still be an issue around
the failing test for TrackLastPatronActivity. Reopened bug 22741.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 13:13:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 11:13:56 +0000
Subject: [Koha-bugs] [Bug 22741] Second prove of Koha/Patrons.t fails on
test BorrowerLogs and TrackLastPatronActivity
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22741
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=22453
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 13:13:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 11:13:56 +0000
Subject: [Koha-bugs] [Bug 22453] TestBuilder should generate now() using the
current timezone
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22453
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=22741
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 13:13:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 11:13:38 +0000
Subject: [Koha-bugs] [Bug 22453] TestBuilder should generate now() using the
current timezone
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22453
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
|y.org |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 13:15:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 11:15:06 +0000
Subject: [Koha-bugs] [Bug 15260] Option for extended loan with useDaysMode
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260
Andrew Isherwood changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 13:15:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 11:15:09 +0000
Subject: [Koha-bugs] [Bug 15260] Option for extended loan with useDaysMode
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260
--- Comment #19 from Andrew Isherwood ---
Created attachment 89178
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89178&action=edit
Bug 15260: (follow-up) Fix bug in subtraction
prev_open_days can receive either positive or negative numbers and
then does the right thing with them. However, we weren't also doing this
with the number it receives back from get_push_amt
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 13:15:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 11:15:38 +0000
Subject: [Koha-bugs] [Bug 15260] Option for extended loan with useDaysMode
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260
--- Comment #20 from Andrew Isherwood ---
Great catch Liz, thanks! That was a nasty one!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 13:28:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 11:28:12 +0000
Subject: [Koha-bugs] [Bug 21946] Group circulation by item type
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946
--- Comment #40 from Nick Clemens ---
(In reply to Jonathan Druart from comment #29)
> 7. I am really not sure the comparisons with '*' in smart-rules.tt are
> correct.
Apologies, I don't see an issue with this, can you explain a bit more?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 13:29:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 11:29:07 +0000
Subject: [Koha-bugs] [Bug 21411] Advanced cataloging editor - rancor - Allow
configuration of Keyboard shortcuts
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21411
Nick Clemens changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 13:29:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 11:29:09 +0000
Subject: [Koha-bugs] [Bug 21411] Advanced cataloging editor - rancor - Allow
configuration of Keyboard shortcuts
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21411
--- Comment #24 from Nick Clemens ---
Created attachment 89179
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89179&action=edit
Bug 21411: (follow-up) Clean up for QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 13:38:34 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 11:38:34 +0000
Subject: [Koha-bugs] [Bug 22819] New: Release team 19.05
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22819
Bug ID: 22819
Summary: Release team 19.05
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: About
Assignee: koha-bugs at lists.koha-community.org
Reporter: m.de.rooy at rijksmuseum.nl
QA Contact: testopia at bugs.koha-community.org
Target Milestone: ---
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 13:38:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 11:38:53 +0000
Subject: [Koha-bugs] [Bug 18303] Release team omnibus
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18303
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |22819
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22819
[Bug 22819] Release team 19.05
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 13:38:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 11:38:53 +0000
Subject: [Koha-bugs] [Bug 22819] Release team 19.05
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22819
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |18303
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18303
[Bug 18303] Release team omnibus
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 13:38:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 11:38:57 +0000
Subject: [Koha-bugs] [Bug 5770] Email librarian when purchase suggestion made
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|josef.moravec at gmail.com |martin.renvoize at ptfs-europe
| |.com
CC| |martin.renvoize at ptfs-europe
| |.com
--- Comment #28 from Martin Renvoize ---
Couple of QA points here... not sure if Josef
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 13:39:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 11:39:06 +0000
Subject: [Koha-bugs] [Bug 22819] Release team 19.05
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22819
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |nick at bywatersolutions.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 13:39:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 11:39:32 +0000
Subject: [Koha-bugs] [Bug 22819] Release team 19.05
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22819
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |ASSIGNED
Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl
|ity.org |
Patch complexity|--- |String patch
Severity|enhancement |trivial
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 13:41:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 11:41:35 +0000
Subject: [Koha-bugs] [Bug 5770] Email librarian when purchase suggestion made
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770
--- Comment #29 from Martin Renvoize ---
Oops.. lets start that again.
1) I think we should allow for the feature to be disabled and so I'd like to
see the syspref allow for that option - I'll work on a QA followup for that
2) We should perhaps take account of the reply-to handling built into branch
addresses and admin email address - I can also look at doing a followup
3) I'm not a fan of us introducing the letter_code option to
C4::Letter::GetMessagesQueue just for use in the tests - I'll do a followup for
that too.
Otherwise, I really like the feature so please bear with me whilst I code up
the followups for QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 13:44:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 11:44:16 +0000
Subject: [Koha-bugs] [Bug 22819] Release team 19.05
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22819
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Resolution|--- |WONTFIX
Status|ASSIGNED |RESOLVED
--- Comment #1 from Marcel de Rooy ---
Already got attention
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 13:44:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 11:44:17 +0000
Subject: [Koha-bugs] [Bug 18303] Release team omnibus
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18303
Bug 18303 depends on bug 22819, which changed state.
Bug 22819 Summary: Release team 19.05
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22819
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |RESOLVED
Resolution|--- |WONTFIX
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 13:44:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 11:44:56 +0000
Subject: [Koha-bugs] [Bug 18303] Release team omnibus
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18303
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=21626
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 13:44:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 11:44:56 +0000
Subject: [Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha
team' page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=18303
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 13:46:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 11:46:20 +0000
Subject: [Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU
daemon that can inject item status MARC subfields
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |release-notes-needed,
| |rel_19_05_candidate
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 13:48:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 11:48:39 +0000
Subject: [Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha
team' page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Patch doesn't apply
CC| |m.de.rooy at rijksmuseum.nl
--- Comment #22 from Marcel de Rooy ---
Applying: Bug 21626: Use teams.yaml for teams section
error: sha1 information is lacking or useless (about.pl).
error: could not build fake ancestor
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 13:52:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 11:52:13 +0000
Subject: [Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha
team' page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626
--- Comment #23 from Marcel de Rooy ---
Glad to see improvements here, but the two teams next to each other are somehow
confusing to me too.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 14:06:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 12:06:00 +0000
Subject: [Koha-bugs] [Bug 21662] Missing developers from history
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #88898|0 |1
is obsolete| |
--- Comment #52 from Martin Renvoize ---
Created attachment 89180
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89180&action=edit
Bug 21662: Make history.txt whitespace consistent
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 14:06:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 12:06:04 +0000
Subject: [Koha-bugs] [Bug 21662] Missing developers from history
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #88899|0 |1
is obsolete| |
--- Comment #53 from Martin Renvoize ---
Created attachment 89181
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89181&action=edit
Bug 21662: Update history.txt
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 14:06:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 12:06:07 +0000
Subject: [Koha-bugs] [Bug 21662] Missing developers from history
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #88900|0 |1
is obsolete| |
--- Comment #54 from Martin Renvoize ---
Created attachment 89182
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89182&action=edit
Bug 21662: Add Contributors.yaml file
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 14:06:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 12:06:10 +0000
Subject: [Koha-bugs] [Bug 21662] Missing developers from history
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #88901|0 |1
is obsolete| |
--- Comment #55 from Martin Renvoize ---
Created attachment 89183
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89183&action=edit
Bug 21662: Use contributors.yaml for contributors list
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 14:06:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 12:06:14 +0000
Subject: [Koha-bugs] [Bug 21662] Missing developers from history
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #88902|0 |1
is obsolete| |
--- Comment #56 from Martin Renvoize ---
Created attachment 89184
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89184&action=edit
Bug 21662: Other history correction
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 14:09:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 12:09:27 +0000
Subject: [Koha-bugs] [Bug 21662] Missing developers from history
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Signed Off
--- Comment #57 from Martin Renvoize ---
Indeed.. after our chat on IRC I'm not entirely sure why the commit numbers
don't add up.. I'll investigate that in a followup bug as suggested.. as you
say, they're not displayed yet anyway.
Capitalisation fixes done.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 14:10:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 12:10:56 +0000
Subject: [Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha
team' page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #88890|0 |1
is obsolete| |
--- Comment #24 from Martin Renvoize ---
Created attachment 89185
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89185&action=edit
Bug 21626: Add teams.yaml to /docs
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 14:11:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 12:11:00 +0000
Subject: [Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha
team' page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #88891|0 |1
is obsolete| |
--- Comment #25 from Martin Renvoize ---
Created attachment 89186
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89186&action=edit
Bug 21626: Use teams.yaml for teams section
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 14:11:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 12:11:52 +0000
Subject: [Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha
team' page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626
--- Comment #26 from Martin Renvoize ---
Rebased so hopefully applies again now.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 14:13:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 12:13:25 +0000
Subject: [Koha-bugs] [Bug 21626] Add 'current maintenance team' to the 'Koha
team' page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21626
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Patch doesn't apply |Needs Signoff
--- Comment #27 from Martin Renvoize ---
A branch is also maintained here:
https://github.com/PTFS-Europe/koha/tree/bug_21626
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 14:15:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 12:15:13 +0000
Subject: [Koha-bugs] [Bug 22819] Release team 19.05
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22819
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |martin.renvoize at ptfs-europe
| |.com
--- Comment #2 from Martin Renvoize ---
Bug 21626 changes how we go about doing this, for the better I hope.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 14:17:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 12:17:47 +0000
Subject: [Koha-bugs] [Bug 18303] Release team omnibus
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18303
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |martin.renvoize at ptfs-europe
| |.com
--- Comment #3 from Martin Renvoize ---
Bug 21626 changes the methodology for this omnibus somewhat moving the
maintenance of the team list into the release-tools repository used by the
maintenance team to produce release notes.
The hope is that the result will mean we only have to maintain such a list in
two places (the Wiki page and the release-tools repo) and then the list in Koha
itself is generated during release from the release tools.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 14:23:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 12:23:24 +0000
Subject: [Koha-bugs] [Bug 21662] Missing developers from history
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |m.de.rooy at rijksmuseum.nl
Status|Signed Off |BLOCKED
--- Comment #58 from Marcel de Rooy ---
QA: Looking here
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 14:28:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 12:28:31 +0000
Subject: [Koha-bugs] [Bug 21662] Missing developers from history
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662
--- Comment #59 from Marcel de Rooy ---
Yeah the number of commits in the yaml file is not correct
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 14:32:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 12:32:07 +0000
Subject: [Koha-bugs] [Bug 21662] Missing developers from history
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21662
--- Comment #60 from Marcel de Rooy ---
Could not compile /usr/share/koha/about.pl: Can't locate YAML/XS.pm in @INC
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 15:00:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 13:00:09 +0000
Subject: [Koha-bugs] [Bug 11529] Add subtitle,
medium and part fields to biblio table
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
--- Comment #187 from Katrin Fischer ---
1) RELEASE NOTES
- Removes the Koha to Keyword mappings
- Might cause change in behaviour for people having mappign fields outside of
245bhnp or UNIMARC equivalents
- Requires you to run misc/batchRebuildBiblioTables.pl to have 245bhnp
displayed
2) Template Toolkit Stash
I noticed some of the files use Stash. I haven't come across this so far. Can
you explain?
koha-tmpl/opac-tmpl/bootstrap/en/modules/opac-detail.tt
+[% USE Stash %]
Details for [% INCLUDE 'biblio-title.inc' biblio=Stash.stash() %]
This is a problem, because at the moment this is only used for debugging and
not marked as required in the Dependencies. Adding dependency tag to the bug.
3) SplitKohaField
I wonder if the use case warrants its own subroutine, it's only used in
a few places and for splitting a pipe separeted string into an array:
C4/Biblio.pm:sub SplitKohaField {
svc/checkouts: subtitle =>
C4::Biblio::SplitKohaField($c->{'subtitle'}),
svc/holds:use C4::Biblio qw(SplitKohaField);
svc/holds: subtitle =>
C4::Biblio::SplitKohaField($biblio->subtitle()),
4) Template variables
Right now the changes require a lot of new variables passed to the templates
and some older SQL methods to be extended to SELECT additional fields.
I wonder if instead of working with an INCLUDE working with a TT plugin
taking the biblionumber and querying would hurt performance much. It would
allow
us to remove quite a bit of code I think. Also I guess in the future working
with
a Record object might make things easier?
5) misc/batchRebuildBiblioTables.pl
I noticed that you removed the table locking. Is this safe?
6) Unrelated changes
Small one:
koha-tmpl/intranet-tmpl/prog/en/includes/biblio-view-menu.inc
And:
t/db_dependent/Biblio.t
- my $authorities_mod = Test::MockModule->new( 'C4::AuthoritiesMarc' );
+ my $authorities_mod = Test::MockModule->new( 'C4::Heading' );
7) Repeatable subfields np
Testing with: 245abhnpnp
Multiple np show as:
The C programming language / Zusatz Number | Number2 Part | Part2
Actually this is a deeper rabbit hole... as we don't keep the sequence we might
lose meaning here, but that would not have worked before.
Maybe this would make things a little easier?
http://template-toolkit.org/docs/manual/VMethods.html#method_split
8) Good news
- Removal of permission complete
- Removal of Koha to keywords feature complete
- Removal of GetRecordValue and Biblio:subtitles complete
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 15:08:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 13:08:21 +0000
Subject: [Koha-bugs] [Bug 22741] Second prove of Koha/Patrons.t fails on
test BorrowerLogs and TrackLastPatronActivity
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22741
--- Comment #7 from Jonathan Druart ---
Hi Marcel, what is the error you get?
How do you recreate the failure?
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 15:29:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 13:29:09 +0000
Subject: [Koha-bugs] [Bug 22741] Second prove of Koha/Patrons.t fails on
test BorrowerLogs and TrackLastPatronActivity
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22741
--- Comment #8 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #7)
> Hi Marcel, what is the error you get?
>
> How do you recreate the failure?
Running Koha/Patrons.t with perl twice no problem, but running with prove the
second time results in a failure. Sql mode ?
# Failed test 'With BorrowerLogs and TrackLastPatronActivity we should
not spam the logs'
# at t/db_dependent/Koha/Patrons.t line 1477.
# got: '2'
# expected: '1'
t/db_dependent/Koha/Patrons.t .. 31/39 # Looks like you failed 1 test of 4.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 15:33:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 13:33:49 +0000
Subject: [Koha-bugs] [Bug 5770] Email librarian when purchase suggestion made
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=2776
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 15:33:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 13:33:49 +0000
Subject: [Koha-bugs] [Bug 2776] emailPurchaseSuggestions system preference
deprecated
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=2776
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
See Also| |https://bugs.koha-community
| |.org/bugzilla3/show_bug.cgi
| |?id=5770
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 15:44:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 13:44:27 +0000
Subject: [Koha-bugs] [Bug 22713] Replacement price removed when receiving if
using MarcItemFieldstoOrder
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22713
robbinsk at middlesex.mass.edu changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |robbinsk at middlesex.mass.edu
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 15:47:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 13:47:22 +0000
Subject: [Koha-bugs] [Bug 21946] Group circulation by item type
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946
--- Comment #41 from Jonathan Druart ---
Forget that, I had the new version in mind (NULL in DB instead of '*').
At some point we really will need it (bug 15522) in I think, we will need to
stop building stuffs that will conflict with it.
Why not implement on top of it instead?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 15:51:39 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 13:51:39 +0000
Subject: [Koha-bugs] [Bug 22741] Second prove of Koha/Patrons.t fails on
test BorrowerLogs and TrackLastPatronActivity
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22741
--- Comment #9 from Jonathan Druart ---
I cannot recreate on a Jessie devbox.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 15:52:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 13:52:05 +0000
Subject: [Koha-bugs] [Bug 21946] Group circulation by item type
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21946
--- Comment #42 from Nick Clemens ---
(In reply to Jonathan Druart from comment #41)
> Forget that, I had the new version in mind (NULL in DB instead of '*').
> At some point we really will need it (bug 15522) in I think, we will need to
> stop building stuffs that will conflict with it.
> Why not implement on top of it instead?
I think that will need work at this point.
I believe the idea was to take care of the architecture, make sure it comes out
as we planned without any great changes in structure during QA etc. Then work
on the interface.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 15:54:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 13:54:35 +0000
Subject: [Koha-bugs] [Bug 22741] Second prove of Koha/Patrons.t fails on
test BorrowerLogs and TrackLastPatronActivity
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22741
--- Comment #10 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #9)
> I cannot recreate on a Jessie devbox.
Thx for testing. I tested with a debian stretch docker container. Will have a
look later..
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 16:00:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 14:00:54 +0000
Subject: [Koha-bugs] [Bug 22741] Second prove of Koha/Patrons.t fails on
test BorrowerLogs and TrackLastPatronActivity
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22741
--- Comment #11 from Jonathan Druart ---
Same on stretch.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 16:07:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 14:07:36 +0000
Subject: [Koha-bugs] [Bug 22820] New: Display 830 series information when
there is no 490 tag (MARC21)
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22820
Bug ID: 22820
Summary: Display 830 series information when there is no 490
tag (MARC21)
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: OPAC
Assignee: oleonard at myacpl.org
Reporter: joy at bywatersolutions.com
QA Contact: testopia at bugs.koha-community.org
Target Milestone: ---
Currently, the 830 tag will display only when the 490 tag is present and
indicator 1=1. It is possible to have a valid 830 tag without a corresponding
490 tag. We need to include logic in the stylesheet to display the 830 when no
490 is found.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 16:07:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 14:07:49 +0000
Subject: [Koha-bugs] [Bug 22820] Display 830 series information when there
is no 490 tag (MARC21)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22820
Joy Nelson changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|oleonard at myacpl.org |wizzyrea at gmail.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 17:07:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 15:07:22 +0000
Subject: [Koha-bugs] [Bug 22713] Replacement price removed when receiving if
using MarcItemFieldstoOrder
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22713
Liz Rea changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 17:07:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 15:07:25 +0000
Subject: [Koha-bugs] [Bug 22713] Replacement price removed when receiving if
using MarcItemFieldstoOrder
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22713
Liz Rea changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #88792|0 |1
is obsolete| |
--- Comment #2 from Liz Rea ---
Created attachment 89187
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89187&action=edit
Bug 22713: Pass replacement price in to order if defined by
MarcItemFieldsToOrder
To test:
1 - Have AcqCreateItems set to 'On ordering' (or set in a basket)
2 - Define MARCItemFieldsToOrder
homebranch: 975$a
holdingbranch: 975$b
itype: 975$y
nonpublic_note: 975$x
public_note: 975$z
loc: 975$c
ccode: 970$c
notforloan: 975$7
uri: 975$u
copyno: 975$n
quantity: 975$q
budget_code: 975$h
price: 975$g
replacementprice: 975$p
3 - Have a marc record with some order info defined as above, including a
replacementprice
4 - Add to basket - > from a new file
5 - Don't check for duplicates, add the order
6 - Note the order has no replacementprice, but the item does
7 - Close basket, receive order, do not enter a new replacement price
8 - Note the items replacement price is clear
9 - Apply patch
10 - Repeat
11 - Note when order added to basket it has a replacement price
12 - Note when order is received the replacement price is populated and passed
into item correctly
Signed-off-by: Liz Rea
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 17:31:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 15:31:48 +0000
Subject: [Koha-bugs] [Bug 22821] New: Patron notes about item email
notification fallback order is incorrect
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821
Bug ID: 22821
Summary: Patron notes about item email notification fallback
order is incorrect
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: OPAC
Assignee: oleonard at myacpl.org
Reporter: martin.renvoize at ptfs-europe.com
QA Contact: testopia at bugs.koha-community.org
Target Milestone: ---
In bug 19496 a fallback order for the email addresses (both to and from) was
added. This fallback order appears to be incorrect per my understanding of the
system preferences.
> my $to_address = $branch->branchemail || $branch->branchreplyto || C4::Context->ReplytoDefault || C4::Context->preference('KohaAdminEmailAddress');
My understanding is that branchemail is used for the 'from' address in emails
from the branch, however it may not be an address which is accessible by the
librarians (as to be allowed through spam filters for most popular email
service the 'from' address domain has to match the domain of the sender
server).. as such 'reply-to' address was added to allow for a library to send
'from' a proper domain but have 'replies' go to an email address they control.
> my $from_address = $patron->email || $patron->emailpro || $patron->B_email;
We cannot spoof send emails from the patrons email address for the same reasons
as outlined above. The email must come from the koha system but may happily
contain the above fallback in the reply-to header to achieve what I believe is
wanted.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 17:32:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 15:32:29 +0000
Subject: [Koha-bugs] [Bug 19496] Patron notes about item does not get
emailed as indicated
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19496
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |martin.renvoize at ptfs-europe
| |.com
--- Comment #15 from Martin Renvoize ---
This looks incorrect to me with regards to how email preference fallbacks
should work.
I'm going to open another bug to clarify - bug 22821
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 17:32:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 15:32:46 +0000
Subject: [Koha-bugs] [Bug 19496] Patron notes about item does not get
emailed as indicated
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19496
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |22821
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821
[Bug 22821] Patron notes about item email notification fallback order is
incorrect
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 17:32:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 15:32:46 +0000
Subject: [Koha-bugs] [Bug 22821] Patron notes about item email notification
fallback order is incorrect
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |19496
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19496
[Bug 19496] Patron notes about item does not get emailed as indicated
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 17:35:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 15:35:29 +0000
Subject: [Koha-bugs] [Bug 22821] Patron notes about item email notification
fallback order is incorrect
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |chris at bigballofwax.co.nz
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 17:35:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 15:35:17 +0000
Subject: [Koha-bugs] [Bug 22821] Patron notes about item email notification
fallback order is incorrect
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22821
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 17:38:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 15:38:00 +0000
Subject: [Koha-bugs] [Bug 22822] New: Better Circulation Rules
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22822
Bug ID: 22822
Summary: Better Circulation Rules
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Circulation
Assignee: koha-bugs at lists.koha-community.org
Reporter: cbrannon at cdalibrary.org
QA Contact: testopia at bugs.koha-community.org
CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com
Target Milestone: ---
IMO, Circulation Rules would be a bit easier to manage if they were not defined
library by library, but instead by Rule Sets, in which you could assign any
number of libraries. If a library is assigned to a set, the library is greyed
out from selection in other rules. If a library isn't assigned, it goes by the
default set.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 20:03:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 18:03:46 +0000
Subject: [Koha-bugs] [Bug 5770] Email librarian when purchase suggestion made
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #89144|0 |1
is obsolete| |
--- Comment #30 from Martin Renvoize ---
Created attachment 89188
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89188&action=edit
Bug 5770: Email librarian when purchase suggestion made
Signed-off-by: Liz Rea
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 20:03:50 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 18:03:50 +0000
Subject: [Koha-bugs] [Bug 5770] Email librarian when purchase suggestion made
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #89145|0 |1
is obsolete| |
--- Comment #31 from Martin Renvoize ---
Created attachment 89189
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89189&action=edit
Bug 5770: New system pref for new suggestion email
Signed-off-by: Liz Rea
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 20:03:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 18:03:54 +0000
Subject: [Koha-bugs] [Bug 5770] Email librarian when purchase suggestion made
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #89146|0 |1
is obsolete| |
--- Comment #32 from Martin Renvoize ---
Created attachment 89190
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89190&action=edit
Bug 5770: Unit test
Signed-off-by: Liz Rea
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 20:03:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 18:03:58 +0000
Subject: [Koha-bugs] [Bug 5770] Email librarian when purchase suggestion made
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #89147|0 |1
is obsolete| |
--- Comment #33 from Martin Renvoize ---
Created attachment 89191
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89191&action=edit
Bug 5770: Notify for new suggestion - sample notices
Signed-off-by: Liz Rea
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 20:04:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 18:04:01 +0000
Subject: [Koha-bugs] [Bug 5770] Email librarian when purchase suggestion made
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770
--- Comment #34 from Martin Renvoize ---
Created attachment 89192
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89192&action=edit
Bug 5770: (QA follow-up) Allow feature to be disable
This patch adds 'None' to the available options for the feature so it
may be disabled entirely (and sets that as default)
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 20:04:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 18:04:05 +0000
Subject: [Koha-bugs] [Bug 5770] Email librarian when purchase suggestion made
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770
--- Comment #35 from Martin Renvoize ---
Created attachment 89193
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89193&action=edit
Bug 5770: (QA follow-up) Revert change to GetQueuedMessages
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 20:04:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 18:04:09 +0000
Subject: [Koha-bugs] [Bug 5770] Email librarian when purchase suggestion made
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770
--- Comment #36 from Martin Renvoize ---
Created attachment 89194
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89194&action=edit
Bug 5770: (QA follow-up) Move system preference to appropriate section
The new sysprefs wher in the general admin section. I believe they are
better placed within the acquisitions area.
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 20:04:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 18:04:12 +0000
Subject: [Koha-bugs] [Bug 5770] Email librarian when purchase suggestion made
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770
--- Comment #37 from Martin Renvoize ---
Created attachment 89195
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89195&action=edit
Bug 5770: (QA follow-up) Adapt for replyto handling
The ReplyTo preferences allwo for libraries to setup various
combinations of addresses for email headers to ensure correct mail
delivery. This patch accounts for their configuration and use in the
suggestions notifications
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 20:05:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 18:05:10 +0000
Subject: [Koha-bugs] [Bug 5770] Email librarian when purchase suggestion made
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--- Comment #38 from Martin Renvoize ---
Right, I'm not confident in this bug.. Passing QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 20:24:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 18:24:11 +0000
Subject: [Koha-bugs] [Bug 5770] Email librarian when purchase suggestion made
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |Manual
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 20:26:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 18:26:04 +0000
Subject: [Koha-bugs] [Bug 5770] Email librarian when purchase suggestion made
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Text to go in the| |The new feature adds the
release notes| |ability to send a new
| |notice to the library,
| |branch or a specific email
| |address whenever a purchase
| |suggestion is created.
Severity|enhancement |new feature
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 20:47:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 18:47:31 +0000
Subject: [Koha-bugs] [Bug 5770] Email librarian when purchase suggestion made
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770
--- Comment #39 from Katrin Fischer ---
no(In reply to Martin Renvoize from comment #38)
> Right, I'm not confident in this bug.. Passing QA
not = now?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 22:49:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 20:49:59 +0000
Subject: [Koha-bugs] [Bug 15260] Option for extended loan with useDaysMode
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260
--- Comment #21 from Liz Rea ---
Thank the unit tests :)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 23:06:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 21:06:30 +0000
Subject: [Koha-bugs] [Bug 5770] Email librarian when purchase suggestion made
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5770
--- Comment #40 from Martin Renvoize ---
Grr, silly typo.. Now! :)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Wed May 1 23:28:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 21:28:45 +0000
Subject: [Koha-bugs] [Bug 22820] Display 830 series information when there
is no 490 tag (MARC21)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22820
Hannah Olsen changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |holsen at duncanville.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 2 00:51:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 22:51:04 +0000
Subject: [Koha-bugs] [Bug 21651] Force insert of notices related tables
during the install process
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21651
Hayley Mapley changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |hayleymapley at catalyst.net.n
| |z
--- Comment #8 from Hayley Mapley ---
Created attachment 89196
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89196&action=edit
Screenshot of error trace
Hi Jonathan,
When testing this and installing all Optional data in English, I got to the end
of the onboarding with no issues and then logged in which led me straight into
an error trace. The issue was with DateUtils, it looked like it was an issue
with the sample news items. I took a screenshot of the Error trace which I'm
attaching. This didn't happen when I tried the same process on master.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 2 00:51:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Wed, 01 May 2019 22:51:36 +0000
Subject: [Koha-bugs] [Bug 21651] Force insert of notices related tables
during the install process
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21651
Hayley Mapley changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 2 02:12:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 May 2019 00:12:06 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662
--- Comment #273 from David Cook ---
(In reply to Mirko Tietgen from comment #272)
> I applied the patches, created a request, tested it ok, submitted and then ?
> nothing happens. "OAI-PMH harvester offline"
> Is there something else I have to do?
>
Thanks for taking a look at this, Mirko!
You might want to take a look at
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662#c198.
I'm not 100% sure what you've done so far, but basically you need to start up
the OAI-PMH harvester daemon, which runs the code that does the real heavy
lifting.
> I can't choose "Record type: Authorities", is that intentional?
>
Yeah, at this point I've only built in support for bibliographic records. In
theory, authorities should be easy enough, but I can see people trying to
download both bibliographic and authority records from a different system and
expecting them to stay linked, which they won't, so that's a problem for
another day...
> I manually installed libpoe-perl and libpoe-component-jobqueue-perl. Are
> there other dependencies I mossed?
It sounds like you've got the code dependencies but you'll need to set up the
harvester daemon and run it as per
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662#c198.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 2 02:12:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 May 2019 00:12:56 +0000
Subject: [Koha-bugs] [Bug 10662] Build OAI-PMH Harvesting Client
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10662
--- Comment #274 from David Cook ---
And thanks again, Mirko!
I really wish that I had time to work on the tests right now, but I don't.
Already burning the candle at both ends...
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 2 02:15:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 May 2019 00:15:36 +0000
Subject: [Koha-bugs] [Bug 21872] Elasticsearch indexing faster by making it
multi-threaded
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21872
--- Comment #70 from David Cook ---
(In reply to Ere Maijala from comment #62)
> On a second thought, I'd leave lock file out. Unlike rebuild_zebra, there's
> normally only need to run rebuild_elasticsearch manually. If you need to
> e.g. cron it for some reason, an external locking mechanism can be used.
> Also, you may want to rebuild authorities and biblios side by side, and lock
> file would just complicate that.
Mmm that's a good point. Yeah, I'll withdraw my concern about it as well in
that case.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Thu May 2 03:50:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 02 May 2019 01:50:43 +0000
Subject: [Koha-bugs] [Bug 19302] Pass objects to
IsAvailableForItemLevelRequest
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19302
Hayley Mapley changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #88987|0 |1
is obsolete| |
--- Comment #12 from Hayley Mapley ---
Created attachment 89197
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89197&action=edit
Bug 19302: Send koha::objects to C4::Reserves::IsAvailableForItemLevelRequest
Almost everywhere we call IsAvailableForItemLevelRequest we already have
a Koha::Patron and Koha::Item object. It makes sense to use them to
avoid a refetch
Test plan:
It would be good to test this patch on top of 19300 and 19301 and make
sure everything works as expected
Signed-off-by: Hayley Mapley