[Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529

--- Comment #202 from Ere Maijala <ere.maijala at helsinki.fi> ---
(In reply to Katrin Fischer from comment #187)

Thanks, Katrin. Comments below.

> 1) RELEASE NOTES
> 
> - Removes the Koha to Keyword mappings
> - Might cause change in behaviour for people having mappign fields outside
> of 245bhnp or UNIMARC equivalents
> - Requires you to run misc/batchRebuildBiblioTables.pl to have 245bhnp
> displayed

Do you want me to clarify these in the proposed release notes?

> 2) Template Toolkit Stash
> 
> I noticed some of the files use Stash. I haven't come across this so far.
> Can you explain?

Ah, I didn't notice it's only for development. I just used it to collect all
the template params to a hash, but changed the code to pass biblio to the
template in one case (the other actually already had it).

> 3) SplitKohaField
>  
> I wonder if the use case warrants its own subroutine, it's only used in
> a few places and for splitting a pipe separeted string into an array:

You're right. Now removed.

> 4) Template variables
> 
> Right now the changes require a lot of new variables passed to the templates
> and some older SQL methods to be extended to SELECT additional fields.
> I wonder if instead of working with an INCLUDE working with a TT plugin 
> taking the biblionumber and querying would hurt performance much. It would
> allow
> us to remove quite a bit of code I think. Also I guess in the future working
> with
> a Record object might make things easier?

It's true, but the primary aim was to improve performance, and while fetching
the data for a single record is not that bad, it's not optimal either, and when
there's a list of records of any kind it can be significant. In some cases we
could just pass the biblio object instead of select pieces of it, but I feel
that's something that could be addressed in a follow-up issue, since this is
usually just extending the existing practice.

> 5) misc/batchRebuildBiblioTables.pl
> 
> I noticed that you removed the table locking. Is this safe?

It was only commented-out code that I cleaned up.

> 6) Unrelated changes

Fixed.

> 7) Repeatable subfields np
> 
> Testing with: 245abhnpnp
> Multiple np show as: 
> The C programming language / Zusatz Number | Number2 Part | Part2 
> 
> Actually this is a deeper rabbit hole... as we don't keep the sequence we
> might lose meaning here, but that would not have worked before.

I made the templates handle repeated fields a bit better. At least I think they
would normally be interleaved, and that's how they're now displayed. It's
perhaps still not perfect, but at least it works properly with ISBD
punctuation, and further tweaks are easy to add later as necessary.

Please note that qa-test-tools is not happy about the WHILE statement in the
biblio-title* templates, but that seems to be a spurious error.

-- 
You are receiving this mail because:
You are watching all bug changes.