[Koha-bugs] [Bug 22832] New: Require plugins to specify the methods they implement

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu May 2 17:43:31 CEST 2019


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22832

            Bug ID: 22832
           Summary: Require plugins to specify the methods they implement
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: tomascohen at gmail.com
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

With bug 21073, a simple plugin implementing (say) only the to_marc method
generates this on the DB:

mysql> SELECT * FROM plugin_methods;
+-----------------------------------------------+-------------------------------+
| plugin_class                                  | plugin_method                
|
+-----------------------------------------------+-------------------------------+
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | _handle_control_field        
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | _version_compare             
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | abs_path                     
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | as_heavy                     
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | canonpath                    
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | catdir                       
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | catfile                      
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | configure                    
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | curdir                       
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | except                       
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | export                       
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | export_fail                  
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | export_ok_tags               
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | export_tags                  
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | export_to_level              
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | file_name_is_absolute        
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | get_metadata                 
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | get_plugin_http_path         
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | get_qualified_table_name     
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | get_template                 
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | go_home                      
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | import                       
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | install                      
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | max                          
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | mbf_dir                      
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | mbf_exists                   
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | mbf_open                     
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | mbf_path                     
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | mbf_read                     
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | mbf_validate                 
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | new                          
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | no_upwards                   
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | only                         
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | output                       
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | output_html                  
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | output_html_with_http_headers
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | output_with_http_headers     
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | path                         
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | plugins                      
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | require_version              
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | retrieve_data                
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | rootdir                      
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | search_path                  
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | store_data                   
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | to_marc                      
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | uninstall                    
|
| Koha::Plugin::Com::ByWaterSolutions::CSV2MARC | updir                        
|
+-----------------------------------------------+-------------------------------+
47 rows in set (0.00 sec)

I think plugins should just expose what methods they implement that are
intended to be used in Koha, not any internal method.

-- 
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.


More information about the Koha-bugs mailing list