[Koha-bugs] [Bug 22837] New: Koha::Account::Line->apply should not require a 'set' of debits

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22837

            Bug ID: 22837
           Summary: Koha::Account::Line->apply should not require a 'set'
                    of debits
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: enhancement
          Priority: P5 - low
         Component: Architecture, internals, and plumbing
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: martin.renvoize at ptfs-europe.com
        QA Contact: testopia at bugs.koha-community.org
  Target Milestone: ---

As it stands the apply method in Koha::Account::Line requires a Koha::Account
resultset to be passed in as the list of debits to be applied against.  This is
suboptimal when the method is often required to apply against the results of a
Koha::Account::Line->find (single not set) as one needs to rework the query.

We should accept an arrayref of results rather than requiring a resultset as
converting from a set to an arrayref is simple (->as_list), but converting for
a single record up to a set is considerably more challenging (both coding wise
and DB hits wise).

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.