[Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #42 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Quick review:

1. ->can_edit_item
    if ( C4::Context->preference('IndependentBranches') ) {
        return $userenv->{branch} eq $branchcode;
    }    

We certainly want to handle non-existing $userenv


2. On update, should not we set edit_any_item for patrons who where already
allowed to edit items?

3. on /cataloguing/additem.pl, the whole dropdown list (edit, delete, print,
etc.) is not displayed, I would expect to see some of them

4. You can add items to other libraries but then you cannot longer edit them?
Maybe add and update should be impacted by this change?

5. Restriction is only done at template level (at least for batchMod), there
should be a low level exception raised if the logged in user is trying to
edit/delete (add?) an item outside of their group.

-- 
You are receiving this mail because:
You are watching all bug changes.