[Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Thu May 9 12:33:45 CEST 2019


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610

--- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
Right, 

I've gotten to the bottom of this.. it's tester error :).. man SIP is 'fun' to
test.

So, I tested with:

perl misc/sip_cli_emulator.pl --sip_user=staff --sip_pass=staff --patron=dir
--fee-identifier=697 --fee-amount=0.50 --payment-type=02 -m fee_paid -a
127.0.0.1 -p 6001 -l MAIN

Note the 'payment-type' as apposed to 'fee-type' used in your version.. to be
entirely honest I have no idea what fee-type is used for here.. I would suggest
it's not for payment but for creation of new fee's only?

Anywho.. the code does appear to work as expected (defaulting to 'Cash' when no
payment-type is specified, but using the payment type if one is).

Just about to upload a Unit test now too.

Thanks again for testing Liz :)

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list