[Koha-bugs] [Bug 22761] Move "Fee receipt" from template to a slip

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22761

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #38 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
Some notes about this:
1. The TT content has been moved but without being adjusted.
For instance:
- Should not we use library.branchname instead of LibraryName (otherwise we
will have to pass 'LibraryName' to all our templates)?
- Branches.GetName( patron.branchcode ), should not we prefer
patron.library.branchname?

If we do not know what is sent/used in the template, it will be a nightmare to
provide backward compatibility in next versions.

2. About evaltt, I really do not understand why we need it, the template has
been parsed already, we should not need to parse it again, I think the content
must be  displayed with $raw

3. +    library     => C4::Context::mybranch,
so library will be the branchcode, whereas we are expecting a Koha::Library
object

(In reply to Kyle M Hall from comment #29)
> > > ::: members/printfeercpt.pl
> > > @@ +83,2 @@
> > > >  
> > > >  $template->param(
> > > 
> > > There are more parameters than before, I would expect less.
> > > Is that correct?
> There are more parameters because I made the slip compatible with the
> existing syntax for the ACCOUNT_PAYMENT/ACCOUNT_WRITEOFF slips.

I am sorry but I still do not understand that part. The variable we do not see
in the template will not be used, so for instance 'credit' is useless.

-- 
You are receiving this mail because:
You are watching all bug changes.