[Koha-bugs] [Bug 22849] Data shared without agreement

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22849

Liz Rea <wizzyrea at gmail.com> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
  Attachment #89355|0                           |1
        is obsolete|                            |

--- Comment #3 from Liz Rea <wizzyrea at gmail.com> ---
Created attachment 89577
  -->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=89577&action=edit
Bug 22849: Do not share data (Mana) without agreement

A couple of things wrong in serials/subscription-add.pl

1.
447     if ( defined( $query->param('mana_id') ) ) {

It's always defined, you wanted to test with ""

2.
375     if ( (C4::Context->preference('Mana')) and ( grep { $_ eq
"subscription" } split(/,/, C4::Context->preference('AutoShareWithMana'))) ){

Mana == 2 == let me think about it
=> I am not expecting to reach Koha::SharedContent in that case

So we are sharing data whereas the library did not decide yet!

Test plan:
You need to be familiar you Mana to test this patch.

JD: I did not test this patch

Signed-off-by: Liz Rea <wizzyrea at gmail.com>
Tested this, adding subscription still works, mana seems not to be queried.
tested on top of 22812.

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.