[Koha-bugs] [Bug 14723] Additional delivery notes to messages

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14723

--- Comment #32 from Katrin Fischer <katrin.fischer at bsz-bw.de> ---
Comment on attachment 87531
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=87531
Bug 14723: Additional delivery notes to messages

Review of attachment 87531:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=14723&attachment=87531)
-----------------------------------------------------------------

I took another look at the code and Joseph is right. Made some additional notes
too.

::: C4/Letters.pm
@@ +912,2 @@
>  VALUES
> +( ?,              ?,       ?,       ?,        ?,           ?,                      ?,      NOW(),       ?,          ?,            ?,            ? )

I think NOW() might be a MySQLism from my research.

@@ +1281,5 @@
>              # warn "FAIL: No 'to_address' and no email for " . ($member->{surname} ||'') . ", borrowernumber ($message->{borrowernumber})";
>              # warning too verbose for this more common case?
>              _set_message_status( { message_id => $message->{'message_id'},
> +                                   status     => 'failed',
> +                                   delivery_note => 'Unable to find an email address for this borrower' } );

See above, these need to be dealt with in the template.

:::
installer/data/mysql/atomicupdate/Bug-14723_-_Additional_delivery_notes_to_messages.perl
@@ +1,3 @@
> +$DBversion = 'XXX';  # will be replaced by the RM
> +if( CheckVersion( $DBversion ) ) {
> +    $dbh->do("ALTER TABLE message_queue ADD delivery_note TEXT");

Please use BEFORE or AFTER column to specify where the new column will be added
exactly. This will help to keep things the same between new and old
installations.

-- 
You are receiving this mail because:
You are watching all bug changes.