[Koha-bugs] [Bug 22880] Convert opacheader system preference to news block

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22880

--- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Katrin Fischer from comment #3)
> Argument "" isn't numeric in numeric gt (>) at
> /home/vagrant/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/includes/
> html_helpers.inc line 23.
> Argument "" isn't numeric in numeric gt (>) at
> /home/vagrant/kohaclone/koha-tmpl/opac-tmpl/bootstrap/en/includes/
> html_helpers.inc line 23.
> 
> This means that there are warnings with this script, but they are the same
> with and without your patch - so no blocker.
> 
>    FAIL	  valid_template
> 		koha_news_block: not found
> 
> I think this is a false positive. I think may the script doesn't manage the
> PROCESS and the BLOCK being in different files as it's here with the .inc

Yes it is a false positive. html_helpers.inc is processed in doc-head-close, so
we are good.

-- 
You are receiving this mail because:
You are watching all bug changes.