[Koha-bugs] [Bug 13640] Holds To Pull List includes items unreserveable items

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13640

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org

--- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Magnus Enger from comment #9)
> What is changed compared to the "Holds to pull" SQL are these two lines:
> 
> - LEFT JOIN default_branch_item_rules ON
> items.itype=default_branch_item_rules.itemtype
> - AND default_branch_item_rules.holdallowed != 0

This seems to fix the issue.

> However, default_branch_item_rules.holdallowed is of the "bit" type:
> http://schema.koha-community.org/18_05/tables/default_branch_item_rules.html
> I gotta confess I'm not familiar with that. Any special tricks to consider?
> When I look in the database, the value of that column is 0 or 2. Why not a
> boolean "0 or 1" value?

Because there are 3 values: From any library, From home library and not allowed
(0)

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.