[Koha-bugs] [Bug 22284] Groups of pickup locations for holds

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

--- Comment #126 from Agustín Moyano <agustinmoyano at theke.io> ---
(In reply to Liz Rea from comment #125)
> Hi Agustin,
> 
> Thanks for updating your patches, I've had a look over them and the
> behaviour seems better to me. I'm willing to sign this off, but I'd really
> like for VOKAL to test it with their real-life requirements and scenarios in
> mind - I'm not with that institution and I can't purport to speak to their
> functional requirements.
> 
> I've approached Joy at ByWater to see if she can arrange a testing setup for
> them with this patchset, hopefully we'll hear something soon about that - I
> know how frustrating it is to endlessly rebase. 
> 
> Note to QA: I haven't attached signed off patches, pending VOKAL's
> testing/comments. Let me know if you'd like me to do something differently.
> 
> The dev itself looks solid, passes the QA scripts and all of your new tests
> are passing. The functionality seems good so far as I can see, thank you for
> all of that and nice job!
> 
> Liz

Hello Liz, thanks for letting me know.

I won't touch this bug untill we've got feedback from VOKAL, but I can't help
thinking on how ReserveControlBranch and HomeOrHolding preferences interact
with each other.

I think maybe (please correct me if I'm wrong) they work in the following way

ReserveControlBranch tell's you which circulation rules should be applied.. for
example:

We got two libraries: Franklin and Centerville

We got a patron from Franklin that want's to place a hold on an item from
Centerville, so if ReserveControlBranch is set to patron's home library, we
should use Franklin's rules.. else we should use Centerville's rules.. 

So, in this example:
1. If ReserveControlBranch is set to "patron's home library", and Franklin has
a rule of "home library" the hold wouldn't be allowed. 
2. If ReserveControlBranch is set to "item's home library" and Centerville has
a rule of "any library" the hold would be allowed.

Now for HomeOrHolding, I think this tell's you to which library it should be
compared when checking the item.. so let's suppose in this same example that
the item has as home library Centerville, but as holding library Franklin.. 

If ReserveControlBranch is set to "patron's home library" (and Franklin still
has a rule of "home library")
1. If HomeOrHolding is set to "home", the hold would not be allowed
2. If HomeOrHolding is set to "holding", in this case hold would be allowed,
because we would be comparing patron's home library with items holding library.

What makes some noise to me, is that the rule name says "From home library", so
maybe HomeOrHolding really doesn't apply at all, and we should always check for
home library.

Other thing I'm not sure is, let's suppose ReserveControBranch is set to
"item's home library", should HomeOrHolding affect also which rule should we
use?.. I mean, using the same example, if HomeOrHolding is set to "home", we
should use Centerville's rules, else we shoul use Franklin's rules?... of
course, if HomeOrHolding doesn't apply at all, this question has no sense also.

Sorry for spitting all this out.. 

Agustín

-- 
You are receiving this mail because:
You are watching all bug changes.