[Koha-bugs] [Bug 14407] Limit web-based self-checkout to specific IP addresses

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14407

--- Comment #78 from David Cook <dcook at prosentient.com.au> ---
Actually, looking at "sub in_ipset" again, I'd also invert the logic, so that
the default return value is 0.

That way, if you've misconfigured the value of $ipset, you're not going to
accidentally return 1. 

Also, using $ENV{'REMOTE_ADDR'} won't work properly if you're using a reverse
proxy. I don't know how we handle this with Plack, but for CGI users running
behind reverse proxies, there's no way this is going to work correctly.

-- 
You are receiving this mail because:
You are watching all bug changes.