[Koha-bugs] [Bug 22644] Some tests in Upload.t are not testing the right thing

bugzilla-daemon at bugs.koha-community.org bugzilla-daemon at bugs.koha-community.org
Wed May 22 15:21:48 CEST 2019


https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22644

--- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
The test reflects the history of Upload to Uploader and UploadedFile(s) with
Koha::Object(s). 
I think we should put the Uploader stuff into its own test Uploader.t. And put
all Koha objects related tests to UploadedFile.t.
What UploadedFile::delete may need, is a return code: deleting the record may
have failed, but deleting the file as well.
The test could be improved by adding some temporary files.
And we need some decisions on 22508 as well. See my older comment there.
Especially, do we copy the file or keep just one and allow direct access to
selected subdirs of the clone upload folder?

-- 
You are receiving this mail because:
You are watching all bug changes.


More information about the Koha-bugs mailing list