[Koha-bugs] [Bug 22907] Cannot add new suggestion with strict SQL modes turned on

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22907

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Failed QA

--- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
I am having trouble understanding what you do here and why you do it:
--- a/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/newordersuggestion.tt
+++ b/koha-tmpl/intranet-tmpl/prog/en/modules/acqui/newordersuggestion.tt
@@ -107,14 +107,19 @@
     $(document).ready(function() {
         var suggestionst = $("#suggestionst").dataTable($.extend(true, {},
dataTablesDefaults, {
             "aoColumnDefs": [
-                { "aTargets": [ 0 ],  "bVisible": false, "bSearchable": true
}, // must be searchable for fnFilter
+                { "aTargets": [ 0 ],  "bVisible": false, "bSearchable": false
},
                 { "aTargets": [ -1 ], "bSortable": false, "bSearchable": false
},
             ],
             "sPaginationType": "four_button"
         }));
         $("#show_only_mine").on('click', function(e){
             e.preventDefault();
+            //suggestionst.settings()[0].aoColumns[index].bSearchable = true;
+            suggestionst.setColumnSearchable(0, true);
+            suggestionst.rows().invalidate();
             suggestionst.fnFilter('^[% loggedinuser | html %]$', 0, true);
+            suggestionst.setColumnSearchable(0, false);
+            suggestionst.rows().invalidate();

This is not about adding a new suggestion but is about adding an order from an
accepted suggestion.
The form newordersuggestion has some problems in current master with and
without your patch. The fnFilter on borrowernumber (only mine) does not seem to
work at all..
It seems unrelated to the problem you are solving on this report.

-- 
You are receiving this mail because:
You are watching all bug changes.