[Koha-bugs] [Bug 22508] Add the ability to prefill 856$u with the direct URL of the file

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22508

--- Comment #39 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Marcel de Rooy from comment #37)
> (In reply to Jonathan Druart from comment #33)
> > (In reply to Marcel de Rooy from comment #28)
> > > > tools/upload-file.pl:
> > > > 
> > > > # FIXME The copy must be done in Koha::Uploader, but where?
> > > > # I (Joubu) did not find a place where the file was completely written
> > > 
> > > Look at Uploader sub cgi when it calls sub _done. The file is written in
> > > _hook. So you should be in _done.
> > 
> > I have tried _done, but it did not work. I cannot remember exactly why but
> > IIRC it was not called when needed. I will have another look later.
> 
> I feel that we should not touch Uploader after all. Maybe we should just
> keep one file and allow (by default) direct access to a *public*
> subdirectory of uploads? Probably allowing subdirs as well there. Maybe pref
> controlled (nothing better than adding yet another one)..

Are you suggesting I should rewrite the whole patch and rethink the approach? I
am not sure I understand exactly what you meant by "just keep one file and
allow (by default) direct access to a *public* subdirectory of uploads"

-- 
You are receiving this mail because:
You are watching all bug changes.