[Koha-bugs] [Bug 22284] Groups of pickup locations for holds

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284

--- Comment #136 from Agustín Moyano <agustinmoyano at theke.io> ---
Ok, I can see this bug just became a big mess (this comment is going to be
number 137!).. To spare those of you, brave enough to test this, I'll try to
make a unified test plan

To test:
1) Apply all patches (including dependencies)
2) perl installer/data/mysql/updatedatabase.pl
3) dbic 

## Library groups ##
# new checkbox option 'Is local hold group' on root groups

4) In intranet go to Library groups in admin module
5) Add new root group
SUCCESS => a new 'Is local hold group' checkbox appears
6) Select 'Is local hold group' and save
7) Click edit button for root group
SUCCESS => 'Is local hold group' is checked

## smart-rules ##
# new options for 'Hold policy' and 'Hold fulfillment policy'

8) Go to 'Circulation and fines rules' in admin
SUCCESS => in 'Hold policy' you should see 'From local hold group' option, and
in 'Hold pickup library match' you should see "Item's hold group" and "Patron's
hold group" new options.
9) Select any of those options and save
SUCCESS => options should be selected when page reloads

## pickup_locations ##
# modified algorithm for obtaining pickup_locations

10) intranet: in Library groups, add 2 root groups marked as local hold group
and add different libraries to each.
11) opac: login as a user of a library belonging to one hold group, and search
try to place a hold on an item belongin to the other hold group.
12) intranet: in Circulation and fines rules, play with 'Hold policy' and 'Hold
pickup library match' rules.
13) opac: On each modification of the rules reload the page.
SUCCESS => Every time you reload the page, the number of pickup locations
showed in select varies.

## reserve/request.tt ##
# new message and column in 'Place a hold on a specific item' table and
filtered pickup select

14) In 'Circulation and fines rules', in 'Default checkout, hold and return
policy', in 'Hold policy' change the value to 'From local hold group' and 'Hold
pickup library match' to 'any'
15) Search a patron from a library not belonging to any holdgroup of step 10,
select one and click 'search to hold'
16) Search by location for items in any library of step 10
17) On any item, clic on 'Place hold for ...'
SUCCESS => when the page is loaded, in the 'Place a hold on a specific item'
table, you should see the message "Cannot place hold from patrons's library" in
'Hold' column
        => You should see a new column called "Allowed pickup locations" and
the message is "Any library"
        => Item's pickup locations select should have all libraries
18) In 'Circulation and fines rules', in 'Default checkout, hold and return
policy', in 'Hold policy' change the value again to 'From any library' and
change 'Hold pickup library match' to "Item's hold group"
19) Repeat steps 15 to 17
SUCCESS => when the page is loaded, you should see the "Pickup at" select
filtered by libraries in hold group
        => You should see in "Allowed pickup locations" a coma separated list
of the libraries in item's hold group
        => If biblio has an item whose control branch is not in a hold group,
you should see the control branch name in "Allowed pickup locations"
        => Item's pickup location select is filtered by allowed pickup
locations


## Tests ##

20) prove t/db_dependent/Holds.t
21) prove t/db_dependent/Koha/Biblios.t
22) prove t/db_dependent/Koha/Items.t
23) prove t/db_dependent/Koha/Libraries.t
24) prove t/db_dependent/LibraryGroups.t

## Finally (\o/ hurray!!)

25) Sing off patches!

-- 
You are receiving this mail because:
You are watching all bug changes.