From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 00:03:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2019 23:03:25 +0000
Subject: [Koha-bugs] [Bug 23914] Hea - share the DBMS (name and version)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23914
--- Comment #8 from Katrin Fischer ---
... meaning I think we as a community agreed on working towards supporting
other RDBMS like Postgres and if we want to change direction, we need to have a
discussion as a community. But I think it was one of the main selling points of
DBIx::Class
(https://wiki.koha-community.org/wiki/RFC_for_using_DBIx_Class_in_Koha). And
now I will stop derailing this bug.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 00:10:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2019 23:10:48 +0000
Subject: [Koha-bugs] [Bug 23805] Add a dedicated credit_types table
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805
--- Comment #51 from Katrin Fischer ---
I am really unhappy about this tbh - we are introducing database specific
things. Pretty new to the RDBMS too if I under understand Julian's comment on
bug 23914 correctly and with different syntax already for the 2 RDBMS we
support atm. We had agreed on not using MysqlIsms as a community and we should
have discussed this... Is it really worth it? Do we need this check so
urgently and can't solve this in another way?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 00:28:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Thu, 31 Oct 2019 23:28:14 +0000
Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084
--- Comment #42 from Nightly Build Bot ---
Created attachment 94933
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94933&action=edit
Bug 17084- Automatic debian/control updates (unstable/master)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 06:43:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 05:43:17 +0000
Subject: [Koha-bugs] [Bug 23805] Add a dedicated credit_types table
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805
--- Comment #52 from Martin Renvoize ---
Check constraints are not a mysqlism and have been in mariadb since 4 Jul 2016,
postgres since before 2001-08-15.. they're not be thing.
I will remove the constraint if people are really that anti having consistent
data. It really is a "do no harm" feature, I don't see why people are getting
so sound up about it. The database update threw a warning but carried on and
didn't break anything.. you just ended up without the constraint.
If we bring this silly about supported systems we should be removing the entire
restful API in my mmm opinion as mojolicious is far less easily packaged,
faster moving and unstable.
I've said my piece.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 07:20:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 06:20:15 +0000
Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084
--- Comment #43 from Martin Renvoize ---
Latest pushed to 19.11.x
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 07:20:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 06:20:25 +0000
Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #94933|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 07:25:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 06:25:33 +0000
Subject: [Koha-bugs] [Bug 23805] Add a dedicated credit_types table
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805
--- Comment #53 from Martin Renvoize ---
As a final note, there has been a check constraint in Koha since 2012-09-12
when one was added as part of bug 5911
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 07:31:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 06:31:06 +0000
Subject: [Koha-bugs] [Bug 23942] New: After upgrading koha from version 16.5
to 18.11 itemtype,
itype and other list boxes corresponding to authorised values attached to
frameworks fail to show the selected values upon editing the bib and item
records
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23942
Bug ID: 23942
Summary: After upgrading koha from version 16.5 to 18.11
itemtype, itype and other list boxes corresponding to
authorised values attached to frameworks fail to show
the selected values upon editing the bib and item
records
Change sponsored?: ---
Product: Koha
Version: 18.11
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Cataloging
Assignee: koha-bugs at lists.koha-community.org
Reporter: rajujogi.t at gmail.com
QA Contact: testopia at bugs.koha-community.org
CC: m.de.rooy at rijksmuseum.nl
Created attachment 94934
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94934&action=edit
Item editor does not show the previous values for the list boxes
I have upgraded Koha from version 16.5 to 18.11. After that when I edit the
biblio record the itemtype list box (942$c) does not show the previous value.
In the same way when the item records edited the list boxes corresponding to
the authorised values LOST, DAMAGED, LOC, NOT_FOR_LOAN, RESTRICTED and itype
(itemtypes) the previous values are not shown in the editor.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 07:35:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 06:35:15 +0000
Subject: [Koha-bugs] [Bug 23827] Cash register statistics uses old
accounttype values
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23827
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |m.de.rooy at rijksmuseum.nl
Status|Signed Off |BLOCKED
--- Comment #14 from Marcel de Rooy ---
QAing
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 07:41:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 06:41:30 +0000
Subject: [Koha-bugs] [Bug 23827] Cash register statistics uses old
accounttype values
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23827
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|BLOCKED |Patch doesn't apply
--- Comment #15 from Marcel de Rooy ---
CONFLICT (content): Merge conflict in reports/cash_register_stats.pl
CONFLICT (content): Merge conflict in
koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash_register_stats.tt
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 07:51:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 06:51:17 +0000
Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database
columns for system preferences
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |rel_20_05_target
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 07:51:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 06:51:54 +0000
Subject: [Koha-bugs] [Bug 20116] Cache language list
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
--- Comment #43 from Marcel de Rooy ---
(In reply to Jonathan Druart from comment #42)
> Still waiting for another QA feedback, back to NQA.
I am still hoping for tests :)
Note even that this patch set breaks a test when these patches are applied and
does not when not.
t/db_dependent/Languages.t (Wstat: 512 Tests: 18 Failed: 2)
Failed tests: 11, 13
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 07:55:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 06:55:33 +0000
Subject: [Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view
(open/closed)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |martin.renvoize at ptfs-europe
| |.com
Keywords|rel_19_11_candidate |rel_20_05_target
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 07:57:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 06:57:44 +0000
Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com
|y.org |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 07:57:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 06:57:54 +0000
Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords|rel_19_11_candidate |rel_20_05_target
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 07:59:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 06:59:11 +0000
Subject: [Koha-bugs] [Bug 17483] Forgiving charge should apply to item's
last fine.
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17483
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Version|master |18.05
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 08:00:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 07:00:12 +0000
Subject: [Koha-bugs] [Bug 22630] Allow to change homebranch in course
reserves
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords|rel_19_11_candidate |rel_20_05_target
CC| |martin.renvoize at ptfs-europe
| |.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 08:01:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 07:01:11 +0000
Subject: [Koha-bugs] [Bug 18958] If patron has multiple record level holds
on one record transferring first hold causes next hold to become item level
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |rel_19_11_candidate
CC| |martin.renvoize at ptfs-europe
| |.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 08:04:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 07:04:20 +0000
Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords|rel_19_11_candidate |rel_20_05_target
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 08:07:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 07:07:33 +0000
Subject: [Koha-bugs] [Bug 18958] If patron has multiple record level holds
on one record transferring first hold causes next hold to become item level
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |BLOCKED
--- Comment #35 from Marcel de Rooy ---
QAing
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 08:15:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 07:15:52 +0000
Subject: [Koha-bugs] [Bug 22581] Add support for Plaine & Easie musical
incipits rendering in OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--- Comment #15 from Martin Renvoize ---
All works as expected for me and I 'think' my comments have all been resolved.
Marking as Signed off.. (Will add SO line to patches on push)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 08:23:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 07:23:12 +0000
Subject: [Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign
key constraint
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |rel_20_05_target
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 08:25:05 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 07:25:05 +0000
Subject: [Koha-bugs] [Bug 15283] Switch default ISSUEQSLIP notice to
Template Toolkit
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15283
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |rel_20_05_target
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 08:25:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 07:25:21 +0000
Subject: [Koha-bugs] [Bug 23890] Plugins that utilise possibly security
breaching hooks should warn
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23890
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |rel_20_05_target
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 08:26:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 07:26:16 +0000
Subject: [Koha-bugs] [Bug 5501] Improve the 'do not notify' option
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5501
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords|Academy |rel_20_05_target
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 08:26:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 07:26:56 +0000
Subject: [Koha-bugs] [Bug 22745] Need a "Do not notify" option in messaging
preferences
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22745
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |rel_20_05_target
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 08:27:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 07:27:49 +0000
Subject: [Koha-bugs] [Bug 18506] SSO - Shibboleth Only Mode
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18506
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords|rel_19_11_candidate |rel_20_05_target
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 08:31:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 07:31:24 +0000
Subject: [Koha-bugs] [Bug 15523] Move a number of sysprefs to circulation
rules (Omnibus)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15523
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |martin.renvoize at ptfs-europe
| |.com
Keywords| |rel_20_05_target
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 08:33:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 07:33:38 +0000
Subject: [Koha-bugs] [Bug 14845] Fines forgiven even when
WhenLostForgiveFine is set to 'Don't Forgive'
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14845
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |martin.renvoize at ptfs-europe
| |.com
Status|NEW |RESOLVED
Resolution|--- |WORKSFORME
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 08:34:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 07:34:44 +0000
Subject: [Koha-bugs] [Bug 22818] ILL should be able to send notices
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords|rel_19_11_candidate |rel_20_05_target
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 08:36:37 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 07:36:37 +0000
Subject: [Koha-bugs] [Bug 18958] If patron has multiple record level holds
on one record transferring first hold causes next hold to become item level
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords|rel_19_11_candidate |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 08:36:51 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 07:36:51 +0000
Subject: [Koha-bugs] [Bug 18958] If patron has multiple record level holds
on one record transferring first hold causes next hold to become item level
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |rel_20_05_target
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 08:42:07 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 07:42:07 +0000
Subject: [Koha-bugs] [Bug 23859] Cities endpoint not setting the Location
header
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23859
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact| |martin.renvoize at ptfs-europe
| |.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 08:42:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 07:42:42 +0000
Subject: [Koha-bugs] [Bug 23860] Patrons endpoint not setting the Location
header
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23860
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact| |martin.renvoize at ptfs-europe
| |.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 08:42:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 07:42:49 +0000
Subject: [Koha-bugs] [Bug 23695] Items holdingbranch should be set to the
originating library when generating a manual transfer
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23695
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|martin.renvoize at ptfs-europe |testopia at bugs.koha-communit
|.com |y.org
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 08:43:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 07:43:36 +0000
Subject: [Koha-bugs] [Bug 23695] Items holdingbranch should be set to the
originating library when generating a manual transfer
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23695
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Failed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 08:44:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 07:44:14 +0000
Subject: [Koha-bugs] [Bug 18958] If patron has multiple record level holds
on one record transferring first hold causes next hold to become item level
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
--- Comment #36 from Marcel de Rooy ---
(In reply to Marcel de Rooy from comment #15)
> Failing QA because this patch has side-effects when you cancel a hold from
> the confirm hold popup. Before we called GetOtherReserves and now we dont.
Still looking at my older comment, and having the feeling that it was kind of
ignored.
Let me rephrase it by showing this diff part:
} else {
my $diffBranchSend = ($userenv_branch ne $diffBranchReturned) ?
$diffBranchReturned : undef;
+
# diffBranchSend tells ModReserveAffect whether document is expected
in this library or not,
# i.e., whether to apply waiting status
ModReserveAffect( $itemnumber, $borrowernumber, $diffBranchSend,
$reserve_id );
- }
-# check if we have other reserves for this document, if we have a return
send the message of transfer
- my ( $messages, $nextreservinfo ) = GetOtherReserves($itemnumber);
As you can see here, the GetOtherReserves call and code around it was placed
AFTER the else, but we remove the closing accolade and put the new code INTO
the else branch.
So what happens: if you come from the if branch (you canceled a hold), you wont
jump into the GetOtherReserves stuff anymore.
Still does not look good to me. Please convince me with some good arguments!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 08:45:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 07:45:35 +0000
Subject: [Koha-bugs] [Bug 18958] If patron has multiple record level holds
on one record transferring first hold causes next hold to become item level
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|BLOCKED |Failed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 08:48:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 07:48:53 +0000
Subject: [Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |BLOCKED
CC| |m.de.rooy at rijksmuseum.nl
--- Comment #24 from Marcel de Rooy ---
QAing
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:19:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 08:19:47 +0000
Subject: [Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944
--- Comment #25 from Marcel de Rooy ---
not ok 19 - AddReturn must have debarred the patron
# Failed test 'AddReturn must have debarred the patron'
# at t/db_dependent/Circulation.t line 86.
# got: ''
# expected: '1'
# AddReturn returned message $VAR1 = {
# 'WasReturned' => 1
# };
not ok 20 - Test at line 1922
# Failed test 'Test at line 1922'
# at t/db_dependent/Circulation.t line 90.
# got: '0'
# expected: '1'
not ok 21 - Test at line 1922
# Failed test 'Test at line 1922'
# at t/db_dependent/Circulation.t line 93.
# got: undef
# expected: '2019-11-15'
# Looks like you failed 3 tests of 21.
not ok 29 - AddReturn + suspension_chargeperiod
# Failed test 'AddReturn + suspension_chargeperiod'
# at t/db_dependent/Circulation.t line 1931.
# Looks like you failed 1 test of 45.
First time I ran Circulation.t, I got this. But I do not manage to reproduce it
another time ;) And it seems unrelated. No holds stuff there.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:32:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 08:32:46 +0000
Subject: [Koha-bugs] [Bug 23943] New: koha-run-backups --days is misleading
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23943
Bug ID: 23943
Summary: koha-run-backups --days is misleading
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: trivial
Priority: P5 - low
Component: Packaging
Assignee: koha-bugs at lists.koha-community.org
Reporter: magnus at libriotech.no
QA Contact: testopia at bugs.koha-community.org
CC: mirko at abunchofthings.net
The documentation for the --days option to koha-run-backups says:
--days: the number of days to keep backups around for (default: 2)
Sometimes I do the following:
1. Rename a backupfile, e.g. from instance-2019-10-22.sql.gz to
instance-2019-10-22-1230.sql.gz
2. Run koha-dump to create a new instance-2019-10-22.sql.gz
This reveals that --days does not really care about days at all, just the
number of files in the backup dir. This means that if I have adjusted the
cronjob to keep backups for 14 days, after the next time it runs, I actually
have backups for 13 days.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:36:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 08:36:54 +0000
Subject: [Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|BLOCKED |Failed QA
--- Comment #26 from Marcel de Rooy ---
($resfound, $resrec, undef) = C4::Reserves::CheckReserves(
$item->itemnumber, undef, $lookahead ) unless ( $item->withdrawn );
# if a hold is found and is waiting at another branch, change the priority
back to 1 and trigger the hold (this will trigger a transfer and update the
hold status properly)
if ( $resfound eq "Waiting" and $branch ne $resrec->{branchcode} ) {
C4::Reserves::RevertWaitingStatus( { itemnumber => $item->itemnumber }
);
#If the hold is reverted we need to refetch for the return values
($resfound, $resrec, undef) = C4::Reserves::CheckReserves(
$item->itemnumber, undef, $lookahead ) unless ( $item->withdrawn );
}
($resfound, $resrec, undef) = C4::Reserves::CheckReserves(
$item->itemnumber, undef, $lookahead ) unless ( $item->withdrawn );
In short what do we see here:
call CheckReserves
if( )
call CheckReserves
endif
call CheckReserves
Three times in a row ? Please explain why you also add the last call. Rebase
problem?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:37:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 08:37:11 +0000
Subject: [Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
|y.org |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:39:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 08:39:26 +0000
Subject: [Koha-bugs] [Bug 23859] Cities endpoint not setting the Location
header
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23859
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Trivial patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:42:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 08:42:06 +0000
Subject: [Koha-bugs] [Bug 22814] Holds modal patron name display
inconsistency
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22814
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:42:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 08:42:09 +0000
Subject: [Koha-bugs] [Bug 22814] Holds modal patron name display
inconsistency
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22814
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #94213|0 |1
is obsolete| |
--- Comment #3 from Marcel de Rooy ---
Created attachment 94937
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94937&action=edit
Bug 22814: Make patron names on holds modal consistent (second check-in)
Bug 22203 changed the behavior on the hold-found2 modal
that pops up when a hold is found so that whether or not
the patron's name is displayed is now governed by the
HidePatronName system preference.
However, if a hold is confirmed and you check the item
in a second time, the modal that pops up is hold-found1
and whether or not the patron's name is displayed in
the hold-found1 modal is not governed by the HidePatronName
system preference.
For the sake of consistency, the display of the patron's
name on hold-found2 and hold-found1 should both be governed
by the HidePatronName system preference.
To test:
- Place a hold on an item
- Check in the item to trigger the hold modal
- Confirm hold
- Check the item in again - verify name of patron displays
- Apply patch
- Repeat
- Verify name display now matches between the two modals
- change HidePatronName pref
- Repeat
- Name display should still match
Signed-off-by: Owen Leonard
Signed-off-by: Marcel de Rooy
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:42:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 08:42:15 +0000
Subject: [Koha-bugs] [Bug 23859] Cities endpoint not setting the Location
header
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23859
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #94498|0 |1
is obsolete| |
--- Comment #5 from Martin Renvoize ---
Created attachment 94938
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94938&action=edit
Bug 23859: Regression tests
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:42:18 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 08:42:18 +0000
Subject: [Koha-bugs] [Bug 23859] Cities endpoint not setting the Location
header
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23859
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #94499|0 |1
is obsolete| |
--- Comment #6 from Martin Renvoize ---
Created attachment 94939
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94939&action=edit
Bug 23859: Make POST add the Location header on cities endpoint
According to the coding guidelines, this endpoint should be adding the
Location header on POST actions.
To test:
1. Apply the tests patch
2. Run:
$ kshell
k$ prove t/db_dependent/api/v1/cities.t
=> FAIL: Tests fail!
3. Apply this patch
4. Repeat (1)
=> SUCCESS: Tests pass!
5. Sign off :-D
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:42:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 08:42:22 +0000
Subject: [Koha-bugs] [Bug 23859] Cities endpoint not setting the Location
header
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23859
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #94500|0 |1
is obsolete| |
--- Comment #7 from Martin Renvoize ---
Created attachment 94940
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94940&action=edit
Bug 23859: Update tests to new style
The /cities endpoint is refered in several places as the reference
implementation of a route for devs to pick it for copy and pasting. Yet,
it is outdated in terms of how the tests are written.
This patch rewrites some bits so it uses BASIC auth and the built-ins
Test::Mojo provides.
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:42:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 08:42:23 +0000
Subject: [Koha-bugs] [Bug 22814] Holds modal patron name display
inconsistency
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22814
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |m.de.rooy at rijksmuseum.nl
QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
|y.org |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:42:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 08:42:41 +0000
Subject: [Koha-bugs] [Bug 23859] Cities endpoint not setting the Location
header
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23859
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:43:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 08:43:27 +0000
Subject: [Koha-bugs] [Bug 23859] Cities endpoint not setting the Location
header
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23859
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--- Comment #8 from Martin Renvoize ---
Trivial patch that improves the consistency of our API's.
Passing QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:45:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 08:45:53 +0000
Subject: [Koha-bugs] [Bug 23860] Patrons endpoint not setting the Location
header
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23860
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #94583|0 |1
is obsolete| |
--- Comment #4 from Martin Renvoize ---
Created attachment 94941
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94941&action=edit
Bug 23860: Regression tests
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:45:57 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 08:45:57 +0000
Subject: [Koha-bugs] [Bug 23860] Patrons endpoint not setting the Location
header
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23860
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #94584|0 |1
is obsolete| |
--- Comment #5 from Martin Renvoize ---
Created attachment 94942
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94942&action=edit
Bug 23860: Make the patrons endpoint add the Location header
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:46:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 08:46:00 +0000
Subject: [Koha-bugs] [Bug 23860] Patrons endpoint not setting the Location
header
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23860
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #94585|0 |1
is obsolete| |
--- Comment #6 from Martin Renvoize ---
Created attachment 94943
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94943&action=edit
Bug 23860: Update tests to new style
Signed-off-by: Tomas Cohen Arazi
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:46:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 08:46:12 +0000
Subject: [Koha-bugs] [Bug 23860] Patrons endpoint not setting the Location
header
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23860
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:46:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 08:46:48 +0000
Subject: [Koha-bugs] [Bug 23860] Patrons endpoint not setting the Location
header
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23860
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--- Comment #7 from Martin Renvoize ---
Trivial patch that improves the consistency of our API's.
Passing QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:48:36 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 08:48:36 +0000
Subject: [Koha-bugs] [Bug 17359] Patron import results use wrong encoding
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17359
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |m.de.rooy at rijksmuseum.nl
Status|Signed Off |BLOCKED
--- Comment #26 from Marcel de Rooy ---
QAing
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:48:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 08:48:58 +0000
Subject: [Koha-bugs] [Bug 23859] Cities endpoint not setting the Location
header
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23859
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)| |19.11.00
released in| |
Status|Passed QA |Pushed to master
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:49:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 08:49:00 +0000
Subject: [Koha-bugs] [Bug 23859] Cities endpoint not setting the Location
header
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23859
--- Comment #9 from Martin Renvoize ---
Nice work!
Pushed to master for 19.11.00
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:49:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 08:49:02 +0000
Subject: [Koha-bugs] [Bug 23860] Patrons endpoint not setting the Location
header
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23860
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)| |19.11.00
released in| |
Status|Passed QA |Pushed to master
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:49:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 08:49:03 +0000
Subject: [Koha-bugs] [Bug 23860] Patrons endpoint not setting the Location
header
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23860
--- Comment #8 from Martin Renvoize ---
Nice work!
Pushed to master for 19.11.00
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:50:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 08:50:47 +0000
Subject: [Koha-bugs] [Bug 22814] Holds modal patron name display
inconsistency
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22814
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |martin.renvoize at ptfs-europe
| |.com
Severity|enhancement |normal
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:53:14 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 08:53:14 +0000
Subject: [Koha-bugs] [Bug 21824] Add ability to format dates in various
formats in templates
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)| |19.11.00
released in| |
Status|Passed QA |Pushed to master
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:53:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 08:53:16 +0000
Subject: [Koha-bugs] [Bug 21824] Add ability to format dates in various
formats in templates
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824
--- Comment #37 from Martin Renvoize ---
Nice work!
Pushed to master for 19.11.00
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:53:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 08:53:19 +0000
Subject: [Koha-bugs] [Bug 22814] Holds modal patron name display
inconsistency
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22814
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Version(s)| |19.11.00
released in| |
Status|Passed QA |Pushed to master
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:53:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 08:53:21 +0000
Subject: [Koha-bugs] [Bug 22814] Holds modal patron name display
inconsistency
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22814
--- Comment #4 from Martin Renvoize ---
Nice work!
Pushed to master for 19.11.00
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 10:03:09 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 09:03:09 +0000
Subject: [Koha-bugs] [Bug 23765] After TranslateNotices is set to 'Don't
allow', email settings still show multiple languages
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23765
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|enhancement |normal
CC| |martin.renvoize at ptfs-europe
| |.com
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 10:03:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 09:03:25 +0000
Subject: [Koha-bugs] [Bug 23765] After TranslateNotices is set to 'Don't
allow', email settings still show multiple languages
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23765
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |bin.wen at inlibro.com
|ity.org |
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 11:12:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 10:12:49 +0000
Subject: [Koha-bugs] [Bug 17359] Patron import results use wrong encoding
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17359
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|BLOCKED |Failed QA
--- Comment #27 from Marcel de Rooy ---
QA Comment:
my $surname ='Chloé';
my $surname_utf8 = encode_utf8($surname);
=> This name is not the best example for UTF-8. Could be Latin too.
=> You dont do anything with this encoded string.
=> When I am adding some Chinese character in the surname, the test fails.
decode_utf8($borrowerline)
Instead of adding this all over the place, we should try to fix at the source
or at least closer.
LINE: while ( my $borrowerline = <$handle> ) {
You could add it here, which would be closer but thats not all. Is the
assumption correct that it is UTF-8? We just got a handle from the caller. On
the report I am reading about people uploading Latin data.
Actually, we see in tools/import_borrowers.pl:
use CGI qw ( -utf8 );
and
my $handle = $input->upload('uploadborrowers');
CGI tells me that "binary upload data ... are left untouched".
Do we actually need another parameter for the file encoding?
Looks like this needs some more attention.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 11:12:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 10:12:58 +0000
Subject: [Koha-bugs] [Bug 17359] Patron import results use wrong encoding
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17359
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
|y.org |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 11:14:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 10:14:49 +0000
Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from
items_last_borrower
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |m.de.rooy at rijksmuseum.nl
Status|Signed Off |BLOCKED
--- Comment #10 from Marcel de Rooy ---
QAing
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 11:15:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 10:15:38 +0000
Subject: [Koha-bugs] [Bug 23765] After TranslateNotices is set to 'Don't
allow', email settings still show multiple languages
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23765
--- Comment #4 from Martin Renvoize ---
Hmmm,
I'm wondering if this should be caught at a higher level.. the issue to me is
that C4::Letters::GetLetterTemplates returns multiple languages even if
TranslateNotices is set to "Don't allow"... I'm wondering if fixing it at this
level would catch some other cases where TranslateNotices isn't being checked
perhaps?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 11:27:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 10:27:55 +0000
Subject: [Koha-bugs] [Bug 23765] After TranslateNotices is set to 'Don't
allow', email settings still show multiple languages
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23765
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
|y.org |.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 11:34:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 10:34:31 +0000
Subject: [Koha-bugs] [Bug 23719] Record matching for authorities using
defined fields is broken under ES
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23719
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact| |jonathan.druart at bugs.koha-c
| |ommunity.org
CC| |martin.renvoize at ptfs-europe
| |.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 11:34:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 10:34:58 +0000
Subject: [Koha-bugs] [Bug 23719] Record matching for authorities using
defined fields is broken under ES
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23719
--- Comment #7 from Martin Renvoize ---
Does the extra patch here resolve your worries Jonathan?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 11:46:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 10:46:38 +0000
Subject: [Koha-bugs] [Bug 23089] Elasticsearch - cannot sort on non-text
fields
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23089
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #94617|0 |1
is obsolete| |
--- Comment #11 from Martin Renvoize ---
Created attachment 94944
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94944&action=edit
Bug 23089: Unit tests
Signed-off-by: Ere Maijala
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 11:46:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 10:46:42 +0000
Subject: [Koha-bugs] [Bug 23089] Elasticsearch - cannot sort on non-text
fields
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23089
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #94618|0 |1
is obsolete| |
--- Comment #12 from Martin Renvoize ---
Created attachment 94945
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94945&action=edit
Bug 23089: Fix sorting on sum and regular fields
As of bug 20589 we no longer analyze sort fields and so we no longer need to
append ".phrase"
to our sort in searches.
Additionally, sort fields based on 'sum' should also use sum in building the
value to sort on
To test:
0 - Be using ES
1 - Find the most circulated item in your collection
2 - Search for '*'
3 - Sort by popularity DESC
4 - Note that item is not first
5 - Try to sort by anything but relevancy, it fails
6 - Apply patch
7 - Redo searches and sorts
8 - Things should now work as expected
Signed-off-by: Ere Maijala
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 11:46:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 10:46:46 +0000
Subject: [Koha-bugs] [Bug 23089] Elasticsearch - cannot sort on non-text
fields
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23089
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #94656|0 |1
is obsolete| |
--- Comment #13 from Martin Renvoize ---
Created attachment 94946
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94946&action=edit
Bug 23089: Fix QueryBuilder tests.
Signed-off-by: Nick Clemens
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 11:47:33 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 10:47:33 +0000
Subject: [Koha-bugs] [Bug 23089] Elasticsearch - cannot sort on non-text
fields
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23089
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
CC| |martin.renvoize at ptfs-europe
| |.com
--- Comment #14 from Martin Renvoize ---
Works as expected, has tests, passes tests and passes QA script.
Passing QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 11:56:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 10:56:00 +0000
Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |rel_20_05_target
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:00:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 11:00:04 +0000
Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from
items_last_borrower
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|BLOCKED |Failed QA
--- Comment #11 from Marcel de Rooy ---
Hi Augustin,
I would like to see you optimize a bit.
for => $table_to_anonymize
Both anonymize and anonymise are correct and in use, but you mix them on this
report (no blocker, just seeing it). The z spelling is American.
But I do not really understand why you put the patron select in
search_patrons_to_anonymise. Why not leave this sub alone? We could directly
call anonymise_items_last_borrower, since you are not really interested in the
patrons here. And optimize it rightaway. Make the query in the new sub, and run
update on that result set without looping with next?
Thanks.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:00:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 11:00:12 +0000
Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from
items_last_borrower
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl
|y.org |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:04:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 11:04:13 +0000
Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Depends on| |14570, 17168
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570
[Bug 14570] Make it possible to add multiple guarantors to a record
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168
[Bug 17168] Add a command line script for updating patron category based on
status
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:04:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 11:04:13 +0000
Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors
to a record
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |12446
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446
[Bug 12446] Enable an adult to have a guarantor
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:04:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 11:04:13 +0000
Subject: [Koha-bugs] [Bug 17168] Add a command line script for updating
patron category based on status
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |12446
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446
[Bug 12446] Enable an adult to have a guarantor
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:04:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 11:04:35 +0000
Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |rel_20_05_target
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:04:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 11:04:44 +0000
Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|Small patch |---
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:05:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 11:05:01 +0000
Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|enhancement |new feature
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:06:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 11:06:16 +0000
Subject: [Koha-bugs] [Bug 19809] Koha::Objects::find calls do not need to be
forbidden in list context
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809
--- Comment #11 from Marcel de Rooy ---
(In reply to Martin Renvoize from comment #10)
> This seems sane to me and I like to follow the example set by DBIx::Class to
> be honest.. that project has been around for a long time and has made allot
> of good decisions for good reasons.
I would agree with you if we were writing Koha::Objects->find at this moment.
But in the meantime they go back to bug 13019, pushed 02/2015. How many find
calls do we have now, and associated if conditions etc.?
In view of that volume and the risk of breaking a lot of code, I would not
recommend it now.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:06:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 11:06:58 +0000
Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search
fields from UI
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |rel_20_05_target
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:14:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 11:14:16 +0000
Subject: [Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten
using the patron import tool
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |m.de.rooy at rijksmuseum.nl
--- Comment #8 from Marcel de Rooy ---
diff --git a/Koha/Patron.pm b/Koha/Patron.pm
index 8e501fcfb1..787713524e 100644
--- a/Koha/Patron.pm
+++ b/Koha/Patron.pm
@@ -250,7 +250,6 @@ sub store {
# Make a copy of the plain text password for later use
$self->plain_text_password( $self->password );
-
Please remove that one from your patch. No need to.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:16:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 11:16:00 +0000
Subject: [Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten
using the patron import tool
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473
--- Comment #9 from Marcel de Rooy ---
+ if ($overwrite_passwords){
+ $patron->set_password({ password => $borrower{password} });
+ }
set_password may throw several exceptions, we should do some checking here
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:16:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 11:16:04 +0000
Subject: [Koha-bugs] [Bug 20194] Display both biblioitems.itemtype and
items.itype in circulation screens
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20194
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #93221|0 |1
is obsolete| |
--- Comment #21 from Martin Renvoize ---
Created attachment 94947
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94947&action=edit
Bug 20194: Display both biblioitems.itemtype and items.itype in circulation
screens
Test plan:
1. Verify that biblioitems.itemtype, items.itype are
mapped to a MARC field. Otherwise create those mappings.
2. Create a biblio with an itemtype
3. Create an item with a different itemtype for this biblio
4. Check out this item to a patron (P1)
5. Verify that both itemtypes are displayed in the
checkouts table (moremember.pl, circulation.pl, returns.pl)
6. Create a patron whose guarantor is P1 and verify that both itemtypes
and the ccode are displayed in the 'relatives checkouts' table
Followed test plan, patch worked as described, also passes QA test tool
Signed-off-by: Alex Buckley
Signed-off-by: Nick Clemens
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:16:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 11:16:53 +0000
Subject: [Koha-bugs] [Bug 20194] Display both biblioitems.itemtype and
items.itype in circulation screens
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20194
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--- Comment #22 from Martin Renvoize ---
Works well and I think clarifies things to the end user.. Passes QA scripts,
Passing QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:16:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 11:16:59 +0000
Subject: [Koha-bugs] [Bug 20194] Display both biblioitems.itemtype and
items.itype in circulation screens
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20194
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
|y.org |.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:17:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 11:17:41 +0000
Subject: [Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten
using the patron import tool
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473
Marcel de Rooy changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Failed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:18:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 11:18:52 +0000
Subject: [Koha-bugs] [Bug 23762] Editing is_html status of email template
fails under multi-languages
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23762
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |martin.renvoize at ptfs-europe
| |.com
Severity|enhancement |normal
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:19:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 11:19:12 +0000
Subject: [Koha-bugs] [Bug 23762] Editing is_html status of email template
fails under multi-languages
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23762
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |bin.wen at inlibro.com
|ity.org |
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:20:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 11:20:08 +0000
Subject: [Koha-bugs] [Bug 23762] Editing is_html status of email template
fails under multi-languages
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23762
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #93820|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:23:01 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 11:23:01 +0000
Subject: [Koha-bugs] [Bug 23762] Editing is_html status of email template
fails under multi-languages
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23762
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #93906|0 |1
is obsolete| |
--- Comment #8 from Martin Renvoize ---
Created attachment 94948
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94948&action=edit
Bug 23762: Editing is_html status of email template fails under multi-languages
To test:
1.Enable multi-languages
2.Set the preference 'TranslateNotices' on 'Allow'
3.Go to: tools==>Notices & slips==>Edit (one notice)
4.Click on the "Email" in the Default, uncheck the checkbox for 'HTML
Messages'.
5.Save
6.Reopen the notice, nothing changed.
7.Apply the patch
8.Repeat the steps 4 and 5
9.Success.
Signed-off-by: Katrin Fischer
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:23:10 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 11:23:10 +0000
Subject: [Koha-bugs] [Bug 23762] Editing is_html status of email template
fails under multi-languages
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23762
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
|y.org |.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:24:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 11:24:25 +0000
Subject: [Koha-bugs] [Bug 23805] Add a dedicated credit_types table
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805
--- Comment #54 from Julian Maurice ---
(In reply to Martin Renvoize from comment #52)
> Check constraints are not a mysqlism and have been in mariadb since 4 Jul
> 2016, postgres since before 2001-08-15.. they're not be thing.
>
> I will remove the constraint if people are really that anti having
> consistent data. It really is a "do no harm" feature, I don't see why
> people are getting so sound up about it. The database update threw a
> warning but carried on and didn't break anything.. you just ended up without
> the constraint.
>
> If we bring this silly about supported systems we should be removing the
> entire restful API in my mmm opinion as mojolicious is far less easily
> packaged, faster moving and unstable.
>
> I've said my piece.
Just to be clear, I am all for consistent data, but I'm also all for consistent
behaviour. That's why I think Koha shouldn't use a database feature that is not
supported by all database systems supported by Koha (btw, does the list of
supported databases - with versions - exist somewhere ?).
With a CHECK constraint, someone with MySQL 8.0.16+ will have different
database constraints than someone with MySQL 5.7. So, possibly different
behaviours, bugs that are hard to reproduce, ... And that, IMO, should be
avoided if possible.
That particular problem could be solved if we decide that Koha now requires at
least MySQL 8.0.16 (which is 6 months old) or MariaDB 10.2 (first 10.2 stable
version is more than 2 years old).
But there's still the problem of the error message shown during
updatedatabase.pl (because of different syntax) that need to be solved (maybe
in a new bug ?)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:24:48 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 11:24:48 +0000
Subject: [Koha-bugs] [Bug 23762] Editing is_html status of email template
fails under multi-languages
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23762
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--- Comment #9 from Martin Renvoize ---
Code makes sense, bug replicated and proved to be resolved by this patch.
Passes QA scripts and although I'd love to have seen an accompanying selenium
test that's not a blocker.
Passing QA.
Minor note.. please remember to alter the 'Importance' of bugs.. This was
labelled as an enhancement when in my mind it's a bug.
Nice work finding and fixing though Bin Wen
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:25:17 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 11:25:17 +0000
Subject: [Koha-bugs] [Bug 23663] Itemtype summary feature in search results
is only used in deprecated opac results non-xslt view
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23663
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
|y.org |.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:26:22 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 11:26:22 +0000
Subject: [Koha-bugs] [Bug 23658] WrongTransfer modal drops off specified
checkin date on returns.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23658
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe
|y.org |.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:42:45 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 11:42:45 +0000
Subject: [Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful
error message
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Failed QA |Signed Off
--- Comment #27 from Martin Renvoize ---
(In reply to Jonathan Druart from comment #26)
> (In reply to Martin Renvoize from comment #25)
> > Created attachment 94363 [details]
> > screenshot
> >
> > This is what I see with the patch applied.
>
> Try with http://mana-test.koha-community.org
But that is a 'good' URL.. so I don't expect to see any errors..
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:55:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 11:55:00 +0000
Subject: [Koha-bugs] [Bug 23938] Title missing from Checked out box
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23938
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Trivial patch
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:55:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 11:55:02 +0000
Subject: [Koha-bugs] [Bug 23938] Title missing from Checked out box
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23938
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #94932|0 |1
is obsolete| |
--- Comment #3 from Owen Leonard ---
Created attachment 94949
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94949&action=edit
Bug 23938: Restore title display in last checked out box
To test:
1 - Check out to a patron
2 - Note the display under the checkotu box does not have title
3 - Apply patch
4 - Checkout another item
5 - Note the title displays
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:55:16 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 11:55:16 +0000
Subject: [Koha-bugs] [Bug 23938] Title missing from Checked out box
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23938
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|normal |major
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:57:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 11:57:49 +0000
Subject: [Koha-bugs] [Bug 22922] Allow to modify hold and hold expiration
date in staff
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |Manual
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:57:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 11:57:56 +0000
Subject: [Koha-bugs] [Bug 22922] Allow to modify hold and hold expiration
date in staff
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |release-notes-needed
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 13:04:11 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 12:04:11 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
Koha::Item
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords| |rel_20_05_target
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 13:04:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 12:04:44 +0000
Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to
Koha::Item
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463
--- Comment #4 from Martin Renvoize ---
Lets hit this one hard beginning of next cycle :)
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 13:13:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 12:13:32 +0000
Subject: [Koha-bugs] [Bug 23944] New: Phase out use of jquery.cookie.js in
favor of js.cookie.js
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944
Bug ID: 23944
Summary: Phase out use of jquery.cookie.js in favor of
js.cookie.js
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: ASSIGNED
Severity: enhancement
Priority: P5 - low
Component: Templates
Assignee: oleonard at myacpl.org
Reporter: oleonard at myacpl.org
QA Contact: testopia at bugs.koha-community.org
The jQuery plugin we use for setting cookies is obsolete:
https://github.com/carhartl/jquery-cookie -- "No longer maintained, superseded
by JS Cookie: https://github.com/js-cookie/js-cookie"
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 13:15:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 12:15:02 +0000
Subject: [Koha-bugs] [Bug 23938] Title missing from Checked out box
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23938
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de
|y.org |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 14:05:15 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 13:05:15 +0000
Subject: [Koha-bugs] [Bug 23805] Add a dedicated credit_types table
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805
--- Comment #55 from Katrin Fischer ---
The update fails on the MariaDB version in my kohadevbox:
Server version: 10.1.38-MariaDB-0+deb9u1 Debian 9.8
See discussion on IRC:
http://irc.koha-community.org/koha/2019-11-01#i_2186242
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 14:07:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 13:07:19 +0000
Subject: [Koha-bugs] [Bug 23938] Title missing from Checked out box
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23938
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 14:07:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 13:07:23 +0000
Subject: [Koha-bugs] [Bug 23938] Title missing from Checked out box
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23938
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #94949|0 |1
is obsolete| |
--- Comment #4 from Katrin Fischer ---
Created attachment 94950
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94950&action=edit
Bug 23938: Restore title display in last checked out box
To test:
1 - Check out to a patron
2 - Note the display under the checkotu box does not have title
3 - Apply patch
4 - Checkout another item
5 - Note the title displays
Signed-off-by: Owen Leonard
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 14:11:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 13:11:23 +0000
Subject: [Koha-bugs] [Bug 23942] After upgrading koha from version 16.5 to
18.11 itemtype,
itype and other list boxes corresponding to authorised values attached to
frameworks fail to show the selected values upon editing the bib and item
records
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23942
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #1 from Katrin Fischer ---
Did you see any errors during your update?
Are the itemtypes and authorised values still configured correctly?
Did you check the configuration in your frameworks?
I would recommend bringing this up on the mailing list first to rule out a
problem specific to your installation. We have run updates up to 18.11 and have
never seen any issue like that.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 14:14:47 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 13:14:47 +0000
Subject: [Koha-bugs] [Bug 23805] Add a dedicated credit_types table
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805
--- Comment #56 from Martin Renvoize ---
I've plain removed the check constraints from both this bug and 23049 too..
Clearly people are generally not interested in data integrity and it's causing
too many headaches attempting to pretend MariaDB and MySQL are the same.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 14:14:53 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 13:14:53 +0000
Subject: [Koha-bugs] [Bug 23805] Add a dedicated credit_types table
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords|additional_work_needed |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 14:15:12 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 13:15:12 +0000
Subject: [Koha-bugs] [Bug 23937] Clear filter in Acquisitions Search doesn't
work
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23937
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de,
| |oleonard at myacpl.org
--- Comment #2 from Katrin Fischer ---
I think it's greyed out because the database filter is empty. I think there is
a difference between the datatables filter and the sql filtering/search done
from the search above shown on the left. You need to clear it out there and
search again.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 14:15:19 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 13:15:19 +0000
Subject: [Koha-bugs] [Bug 23944] Phase out use of jquery.cookie.js in favor
of js.cookie.js
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
Patch complexity|--- |Small patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 14:15:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 13:15:21 +0000
Subject: [Koha-bugs] [Bug 23944] Phase out use of jquery.cookie.js in favor
of js.cookie.js
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944
--- Comment #1 from Owen Leonard ---
Created attachment 94951
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94951&action=edit
Bug 23944: Phase out use of jquery.cookie.js in favor of js.cookie.js
This patch adds a new JavaScript file to the staff client's global
JavaScript include file: js.cookie-2.2.1.min.js. This "plugin" will
replace jquery.cookie.js which is no longer maintained.
The "About" page in the staff client is updated to include this new
resource as well as adding previously-missing information about the old
plugin which will remain until all instances of its usage have been
removed.
To test, apply the patch and check the About page to confirm the correct
information is included.
No functionality change is introduced by this bug. The only other
observable change is the existence of the new files and the inclusion of
the minified version of the file in any staff client page.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 14:15:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 13:15:26 +0000
Subject: [Koha-bugs] [Bug 23937] Clear filter in Acquisitions Search doesn't
work
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23937
--- Comment #3 from Katrin Fischer ---
database filter = datatable filter!
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 14:29:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 13:29:28 +0000
Subject: [Koha-bugs] [Bug 23936] Authenticating a patron without library
card or ID
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23936
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
--- Comment #1 from Katrin Fischer ---
Sounds like a nice idea.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 14:30:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 13:30:59 +0000
Subject: [Koha-bugs] [Bug 22581] Add support for Plaine & Easie musical
incipits rendering in OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581
--- Comment #16 from Katrin Fischer ---
Having a go here.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 14:32:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 13:32:55 +0000
Subject: [Koha-bugs] [Bug 22581] Add support for Plaine & Easie musical
incipits rendering in OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #94856|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 14:40:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 13:40:04 +0000
Subject: [Koha-bugs] [Bug 23937] Clear filter in Acquisitions Search doesn't
work
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23937
--- Comment #4 from Owen Leonard ---
(In reply to Katrin Fischer from comment #2)
> I think it's greyed out because the database filter is empty.
Correct. I'm not sure how we can better make that distinction clear.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 15:02:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 14:02:58 +0000
Subject: [Koha-bugs] [Bug 22581] Add support for Plaine & Easie musical
incipits rendering in OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 15:03:02 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 14:03:02 +0000
Subject: [Koha-bugs] [Bug 22581] Add support for Plaine & Easie musical
incipits rendering in OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581
--- Comment #17 from Katrin Fischer ---
Created attachment 94952
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94952&action=edit
Bug 22581: Add new system preferences
This patch adds 2 new system preferences:
1. OPACShowMusicalInscripts - to toggle musical inscripts to appear in opac's
detail page
2. OPACPlayMusicalInscripts - to toggle musical inscripts to be transformed and
payed in midi. Depends on OPACShowMusicalInscripts to be enabled.
To test:
1. apply this patch
2. perl installer/data/mysql/updatedatabase.pl
3. search for this new preferences in admin module
SUCCESS => they appear in OPAC section.
4. sign off
Sponsored-by: Biblioteca Provincial Fr. Mamerto Esquiú (Provincia Franciscana
de la Asunción)
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 15:04:28 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 14:04:28 +0000
Subject: [Koha-bugs] [Bug 22581] Add support for Plaine & Easie musical
incipits rendering in OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581
--- Comment #18 from Katrin Fischer ---
The written music is very pretty. How is the code in 031 generated? (out of
interest) Passing QA on this one.
Do we need to add something to the about page for the new JavaScript libraries
used here?
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 15:05:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 14:05:30 +0000
Subject: [Koha-bugs] [Bug 22581] Add support for Plaine & Easie musical
incipits rendering in OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581
--- Comment #19 from Katrin Fischer ---
We might to improve the display later slightly - maybe move it further up, move
the link closer to the written music, include a label.. but works for now
nicely and is an optional feature.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 15:07:37 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 14:07:37 +0000
Subject: [Koha-bugs] [Bug 22581] Add support for Plaine & Easie musical
incipits rendering in OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581
--- Comment #20 from Katrin Fischer ---
Tiny thing: Play this sample - the space might get lost
with the translation tools.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 15:56:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 14:56:26 +0000
Subject: [Koha-bugs] [Bug 23944] Phase out use of jquery.cookie.js in favor
of js.cookie.js
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944
--- Comment #2 from Owen Leonard ---
Created attachment 94953
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94953&action=edit
Bug 23944: (follow-up) Update circulation to use new library
This patch updates the circulation page to use the new JavaScript Cookie
library for cookie management.
To test, apply the patch and open a patron record for checkout in the
staff client.
- Click "Search to hold" in the toolbar and perform a catalog search
which will return results.
- On the search results page, the toolbar at the top of the results
should include a split "Place hold" button. The button's menu should
include "Place hold for " and "Forget " options. Test
that these work correctly.
- In the table of search results each title should include a "Place
hold for " link.
- Go to the checkouts page for a patron with one or more checked-out
items.
- Check the "Always show checkouts immediately" checkbox.
- The patron's checkouts should load.
- Open another patron for checkout who has checked-out items.
- The table of checkouts should load automatically.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 16:06:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 15:06:20 +0000
Subject: [Koha-bugs] [Bug 23673] Separate time sent from time created in
message_queue table
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673
--- Comment #4 from Maxime Dufresne ---
Created attachment 94954
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94954&action=edit
Bug 23805: (RM follow-up) Remove CHECK constraints
MariaDB and MySQL support different syntaxes for CHECK constraints at
different versions. To remove complexities in the updatedatabase script
I have opted to remove all CHECK constraints entirely.
Signed-off-by: Martin Renvoize
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 16:34:25 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 15:34:25 +0000
Subject: [Koha-bugs] [Bug 23945] New: koha-remove does not support older
mysql and mariadb
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23945
Bug ID: 23945
Summary: koha-remove does not support older mysql and mariadb
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Database
Assignee: koha-bugs at lists.koha-community.org
Reporter: martin.renvoize at ptfs-europe.com
QA Contact: testopia at bugs.koha-community.org
koha-remove utilises IF EXISTS in the DROP USER calls and this was only
introduced in later versions of MySQL and MariaDB.. as such it breaks on many
otherwise stable distributions.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 16:35:27 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 15:35:27 +0000
Subject: [Koha-bugs] [Bug 23945] koha-remove does not support older mysql
and mariadb
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23945
--- Comment #1 from Martin Renvoize ---
MariaDB introduced the IF EXISTS clause in 10.1.3 and MySQL introduced it in
5.7
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 16:35:37 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 15:35:37 +0000
Subject: [Koha-bugs] [Bug 23945] koha-remove does not support older mysql
and mariadb
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23945
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de
|ity.org |
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 16:35:43 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 15:35:43 +0000
Subject: [Koha-bugs] [Bug 23945] koha-remove does not support older mysql
and mariadb
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23945
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|enhancement |major
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 16:38:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 15:38:30 +0000
Subject: [Koha-bugs] [Bug 23711] Icons on staff main page should be font
icons
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23711
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |23946
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23946
[Bug 23946] Remove Noun Project icons from the About page
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 16:38:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 15:38:30 +0000
Subject: [Koha-bugs] [Bug 23946] New: Remove Noun Project icons from the
About page
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23946
Bug ID: 23946
Summary: Remove Noun Project icons from the About page
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: ASSIGNED
Severity: minor
Priority: P5 - low
Component: Templates
Assignee: oleonard at myacpl.org
Reporter: oleonard at myacpl.org
QA Contact: testopia at bugs.koha-community.org
CC: fridolin.somers at biblibre.com, gmcharlt at gmail.com,
lucas at bywatersolutions.com,
testopia at bugs.koha-community.org
Depends on: 23711
Bug 23711 removed all the Noun Project icons from Koha, so the attribution can
be removed.
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23711
[Bug 23711] Icons on staff main page should be font icons
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 16:38:49 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 15:38:49 +0000
Subject: [Koha-bugs] [Bug 23859] Cities endpoint not setting the Location
header
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23859
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords|rel_19_11_candidate |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 16:39:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 15:39:06 +0000
Subject: [Koha-bugs] [Bug 23860] Patrons endpoint not setting the Location
header
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23860
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords|rel_19_11_candidate |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 16:40:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 15:40:00 +0000
Subject: [Koha-bugs] [Bug 21824] Add ability to format dates in various
formats in templates
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Keywords|rel_19_11_candidate |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 16:42:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 15:42:42 +0000
Subject: [Koha-bugs] [Bug 22569] Stock rotation: need transfer reports
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Small patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 16:56:55 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 15:56:55 +0000
Subject: [Koha-bugs] [Bug 23946] Remove Noun Project icons from the About
page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23946
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|ASSIGNED |Needs Signoff
Patch complexity|--- |Trivial patch
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 16:56:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 15:56:58 +0000
Subject: [Koha-bugs] [Bug 23946] Remove Noun Project icons from the About
page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23946
--- Comment #1 from Owen Leonard ---
Created attachment 94955
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94955&action=edit
Bug 23946: Remove Noun Project icons from the About page
This patch removes the part of the About page which gives attribution
for Noun Project icons on the staff client home page.
To test, apply the patch and view the About page in the staff client.
There should be no reference to Noun Project icons.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 17:52:08 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 16:52:08 +0000
Subject: [Koha-bugs] [Bug 23079] Checkouts page broken because of problems
with date calculation (TZAmerica/Sao_Paulo)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23079
Jose Ricardo Quaglio changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |jose.quaglio at saobernardo.sp
| |.gov.br
--- Comment #22 from Jose Ricardo Quaglio ---
Hello,
I work at the public library of Sao Bernardo do Campo / Sao Paulo / Brazil.
We have been using Koha since 2009, and we always have problems with the time
zone.
We currently use version 18 and have a homologation server with version 19,
both with error.
Today, 1/11/2019, we do not have "summer time".
There is an error in the time zone of registering a new user, check out or
renew materials.
Error: "Internal Server Error" in "/cgi-bin/koha/members/memberentry.pl"
When checking the log "plack-error":
Wide character in print at /usr/share/perl5/CGI/Session/Driver/file.pm line
118.
Wide character in print at /usr/share/perl5/CGI/Session/Driver/file.pm line
118.
Invalid local time for date in time zone: America / Sao_Paulo
Can someone help me?
Tks,
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 19:12:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 18:12:41 +0000
Subject: [Koha-bugs] [Bug 23947] New: Phase out jquery.cookie.js: Authority
merge
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23947
Bug ID: 23947
Summary: Phase out jquery.cookie.js: Authority merge
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: ASSIGNED
Severity: enhancement
Priority: P5 - low
Component: Templates
Assignee: oleonard at myacpl.org
Reporter: oleonard at myacpl.org
QA Contact: testopia at bugs.koha-community.org
CC: testopia at bugs.koha-community.org
Depends on: 23944
The authority merge process sets cookes to track which records are being
merged. This process should use the newer cookie library, js-cookie.
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944
[Bug 23944] Phase out use of jquery.cookie.js in favor of js.cookie.js
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 19:12:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 18:12:41 +0000
Subject: [Koha-bugs] [Bug 23944] Phase out use of jquery.cookie.js in favor
of js.cookie.js
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |23947
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23947
[Bug 23947] Phase out jquery.cookie.js: Authority merge
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 19:13:54 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 18:13:54 +0000
Subject: [Koha-bugs] [Bug 23948] New: Move mandatory .sql files to the
mandatory/ directory
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23948
Bug ID: 23948
Summary: Move mandatory .sql files to the mandatory/ directory
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Architecture, internals, and plumbing
Assignee: koha-bugs at lists.koha-community.org
Reporter: tomascohen at gmail.com
QA Contact: testopia at bugs.koha-community.org
Some files exist in the root directory (installer/data/mysql) and some other in
the mandatory/ one. All should be put in the mandatory one. The current
'layout' becomes particularly troublesome on this commit:
https://gitlab.com/koha-community/koha-misc4dev/commit/7ecb9de5b6c7ef660ff63254e802a8ec42199a13
After that commit, the tools won't work for earlier versions that don't have
that .sql files. If they were put in the mandatory directory there would be no
need to explicitly list them or branching in the code depending on the version
(possible workaround in koha-misc4dev).
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 19:14:41 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 18:14:41 +0000
Subject: [Koha-bugs] [Bug 23948] Move mandatory .sql files to the mandatory/
directory
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23948
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Component|Architecture, internals, |Installation and upgrade
|and plumbing |(command-line installer)
CC| |jonathan.druart at bugs.koha-c
| |ommunity.org,
| |martin.renvoize at ptfs-europe
| |.com,
| |nick at bywatersolutions.com
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 19:21:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 18:21:21 +0000
Subject: [Koha-bugs] [Bug 23947] Phase out jquery.cookie.js: Authority merge
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23947
Owen Leonard changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Trivial patch
Status|ASSIGNED |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 19:21:23 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 18:21:23 +0000
Subject: [Koha-bugs] [Bug 23947] Phase out jquery.cookie.js: Authority merge
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23947
--- Comment #1 from Owen Leonard ---
Created attachment 94956
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94956&action=edit
Bug 23947: Phase out jquery.cookie.js: Authority merge
This patch updates the JavaScript which sets cookies during the
authority merge process so that it uses the new js-cookie library.
To test, apply the patch and perform a search in the authority module
which will return multiple results.
- Select "Merge" from the Actions menu next to any result.
- A message should appear at the top of the page: "Merging with
authority: ".
- Click "Cancel merge." The message should disappear.
- Select a record to merge again.
- Select another record.
- The page should redirect to the authority merge page.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 19:48:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 18:48:31 +0000
Subject: [Koha-bugs] [Bug 23949] New: koha-common.init missing actions for
koha-z3950-responder
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949
Bug ID: 23949
Summary: koha-common.init missing actions for
koha-z3950-responder
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: normal
Priority: P5 - low
Component: Installation and upgrade (command-line installer)
Assignee: koha-bugs at lists.koha-community.org
Reporter: tomascohen at gmail.com
QA Contact: testopia at bugs.koha-community.org
For consistency, it should be calling the script for --stop and --restart
actions as well.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 19:55:35 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 18:55:35 +0000
Subject: [Koha-bugs] [Bug 23949] koha-common.init missing actions for
koha-z3950-responder
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
Patch complexity|--- |Trivial patch
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 19:55:38 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 18:55:38 +0000
Subject: [Koha-bugs] [Bug 23949] koha-common.init missing actions for
koha-z3950-responder
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949
--- Comment #1 from Tomás Cohen Arazi ---
Created attachment 94957
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94957&action=edit
Bug 23949: Add missing actions for koha-z3950-responder in koha-common.init
This patch makes the init script deal with koha-z3950-responder in --stop
and --restart actions. Currently, only --start calls the script.
To test:
- Enable the server:
$ koha-z3950-responder --enable kohadev
- Stop koha-common
$ service koha-common stop
=> SUCCESS: No koha-z3950-responder running
- Start koha-common
$ service koha-common start
=> SUCCESS: It is loaded (even if failing because of config issues)
- Stop koha-common
$ service koha-common stop
=> FAIL: It is still running (no --stop issued)
- Repeat for restart
- Apply this patch
- Redo
=> SUCCESS: Things behave as expected!
- Sign off :-D
Signed-off-by: Tomas Cohen Arazi
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 19:56:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 18:56:20 +0000
Subject: [Koha-bugs] [Bug 23949] koha-common.init missing actions for
koha-z3950-responder
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com
|ity.org |
Depends on| |13937
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937
[Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject
item status MARC subfields
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 19:56:20 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 18:56:20 +0000
Subject: [Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU
daemon that can inject item status MARC subfields
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937
Tomás Cohen Arazi changed:
What |Removed |Added
----------------------------------------------------------------------------
Blocks| |23949
Referenced Bugs:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949
[Bug 23949] koha-common.init missing actions for koha-z3950-responder
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 20:30:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 19:30:06 +0000
Subject: [Koha-bugs] [Bug 5276] subscription end date shouldn't be required
/ allow indefinite subscriptions
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5276
Kelly McElligott changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |kelly at bywatersolutions.com
--- Comment #3 from Kelly McElligott ---
This is still a valid bug. Adding this subscription expiration date (and even
the subscription length) as required, is very limiting to libraries who are not
concerned with this value but need to fill it out.
--
You are receiving this mail because:
You are the QA Contact for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 20:41:52 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 19:41:52 +0000
Subject: [Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful
error message
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075
--- Comment #28 from David Nind ---
The https version works fine, the http version produces errors as it is not a
'valid' URL.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 21:28:26 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 20:28:26 +0000
Subject: [Koha-bugs] [Bug 23948] Move mandatory .sql files to the mandatory/
directory
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23948
--- Comment #1 from Martin Renvoize ---
See bug 23895 which I think it's a duplicate of this.
Actually, just moving them doesn't mean they don't have to be explicitly
listed, right now the code in C4/Installer lists all mandatory files to nature
correct load order.. silly huh.
What 'tools' are you talking about? I've already updated misc4dev.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 21:45:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 20:45:03 +0000
Subject: [Koha-bugs] [Bug 22247]
Koha::IssuingRule->get_effective_issuing_rule has no hard fallback
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22247
Martin Renvoize changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|enhancement |normal
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 22:12:56 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 21:12:56 +0000
Subject: [Koha-bugs] [Bug 23862] Add enumchron to holds-table on checkout
page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23862
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Patch complexity|--- |Trivial patch
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 22:13:00 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 21:13:00 +0000
Subject: [Koha-bugs] [Bug 23862] Add enumchron to holds-table on checkout
page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23862
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #94821|0 |1
is obsolete| |
--- Comment #5 from Katrin Fischer ---
Created attachment 94958
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94958&action=edit
Bug 23862: add enumchron to holds-table
Signed-off-by: Kyle M Hall
Signed-off-by: Séverine QUEUNE
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 22:19:40 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 21:19:40 +0000
Subject: [Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and
does not indicate it is for SIP-based checkouts only
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
Status|Signed Off |Failed QA
--- Comment #20 from Katrin Fischer ---
Hi Joonas,
this one is confusing to me - from the bug title/description it only seemed to
affect the description of the pref/naming of the pref, so I expected an easy
QA, but there is definitely more going on here.
Can you explain why you removed the checks for the prefs in several parts of
the code? Especially the changes to GetItemsInfo.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 22:57:46 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 21:57:46 +0000
Subject: [Koha-bugs] [Bug 23950] New: Replace MARC21xslt materialtype PNG
icons with Font Awesome
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23950
Bug ID: 23950
Summary: Replace MARC21xslt materialtype PNG icons with Font
Awesome
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: OPAC
Assignee: oleonard at myacpl.org
Reporter: lucas at bywatersolutions.com
QA Contact: testopia at bugs.koha-community.org
We should replace all the PNG icons in the XSLT with font awesome. This will
replace all the materialtype icons in the MARC21slim2OPACDetail.xsl and
MARC21slim2OPACResults.xsl with Font Awesome
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 23:04:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 22:04:42 +0000
Subject: [Koha-bugs] [Bug 23950] Replace MARC21xslt materialtype PNG icons
with Font Awesome
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23950
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|NEW |Needs Signoff
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 23:04:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 22:04:44 +0000
Subject: [Koha-bugs] [Bug 23950] Replace MARC21xslt materialtype PNG icons
with Font Awesome
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23950
--- Comment #1 from Lucas Gass ---
Created attachment 94959
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94959&action=edit
Bug 23950: Replace MARC21xslt materialtype PNG icons with Font Awesome
1. Have all the material type icons handy by having records with the following
in the 6th position (t, o, m, e, g, k, r, I, j, c) and the following in the 7th
position (c, i, a)
2. Notice all the old PNG icons in both the OPAC results and the OPAC details
3. Apply patch.
4. Check all the items again (OPAC results and OPAC details) and make sure that
each has been updated to a Font Awesome Icon.
5. Rejoice.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 23:06:06 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 22:06:06 +0000
Subject: [Koha-bugs] [Bug 23950] Replace MARC21xslt materialtype PNG icons
with Font Awesome in the OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23950
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Replace MARC21xslt |Replace MARC21xslt
|materialtype PNG icons with |materialtype PNG icons with
|Font Awesome |Font Awesome in the OPAC
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 23:07:42 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Fri, 01 Nov 2019 22:07:42 +0000
Subject: [Koha-bugs] [Bug 23950] Replace MARC21xslt materialtype PNG icons
with Font Awesome in the OPAC
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23950
Lucas Gass changed:
What |Removed |Added
----------------------------------------------------------------------------
Assignee|oleonard at myacpl.org |lucas at bywatersolutions.com
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 11:33:13 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Nov 2019 10:33:13 +0000
Subject: [Koha-bugs] [Bug 22661] TinyMCE/WYSIWYG editor doesn't translate
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22661
--- Comment #14 from Katrin Fischer ---
I really love the handling of the newer editor and fixing the translatability
bug is almost just icing on the cake. Much more modern and I think I discovered
some features that weren't there before (or that I always missed).
Also tested the news editor.
Thx Owen! PQA!
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 11:33:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Nov 2019 10:33:21 +0000
Subject: [Koha-bugs] [Bug 22661] TinyMCE/WYSIWYG editor doesn't translate
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22661
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 11:41:58 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Nov 2019 10:41:58 +0000
Subject: [Koha-bugs] [Bug 23951] New: Sundy and Account management fee
missing from manual fine pull down
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23951
Bug ID: 23951
Summary: Sundy and Account management fee missing from manual
fine pull down
Change sponsored?: ---
Product: Koha
Version: master
Hardware: All
OS: All
Status: NEW
Severity: enhancement
Priority: P5 - low
Component: Fines and fees
Assignee: koha-bugs at lists.koha-community.org
Reporter: katrin.fischer at bsz-bw.de
QA Contact: testopia at bugs.koha-community.org
When comparing the pull down offered when creating a manual fine between 18.11
and master, there are some options missing:
- Account management fee
- Sundry
Is this a bug or by intention?
For libraries who have been using these and have built reports on them this
could be an issue.
--
You are receiving this mail because:
You are watching all bug changes.
You are the assignee for the bug.
From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 11:42:04 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Nov 2019 10:42:04 +0000
Subject: [Koha-bugs] [Bug 23951] Sundy and Account management fee missing
from manual fine pull down
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23951
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Severity|enhancement |normal
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 11:42:24 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Nov 2019 10:42:24 +0000
Subject: [Koha-bugs] [Bug 23951] Sundry and Account management fee missing
from manual fine pull down
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23951
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Summary|Sundy and Account |Sundry and Account
|management fee missing from |management fee missing from
|manual fine pull down |manual fine pull down
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 11:49:31 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Nov 2019 10:49:31 +0000
Subject: [Koha-bugs] [Bug 23079] Checkouts page broken because of problems
with date calculation (TZAmerica/Sao_Paulo)
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23079
--- Comment #23 from Katrin Fischer ---
(In reply to Jose Ricardo Quaglio from comment #22)
> Hello,
>
> I work at the public library of Sao Bernardo do Campo / Sao Paulo / Brazil.
>
> We have been using Koha since 2009, and we always have problems with the
> time zone.
>
> We currently use version 18 and have a homologation server with version 19,
> both with error.
>
> Today, 1/11/2019, we do not have "summer time".
>
> There is an error in the time zone of registering a new user, check out or
> renew materials.
>
> Error: "Internal Server Error" in "/cgi-bin/koha/members/memberentry.pl"
>
> When checking the log "plack-error":
> Wide character in print at /usr/share/perl5/CGI/Session/Driver/file.pm
> line 118.
> Wide character in print at /usr/share/perl5/CGI/Session/Driver/file.pm
> line 118.
> Invalid local time for date in time zone: America / Sao_Paulo
>
> Can someone help me?
>
> Tks,
Hi Jose, there are no versions 18 and 19, (there are 18.05, 18.11, 19.05 - two
a year and many bugfix releases between: 18.11.10...), you always need to give
us the full version number as listed on the about page to make it possible for
us to see if this should have been fixed by this patch or not.
When you experience the problem again, try manually changing the date expiry by
a bit to be able to work around it.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 11:52:29 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Nov 2019 10:52:29 +0000
Subject: [Koha-bugs] [Bug 23946] Remove Noun Project icons from the About
page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23946
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Needs Signoff |Signed Off
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 11:52:32 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Nov 2019 10:52:32 +0000
Subject: [Koha-bugs] [Bug 23946] Remove Noun Project icons from the About
page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23946
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Attachment #94955|0 |1
is obsolete| |
--- Comment #2 from Katrin Fischer ---
Created attachment 94960
-->
https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94960&action=edit
Bug 23946: Remove Noun Project icons from the About page
This patch removes the part of the About page which gives attribution
for Noun Project icons on the staff client home page.
To test, apply the patch and view the About page in the staff client.
There should be no reference to Noun Project icons.
Signed-off-by: Katrin Fischer
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 11:53:03 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Nov 2019 10:53:03 +0000
Subject: [Koha-bugs] [Bug 23946] Remove Noun Project icons from the About
page
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23946
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
Status|Signed Off |Passed QA
CC| |katrin.fischer at bsz-bw.de
--- Comment #3 from Katrin Fischer ---
Basically a string patch and a logical consequence of bug 23711. PQA.
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 12:02:21 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Nov 2019 11:02:21 +0000
Subject: [Koha-bugs] [Bug 23658] [18.11] WrongTransfer modal drops off
specified checkin date on returns.pl
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23658
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
Summary|WrongTransfer modal drops |[18.11] WrongTransfer modal
|off specified checkin date |drops off specified checkin
|on returns.pl |date on returns.pl
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 12:13:44 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Nov 2019 11:13:44 +0000
Subject: [Koha-bugs] [Bug 23684] Import items only with merging rule
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23684
--- Comment #5 from Katrin Fischer ---
Hi Villam, this reminded me of bug 18757 - I wonder if this could be part of
the problem? It's marked to affect UNIMARC only, but the change is general.
--
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 12:14:59 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Nov 2019 11:14:59 +0000
Subject: [Koha-bugs] [Bug 19780] Actual price is not updated after it has
been amended post receiving an order
In-Reply-To:
References:
Message-ID:
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19780
Katrin Fischer changed:
What |Removed |Added
----------------------------------------------------------------------------
CC| |katrin.fischer at bsz-bw.de
Attachment #73359|0 |1
is obsolete| |
--
You are receiving this mail because:
You are watching all bug changes.
From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 12:16:30 2019
From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org)
Date: Sat, 02 Nov 2019 11:16:30 +0000
Subject: [Koha-bugs] [Bug 19780] Actual price is not updated after it has
been amended post receiving an order
In-Reply-To: