From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 00:03:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Oct 2019 23:03:25 +0000 Subject: [Koha-bugs] [Bug 23914] Hea - share the DBMS (name and version) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23914 --- Comment #8 from Katrin Fischer --- ... meaning I think we as a community agreed on working towards supporting other RDBMS like Postgres and if we want to change direction, we need to have a discussion as a community. But I think it was one of the main selling points of DBIx::Class (https://wiki.koha-community.org/wiki/RFC_for_using_DBIx_Class_in_Koha). And now I will stop derailing this bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 00:10:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Oct 2019 23:10:48 +0000 Subject: [Koha-bugs] [Bug 23805] Add a dedicated credit_types table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 --- Comment #51 from Katrin Fischer --- I am really unhappy about this tbh - we are introducing database specific things. Pretty new to the RDBMS too if I under understand Julian's comment on bug 23914 correctly and with different syntax already for the 2 RDBMS we support atm. We had agreed on not using MysqlIsms as a community and we should have discussed this... Is it really worth it? Do we need this check so urgently and can't solve this in another way? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 00:28:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 31 Oct 2019 23:28:14 +0000 Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084 --- Comment #42 from Nightly Build Bot --- Created attachment 94933 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94933&action=edit Bug 17084- Automatic debian/control updates (unstable/master) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 06:43:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 05:43:17 +0000 Subject: [Koha-bugs] [Bug 23805] Add a dedicated credit_types table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 --- Comment #52 from Martin Renvoize --- Check constraints are not a mysqlism and have been in mariadb since 4 Jul 2016, postgres since before 2001-08-15.. they're not be thing. I will remove the constraint if people are really that anti having consistent data. It really is a "do no harm" feature, I don't see why people are getting so sound up about it. The database update threw a warning but carried on and didn't break anything.. you just ended up without the constraint. If we bring this silly about supported systems we should be removing the entire restful API in my mmm opinion as mojolicious is far less easily packaged, faster moving and unstable. I've said my piece. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 07:20:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 06:20:15 +0000 Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084 --- Comment #43 from Martin Renvoize --- Latest pushed to 19.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 07:20:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 06:20:25 +0000 Subject: [Koha-bugs] [Bug 17084] Automatic debian/control updates (master) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17084 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94933|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 07:25:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 06:25:33 +0000 Subject: [Koha-bugs] [Bug 23805] Add a dedicated credit_types table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 --- Comment #53 from Martin Renvoize --- As a final note, there has been a check constraint in Koha since 2012-09-12 when one was added as part of bug 5911 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 07:31:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 06:31:06 +0000 Subject: [Koha-bugs] [Bug 23942] New: After upgrading koha from version 16.5 to 18.11 itemtype, itype and other list boxes corresponding to authorised values attached to frameworks fail to show the selected values upon editing the bib and item records Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23942 Bug ID: 23942 Summary: After upgrading koha from version 16.5 to 18.11 itemtype, itype and other list boxes corresponding to authorised values attached to frameworks fail to show the selected values upon editing the bib and item records Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: rajujogi.t at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Created attachment 94934 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94934&action=edit Item editor does not show the previous values for the list boxes I have upgraded Koha from version 16.5 to 18.11. After that when I edit the biblio record the itemtype list box (942$c) does not show the previous value. In the same way when the item records edited the list boxes corresponding to the authorised values LOST, DAMAGED, LOC, NOT_FOR_LOAN, RESTRICTED and itype (itemtypes) the previous values are not shown in the editor. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 07:35:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 06:35:15 +0000 Subject: [Koha-bugs] [Bug 23827] Cash register statistics uses old accounttype values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23827 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |BLOCKED --- Comment #14 from Marcel de Rooy --- QAing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 07:41:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 06:41:30 +0000 Subject: [Koha-bugs] [Bug 23827] Cash register statistics uses old accounttype values In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23827 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Patch doesn't apply --- Comment #15 from Marcel de Rooy --- CONFLICT (content): Merge conflict in reports/cash_register_stats.pl CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/reports/cash_register_stats.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 07:51:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 06:51:17 +0000 Subject: [Koha-bugs] [Bug 22844] Simplify the process of selecting database columns for system preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22844 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 07:51:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 06:51:54 +0000 Subject: [Koha-bugs] [Bug 20116] Cache language list In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #43 from Marcel de Rooy --- (In reply to Jonathan Druart from comment #42) > Still waiting for another QA feedback, back to NQA. I am still hoping for tests :) Note even that this patch set breaks a test when these patches are applied and does not when not. t/db_dependent/Languages.t (Wstat: 512 Tests: 18 Failed: 2) Failed tests: 11, 13 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 07:55:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 06:55:33 +0000 Subject: [Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Keywords|rel_19_11_candidate |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 07:57:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 06:57:44 +0000 Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 07:57:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 06:57:54 +0000 Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_19_11_candidate |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 07:59:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 06:59:11 +0000 Subject: [Koha-bugs] [Bug 17483] Forgiving charge should apply to item's last fine. In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17483 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version|master |18.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 08:00:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 07:00:12 +0000 Subject: [Koha-bugs] [Bug 22630] Allow to change homebranch in course reserves In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22630 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_19_11_candidate |rel_20_05_target CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 08:01:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 07:01:11 +0000 Subject: [Koha-bugs] [Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_19_11_candidate CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 08:04:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 07:04:20 +0000 Subject: [Koha-bugs] [Bug 22284] Groups of pickup locations for holds In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22284 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_19_11_candidate |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 08:07:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 07:07:33 +0000 Subject: [Koha-bugs] [Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #35 from Marcel de Rooy --- QAing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 08:15:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 07:15:52 +0000 Subject: [Koha-bugs] [Bug 22581] Add support for Plaine & Easie musical incipits rendering in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #15 from Martin Renvoize --- All works as expected for me and I 'think' my comments have all been resolved. Marking as Signed off.. (Will add SO line to patches on push) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 08:23:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 07:23:12 +0000 Subject: [Koha-bugs] [Bug 22421] accountlines.issue_id is missing a foreign key constraint In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22421 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 08:25:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 07:25:05 +0000 Subject: [Koha-bugs] [Bug 15283] Switch default ISSUEQSLIP notice to Template Toolkit In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15283 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 08:25:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 07:25:21 +0000 Subject: [Koha-bugs] [Bug 23890] Plugins that utilise possibly security breaching hooks should warn In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23890 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 08:26:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 07:26:16 +0000 Subject: [Koha-bugs] [Bug 5501] Improve the 'do not notify' option In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5501 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy |rel_20_05_target -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 08:26:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 07:26:56 +0000 Subject: [Koha-bugs] [Bug 22745] Need a "Do not notify" option in messaging preferences In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22745 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_target -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 08:27:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 07:27:49 +0000 Subject: [Koha-bugs] [Bug 18506] SSO - Shibboleth Only Mode In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18506 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_19_11_candidate |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 08:31:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 07:31:24 +0000 Subject: [Koha-bugs] [Bug 15523] Move a number of sysprefs to circulation rules (Omnibus) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15523 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Keywords| |rel_20_05_target -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 08:33:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 07:33:38 +0000 Subject: [Koha-bugs] [Bug 14845] Fines forgiven even when WhenLostForgiveFine is set to 'Don't Forgive' In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14845 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|NEW |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 08:34:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 07:34:44 +0000 Subject: [Koha-bugs] [Bug 22818] ILL should be able to send notices In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22818 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_19_11_candidate |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 08:36:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 07:36:37 +0000 Subject: [Koha-bugs] [Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_19_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 08:36:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 07:36:51 +0000 Subject: [Koha-bugs] [Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 08:42:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 07:42:07 +0000 Subject: [Koha-bugs] [Bug 23859] Cities endpoint not setting the Location header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23859 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 08:42:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 07:42:42 +0000 Subject: [Koha-bugs] [Bug 23860] Patrons endpoint not setting the Location header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23860 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 08:42:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 07:42:49 +0000 Subject: [Koha-bugs] [Bug 23695] Items holdingbranch should be set to the originating library when generating a manual transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23695 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|martin.renvoize at ptfs-europe |testopia at bugs.koha-communit |.com |y.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 08:43:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 07:43:36 +0000 Subject: [Koha-bugs] [Bug 23695] Items holdingbranch should be set to the originating library when generating a manual transfer In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23695 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 08:44:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 07:44:14 +0000 Subject: [Koha-bugs] [Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958 --- Comment #36 from Marcel de Rooy --- (In reply to Marcel de Rooy from comment #15) > Failing QA because this patch has side-effects when you cancel a hold from > the confirm hold popup. Before we called GetOtherReserves and now we dont. Still looking at my older comment, and having the feeling that it was kind of ignored. Let me rephrase it by showing this diff part: } else { my $diffBranchSend = ($userenv_branch ne $diffBranchReturned) ? $diffBranchReturned : undef; + # diffBranchSend tells ModReserveAffect whether document is expected in this library or not, # i.e., whether to apply waiting status ModReserveAffect( $itemnumber, $borrowernumber, $diffBranchSend, $reserve_id ); - } -# check if we have other reserves for this document, if we have a return send the message of transfer - my ( $messages, $nextreservinfo ) = GetOtherReserves($itemnumber); As you can see here, the GetOtherReserves call and code around it was placed AFTER the else, but we remove the closing accolade and put the new code INTO the else branch. So what happens: if you come from the if branch (you canceled a hold), you wont jump into the GetOtherReserves stuff anymore. Still does not look good to me. Please convince me with some good arguments! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 08:45:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 07:45:35 +0000 Subject: [Koha-bugs] [Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 08:48:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 07:48:53 +0000 Subject: [Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED CC| |m.de.rooy at rijksmuseum.nl --- Comment #24 from Marcel de Rooy --- QAing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:19:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 08:19:47 +0000 Subject: [Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 --- Comment #25 from Marcel de Rooy --- not ok 19 - AddReturn must have debarred the patron # Failed test 'AddReturn must have debarred the patron' # at t/db_dependent/Circulation.t line 86. # got: '' # expected: '1' # AddReturn returned message $VAR1 = { # 'WasReturned' => 1 # }; not ok 20 - Test at line 1922 # Failed test 'Test at line 1922' # at t/db_dependent/Circulation.t line 90. # got: '0' # expected: '1' not ok 21 - Test at line 1922 # Failed test 'Test at line 1922' # at t/db_dependent/Circulation.t line 93. # got: undef # expected: '2019-11-15' # Looks like you failed 3 tests of 21. not ok 29 - AddReturn + suspension_chargeperiod # Failed test 'AddReturn + suspension_chargeperiod' # at t/db_dependent/Circulation.t line 1931. # Looks like you failed 1 test of 45. First time I ran Circulation.t, I got this. But I do not manage to reproduce it another time ;) And it seems unrelated. No holds stuff there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:32:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 08:32:46 +0000 Subject: [Koha-bugs] [Bug 23943] New: koha-run-backups --days is misleading Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23943 Bug ID: 23943 Summary: koha-run-backups --days is misleading Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Packaging Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org CC: mirko at abunchofthings.net The documentation for the --days option to koha-run-backups says: --days: the number of days to keep backups around for (default: 2) Sometimes I do the following: 1. Rename a backupfile, e.g. from instance-2019-10-22.sql.gz to instance-2019-10-22-1230.sql.gz 2. Run koha-dump to create a new instance-2019-10-22.sql.gz This reveals that --days does not really care about days at all, just the number of files in the backup dir. This means that if I have adjusted the cronjob to keep backups for 14 days, after the next time it runs, I actually have backups for 13 days. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:36:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 08:36:54 +0000 Subject: [Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA --- Comment #26 from Marcel de Rooy --- ($resfound, $resrec, undef) = C4::Reserves::CheckReserves( $item->itemnumber, undef, $lookahead ) unless ( $item->withdrawn ); # if a hold is found and is waiting at another branch, change the priority back to 1 and trigger the hold (this will trigger a transfer and update the hold status properly) if ( $resfound eq "Waiting" and $branch ne $resrec->{branchcode} ) { C4::Reserves::RevertWaitingStatus( { itemnumber => $item->itemnumber } ); #If the hold is reverted we need to refetch for the return values ($resfound, $resrec, undef) = C4::Reserves::CheckReserves( $item->itemnumber, undef, $lookahead ) unless ( $item->withdrawn ); } ($resfound, $resrec, undef) = C4::Reserves::CheckReserves( $item->itemnumber, undef, $lookahead ) unless ( $item->withdrawn ); In short what do we see here: call CheckReserves if( ) call CheckReserves endif call CheckReserves Three times in a row ? Please explain why you also add the last call. Rebase problem? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:37:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 08:37:11 +0000 Subject: [Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:39:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 08:39:26 +0000 Subject: [Koha-bugs] [Bug 23859] Cities endpoint not setting the Location header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23859 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:42:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 08:42:06 +0000 Subject: [Koha-bugs] [Bug 22814] Holds modal patron name display inconsistency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22814 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:42:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 08:42:09 +0000 Subject: [Koha-bugs] [Bug 22814] Holds modal patron name display inconsistency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22814 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94213|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy --- Created attachment 94937 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94937&action=edit Bug 22814: Make patron names on holds modal consistent (second check-in) Bug 22203 changed the behavior on the hold-found2 modal that pops up when a hold is found so that whether or not the patron's name is displayed is now governed by the HidePatronName system preference. However, if a hold is confirmed and you check the item in a second time, the modal that pops up is hold-found1 and whether or not the patron's name is displayed in the hold-found1 modal is not governed by the HidePatronName system preference. For the sake of consistency, the display of the patron's name on hold-found2 and hold-found1 should both be governed by the HidePatronName system preference. To test: - Place a hold on an item - Check in the item to trigger the hold modal - Confirm hold - Check the item in again - verify name of patron displays - Apply patch - Repeat - Verify name display now matches between the two modals - change HidePatronName pref - Repeat - Name display should still match Signed-off-by: Owen Leonard Signed-off-by: Marcel de Rooy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:42:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 08:42:15 +0000 Subject: [Koha-bugs] [Bug 23859] Cities endpoint not setting the Location header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23859 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94498|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 94938 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94938&action=edit Bug 23859: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:42:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 08:42:18 +0000 Subject: [Koha-bugs] [Bug 23859] Cities endpoint not setting the Location header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23859 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94499|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 94939 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94939&action=edit Bug 23859: Make POST add the Location header on cities endpoint According to the coding guidelines, this endpoint should be adding the Location header on POST actions. To test: 1. Apply the tests patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/cities.t => FAIL: Tests fail! 3. Apply this patch 4. Repeat (1) => SUCCESS: Tests pass! 5. Sign off :-D Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:42:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 08:42:22 +0000 Subject: [Koha-bugs] [Bug 23859] Cities endpoint not setting the Location header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23859 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94500|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize --- Created attachment 94940 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94940&action=edit Bug 23859: Update tests to new style The /cities endpoint is refered in several places as the reference implementation of a route for devs to pick it for copy and pasting. Yet, it is outdated in terms of how the tests are written. This patch rewrites some bits so it uses BASIC auth and the built-ins Test::Mojo provides. Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:42:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 08:42:23 +0000 Subject: [Koha-bugs] [Bug 22814] Holds modal patron name display inconsistency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22814 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:42:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 08:42:41 +0000 Subject: [Koha-bugs] [Bug 23859] Cities endpoint not setting the Location header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23859 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:43:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 08:43:27 +0000 Subject: [Koha-bugs] [Bug 23859] Cities endpoint not setting the Location header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23859 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from Martin Renvoize --- Trivial patch that improves the consistency of our API's. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:45:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 08:45:53 +0000 Subject: [Koha-bugs] [Bug 23860] Patrons endpoint not setting the Location header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23860 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94583|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize --- Created attachment 94941 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94941&action=edit Bug 23860: Regression tests Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:45:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 08:45:57 +0000 Subject: [Koha-bugs] [Bug 23860] Patrons endpoint not setting the Location header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23860 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94584|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize --- Created attachment 94942 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94942&action=edit Bug 23860: Make the patrons endpoint add the Location header Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:46:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 08:46:00 +0000 Subject: [Koha-bugs] [Bug 23860] Patrons endpoint not setting the Location header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23860 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94585|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize --- Created attachment 94943 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94943&action=edit Bug 23860: Update tests to new style Signed-off-by: Tomas Cohen Arazi Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:46:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 08:46:12 +0000 Subject: [Koha-bugs] [Bug 23860] Patrons endpoint not setting the Location header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23860 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:46:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 08:46:48 +0000 Subject: [Koha-bugs] [Bug 23860] Patrons endpoint not setting the Location header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23860 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Martin Renvoize --- Trivial patch that improves the consistency of our API's. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:48:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 08:48:36 +0000 Subject: [Koha-bugs] [Bug 17359] Patron import results use wrong encoding In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17359 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |BLOCKED --- Comment #26 from Marcel de Rooy --- QAing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:48:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 08:48:58 +0000 Subject: [Koha-bugs] [Bug 23859] Cities endpoint not setting the Location header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23859 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:49:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 08:49:00 +0000 Subject: [Koha-bugs] [Bug 23859] Cities endpoint not setting the Location header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23859 --- Comment #9 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:49:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 08:49:02 +0000 Subject: [Koha-bugs] [Bug 23860] Patrons endpoint not setting the Location header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23860 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:49:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 08:49:03 +0000 Subject: [Koha-bugs] [Bug 23860] Patrons endpoint not setting the Location header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23860 --- Comment #8 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:50:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 08:50:47 +0000 Subject: [Koha-bugs] [Bug 22814] Holds modal patron name display inconsistency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22814 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:53:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 08:53:14 +0000 Subject: [Koha-bugs] [Bug 21824] Add ability to format dates in various formats in templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:53:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 08:53:16 +0000 Subject: [Koha-bugs] [Bug 21824] Add ability to format dates in various formats in templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 --- Comment #37 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:53:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 08:53:19 +0000 Subject: [Koha-bugs] [Bug 22814] Holds modal patron name display inconsistency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22814 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 09:53:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 08:53:21 +0000 Subject: [Koha-bugs] [Bug 22814] Holds modal patron name display inconsistency In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22814 --- Comment #4 from Martin Renvoize --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 10:03:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 09:03:09 +0000 Subject: [Koha-bugs] [Bug 23765] After TranslateNotices is set to 'Don't allow', email settings still show multiple languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23765 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 10:03:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 09:03:25 +0000 Subject: [Koha-bugs] [Bug 23765] After TranslateNotices is set to 'Don't allow', email settings still show multiple languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23765 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |bin.wen at inlibro.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 11:12:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 10:12:49 +0000 Subject: [Koha-bugs] [Bug 17359] Patron import results use wrong encoding In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17359 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA --- Comment #27 from Marcel de Rooy --- QA Comment: my $surname ='Chloé'; my $surname_utf8 = encode_utf8($surname); => This name is not the best example for UTF-8. Could be Latin too. => You dont do anything with this encoded string. => When I am adding some Chinese character in the surname, the test fails. decode_utf8($borrowerline) Instead of adding this all over the place, we should try to fix at the source or at least closer. LINE: while ( my $borrowerline = <$handle> ) { You could add it here, which would be closer but thats not all. Is the assumption correct that it is UTF-8? We just got a handle from the caller. On the report I am reading about people uploading Latin data. Actually, we see in tools/import_borrowers.pl: use CGI qw ( -utf8 ); and my $handle = $input->upload('uploadborrowers'); CGI tells me that "binary upload data ... are left untouched". Do we actually need another parameter for the file encoding? Looks like this needs some more attention. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 11:12:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 10:12:58 +0000 Subject: [Koha-bugs] [Bug 17359] Patron import results use wrong encoding In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17359 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 11:14:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 10:14:49 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |BLOCKED --- Comment #10 from Marcel de Rooy --- QAing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 11:15:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 10:15:38 +0000 Subject: [Koha-bugs] [Bug 23765] After TranslateNotices is set to 'Don't allow', email settings still show multiple languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23765 --- Comment #4 from Martin Renvoize --- Hmmm, I'm wondering if this should be caught at a higher level.. the issue to me is that C4::Letters::GetLetterTemplates returns multiple languages even if TranslateNotices is set to "Don't allow"... I'm wondering if fixing it at this level would catch some other cases where TranslateNotices isn't being checked perhaps? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 11:27:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 10:27:55 +0000 Subject: [Koha-bugs] [Bug 23765] After TranslateNotices is set to 'Don't allow', email settings still show multiple languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23765 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 11:34:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 10:34:31 +0000 Subject: [Koha-bugs] [Bug 23719] Record matching for authorities using defined fields is broken under ES In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23719 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact| |jonathan.druart at bugs.koha-c | |ommunity.org CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 11:34:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 10:34:58 +0000 Subject: [Koha-bugs] [Bug 23719] Record matching for authorities using defined fields is broken under ES In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23719 --- Comment #7 from Martin Renvoize --- Does the extra patch here resolve your worries Jonathan? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 11:46:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 10:46:38 +0000 Subject: [Koha-bugs] [Bug 23089] Elasticsearch - cannot sort on non-text fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23089 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94617|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize --- Created attachment 94944 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94944&action=edit Bug 23089: Unit tests Signed-off-by: Ere Maijala Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 11:46:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 10:46:42 +0000 Subject: [Koha-bugs] [Bug 23089] Elasticsearch - cannot sort on non-text fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23089 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94618|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize --- Created attachment 94945 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94945&action=edit Bug 23089: Fix sorting on sum and regular fields As of bug 20589 we no longer analyze sort fields and so we no longer need to append ".phrase" to our sort in searches. Additionally, sort fields based on 'sum' should also use sum in building the value to sort on To test: 0 - Be using ES 1 - Find the most circulated item in your collection 2 - Search for '*' 3 - Sort by popularity DESC 4 - Note that item is not first 5 - Try to sort by anything but relevancy, it fails 6 - Apply patch 7 - Redo searches and sorts 8 - Things should now work as expected Signed-off-by: Ere Maijala Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 11:46:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 10:46:46 +0000 Subject: [Koha-bugs] [Bug 23089] Elasticsearch - cannot sort on non-text fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23089 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94656|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize --- Created attachment 94946 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94946&action=edit Bug 23089: Fix QueryBuilder tests. Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 11:47:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 10:47:33 +0000 Subject: [Koha-bugs] [Bug 23089] Elasticsearch - cannot sort on non-text fields In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23089 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #14 from Martin Renvoize --- Works as expected, has tests, passes tests and passes QA script. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 11:56:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 10:56:00 +0000 Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:00:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 11:00:04 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA --- Comment #11 from Marcel de Rooy --- Hi Augustin, I would like to see you optimize a bit. for => $table_to_anonymize Both anonymize and anonymise are correct and in use, but you mix them on this report (no blocker, just seeing it). The z spelling is American. But I do not really understand why you put the patron select in search_patrons_to_anonymise. Why not leave this sub alone? We could directly call anonymise_items_last_borrower, since you are not really interested in the patrons here. And optimize it rightaway. Make the query in the new sub, and run update on that result set without looping with next? Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:00:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 11:00:12 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:04:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 11:04:13 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14570, 17168 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 [Bug 14570] Make it possible to add multiple guarantors to a record https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168 [Bug 17168] Add a command line script for updating patron category based on status -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:04:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 11:04:13 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12446 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 [Bug 12446] Enable an adult to have a guarantor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:04:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 11:04:13 +0000 Subject: [Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |12446 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 [Bug 12446] Enable an adult to have a guarantor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:04:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 11:04:35 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:04:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 11:04:44 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|Small patch |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:05:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 11:05:01 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:06:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 11:06:16 +0000 Subject: [Koha-bugs] [Bug 19809] Koha::Objects::find calls do not need to be forbidden in list context In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809 --- Comment #11 from Marcel de Rooy --- (In reply to Martin Renvoize from comment #10) > This seems sane to me and I like to follow the example set by DBIx::Class to > be honest.. that project has been around for a long time and has made allot > of good decisions for good reasons. I would agree with you if we were writing Koha::Objects->find at this moment. But in the meantime they go back to bug 13019, pushed 02/2015. How many find calls do we have now, and associated if conditions etc.? In view of that volume and the risk of breaking a lot of code, I would not recommend it now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:06:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 11:06:58 +0000 Subject: [Koha-bugs] [Bug 20388] Elasticsearch - Ability to add search fields from UI In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20388 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:14:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 11:14:16 +0000 Subject: [Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten using the patron import tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #8 from Marcel de Rooy --- diff --git a/Koha/Patron.pm b/Koha/Patron.pm index 8e501fcfb1..787713524e 100644 --- a/Koha/Patron.pm +++ b/Koha/Patron.pm @@ -250,7 +250,6 @@ sub store { # Make a copy of the plain text password for later use $self->plain_text_password( $self->password ); - Please remove that one from your patch. No need to. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:16:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 11:16:00 +0000 Subject: [Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten using the patron import tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473 --- Comment #9 from Marcel de Rooy --- + if ($overwrite_passwords){ + $patron->set_password({ password => $borrower{password} }); + } set_password may throw several exceptions, we should do some checking here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:16:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 11:16:04 +0000 Subject: [Koha-bugs] [Bug 20194] Display both biblioitems.itemtype and items.itype in circulation screens In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20194 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93221|0 |1 is obsolete| | --- Comment #21 from Martin Renvoize --- Created attachment 94947 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94947&action=edit Bug 20194: Display both biblioitems.itemtype and items.itype in circulation screens Test plan: 1. Verify that biblioitems.itemtype, items.itype are mapped to a MARC field. Otherwise create those mappings. 2. Create a biblio with an itemtype 3. Create an item with a different itemtype for this biblio 4. Check out this item to a patron (P1) 5. Verify that both itemtypes are displayed in the checkouts table (moremember.pl, circulation.pl, returns.pl) 6. Create a patron whose guarantor is P1 and verify that both itemtypes and the ccode are displayed in the 'relatives checkouts' table Followed test plan, patch worked as described, also passes QA test tool Signed-off-by: Alex Buckley Signed-off-by: Nick Clemens Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:16:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 11:16:53 +0000 Subject: [Koha-bugs] [Bug 20194] Display both biblioitems.itemtype and items.itype in circulation screens In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20194 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #22 from Martin Renvoize --- Works well and I think clarifies things to the end user.. Passes QA scripts, Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:16:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 11:16:59 +0000 Subject: [Koha-bugs] [Bug 20194] Display both biblioitems.itemtype and items.itype in circulation screens In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20194 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:17:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 11:17:41 +0000 Subject: [Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten using the patron import tool In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473 Marcel de Rooy changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:18:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 11:18:52 +0000 Subject: [Koha-bugs] [Bug 23762] Editing is_html status of email template fails under multi-languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23762 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:19:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 11:19:12 +0000 Subject: [Koha-bugs] [Bug 23762] Editing is_html status of email template fails under multi-languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23762 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |bin.wen at inlibro.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:20:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 11:20:08 +0000 Subject: [Koha-bugs] [Bug 23762] Editing is_html status of email template fails under multi-languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23762 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93820|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:23:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 11:23:01 +0000 Subject: [Koha-bugs] [Bug 23762] Editing is_html status of email template fails under multi-languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23762 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93906|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize --- Created attachment 94948 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94948&action=edit Bug 23762: Editing is_html status of email template fails under multi-languages To test: 1.Enable multi-languages 2.Set the preference 'TranslateNotices' on 'Allow' 3.Go to: tools==>Notices & slips==>Edit (one notice) 4.Click on the "Email" in the Default, uncheck the checkbox for 'HTML Messages'. 5.Save 6.Reopen the notice, nothing changed. 7.Apply the patch 8.Repeat the steps 4 and 5 9.Success. Signed-off-by: Katrin Fischer Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:23:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 11:23:10 +0000 Subject: [Koha-bugs] [Bug 23762] Editing is_html status of email template fails under multi-languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23762 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:24:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 11:24:25 +0000 Subject: [Koha-bugs] [Bug 23805] Add a dedicated credit_types table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 --- Comment #54 from Julian Maurice --- (In reply to Martin Renvoize from comment #52) > Check constraints are not a mysqlism and have been in mariadb since 4 Jul > 2016, postgres since before 2001-08-15.. they're not be thing. > > I will remove the constraint if people are really that anti having > consistent data. It really is a "do no harm" feature, I don't see why > people are getting so sound up about it. The database update threw a > warning but carried on and didn't break anything.. you just ended up without > the constraint. > > If we bring this silly about supported systems we should be removing the > entire restful API in my mmm opinion as mojolicious is far less easily > packaged, faster moving and unstable. > > I've said my piece. Just to be clear, I am all for consistent data, but I'm also all for consistent behaviour. That's why I think Koha shouldn't use a database feature that is not supported by all database systems supported by Koha (btw, does the list of supported databases - with versions - exist somewhere ?). With a CHECK constraint, someone with MySQL 8.0.16+ will have different database constraints than someone with MySQL 5.7. So, possibly different behaviours, bugs that are hard to reproduce, ... And that, IMO, should be avoided if possible. That particular problem could be solved if we decide that Koha now requires at least MySQL 8.0.16 (which is 6 months old) or MariaDB 10.2 (first 10.2 stable version is more than 2 years old). But there's still the problem of the error message shown during updatedatabase.pl (because of different syntax) that need to be solved (maybe in a new bug ?) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:24:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 11:24:48 +0000 Subject: [Koha-bugs] [Bug 23762] Editing is_html status of email template fails under multi-languages In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23762 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Martin Renvoize --- Code makes sense, bug replicated and proved to be resolved by this patch. Passes QA scripts and although I'd love to have seen an accompanying selenium test that's not a blocker. Passing QA. Minor note.. please remember to alter the 'Importance' of bugs.. This was labelled as an enhancement when in my mind it's a bug. Nice work finding and fixing though Bin Wen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:25:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 11:25:17 +0000 Subject: [Koha-bugs] [Bug 23663] Itemtype summary feature in search results is only used in deprecated opac results non-xslt view In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23663 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:26:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 11:26:22 +0000 Subject: [Koha-bugs] [Bug 23658] WrongTransfer modal drops off specified checkin date on returns.pl In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23658 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:42:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 11:42:45 +0000 Subject: [Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #27 from Martin Renvoize --- (In reply to Jonathan Druart from comment #26) > (In reply to Martin Renvoize from comment #25) > > Created attachment 94363 [details] > > screenshot > > > > This is what I see with the patch applied. > > Try with http://mana-test.koha-community.org But that is a 'good' URL.. so I don't expect to see any errors.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:55:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 11:55:00 +0000 Subject: [Koha-bugs] [Bug 23938] Title missing from Checked out box In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23938 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:55:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 11:55:02 +0000 Subject: [Koha-bugs] [Bug 23938] Title missing from Checked out box In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23938 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94932|0 |1 is obsolete| | --- Comment #3 from Owen Leonard --- Created attachment 94949 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94949&action=edit Bug 23938: Restore title display in last checked out box To test: 1 - Check out to a patron 2 - Note the display under the checkotu box does not have title 3 - Apply patch 4 - Checkout another item 5 - Note the title displays Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:55:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 11:55:16 +0000 Subject: [Koha-bugs] [Bug 23938] Title missing from Checked out box In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23938 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:57:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 11:57:49 +0000 Subject: [Koha-bugs] [Bug 22922] Allow to modify hold and hold expiration date in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 12:57:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 11:57:56 +0000 Subject: [Koha-bugs] [Bug 22922] Allow to modify hold and hold expiration date in staff In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22922 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 13:04:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 12:04:11 +0000 Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 13:04:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 12:04:44 +0000 Subject: [Koha-bugs] [Bug 23463] Move C4::Items CRUD subroutines to Koha::Item In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23463 --- Comment #4 from Martin Renvoize --- Lets hit this one hard beginning of next cycle :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 13:13:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 12:13:32 +0000 Subject: [Koha-bugs] [Bug 23944] New: Phase out use of jquery.cookie.js in favor of js.cookie.js Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 Bug ID: 23944 Summary: Phase out use of jquery.cookie.js in favor of js.cookie.js Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org The jQuery plugin we use for setting cookies is obsolete: https://github.com/carhartl/jquery-cookie -- "No longer maintained, superseded by JS Cookie: https://github.com/js-cookie/js-cookie" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 13:15:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 12:15:02 +0000 Subject: [Koha-bugs] [Bug 23938] Title missing from Checked out box In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23938 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 14:05:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 13:05:15 +0000 Subject: [Koha-bugs] [Bug 23805] Add a dedicated credit_types table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 --- Comment #55 from Katrin Fischer --- The update fails on the MariaDB version in my kohadevbox: Server version: 10.1.38-MariaDB-0+deb9u1 Debian 9.8 See discussion on IRC: http://irc.koha-community.org/koha/2019-11-01#i_2186242 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 14:07:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 13:07:19 +0000 Subject: [Koha-bugs] [Bug 23938] Title missing from Checked out box In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23938 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 14:07:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 13:07:23 +0000 Subject: [Koha-bugs] [Bug 23938] Title missing from Checked out box In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23938 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94949|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer --- Created attachment 94950 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94950&action=edit Bug 23938: Restore title display in last checked out box To test: 1 - Check out to a patron 2 - Note the display under the checkotu box does not have title 3 - Apply patch 4 - Checkout another item 5 - Note the title displays Signed-off-by: Owen Leonard -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 14:11:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 13:11:23 +0000 Subject: [Koha-bugs] [Bug 23942] After upgrading koha from version 16.5 to 18.11 itemtype, itype and other list boxes corresponding to authorised values attached to frameworks fail to show the selected values upon editing the bib and item records In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23942 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Did you see any errors during your update? Are the itemtypes and authorised values still configured correctly? Did you check the configuration in your frameworks? I would recommend bringing this up on the mailing list first to rule out a problem specific to your installation. We have run updates up to 18.11 and have never seen any issue like that. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 14:14:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 13:14:47 +0000 Subject: [Koha-bugs] [Bug 23805] Add a dedicated credit_types table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 --- Comment #56 from Martin Renvoize --- I've plain removed the check constraints from both this bug and 23049 too.. Clearly people are generally not interested in data integrity and it's causing too many headaches attempting to pretend MariaDB and MySQL are the same. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 14:14:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 13:14:53 +0000 Subject: [Koha-bugs] [Bug 23805] Add a dedicated credit_types table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 14:15:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 13:15:12 +0000 Subject: [Koha-bugs] [Bug 23937] Clear filter in Acquisitions Search doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23937 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |oleonard at myacpl.org --- Comment #2 from Katrin Fischer --- I think it's greyed out because the database filter is empty. I think there is a difference between the datatables filter and the sql filtering/search done from the search above shown on the left. You need to clear it out there and search again. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 14:15:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 13:15:19 +0000 Subject: [Koha-bugs] [Bug 23944] Phase out use of jquery.cookie.js in favor of js.cookie.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 14:15:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 13:15:21 +0000 Subject: [Koha-bugs] [Bug 23944] Phase out use of jquery.cookie.js in favor of js.cookie.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 --- Comment #1 from Owen Leonard --- Created attachment 94951 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94951&action=edit Bug 23944: Phase out use of jquery.cookie.js in favor of js.cookie.js This patch adds a new JavaScript file to the staff client's global JavaScript include file: js.cookie-2.2.1.min.js. This "plugin" will replace jquery.cookie.js which is no longer maintained. The "About" page in the staff client is updated to include this new resource as well as adding previously-missing information about the old plugin which will remain until all instances of its usage have been removed. To test, apply the patch and check the About page to confirm the correct information is included. No functionality change is introduced by this bug. The only other observable change is the existence of the new files and the inclusion of the minified version of the file in any staff client page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 14:15:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 13:15:26 +0000 Subject: [Koha-bugs] [Bug 23937] Clear filter in Acquisitions Search doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23937 --- Comment #3 from Katrin Fischer --- database filter = datatable filter! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 14:29:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 13:29:28 +0000 Subject: [Koha-bugs] [Bug 23936] Authenticating a patron without library card or ID In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23936 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer --- Sounds like a nice idea. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 14:30:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 13:30:59 +0000 Subject: [Koha-bugs] [Bug 22581] Add support for Plaine & Easie musical incipits rendering in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581 --- Comment #16 from Katrin Fischer --- Having a go here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 14:32:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 13:32:55 +0000 Subject: [Koha-bugs] [Bug 22581] Add support for Plaine & Easie musical incipits rendering in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94856|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 14:40:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 13:40:04 +0000 Subject: [Koha-bugs] [Bug 23937] Clear filter in Acquisitions Search doesn't work In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23937 --- Comment #4 from Owen Leonard --- (In reply to Katrin Fischer from comment #2) > I think it's greyed out because the database filter is empty. Correct. I'm not sure how we can better make that distinction clear. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 15:02:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 14:02:58 +0000 Subject: [Koha-bugs] [Bug 22581] Add support for Plaine & Easie musical incipits rendering in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581 Katrin Fischer changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 15:03:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 14:03:02 +0000 Subject: [Koha-bugs] [Bug 22581] Add support for Plaine & Easie musical incipits rendering in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581 --- Comment #17 from Katrin Fischer --- Created attachment 94952 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94952&action=edit Bug 22581: Add new system preferences This patch adds 2 new system preferences: 1. OPACShowMusicalInscripts - to toggle musical inscripts to appear in opac's detail page 2. OPACPlayMusicalInscripts - to toggle musical inscripts to be transformed and payed in midi. Depends on OPACShowMusicalInscripts to be enabled. To test: 1. apply this patch 2. perl installer/data/mysql/updatedatabase.pl 3. search for this new preferences in admin module SUCCESS => they appear in OPAC section. 4. sign off Sponsored-by: Biblioteca Provincial Fr. Mamerto Esquiú (Provincia Franciscana de la Asunción) Signed-off-by: Katrin Fischer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 15:04:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 14:04:28 +0000 Subject: [Koha-bugs] [Bug 22581] Add support for Plaine & Easie musical incipits rendering in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581 --- Comment #18 from Katrin Fischer --- The written music is very pretty. How is the code in 031 generated? (out of interest) Passing QA on this one. Do we need to add something to the about page for the new JavaScript libraries used here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 15:05:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 14:05:30 +0000 Subject: [Koha-bugs] [Bug 22581] Add support for Plaine & Easie musical incipits rendering in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581 --- Comment #19 from Katrin Fischer --- We might to improve the display later slightly - maybe move it further up, move the link closer to the written music, include a label.. but works for now nicely and is an optional feature. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 15:07:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 14:07:37 +0000 Subject: [Koha-bugs] [Bug 22581] Add support for Plaine & Easie musical incipits rendering in OPAC In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581 --- Comment #20 from Katrin Fischer --- Tiny thing: Play this sample - the space might get lost with the translation tools. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 15:56:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 14:56:26 +0000 Subject: [Koha-bugs] [Bug 23944] Phase out use of jquery.cookie.js in favor of js.cookie.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 --- Comment #2 from Owen Leonard --- Created attachment 94953 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94953&action=edit Bug 23944: (follow-up) Update circulation to use new library This patch updates the circulation page to use the new JavaScript Cookie library for cookie management. To test, apply the patch and open a patron record for checkout in the staff client. - Click "Search to hold" in the toolbar and perform a catalog search which will return results. - On the search results page, the toolbar at the top of the results should include a split "Place hold" button. The button's menu should include "Place hold for " and "Forget " options. Test that these work correctly. - In the table of search results each title should include a "Place hold for " link. - Go to the checkouts page for a patron with one or more checked-out items. - Check the "Always show checkouts immediately" checkbox. - The patron's checkouts should load. - Open another patron for checkout who has checked-out items. - The table of checkouts should load automatically. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 16:06:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 15:06:20 +0000 Subject: [Koha-bugs] [Bug 23673] Separate time sent from time created in message_queue table In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 --- Comment #4 from Maxime Dufresne --- Created attachment 94954 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94954&action=edit Bug 23805: (RM follow-up) Remove CHECK constraints MariaDB and MySQL support different syntaxes for CHECK constraints at different versions. To remove complexities in the updatedatabase script I have opted to remove all CHECK constraints entirely. Signed-off-by: Martin Renvoize -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 16:34:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 15:34:25 +0000 Subject: [Koha-bugs] [Bug 23945] New: koha-remove does not support older mysql and mariadb Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23945 Bug ID: 23945 Summary: koha-remove does not support older mysql and mariadb Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org koha-remove utilises IF EXISTS in the DROP USER calls and this was only introduced in later versions of MySQL and MariaDB.. as such it breaks on many otherwise stable distributions. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 16:35:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 15:35:27 +0000 Subject: [Koha-bugs] [Bug 23945] koha-remove does not support older mysql and mariadb In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23945 --- Comment #1 from Martin Renvoize --- MariaDB introduced the IF EXISTS clause in 10.1.3 and MySQL introduced it in 5.7 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 16:35:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 15:35:37 +0000 Subject: [Koha-bugs] [Bug 23945] koha-remove does not support older mysql and mariadb In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23945 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 16:35:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 15:35:43 +0000 Subject: [Koha-bugs] [Bug 23945] koha-remove does not support older mysql and mariadb In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23945 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 16:38:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 15:38:30 +0000 Subject: [Koha-bugs] [Bug 23711] Icons on staff main page should be font icons In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23711 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23946 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23946 [Bug 23946] Remove Noun Project icons from the About page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 16:38:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 15:38:30 +0000 Subject: [Koha-bugs] [Bug 23946] New: Remove Noun Project icons from the About page Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23946 Bug ID: 23946 Summary: Remove Noun Project icons from the About page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: fridolin.somers at biblibre.com, gmcharlt at gmail.com, lucas at bywatersolutions.com, testopia at bugs.koha-community.org Depends on: 23711 Bug 23711 removed all the Noun Project icons from Koha, so the attribution can be removed. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23711 [Bug 23711] Icons on staff main page should be font icons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 16:38:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 15:38:49 +0000 Subject: [Koha-bugs] [Bug 23859] Cities endpoint not setting the Location header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23859 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_19_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 16:39:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 15:39:06 +0000 Subject: [Koha-bugs] [Bug 23860] Patrons endpoint not setting the Location header In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23860 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_19_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 16:40:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 15:40:00 +0000 Subject: [Koha-bugs] [Bug 21824] Add ability to format dates in various formats in templates In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21824 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_19_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 16:42:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 15:42:42 +0000 Subject: [Koha-bugs] [Bug 22569] Stock rotation: need transfer reports In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 16:56:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 15:56:55 +0000 Subject: [Koha-bugs] [Bug 23946] Remove Noun Project icons from the About page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23946 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 16:56:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 15:56:58 +0000 Subject: [Koha-bugs] [Bug 23946] Remove Noun Project icons from the About page In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23946 --- Comment #1 from Owen Leonard --- Created attachment 94955 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94955&action=edit Bug 23946: Remove Noun Project icons from the About page This patch removes the part of the About page which gives attribution for Noun Project icons on the staff client home page. To test, apply the patch and view the About page in the staff client. There should be no reference to Noun Project icons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 17:52:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 16:52:08 +0000 Subject: [Koha-bugs] [Bug 23079] Checkouts page broken because of problems with date calculation (TZAmerica/Sao_Paulo) In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23079 Jose Ricardo Quaglio changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jose.quaglio at saobernardo.sp | |.gov.br --- Comment #22 from Jose Ricardo Quaglio --- Hello, I work at the public library of Sao Bernardo do Campo / Sao Paulo / Brazil. We have been using Koha since 2009, and we always have problems with the time zone. We currently use version 18 and have a homologation server with version 19, both with error. Today, 1/11/2019, we do not have "summer time". There is an error in the time zone of registering a new user, check out or renew materials. Error: "Internal Server Error" in "/cgi-bin/koha/members/memberentry.pl" When checking the log "plack-error": Wide character in print at /usr/share/perl5/CGI/Session/Driver/file.pm line 118. Wide character in print at /usr/share/perl5/CGI/Session/Driver/file.pm line 118. Invalid local time for date in time zone: America / Sao_Paulo Can someone help me? Tks, -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 19:12:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 18:12:41 +0000 Subject: [Koha-bugs] [Bug 23947] New: Phase out jquery.cookie.js: Authority merge Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23947 Bug ID: 23947 Summary: Phase out jquery.cookie.js: Authority merge Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: testopia at bugs.koha-community.org Depends on: 23944 The authority merge process sets cookes to track which records are being merged. This process should use the newer cookie library, js-cookie. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 [Bug 23944] Phase out use of jquery.cookie.js in favor of js.cookie.js -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 19:12:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 18:12:41 +0000 Subject: [Koha-bugs] [Bug 23944] Phase out use of jquery.cookie.js in favor of js.cookie.js In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23944 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23947 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23947 [Bug 23947] Phase out jquery.cookie.js: Authority merge -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 19:13:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 18:13:54 +0000 Subject: [Koha-bugs] [Bug 23948] New: Move mandatory .sql files to the mandatory/ directory Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23948 Bug ID: 23948 Summary: Move mandatory .sql files to the mandatory/ directory Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org Some files exist in the root directory (installer/data/mysql) and some other in the mandatory/ one. All should be put in the mandatory one. The current 'layout' becomes particularly troublesome on this commit: https://gitlab.com/koha-community/koha-misc4dev/commit/7ecb9de5b6c7ef660ff63254e802a8ec42199a13 After that commit, the tools won't work for earlier versions that don't have that .sql files. If they were put in the mandatory directory there would be no need to explicitly list them or branching in the code depending on the version (possible workaround in koha-misc4dev). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 19:14:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 18:14:41 +0000 Subject: [Koha-bugs] [Bug 23948] Move mandatory .sql files to the mandatory/ directory In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23948 Tomás Cohen Arazi changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |Installation and upgrade |and plumbing |(command-line installer) CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |martin.renvoize at ptfs-europe | |.com, | |nick at bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 19:21:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 18:21:21 +0000 Subject: [Koha-bugs] [Bug 23947] Phase out jquery.cookie.js: Authority merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23947 Owen Leonard changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 19:21:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 18:21:23 +0000 Subject: [Koha-bugs] [Bug 23947] Phase out jquery.cookie.js: Authority merge In-Reply-To: References: Message-ID: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23947 --- Comment #1 from Owen Leonard --- Created attachment 94956 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94956&action=edit Bug 23947: Phase out jquery.cookie.js: Authority merge This patch updates the JavaScript which sets cookies during the authority merge process so that it uses the new js-cookie library. To test, apply the patch and perform a search in the authority module which will return multiple results. - Select "Merge" from the Actions menu next to any result. - A message should appear at the top of the page: "Merging with authority: ". - Click "Cancel merge." The message should disappear. - Select a record to merge again. - Select another record. - The page should redirect to the authority merge page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 19:48:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 18:48:31 +0000 Subject: [Koha-bugs] [Bug 23949] New: koha-common.init missing actions for koha-z3950-responder Message-ID: <bug-23949-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 Bug ID: 23949 Summary: koha-common.init missing actions for koha-z3950-responder Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs at lists.koha-community.org Reporter: tomascohen at gmail.com QA Contact: testopia at bugs.koha-community.org For consistency, it should be calling the script for --stop and --restart actions as well. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 19:55:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 18:55:35 +0000 Subject: [Koha-bugs] [Bug 23949] koha-common.init missing actions for koha-z3950-responder In-Reply-To: <bug-23949-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23949-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23949-70-FOYTEzy5qM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 19:55:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 18:55:38 +0000 Subject: [Koha-bugs] [Bug 23949] koha-common.init missing actions for koha-z3950-responder In-Reply-To: <bug-23949-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23949-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23949-70-vYUamvCg42@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 --- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 94957 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94957&action=edit Bug 23949: Add missing actions for koha-z3950-responder in koha-common.init This patch makes the init script deal with koha-z3950-responder in --stop and --restart actions. Currently, only --start calls the script. To test: - Enable the server: $ koha-z3950-responder --enable kohadev - Stop koha-common $ service koha-common stop => SUCCESS: No koha-z3950-responder running - Start koha-common $ service koha-common start => SUCCESS: It is loaded (even if failing because of config issues) - Stop koha-common $ service koha-common stop => FAIL: It is still running (no --stop issued) - Repeat for restart - Apply this patch - Redo => SUCCESS: Things behave as expected! - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 19:56:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 18:56:20 +0000 Subject: [Koha-bugs] [Bug 23949] koha-common.init missing actions for koha-z3950-responder In-Reply-To: <bug-23949-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23949-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23949-70-MyX2OxKKWA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | Depends on| |13937 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 19:56:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 18:56:20 +0000 Subject: [Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13937-70-ctcqOrcMxB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23949 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 [Bug 23949] koha-common.init missing actions for koha-z3950-responder -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 20:30:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 19:30:06 +0000 Subject: [Koha-bugs] [Bug 5276] subscription end date shouldn't be required / allow indefinite subscriptions In-Reply-To: <bug-5276-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-5276-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5276-70-gLqoNFcsSo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5276 Kelly McElligott <kelly at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly at bywatersolutions.com --- Comment #3 from Kelly McElligott <kelly at bywatersolutions.com> --- This is still a valid bug. Adding this subscription expiration date (and even the subscription length) as required, is very limiting to libraries who are not concerned with this value but need to fill it out. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 20:41:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 19:41:52 +0000 Subject: [Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message In-Reply-To: <bug-23075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23075-70-YR4rvba2AG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 --- Comment #28 from David Nind <david at davidnind.com> --- The https version works fine, the http version produces errors as it is not a 'valid' URL. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 21:28:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 20:28:26 +0000 Subject: [Koha-bugs] [Bug 23948] Move mandatory .sql files to the mandatory/ directory In-Reply-To: <bug-23948-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23948-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23948-70-6viGhBPieL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23948 --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- See bug 23895 which I think it's a duplicate of this. Actually, just moving them doesn't mean they don't have to be explicitly listed, right now the code in C4/Installer lists all mandatory files to nature correct load order.. silly huh. What 'tools' are you talking about? I've already updated misc4dev. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 21:45:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 20:45:03 +0000 Subject: [Koha-bugs] [Bug 22247] Koha::IssuingRule->get_effective_issuing_rule has no hard fallback In-Reply-To: <bug-22247-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22247-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22247-70-xRtvpnEsoc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22247 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 22:12:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 21:12:56 +0000 Subject: [Koha-bugs] [Bug 23862] Add enumchron to holds-table on checkout page In-Reply-To: <bug-23862-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23862-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23862-70-p2iQYqJwxN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23862 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 22:13:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 21:13:00 +0000 Subject: [Koha-bugs] [Bug 23862] Add enumchron to holds-table on checkout page In-Reply-To: <bug-23862-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23862-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23862-70-AZ1ydOIDg8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23862 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94821|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 94958 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94958&action=edit Bug 23862: add enumchron to holds-table Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 22:19:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 21:19:40 +0000 Subject: [Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and does not indicate it is for SIP-based checkouts only In-Reply-To: <bug-23233-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23233-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23233-70-nDLKTgcjSp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Failed QA --- Comment #20 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Joonas, this one is confusing to me - from the bug title/description it only seemed to affect the description of the pref/naming of the pref, so I expected an easy QA, but there is definitely more going on here. Can you explain why you removed the checks for the prefs in several parts of the code? Especially the changes to GetItemsInfo. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 22:57:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 21:57:46 +0000 Subject: [Koha-bugs] [Bug 23950] New: Replace MARC21xslt materialtype PNG icons with Font Awesome Message-ID: <bug-23950-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23950 Bug ID: 23950 Summary: Replace MARC21xslt materialtype PNG icons with Font Awesome Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org We should replace all the PNG icons in the XSLT with font awesome. This will replace all the materialtype icons in the MARC21slim2OPACDetail.xsl and MARC21slim2OPACResults.xsl with Font Awesome -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 23:04:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 22:04:42 +0000 Subject: [Koha-bugs] [Bug 23950] Replace MARC21xslt materialtype PNG icons with Font Awesome In-Reply-To: <bug-23950-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23950-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23950-70-u5rtVPw77w@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23950 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 23:04:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 22:04:44 +0000 Subject: [Koha-bugs] [Bug 23950] Replace MARC21xslt materialtype PNG icons with Font Awesome In-Reply-To: <bug-23950-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23950-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23950-70-uAR2iqrjzK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23950 --- Comment #1 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 94959 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94959&action=edit Bug 23950: Replace MARC21xslt materialtype PNG icons with Font Awesome 1. Have all the material type icons handy by having records with the following in the 6th position (t, o, m, e, g, k, r, I, j, c) and the following in the 7th position (c, i, a) 2. Notice all the old PNG icons in both the OPAC results and the OPAC details 3. Apply patch. 4. Check all the items again (OPAC results and OPAC details) and make sure that each has been updated to a Font Awesome Icon. 5. Rejoice. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 23:06:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 22:06:06 +0000 Subject: [Koha-bugs] [Bug 23950] Replace MARC21xslt materialtype PNG icons with Font Awesome in the OPAC In-Reply-To: <bug-23950-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23950-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23950-70-pLr34lbNRU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23950 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Replace MARC21xslt |Replace MARC21xslt |materialtype PNG icons with |materialtype PNG icons with |Font Awesome |Font Awesome in the OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 1 23:07:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 01 Nov 2019 22:07:42 +0000 Subject: [Koha-bugs] [Bug 23950] Replace MARC21xslt materialtype PNG icons with Font Awesome in the OPAC In-Reply-To: <bug-23950-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23950-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23950-70-kQpx1N80Po@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23950 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 11:33:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 10:33:13 +0000 Subject: [Koha-bugs] [Bug 22661] TinyMCE/WYSIWYG editor doesn't translate In-Reply-To: <bug-22661-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22661-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22661-70-fn06XWyn7H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22661 --- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I really love the handling of the newer editor and fixing the translatability bug is almost just icing on the cake. Much more modern and I think I discovered some features that weren't there before (or that I always missed). Also tested the news editor. Thx Owen! PQA! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 11:33:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 10:33:21 +0000 Subject: [Koha-bugs] [Bug 22661] TinyMCE/WYSIWYG editor doesn't translate In-Reply-To: <bug-22661-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22661-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22661-70-WVuWD4Kvf5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22661 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 11:41:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 10:41:58 +0000 Subject: [Koha-bugs] [Bug 23951] New: Sundy and Account management fee missing from manual fine pull down Message-ID: <bug-23951-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23951 Bug ID: 23951 Summary: Sundy and Account management fee missing from manual fine pull down Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org When comparing the pull down offered when creating a manual fine between 18.11 and master, there are some options missing: - Account management fee - Sundry Is this a bug or by intention? For libraries who have been using these and have built reports on them this could be an issue. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 11:42:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 10:42:04 +0000 Subject: [Koha-bugs] [Bug 23951] Sundy and Account management fee missing from manual fine pull down In-Reply-To: <bug-23951-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23951-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23951-70-5REAOC4BAe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23951 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 11:42:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 10:42:24 +0000 Subject: [Koha-bugs] [Bug 23951] Sundry and Account management fee missing from manual fine pull down In-Reply-To: <bug-23951-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23951-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23951-70-NY3QGImIrE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23951 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Sundy and Account |Sundry and Account |management fee missing from |management fee missing from |manual fine pull down |manual fine pull down -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 11:49:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 10:49:31 +0000 Subject: [Koha-bugs] [Bug 23079] Checkouts page broken because of problems with date calculation (TZAmerica/Sao_Paulo) In-Reply-To: <bug-23079-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23079-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23079-70-tl1f6dpeUN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23079 --- Comment #23 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Jose Ricardo Quaglio from comment #22) > Hello, > > I work at the public library of Sao Bernardo do Campo / Sao Paulo / Brazil. > > We have been using Koha since 2009, and we always have problems with the > time zone. > > We currently use version 18 and have a homologation server with version 19, > both with error. > > Today, 1/11/2019, we do not have "summer time". > > There is an error in the time zone of registering a new user, check out or > renew materials. > > Error: "Internal Server Error" in "/cgi-bin/koha/members/memberentry.pl" > > When checking the log "plack-error": > Wide character in print at /usr/share/perl5/CGI/Session/Driver/file.pm > line 118. > Wide character in print at /usr/share/perl5/CGI/Session/Driver/file.pm > line 118. > Invalid local time for date in time zone: America / Sao_Paulo > > Can someone help me? > > Tks, Hi Jose, there are no versions 18 and 19, (there are 18.05, 18.11, 19.05 - two a year and many bugfix releases between: 18.11.10...), you always need to give us the full version number as listed on the about page to make it possible for us to see if this should have been fixed by this patch or not. When you experience the problem again, try manually changing the date expiry by a bit to be able to work around it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 11:52:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 10:52:29 +0000 Subject: [Koha-bugs] [Bug 23946] Remove Noun Project icons from the About page In-Reply-To: <bug-23946-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23946-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23946-70-9NprjJBH6X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23946 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 11:52:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 10:52:32 +0000 Subject: [Koha-bugs] [Bug 23946] Remove Noun Project icons from the About page In-Reply-To: <bug-23946-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23946-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23946-70-AvOMqnLuGM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23946 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94955|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 94960 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94960&action=edit Bug 23946: Remove Noun Project icons from the About page This patch removes the part of the About page which gives attribution for Noun Project icons on the staff client home page. To test, apply the patch and view the About page in the staff client. There should be no reference to Noun Project icons. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 11:53:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 10:53:03 +0000 Subject: [Koha-bugs] [Bug 23946] Remove Noun Project icons from the About page In-Reply-To: <bug-23946-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23946-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23946-70-YqZ8QcNxnl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23946 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Basically a string patch and a logical consequence of bug 23711. PQA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 12:02:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 11:02:21 +0000 Subject: [Koha-bugs] [Bug 23658] [18.11] WrongTransfer modal drops off specified checkin date on returns.pl In-Reply-To: <bug-23658-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23658-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23658-70-B8Qh2yXB96@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23658 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|WrongTransfer modal drops |[18.11] WrongTransfer modal |off specified checkin date |drops off specified checkin |on returns.pl |date on returns.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 12:13:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 11:13:44 +0000 Subject: [Koha-bugs] [Bug 23684] Import items only with merging rule In-Reply-To: <bug-23684-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23684-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23684-70-1ci5FKoe95@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23684 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Villam, this reminded me of bug 18757 - I wonder if this could be part of the problem? It's marked to affect UNIMARC only, but the change is general. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 12:14:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 11:14:59 +0000 Subject: [Koha-bugs] [Bug 19780] Actual price is not updated after it has been amended post receiving an order In-Reply-To: <bug-19780-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19780-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19780-70-m0dGxcA7P6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19780 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Attachment #73359|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 12:16:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 11:16:30 +0000 Subject: [Koha-bugs] [Bug 19780] Actual price is not updated after it has been amended post receiving an order In-Reply-To: <bug-19780-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19780-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19780-70-XVbv2djTn8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19780 --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think there went something wrong when Hayley rebased it, so old and new patch were both on the bug, but even after obsoleting the older, this won't apply: Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 19780 - Updating the invoice costs after updating of the actual value post receiving of the order Using index info to reconstruct a base tree... M acqui/neworderempty.pl M koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt M koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/neworderempty.tt Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/basket.tt Auto-merging acqui/neworderempty.pl CONFLICT (content): Merge conflict in acqui/neworderempty.pl error: Failed to merge in the changes. Patch failed at 0001 Bug 19780 - Updating the invoice costs after updating of the actual value post receiving of the order The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Fixed-merge-conflicts---zTWP_q.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 12:18:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 11:18:33 +0000 Subject: [Koha-bugs] [Bug 10635] Can't query for CREATE/DELETE in action_logs with SQL reports In-Reply-To: <bug-10635-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10635-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10635-70-JnxKqi48Cs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10635 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|can't query for create in |Can't query for |action_logs |CREATE/DELETE in | |action_logs with SQL | |reports -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 12:18:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 11:18:59 +0000 Subject: [Koha-bugs] [Bug 23743] Show that token has not been validated yet In-Reply-To: <bug-23743-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23743-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23743-70-LgcVBmNrie@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23743 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|show that token has not |Show that token has not |been validated yet |been validated yet CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 12:19:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 11:19:31 +0000 Subject: [Koha-bugs] [Bug 23747] Replace a local object by a mana-kb one In-Reply-To: <bug-23747-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23747-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23747-70-1izq7kBHwC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23747 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|replace a local object by a |Replace a local object by a |mana-kb one |mana-kb one CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 12:20:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 11:20:26 +0000 Subject: [Koha-bugs] [Bug 23751] Description of staffaccess permission should be improved In-Reply-To: <bug-23751-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23751-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23751-70-RniFmyAzbE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23751 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.11 |master Summary|Description of staffaccess |Description of staffaccess |permission should be |permission should be |improved. |improved CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 12:26:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 11:26:00 +0000 Subject: [Koha-bugs] [Bug 23751] Description of staffaccess permission should be improved In-Reply-To: <bug-23751-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23751-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23751-70-XnNpK4R04U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23751 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- This appears fixed in newer versions: Allow staff members to modify permissions and passwords for other staff members -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 12:26:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 11:26:45 +0000 Subject: [Koha-bugs] [Bug 23751] Description of staffaccess permission should be improved In-Reply-To: <bug-23751-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23751-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23751-70-CAvs43qGbj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23751 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |REOPENED --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I realize, there is also username in the mix here. Reopening. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 12:33:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 11:33:05 +0000 Subject: [Koha-bugs] [Bug 23751] Description of staffaccess permission should be improved In-Reply-To: <bug-23751-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23751-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23751-70-5CMkTNL7pv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23751 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 12:33:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 11:33:08 +0000 Subject: [Koha-bugs] [Bug 23751] Description of staffaccess permission should be improved In-Reply-To: <bug-23751-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23751-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23751-70-PJHNOawbvR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23751 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 94961 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94961&action=edit Bug 23751: Make staffaccess permission description more precise The permission description was missing 'username' from the description. To test: - Look at the permissions of a patron - Verify the staffaccess permission is labelled: Allow staff members to modify permissions and passwords for other staff members - Apply patch - Check description again: Allow staff members to modify permissions, usernames, and passwords for other staff members -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 12:33:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 11:33:31 +0000 Subject: [Koha-bugs] [Bug 23751] Description of staffaccess permission should be improved In-Reply-To: <bug-23751-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23751-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23751-70-37Wm10eABD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23751 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 12:41:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 11:41:52 +0000 Subject: [Koha-bugs] [Bug 22592] Elasticsearch - Support for index scan In-Reply-To: <bug-22592-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22592-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22592-70-q1YX6tmbEn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 12:41:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 11:41:56 +0000 Subject: [Koha-bugs] [Bug 22592] Elasticsearch - Support for index scan In-Reply-To: <bug-22592-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22592-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22592-70-gkXGUtIxoB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93745|0 |1 is obsolete| | --- Comment #31 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 94962 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94962&action=edit Bug 22592: Add index scan emulation to Elasticsearch Adds support for using the "scan indexes" action in advanced search by using faceting with a prefix filter. Requires that the field be set as facetable for anything to be found. Test plan: 1. Apply patch 2. Go to advanced search and click "More options" 3. Select author as the search field, enter a last name and check "Scan indexes" 4. Perform search and observe the result list resembling scan results Signed-off-by: Michal Denar <black23 at gmail.com> Signed-off-by: Michal Denar <black23 at gmail.com> Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 12:43:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 11:43:34 +0000 Subject: [Koha-bugs] [Bug 22592] Elasticsearch - Support for index scan In-Reply-To: <bug-22592-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22592-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22592-70-7Lz2NzTSys@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #32 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I feel while this is not the 'perfect' scan search, it's a great first step forwards from not supporting it to giving pretty good results in most cases (better than with Zebra actually). I think we could even discuss for this to be a bug fix, as we offer the scan search with Elastic, but it didn't work before. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 12:46:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 11:46:36 +0000 Subject: [Koha-bugs] [Bug 23503] Personal name authority search: search results aren't sorted in alphabetical order after page 51 In-Reply-To: <bug-23503-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23503-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23503-70-isxJAC8yFg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23503 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think this might be related to a setting in Zebra - a limit on how many records are sorted. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 12:54:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 11:54:29 +0000 Subject: [Koha-bugs] [Bug 16910] Authority search plugin in cataloguing stops at 15 pages In-Reply-To: <bug-16910-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16910-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16910-70-42ryt2k9mg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16910 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Just retested this and I think the issue is that unlike in other places the number of the new page doesn't show up in the list, it always remains: << 1 2 3 4 5 6 7 8 9 10 11 12 13 14 15 >> Results 381 to 400 of 650 You can navigate past page 15 using >> but the page numbers appear hardcoded. Maybe it could be an option to switch to the more commonly used and formatted paging display here? (bibliographic search results, authority module search) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 12:55:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 11:55:16 +0000 Subject: [Koha-bugs] [Bug 11808] When searching for a cardnumber in the intranet, also try to search for it on the LDAP server if one is configured and add/update user In-Reply-To: <bug-11808-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11808-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11808-70-p3qYht7J4O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11808 --- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Maryse Simard from comment #11) > For now, I've rebased the patch on current master and started to fix the > problems reported. Among those fixes, I've added a third option, as Katrin > suggested, for the system preference. Hi Maryse, is this ready for testing again yet? If so, please remember to switch the status! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 13:02:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 12:02:18 +0000 Subject: [Koha-bugs] [Bug 23768] ISBN search in IntranetCatalogPulldown searches nothing if passed an invalid ISBN and using SearchWithISBNVariations In-Reply-To: <bug-23768-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23768-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23768-70-kixl4zAJ3H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23768 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 13:02:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 12:02:21 +0000 Subject: [Koha-bugs] [Bug 23768] ISBN search in IntranetCatalogPulldown searches nothing if passed an invalid ISBN and using SearchWithISBNVariations In-Reply-To: <bug-23768-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23768-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23768-70-I91clGQ0GX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23768 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93829|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 94963 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94963&action=edit Bug 23768: Return invalid ISBN when searching with variations To test: 1 - Enable SearchWithISBNVariations and IntranetCatalogSearchPulldown 2 - Refresh page and click on 'Search the catalog' tab 3 - Search for 'ISBN' 0385299209 4 - Note no results 5 - Note the search says if searched 'kw,wrdl: (nb=)' 6 - Apply patch, restart all the things 7 - Repeat search 8 - Search looks correctly formed 9 - Add the isbn above to a record, confirm it is returned by search 10 - Confirm searches for valid ISBNs still work as expected Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 13:02:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 12:02:38 +0000 Subject: [Koha-bugs] [Bug 23768] ISBN search in IntranetCatalogPulldown searches nothing if passed an invalid ISBN and using SearchWithISBNVariations In-Reply-To: <bug-23768-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23768-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23768-70-C5BZQyE1Nh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23768 --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- A sign-off as incentive for a regression test? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 13:05:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 12:05:54 +0000 Subject: [Koha-bugs] [Bug 13749] On loading holds in patron account 'processing' is not translatable In-Reply-To: <bug-13749-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13749-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13749-70-RANlRa04q2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13749 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 13:05:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 12:05:57 +0000 Subject: [Koha-bugs] [Bug 13749] On loading holds in patron account 'processing' is not translatable In-Reply-To: <bug-13749-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13749-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13749-70-p3cFvBvw04@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13749 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93889|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 94964 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94964&action=edit Bug 13749: On loading holds in patron account 'processing' is not translatable This patch updates the DataTables configuration for two tables: The checkouts and holds lists shown on the checkout and patron details screen. The tables lacked the standard application of a custom set of defaults defined in js/datatables.js. It is in this file that custom language strings are defined for DataTable interface elements, pulling in the translated values from datatables.inc. Without our custom defaults applied, DataTables used its own defaults, which are not translated. To test, apply the patch and check out to a patron who has both checkouts and holds. The more the better to give you more time to observer the loading state of the tables. - Checkouts: This table doesn't exhibit any visible problems because page-specific text is defined for the table's "Loading" message. However, it still makes sense to apply the defaults to the table for consistency's sake. There should be no visible changes to the table. - Holds: From the checkout or patron details page click the "Holds" tab. While the table loads there should be a "Processing" message. If you switch to another translation the message should appear in that language. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 13:06:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 12:06:15 +0000 Subject: [Koha-bugs] [Bug 13749] On loading holds in patron account 'processing' is not translatable In-Reply-To: <bug-13749-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13749-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13749-70-1sR1OKqVDs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13749 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Thx, Owen! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 13:37:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 12:37:27 +0000 Subject: [Koha-bugs] [Bug 21565] SCO checkout confirm language In-Reply-To: <bug-21565-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21565-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21565-70-uN8VCNOBDZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21565 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|unspecified |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 13:45:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 12:45:53 +0000 Subject: [Koha-bugs] [Bug 23181] Unable to use payment library in ACCOUNT_PAYMENT or ACCOUNT_WRITEOFF notices In-Reply-To: <bug-23181-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23181-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23181-70-hkXxTRvZNQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23181 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|unspecified |master --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- A bit sad to see this one blocked by the missing test - it means you can't print your library's address into the new notices and have to hardcode it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 14:51:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 13:51:07 +0000 Subject: [Koha-bugs] [Bug 23783] Show languages from MARC21 field 041 in OPAC In-Reply-To: <bug-23783-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23783-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23783-70-Y6qfRSTaWn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23783 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 14:51:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 13:51:10 +0000 Subject: [Koha-bugs] [Bug 23783] Show languages from MARC21 field 041 in OPAC In-Reply-To: <bug-23783-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23783-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23783-70-2YF9t7r6CF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23783 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 94965 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94965&action=edit Bug 23783: Show languages from MARC21 field 041 in OPAC This copies the changes made in bug 20364 for the staff interface to the OPAC. Some slight changes have been made in comparison: - OPAC uses the class "separator" for the characters that are used between repeatable tags. "sep" as used in the original patch set has some CSS rules attached to it that break display, so it makes double sense to change it. - We revently removed ending . from the display in OPAC - so it's done here too. To test: 1) Apply patch 2) Do a search in the OPAC and check the results look correct 3) Check some biblio detail pages and verify that they look correct 4) Add some 041 subfields (a, b, d, h, j) in any combinations 5) Repeat 2 and 3 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 14:53:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 13:53:17 +0000 Subject: [Koha-bugs] [Bug 23783] Show languages from MARC21 field 041 in OPAC In-Reply-To: <bug-23783-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23783-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23783-70-3fZUitJmHs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23783 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 14:57:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 13:57:19 +0000 Subject: [Koha-bugs] [Bug 23834] Add default ESLint configuration In-Reply-To: <bug-23834-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23834-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23834-70-WAItAhwefR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23834 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 14:57:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 13:57:22 +0000 Subject: [Koha-bugs] [Bug 23834] Add default ESLint configuration In-Reply-To: <bug-23834-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23834-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23834-70-INQych73yO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23834 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94373|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 94966 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94966&action=edit Bug 23834: Add default ESLint configuration This patch adds a default ESLint configuration for use when editing JavaScript, as recommended in the coding guidelines: https://wiki.koha-community.org/wiki/Coding_Guidelines#JS8:_Follow_guidelines_set_by_ESLint Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 14:57:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 13:57:47 +0000 Subject: [Koha-bugs] [Bug 23834] Add default ESLint configuration In-Reply-To: <bug-23834-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23834-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23834-70-kQgLEAYAI6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23834 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Passed QA --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Adds a config file, PQA right away. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 15:34:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 14:34:56 +0000 Subject: [Koha-bugs] [Bug 23181] Unable to use payment library in ACCOUNT_PAYMENT or ACCOUNT_WRITEOFF notices In-Reply-To: <bug-23181-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23181-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23181-70-ersDXogC3a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23181 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 15:34:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 14:34:59 +0000 Subject: [Koha-bugs] [Bug 23181] Unable to use payment library in ACCOUNT_PAYMENT or ACCOUNT_WRITEOFF notices In-Reply-To: <bug-23181-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23181-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23181-70-O2lYwJcCkp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23181 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 94967 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94967&action=edit Bug 23181: Extend unit tests Run t/db_dependent/Accounts.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 15:35:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 14:35:23 +0000 Subject: [Koha-bugs] [Bug 23181] Unable to use payment library in ACCOUNT_PAYMENT or ACCOUNT_WRITEOFF notices In-Reply-To: <bug-23181-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23181-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23181-70-uhIV7IYdBB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23181 --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I've given the unit test a go. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 16:08:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 15:08:42 +0000 Subject: [Koha-bugs] [Bug 21652] reserves.waitingdate is set to current date by printing new hold slip In-Reply-To: <bug-21652-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21652-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21652-70-ZQFlFVNdAl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21652 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Andrew, can you confirm this is still an issue in newer versions? 17.11 is on longer maintained. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 16:21:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 15:21:01 +0000 Subject: [Koha-bugs] [Bug 23787] Add AUTO_RENEWALS in sample_notices.sql In-Reply-To: <bug-23787-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23787-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23787-70-Ad30LX3jtF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Needs Signoff |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- 2 things: When you run xt/sample_noticed.t you can see that it-IT is missing. I am adding it in a follow up. But another thing: The notice states twice... "The following item...", but there is no item information in the sample text. Should we add something? Also I'd like to make the subject a bit more patron friendly, maybe "Automatic renewals on your account" or similar? And "notification" would be nicer as "Notification". I can help with the updatedatabase if necessary! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 16:21:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 15:21:44 +0000 Subject: [Koha-bugs] [Bug 23787] Add AUTO_RENEWALS in sample_notices.sql In-Reply-To: <bug-23787-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23787-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23787-70-5hVeBfm86j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23787 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 94968 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94968&action=edit Bug 23787: Add AUTO_RENEWALS to it-IT installer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 16:24:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 15:24:35 +0000 Subject: [Koha-bugs] [Bug 23952] New: Fix body id on OPAC course details page Message-ID: <bug-23952-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23952 Bug ID: 23952 Summary: Fix body id on OPAC course details page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Course reserves Assignee: katrin.fischer at bsz-bw.de Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org The id for the OPAC course details page is 'opac-main', but it should have a specific one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 16:24:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 15:24:43 +0000 Subject: [Koha-bugs] [Bug 23952] Fix body id on OPAC course details page In-Reply-To: <bug-23952-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23952-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23952-70-m5ecqYEipy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23952 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 16:28:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 15:28:41 +0000 Subject: [Koha-bugs] [Bug 23952] Fix body id on OPAC course details page In-Reply-To: <bug-23952-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23952-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23952-70-rggQvF77lj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23952 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 16:28:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 15:28:45 +0000 Subject: [Koha-bugs] [Bug 23952] Fix body id on OPAC course details page In-Reply-To: <bug-23952-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23952-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23952-70-7EzN9YzgrC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23952 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 94969 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94969&action=edit Bug 23952: Fix body tag on OPAC course details page The id was not changed, when the page was added and remained opac-main. The patch changes it to opac-course-details so the page has its own unique id. To test: - Add a course reserve to your installation - Go to the course reserves page in the OPAC - Click on the course to see its details - Look at the source code, the <body> tag should show: Without patch: opac-main with patch applied: opac-course-details -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 17:00:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 16:00:50 +0000 Subject: [Koha-bugs] [Bug 23950] Replace MARC21xslt materialtype PNG icons with Font Awesome in the OPAC In-Reply-To: <bug-23950-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23950-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23950-70-NuR6zbNqSF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23950 --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 94970 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94970&action=edit Search results with other png icons Is it expected that not all the PNG icons have been replaced? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 21:15:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 20:15:50 +0000 Subject: [Koha-bugs] [Bug 23784] Show subtitle, number and parts in course reserves list of items In-Reply-To: <bug-23784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23784-70-Rt6StBlWpP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23784 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 21:15:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 20:15:53 +0000 Subject: [Koha-bugs] [Bug 23784] Show subtitle, number and parts in course reserves list of items In-Reply-To: <bug-23784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23784-70-19yVvdgWbT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23784 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 94971 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94971&action=edit Bug 23784: Show subtitle, number and part in course reserve list of records At the moment only the title will display in the course reserves details, but not the information from other title fields. For series with multiple volumes that can lead to confusing display. The patch makes use of the new include to display 245$abnp. To test: - Add mulitple records to a course reserce course Make sure you have some with different combinations of 245$b$n$p - Look at the course details in the OPAC - Verify only $a displays - Apply patch - Reload - Verify now the full information displays Depending on your installation, you might want ot check that the 245 are correctly mapped and save the record once so the database fields are correctly filled. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 21:16:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 20:16:03 +0000 Subject: [Koha-bugs] [Bug 23784] Show subtitle, number and parts in course reserves list of items In-Reply-To: <bug-23784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23784-70-rRxb6odc3E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23784 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 21:23:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 20:23:27 +0000 Subject: [Koha-bugs] [Bug 21939] Permissions for Holds History Tab In-Reply-To: <bug-21939-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21939-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21939-70-x3ZS17MyxE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.05 |master Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 21:26:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 20:26:10 +0000 Subject: [Koha-bugs] [Bug 23779] Importing authority records should look for $1xx field matches In-Reply-To: <bug-23779-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23779-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23779-70-rGzd565Ul8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23779 --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I am surprised that the rule attached is working, I would have expected it not to because the Search index information is empty - could it be that it's using the keyword index for matching in this case? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 21:26:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 20:26:34 +0000 Subject: [Koha-bugs] [Bug 23779] Add sample matching rule for authority records on $1xx field matches In-Reply-To: <bug-23779-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23779-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23779-70-xIhQF6j3RA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23779 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.05 |master Summary|Importing authority records |Add sample matching rule |should look for $1xx field |for authority records on |matches |$1xx field matches -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 21:29:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 20:29:39 +0000 Subject: [Koha-bugs] [Bug 21939] Permissions for Holds History Tab In-Reply-To: <bug-21939-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21939-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21939-70-HPgzuBqh9l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 21:29:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 20:29:42 +0000 Subject: [Koha-bugs] [Bug 21939] Permissions for Holds History Tab In-Reply-To: <bug-21939-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21939-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21939-70-wuFWKEKip2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 94972 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94972&action=edit Bug 21939: Fix permissions for holds history tab The tab will show when the staff user has edit_borrowers permission, but the page itself will not be accessible. This patch fixes the page permissions to allow access with the edit_borrowers permission as suggested by the comments on the original bug report. To test: - Create a staff user with only "edit_borrowers" permission from the borrowers module - Try to access the holds history tab from any patron account - Verify you are blocked - Apply patch - Try again and verify the page is accessible now - Repeat with superlibrarian and full borrowers permission. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 21:30:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 20:30:01 +0000 Subject: [Koha-bugs] [Bug 21939] Permission for holds history tab is too strict In-Reply-To: <bug-21939-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21939-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21939-70-TX0Pr0SU1V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Permissions for Holds |Permission for holds |History Tab |history tab is too strict -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 21:30:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 20:30:21 +0000 Subject: [Koha-bugs] [Bug 21939] Permission for holds history tab is too strict In-Reply-To: <bug-21939-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21939-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21939-70-DVbbWAOs1k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I've tried fixing it as suggested, can you please test? Should work fine on sandboxes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 21:31:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 20:31:21 +0000 Subject: [Koha-bugs] [Bug 22988] Visible reduction in image quality In-Reply-To: <bug-22988-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22988-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22988-70-ryJy9HB7JS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22988 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Jonathan Druart from comment #9) > I will need a step-by-step plan to recreate, as well as an image (or at > least a link). > > While waiting for a correct fix it seems that we should consider a revert of > the original patch to prevent the problem to propagate. If it's doable we should consider that - leaving it that way another release woud not be good. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 21:34:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 20:34:49 +0000 Subject: [Koha-bugs] [Bug 23814] make it easier to manage items in baskets In-Reply-To: <bug-23814-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23814-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23814-70-Lr94ETkosz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23814 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|18.11 |master --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I am not sure about the use case here. What you can already do: - If you are creating your items on order or on receive, you can move the items or merge the records and the order information should follow (if we broke that, this would be a bug) - You can transfer order lines from one basket to another leaving a trail of what happened in the old basket. What is the thing we are missing? For new features, it's good to file them against master - 18.11 will be end of life soon and new features go into master first. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 21:35:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 20:35:08 +0000 Subject: [Koha-bugs] [Bug 23814] Make it easier to manage items in baskets In-Reply-To: <bug-23814-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23814-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23814-70-gXQ3fjGDdv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23814 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|make it easier to manage |Make it easier to manage |items in baskets |items in baskets -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 21:36:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 20:36:35 +0000 Subject: [Koha-bugs] [Bug 23081] Item search : Filter for Items with Zero Checkouts Returns No Results In-Reply-To: <bug-23081-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23081-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23081-70-b4rd57oc4e@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23081 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|18.11 |master Severity|enhancement |normal --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I've confirmed, issues = 0 doesn't work in item search. Looking for items that haven't been issued is a common use case for weeding, marking this as a bug. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 21:45:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 20:45:25 +0000 Subject: [Koha-bugs] [Bug 23818] Acquisitions receipt created when an item or invoice is received In-Reply-To: <bug-23818-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23818-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23818-70-obkmtP0glf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23818 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Acquisitions receipt |Acquisitions receipt |created when an item or |created when an item or |invoice is received. |invoice is received CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Rhonda, thx for the great examples! I've seen similar slips used in German libraries as well. If this get implemented, I think it would be great to have it as a customizable slip, so you could add workflow things as well (like checkboxes for certain steps). With TT we can do a lot of great things now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 21:47:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 20:47:56 +0000 Subject: [Koha-bugs] [Bug 8331] Hidden field does not hide from plain MARC view In-Reply-To: <bug-8331-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8331-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8331-70-6i8aB5A77I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8331 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think most important would be to fix the OPAC views - people want to hide things from patrons, staff views could be second priority. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 21:48:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 20:48:58 +0000 Subject: [Koha-bugs] [Bug 15448] OPACHiddenItems show in OPAC when patron places a hold on a specific item In-Reply-To: <bug-15448-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15448-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15448-70-F4jIHSwetT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448 --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Old and mean bug with quite some votes... just giving it another bump. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 21:53:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 20:53:37 +0000 Subject: [Koha-bugs] [Bug 11815] Convert BorrowersTitles to an authorised value In-Reply-To: <bug-11815-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11815-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11815-70-FN1OGTJ8sS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11815 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|convert BorrowersTitles to |Convert BorrowersTitles to |an authorised value |an authorised value -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 22:06:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 21:06:06 +0000 Subject: [Koha-bugs] [Bug 23557] REST API: Add ILL request In-Reply-To: <bug-23557-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23557-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23557-70-SOVnKz8Rvi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23557 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Michal, just had a look at the RFC, looks good to me. Do you plan to bring this up for voting? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 22:10:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 21:10:05 +0000 Subject: [Koha-bugs] [Bug 23527] BakerTaylorBookstoreURL is converted to escaped characters by template, rendering it invalid In-Reply-To: <bug-23527-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23527-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23527-70-SssucNpzOU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23527 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 22:11:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 21:11:52 +0000 Subject: [Koha-bugs] [Bug 23600] url broken in advanced search In-Reply-To: <bug-23600-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23600-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23600-70-BWVSMn7Mfj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23600 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- How many libraried did you group? Can you share the URL by chance? >From the error it sounds like the search link generated got too long. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 22:12:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 21:12:08 +0000 Subject: [Koha-bugs] [Bug 23600] Library group search broken in advanced search In-Reply-To: <bug-23600-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23600-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23600-70-aNGUvDc9Qf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23600 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|url broken in advanced |Library group search broken |search |in advanced search -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 22:16:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 21:16:57 +0000 Subject: [Koha-bugs] [Bug 23506] Sound material type displays wrong icon in OPAC/Staff details In-Reply-To: <bug-23506-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23506-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23506-70-vVXowkiH3w@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23506 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 22:17:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 21:17:01 +0000 Subject: [Koha-bugs] [Bug 23506] Sound material type displays wrong icon in OPAC/Staff details In-Reply-To: <bug-23506-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23506-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23506-70-Ni8yw28Eh0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23506 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94840|0 |1 is obsolete| | --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 94973 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94973&action=edit Bug 23506: Display correct icon in staff client and OPAC When the leader6 is set to 'i' the MARC21slim2intranetDetail.xsl attempts to display 'SO.png' which does not exist. TEST PLAN: 1. Find or create a record with an 'i' as the 6th position in the 000 leader. 2. Do to the OPAC detail page and staff detail for an item in that record. 3. Notice the material type icon does not display because SO.png does not exist. 4. Apply patch and restart_all 5. Look at the opac detail and staff detail page again after clearning the browser cache. 6. The material type icon now displays (MU.png), this is the same icon used on the OPAC results page. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 22:17:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 21:17:37 +0000 Subject: [Koha-bugs] [Bug 23506] Sound material type displays wrong icon in OPAC/Staff details In-Reply-To: <bug-23506-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23506-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23506-70-PPuJ8BYtAN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23506 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I fixed the Bug description and commit message. Moving to PQA as it's a really simple fix. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 22:17:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 21:17:55 +0000 Subject: [Koha-bugs] [Bug 23557] REST API: Add ILL request In-Reply-To: <bug-23557-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23557-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23557-70-2IxcL9HQVd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23557 --- Comment #2 from Michal Denar <black23 at gmail.com> --- Hi, I need to talk with Josef about it. But yes, ILL endpoint is important and very useful. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 22:22:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 21:22:08 +0000 Subject: [Koha-bugs] [Bug 23401] Make koha-create more user friendly In-Reply-To: <bug-23401-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23401-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23401-70-Dl9C5FBTrO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23401 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- +1 This happens quite often - mismatch of MARC flavours -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 22:23:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 21:23:05 +0000 Subject: [Koha-bugs] [Bug 23401] Optionally display config values for koha-create before creating a new instance In-Reply-To: <bug-23401-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23401-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23401-70-4PjjyBXcjJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23401 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Make koha-create more user |Optionally display config |friendly |values for koha-create | |before creating a new | |instance -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 22:24:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 21:24:26 +0000 Subject: [Koha-bugs] [Bug 23452] Multiple select options in system preferences are not translatable In-Reply-To: <bug-23452-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23452-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23452-70-5exhCccUVV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23452 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bgkriegel at gmail.com, | |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Owen Leonard from comment #1) > The problem appears to only happen to system preferences with the key > "multiple:" in the .pref file, so I wonder if the translation script is not > parsing them at all That makes sense. Adding Bernardo - maybe he has an idea. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 22:29:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 21:29:06 +0000 Subject: [Koha-bugs] [Bug 23270] Auto barcodes not generated correctly when adding several items In-Reply-To: <bug-23270-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23270-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23270-70-61KGz4vzkp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23270 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** This bug has been marked as a duplicate of bug 23851 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 22:29:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 21:29:06 +0000 Subject: [Koha-bugs] [Bug 23851] Auto generate accession number format <branchcode>yymm0001 fails to add branchcode prefix(branchcode) for multiple item addition In-Reply-To: <bug-23851-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23851-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23851-70-lAmTNfPFXa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23851 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |isabel.pineda at ds.edu.sv --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** Bug 23270 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 22:30:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 21:30:20 +0000 Subject: [Koha-bugs] [Bug 23181] Unable to use payment library in ACCOUNT_PAYMENT or ACCOUNT_WRITEOFF notices In-Reply-To: <bug-23181-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23181-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23181-70-cn3sxnWk0L@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23181 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 22:48:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 21:48:38 +0000 Subject: [Koha-bugs] [Bug 4175] duplicate items does not obey autoBarcode sys pref In-Reply-To: <bug-4175-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-4175-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4175-70-p4rnB4ewrM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4175 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** This bug has been marked as a duplicate of bug 23851 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 22:48:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 21:48:38 +0000 Subject: [Koha-bugs] [Bug 23851] Auto generate accession number format <branchcode>yymm0001 fails to add branchcode prefix(branchcode) for multiple item addition In-Reply-To: <bug-23851-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23851-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23851-70-gwn7MPk0w0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23851 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nengard at gmail.com --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** Bug 4175 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 22:49:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 21:49:09 +0000 Subject: [Koha-bugs] [Bug 23851] Auto generate accession number format <branchcode>yymm0001 fails to add branchcode prefix(branchcode) for multiple item addition In-Reply-To: <bug-23851-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23851-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23851-70-5LuiJzQ2j7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23851 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 22:49:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 21:49:12 +0000 Subject: [Koha-bugs] [Bug 23851] Auto generate accession number format <branchcode>yymm0001 fails to add branchcode prefix(branchcode) for multiple item addition In-Reply-To: <bug-23851-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23851-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23851-70-FI7D8n3BDN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23851 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94519|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 94974 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94974&action=edit Bug 23851: Add the homebranch prefix to the barcode when adding multiple copies of an items See the comment in the code for more information. Test plan: - Set autoBarcode to hbyymmincr - Create an item and click on the barcode field - A barcode prefixed by the homebranch is generated - Click the "Add multiple copies of this item" and enter 4 - Save => Without this patch only the first item has the homebranch prefix => With this patch applied they all have a barcode in the same format Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 22:49:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 21:49:31 +0000 Subject: [Koha-bugs] [Bug 23851] Auto generate accession number format <branchcode>yymm0001 fails to add branchcode prefix(branchcode) for multiple item addition In-Reply-To: <bug-23851-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23851-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23851-70-jbHrzBzFCX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23851 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- 3 bugs for the price of one sign-off... a good deal I'd say :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 22:53:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 21:53:00 +0000 Subject: [Koha-bugs] [Bug 13273] Additem.pl barcode tag editor useless with autoBarcode disabled In-Reply-To: <bug-13273-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13273-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13273-70-X4vUv71hOT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13273 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=16580 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 22:53:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 21:53:00 +0000 Subject: [Koha-bugs] [Bug 16580] Explain the link between the autoBarcode preference and the cataloging plugin In-Reply-To: <bug-16580-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16580-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16580-70-RfMKzj5w0O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16580 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13273 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 22:54:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 21:54:45 +0000 Subject: [Koha-bugs] [Bug 8857] Add and duplicate functionality inconsistent w/autobarcode In-Reply-To: <bug-8857-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8857-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8857-70-s3kfLkHlWt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8857 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I've just tested this on master duplicating an existing item and using the duplicate fix of bug 23851 - in both cases, the barcode was left empty. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 22:56:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 21:56:18 +0000 Subject: [Koha-bugs] [Bug 15239] Add multiple items fail on barcode In-Reply-To: <bug-15239-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15239-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15239-70-5KexXFKljw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15239 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |DUPLICATE --- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** This bug has been marked as a duplicate of bug 23851 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 22:56:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 21:56:18 +0000 Subject: [Koha-bugs] [Bug 23851] Auto generate accession number format <branchcode>yymm0001 fails to add branchcode prefix(branchcode) for multiple item addition In-Reply-To: <bug-23851-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23851-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23851-70-pOvKL2Pgen@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23851 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hagud at orex.es --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** Bug 15239 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 23:06:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 22:06:36 +0000 Subject: [Koha-bugs] [Bug 23874] Advanced Editor is not loaded over HTTPS In-Reply-To: <bug-23874-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23874-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23874-70-33IctoNAcV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23874 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I can't replicate this issue on 18.11.10 - any more clues on where the hardcoded bit is hiding? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 23:33:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 22:33:19 +0000 Subject: [Koha-bugs] [Bug 23913] Use a single menu to sort lists in the OPAC In-Reply-To: <bug-23913-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23913-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23913-70-TX0tAng3A0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23913 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 23:33:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 22:33:23 +0000 Subject: [Koha-bugs] [Bug 23913] Use a single menu to sort lists in the OPAC In-Reply-To: <bug-23913-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23913-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23913-70-Xc7Wflq3py@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23913 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94814|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 94975 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94975&action=edit Bug 23913: Use a single menu to sort lists in the OPAC This patch modifies the sorting form on the OPAC list contents view so that the two menus (sort field and direction) are combined into one. This makes it consistent with the sort menu on the search results page. To test, apply the patch and view a list with multiple titles on it. Test the "Sort by" menu, trying all the various options. Confirm that the pre-selected item in the sorting menu is correct after each re-sort. Edit the list to change the default sorting and verify that the "Sort by" menu reflects your selection. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 23:36:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 22:36:23 +0000 Subject: [Koha-bugs] [Bug 23841] Add link to bibliographic details page in item details breadcrumbs In-Reply-To: <bug-23841-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23841-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23841-70-tKNOKBhucO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23841 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 23:36:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 22:36:27 +0000 Subject: [Koha-bugs] [Bug 23841] Add link to bibliographic details page in item details breadcrumbs In-Reply-To: <bug-23841-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23841-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23841-70-1JUo4q7wBQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23841 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94435|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 94976 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94976&action=edit Bug 23841: Add link to bibliographic details page in item details breadcrumbs This patch adds a link to the default bibliographic details page from the breadcrumbs menu on the item details page. The patch also makes a minor update to staff client CSS to allow for use of biblio-default-view.inc to generate the link and have it styled correctly. To test, apply the patch and update the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Locate an record in the catalog and view the item details page. Verify that the breadcrumbs menu includes a link back to the bibliographic details page as defined in the IntranetBiblioDefaultView system preference. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 23:37:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 22:37:59 +0000 Subject: [Koha-bugs] [Bug 23841] Add link to bibliographic details page in item details breadcrumbs In-Reply-To: <bug-23841-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23841-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23841-70-Xy9nejVV3B@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23841 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Should we change any of the other breadcrumbs as well? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 23:53:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 22:53:12 +0000 Subject: [Koha-bugs] [Bug 23889] Improve style of menu header in advanced cataloging editor In-Reply-To: <bug-23889-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23889-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23889-70-mNFeE9lTxh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23889 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 23:53:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 22:53:16 +0000 Subject: [Koha-bugs] [Bug 23889] Improve style of menu header in advanced cataloging editor In-Reply-To: <bug-23889-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23889-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23889-70-MEVkFCQQap@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23889 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94679|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 94977 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94977&action=edit Bug 23889: Improve style of menu header in advanced cataloging editor This patch updates the style of dropdown menu headers to make it apply more globally and changes the advanced cataloging editor template so that the correct class is applied to the menu header. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Test the interfaces where these kinds of menu headers can be found: - Catalog search results: The "Sort" menu (Popularity, Author, etc. headings). - Saved report results: Run a report which returns a column of biblionumbers or itemnumbers. Check the "Batch operations" menu (Bibliographic records or item records headings). - Advanced cataloging editor: The settings menu (Change framework header). Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 23:55:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 22:55:16 +0000 Subject: [Koha-bugs] [Bug 23899] Cannot change size of Show SQL Code box on run report page In-Reply-To: <bug-23899-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23899-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23899-70-hltifd9n96@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23899 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|19.05 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 23:57:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 22:57:42 +0000 Subject: [Koha-bugs] [Bug 23899] Cannot change size of Show SQL Code box on run report page In-Reply-To: <bug-23899-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23899-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23899-70-cIdGwS0K9y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23899 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- The little tab does work for me in master in Firefox, but not in Chromium. Same for the box on "edit report". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 23:58:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 22:58:20 +0000 Subject: [Koha-bugs] [Bug 8807] Add Carton support to Koha In-Reply-To: <bug-8807-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8807-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8807-70-OF8Ex4E3fD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8807 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19735 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 2 23:58:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 22:58:20 +0000 Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile In-Reply-To: <bug-19735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19735-70-nOWBwxm294@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=8807 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 00:07:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 23:07:37 +0000 Subject: [Koha-bugs] [Bug 23429] ilsdi.pl GetRecords documentation does not match output In-Reply-To: <bug-23429-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23429-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23429-70-laMXSl1qtT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23429 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 00:07:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 23:07:42 +0000 Subject: [Koha-bugs] [Bug 23429] ilsdi.pl GetRecords documentation does not match output In-Reply-To: <bug-23429-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23429-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23429-70-OyRoI8BQE4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23429 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92405|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 94978 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94978&action=edit Bug 23429: ilsdi.pl GetRecords documentation does not match output Updated contents of Describe for GetRecords to match current behaviour. To test, ensure ILSDI is configured and then compare the output of: http://yourserver/cgi-bin/koha/ilsdi.pl?service=Describe&verb=GetRecords before and after applying the patch. Note that afterwards it includes things like <onloan> and has removed elements such as <date_due> that no longer get returned. https://bugs.koha-community.org/show_bug.cgi?id=23429 Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 00:08:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 23:08:06 +0000 Subject: [Koha-bugs] [Bug 23429] ilsdi.pl GetRecords documentation does not match output In-Reply-To: <bug-23429-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23429-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23429-70-EwU3lZkarg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23429 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Nice improvement, Thx Jon! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 00:44:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 23:44:57 +0000 Subject: [Koha-bugs] [Bug 22857] Entries missing in koha-conf.xml In-Reply-To: <bug-22857-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22857-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22857-70-NybAlzasBB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22857 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|In Discussion |ASSIGNED --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Agreed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 00:46:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 02 Nov 2019 23:46:41 +0000 Subject: [Koha-bugs] [Bug 23055] Internal server error when trying to pay selected charges in fines accountant In-Reply-To: <bug-23055-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23055-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23055-70-dPWjlQKk7X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23055 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|BLOCKED |RESOLVED Resolution|--- |WORKSFORME -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 08:46:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 07:46:03 +0000 Subject: [Koha-bugs] [Bug 23841] Add link to bibliographic details page in item details breadcrumbs In-Reply-To: <bug-23841-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23841-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23841-70-nrpnIGbCt7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23841 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- This is a nice change.. may be worth doing elsewhere too.. though I can't think of any example off the top of my head. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 08:47:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 07:47:15 +0000 Subject: [Koha-bugs] [Bug 22661] TinyMCE/WYSIWYG editor doesn't translate In-Reply-To: <bug-22661-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22661-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22661-70-6mRbKK0dN0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22661 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 08:47:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 07:47:17 +0000 Subject: [Koha-bugs] [Bug 22661] TinyMCE/WYSIWYG editor doesn't translate In-Reply-To: <bug-22661-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22661-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22661-70-F8mCUMGmc6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22661 --- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 08:47:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 07:47:19 +0000 Subject: [Koha-bugs] [Bug 23089] Elasticsearch - cannot sort on non-text fields In-Reply-To: <bug-23089-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23089-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23089-70-EodqtNAPYp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23089 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 08:47:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 07:47:21 +0000 Subject: [Koha-bugs] [Bug 23089] Elasticsearch - cannot sort on non-text fields In-Reply-To: <bug-23089-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23089-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23089-70-jHYgFzxAXF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23089 --- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 08:47:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 07:47:24 +0000 Subject: [Koha-bugs] [Bug 23506] Sound material type displays wrong icon in OPAC/Staff details In-Reply-To: <bug-23506-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23506-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23506-70-z6aNAuVhP5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23506 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 08:47:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 07:47:25 +0000 Subject: [Koha-bugs] [Bug 23506] Sound material type displays wrong icon in OPAC/Staff details In-Reply-To: <bug-23506-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23506-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23506-70-WZncVdWESt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23506 --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 08:47:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 07:47:27 +0000 Subject: [Koha-bugs] [Bug 23762] Editing is_html status of email template fails under multi-languages In-Reply-To: <bug-23762-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23762-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23762-70-HnoJfUzFIm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23762 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 08:47:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 07:47:29 +0000 Subject: [Koha-bugs] [Bug 23762] Editing is_html status of email template fails under multi-languages In-Reply-To: <bug-23762-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23762-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23762-70-w6lhR1KEMY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23762 --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 08:47:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 07:47:31 +0000 Subject: [Koha-bugs] [Bug 23841] Add link to bibliographic details page in item details breadcrumbs In-Reply-To: <bug-23841-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23841-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23841-70-P0olsfNVqH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23841 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 08:47:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 07:47:33 +0000 Subject: [Koha-bugs] [Bug 23841] Add link to bibliographic details page in item details breadcrumbs In-Reply-To: <bug-23841-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23841-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23841-70-u5xn8sWCwB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23841 --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 08:47:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 07:47:34 +0000 Subject: [Koha-bugs] [Bug 23862] Add enumchron to holds-table on checkout page In-Reply-To: <bug-23862-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23862-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23862-70-ZaC7RMCmma@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23862 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 08:47:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 07:47:36 +0000 Subject: [Koha-bugs] [Bug 23862] Add enumchron to holds-table on checkout page In-Reply-To: <bug-23862-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23862-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23862-70-VGiyzYXN61@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23862 --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 08:47:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 07:47:38 +0000 Subject: [Koha-bugs] [Bug 23938] Title missing from Checked out box In-Reply-To: <bug-23938-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23938-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23938-70-UrmAlpbOfm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23938 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 08:47:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 07:47:40 +0000 Subject: [Koha-bugs] [Bug 23938] Title missing from Checked out box In-Reply-To: <bug-23938-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23938-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23938-70-xHUJzv501q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23938 --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 08:47:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 07:47:42 +0000 Subject: [Koha-bugs] [Bug 23946] Remove Noun Project icons from the About page In-Reply-To: <bug-23946-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23946-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23946-70-DdmHjm8cct@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23946 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 08:47:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 07:47:44 +0000 Subject: [Koha-bugs] [Bug 23946] Remove Noun Project icons from the About page In-Reply-To: <bug-23946-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23946-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23946-70-Nr933LmXvm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23946 --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 08:52:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 07:52:50 +0000 Subject: [Koha-bugs] [Bug 20194] Display both biblioitems.itemtype and items.itype in circulation screens In-Reply-To: <bug-20194-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20194-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20194-70-CKu72zwJMT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20194 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 08:52:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 07:52:53 +0000 Subject: [Koha-bugs] [Bug 20194] Display both biblioitems.itemtype and items.itype in circulation screens In-Reply-To: <bug-20194-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20194-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20194-70-36B4Epw4JT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20194 --- Comment #23 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 08:52:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 07:52:55 +0000 Subject: [Koha-bugs] [Bug 22592] Elasticsearch - Support for index scan In-Reply-To: <bug-22592-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22592-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22592-70-IeP7hPvkPv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 08:52:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 07:52:57 +0000 Subject: [Koha-bugs] [Bug 22592] Elasticsearch - Support for index scan In-Reply-To: <bug-22592-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22592-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22592-70-YgyMpWGN5Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22592 --- Comment #33 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 09:12:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 08:12:17 +0000 Subject: [Koha-bugs] [Bug 22581] Add support for Plaine & Easie musical incipits rendering in OPAC In-Reply-To: <bug-22581-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22581-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22581-70-N1gn62Hopo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 09:12:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 08:12:19 +0000 Subject: [Koha-bugs] [Bug 22581] Add support for Plaine & Easie musical incipits rendering in OPAC In-Reply-To: <bug-22581-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22581-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22581-70-BXiKhvEdUp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581 --- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 09:12:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 08:12:21 +0000 Subject: [Koha-bugs] [Bug 23834] Add default ESLint configuration In-Reply-To: <bug-23834-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23834-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23834-70-HTIOdel2ar@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23834 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 09:12:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 08:12:23 +0000 Subject: [Koha-bugs] [Bug 23834] Add default ESLint configuration In-Reply-To: <bug-23834-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23834-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23834-70-exbL8hu34X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23834 --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 17:27:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 16:27:51 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18936-70-MJdxRbIhFt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Failed QA --- Comment #88 from Josef Moravec <josef.moravec at gmail.com> --- I tested using git branch and found two issues: - holds per day are not transferred in database update - in note column, I can see link "view notes" even if there is no note - if the rule is specific for library and patron category, or for library and itemtype, the rules for current checkouts allowed and current on-site checkouts allowed are not transferred - No automatic renewal after (hard limit) does not respect dateformat and is shown in iso format - Overdue fines cap (amount) is not possible to edit in GUI -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 17:33:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 16:33:39 +0000 Subject: [Koha-bugs] [Bug 23429] ilsdi.pl GetRecords documentation does not match output In-Reply-To: <bug-23429-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23429-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23429-70-KdWBWtnE4m@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23429 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | Assignee|koha-bugs at lists.koha-commun |J.P.Knight at lboro.ac.uk |ity.org | CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 17:34:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 16:34:03 +0000 Subject: [Koha-bugs] [Bug 23429] ilsdi.pl GetRecords documentation does not match output In-Reply-To: <bug-23429-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23429-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23429-70-E5lakqDP8q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23429 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 17:34:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 16:34:07 +0000 Subject: [Koha-bugs] [Bug 23429] ilsdi.pl GetRecords documentation does not match output In-Reply-To: <bug-23429-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23429-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23429-70-UQsLIUDwZ1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23429 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94978|0 |1 is obsolete| | --- Comment #4 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 94979 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94979&action=edit Bug 23429: ilsdi.pl GetRecords documentation does not match output Updated contents of Describe for GetRecords to match current behaviour. To test, ensure ILSDI is configured and then compare the output of: http://yourserver/cgi-bin/koha/ilsdi.pl?service=Describe&verb=GetRecords before and after applying the patch. Note that afterwards it includes things like <onloan> and has removed elements such as <date_due> that no longer get returned. https://bugs.koha-community.org/show_bug.cgi?id=23429 Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 17:43:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 16:43:27 +0000 Subject: [Koha-bugs] [Bug 23181] Unable to use payment library in ACCOUNT_PAYMENT or ACCOUNT_WRITEOFF notices In-Reply-To: <bug-23181-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23181-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23181-70-e8inZYis1k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23181 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 17:43:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 16:43:30 +0000 Subject: [Koha-bugs] [Bug 23181] Unable to use payment library in ACCOUNT_PAYMENT or ACCOUNT_WRITEOFF notices In-Reply-To: <bug-23181-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23181-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23181-70-RxORZEkzEL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23181 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91520|0 |1 is obsolete| | Attachment #94967|0 |1 is obsolete| | --- Comment #7 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 94980 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94980&action=edit Bug 23181: Extend unit tests Run t/db_dependent/Accounts.t Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 17:43:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 16:43:33 +0000 Subject: [Koha-bugs] [Bug 23181] Unable to use payment library in ACCOUNT_PAYMENT or ACCOUNT_WRITEOFF notices In-Reply-To: <bug-23181-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23181-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23181-70-JwNzvmCqh4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23181 --- Comment #8 from Josef Moravec <josef.moravec at gmail.com> --- Created attachment 94981 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94981&action=edit Bug 23181: Unable to use payment library in ACCOUNT_PAYMENT or ACCOUNT_WRITEOFF notices Do to a simple semantic typo, the branches key will always be null for the tables key of the parameters for GetPreparedLetter. Test Plan: 0) Activate UseEmailReceipts 1) Attempt to use [% branch.branchname %] in the ACCOUNT_PAYMENT notice 2) Note it produces no output 3) Apply this patch 4) Make another payment 5) You should now see the branche's name! Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Also requires UseEmailReceipts to be activated. Signed-off-by: Josef Moravec <josef.moravec at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 17:44:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 16:44:04 +0000 Subject: [Koha-bugs] [Bug 23181] Unable to use payment library in ACCOUNT_PAYMENT or ACCOUNT_WRITEOFF notices In-Reply-To: <bug-23181-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23181-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23181-70-IpL97sNtmm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23181 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |josef.moravec at gmail.com |y.org | CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 19:53:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 18:53:31 +0000 Subject: [Koha-bugs] [Bug 23181] Unable to use payment library in ACCOUNT_PAYMENT or ACCOUNT_WRITEOFF notices In-Reply-To: <bug-23181-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23181-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23181-70-bg7wqnhMnz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23181 --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Thx Josef! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 20:07:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 19:07:14 +0000 Subject: [Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message In-Reply-To: <bug-23075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23075-70-hJnBZbWn1K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Failed QA --- Comment #29 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Failing because of David's last comment, can you have a look Martin? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 20:11:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 19:11:08 +0000 Subject: [Koha-bugs] [Bug 22569] Stock rotation: need transfer reports In-Reply-To: <bug-22569-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22569-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22569-70-Xr7M25BGkZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Martin, I am not sure about how the report is supposed to be used - can you explain? A bit worried that this will be the crucial bit: 2) There is no way to differentiate between a transfer that has been requested and a transfer than has been actually sent. So you won't see what has been put into transfer already? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 20:39:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 19:39:24 +0000 Subject: [Koha-bugs] [Bug 22304] Bugzilla blocked by UK mobile network EE In-Reply-To: <bug-22304-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22304-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22304-70-MjSS916OGN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22304 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|blocker |normal Resolution|--- |WORKSFORME Status|ASSIGNED |RESOLVED --- Comment #3 from Chris Cormack <chris at bigballofwax.co.nz> --- Yeah it's letsencrypt, there isn't much we can do about that. https://www.ssllabs.com/ssltest/analyze.html?d=bugs.koha-community.org&s=72.14.190.217 It gets a B (we support a couple of weaker encryption routines, that I will turn off) But the cert itself is fine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 22:02:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 21:02:05 +0000 Subject: [Koha-bugs] [Bug 23532] AutoCreateAuthorities create authority only headings In-Reply-To: <bug-23532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23532-70-I7DdpfV8ve@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23532 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|trivial |normal CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 22:06:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 21:06:34 +0000 Subject: [Koha-bugs] [Bug 23556] MARC bibliographic framework test (admin/checkmark.pl) does not consider item-level_itype system preference In-Reply-To: <bug-23556-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23556-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23556-70-xhzz34j2yH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23556 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |WONTFIX --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Sophie, I think this is the correct behavior. Even with item-level itypes, there is a lot of functionality in Koha that relies on a fallback on record level itemtypes (article requests on records without items, checks if something is holdable and which rule should apply, itemtype search in advanced search includes 942$c, etc.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 22:12:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 21:12:48 +0000 Subject: [Koha-bugs] [Bug 23572] Regression: Bug 18878 - Improve item form display / labels too far from input fields In-Reply-To: <bug-23572-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23572-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23572-70-SNOKi6ioO6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23572 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org Depends on| |19474 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- It looks like this might have been lost in or before the conversion to SCSS - Owen, could you maybe have a look? I am not where to add it in the scss - is there a specific sequence in the file? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 [Bug 19474] Convert staff client CSS to SCSS -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 22:12:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 21:12:48 +0000 Subject: [Koha-bugs] [Bug 19474] Convert staff client CSS to SCSS In-Reply-To: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19474-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19474-70-KZnXQoS3lH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19474 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23572 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23572 [Bug 23572] Regression: Bug 18878 - Improve item form display / labels too far from input fields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 22:13:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 21:13:01 +0000 Subject: [Koha-bugs] [Bug 23953] New: Cancelling hold does not work if checkout not completed Message-ID: <bug-23953-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23953 Bug ID: 23953 Summary: Cancelling hold does not work if checkout not completed Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com To reproduce: 1. Place a hold on item A for patron A 2. Check out item A to patron B 3. See the prompt to confirm the checkout because the hold for patron A exists. Check the 'cancel hold' checkbox and click the 'No, don't check out' button 4. Notice the hold for patron A is NOT cancelled <-- bug 5. Attempt to check out item to patron B again 6. This time, check the 'cancel hold' checkbox but click the 'Yes, check out' button 7. Notice that item A is successfully checked out to patron B and the hold for patron A has been cancelled. Therefore, the 'cancel hold' checkbox does not work if the checkout is not completed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 22:17:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 21:17:51 +0000 Subject: [Koha-bugs] [Bug 23574] Adding a suggestion to a basket when UseACQFrameworkForBiblioRecords is use publication date is not copied In-Reply-To: <bug-23574-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23574-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23574-70-FOCHMIupk2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23574 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Patrick, I just tested on master with the default ACQ framework and my 260c ended up in copyrightdate correctly as mapped. Can you retest and tell us the exact version you are testing with? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 22:21:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 21:21:34 +0000 Subject: [Koha-bugs] [Bug 23616] Private repeatable note field needed in Serials Subscription Record In-Reply-To: <bug-23616-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23616-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23616-70-PTFPnWD8Ay@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23616 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|18.11 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 22:22:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 21:22:20 +0000 Subject: [Koha-bugs] [Bug 23618] Make addition SIP2 fields available to self service to add cost of items checked out to check out slip In-Reply-To: <bug-23618-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23618-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23618-70-m6APhfzR7u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23618 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.11 |master CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 22:25:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 21:25:16 +0000 Subject: [Koha-bugs] [Bug 3642] New information in overdues CSV export In-Reply-To: <bug-3642-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-3642-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3642-70-O9F36H47so@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3642 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|New informations in |New information in overdues |overdues CSV export |CSV export -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 22:29:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 21:29:06 +0000 Subject: [Koha-bugs] [Bug 4809] Allow to pay lost item replacement fee when changing the lost status In-Reply-To: <bug-4809-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-4809-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4809-70-s1f3e3wDaf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4809 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Lost & Paid For doesn't |Allow to pay lost item |record payment |replacement fee when | |changing the lost status --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think the comment from Chris on comment#6 is still valid. There is no special behavior tied to any of the lost values - they all do the same thing. If we want a way to immediately mark 'paid' when changing the lost status, this will need more work. Another way might be a pref, where you list the lost values that you want to do that for. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 22:31:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 21:31:31 +0000 Subject: [Koha-bugs] [Bug 23954] New: Format notes in suggestion management Message-ID: <bug-23954-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23954 Bug ID: 23954 Summary: Format notes in suggestion management Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org In looking for places in the templates where we still refer to famfamfam icons I found some inline CSS in the suggestions management page. A markup mis-match means that this style hasn't been correctly applied. I would like to modify the CSS and markup so that the note stands out from the other info in the suggestions list and replace the background image icon with a Font Awesome icon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 22:44:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 21:44:03 +0000 Subject: [Koha-bugs] [Bug 23954] Format notes in suggestion management In-Reply-To: <bug-23954-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23954-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23954-70-Tnk3RLpuJn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23954 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 22:44:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 21:44:06 +0000 Subject: [Koha-bugs] [Bug 23954] Format notes in suggestion management In-Reply-To: <bug-23954-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23954-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23954-70-8uT6NM2KCt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23954 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 94982 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94982&action=edit Bug 23954: Format notes in suggestion management This patch makes minor CSS and markup changes in order to deliniate suggestion notes from the other data in the suggestions list view. To test you should have at least one suggestion with a note. Apply the patch and go to Acquisitions -> Suggestions. In the table of suggestions, check that the notes display clearly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 22:47:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 21:47:55 +0000 Subject: [Koha-bugs] [Bug 23622] Add the ability to edit suspension restrictions In-Reply-To: <bug-23622-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23622-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23622-70-iSVovKiENw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23622 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.11 |master Summary|Add the ability to edit |Add the ability to edit |suspensions like fines |suspension restrictions |would be edited. | CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 22:56:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 21:56:35 +0000 Subject: [Koha-bugs] [Bug 23847] Custom item search fields don't work if subfield is 0 (e.g. Withdrawn) In-Reply-To: <bug-23847-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23847-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23847-70-pL8MGD2CP8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23847 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 22:56:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 21:56:38 +0000 Subject: [Koha-bugs] [Bug 23847] Custom item search fields don't work if subfield is 0 (e.g. Withdrawn) In-Reply-To: <bug-23847-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23847-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23847-70-HQex0OAOmE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23847 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94423|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 94983 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94983&action=edit Bug 23847: Fix custom item search fields if subfield is '0' The subfield is not used if is false, so if 0. We want to test if the subfield is defined and not an empty string. Test plan: - Define a new custom item search fields using a subfield '0' (withdrawn=952$0 for instance) - Define one which does not have a subfield (control field) - Search items using those newly created fields. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 22:57:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 21:57:41 +0000 Subject: [Koha-bugs] [Bug 23868] PayPal payment button is never enabled In-Reply-To: <bug-23868-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23868-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23868-70-mFgjZHRHi0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23868 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |tomascohen at gmail.com --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Tomas or Kyle, can you help here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 23:02:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 22:02:44 +0000 Subject: [Koha-bugs] [Bug 23955] New: Replace famfamfam icon in OPAC holds template Message-ID: <bug-23955-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23955 Bug ID: 23955 Summary: Replace famfamfam icon in OPAC holds template Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org The OPAC holds template uses a famfamfam icon image to indicate an item which cannot be put on hold when "a specific item" has been selected. This icon can be replaced with an Font Awesome icon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 23:09:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 22:09:32 +0000 Subject: [Koha-bugs] [Bug 23955] Replace famfamfam icon in OPAC holds template In-Reply-To: <bug-23955-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23955-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23955-70-kcCsIFcCWf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23955 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 23:09:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 22:09:35 +0000 Subject: [Koha-bugs] [Bug 23955] Replace famfamfam icon in OPAC holds template In-Reply-To: <bug-23955-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23955-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23955-70-a3Mikx3ony@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23955 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 94984 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94984&action=edit Bug 23955: Replace famfamfam icon in OPAC holds template This patch modifies the OPAC holds template so that when an item isn't available for an item-level hold a Font Awesome icon is displayed instead of a famfamfam image. To test, apply the patch and regenerate the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Make sure you have items which can be placed on hold at the item level. - Locate a title with more than one item, at least one of which isn't available to be placed on hold (item is marked withdrawn, for instance). - Start the process of placing a hold on the item. - On the "Confirm holds" scren, click "Show more options" and select "A specific item." - In the table of items, any item which isn't available to be put on hold should be inidicated with a red X. The title attribute of the icon should show "Cannot be put on hold." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 23:19:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 22:19:50 +0000 Subject: [Koha-bugs] [Bug 22846] Remove warning in the manual about needing StaticHoldsQueueWeight to use RandomizeHoldsQueueWeight In-Reply-To: <bug-22846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22846-70-rhN5VpY6Pw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22846 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Found another mention of this in the 'holds queue' description. Will make a merge request to remove. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 23:26:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 22:26:50 +0000 Subject: [Koha-bugs] [Bug 23499] Show subtitle in serials search In-Reply-To: <bug-23499-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23499-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23499-70-bLNaGNlCb0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23499 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I agree seeing more would be nice, but I wonder if it's as easy as changing the display here - if we display it, we should probably make it searchable as well? But that pushes this to another level of complexity. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 23:29:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 22:29:31 +0000 Subject: [Koha-bugs] [Bug 23956] New: Replace famfamfam calendar icon in staff client with CSS data-url Message-ID: <bug-23956-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23956 Bug ID: 23956 Summary: Replace famfamfam calendar icon in staff client with CSS data-url Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org The calendar icon we show with datepicker input fields can't be replaced by a Font Awesome icon because the image is displayed as a background image inside the input field itself. A simplified version of the famfamfam calendar icon converted to a data-url is only about 200 characters. This seems compact enough to include in staff-global.css to eliminate an image dependency. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 23:33:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 22:33:45 +0000 Subject: [Koha-bugs] [Bug 23498] [18.11] Broken links to bibs when placing holds on multiple records and a hold exists on at least one record In-Reply-To: <bug-23498-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23498-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23498-70-WWj5fOxuXu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23498 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Broken links to bibs when |[18.11] Broken links to |placing holds on multiple |bibs when placing holds on |records and a hold exists |multiple records and a hold |on at least one record |exists on at least one | |record CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I just tested this on master, but the display of information there is quite different. On 18.11 I can confirm the bug, suspecting a problem in the template. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 23:36:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 22:36:15 +0000 Subject: [Koha-bugs] [Bug 23477] Alphabet error searching In-Reply-To: <bug-23477-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23477-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23477-70-2BKuJowXWM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23477 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Imr, can you provide more information on where you search? Is this patron search? bibiographic search? which search option is used? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 23:37:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 22:37:52 +0000 Subject: [Koha-bugs] [Bug 23467] BlockExpiredPatronOpacActions is causing screen to duplicate In-Reply-To: <bug-23467-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23467-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23467-70-ck6DeetY7L@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23467 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- OPAC bug, major... giving it another nudge. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 23:38:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 22:38:15 +0000 Subject: [Koha-bugs] [Bug 23956] Replace famfamfam calendar icon in staff client with CSS data-url In-Reply-To: <bug-23956-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23956-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23956-70-ysHomL3R0n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23956 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 23:38:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 22:38:18 +0000 Subject: [Koha-bugs] [Bug 23956] Replace famfamfam calendar icon in staff client with CSS data-url In-Reply-To: <bug-23956-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23956-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23956-70-BqH6oNzJaR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23956 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 94985 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94985&action=edit Bug 23956: Replace famfamfam calendar icon in staff client with CSS data-url This patch modifies the staff client CSS so that the backround image for datepicker input fields is defined as a data-url rather than a reference to an image file. To test, apply the patch and regenerate the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - In the staff client, view any form which includes a datepicker-styled input. For instance, patron entry: date of birth, expiry; Aquisitions -> Late orders -> Filter results. - Confirm that the calendar icon looks correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 23:40:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 22:40:44 +0000 Subject: [Koha-bugs] [Bug 23478] Simplify report landing page In-Reply-To: <bug-23478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23478-70-AW9K2btZM9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23478 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I'd agree to use the complete navigation as on the other pages on "Saved reports", but I think as we have a module with multiple pages and reports that go with it, it makes sense to have a start page, like we have for the other modules. You could change the module link to be saved reports with jQuery maybe? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 23:43:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 22:43:24 +0000 Subject: [Koha-bugs] [Bug 23954] Format notes in suggestion management In-Reply-To: <bug-23954-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23954-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23954-70-LsR9SGb2JQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23954 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 23:43:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 22:43:51 +0000 Subject: [Koha-bugs] [Bug 23483] When writing off a fine, the title of the patron is shown as description In-Reply-To: <bug-23483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23483-70-Gh2fJvKZ0W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23483 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Confirmed on master now as well. To test: - Make sure that in the account you use a saluation is set (Mr Mrs...) - Create a manual fine - Pay or Writeoff the fine using the buttons next to the fine (not at the bottom) - Look at the description shown before saving -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 23:44:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 22:44:09 +0000 Subject: [Koha-bugs] [Bug 23483] When writing off a fine, the title of the patron is shown as description In-Reply-To: <bug-23483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23483-70-nw8466NEfZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23483 --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Katrin Fischer from comment #1) > Confirmed on master now as well. > > To test: > - Make sure that in the account you use a saluation is set (Mr Mrs...) > - Create a manual fine > - Pay or Writeoff the fine using the buttons next to the fine (not at the > bottom) > - Look at the description shown before saving It only happens for writeoff. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 3 23:47:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 22:47:32 +0000 Subject: [Koha-bugs] [Bug 23483] When writing off a fine, the title of the patron is shown as description In-Reply-To: <bug-23483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23483-70-DZtG6TticX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23483 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | Version|unspecified |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 00:02:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 23:02:03 +0000 Subject: [Koha-bugs] [Bug 23888] Incorrect vendor id in subscription creation causes internal server error In-Reply-To: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23888-70-tTgij10dHq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I can't replicate the error on master - now it just saves and doesn't show a vendor name in the details. We should validate if the vendor id is valid before switching to the next page. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 00:02:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 23:02:18 +0000 Subject: [Koha-bugs] [Bug 23955] Replace famfamfam icon in OPAC holds template In-Reply-To: <bug-23955-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23955-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23955-70-nVh2a9u5YN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23955 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 00:02:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 23:02:38 +0000 Subject: [Koha-bugs] [Bug 23956] Replace famfamfam calendar icon in staff client with CSS data-url In-Reply-To: <bug-23956-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23956-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23956-70-xxR9PAMfIi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23956 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 00:03:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 23:03:53 +0000 Subject: [Koha-bugs] [Bug 23483] When writing off a fine, the title of the patron is shown as description In-Reply-To: <bug-23483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23483-70-mzI49jVZPo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23483 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 00:03:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 23:03:57 +0000 Subject: [Koha-bugs] [Bug 23483] When writing off a fine, the title of the patron is shown as description In-Reply-To: <bug-23483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23483-70-eZj4a2rwBc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23483 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 94986 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94986&action=edit Bug 23483: Show the description, not the patron's title when writing off an individual fine/fee When writing off an individual fine, the description shown was the patron's title, instead of the fine description. Fixing it by changing it to the same template variable used for paying individuals so they match up. To test: - Pick a patron and make sure salutation is set (Mr, Mrs, ...) - Create a manual fine - For the fine, compare the description shown when using the Writeoff and Pay buttons next to the fine - Verify the display is different and writeoff displays the salutation - Apply patch - Repeat, descriptions now should match up -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 00:07:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 23:07:52 +0000 Subject: [Koha-bugs] [Bug 23956] Replace famfamfam calendar icon in staff client with CSS data-url In-Reply-To: <bug-23956-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23956-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23956-70-Wy48HssbjB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23956 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 00:07:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 23:07:56 +0000 Subject: [Koha-bugs] [Bug 23956] Replace famfamfam calendar icon in staff client with CSS data-url In-Reply-To: <bug-23956-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23956-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23956-70-gB0QkGU0YL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23956 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94985|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 94987 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94987&action=edit Bug 23956: Replace famfamfam calendar icon in staff client with CSS data-url This patch modifies the staff client CSS so that the backround image for datepicker input fields is defined as a data-url rather than a reference to an image file. To test, apply the patch and regenerate the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - In the staff client, view any form which includes a datepicker-styled input. For instance, patron entry: date of birth, expiry; Aquisitions -> Late orders -> Filter results. - Confirm that the calendar icon looks correct. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 00:10:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 23:10:52 +0000 Subject: [Koha-bugs] [Bug 23955] Replace famfamfam icon in OPAC holds template In-Reply-To: <bug-23955-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23955-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23955-70-LzWI2HNHpJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23955 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 00:10:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 23:10:56 +0000 Subject: [Koha-bugs] [Bug 23955] Replace famfamfam icon in OPAC holds template In-Reply-To: <bug-23955-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23955-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23955-70-u85fx009sA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23955 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94984|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 94988 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94988&action=edit Bug 23955: Replace famfamfam icon in OPAC holds template This patch modifies the OPAC holds template so that when an item isn't available for an item-level hold a Font Awesome icon is displayed instead of a famfamfam image. To test, apply the patch and regenerate the OPAC CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Make sure you have items which can be placed on hold at the item level. - Locate a title with more than one item, at least one of which isn't available to be placed on hold (item is marked withdrawn, for instance). - Start the process of placing a hold on the item. - On the "Confirm holds" scren, click "Show more options" and select "A specific item." - In the table of items, any item which isn't available to be put on hold should be inidicated with a red X. The title attribute of the icon should show "Cannot be put on hold." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 00:14:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 23:14:01 +0000 Subject: [Koha-bugs] [Bug 8132] batch delete tool deletes items with holds on them In-Reply-To: <bug-8132-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8132-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8132-70-Wtaq8JmcZu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 --- Comment #23 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Christopher Brannon from comment #22) > (In reply to Jonathan Druart from comment #21) > > Trying to get back to this. > > > > Are we supposed to silently delete an item with an item-level hold that is > > not found (W or T)? > > In my opinion, staff or patron should be notified. At least staff, because > they could make a decision to move the hold to another record, order the > item, or notify the patron that the item is no longer available. I think a notification in the GUI would be good, Maybe at the top, sth like: Following items can't be deleted because they have holds on them? What if it's a record level hold and it's the last item? Maybe we should just check for items in general. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 00:14:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 23:14:12 +0000 Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them In-Reply-To: <bug-8132-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8132-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8132-70-w3Ol5QXSn7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|batch delete tool deletes |Batch delete tool deletes |items with holds on them |items with holds on them -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 00:18:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 23:18:23 +0000 Subject: [Koha-bugs] [Bug 23876] Holds queue section says it "shows all of the holds at your library" which is not true In-Reply-To: <bug-23876-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23876-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23876-70-H9kDMrDd6n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23876 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | Resolution|--- |FIXED --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Merge request sent. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 00:42:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 23:42:29 +0000 Subject: [Koha-bugs] [Bug 23957] New: Remove button style with famfamfam icon background and replace with Font Awesome Message-ID: <bug-23957-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23957 Bug ID: 23957 Summary: Remove button style with famfamfam icon background and replace with Font Awesome Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org When hold policy override is enabled and the librarian tries to place a hold on an title which would otherwise not be available to be placed on hold, the input button is shown with a "warning" icon. Elsewhere in this template this image icon was replaced with a Font Awesome icon (in Bug 14695). This should be done for the inputs as well. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 00:42:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 23:42:29 +0000 Subject: [Koha-bugs] [Bug 14695] Add ability to place multiple item holds on a given record per patron In-Reply-To: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14695-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14695-70-e4hheJpV0F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14695 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23957 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 00:51:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 23:51:46 +0000 Subject: [Koha-bugs] [Bug 23957] Remove button style with famfamfam icon background and replace with Font Awesome In-Reply-To: <bug-23957-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23957-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23957-70-SX4Li5TpD4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23957 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 00:51:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 03 Nov 2019 23:51:49 +0000 Subject: [Koha-bugs] [Bug 23957] Remove button style with famfamfam icon background and replace with Font Awesome In-Reply-To: <bug-23957-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23957-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23957-70-YbSL6X4Ir7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23957 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 94989 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94989&action=edit Bug 23957: Remove button style with famfamfam icon background and replace with Font Awesome The patch modifies the markup and CSS related to the holds template in the staff client when holds policy override is necessary. The CSS background image is replaced with a Font Awesome icon. <input>s are replaced with <button>s to allow for the icon markup. To test, apply the patch and regenerate the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Enable the AllowHoldPolicyOverride system preference. - Start the process of placing a hold for a patron on a title which would not normally be available for hold. For instance: The patron already has too many holds. - On the hold confirmation screen the "Place hold" buttons should appear with a little yellow "warning" icon. - Clicking either of the two "Place hold" buttons should trigger a confirmation dialog. Test both the "Confirm" and "Cancel" options. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 01:37:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 00:37:22 +0000 Subject: [Koha-bugs] [Bug 23958] New: Use Font Awesome icon to replace "new window" icon image Message-ID: <bug-23958-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23958 Bug ID: 23958 Summary: Use Font Awesome icon to replace "new window" icon image Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Several links in the staff client are styled with a "new window" icon to indicate that they will open a pop-up. These can use Font Awesome icons instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 05:11:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 04:11:44 +0000 Subject: [Koha-bugs] [Bug 23959] New: Label Creator gives empty PDF Message-ID: <bug-23959-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23959 Bug ID: 23959 Summary: Label Creator gives empty PDF Change sponsored?: --- Product: Koha Version: 18.11 Hardware: Other OS: Linux Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: sakib.ahmed at bracu.ac.bd QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 05:13:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 04:13:14 +0000 Subject: [Koha-bugs] [Bug 23959] Label Creator gives empty PDF In-Reply-To: <bug-23959-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23959-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23959-70-3it6vzVSf3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23959 --- Comment #1 from sakibahmedsezan <sakib.ahmed at bracu.ac.bd> --- CSV and XLM are working fine. Just exported PDF is an empty one, no data or barcode drawn -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 05:41:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 04:41:45 +0000 Subject: [Koha-bugs] [Bug 23959] Label Creator gives empty PDF In-Reply-To: <bug-23959-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23959-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23959-70-aSmFrVbIkg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23959 sakibahmedsezan <sakib.ahmed at bracu.ac.bd> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #2 from sakibahmedsezan <sakib.ahmed at bracu.ac.bd> --- Sorry!! my bad. Didn't properly defined Label Templets. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 08:31:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 07:31:22 +0000 Subject: [Koha-bugs] [Bug 23888] Incorrect vendor id in subscription creation causes internal server error In-Reply-To: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23888-70-dZuv5ujb1F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888 --- Comment #2 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> --- (In reply to Katrin Fischer from comment #1) > I can't replicate the error on master - now it just saves and doesn't show a > vendor name in the details. We should validate if the vendor id is valid > before switching to the next page. That happens to me also when I type some other invalid vendor id. If I type exactly "9999999999" then the error happens. Did you type that exactly? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 09:07:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 08:07:18 +0000 Subject: [Koha-bugs] [Bug 22988] Visible reduction in image quality In-Reply-To: <bug-22988-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22988-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22988-70-PEfoS5zzXa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22988 --- Comment #11 from Magnus Enger <magnus at libriotech.no> --- (In reply to Katrin Fischer from comment #10) > If it's doable we should consider that - leaving it that way another release > woud not be good. Agreed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 09:18:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 08:18:49 +0000 Subject: [Koha-bugs] [Bug 19809] Koha::Objects::find calls do not need to be forbidden in list context In-Reply-To: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19809-70-7NG73osilm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809 --- Comment #12 from Julian Maurice <julian.maurice at biblibre.com> --- (In reply to Marcel de Rooy from comment #11) > (In reply to Martin Renvoize from comment #10) > > This seems sane to me and I like to follow the example set by DBIx::Class to > > be honest.. that project has been around for a long time and has made allot > > of good decisions for good reasons. > > I would agree with you if we were writing Koha::Objects->find at this > moment. But in the meantime they go back to bug 13019, pushed 02/2015. How > many find calls do we have now, and associated if conditions etc.? > In view of that volume and the risk of breaking a lot of code, I would not > recommend it now. Currently, calls to `find` are always in scalar context (because otherwise Koha croaks), and this patch doesn't change the behaviour of `find` in scalar context. Why do you think there's a risk of breaking code ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 09:50:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 08:50:48 +0000 Subject: [Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and does not indicate it is for SIP-based checkouts only In-Reply-To: <bug-23233-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23233-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23233-70-xjQh2gVqp2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233 --- Comment #21 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> --- (In reply to Katrin Fischer from comment #20) > Hi Joonas, > > this one is confusing to me - from the bug title/description it only seemed > to affect the description of the pref/naming of the pref, so I expected an > easy QA, but there is definitely more going on here. > > Can you explain why you removed the checks for the prefs in several parts of > the code? Especially the changes to GetItemsInfo. Does the comment #6 explain (and the ones before that)? Kyle, maybe you would like to improve the commit messages? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 10:05:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 09:05:38 +0000 Subject: [Koha-bugs] [Bug 23954] Format notes in suggestion management In-Reply-To: <bug-23954-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23954-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23954-70-Hgdgsf57Vy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23954 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 10:05:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 09:05:43 +0000 Subject: [Koha-bugs] [Bug 23954] Format notes in suggestion management In-Reply-To: <bug-23954-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23954-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23954-70-tXGZaRRiPG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23954 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94982|0 |1 is obsolete| | --- Comment #2 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 94990 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94990&action=edit Bug 23954: Format notes in suggestion management This patch makes minor CSS and markup changes in order to deliniate suggestion notes from the other data in the suggestions list view. To test you should have at least one suggestion with a note. Apply the patch and go to Acquisitions -> Suggestions. In the table of suggestions, check that the notes display clearly. Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 10:09:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 09:09:04 +0000 Subject: [Koha-bugs] [Bug 23960] New: Issue with MariaDB (rows column name in creator_template table) Message-ID: <bug-23960-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23960 Bug ID: 23960 Summary: Issue with MariaDB (rows column name in creator_template table) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: amitddng135 at gmail.com QA Contact: testopia at bugs.koha-community.org Using 'rows' as a column name in creator_templates table giving error while saving. (Issue with MariaDB version: 10.3.13). As in MariaDB 'rows' is a predefined column name. I think we can change the column name rows to rowls -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 10:09:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 09:09:23 +0000 Subject: [Koha-bugs] [Bug 23960] Issue with MariaDB (rows column name in creator_template table) In-Reply-To: <bug-23960-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23960-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23960-70-6ThO6fSMaE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23960 Amit Gupta <amitddng135 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|cnighswonger at foundations.ed |amitddng135 at gmail.com |u | Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 10:11:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 09:11:06 +0000 Subject: [Koha-bugs] [Bug 23960] Issue with MariaDB (rows column name in creator_template table) In-Reply-To: <bug-23960-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23960-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23960-70-pDwn1JK2LW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23960 Amit Gupta <amitddng135 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amit.gupta at informaticsgloba | |l.com, | |chris at bigballofwax.co.nz, | |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 10:11:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 09:11:56 +0000 Subject: [Koha-bugs] [Bug 23960] Issue with MariaDB (rows column name in creator_template table) In-Reply-To: <bug-23960-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23960-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23960-70-7Uk0DRjqdq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23960 Amit Gupta <amitddng135 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P2 Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 10:12:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 09:12:38 +0000 Subject: [Koha-bugs] [Bug 23960] Issue with MariaDB version (rows column name in creator_template table) In-Reply-To: <bug-23960-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23960-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23960-70-oj4RMPuAnR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23960 Amit Gupta <amitddng135 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Issue with MariaDB (rows |Issue with MariaDB version |column name in |(rows column name in |creator_template table) |creator_template table) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 10:14:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 09:14:18 +0000 Subject: [Koha-bugs] [Bug 21939] Permission for holds history tab is too strict In-Reply-To: <bug-21939-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21939-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21939-70-7ZfDY4T0uv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 10:14:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 09:14:21 +0000 Subject: [Koha-bugs] [Bug 21939] Permission for holds history tab is too strict In-Reply-To: <bug-21939-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21939-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21939-70-GLFt8IaCK8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94972|0 |1 is obsolete| | --- Comment #4 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 94991 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94991&action=edit Bug 21939: Fix permissions for holds history tab The tab will show when the staff user has edit_borrowers permission, but the page itself will not be accessible. This patch fixes the page permissions to allow access with the edit_borrowers permission as suggested by the comments on the original bug report. To test: - Create a staff user with only "edit_borrowers" permission from the borrowers module - Try to access the holds history tab from any patron account - Verify you are blocked - Apply patch - Try again and verify the page is accessible now - Repeat with superlibrarian and full borrowers permission. Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 10:54:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 09:54:32 +0000 Subject: [Koha-bugs] [Bug 23719] Record matching for authorities using defined fields is broken under ES In-Reply-To: <bug-23719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23719-70-Of9H2OnRCI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23719 --- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Martin Renvoize from comment #7) > Does the extra patch here resolve your worries Jonathan? I do not think so: Unknown search field personal-name in marclist at /home/vagrant/kohaclone/Koha/SearchEngine/Elasticsearch/QueryBuilder.pm line 478. http://pro.kohadev.org/cgi-bin/koha/authorities/authorities-home.pl?op=do_search&type=intranet&marclist=Personal-name&and_or=and&operator=contains&value=d&orderby=HeadingAsc -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 11:21:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 10:21:36 +0000 Subject: [Koha-bugs] [Bug 23483] When writing off a fine, the title of the patron is shown as description In-Reply-To: <bug-23483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23483-70-53lXYgm6pg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23483 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 11:21:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 10:21:40 +0000 Subject: [Koha-bugs] [Bug 23483] When writing off a fine, the title of the patron is shown as description In-Reply-To: <bug-23483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23483-70-oH3wqvxCTB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23483 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94986|0 |1 is obsolete| | --- Comment #4 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 94992 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94992&action=edit Bug 23483: Show the description, not the patron's title when writing off an individual fine/fee When writing off an individual fine, the description shown was the patron's title, instead of the fine description. Fixing it by changing it to the same template variable used for paying individuals so they match up. To test: - Pick a patron and make sure salutation is set (Mr, Mrs, ...) - Create a manual fine - For the fine, compare the description shown when using the Writeoff and Pay buttons next to the fine - Verify the display is different and writeoff displays the salutation - Apply patch - Repeat, descriptions now should match up Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 11:25:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 10:25:15 +0000 Subject: [Koha-bugs] [Bug 23957] Remove button style with famfamfam icon background and replace with Font Awesome In-Reply-To: <bug-23957-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23957-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23957-70-CYffXlnPln@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23957 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Owen Leonard from comment #0) > This should be done for the inputs as well. Why not on the same patch? $ yarn build Message: koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss Error: Invalid CSS after "...hadow: 0 -1px 0": expected expression (e.g. 1px, bold), was "#00000059;" on line 1794 of koha-tmpl/intranet-tmpl/prog/css/src/staff-global.scss >> text-shadow: 0 -1px 0 #00000059; ----------------------------------^ The hex code color is not valid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 11:27:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 10:27:30 +0000 Subject: [Koha-bugs] [Bug 23751] Description of staffaccess permission should be improved In-Reply-To: <bug-23751-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23751-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23751-70-a9q5QL71h6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23751 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 11:27:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 10:27:33 +0000 Subject: [Koha-bugs] [Bug 23751] Description of staffaccess permission should be improved In-Reply-To: <bug-23751-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23751-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23751-70-LUTeeLrNp8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23751 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94961|0 |1 is obsolete| | --- Comment #4 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 94993 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94993&action=edit Bug 23751: Make staffaccess permission description more precise The permission description was missing 'username' from the description. To test: - Look at the permissions of a patron - Verify the staffaccess permission is labelled: Allow staff members to modify permissions and passwords for other staff members - Apply patch - Check description again: Allow staff members to modify permissions, usernames, and passwords for other staff members Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 11:29:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 10:29:48 +0000 Subject: [Koha-bugs] [Bug 23079] Checkouts page broken because of problems with date calculation (TZAmerica/Sao_Paulo) In-Reply-To: <bug-23079-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23079-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23079-70-6IERsdOF3c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23079 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |liz at catalyst.net.nz, | |lucas at bywatersolutions.com --- Comment #24 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- @RMaints, please backport this one, even if a bit late for this year. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 11:30:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 10:30:11 +0000 Subject: [Koha-bugs] [Bug 20389] Indexing fields concatenated In-Reply-To: <bug-20389-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20389-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20389-70-wvqqvHlnSW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20389 claire.hernandez at biblibre.com <claire.hernandez at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #7 from claire.hernandez at biblibre.com <claire.hernandez at biblibre.com> --- I think yes, thank you. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 11:31:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 10:31:13 +0000 Subject: [Koha-bugs] [Bug 23948] Move mandatory .sql files to the mandatory/ directory In-Reply-To: <bug-23948-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23948-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23948-70-tTvEdaXMyp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23948 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- *** This bug has been marked as a duplicate of bug 23895 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 11:31:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 10:31:13 +0000 Subject: [Koha-bugs] [Bug 23895] We should tidy up the directories under installer/data/mysql/ In-Reply-To: <bug-23895-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23895-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23895-70-Q0kVpVhBXN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23895 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- *** Bug 23948 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 11:33:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 10:33:45 +0000 Subject: [Koha-bugs] [Bug 23234] Circulation.t failing when comparing dates that seem identical In-Reply-To: <bug-23234-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23234-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23234-70-hu0Xekm5si@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23234 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Upping severity, it's very annoying for people hitting this one (hard to write or execute those tests). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 11:36:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 10:36:54 +0000 Subject: [Koha-bugs] [Bug 23952] Fix body id on OPAC course details page In-Reply-To: <bug-23952-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23952-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23952-70-EcQMqtzrIX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23952 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 11:36:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 10:36:57 +0000 Subject: [Koha-bugs] [Bug 23952] Fix body id on OPAC course details page In-Reply-To: <bug-23952-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23952-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23952-70-YBVOdMOtwO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23952 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94969|0 |1 is obsolete| | --- Comment #2 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 94994 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94994&action=edit Bug 23952: Fix body tag on OPAC course details page The id was not changed, when the page was added and remained opac-main. The patch changes it to opac-course-details so the page has its own unique id. To test: - Add a course reserve to your installation - Go to the course reserves page in the OPAC - Click on the course to see its details - Look at the source code, the <body> tag should show: Without patch: opac-main with patch applied: opac-course-details Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 11:40:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 10:40:56 +0000 Subject: [Koha-bugs] [Bug 20116] Cache language list In-Reply-To: <bug-20116-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20116-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20116-70-58q3g2BN19@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 11:41:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 10:41:00 +0000 Subject: [Koha-bugs] [Bug 20116] Cache language list In-Reply-To: <bug-20116-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20116-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20116-70-o0A2EQOQyX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88200|0 |1 is obsolete| | Attachment #88201|0 |1 is obsolete| | Attachment #88202|0 |1 is obsolete| | --- Comment #44 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 94995 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94995&action=edit Bug 20116: Prepare the ground Just refactoring to make the next patch more readable Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 11:41:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 10:41:04 +0000 Subject: [Koha-bugs] [Bug 20116] Cache language list In-Reply-To: <bug-20116-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20116-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20116-70-juhouWQdVQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 --- Comment #45 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 94996 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94996&action=edit Bug 20116: Flush the caches When languages are added or removed when need to flush the caches to keep the interface consistent Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 11:41:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 10:41:09 +0000 Subject: [Koha-bugs] [Bug 20116] Cache language list In-Reply-To: <bug-20116-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20116-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20116-70-wrP25Q0Eou@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 --- Comment #46 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 94997 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94997&action=edit Bug 20116: Cache language list Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 11:43:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 10:43:27 +0000 Subject: [Koha-bugs] [Bug 20116] Cache language list In-Reply-To: <bug-20116-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20116-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20116-70-6uwYnEW1MD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 --- Comment #47 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #43) > (In reply to Jonathan Druart from comment #42) > > Still waiting for another QA feedback, back to NQA. > > I am still hoping for tests :) Hi Marcel, Yes I know, but I still not know how to write them usefully. I switched back to SO to get the point of view of an other QAer. See comments 28 to 32. > Note even that this patch set breaks a test when these patches are applied > and does not when not. > > t/db_dependent/Languages.t (Wstat: 512 Tests: 18 Failed: 2) > Failed tests: 11, 13 Thanks for catching that, fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 11:47:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 10:47:23 +0000 Subject: [Koha-bugs] [Bug 23961] New: Menu "add subcription fields" has disappeared Message-ID: <bug-23961-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23961 Bug ID: 23961 Summary: Menu "add subcription fields" has disappeared Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: corinne.hayet at progilone.fr QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com the page ...cgi-bin/koha/serials/add_fields.pl still exists but we cannot use it because where is no menu for this in serials module In 19.05, this menu moved in administration module ...cgi-bin/koha/admin/additional-fields.pl?tablename=subscription -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 11:50:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 10:50:08 +0000 Subject: [Koha-bugs] [Bug 11514] Untranslatable "Uncertain" text in acq In-Reply-To: <bug-11514-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11514-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11514-70-J9UmSI0pmU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11514 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|INVALID |--- Status|RESOLVED |REOPENED --- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Owen, you closed this bug but I think it is still useful. Even if it needs a small adjustment. See comment 11 > 1) It's a bug fix for the existing behavior: "(Uncertain)" is not longer displayed, because of the use of the Price plugin. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 11:50:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 10:50:20 +0000 Subject: [Koha-bugs] [Bug 11514] Untranslatable "Uncertain" text in acq In-Reply-To: <bug-11514-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11514-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11514-70-swinyZofM5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11514 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 11:50:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 10:50:26 +0000 Subject: [Koha-bugs] [Bug 11514] Untranslatable "Uncertain" text in acq In-Reply-To: <bug-11514-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11514-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11514-70-aX2PfvoaJn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11514 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 11:56:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 10:56:44 +0000 Subject: [Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and does not indicate it is for SIP-based checkouts only In-Reply-To: <bug-23233-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23233-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23233-70-UbBz0QgVu3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233 --- Comment #22 from Kyle M Hall <kyle at bywatersolutions.com> --- (In reply to Joonas Kylmälä from comment #21) > (In reply to Katrin Fischer from comment #20) > > Hi Joonas, > > > > this one is confusing to me - from the bug title/description it only seemed > > to affect the description of the pref/naming of the pref, so I expected an > > easy QA, but there is definitely more going on here. > > > > Can you explain why you removed the checks for the prefs in several parts of > > the code? Especially the changes to GetItemsInfo. > > Does the comment #6 explain (and the ones before that)? > > Kyle, maybe you would like to improve the commit messages? I've re-read the commit message and even with the followups if still reads accurately. What happened is that Joonas noticed that some places in Koha would present certain data only if AllowItemsOnHoldCheckoutSIP although that data should be displayed regardless of AllowItemsOnHoldCheckoutSIP! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 12:02:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 11:02:01 +0000 Subject: [Koha-bugs] [Bug 23903] Replace OPAC icons with Font Awesome In-Reply-To: <bug-23903-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23903-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23903-70-u2qPwGrnbc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23903 --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 94998 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94998&action=edit Bug 23903: fix selenium tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 12:09:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 11:09:54 +0000 Subject: [Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace In-Reply-To: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23414-70-USRIU64DLr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 --- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #9) > Nick, it was either you restored the elsif's, or you changed the order, not > both :) Forget that! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 12:12:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 11:12:32 +0000 Subject: [Koha-bugs] [Bug 22581] Add support for Plaine & Easie musical incipits rendering in OPAC In-Reply-To: <bug-22581-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22581-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22581-70-GmWVoOEJUl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_19_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 12:12:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 11:12:43 +0000 Subject: [Koha-bugs] [Bug 22581] Add support for Plaine & Easie musical incipits rendering in OPAC In-Reply-To: <bug-22581-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22581-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22581-70-bT8zRlT08I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 12:19:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 11:19:18 +0000 Subject: [Koha-bugs] [Bug 23945] koha-remove does not support older mysql and mariadb In-Reply-To: <bug-23945-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23945-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23945-70-Z8Nw6bVtJH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23945 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Depends on| |22128 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22128 [Bug 22128] koha-remove fails mysql ERROR 1133 (42000) at line 2: Can't find any matching row in the user table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 12:19:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 11:19:18 +0000 Subject: [Koha-bugs] [Bug 22128] koha-remove fails mysql ERROR 1133 (42000) at line 2: Can't find any matching row in the user table In-Reply-To: <bug-22128-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22128-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22128-70-QfzKc8FmL5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22128 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23945 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23945 [Bug 23945] koha-remove does not support older mysql and mariadb -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 12:21:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 11:21:17 +0000 Subject: [Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message In-Reply-To: <bug-23075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23075-70-PAtqmQoSvz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 --- Comment #30 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Still confused.. it should warn you when using http and not https as that's an invalid mana url. http://neverssl.com/mana-test.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 12:23:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 11:23:54 +0000 Subject: [Koha-bugs] [Bug 23933] commit_file.pl Can't call method "get_effective_marcorgcode" on an undefined value at /usr/share/koha/lib/C4/AuthoritiesMarc.pm line 578. In-Reply-To: <bug-23933-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23933-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23933-70-fpY3zSXGsm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23933 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Depends on| |10132 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Caused by my follow-up on bug 10132: commit 80c749df80f08be46b895715045b38cd1ded2ed1 Bug 10132: Simplify code, call the method only once Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10132 [Bug 10132] Add option to set MarcOrgCode on branch level -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 12:23:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 11:23:54 +0000 Subject: [Koha-bugs] [Bug 10132] Add option to set MarcOrgCode on branch level In-Reply-To: <bug-10132-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10132-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10132-70-eX7dY6ypko@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10132 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23933 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23933 [Bug 23933] commit_file.pl Can't call method "get_effective_marcorgcode" on an undefined value at /usr/share/koha/lib/C4/AuthoritiesMarc.pm line 578. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 12:26:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 11:26:29 +0000 Subject: [Koha-bugs] [Bug 23933] commit_file.pl Can't call method "get_effective_marcorgcode" on an undefined value at /usr/share/koha/lib/C4/AuthoritiesMarc.pm line 578. In-Reply-To: <bug-23933-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23933-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23933-70-bnXYatJHay@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23933 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 12:26:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 11:26:33 +0000 Subject: [Koha-bugs] [Bug 23933] commit_file.pl Can't call method "get_effective_marcorgcode" on an undefined value at /usr/share/koha/lib/C4/AuthoritiesMarc.pm line 578. In-Reply-To: <bug-23933-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23933-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23933-70-wJ2qVTBjum@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23933 --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 94999 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94999&action=edit Bug 23933: (bug 10132 follow-up) Fix commit_file.pl -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 12:26:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 11:26:52 +0000 Subject: [Koha-bugs] [Bug 23933] commit_file.pl Can't call method "get_effective_marcorgcode" on an undefined value at /usr/share/koha/lib/C4/AuthoritiesMarc.pm line 578. In-Reply-To: <bug-23933-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23933-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23933-70-8gzG9JP3v0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23933 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org Version|19.05 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 12:26:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 11:26:59 +0000 Subject: [Koha-bugs] [Bug 23962] New: We should drop support for Debian Jessie during 20.05 cycle. Message-ID: <bug-23962-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23962 Bug ID: 23962 Summary: We should drop support for Debian Jessie during 20.05 cycle. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org The Debian Jessie LTS support is officially coming to an end on June 30, 2020. We should continue to support the stable releases until that time (and perhaps for a short period afterwards) but publicise an official drop of support with our 20.05 release as we can't/shouldn't really officially support 20.05 on Jessie for more than a month after it's release (i.e. after Debian has dropped such support itself) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 12:30:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 11:30:29 +0000 Subject: [Koha-bugs] [Bug 23945] koha-remove does not support older mysql and mariadb In-Reply-To: <bug-23945-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23945-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23945-70-MVjUFgenB8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23945 Rudolf Byker <rudolfbyker at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rudolfbyker at gmail.com --- Comment #2 from Rudolf Byker <rudolfbyker at gmail.com> --- If you are still using MariaDB from 2015 (when 10.1.3 was released) or earlier, you have bigger problems than not being able to run `koha-remove`, i.e. security vulnerabilities. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 12:38:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 11:38:19 +0000 Subject: [Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message In-Reply-To: <bug-23075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23075-70-s6ZgSYvqdE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 --- Comment #31 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- What I see https://snipboard.io/bWxT4B.jpg with <mana_config>http://mana-test.koha-community.org</mana_config> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 12:51:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 11:51:50 +0000 Subject: [Koha-bugs] [Bug 23945] koha-remove does not support older mysql and mariadb In-Reply-To: <bug-23945-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23945-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23945-70-KeOZLAqNnW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23945 --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Rudolf Byker from comment #2) > If you are still using MariaDB from 2015 (when 10.1.3 was released) or > earlier, you have bigger problems than not being able to run `koha-remove`, > i.e. security vulnerabilities. Debian stretch is still using MySQL 5.5, and we are suppose to support the oldstable debian version. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 12:57:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 11:57:34 +0000 Subject: [Koha-bugs] [Bug 5365] It should be more clear how to reopen a basket in a basket group In-Reply-To: <bug-5365-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-5365-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5365-70-LCZsy7n2tl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5365 SiobhanC <siobhancottam at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |siobhancottam at gmail.com --- Comment #8 from SiobhanC <siobhancottam at gmail.com> --- I've just come across this problem when trying to cancel an order in a basket that is within a group, I had to ungroup the basket, then I was able to reopen it and cancel the order. Then regroup the basket. Why can't baskets within basket groups be reopened, edited and closed? What problems would this cause? This is happening in version 18.11. -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 13:08:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 12:08:23 +0000 Subject: [Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message In-Reply-To: <bug-23075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23075-70-ZUevtJoJnu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94098|0 |1 is obsolete| | --- Comment #32 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95000 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95000&action=edit Bug 23075: Report if mana-kb server is not found This patch adds a status check into the mana configuration page and prompts the user to ask an adminstrator to check the configured mana service url. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 13:14:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 12:14:53 +0000 Subject: [Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message In-Reply-To: <bug-23075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23075-70-uAR7sZOGVj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 --- Comment #33 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Pushed yet another rebased version.. but nothing has actually changed in the code.. I can't reproduce your issues, and can't see in the code how you would get that either. :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 13:16:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 12:16:08 +0000 Subject: [Koha-bugs] [Bug 23774] When placing a hold editing using Inspect Element allows addition to the code of non listed library In-Reply-To: <bug-23774-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23774-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23774-70-5u5gD0YEQR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23774 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_19_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 13:21:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 12:21:10 +0000 Subject: [Koha-bugs] [Bug 22128] koha-remove fails mysql ERROR 1133 (42000) at line 2: Can't find any matching row in the user table In-Reply-To: <bug-22128-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22128-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22128-70-by6D6eV2D6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22128 --- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- This was a bad push on my part. We still support Debian Jessie (which comes with Mysql5.5 by default) and this breaks our support for Jessie as such... Stretch is also pinned to MySQL5.5 which makes this worse but you can get MariaDB 10.1.4 which resolves it in Stretch (MariaDB supports IF EXISTS from 10.1.3) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 13:32:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 12:32:26 +0000 Subject: [Koha-bugs] [Bug 11514] Untranslatable "Uncertain" text in acq In-Reply-To: <bug-11514-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11514-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11514-70-bKCeV3b0bU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11514 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |ASSIGNED --- Comment #14 from Owen Leonard <oleonard at myacpl.org> --- (In reply to Jonathan Druart from comment #13) > Owen, you closed this bug but I think it is still useful. Even if it needs a > small adjustment. The bug refers to a translation issue and the translation issue is now invalid. If someone else want to continue to work on it I suggest at least renaming the report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 13:32:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 12:32:32 +0000 Subject: [Koha-bugs] [Bug 11514] Untranslatable "Uncertain" text in acq In-Reply-To: <bug-11514-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11514-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11514-70-vAkc0cJddm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11514 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 13:32:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 12:32:49 +0000 Subject: [Koha-bugs] [Bug 11514] Untranslatable "Uncertain" text in acq In-Reply-To: <bug-11514-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11514-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11514-70-s9iv4Az12C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11514 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 13:33:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 12:33:07 +0000 Subject: [Koha-bugs] [Bug 11514] Untranslatable "Uncertain" text in acq In-Reply-To: <bug-11514-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11514-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11514-70-NGWEkXWhNO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11514 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93323|0 |1 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 13:33:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 12:33:53 +0000 Subject: [Koha-bugs] [Bug 23719] Record matching for authorities using defined fields is broken under ES In-Reply-To: <bug-23719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23719-70-bJFsH8muNr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23719 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94913|0 |1 is obsolete| | --- Comment #9 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95001 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95001&action=edit Bug 23719: (follow-up) Add warn when passed invalid search field in marclist Note: I also remove warnings for undefined operation in this patch, is a trivial fix To test: prove -v t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 13:35:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 12:35:03 +0000 Subject: [Koha-bugs] [Bug 23719] Record matching for authorities using defined fields is broken under ES In-Reply-To: <bug-23719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23719-70-sGCTcuzFDn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23719 --- Comment #10 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Nick Clemens from comment #6) > Created attachment 94913 [details] [review] > Bug 23719: (follow-up) Add warn when passed invalid search field in marclist Heh, helps if you get the order of the hashes correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 13:48:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 12:48:59 +0000 Subject: [Koha-bugs] [Bug 23184] Export/bibs/holdings settings unclear for exporting bibs without any holdings In-Reply-To: <bug-23184-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23184-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23184-70-2c1L01Dd3D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23184 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 13:49:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 12:49:01 +0000 Subject: [Koha-bugs] [Bug 23184] Export/bibs/holdings settings unclear for exporting bibs without any holdings In-Reply-To: <bug-23184-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23184-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23184-70-BxB8XygnSq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23184 --- Comment #4 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95002 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95002&action=edit Bug 23184: Don't select branches for export by default This patch changes the include to require passing "selectall=1" to select all items This include is only used in this page, so changes should not have side effects git grep "branch-selector\.inc" This patch also corrects a mismatch in the class names To test: 1 - Browse to Tools->Export data 2 - Note all branches are selected 3 - Note this will exclude records wiuthout items if you click 'Export bibiographic records' 4 - Apply patch 5 - Visit page again 6 - Note no branches are selected by default 7 - Confirm 'Select all/Clear all' still work 8 - Note record with no items are exported by default now -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 13:49:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 12:49:15 +0000 Subject: [Koha-bugs] [Bug 23184] Export/bibs/holdings settings unclear for exporting bibs without any holdings In-Reply-To: <bug-23184-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23184-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23184-70-Y1lqz3O4Bj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23184 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 13:51:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 12:51:39 +0000 Subject: [Koha-bugs] [Bug 23918] search results incorrect for multiple vowel words In-Reply-To: <bug-23918-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23918-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23918-70-yOtQEa2E68@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23918 --- Comment #4 from Bernard <bernard.scaife at ptfs-europe.com> --- Thanks. I can't see anything in that file that would map 1 lowercase letter o to 2 (or 2 to 3). Our file is like this: https://github.com/Koha-Community/Koha/blob/18.11.x/etc/zebradb/etc/word-phrase-utf.chr Any idea which line might be causing this to happen? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 13:51:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 12:51:43 +0000 Subject: [Koha-bugs] [Bug 23079] Checkouts page broken because of problems with date calculation (TZAmerica/Sao_Paulo) In-Reply-To: <bug-23079-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23079-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23079-70-Hq7Iy07Qpb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23079 --- Comment #25 from Jose Ricardo Quaglio <jose.quaglio at saobernardo.sp.gov.br> --- Katrin Fischer, We use version 18.11.03.000 and have a homologation server with version 19.05.04.000. We are doing this to work around the problem. This year the government did not apply "summer time". I noticed that in version 19.05.04 this bug was adjusted, but I think it was not thought in case the government did not implement this time. Tks, -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 13:52:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 12:52:57 +0000 Subject: [Koha-bugs] [Bug 22128] koha-remove fails mysql ERROR 1133 (42000) at line 2: Can't find any matching row in the user table In-Reply-To: <bug-22128-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22128-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22128-70-yEuNqmAKxD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22128 --- Comment #15 from Rudolf Byker <rudolfbyker at gmail.com> --- Not just your fault. I proposed the fix without checking which distributions Koha is supposed to support. We have a conflict between trying to support the old DBs vs the new DBs, because as I mentioned above, the latest versions of MySQL and MariaDB fail on "GRANT USAGE" if the user does not exist, which is problematic. Maybe we should check the MySQL version, and then run the appropriate code in response to that. It's a simple IF statement. One day, when oldstable has moved on to the next release, the old code and the IF statement can simply be removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 13:54:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 12:54:19 +0000 Subject: [Koha-bugs] [Bug 23945] koha-remove does not support older mysql and mariadb In-Reply-To: <bug-23945-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23945-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23945-70-0Ct4aeG1qf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23945 --- Comment #4 from Rudolf Byker <rudolfbyker at gmail.com> --- Sorry, I didn't know about the oldstable requirement. See my comment at https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22128 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 14:16:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 13:16:39 +0000 Subject: [Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message In-Reply-To: <bug-23075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23075-70-xbld7fd9Ov@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 --- Comment #34 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95003 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95003&action=edit Bug 23075: (follow-up) Dissallow transparent redirects GET request redirects were causing the http URL to 'pass' our 'good url' test for http => https redirected mana servers. However, on the subsquent POST request to get a mana security token we would fail as the POST was not transparently redirected. This patch changes the request to be a simple_request so we will catch bad urls earlier and it also prevents submissions for security tokens if the configured URL is identified as bad. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 14:17:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 13:17:33 +0000 Subject: [Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message In-Reply-To: <bug-23075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23075-70-I2Ggmbsodi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #35 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Bad to needs signoff.. after a long chat with Jonathan on IRC I managed to replicate it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 14:24:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 13:24:41 +0000 Subject: [Koha-bugs] [Bug 23963] New: Visible reduction in image quality Message-ID: <bug-23963-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23963 Bug ID: 23963 Summary: Visible reduction in image quality Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: bibliwho at gmail.com, jonathan.druart at bugs.koha-community.org, katrin.fischer at bsz-bw.de, magnus at libriotech.no, mtj at kohaaloha.com, testopia at bugs.koha-community.org, wizzyrea at gmail.com Depends on: 21987, 22988 +++ This bug was initially created as a clone of Bug #22988 +++ RM NOTE: This bug is a placeholder to note that we are reverting bug 21987 whilst we work on the main issue for a longer term resolution to bug 22988 in that bug. I have a library that is noticing a visible reduction in image and thumbnail quality after upgrading from 18.11.03 to 18.11.05. This could be a regression from bug 21987. They have a lot of scanned black and white covers. The largest text in the thumbnails used to be readable, but after the upgrade, it is not. Their scanning process has not changed, so the original image that they upload should be of the same quality as before. Old, good image: http://bibliotek.dis-danmark.dk:8080/cgi-bin/koha/catalogue/image.pl?imagenumber=4332 http://bibliotek.dis-danmark.dk:8080/cgi-bin/koha/catalogue/image.pl?imagenumber=4332&thumbnail=1 New, not so good, image: http://bibliotek.dis-danmark.dk:8080/cgi-bin/koha/catalogue/image.pl?imagenumber=4463 http://bibliotek.dis-danmark.dk:8080/cgi-bin/koha/catalogue/image.pl?imagenumber=4463&thumbnail=1 Did we reduce the quality a bit too much? Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21987 [Bug 21987] Local cover 'thumbnail' size is bigger than 'imagefile' size in biblioimages table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22988 [Bug 22988] Visible reduction in image quality -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 14:24:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 13:24:41 +0000 Subject: [Koha-bugs] [Bug 21987] Local cover 'thumbnail' size is bigger than 'imagefile' size in biblioimages table In-Reply-To: <bug-21987-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21987-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21987-70-aEbKF4WvxH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21987 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23963 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23963 [Bug 23963] Visible reduction in image quality -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 14:24:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 13:24:41 +0000 Subject: [Koha-bugs] [Bug 22988] Visible reduction in image quality In-Reply-To: <bug-22988-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22988-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22988-70-qK8sdWJUyq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22988 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23963 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23963 [Bug 23963] Visible reduction in image quality -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 14:24:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 13:24:42 +0000 Subject: [Koha-bugs] [Bug 23050] Plugins: Add hook to add a tab in intranet biblio details page In-Reply-To: <bug-23050-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23050-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23050-70-4MFTK258ml@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23050 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 14:24:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 13:24:44 +0000 Subject: [Koha-bugs] [Bug 23050] Plugins: Add hook to add a tab in intranet biblio details page In-Reply-To: <bug-23050-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23050-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23050-70-P5gf1JzK7z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23050 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91523|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 14:24:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 13:24:46 +0000 Subject: [Koha-bugs] [Bug 23050] Plugins: Add hook to add a tab in intranet biblio details page In-Reply-To: <bug-23050-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23050-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23050-70-3kpURSUryx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23050 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91524|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 14:24:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 13:24:48 +0000 Subject: [Koha-bugs] [Bug 23050] Plugins: Add hook to add a tab in intranet biblio details page In-Reply-To: <bug-23050-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23050-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23050-70-HKBhnVGTxx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23050 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91525|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 14:24:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 13:24:51 +0000 Subject: [Koha-bugs] [Bug 23050] Plugins: Add hook to add a tab in intranet biblio details page In-Reply-To: <bug-23050-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23050-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23050-70-UOD08G6cFr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23050 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93222|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 14:24:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 13:24:53 +0000 Subject: [Koha-bugs] [Bug 23963] Visible reduction in image quality In-Reply-To: <bug-23963-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23963-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23963-70-vpNArnuqxv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23963 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 14:25:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 13:25:06 +0000 Subject: [Koha-bugs] [Bug 23963] Visible reduction in image quality In-Reply-To: <bug-23963-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23963-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23963-70-39aVXXB1Gj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23963 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 14:25:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 13:25:43 +0000 Subject: [Koha-bugs] [Bug 23963] Visible reduction in image quality In-Reply-To: <bug-23963-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23963-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23963-70-owZhTPxS7m@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23963 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|22988 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22988 [Bug 22988] Visible reduction in image quality -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 14:25:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 13:25:43 +0000 Subject: [Koha-bugs] [Bug 22988] Visible reduction in image quality In-Reply-To: <bug-22988-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22988-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22988-70-lkjY9CW10N@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22988 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|23963 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23963 [Bug 23963] Visible reduction in image quality -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 14:28:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 13:28:24 +0000 Subject: [Koha-bugs] [Bug 22988] Visible reduction in image quality In-Reply-To: <bug-22988-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22988-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22988-70-Ph8vkN8v3x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22988 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|21987 |23963 CC| |martin.renvoize at ptfs-europe | |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21987 [Bug 21987] Local cover 'thumbnail' size is bigger than 'imagefile' size in biblioimages table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23963 [Bug 23963] Visible reduction in image quality -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 14:28:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 13:28:24 +0000 Subject: [Koha-bugs] [Bug 21987] Local cover 'thumbnail' size is bigger than 'imagefile' size in biblioimages table In-Reply-To: <bug-21987-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21987-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21987-70-8u5Vc1ujce@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21987 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22988 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22988 [Bug 22988] Visible reduction in image quality -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 14:28:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 13:28:24 +0000 Subject: [Koha-bugs] [Bug 23963] Visible reduction in image quality In-Reply-To: <bug-23963-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23963-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23963-70-1Yly7bQ0HN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23963 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22988 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22988 [Bug 22988] Visible reduction in image quality -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 14:28:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 13:28:54 +0000 Subject: [Koha-bugs] [Bug 22988] Visible reduction in image quality In-Reply-To: <bug-22988-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22988-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22988-70-EmYoI73jhV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22988 --- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Bug 21987 reverted as per above requests whilst we work on a longer term resolution here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 14:29:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 13:29:23 +0000 Subject: [Koha-bugs] [Bug 22988] Visible reduction in image quality In-Reply-To: <bug-22988-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22988-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22988-70-ythvaQyA6N@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22988 --- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Revert action recorded as bug 23963 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 14:29:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 13:29:59 +0000 Subject: [Koha-bugs] [Bug 23050] Plugins: Add hook to add a tab in intranet biblio details page In-Reply-To: <bug-23050-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23050-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23050-70-p0AaRnQLxv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23050 --- Comment #11 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 95004 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95004&action=edit Bug 23050: Plugin hook to add tabs in intranet biblio details page Test Plan: 1) Enable plugins 2) Download and install the latest version of this plugin https://git.biblibre.com/biblibre/koha-plugin-intranet-detail-hook 3) Browse to catalogue/detail.pl for a record 4) Note you see two new tabs with content Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 14:30:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 13:30:04 +0000 Subject: [Koha-bugs] [Bug 23050] Plugins: Add hook to add a tab in intranet biblio details page In-Reply-To: <bug-23050-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23050-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23050-70-VQUZXtTBUU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23050 --- Comment #12 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 95005 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95005&action=edit Bug 23050: Add missing template filters Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 14:30:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 13:30:08 +0000 Subject: [Koha-bugs] [Bug 23050] Plugins: Add hook to add a tab in intranet biblio details page In-Reply-To: <bug-23050-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23050-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23050-70-MtWPB1B4xX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23050 --- Comment #13 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 95006 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95006&action=edit Bug 23050: Fix tab's id to avoid compatibility issues MDN says: Using characters except ASCII letters, digits, '_', '-' and '.' may cause compatibility problems, as they weren't allowed in HTML 4. Though this restriction has been lifted in HTML5, an ID should start with a letter for compatibility. https://developer.mozilla.org/en-US/docs/Web/HTML/Global_attributes/id Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 14:30:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 13:30:13 +0000 Subject: [Koha-bugs] [Bug 23050] Plugins: Add hook to add a tab in intranet biblio details page In-Reply-To: <bug-23050-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23050-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23050-70-0ahhJEx9d6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23050 --- Comment #14 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 95007 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95007&action=edit Bug 23050: Fix creation of biblio tab's id (Too much javascript in my head...) Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 14:30:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 13:30:43 +0000 Subject: [Koha-bugs] [Bug 21987] Local cover 'thumbnail' size is bigger than 'imagefile' size in biblioimages table In-Reply-To: <bug-21987-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21987-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21987-70-dJvcXwVp3Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21987 --- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Reverted as bug 23963 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 14:31:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 13:31:51 +0000 Subject: [Koha-bugs] [Bug 23963] Visible reduction in image quality In-Reply-To: <bug-23963-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23963-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23963-70-gfB7iFgxie@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23963 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 14:31:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 13:31:56 +0000 Subject: [Koha-bugs] [Bug 23963] Visible reduction in image quality In-Reply-To: <bug-23963-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23963-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23963-70-a74A5mgOjE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23963 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 14:32:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 13:32:01 +0000 Subject: [Koha-bugs] [Bug 23963] Visible reduction in image quality In-Reply-To: <bug-23963-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23963-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23963-70-GP6ycYVXHK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23963 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 14:32:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 13:32:12 +0000 Subject: [Koha-bugs] [Bug 23963] Visible reduction in image quality In-Reply-To: <bug-23963-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23963-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23963-70-4zZzA43zIr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23963 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 14:32:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 13:32:26 +0000 Subject: [Koha-bugs] [Bug 23963] Visible reduction in image quality In-Reply-To: <bug-23963-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23963-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23963-70-pbdhBoZado@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23963 --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Revert pushed to master for 19.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 14:36:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 13:36:49 +0000 Subject: [Koha-bugs] [Bug 23868] PayPal payment button is never enabled In-Reply-To: <bug-23868-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23868-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23868-70-FB6ZSZKDQb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23868 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |blocker Assignee|oleonard at myacpl.org |agustinmoyano at theke.io Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 14:42:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 13:42:38 +0000 Subject: [Koha-bugs] [Bug 23452] Multiple select options in system preferences are not translatable In-Reply-To: <bug-23452-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23452-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23452-70-54ZiOUdlo1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23452 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |bgkriegel at gmail.com |ity.org | Status|NEW |ASSIGNED --- Comment #3 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Hi, problem is that LangInstaller.pm ignores options other than 'choices', egrep -n choices LangInstaller.pm 189: next unless $key eq 'choices'; 230: next unless $key eq 'choices'; Patch is comming. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 14:46:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 13:46:37 +0000 Subject: [Koha-bugs] [Bug 21652] reserves.waitingdate is set to current date by printing new hold slip In-Reply-To: <bug-21652-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21652-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21652-70-pkkK8td4aw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21652 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|17.11 |19.05 --- Comment #2 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Confirmed this issue still exists in 19.05. Thanks! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 14:46:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 13:46:48 +0000 Subject: [Koha-bugs] [Bug 22329] Parent funds showing incorrect amounts for Ordered, Spent, Available on Acquisitions Home In-Reply-To: <bug-22329-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22329-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22329-70-AQZu5bdfJi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22329 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.05 |19.05 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 15:07:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 14:07:27 +0000 Subject: [Koha-bugs] [Bug 23452] Multiple select options in system preferences are not translatable In-Reply-To: <bug-23452-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23452-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23452-70-zdtFJUIDuU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23452 --- Comment #4 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 95008 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95008&action=edit Bug 23452: Multiple select options in system preferences are not translatable Translate script ignores multiple options in system preferences, this patch fix that. To test: 1) Apply the patch 2) Go to misc/translator cd misc/translator 3) Update your preferred language perl translate update xx-YY 4) Updated pref file must contain new strings, eg. egrep "when cataloguing an item" po/xx-YY-pref.po 5) Edit & translate that string 6) Install the updated translation perl translate install xx-YY 7) Check that the translated pref file has a) multiple options present b) the message from 5) is translated see for example circulation.pref en: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref xx: koha-tmpl/intranet-tmpl/prog/xx-YY/modules/admin/preferences/circulation.pref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 15:07:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 14:07:54 +0000 Subject: [Koha-bugs] [Bug 23452] Multiple select options in system preferences are not translatable In-Reply-To: <bug-23452-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23452-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23452-70-dhuNnhu94o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23452 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 15:10:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 14:10:55 +0000 Subject: [Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message In-Reply-To: <bug-23075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23075-70-L8qLOk7vf8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 --- Comment #36 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95009 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95009&action=edit Bug 23075: Do not 'Send' if the url is not correct Just in case. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 15:19:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 14:19:24 +0000 Subject: [Koha-bugs] [Bug 23927] Duplicate a "Complete" order link the "New" one to the invoice In-Reply-To: <bug-23927-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23927-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23927-70-zjqY1AREY2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23927 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Hi Séverine, can you detail what is the behavior you expect? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 15:21:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 14:21:48 +0000 Subject: [Koha-bugs] [Bug 23927] Duplicate a "Complete" order link the "New" one to the invoice In-Reply-To: <bug-23927-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23927-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23927-70-0u4nyyuRNy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23927 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15184 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 [Bug 15184] Ability to duplicate existing order lines to a given basket -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 15:21:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 14:21:48 +0000 Subject: [Koha-bugs] [Bug 15184] Ability to duplicate existing order lines to a given basket In-Reply-To: <bug-15184-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15184-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15184-70-QBNcCyC8eP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15184 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23927 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23927 [Bug 23927] Duplicate a "Complete" order link the "New" one to the invoice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 15:29:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 14:29:16 +0000 Subject: [Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace In-Reply-To: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23414-70-YcOJpVhzWM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 15:29:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 14:29:19 +0000 Subject: [Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace In-Reply-To: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23414-70-5ulhHsP845@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94580|0 |1 is obsolete| | Attachment #94581|0 |1 is obsolete| | --- Comment #12 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95010 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95010&action=edit Bug 23414: Unit tests To test: 1 - Apply this patch alone 2 - prove -v t/db_dependent/XSLT.t 3 - All pass 4 - Apply other patches 5 - prove -v t/db_dependent/XSLT.t 6 - All pass -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 15:29:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 14:29:22 +0000 Subject: [Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace In-Reply-To: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23414-70-nleAnBqfdK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 --- Comment #13 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95011 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95011&action=edit Bug 23414: Use Koha Item objects in buildKohaItemsNamespace Removing the use of C4::GetItemsInfo cuts down on the number of DB requests and speeds things up To test I added 100 items to each of the first 20 records returned by a search for 'a' I saw a reduction from ~30 seconds to ~26 seconds This also makes the code a little cleaner and moves us toward the Koha namespace To test: 1 - Perform a search in the OPAC and STaff Client with the Browser Console opened (F12) 2 - View the netwrok tab and see how long the pages take to load 3 - Apply the patches, restart all the things 4 - Repeat and note if the results are returned faster -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 15:29:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 14:29:25 +0000 Subject: [Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace In-Reply-To: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23414-70-EWIwcgkQxM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 --- Comment #14 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95012 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95012&action=edit Bug 23414: Prefetch transfers, use only default framework, use elsif This further cleans up the code, before we tested each condition though we return only one status line. Koha mappings can no longer differ by framework so we don't need to fetch the biblio framework Prefetching should offer a boost To test: Same as before - there is not as big a boost form this, but there shouldn't be a hit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 15:31:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 14:31:13 +0000 Subject: [Koha-bugs] [Bug 22128] koha-remove fails mysql ERROR 1133 (42000) at line 2: Can't find any matching row in the user table In-Reply-To: <bug-22128-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22128-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22128-70-vw7lbfI7fZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22128 --- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- In better news.. Jessie drops out of support just after the release of 20.05.. so we won't have to support this for long.. Having said that.. we don't limit people to MariaDB.. so in Stretch they'll still have issues if they want to stick to mysql-server and not myself-server-transitional (which installs mariadb I believe). One for broader discussion there. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 15:40:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 14:40:07 +0000 Subject: [Koha-bugs] [Bug 22569] Stock rotation: need transfer reports In-Reply-To: <bug-22569-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22569-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22569-70-gPygi2RnaC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 --- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- (In reply to Katrin Fischer from comment #12) > Hi Martin, I am not sure about how the report is supposed to be used - can > you explain? > > A bit worried that this will be the crucial bit: > 2) There is no way to differentiate between a transfer that has been > requested and a transfer than has been actually sent. > > So you won't see what has been put into transfer already? Well, it's as an alternative to the stock rotation email reports which send this same data via email as a pick list for staff. I can see where the confusion could come in.. perhaps bug 23092 needs to be done first if you think this will be more confusing as opposed to less? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 15:42:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 14:42:12 +0000 Subject: [Koha-bugs] [Bug 22569] Stock rotation: need transfer reports In-Reply-To: <bug-22569-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22569-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22569-70-TeyMtNqVTF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22569 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_19_11_candidate |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 15:44:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 14:44:56 +0000 Subject: [Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace In-Reply-To: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23414-70-w2cd6K83Og@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 --- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Not sure about $item->itype, it seems that it should be $item->effective_itemtype -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 15:53:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 14:53:09 +0000 Subject: [Koha-bugs] [Bug 23964] New: An item level hold when placed is set to Waiting, if ReservesNeedReturn is set to Automatic Message-ID: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23964 Bug ID: 23964 Summary: An item level hold when placed is set to Waiting, if ReservesNeedReturn is set to Automatic Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Hold requests Assignee: nick at bywatersolutions.com Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com If a library has the system preference, ReservesNeedReturn, set to Automatically; when an item level hold is placed- regardless if the item is checked out, the hold goes right to Waiting. This should not go to Waiting when the Item is checked out. It should be an item level hold until the item has been checked in. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 15:54:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 14:54:28 +0000 Subject: [Koha-bugs] [Bug 23181] Unable to use payment library in ACCOUNT_PAYMENT or ACCOUNT_WRITEOFF notices In-Reply-To: <bug-23181-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23181-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23181-70-u7l7CZomtD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23181 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 15:54:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 14:54:30 +0000 Subject: [Koha-bugs] [Bug 23181] Unable to use payment library in ACCOUNT_PAYMENT or ACCOUNT_WRITEOFF notices In-Reply-To: <bug-23181-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23181-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23181-70-BgD1GeAV7H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23181 --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 15:54:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 14:54:32 +0000 Subject: [Koha-bugs] [Bug 23429] ilsdi.pl GetRecords documentation does not match output In-Reply-To: <bug-23429-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23429-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23429-70-AfqrR5sGDm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23429 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 15:54:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 14:54:33 +0000 Subject: [Koha-bugs] [Bug 23429] ilsdi.pl GetRecords documentation does not match output In-Reply-To: <bug-23429-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23429-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23429-70-jj5kd9xi8D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23429 --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 16:03:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 15:03:25 +0000 Subject: [Koha-bugs] [Bug 23050] Plugins: Add hook to add a tab in intranet biblio details page In-Reply-To: <bug-23050-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23050-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23050-70-KCICmLBmL7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23050 --- Comment #15 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 95013 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95013&action=edit Bug 23050: (QA follow-up) Add Koha::Plugins::Tab class This minimal class encapsulates the tabs to be passed around to the templates, so error checking on missing bits is done in a single place. It throws exceptions on errors Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 16:04:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 15:04:19 +0000 Subject: [Koha-bugs] [Bug 7614] Use branch transfer limits for determining available opac holds pickup locations In-Reply-To: <bug-7614-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7614-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7614-70-MnoaXReDgR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7614 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|paul.poulain at biblibre.com |lari.taskula at hypernova.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 16:16:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 15:16:51 +0000 Subject: [Koha-bugs] [Bug 21565] SCO checkout confirm language In-Reply-To: <bug-21565-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21565-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21565-70-IxBcKCDCF0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21565 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lucas at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 16:22:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 15:22:03 +0000 Subject: [Koha-bugs] [Bug 23818] Acquisitions receipt created when an item or invoice is received In-Reply-To: <bug-23818-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23818-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23818-70-RZx9t8ueI0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23818 --- Comment #5 from rkuiper at roundrocktexas.gov --- I really like that idea! A customizable slip would be a great way to enhance workflows for libraries of all kinds. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 16:23:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 15:23:58 +0000 Subject: [Koha-bugs] [Bug 23774] When placing a hold editing using Inspect Element allows addition to the code of non listed library In-Reply-To: <bug-23774-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23774-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23774-70-Y4RRgUQ3Oy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23774 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|martin.renvoize at ptfs-europe |lari.taskula at hypernova.fi |.com | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 16:31:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 15:31:45 +0000 Subject: [Koha-bugs] [Bug 22857] Entries missing in koha-conf.xml In-Reply-To: <bug-22857-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22857-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22857-70-uD2CN455Wx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22857 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 16:36:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 15:36:39 +0000 Subject: [Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace In-Reply-To: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23414-70-9VZWRpYR7N@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 --- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95014 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95014&action=edit Bug 23414: Easy readability and simplify logic in buildKohaItemsNamespace This patch improves true/false logic and avoid autovivication. Also note that xml_escape already deals with empty string. An unecessary call to GetReserveStatus is removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 16:36:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 15:36:42 +0000 Subject: [Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace In-Reply-To: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23414-70-cj4jAWwJBg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 --- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95015 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95015&action=edit Bug 23414: Use effective_itemtype We should use effective_itemtype instead of itype to take the item-level_itypes pref into account. Note that we should not need to test for the existence of the key as we now assume that item types are correctly set to a valid item type. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 16:52:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 15:52:20 +0000 Subject: [Koha-bugs] [Bug 23965] New: DVD covers Message-ID: <bug-23965-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23965 Bug ID: 23965 Summary: DVD covers Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Wondering if the same resources that Plex uses could be used for Koha in DVD covers. TV shows use TVDB mainly and Freebase or Movieposters.DB for Movies -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 17:09:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 16:09:55 +0000 Subject: [Koha-bugs] [Bug 23964] An item level hold when placed is set to Waiting, if ReservesNeedReturn is set to Automatic In-Reply-To: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23964-70-rIMNj4DveZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23964 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 17:09:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 16:09:58 +0000 Subject: [Koha-bugs] [Bug 23964] An item level hold when placed is set to Waiting, if ReservesNeedReturn is set to Automatic In-Reply-To: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23964-70-AVshFM22Vj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23964 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95016 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95016&action=edit Bug 23964: Unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 17:10:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 16:10:00 +0000 Subject: [Koha-bugs] [Bug 23964] An item level hold when placed is set to Waiting, if ReservesNeedReturn is set to Automatic In-Reply-To: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23964-70-DiXYkr4Ym7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23964 --- Comment #2 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95017 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95017&action=edit Bug 23964: ReservesNeedReturn shoudl only apply to available items To test: 1 - Checkout an item to a patron 2 - Make sure 'ReservesNeedReturn' is set to 'Automatically' 3 - Place an item level hold on the checked out item 4 - Note the hold is marked waiting 5 - Delete the hold 6 - Apply patch 7 - Place a new hold 8 - Hold is not marked waiting 9 - Please a hold on a different item 10 - Note it is marked waiting 11 - Test when item is damaged and hold not allowed on damaged items 12 - Test when item is in transit 13 - Test when item has another hold 14 - Only in the case where none of the above are true should the hold be marked waiting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 17:19:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 16:19:23 +0000 Subject: [Koha-bugs] [Bug 23825] Object.t is failing - Exception not caught In-Reply-To: <bug-23825-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23825-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23825-70-cpOcduR2PP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal --- Comment #23 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Downgrading from Major as this only affects very new DBMS versions which the majority of people will not be running. Having said that, so long as it doesn't break tests on the current stable DBMS versions then I don't have a problem with pushing it. I've not tested this yet myself, but if someone here can verify the tests continue to work with MySQL5.5, MariaDB10.1 and MariaDB10.3 then this feels OK to push at this point. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 17:23:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 16:23:14 +0000 Subject: [Koha-bugs] [Bug 14759] Replacement for Text::Unaccent In-Reply-To: <bug-14759-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14759-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14759-70-ojFjdjpEtt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14759 --- Comment #33 from Colin Campbell <colin.campbell at ptfs-europe.com> --- Looks like in addition to the problems of building on 64 bit systems it fails to build on the most recent versions of Perl. I think this is a result of the removal of . from the default path -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 17:32:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 16:32:36 +0000 Subject: [Koha-bugs] [Bug 23965] Use an external service to provide DVD cover images In-Reply-To: <bug-23965-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23965-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23965-70-qyxBpVQUoS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23965 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|DVD covers |Use an external service to | |provide DVD cover images Version|unspecified |master --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- When considering the feasibility of getting cover images from external sources there are I think two major factors to consider: 1. The availability and licensing of the data. What do we know about access to the data on TVDB, Freebase, and Movieposter.DB? Are there open APIs? Do their terms of use permit direct access by third-party software? Are there limitations to the amount of data which can be requested? 2. The means of connecting the data in Koha to the data on the service. Even if you have access to cover image data, the unique identifier used by the external service to identify the title is probably not going to match any unique identifier which is stored in Koha. Would DVD records need to be manually updated to include the ID of the resource in the external service? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 17:37:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 16:37:49 +0000 Subject: [Koha-bugs] [Bug 23673] Separate time sent from time created in message_queue table In-Reply-To: <bug-23673-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23673-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23673-70-Yz17xyMeHD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23673 Maxime Dufresne <maxime.dufresne at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maxime.dufresne at inlibro.com Attachment #94954|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 17:39:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 16:39:06 +0000 Subject: [Koha-bugs] [Bug 23774] When placing a hold editing using Inspect Element allows addition to the code of non listed library In-Reply-To: <bug-23774-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23774-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23774-70-0PD3lA5YIm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23774 Lari Taskula <lari.taskula at hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22330 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 17:39:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 16:39:06 +0000 Subject: [Koha-bugs] [Bug 22330] Transfer limits should be respected for placing holds in staff interface and APIs In-Reply-To: <bug-22330-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22330-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22330-70-dBcicBul5B@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22330 Lari Taskula <lari.taskula at hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23774 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 17:42:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 16:42:16 +0000 Subject: [Koha-bugs] [Bug 23774] When placing a hold editing using Inspect Element allows addition to the code of non listed library In-Reply-To: <bug-23774-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23774-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23774-70-htiH8jGaC0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23774 Lari Taskula <lari.taskula at hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 17:42:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 16:42:18 +0000 Subject: [Koha-bugs] [Bug 23774] When placing a hold editing using Inspect Element allows addition to the code of non listed library In-Reply-To: <bug-23774-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23774-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23774-70-ALSdKDsAuQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23774 --- Comment #3 from Lari Taskula <lari.taskula at hypernova.fi> --- Created attachment 95018 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95018&action=edit Bug 23774: Server-side confirmation for hold pickup location in OPAC While placing a hold on a book, if a user opens up Inspect Element on the Pick up location drop down box they can change the pick up location in the code to a library that is not listed as a pick up location. How to replicate: Search for a book Select book Click Place Hold On the screen Home > Placing a hold Right click on Pick up location Select 'Inspect Element' Under <!-- HOLDABLE --> <li class="Branch"> <select name="Branch ******"> Pick Up location:</label>=$0 Option values are listed that relate to the pick up location, this value can be changed to another new location and when the hold is placed the hold will be placed for this new location instead of the listed options in the Pick up location drop down list. To test: 1. Apply patch 2. Repeat "How to replicate" 3. Observe it is no longer possible to place holds on libraries not defined as pickup location by changing option value via Inspect Element tool -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 17:45:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 16:45:24 +0000 Subject: [Koha-bugs] [Bug 23908] Require patrons to confirm their email address In-Reply-To: <bug-23908-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23908-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23908-70-6yGAKUffEd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23908 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9097 CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 17:45:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 16:45:24 +0000 Subject: [Koha-bugs] [Bug 9097] 'Welcome mail' for new library users In-Reply-To: <bug-9097-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9097-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9097-70-1KwjHIwfwE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9097 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23908 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 17:54:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 16:54:54 +0000 Subject: [Koha-bugs] [Bug 15729] SIP server allows checkin of reserved item In-Reply-To: <bug-15729-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15729-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15729-70-m8cpNHmrP4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15729 --- Comment #6 from Barry Cannon <bc at interleaf.ie> --- Created attachment 95019 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95019&action=edit Bug 15729 - SIP server allows checkin of reserved item This patch allows the library to allow or dissallow items that are reserved to be checked in via a selfcheck machine. Some libraries perfer to deny the checkin transaction to force the borrower to return via the circ desk. Adds a new systempreference called AllowSIPCheckInOnHolds. To Test, apply the patch and run database update - Check Administration > System preferences > Circulation > AllowSIPCheckInOnHolds and set to "Don't Allow" - Find, or create, a biblio in the catalogue with more that one item and place a bib level hold. - Restart SIP instance on the server - Issue a checkin transaction call from a selfcheck machine or via the sip_cli emulator - Observe the checkin has been denied with screen message explaining why. - Delete the hold on the biblio record. - Create a new hold item-level hold on the same biblio record - Try the transaction again with the item that has an item-level hold. - Observe the checing has been denied. - Try the transaction again with an item attached to the biblio that does not have an item-level hold - Observer the checkin is allowed. - Change the System preference AllowSIPCheckInOnHolds to "Allow" - Restart the SIP instance on the server - Preform the checkin transaction above again and notice they are now permitted -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 17:57:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 16:57:55 +0000 Subject: [Koha-bugs] [Bug 23813] DB error on 18.12.00.020 In-Reply-To: <bug-23813-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23813-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23813-70-fX4zDCSGd6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23813 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94524|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95020 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95020&action=edit Bug 23813: (bug 18925 follow-up) Remove invalid circ rules to avoid FK constraints to fail There is not FK constraints on the itemtype, categorycode and branchcode columns of the issuingrules table, because of the '*' value we use for default. We created the new table circulation_rules with those constraints, and when we moved the rules for maxissueqty, the INSERT failed. To avoid the FK constraints to fail we are going to delete the invalid rows before. It could lead to data lost, but this situation certainly comes from a bad data manipulation at some point of the history of the installation. Test plan: git reset --hard 1e4f442442844cfaf17f5b06f122f6259d5fee92 # before 18.12.00.020 reset_all insert into branches(branchcode, branchname) values('rmme', 'rmme'); insert into categories (categorycode, description) values ('rmme', 'rmme'); insert into itemtypes (itemtype, description) values('rmme', 'rmme'); Go to http://pro.kohadev.org/cgi-bin/koha/admin/smart-rules.pl Create a new rule for the patron category Create a new rule for the item type Copy all the default rule to the new library Create other rules for "Default checkout, hold policy by patron category" and "Default holds policy by item type" using this patron's category and itemtype. Same for patrons' categories and itemtypes you will not delete. delete from branches where branchcode="rmme"; delete from categories where categorycode="rmme"; delete from itemtypes where itemtype="rmme"; git checkout master and execute the DB process. => With this patch applied you will not get the error and the rules will be moved correctly. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 17:58:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 16:58:31 +0000 Subject: [Koha-bugs] [Bug 23813] DB error on 18.12.00.020 In-Reply-To: <bug-23813-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23813-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23813-70-sNtEdIPLDE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23813 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Code reads well and the patch does resolve the issue for me.. Signing Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 18:02:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 17:02:53 +0000 Subject: [Koha-bugs] [Bug 15729] SIP server allows checkin of reserved item In-Reply-To: <bug-15729-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15729-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15729-70-TQwYyA1lWu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15729 Barry Cannon <bc at interleaf.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 18:09:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 17:09:20 +0000 Subject: [Koha-bugs] [Bug 23964] An item level hold when placed is set to Waiting, if ReservesNeedReturn is set to Automatic In-Reply-To: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23964-70-qex5xT2D0I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23964 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95016|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95021 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95021&action=edit Bug 23964: Unit tests Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 18:09:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 17:09:24 +0000 Subject: [Koha-bugs] [Bug 23964] An item level hold when placed is set to Waiting, if ReservesNeedReturn is set to Automatic In-Reply-To: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23964-70-pCrgohULGo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23964 --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95022 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95022&action=edit Bug 23964: ReservesNeedReturn should only apply to available items To test: 1 - Checkout an item to a patron 2 - Make sure 'ReservesNeedReturn' is set to 'Automatically' 3 - Place an item level hold on the checked out item 4 - Note the hold is marked waiting 5 - Delete the hold 6 - Apply patch 7 - Place a new hold 8 - Hold is not marked waiting 9 - Please a hold on a different item 10 - Note it is marked waiting 11 - Test when item is damaged and hold not allowed on damaged items 12 - Test when item is in transit 13 - Test when item has another hold 14 - Only in the case where none of the above are true should the hold be marked waiting Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 18:09:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 17:09:45 +0000 Subject: [Koha-bugs] [Bug 23964] An item level hold when placed is set to Waiting, if ReservesNeedReturn is set to Automatic In-Reply-To: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23964-70-Ajxd6mVaB6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23964 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Attachment #95017|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 18:10:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 17:10:26 +0000 Subject: [Koha-bugs] [Bug 23964] An item level hold when placed is set to Waiting, if ReservesNeedReturn is set to Automatic In-Reply-To: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23964-70-HwKT7pryLz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23964 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Code scans well, tests pass and qa script passes. This looks logically correct to me and works as described so I'm signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 18:14:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 17:14:28 +0000 Subject: [Koha-bugs] [Bug 23966] New: Branch Transfer Limits editor unusable for sites with many libraries and ccodes/itemtypes Message-ID: <bug-23966-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23966 Bug ID: 23966 Summary: Branch Transfer Limits editor unusable for sites with many libraries and ccodes/itemtypes Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Right now the branch transfer limits editor works fine if an instance has a small number of libraries and ccodes/itemtypes, but for large consortia who may have over 100 branches and ccodes/itemtypes, the editor page can take literal minutes to load ( we have partners where the page load time is 7-8 minutes ). This is because we run a separate database query for each limit. We should use a single query to find all the limits for this page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 18:15:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 17:15:14 +0000 Subject: [Koha-bugs] [Bug 23774] When placing a hold editing using Inspect Element allows addition to the code of non listed library In-Reply-To: <bug-23774-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23774-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23774-70-e94qS0kCTF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23774 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95018|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95023 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95023&action=edit Bug 23774: Server-side confirmation for hold pickup location in OPAC While placing a hold on a book, if a user opens up Inspect Element on the Pick up location drop down box they can change the pick up location in the code to a library that is not listed as a pick up location. How to replicate: Search for a book Select book Click Place Hold On the screen Home > Placing a hold Right click on Pick up location Select 'Inspect Element' Under <!-- HOLDABLE --> <li class="Branch"> <select name="Branch ******"> Pick Up location:</label>=$0 Option values are listed that relate to the pick up location, this value can be changed to another new location and when the hold is placed the hold will be placed for this new location instead of the listed options in the Pick up location drop down list. To test: 1. Apply patch 2. Repeat "How to replicate" 3. Observe it is no longer possible to place holds on libraries not defined as pickup location by changing option value via Inspect Element tool Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 18:16:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 17:16:02 +0000 Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders In-Reply-To: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18731-70-j0YBiTNFmw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Jessie Zairo <jzairo at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 18:16:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 17:16:13 +0000 Subject: [Koha-bugs] [Bug 23774] When placing a hold editing using Inspect Element allows addition to the code of non listed library In-Reply-To: <bug-23774-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23774-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23774-70-5JTVPB6YGk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23774 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Thanks for the quick fix once assigned Lari, I'd meant to catch you to ask but you beat me to it :). Works as requested, so glad you jumped in as I was somewhat daunted when I started digging through the code. Signing Off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 18:16:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 17:16:16 +0000 Subject: [Koha-bugs] [Bug 17371] Add routes for biblios In-Reply-To: <bug-17371-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17371-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17371-70-xBwdxAjIin@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17371 Jessie Zairo <jzairo at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 18:16:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 17:16:54 +0000 Subject: [Koha-bugs] [Bug 23966] Branch Transfer Limits editor unusable for sites with many libraries and ccodes/itemtypes In-Reply-To: <bug-23966-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23966-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23966-70-2DmMIjArr7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23966 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 18:16:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 17:16:57 +0000 Subject: [Koha-bugs] [Bug 23966] Branch Transfer Limits editor unusable for sites with many libraries and ccodes/itemtypes In-Reply-To: <bug-23966-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23966-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23966-70-Eun02IDFAS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23966 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 95024 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95024&action=edit Bug 23966 - Branch Transfer Limits editor unusable for sites with many libraries and ccodes/itemtypes Right now the branch transfer limits editor works fine if an instance has a small number of libraries and ccodes/itemtypes, but for large consortia who may have over 100 branches and ccodes/itemtypes, the editor page can take literal minutes to load ( we have partners where the page load time is 7-8 minutes ). This is because we run a separate database query for each limit. We should use a single query to find all the limits for this page. Test Plan: 1) Enable BranchTransferLimits 2) Create some limits, test adding and removing limits 3) Apply this patch 4) Restart all the things! 5) Reload the page, you should see the same limits in place as before 6) Test adding and removing limits, everything should behave the same as it did before the patch was applied! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 18:19:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 17:19:00 +0000 Subject: [Koha-bugs] [Bug 23966] Branch Transfer Limits editor unusable for sites with many libraries and ccodes/itemtypes In-Reply-To: <bug-23966-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23966-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23966-70-LqRnz4VtD6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23966 Jessie Zairo <jzairo at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 18:19:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 17:19:25 +0000 Subject: [Koha-bugs] [Bug 23966] Branch Transfer Limits editor unusable for sites with many libraries and ccodes/itemtypes In-Reply-To: <bug-23966-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23966-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23966-70-DU2loritJa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23966 --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- FYI, for one partner this patch reduced the load time from 8 minutes to 8 seconds! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 18:21:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 17:21:51 +0000 Subject: [Koha-bugs] [Bug 23774] When placing a hold editing using Inspect Element allows addition to the code of non listed library In-Reply-To: <bug-23774-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23774-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23774-70-rrxG9HMeUD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23774 --- Comment #6 from Patrick <pm at interleaf.ie> --- Many thanks Lari, Martin & Kathrin. Greatly appreciated. Kind regards, Patrick. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 18:24:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 17:24:58 +0000 Subject: [Koha-bugs] [Bug 23234] Circulation.t failing when comparing dates that seem identical In-Reply-To: <bug-23234-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23234-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23234-70-8i8DRt0utr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23234 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94652|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95025 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95025&action=edit Bug 23234: Mock DateTime->now using the time zone The timezone of the two dt was different, one was UTC, the other one was my local one. When we mocked DateTime->now we did not use the time zone, we must use dt_from_string instead Test plan: Make sure your environment has a different time zone than UTC `prove t/db_dependent/Circulation.t` should fail without this patch Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 18:25:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 17:25:28 +0000 Subject: [Koha-bugs] [Bug 23234] Circulation.t failing when comparing dates that seem identical In-Reply-To: <bug-23234-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23234-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23234-70-GqBu8KP1Zy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23234 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize at ptfs-europe | |.com --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- An annoying bug that's fixed nicely here.. Going straight for QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 18:25:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 17:25:33 +0000 Subject: [Koha-bugs] [Bug 23234] Circulation.t failing when comparing dates that seem identical In-Reply-To: <bug-23234-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23234-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23234-70-tpH5u9htJe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23234 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 18:25:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 17:25:41 +0000 Subject: [Koha-bugs] [Bug 23234] Circulation.t failing when comparing dates that seem identical In-Reply-To: <bug-23234-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23234-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23234-70-4pIZlnBJsK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23234 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 18:25:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 17:25:45 +0000 Subject: [Koha-bugs] [Bug 23234] Circulation.t failing when comparing dates that seem identical In-Reply-To: <bug-23234-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23234-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23234-70-8IoxH8Z1GG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23234 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 18:27:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 17:27:15 +0000 Subject: [Koha-bugs] [Bug 23234] Circulation.t failing when comparing dates that seem identical In-Reply-To: <bug-23234-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23234-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23234-70-vMXGdzJkkM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23234 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 18:27:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 17:27:17 +0000 Subject: [Koha-bugs] [Bug 23234] Circulation.t failing when comparing dates that seem identical In-Reply-To: <bug-23234-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23234-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23234-70-ojqOUSA0zq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23234 --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 18:29:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 17:29:54 +0000 Subject: [Koha-bugs] [Bug 23957] Remove button style with famfamfam icon background and replace with Font Awesome In-Reply-To: <bug-23957-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23957-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23957-70-zrhfaEjbAQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23957 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 18:29:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 17:29:56 +0000 Subject: [Koha-bugs] [Bug 23933] commit_file.pl Can't call method "get_effective_marcorgcode" on an undefined value at /usr/share/koha/lib/C4/AuthoritiesMarc.pm line 578. In-Reply-To: <bug-23933-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23933-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23933-70-ZybjVro2UM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23933 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94999|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95026 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95026&action=edit Bug 23933: (bug 10132 follow-up) Fix commit_file.pl Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 18:29:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 17:29:57 +0000 Subject: [Koha-bugs] [Bug 23957] Remove button style with famfamfam icon background and replace with Font Awesome In-Reply-To: <bug-23957-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23957-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23957-70-YfsD2HJMKU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23957 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94989|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 95027 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95027&action=edit Bug 23957: Remove button style with famfamfam icon background and replace with Font Awesome The patch modifies the markup and CSS related to the holds template in the staff client when holds policy override is necessary. The CSS background image is replaced with a Font Awesome icon. <input>s are replaced with <button>s to allow for the icon markup. To test, apply the patch and regenerate the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Enable the AllowHoldPolicyOverride system preference. - Start the process of placing a hold for a patron on a title which would not normally be available for hold. For instance: The patron already has too many holds. - On the hold confirmation screen the "Place hold" buttons should appear with a little yellow "warning" icon. - Clicking either of the two "Place hold" buttons should trigger a confirmation dialog. Test both the "Confirm" and "Cancel" options. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 18:30:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 17:30:41 +0000 Subject: [Koha-bugs] [Bug 23933] commit_file.pl Can't call method "get_effective_marcorgcode" on an undefined value at /usr/share/koha/lib/C4/AuthoritiesMarc.pm line 578. In-Reply-To: <bug-23933-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23933-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23933-70-HhNzo1ciao@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23933 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Fix works, Signingoff.. Wondering about Unit tests, but will leave that for QA discretion. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 18:31:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 17:31:03 +0000 Subject: [Koha-bugs] [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission In-Reply-To: <bug-18729-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18729-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18729-70-IOjtSa96gI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729 Sally <sally.healey at cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk --- Comment #6 from Sally <sally.healey at cheshiresharedservices.gov.uk> --- This is still valid on master. It'd be a great addition to Koha if it could be resolved. We need all of our librarians to be able to make location modifications, but we don't want them to be able to adjust the priority of the holds. Patrons have a valid reason to say to staff, "I want to pick my hold up from ABC instead XYZ" - but they don't have one to say, "I want to be moved from 174 to 9 in the queue." We'd love to be able to take the "modify_holds_priority" feature away from some librarians, but we can't justify losing the location modification feature in the process. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 18:31:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 17:31:06 +0000 Subject: [Koha-bugs] [Bug 23949] koha-common.init missing actions for koha-z3950-responder In-Reply-To: <bug-23949-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23949-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23949-70-wrs1xeYOXE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 18:31:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 17:31:12 +0000 Subject: [Koha-bugs] [Bug 23957] Remove button style with famfamfam icon background and replace with Font Awesome In-Reply-To: <bug-23957-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23957-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23957-70-4MNf7NtOEI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23957 --- Comment #4 from Owen Leonard <oleonard at myacpl.org> --- (In reply to Jonathan Druart from comment #2) > (In reply to Owen Leonard from comment #0) > > This should be done for the inputs as well. > > Why not on the same patch? My comment refers to the changes made in the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 18:36:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 17:36:45 +0000 Subject: [Koha-bugs] [Bug 23517] Add /holds/{hold_id}/priority route (PUT) In-Reply-To: <bug-23517-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23517-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23517-70-mdHhCARIiW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23517 Sally <sally.healey at cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 18:37:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 17:37:10 +0000 Subject: [Koha-bugs] [Bug 23949] koha-common.init missing actions for koha-z3950-responder In-Reply-To: <bug-23949-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23949-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23949-70-eXlQCHabKr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94957|0 |1 is obsolete| | --- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 95028 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95028&action=edit Bug 23949: Add missing actions for koha-z3950-responder in koha-common.init This patch makes the init script deal with koha-z3950-responder in --stop and --restart actions. Currently, only --start calls the script. To test: - Enable the server: $ koha-z3950-responder --enable kohadev - Stop koha-common $ service koha-common stop => SUCCESS: No koha-z3950-responder running - Start koha-common $ service koha-common start => SUCCESS: It is loaded (even if failing because of config issues) - Stop koha-common $ service koha-common stop => FAIL: It is still running (no --stop issued) - Repeat for restart - Apply this patch - Redo => SUCCESS: Things behave as expected! - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 18:38:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 17:38:39 +0000 Subject: [Koha-bugs] [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission In-Reply-To: <bug-18729-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18729-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18729-70-T5RJjKAyM8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729 --- Comment #7 from Sally <sally.healey at cheshiresharedservices.gov.uk> --- I've just seen: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23517 - do those changes resolve this bug? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 18:49:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 17:49:50 +0000 Subject: [Koha-bugs] [Bug 23967] New: Add system preference information about OrderpriceRounding in 19.05 manual Message-ID: <bug-23967-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23967 Bug ID: 23967 Summary: Add system preference information about OrderpriceRounding in 19.05 manual Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org This new system preference, orderpricerounding, does not get defined in the 19.05 manual. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 19:17:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 18:17:33 +0000 Subject: [Koha-bugs] [Bug 23868] PayPal payment button is never enabled In-Reply-To: <bug-23868-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23868-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23868-70-hQ14Jjeffi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23868 Agustín Moyano <agustinmoyano at theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 19:17:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 18:17:36 +0000 Subject: [Koha-bugs] [Bug 23868] PayPal payment button is never enabled In-Reply-To: <bug-23868-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23868-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23868-70-hokZhHlSjp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23868 --- Comment #3 from Agustín Moyano <agustinmoyano at theke.io> --- Created attachment 95029 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95029&action=edit Bug 23868: Check if threshold is undefined in javascript block of opac-account.tt This patch fixes a bug introduced by checking payment plugins threshold To test: 1. do not apply this patch 2. configure paypal options in intranet 3. create a manual invoice for a patron 4. in opac try to pay that invoice CHECK => Make Payment button is disabled, even when invoices where checked. 5. apply this patch 6. repeat step 4 SUCCESS => Make Payment button is enabled when an invoice is checked. 7. Sign off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 19:30:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 18:30:09 +0000 Subject: [Koha-bugs] [Bug 23965] Use an external service to provide DVD cover images In-Reply-To: <bug-23965-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23965-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23965-70-fyuSFgYmO1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23965 --- Comment #2 from Christopher Brannon <cbrannon at cdalibrary.org> --- Perhaps the Mana Knowledge Base could share images that people have uploaded. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 19:59:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 18:59:26 +0000 Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference In-Reply-To: <bug-18532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18532-70-40UNNFRGxz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Agustín Moyano <agustinmoyano at theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 19:59:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 18:59:30 +0000 Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference In-Reply-To: <bug-18532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18532-70-Cg0LnJNDPJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #6 from Agustín Moyano <agustinmoyano at theke.io> --- Created attachment 95030 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95030&action=edit Bug 18532: Add new letter AUTO_RENEWALS_DGST, new Auto_Renewals in message_attributes, and configured message_transports -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 19:59:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 18:59:34 +0000 Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference In-Reply-To: <bug-18532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18532-70-6PXuD2Gl1q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #7 from Agustín Moyano <agustinmoyano at theke.io> --- Created attachment 95031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95031&action=edit Bug 18532: set auto_renewals as patron messaging preference This patch adds the "Auto renewals" messaging preference on intranet and OPAC, and adds digest feature to misc/cronjobs/automatic_renewals.pl script. To test: 1. apply patches 2. perl installer/data/mysql/updatedatabase.pl 3. make sure renewals are allowed in circ rules 4. grab a patron and go to details page CHECK => patron's messaging preferences has a "Auto renewals" row -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 20:07:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 19:07:40 +0000 Subject: [Koha-bugs] [Bug 23958] Use Font Awesome icon to replace "new window" icon image In-Reply-To: <bug-23958-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23958-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23958-70-FMlaAciOSy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23958 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 20:07:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 19:07:43 +0000 Subject: [Koha-bugs] [Bug 23958] Use Font Awesome icon to replace "new window" icon image In-Reply-To: <bug-23958-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23958-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23958-70-M3BA1mQDeC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23958 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 95032 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95032&action=edit Bug 23958: Use Font Awesome icon to replace "new window" icon image This patch modifies several templates in order to eliminate the dependency on an image file for styling certain links which open popups or new windows. A Font Awesome icon is used instead. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Cataloging: - Create a new MARC record which has the same ISBN as a record in your catalog. - When you save the record it should warn you that it is a possible duplicate. The message should contain an icon-prefixed link to the existing record. - Clicking the link should open details about the title in a new window. Circulation: - Enable the itemBarcodeFallbackSearch system preference. - Open a patron for checkout and enter a word in the "barcode" field instead of a barcode. - The page should return a list of titles to choose from. Each title should be a link with an icon. Clicking the link should open details about the title in a new window. Acquisitions: - Go to Acquistisions -> Vendor -> Basket. - Choose "Add to basket" -> From an external source. - Search for and select a record which exists in your catalog. - You should be taken to a page with a "Duplicate warning" message. The message should contain an icon-prefixed link to the existing record. - Clicking this link should open details about the title in a new window. - Create a MARC file with two records: One which exists in your catalog and one which doesn't. Stage that file for import. - Choose "Add to basket" again and select "From a staged file." - Select the file you staged. - You should be taken to a page with a "Duplicate warning" message. The message should contain an icon-prefixed link to the existing record. - Clicking the link should open details about the title in a new window. Patrons: - Create a new patron which has the same name and birthday as an existing patron. - When you save the record you should be shown a duplicate warning. The link to the possible duplicate patron should be prefixed with an icon and should open the patron's details in a popup window. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 20:08:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 19:08:15 +0000 Subject: [Koha-bugs] [Bug 23523] Unitprice tax column values are not populated if entered upon ordering In-Reply-To: <bug-23523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23523-70-ZLs34S2r5a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23523 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 20:37:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 19:37:17 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23260-70-n0H7qSSvzl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Agustín Moyano <agustinmoyano at theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 20:37:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 19:37:21 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23260-70-IXIvDBJFUi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #12 from Agustín Moyano <agustinmoyano at theke.io> --- Created attachment 95033 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95033&action=edit Bug 23260: (follow-up) optimize anonymise_items_last_borrower -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 20:45:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 19:45:35 +0000 Subject: [Koha-bugs] [Bug 23523] Unitprice tax column values are not populated if entered upon ordering In-Reply-To: <bug-23523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23523-70-p2uAfVbITz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23523 --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- (In reply to Katrin Fischer from comment #5) > I think usually the 'actual price' is entered on receive - can you explain > the use case for entering it on order? The ability to enter this field on order was removed in bug 9775 and then put back again in bug 23294.. I'm still not sure I agree with it having been put back as editable, but Nicks comment regarding 'Databases where they know the price before ordering' sort of makes sense.. So... one 'can' enter it... as such we should record it and use it in calculations in my opinion. Having said that, I'm sure this will break someone's workflow to fix someone elses much like bug 9775 did in the first place.. somewhat torn. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 21:14:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 20:14:05 +0000 Subject: [Koha-bugs] [Bug 23523] Unitprice tax column values are not populated if entered upon ordering In-Reply-To: <bug-23523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23523-70-ZAxNbOEpBf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23523 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93950|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95034 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95034&action=edit Bug 23523: unitprice tax column values are not populated if entered upon ordering To test: 1 - Add an item to an acquisitions basket 2 - Make sure to enter 'Actual cost' 3 - Check the db: SELECT * FROM aqorders WHERE ordernumber={your ordernumber} 4 - Note that unitprice_tax_included and unitprice_tax_excluded are not populated 5 - Apply patch 6 - Edit that order 7 - Check DB 8 - Values should be populated 9 - Place another order, ensude values populated on creation 10 - QA people: prove -v t/db_dependent/Acquisition/populate_order_with_prices.t Signed-off-by: Claire Gravely <claire.gravely at bsz-bw.de> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 21:14:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 20:14:08 +0000 Subject: [Koha-bugs] [Bug 23523] Unitprice tax column values are not populated if entered upon ordering In-Reply-To: <bug-23523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23523-70-stOn0KowCL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23523 --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95035 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95035&action=edit Bug 23523: (QA follow-up) Minor POD corrections This just fixes a couple of typos in the POD that predate this patch but I noticed whilst QAing this ;) Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 21:15:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 20:15:35 +0000 Subject: [Koha-bugs] [Bug 23523] Unitprice tax column values are not populated if entered upon ordering In-Reply-To: <bug-23523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23523-70-27NRZnZ3tK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23523 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- OK, Having spoken to Nick and worked through the various use cases, workflows and scenarios I agree with this patchset. I'd really like to see more workflows documented so we lower the likelihood of going around in circles again, but that should hold up this bug. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 21:21:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 20:21:09 +0000 Subject: [Koha-bugs] [Bug 23523] Unitprice tax column values are not populated if entered upon ordering In-Reply-To: <bug-23523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23523-70-bVNbP7cuxt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23523 --- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Workflows to document. 1) Standing orders (unitprice is passed through from previous 'receipts' - restored functionality in bug 23294) 2) RRP 0, One can 'trick' the encumberment system by setting unitprice and rrp at the same time, setting rrp to 0 ensures ecost is also set to 0 and as such the cost of the item is not included in the encumberment totals (which is a function some libraries aparently want/require) In short: * There are workflows where you only want rrp (ecost) entered at ordering and unitprice entered at receipt. * There are workflows where if you know unitprice at ordering you should be able to enter it, but ecost should be set to match it. * There are workflows where you want to deliberately enter different values for the two to get the result out of the system you want. As such, I'm not sure we can easily clarify any one of those workflows at this point as all need to be available. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 21:21:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 20:21:35 +0000 Subject: [Koha-bugs] [Bug 23522] Actual price should be shown in basket In-Reply-To: <bug-23522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23522-70-e1yWVpRh32@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23522 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Signed Off CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 21:26:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 20:26:12 +0000 Subject: [Koha-bugs] [Bug 23522] Actual price should be shown in basket In-Reply-To: <bug-23522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23522-70-J1atsVYmPl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23522 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93215|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95036 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95036&action=edit Bug 23522: Show actual price on in baskets To test: 1 - Create a new basket in acq, mark it as 'standing' 2 - Add an item, leave the RRP and Vendor price as 0 3 - Receive shipments for the vendor 4 - Select the title from this basket 5 - On receipt enter an actual cost 6 - Finsih receiving 7 - Go to the basket 8 - Note the total for the order and the basket are 0, keep this browser tab open 9 - Open a new browser tab and create a new non standing basket 10 - Add to basket, again with no RRP or vendor price 11 - Close the basket, receive the item 12 - Enter an actual cost on receipt 13 - Return to view the basket 14 - Total and order are $0 15 - Apply patch 16 - Refresh the basket in both tabs 17 - You now see the actual price for the orders Signed-off-by: Rhonda Kuiper <rkuiper at roundrocktexas.gov> Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 21:26:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 20:26:16 +0000 Subject: [Koha-bugs] [Bug 23522] Actual price should be shown in basket In-Reply-To: <bug-23522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23522-70-QvTtKemiZP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23522 --- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95037 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95037&action=edit Bug 23522: (QA follow-up) Typo fix in comment Tiny typo fix in a new code comment Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 21:27:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 20:27:27 +0000 Subject: [Koha-bugs] [Bug 23522] Actual price should be shown in basket In-Reply-To: <bug-23522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23522-70-0JngKol752@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23522 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Clarifies what's going on behind the scenes by displaying any data we have available to us at the time at which we are looking at the basket. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 21:29:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 20:29:28 +0000 Subject: [Koha-bugs] [Bug 23522] Actual price should be shown in basket In-Reply-To: <bug-23522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23522-70-bzzFxfw1a0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23522 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_19_11_candidate Severity|normal |enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 21:30:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 20:30:05 +0000 Subject: [Koha-bugs] [Bug 23522] Show "Actual price" in basket when available In-Reply-To: <bug-23522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23522-70-xJ2kOQUE0k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23522 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Actual price should be |Show "Actual price" in |shown in basket |basket when available -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 21:30:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 20:30:34 +0000 Subject: [Koha-bugs] [Bug 23522] Show "Actual price" in basket when available In-Reply-To: <bug-23522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23522-70-37L2hKNLxW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23522 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual, | |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 21:30:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 20:30:53 +0000 Subject: [Koha-bugs] [Bug 23523] Unitprice tax column values are not populated if entered upon ordering In-Reply-To: <bug-23523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23523-70-l3fTcZPVH3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23523 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual, | |release-notes-needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 21:53:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 20:53:59 +0000 Subject: [Koha-bugs] [Bug 23949] koha-common.init missing actions for koha-z3950-responder In-Reply-To: <bug-23949-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23949-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23949-70-0LocmV6vc9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_19_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 22:38:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 21:38:20 +0000 Subject: [Koha-bugs] [Bug 23050] Plugins: Add hook to add a tab in intranet biblio details page In-Reply-To: <bug-23050-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23050-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23050-70-z97yG1nuJx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23050 --- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Thx, Tomas! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 22:40:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 21:40:26 +0000 Subject: [Koha-bugs] [Bug 23091] Restore Forgiven Overdue Fines When Lost Item Returned In-Reply-To: <bug-23091-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23091-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23091-70-eEc0lE04Mp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 rkuiper at roundrocktexas.gov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rkuiper at roundrocktexas.gov --- Comment #2 from rkuiper at roundrocktexas.gov --- We have the same process for lost items as Chris's library. If an item is long overdue lost we drop the overdue fine and charge the item replacement cost. If the item is returned, we drop the item replacement cost and charge the max overdue fine. Bug 22877 will break this process for us. We would like to have the ability to maintain this function as an option. Rhonda Kuiper -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 22:42:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 21:42:42 +0000 Subject: [Koha-bugs] [Bug 23483] When writing off a fine, the title of the patron is shown as description In-Reply-To: <bug-23483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23483-70-gKtt1C4lEt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23483 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Thank you Severine! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 22:49:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 21:49:51 +0000 Subject: [Koha-bugs] [Bug 16882] Circ restrictions caused by long overdue should be removed when the offending item is returned In-Reply-To: <bug-16882-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16882-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16882-70-5QCCTN6XK0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16882 Deb <dstephen at dubuque.lib.ia.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dstephen at dubuque.lib.ia.us --- Comment #5 from Deb <dstephen at dubuque.lib.ia.us> --- We are also having this problem. Our restricted patrons are returning items but the restriction must be removed manually. Our patrons are restricted from checking out if a single item is 7days past due. Upon return the restriction should be removed automatically. The bug is keeping patrons from using our self checks. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 23:02:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 22:02:16 +0000 Subject: [Koha-bugs] [Bug 23918] search results incorrect for multiple vowel words In-Reply-To: <bug-23918-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23918-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23918-70-LqaHQZIlVl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23918 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Bernard from comment #4) > Thanks. I can't see anything in that file that would map 1 lowercase letter > o to 2 (or 2 to 3). Our file is like this: > https://github.com/Koha-Community/Koha/blob/18.11.x/etc/zebradb/etc/word- > phrase-utf.chr Any idea which line might be causing this to happen? My theory is, that the combination of those is doing it: equivalent ō(oo) map ō o I could be wrong :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 23:22:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 22:22:14 +0000 Subject: [Koha-bugs] [Bug 23965] Use an external service to provide DVD cover images In-Reply-To: <bug-23965-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23965-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23965-70-OxKelYEFjK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23965 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Christopher Brannon from comment #2) > Perhaps the Mana Knowledge Base could share images that people have uploaded. There might be copyright issues in some countries (I think Germany being one of them). But that just means we should make it easy to turn it on/off, to be on the safe side. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 23:25:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 22:25:27 +0000 Subject: [Koha-bugs] [Bug 13503] Auth.pm needs tests In-Reply-To: <bug-13503-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13503-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13503-70-vqDsl0I5sN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13503 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |LATER Status|NEW |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 23:28:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 22:28:25 +0000 Subject: [Koha-bugs] [Bug 13563] AngularJS In-Reply-To: <bug-13563-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13563-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13563-70-a6RStNI927@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13563 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|BLOCKED |RESOLVED --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- AngularJS now had many versions and simpler more Koha friendly alternatives are available. Closing this bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 23:28:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 22:28:26 +0000 Subject: [Koha-bugs] [Bug 13630] Angular-based circulation client In-Reply-To: <bug-13630-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13630-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13630-70-dOi2SUxqWi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13630 Bug 13630 depends on bug 13563, which changed state. Bug 13563 Summary: AngularJS https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13563 What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 23:28:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 22:28:26 +0000 Subject: [Koha-bugs] [Bug 13733] Give librarians the ability to add messages to an item In-Reply-To: <bug-13733-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13733-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13733-70-LZOUBz5Rhc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13733 Bug 13733 depends on bug 13563, which changed state. Bug 13563 Summary: AngularJS https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13563 What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |RESOLVED Resolution|--- |WONTFIX -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 23:43:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 22:43:26 +0000 Subject: [Koha-bugs] [Bug 18587] LDAP: update_local is entirely untested! In-Reply-To: <bug-18587-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18587-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18587-70-UINgFISn0u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18587 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 23:43:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 22:43:39 +0000 Subject: [Koha-bugs] [Bug 18587] LDAP: update_local is entirely untested! In-Reply-To: <bug-18587-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18587-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18587-70-ArtmWErssp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18587 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 23:43:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 22:43:50 +0000 Subject: [Koha-bugs] [Bug 18587] LDAP: update_local is entirely untested! In-Reply-To: <bug-18587-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18587-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18587-70-y0CNxA9K3E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18587 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|martin.renvoize at ptfs-europe |testopia at bugs.koha-communit |.com |y.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 4 23:46:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 22:46:56 +0000 Subject: [Koha-bugs] [Bug 20965] Batch patron anonymization logic is flawed In-Reply-To: <bug-20965-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20965-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20965-70-65q68e3bDv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20965 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 00:58:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 04 Nov 2019 23:58:46 +0000 Subject: [Koha-bugs] [Bug 23068] Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy In-Reply-To: <bug-23068-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23068-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23068-70-mL9IAR6g4s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068 --- Comment #30 from David Cook <dcook at prosentient.com.au> --- Yay! Nice one, Kyle! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 04:01:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 03:01:50 +0000 Subject: [Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC In-Reply-To: <bug-14715-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14715-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14715-70-7ET15uvMbk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 04:01:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 03:01:55 +0000 Subject: [Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC In-Reply-To: <bug-14715-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14715-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14715-70-DrTBGfiCg5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #88831|0 |1 is obsolete| | Attachment #88832|0 |1 is obsolete| | Attachment #88833|0 |1 is obsolete| | Attachment #88834|0 |1 is obsolete| | Attachment #88835|0 |1 is obsolete| | Attachment #88836|0 |1 is obsolete| | Attachment #88837|0 |1 is obsolete| | Attachment #88838|0 |1 is obsolete| | Attachment #88839|0 |1 is obsolete| | --- Comment #92 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Created attachment 95038 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95038&action=edit Bug 14715: Results per page dropdown for catalogue search This patch utilises an unused search facet to handle results shown per page. To test: 1) Enable patch and update database to apply atomic updates 2) Go to system preferences and set both 'numSearchResultsDropdown' and 'OPACnumSearchResultsDropdown' to 'Show' 3) Set both 'numSearchResults' and 'OPACnumSearchResults' system preferences to 10 so that it will be clear to see how the patch works 4) Do a catalogue search in the intranet using a search term that will bring lots of results 5) The results per page dropdown should show with the selected option as the library default, the value of numSearchResults. The number of results shown on the page should match numSearchResults. 6) Choose a different number of results per page in the dropdown. The search results will automatically refresh 7) Confirm that the correct number of results per page shows 8) Confirm that changing pages does not revert the number of results shown per page to the default value 9) Confirm that you are still able to use other search facets as expected 10) Repeat steps 4-9 on the OPAC (note OPAC uses OPACnumSearchResults as the default value) Sponsored-by: Region Halland -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 04:02:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 03:02:15 +0000 Subject: [Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC In-Reply-To: <bug-14715-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14715-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14715-70-O3iklTzLby@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 08:14:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 07:14:57 +0000 Subject: [Koha-bugs] [Bug 21959] Batch item modification - ability to apply regular expression on text fields In-Reply-To: <bug-21959-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21959-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21959-70-CxCAHhESWX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21959 anne-cecile.bories at iepg.fr changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anne-cecile.bories at iepg.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 09:14:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 08:14:20 +0000 Subject: [Koha-bugs] [Bug 23050] Plugins: Add hook to add a tab in intranet biblio details page In-Reply-To: <bug-23050-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23050-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23050-70-Hm7VrzcwtC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23050 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 09:14:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 08:14:22 +0000 Subject: [Koha-bugs] [Bug 23050] Plugins: Add hook to add a tab in intranet biblio details page In-Reply-To: <bug-23050-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23050-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23050-70-Lq3vIq9UBa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23050 --- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 09:14:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 08:14:24 +0000 Subject: [Koha-bugs] [Bug 23522] Show "Actual price" in basket when available In-Reply-To: <bug-23522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23522-70-kAJ4YLEq98@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23522 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 09:14:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 08:14:26 +0000 Subject: [Koha-bugs] [Bug 23522] Show "Actual price" in basket when available In-Reply-To: <bug-23522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23522-70-bTzMRdf2eG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23522 --- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 09:14:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 08:14:28 +0000 Subject: [Koha-bugs] [Bug 23523] Unitprice tax column values are not populated if entered upon ordering In-Reply-To: <bug-23523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23523-70-vPROsz2S5n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23523 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 09:14:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 08:14:30 +0000 Subject: [Koha-bugs] [Bug 23523] Unitprice tax column values are not populated if entered upon ordering In-Reply-To: <bug-23523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23523-70-dLmJYEAAN3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23523 --- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 09:24:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 08:24:29 +0000 Subject: [Koha-bugs] [Bug 23733] Passwort import explodes when password is too 'weak' and doesn't allow empty passwords anymore In-Reply-To: <bug-23733-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23733-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23733-70-jwJFUlNbpk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23733 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Isn't this a duplicate of bug 23473 ? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 09:24:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 08:24:49 +0000 Subject: [Koha-bugs] [Bug 23733] Passwort import explodes when password is too 'weak' and doesn't allow empty passwords anymore In-Reply-To: <bug-23733-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23733-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23733-70-GHpWo9AOHP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23733 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- *** This bug has been marked as a duplicate of bug 23473 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 09:24:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 08:24:49 +0000 Subject: [Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten using the patron import tool In-Reply-To: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23473-70-pgxrGI1ada@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473 --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- *** Bug 23733 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 09:25:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 08:25:39 +0000 Subject: [Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten using the patron import tool In-Reply-To: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23473-70-Rjs9BbbpaH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 09:27:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 08:27:10 +0000 Subject: [Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten using the patron import tool In-Reply-To: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23473-70-ZBNWQvEa05@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473 --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Escalating to Major as this appears to be a regression rather than an enhancement as highlighted by bug 23733. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 09:37:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 08:37:39 +0000 Subject: [Koha-bugs] [Bug 23800] Batch modification tool orders items by barcode incremental by default (regression to 17.11) In-Reply-To: <bug-23800-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23800-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23800-70-hM7A0A2hpc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |In Discussion CC| |fridolin.somers at biblibre.co | |m --- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Oh using order_by on all barcodes may be a performance issue. See if we can change this code. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 09:51:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 08:51:00 +0000 Subject: [Koha-bugs] [Bug 23968] New: OPACMySummaryNote does not work Message-ID: <bug-23968-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23968 Bug ID: 23968 Summary: OPACMySummaryNote does not work Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org The system preference OPACMySummaryNote is used to display on the logged-in patron summary page at OPAC. It does not display anymore. Looks like it comes from code : [% IF OPACMySummaryNote %][% Koha.Preference('OPACMySummaryNote') | $raw %][% END %] OPACMySummaryNote used to be a provided variable. I propose to fix and add a div with an id to allow tunning of this specific display. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 09:51:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 08:51:19 +0000 Subject: [Koha-bugs] [Bug 23968] OPACMySummaryNote does not work In-Reply-To: <bug-23968-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23968-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23968-70-uYWOlTNlkq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23968 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |fridolin.somers at biblibre.co | |m Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 09:56:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 08:56:50 +0000 Subject: [Koha-bugs] [Bug 23968] OPACMySummaryNote does not work In-Reply-To: <bug-23968-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23968-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23968-70-7V5xjyCd0N@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23968 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 09:56:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 08:56:52 +0000 Subject: [Koha-bugs] [Bug 23968] OPACMySummaryNote does not work In-Reply-To: <bug-23968-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23968-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23968-70-g1eI4w8eFS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23968 --- Comment #1 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Created attachment 95039 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95039&action=edit Bug 23968: fix OPACMySummaryNote feature The system preference OPACMySummaryNote is used to display on the logged-in patron summary page at OPAC. It does not display anymore. Looks like it comes from code : [% IF OPACMySummaryNote %][% Koha.Preference('OPACMySummaryNote') | $raw %][% END %] OPACMySummaryNote used to be a provided variable. Test plan: 1) Enable system preference OPACMySummaryNote 2) Enter some HTML into it 3) Go to OPAC and loggin 4) Check you see the HTML in opac-user.pl 5) Disable the preference 6) Check you dont see the HTML anymore -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 09:57:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 08:57:03 +0000 Subject: [Koha-bugs] [Bug 23968] OPACMySummaryNote does not work In-Reply-To: <bug-23968-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23968-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23968-70-MqK1dPVN5m@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23968 --- Comment #2 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Created attachment 95040 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95040&action=edit Bug 23968: Add div this id around OPACMySummaryNote content -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 10:06:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 09:06:42 +0000 Subject: [Koha-bugs] [Bug 23774] When placing a hold editing using Inspect Element allows addition to the code of non listed library In-Reply-To: <bug-23774-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23774-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23774-70-py1kiOb0Nc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23774 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 10:06:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 09:06:46 +0000 Subject: [Koha-bugs] [Bug 23774] When placing a hold editing using Inspect Element allows addition to the code of non listed library In-Reply-To: <bug-23774-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23774-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23774-70-suklojuEuj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23774 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95023|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95041 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95041&action=edit Bug 23774: Server-side confirmation for hold pickup location in OPAC While placing a hold on a book, if a user opens up Inspect Element on the Pick up location drop down box they can change the pick up location in the code to a library that is not listed as a pick up location. How to replicate: Search for a book Select book Click Place Hold On the screen Home > Placing a hold Right click on Pick up location Select 'Inspect Element' Under <!-- HOLDABLE --> <li class="Branch"> <select name="Branch ******"> Pick Up location:</label>=$0 Option values are listed that relate to the pick up location, this value can be changed to another new location and when the hold is placed the hold will be placed for this new location instead of the listed options in the Pick up location drop down list. To test: 1. Apply patch 2. Repeat "How to replicate" 3. Observe it is no longer possible to place holds on libraries not defined as pickup location by changing option value via Inspect Element tool Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 10:27:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 09:27:30 +0000 Subject: [Koha-bugs] [Bug 23969] New: Add library to public lists Message-ID: <bug-23969-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23969 Bug ID: 23969 Summary: Add library to public lists Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Lists Assignee: koha-bugs at lists.koha-community.org Reporter: baselibrary.consortium at nhs.net QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl We would like to add a column and sort by library name, or separate tabs for each library on the public lists on the OPAC. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 10:29:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 09:29:54 +0000 Subject: [Koha-bugs] [Bug 17359] Patron import results use wrong encoding In-Reply-To: <bug-17359-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17359-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17359-70-N3NcakZeDo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17359 --- Comment #28 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95042 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95042&action=edit Bug 17359: Use a unicode character in tests And remove an unused variable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 10:33:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 09:33:00 +0000 Subject: [Koha-bugs] [Bug 23970] New: itemsearch: when combining two fields with the boolean operator OR, the entry of the second field is not taken into account Message-ID: <bug-23970-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23970 Bug ID: 23970 Summary: itemsearch: when combining two fields with the boolean operator OR, the entry of the second field is not taken into account Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: christian.stelzenmueller at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Itemsearch. Search for: publication date: 2005 OR publication date: 2006 Koha doesn't take the search for 2006 into account. Only items from 2005 are shown in the search results. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 10:33:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 09:33:15 +0000 Subject: [Koha-bugs] [Bug 17359] Patron import results use wrong encoding In-Reply-To: <bug-17359-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17359-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17359-70-P6mJO0XhbJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17359 --- Comment #29 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #27) Hi Marcel, thanks for the review. > my $surname ='Chloé'; > my $surname_utf8 = encode_utf8($surname); > => This name is not the best example for UTF-8. Could be Latin too. > => You dont do anything with this encoded string. > => When I am adding some Chinese character in the surname, the test fails. Looks correct for me, see the last patch. Which tests fail? > decode_utf8($borrowerline) > Instead of adding this all over the place, we should try to fix at the > source or at least closer. > LINE: while ( my $borrowerline = <$handle> ) { > You could add it here, which would be closer but thats not all. Is the > assumption correct that it is UTF-8? We just got a handle from the caller. > On the report I am reading about people uploading Latin data. > Actually, we see in tools/import_borrowers.pl: > use CGI qw ( -utf8 ); > and > my $handle = $input->upload('uploadborrowers'); > CGI tells me that "binary upload data ... are left untouched". > Do we actually need another parameter for the file encoding? As it seems that there is no encoding issue during the import process I tried to provide a patch that will not have impact on it. That's why I preferred to only modify the lines where @missing_criticals was used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 10:39:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 09:39:32 +0000 Subject: [Koha-bugs] [Bug 23969] Add library to public lists In-Reply-To: <bug-23969-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23969-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23969-70-ByUGm9Ym0D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23969 BASE Library Consortium <baselibrary.consortium at nhs.net> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |baselibrary.consortium at nhs. | |net -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 10:44:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 09:44:07 +0000 Subject: [Koha-bugs] [Bug 11514] Untranslatable "Uncertain" text in acq In-Reply-To: <bug-11514-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11514-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11514-70-aIWf3cu24h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11514 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 10:44:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 09:44:33 +0000 Subject: [Koha-bugs] [Bug 11514] "Uncertain" no longer display in acq In-Reply-To: <bug-11514-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11514-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11514-70-h7F0WOQMzC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11514 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Untranslatable "Uncertain" |"Uncertain" no longer |text in acq |display in acq -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 10:45:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 09:45:27 +0000 Subject: [Koha-bugs] [Bug 11514] "Uncertain" no longer display in acq In-Reply-To: <bug-11514-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11514-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11514-70-gGu6OxO4nF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11514 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93323|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 10:48:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 09:48:51 +0000 Subject: [Koha-bugs] [Bug 11514] "Uncertain" no longer display in acq In-Reply-To: <bug-11514-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11514-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11514-70-dQawt0pS9h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11514 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 10:49:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 09:49:08 +0000 Subject: [Koha-bugs] [Bug 11514] "Uncertain" no longer display in acq In-Reply-To: <bug-11514-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11514-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11514-70-pyA3kiPjEd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11514 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 10:49:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 09:49:14 +0000 Subject: [Koha-bugs] [Bug 11514] "Uncertain" no longer display in acq In-Reply-To: <bug-11514-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11514-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11514-70-cuq42YNwx5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11514 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93323|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95043 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95043&action=edit Bug 11514: Untranslatable "Uncertain" text in acq This patch modifies two pages so that the "Uncertain price" information is shown by the template rather than the Perl script, making the text translatable. To test, apply the patch and go to Acquisitions. - Locate or create an order in a basket which has an uncertain price. - When viewing the contents of that basket the order which was marked as having an uncertain price should be labeled "Uncertain." - The same should be true for the invoice page. If you don't have an existing invoice with an "uncertain" order, - Go to "Receive shipments" for the vendor your "uncertain" order is with. - Create a new invoice. - Receive one or more orders which has an uncertain price. - Press the "finish receiving" button. - In the "Invoice details" section of the invoice page you should see the "Uncertain" label on the correct order. Signed-off-by: Christophe Croullebois <christophe.croullebois at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> For the invoice view: close, receive, reopen, mark prices uncertain, go to the invoice page (not sure it's expected however) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 10:49:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 09:49:38 +0000 Subject: [Koha-bugs] [Bug 11514] "Uncertain" no longer display in acq In-Reply-To: <bug-11514-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11514-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11514-70-X8RiFJaNmA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11514 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 11:03:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 10:03:39 +0000 Subject: [Koha-bugs] [Bug 23825] Object.t is failing - Exception not caught In-Reply-To: <bug-23825-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23825-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23825-70-81vjs1YD1p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #24 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- 10.4.8-MariaDB-1:10.4.8+maria~stretch master: fail with patches: ok 10.1.41-MariaDB-0+deb9u1 master: ok with patches: fail # Failed test 'Column should be the expected one' # at t/db_dependent/Koha/Object.t line 413. # 'lastseen' # doesn't match '(?^u:borrowers\.lastseen)' # Looks like you failed 1 test of 3. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 11:09:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 10:09:29 +0000 Subject: [Koha-bugs] [Bug 23825] Object.t is failing - Exception not caught In-Reply-To: <bug-23825-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23825-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23825-70-fZEZTAb03z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 --- Comment #25 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95044 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95044&action=edit Bug 23825: table name is not always displayed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 11:10:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 10:10:21 +0000 Subject: [Koha-bugs] [Bug 23825] Object.t is failing - Exception not caught In-Reply-To: <bug-23825-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23825-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23825-70-mLLquvwmpD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #26 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- With this last patch I got the tests passing for both 10.4.8-MariaDB-1:10.4.8+maria~stretch and 10.1.41-MariaDB-0+deb9u1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 11:13:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 10:13:40 +0000 Subject: [Koha-bugs] [Bug 23050] Plugins: Add hook to add a tab in intranet biblio details page In-Reply-To: <bug-23050-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23050-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23050-70-0uk3YGGvvI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23050 --- Comment #18 from Matthias Meusburger <matthias.meusburger at biblibre.com> --- Tomás, didn't you forgot to "use Try::Tiny;" in catalogue/detail.pl for your last patch? (attachment 95013) Without the use statement, I get the following error when trying to display content: Can't locate object method "catch" via package "1" (perhaps you forgot to load "1"?) at /home/koha/src/catalogue/detail.pl line 89. With the use statement, it works properly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 11:19:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 10:19:54 +0000 Subject: [Koha-bugs] [Bug 23050] Plugins: Add hook to add a tab in intranet biblio details page In-Reply-To: <bug-23050-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23050-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23050-70-EcHoikAZrk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23050 --- Comment #19 from Tomás Cohen Arazi <tomascohen at gmail.com> --- (In reply to Matthias Meusburger from comment #18) > Tomás, didn't you forgot to "use Try::Tiny;" in catalogue/detail.pl for your > last patch? (attachment 95013 [details] [review]) > > Without the use statement, I get the following error when trying to display > content: > > Can't locate object method "catch" via package "1" (perhaps you forgot to > load "1"?) at /home/koha/src/catalogue/detail.pl line 89. > > With the use statement, it works properly. I did -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 11:25:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 10:25:15 +0000 Subject: [Koha-bugs] [Bug 22857] Entries missing in koha-conf.xml In-Reply-To: <bug-22857-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22857-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22857-70-TY3qq9ZkbR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22857 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 11:25:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 10:25:19 +0000 Subject: [Koha-bugs] [Bug 22857] Entries missing in koha-conf.xml In-Reply-To: <bug-22857-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22857-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22857-70-DxrglN0AT6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22857 --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95045 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95045&action=edit Bug 22857: Sync koha-conf.xml files Missing entries are added to those files. Test plan: Search for typos Compare the two files and comfirm the entries are the same in both. Exception: supportdir exists in etc/koha-conf.xml only, but I think it's obsolete. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 11:25:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 10:25:28 +0000 Subject: [Koha-bugs] [Bug 22857] Entries missing in koha-conf.xml In-Reply-To: <bug-22857-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22857-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22857-70-PflIdWf9fi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22857 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 11:55:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 10:55:18 +0000 Subject: [Koha-bugs] [Bug 23918] Search results incorrect for multiple vowel words In-Reply-To: <bug-23918-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23918-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23918-70-uIiu5JJONh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23918 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.11 |master Summary|search results incorrect |Search results incorrect |for multiple vowel words |for multiple vowel words -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 11:57:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 10:57:34 +0000 Subject: [Koha-bugs] [Bug 23971] New: Add logging for basket relation actions Message-ID: <bug-23971-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Bug ID: 23971 Summary: Add logging for basket relation actions Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: andrew.isherwood at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org Acquisitions currently creates no action_logs. Some of our customers are requesting the addition of logs. The first stage of this work is to add the following logging: 1. Who created a basket and when Basket number, Basket name, Creation date, Vendor name, Creator name 2. Who edited a basket and when Basket number, Basket name, Edited date, Vendor name, Editor name 3. Who approved a basket and when Basket number, Basket name, Approval date, Vendor name, Who approved 4. Who closed a basket and when Basket number, Basket name, Closed date, Vendor name, Who closed (all should include EDI order information) This bug is related to Bug 13325, which requests logging of fund related actions -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 11:58:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 10:58:10 +0000 Subject: [Koha-bugs] [Bug 23971] Add logging for basket relation actions In-Reply-To: <bug-23971-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23971-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23971-70-lpVQWrLsPA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |andrew.isherwood at ptfs-europ |ity.org |e.com Status|NEW |ASSIGNED Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 12:42:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 11:42:51 +0000 Subject: [Koha-bugs] [Bug 23968] OPACMySummaryNote does not work In-Reply-To: <bug-23968-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23968-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23968-70-zFC5LGyyKp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23968 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 12:42:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 11:42:54 +0000 Subject: [Koha-bugs] [Bug 23968] OPACMySummaryNote does not work In-Reply-To: <bug-23968-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23968-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23968-70-jXF4J7asHm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23968 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95039|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 95046 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95046&action=edit Bug 23968: fix OPACMySummaryNote feature The system preference OPACMySummaryNote is used to display on the logged-in patron summary page at OPAC. It does not display anymore. Looks like it comes from code : [% IF OPACMySummaryNote %][% Koha.Preference('OPACMySummaryNote') | $raw %][% END %] OPACMySummaryNote used to be a provided variable. Test plan: 1) Enable system preference OPACMySummaryNote 2) Enter some HTML into it 3) Go to OPAC and loggin 4) Check you see the HTML in opac-user.pl 5) Disable the preference 6) Check you dont see the HTML anymore -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 12:42:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 11:42:58 +0000 Subject: [Koha-bugs] [Bug 23968] OPACMySummaryNote does not work In-Reply-To: <bug-23968-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23968-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23968-70-NGe46oLA0f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23968 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95040|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 95047 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95047&action=edit Bug 23968: Add div this id around OPACMySummaryNote content Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 12:43:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 11:43:55 +0000 Subject: [Koha-bugs] [Bug 23968] OPACMySummaryNote does not work In-Reply-To: <bug-23968-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23968-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23968-70-ivu5MsN1Sj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23968 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Obvious template fix, passing QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 12:45:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 11:45:47 +0000 Subject: [Koha-bugs] [Bug 23969] Add library to public lists In-Reply-To: <bug-23969-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23969-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23969-70-qbWTcBy3FN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23969 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi! Can you clarify what is meant by library here? The home library of the list's creator? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 12:47:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 11:47:35 +0000 Subject: [Koha-bugs] [Bug 23971] Add logging for basket related actions In-Reply-To: <bug-23971-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23971-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23971-70-7Pgcy8QzKV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22794 CC| |katrin.fischer at bsz-bw.de Summary|Add logging for basket |Add logging for basket |relation actions |related actions Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794 [Bug 22794] Omnibus: Improve and extend logging in Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 12:47:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 11:47:35 +0000 Subject: [Koha-bugs] [Bug 22794] Omnibus: Improve and extend logging in Koha In-Reply-To: <bug-22794-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22794-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22794-70-wJdmBDf3is@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23971 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 [Bug 23971] Add logging for basket related actions -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 12:49:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 11:49:32 +0000 Subject: [Koha-bugs] [Bug 23733] Passwort import explodes when password is too 'weak' and doesn't allow empty passwords anymore In-Reply-To: <bug-23733-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23733-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23733-70-zPp3awco4g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23733 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|DUPLICATE |--- Status|RESOLVED |REOPENED --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- No, it's not a duplicate. This is about initial import and a regression, the other is a completely new behaviour. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 12:49:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 11:49:39 +0000 Subject: [Koha-bugs] [Bug 23733] Passwort import explodes when password is too 'weak' and doesn't allow empty passwords anymore In-Reply-To: <bug-23733-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23733-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23733-70-9nPKTI2kDE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23733 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 12:59:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 11:59:08 +0000 Subject: [Koha-bugs] [Bug 23733] Passwort import explodes when password is too 'weak' and doesn't allow empty passwords anymore In-Reply-To: <bug-23733-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23733-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23733-70-Ukpvxdl7wn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23733 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I've retested and it seems better now: Initial import (new patrons) cardnumber,surname,userid,categorycode,branchcode,password test1,Mcknight,test1,YA,SPL,'' test2,Edwards,test2,PT,MPL, Patrons are imported, only thing I wonder about: password, userid ! test2 $2a$08$.28krH.OYaHspkZ98mTew.MBDYc4ggbgaxslZgBtmlewQ58Xoip.W test3 What password has been set for the second patron? Overwriting them matching on cardnumber also works as expected. Maybe I was not testing in a clean installation - closing this for now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 13:00:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 12:00:30 +0000 Subject: [Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten using the patron import tool In-Reply-To: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23473-70-YB8Z2Chckv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473 --- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Martin Renvoize from comment #11) > Escalating to Major as this appears to be a regression rather than an > enhancement as highlighted by bug 23733. I just restested bug 23733 and all seems well - should we downgrade again? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 13:08:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 12:08:09 +0000 Subject: [Koha-bugs] [Bug 22857] Entries missing in koha-conf.xml In-Reply-To: <bug-22857-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22857-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22857-70-D89GRVTkZ9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22857 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 13:08:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 12:08:14 +0000 Subject: [Koha-bugs] [Bug 22857] Entries missing in koha-conf.xml In-Reply-To: <bug-22857-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22857-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22857-70-LLR1iNWZ9o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22857 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95045|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 95048 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95048&action=edit Bug 22857: Sync koha-conf.xml files Missing entries are added to those files. Test plan: Search for typos Compare the two files and comfirm the entries are the same in both. Exception: supportdir exists in etc/koha-conf.xml only, but I think it's obsolete. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 13:09:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 12:09:43 +0000 Subject: [Koha-bugs] [Bug 22857] Entries missing in koha-conf.xml In-Reply-To: <bug-22857-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22857-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22857-70-MUngzcjQVb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22857 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Reads well, just wondering if this could cause problems being there by default when not using the Let's encrypt feature provided by Koha for your certs? + <tls>__DB_USE_TLS__</tls> + <ca>__DB_TLS_CA_CERTIFICATE__</ca> + <cert>__DB_TLS_CLIENT_CERTIFICATE__</cert> + <key>__DB_TLS_CLIENT_KEY__</key> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 13:59:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 12:59:23 +0000 Subject: [Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten using the patron import tool In-Reply-To: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23473-70-0WdjBjSGCA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 13:59:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 12:59:25 +0000 Subject: [Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten using the patron import tool In-Reply-To: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23473-70-sY0wkk3wSN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93074|0 |1 is obsolete| | Attachment #93594|0 |1 is obsolete| | Attachment #94822|0 |1 is obsolete| | --- Comment #13 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95049 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95049&action=edit Bug 23473: Allow overwrite of passwords during import To test: 1 - Have some patrons in your system 2 - Export some of their info via reports SELECT cardnumber, userid, surname, firstname, password, branchcode, categorycode 3 - Edit the file from above, changing all the password lines 4 - Import the file with overwrite 5 - Confirm passwords have not changed (run the report again and confirm the hashes are the same) 6 - Apply patch 7 - Restart all the things 8 - Check the new box on import screen to overwrite passwrods 9 - Import file again 10 - Confirm passwords have changed 11 - Signin using new password to verify the hash is the password as supplied 12 - Repeat via commandline import supplying --overwrite_passwords option 13 - Verify works as expected 14 - Prove -v t/db_dependent/Koha/Patrons/Import.t Sponsored-by: ByWater Solutions Signed-off-by: Ron Marion <ron.marion at goddard.edu> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 13:59:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 12:59:28 +0000 Subject: [Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten using the patron import tool In-Reply-To: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23473-70-aC2O1HV1vC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473 --- Comment #14 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95050 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95050&action=edit Bug 23473: (follow-up) Make passwords 'secure' for tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 13:59:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 12:59:31 +0000 Subject: [Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten using the patron import tool In-Reply-To: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23473-70-MQTcSLHFbS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473 --- Comment #15 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95051 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95051&action=edit Bug 23473: (follow-up) check if overwrite_passwords is set -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 13:59:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 12:59:34 +0000 Subject: [Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten using the patron import tool In-Reply-To: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23473-70-FbrM6UCvdS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473 --- Comment #16 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95052 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95052&action=edit Bug 23473: (follow-up) Catch and show password exceptions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 14:13:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 13:13:54 +0000 Subject: [Koha-bugs] [Bug 23825] Object.t is failing - Exception not caught In-Reply-To: <bug-23825-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23825-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23825-70-gYriHVQ6P5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95044|0 |1 is obsolete| | --- Comment #27 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 95053 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95053&action=edit Bug 23825: table name is not always displayed Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 14:47:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 13:47:43 +0000 Subject: [Koha-bugs] [Bug 23972] New: No property remove_debarment for Koha::Patron Message-ID: <bug-23972-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23972 Bug ID: 23972 Summary: No property remove_debarment for Koha::Patron Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com To reproduce: - Make sure you have a borrower with a debarment - Go to the full "patron edit" screen, e.g. /cgi-bin/koha/members/memberentry.pl?op=modify&destination=circ&borrowernumber=1&categorycode=STAFF - Tick the checkbox for "Remove?" connected with the debarment - Click "Save" on the floating toolbar on the top of the screen - Observe the "Internal Server Error" message - Check the plack-error.log and it should say just "No property remove_debarment for Koha::Patron" Tested on a debian package install of Koha 18.11.03. (I also tested on current master, but could NOT reproduce the problem there.) I tried to grep for instances of remove_debarment being used as a property of a Koha::Patron object, but with no luck: $ grep -rn remove_debarment * koha-tmpl/intranet-tmpl/prog/en/modules/members/memberentrygen.tt: 954: <input type="checkbox" id="debarment_[% d.borrower_debarment_id | html %]" name="remove_debarment" value="[% d.borrower_debarment_id | html %]" /> members/memberentry.pl: 112: my @debarments_to_remove = $input->multi_param('remove_debarment'); members/memberentry.pl: 224: qr/^add_debarment$/, qr/^debarred_expiration$/, qr/^remove_debarment$/, # We already dealt with debarments previously -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 14:48:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 13:48:54 +0000 Subject: [Koha-bugs] [Bug 23972] No property remove_debarment for Koha::Patron In-Reply-To: <bug-23972-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23972-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23972-70-jJYtWd3EpG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23972 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Magnus Enger <magnus at libriotech.no> --- *** This bug has been marked as a duplicate of bug 23082 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 14:48:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 13:48:54 +0000 Subject: [Koha-bugs] [Bug 23082] Fatal error editing a restricted patron In-Reply-To: <bug-23082-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23082-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23082-70-PfZn8ckMph@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23082 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #18 from Magnus Enger <magnus at libriotech.no> --- *** Bug 23972 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 14:58:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 13:58:43 +0000 Subject: [Koha-bugs] [Bug 23973] New: Serials module broken by Swedish translation Message-ID: <bug-23973-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23973 Bug ID: 23973 Summary: Serials module broken by Swedish translation Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com One customer recently upgraded to 19.05.04.000 (Debian packages). After the upgrade the serials module is broken when they view the Swedish translation, but not when they view it in English. The most visually striking problem is that both page 1 and 2 of the serials form is displayed on one page. I have narrowed the problem down to koha-tmpl/intranet-tmpl/prog/sv-SE/modules/serials/subscription-add.tt line 509 which looks like this in the Swedish translation: var mana_enabled = [% IF (Koha.Preference('Mana') == 1 && mana_url) %]1[% ELSE %][% END %]; and this in the English original: var mana_enabled = [% IF (Koha.Preference('Mana') == 1 && mana_url) %]1[% ELSE %]0[% END %]; Notice the missing 0 between ELSE and END in the Swedish template. I have tried to look through the Swedish staff .po file, but I have not been able to spot any strings that affect this area of the file. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 15:19:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 14:19:40 +0000 Subject: [Koha-bugs] [Bug 23805] Add a dedicated credit_types table In-Reply-To: <bug-23805-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23805-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23805-70-hGqIUOuQ6G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 --- Comment #57 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Martin Renvoize from comment #53) > As a final note, there has been a check constraint in Koha since 2012-09-12 > when one was added as part of bug 5911 +CREATE TABLE transport_cost ( + frombranch varchar(10) NOT NULL, + tobranch varchar(10) NOT NULL, + cost decimal(6,2) NOT NULL, + disable_transfer tinyint(1) NOT NULL DEFAULT 0, + CHECK ( frombranch <> tobranch ), -- a dud check, mysql does not support that + PRIMARY KEY (frombranch, tobranch), + CONSTRAINT transport_cost_ibfk_1 FOREIGN KEY (frombranch) REFERENCES branches (branchcode) ON DELETE CASCADE ON UPDATE CASCADE, + CONSTRAINT transport_cost_ibfk_2 FOREIGN KEY (tobranch) REFERENCES branches (`branchcode`) ON DELETE CASCADE ON UPDATE CASCADE +) ENGINE=InnoDB DEFAULT CHARSET=utf8; a dud check? Interestingly, MySQL 5.5, 5.7 allows you to define CHECK constraints, but with the note that they are parsed, but ignored by all storage engines. I am having the impression that this explained why I saw it and you did not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 15:25:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 14:25:15 +0000 Subject: [Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten using the patron import tool In-Reply-To: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23473-70-37rst2jmam@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 15:39:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 14:39:03 +0000 Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders In-Reply-To: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18731-70-PHC1B2kMsl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 15:39:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 14:39:05 +0000 Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders In-Reply-To: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18731-70-NiTRFO2jYD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84133|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 15:39:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 14:39:08 +0000 Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders In-Reply-To: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18731-70-LzWFOvSEKp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #84134|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 15:42:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 14:42:46 +0000 Subject: [Koha-bugs] [Bug 23805] Add a dedicated credit_types table In-Reply-To: <bug-23805-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23805-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23805-70-rEcUvIxhhp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 --- Comment #58 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Martin Renvoize from comment #56) > I've plain removed the check constraints from both this bug and 23049 too.. > Clearly people are generally not interested in data integrity [..] Surely people are. Too bad that you had to remove it for now. But couldnt we add a check on the about: System information ? > and it's > causing too many headaches attempting to pretend MariaDB and MySQL are the > same. On the DBMS part, since a default mysql-server install now means MariaDB in Debian, we should imo try to keep the sql stuff in mysql folder running under MariaDB and MySQL as long as practically feasible. Making another sql folder like we did for PostgreSQL was no success. Removed in 2013. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 15:43:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 14:43:48 +0000 Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders In-Reply-To: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18731-70-2A9WjnCB8E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 --- Comment #17 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 95054 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95054&action=edit Bug 18731: Unit tests This patch implements unit tests for the orders endpoint. Sponsored-by: Camden County -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 15:43:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 14:43:53 +0000 Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders In-Reply-To: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18731-70-kXOve06AHZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 --- Comment #18 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 95055 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95055&action=edit Bug 18731: OpenAPI definitions This patch introduces the OpenAPI definitions required for the orders endpoint. It matches the voted RFC. Sponsored-by: Camden County Signed-off-by: Matthias Meusburger <matthias.meusburger at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 15:43:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 14:43:57 +0000 Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders In-Reply-To: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18731-70-Tqwhgh2dZZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 --- Comment #19 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 95056 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95056&action=edit Bug 18731: /acquisitions/orders endpoint This patches implement the /acquisitions/orders endpoint. The attribute names are consistent with the voted RFC To test: 1. Apply this patchset 2. Run: $ kshell k$ prove t/db_dependent/api/v1/acquisitions_orders.t => SUCCESS: Tests pass! 3. Test the API with your favourite tool (Postman?) => SUCCESS: It works as expected! 4 Sign off :-D Sponsored-by: Camden County Signed-off-by: Matthias Meusburger <matthias.meusburger at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 16:11:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 15:11:32 +0000 Subject: [Koha-bugs] [Bug 19809] Koha::Objects::find calls do not need to be forbidden in list context In-Reply-To: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19809-70-mvGt9TdOTj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Julian Maurice from comment #12) > (In reply to Marcel de Rooy from comment #11) > > (In reply to Martin Renvoize from comment #10) > > > This seems sane to me and I like to follow the example set by DBIx::Class to > > > be honest.. that project has been around for a long time and has made allot > > > of good decisions for good reasons. > > > > I would agree with you if we were writing Koha::Objects->find at this > > moment. But in the meantime they go back to bug 13019, pushed 02/2015. How > > many find calls do we have now, and associated if conditions etc.? > > In view of that volume and the risk of breaking a lot of code, I would not > > recommend it now. > > Currently, calls to `find` are always in scalar context (because otherwise > Koha croaks), and this patch doesn't change the behaviour of `find` in > scalar context. Why do you think there's a risk of breaking code ? Hi Julian, This might have been a bit overcautious, you are right. But looking at the code, I still see some problems: + @pars = grep { defined } @pars; This is not the same as the earlier check: - return if !@pars || none { defined($_) } @pars; Btw note that this statement would return an empty list (with the croak removed). return $object; This is no longer good. Since you are returning 'undef' here literally while you want to return empty list if it is list context. You should do: if (@pars) { my $result = $self->_resultset()->find(@pars); if ($result) { $object = $self->object_class()->_new_from_dbic($result); return $object; } } return; The last return gives empty list in list context and undef in scalar context. I would like to see that tested too in the Objects.t test. And we need a rebase on members/pay.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 16:22:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 15:22:36 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23260-70-B5shr9lTvO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Thx for continuing here, Augustin. Just wondering what happens here: - subtest 'Logged in librarian is not superlibrarian & IndependentBranches' => sub { Why remove another subtest?? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 16:26:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 15:26:22 +0000 Subject: [Koha-bugs] [Bug 17359] Patron import results use wrong encoding In-Reply-To: <bug-17359-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17359-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17359-70-sMgAWbEHpM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17359 --- Comment #30 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #28) > Created attachment 95042 [details] [review] > Bug 17359: Use a unicode character in tests > > And remove an unused variable. t/db_dependent/Koha/Patrons/Import.t | 2 +- Where did you remove it? :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 16:28:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 15:28:49 +0000 Subject: [Koha-bugs] [Bug 17359] Patron import results use wrong encoding In-Reply-To: <bug-17359-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17359-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17359-70-9xVX6TUb0N@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17359 --- Comment #31 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #29) > Looks correct for me, see the last patch. Which tests fail? my $surname ='Chloé覂'; And now it does not fail. So what can I say? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 16:36:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 15:36:46 +0000 Subject: [Koha-bugs] [Bug 17359] Patron import results use wrong encoding In-Reply-To: <bug-17359-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17359-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17359-70-HEeuBDIcAN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17359 --- Comment #32 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #29) > As it seems that there is no encoding issue during the import process I > tried to provide a patch that will not have impact on it. That's why I > preferred to only modify the lines where @missing_criticals was used. I think that Text::CSV resolves the issue for us by guessing the encoding correctly. Formally, we cannot even pass it the encoding because we don't know. So I can understand your point. And will pass QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 16:39:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 15:39:11 +0000 Subject: [Koha-bugs] [Bug 17359] Patron import results use wrong encoding In-Reply-To: <bug-17359-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17359-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17359-70-HQffpwRx8U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17359 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 16:39:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 15:39:14 +0000 Subject: [Koha-bugs] [Bug 17359] Patron import results use wrong encoding In-Reply-To: <bug-17359-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17359-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17359-70-e3Fwd5s2RZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17359 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94809|0 |1 is obsolete| | --- Comment #33 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 95057 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95057&action=edit Bug 17359: Add tests Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 16:39:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 15:39:18 +0000 Subject: [Koha-bugs] [Bug 17359] Patron import results use wrong encoding In-Reply-To: <bug-17359-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17359-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17359-70-VsgzVJ4eD1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17359 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94810|0 |1 is obsolete| | --- Comment #34 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 95058 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95058&action=edit Bug 17359: Correct encoding when displaying patron import summary There is an encoding issue when the patron import summry, the string must be UTF8 decoded before being sent to the template. Test plan: - Create a patron import CSV file with import issues. Use UTF8 characters. See file attached to the bug report 'patron_import.csv' => The screen should display the line correctly - Correct the import issue (add a surname for Chloé) => The imported patrons should contain the correct values. Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 16:39:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 15:39:23 +0000 Subject: [Koha-bugs] [Bug 17359] Patron import results use wrong encoding In-Reply-To: <bug-17359-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17359-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17359-70-UdeO5c2cbc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17359 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95042|0 |1 is obsolete| | --- Comment #35 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 95059 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95059&action=edit Bug 17359: Use a unicode character in tests And remove an unused variable. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> [EDIT] Now really removed it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 16:42:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 15:42:11 +0000 Subject: [Koha-bugs] [Bug 19809] Koha::Objects::find calls do not need to be forbidden in list context In-Reply-To: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19809-70-AhBJnOzTa4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809 --- Comment #14 from Julian Maurice <julian.maurice at biblibre.com> --- (In reply to Marcel de Rooy from comment #13) > Hi Julian, > This might have been a bit overcautious, you are right. > But looking at the code, I still see some problems: > > + @pars = grep { defined } @pars; > This is not the same as the earlier check: > - return if !@pars || none { defined($_) } @pars; > Btw note that this statement would return an empty list (with the croak > removed). Yes, but the croak is there, so if we reach this line it means we're in scalar context, so it would return undef. Also, I am failing to see what the differences are between the two checks. In both cases, if @pars is empty or contain only undefined values, the rest of the subroutine is not executed. Can you give a value of @pars for which the behavior differ ? > > return $object; > This is no longer good. Since you are returning 'undef' here literally while > you want to return empty list if it is list context. I do not want to return an empty list. I want Koha::Objects::find to behave like DBIx::Class::ResultSet::find, which returns undef if no results were found (even if in list context) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 16:50:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 15:50:53 +0000 Subject: [Koha-bugs] [Bug 17359] Patron import results use wrong encoding In-Reply-To: <bug-17359-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17359-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17359-70-zbTInKo6sS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17359 --- Comment #36 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #30) > (In reply to Jonathan Druart from comment #28) > > Created attachment 95042 [details] [review] [review] > > Bug 17359: Use a unicode character in tests > > > > And remove an unused variable. > > t/db_dependent/Koha/Patrons/Import.t | 2 +- > > Where did you remove it? :) You... lack imagination! ;) Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 16:57:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 15:57:49 +0000 Subject: [Koha-bugs] [Bug 19809] Koha::Objects::find calls do not need to be forbidden in list context In-Reply-To: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19809-70-2buT8G4hk4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809 --- Comment #15 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Julian Maurice from comment #14) > (In reply to Marcel de Rooy from comment #13) > > Hi Julian, > > This might have been a bit overcautious, you are right. > > But looking at the code, I still see some problems: > > > > + @pars = grep { defined } @pars; > > This is not the same as the earlier check: > > - return if !@pars || none { defined($_) } @pars; > > Btw note that this statement would return an empty list (with the croak > > removed). > > Also, I am failing to see what the differences are between the two checks. > In both cases, if @pars is empty or contain only undefined values, the rest > of the subroutine is not executed. Can you give a value of @pars for which > the behavior differ ? Yes, this is very theoretical. You strip the @pars array now. Before we passed the original array unless it only consisted of undefined values. So suppose I pass 51, undef, 13. You are now passing 51, 13. Different thing! Note that find responds to multiple column PKs and unique constraint stuff. (We are probably not using in Koha.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 17:00:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 16:00:57 +0000 Subject: [Koha-bugs] [Bug 19809] Koha::Objects::find calls do not need to be forbidden in list context In-Reply-To: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19809-70-HcVDaW28JH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809 --- Comment #16 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Julian Maurice from comment #14) > > return $object; > > This is no longer good. Since you are returning 'undef' here literally while > > you want to return empty list if it is list context. > > I do not want to return an empty list. I want Koha::Objects::find to behave > like DBIx::Class::ResultSet::find, which returns undef if no results were > found (even if in list context) OK. I didnt get that right away. It is quite unperlish to return ( undef ). But yes, I checked and DBIx does it here.. So, should we stick to perl or to DBIx ? Since Koha::Objects relies on DBIx, I wouldnt mind doing the latter here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 17:33:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 16:33:15 +0000 Subject: [Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results In-Reply-To: <bug-7611-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7611-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7611-70-PKnpfabZe6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #27 from Nick Clemens <nick at bywatersolutions.com> --- Okay, I reviewed this, what it does is that: Available doesn't change Items marked 'not for loan' at itemtype level go into 'Available for reference' Items marked 'not for loan' individually, whether negative or positive, are displayed in the 'unavailable' section with the description of the 'not for loan' status showing. If you have several not for loan statuses with the same description, e.g. 'Available for reference' then they will be displayed together in the unavailable section It also adds some classes and styling to allow for the end user to adjust using css/jquery I am attaching a smaple record as described in the test plan which you can import if using the default database. You will need to add a 'NOT_LOAN' value of 4 with opac description 'Ordered' to see it in operation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 17:33:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 16:33:35 +0000 Subject: [Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results In-Reply-To: <bug-7611-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7611-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7611-70-rBhXirSTnf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611 --- Comment #28 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95060 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95060&action=edit Bug 7611: (follow-up) Fix display of undefined statuses and add a class -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 17:34:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 16:34:05 +0000 Subject: [Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results In-Reply-To: <bug-7611-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7611-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7611-70-BvJGKHBDLX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611 --- Comment #29 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95061 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95061&action=edit Sample marc record to illustrate display -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 17:41:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 16:41:42 +0000 Subject: [Koha-bugs] [Bug 23974] New: hours_between and days_between lack tests Message-ID: <bug-23974-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Bug ID: 23974 Summary: hours_between and days_between lack tests Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Those two methods are not covered by tests, which makes difficult changes like: commit a693c7243c23f888e2fad38a4fff9f37ff4a9301 Bug 23382: hours_between should match the logic of days_between We need to add more test coverage in order to improve them. For example we would like to improve the calculation for hourly loans (due date or suspension). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 17:42:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 16:42:50 +0000 Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests In-Reply-To: <bug-23974-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23974-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23974-70-FhWw9s17AC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23382 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 17:42:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 16:42:50 +0000 Subject: [Koha-bugs] [Bug 23382] Issuing rules failing after bug 20912 In-Reply-To: <bug-23382-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23382-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23382-70-viIpoitHyF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23382 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23974 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 17:44:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 16:44:59 +0000 Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests In-Reply-To: <bug-23974-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23974-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23974-70-42qb2zI0uw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95062 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95062&action=edit Bug 23974: Improve readability This patch does not change anything, just a bit of cleaning -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 17:45:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 16:45:02 +0000 Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests In-Reply-To: <bug-23974-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23974-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23974-70-Vq9lb3tT43@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95063 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95063&action=edit Bug 23974: Add new tests for hours_between -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 17:45:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 16:45:06 +0000 Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests In-Reply-To: <bug-23974-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23974-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23974-70-u7q5mkhK95@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95064 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95064&action=edit Bug 23974: Add tests for days_between -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 17:45:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 16:45:09 +0000 Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests In-Reply-To: <bug-23974-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23974-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23974-70-h6Gf2YvFfh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95065 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95065&action=edit Bug 23974: both methods should have the same logic/construction -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 17:45:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 16:45:48 +0000 Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests In-Reply-To: <bug-23974-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23974-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23974-70-KBg2XWS9L0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|ASSIGNED |In Discussion --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Now that we have a base for tests we can discuss the expected behaviors/values :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 17:55:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 16:55:36 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23260-70-bth0F6rO5Q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #14 from Agustín Moyano <agustinmoyano at theke.io> --- (In reply to Marcel de Rooy from comment #13) > Thx for continuing here, Augustin. > > Just wondering what happens here: > - subtest 'Logged in librarian is not superlibrarian & > IndependentBranches' => sub { > > Why remove another subtest?? Hi Marcel, now that we don't search the patron to anonymise, this test has no sense.. We can no longer check the library of the borrower in case IndependentBranches preference is set on. Thanks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 18:01:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 17:01:21 +0000 Subject: [Koha-bugs] [Bug 23868] PayPal payment button is never enabled In-Reply-To: <bug-23868-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23868-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23868-70-fzDvT5hWNo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23868 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23213 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23213 [Bug 23213] OPAC check mimimum payment threshold from payment plugin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 18:01:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 17:01:21 +0000 Subject: [Koha-bugs] [Bug 23213] OPAC check mimimum payment threshold from payment plugin In-Reply-To: <bug-23213-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23213-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23213-70-uQVNPWeykX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23213 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23868 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23868 [Bug 23868] PayPal payment button is never enabled -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 18:09:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 17:09:08 +0000 Subject: [Koha-bugs] [Bug 23868] PayPal payment button is never enabled In-Reply-To: <bug-23868-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23868-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23868-70-XJinJyC87w@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23868 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 18:09:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 17:09:12 +0000 Subject: [Koha-bugs] [Bug 23868] PayPal payment button is never enabled In-Reply-To: <bug-23868-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23868-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23868-70-X4ryIefLUB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23868 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95029|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95066 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95066&action=edit Bug 23868: Check if threshold is undefined in javascript block of opac-account.tt This patch fixes a bug introduced by checking payment plugins threshold To test: 1. do not apply this patch 2. configure paypal options in intranet 3. create a manual invoice for a patron 4. in opac try to pay that invoice CHECK => Make Payment button is disabled, even when invoices where checked. 5. apply this patch 6. repeat step 4 SUCCESS => Make Payment button is enabled when an invoice is checked. 7. Sign off Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 18:30:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 17:30:20 +0000 Subject: [Koha-bugs] [Bug 23975] New: Add ability to search and install plugins from GitHub Message-ID: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Bug ID: 23975 Summary: Add ability to search and install plugins from GitHub Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org It would be nice to be able to search and install plugins directly from GitHub ( and GitLab if possible ). This would make it easier to verify the authenticity of plugins and make discovering new plugins easier as well as making installation of plugins simpler. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 18:30:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 17:30:25 +0000 Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub In-Reply-To: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23975-70-RLF2CM7r7P@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 18:30:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 17:30:35 +0000 Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub In-Reply-To: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23975-70-CwEjvxBgbP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 18:32:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 17:32:28 +0000 Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub In-Reply-To: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23975-70-fxuGOALbhu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 95067 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95067&action=edit Bug 23975: [PoC] Add ability to search and install plugins from GitHub It would be nice to be able to search and install plugins directly from GitHub ( and GitLab if possible ). This would make it easier to verify the authenticity of plugins and make discovering new plugins easier as well as making installation of plugins simpler. Test Plan: 1) Apply this patch 2) Add the new block for plugin_repos to your koha-conf.xml 3) Restart all the things! 4) Browse to the plugins home page 5) Try searching for 'patrons' in the new search box 6) Verify you get results! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 18:34:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 17:34:48 +0000 Subject: [Koha-bugs] [Bug 23949] koha-common.init missing actions for koha-z3950-responder In-Reply-To: <bug-23949-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23949-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23949-70-wFrBF8c7es@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95068 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95068&action=edit Bug 23949: Update documentation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 18:35:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 17:35:17 +0000 Subject: [Koha-bugs] [Bug 23949] koha-common.init missing actions for koha-z3950-responder In-Reply-To: <bug-23949-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23949-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23949-70-VYF6ZJGdV5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- vagrant at kohadevbox:misc4dev(master)$ sudo koha-z3950-responder --enable kohadev cp: cannot stat '/etc/koha/z3950/*': No such file or directory Where/How is this directory created? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 18:41:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 17:41:24 +0000 Subject: [Koha-bugs] [Bug 19809] Koha::Objects::find calls do not need to be forbidden in list context In-Reply-To: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19809-70-dOhRYMdyb3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809 --- Comment #17 from Julian Maurice <julian.maurice at biblibre.com> --- (In reply to Marcel de Rooy from comment #15) > Yes, this is very theoretical. > You strip the @pars array now. Before we passed the original array unless it > only consisted of undefined values. > So suppose I pass 51, undef, 13. You are now passing 51, 13. Different thing! > Note that find responds to multiple column PKs and unique constraint stuff. > (We are probably not using in Koha.) Ah yes, you are right. Even if we are not using it in Koha it may be used by external tools or plugins, so it needs to be fixed (In reply to Marcel de Rooy from comment #16) > OK. I didnt get that right away. It is quite unperlish to return ( undef ). > But yes, I checked and DBIx does it here.. > So, should we stick to perl or to DBIx ? Since Koha::Objects relies on DBIx, > I wouldnt mind doing the latter here. I don't know if it's perlish or not. To me it just feels natural to always get a value (even if that value is undef) when I call find. And when you think about it, that's what we get actually by being forced to put scalar in front of `find` calls. Also, it's not that uncommon in other Perl modules. Cache::Memcached does the same thing for instance % perl -MCache::Memcached -MData::Dumper -E '$memd = new Cache::Memcached; say Dumper [$memd->get("mykey")];' $VAR1 = [ undef ]; It would be great to have Jonathan's opinion as he wrote the patch for bug 18539 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 19:07:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 18:07:20 +0000 Subject: [Koha-bugs] [Bug 23949] koha-common.init missing actions for koha-z3950-responder In-Reply-To: <bug-23949-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23949-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23949-70-8Y12voH60O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 --- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> --- (In reply to Jonathan Druart from comment #4) > vagrant at kohadevbox:misc4dev(master)$ sudo koha-z3950-responder --enable > kohadev > cp: cannot stat '/etc/koha/z3950/*': No such file or directory > > > Where/How is this directory created? I think it is missing in cp_debian_files.pl or smth -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 19:10:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 18:10:01 +0000 Subject: [Koha-bugs] [Bug 23713] Subscription add form broken for translations In-Reply-To: <bug-23713-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23713-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23713-70-ImCW6DgzEG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23713 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m, | |lucas at bywatersolutions.com --- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi all, this is a major bug confirmed in 18.11 - can this please be backported? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 19:10:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 18:10:50 +0000 Subject: [Koha-bugs] [Bug 23973] Serials module broken by Swedish translation In-Reply-To: <bug-23973-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23973-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23973-70-GGXR9pGsue@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23973 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Magnus, this has been discussed on the German mailing list and finally fixed in bug 23713 (sadly not backported yet). Marking duplicate, but the fix should be easy to implement! *** This bug has been marked as a duplicate of bug 23713 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 19:10:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 18:10:50 +0000 Subject: [Koha-bugs] [Bug 23713] Subscription add form broken for translations In-Reply-To: <bug-23713-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23713-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23713-70-hYgbLT6A1Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23713 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #15 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** Bug 23973 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 19:30:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 18:30:42 +0000 Subject: [Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace In-Reply-To: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23414-70-rxbvrwF167@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 19:30:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 18:30:45 +0000 Subject: [Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace In-Reply-To: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23414-70-3n02JjAD96@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95011|0 |1 is obsolete| | --- Comment #18 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 95069 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95069&action=edit Bug 23414: Use Koha Item objects in buildKohaItemsNamespace Removing the use of C4::GetItemsInfo cuts down on the number of DB requests and speeds things up To test I added 100 items to each of the first 20 records returned by a search for 'a' I saw a reduction from ~30 seconds to ~26 seconds This also makes the code a little cleaner and moves us toward the Koha namespace To test: 1 - Perform a search in the OPAC and STaff Client with the Browser Console opened (F12) 2 - View the netwrok tab and see how long the pages take to load 3 - Apply the patches, restart all the things 4 - Repeat and note if the results are returned faster Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 19:30:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 18:30:53 +0000 Subject: [Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace In-Reply-To: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23414-70-PfkduqPs8C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95012|0 |1 is obsolete| | --- Comment #19 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 95070 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95070&action=edit Bug 23414: Prefetch transfers, use only default framework, use elsif This further cleans up the code, before we tested each condition though we return only one status line. Koha mappings can no longer differ by framework so we don't need to fetch the biblio framework Prefetching should offer a boost To test: Same as before - there is not as big a boost form this, but there shouldn't be a hit Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 19:30:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 18:30:56 +0000 Subject: [Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace In-Reply-To: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23414-70-0nGyAsSBOD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95014|0 |1 is obsolete| | --- Comment #20 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 95071 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95071&action=edit Bug 23414: Easy readability and simplify logic in buildKohaItemsNamespace This patch improves true/false logic and avoid autovivication. Also note that xml_escape already deals with empty string. An unecessary call to GetReserveStatus is removed. Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 19:30:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 18:30:58 +0000 Subject: [Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace In-Reply-To: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23414-70-HwQ5mfHWwg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95015|0 |1 is obsolete| | --- Comment #21 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 95072 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95072&action=edit Bug 23414: Use effective_itemtype We should use effective_itemtype instead of itype to take the item-level_itypes pref into account. Note that we should not need to test for the existence of the key as we now assume that item types are correctly set to a valid item type. Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 19:34:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 18:34:02 +0000 Subject: [Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace In-Reply-To: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23414-70-ngEa6DcWUB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95010|0 |1 is obsolete| | --- Comment #22 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 95073 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95073&action=edit Bug 23414: Unit tests To test: 1 - Apply this patch alone 2 - prove -v t/db_dependent/XSLT.t 3 - All pass 4 - Apply other patches 5 - prove -v t/db_dependent/XSLT.t 6 - All pass Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 19:46:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 18:46:36 +0000 Subject: [Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record In-Reply-To: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14963-70-L8H5WwHCJv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Change sponsored?|Seeking developer |Sponsored Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 20:37:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 19:37:23 +0000 Subject: [Koha-bugs] [Bug 14287] Preserve valid ISBN-13 identifiers if they start with something else than 978 In-Reply-To: <bug-14287-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14287-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14287-70-8CAwVcOe8o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14287 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 20:46:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 19:46:56 +0000 Subject: [Koha-bugs] [Bug 13192] Hard-coded value (ISBN Prefix '978') in cataloguing::value_builder::unimarc_field_010 In-Reply-To: <bug-13192-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13192-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13192-70-0rgXu5L1KW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13192 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 20:47:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 19:47:35 +0000 Subject: [Koha-bugs] [Bug 21329] Purchase Suggestions Add Custom Fields In-Reply-To: <bug-21329-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21329-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21329-70-YdJ02yNf03@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21329 Lisette Scheer <lisetteslatah at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15774 --- Comment #4 from Lisette Scheer <lisetteslatah at gmail.com> --- The additional fields for baskets that was added in 19.05 looks very similar to what I would like to have for this. I also linked a bug for hiding the unwanted fields in the "See Also" for this bug. Lisette -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 20:47:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 19:47:35 +0000 Subject: [Koha-bugs] [Bug 15774] Additional fields for baskets In-Reply-To: <bug-15774-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15774-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15774-70-yTxk3ubhT3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15774 Lisette Scheer <lisetteslatah at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21329 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 20:51:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 19:51:48 +0000 Subject: [Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message In-Reply-To: <bug-23075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23075-70-c3gTlxvqGA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 20:51:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 19:51:51 +0000 Subject: [Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message In-Reply-To: <bug-23075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23075-70-JyQaEji0Ci@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95000|0 |1 is obsolete| | --- Comment #37 from David Nind <david at davidnind.com> --- Created attachment 95074 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95074&action=edit Bug 23075: Report if mana-kb server is not found This patch adds a status check into the mana configuration page and prompts the user to ask an adminstrator to check the configured mana service url. Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 20:51:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 19:51:54 +0000 Subject: [Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message In-Reply-To: <bug-23075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23075-70-sUoqbQZUxY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95003|0 |1 is obsolete| | --- Comment #38 from David Nind <david at davidnind.com> --- Created attachment 95075 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95075&action=edit Bug 23075: (follow-up) Dissallow transparent redirects GET request redirects were causing the http URL to 'pass' our 'good url' test for http => https redirected mana servers. However, on the subsquent POST request to get a mana security token we would fail as the POST was not transparently redirected. This patch changes the request to be a simple_request so we will catch bad urls earlier and it also prevents submissions for security tokens if the configured URL is identified as bad. Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 20:51:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 19:51:58 +0000 Subject: [Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message In-Reply-To: <bug-23075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23075-70-JaTUxfpN5x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95009|0 |1 is obsolete| | --- Comment #39 from David Nind <david at davidnind.com> --- Created attachment 95076 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95076&action=edit Bug 23075: Do not 'Send' if the url is not correct Just in case. Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 20:53:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 19:53:48 +0000 Subject: [Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message In-Reply-To: <bug-23075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23075-70-HjJImLXikd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 --- Comment #40 from David Nind <david at davidnind.com> --- Thanks Jonathan and Martin for your perseverance in resolving this! Message if an incorrect URL in config now says 'Cannot detect mana server at http://mana-test.koha-community.org, please ask an administrator to check your configuration.' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 21:14:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 20:14:14 +0000 Subject: [Koha-bugs] [Bug 23949] koha-common.init missing actions for koha-z3950-responder In-Reply-To: <bug-23949-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23949-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23949-70-sD9wLp0WHz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 5 23:34:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 05 Nov 2019 22:34:15 +0000 Subject: [Koha-bugs] [Bug 15395] Internationalization: plural forms, context, and more In-Reply-To: <bug-15395-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15395-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15395-70-5k2kFA4Iql@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #145 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Woohoo! I did my first contextualization (locally)! I was wondering what is the process to add a contextualization to the community file? Do I just submit the .tt file in a bug? It probably wouldn't be relevant to all languages... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 02:43:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 01:43:40 +0000 Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions In-Reply-To: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22784-70-1q0cxGNcXc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Agustín Moyano <agustinmoyano at theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 04:10:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 03:10:26 +0000 Subject: [Koha-bugs] [Bug 22831] Elasticsearch - add a maintenance script for checking DB vs index counts In-Reply-To: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22831-70-z7FADof4Oc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89233|0 |1 is obsolete| | --- Comment #2 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95077 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95077&action=edit Bug 22831: Elasticsearch - add a maintenance script for checking DB vs index counts This script uses Array::Utils and adds a dependency To test: 1 - Have Koha with ES running 2 - Delete some records from ES curl -X DELETE "es:9200/koha_kohadev_biblios/data/5" curl -X DELETE "es:9200/koha_kohadev_authorities/data/5" 3 - perl misc/maintenance/compare_es_to_db.pl 4 - Note you are notified of problems in both indexes 5 - perl misc/search_tools/rebuild_elastic_search.pl -a 6 - perl misc/maintenance/compare_es_to_db.pl 7 - Note you are only notified about problems in biblios (assuming you don't have other issues) 8 - perl misc/search_tools/rebuild_elastic_search.pl -b 9 - perl misc/maintenance/compare_es_to_db.pl 10 - Both counts match, no problems -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 04:21:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 03:21:46 +0000 Subject: [Koha-bugs] [Bug 22828] Elasticsearch - display errors encountered during indexing on the command line In-Reply-To: <bug-22828-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22828-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22828-70-bGr7opcbeu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22828 --- Comment #4 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Ere Maijala from comment #3) > I agree errors should be displayed, but I don't think we should fail > indexing a record with an empty field. I don't know what I meant there, but I cannot recreate a record that will not index, at least not by simply adding an empty field. All sample records index successfully now. I don't think this patch is a bad idea still in the case that we do encounter errors -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 08:29:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 07:29:59 +0000 Subject: [Koha-bugs] [Bug 23713] Subscription add form broken for translations In-Reply-To: <bug-23713-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23713-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23713-70-Ew55DJnVuV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23713 --- Comment #16 from Magnus Enger <magnus at libriotech.no> --- (In reply to Katrin Fischer from comment #14) > Hi all, this is a major bug confirmed in 18.11 - can this please be > backported? +1 for backporting! :-) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 08:39:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 07:39:00 +0000 Subject: [Koha-bugs] [Bug 22828] Elasticsearch - display errors encountered during indexing on the command line In-Reply-To: <bug-22828-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22828-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22828-70-BCPdNxJDp1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22828 --- Comment #5 from Ere Maijala <ere.maijala at helsinki.fi> --- Agreed. Could you rebase, please? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 09:02:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 08:02:05 +0000 Subject: [Koha-bugs] [Bug 22831] Elasticsearch - add a maintenance script for checking DB vs index counts In-Reply-To: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22831-70-oe8RwumaFV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Ere Maijala <ere.maijala at helsinki.fi> --- I think this needs to display some sort of progress message. Otherwise it looks like it just hangs with high CPU usage. And please fix "elastic search" to "Elasticsearch" in the comment while at it. :) It would also be useful to check from which array a record is missing and tell it to the user. Since we already have the information in the arrays, let's help the user out. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 09:16:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 08:16:33 +0000 Subject: [Koha-bugs] [Bug 22831] Elasticsearch - add a maintenance script for checking DB vs index counts In-Reply-To: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22831-70-M1EdXR5cVE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 --- Comment #4 from Michal Denar <black23 at gmail.com> --- Hi Nick, I troed to test it with Kohadevbox, but get this error on step 3: Can't locate Koha/Items.pm in @INC (you may need to install the Koha::Items module) (@INC contains: /etc/perl /usr/local/lib/x86_64-linux-gnu/perl/5.24.1 /usr/local/share/perl/5.24.1 /usr/lib/x86_64-linux-gnu/perl5/5.24 /usr/share/perl5 /usr/lib/x86_64-linux-gnu/perl/5.24 /usr/share/perl/5.24 /usr/local/lib/site_perl /usr/lib/x86_64-linux-gnu/perl-base) at compare_es_to_db.pl line 33. BEGIN failed--compilation aborted at compare_es_to_db.pl line 33. I'm really not sure about this issue. It can be based at Kohadevbox instalation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 09:20:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 08:20:12 +0000 Subject: [Koha-bugs] [Bug 15395] Internationalization: plural forms, context, and more In-Reply-To: <bug-15395-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15395-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15395-70-U9w6XvoXz8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 --- Comment #146 from Julian Maurice <julian.maurice at biblibre.com> --- (In reply to Caroline Cyr La Rose from comment #145) > Woohoo! I did my first contextualization (locally)! > > I was wondering what is the process to add a contextualization to the > community file? Do I just submit the .tt file in a bug? It probably wouldn't > be relevant to all languages... Glad to hear it! :) You should create a new bug report and submit your changes in the form of a .patch file. See https://wiki.koha-community.org/wiki/Submitting_A_Patch for more informations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 09:38:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 08:38:46 +0000 Subject: [Koha-bugs] [Bug 23949] koha-common.init missing actions for koha-z3950-responder In-Reply-To: <bug-23949-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23949-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23949-70-J7kEWDf3pQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Tomás Cohen Arazi from comment #5) > (In reply to Jonathan Druart from comment #4) > > vagrant at kohadevbox:misc4dev(master)$ sudo koha-z3950-responder --enable > > kohadev > > cp: cannot stat '/etc/koha/z3950/*': No such file or directory > > > > > > Where/How is this directory created? > > I think it is missing in cp_debian_files.pl or smth What about the debian package? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 09:50:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 08:50:43 +0000 Subject: [Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message In-Reply-To: <bug-23075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23075-70-im0GyGR0yf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 09:50:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 08:50:47 +0000 Subject: [Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message In-Reply-To: <bug-23075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23075-70-CThPdXNvae@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95074|0 |1 is obsolete| | Attachment #95075|0 |1 is obsolete| | Attachment #95076|0 |1 is obsolete| | --- Comment #41 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95078 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95078&action=edit Bug 23075: Report if mana-kb server is not found This patch adds a status check into the mana configuration page and prompts the user to ask an adminstrator to check the configured mana service url. Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 09:50:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 08:50:51 +0000 Subject: [Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message In-Reply-To: <bug-23075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23075-70-hXDnDOlI6I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 --- Comment #42 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95079 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95079&action=edit Bug 23075: (follow-up) Dissallow transparent redirects GET request redirects were causing the http URL to 'pass' our 'good url' test for http => https redirected mana servers. However, on the subsquent POST request to get a mana security token we would fail as the POST was not transparently redirected. This patch changes the request to be a simple_request so we will catch bad urls earlier and it also prevents submissions for security tokens if the configured URL is identified as bad. Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 09:50:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 08:50:55 +0000 Subject: [Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message In-Reply-To: <bug-23075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23075-70-xvYd5Pe32E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 --- Comment #43 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95080 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95080&action=edit Bug 23075: Do not 'Send' if the url is not correct Just in case. Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 09:50:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 08:50:59 +0000 Subject: [Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message In-Reply-To: <bug-23075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23075-70-zIJJhYXhaD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 --- Comment #44 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95081 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95081&action=edit Bug 23075: Correct indendation Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 09:55:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 08:55:23 +0000 Subject: [Koha-bugs] [Bug 23523] Unitprice tax column values are not populated if entered upon ordering In-Reply-To: <bug-23523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23523-70-XcdpCgiAUj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23523 --- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95082 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95082&action=edit Bug 23523: (RM follow-up) Failing tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 09:59:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 08:59:03 +0000 Subject: [Koha-bugs] [Bug 22831] Elasticsearch - add a maintenance script for checking DB vs index counts In-Reply-To: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22831-70-5SkibmSuc0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 --- Comment #5 from Ere Maijala <ere.maijala at helsinki.fi> --- That's a weird one. The script worked for me in my dev environment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 10:01:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 09:01:05 +0000 Subject: [Koha-bugs] [Bug 23523] Unitprice tax column values are not populated if entered upon ordering In-Reply-To: <bug-23523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23523-70-RIiDrp8Cz0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23523 --- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- My followup gets the tests passing but I'm pretty confident it's not right :(. The deeper down this rabbit hole I dive the less confidence in this original patchset I have I'm afraid. So, digging deeply it seems that unitprice is pretty much always passed into populate_order_with_prices (regardless of whether you have entered such a price into the UI at order time). If you have not entered a such a price then it will fallback to using 'ecost' which is calculated clientside by JS and added to a readonly form field. As such, the t/Prices.t (which before my patch always submitted ecost = unitprice), should continue to pass but it does not.. this to my highlights an issue somewhere, but I'm stuck regarding finding it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 10:01:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 09:01:14 +0000 Subject: [Koha-bugs] [Bug 23523] Unitprice tax column values are not populated if entered upon ordering In-Reply-To: <bug-23523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23523-70-7pwY9TXftZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23523 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 10:11:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 09:11:30 +0000 Subject: [Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace In-Reply-To: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23414-70-pg5Z9vnMf5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 10:11:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 09:11:38 +0000 Subject: [Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace In-Reply-To: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23414-70-32TVzX2Sbj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95069|0 |1 is obsolete| | Attachment #95070|0 |1 is obsolete| | Attachment #95071|0 |1 is obsolete| | Attachment #95072|0 |1 is obsolete| | Attachment #95073|0 |1 is obsolete| | --- Comment #23 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95083 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95083&action=edit Bug 23414: Use Koha Item objects in buildKohaItemsNamespace Removing the use of C4::GetItemsInfo cuts down on the number of DB requests and speeds things up To test I added 100 items to each of the first 20 records returned by a search for 'a' I saw a reduction from ~30 seconds to ~26 seconds This also makes the code a little cleaner and moves us toward the Koha namespace To test: 1 - Perform a search in the OPAC and STaff Client with the Browser Console opened (F12) 2 - View the netwrok tab and see how long the pages take to load 3 - Apply the patches, restart all the things 4 - Repeat and note if the results are returned faster Signed-off-by: Liz Rea <wizzyrea at gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 10:11:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 09:11:44 +0000 Subject: [Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace In-Reply-To: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23414-70-062uVc0LrF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 --- Comment #24 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95084 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95084&action=edit Bug 23414: Prefetch transfers, use only default framework, use elsif This further cleans up the code, before we tested each condition though we return only one status line. Koha mappings can no longer differ by framework so we don't need to fetch the biblio framework Prefetching should offer a boost To test: Same as before - there is not as big a boost form this, but there shouldn't be a hit Signed-off-by: Liz Rea <wizzyrea at gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 10:11:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 09:11:50 +0000 Subject: [Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace In-Reply-To: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23414-70-urV7mLIqe7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 --- Comment #25 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95085 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95085&action=edit Bug 23414: Easy readability and simplify logic in buildKohaItemsNamespace This patch improves true/false logic and avoid autovivication. Also note that xml_escape already deals with empty string. An unecessary call to GetReserveStatus is removed. Signed-off-by: Liz Rea <wizzyrea at gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 10:11:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 09:11:55 +0000 Subject: [Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace In-Reply-To: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23414-70-ZP3He862mh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 --- Comment #26 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95086 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95086&action=edit Bug 23414: Use effective_itemtype We should use effective_itemtype instead of itype to take the item-level_itypes pref into account. Note that we should not need to test for the existence of the key as we now assume that item types are correctly set to a valid item type. Signed-off-by: Liz Rea <wizzyrea at gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 10:12:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 09:12:00 +0000 Subject: [Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace In-Reply-To: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23414-70-28h6zaRl29@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 --- Comment #27 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95087 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95087&action=edit Bug 23414: Unit tests To test: 1 - Apply this patch alone 2 - prove -v t/db_dependent/XSLT.t 3 - All pass 4 - Apply other patches 5 - prove -v t/db_dependent/XSLT.t 6 - All pass Signed-off-by: Liz Rea <wizzyrea at gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 10:12:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 09:12:06 +0000 Subject: [Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace In-Reply-To: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23414-70-PXv8TEL46g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 --- Comment #28 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95088 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95088&action=edit Bug 23414: Add tests for previous effective_itemtype change Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 10:12:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 09:12:13 +0000 Subject: [Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace In-Reply-To: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23414-70-wy7a2vbtkg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 --- Comment #29 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95089 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95089&action=edit Bug 23414: Replace delimiter of regexs to ease readability Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 10:14:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 09:14:46 +0000 Subject: [Koha-bugs] [Bug 22831] Elasticsearch - add a maintenance script for checking DB vs index counts In-Reply-To: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22831-70-yTGWDPwOwS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 --- Comment #6 from Ere Maijala <ere.maijala at helsinki.fi> --- Nick, one more thing: you can make the ES cursor a zillion times faster by not retrieving any of the stored fields: my $scroll = $es->scroll_helper( index => $searcher->get_elasticsearch_params->{index_name}, size => 5000, body => { query => { match_all => {} }, stored_fields => [] }, scroll_in_qs => 1, ); I'd also run the id comparison regardless of whether record counts match since there's could be a case where they do but the records still differ. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 10:15:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 09:15:44 +0000 Subject: [Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace In-Reply-To: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23414-70-UHon1vGp57@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 --- Comment #30 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Sorry, scope creep... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 10:31:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 09:31:32 +0000 Subject: [Koha-bugs] [Bug 23719] Record matching for authorities using defined fields is broken under ES In-Reply-To: <bug-23719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23719-70-Qn3OU9QYB1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23719 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 10:31:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 09:31:36 +0000 Subject: [Koha-bugs] [Bug 23719] Record matching for authorities using defined fields is broken under ES In-Reply-To: <bug-23719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23719-70-6vuyrnmUN3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23719 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94680|0 |1 is obsolete| | Attachment #95001|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95090 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95090&action=edit Bug 23719: Allow searching specific fields for matching authorities in ES To test: 1 - Export your authorities via Tools->Export data 2 - Define a record matching rule in Admin->Record matchign rules Use index: LC-card-number field: 010$a 3 - Stage the exported records for import and use the rule created above for matching 4 - The process does not complete 5 - Check intranet error logs - exception on unknown marclist 6 - Apply patch 7 - Repeat 8 - Success! 9 - prove -v t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 10:31:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 09:31:40 +0000 Subject: [Koha-bugs] [Bug 23719] Record matching for authorities using defined fields is broken under ES In-Reply-To: <bug-23719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23719-70-7D0zRVBGDa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23719 --- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95091 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95091&action=edit Bug 23719: (follow-up) Add warn when passed invalid search field in marclist Note: I also remove warnings for undefined operation in this patch, is a trivial fix To test: prove -v t/db_dependent/Koha/SearchEngine/Elasticsearch/QueryBuilder.t Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 10:51:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 09:51:04 +0000 Subject: [Koha-bugs] [Bug 5365] It should be more clear how to reopen a basket in a basket group In-Reply-To: <bug-5365-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-5365-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5365-70-x5S25jtyFk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5365 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 10:51:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 09:51:09 +0000 Subject: [Koha-bugs] [Bug 5365] It should be more clear how to reopen a basket in a basket group In-Reply-To: <bug-5365-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-5365-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5365-70-Ki66zLNKBO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5365 --- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95092 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95092&action=edit Bug 5365: Make more clear how to reopen a basket in a basket group The "reopen basket" button will be visible but disabled if the basket cannot be reopened. A tooltip is attached to the button to add more information. Note that the export button is still hidden, would it makes sense to display it (visible and active)? Test plan: - Create a basket - Close it - Go to the basket detail view => The reopen button should be displayed and enabled - Attach it to a basket group - Go to the basket detail view => The reopen button should be displayed but disabled -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 10:53:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 09:53:22 +0000 Subject: [Koha-bugs] [Bug 5365] It should be more clear how to reopen a basket in a basket group In-Reply-To: <bug-5365-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-5365-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5365-70-9mY0iXlU0F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5365 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org --- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- This patch only addresses what is described in the title of this bug report => Display the button, but disabled, if the basket cannot be reopened. -- You are receiving this mail because: You are the assignee for the bug. You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 11:01:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 10:01:09 +0000 Subject: [Koha-bugs] [Bug 23467] BlockExpiredPatronOpacActions is causing screen to duplicate In-Reply-To: <bug-23467-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23467-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23467-70-Kt7ZQJUuHk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23467 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 11:01:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 10:01:13 +0000 Subject: [Koha-bugs] [Bug 23467] BlockExpiredPatronOpacActions is causing screen to duplicate In-Reply-To: <bug-23467-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23467-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23467-70-OhpSGqRVcU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23467 --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95093 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95093&action=edit Bug 23467: Exit after output_html - opac-reserve.pl To avoid double screen There are several ways to recreate the issue, the easiest is: /cgi-bin/koha/opac-reserve.pl?biblionumber= You should see "ERROR: No record id specified." -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 11:01:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 10:01:28 +0000 Subject: [Koha-bugs] [Bug 23467] BlockExpiredPatronOpacActions is causing screen to duplicate In-Reply-To: <bug-23467-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23467-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23467-70-iwtTA2hdww@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23467 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_19_11_candidate Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 11:02:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 10:02:19 +0000 Subject: [Koha-bugs] [Bug 23467] Duplicated screen if error in opac-reserve.pl In-Reply-To: <bug-23467-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23467-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23467-70-uT8Uljpmqz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23467 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|BlockExpiredPatronOpacActio |Duplicated screen if error |ns is causing screen to |in opac-reserve.pl |duplicate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 11:02:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 10:02:51 +0000 Subject: [Koha-bugs] [Bug 23467] Duplicated screen if error in opac-reserve.pl In-Reply-To: <bug-23467-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23467-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23467-70-CppjPd97lu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23467 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22542 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22542 [Bug 22542] Back browser should not allow to see other patrons details (see bug 5371) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 11:02:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 10:02:51 +0000 Subject: [Koha-bugs] [Bug 22542] Back browser should not allow to see other patrons details (see bug 5371) In-Reply-To: <bug-22542-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22542-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22542-70-Ntz00EcODX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22542 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23467 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23467 [Bug 23467] Duplicated screen if error in opac-reserve.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 11:09:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 10:09:54 +0000 Subject: [Koha-bugs] [Bug 23774] When placing a hold editing using Inspect Element allows addition to the code of non listed library In-Reply-To: <bug-23774-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23774-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23774-70-Pa2asKalP5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23774 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |jonathan.druart at bugs.koha-c |y.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 11:15:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 10:15:44 +0000 Subject: [Koha-bugs] [Bug 23961] Menu "add subcription fields" has disappeared In-Reply-To: <bug-23961-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23961-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23961-70-KcSOQ5ZOdB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23961 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org Depends on| |22851 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22851 [Bug 22851] Navigation links in the serials module should be styled the same as other modules -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 11:15:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 10:15:44 +0000 Subject: [Koha-bugs] [Bug 22851] Navigation links in the serials module should be styled the same as other modules In-Reply-To: <bug-22851-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22851-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22851-70-hR4IziwHKb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22851 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23961 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23961 [Bug 23961] Menu "add subcription fields" has disappeared -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 11:19:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 10:19:02 +0000 Subject: [Koha-bugs] [Bug 23961] Menu "add subcription fields" has disappeared In-Reply-To: <bug-23961-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23961-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23961-70-AabYZLaup3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23961 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 11:19:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 10:19:05 +0000 Subject: [Koha-bugs] [Bug 23961] Menu "add subcription fields" has disappeared In-Reply-To: <bug-23961-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23961-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23961-70-vtr9ckiCvw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23961 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95094 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95094&action=edit Bug 23961: (bug 22851 follow-up) Restore Add subscription fields link This fix a wrong rebase conflict resolution from commit 414869eb9d7b29754b75bd0c798d6a566df88a7e Bug 22851: Style navigation links in serials modules like same links in other modules It only affects 18.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 11:19:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 10:19:22 +0000 Subject: [Koha-bugs] [Bug 22851] Navigation links in the serials module should be styled the same as other modules In-Reply-To: <bug-22851-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22851-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22851-70-vd9BspXz9k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22851 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Lucas Gass from comment #8) > backported to 18.11.x for 18.11.08 Something went wrong during the backport, see bug 23961. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 11:20:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 10:20:11 +0000 Subject: [Koha-bugs] [Bug 23961] Menu "add subcription fields" has disappeared In-Reply-To: <bug-23961-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23961-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23961-70-atczjr3YlE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23961 --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Also, the Mana link is removed. It does not exist yet in 18.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 11:22:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 10:22:00 +0000 Subject: [Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed) In-Reply-To: <bug-22773-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22773-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22773-70-ZcEw0Wqbld@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi all, as there are some concerns about the datatables plugin used, could it be an option to see how it was solved for the subscription (separate tabs for active and closed subscriptions) and if this could be a way to avoid the plugin? If it turns out that we can't do without the plugin for now, we could still maybe add it with a FIXME. Would that be agreeable? Then this leaves updating the number displayed on the bug (comment#8). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 11:40:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 10:40:09 +0000 Subject: [Koha-bugs] [Bug 23961] [18.11] Menu "add subcription fields" has disappeared In-Reply-To: <bug-23961-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23961-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23961-70-EkQFuBBW4I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23961 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Menu "add subcription |[18.11] Menu "add |fields" has disappeared |subcription fields" has | |disappeared CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 11:40:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 10:40:48 +0000 Subject: [Koha-bugs] [Bug 23961] [18.11] Menu "add subcription fields" has disappeared In-Reply-To: <bug-23961-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23961-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23961-70-oIjy2u3qsk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23961 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 11:40:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 10:40:51 +0000 Subject: [Koha-bugs] [Bug 23961] [18.11] Menu "add subcription fields" has disappeared In-Reply-To: <bug-23961-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23961-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23961-70-NKIskj0mXv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23961 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95094|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 95095 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95095&action=edit Bug 23961: (bug 22851 follow-up) Restore Add subscription fields link This fix a wrong rebase conflict resolution from commit 414869eb9d7b29754b75bd0c798d6a566df88a7e Bug 22851: Style navigation links in serials modules like same links in other modules It only affects 18.11.x Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 11:41:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 10:41:39 +0000 Subject: [Koha-bugs] [Bug 23961] [18.11] Menu "add subcription fields" has disappeared In-Reply-To: <bug-23961-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23961-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23961-70-BZOL3NRFTz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23961 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Signed Off |Passed QA --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Lucas, this is 18.11 only - please push! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 11:41:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 10:41:51 +0000 Subject: [Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed) In-Reply-To: <bug-22773-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22773-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22773-70-IjmOJ3UXV3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- I don't mind whether we use tabs or a single table and filter.. there's precedence for both. I really don't like the idea of introducing a new dependency that is already officially deprecated, so if there's any way to work around that then I'd be onboard with it. Hope that helps guide this.. it's a nice feature and would be good to get moving again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 11:42:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 10:42:52 +0000 Subject: [Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten using the patron import tool In-Reply-To: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23473-70-agzAJu1Zxn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- 1. If empty, should not we not update the password? I get a "too_weak" error. 2. You forgot to adjust the CLI script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 11:44:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 10:44:01 +0000 Subject: [Koha-bugs] [Bug 23467] Duplicated screen if error in opac-reserve.pl In-Reply-To: <bug-23467-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23467-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23467-70-Uzn7C8r8Gq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23467 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 11:51:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 10:51:44 +0000 Subject: [Koha-bugs] [Bug 22828] Elasticsearch - display errors encountered during indexing on the command line In-Reply-To: <bug-22828-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22828-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22828-70-SbBSDogA2o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22828 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #89228|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95096 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95096&action=edit Bug 22828: Elasticsearch - display errors encountered during indexing on the command line To test: 1 - Use the Koha sample data, or insert a blank 245$b into a record (easiest way is using advanced cataloging editor 2 - Reindex elasticsearch 3 - Check the ES count on the about page 4 - Check the count in the DB (SELECT count(*) FROM biblio) 5 - They don't match! 6 - perl misc/search_tools/rebuild_elasticsearch.pl -v -v 7 - No errors indicated 8 - Apply patch 9 - perl misc/search_tools/rebuild_elasticsearch.pl -v 10 - You should be notified of an error 11 - perl misc/search_tools/rebuild_elasticsearch.pl -v -v 12 - You should be notified of the specific biblio with an error and a (somewhat) readable reason 13 - perl misc/search_tools/rebuild_elasticsearch.pl 14 - No output -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 12:02:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 11:02:40 +0000 Subject: [Koha-bugs] [Bug 23467] Duplicated screen if error in opac-reserve.pl In-Reply-To: <bug-23467-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23467-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23467-70-LxWFSM3Qh8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23467 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 12:02:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 11:02:43 +0000 Subject: [Koha-bugs] [Bug 23467] Duplicated screen if error in opac-reserve.pl In-Reply-To: <bug-23467-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23467-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23467-70-7UOp7MSwG2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23467 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95093|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 95097 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95097&action=edit Bug 23467: Exit after output_html - opac-reserve.pl To avoid double screen There are several ways to recreate the issue, the easiest is: /cgi-bin/koha/opac-reserve.pl?biblionumber= You should see "ERROR: No record id specified." Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 12:04:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 11:04:42 +0000 Subject: [Koha-bugs] [Bug 22828] Elasticsearch - display errors encountered during indexing on the command line In-Reply-To: <bug-22828-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22828-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22828-70-If6laWgLuB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22828 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95096|0 |1 is obsolete| | --- Comment #7 from Ere Maijala <ere.maijala at helsinki.fi> --- Created attachment 95098 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95098&action=edit Bug 22828: Elasticsearch - display errors encountered during indexing on the command line To test: 1 - Use the Koha sample data, or insert a blank 245$b into a record (easiest way is using advanced cataloging editor 2 - Reindex elasticsearch 3 - Check the ES count on the about page 4 - Check the count in the DB (SELECT count(*) FROM biblio) 5 - They don't match! 6 - perl misc/search_tools/rebuild_elastic_search.pl -v -v 7 - No errors indicated 8 - Apply patch 9 - perl misc/search_tools/rebuild_elastic_search.pl -v 10 - You should be notified of an error 11 - perl misc/search_tools/rebuild_elastic_search.pl -v -v 12 - You should be notified of the specific biblio with an error and a (somewhat) readable reason 13 - perl misc/search_tools/rebuild_elastic_search.pl 14 - No output Signed-off-by: Ere Maijala <ere.maijala at helsinki.fi> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 12:06:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 11:06:29 +0000 Subject: [Koha-bugs] [Bug 5365] It should be more clear how to reopen a basket in a basket group In-Reply-To: <bug-5365-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-5365-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5365-70-dyxjmS6NHM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5365 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 12:09:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 11:09:18 +0000 Subject: [Koha-bugs] [Bug 23467] Duplicated screen if error in opac-reserve.pl In-Reply-To: <bug-23467-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23467-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23467-70-H06RoamOUc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23467 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Nudging it further. I tested both, the way Jonathan suggested with the missing parameter and the original problem case with the holds. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 12:21:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 11:21:11 +0000 Subject: [Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search In-Reply-To: <bug-21249-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21249-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21249-70-VhJiPjOIXA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 12:21:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 11:21:16 +0000 Subject: [Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search In-Reply-To: <bug-21249-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21249-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21249-70-tst4oAtZnZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93345|0 |1 is obsolete| | Attachment #93346|0 |1 is obsolete| | --- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95099 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95099&action=edit Bug 21249: New syspref controlling branch fields queried against selected library group value in advanced search This commit allows librarians to choose whether they want to query the homebranch, holdingbranch or homebranch AND holdingbranch when they set a library group search condition in the staff client and OPAC advanced searches. Test plan: 1. Apply patch and run ./updatedatabase.pl in the koha shell 2. Restart memcached and plack 3. In the staff client go to Administration->Global system preferences and search for the systempreference: AdvancedSearchBranchFieldToUse and notice by default it is set to 'homebranch and holdingbranch' 4. Create a library group. Create a subgroup from the library group and add several library branches to the sub group. 5. Note down the barcode of an item to use for testing searching. Make sure the items homebranch and holdingbranch are different and the items homebranch is a child of the sub group created in step 4 6. Perform an Advanced search in the staff client and write in the item barcode as the keyword and select the sub group in the 'Location and availability' section. 7. Submit the search query and notice the item with a homebranch existing in the selected sub group is returned. This proves that when the AdvancedSearchBranchFieldToUse syspref is set to 'homebranch and holdingbranch' the homebranch value is checked. Also note at the top of the search result page the search query is listed: Results of search with limit(s): '(homebranch: <branch1> or holdingbranch: <branch2> or homebranch: <homebranch1> or holdingbranch: <branch2>)' 8. Now edit the item making sure the homebranch branch is not in the sub group, and making sure the holdingbranch is in the sub group. This is to test that holdingbranch is indeed being checked when the AdvancedSearchBranchFieldToUse is set to 'homebranch and holdingbranch' 9. Repeat step 6 and notice the item with a holdingbranch existing in the selected library group is returned. 10. Change the value of the AdvancedSearchBranchFieldToUse syspref to 'holdingbranch' and repeat step 6 and again notice the item with a holdingbranch existing in the selected library group is returned. Also note the search query at the top of the page is: "Results of search with limit(s): '(holdingbranch: <branch1> or holdingbranch: <branch2>)'" this shows holdingbranch not homebranch is a condition in the query 11. Change the value of the AdvancedSearchBranchFieldToUse syspref to 'homebranch' 12. Change the item homebranch back to a branch that is in the sub group and change the holdingbranch value to a library branch that is not in the sub group. 13. Repeat step 6 and notice the item with the homebranch in the selected library group is returned, so we know the homebranch is being checked. Also note the search query at the top of the page is: " Results of search with limit(s): '(homebranch: <branch1> or homebranch: <branch2>)'" this shows homebranch not holdingbranch is a condition in the query. Sponsored-By: Brimbank Library Signed-off-by: Amandine Zocca <azocca at ville-montauban.fr> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 12:21:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 11:21:21 +0000 Subject: [Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search In-Reply-To: <bug-21249-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21249-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21249-70-xRdQws89SU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 --- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95100 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95100&action=edit Bug 21249: Made the SQL INSERT statement idempotent Sponsored-BY: Brimbank Library, Australia Signed-off-by: Amandine Zocca <azocca at ville-montauban.fr> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 12:21:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 11:21:27 +0000 Subject: [Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search In-Reply-To: <bug-21249-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21249-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21249-70-QoBoTYT55H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 --- Comment #19 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95101 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95101&action=edit Bug 21249: Code cleaning Trying to make the code a bit more readable removing unecessary variables and parenthesis. Code is duplicated but no idea where we could move it to. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 12:22:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 11:22:33 +0000 Subject: [Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search In-Reply-To: <bug-21249-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21249-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21249-70-sYtJ4vCSkt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Passed QA |Failed QA --- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #16) > Hi Alex, > > some small stuff: > > 1) The pref name and pref description use 'branch' according to our > terminology guidelines 'library' should be used. This would also be > consistent with other prefs using 'home library' and 'holding library' (see > OPAC results library, OpacLocationOnDetail, ...) > > 2) The pref description always talks about the advanced search, but I think > this applies to the branch selection on the simple search > (OpacAddMastheadLibraryPulldown) too or should apply to it to have > consistent behaviour - can you clarify? > > 3) You are missing the change to sysprefs.sql. Sorry, I missed that comment! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 12:25:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 11:25:16 +0000 Subject: [Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed) In-Reply-To: <bug-22773-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22773-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22773-70-I5sgY6hyG8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 12:32:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 11:32:38 +0000 Subject: [Koha-bugs] [Bug 23976] New: limit ill by patron category Message-ID: <bug-23976-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23976 Bug ID: 23976 Summary: limit ill by patron category Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: ILL Assignee: koha-bugs at lists.koha-community.org Reporter: hagud at orex.es Koha administer could limit article request by patron category at circulation rules, but ill that it could cost more money is open to all type of patron it should be desirable if ill requests could be also limited by patroncategory like article request.. the limitation could be placed at syspref or also at circulation rules... perhaps better at syspref as itemtype could noe match with ill destination -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 12:32:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 11:32:43 +0000 Subject: [Koha-bugs] [Bug 23976] limit ill by patron category In-Reply-To: <bug-23976-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23976-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23976-70-fCKwGmW4gJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23976 Hugo Agud <hagud at orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Seeking developer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 12:33:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 11:33:36 +0000 Subject: [Koha-bugs] [Bug 23945] koha-remove does not support older mysql and mariadb In-Reply-To: <bug-23945-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23945-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23945-70-2vLtTup54a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23945 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|katrin.fischer at bsz-bw.de |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 12:38:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 11:38:47 +0000 Subject: [Koha-bugs] [Bug 23752] Search all z39.50 / SRU targets and resource discovery layer / open link resolver from any ILL backend In-Reply-To: <bug-23752-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23752-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23752-70-0W1NFihzQ3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23752 Hugo Agud <hagud at orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hagud at orex.es Change sponsored?|--- |Seeking developer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 12:40:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 11:40:14 +0000 Subject: [Koha-bugs] [Bug 23752] Search all z39.50 / SRU targets and resource discovery layer / open link resolver from any ILL backend In-Reply-To: <bug-23752-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23752-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23752-70-3t9FQbYtjO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23752 --- Comment #1 from Hugo Agud <hagud at orex.es> --- It should be desirable if administrator could select what z39.50 assign to ill backends. not all z39. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 12:58:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 11:58:58 +0000 Subject: [Koha-bugs] [Bug 23874] Advanced Editor is not loaded over HTTPS In-Reply-To: <bug-23874-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23874-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23874-70-XH6PMcICiB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23874 --- Comment #5 from Tomáš Wünsch <fraktik at gmail.com> --- Not sure how to help. You can login into our 19.05: https://demo.koha.cz/ user demo passwd demo -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 13:06:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 12:06:52 +0000 Subject: [Koha-bugs] [Bug 19809] Koha::Objects::find calls do not need to be forbidden in list context In-Reply-To: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19809-70-I72dWVkmy6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 13:12:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 12:12:58 +0000 Subject: [Koha-bugs] [Bug 23523] Unitprice tax column values are not populated if entered upon ordering In-Reply-To: <bug-23523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23523-70-afpKgM749V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23523 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95082|0 |1 is obsolete| | --- Comment #17 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95102 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95102&action=edit Bug 23523: (follow-up) Adjust tests for new expectations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 13:13:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 12:13:01 +0000 Subject: [Koha-bugs] [Bug 23523] Unitprice tax column values are not populated if entered upon ordering In-Reply-To: <bug-23523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23523-70-DW6gu82CB5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23523 --- Comment #18 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95103 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95103&action=edit Bug 23523: (follow-up) Clarify meaning configurations in tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 13:22:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 12:22:19 +0000 Subject: [Koha-bugs] [Bug 19809] Koha::Objects::find calls do not need to be forbidden in list context In-Reply-To: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19809-70-txTVEv1qhr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809 --- Comment #18 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Julian Maurice from comment #17) > I don't know if it's perlish or not. To me it just feels natural to always > get a value (even if that value is undef) when I call find. And when you > think about it, that's what we get actually by being forced to put scalar in > front of `find` calls. https://metacpan.org/pod/Perl::Critic::Policy::Subroutines::ProhibitExplicitReturnUndef Inspired by Damian's best practices. Note that my $object; ... return $object; is almost the same. But this is not an argument to not allow an exception from the rule ;) The only thing we should not do is: @array = Koha::Objects->find($x); if( @array ) { etc. Because that condition would always be true. Similarly, foreach( ..->find ) would not work. if( Koha::Objects->find($x) ) would be just fine however and probably what we need most. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 13:30:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 12:30:18 +0000 Subject: [Koha-bugs] [Bug 19809] Koha::Objects::find calls do not need to be forbidden in list context In-Reply-To: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19809-70-qC0GiBpsns@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809 --- Comment #19 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Julian Maurice from comment #17) > It would be great to have Jonathan's opinion as he wrote the patch for bug > 18539 Looking back, I think that the biggest problem was using ->find in parameter hashes like { var1 => KO->find, var2 => etc }. Here we have list context and if there was no result, we were returning an empty list causing a parameter/value shift. This comes from: return unless $result; Since your patch does not return empty list, we would not suffer from that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 13:30:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 12:30:29 +0000 Subject: [Koha-bugs] [Bug 23523] Unitprice tax column values are not populated if entered upon ordering In-Reply-To: <bug-23523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23523-70-GFKeuZCU67@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23523 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 13:30:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 12:30:51 +0000 Subject: [Koha-bugs] [Bug 23523] Unitprice tax column values are not populated if entered upon ordering In-Reply-To: <bug-23523-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23523-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23523-70-laxeBBRcO8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23523 --- Comment #19 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Thanks Nick, this looks good now.. followups pushed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 13:31:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 12:31:45 +0000 Subject: [Koha-bugs] [Bug 23727] Editing course reserve items is broken In-Reply-To: <bug-23727-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23727-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23727-70-jsvSUhMIp6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 95104 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95104&action=edit PDF highlighting the problematic behaviour -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 13:34:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 12:34:45 +0000 Subject: [Koha-bugs] [Bug 23977] New: tag 110 not published at isbd tab Message-ID: <bug-23977-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23977 Bug ID: 23977 Summary: tag 110 not published at isbd tab Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: hagud at orex.es QA Contact: testopia at bugs.koha-community.org Tag 110$ doesn't display at ISBD view at opac and staff, even exists and it is defined at syspref and at marc framework -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 13:35:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 12:35:47 +0000 Subject: [Koha-bugs] [Bug 23886] autocreate thumbnail for pdfs or images hosted at koha repository In-Reply-To: <bug-23886-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23886-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23886-70-k8ToUfb4zM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23886 Hugo Agud <hagud at orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Seeking developer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 13:36:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 12:36:09 +0000 Subject: [Koha-bugs] [Bug 23882] Use xslt or notice for sending results by email In-Reply-To: <bug-23882-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23882-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23882-70-fgTPl3tVE9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23882 Hugo Agud <hagud at orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|Sponsored |Seeking developer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 13:36:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 12:36:30 +0000 Subject: [Koha-bugs] [Bug 23832] 001 control number auto complet or copy from 999c In-Reply-To: <bug-23832-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23832-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23832-70-lnKQNs9D7h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23832 Hugo Agud <hagud at orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|Sponsored |Seeking developer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 13:36:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 12:36:42 +0000 Subject: [Koha-bugs] [Bug 23831] Allow public reports to add parameters In-Reply-To: <bug-23831-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23831-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23831-70-xcJK0oe41C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23831 Hugo Agud <hagud at orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|Sponsored |Seeking developer -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 13:38:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 12:38:34 +0000 Subject: [Koha-bugs] [Bug 23977] tag 110 not published at isbd tab In-Reply-To: <bug-23977-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23977-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23977-70-vUuXCooPGe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23977 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Have you checked the visibility settings in the framework? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 13:44:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 12:44:19 +0000 Subject: [Koha-bugs] [Bug 23977] tag 110 not published at isbd tab In-Reply-To: <bug-23977-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23977-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23977-70-fKwL0pkUOH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23977 --- Comment #2 from Hugo Agud <hagud at orex.es> --- yes, I have checked it a Nombre de entidad corporativa o nombre de jurisdicción como elemento de entrada Tab:1, Not repeatable, Not mandatory, | Authority:CORPO_NAME, -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 13:45:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 12:45:31 +0000 Subject: [Koha-bugs] [Bug 23977] tag 110 not published at isbd tab In-Reply-To: <bug-23977-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23977-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23977-70-AbMEIF8Lpa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23977 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I meant the checkboxes on the advanced settings for the subfields you want to see. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 13:55:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 12:55:33 +0000 Subject: [Koha-bugs] [Bug 23945] koha-remove does not support older mysql and mariadb In-Reply-To: <bug-23945-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23945-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23945-70-EfmtlAgj8L@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23945 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- So, I tried to install MySQL 5.5 on a debian 9 (old stable, stretch) and realized that it was not possible. Then I found this: https://mariadb.com/kb/en/library/moving-from-mysql-to-mariadb-in-debian-9/ Which basically says that it's expected and that Debian does no longer provide a MySQL package. So I feel like we are good here. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 13:59:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 12:59:23 +0000 Subject: [Koha-bugs] [Bug 23727] Editing course reserve items is broken In-Reply-To: <bug-23727-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23727-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23727-70-n94w8JxnxZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |blocker --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Updating to blocker, as this ends in data loss (original item values can't be restored) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 14:00:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 13:00:39 +0000 Subject: [Koha-bugs] [Bug 23874] Advanced Editor is not loaded over HTTPS In-Reply-To: <bug-23874-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23874-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23874-70-xFWcgYGIbs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23874 --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Tomáš Wünsch from comment #5) > Not sure how to help. You can login into our 19.05: > https://demo.koha.cz/ > user demo > passwd demo Hi Tomas, the Advanced Editor appears to be turned off on that one and I don't have access to the system preferences with that login. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 14:01:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 13:01:11 +0000 Subject: [Koha-bugs] [Bug 23874] Advanced Editor is not loaded over HTTPS In-Reply-To: <bug-23874-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23874-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23874-70-ojHL1OCMau@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23874 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 14:04:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 13:04:27 +0000 Subject: [Koha-bugs] [Bug 22831] Elasticsearch - add a maintenance script for checking DB vs index counts In-Reply-To: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22831-70-KXRyjXVIhO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 14:04:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 13:04:30 +0000 Subject: [Koha-bugs] [Bug 22831] Elasticsearch - add a maintenance script for checking DB vs index counts In-Reply-To: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22831-70-S8ghpvqKiZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95077|0 |1 is obsolete| | --- Comment #7 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95105 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95105&action=edit Bug 22831: Elasticsearch - add a maintenance script for checking DB vs index counts This script uses Array::Utils and adds a dependency To test: 1 - Have Koha with ES running 2 - Delete some records from ES curl -X DELETE "es:9200/koha_kohadev_biblios/data/5" curl -X DELETE "es:9200/koha_kohadev_authorities/data/5" 3 - perl misc/maintenance/compare_es_to_db.pl 4 - Note you are notified of problems in both indexes 5 - perl misc/search_tools/rebuild_elastic_search.pl -a 6 - perl misc/maintenance/compare_es_to_db.pl 7 - Note you are only notified about problems in biblios (assuming you don't have other issues) 8 - perl misc/search_tools/rebuild_elasticsearch.pl -b 9 - perl misc/maintenance/compare_es_to_db.pl 10 - Both counts match, no problems -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 14:09:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 13:09:25 +0000 Subject: [Koha-bugs] [Bug 23751] Description of staffaccess permission should be improved In-Reply-To: <bug-23751-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23751-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23751-70-WXWB8jjrMR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23751 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 14:09:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 13:09:42 +0000 Subject: [Koha-bugs] [Bug 21939] Permission for holds history tab is too strict In-Reply-To: <bug-21939-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21939-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21939-70-5ZdbQYeIS8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 14:21:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 13:21:55 +0000 Subject: [Koha-bugs] [Bug 3342] Changes to holds priority list should be logged for accountability In-Reply-To: <bug-3342-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-3342-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3342-70-a0X5zrGSF4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3342 Sally <sally.healey at cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 14:24:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 13:24:20 +0000 Subject: [Koha-bugs] [Bug 19809] Koha::Objects::find calls do not need to be forbidden in list context In-Reply-To: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19809-70-e9CgAWj0wM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809 --- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- >From 18539: """ Reading https://perlmaven.com/how-to-return-undef-from-a-function this sound like the more correct behaviour. """ That is why I picked this solution. I am not against another one, but what would be the gain? Behave as DBIx::Class::ResultSet::find? Ok I am good with that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 14:27:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 13:27:15 +0000 Subject: [Koha-bugs] [Bug 5365] It should be more clear how to reopen a basket in a basket group In-Reply-To: <bug-5365-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-5365-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5365-70-ppve8IyzXJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5365 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 14:27:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 13:27:18 +0000 Subject: [Koha-bugs] [Bug 5365] It should be more clear how to reopen a basket in a basket group In-Reply-To: <bug-5365-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-5365-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5365-70-FT7QyO4iGI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5365 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95092|0 |1 is obsolete| | --- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 95106 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95106&action=edit Bug 5365: Make more clear how to reopen a basket in a basket group The "reopen basket" button will be visible but disabled if the basket cannot be reopened. A tooltip is attached to the button to add more information. Note that the export button is still hidden, would it makes sense to display it (visible and active)? Test plan: - Create a basket - Close it - Go to the basket detail view => The reopen button should be displayed and enabled - Attach it to a basket group - Go to the basket detail view => The reopen button should be displayed but disabled Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 14:32:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 13:32:08 +0000 Subject: [Koha-bugs] [Bug 5365] It should be more clear how to reopen a basket in a basket group In-Reply-To: <bug-5365-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-5365-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5365-70-4F9BN9hc9K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5365 --- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- This one is in the top 10 of repeated support questions for us, so happy to see this change. We could refine the wording of the tooltip a little bit maybe, but it's ok to go in as is. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 14:45:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 13:45:52 +0000 Subject: [Koha-bugs] [Bug 23874] Advanced Editor is not loaded over HTTPS In-Reply-To: <bug-23874-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23874-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23874-70-ZTCyQJCos4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23874 --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Katrin Fischer from comment #6) > (In reply to Tomáš Wünsch from comment #5) > > Not sure how to help. You can login into our 19.05: > > https://demo.koha.cz/ > > user demo > > passwd demo > > Hi Tomas, the Advanced Editor appears to be turned off on that one and I > don't have access to the system preferences with that login. I've tested in the Catalyst demo that uses https, but the Advanced editor loads: https://demo-intra.mykoha.co.nz/cgi-bin/koha/cataloguing/editor.pl#new/ (https://koha-community.org/demo/) Tested in Firefox on Ubuntu. Did I miss something form the test plan? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 14:46:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 13:46:29 +0000 Subject: [Koha-bugs] [Bug 22831] Elasticsearch - add a maintenance script for checking DB vs index counts In-Reply-To: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22831-70-6cT0RA4i8E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 --- Comment #8 from Ere Maijala <ere.maijala at helsinki.fi> --- Nick, did you consider my suggestion about more informative result display: It would also be useful to check from which array a record is missing and tell it to the user. Since we already have the information in the arrays, let's help the user out. Also, maybe a running counter when fetching the records? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 14:48:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 13:48:58 +0000 Subject: [Koha-bugs] [Bug 23978] New: notes field in saved reports should allow HTML Message-ID: <bug-23978-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23978 Bug ID: 23978 Summary: notes field in saved reports should allow HTML Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: theod at lib.auth.gr QA Contact: testopia at bugs.koha-community.org In recent Koha 18.11, parsing of HTML tags was removed from many fields for security reasons. However, as also seen in 22938, 22702, 22501, 23194, 23683 there are places where HTML (or at leas line breaks!) are required, or the output is too messy. The 'notes' field in the "Guided reports wizard › Saved reports" displays the data that is previously entered in a textarea. However, the guided_reports_start.tt does not parse the HTML (nor line breaks), so the output in the resulting table is all in one line! As with the other patches, I propose that we allow HTML in report notes, so one can use strong/italics/colors/urls in notes, and most importantly, line breaks! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 14:49:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 13:49:49 +0000 Subject: [Koha-bugs] [Bug 23978] notes field in saved reports should allow HTML In-Reply-To: <bug-23978-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23978-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23978-70-2SCCJSBRIV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23978 Theodoros Theodoropoulos <theod at lib.auth.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22938, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22702, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22501, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23194, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23683 Patch complexity|--- |Trivial patch Severity|enhancement |trivial -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 14:49:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 13:49:49 +0000 Subject: [Koha-bugs] [Bug 22938] Public Notes on an Item that are on Course Reserve to show up on catalogue/detail.pl page In-Reply-To: <bug-22938-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22938-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22938-70-bzlJsHWpUR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22938 Theodoros Theodoropoulos <theod at lib.auth.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23978 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 14:49:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 13:49:49 +0000 Subject: [Koha-bugs] [Bug 22702] Circulation note on patron page should allow for HTML tags In-Reply-To: <bug-22702-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22702-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22702-70-KEUWIpyo5I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22702 Theodoros Theodoropoulos <theod at lib.auth.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23978 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 14:49:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 13:49:49 +0000 Subject: [Koha-bugs] [Bug 22501] OPAC course reserves notes should allow html links In-Reply-To: <bug-22501-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22501-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22501-70-GlnLqiPXgj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22501 Theodoros Theodoropoulos <theod at lib.auth.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23978 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 14:49:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 13:49:49 +0000 Subject: [Koha-bugs] [Bug 23194] Public notes items in the OPAC should allow for HTML tags In-Reply-To: <bug-23194-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23194-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23194-70-WcKHpPhQGK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23194 Theodoros Theodoropoulos <theod at lib.auth.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23978 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 14:49:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 13:49:49 +0000 Subject: [Koha-bugs] [Bug 23683] Course reserves public notes on specific items should allow for HTML In-Reply-To: <bug-23683-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23683-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23683-70-8EsQAEH9w4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23683 Theodoros Theodoropoulos <theod at lib.auth.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23978 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 14:51:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 13:51:45 +0000 Subject: [Koha-bugs] [Bug 20460] Changing password through the patron edit form does not reset failedloginattempts or log change In-Reply-To: <bug-20460-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20460-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20460-70-dC9rTEIwOi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20460 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #5 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- This is no longer valid as of 19.05. Changing the password via memberentry.pl now resets login_attempts to zero. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 14:52:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 13:52:02 +0000 Subject: [Koha-bugs] [Bug 20040] FailedLoginAttempts syspref will lock out users so that they cannot log in unless the syspref is cleared In-Reply-To: <bug-20040-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20040-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20040-70-oEFWX4W4zS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20040 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|Oldversions |--- Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com Resolution|INVALID |WORKSFORME -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 15:08:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 14:08:34 +0000 Subject: [Koha-bugs] [Bug 23978] notes field in saved reports should allow HTML In-Reply-To: <bug-23978-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23978-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23978-70-xEa3xRSgFG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23978 --- Comment #1 from Theodoros Theodoropoulos <theod at lib.auth.gr> --- Created attachment 95107 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95107&action=edit Allow HTML in saved reports note field -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 15:24:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 14:24:22 +0000 Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation' (bug 11373) In-Reply-To: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22359-70-qUQK9QNUgA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|19.05 |--- Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 15:25:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 14:25:51 +0000 Subject: [Koha-bugs] [Bug 23978] notes field in saved reports should allow HTML In-Reply-To: <bug-23978-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23978-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23978-70-N6WrSOU9tf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23978 Theodoros Theodoropoulos <theod at lib.auth.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95107|0 |1 is obsolete| | --- Comment #2 from Theodoros Theodoropoulos <theod at lib.auth.gr> --- Created attachment 95108 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95108&action=edit Allow HTML in saved reports note field patch based on Koha 18.11.06 code -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 15:27:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 14:27:05 +0000 Subject: [Koha-bugs] [Bug 23964] An item level hold when placed is set to Waiting, if ReservesNeedReturn is set to Automatic In-Reply-To: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23964-70-Tjd9DNPRTF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23964 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Nick, can you explain a bit please? Also I would love to see this line a bit more readable, on several lines with comments. It also seems that we are doing almost identical conditions in other places in this module (IsAvailableForItemLevelRequest). Does it means it should be refactored? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 15:27:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 14:27:33 +0000 Subject: [Koha-bugs] [Bug 22677] Include hint on OAI-PMH URL for Koha in system preference In-Reply-To: <bug-22677-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22677-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22677-70-z1s9gccHuB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22677 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94103|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 15:31:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 14:31:07 +0000 Subject: [Koha-bugs] [Bug 23979] New: "Account is locked" message on moremember.pl should be displayed on the "Check out" tab in addition to the "Details" tab Message-ID: <bug-23979-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23979 Bug ID: 23979 Summary: "Account is locked" message on moremember.pl should be displayed on the "Check out" tab in addition to the "Details" tab Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: george at nekls.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Bug 21311 removes the "This account has been locked!" message from the OPAC when a patron account has been locked because someone has attempted to log into that account with an incorrect password more than the number of times specified by the system preference FailedLoginAttempts. This means that a patron may not know that their account has been locked if someone other than themselves has attempted to hack their account. Bug 21312 adds an "Account is locked" message on the patron's "Details" tab when a patron has locked their account by logging in with an incorrect password more than the number of times specified by the system preference FailedLoginAttempts. Most public library staff access a patron's account through the "Check out" tool which takes them directly to the "Check out" tab on the patron's account rather than the "Details" tab. The "Check out" tool is, after all, the default action of the header_search input box on the Koha home page. Having the "Account is locked" message only on the "Details" tab means that when a patron comes into the library and says "I don't understand why I can't get into my account" when staff look up the patron's account through "Check out", as they normally do, they have to take the extra step of switching to the "Details" tab to find out that the "Account is locked." The "Account is locked" message on moremember.pl should be displayed on the "Check out" tab in addition to the "Details" tab. George -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 15:34:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 14:34:02 +0000 Subject: [Koha-bugs] [Bug 23979] "Account is locked" message on moremember.pl should be displayed on the "Check out" tab in addition to the "Details" tab In-Reply-To: <bug-23979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23979-70-N873hrE5r7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23979 George Williams (NEKLS) <george at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bugzilla at koha-us.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 15:36:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 14:36:25 +0000 Subject: [Koha-bugs] [Bug 22677] Include hint on OAI-PMH URL for Koha in system preference In-Reply-To: <bug-22677-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22677-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22677-70-HClNz0KX0J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22677 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_19_11_candidate CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 15:37:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 14:37:19 +0000 Subject: [Koha-bugs] [Bug 22831] Elasticsearch - add a maintenance script for checking DB vs index counts In-Reply-To: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22831-70-rEe2f2Dids@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 --- Comment #9 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95109 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95109&action=edit Bug 22831: (follow-up) Determine where the record is missing and provide link, show counter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 15:38:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 14:38:12 +0000 Subject: [Koha-bugs] [Bug 22831] Elasticsearch - add a maintenance script for checking DB vs index counts In-Reply-To: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22831-70-mvAZqsimbe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95109|0 |1 is obsolete| | --- Comment #10 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95110 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95110&action=edit Bug 22831: (follow-up) Determine where the record is missing and provide link, show counter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 15:48:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 14:48:58 +0000 Subject: [Koha-bugs] [Bug 23978] notes field in saved reports should allow HTML In-Reply-To: <bug-23978-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23978-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23978-70-2vGTD7Zdyn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23978 Theodoros Theodoropoulos <theod at lib.auth.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |theod at lib.auth.gr |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 15:49:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 14:49:19 +0000 Subject: [Koha-bugs] [Bug 23978] notes field in saved reports should allow HTML In-Reply-To: <bug-23978-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23978-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23978-70-udZCVuhrrd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23978 Theodoros Theodoropoulos <theod at lib.auth.gr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 15:59:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 14:59:27 +0000 Subject: [Koha-bugs] [Bug 23964] An item level hold when placed is set to Waiting, if ReservesNeedReturn is set to Automatic In-Reply-To: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23964-70-C5Mu36twLi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23964 --- Comment #7 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95111 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95111&action=edit Bug 23964: (follow-up) Add comments and improve readability -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 16:00:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 15:00:56 +0000 Subject: [Koha-bugs] [Bug 23964] An item level hold when placed is set to Waiting, if ReservesNeedReturn is set to Automatic In-Reply-To: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23964-70-CfVa1sT6Ls@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23964 --- Comment #8 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Jonathan Druart from comment #6) ents. > It also seems that we are doing almost identical conditions in other places > in this module (IsAvailableForItemLevelRequest). Does it means it should be > refactored? That routine is more concerned whether this hold is allowed or not, the code here is to test if the hold can be set immediately to waiting. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 16:10:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 15:10:36 +0000 Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests In-Reply-To: <bug-23974-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23974-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23974-70-q5QIzSjIJN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_19_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 16:13:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 15:13:22 +0000 Subject: [Koha-bugs] [Bug 23470] Elasticsearch - OpacSuppression not implemented in search result In-Reply-To: <bug-23470-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23470-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23470-70-TncPk6vXY6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23470 --- Comment #13 from Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> --- (In reply to Katrin Fischer from comment #11) > Hi Caroline, I think if it works for for Nick but not for you, we need to > look for the difference... > > What version of Koha are they running? > Is there a way to confirm that the suppress index is configured and filled? Hi Katrin, Have you been able to watch Caroline's last comment? I have another client reporting the same problem and everything seems well configured for the suppress index. Regards, Marjorie -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 16:16:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 15:16:17 +0000 Subject: [Koha-bugs] [Bug 23977] tag 110 not published at isbd tab In-Reply-To: <bug-23977-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23977-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23977-70-QHiWqbysic@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23977 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Assignee|oleonard at myacpl.org |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 16:17:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 15:17:17 +0000 Subject: [Koha-bugs] [Bug 23733] Password import explodes when password is too 'weak' and doesn't allow empty passwords anymore In-Reply-To: <bug-23733-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23733-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23733-70-8maYMwqFkT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23733 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Passwort import explodes |Password import explodes |when password is too 'weak' |when password is too 'weak' |and doesn't allow empty |and doesn't allow empty |passwords anymore |passwords anymore -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 16:21:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 15:21:09 +0000 Subject: [Koha-bugs] [Bug 23976] Limit interlibrary loan by patron category In-Reply-To: <bug-23976-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23976-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23976-70-erJoBubbjE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23976 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Summary|limit ill by patron |Limit interlibrary loan by |category |patron category -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 16:39:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 15:39:53 +0000 Subject: [Koha-bugs] [Bug 19809] Koha::Objects::find calls do not need to be forbidden in list context In-Reply-To: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19809-70-MVErZ1zGiy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809 --- Comment #21 from Julian Maurice <julian.maurice at biblibre.com> --- (In reply to Jonathan Druart from comment #20) > From 18539: > """ > Reading https://perlmaven.com/how-to-return-undef-from-a-function > this sound like the more correct behaviour. > """ All the pages I read about this topic talk about returning undef to indicate a failure (it is compared to `die` and `croak`) But this is not a failure here. Not finding a database entry is not a failure. "No results" is a valid result. https://perlmaven.com/how-to-return-undef-from-a-function uses this example my @y_results = div(42, 0); if (@y_results) { say "Success! We can divide 42 by 0"; } else { say "Failure!"; } In my opinion this is a bad example. Nobody should write code like that. The `div` subroutine must be clear about its return value. It is then the caller responsibility to use it correctly. And there is nothing wrong in calling `div` in a list context. For example: my @results = map { div(42, $_) } (0..9); Forbidding a perfectly valid use case makes no sense to me. > I am not against another one, but what would be the gain? It just feels like the sane thing to do. I expect Koha::Objects->find to return a scalar value, not a list. And adding `scalar` in front of `->find` calls seems superfluous. If I'm the only one feeling that way, please mark it as "wontfix", I will gladly give up on this patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 16:55:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 15:55:41 +0000 Subject: [Koha-bugs] [Bug 19809] Koha::Objects::find calls do not need to be forbidden in list context In-Reply-To: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19809-70-HevjS7sYcT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809 --- Comment #22 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Julian Maurice from comment #21) > (In reply to Jonathan Druart from comment #20) > It just feels like the sane thing to do. I expect Koha::Objects->find to > return a scalar value, not a list. And adding `scalar` in front of `->find` > calls seems superfluous. > If I'm the only one feeling that way, please mark it as "wontfix", I will > gladly give up on this patch I am having the impression that he did not want you to give up at all. So please continue (ungladly) and make it work again! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 16:56:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 15:56:52 +0000 Subject: [Koha-bugs] [Bug 23529] Interlibrary loan javascript is broken In-Reply-To: <bug-23529-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23529-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23529-70-ILMlt4SFos@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23529 --- Comment #15 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Is there any chance of this being backported to 18.11.x? Without it, ILL Javascript is completely broken in 18.11.x. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 16:57:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 15:57:11 +0000 Subject: [Koha-bugs] [Bug 23980] New: Non existent include prevents template display Message-ID: <bug-23980-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23980 Bug ID: 23980 Summary: Non existent include prevents template display Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: ILL Assignee: koha-bugs at lists.koha-community.org Reporter: andrew.isherwood at ptfs-europe.com One of the patches done during the QA process on Bug 18589 moved the strings into a separate file "ill-list-table-strings.inc", an include for this file was added to "ill-requests.tt". This bug, being an enhancement, was not backported to 18.11.x. Some months later, Bug 23529 made some changes to that template, which contained the include, which was by this time in master. Bug 23529 *was* backported to 18.11.x, along with the include. This breaks since the include is referring to a file that never made it into 18.11.x. The original bug, 18589, was definitely an enhancement, so there's no point in trying to backport it. The fix is to just remove the include. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 16:57:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 15:57:28 +0000 Subject: [Koha-bugs] [Bug 23980] Non existent include prevents template display In-Reply-To: <bug-23980-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23980-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23980-70-4PY9iWXJRv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23980 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |andrew.isherwood at ptfs-europ |ity.org |e.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 16:58:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 15:58:17 +0000 Subject: [Koha-bugs] [Bug 23980] Non existent include prevents template display In-Reply-To: <bug-23980-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23980-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23980-70-WHaAa2dg8W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23980 --- Comment #1 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 95112 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95112&action=edit Bug 23980: Remove non-existent include This patch removes the erroneous include -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 16:58:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 15:58:28 +0000 Subject: [Koha-bugs] [Bug 23980] Non existent include prevents template display In-Reply-To: <bug-23980-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23980-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23980-70-NYm5CvEImN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23980 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 16:58:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 15:58:58 +0000 Subject: [Koha-bugs] [Bug 23980] [18.11] Non existent include prevents template display In-Reply-To: <bug-23980-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23980-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23980-70-NsUA6ZeWGu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23980 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Non existent include |[18.11] Non existent |prevents template display |include prevents template | |display CC| |katrin.fischer at bsz-bw.de, | |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 17:00:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 16:00:10 +0000 Subject: [Koha-bugs] [Bug 23945] koha-remove does not support older mysql and mariadb In-Reply-To: <bug-23945-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23945-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23945-70-8NPkzl1DbD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23945 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #3) > Debian stretch is still using MySQL 5.5, and we are suppose to support the > oldstable debian version. Jessie indeed -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 17:00:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 16:00:28 +0000 Subject: [Koha-bugs] [Bug 8838] Digest option for HOLD notice In-Reply-To: <bug-8838-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8838-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8838-70-miypxPGcbd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8838 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #7 from Liz Rea <wizzyrea at gmail.com> --- I think for phone ones, it might be better to talk to the vendor who does your phone calls, to see if they can change how they parse the file for calls to only call once if there are holds waiting. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 17:01:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 16:01:34 +0000 Subject: [Koha-bugs] [Bug 23980] [18.11] Non existent include prevents template display In-Reply-To: <bug-23980-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23980-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23980-70-yE8bwjPRDR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23980 --- Comment #2 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Test plan: - Do not apply the patch - Go to /cgi-bin/koha/ill/ill-requests.pl => TEST: Observe that you receive the error: "Template process failed: file error - ill-list-table-strings.inc: not found at ..." - Apply the patch - Refresh the page => TEST: Observe that you no longer receive the error -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 17:12:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 16:12:52 +0000 Subject: [Koha-bugs] [Bug 23945] koha-remove does not support older mysql and mariadb In-Reply-To: <bug-23945-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23945-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23945-70-3T7tsQYiJl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23945 --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #6) > (In reply to Jonathan Druart from comment #3) > > Debian stretch is still using MySQL 5.5, and we are suppose to support the > > oldstable debian version. > > Jessie indeed I meant Stretch: vagrant at kohadevbox$ more /etc/debian_version 9.11 vagrant at kohadevbox$ apt show mysql-server Package: mysql-server Version: 5.5.9999+default But that's not a "real" mysql-server package -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 17:18:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 16:18:57 +0000 Subject: [Koha-bugs] [Bug 23529] Interlibrary loan javascript is broken In-Reply-To: <bug-23529-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23529-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23529-70-W7rqcM90Pd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23529 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 17:19:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 16:19:44 +0000 Subject: [Koha-bugs] [Bug 23529] Interlibrary loan javascript is broken In-Reply-To: <bug-23529-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23529-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23529-70-OisZDozSlV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23529 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- It needs to go into 19.05 first - adding Fridolin und Lucas. As discussed at the IRC meeting today, you might want to email them. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 17:24:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 16:24:03 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: <bug-14973-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14973-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14973-70-owUjDWIn20@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 --- Comment #41 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95113 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95113&action=edit Bug 14973: Remove double declaration of suggestions_loop -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 17:26:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 16:26:47 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: <bug-14973-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14973-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14973-70-0tLntD9Nis@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 --- Comment #42 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95114 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95114&action=edit Bug 14973: Add missing filters in templates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 17:31:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 16:31:57 +0000 Subject: [Koha-bugs] [Bug 19809] Koha::Objects::find calls do not need to be forbidden in list context In-Reply-To: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19809-70-rqn2ZzyWA3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92825|0 |1 is obsolete| | --- Comment #23 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 95115 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95115&action=edit Bug 19809: Re-allow to call Koha::Objects::find in list context and remove 'scalar' keyword in calls where it's not needed. Signed-off-by: Brendan Gallagher <brendan at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 17:33:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 16:33:49 +0000 Subject: [Koha-bugs] [Bug 23980] [18.11] Non existent include prevents template display In-Reply-To: <bug-23980-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23980-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23980-70-LqHi8Q9fuA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23980 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #3 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Looking at this further, I have noticed that the request for: [% Asset.js("js/ill-list-table.js") | $raw %] is also incorrect since, in 18.11.x, the JS has not been moved out of the template. I will create another patch to address this -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 17:34:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 16:34:32 +0000 Subject: [Koha-bugs] [Bug 19809] Koha::Objects::find calls do not need to be forbidden in list context In-Reply-To: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19809-70-UqusS7KgEJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809 --- Comment #24 from Julian Maurice <julian.maurice at biblibre.com> --- Patch rebased + some changes: - Explicitly say in POD that `find` returns undef when there is no results. - Fix the `if` condition so that the behaviour is unchanged (see comment 15) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 17:36:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 16:36:26 +0000 Subject: [Koha-bugs] [Bug 23529] Interlibrary loan javascript is broken In-Reply-To: <bug-23529-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23529-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23529-70-yZgEYKTupT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23529 --- Comment #17 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Actually, hold off on that last request... It may not actually be the case. Just trying to determine what the heck is going on. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 17:43:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 16:43:21 +0000 Subject: [Koha-bugs] [Bug 19809] Koha::Objects::find calls do not need to be forbidden in list context In-Reply-To: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19809-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19809-70-26fp7dT5Hr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19809 --- Comment #25 from Julian Maurice <julian.maurice at biblibre.com> --- > I am having the impression that he did not want you to give up at all. So > please continue (ungladly) and make it work again! I know, but at this point, it just feel like I'm pushing something that is a matter of personal preferences rather than an objective improvement. And it's not important enough to waste time on it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 17:43:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 16:43:22 +0000 Subject: [Koha-bugs] [Bug 23980] [18.11] Non existent include prevents template display In-Reply-To: <bug-23980-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23980-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23980-70-6vmQjPkHwQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23980 --- Comment #4 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- OK, I *think* I know what's going on. Bug 23229 should never have been backported to 18.11.x since it contains patches that don't correspond with the ILL template in that version and they add file includes to files that don't exist in 18.11.x. Fortunately, there have been no commits to ill-requests.tt since this was backported, so it should be just a case of reverting the commits. I'll add Lucas to this, since he did the backport of 23229 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 17:43:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 16:43:48 +0000 Subject: [Koha-bugs] [Bug 23854] Cannot edit a suggestion In-Reply-To: <bug-23854-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23854-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23854-70-VNGUOtbHkv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23854 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Setting to Needs Signoff to collect ideas. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 17:45:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 16:45:33 +0000 Subject: [Koha-bugs] [Bug 23483] When writing off a fine, the title of the patron is shown as description In-Reply-To: <bug-23483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23483-70-cRRMUtUXU4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23483 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94992|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95116 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95116&action=edit Bug 23483: Show the description, not the patron's title when writing off an individual fine/fee When writing off an individual fine, the description shown was the patron's title, instead of the fine description. Fixing it by changing it to the same template variable used for paying individuals so they match up. To test: - Pick a patron and make sure salutation is set (Mr, Mrs, ...) - Create a manual fine - For the fine, compare the description shown when using the Writeoff and Pay buttons next to the fine - Verify the display is different and writeoff displays the salutation - Apply patch - Repeat, descriptions now should match up Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 17:46:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 16:46:10 +0000 Subject: [Koha-bugs] [Bug 23483] When writing off a fine, the title of the patron is shown as description In-Reply-To: <bug-23483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23483-70-ytZE4F1ncX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23483 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Trivial patch works as expected.. passing qa -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 17:47:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 16:47:24 +0000 Subject: [Koha-bugs] [Bug 22677] Include hint on OAI-PMH URL for Koha in system preference In-Reply-To: <bug-22677-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22677-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22677-70-3iuuI74Kwa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22677 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94358|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95117 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95117&action=edit Bug 22677: Include hint to OAI page path on OAI-PMH preference This copies the way we are doing it for othe rprefs (ILSDI and similar) and adds a hint to the description to make it easier to find the right path for the OAI server. To test: - Apply patch - Verify that the system preference for OAI-PMH includes now a hint to: /cgi-bin/koha/oai.pl?verb=Identify - Verify the hint is correct (add OPAC base URL) Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 17:47:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 16:47:36 +0000 Subject: [Koha-bugs] [Bug 22677] Include hint on OAI-PMH URL for Koha in system preference In-Reply-To: <bug-22677-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22677-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22677-70-UKIHzDL5o0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22677 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 17:47:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 16:47:40 +0000 Subject: [Koha-bugs] [Bug 22677] Include hint on OAI-PMH URL for Koha in system preference In-Reply-To: <bug-22677-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22677-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22677-70-OMBzzgHs6r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22677 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 17:49:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 16:49:44 +0000 Subject: [Koha-bugs] [Bug 23979] "Account is locked" message on moremember.pl should be displayed on the "Check out" tab in addition to the "Details" tab In-Reply-To: <bug-23979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23979-70-1KHueXF07F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23979 Lisette Scheer <lisetteslatah at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 17:57:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 16:57:23 +0000 Subject: [Koha-bugs] [Bug 23968] OPACMySummaryNote does not work In-Reply-To: <bug-23968-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23968-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23968-70-8c7K7CctZm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23968 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 18:03:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 17:03:37 +0000 Subject: [Koha-bugs] [Bug 23658] [18.11] WrongTransfer modal drops off specified checkin date on returns.pl In-Reply-To: <bug-23658-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23658-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23658-70-VdbnI16d0l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23658 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to oldstable CC| |lucas at bywatersolutions.com --- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> --- backported to 18.11.x for 18.11.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 18:08:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 17:08:10 +0000 Subject: [Koha-bugs] [Bug 23961] [18.11] Menu "add subcription fields" has disappeared In-Reply-To: <bug-23961-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23961-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23961-70-bhIo7fyQNO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23961 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to oldstable --- Comment #5 from Lucas Gass <lucas at bywatersolutions.com> --- backported to 18.11.x for 18.11.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 18:10:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 17:10:05 +0000 Subject: [Koha-bugs] [Bug 11514] "Uncertain" no longer display in acq In-Reply-To: <bug-11514-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11514-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11514-70-ubysibM6Gi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11514 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 18:10:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 17:10:07 +0000 Subject: [Koha-bugs] [Bug 11514] "Uncertain" no longer display in acq In-Reply-To: <bug-11514-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11514-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11514-70-U9IUWpRoIV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11514 --- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 18:10:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 17:10:09 +0000 Subject: [Koha-bugs] [Bug 17359] Patron import results use wrong encoding In-Reply-To: <bug-17359-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17359-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17359-70-dxmlz9hKd3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17359 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 18:10:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 17:10:11 +0000 Subject: [Koha-bugs] [Bug 17359] Patron import results use wrong encoding In-Reply-To: <bug-17359-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17359-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17359-70-y0eewjbDhu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17359 --- Comment #37 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 18:10:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 17:10:13 +0000 Subject: [Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message In-Reply-To: <bug-23075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23075-70-9woiQkHM3s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 18:10:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 17:10:15 +0000 Subject: [Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message In-Reply-To: <bug-23075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23075-70-CSbO8Gp2aH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 --- Comment #45 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 18:10:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 17:10:17 +0000 Subject: [Koha-bugs] [Bug 23467] Duplicated screen if error in opac-reserve.pl In-Reply-To: <bug-23467-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23467-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23467-70-PGmyyY3yZq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23467 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 18:10:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 17:10:18 +0000 Subject: [Koha-bugs] [Bug 23467] Duplicated screen if error in opac-reserve.pl In-Reply-To: <bug-23467-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23467-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23467-70-nwdisCwd0T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23467 --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 18:10:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 17:10:20 +0000 Subject: [Koha-bugs] [Bug 23483] When writing off a fine, the title of the patron is shown as description In-Reply-To: <bug-23483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23483-70-3qMMOdWqzZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23483 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 18:10:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 17:10:22 +0000 Subject: [Koha-bugs] [Bug 23483] When writing off a fine, the title of the patron is shown as description In-Reply-To: <bug-23483-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23483-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23483-70-mLC4pjE5ON@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23483 --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 18:10:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 17:10:23 +0000 Subject: [Koha-bugs] [Bug 23719] Record matching for authorities using defined fields is broken under ES In-Reply-To: <bug-23719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23719-70-kx1Lm31kag@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23719 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 18:10:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 17:10:25 +0000 Subject: [Koha-bugs] [Bug 23719] Record matching for authorities using defined fields is broken under ES In-Reply-To: <bug-23719-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23719-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23719-70-JZrGHNJPMh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23719 --- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 18:10:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 17:10:27 +0000 Subject: [Koha-bugs] [Bug 23774] When placing a hold editing using Inspect Element allows addition to the code of non listed library In-Reply-To: <bug-23774-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23774-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23774-70-jvLPK0N1He@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23774 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 18:10:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 17:10:29 +0000 Subject: [Koha-bugs] [Bug 23774] When placing a hold editing using Inspect Element allows addition to the code of non listed library In-Reply-To: <bug-23774-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23774-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23774-70-lBC8B4k5aN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23774 --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 18:10:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 17:10:31 +0000 Subject: [Koha-bugs] [Bug 23968] OPACMySummaryNote does not work In-Reply-To: <bug-23968-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23968-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23968-70-tJxx9fX41E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23968 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 18:10:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 17:10:33 +0000 Subject: [Koha-bugs] [Bug 23968] OPACMySummaryNote does not work In-Reply-To: <bug-23968-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23968-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23968-70-ZP0SilCw7k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23968 --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 18:13:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 17:13:02 +0000 Subject: [Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace In-Reply-To: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23414-70-nUtcYcvUcc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |jonathan.druart at bugs.koha-c |y.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 18:14:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 17:14:38 +0000 Subject: [Koha-bugs] [Bug 21406] Not adding author to request can cause JS errors In-Reply-To: <bug-21406-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21406-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21406-70-9FcI3SqnOS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21406 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to oldstable --- Comment #10 from Lucas Gass <lucas at bywatersolutions.com> --- backported to 18.11.x for 18.11.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 18:16:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 17:16:01 +0000 Subject: [Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace In-Reply-To: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23414-70-JumB6QJu4G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 --- Comment #31 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Well done getting this one over the finish line just in time for the freeze guys. I was about to update it to rel_20_05_target when I spotted the diligent final QAing.. Thanks! Looks good, clarifies things and improves performance, Pushing :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 18:16:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 17:16:47 +0000 Subject: [Koha-bugs] [Bug 22677] Include hint on OAI-PMH URL for Koha in system preference In-Reply-To: <bug-22677-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22677-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22677-70-4qpQejeeKT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22677 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 18:16:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 17:16:49 +0000 Subject: [Koha-bugs] [Bug 22677] Include hint on OAI-PMH URL for Koha in system preference In-Reply-To: <bug-22677-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22677-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22677-70-kHfrFZVmkq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22677 --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 18:16:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 17:16:50 +0000 Subject: [Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace In-Reply-To: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23414-70-PSo36W459h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 18:16:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 17:16:52 +0000 Subject: [Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace In-Reply-To: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23414-70-AXHYGNR102@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 --- Comment #32 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 18:17:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 17:17:18 +0000 Subject: [Koha-bugs] [Bug 23981] New: Inconsistencies with the different prices Message-ID: <bug-23981-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23981 Bug ID: 23981 Summary: Inconsistencies with the different prices Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org I was investigating bug 18639 and I came across some inconsistencies in the prices, where they are used, the calculations, etc. To reproduce : (Note: my vendor setting is "tax excluded" for both list and invoice price, I tried with different settings and as far as I can tell, the result is the same) 1- Create a new basket 2- Add an order 3- In the financial details, enter the following informations (I know it doesn't make sense IRL, but we are entering different prices just to see what goes where): - Vendor price: 10.99 - Tax rate: 0% - Discount: 0% - Retail price: 12.99 - Replacement cost: 15.99 - Actual cost: 18.99 4- Note that Budgeted cost and Total are based on *vendor* price (10.99) 5- Save your order 6- If you have access to your database, check the info that is entered (if you don't have access to your database, you can do an SQL report with the following query SELECT * from aqorders where basketno = X; Substitute de X for your basket number My db shows the following: listprice: 10.990000 unitprice: 18.990000 rrp: 12.99 replacementprice: 15.990000 rrp_tax_excluded: 12.990000 rrp_tax_included: 12.990000 ecost: 10.99 ecost_tax_excluded: 12.990000 ecost_tax_included: 12.990000 Note that the ecost_tax_excluded and ecost_tax_included are not based on ecost, but on rrp. 7- Go back to acquisitions home page and click on the amount ordered in your budget 8- Find your order and note that the estimated cost per unit is the retail price (12.99), not the vendor price (10.99) and not the budgeted cost as calculated during the order (10.99). 9- Close the basket 10- Receive the order 11- On the receipt summary page (which lists all the items yet to be received), the unit cost is the retail price (12.99) and the replacement cost is correct 12- On the item receiving page, the retail price is correct, the replacement price is correct, the budgeted cost is the retail price not the vendor price (listprice) nor the budgeted cost calculated during the order (ecost), the actual price is correct. 13- In the already received page, the prices are correct 14- In the "Spent column" of the budget, the price taken out of the fund is the actual price, which is correct. Summary: - The vendor price/listprice is not used anywhere else than during the first step of the order - The budgeted cost (ecost) is based on the retail price, the order form needs to reflect that Propositions: - Unless there is a good reason to keep it (like someone wanting to discriminate between how much the vendor sells it vs how much another vendor might sell it), I would remove the vendor price completely and replace it with the retail price - Correct the order form to show the real estimated price, based on the retail price - Correct the db calculations to make sure the ecost is based on the rrp and that the tax are calculated on the ecost I'm sorry if this is all over the place, hopefully by following the steps, you will see what I mean. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 18:17:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 17:17:31 +0000 Subject: [Koha-bugs] [Bug 22677] Include hint on OAI-PMH URL for Koha in system preference In-Reply-To: <bug-22677-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22677-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22677-70-ZB1mFyuDS4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22677 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy, | |rel_19_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 18:17:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 17:17:48 +0000 Subject: [Koha-bugs] [Bug 23981] Inconsistencies with the different prices In-Reply-To: <bug-23981-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23981-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23981-70-EZecYnTBrC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23981 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |martin.renvoize at ptfs-europe | |.com, | |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 18:17:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 17:17:59 +0000 Subject: [Koha-bugs] [Bug 23981] Inconsistencies with the different prices In-Reply-To: <bug-23981-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23981-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23981-70-cE1Q1aDiAg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23981 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 18:20:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 17:20:16 +0000 Subject: [Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace In-Reply-To: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23414-70-FUiwAgcREU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_19_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 18:20:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 17:20:41 +0000 Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23354-70-z9f32LbYF2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_19_11_candidate |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 18:21:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 17:21:13 +0000 Subject: [Koha-bugs] [Bug 23050] Plugins: Add hook to add a tab in intranet biblio details page In-Reply-To: <bug-23050-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23050-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23050-70-EcBNSJ49UO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23050 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_19_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 18:21:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 17:21:22 +0000 Subject: [Koha-bugs] [Bug 23522] Show "Actual price" in basket when available In-Reply-To: <bug-23522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23522-70-kbDySyJGXG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23522 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_19_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 18:21:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 17:21:59 +0000 Subject: [Koha-bugs] [Bug 23075] Incorrect URL should have a meaningful error message In-Reply-To: <bug-23075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23075-70-P0zIfR0E7l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23075 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_19_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 18:22:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 17:22:21 +0000 Subject: [Koha-bugs] [Bug 23774] When placing a hold editing using Inspect Element allows addition to the code of non listed library In-Reply-To: <bug-23774-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23774-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23774-70-XfclAz0D8t@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23774 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_19_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 18:22:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 17:22:28 +0000 Subject: [Koha-bugs] [Bug 23467] Duplicated screen if error in opac-reserve.pl In-Reply-To: <bug-23467-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23467-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23467-70-RdCyOPFDwI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23467 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Keywords|rel_19_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 18:23:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 17:23:15 +0000 Subject: [Koha-bugs] [Bug 23051] Optionally renew fine accruing items when all fines on item are paid off In-Reply-To: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23051-70-l3u1K1wKqk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_19_11_candidate |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 18:31:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 17:31:14 +0000 Subject: [Koha-bugs] [Bug 23981] Inconsistencies with the different prices In-Reply-To: <bug-23981-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23981-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23981-70-RoEG2lfkZ5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23981 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Another thing I noticed, when importing files into a basket, the fields are simply labeled "Price" and "Replacement price". Price is copied into every db field that is not replacementprice (rrp, ecost, listprice, unitprice, etc), so there is no risk of confusion here. However, we might want to relabel it Retail price? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 18:31:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 17:31:52 +0000 Subject: [Koha-bugs] [Bug 23695] Items holdingbranch should be set to the originating library when generating a manual transfer In-Reply-To: <bug-23695-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23695-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23695-70-Xr20kcdoT5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23695 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_19_11_candidate |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 18:34:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 17:34:13 +0000 Subject: [Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search In-Reply-To: <bug-21249-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21249-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21249-70-RiIJVGeFA7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_19_11_candidate |rel_20_05_target CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 18:35:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 17:35:19 +0000 Subject: [Koha-bugs] [Bug 23981] Inconsistencies with the different prices In-Reply-To: <bug-23981-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23981-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23981-70-JXQ2bojGxI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23981 --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Created attachment 95118 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95118&action=edit Screenshot showing the price fields Sorry again, just a minor thing. I noticed there is not prefilled "0.00" in the retail price field as there is with other price fields. See attached screenshot -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 18:36:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 17:36:04 +0000 Subject: [Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search In-Reply-To: <bug-21249-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21249-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21249-70-9xmlMPpKow@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249 --- Comment #21 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Would love to see this picked back up near the beginning of the next cycle.. I'm afraid it's just missed the freeze for 19.11 :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 18:38:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 17:38:53 +0000 Subject: [Koha-bugs] [Bug 23470] Elasticsearch - OpacSuppression not implemented in search result In-Reply-To: <bug-23470-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23470-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23470-70-KfVxltQqHR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23470 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ere.maijala at helsinki.fi --- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Marjorie Barry-Vila from comment #13) > (In reply to Katrin Fischer from comment #11) > > Hi Caroline, I think if it works for for Nick but not for you, we need to > > look for the difference... > > > > What version of Koha are they running? > > Is there a way to confirm that the suppress index is configured and filled? > > Hi Katrin, > > Have you been able to watch Caroline's last comment? > I have another client reporting the same problem and everything seems well > configured for the suppress index. > > Regards, > Marjorie Hi Marjorie, I am actually not a Elasticsearch expert, but have tried to help narrow it down and get he experts to take a look. Last I had talked to Nick in Marseille about it - adding both Nick and Ere in hope they have a minute and some new ideas. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 18:42:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 17:42:53 +0000 Subject: [Koha-bugs] [Bug 23868] PayPal payment button is never enabled In-Reply-To: <bug-23868-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23868-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23868-70-KlNvR2HkKi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23868 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 18:42:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 17:42:56 +0000 Subject: [Koha-bugs] [Bug 23868] PayPal payment button is never enabled In-Reply-To: <bug-23868-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23868-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23868-70-ETQJ921ouq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23868 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95066|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 95119 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95119&action=edit Bug 23868: Check if threshold is undefined in javascript block of opac-account.tt This patch fixes a bug introduced by checking payment plugins threshold To test: 1. do not apply this patch 2. configure paypal options in intranet 3. create a manual invoice for a patron 4. in opac try to pay that invoice CHECK => Make Payment button is disabled, even when invoices where checked. 5. apply this patch 6. repeat step 4 SUCCESS => Make Payment button is enabled when an invoice is checked. 7. Sign off Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 18:43:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 17:43:20 +0000 Subject: [Koha-bugs] [Bug 23868] PayPal payment button is never enabled In-Reply-To: <bug-23868-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23868-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23868-70-aUjEs0Z7LQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23868 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|String patch |Trivial patch --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Just changing: String patch = Interface/GUI strings, changing to Trivial. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 18:59:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 17:59:49 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23260-70-aurJ0xHaue@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Agustín Moyano <agustinmoyano at theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 19:13:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 18:13:26 +0000 Subject: [Koha-bugs] [Bug 19718] Create message for patrons with multiple holds on the same item In-Reply-To: <bug-19718-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19718-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19718-70-K0GVUTxuhW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19718 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92489|0 |1 is obsolete| | --- Comment #5 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 95120 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95120&action=edit Bug 19718: Show message if patron has existing holds on a title To test: 1 - Set a rule to allow multiple holds on a title 2 - Place a single hold in the opac for a patron 3 - Return to record and attempt place a second hold 4 - Note there is no message but that you must match the type placed before (item or record level) 5 - Don't place the hold 6 - Apply patch 7 - Attempt to place second hold again 8 - Note there is a message informing you of which level hold you may place 9 - Test with both item/record level holds and placing a single request or multiple requests Signed-off-by: donnab <donna at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 19:20:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 18:20:30 +0000 Subject: [Koha-bugs] [Bug 23600] Library group search broken in advanced search In-Reply-To: <bug-23600-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23600-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23600-70-dsPnwAbdRd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23600 --- Comment #2 from Andres Ovalle <aovalle at biteca.com> --- (In reply to Katrin Fischer from comment #1) > How many libraried did you group? Can you share the URL by chance? > > From the error it sounds like the search link generated got too long. Hello, Indeed it happens because the library group is very large, there are about 800 libraries within the group. Here is the OPAC URL, however the problem also occurs in the administrative cataloging interface. https://catalogo.patrimoniofilmico.org.co/ Select the "Inventario" group that appears at the end of the search box per library. In the list of results go to the second page. Thanks Andrés, -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 19:41:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 18:41:15 +0000 Subject: [Koha-bugs] [Bug 23293] OPACFineNoRenewals compares against 'balance' not 'outstanding' In-Reply-To: <bug-23293-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23293-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23293-70-MCyo4gwCGF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23293 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 19:44:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 18:44:00 +0000 Subject: [Koha-bugs] [Bug 23293] OPACFineNoRenewals compares against 'balance' not 'outstanding' In-Reply-To: <bug-23293-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23293-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23293-70-wkGvWeFowr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23293 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 19:44:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 18:44:03 +0000 Subject: [Koha-bugs] [Bug 23293] OPACFineNoRenewals compares against 'balance' not 'outstanding' In-Reply-To: <bug-23293-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23293-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23293-70-6uJqCSN3MN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23293 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93149|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 19:44:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 18:44:05 +0000 Subject: [Koha-bugs] [Bug 23293] OPACFineNoRenewals compares against 'balance' not 'outstanding' In-Reply-To: <bug-23293-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23293-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23293-70-rdfOvKF5kz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23293 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93150|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 19:44:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 18:44:07 +0000 Subject: [Koha-bugs] [Bug 23293] OPACFineNoRenewals compares against 'balance' not 'outstanding' In-Reply-To: <bug-23293-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23293-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23293-70-Ih4pzw3RHW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23293 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93151|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 19:48:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 18:48:47 +0000 Subject: [Koha-bugs] [Bug 23600] Library group search broken for group with a big number of libraries In-Reply-To: <bug-23600-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23600-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23600-70-UDqmnhXAEl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23600 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Library group search broken |Library group search broken |in advanced search |for group with a big number | |of libraries --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Andres Ovalle from comment #2) > (In reply to Katrin Fischer from comment #1) > > How many libraried did you group? Can you share the URL by chance? > > > > From the error it sounds like the search link generated got too long. > > Hello, > > Indeed it happens because the library group is very large, there are about > 800 libraries within the group. > > Here is the OPAC URL, however the problem also occurs in the administrative > cataloging interface. > > https://catalogo.patrimoniofilmico.org.co/ > > Select the "Inventario" group that appears at the end of the search box per > library. > > In the list of results go to the second page. > > Thanks > > Andrés, Hi Andres, I really think it's the number of libraries, but don't see a Group Inventario - or another group - on your Advanced search? Btw, love the OPAC design. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 19:48:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 18:48:47 +0000 Subject: [Koha-bugs] [Bug 23293] OPACFineNoRenewals compares against 'balance' not 'outstanding' In-Reply-To: <bug-23293-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23293-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23293-70-RZe7cLciQv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23293 --- Comment #12 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 95121 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95121&action=edit Bug 23293: Add system preference Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 19:48:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 18:48:51 +0000 Subject: [Koha-bugs] [Bug 23293] OPACFineNoRenewals compares against 'balance' not 'outstanding' In-Reply-To: <bug-23293-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23293-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23293-70-Otsa3gDJXw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23293 --- Comment #13 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 95122 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95122&action=edit Bug 23293: Apply OPACFineNoRenewalsIncludeCredit preference Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 19:48:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 18:48:54 +0000 Subject: [Koha-bugs] [Bug 23293] OPACFineNoRenewals compares against 'balance' not 'outstanding' In-Reply-To: <bug-23293-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23293-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23293-70-aaQJSv6zmr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23293 --- Comment #14 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 95123 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95123&action=edit Bug 23293: (follow-up) Add tests for C4::Circulation change Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 19:48:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 18:48:57 +0000 Subject: [Koha-bugs] [Bug 23293] OPACFineNoRenewals compares against 'balance' not 'outstanding' In-Reply-To: <bug-23293-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23293-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23293-70-XnXmfWgxYR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23293 --- Comment #15 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 95124 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95124&action=edit Bug 23293: (QA follow-up) Minor fix for tests Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 20:08:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 19:08:55 +0000 Subject: [Koha-bugs] [Bug 23600] Library group search broken for group with a big number of libraries In-Reply-To: <bug-23600-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23600-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23600-70-aJKHm0HDhb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23600 --- Comment #4 from Andres Ovalle <aovalle at biteca.com> --- (In reply to Katrin Fischer from comment #3) > (In reply to Andres Ovalle from comment #2) > > (In reply to Katrin Fischer from comment #1) > > > How many libraried did you group? Can you share the URL by chance? > > > > > > From the error it sounds like the search link generated got too long. > > > > Hello, > > > > Indeed it happens because the library group is very large, there are about > > 800 libraries within the group. > > > > Here is the OPAC URL, however the problem also occurs in the administrative > > cataloging interface. > > > > https://catalogo.patrimoniofilmico.org.co/ > > > > Select the "Inventario" group that appears at the end of the search box per > > library. > > > > In the list of results go to the second page. > > > > Thanks > > > > Andrés, > > Hi Andres, I really think it's the number of libraries, but don't see a > Group Inventario - or another group - on your Advanced search? Btw, love the > OPAC design. Hello, The simple search also occurs by searching for the Inventory library group at the end of the library list. Could you see the following link? https://www.dropbox.com/s/13ns9icyx4cnnu7/Nov-06-2019%2014-01-26.mp4?dl=0 The OPAC design has been stylized to look like the institutional site Thanks, Andrés, -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 20:19:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 19:19:18 +0000 Subject: [Koha-bugs] [Bug 23949] koha-common.init missing actions for koha-z3950-responder In-Reply-To: <bug-23949-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23949-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23949-70-wfRmc8gyDh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 --- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 95125 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95125&action=edit Bug 23949: Add z3950 directory to koha-common.install Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 20:27:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 19:27:52 +0000 Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference In-Reply-To: <bug-18532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18532-70-2EtDtsWLl0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #8 from Chris Cormack <chris at bigballofwax.co.nz> --- Comment on attachment 95031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95031 Bug 18532: set auto_renewals as patron messaging preference Review of attachment 95031: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18532&attachment=95031) ----------------------------------------------------------------- ::: misc/cronjobs/automatic_renewals.pl @@ +2,4 @@ > > # This file is part of Koha. > # > +# Copyright (C) 2014 Hochschule f�r Gesundheit (hsg), Germany This looks like a typo, can you fix please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 20:39:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 19:39:42 +0000 Subject: [Koha-bugs] [Bug 23600] Library group search broken for group with a big number of libraries In-Reply-To: <bug-23600-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23600-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23600-70-GRLekEsrHY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23600 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I can see the link but for me the list ends at ENTIDAD THE PRUEBA in Firefox and Chromium. Can you check, if you see the same when using the catalog without logging in first? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 20:41:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 19:41:36 +0000 Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference In-Reply-To: <bug-18532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18532-70-aL6IVztVuO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Comment on attachment 95031 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95031 Bug 18532: set auto_renewals as patron messaging preference Review of attachment 95031: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=18532&attachment=95031) ----------------------------------------------------------------- ::: misc/cronjobs/automatic_renewals.pl @@ +2,4 @@ > > # This file is part of Koha. > # > +# Copyright (C) 2014 Hochschule f�r Gesundheit (hsg), Germany It looks like maybe the encoding of the file was changed? it Should be reading "für". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 21:01:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 20:01:52 +0000 Subject: [Koha-bugs] [Bug 23982] New: Count/pagination broken for reports with duplicated column names Message-ID: <bug-23982-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23982 Bug ID: 23982 Summary: Count/pagination broken for reports with duplicated column names Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org bug 23624 simplified how we get the count of rows in a report, however, it breaks under certain circumstances. A report like: SELECT * FROM issues JOIN borrowers USING (borrowernumber) will have two borrowernumber columns - SQL will give us there rsults, but if we try to wrap them in a SELECT COUNT(*) FROM (report) it throws a duplicated column error. I don't know an easy fix except to state that one must name the columns they want to avoid duplication -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 21:02:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 20:02:24 +0000 Subject: [Koha-bugs] [Bug 23982] Count/pagination broken for reports with duplicated column names In-Reply-To: <bug-23982-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23982-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23982-70-5ay42bNntf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23982 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |kelly at bywatersolutions.com, | |martin.renvoize at ptfs-europe | |.com, tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 21:59:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 20:59:12 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX) In-Reply-To: <bug-11299-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11299-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11299-70-ccq67gwfAH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Bouzid Fergani <bouzid.fergani at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 21:59:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 20:59:16 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX) In-Reply-To: <bug-11299-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11299-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11299-70-ibEqYFCXm4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Bouzid Fergani <bouzid.fergani at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94818|0 |1 is obsolete| | --- Comment #102 from Bouzid Fergani <bouzid.fergani at inlibro.com> --- Created attachment 95126 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95126&action=edit Bug 11299 - Add a button to the biblio edition page to automatically add authority links in the current biblio record via AJAX. Also adds a button to easily create missing authority records. add authority type in the form to create the missing authority. when authority was found, the 600$9 field have the authid. Testing scenario (Creating an authority record for a failed automatic link) : * In you system preferences, deactivate the "AutoCreateAuthorities" preference. * Go to the biblio record creation form to create a new biblio record. (koha/cataloguing/addbiblio.pl) * Click the "Link authorities automatically" button. A message should appear, telling the user "No authority link was changed." * Add random informations in field 600$a of the biblio record. * Click the "Link authorities automatically" button. * if matching authority was found, The message box should now show "600 - A matching authority was found in the local database". * if no matching authority was found, the message box should now show "600 - No matching authority found.". For this scenario, we want the authority match to have failed. * The 600$9 field should now be red and icons should have appeared next to it. Click on the "create authority" icon. * A popup will appear, containing a form to create the missing authority. The form should be pre-filled, a the informations in the 600$a field of the biblio should be in the 100$a field of this new authority record. * Fill in the form and click the "Save" button * The 600$9 field in the biblio record should now be back to normal and have the authid of the authority record that was just created. * Click the "Link authorities automatically" button again. The message box should now show "No authority link was changed.". Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> https://bugs.koha-community.org/show_bug.cgi?id=12299 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 22:01:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 21:01:35 +0000 Subject: [Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results In-Reply-To: <bug-7611-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7611-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7611-70-5XyZYmsskn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611 --- Comment #30 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Nick Clemens from comment #27) > Okay, I reviewed this, what it does is that: > Available doesn't change > Items marked 'not for loan' at itemtype level go into 'Available for > reference' > Items marked 'not for loan' individually, whether negative or positive, are > displayed in the 'unavailable' section with the description of the 'not for > loan' status showing. > > If you have several not for loan statuses with the same description, e.g. > 'Available for reference' then they will be displayed together in the > unavailable section > > It also adds some classes and styling to allow for the end user to adjust > using css/jquery > > I am attaching a smaple record as described in the test plan which you can > import if using the default database. You will need to add a 'NOT_LOAN' > value of 4 with opac description 'Ordered' to see it in operation Hi Nick, first: thank you for the summary! Second: I am sorry, it just doesn't feel quite right yet to me :( I am trying to put into words, but please feel free to get others opinions as well. >Items marked 'not for loan' at itemtype level go into 'Available for reference' >Items marked 'not for loan' individually, whether negative or positive, are displayed in the 'unavailable' section with the >description of the 'not for loan' status showing 1) We have built on the fact that the not-for-loan works the same on item type as on individual level and I think this change might be controversial. With the patch, itype level 'not for loan' is green, but individual show red = different messages. Koha defines available as 'on the shelf' not as 'loanable' in my understanding - so green seems the better default choice. 2) The display with the extra break looks like we are missing a label (I think it's intended, but that's the impression I get): Availability: Items available for loan: Midway (1). Centerville Staff Collection (1). Or with some more items: Availability: Items available for loan: Centerville (1). Items available for reference: Centerville (1). Centerville Staff Collection (1). Damaged (1). I think I'd opt for removing the line break and always displaying the "Itmes available for reference:" when there is at least one item with a not for loan value. That would mean the first example would look like this: Availability: Items available for loan: Midway (1). Items available for reference: Centerville Staff Collection (1). And the second could be like this, using a comma between different values: Availability: Items available for loan: Centerville (1). Items available for reference: Centerville (1), Centerville Staff Collection (1). Damaged (1). Just notes (no lockers at all): I see that you use individual CSS classes on the items, I like that. Just wondering: currently we use the description, so a description change will mean the CSS needs to change as well. On the other side: not for loan values are numeric and we are grouping the onces with the same name and I like that - so that's probably the best way. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 22:01:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 21:01:42 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX) In-Reply-To: <bug-11299-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11299-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11299-70-F1P0JPWOVG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 --- Comment #103 from Bouzid Fergani <bouzid.fergani at inlibro.com> --- Hi Michal, I fixed the problem for import z3950. Thanks. Bouzid. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 22:23:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 21:23:58 +0000 Subject: [Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized In-Reply-To: <bug-22381-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22381-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22381-70-LqZFlmcySh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94925|0 |1 is obsolete| | --- Comment #6 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 95127 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95127&action=edit Bug 22381: Change wording on Calendar-related system preferences Signed-off-by: Lisette Scheer <lisetteslatah at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 22:24:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 21:24:06 +0000 Subject: [Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized In-Reply-To: <bug-22381-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22381-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22381-70-UQnOvDuYBW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Lisette Scheer <lisetteslatah at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 23:25:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 22:25:02 +0000 Subject: [Koha-bugs] [Bug 23983] New: Contextualization of "Order" (verb) vs "Order" (noun) Message-ID: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23983 Bug ID: 23983 Summary: Contextualization of "Order" (verb) vs "Order" (noun) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr In French, the words for "Order" (verb) and "Order" (noun) are slightly different. We need to add contextualization (as added in 15395) to some acquisitions tt files. I looked through the acqui tt files and listed all the files where the word "Order" is alone (without a sentence for context) basket.tt neworderbiblio.tt newordersubscription.tt newordersuggestion.tt order.tt parcel.tt spent.tt transferorder.tt uncertainprice.tt z3950_search.tt -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 6 23:34:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 22:34:49 +0000 Subject: [Koha-bugs] [Bug 21939] Permission for holds history tab is too strict In-Reply-To: <bug-21939-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21939-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21939-70-gH2MVoEkhs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94991|0 |1 is obsolete| | --- Comment #5 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 95128 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95128&action=edit Bug 21939: Fix permissions for holds history tab The tab will show when the staff user has edit_borrowers permission, but the page itself will not be accessible. This patch fixes the page permissions to allow access with the edit_borrowers permission as suggested by the comments on the original bug report. To test: - Create a staff user with only "edit_borrowers" permission from the borrowers module - Try to access the holds history tab from any patron account - Verify you are blocked - Apply patch - Try again and verify the page is accessible now - Repeat with superlibrarian and full borrowers permission. Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> Signed-off-by: Bob Bennhoff <bbennhoff at clicweb.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 00:27:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 23:27:05 +0000 Subject: [Koha-bugs] [Bug 23983] Contextualization of "Order" (verb) vs "Order" (noun) In-Reply-To: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23983-70-lt4SegSvS3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23983 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 00:27:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 06 Nov 2019 23:27:08 +0000 Subject: [Koha-bugs] [Bug 23983] Contextualization of "Order" (verb) vs "Order" (noun) In-Reply-To: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23983-70-TmC5OFWjQE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23983 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Created attachment 95129 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95129&action=edit Bug 23983: Contextualization of 'Order' (verb) vs 'Order' (noun) This patch adds context (word class, either verb or noun) to the word 'Order' when it is displayed alone in the acquisitions module. The following files have been modified: basket.tt neworderbiblio.tt newordersubscription.tt newordersuggestion.tt ordered.tt parcel.tt spent.tt transferorder.tt uncertainprice.tt z3950_search.tt To test, check all those pages in English to make sure there is no change. 1- Go to Acquisitions 2- Create a basket 3- Add to basket from an existing record (neworderbiblio) 4- Add to basket from a subscription (newordersubscription) 5- Add to basket from a suggestion (newordersuggestion) 6- Add to basket from an external source (z3950_search) 7- In one of the orders, check the uncertain price box 8- Check the basket display table (basket) 9- Click transfer on one of the orders (transferorder) 10- Go to the vendor page and click on 'Uncertain prices' (uncertainprice) 11- Click on 'Receive parcel' (parcel) 12- Go to the Acquisitions home page and click on the amount for 'ordered' (ordered) 13- Go to the Acquisitions home page and click on the amount for 'spent' (spent) Next, install a new language (fr-CA used as example) 1- translate create fr-CA 2- open fr-CA-messages.po and add a translation for Order (verb) and Order (noun) (it doesn't have to be real, just write something different for each) 3- translate install fr-CA 4- in the system preferences, enable the french language in 'language' 5- change interface language to french Redo the tests above to make sure the word you put in the translation for the verb is in the places where 'Order' should be a verb and that the translation you put in for the noun is in the places where 'Order' should be a noun -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 01:42:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 00:42:55 +0000 Subject: [Koha-bugs] [Bug 21582] Use CodeMirror for *UserJS & *UserCSS In-Reply-To: <bug-21582-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21582-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21582-70-t6uJMeANec@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21582 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #24 from David Cook <dcook at prosentient.com.au> --- This makes me so happy. I was just about to open a bug report for this, as this would substantially improve my life 😅. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 03:37:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 02:37:01 +0000 Subject: [Koha-bugs] [Bug 21608] Arranging holds priority with dropdowns is faulty when there are waiting/intransit holds In-Reply-To: <bug-21608-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21608-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21608-70-jyvOPwOwBr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21608 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #39 from David Cook <dcook at prosentient.com.au> --- _FixPriority seems horrifically broken. I was really hoping that someone else had already fixed it... heh -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 03:42:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 02:42:58 +0000 Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions In-Reply-To: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22784-70-8svZM6F4QZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|Seeking developer |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 04:10:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 03:10:41 +0000 Subject: [Koha-bugs] [Bug 23960] Issue with MariaDB version (rows column name in creator_template table) In-Reply-To: <bug-23960-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23960-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23960-70-4j2IgnSUYp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23960 Amit Gupta <amitddng135 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chrish at catalyst.net.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 09:06:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 08:06:38 +0000 Subject: [Koha-bugs] [Bug 23983] Contextualization of "Order" (verb) vs "Order" (noun) In-Reply-To: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23983-70-NDNU9Nm4UT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23983 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |julian.maurice at biblibre.com --- Comment #2 from Julian Maurice <julian.maurice at biblibre.com> --- The patch works well, but the QA script complains about missing filters in template. Instead of [% tp('noun', 'Order') %] you have to write [% tp('noun', 'Order') | html %] -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 09:13:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 08:13:51 +0000 Subject: [Koha-bugs] [Bug 23827] Cash register statistics uses old accounttype values In-Reply-To: <bug-23827-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23827-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23827-70-bPYlGedPhS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23827 --- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95130 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95130&action=edit Bug 23827: Correction for missed 'F' and 'FU' case When replacing F and FU with 'OVERDUE' + status in bug 22521 I missed the cases inside the cash_register_stats template. This patch should correct that mistake. Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 09:14:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 08:14:14 +0000 Subject: [Koha-bugs] [Bug 23827] Cash register statistics uses old accounttype values In-Reply-To: <bug-23827-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23827-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23827-70-1TVgLK5YnK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23827 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94305|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 09:14:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 08:14:57 +0000 Subject: [Koha-bugs] [Bug 23827] Cash register statistics uses old accounttype values In-Reply-To: <bug-23827-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23827-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23827-70-xAJEviLQVf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23827 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off --- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- It applies to 19.05 fine for me.. this bug is for 19.05.x (and below) only. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 09:15:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 08:15:57 +0000 Subject: [Koha-bugs] [Bug 19014] Patrons should not get an 'on_reserve' notification if the due date is far into the future In-Reply-To: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19014-70-qCV5CkCY6q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Patrons should not get a |Patrons should not get an |on_reserve notification if |'on_reserve' notification |the due date is far into |if the due date is far into |the future |the future CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 09:21:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 08:21:31 +0000 Subject: [Koha-bugs] [Bug 19014] Patrons should not get an 'on_reserve' notification if the due date is far into the future In-Reply-To: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19014-70-ui6rz4FAOL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 09:22:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 08:22:13 +0000 Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in In-Reply-To: <bug-7376-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7376-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7376-70-zoDgRMnPMK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 09:44:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 08:44:27 +0000 Subject: [Koha-bugs] [Bug 22831] Elasticsearch - add a maintenance script for checking DB vs index counts In-Reply-To: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22831-70-NMQxiC7TVN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #11 from Ere Maijala <ere.maijala at helsinki.fi> --- The url is a nice touch! A few issues remain, though: 1.) I'd still fetch the base urls outside the loop. Would improve readability and avoid repeated pref calls. 2.) For authorities, the OPAC URLs are now invalid. They should be something like [...]/cgi-bin/koha/opac-authoritiesdetail.pl?authid=123. 3.) The patch for PerlDependencies.pl is borked. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 09:51:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 08:51:56 +0000 Subject: [Koha-bugs] [Bug 8292] clicking ignore on hold cancels transfer In-Reply-To: <bug-8292-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8292-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8292-70-Ec8r9SjlSq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8292 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Kyle, I had a quick go at rescuing this one but I wasn't confident in my rebase. Could you take a look and get it rebased...? We could also do with some tests for the C4::Circualation change, but I'm happy to work on those as a QA/RM followup if it helps move this along a bit? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 09:52:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 08:52:18 +0000 Subject: [Koha-bugs] [Bug 8292] clicking ignore on hold cancels transfer In-Reply-To: <bug-8292-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8292-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8292-70-T5aS9lXc1m@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8292 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 09:53:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 08:53:36 +0000 Subject: [Koha-bugs] [Bug 7376] Transfer limits should be checked at check-in In-Reply-To: <bug-7376-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7376-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7376-70-wLlrItu0SO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7376 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 10:02:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 09:02:53 +0000 Subject: [Koha-bugs] [Bug 13958] Add a suspensionsCalendar syspref In-Reply-To: <bug-13958-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13958-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13958-70-jJc2ibRGln@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13958 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90118|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95131 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95131&action=edit Bug 13958: Add SuspensionsCalendar syspref Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 10:02:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 09:02:56 +0000 Subject: [Koha-bugs] [Bug 13958] Add a suspensionsCalendar syspref In-Reply-To: <bug-13958-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13958-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13958-70-Odgr3Y1vsy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13958 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90119|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95132 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95132&action=edit Bug 13958: Use SuspensionsCalendar syspref for more granularity This patch makes the calculation of suspension expiration configuration detached from the finesCalendar syspref. This way libraries have more flexibility when setting circ rules. I wrote this path as a bugfix, because the recent change pushed by bug 19204 changed this behavior and libraries have been complaining since they got upgraded. It is a minor change, just adding the new syspref, and replacing the single place in which it is used for debarment calculation for the new one. The tests are updated similarly, just adding the new mocked syspref as it was with the old one. To test: - Apply this patches - updatedatabase - Run: $ kshell k$ prove t/db_dependent/Circulation.t => SUCCESS: Tests pass! - Sign off :-D Sponsored-by: Universidad Nacional de Córdoba Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 10:06:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 09:06:20 +0000 Subject: [Koha-bugs] [Bug 13958] Add a suspensionsCalendar syspref In-Reply-To: <bug-13958-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13958-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13958-70-XbNOE8GjUk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13958 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Passed QA CC| |martin.renvoize at ptfs-europe | |.com --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- This works as expected for me, and I'm pleased that the DB update takes the original settings into account. Trivial patch, passing QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 10:09:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 09:09:16 +0000 Subject: [Koha-bugs] [Bug 23868] PayPal payment button is never enabled In-Reply-To: <bug-23868-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23868-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23868-70-kHLy39PT7i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23868 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |katrin.fischer at bsz-bw.de |y.org | CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 10:12:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 09:12:39 +0000 Subject: [Koha-bugs] [Bug 13958] Add a suspensionsCalendar syspref In-Reply-To: <bug-13958-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13958-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13958-70-oZgd4Ye1OU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13958 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 10:12:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 09:12:41 +0000 Subject: [Koha-bugs] [Bug 13958] Add a suspensionsCalendar syspref In-Reply-To: <bug-13958-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13958-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13958-70-l1nfVVUxpo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13958 --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 10:12:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 09:12:43 +0000 Subject: [Koha-bugs] [Bug 23868] PayPal payment button is never enabled In-Reply-To: <bug-23868-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23868-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23868-70-GPswz6vXnL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23868 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 10:12:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 09:12:45 +0000 Subject: [Koha-bugs] [Bug 23868] PayPal payment button is never enabled In-Reply-To: <bug-23868-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23868-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23868-70-fgnngncPDd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23868 --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 10:16:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 09:16:53 +0000 Subject: [Koha-bugs] [Bug 23415] Notify patron fines when renewing In-Reply-To: <bug-23415-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23415-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23415-70-k474hEIaoJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Anneli Österman <anneli.osterman at koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |anneli.osterman at koha-suomi. | |fi --- Comment #4 from Anneli Österman <anneli.osterman at koha-suomi.fi> --- I also tried this patch on a sandbox and the alert was displayed on moremember.pl-page and renew.pl-page. It was not displayed on circulation.pl-page, where it should also appear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 10:19:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 09:19:53 +0000 Subject: [Koha-bugs] [Bug 11909] Fix hidelostitems, OpacHiddenItems total count, prog them facet display In-Reply-To: <bug-11909-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11909-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11909-70-vUeODZl1e8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11909 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |RESOLVED Resolution|--- |WORKSFORME CC| |martin.renvoize at ptfs-europe | |.com --- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Sounds like this one is resolved.. marking as such. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 10:23:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 09:23:25 +0000 Subject: [Koha-bugs] [Bug 23813] DB error on 18.12.00.020 In-Reply-To: <bug-23813-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23813-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23813-70-VCd8q5urDT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23813 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Going for PQA here, it's a simple patch that should only improve the situation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 10:23:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 09:23:57 +0000 Subject: [Koha-bugs] [Bug 23813] DB error on 18.12.00.020 In-Reply-To: <bug-23813-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23813-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23813-70-pWkEIv2v5Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23813 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 10:23:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 09:23:58 +0000 Subject: [Koha-bugs] [Bug 23813] DB error on 18.12.00.020 In-Reply-To: <bug-23813-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23813-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23813-70-tj4ElIJNgv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23813 --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 10:25:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 09:25:42 +0000 Subject: [Koha-bugs] [Bug 22988] Visible reduction in image quality In-Reply-To: <bug-22988-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22988-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22988-70-EKYqeXrFMy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22988 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 10:27:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 09:27:35 +0000 Subject: [Koha-bugs] [Bug 23949] koha-common.init missing actions for koha-z3950-responder In-Reply-To: <bug-23949-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23949-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23949-70-HKN3zmXjVG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 10:27:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 09:27:39 +0000 Subject: [Koha-bugs] [Bug 23949] koha-common.init missing actions for koha-z3950-responder In-Reply-To: <bug-23949-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23949-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23949-70-hprx9qw1d1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95028|0 |1 is obsolete| | Attachment #95068|0 |1 is obsolete| | Attachment #95125|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95133 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95133&action=edit Bug 23949: Add missing actions for koha-z3950-responder in koha-common.init This patch makes the init script deal with koha-z3950-responder in --stop and --restart actions. Currently, only --start calls the script. To test: - Enable the server: $ koha-z3950-responder --enable kohadev - Stop koha-common $ service koha-common stop => SUCCESS: No koha-z3950-responder running - Start koha-common $ service koha-common start => SUCCESS: It is loaded (even if failing because of config issues) - Stop koha-common $ service koha-common stop => FAIL: It is still running (no --stop issued) - Repeat for restart - Apply this patch - Redo => SUCCESS: Things behave as expected! - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 10:27:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 09:27:42 +0000 Subject: [Koha-bugs] [Bug 23984] New: Local cover 'thumbnail' size is bigger than 'imagefile' size in biblioimages table Message-ID: <bug-23984-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23984 Bug ID: 23984 Summary: Local cover 'thumbnail' size is bigger than 'imagefile' size in biblioimages table Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P3 Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: arouss1980 at gmail.com, jonathan.druart at bugs.koha-community.org, lucas at bywatersolutions.com, magnus at libriotech.no, martin.renvoize at ptfs-europe.com, nick at bywatersolutions.com, tomascohen at gmail.com Depends on: 21987 Blocks: 23963 The original resolution to this issue, bug 21987, caused a nasty regression and has since been reverted. Opening this bug so we may pursue a new route to goal. +++ This bug was initially created as a clone of Bug #21987 +++ We use local cover images in our setup, and also resize the covers we scan to a width of 160px before uploading and attaching them to a Koha bibliographic record (we upload one cover per biblio). While using phpMyAdmin to view the contents of the 'biblioimages' table (relevant screenshot here: https://imgur.com/a/cSEVLBI), we noticed that the size of the BLOBs for the 'thumbnail' column was in some cases twice as big as that of the 'imagefile' column. In fact, this happens for more than 50% of uploaded covers as you can see from the output of the SQL queries below: mysql> SELECT COUNT( * ) AS count FROM biblioimages WHERE LENGTH( thumbnail ) > ( LENGTH( imagefile ) * 2 ) ; +-------+ | count | +-------+ | 1356 | +-------+ mysql> SELECT COUNT( * ) AS count, SUM( LENGTH( imagefile ) ) AS images_size, SUM( LENGTH( thumbnail ) ) AS thumbnails_size FROM biblioimages ; +-------+-------------+-----------------+ | count | images_size | thumbnails_size | +-------+-------------+-----------------+ | 2347 | 68323933 | 115839686 | +-------+-------------+-----------------+ It would appear that for each 160px-wide JPG with 24-bit depth that we have uploaded, the 'imagefile' column has been populated with an PNG of 8-bit depth with the same dimensions as the uploaded file, whereas the 'thumbnail' column contains a 24-bit PNG image with a width reduced to 140 pixels. I've tracked down the creation of resized 24-bit PNGs to this code: https://github.com/Koha-Community/Koha/blob/master/C4/Images.pm#L182-L183 Do thumbnails for covers need to be true colour (24-bit) images? Also, why is it that _scale_image() returns an image of 8-bit depth if the source image's dimensions are less than 600x800? (i.e. when no resizing is performed) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21987 [Bug 21987] Local cover 'thumbnail' size is bigger than 'imagefile' size in biblioimages table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23963 [Bug 23963] Visible reduction in image quality -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 10:27:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 09:27:42 +0000 Subject: [Koha-bugs] [Bug 21987] Local cover 'thumbnail' size is bigger than 'imagefile' size in biblioimages table In-Reply-To: <bug-21987-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21987-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21987-70-iWznaoGdfH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21987 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23984 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23984 [Bug 23984] Local cover 'thumbnail' size is bigger than 'imagefile' size in biblioimages table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 10:27:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 09:27:43 +0000 Subject: [Koha-bugs] [Bug 23949] koha-common.init missing actions for koha-z3950-responder In-Reply-To: <bug-23949-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23949-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23949-70-e8S5mOXwa6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 --- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95134 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95134&action=edit Bug 23949: Update documentation Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 10:27:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 09:27:42 +0000 Subject: [Koha-bugs] [Bug 23963] Visible reduction in image quality In-Reply-To: <bug-23963-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23963-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23963-70-lMPYSjgo18@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23963 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23984 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23984 [Bug 23984] Local cover 'thumbnail' size is bigger than 'imagefile' size in biblioimages table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 10:27:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 09:27:47 +0000 Subject: [Koha-bugs] [Bug 23949] koha-common.init missing actions for koha-z3950-responder In-Reply-To: <bug-23949-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23949-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23949-70-WdFPawasvt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 --- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95135 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95135&action=edit Bug 23949: Add z3950 directory to koha-common.install Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 10:28:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 09:28:07 +0000 Subject: [Koha-bugs] [Bug 23984] Local cover 'thumbnail' size is bigger than 'imagefile' size in biblioimages table In-Reply-To: <bug-23984-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23984-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23984-70-7m46Ouy3Qu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23984 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|23963 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23963 [Bug 23963] Visible reduction in image quality -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 10:28:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 09:28:07 +0000 Subject: [Koha-bugs] [Bug 23963] Visible reduction in image quality In-Reply-To: <bug-23963-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23963-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23963-70-bIKlsF92M8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23963 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|23984 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23984 [Bug 23984] Local cover 'thumbnail' size is bigger than 'imagefile' size in biblioimages table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 10:28:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 09:28:38 +0000 Subject: [Koha-bugs] [Bug 22988] Visible reduction in image quality In-Reply-To: <bug-22988-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22988-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22988-70-fLmge2bvDx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22988 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23984 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23984 [Bug 23984] Local cover 'thumbnail' size is bigger than 'imagefile' size in biblioimages table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 10:28:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 09:28:38 +0000 Subject: [Koha-bugs] [Bug 23984] Local cover 'thumbnail' size is bigger than 'imagefile' size in biblioimages table In-Reply-To: <bug-23984-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23984-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23984-70-apyefgRkap@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23984 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22988 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22988 [Bug 22988] Visible reduction in image quality -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 10:29:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 09:29:30 +0000 Subject: [Koha-bugs] [Bug 23981] Inconsistencies with the different prices In-Reply-To: <bug-23981-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23981-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23981-70-Qzl3VC2VsU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23981 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 10:42:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 09:42:51 +0000 Subject: [Koha-bugs] [Bug 23982] Count/pagination broken for reports with duplicated column names In-Reply-To: <bug-23982-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23982-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23982-70-DtswRL8v6e@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23982 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- It seems that we should revert commit bca4453c50d8b5b1d3c7029ded2b522a9a2bf868 Bug 23624: (QA follow-up) Optimize even more >From https://bugs.mysql.com/bug.php?id=6709: """ This is in agreement with the SQL Standard, which says: [...] 11) No <column name> shall be specified more than once in a <derived column> list. """ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 10:43:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 09:43:07 +0000 Subject: [Koha-bugs] [Bug 23982] Count/pagination broken for reports with duplicated column names In-Reply-To: <bug-23982-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23982-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23982-70-HgKEVNGW7D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23982 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_19_11_candidate Severity|normal |major -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 10:43:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 09:43:55 +0000 Subject: [Koha-bugs] [Bug 18587] LDAP: update_local is entirely untested! In-Reply-To: <bug-18587-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18587-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18587-70-CPzErCfb4i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18587 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 10:44:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 09:44:39 +0000 Subject: [Koha-bugs] [Bug 20627] Prevent leakages of user permissions to api access tokens In-Reply-To: <bug-20627-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20627-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20627-70-T2BSIRAg7k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20627 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 10:44:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 09:44:45 +0000 Subject: [Koha-bugs] [Bug 23982] Count/pagination broken for reports with duplicated column names In-Reply-To: <bug-23982-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23982-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23982-70-sdvzlESfON@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23982 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23624 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23624 [Bug 23624] Count rows in report without (potentially) consuming all memory -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 10:44:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 09:44:45 +0000 Subject: [Koha-bugs] [Bug 23624] Count rows in report without (potentially) consuming all memory In-Reply-To: <bug-23624-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23624-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23624-70-o50MqmE8Uu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23624 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23982 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23982 [Bug 23982] Count/pagination broken for reports with duplicated column names -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 11:43:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 10:43:01 +0000 Subject: [Koha-bugs] [Bug 23765] After TranslateNotices is set to 'Don't allow', email settings still show multiple languages In-Reply-To: <bug-23765-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23765-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23765-70-fwZXetQfav@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23765 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 11:43:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 10:43:05 +0000 Subject: [Koha-bugs] [Bug 23765] After TranslateNotices is set to 'Don't allow', email settings still show multiple languages In-Reply-To: <bug-23765-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23765-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23765-70-UQ3izBagwn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23765 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93903|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95136 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95136&action=edit Bug 23765: Do not display localized templates if TranslateNotices is off To test: 1. Enable multi-languages 2. Set the preference 'TranslateNotices' on 'Allow' 3. Go to: tools==>Notices & slips==>Edit, make sure it has multilingual email templates. 4. Set the preference TranslateNotices on 'Don't allow'. 5. Go to: tools==>Notices & slips==>Edit, the template shows several tab for the same transport type. 6. Apply the patch. 7. Repeat the steps 4 and 5 8. Success. It only shows the default template when TranslateNotices is 'Dont allow'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 11:43:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 10:43:36 +0000 Subject: [Koha-bugs] [Bug 23765] After TranslateNotices is set to 'Don't allow', email settings still show multiple languages In-Reply-To: <bug-23765-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23765-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23765-70-jEDeKMzxC6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23765 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_19_11_candidate Severity|normal |major Assignee|bin.wen at inlibro.com |jonathan.druart at bugs.koha-c | |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Martin Renvoize from comment #4) > Hmmm, > > I'm wondering if this should be caught at a higher level.. the issue to me > is that C4::Letters::GetLetterTemplates returns multiple languages even if > TranslateNotices is set to "Don't allow"... I'm wondering if fixing it at > this level would catch some other cases where TranslateNotices isn't being > checked perhaps? Yes, definitely! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 11:49:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 10:49:43 +0000 Subject: [Koha-bugs] [Bug 23768] ISBN search in IntranetCatalogPulldown searches nothing if passed an invalid ISBN and using SearchWithISBNVariations In-Reply-To: <bug-23768-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23768-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23768-70-ps5HWgqQxo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23768 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 11:49:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 10:49:46 +0000 Subject: [Koha-bugs] [Bug 23768] ISBN search in IntranetCatalogPulldown searches nothing if passed an invalid ISBN and using SearchWithISBNVariations In-Reply-To: <bug-23768-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23768-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23768-70-25n2jFn81G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23768 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94963|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95137 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95137&action=edit Bug 23768: Return invalid ISBN when searching with variations To test: 1 - Enable SearchWithISBNVariations and IntranetCatalogSearchPulldown 2 - Refresh page and click on 'Search the catalog' tab 3 - Search for 'ISBN' 0385299209 4 - Note no results 5 - Note the search says if searched 'kw,wrdl: (nb=)' 6 - Apply patch, restart all the things 7 - Repeat search 8 - Search looks correctly formed 9 - Add the isbn above to a record, confirm it is returned by search 10 - Confirm searches for valid ISBNs still work as expected Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 11:49:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 10:49:49 +0000 Subject: [Koha-bugs] [Bug 23768] ISBN search in IntranetCatalogPulldown searches nothing if passed an invalid ISBN and using SearchWithISBNVariations In-Reply-To: <bug-23768-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23768-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23768-70-2rcRP5fCIq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23768 --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95138 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95138&action=edit Bug 23768: Adjust the test for invalid ISBN Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 11:51:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 10:51:19 +0000 Subject: [Koha-bugs] [Bug 23768] ISBN search in IntranetCatalogPulldown searches nothing if passed an invalid ISBN and using SearchWithISBNVariations In-Reply-To: <bug-23768-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23768-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23768-70-yZNMPZ8g06@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23768 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #4) > A sign-off as incentive for a regression test? There was a test, and it was failing :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 11:58:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 10:58:00 +0000 Subject: [Koha-bugs] [Bug 15448] OPACHiddenItems show in OPAC when patron places a hold on a specific item In-Reply-To: <bug-15448-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15448-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15448-70-UBgWISWifD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15448 --- Comment #9 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- (In reply to Katrin Fischer from comment #7) > (In reply to Fridolin SOMERS from comment #5) > > Maybe hidden items should be removed directly in C4::Items::GetItemsInfo, > > called by opac-reserve.pl > > Can you explain this a bit more? Not sure how it works right now, did you > mean move or remove? I mean remove, so they are never given to the OPAC. One should then add a new arg to the method to say opac or staff interface. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 12:00:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 11:00:59 +0000 Subject: [Koha-bugs] [Bug 13749] On loading holds in patron account 'processing' is not translatable In-Reply-To: <bug-13749-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13749-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13749-70-ZND5KYtkqx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13749 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 12:01:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 11:01:02 +0000 Subject: [Koha-bugs] [Bug 13749] On loading holds in patron account 'processing' is not translatable In-Reply-To: <bug-13749-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13749-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13749-70-vxk1UQ1tR9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13749 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94964|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95139 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95139&action=edit Bug 13749: On loading holds in patron account 'processing' is not translatable This patch updates the DataTables configuration for two tables: The checkouts and holds lists shown on the checkout and patron details screen. The tables lacked the standard application of a custom set of defaults defined in js/datatables.js. It is in this file that custom language strings are defined for DataTable interface elements, pulling in the translated values from datatables.inc. Without our custom defaults applied, DataTables used its own defaults, which are not translated. To test, apply the patch and check out to a patron who has both checkouts and holds. The more the better to give you more time to observer the loading state of the tables. - Checkouts: This table doesn't exhibit any visible problems because page-specific text is defined for the table's "Loading" message. However, it still makes sense to apply the defaults to the table for consistency's sake. There should be no visible changes to the table. - Holds: From the checkout or patron details page click the "Holds" tab. While the table loads there should be a "Processing" message. If you switch to another translation the message should appear in that language. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 12:01:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 11:01:46 +0000 Subject: [Koha-bugs] [Bug 13749] On loading holds in patron account 'processing' is not translatable In-Reply-To: <bug-13749-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13749-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13749-70-ybEE6kdCAo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13749 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- It does not appear on moremember, any ideas why? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 12:05:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 11:05:57 +0000 Subject: [Koha-bugs] [Bug 15248] Improve FindDuplicate In-Reply-To: <bug-15248-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15248-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15248-70-TbAyVZh4lI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15248 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 12:15:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 11:15:33 +0000 Subject: [Koha-bugs] [Bug 23954] Format notes in suggestion management In-Reply-To: <bug-23954-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23954-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23954-70-qAuwlVtJCv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23954 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 12:15:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 11:15:37 +0000 Subject: [Koha-bugs] [Bug 23954] Format notes in suggestion management In-Reply-To: <bug-23954-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23954-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23954-70-GQDAYKPFmo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23954 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94990|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95140 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95140&action=edit Bug 23954: Format notes in suggestion management This patch makes minor CSS and markup changes in order to deliniate suggestion notes from the other data in the suggestions list view. To test you should have at least one suggestion with a note. Apply the patch and go to Acquisitions -> Suggestions. In the table of suggestions, check that the notes display clearly. Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 12:18:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 11:18:13 +0000 Subject: [Koha-bugs] [Bug 23952] Fix body id on OPAC course details page In-Reply-To: <bug-23952-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23952-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23952-70-SYsAWgANYJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23952 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 12:18:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 11:18:17 +0000 Subject: [Koha-bugs] [Bug 23952] Fix body id on OPAC course details page In-Reply-To: <bug-23952-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23952-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23952-70-WrHjWcC3Wm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23952 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94994|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95141 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95141&action=edit Bug 23952: Fix body tag on OPAC course details page The id was not changed, when the page was added and remained opac-main. The patch changes it to opac-course-details so the page has its own unique id. To test: - Add a course reserve to your installation - Go to the course reserves page in the OPAC - Click on the course to see its details - Look at the source code, the <body> tag should show: Without patch: opac-main with patch applied: opac-course-details Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 12:23:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 11:23:55 +0000 Subject: [Koha-bugs] [Bug 23751] Description of staffaccess permission should be improved In-Reply-To: <bug-23751-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23751-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23751-70-v7CG1JmCQV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23751 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 12:23:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 11:23:55 +0000 Subject: [Koha-bugs] [Bug 23985] New: The method Koha::Item-> is not covered by tests! Message-ID: <bug-23985-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23985 Bug ID: 23985 Summary: The method Koha::Item-> is not covered by tests! Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When checking out an item: The method Koha::Item-> is not covered by tests! Trace begun at /home/koha/env/master/src/Koha/Object.pm line 495 Koha::Object::AUTOLOAD('Koha::Item=HASH(0x55c5a43bcfb0)') called at /home/koha/env/master/src/C4/Reserves.pm line 799 C4::Reserves::CheckReserves(9) called at /home/koha/env/master/src/C4/Circulation.pm line 1024 C4::Circulation::CanBookBeIssued('Koha::Patron=HASH(0x55c5a43d6298)', 1, undef, undef, undef, 'HASH(0x55c5a45432b0)') called at /home/koha/env/master/src/circ/circulation.pl line 349 The bad lines are : my $hold_fulfillment_policy = $branchitemrule->{hold_fulfillment_policy}; next if ( ($branchitemrule->{hold_fulfillment_policy} ne 'any') && ($res->{branchcode} ne $item->$hold_fulfillment_policy) ); $hold_fulfillment_policy can apparently be empty, and this is not checked. I'm not sure what should be done in this case. Steps to reproduce: 1. Go to "Circulation and fines rules" 2. Under "Default checkout, hold and return policy", unset "Hold pickup library match" and Save 3. Place a hold on one item for one patron 4. Try to checkout the same item with another patron Caused by bug 21206 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 12:23:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 11:23:58 +0000 Subject: [Koha-bugs] [Bug 23751] Description of staffaccess permission should be improved In-Reply-To: <bug-23751-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23751-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23751-70-UwybWE2V9O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23751 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94993|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95142 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95142&action=edit Bug 23751: Make staffaccess permission description more precise The permission description was missing 'username' from the description. To test: - Look at the permissions of a patron - Verify the staffaccess permission is labelled: Allow staff members to modify permissions and passwords for other staff members - Apply patch - Check description again: Allow staff members to modify permissions, usernames, and passwords for other staff members Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 12:31:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 11:31:18 +0000 Subject: [Koha-bugs] [Bug 23293] OPACFineNoRenewals compares against 'balance' not 'outstanding' In-Reply-To: <bug-23293-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23293-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23293-70-1B1Wdlh10H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23293 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 12:31:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 11:31:22 +0000 Subject: [Koha-bugs] [Bug 23293] OPACFineNoRenewals compares against 'balance' not 'outstanding' In-Reply-To: <bug-23293-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23293-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23293-70-7PX3etJWyD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23293 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95121|0 |1 is obsolete| | Attachment #95122|0 |1 is obsolete| | Attachment #95123|0 |1 is obsolete| | Attachment #95124|0 |1 is obsolete| | --- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95143 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95143&action=edit Bug 23293: Add system preference Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 12:31:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 11:31:27 +0000 Subject: [Koha-bugs] [Bug 23293] OPACFineNoRenewals compares against 'balance' not 'outstanding' In-Reply-To: <bug-23293-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23293-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23293-70-kA8G0tFzIh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23293 --- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95144 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95144&action=edit Bug 23293: Apply OPACFineNoRenewalsIncludeCredit preference Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 12:31:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 11:31:31 +0000 Subject: [Koha-bugs] [Bug 23293] OPACFineNoRenewals compares against 'balance' not 'outstanding' In-Reply-To: <bug-23293-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23293-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23293-70-QuqTqdnVX7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23293 --- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95145 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95145&action=edit Bug 23293: (follow-up) Add tests for C4::Circulation change Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 12:31:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 11:31:36 +0000 Subject: [Koha-bugs] [Bug 23293] OPACFineNoRenewals compares against 'balance' not 'outstanding' In-Reply-To: <bug-23293-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23293-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23293-70-YAyEdRCS4A@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23293 --- Comment #19 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95146 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95146&action=edit Bug 23293: (QA follow-up) Minor fix for tests Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 12:34:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 11:34:57 +0000 Subject: [Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized In-Reply-To: <bug-22381-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22381-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22381-70-fpnpqufu4X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Patch doesn't apply -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 12:35:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 11:35:41 +0000 Subject: [Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized In-Reply-To: <bug-22381-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22381-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22381-70-tHWmWq8yqq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Conflict with bug 13958, please rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 12:39:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 11:39:30 +0000 Subject: [Koha-bugs] [Bug 21939] Permission for holds history tab is too strict In-Reply-To: <bug-21939-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21939-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21939-70-H6V3myTazj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 12:39:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 11:39:34 +0000 Subject: [Koha-bugs] [Bug 21939] Permission for holds history tab is too strict In-Reply-To: <bug-21939-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21939-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21939-70-cKlZk4Xn29@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95128|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95147 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95147&action=edit Bug 21939: Fix permissions for holds history tab The tab will show when the staff user has edit_borrowers permission, but the page itself will not be accessible. This patch fixes the page permissions to allow access with the edit_borrowers permission as suggested by the comments on the original bug report. To test: - Create a staff user with only "edit_borrowers" permission from the borrowers module - Try to access the holds history tab from any patron account - Verify you are blocked - Apply patch - Try again and verify the page is accessible now - Repeat with superlibrarian and full borrowers permission. Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> Signed-off-by: Bob Bennhoff <bbennhoff at clicweb.org> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 12:47:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 11:47:29 +0000 Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23681-70-fDGXLVOyax@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 --- Comment #42 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 95148 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95148&action=edit Bug 23681: (follow-up) Fix typo -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 12:56:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 11:56:33 +0000 Subject: [Koha-bugs] [Bug 23529] Interlibrary loan javascript is broken In-Reply-To: <bug-23529-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23529-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23529-70-GkUuNRqJOZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23529 --- Comment #18 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- OK, ignore me. Nothing needs doing here. Sorry for the noise. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 13:34:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 12:34:03 +0000 Subject: [Koha-bugs] [Bug 22831] Elasticsearch - add a maintenance script for checking DB vs index counts In-Reply-To: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22831-70-FiS1EW8Fih@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 --- Comment #12 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Very nice script, thanks a lot ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 13:36:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 12:36:59 +0000 Subject: [Koha-bugs] [Bug 23427] Better sorting of previous checkouts In-Reply-To: <bug-23427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23427-70-Ry07eW24mm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23427 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 13:37:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 12:37:03 +0000 Subject: [Koha-bugs] [Bug 23427] Better sorting of previous checkouts In-Reply-To: <bug-23427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23427-70-E0TdbWKCpi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23427 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94259|0 |1 is obsolete| | Attachment #94260|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95149 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95149&action=edit Bug 23427: fix previous checkouts sort order In patron circulation or details page, previous checkouts are displayed sorted by due date. Actual sort order is not honoring system preference "previousIssuesDefaultSortOrder". Todays's checkouts is correct thanks to Bug 13908. Patch adds comments that refer to the text of system preferences "previousIssuesDefaultSortOrder" and "TodayIssuesDefaultSortOrder" : latest to earliest = asc earliest to latest = desc Test plan : 1) Create for a patron two old issues with a few days between them 2) Set preference previousIssuesDefaultSortOrder = "latest to earliest" 3) Go to patron circulation page and check sort order is OK 4) Go to patron details page and check sort order is OK 5) Set preference previousIssuesDefaultSortOrder = "earliest to latest" 6) Go to patron circulation page and check sort order is OK 7) Go to patron details page and check sort order is OK Signed-off-by: Michal Denar <black23 at gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 13:37:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 12:37:08 +0000 Subject: [Koha-bugs] [Bug 23427] Better sorting of previous checkouts In-Reply-To: <bug-23427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23427-70-aruoboqFrI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23427 --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95150 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95150&action=edit Bug 23427: Better sorting of previous checkouts In patron circulation or details page, previous checkouts are displayed sorted by due date. Many checkouts may have same due date so it would be better to sort on timestamp as second sort criteria, like todays's checkouts. Test plan : 1) Create for a patron two issues with same due date and a few seconds between them 2) Create another issue with a different due date 3) Come back a day later 4) Set preference previousIssuesDefaultSortOrder = "latest to earliest" 5) Go to patron circulation page and check sort order is OK : sorted by "Due date" then "Cheked out on" 6) Go to patron details page and check sort order is OK : sorted by "Due date" then "Cheked out on" 7) Set preference previousIssuesDefaultSortOrder = "earliest to latest" 8) Go to patron circulation page and check sort order is OK : sorted by "Due date" then "Cheked out on" 9) Go to patron details page and check sort order is OK : sorted by "Due date" then "Cheked out on" Signed-off-by: Michal Denar <black23 at gmail.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 13:37:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 12:37:13 +0000 Subject: [Koha-bugs] [Bug 23427] Better sorting of previous checkouts In-Reply-To: <bug-23427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23427-70-YCxnvQpIqu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23427 --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95151 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95151&action=edit Bug 23427: Simplify sort logic This is the usual syntax. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 13:46:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 12:46:31 +0000 Subject: [Koha-bugs] [Bug 23165] Renewals for Self Checkout (SCO) module do not record branchcode in statistics In-Reply-To: <bug-23165-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23165-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23165-70-EEgG7QDUj8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23165 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |Patch doesn't apply --- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- CONFLICT (content): Merge conflict in C4/Circulation.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 13:47:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 12:47:58 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX) In-Reply-To: <bug-11299-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11299-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11299-70-QNR4XvQrRm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Michal Denar <black23 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 13:48:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 12:48:03 +0000 Subject: [Koha-bugs] [Bug 11299] Add a button to automatically link authority records in cataloguing (AJAX) In-Reply-To: <bug-11299-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11299-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11299-70-gFa27RXx2U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11299 Michal Denar <black23 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95126|0 |1 is obsolete| | --- Comment #104 from Michal Denar <black23 at gmail.com> --- Created attachment 95152 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95152&action=edit Bug 11299 - Add a button to the biblio edition page to automatically add authority links in the current biblio record via AJAX. Also adds a button to easily create missing authority records. add authority type in the form to create the missing authority. when authority was found, the 600$9 field have the authid. Testing scenario (Creating an authority record for a failed automatic link) : * In you system preferences, deactivate the "AutoCreateAuthorities" preference. * Go to the biblio record creation form to create a new biblio record. (koha/cataloguing/addbiblio.pl) * Click the "Link authorities automatically" button. A message should appear, telling the user "No authority link was changed." * Add random informations in field 600$a of the biblio record. * Click the "Link authorities automatically" button. * if matching authority was found, The message box should now show "600 - A matching authority was found in the local database". * if no matching authority was found, the message box should now show "600 - No matching authority found.". For this scenario, we want the authority match to have failed. * The 600$9 field should now be red and icons should have appeared next to it. Click on the "create authority" icon. * A popup will appear, containing a form to create the missing authority. The form should be pre-filled, a the informations in the 600$a field of the biblio should be in the 100$a field of this new authority record. * Fill in the form and click the "Save" button * The 600$9 field in the biblio record should now be back to normal and have the authid of the authority record that was just created. * Click the "Link authorities automatically" button again. The message box should now show "No authority link was changed.". Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> https://bugs.koha-community.org/show_bug.cgi?id=12299 Signed-off-by: Michal Denar <black23 at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 13:53:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 12:53:04 +0000 Subject: [Koha-bugs] [Bug 23806] FinePaymentAutoPopup does not trigger pop-up for writeoff by "Write off" button In-Reply-To: <bug-23806-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23806-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23806-70-zxG8SogCiO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23806 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 13:53:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 12:53:08 +0000 Subject: [Koha-bugs] [Bug 23806] FinePaymentAutoPopup does not trigger pop-up for writeoff by "Write off" button In-Reply-To: <bug-23806-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23806-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23806-70-CAinURShcH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23806 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94273|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95153 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95153&action=edit Bug 23806: FinePaymentAutoPopup does not trigger pop-up for writeoff by "Write off" button Test Plan: 1) Enable reciept popups for payments and writeoffs 2) Test the "Write off" button, no popup 3) Apply this patch 4) Restart all the things! 5) Test again, you should get the popup! Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Sean McGarvey <seanm at pascolibraries.org> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 13:55:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 12:55:54 +0000 Subject: [Koha-bugs] [Bug 11300] Add a new authority linker which searches for authority links on a Z39.50 server. In-Reply-To: <bug-11300-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11300-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11300-70-110u0WNKYl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11300 --- Comment #31 from Michal Denar <black23 at gmail.com> --- Any test plan? Thanks. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 14:12:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 13:12:41 +0000 Subject: [Koha-bugs] [Bug 23293] OPACFineNoRenewals always compares against 'balance' not 'outstanding' In-Reply-To: <bug-23293-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23293-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23293-70-vrzVDVd42i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23293 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|OPACFineNoRenewals compares |OPACFineNoRenewals always |against 'balance' not |compares against 'balance' |'outstanding' |not 'outstanding' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 14:21:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 13:21:03 +0000 Subject: [Koha-bugs] [Bug 22831] Elasticsearch - add a maintenance script for checking DB vs index counts In-Reply-To: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22831-70-gfkng4DS5G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 14:21:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 13:21:06 +0000 Subject: [Koha-bugs] [Bug 22831] Elasticsearch - add a maintenance script for checking DB vs index counts In-Reply-To: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22831-70-j7lY0wWAwW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95105|0 |1 is obsolete| | Attachment #95110|0 |1 is obsolete| | --- Comment #13 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95154 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95154&action=edit Bug 22831: Elasticsearch - add a maintenance script for checking DB vs index counts This script uses Array::Utils and adds a dependency To test: 1 - Have Koha with ES running 2 - Delete some records from ES curl -X DELETE "es:9200/koha_kohadev_biblios/data/5" curl -X DELETE "es:9200/koha_kohadev_authorities/data/5" 3 - perl misc/maintenance/compare_es_to_db.pl 4 - Note you are notified of problems in both indexes 5 - perl misc/search_tools/rebuild_elastic_search.pl -a 6 - perl misc/maintenance/compare_es_to_db.pl 7 - Note you are only notified about problems in biblios (assuming you don't have other issues) 8 - perl misc/search_tools/rebuild_elasticsearch.pl -b 9 - perl misc/maintenance/compare_es_to_db.pl 10 - Both counts match, no problems -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 14:21:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 13:21:09 +0000 Subject: [Koha-bugs] [Bug 22831] Elasticsearch - add a maintenance script for checking DB vs index counts In-Reply-To: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22831-70-hAVAljtzoF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 --- Comment #14 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95155 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95155&action=edit Bug 22831: (follow-up) Determine where the record is missing and provide link, show counter -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 14:25:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 13:25:49 +0000 Subject: [Koha-bugs] [Bug 23427] Better sorting of previous checkouts In-Reply-To: <bug-23427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23427-70-Lrn8ZevR3e@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23427 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice bit of golfing there, thanks :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 14:27:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 13:27:03 +0000 Subject: [Koha-bugs] [Bug 13749] On loading holds in patron account 'processing' is not translatable In-Reply-To: <bug-13749-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13749-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13749-70-1wRjRVcSd3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13749 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 14:27:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 13:27:04 +0000 Subject: [Koha-bugs] [Bug 23600] Library group search broken for group with a big number of libraries In-Reply-To: <bug-23600-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23600-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23600-70-t2xV5HwGrt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23600 --- Comment #6 from Andres Ovalle <aovalle at biteca.com> --- "ENTIDAD DE PRUEBA" was the last library created in the system, after that there are the groups that is where we have problems. An example image: https://www.dropbox.com/s/vn753b4a9g4or6c/Captura%20de%20Pantalla%202019-11-06%20a%20la%28s%29%208.01.19%20p.%20m..png?dl=0 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 14:27:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 13:27:05 +0000 Subject: [Koha-bugs] [Bug 13749] On loading holds in patron account 'processing' is not translatable In-Reply-To: <bug-13749-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13749-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13749-70-tohGM4Zzue@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13749 --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 14:27:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 13:27:07 +0000 Subject: [Koha-bugs] [Bug 21939] Permission for holds history tab is too strict In-Reply-To: <bug-21939-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21939-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21939-70-vwwkA2hjyt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 14:27:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 13:27:09 +0000 Subject: [Koha-bugs] [Bug 21939] Permission for holds history tab is too strict In-Reply-To: <bug-21939-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21939-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21939-70-Iq3qmmWsI2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 14:27:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 13:27:12 +0000 Subject: [Koha-bugs] [Bug 23293] OPACFineNoRenewals always compares against 'balance' not 'outstanding' In-Reply-To: <bug-23293-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23293-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23293-70-F3mCfjYaod@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23293 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 14:27:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 13:27:13 +0000 Subject: [Koha-bugs] [Bug 23293] OPACFineNoRenewals always compares against 'balance' not 'outstanding' In-Reply-To: <bug-23293-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23293-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23293-70-xJqsRohbuq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23293 --- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 14:27:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 13:27:15 +0000 Subject: [Koha-bugs] [Bug 23427] Better sorting of previous checkouts In-Reply-To: <bug-23427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23427-70-ju4ySNqpi3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23427 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 14:27:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 13:27:17 +0000 Subject: [Koha-bugs] [Bug 23427] Better sorting of previous checkouts In-Reply-To: <bug-23427-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23427-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23427-70-2dHmiEpp16@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23427 --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 14:27:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 13:27:19 +0000 Subject: [Koha-bugs] [Bug 23751] Description of staffaccess permission should be improved In-Reply-To: <bug-23751-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23751-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23751-70-TwsA1DJ5sj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23751 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 14:27:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 13:27:21 +0000 Subject: [Koha-bugs] [Bug 23751] Description of staffaccess permission should be improved In-Reply-To: <bug-23751-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23751-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23751-70-fsYYtaJOv5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23751 --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 14:27:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 13:27:23 +0000 Subject: [Koha-bugs] [Bug 23768] ISBN search in IntranetCatalogPulldown searches nothing if passed an invalid ISBN and using SearchWithISBNVariations In-Reply-To: <bug-23768-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23768-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23768-70-ZM4zE5innr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23768 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 14:27:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 13:27:25 +0000 Subject: [Koha-bugs] [Bug 23768] ISBN search in IntranetCatalogPulldown searches nothing if passed an invalid ISBN and using SearchWithISBNVariations In-Reply-To: <bug-23768-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23768-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23768-70-MG02v2iXxQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23768 --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 14:27:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 13:27:27 +0000 Subject: [Koha-bugs] [Bug 23806] FinePaymentAutoPopup does not trigger pop-up for writeoff by "Write off" button In-Reply-To: <bug-23806-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23806-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23806-70-ExT74Edrls@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23806 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 14:27:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 13:27:28 +0000 Subject: [Koha-bugs] [Bug 23806] FinePaymentAutoPopup does not trigger pop-up for writeoff by "Write off" button In-Reply-To: <bug-23806-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23806-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23806-70-ysUnFFxNrz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23806 --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 14:27:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 13:27:30 +0000 Subject: [Koha-bugs] [Bug 23952] Fix body id on OPAC course details page In-Reply-To: <bug-23952-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23952-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23952-70-T2yDZ3cFHq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23952 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 14:27:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 13:27:32 +0000 Subject: [Koha-bugs] [Bug 23952] Fix body id on OPAC course details page In-Reply-To: <bug-23952-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23952-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23952-70-kJX5JLqBdi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23952 --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 14:27:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 13:27:34 +0000 Subject: [Koha-bugs] [Bug 23954] Format notes in suggestion management In-Reply-To: <bug-23954-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23954-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23954-70-aZRBwRNds9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23954 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 14:27:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 13:27:36 +0000 Subject: [Koha-bugs] [Bug 23954] Format notes in suggestion management In-Reply-To: <bug-23954-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23954-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23954-70-jmNJeFNpNQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23954 --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 14:28:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 13:28:50 +0000 Subject: [Koha-bugs] [Bug 22831] Elasticsearch - add a maintenance script for checking DB vs index counts In-Reply-To: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22831-70-lp5zyk7Nyc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 14:28:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 13:28:54 +0000 Subject: [Koha-bugs] [Bug 22831] Elasticsearch - add a maintenance script for checking DB vs index counts In-Reply-To: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22831-70-nqUsFprDcf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95154|0 |1 is obsolete| | --- Comment #15 from Ere Maijala <ere.maijala at helsinki.fi> --- Created attachment 95156 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95156&action=edit Bug 22831: Elasticsearch - add a maintenance script for checking DB vs index counts This script uses Array::Utils and adds a dependency To test: 1 - Have Koha with ES running 2 - Delete some records from ES curl -X DELETE "es:9200/koha_kohadev_biblios/data/5" curl -X DELETE "es:9200/koha_kohadev_authorities/data/5" 3 - perl misc/maintenance/compare_es_to_db.pl 4 - Note you are notified of problems in both indexes 5 - perl misc/search_tools/rebuild_elastic_search.pl -a 6 - perl misc/maintenance/compare_es_to_db.pl 7 - Note you are only notified about problems in biblios (assuming you don't have other issues) 8 - perl misc/search_tools/rebuild_elasticsearch.pl -b 9 - perl misc/maintenance/compare_es_to_db.pl 10 - Both counts match, no problems Signed-off-by: Ere Maijala <ere.maijala at helsinki.fi> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 14:28:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 13:28:57 +0000 Subject: [Koha-bugs] [Bug 22831] Elasticsearch - add a maintenance script for checking DB vs index counts In-Reply-To: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22831-70-qqGaxYW8pX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Ere Maijala <ere.maijala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95155|0 |1 is obsolete| | --- Comment #16 from Ere Maijala <ere.maijala at helsinki.fi> --- Created attachment 95157 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95157&action=edit Bug 22831: (follow-up) Determine where the record is missing and provide link, show counter Signed-off-by: Ere Maijala <ere.maijala at helsinki.fi> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 14:30:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 13:30:48 +0000 Subject: [Koha-bugs] [Bug 23986] New: Batch Record Deletion does not remove records from search index Message-ID: <bug-23986-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23986 Bug ID: 23986 Summary: Batch Record Deletion does not remove records from search index Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com To test: - create a bib record - perform a search that returns a list of results including your record - delete record via batch record delete tool - repeat your search, observe that record still appears in results - click deleted title in search results, get "The record you requested does not exist" error -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 14:31:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 13:31:00 +0000 Subject: [Koha-bugs] [Bug 23986] Batch Record Deletion does not remove records from search index In-Reply-To: <bug-23986-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23986-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23986-70-3Wj7ZAfPxq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23986 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 14:34:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 13:34:32 +0000 Subject: [Koha-bugs] [Bug 6775] Add option to use authorized values as reasons for restrictions In-Reply-To: <bug-6775-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6775-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6775-70-8SGpAMSt74@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6775 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE CC| |magnus at libriotech.no --- Comment #4 from Magnus Enger <magnus at libriotech.no> --- Looks like this is being handled in bug 23681, marking as duplicate. *** This bug has been marked as a duplicate of bug 23681 *** -- You are receiving this mail because: You are the QA Contact for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 14:34:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 13:34:32 +0000 Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23681-70-I8TiGCE4EI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |savitra.sirohi at osslabs.biz --- Comment #43 from Magnus Enger <magnus at libriotech.no> --- *** Bug 6775 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 14:36:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 13:36:54 +0000 Subject: [Koha-bugs] [Bug 17259] Allow batch removal of restrictions In-Reply-To: <bug-17259-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17259-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17259-70-Wu9Ds6MElw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17259 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no --- Comment #1 from Magnus Enger <magnus at libriotech.no> --- Is this taken care of by bug 13552? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 14:39:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 13:39:58 +0000 Subject: [Koha-bugs] [Bug 14680] when doing acquisitions from a staged file, MarcFieldsToOrder-syspref discounts are instead added. In-Reply-To: <bug-14680-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14680-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14680-70-SfVEwRu12W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |major CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 14:45:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 13:45:22 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-plX6knFqVB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|NEW |ASSIGNED Change sponsored?|Seeking developer |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 15:02:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 14:02:06 +0000 Subject: [Koha-bugs] [Bug 23987] New: batchMod.pl provides a link back to the record after the record is deleted Message-ID: <bug-23987-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23987 Bug ID: 23987 Summary: batchMod.pl provides a link back to the record after the record is deleted Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com To recreate: 1 - Have/make a bib with items 2 - On details page select Edit->Delete items in a batch 3 - Select all items and check "Delete record if no items remain" 4 - Delete the things 5 - On confirmation screen you have a count of items/bibs deleted 6 - Click 'Return to record' link 7 - It don't work, because you just deleted the record -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 15:17:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 14:17:29 +0000 Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile In-Reply-To: <bug-19735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19735-70-G6xa2oU5Lv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 15:17:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 14:17:47 +0000 Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile In-Reply-To: <bug-19735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19735-70-8LoxXDmgNL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22522 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 15:27:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 14:27:35 +0000 Subject: [Koha-bugs] [Bug 21301] Restriction of the informations given by GetRecords ILS-DI service In-Reply-To: <bug-21301-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21301-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21301-70-Mfx4wetBhY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 15:28:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 14:28:05 +0000 Subject: [Koha-bugs] [Bug 21301] Restriction of the informations given by GetRecords ILS-DI service In-Reply-To: <bug-21301-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21301-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21301-70-lPgwPxqP5P@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- False positive on the POD issue, we remove a whole routine and as such remove the corresponding POD too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 15:28:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 14:28:37 +0000 Subject: [Koha-bugs] [Bug 21301] Restriction of the informations given by GetRecords ILS-DI service In-Reply-To: <bug-21301-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21301-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21301-70-QrRVUXRFVS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93495|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95158 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95158&action=edit Bug 21301: Remove patron informations in issues for GetRecords ILS-DI service Actually, the GetRecords service gives many information : bibliographic data (marcxml field) item data (items field) issue data (issues field) The issue data should not be sent by these service, its a privacy problem. Biblio title and author are redundant. This patch changes to use Koha::Checkouts to get issues informations with only the addition of item barcode. Test plan : 1) Enable ILS-DI webservice 2) Checkout an item 3) Go to {opac}/cgi-bin/koha/ilsdi.pl?service=GetRecords&id={biblionumber} 4) Check the issues tag content Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 15:28:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 14:28:41 +0000 Subject: [Koha-bugs] [Bug 21301] Restriction of the informations given by GetRecords ILS-DI service In-Reply-To: <bug-21301-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21301-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21301-70-v7I43nvcPW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93603|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95159 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95159&action=edit Bug 21301: Remove patron informations in reserves for GetRecords ILS-DI service Actually, the GetRecords service gives many information : borrowernumber (reserves field) The issue data should not be sent by these service, its a privacy problem. Test plan : 1) Enable ILS-DI webservice 2) Place hold on an item 3) Go to {opac}/cgi-bin/koha/ilsdi.pl?service=GetRecords&id={biblionumber} 4) Check the reserves tag content Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 15:38:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 14:38:08 +0000 Subject: [Koha-bugs] [Bug 21301] Restriction of the informations given by GetRecords ILS-DI service In-Reply-To: <bug-21301-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21301-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21301-70-PsZpbEz47r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 15:39:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 14:39:03 +0000 Subject: [Koha-bugs] [Bug 21301] Restriction of the informations given by GetRecords ILS-DI service In-Reply-To: <bug-21301-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21301-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21301-70-HSgz4UCkiI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301 --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Works as expected, checked if the online documentation needed any updating to reflect the change, but neither issues nor reservations have any details in the examples. Looks good to me, signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 15:40:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 14:40:17 +0000 Subject: [Koha-bugs] [Bug 21301] Restriction of the informations given by GetRecords ILS-DI service In-Reply-To: <bug-21301-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21301-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21301-70-Fi2ZHrAL4W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|martin.renvoize at ptfs-europe |testopia at bugs.koha-communit |.com |y.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 15:47:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 14:47:59 +0000 Subject: [Koha-bugs] [Bug 23964] An item level hold when placed is set to Waiting, if ReservesNeedReturn is set to Automatic In-Reply-To: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23964-70-BoL2KCXWTd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23964 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |jonathan.druart at bugs.koha-c |y.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 15:49:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 14:49:49 +0000 Subject: [Koha-bugs] [Bug 23983] Contextualization of "Order" (verb) vs "Order" (noun) In-Reply-To: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23983-70-IoZUc7ljJk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23983 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 15:49:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 14:49:51 +0000 Subject: [Koha-bugs] [Bug 23983] Contextualization of "Order" (verb) vs "Order" (noun) In-Reply-To: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23983-70-X7N8pQp6JP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23983 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95129|0 |1 is obsolete| | --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Created attachment 95160 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95160&action=edit Bug 23983: Contextualization of 'Order' (verb) vs 'Order' (noun) This patch adds context (word class, either verb or noun) to the word 'Order' when it is displayed alone in the acquisitions module. The following files have been modified: basket.tt neworderbiblio.tt newordersubscription.tt newordersuggestion.tt ordered.tt parcel.tt spent.tt transferorder.tt uncertainprice.tt z3950_search.tt To test, check all those pages in English to make sure there is no change. 1- Go to Acquisitions 2- Create a basket 3- Add to basket from an existing record (neworderbiblio) 4- Add to basket from a subscription (newordersubscription) 5- Add to basket from a suggestion (newordersuggestion) 6- Add to basket from an external source (z3950_search) 7- In one of the orders, check the uncertain price box 8- Check the basket display table (basket) 9- Click transfer on one of the orders (transferorder) 10- Go to the vendor page and click on 'Uncertain prices' (uncertainprice) 11- Click on 'Receive parcel' (parcel) 12- Go to the Acquisitions home page and click on the amount for 'ordered' (ordered) 13- Go to the Acquisitions home page and click on the amount for 'spent' (spent) Next, install a new language (fr-CA used as example) 1- translate create fr-CA 2- open fr-CA-messages.po and add a translation for Order (verb) and Order (noun) (it doesn't have to be real, just write something different for each) 3- translate install fr-CA 4- in the system preferences, enable the french language in 'language' 5- change interface language to french Redo the tests above to make sure the word you put in the translation for the verb is in the places where 'Order' should be a verb and that the translation you put in for the noun is in the places where 'Order' should be a noun -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 15:50:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 14:50:06 +0000 Subject: [Koha-bugs] [Bug 23398] Exporting/Reimporting frameworks in XML format will give incomplete results In-Reply-To: <bug-23398-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23398-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23398-70-vyeBLbs4NI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23398 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94687|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95161 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95161&action=edit Bug 23398: Disable the XML import/export format for biblio framework It gives incomplete results and not sure it ever worked. To prevent data loss it is better to remove this option. Note that the code in C4/ImportExportFramework.pm is too complex to attach with this patch to deletion of the code related to the XML import/export. Safer to keep it for a separate bug report. Test plan: Import/export biblio frameworks and confirm that there is no more reference to the xml format. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 15:50:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 14:50:18 +0000 Subject: [Koha-bugs] [Bug 23983] Contextualization of "Order" (verb) vs "Order" (noun) In-Reply-To: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23983-70-zf6K8mTNSP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23983 --- Comment #4 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- I have added the | html filters -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 15:50:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 14:50:54 +0000 Subject: [Koha-bugs] [Bug 23398] Exporting/Reimporting frameworks in XML format will give incomplete results In-Reply-To: <bug-23398-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23398-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23398-70-lwnqrFSdoJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23398 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Code scans well and does what is expected. I agree to the pragmatic decision of just removing the option at this point too. Signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 15:52:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 14:52:56 +0000 Subject: [Koha-bugs] [Bug 23983] Contextualization of "Order" (verb) vs "Order" (noun) In-Reply-To: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23983-70-fUqPdqocyZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23983 --- Comment #5 from Julian Maurice <julian.maurice at biblibre.com> --- It looks like you have obsoleted the previous patch while it's still needed. Is it intended ? If you are using git-bz, it automatically obsoletes patch with the same title, so be sure to use different titles for all your commits. I will de-obsolete the first patch and test it as soon as possible. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 15:53:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 14:53:24 +0000 Subject: [Koha-bugs] [Bug 23983] Contextualization of "Order" (verb) vs "Order" (noun) In-Reply-To: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23983-70-8lg5AsPNz2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23983 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95129|1 |0 is obsolete| | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 15:54:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 14:54:40 +0000 Subject: [Koha-bugs] [Bug 23983] Contextualization of "Order" (verb) vs "Order" (noun) In-Reply-To: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23983-70-eT5qW2GPtF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23983 --- Comment #6 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Sorry! I thought only the last patch would work as it contains the previous work too, but maybe not... Still learning git -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 16:09:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 15:09:56 +0000 Subject: [Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record In-Reply-To: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14963-70-vdLhOBe48S@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14973 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 16:09:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 15:09:56 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: <bug-14973-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14973-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14973-70-QnPdQdnxEH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14963 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 [Bug 14963] Ability to suggest purchase on existing catalogue record -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 16:11:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 15:11:02 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-LlJUa0wiwq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14963, 23594, 23854 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 [Bug 14963] Ability to suggest purchase on existing catalogue record https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594 [Bug 23594] Batch modification for itemtypes on suggestions page https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23854 [Bug 23854] Cannot edit a suggestion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 16:11:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 15:11:02 +0000 Subject: [Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record In-Reply-To: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14963-70-ljI991iSwi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23590 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 [Bug 23590] Allow to modify the manager of a suggestion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 16:11:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 15:11:02 +0000 Subject: [Koha-bugs] [Bug 23594] Batch modification for itemtypes on suggestions page In-Reply-To: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23594-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23594-70-v7KXmNRlO0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23594 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23590 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 [Bug 23590] Allow to modify the manager of a suggestion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 16:11:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 15:11:02 +0000 Subject: [Koha-bugs] [Bug 23854] Cannot edit a suggestion In-Reply-To: <bug-23854-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23854-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23854-70-BufPeQTEal@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23854 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23590 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 [Bug 23590] Allow to modify the manager of a suggestion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 16:12:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 15:12:41 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-42UTEHgWSU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 16:12:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 15:12:45 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-CuMdFWjjei@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95162 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95162&action=edit Bug 23590: Add ability to edit the manager of a suggestion Prior to this patch there was an hidden behavior that set the manager to the logged in user when a suggestion was edited. This patch proposes to let the librarian pick another manager. Other small adjustements will be added to polish this new behavior: * Create 2 new DB columns: suggestions.lastmodificationby and suggestion.lastmodificationdate * Choose a manager when editing a suggestion * Batch modify suggestions and set a manager for them * Let notify the new manager using the TO_PROCESS letter * Display the manageddate, lastmodificationby and lastmodificationdate info where appropriate This first patch adds a new "Select manager" link when editing a suggestion. Test plan for the whole patchset: 0/ a. Execute the update DB entry, generate the new DBIC file and restart all b. Create at least 2 patrons with the suggestions_manage permission 1/ Submit a new suggestion (OPAC or staff, not important) 2/ Accept it 3/ Edit it => "Last modification by" is empty => You see that you are the manager of this suggestion 4/ Click "Select manager" and search for a new manager => The patron search will only display patrons with the suggestions_manage permission 5/ Save 6/ Edit again => The manager is set to you, but there is a note saying that previously it was the patron you picked => The "Last modification by" is set to you 7/ Click "Keep existing manager" => The manager is now set to the previous manager 8/ Select another manager (which has a valid email address defined) 9/ Click the "notify" checkbox 10/ Save 11/ Confirm that a TO_PROCESS notice has been generated into the message_queue table 12/ Create at least one other suggestion 13/ List the suggestions => There is a 4th action column to assign a manager to several suggestions in one go. 14/ Use this new button and confirm that it works as expected 15/ Go to your purchase suggestion list (OPAC and staff) => You see the "managed date" displayed in a new column -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 16:12:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 15:12:48 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-vkKZogLqyH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95163 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95163&action=edit Bug 23590: Clean TT variables for patrons Just a bit of cleaning -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 16:12:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 15:12:52 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-UxGCVBqnwE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95164 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95164&action=edit Bug 23590: Cleaning - Remove op_* vars -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 16:12:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 15:12:55 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-OEVPSVuISC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95165 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95165&action=edit Bug 23590: Batch update manager for suggestions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 16:12:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 15:12:59 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-jZy46zdEzu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95166 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95166&action=edit Bug 23590: Only return patrons that have the suggestions_manage permission -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 16:13:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 15:13:03 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-LFssgL9hjO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95167 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95167&action=edit Bug 23590: Add the ability to notify a new manager -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 16:13:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 15:13:06 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-LbD8n3pO6e@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95168 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95168&action=edit Bug 23590: Display managed date in 'Your purchase suggestions' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 16:13:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 15:13:10 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-FxCe9U4aQf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95169 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95169&action=edit Bug 23590: Add lastmodification by and date columns No tests are provided for the changes made to SearchSuggestion. It is going to be remove very soon as it is super ugly... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 16:13:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 15:13:18 +0000 Subject: [Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record In-Reply-To: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14963-70-DbFdls0yRN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 16:13:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 15:13:21 +0000 Subject: [Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record In-Reply-To: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14963-70-qfOUui2ELL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95170 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95170&action=edit Bug 14963: Add the ability to suggest purchase on existing title This patch adds the ability to create a new purchase suggestion from an existing title. This will prevent the creation of bibliographic records that already exist in the catalogue. Also it will ease the process during acquisition. Test plan: - Login at the OPAC and go to the detail of a bibliographic record. - Note that there is a new link "New purchase suggestion for this title" on the right of the screen - Please suggest an other icon if that one is not appropriated - Click on it and submit your new suggestion => You should not get the confirmation screen (introduced by bug 14973) warning you that the title already exists. - Login staff side and order from this suggestion. - Receive items and confirm that a new bibliographic record is not created. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 16:15:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 15:15:02 +0000 Subject: [Koha-bugs] [Bug 21507] Decimal separators issues in patrons payments/fines, simplified In-Reply-To: <bug-21507-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21507-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21507-70-ARJrolzuov@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21507 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Severity|major |critical -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 16:15:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 15:15:10 +0000 Subject: [Koha-bugs] [Bug 19521] Partial fine payment is not working with comma decimal separator In-Reply-To: <bug-19521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19521-70-w9ORMTkS0r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |major CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 16:15:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 15:15:21 +0000 Subject: [Koha-bugs] [Bug 23988] New: When replace record with z39.50, give option on what gets pre-populated Message-ID: <bug-23988-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23988 Bug ID: 23988 Summary: When replace record with z39.50, give option on what gets pre-populated Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Currently in Koha, when a user chooses to replace an existing record with another record using z39.50, Koha will prepopulate the z39.50 search with Title, Author and ISBN. This search is very constrictive and it would be nice to have the option of what fields get prepopulated instead of having to manually remove the fields that the user doesn't want. Specifically, an ISBN pre-population would be ideal for a library. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 16:27:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 15:27:15 +0000 Subject: [Koha-bugs] [Bug 23988] When replace record with z39.50, give option on what gets pre-populated In-Reply-To: <bug-23988-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23988-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23988-70-oekzKwPqZY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23988 Peggy Thrasher <p.thrasher at dover.nh.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |p.thrasher at dover.nh.gov --- Comment #1 from Peggy Thrasher <p.thrasher at dover.nh.gov> --- It would make our lives so much easier if this had only the ISBN filled in. Dover Public Library, NH -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 16:48:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 15:48:34 +0000 Subject: [Koha-bugs] [Bug 23989] New: Enable SSO options for SelfCheck modules for Koha Message-ID: <bug-23989-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23989 Bug ID: 23989 Summary: Enable SSO options for SelfCheck modules for Koha Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Self checkout Assignee: koha-bugs at lists.koha-community.org Reporter: jzairo at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Currently the self check module allow users to sign in via cardnumber, or userid/password. The sign in form should be extended to allow SSO options (LDAP/Shibboleth/OAuth/etc.) on this login form. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 16:48:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 15:48:57 +0000 Subject: [Koha-bugs] [Bug 23989] Enable SSO options for SelfCheck modules for Koha In-Reply-To: <bug-23989-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23989-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23989-70-fqvwcTy3F9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23989 Jessie Zairo <jzairo at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 16:49:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 15:49:10 +0000 Subject: [Koha-bugs] [Bug 23989] Enable SSO options for SelfCheck modules for Koha In-Reply-To: <bug-23989-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23989-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23989-70-O5WDIt5pNC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23989 Jessie Zairo <jzairo at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 17:25:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 16:25:24 +0000 Subject: [Koha-bugs] [Bug 8437] Large database backups and large exports from export.pl fail under plack In-Reply-To: <bug-8437-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8437-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8437-70-eJKE5tcr2c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8437 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Severity|critical |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 17:37:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 16:37:52 +0000 Subject: [Koha-bugs] [Bug 23990] New: Move C4::Suggestions code to the Koha namespace Message-ID: <bug-23990-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990 Bug ID: 23990 Summary: Move C4::Suggestions code to the Koha namespace Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 17:38:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 16:38:13 +0000 Subject: [Koha-bugs] [Bug 15449] Move stuffs to the Koha namespace In-Reply-To: <bug-15449-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15449-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15449-70-liYl5NPlDD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23990 --- Comment #24 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Bug 23990 - Move C4::Suggestions code to the Koha namespace Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990 [Bug 23990] Move C4::Suggestions code to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 17:38:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 16:38:13 +0000 Subject: [Koha-bugs] [Bug 23990] Move C4::Suggestions code to the Koha namespace In-Reply-To: <bug-23990-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23990-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23990-70-fz7TGrQOk2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15449 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 [Bug 15449] Move stuffs to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 17:39:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 16:39:07 +0000 Subject: [Koha-bugs] [Bug 23991] New: Move SearchSuggestion to Koha::Suggestions Message-ID: <bug-23991-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Bug ID: 23991 Summary: Move SearchSuggestion to Koha::Suggestions Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 17:39:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 16:39:53 +0000 Subject: [Koha-bugs] [Bug 23990] Move C4::Suggestions code to the Koha namespace In-Reply-To: <bug-23990-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23990-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23990-70-brlchSHM8w@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23991 Blocks|15449 | --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Bug 23991 - Move SearchSuggestion to Koha::Suggestions Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 [Bug 15449] Move stuffs to the Koha namespace https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 [Bug 23991] Move SearchSuggestion to Koha::Suggestions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 17:39:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 16:39:53 +0000 Subject: [Koha-bugs] [Bug 15449] Move stuffs to the Koha namespace In-Reply-To: <bug-15449-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15449-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15449-70-1lbeONhO4i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|23990 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990 [Bug 23990] Move C4::Suggestions code to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 17:39:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 16:39:53 +0000 Subject: [Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions In-Reply-To: <bug-23991-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23991-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23991-70-hQSIU78TqF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23990 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990 [Bug 23990] Move C4::Suggestions code to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 17:40:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 16:40:04 +0000 Subject: [Koha-bugs] [Bug 23986] Batch Record Deletion does not remove records from search index In-Reply-To: <bug-23986-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23986-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23986-70-2SsrwCcS9M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23986 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 17:40:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 16:40:06 +0000 Subject: [Koha-bugs] [Bug 23986] Batch Record Deletion does not remove records from search index In-Reply-To: <bug-23986-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23986-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23986-70-oK4NZNrHu9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23986 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95171 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95171&action=edit Bug 23986: Remove sort from batch bib deletion After lots and lots fo digging, I removed the sort from this loop. Somehow, this allows the ES records to be deleted. I do not understand this patch, but it works. Possibly we need to sort the error arrays after the fact To test: 1 - Have or create a bib 2 - Go to Tools->Batch record deletion 3 - Click 'Enter a list of record numbers' 4 - Enter the biblionumber' 5 - Confirm deletion 6 - Search for the record, it still appears 7 - Apply patch, restart all the things 8 - Repeat 1-6 9 - This time the record is deleted -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 17:40:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 16:40:20 +0000 Subject: [Koha-bugs] [Bug 23990] Move C4::Suggestions code to the Koha namespace In-Reply-To: <bug-23990-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23990-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23990-70-cJLPB3mgd7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15449 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 [Bug 15449] Move stuffs to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 17:40:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 16:40:20 +0000 Subject: [Koha-bugs] [Bug 15449] Move stuffs to the Koha namespace In-Reply-To: <bug-15449-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15449-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15449-70-eICoApYIWU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23990 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23990 [Bug 23990] Move C4::Suggestions code to the Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 17:40:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 16:40:35 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-AJUUqG6iar@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23991 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 [Bug 23991] Move SearchSuggestion to Koha::Suggestions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 17:40:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 16:40:35 +0000 Subject: [Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions In-Reply-To: <bug-23991-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23991-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23991-70-FhS9D02kgg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23590 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 [Bug 23590] Allow to modify the manager of a suggestion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 17:41:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 16:41:18 +0000 Subject: [Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions In-Reply-To: <bug-23991-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23991-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23991-70-b8lCxEKjGs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95172 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95172&action=edit Bug 23991: Move SearchSuggestion to Koha::Suggestions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 17:41:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 16:41:43 +0000 Subject: [Koha-bugs] [Bug 23986] Batch Record Deletion does not remove records from search index In-Reply-To: <bug-23986-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23986-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23986-70-AjozAgruL9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23986 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | CC| |alex.arnaud at biblibre.com, | |ere.maijala at helsinki.fi, | |fridolin.somers at biblibre.co | |m, glasklas at gmail.com, | |jonathan.druart at bugs.koha-c | |ommunity.org, | |joonas.kylmala at helsinki.fi, | |julian.maurice at biblibre.com | |, m.de.rooy at rijksmuseum.nl, | |martin.renvoize at ptfs-europe | |.com, tomascohen at gmail.com --- Comment #2 from Nick Clemens <nick at bywatersolutions.com> --- I could use a hand understanding what is happening here -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 17:42:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 16:42:00 +0000 Subject: [Koha-bugs] [Bug 23991] Move SearchSuggestion to Koha::Suggestions In-Reply-To: <bug-23991-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23991-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23991-70-GCoNpOxlCw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23991 --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- The hardest part is missing, suggestion/suggestion.pl I will come back to this one later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 17:42:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 16:42:12 +0000 Subject: [Koha-bugs] [Bug 23986] Batch Record Deletion does not remove records from Elasticsearch search index In-Reply-To: <bug-23986-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23986-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23986-70-P0MGKKL4b5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23986 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Batch Record Deletion does |Batch Record Deletion does |not remove records from |not remove records from |search index |Elasticsearch search index -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 17:42:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 16:42:48 +0000 Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them In-Reply-To: <bug-8132-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8132-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8132-70-qRVqtxF4kS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 18:04:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 17:04:02 +0000 Subject: [Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record In-Reply-To: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14963-70-NprIJAriWn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #3 from Séverine Queune <severine.queune at bulac.fr> --- Hi Jonathan, I found 2 issues. I have this software error : "Tag "" is not a valid tag. at /var/repositories/koha/C4/Suggestions.pm line 690." when I want to add a suggestion using the empty form (opac & staff client) and saving a suggestion modification on staff client (no problem using the checkbox and drop-down menu). For suggestions made from an existing notice, suggestion status is not update after the adding to a basket (no problem for suggestions made from the empty form, and for the "Available" status after the receipt). Except these point, everything seems very clear to me and respond to our needs, so thanks a lot ! Icon on opac is ok for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 18:15:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 17:15:03 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-Kn8WXQkM0P@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #9 from Séverine Queune <severine.queune at bulac.fr> --- Patch failed on both sandbox and devbox. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 23590: Add ability to edit the manager of a suggestion fatal: sha1 information is lacking or useless (koha-tmpl/intranet-tmpl/prog/en/modules/suggestion/suggestion.tt). Repository lacks necessary blobs to fall back on 3-way merge. Cannot fall back to three-way merge. Patch failed at 0001 Bug 23590: Add ability to edit the manager of a suggestion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 18:17:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 17:17:00 +0000 Subject: [Koha-bugs] [Bug 18731] Add routes for acquisition orders In-Reply-To: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18731-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18731-70-cVGxEGmknH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18731 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nicolas.legrand at bulac.fr, | |severine.queune at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 18:19:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 17:19:02 +0000 Subject: [Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record In-Reply-To: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14963-70-LYnT6oBVnX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95173 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95173&action=edit Bug 14963: Set status=ORDERED for suggestions created from existing record -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 18:22:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 17:22:01 +0000 Subject: [Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record In-Reply-To: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14963-70-OYaBUJRJB9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Séverine Queune from comment #3) > Hi Jonathan, > > I found 2 issues. > > I have this software error : "Tag "" is not a valid tag. at > /var/repositories/koha/C4/Suggestions.pm line 690." when I want to add a > suggestion using the empty form (opac & staff client) and saving a > suggestion modification on staff client (no problem using the checkbox and > drop-down menu). I do not understand that one. There are 2 bugs opened with this error but no idea where the error comes from. Can you detail a bit more? Reading the code it seems related to the item type. (for the record) 685 my ($it_tag, $it_subfield) = GetMarcFromKohaField('biblioitems.itemtype', ''); 686 if ($record->field( $it_tag )) { 687 $record->field( $it_tag )->add_subfields( $it_subfield => $suggestion->{itemtype} ); 688 } 689 else { 690 $record->append_fields( 691 MARC::Field->new($it_tag, ' ', ' ', $it_subfield => $suggestion->{itemtype}) 692 ); 693 } > For suggestions made from an existing notice, suggestion status is not > update after the adding to a basket (no problem for suggestions made from > the empty form, and for the "Available" status after the receipt). Fixed! > Except these point, everything seems very clear to me and respond to our > needs, so thanks a lot ! > Icon on opac is ok for me. Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 18:28:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 17:28:19 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-DCWuLo65F3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff URL| |https://gitlab.com/joubu/Ko | |ha/commits/bug_23590 --- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- The patches need to be applied in the following (reverse) order: Bug 23590: Add lastmodification by and date columns Bug 23590: Display managed date in 'Your purchase suggestions' Bug 23590: Add the ability to notify a new manager Bug 23590: Only return patrons that have the suggestions_manage permission Bug 23590: Batch update manager for suggestions Bug 23590: Cleaning - Remove op_* vars Bug 23590: Clean TT variables for patrons Bug 23590: Add ability to edit the manager of a suggestion Bug 14963: Set status=ORDERED for suggestions created from existing record Bug 14963: Add the ability to suggest purchase on existing title Bug 23854: Fix failure on dates when editing a suggestion Bug 23594: Restore previous view after delete or update itemtype Bug 23594: Fix [un]checkall links Bug 23594: Batch modification for itemtypes on suggestions page Bug 14973: Add missing filters in templates Bug 14973: Remove double declaration of suggestions_loop Bug 14973: Remove double textarea for notes Bug 14973: Do not skip validation step when submiting a suggestion - OPAC Bug 14973: Check existing biblio when submitting a purchase suggestion (staff side) Bug 14973: Check existing biblio when submitting a purchase suggestion (opac side) If it can help, I have pushed a branch with all the patches applied: https://gitlab.com/joubu/Koha/commits/bug_23590 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 18:52:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 17:52:18 +0000 Subject: [Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record In-Reply-To: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14963-70-gzNoFJwke6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 --- Comment #6 from Séverine Queune <severine.queune at bulac.fr> --- (In reply to Jonathan Druart from comment #5) > (In reply to Séverine Queune from comment #3) > > Hi Jonathan, > > > > I found 2 issues. > > > > I have this software error : "Tag "" is not a valid tag. at > > /var/repositories/koha/C4/Suggestions.pm line 690." when I want to add a > > suggestion using the empty form (opac & staff client) and saving a > > suggestion modification on staff client (no problem using the checkbox and > > drop-down menu). > > I do not understand that one. There are 2 bugs opened with this error but no > idea where the error comes from. Can you detail a bit more? > Reading the code it seems related to the item type. > > (for the record) > 685 my ($it_tag, $it_subfield) = > GetMarcFromKohaField('biblioitems.itemtype', ''); > 686 if ($record->field( $it_tag )) { > 687 $record->field( $it_tag )->add_subfields( $it_subfield => > $suggestion->{itemtype} ); > 688 } > 689 else { > 690 $record->append_fields( > 691 MARC::Field->new($it_tag, ' ', ' ', $it_subfield => > $suggestion->{itemtype}) > 692 ); > 693 } Oh... Weird... In my instance, there is no field mapped to biblioitems.itemtype, but if I add one, I can save the suggestion correctly. Is it the expected / future behaviour ? This a problem we don't have with 18.05.00 so we'll have to be be aware about adding a mapping for biblioitems.itemtype if so. My second try was an on different computer with a different resolution screen, I noticed a tiny display issu with the new link in OPAC (see attachement). Sorry I missed that on first test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 18:52:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 17:52:36 +0000 Subject: [Koha-bugs] [Bug 22831] Elasticsearch - add a maintenance script for checking DB vs index counts In-Reply-To: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22831-70-kGTA7GX77E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- record ids should be sorted numerically. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 18:53:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 17:53:29 +0000 Subject: [Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record In-Reply-To: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14963-70-fUJpVpRkJN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 --- Comment #7 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 95174 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95174&action=edit Tiny gap before the new "Suggestion" link -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 19:15:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 18:15:31 +0000 Subject: [Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record In-Reply-To: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14963-70-yyMsVu1UIa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 --- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95175 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95175&action=edit Bug 14963: Fix ergonomic issue on small screen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 19:19:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 18:19:15 +0000 Subject: [Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record In-Reply-To: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14963-70-OSP3mSdGMN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Séverine Queune from comment #6) > (In reply to Jonathan Druart from comment #5) > > (In reply to Séverine Queune from comment #3) > > > Hi Jonathan, > > > > > > I found 2 issues. > > > > > > I have this software error : "Tag "" is not a valid tag. at > > > /var/repositories/koha/C4/Suggestions.pm line 690." when I want to add a > > > suggestion using the empty form (opac & staff client) and saving a > > > suggestion modification on staff client (no problem using the checkbox and > > > drop-down menu). > > > > I do not understand that one. There are 2 bugs opened with this error but no > > idea where the error comes from. Can you detail a bit more? > > Reading the code it seems related to the item type. > > > > (for the record) > > 685 my ($it_tag, $it_subfield) = > > GetMarcFromKohaField('biblioitems.itemtype', ''); > > 686 if ($record->field( $it_tag )) { > > 687 $record->field( $it_tag )->add_subfields( $it_subfield => > > $suggestion->{itemtype} ); > > 688 } > > 689 else { > > 690 $record->append_fields( > > 691 MARC::Field->new($it_tag, ' ', ' ', $it_subfield => > > $suggestion->{itemtype}) > > 692 ); > > 693 } > > Oh... Weird... In my instance, there is no field mapped to > biblioitems.itemtype, but if I add one, I can save the suggestion correctly. > Is it the expected / future behaviour ? > This a problem we don't have with 18.05.00 so we'll have to be be aware > about adding a mapping for biblioitems.itemtype if so. I am not sure, but the code that is exploding comes from bug 14973 (so not pushed yet). Do you know why you do not have this mapping? Discussion should continue on bug 14973 if needed. > My second try was an on different computer with a different resolution > screen, I noticed a tiny display issu with the new link in OPAC (see > attachement). Sorry I missed that on first test. Fixed. You will need to regenerate the CSS file to see the changes: yarn build --view opac -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 19:49:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 18:49:31 +0000 Subject: [Koha-bugs] [Bug 22831] Elasticsearch - add a maintenance script for checking DB vs index counts In-Reply-To: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22831-70-M4MnPopwVm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 --- Comment #18 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95176 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95176&action=edit Bug 22831: (follow-up) Sort results, group by db -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 19:54:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 18:54:13 +0000 Subject: [Koha-bugs] [Bug 23960] Issue with MariaDB version (rows column name in creator_template table) In-Reply-To: <bug-23960-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23960-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23960-70-36NkB7hukH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23960 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Label/patron card printing |Database --- Comment #1 from Chris Cormack <chris at bigballofwax.co.nz> --- Switching to the DB component so we can try to gather all the DB changes together -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 20:08:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 19:08:01 +0000 Subject: [Koha-bugs] [Bug 17875] Linking to series authority records fails when a space precedes the semicolon In-Reply-To: <bug-17875-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17875-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17875-70-LPNd7knXzp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17875 Lisette Scheer <lisetteslatah at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 21:21:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 20:21:23 +0000 Subject: [Koha-bugs] [Bug 15732] Remove accountno column from accountlines In-Reply-To: <bug-15732-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15732-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15732-70-sVe7ATWmvd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15732 Rocio Dressler <rocio at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rocio at bywatersolutions.com --- Comment #2 from Rocio Dressler <rocio at bywatersolutions.com> --- I agree!! And it's a required field so has to be supplied when migrating fines. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 21:34:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 20:34:36 +0000 Subject: [Koha-bugs] [Bug 23992] New: Adding multiple items with barcode might end with infinite loop if same barcode will be next_value Message-ID: <bug-23992-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23992 Bug ID: 23992 Summary: Adding multiple items with barcode might end with infinite loop if same barcode will be next_value Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: nugged at gmail.com Reporter: nugged at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl In /cataloguing/additem.pl we had the comment: "FIXME : Please note that there is a risk of infinite loop here if we never find a suitable barcode". I researched that when we are adding '$number_of_copies', there will be no infinite loop there in that 'for' loop EXCEPT if the 'next_value' method will return the same but defined barcode only (border case1). Other cases: - without a barcode code always adds any number of items in a sequential way, so nothing to fix, - if we have '$barcodevalue' defined in the beginning, code adds items with barcodes generating them with 'next_value', if then no barcode will be generated in 'next_value' then '$exist_itemnumber' will not be defined, so loop will keep adding items without barcodes. Sequentially. (case2) - if barcode will be occupied so it will be skipped until next barcode will be generated, a free one, this was discussed with KohaSuomi as "might be not needed" but because this already created in this way in KC so let's keep this logic, so nothing to fix here too. I am preparing patch to generate in case2: "no_barcode_value" error message if it was started with a barcode and no more barcodes generated, or in case1: if the barcode after 'next_value' will be the same as old value. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 22:22:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 21:22:07 +0000 Subject: [Koha-bugs] [Bug 15732] Remove accountno column from accountlines In-Reply-To: <bug-15732-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15732-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15732-70-ra8mZmDSpU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15732 Rocio Dressler <rocio at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Rocio Dressler <rocio at bywatersolutions.com> --- *** This bug has been marked as a duplicate of bug 21683 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 22:22:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 21:22:07 +0000 Subject: [Koha-bugs] [Bug 21683] Remove accountlines.accountno In-Reply-To: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21683-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21683-70-IWFH2ev96C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21683 --- Comment #51 from Rocio Dressler <rocio at bywatersolutions.com> --- *** Bug 15732 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 22:48:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 21:48:09 +0000 Subject: [Koha-bugs] [Bug 13775] software error when choosing authority via plugin In-Reply-To: <bug-13775-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13775-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13775-70-SFHjgner84@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13775 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Severity|critical |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 22:48:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 21:48:22 +0000 Subject: [Koha-bugs] [Bug 13775] software error when choosing authority via plugin In-Reply-To: <bug-13775-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13775-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13775-70-e3cr71EQnN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13775 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 22:49:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 21:49:03 +0000 Subject: [Koha-bugs] [Bug 13775] software error when choosing authority via plugin In-Reply-To: <bug-13775-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13775-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13775-70-pA79bhiIhm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13775 --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Wondering if this one is still relevant and whether Katrins information was enough and you wanted to take this forward Jonathan? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 22:49:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 21:49:51 +0000 Subject: [Koha-bugs] [Bug 9715] Various combinations of prefs QueryAutoTruncate, QueryFuzzy and QueryWeightFields conflict In-Reply-To: <bug-9715-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9715-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9715-70-j4trpsDka2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9715 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 7 23:39:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 07 Nov 2019 22:39:57 +0000 Subject: [Koha-bugs] [Bug 21496] install.pl: DBD::mysql::st execute failed: Index column size too large. The maximum column size is 767 bytes. at /usr/share/perl5/DBIx/RunSQL.pm line 273. In-Reply-To: <bug-21496-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21496-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21496-70-lDfK2VpRNZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21496 Jorge Rodriguez <jorge.molina at urural.edu.gt> changed: What |Removed |Added ---------------------------------------------------------------------------- Ever confirmed|1 |0 Severity|enhancement |new feature CC| |jorge.molina at urural.edu.gt Status|RESOLVED |UNCONFIRMED Resolution|INVALID |--- --- Comment #4 from Jorge Rodriguez <jorge.molina at urural.edu.gt> --- install.pl: DBD::mysql::st execute failed: Table 'koha_library.audio_alerts' doesn't exist at /usr/share/perl5/DBIx/RunSQL.pm line 273. I have Ubuntu 18.04 lts y Koha Estable 19.05 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 03:07:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 02:07:47 +0000 Subject: [Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation In-Reply-To: <bug-20844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20844-70-90QTtmQ0wH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844 --- Comment #32 from David Cook <dcook at prosentient.com.au> --- Comment on attachment 81710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81710 Bug 20844: Revert hold when setting an item to lost Review of attachment 81710: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20844&attachment=81710) ----------------------------------------------------------------- ::: C4/Circulation.pm @@ +3688,5 @@ > + my $LostItemLevelHold; > + if ( $restype eq "Waiting" || $restype eq "Reserved" ) { > + if ( $res->{originalholdtype} eq "B" ) { > + #originalholdtype equalling "B" means this is a bib level hold > + C4::Reserves::RevertWaitingStatus({itemnumber => $itemnumber}); This line appears to be buggy. I haven't fully investigated, but if the hold type is B, the itemnumber can't be used to look up the reserve, and eventually causes a fatal error in _FixPriority (due to a lack of error handling in RevertWaitingStatus, _FixPriority, etc.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 03:11:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 02:11:32 +0000 Subject: [Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation In-Reply-To: <bug-20844-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20844-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20844-70-gsIstcbw7V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #33 from David Cook <dcook at prosentient.com.au> --- Ran into this problem as it was causing /usr/share/koha/bin/cronjobs/longoverdue.pl to seemingly randomly die when this patch is applied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 04:00:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 03:00:46 +0000 Subject: [Koha-bugs] [Bug 23986] Batch Record Deletion does not remove records from Elasticsearch search index In-Reply-To: <bug-23986-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23986-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23986-70-IPPEVg0f6m@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23986 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95171|0 |1 is obsolete| | --- Comment #3 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95177 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95177&action=edit Bug 23986: Pass strings to Catmandu for deletion The deletion subroutine expects to get a string, this is fine in most places, but when we sort our records for batch deletion they are cast to numbers and the delete is not processed. This patch quotes the biblionumbers as strings before passing them to Catmandu To aid in detecting orphaned records you can use the patches on bug 22831 To test: 1 - Have or create a bib 2 - Go to Tools->Batch record deletion 3 - Click 'Enter a list of record numbers' 4 - Enter the biblionumber' 5 - Confirm deletion 6 - Search for the record, it still appears 7 - Apply patch, restart all the things 8 - Repeat 1-6 9 - This time the record is deleted 10 - Test other methods of record deletion to confirm the record is removed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 07:50:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 06:50:33 +0000 Subject: [Koha-bugs] [Bug 21301] Restriction of the informations given by GetRecords ILS-DI service In-Reply-To: <bug-21301-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21301-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21301-70-Y5KTuH4duY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Status|Signed Off |BLOCKED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 07:55:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 06:55:36 +0000 Subject: [Koha-bugs] [Bug 22831] Elasticsearch - add a maintenance script for checking DB vs index counts In-Reply-To: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22831-70-GfiPzJAHDB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 07:56:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 06:56:28 +0000 Subject: [Koha-bugs] [Bug 23989] Enable SSO options for SelfCheck modules for Koha In-Reply-To: <bug-23989-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23989-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23989-70-Fd0zxcvhnl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23989 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 07:58:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 06:58:48 +0000 Subject: [Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images In-Reply-To: <bug-22445-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22445-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22445-70-K7Y9GmL3hE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Joonas Kylmälä <joonas.kylmala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at helsinki.fi --- Comment #119 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> --- The database upgrade breaks on my kohadevbox setup (mysql-server package version 5.7.27-0ubuntu0.18.04.1): > $ updatedatabase > Upgrade to 19.06.00.042 done (Bug 22445 - Add new pref *CustomCoverImages*) > DBD::mysql::db do failed: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'IGNORE TABLE accountlines > ADD > debit_type_code ' at line 1 [for Statement " > ALTER IGNORE TABLE accountlines > ADD > debit_type_code varchar(80) DEFAULT NULL > AFTER > accounttype > "] at /home/koha/kohaclone/installer/data/mysql/updatedatabase.pl line 19888. > DBD::mysql::db do failed: Key column 'debit_type_code' doesn't exist in table [for Statement " > ALTER TABLE accountlines ADD CONSTRAINT `accountlines_ibfk_debit_type` FOREIGN KEY (`debit_type_code`) REFERENCES `account_debit_types` (`code`) ON DELETE RESTRICT ON UPDATE CASCADE > "] at /home/koha/kohaclone/installer/data/mysql/updatedatabase.pl line 19901. > DBD::mysql::db do failed: Unknown column 'debit_type_code' in 'field list' [for Statement " > UPDATE accountlines SET debit_type_code = accounttype, accounttype = NULL WHERE accounttype IN (SELECT code from account_debit_types) > "] at /home/koha/kohaclone/installer/data/mysql/updatedatabase.pl line 19910. > Upgrade to 19.06.00.043 done (Bug 23049 - Add account debit_types) > DBD::mysql::db do failed: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'IGNORE TABLE accountlines > ADD > credit_type_code' at line 1 [for Statement " > ALTER IGNORE TABLE accountlines > ADD > credit_type_code varchar(80) DEFAULT NULL > AFTER > accounttype > "] at /home/koha/kohaclone/installer/data/mysql/updatedatabase.pl line 19992. > DBD::mysql::db do failed: Key column 'credit_type_code' doesn't exist in table [for Statement " > ALTER TABLE accountlines > ADD CONSTRAINT > `accountlines_ibfk_credit_type` > FOREIGN KEY (`credit_type_code`) REFERENCES `account_credit_types` (`code`) > ON DELETE RESTRICT > ON UPDATE CASCADE > "] at /home/koha/kohaclone/installer/data/mysql/updatedatabase.pl line 20005. > DBD::mysql::db do failed: Unknown column 'credit_type_code' in 'field list' [for Statement " > UPDATE > accountlines > SET > credit_type_code = accounttype, accounttype = NULL > WHERE accounttype IN (SELECT code from account_credit_types) > "] at /home/koha/kohaclone/installer/data/mysql/updatedatabase.pl line 20067. > Upgrade to 19.06.00.044 done (Bug 23805 - Add account credit_types) > Upgrade to 19.06.00.045 done (Bug 23866 - Set HEA syspref to prompt for review) > Upgrade to 19.06.00.046 done (Bug 15260 - Option for extended loan with useDaysMode) > Upgrade to 19.06.00.047 done (Bug 14697 - Extend and enhance 'Claims returned' lost status) > Upgrade to 19.06.00.048 done (Bug 22581 - add new OPACShowMusicalInscripts and OPACPlayMusicalInscripts system preferences) > Upgrade to 19.06.00.049 done (Bug 13958 - Add a SuspensionsCalendar syspref) > Upgrade to 19.06.00.050 done (Bug 23293 - Add 'OPACFineNoRenewalsIncludeCredits' system preference) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 08:17:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 07:17:59 +0000 Subject: [Koha-bugs] [Bug 21301] Restriction of the informations given by GetRecords ILS-DI service In-Reply-To: <bug-21301-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21301-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21301-70-EEq9GpIUwD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301 --- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Fridolin SOMERS from comment #2) > The issue data should not be sent by these service, its a privacy problem. <reserve> <suspend>0</suspend> <biblionumber>633</biblionumber> <timestamp>2019-11-08 07:06:05</timestamp> <borrowernumber>5</borrowernumber> <lowestPriority>0</lowestPriority> <reservedate>2019-11-08</reservedate> <priority>1</priority> <reserve_id>110</reserve_id> <branchcode>CPL</branchcode> <item_level_hold>0</item_level_hold> </reserve> Is this really a privacy issue? In order to identify the person associated with borrowernumber 5, you'll need additional information. So if this is just theoretical, then removing the borrowernumber might not be enough ;) If I have biblionumber and reservedata or timestamp, I might also be able to find the associated borrower? No blocker, just pushing a bit.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 08:23:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 07:23:36 +0000 Subject: [Koha-bugs] [Bug 21301] Restriction of the informations given by GetRecords ILS-DI service In-Reply-To: <bug-21301-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21301-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21301-70-rhGDdjzJGk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301 --- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- More serious: <issue> <issuedate>2019-11-08 07:21:08</issuedate> <onsite_checkout>0</onsite_checkout> <itemnumber>598</itemnumber> <branchcode>CPL</branchcode> <date_due>2019-11-22 23:59:00</date_due> <barcode>perl01</barcode> <issue_id>690</issue_id> <renewals>0</renewals> <timestamp>2019-11-08 07:21:08</timestamp> <auto_renew>0</auto_renew> <borrowernumber>5</borrowernumber> </issue> If you are concerned about borrowernumber in hold, then you should be for issue too. Inconsistent ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 08:26:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 07:26:14 +0000 Subject: [Koha-bugs] [Bug 21301] Restriction of the informations given by GetRecords ILS-DI service In-Reply-To: <bug-21301-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21301-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21301-70-xlc5PLySuT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |major --- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Lowering the severity to Major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 08:27:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 07:27:10 +0000 Subject: [Koha-bugs] [Bug 21301] Restriction of the informations given by GetRecords ILS-DI service In-Reply-To: <bug-21301-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21301-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21301-70-B5HfjLgHW2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA --- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- I do expect additional tests here too. Your test should show that the sensitive information is no longer in the output of GetRecords etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 08:29:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 07:29:46 +0000 Subject: [Koha-bugs] [Bug 23398] Exporting/Reimporting frameworks in XML format will give incomplete results In-Reply-To: <bug-23398-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23398-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23398-70-sMo5TgXqUQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23398 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 08:31:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 07:31:02 +0000 Subject: [Koha-bugs] [Bug 21301] Restriction of the informations given by GetRecords ILS-DI service In-Reply-To: <bug-21301-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21301-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21301-70-sdLQDtCirV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21301 --- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 95178 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95178&action=edit Bug 21301: (QA follow-up) Fix number of tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 08:34:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 07:34:49 +0000 Subject: [Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images In-Reply-To: <bug-22445-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22445-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22445-70-1P8xXqsEg0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #120 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> --- (In reply to Joonas Kylmälä from comment #119) > The database upgrade breaks on my kohadevbox setup (mysql-server package > version 5.7.27-0ubuntu0.18.04.1): Looking again at the error message the bug is probably from Bug 23049 and not this. Sorry for the noise. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 08:40:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 07:40:12 +0000 Subject: [Koha-bugs] [Bug 23398] Exporting/Reimporting frameworks in XML format will give incomplete results In-Reply-To: <bug-23398-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23398-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23398-70-n8cCf865yQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23398 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 08:40:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 07:40:15 +0000 Subject: [Koha-bugs] [Bug 23398] Exporting/Reimporting frameworks in XML format will give incomplete results In-Reply-To: <bug-23398-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23398-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23398-70-DS74xyzc5q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23398 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95161|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 95179 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95179&action=edit Bug 23398: Disable the XML import/export format for biblio framework It gives incomplete results and not sure it ever worked. To prevent data loss it is better to remove this option. Note that the code in C4/ImportExportFramework.pm is too complex to attach with this patch to deletion of the code related to the XML import/export. Safer to keep it for a separate bug report. Test plan: Import/export biblio frameworks and confirm that there is no more reference to the xml format. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 08:47:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 07:47:47 +0000 Subject: [Koha-bugs] [Bug 23949] koha-common.init missing actions for koha-z3950-responder In-Reply-To: <bug-23949-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23949-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23949-70-bCZJopZGEz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 08:47:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 07:47:50 +0000 Subject: [Koha-bugs] [Bug 23949] koha-common.init missing actions for koha-z3950-responder In-Reply-To: <bug-23949-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23949-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23949-70-pbRctgnGnE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95133|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 95180 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95180&action=edit Bug 23949: Add missing actions for koha-z3950-responder in koha-common.init This patch makes the init script deal with koha-z3950-responder in --stop and --restart actions. Currently, only --start calls the script. To test: - Enable the server: $ koha-z3950-responder --enable kohadev - Stop koha-common $ service koha-common stop => SUCCESS: No koha-z3950-responder running - Start koha-common $ service koha-common start => SUCCESS: It is loaded (even if failing because of config issues) - Stop koha-common $ service koha-common stop => FAIL: It is still running (no --stop issued) - Repeat for restart - Apply this patch - Redo => SUCCESS: Things behave as expected! - Sign off :-D Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 08:47:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 07:47:54 +0000 Subject: [Koha-bugs] [Bug 23949] koha-common.init missing actions for koha-z3950-responder In-Reply-To: <bug-23949-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23949-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23949-70-WK1Ye4KEl7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95134|0 |1 is obsolete| | --- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 95181 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95181&action=edit Bug 23949: Update documentation Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 08:47:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 07:47:58 +0000 Subject: [Koha-bugs] [Bug 23949] koha-common.init missing actions for koha-z3950-responder In-Reply-To: <bug-23949-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23949-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23949-70-ZVtFnFD8tH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95135|0 |1 is obsolete| | --- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 95182 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95182&action=edit Bug 23949: Add z3950 directory to koha-common.install Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 08:48:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 07:48:08 +0000 Subject: [Koha-bugs] [Bug 23949] koha-common.init missing actions for koha-z3950-responder In-Reply-To: <bug-23949-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23949-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23949-70-gXcCqafEZL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 09:00:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 08:00:39 +0000 Subject: [Koha-bugs] [Bug 23983] Contextualization of "Order" (verb) vs "Order" (noun) In-Reply-To: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23983-70-DgDixLAyqy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23983 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95129|0 |1 is obsolete| | Attachment #95160|0 |1 is obsolete| | --- Comment #7 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 95183 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95183&action=edit Bug 23983: Contextualization of 'Order' (verb) vs 'Order' (noun) This patch adds context (word class, either verb or noun) to the word 'Order' when it is displayed alone in the acquisitions module. The following files have been modified: basket.tt neworderbiblio.tt newordersubscription.tt newordersuggestion.tt ordered.tt parcel.tt spent.tt transferorder.tt uncertainprice.tt z3950_search.tt To test, check all those pages in English to make sure there is no change. 1- Go to Acquisitions 2- Create a basket 3- Add to basket from an existing record (neworderbiblio) 4- Add to basket from a subscription (newordersubscription) 5- Add to basket from a suggestion (newordersuggestion) 6- Add to basket from an external source (z3950_search) 7- In one of the orders, check the uncertain price box 8- Check the basket display table (basket) 9- Click transfer on one of the orders (transferorder) 10- Go to the vendor page and click on 'Uncertain prices' (uncertainprice) 11- Click on 'Receive parcel' (parcel) 12- Go to the Acquisitions home page and click on the amount for 'ordered' (ordered) 13- Go to the Acquisitions home page and click on the amount for 'spent' (spent) Next, install a new language (fr-CA used as example) 1- translate create fr-CA 2- open fr-CA-messages.po and add a translation for Order (verb) and Order (noun) (it doesn't have to be real, just write something different for each) 3- translate install fr-CA 4- in the system preferences, enable the french language in 'language' 5- change interface language to french Redo the tests above to make sure the word you put in the translation for the verb is in the places where 'Order' should be a verb and that the translation you put in for the noun is in the places where 'Order' should be a noun Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 09:02:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 08:02:00 +0000 Subject: [Koha-bugs] [Bug 23983] Contextualization of "Order" (verb) vs "Order" (noun) In-Reply-To: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23983-70-e6pZVco6QS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23983 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #8 from Julian Maurice <julian.maurice at biblibre.com> --- I squashed the two patches together. It works as expected. Signed off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 09:11:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 08:11:56 +0000 Subject: [Koha-bugs] [Bug 22857] Entries missing in koha-conf.xml In-Reply-To: <bug-22857-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22857-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22857-70-LgK9vaaRv7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22857 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | Status|Signed Off |BLOCKED CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 09:18:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 08:18:03 +0000 Subject: [Koha-bugs] [Bug 22857] Entries missing in koha-conf.xml In-Reply-To: <bug-22857-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22857-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22857-70-Mfa4H8ws3K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22857 --- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #5) > Reads well, just wondering if this could cause problems being there by > default when not using the Let's encrypt feature provided by Koha for your > certs? > > + <tls>__DB_USE_TLS__</tls> > + <ca>__DB_TLS_CA_CERTIFICATE__</ca> > + <cert>__DB_TLS_CLIENT_CERTIFICATE__</cert> > + <key>__DB_TLS_CLIENT_KEY__</key> This is stuff from an older 'feature': commit 84e48d03238ce2446e7ea24401bda0a8f4e4422d Author: Dimitris Kamenopoulos <dkamen at gmail.com> Date: Sun Dec 27 16:01:43 2015 +1300 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 09:18:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 08:18:50 +0000 Subject: [Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images In-Reply-To: <bug-22445-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22445-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22445-70-iufoscDGNR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 --- Comment #121 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Fix pushed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 09:34:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 08:34:31 +0000 Subject: [Koha-bugs] [Bug 23986] Batch Record Deletion does not remove records from Elasticsearch search index In-Reply-To: <bug-23986-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23986-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23986-70-yYGiWypfRS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23986 --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Now it makes sense! :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 09:35:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 08:35:24 +0000 Subject: [Koha-bugs] [Bug 22857] Entries missing in koha-conf.xml In-Reply-To: <bug-22857-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22857-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22857-70-e5jM0c6nQg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22857 --- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- if( $self->{'tls'} && $self->{'tls'} eq 'yes' ) { => if tls == __DB_USE_TLS_ (since it was not replaced by koha-create), the condition still works => But I could imagine that we should want to comment it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 10:02:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 09:02:28 +0000 Subject: [Koha-bugs] [Bug 22857] Entries missing in koha-conf.xml In-Reply-To: <bug-22857-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22857-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22857-70-Jb3XnEHpvg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22857 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 10:02:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 09:02:31 +0000 Subject: [Koha-bugs] [Bug 22857] Entries missing in koha-conf.xml In-Reply-To: <bug-22857-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22857-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22857-70-gSThFFHmu3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22857 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95048|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 95184 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95184&action=edit Bug 22857: Sync koha-conf.xml files Missing entries are added to those files. Test plan: Search for typos Compare the two files and comfirm the entries are the same in both. Exception: supportdir exists in etc/koha-conf.xml only, but I think it's obsolete. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 10:02:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 09:02:35 +0000 Subject: [Koha-bugs] [Bug 22857] Entries missing in koha-conf.xml In-Reply-To: <bug-22857-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22857-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22857-70-deVZTeqDrm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22857 --- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 95185 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95185&action=edit Bug 22857: (QA follow-up) Cosmetic changes: typo, whitespace Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 10:05:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 09:05:07 +0000 Subject: [Koha-bugs] [Bug 23993] New: Can't call method "notforloan" on an undefined value at C4/Reserves.pm line 1177. Message-ID: <bug-23993-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23993 Bug ID: 23993 Summary: Can't call method "notforloan" on an undefined value at C4/Reserves.pm line 1177. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org Imported an unknown item type. Tried to place a hold. Can't call method "notforloan" on an undefined value at /usr/share/koha/C4/Reserves.pm line 1177. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 10:18:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 09:18:53 +0000 Subject: [Koha-bugs] [Bug 23993] Can't call method "notforloan" on an undefined value at C4/Reserves.pm line 1177. In-Reply-To: <bug-23993-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23993-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23993-70-TXJlSVZCxG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23993 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 10:18:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 09:18:56 +0000 Subject: [Koha-bugs] [Bug 23993] Can't call method "notforloan" on an undefined value at C4/Reserves.pm line 1177. In-Reply-To: <bug-23993-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23993-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23993-70-KiZZEk6754@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23993 --- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 95186 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95186&action=edit Bug 23993: Add check if itemtype exists in IsAvailableForItemLevelRequest Trivial change Test plan: Run Reserves.t Import book with unknown item type, try to place hold (with/without patch) Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 10:19:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 09:19:36 +0000 Subject: [Koha-bugs] [Bug 23993] Can't call method "notforloan" on an undefined value at C4/Reserves.pm line 1177. In-Reply-To: <bug-23993-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23993-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23993-70-trdGgvQ05r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23993 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Status|Needs Signoff |Signed Off Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Trivial fix, self signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 10:27:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 09:27:41 +0000 Subject: [Koha-bugs] [Bug 23994] New: AdditionalFields.t is failing randomly (U18) Message-ID: <bug-23994-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23994 Bug ID: 23994 Summary: AdditionalFields.t is failing randomly (U18) Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org t/db_dependent/Koha/Objects/Mixin/AdditionalFields.t .. 1/12 # Failed test '->additional_field_values should return the correct values' # at t/db_dependent/Koha/Objects/Mixin/AdditionalFields.t line 82. # Structures begin differing at: # $got->[0]{value} = 'bar value for basket2' # $expected->[0]{value} = 'foo value for basket2' # Looks like you failed 1 test of 12. We do not really know why, but the values are not returned in the order they are stored in DB. Fixing this random failure for now at test level. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 10:28:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 09:28:56 +0000 Subject: [Koha-bugs] [Bug 23994] AdditionalFields.t is failing randomly (U18) In-Reply-To: <bug-23994-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23994-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23994-70-GWILwxI9rI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23994 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 10:29:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 09:29:00 +0000 Subject: [Koha-bugs] [Bug 23994] AdditionalFields.t is failing randomly (U18) In-Reply-To: <bug-23994-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23994-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23994-70-lBd8RaWWox@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23994 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95187 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95187&action=edit Bug 23994: Fix random failure from AdditionalFields.t (U18) t/db_dependent/Koha/Objects/Mixin/AdditionalFields.t .. 1/12 # Failed test '->additional_field_values should return the correct values' # at t/db_dependent/Koha/Objects/Mixin/AdditionalFields.t line 82. # Structures begin differing at: # $got->[0]{value} = 'bar value for basket2' # $expected->[0]{value} = 'foo value for basket2' # Looks like you failed 1 test of 12. We do not really know why, but the values are not returned in the order they are stored in DB. Fixing this random failure for now at test level. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 10:33:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 09:33:18 +0000 Subject: [Koha-bugs] [Bug 23994] AdditionalFields.t is failing randomly (U18) In-Reply-To: <bug-23994-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23994-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23994-70-MgdQMD6b70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23994 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 10:34:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 09:34:32 +0000 Subject: [Koha-bugs] [Bug 23994] AdditionalFields.t is failing randomly (U18) In-Reply-To: <bug-23994-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23994-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23994-70-qzHsN4JCgH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23994 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- As discussed on IRC, this works and gets the tests passing again... no idea why it returns differently on U18 but the order is unimportant in the context anyway. Passing QA and Pushing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 10:35:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 09:35:36 +0000 Subject: [Koha-bugs] [Bug 23994] AdditionalFields.t is failing randomly (U18) In-Reply-To: <bug-23994-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23994-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23994-70-kLa33Ej6oK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23994 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 10:45:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 09:45:23 +0000 Subject: [Koha-bugs] [Bug 23986] Batch Record Deletion does not remove records from Elasticsearch search index In-Reply-To: <bug-23986-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23986-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23986-70-h24cINNWLs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23986 --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I guess we could have replaced <=> with cmp, but it seems wrong (we want a numeric sort). It's weird to see the delete request ignored by Catmandu. What about tests? I do not think it should be required for this patch as it's a quite critical bugfix, but we really should start cover that area a bit more... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 10:48:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 09:48:57 +0000 Subject: [Koha-bugs] [Bug 23986] Batch Record Deletion does not remove records from Elasticsearch search index In-Reply-To: <bug-23986-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23986-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23986-70-C3Planp4QD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23986 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 10:49:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 09:49:02 +0000 Subject: [Koha-bugs] [Bug 23986] Batch Record Deletion does not remove records from Elasticsearch search index In-Reply-To: <bug-23986-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23986-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23986-70-ndpdsxr25u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23986 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95177|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95188 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95188&action=edit Bug 23986: Pass strings to Catmandu for deletion The deletion subroutine expects to get a string, this is fine in most places, but when we sort our records for batch deletion they are cast to numbers and the delete is not processed. This patch quotes the biblionumbers as strings before passing them to Catmandu To aid in detecting orphaned records you can use the patches on bug 22831 To test: 1 - Have or create a bib 2 - Go to Tools->Batch record deletion 3 - Click 'Enter a list of record numbers' 4 - Enter the biblionumber' 5 - Confirm deletion 6 - Search for the record, it still appears 7 - Apply patch, restart all the things 8 - Repeat 1-6 9 - This time the record is deleted 10 - Test other methods of record deletion to confirm the record is removed Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 10:49:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 09:49:52 +0000 Subject: [Koha-bugs] [Bug 23986] Batch Record Deletion does not remove records from Elasticsearch search index In-Reply-To: <bug-23986-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23986-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23986-70-YxgKuhkc7L@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23986 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.05 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 11:06:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 10:06:47 +0000 Subject: [Koha-bugs] [Bug 22329] Parent funds showing incorrect amounts for Ordered, Spent, Available on Acquisitions Home In-Reply-To: <bug-22329-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22329-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22329-70-YXJLN4y9MT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22329 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Is this perhaps a duplicate of bug 23767 ? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 11:07:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 10:07:35 +0000 Subject: [Koha-bugs] [Bug 23767] Spent and Ordered total values don't include child funds on acqui-home In-Reply-To: <bug-23767-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23767-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23767-70-80iwNeOjlu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23767 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_19_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 11:11:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 10:11:12 +0000 Subject: [Koha-bugs] [Bug 13775] software error when choosing authority via plugin In-Reply-To: <bug-13775-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13775-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13775-70-wwzDQSzM6X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13775 --- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #8) > Hi Jonathan, those are the ones for MARC21: > > SELECT authtypecode, auth_tag_to_report FROM koha_kohadev.auth_types where > authtypecode != "" > > 'CHRON_TERM', '148' > 'CORPO_NAME', '110' > 'GENRE/FORM', '155' > 'GEOGR_NAME', '151' > 'MEETI_NAME', '111' > 'PERSO_NAME', '100' > 'TOPIC_TERM', '150' > 'UNIF_TITLE', '130' It that correct for all marc flavors? Only for existing installs I guess? Fix should be provided for existing installs, at code level then. What kind message should we display to the user? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 11:15:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 10:15:25 +0000 Subject: [Koha-bugs] [Bug 23827] [19.05] Cash register statistics uses old accounttype values In-Reply-To: <bug-23827-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23827-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23827-70-s9ES0ftwPQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23827 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Cash register statistics |[19.05] Cash register |uses old accounttype values |statistics uses old | |accounttype values -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 11:16:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 10:16:44 +0000 Subject: [Koha-bugs] [Bug 23827] [19.05] Cash register statistics uses old accounttype values In-Reply-To: <bug-23827-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23827-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23827-70-qCoFGqsoi8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23827 --- Comment #18 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- QA generally skips patches for older versions. Change status in order to put it on the list of the appropriate RMaint ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 11:20:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 10:20:03 +0000 Subject: [Koha-bugs] [Bug 5365] It should be more clear how to reopen a basket in a basket group In-Reply-To: <bug-5365-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-5365-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5365-70-jlYn1FdflF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5365 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 11:20:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 10:20:06 +0000 Subject: [Koha-bugs] [Bug 5365] It should be more clear how to reopen a basket in a basket group In-Reply-To: <bug-5365-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-5365-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5365-70-3Be84TkDZj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5365 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95106|0 |1 is obsolete| | --- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 95189 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95189&action=edit Bug 5365: Make more clear how to reopen a basket in a basket group The "reopen basket" button will be visible but disabled if the basket cannot be reopened. A tooltip is attached to the button to add more information. Note that the export button is still hidden, would it makes sense to display it (visible and active)? Test plan: - Create a basket - Close it - Go to the basket detail view => The reopen button should be displayed and enabled - Attach it to a basket group - Go to the basket detail view => The reopen button should be displayed but disabled Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 11:20:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 10:20:26 +0000 Subject: [Koha-bugs] [Bug 5365] It should be more clear how to reopen a basket in a basket group In-Reply-To: <bug-5365-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-5365-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5365-70-03rAE3rOb4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5365 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|katrin.fischer at bsz-bw.de |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 11:22:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 10:22:48 +0000 Subject: [Koha-bugs] [Bug 23933] commit_file.pl Can't call method "get_effective_marcorgcode" on an undefined value at /usr/share/koha/lib/C4/AuthoritiesMarc.pm line 578. In-Reply-To: <bug-23933-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23933-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23933-70-woLLVbj9a6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23933 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 11:22:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 10:22:51 +0000 Subject: [Koha-bugs] [Bug 23933] commit_file.pl Can't call method "get_effective_marcorgcode" on an undefined value at /usr/share/koha/lib/C4/AuthoritiesMarc.pm line 578. In-Reply-To: <bug-23933-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23933-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23933-70-ffl47z87Cr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23933 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95026|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 95190 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95190&action=edit Bug 23933: (bug 10132 follow-up) Fix commit_file.pl Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 11:23:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 10:23:02 +0000 Subject: [Koha-bugs] [Bug 23933] commit_file.pl Can't call method "get_effective_marcorgcode" on an undefined value at /usr/share/koha/lib/C4/AuthoritiesMarc.pm line 578. In-Reply-To: <bug-23933-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23933-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23933-70-zmw1JsgY4K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23933 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 11:26:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 10:26:46 +0000 Subject: [Koha-bugs] [Bug 23995] New: Check constraints are supported differently by MySQL and MariaDB so we should remove them for now. Message-ID: <bug-23995-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23995 Bug ID: 23995 Summary: Check constraints are supported differently by MySQL and MariaDB so we should remove them for now. Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Database Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org We had two check constraints in kohastructure.. MariaDB and MySQL have now both implimented support for such constraints, but decided to use different, incompatible, syntaxes. As such, we should remove the current check constraints until a time when we have a better understanding on how to work around these differences. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 11:26:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 10:26:51 +0000 Subject: [Koha-bugs] [Bug 23995] Check constraints are supported differently by MySQL and MariaDB so we should remove them for now. In-Reply-To: <bug-23995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23995-70-41opDEHZhO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23995 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 11:26:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 10:26:56 +0000 Subject: [Koha-bugs] [Bug 23995] Check constraints are supported differently by MySQL and MariaDB so we should remove them for now. In-Reply-To: <bug-23995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23995-70-lQRUgE4WZ8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23995 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 11:29:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 10:29:01 +0000 Subject: [Koha-bugs] [Bug 23995] Check constraints are supported differently by MySQL and MariaDB so we should remove them for now. In-Reply-To: <bug-23995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23995-70-E4eNXRsLdZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23995 --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95191 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95191&action=edit Bug 23995: Remove CHECK constraints from kohastructure MySQL8 and MariaDB10.3 impliment check constraints but utilise different, incompatible, syntaxes to do so. This patch removes the check constraints entirely whilst we work on a better solution to work around the incompatabilities of the two DBs. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 11:33:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 10:33:32 +0000 Subject: [Koha-bugs] [Bug 23995] Check constraints are supported differently by MySQL and MariaDB so we should remove them for now. In-Reply-To: <bug-23995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23995-70-DSILs1oig5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23995 --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Mysql8 Manual: `Foreign key referential actions (ON UPDATE, ON DELETE) are prohibited on columns used in CHECK constraints. Likewise, CHECK constraints are prohibited on columns used in foreign key referential actions.` This is why the accountline check constraint must be dropped to support mysql8 (no such requirement in mariadb I believe) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 11:34:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 10:34:41 +0000 Subject: [Koha-bugs] [Bug 23995] Check constraints are supported differently by MySQL and MariaDB so we should remove them for now. In-Reply-To: <bug-23995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23995-70-pFHAicGBuW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23995 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Error is: DBD::mysql::st execute failed: Column 'frombranch' cannot be used in a check constraint 'transport_cost_chk_1': needed in a foreign key constraint 'transport_cost_ibfk_1' referential action. at /usr/share/perl5/DBIx/RunSQL.pm line 273. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 11:36:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 10:36:36 +0000 Subject: [Koha-bugs] [Bug 23847] Custom item search fields don't work if subfield is 0 (e.g. Withdrawn) In-Reply-To: <bug-23847-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23847-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23847-70-LFxdd7aCA9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23847 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 11:37:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 10:37:48 +0000 Subject: [Koha-bugs] [Bug 23995] Check constraints are supported differently by MySQL and MariaDB so we should remove them for now. In-Reply-To: <bug-23995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23995-70-nmK1kVEjN8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23995 --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Ditto for the other check constraint.. that's also upon a foreign key column then :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 11:37:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 10:37:55 +0000 Subject: [Koha-bugs] [Bug 23995] Check constraints are supported differently by MySQL and MariaDB so we should remove them for now. In-Reply-To: <bug-23995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23995-70-puEzeP7o1i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23995 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 11:38:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 10:38:34 +0000 Subject: [Koha-bugs] [Bug 23995] Check constraints are supported differently by MySQL and MariaDB so we should remove them for now. In-Reply-To: <bug-23995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23995-70-orr5hkRTkc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23995 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 11:38:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 10:38:38 +0000 Subject: [Koha-bugs] [Bug 23995] Check constraints are supported differently by MySQL and MariaDB so we should remove them for now. In-Reply-To: <bug-23995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23995-70-HosyA1tCpY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23995 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95191|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95192 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95192&action=edit Bug 23995: Remove CHECK constraints from kohastructure MySQL8 and MariaDB10.3 impliment check constraints but utilise different, incompatible, syntaxes to do so. This patch removes the check constraints entirely whilst we work on a better solution to work around the incompatabilities of the two DBs. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 11:38:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 10:38:54 +0000 Subject: [Koha-bugs] [Bug 23995] Check constraints are supported differently by MySQL and MariaDB so we should remove them for now. In-Reply-To: <bug-23995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23995-70-kxA4p0Vsz7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23995 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 11:41:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 10:41:01 +0000 Subject: [Koha-bugs] [Bug 23996] New: MySQL 8 support Message-ID: <bug-23996-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23996 Bug ID: 23996 Summary: MySQL 8 support Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 11:41:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 10:41:13 +0000 Subject: [Koha-bugs] [Bug 23995] Check constraints are supported differently by MySQL and MariaDB so we should remove them for now. In-Reply-To: <bug-23995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23995-70-16P0hlryiV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23995 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23996 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23996 [Bug 23996] MySQL 8 support -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 11:41:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 10:41:13 +0000 Subject: [Koha-bugs] [Bug 23996] MySQL 8 support In-Reply-To: <bug-23996-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23996-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23996-70-sLMq1wJdRD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23996 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23995 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23995 [Bug 23995] Check constraints are supported differently by MySQL and MariaDB so we should remove them for now. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 11:42:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 10:42:17 +0000 Subject: [Koha-bugs] [Bug 23997] New: sample_z3950_servers.sql is failing on MySQL 8 Message-ID: <bug-23997-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23997 Bug ID: 23997 Summary: sample_z3950_servers.sql is failing on MySQL 8 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Blocks: 23996 koha_1 | DBD::mysql::st execute failed: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'rank, syntax, encoding,recordtype) VALUES koha_1 | ('lx2.loc.gov',210,'LCDB','','','LIBRA' at line 2 at /usr/share/perl5/DBIx/RunSQL.pm line 273. https://dev.mysql.com/doc/refman/8.0/en/keywords.html => RANK (R); added in 8.0.2 (reserved) Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23996 [Bug 23996] MySQL 8 support -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 11:42:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 10:42:17 +0000 Subject: [Koha-bugs] [Bug 23996] MySQL 8 support In-Reply-To: <bug-23996-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23996-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23996-70-KnuYLXIEnk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23996 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23997 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23997 [Bug 23997] sample_z3950_servers.sql is failing on MySQL 8 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 11:44:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 10:44:27 +0000 Subject: [Koha-bugs] [Bug 23997] sample_z3950_servers.sql is failing on MySQL 8 In-Reply-To: <bug-23997-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23997-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23997-70-Qyk8M9yp2y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23997 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 11:44:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 10:44:34 +0000 Subject: [Koha-bugs] [Bug 23997] sample_z3950_servers.sql is failing on MySQL 8 In-Reply-To: <bug-23997-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23997-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23997-70-LqBtFxvB2p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23997 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 11:50:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 10:50:56 +0000 Subject: [Koha-bugs] [Bug 23997] sample_z3950_servers.sql is failing on MySQL 8 In-Reply-To: <bug-23997-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23997-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23997-70-Hgs7unpOGq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23997 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 11:51:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 10:51:00 +0000 Subject: [Koha-bugs] [Bug 23997] sample_z3950_servers.sql is failing on MySQL 8 In-Reply-To: <bug-23997-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23997-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23997-70-GH2DmKvvE9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23997 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95193 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95193&action=edit Bug 23997: Escape z3950servers.rank as it's a new MySQL 8 kw This patch will fix installation of Koha on MySQL 8 DBD::mysql::st execute failed: You have an error in your SQL syntax; check the manual that corresponds to your MySQL server version for the right syntax to use near 'rank, syntax, encoding,recordtype) VALUES ('lx2.loc.gov',210,'LCDB','','','LIBRA' at line 2 at /usr/share/perl5/DBIx/RunSQL.pm line 273. https://dev.mysql.com/doc/refman/8.0/en/keywords.html => RANK (R); added in 8.0.2 (reserved) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 11:51:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 10:51:27 +0000 Subject: [Koha-bugs] [Bug 23998] New: Messages REST API Message-ID: <bug-23998-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23998 Bug ID: 23998 Summary: Messages REST API Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST api Assignee: koha-bugs at lists.koha-community.org Reporter: lari.taskula at hypernova.fi Expose messages table via REST API. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 11:51:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 10:51:46 +0000 Subject: [Koha-bugs] [Bug 23998] Messages REST API In-Reply-To: <bug-23998-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23998-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23998-70-5ImeGQBDuG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23998 Lari Taskula <lari.taskula at hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |lari.taskula at hypernova.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 11:52:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 10:52:36 +0000 Subject: [Koha-bugs] [Bug 23999] New: auth_header.sql is failing on MySQL 8 Message-ID: <bug-23999-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23999 Bug ID: 23999 Summary: auth_header.sql is failing on MySQL 8 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Blocks: 23996 koha_1 | DBD::mysql::st execute failed: Column 'modification_time' cannot be null at /usr/share/perl5/DBIx/RunSQL.pm line 273. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23996 [Bug 23996] MySQL 8 support -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 11:52:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 10:52:36 +0000 Subject: [Koha-bugs] [Bug 23996] MySQL 8 support In-Reply-To: <bug-23996-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23996-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23996-70-gbr9UDpggK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23996 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23999 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23999 [Bug 23999] auth_header.sql is failing on MySQL 8 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 11:56:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 10:56:10 +0000 Subject: [Koha-bugs] [Bug 23999] auth_header.sql is failing on MySQL 8 In-Reply-To: <bug-23999-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23999-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23999-70-AIMOA12o3G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23999 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- It's actually an error from misc4dev. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 12:01:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 11:01:20 +0000 Subject: [Koha-bugs] [Bug 23847] Custom item search fields don't work if subfield is 0 (e.g. Withdrawn) In-Reply-To: <bug-23847-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23847-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23847-70-M9tGKNHMPD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23847 --- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Confusing title and test plan. Just figured out how to reproduce by searching on withdrawn in the box below instead of the withdrawn field above it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 12:02:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 11:02:16 +0000 Subject: [Koha-bugs] [Bug 23847] Custom item search fields don't work if subfield is 0 (e.g. Withdrawn) In-Reply-To: <bug-23847-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23847-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23847-70-2nzAQL0MQa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23847 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 12:02:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 11:02:19 +0000 Subject: [Koha-bugs] [Bug 23847] Custom item search fields don't work if subfield is 0 (e.g. Withdrawn) In-Reply-To: <bug-23847-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23847-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23847-70-Aw6hWVwsDp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23847 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94983|0 |1 is obsolete| | --- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 95194 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95194&action=edit Bug 23847: Fix custom item search fields if subfield is '0' The subfield is not used if is false, so if 0. We want to test if the subfield is defined and not an empty string. Test plan: - Define a new custom item search fields using a subfield '0' (withdrawn=952$0 for instance) - Define one which does not have a subfield (control field) - Search items using those newly created fields. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 12:03:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 11:03:33 +0000 Subject: [Koha-bugs] [Bug 24000] New: working title Message-ID: <bug-24000-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24000 Bug ID: 24000 Summary: working title Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: m.de.rooy at rijksmuseum.nl QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 12:04:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 11:04:42 +0000 Subject: [Koha-bugs] [Bug 24000] working title In-Reply-To: <bug-24000-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24000-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24000-70-08DS0ggUPr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24000 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 12:07:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 11:07:59 +0000 Subject: [Koha-bugs] [Bug 23960] Issue with MariaDB version (rows column name in creator_template table) In-Reply-To: <bug-23960-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23960-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23960-70-Wk5hhqFjnF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23960 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Can you detail how to replicate this issue Amit.. having dug around the codebase it looks like 'rows' is always correctly quoted as an identifier to me, so I'm struggling to narrow down the problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 12:08:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 11:08:35 +0000 Subject: [Koha-bugs] [Bug 23999] auth_header.sql is failing on MySQL 8 In-Reply-To: <bug-23999-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23999-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23999-70-Nssdch6cFg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23999 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |MOVED Status|ASSIGNED |RESOLVED --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Moved to koha-misc4dev https://gitlab.com/koha-community/koha-misc4dev/issues/34 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 12:08:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 11:08:35 +0000 Subject: [Koha-bugs] [Bug 23996] MySQL 8 support In-Reply-To: <bug-23996-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23996-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23996-70-SEmRgPAEDw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23996 Bug 23996 depends on bug 23999, which changed state. Bug 23999 Summary: auth_header.sql is failing on MySQL 8 https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23999 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |MOVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 12:10:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 11:10:33 +0000 Subject: [Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record In-Reply-To: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14963-70-fJsYUc3T73@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 12:10:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 11:10:37 +0000 Subject: [Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record In-Reply-To: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14963-70-upupM8wT5d@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 --- Comment #10 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 95195 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95195&action=edit Bug 14973: Check existing biblio when submitting a purchase suggestion (opac side) Test plan: - Go to opac suggestions page (opac-suggestions.pl) and click on "New purchase suggestion", - type the title (and author?) of a document that stand in you database - you should get a warning message about an exiting biblio. - clicking on confirm your suggestion add it, cancel does nothing Signed-off-by: Nicole Engard <nengard at bywatersolutions.com> Signed-off-by: Lisette Scheer <lisetteslatah at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 12:10:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 11:10:41 +0000 Subject: [Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record In-Reply-To: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14963-70-zJzeW5Q6uY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 --- Comment #11 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 95196 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95196&action=edit Bug 14973: Check existing biblio when submitting a purchase suggestion (staff side) Signed-off-by: Lisette Scheer <lisetteslatah at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 12:10:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 11:10:44 +0000 Subject: [Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record In-Reply-To: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14963-70-oReCPKamR1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 --- Comment #12 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 95197 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95197&action=edit Bug 14973: Do not skip validation step when submiting a suggestion - OPAC Signed-off-by: Lisette Scheer <lisetteslatah at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 12:10:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 11:10:47 +0000 Subject: [Koha-bugs] [Bug 24000] working title In-Reply-To: <bug-24000-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24000-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24000-70-mAPrcYLiQc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24000 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 12:10:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 11:10:48 +0000 Subject: [Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record In-Reply-To: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14963-70-fT4YB9XqrT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 --- Comment #13 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 95198 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95198&action=edit Bug 14973: Remove double textarea for notes Certainly a bad merge conflict resolution (I am certainly the one to blame). However I do not understand where this "note" variable come from. Signed-off-by: Lisette Scheer <lisetteslatah at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 12:10:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 11:10:50 +0000 Subject: [Koha-bugs] [Bug 24000] working title In-Reply-To: <bug-24000-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24000-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24000-70-3qNuhXxF6y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24000 --- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 95199 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95199&action=edit Bug 24000: Koha::Item::Search::Field does not return 1 Test plan: Run t/db_dependent/Koha/Item/Search/Field.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 12:10:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 11:10:51 +0000 Subject: [Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record In-Reply-To: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14963-70-ArykOGwX4W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 --- Comment #14 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 95200 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95200&action=edit Bug 14973: Remove double declaration of suggestions_loop -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 12:10:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 11:10:55 +0000 Subject: [Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record In-Reply-To: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14963-70-0waE6ZSBCu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 --- Comment #15 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 95201 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95201&action=edit Bug 14973: Add missing filters in templates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 12:10:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 11:10:59 +0000 Subject: [Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record In-Reply-To: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14963-70-AYA36mwMXy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95170|0 |1 is obsolete| | --- Comment #16 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 95202 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95202&action=edit Bug 14963: Add the ability to suggest purchase on existing title This patch adds the ability to create a new purchase suggestion from an existing title. This will prevent the creation of bibliographic records that already exist in the catalogue. Also it will ease the process during acquisition. Test plan: - Login at the OPAC and go to the detail of a bibliographic record. - Note that there is a new link "New purchase suggestion for this title" on the right of the screen - Please suggest an other icon if that one is not appropriated - Click on it and submit your new suggestion => You should not get the confirmation screen (introduced by bug 14973) warning you that the title already exists. - Login staff side and order from this suggestion. - Receive items and confirm that a new bibliographic record is not created. Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 12:11:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 11:11:04 +0000 Subject: [Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record In-Reply-To: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14963-70-z42pYX2Mky@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95173|0 |1 is obsolete| | --- Comment #17 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 95203 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95203&action=edit Bug 14963: Set status=ORDERED for suggestions created from existing record Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 12:11:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 11:11:08 +0000 Subject: [Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record In-Reply-To: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14963-70-wAA9S5OexH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95175|0 |1 is obsolete| | --- Comment #18 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 95204 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95204&action=edit Bug 14963: Fix ergonomic issue on small screen Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 12:11:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 11:11:35 +0000 Subject: [Koha-bugs] [Bug 24000] Koha::Item::Search::Field does not return 1 In-Reply-To: <bug-24000-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24000-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24000-70-YuoKQhewQE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24000 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Summary|working title |Koha::Item::Search::Field | |does not return 1 --- Comment #2 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Super trivial, signing off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 12:12:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 11:12:48 +0000 Subject: [Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record In-Reply-To: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14963-70-vwvTHh4GcM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 --- Comment #19 from Séverine Queune <severine.queune at bulac.fr> --- I'm sorry Jonathan, I missed everything with bug 14973 when I signed the present one... #shameonme... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 12:16:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 11:16:08 +0000 Subject: [Koha-bugs] [Bug 23960] Issue with MariaDB version (rows column name in creator_template table) In-Reply-To: <bug-23960-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23960-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23960-70-LPlM42mruq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23960 --- Comment #3 from Amit Gupta <amitddng135 at gmail.com> --- (In reply to Martin Renvoize from comment #2) > Can you detail how to replicate this issue Amit.. having dug around the > codebase it looks like 'rows' is always correctly quoted as an identifier to > me, so I'm struggling to narrow down the problem. Hi Martin, I am using MariaDB version 10.3.13 (while saving the template I found the issue) and checked the log giving errors. Seems "rows" are the keyword in MariaDB 10.3.13. Can you install 10.3.13 and see the issue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 12:23:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 11:23:06 +0000 Subject: [Koha-bugs] [Bug 23997] sample_z3950_servers.sql is failing on MySQL 8 In-Reply-To: <bug-23997-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23997-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23997-70-SpUyQF4El1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23997 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Another good catch with a trivial fix.. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 12:23:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 11:23:11 +0000 Subject: [Koha-bugs] [Bug 23997] sample_z3950_servers.sql is failing on MySQL 8 In-Reply-To: <bug-23997-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23997-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23997-70-kGbaiycy98@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23997 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 12:23:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 11:23:45 +0000 Subject: [Koha-bugs] [Bug 23995] Check constraints are supported differently by MySQL and MariaDB so we should remove them for now. In-Reply-To: <bug-23995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23995-70-nRuVoVd66G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23995 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 12:23:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 11:23:47 +0000 Subject: [Koha-bugs] [Bug 23995] Check constraints are supported differently by MySQL and MariaDB so we should remove them for now. In-Reply-To: <bug-23995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23995-70-PPOF78Fj6q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23995 --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 12:23:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 11:23:49 +0000 Subject: [Koha-bugs] [Bug 23997] sample_z3950_servers.sql is failing on MySQL 8 In-Reply-To: <bug-23997-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23997-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23997-70-u5paQvSMwH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23997 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 12:23:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 11:23:51 +0000 Subject: [Koha-bugs] [Bug 23997] sample_z3950_servers.sql is failing on MySQL 8 In-Reply-To: <bug-23997-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23997-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23997-70-5Ri4CiCbsu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23997 --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 12:25:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 11:25:04 +0000 Subject: [Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record In-Reply-To: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14963-70-djjWCkfTLM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 --- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Séverine Queune from comment #19) > I'm sorry Jonathan, I missed everything with bug 14973 when I signed the > present one... > #shameonme... I will fix that :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 12:26:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 11:26:17 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: <bug-14973-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14973-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14973-70-0JO8uWqBMT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 --- Comment #43 from Séverine Queune <severine.queune at bulac.fr> --- Found an issue coming from this patch, when testing bug 14763 : biblioitems.itemtypes is now mandatory to edit a suggestion. It seems an important data to map, so I don't think a modification of the present code is needed, but maybe a warning should be clearly displayed in the release note, and maybe Koha (About > System information ?). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 12:27:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 11:27:22 +0000 Subject: [Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record In-Reply-To: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14963-70-bjTqIQy7Z6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95195|0 |1 is obsolete| | Attachment #95196|0 |1 is obsolete| | Attachment #95197|0 |1 is obsolete| | Attachment #95198|0 |1 is obsolete| | Attachment #95200|0 |1 is obsolete| | Attachment #95201|0 |1 is obsolete| | Attachment #95202|0 |1 is obsolete| | Attachment #95203|0 |1 is obsolete| | Attachment #95204|0 |1 is obsolete| | --- Comment #21 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95205 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95205&action=edit Bug 14963: Add the ability to suggest purchase on existing title This patch adds the ability to create a new purchase suggestion from an existing title. This will prevent the creation of bibliographic records that already exist in the catalogue. Also it will ease the process during acquisition. Test plan: - Login at the OPAC and go to the detail of a bibliographic record. - Note that there is a new link "New purchase suggestion for this title" on the right of the screen - Please suggest an other icon if that one is not appropriated - Click on it and submit your new suggestion => You should not get the confirmation screen (introduced by bug 14973) warning you that the title already exists. - Login staff side and order from this suggestion. - Receive items and confirm that a new bibliographic record is not created. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 12:27:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 11:27:27 +0000 Subject: [Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record In-Reply-To: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14963-70-lWwR68uP4k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 --- Comment #22 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95206 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95206&action=edit Bug 14963: Set status=ORDERED for suggestions created from existing record Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 12:27:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 11:27:33 +0000 Subject: [Koha-bugs] [Bug 14963] Ability to suggest purchase on existing catalogue record In-Reply-To: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14963-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14963-70-nQuJbMsLhz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14963 --- Comment #23 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95207 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95207&action=edit Bug 14963: Fix ergonomic issue on small screen Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 12:27:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 11:27:39 +0000 Subject: [Koha-bugs] [Bug 23851] Auto generate accession number format <branchcode>yymm0001 fails to add branchcode prefix(branchcode) for multiple item addition In-Reply-To: <bug-23851-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23851-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23851-70-JGEDMB2SbO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23851 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 12:27:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 11:27:43 +0000 Subject: [Koha-bugs] [Bug 23851] Auto generate accession number format <branchcode>yymm0001 fails to add branchcode prefix(branchcode) for multiple item addition In-Reply-To: <bug-23851-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23851-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23851-70-FivQStHDg9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23851 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94974|0 |1 is obsolete| | --- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 95208 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95208&action=edit Bug 23851: Add the homebranch prefix to the barcode when adding multiple copies of an items See the comment in the code for more information. Test plan: - Set autoBarcode to hbyymmincr - Create an item and click on the barcode field - A barcode prefixed by the homebranch is generated - Click the "Add multiple copies of this item" and enter 4 - Save => Without this patch only the first item has the homebranch prefix => With this patch applied they all have a barcode in the same format Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 12:28:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 11:28:09 +0000 Subject: [Koha-bugs] [Bug 23851] Auto generate accession number format <branchcode>yymm0001 fails to add branchcode prefix(branchcode) for multiple item addition In-Reply-To: <bug-23851-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23851-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23851-70-vnWTcPzf9Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23851 --- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Katrin Fischer from comment #6) > 3 bugs for the price of one sign-off... a good deal I'd say :) No good deal, this is horrible code ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 12:28:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 11:28:16 +0000 Subject: [Koha-bugs] [Bug 23851] Auto generate accession number format <branchcode>yymm0001 fails to add branchcode prefix(branchcode) for multiple item addition In-Reply-To: <bug-23851-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23851-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23851-70-bZm92nV76X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23851 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 12:30:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 11:30:53 +0000 Subject: [Koha-bugs] [Bug 23767] Spent and Ordered total values don't include child funds on acqui-home In-Reply-To: <bug-23767-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23767-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23767-70-7zSvow1EhB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23767 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 12:34:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 11:34:11 +0000 Subject: [Koha-bugs] [Bug 23960] Issue with MariaDB version (rows column name in creator_template table) In-Reply-To: <bug-23960-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23960-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23960-70-ybYBZSLgbK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23960 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23289 CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Amit, which version of Koha? Steps to recreate? See also bug 23289, which is supposed to have fixed that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 12:34:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 11:34:11 +0000 Subject: [Koha-bugs] [Bug 23289] Label Template - Creation not working (MariaDB >= 10.2.4) In-Reply-To: <bug-23289-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23289-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23289-70-76l5pF9x0S@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23289 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23960 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 12:34:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 11:34:58 +0000 Subject: [Koha-bugs] [Bug 23960] Issue with MariaDB version (rows column name in creator_template table) In-Reply-To: <bug-23960-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23960-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23960-70-fBkgr7kG8f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23960 --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (collision with Martin!) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 12:47:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 11:47:20 +0000 Subject: [Koha-bugs] [Bug 23960] Issue with MariaDB version (rows column name in creator_template table) In-Reply-To: <bug-23960-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23960-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23960-70-e3Fj1LBw3K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23960 --- Comment #6 from Amit Gupta <amitddng135 at gmail.com> --- (In reply to Jonathan Druart from comment #4) > Amit, which version of Koha? Steps to recreate? > > See also bug 23289, which is supposed to have fixed that. Thanks, Jonathan I applied the patch and the issue is resolved. I am using 18.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 12:55:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 11:55:24 +0000 Subject: [Koha-bugs] [Bug 24001] New: Cannot edit card template Message-ID: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 Bug ID: 24001 Summary: Cannot edit card template Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Label/patron card printing Assignee: cnighswonger at foundations.edu Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org To recreate: - Go to Home › Tools › Patron card creator › Templates - New > Card template - Save - Edit - Save => Can't bless non-reference value at /home/vagrant/kohaclone/C4/Creators/Profile.pm line 89 C4::Creators::Profile::retrieve('C4::Patroncards::Profile', 'profile_id', 22, 'creator', 'Patroncards') called at /home/vagrant/kohaclone/C4/Patroncards/Profile.pm line 29 C4::Patroncards::Profile::retrieve('profile_id', 22, 'creator', 'Patroncards') called at /home/vagrant/kohaclone/patroncards/edit-template.pl line 78 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 12:58:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 11:58:38 +0000 Subject: [Koha-bugs] [Bug 24002] New: Test suite is failing on MySQL 8 Message-ID: <bug-24002-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002 Bug ID: 24002 Summary: Test suite is failing on MySQL 8 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Blocks: 23996 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23996 [Bug 23996] MySQL 8 support -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 12:58:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 11:58:38 +0000 Subject: [Koha-bugs] [Bug 23996] MySQL 8 support In-Reply-To: <bug-23996-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23996-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23996-70-PxPOzv1DTZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23996 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24002 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002 [Bug 24002] Test suite is failing on MySQL 8 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 12:59:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 11:59:28 +0000 Subject: [Koha-bugs] [Bug 23960] Issue with MariaDB version (rows column name in creator_template table) In-Reply-To: <bug-23960-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23960-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23960-70-aZCdmqvIwE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23960 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|ASSIGNED |RESOLVED --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- *** This bug has been marked as a duplicate of bug 23289 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 12:59:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 11:59:28 +0000 Subject: [Koha-bugs] [Bug 23289] Label Template - Creation not working (MariaDB >= 10.2.4) In-Reply-To: <bug-23289-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23289-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23289-70-kBUCuEtPpj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23289 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amitddng135 at gmail.com --- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- *** Bug 23960 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 13:56:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 12:56:41 +0000 Subject: [Koha-bugs] [Bug 5365] It should be more clear how to reopen a basket in a basket group In-Reply-To: <bug-5365-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-5365-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5365-70-TS3vTJp2s0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5365 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 13:56:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 12:56:43 +0000 Subject: [Koha-bugs] [Bug 5365] It should be more clear how to reopen a basket in a basket group In-Reply-To: <bug-5365-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-5365-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5365-70-Lm2t8IfHGi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5365 --- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 13:56:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 12:56:45 +0000 Subject: [Koha-bugs] [Bug 22857] Entries missing in koha-conf.xml In-Reply-To: <bug-22857-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22857-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22857-70-VzPKka1EgO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22857 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 13:56:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 12:56:47 +0000 Subject: [Koha-bugs] [Bug 22857] Entries missing in koha-conf.xml In-Reply-To: <bug-22857-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22857-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22857-70-5y1Lbx3pL2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22857 --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 13:56:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 12:56:49 +0000 Subject: [Koha-bugs] [Bug 23398] Exporting/Reimporting frameworks in XML format will give incomplete results In-Reply-To: <bug-23398-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23398-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23398-70-4no9nRuQcg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23398 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 13:56:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 12:56:51 +0000 Subject: [Koha-bugs] [Bug 23398] Exporting/Reimporting frameworks in XML format will give incomplete results In-Reply-To: <bug-23398-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23398-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23398-70-R2N7sPcC8u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23398 --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 13:56:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 12:56:53 +0000 Subject: [Koha-bugs] [Bug 23847] Custom item search fields don't work if subfield is 0 (e.g. Withdrawn) In-Reply-To: <bug-23847-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23847-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23847-70-rw8Rsaf6FB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23847 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 13:56:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 12:56:55 +0000 Subject: [Koha-bugs] [Bug 23847] Custom item search fields don't work if subfield is 0 (e.g. Withdrawn) In-Reply-To: <bug-23847-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23847-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23847-70-8GD3asJEAN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23847 --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 13:56:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 12:56:57 +0000 Subject: [Koha-bugs] [Bug 23851] Auto generate accession number format <branchcode>yymm0001 fails to add branchcode prefix(branchcode) for multiple item addition In-Reply-To: <bug-23851-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23851-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23851-70-wHlJIEJ0FR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23851 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 13:56:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 12:56:59 +0000 Subject: [Koha-bugs] [Bug 23851] Auto generate accession number format <branchcode>yymm0001 fails to add branchcode prefix(branchcode) for multiple item addition In-Reply-To: <bug-23851-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23851-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23851-70-b5LowFGABx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23851 --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 13:57:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 12:57:01 +0000 Subject: [Koha-bugs] [Bug 23933] commit_file.pl Can't call method "get_effective_marcorgcode" on an undefined value at /usr/share/koha/lib/C4/AuthoritiesMarc.pm line 578. In-Reply-To: <bug-23933-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23933-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23933-70-zC8gJNQcHw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23933 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 13:57:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 12:57:03 +0000 Subject: [Koha-bugs] [Bug 23933] commit_file.pl Can't call method "get_effective_marcorgcode" on an undefined value at /usr/share/koha/lib/C4/AuthoritiesMarc.pm line 578. In-Reply-To: <bug-23933-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23933-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23933-70-gZY2YImMRU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23933 --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 13:57:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 12:57:04 +0000 Subject: [Koha-bugs] [Bug 23949] koha-common.init missing actions for koha-z3950-responder In-Reply-To: <bug-23949-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23949-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23949-70-sSJ6LMDNHn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 13:57:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 12:57:06 +0000 Subject: [Koha-bugs] [Bug 23949] koha-common.init missing actions for koha-z3950-responder In-Reply-To: <bug-23949-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23949-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23949-70-d5IwTXTo3P@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 --- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 14:12:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 13:12:10 +0000 Subject: [Koha-bugs] [Bug 22329] Parent funds showing incorrect amounts for Ordered, Spent, Available on Acquisitions Home In-Reply-To: <bug-22329-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22329-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22329-70-lUejMOTW3R@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22329 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #3 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- *** This bug has been marked as a duplicate of bug 23767 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 14:12:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 13:12:10 +0000 Subject: [Koha-bugs] [Bug 23767] Spent and Ordered total values don't include child funds on acqui-home In-Reply-To: <bug-23767-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23767-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23767-70-gBziMT1YR3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23767 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com --- Comment #7 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- *** Bug 22329 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 14:17:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 13:17:56 +0000 Subject: [Koha-bugs] [Bug 23293] OPACFineNoRenewals always compares against 'balance' not 'outstanding' In-Reply-To: <bug-23293-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23293-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23293-70-4C5FTRuXwm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23293 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_19_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 14:18:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 13:18:02 +0000 Subject: [Koha-bugs] [Bug 23949] koha-common.init missing actions for koha-z3950-responder In-Reply-To: <bug-23949-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23949-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23949-70-pAd1b5kiNd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23949 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_19_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 14:18:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 13:18:23 +0000 Subject: [Koha-bugs] [Bug 23473] Allow passwords to be imported/overwritten using the patron import tool In-Reply-To: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23473-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23473-70-eGNxslyiB5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23473 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_19_11_candidate |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 14:30:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 13:30:56 +0000 Subject: [Koha-bugs] [Bug 23932] Typo on 'aqinvoice_adjustments.encumber_open' description in Koha Schema In-Reply-To: <bug-23932-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23932-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23932-70-X6iOcV1aoh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23932 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 14:30:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 13:30:59 +0000 Subject: [Koha-bugs] [Bug 23932] Typo on 'aqinvoice_adjustments.encumber_open' description in Koha Schema In-Reply-To: <bug-23932-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23932-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23932-70-KSIFnlpitd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23932 --- Comment #1 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 95209 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95209&action=edit Bug 23932: Typo on 'aqinvoice_adjustments.encumber_open' description in Koha Schema Correct a typo in Koha Schema comment. finds --> funds -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 14:49:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 13:49:28 +0000 Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests In-Reply-To: <bug-23974-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23974-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23974-70-bOWn59N9tg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95062|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95210 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95210&action=edit Bug 23974: Improve readability This patch does not change anything, just a bit of cleaning Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 14:49:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 13:49:31 +0000 Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests In-Reply-To: <bug-23974-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23974-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23974-70-eEy8pwtv13@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95063|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95211 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95211&action=edit Bug 23974: Add new tests for hours_between Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 14:49:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 13:49:34 +0000 Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests In-Reply-To: <bug-23974-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23974-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23974-70-nPeHjq42ji@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95064|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95212 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95212&action=edit Bug 23974: Add tests for days_between Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 14:49:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 13:49:37 +0000 Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests In-Reply-To: <bug-23974-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23974-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23974-70-Qlc6IiPJ1N@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95065|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95213 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95213&action=edit Bug 23974: both methods should have the same logic/construction Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 14:49:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 13:49:41 +0000 Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests In-Reply-To: <bug-23974-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23974-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23974-70-LC6ZGOghWN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95214 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95214&action=edit Bug 23974: (follow-up) Add same day loan tests Hourly loans can be short enough to not cross a day boundary and as such we should test for that scenario in the hour_between tests too. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 14:50:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 13:50:42 +0000 Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests In-Reply-To: <bug-23974-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23974-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23974-70-1N3C7YeNCQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- I'm really happy to see these tests and agree with the logic in them... Signing off on yours and have added one minor addition to ensure we're checking same day hourly loans. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 14:53:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 13:53:11 +0000 Subject: [Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8 In-Reply-To: <bug-24002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24002-70-Nnwe6t9IQt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 14:53:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 13:53:15 +0000 Subject: [Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8 In-Reply-To: <bug-24002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24002-70-cZRXtlDAA2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95215 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95215&action=edit Bug 24002: Incorrect DATE value: '00-00-0000' in NewsChannels.pm % prove xt/author/valid-templates.t DBD::mysql::st execute failed: Incorrect DATE value: '00-00-0000' [for Statement " SELECT opac_news.*,timestamp AS newdate, borrowers.title AS author_title, borrowers.firstname AS author_firstname, borrowers.surname AS author_surname FROM opac_news LEFT JOIN borrowers on borrowers.borrowernumber = opac_news.borrowernumber WHERE ( expirationdate >= CURRENT_DATE() OR expirationdate IS NULL OR expirationdate = '00-00-0000' ) AND DATE(timestamp) < DATE_ADD(CURDATE(), INTERVAL 1 DAY) AND (opac_news.lang = '' OR opac_news.lang = ?) AND (opac_news.branchcode IS NULL OR opac_news.branchcode = ?) ORDER BY number " with ParamValues: 0='OpacNavRight_', 1=''] at /kohadevbox/koha/C4/NewsChannels.pm line 216. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 14:53:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 13:53:19 +0000 Subject: [Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8 In-Reply-To: <bug-24002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24002-70-G5P8MVxyua@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002 --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95216 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95216&action=edit Bug 24002: Incorrect DATE value: '' in C4/Bookseller.pm t/db_dependent/Bookseller.t .. 3/86 DBD::mysql::st execute failed: Incorrect DATE value: '' [for Statement " SELECT DISTINCT aqbasket.booksellerid, aqbooksellers.name FROM aqorders LEFT JOIN aqbasket ON aqorders.basketno=aqbasket.basketno LEFT JOIN aqbooksellers ON aqbasket.booksellerid = aqbooksellers.id WHERE ( datereceived = '' OR datereceived IS NULL OR aqorders.quantityreceived < aqorders.quantity ) AND aqorders.quantity - COALESCE(aqorders.quantityreceived,0) <> 0 AND aqbasket.closedate IS NOT NULL "] at /kohadevbox/koha/C4/Bookseller.pm line 100. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 14:53:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 13:53:23 +0000 Subject: [Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8 In-Reply-To: <bug-24002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24002-70-uOSPRN4Fmw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002 --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95217 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95217&action=edit Bug 24002: Incorrect DATE value: '0000-00-00' in C4/Serials.pm DBD::mysql::st execute failed: Incorrect DATE value: '0000-00-00' [for Statement "SELECT serialid,serialseq, status, planneddate, publisheddate, publisheddatetext, notes, routingnotes FROM serial WHERE subscriptionid = ? AND status IN ( 2,4,41,42,43,44,5 ) ORDER BY IF(publisheddate<>'0000-00-00',publisheddate,planneddate) DESC " with ParamValues: 0=8] at /kohadevbox/koha/C4/Serials.pm line 688. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 14:53:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 13:53:27 +0000 Subject: [Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8 In-Reply-To: <bug-24002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24002-70-W4KlzROJrl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002 --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95218 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95218&action=edit Bug 24002: Incorrect DATE value: '00-00-0000' in C4/Serials.pm t/db_dependent/Biblio.t .. 2/12 DBD::mysql::st execute failed: Incorrect DATE value: '00-00-0000' [for Statement " SELECT serial.serialid, serial.serialseq, serial.planneddate, serial.publisheddate, serial.publisheddatetext, serial.status, serial.notes as notes, year(IF(serial.publisheddate="00-00-0000",serial.planneddate,serial.publisheddate)) as year, biblio.title as bibliotitle, subscription.branchcode AS branchcode, subscription.subscriptionid AS subscriptionid FROM serial LEFT JOIN subscription ON (serial.subscriptionid=subscription.subscriptionid) LEFT JOIN aqbooksellers on subscription.aqbooksellerid=aqbooksellers.id LEFT JOIN biblio on biblio.biblionumber=subscription.biblionumber WHERE subscription.biblionumber = ? ORDER BY year DESC, IF(serial.publisheddate="00-00-0000",serial.planneddate,serial.publisheddate) DESC, serial.subscriptionid " with ParamValues: 0='446'] at /kohadevbox/koha/C4/Serials.pm line 482. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 14:53:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 13:53:31 +0000 Subject: [Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8 In-Reply-To: <bug-24002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24002-70-bFdKbgLP1h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002 --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95219 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95219&action=edit Bug 24002: Incorrect DATE value: '0000-00-00' in C4/Acquisition.pm t/db_dependent/Acquisition/close_reopen_basket.t .. DBD::mysql::st execute failed: Incorrect DATE value: '0000-00-00' [for Statement " SELECT COUNT( DISTINCT( biblionumber ) ) FROM aqorders WHERE basketno = ? AND (datecancellationprinted IS NULL OR datecancellationprinted='0000-00-00') " with ParamValues: 0='2'] at /kohadevbox/koha/C4/Acquisition.pm line 3012. DBD::mysql::st execute failed: Incorrect DATE value: '0000-00-00' [for Statement " SELECT COUNT( DISTINCT( biblionumber ) ) FROM aqorders WHERE basketno = ? AND (datecancellationprinted IS NULL OR datecancellationprinted='0000-00-00') " with ParamValues: 0='2'] at /kohadevbox/koha/C4/Acquisition.pm line 3012. And anticipating other failures -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 14:53:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 13:53:35 +0000 Subject: [Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8 In-Reply-To: <bug-24002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24002-70-dd3Wr7K1lY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002 --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95220 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95220&action=edit Bug 24002: Incorrect DATE value: '' in C4/Acquisition.pm DBD::mysql::st execute failed: Incorrect DATE value: '' [for Statement " SELECT aqbasket.basketno, aqorders.ordernumber, DATE(aqbasket.closedate) AS orderdate, aqbasket.basketname AS basketname, aqbasket.basketgroupid AS basketgroupid, aqbasketgroups.name AS basketgroupname, aqorders.rrp AS unitpricesupplier, aqorders.ecost AS unitpricelib, aqorders.claims_count AS claims_count, aqorders.claimed_date AS claimed_date, aqbudgets.budget_name AS budget, borrowers.branchcode AS branch, aqbooksellers.name AS supplier, aqbooksellers.id AS supplierid, biblio.author, biblio.title, biblioitems.publishercode AS publisher, biblioitems.publicationyear, ADDDATE(aqbasket.closedate, INTERVAL aqbooksellers.deliverytime DAY) AS estimateddeliverydate, aqorders.quantity - COALESCE(aqorders.quantityreceived,0) AS quantity, (aqorders.quantity - COALESCE(aqorders.quantityreceived,0)) * aqorders.rrp AS subtotal, DATEDIFF(CAST(now() AS date),closedate) AS latesince FROM aqorders LEFT JOIN biblio ON biblio.biblionumber = aqorders.biblionumber LEFT JOIN biblioitems ON biblioitems.biblionumber = biblio.biblionumber LEFT JOIN aqbudgets ON aqorders.budget_id = aqbudgets.budget_id, aqbasket LEFT JOIN borrowers ON aqbasket.authorisedby = borrowers.borrowernumber LEFT JOIN aqbooksellers ON aqbasket.booksellerid = aqbooksellers.id LEFT JOIN aqbasketgroups ON aqbasket.basketgroupid = aqbasketgroups.id WHERE aqorders.basketno = aqbasket.basketno AND ( datereceived = '' OR datereceived IS NULL OR aqorders.quantityreceived < aqorders.quantity ) AND aqbasket.closedate IS NOT NULL AND aqorders.datecancellationprinted IS NULL AND (closedate <= DATE_SUB(CAST(now() AS date),INTERVAL ? DAY)) AND aqorders.quantity - COALESCE(aqorders.quantityreceived,0) <> 0 AND orderstatus <> 'cancelled' ORDER BY latesince, basketno, borrowers.branchcode, supplier" with ParamValues: 0=0] at /kohadevbox/koha/C4/Acquisition.pm line 2248. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 14:55:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 13:55:26 +0000 Subject: [Koha-bugs] [Bug 23484] Holds to pull (pendingreserves.pl) uses removed default_branch_item_rules table In-Reply-To: <bug-23484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23484-70-nOg7rhXgLn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23484 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #20 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 19.05.x for 19.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 14:59:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 13:59:23 +0000 Subject: [Koha-bugs] [Bug 21985] Test t/db_dependent/Circulation.t fails if SearchEngine is set to elasticsearch In-Reply-To: <bug-21985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21985-70-hat7upzY9d@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21985 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.05 released in| | --- Comment #17 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 19.05.x for 19.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 15:00:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 14:00:50 +0000 Subject: [Koha-bugs] [Bug 23252] Pressing enter should not submit form in item editor In-Reply-To: <bug-23252-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23252-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23252-70-YKovaylWss@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23252 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #15 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 19.05.x for 19.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 15:01:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 14:01:39 +0000 Subject: [Koha-bugs] [Bug 23710] Holds broken on intranet, displays a JSON page with an error In-Reply-To: <bug-23710-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23710-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23710-70-1cKySuOyXe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23710 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED CC| |fridolin.somers at biblibre.co | |m --- Comment #27 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Depends on Bug 19618 not in 19.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 15:01:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 14:01:40 +0000 Subject: [Koha-bugs] [Bug 17229] ILS-DI HoldTitle and HoldItem should check if patron is expired In-Reply-To: <bug-17229-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17229-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17229-70-raTtWara7m@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 Bug 17229 depends on bug 23710, which changed state. Bug 23710 Summary: Holds broken on intranet, displays a JSON page with an error https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23710 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 15:22:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 14:22:32 +0000 Subject: [Koha-bugs] [Bug 24003] New: REST API basic auth lacks C4::Context->userenv Message-ID: <bug-24003-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 Bug ID: 24003 Summary: REST API basic auth lacks C4::Context->userenv Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST api Assignee: koha-bugs at lists.koha-community.org Reporter: lari.taskula at hypernova.fi -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 15:22:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 14:22:43 +0000 Subject: [Koha-bugs] [Bug 24003] REST API basic auth lacks C4::Context->userenv In-Reply-To: <bug-24003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24003-70-N1mDU8Cbr0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 Lari Taskula <lari.taskula at hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lari.taskula at hypernova.fi |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 15:24:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 14:24:16 +0000 Subject: [Koha-bugs] [Bug 23983] Contextualization of "Order" (verb) vs "Order" (noun) In-Reply-To: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23983-70-gQtvLKjazt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23983 --- Comment #9 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Thanks so much Julian! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 15:24:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 14:24:39 +0000 Subject: [Koha-bugs] [Bug 23723] Using exit inside eval to stop sending output to the browser doesn't work under Plack In-Reply-To: <bug-23723-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23723-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23723-70-Vw74SVSEgM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23723 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #17 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 19.05.x for 19.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 15:27:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 14:27:08 +0000 Subject: [Koha-bugs] [Bug 23730] Exporting reports is broken In-Reply-To: <bug-23730-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23730-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23730-70-RWpBAHhpAj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23730 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |RESOLVED Resolution|--- |FIXED Depends on| |23390 --- Comment #5 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Depends on bug 23390 not in 19.05.x Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23390 [Bug 23390] Add placeholder syntax for column names -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 15:27:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 14:27:08 +0000 Subject: [Koha-bugs] [Bug 23390] Add placeholder syntax for column names In-Reply-To: <bug-23390-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23390-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23390-70-72c26M2xIN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23390 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23730 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23730 [Bug 23730] Exporting reports is broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 15:32:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 14:32:54 +0000 Subject: [Koha-bugs] [Bug 23854] Cannot edit a suggestion In-Reply-To: <bug-23854-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23854-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23854-70-P5rFMYLPsZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23854 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_19_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 15:38:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 14:38:32 +0000 Subject: [Koha-bugs] [Bug 22997] Searching gives no results in auth_finder.pl In-Reply-To: <bug-22997-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22997-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22997-70-tU85Ha34po@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22997 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|19.11.00 |19.11.00,19.05.05 released in| | --- Comment #19 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 19.05.x for 19.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 15:41:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 14:41:47 +0000 Subject: [Koha-bugs] [Bug 23771] CAS/Shib Authentication can fail when multiple users with no userid/cardnumber defined and one of them is locked In-Reply-To: <bug-23771-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23771-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23771-70-vCR73Ij878@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23771 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 19.05.x for 19.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 15:45:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 14:45:04 +0000 Subject: [Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8 In-Reply-To: <bug-24002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24002-70-qelAx0xUoj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002 --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95221 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95221&action=edit Bug 24002: One more occurrence of datecancellationprinted -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 15:45:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 14:45:51 +0000 Subject: [Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8 In-Reply-To: <bug-24002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24002-70-8HgmNNGUvE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95215|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95222 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95222&action=edit Bug 24002: Incorrect DATE value: '00-00-0000' in NewsChannels.pm % prove xt/author/valid-templates.t DBD::mysql::st execute failed: Incorrect DATE value: '00-00-0000' [for Statement " SELECT opac_news.*,timestamp AS newdate, borrowers.title AS author_title, borrowers.firstname AS author_firstname, borrowers.surname AS author_surname FROM opac_news LEFT JOIN borrowers on borrowers.borrowernumber = opac_news.borrowernumber WHERE ( expirationdate >= CURRENT_DATE() OR expirationdate IS NULL OR expirationdate = '00-00-0000' ) AND DATE(timestamp) < DATE_ADD(CURDATE(), INTERVAL 1 DAY) AND (opac_news.lang = '' OR opac_news.lang = ?) AND (opac_news.branchcode IS NULL OR opac_news.branchcode = ?) ORDER BY number " with ParamValues: 0='OpacNavRight_', 1=''] at /kohadevbox/koha/C4/NewsChannels.pm line 216. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 15:45:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 14:45:54 +0000 Subject: [Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8 In-Reply-To: <bug-24002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24002-70-l7eHpKPZiy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95216|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95223 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95223&action=edit Bug 24002: Incorrect DATE value: '' in C4/Bookseller.pm t/db_dependent/Bookseller.t .. 3/86 DBD::mysql::st execute failed: Incorrect DATE value: '' [for Statement " SELECT DISTINCT aqbasket.booksellerid, aqbooksellers.name FROM aqorders LEFT JOIN aqbasket ON aqorders.basketno=aqbasket.basketno LEFT JOIN aqbooksellers ON aqbasket.booksellerid = aqbooksellers.id WHERE ( datereceived = '' OR datereceived IS NULL OR aqorders.quantityreceived < aqorders.quantity ) AND aqorders.quantity - COALESCE(aqorders.quantityreceived,0) <> 0 AND aqbasket.closedate IS NOT NULL "] at /kohadevbox/koha/C4/Bookseller.pm line 100. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 15:45:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 14:45:58 +0000 Subject: [Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8 In-Reply-To: <bug-24002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24002-70-9GhBZWN305@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95217|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95224 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95224&action=edit Bug 24002: Incorrect DATE value: '0000-00-00' in C4/Serials.pm DBD::mysql::st execute failed: Incorrect DATE value: '0000-00-00' [for Statement "SELECT serialid,serialseq, status, planneddate, publisheddate, publisheddatetext, notes, routingnotes FROM serial WHERE subscriptionid = ? AND status IN ( 2,4,41,42,43,44,5 ) ORDER BY IF(publisheddate<>'0000-00-00',publisheddate,planneddate) DESC " with ParamValues: 0=8] at /kohadevbox/koha/C4/Serials.pm line 688. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 15:46:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 14:46:01 +0000 Subject: [Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8 In-Reply-To: <bug-24002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24002-70-pOFbTnf3qp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95218|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95225 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95225&action=edit Bug 24002: Incorrect DATE value: '00-00-0000' in C4/Serials.pm t/db_dependent/Biblio.t .. 2/12 DBD::mysql::st execute failed: Incorrect DATE value: '00-00-0000' [for Statement " SELECT serial.serialid, serial.serialseq, serial.planneddate, serial.publisheddate, serial.publisheddatetext, serial.status, serial.notes as notes, year(IF(serial.publisheddate="00-00-0000",serial.planneddate,serial.publisheddate)) as year, biblio.title as bibliotitle, subscription.branchcode AS branchcode, subscription.subscriptionid AS subscriptionid FROM serial LEFT JOIN subscription ON (serial.subscriptionid=subscription.subscriptionid) LEFT JOIN aqbooksellers on subscription.aqbooksellerid=aqbooksellers.id LEFT JOIN biblio on biblio.biblionumber=subscription.biblionumber WHERE subscription.biblionumber = ? ORDER BY year DESC, IF(serial.publisheddate="00-00-0000",serial.planneddate,serial.publisheddate) DESC, serial.subscriptionid " with ParamValues: 0='446'] at /kohadevbox/koha/C4/Serials.pm line 482. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 15:46:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 14:46:05 +0000 Subject: [Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8 In-Reply-To: <bug-24002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24002-70-USVWvABh7v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95219|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95226 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95226&action=edit Bug 24002: Incorrect DATE value: '0000-00-00' in C4/Acquisition.pm t/db_dependent/Acquisition/close_reopen_basket.t .. DBD::mysql::st execute failed: Incorrect DATE value: '0000-00-00' [for Statement " SELECT COUNT( DISTINCT( biblionumber ) ) FROM aqorders WHERE basketno = ? AND (datecancellationprinted IS NULL OR datecancellationprinted='0000-00-00') " with ParamValues: 0='2'] at /kohadevbox/koha/C4/Acquisition.pm line 3012. DBD::mysql::st execute failed: Incorrect DATE value: '0000-00-00' [for Statement " SELECT COUNT( DISTINCT( biblionumber ) ) FROM aqorders WHERE basketno = ? AND (datecancellationprinted IS NULL OR datecancellationprinted='0000-00-00') " with ParamValues: 0='2'] at /kohadevbox/koha/C4/Acquisition.pm line 3012. And anticipating other failures Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 15:46:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 14:46:09 +0000 Subject: [Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8 In-Reply-To: <bug-24002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24002-70-5DUTtFQxqZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95220|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95227 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95227&action=edit Bug 24002: Incorrect DATE value: '' in C4/Acquisition.pm DBD::mysql::st execute failed: Incorrect DATE value: '' [for Statement " SELECT aqbasket.basketno, aqorders.ordernumber, DATE(aqbasket.closedate) AS orderdate, aqbasket.basketname AS basketname, aqbasket.basketgroupid AS basketgroupid, aqbasketgroups.name AS basketgroupname, aqorders.rrp AS unitpricesupplier, aqorders.ecost AS unitpricelib, aqorders.claims_count AS claims_count, aqorders.claimed_date AS claimed_date, aqbudgets.budget_name AS budget, borrowers.branchcode AS branch, aqbooksellers.name AS supplier, aqbooksellers.id AS supplierid, biblio.author, biblio.title, biblioitems.publishercode AS publisher, biblioitems.publicationyear, ADDDATE(aqbasket.closedate, INTERVAL aqbooksellers.deliverytime DAY) AS estimateddeliverydate, aqorders.quantity - COALESCE(aqorders.quantityreceived,0) AS quantity, (aqorders.quantity - COALESCE(aqorders.quantityreceived,0)) * aqorders.rrp AS subtotal, DATEDIFF(CAST(now() AS date),closedate) AS latesince FROM aqorders LEFT JOIN biblio ON biblio.biblionumber = aqorders.biblionumber LEFT JOIN biblioitems ON biblioitems.biblionumber = biblio.biblionumber LEFT JOIN aqbudgets ON aqorders.budget_id = aqbudgets.budget_id, aqbasket LEFT JOIN borrowers ON aqbasket.authorisedby = borrowers.borrowernumber LEFT JOIN aqbooksellers ON aqbasket.booksellerid = aqbooksellers.id LEFT JOIN aqbasketgroups ON aqbasket.basketgroupid = aqbasketgroups.id WHERE aqorders.basketno = aqbasket.basketno AND ( datereceived = '' OR datereceived IS NULL OR aqorders.quantityreceived < aqorders.quantity ) AND aqbasket.closedate IS NOT NULL AND aqorders.datecancellationprinted IS NULL AND (closedate <= DATE_SUB(CAST(now() AS date),INTERVAL ? DAY)) AND aqorders.quantity - COALESCE(aqorders.quantityreceived,0) <> 0 AND orderstatus <> 'cancelled' ORDER BY latesince, basketno, borrowers.branchcode, supplier" with ParamValues: 0=0] at /kohadevbox/koha/C4/Acquisition.pm line 2248. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 15:47:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 14:47:35 +0000 Subject: [Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8 In-Reply-To: <bug-24002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24002-70-r4ewq0ibrE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Ran tests again M8, saw failures.. applied patches and re-ran tests, full Pass. Looks good, signing off. Minor concern is whether we might be missing some DB updates to ensure all tables are filled with expected data to start with.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 15:50:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 14:50:42 +0000 Subject: [Koha-bugs] [Bug 24003] REST API basic auth lacks C4::Context->userenv In-Reply-To: <bug-24003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24003-70-gKmnE7dSkt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 Lari Taskula <lari.taskula at hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22132 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132 [Bug 22132] Add Basic authentication to the REST API -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 15:50:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 14:50:42 +0000 Subject: [Koha-bugs] [Bug 22132] Add Basic authentication to the REST API In-Reply-To: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22132-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22132-70-FLbDnQy7ix@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22132 Lari Taskula <lari.taskula at hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24003 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 [Bug 24003] REST API basic auth lacks C4::Context->userenv -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 15:50:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 14:50:45 +0000 Subject: [Koha-bugs] [Bug 24003] REST API basic auth lacks C4::Context->userenv In-Reply-To: <bug-24003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24003-70-TVJIds759G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 --- Comment #1 from Lari Taskula <lari.taskula at hypernova.fi> --- Created attachment 95228 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95228&action=edit Bug 24003: Add a failing test for missing userenv for REST basic auth When using REST API via basic authentication method, C4::Context->userenv returns undef. This patch adds a failing test to prove it. To test: 1. prove t/db_dependent/api/v1/auth_basic.t 2. Observe failures: not ok 5 - exact match for JSON Pointer "/userenv/number" Failed test 'exact match for JSON Pointer "/userenv/number"' at t/db_dependent/api/v1/auth_basic.t line 52. got: undef expected: '1054' not ok 6 - exact match for JSON Pointer "/userenv/id" Failed test 'exact match for JSON Pointer "/userenv/id"' at t/db_dependent/api/v1/auth_basic.t line 52. got: undef expected: 'tomasito' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 15:51:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 14:51:49 +0000 Subject: [Koha-bugs] [Bug 23809] Update to DB revision 16.12.00.032 fails: `Not a HASH reference at /usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line 14371.` In-Reply-To: <bug-23809-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23809-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23809-70-zlwhXEt2SA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23809 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 19.05.x for 19.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 15:52:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 14:52:34 +0000 Subject: [Koha-bugs] [Bug 23772] Itemtype icons not showing in table In-Reply-To: <bug-23772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23772-70-SBNlZDoakM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23772 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Pushed to master |RESOLVED CC| |fridolin.somers at biblibre.co | |m --- Comment #8 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Depends on Bug 23602 not in 19.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 15:53:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 14:53:06 +0000 Subject: [Koha-bugs] [Bug 23804] Itemtype not checked when editing In-Reply-To: <bug-23804-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23804-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23804-70-mCwbOzOoNK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23804 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #10 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Depends on Bug 23602 not in 19.05.x -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 15:59:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 14:59:13 +0000 Subject: [Koha-bugs] [Bug 23826] Manual Invoice does not use new accounttype and status for fines In-Reply-To: <bug-23826-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23826-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23826-70-nQIj6xZUD6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23826 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Depends on| |22521 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 15:59:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 14:59:13 +0000 Subject: [Koha-bugs] [Bug 22521] Convert fines handling to use 'status' instead of two accounttypes In-Reply-To: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22521-70-ep0V6aBIkJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22521 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23826 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23826 [Bug 23826] Manual Invoice does not use new accounttype and status for fines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 16:00:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 15:00:39 +0000 Subject: [Koha-bugs] [Bug 23827] [19.05] Cash register statistics uses old accounttype values In-Reply-To: <bug-23827-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23827-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23827-70-6uWkEyNBqy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23827 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 16:03:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 15:03:32 +0000 Subject: [Koha-bugs] [Bug 23986] Batch Record Deletion does not remove records from Elasticsearch search index In-Reply-To: <bug-23986-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23986-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23986-70-nbZENaqn3m@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23986 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95188|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95229 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95229&action=edit Bug 23986: Pass strings to Catmandu for deletion The deletion subroutine expects to get a string, this is fine in most places, but when we sort our records for batch deletion they are cast to numbers and the delete is not processed. This patch quotes the biblionumbers as strings before passing them to Catmandu To aid in detecting orphaned records you can use the patches on bug 22831 To test: 1 - Have or create a bib 2 - Go to Tools->Batch record deletion 3 - Click 'Enter a list of record numbers' 4 - Enter the biblionumber' 5 - Confirm deletion 6 - Search for the record, it still appears 7 - Apply patch, restart all the things 8 - Repeat 1-6 9 - This time the record is deleted 10 - Test other methods of record deletion to confirm the record is removed Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 16:04:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 15:04:19 +0000 Subject: [Koha-bugs] [Bug 23826] Manual Invoice does not use new accounttype and status for fines In-Reply-To: <bug-23826-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23826-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23826-70-gCJZOVLd17@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23826 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22563 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 16:04:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 15:04:19 +0000 Subject: [Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes In-Reply-To: <bug-22563-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22563-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22563-70-mHC9Qk7xVV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23826 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 16:04:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 15:04:25 +0000 Subject: [Koha-bugs] [Bug 23986] Batch Record Deletion does not remove records from Elasticsearch search index In-Reply-To: <bug-23986-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23986-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23986-70-0kG1WMtsfv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23986 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Man, that's silly. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 16:09:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 15:09:37 +0000 Subject: [Koha-bugs] [Bug 23826] Manual Invoice does not use new accounttype and status for fines In-Reply-To: <bug-23826-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23826-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23826-70-rMjYkIDVah@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23826 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #8 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Conflict on 19.05.x because there is : <option value="L">Lost item</option> instead of <option value="LOST">Lost item</option> Looks like its from Bug 22563 not in 19.05.x : https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=91345 Pushed to 19.05.x for 19.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 16:15:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 15:15:58 +0000 Subject: [Koha-bugs] [Bug 23293] OPACFineNoRenewals always compares against 'balance' not 'outstanding' In-Reply-To: <bug-23293-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23293-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23293-70-mRMY1cQ49o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23293 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |The patchset adds a new release notes| |system preference, | |`OPACFineNoRenewalsIncludeC | |redits`, to control whether | |the `OPACFineNoRenewals` | |function uses the account | |balance or account amount | |outstanding for | |calculation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 16:16:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 15:16:24 +0000 Subject: [Koha-bugs] [Bug 23855] Cannot mark the selected suggestion as "pending" In-Reply-To: <bug-23855-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23855-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23855-70-2EWtDwxyBt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23855 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.05 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 19.05.x for 19.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 16:17:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 15:17:09 +0000 Subject: [Koha-bugs] [Bug 8959] Self checkout timeout is JavaScript-dependent In-Reply-To: <bug-8959-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8959-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8959-70-eZK56bp9gh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8959 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Is this still true? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 16:17:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 15:17:55 +0000 Subject: [Koha-bugs] [Bug 12585] Tag searching broken if QueryParser is turned on In-Reply-To: <bug-12585-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12585-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12585-70-kIYhZkDoG7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12585 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Resolution|--- |WORKSFORME Status|In Discussion |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 16:17:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 15:17:59 +0000 Subject: [Koha-bugs] [Bug 23863] Editing a basket clears create_items value In-Reply-To: <bug-23863-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23863-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23863-70-xbgIEwpi0m@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23863 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.x released in| | Status|Pushed to master |Pushed to stable --- Comment #12 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 19.05.x for 19.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 16:18:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 15:18:32 +0000 Subject: [Koha-bugs] [Bug 9327] Database update system should provide utility function for adding sysprefs In-Reply-To: <bug-9327-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9327-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9327-70-379k6RameR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9327 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |enhancement CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 16:19:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 15:19:02 +0000 Subject: [Koha-bugs] [Bug 23596] Update/Delete suggestion reason when receiving the item In-Reply-To: <bug-23596-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23596-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23596-70-XzMH3FePqe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23596 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|Seeking developer |Sponsored CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 16:20:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 15:20:27 +0000 Subject: [Koha-bugs] [Bug 23551] Problem with renewal period when using the renewal tab In-Reply-To: <bug-23551-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23551-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23551-70-tXDqrklKeL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23551 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #16 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 19.05.x for 19.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 16:21:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 15:21:17 +0000 Subject: [Koha-bugs] [Bug 24003] REST API basic auth lacks C4::Context->userenv In-Reply-To: <bug-24003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24003-70-gWSKy0p6Gg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 Lari Taskula <lari.taskula at hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 16:21:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 15:21:20 +0000 Subject: [Koha-bugs] [Bug 24003] REST API basic auth lacks C4::Context->userenv In-Reply-To: <bug-24003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24003-70-A00jaD5Au0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 --- Comment #2 from Lari Taskula <lari.taskula at hypernova.fi> --- Created attachment 95230 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95230&action=edit Bug 24003: Create new userenv for REST basic authentication To test: 1. prove t/db_dependent/api/v1/auth_basic.t 2. Observe success -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 16:22:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 15:22:21 +0000 Subject: [Koha-bugs] [Bug 23579] error during web install: 'changed_fields' can't have a default value In-Reply-To: <bug-23579-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23579-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23579-70-RF47V3KC9W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23579 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|19.11.00 |19.11.00,19.05.05 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #10 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 19.05.x for 19.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 16:25:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 15:25:35 +0000 Subject: [Koha-bugs] [Bug 18743] Filter suggestion lists correctly for IndependentBranches In-Reply-To: <bug-18743-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18743-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18743-70-y8JmmpOP05@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18743 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|19.11.00 |19.11.00,19.05.05 released in| | --- Comment #36 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 19.05.x for 19.05.05 Great job everyone and thanks a lot BULAC ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 16:27:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 15:27:03 +0000 Subject: [Koha-bugs] [Bug 23655] Debian jessie no longer supported In-Reply-To: <bug-23655-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23655-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23655-70-X7RrsuU37u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23655 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Depends on| |14570 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 [Bug 14570] Make it possible to add multiple guarantors to a record -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 16:27:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 15:27:03 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: <bug-14570-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14570-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14570-70-JCHoz0aOwQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23655 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23655 [Bug 23655] Debian jessie no longer supported -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 16:28:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 15:28:29 +0000 Subject: [Koha-bugs] [Bug 23596] Update/Delete suggestion reason when receiving the item In-Reply-To: <bug-23596-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23596-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23596-70-uWvBVdWRkh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23596 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 16:28:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 15:28:33 +0000 Subject: [Koha-bugs] [Bug 23596] Update/Delete suggestion reason when receiving the item In-Reply-To: <bug-23596-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23596-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23596-70-zZsDF7x6Pw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23596 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95231 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95231&action=edit Bug 23596: Edit suggestion's reason when receiving This patch displays and let the librarian edit the suggestion.reason information when receiving an order. Note that if no reason was given the edit is not possible (easily modifiable if needed but it seems that we do not want to display too much details unnecessarily) Test plan: - Create a suggestion and fill the reason - Create an order from this suggestion - Close the basket and start receiving the order => The reason is displayed and editable - Modify the reason and click Save - Receive again => The reason has been correctly modified - Play with the "Others..." option and give a specific reason Sponsored-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 16:30:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 15:30:05 +0000 Subject: [Koha-bugs] [Bug 23655] Debian jessie no longer supported In-Reply-To: <bug-23655-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23655-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23655-70-jFZXNCYYxT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23655 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED Resolution|--- |FIXED --- Comment #9 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Depends on Bug 14570 not in 19.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 16:35:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 15:35:16 +0000 Subject: [Koha-bugs] [Bug 17140] Incorrect rounding in total fines calculations, part 2 In-Reply-To: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17140-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17140-70-Hh3hV9DOVH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17140 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #48 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 19.05.x for 19.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 16:38:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 15:38:40 +0000 Subject: [Koha-bugs] [Bug 23788] Writing off multiple fees allows 'overpayment' of those fees In-Reply-To: <bug-23788-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23788-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23788-70-VbofP2xw2j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23788 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94787|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95232 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95232&action=edit Bug 23788: Rename $select to $selected_accts Signed-off-by: Sean McGarvey <seanm at pascolibraries.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 16:38:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 15:38:43 +0000 Subject: [Koha-bugs] [Bug 23788] Writing off multiple fees allows 'overpayment' of those fees In-Reply-To: <bug-23788-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23788-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23788-70-SimTcNmGy8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23788 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94788|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95233 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95233&action=edit Bug 23788: Rename $select_lines to $selected_lines Signed-off-by: Sean McGarvey <seanm at pascolibraries.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 16:38:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 15:38:47 +0000 Subject: [Koha-bugs] [Bug 23788] Writing off multiple fees allows 'overpayment' of those fees In-Reply-To: <bug-23788-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23788-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23788-70-LPYOWFEbEf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23788 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94789|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95234 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95234&action=edit Bug 23788: Recalculate ammount due for selected accountlines Individual fees cannot be overpaid of over-written off, but it's possible to 'overpay' a writeoff of selected fees. Test Plan: 1) Create 3 fees 2) Pick 2 and choose "Write off selected" 3) Write off more than the total amount of those fees 4) Apply this patch set 5) Restart all the things! 6) Try again, you should no longer be able to! Signed-off-by: Sean McGarvey <seanm at pascolibraries.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 16:39:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 15:39:53 +0000 Subject: [Koha-bugs] [Bug 23788] Writing off multiple fees allows 'overpayment' of those fees In-Reply-To: <bug-23788-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23788-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23788-70-sA5RTT94Lf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23788 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Works as expected and passes qa scripts. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 16:40:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 15:40:01 +0000 Subject: [Koha-bugs] [Bug 23788] Writing off multiple fees allows 'overpayment' of those fees In-Reply-To: <bug-23788-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23788-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23788-70-V1JjnWhjKi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23788 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 16:43:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 15:43:09 +0000 Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub In-Reply-To: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23975-70-lu2NCvrJIV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_target CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 16:43:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 15:43:41 +0000 Subject: [Koha-bugs] [Bug 20086] AddRenewal is not executed as a transaction and can results in partial success and doubled fines In-Reply-To: <bug-20086-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20086-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20086-70-8QsbSR3rpW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20086 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #10 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- There is a conflict for 19.05.x. Please provide dedicated patches. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 16:46:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 15:46:36 +0000 Subject: [Koha-bugs] [Bug 23867] 18.12.00.051 fails with "Truncated incorrect DOUBLE value" In-Reply-To: <bug-23867-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23867-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23867-70-d5quxrMYYu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23867 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.x released in| | Status|Pushed to master |Pushed to stable --- Comment #6 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 19.05.x for 19.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 16:50:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 15:50:12 +0000 Subject: [Koha-bugs] [Bug 23626] Add a system preference to limit the number of rows of data used when charting or exporting report results In-Reply-To: <bug-23626-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23626-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23626-70-8m8CSdfEnK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.05 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #51 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 19.05.x for 19.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 16:53:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 15:53:11 +0000 Subject: [Koha-bugs] [Bug 14697] Extend and enhance "Claims returned" lost status In-Reply-To: <bug-14697-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14697-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14697-70-jPlqsGNvfn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 Joy Nelson <joy at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement extends |This enhancement extends release notes|the "Claims returned" lost |the "Claims returned" lost |status and allows staff to |status and allows staff to |track items that patrons |track items that patrons |claim to have returned. |claim to have returned. |Items are marked as "Claims |Items are marked as "Claims |returned" from the checkout |returned" from the checkout |page in the staff side. |page in the staff side. |There are 3 new systems |There are 3 new systems |preferences to set for this |preferences to set for this |functionality to work. |functionality to work. | |Sponsored by: Fargo Public | |Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 16:55:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 15:55:05 +0000 Subject: [Koha-bugs] [Bug 17179] Advanced editor: Add keyboard shortcuts to repeat (duplicate) a field, and cut text In-Reply-To: <bug-17179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17179-70-XKFpy5zjKM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Joy Nelson <joy at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Sponsored by: Round Rock release notes| |Public Library CC| |joy at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 16:59:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 15:59:41 +0000 Subject: [Koha-bugs] [Bug 23630] Elasticsearch indexing is removing field 999 In-Reply-To: <bug-23630-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23630-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23630-70-1RxRqDnjzL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23630 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #9 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 19.05.x for 19.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 17:04:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 16:04:17 +0000 Subject: [Koha-bugs] [Bug 23089] Elasticsearch - cannot sort on non-text fields In-Reply-To: <bug-23089-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23089-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23089-70-efXeFgNvEP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23089 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #16 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Can it be applyed on 19.05.x even without Bug 20589 that added changed admin/searchengine/elasticsearch/field_config.yaml -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 17:08:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 16:08:03 +0000 Subject: [Koha-bugs] [Bug 23938] Title missing from Checked out box In-Reply-To: <bug-23938-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23938-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23938-70-BBoSTEy7YL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23938 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.05 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #6 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 19.05.x for 19.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 17:09:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 16:09:30 +0000 Subject: [Koha-bugs] [Bug 23767] Spent and Ordered total values don't include child funds on acqui-home In-Reply-To: <bug-23767-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23767-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23767-70-uv3uzbpt6V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23767 rkuiper at roundrocktexas.gov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rkuiper at roundrocktexas.gov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 17:29:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 16:29:31 +0000 Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub In-Reply-To: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23975-70-1uYwBlIrHT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- This is an awesome PoC :) Wish list wise I'd love to see. 1) Metadata that's currently embedded inside the plugins main class pulled out into a json (or yaml) file in the repository as a standard so we could read that and get things like supported versions etc into this. 2) Perhaps some 'Changelog.md' or 'Readme.md' support somehow at some point 3) Support for gitlab added. But, this is a great first proof we can refine :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 17:35:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 16:35:29 +0000 Subject: [Koha-bugs] [Bug 24003] REST API basic auth lacks C4::Context->userenv In-Reply-To: <bug-24003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24003-70-WOnH0cHih4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 Lari Taskula <lari.taskula at hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED Resolution|--- |WONTFIX --- Comment #3 from Lari Taskula <lari.taskula at hypernova.fi> --- After discussing this issue on IRC we came to a conclusion that we should use the Koha::Patron from koha.user stash instead, and fix Koha::Objects that rely on userenv alone. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 17:58:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 16:58:04 +0000 Subject: [Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results In-Reply-To: <bug-7611-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7611-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7611-70-mbwMWvbEJ6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92495|0 |1 is obsolete| | Attachment #94026|0 |1 is obsolete| | Attachment #94212|0 |1 is obsolete| | Attachment #95060|0 |1 is obsolete| | --- Comment #31 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95235 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95235&action=edit Bug 23986: Pass strings to Catmandu for deletion The deletion subroutine expects to get a string, this is fine in most places, but when we sort our records for batch deletion they are cast to numbers and the delete is not processed. This patch quotes the biblionumbers as strings before passing them to Catmandu To aid in detecting orphaned records you can use the patches on bug 22831 To test: 1 - Have or create a bib 2 - Go to Tools->Batch record deletion 3 - Click 'Enter a list of record numbers' 4 - Enter the biblionumber' 5 - Confirm deletion 6 - Search for the record, it still appears 7 - Apply patch, restart all the things 8 - Repeat 1-6 9 - This time the record is deleted 10 - Test other methods of record deletion to confirm the record is removed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 17:58:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 16:58:52 +0000 Subject: [Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results In-Reply-To: <bug-7611-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7611-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7611-70-R9PSSQiBsy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95235|0 |1 is obsolete| | --- Comment #32 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95236 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95236&action=edit Bug 7611: Show the NOT_LOAN authorised values for item status in XSLT OPAC search results Added : Call number for all not for loan status XSLT Results template improvement : Use the NOT_LOAN authorised values Improvement : Use the NOT_LOAN authorised values when showing items status in the OPAC search results. Before this patch, these items were only considered as "unavailable". Note : This patch only affects the OPAC XSLT search results template for MARC21 records. This patch was not tested on UNIMARC or NORMARC records. I won't be able to support these formats, so I'm hoping someone could do the same for these other record formats. Patch sponsored by the CCSR ( http://www.ccsr.qc.ca ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 17:58:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 16:58:56 +0000 Subject: [Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results In-Reply-To: <bug-7611-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7611-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7611-70-1JYD7H181d@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611 --- Comment #33 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95237 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95237&action=edit Bug 7611: Change negative notforloan as well This makes the changes apply to both positive and negative notforloan values The extra line generated before is removed Some spans are added and cleaned up and labels moved to CSS to allow for easier altering where needed Itemtypes marked notforloan remain as reference, the label can be changed via css To test: 1 - Have a record with items in various statuses, ideally - 3 available, with 2 in one branch, 1 in another - 3 with itemtype not for loan, 2 in one branch, 1 in another - 3 in a positive not for loan status, 2 and 1 as above - 3 in a negative not for loan status, 2 and 1 as above - 1 in a different positive loan status, but with the same opac description as the negative above 2 - Search the opac to include this record, take a screenshot 3 - Apply patch 4 - Restart all and refresh 5 - Compare to screen shot 6 - Differences include: - Positive statuses are now on separate line with opac description showing - Unavailable (not for loan items) now include callnumber and branch in display - Positive and negative notforloan with same description are combined where branches match - Inspect the elements, note new spans around 'Items available for loan/reference' 7 - Add to OPACUserCSS: .ItemSummary .ItemBranch{ display:none; } .unavailable .ItemSummary .CallNumber,.unavailable .ItemSummary .LabelCallNumber{ display:none; } 8 - Note the branches are hidden, and callnumbe rhidden for unavailable items Signed-off-by: Jessica Zairo <jzairo at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 17:59:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 16:59:00 +0000 Subject: [Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results In-Reply-To: <bug-7611-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7611-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7611-70-uMAIeNdzKt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611 --- Comment #34 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95238 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95238&action=edit Bug 7611: (follow-up) Add missing space -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 17:59:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 16:59:04 +0000 Subject: [Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results In-Reply-To: <bug-7611-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7611-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7611-70-glx8EmLOoI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611 --- Comment #35 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95239 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95239&action=edit Bug 7611: (follow-up) Fix display of undefined statuses and add a class -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 17:59:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 16:59:09 +0000 Subject: [Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results In-Reply-To: <bug-7611-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7611-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7611-70-TxwjRFmOLJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611 --- Comment #36 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95240 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95240&action=edit Bug 7611: (follow-up) separate positive and negative statuses as in the past This patch preserves someting closer to previous functionality. Negative not for loan are in the 'unavailable' section in red, positive ones are in the 'reference' section in green. Itemtype level will also be in green in reference Item specific status will override an itemtype level. The line break between 'reference' and 'unavailable' existed before and is preserved - negative not for loan and checked out items appear here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 18:03:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 17:03:34 +0000 Subject: [Koha-bugs] [Bug 7611] Show the NOT_LOAN authorised values for item status in XSLT OPAC search results In-Reply-To: <bug-7611-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7611-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7611-70-9MvHLBG8ax@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7611 --- Comment #37 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Katrin Fischer from comment #30) > (In reply to Nick Clemens from comment #27) > > 1) We have built on the fact that the not-for-loan works the same on item > type as on individual level and I think this change might be controversial. Good point, last patch restores postive statuses to the 'green' section. Itemtype notforloan get 'Not for loan' as description and will lump with any others with same description > 2) The display with the extra break looks like we are missing a label (I > think it's intended, but that's the impression I get) The line break was always there for Checked Out or On Order items, so I opted to preserve it. Negative not for loan are on this line as they were all 'On order' before - the negative seeming to imply 'holdable' but not 'available' > Just notes (no blockers at all): > > I see that you use individual CSS classes on the items, I like that. Just > wondering: currently we use the description, so a description change will > mean the CSS needs to change as well. On the other side: not for loan values > are numeric and we are grouping the onces with the same name and I like that > - so that's probably the best way. Excellent, I think you agree with me here that grouping by description is good. It allows for staff to have two separate values with differing descriptions that show the same on the opac, which I think could have value. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 18:09:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 17:09:18 +0000 Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub In-Reply-To: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23975-70-jT2di3kavV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Going further with the moving metadata outside of the file, this could allow us to adopt signed manifest approach and make our plugins that bit more secure and reliable. Let's give this a real push for 20.05 and give the best plugins another bug lift in that release. That should give us ample time to work it out. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 19:04:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 18:04:54 +0000 Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace In-Reply-To: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18595-70-omCSlsBTig@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 19:20:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 18:20:54 +0000 Subject: [Koha-bugs] [Bug 20407] Hide some fields from unauthorized users In-Reply-To: <bug-20407-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20407-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20407-70-Kj50vpqyVa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20407 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |WONTFIX --- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> --- We implemented the separate /public namespace already. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 19:28:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 18:28:49 +0000 Subject: [Koha-bugs] [Bug 23851] Auto generate accession number format <branchcode>yymm0001 fails to add branchcode prefix(branchcode) for multiple item addition In-Reply-To: <bug-23851-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23851-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23851-70-1KLs814omy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23851 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #11 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Thanks for this fix! It is present in 18.11 also. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 19:31:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 18:31:16 +0000 Subject: [Koha-bugs] [Bug 17505] Add routes for messaging preferences In-Reply-To: <bug-17505-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17505-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17505-70-ltT1YeyKXR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17505 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|tomascohen at gmail.com | Assignee|koha-bugs at lists.koha-commun |lari.taskula at hypernova.fi |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 21:26:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 20:26:23 +0000 Subject: [Koha-bugs] [Bug 21979] Add option to SIP2 config to send arbitrary item field in CR instead of collection code In-Reply-To: <bug-21979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21979-70-opGGDq7lZT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21979 Bouzid Fergani <bouzid.fergani at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bouzid.fergani at inlibro.com --- Comment #6 from Bouzid Fergani <bouzid.fergani at inlibro.com> --- Hi Kyle, We have conflict in etc/SIPconfig.xml when applying. Bug 21979 - Add option to SIP2 config to send arbitrary item field in CR instead of collection code 93535 - Works as expected. Thanks. Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 21979: Add option to SIP2 config to send arbitrary item field in CR instead of collection code Using index info to reconstruct a base tree... M etc/SIPconfig.xml Falling back to patching base and 3-way merge... Auto-merging etc/SIPconfig.xml CONFLICT (content): Merge conflict in etc/SIPconfig.xml error: Failed to merge in the changes. Patch failed at 0001 Bug 21979: Add option to SIP2 config to send arbitrary item field in CR instead of collection code The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Works-as-expected-Thanks-ELLAUG.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 21:26:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 20:26:34 +0000 Subject: [Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized In-Reply-To: <bug-22381-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22381-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22381-70-6bhL833fFk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95127|0 |1 is obsolete| | --- Comment #8 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 95241 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95241&action=edit Bug 22381: Change wording on Calendar-related system preferences TEST PLAN: 1. Apply Patch 2. Look at the 4 sysprefs (useDaysMode, OverdueNoticeCalendar, finesCalendar, ExcludeHolidaysFromMaxPickUpDelay) 3. Make sure the wording and options all make sense 4. Make sure the options are properly ignoring or using the calendar. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 21:26:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 20:26:57 +0000 Subject: [Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized In-Reply-To: <bug-22381-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22381-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22381-70-nWvjpqX7XK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 21:34:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 20:34:26 +0000 Subject: [Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing of required indexes In-Reply-To: <bug-19482-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19482-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19482-70-DDNE0csqJH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482 Bouzid Fergani <bouzid.fergani at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bouzid.fergani at inlibro.com --- Comment #34 from Bouzid Fergani <bouzid.fergani at inlibro.com> --- Hi, We have conflict when applying. Bug 19482 - Elasticsearch - prevent removal / editing of required indexes 93371 - Bug 19482 - DB changes 93372 - Bug 19482 - Add support for defining 'mandatory' mappings 93373 - Bug 19482: SCHEMA CHANGES - DO NOT PUSH Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 19482 - DB changes Using index info to reconstruct a base tree... M installer/data/mysql/kohastructure.sql Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/kohastructure.sql CONFLICT (content): Merge conflict in installer/data/mysql/kohastructure.sql error: Failed to merge in the changes. Patch failed at 0001 Bug 19482 - DB changes The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-19482---DB-changes-FC4ixa.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 22:10:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 21:10:48 +0000 Subject: [Koha-bugs] [Bug 23958] Use Font Awesome icon to replace "new window" icon image In-Reply-To: <bug-23958-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23958-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23958-70-nhvHHXE8pi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23958 Maryse Simard <maryse.simard at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95032|0 |1 is obsolete| | --- Comment #2 from Maryse Simard <maryse.simard at inlibro.com> --- Created attachment 95242 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95242&action=edit Bug 23958: Use Font Awesome icon to replace "new window" icon image This patch modifies several templates in order to eliminate the dependency on an image file for styling certain links which open popups or new windows. A Font Awesome icon is used instead. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Cataloging: - Create a new MARC record which has the same ISBN as a record in your catalog. - When you save the record it should warn you that it is a possible duplicate. The message should contain an icon-prefixed link to the existing record. - Clicking the link should open details about the title in a new window. Circulation: - Enable the itemBarcodeFallbackSearch system preference. - Open a patron for checkout and enter a word in the "barcode" field instead of a barcode. - The page should return a list of titles to choose from. Each title should be a link with an icon. Clicking the link should open details about the title in a new window. Acquisitions: - Go to Acquistisions -> Vendor -> Basket. - Choose "Add to basket" -> From an external source. - Search for and select a record which exists in your catalog. - You should be taken to a page with a "Duplicate warning" message. The message should contain an icon-prefixed link to the existing record. - Clicking this link should open details about the title in a new window. - Create a MARC file with two records: One which exists in your catalog and one which doesn't. Stage that file for import. - Choose "Add to basket" again and select "From a staged file." - Select the file you staged. - You should be taken to a page with a "Duplicate warning" message. The message should contain an icon-prefixed link to the existing record. - Clicking the link should open details about the title in a new window. Patrons: - Create a new patron which has the same name and birthday as an existing patron. - When you save the record you should be shown a duplicate warning. The link to the possible duplicate patron should be prefixed with an icon and should open the patron's details in a popup window. Signed-off-by: Maryse Simard <maryse.simard at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 22:11:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 21:11:07 +0000 Subject: [Koha-bugs] [Bug 23958] Use Font Awesome icon to replace "new window" icon image In-Reply-To: <bug-23958-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23958-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23958-70-fiGw8Xsy79@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23958 Maryse Simard <maryse.simard at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maryse.simard at inlibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 22:33:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 21:33:33 +0000 Subject: [Koha-bugs] [Bug 23993] Can't call method "notforloan" on an undefined value at C4/Reserves.pm line 1177. In-Reply-To: <bug-23993-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23993-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23993-70-LvLc6gNDG5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23993 Bouzid Fergani <bouzid.fergani at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95186|0 |1 is obsolete| | --- Comment #3 from Bouzid Fergani <bouzid.fergani at inlibro.com> --- Created attachment 95243 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95243&action=edit Bug 23993: Add check if itemtype exists in IsAvailableForItemLevelRequest Trivial change Test plan: Run Reserves.t Import book with unknown item type, try to place hold (with/without patch) Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 22:38:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 21:38:37 +0000 Subject: [Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history In-Reply-To: <bug-18795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18795-70-ilH9PVWYci@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795 Bouzid Fergani <bouzid.fergani at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bouzid.fergani at inlibro.com --- Comment #10 from Bouzid Fergani <bouzid.fergani at inlibro.com> --- Hi, Please rebase this patch. Bug 18795 - REST API: DELETE (anonymize) checkout history 94547 - Bug 18795: DELETE (anonymize) checkout history 94552 - Bug 18795: (follow-up) Check whether patrons exists before deleting history 94555 - Bug 18795: (follow-up) Unify error message to be same across codebase Apply? [(y)es, (n)o, (i)nteractive] y Applying: Bug 18795: DELETE (anonymize) checkout history Using index info to reconstruct a base tree... M Koha/REST/V1/Checkouts.pm M api/v1/swagger/paths.json Falling back to patching base and 3-way merge... Auto-merging api/v1/swagger/paths.json CONFLICT (content): Merge conflict in api/v1/swagger/paths.json Auto-merging Koha/REST/V1/Checkouts.pm error: Failed to merge in the changes. Patch failed at 0001 Bug 18795: DELETE (anonymize) checkout history The copy of the patch that failed is found in: .git/rebase-apply/patch When you have resolved this problem run "git bz apply --continue". If you would prefer to skip this patch, instead run "git bz apply --skip". To restore the original branch and stop patching run "git bz apply --abort". Patch left in /tmp/Bug-18795-DELETE-anonymize-checkout-history-G3iEhh.patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 22:49:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 21:49:35 +0000 Subject: [Koha-bugs] [Bug 23957] Remove button style with famfamfam icon background and replace with Font Awesome In-Reply-To: <bug-23957-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23957-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23957-70-FrrEP2Jxj3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23957 Maryse Simard <maryse.simard at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95027|0 |1 is obsolete| | --- Comment #5 from Maryse Simard <maryse.simard at inlibro.com> --- Created attachment 95244 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95244&action=edit Bug 23957: Remove button style with famfamfam icon background and replace with Font Awesome The patch modifies the markup and CSS related to the holds template in the staff client when holds policy override is necessary. The CSS background image is replaced with a Font Awesome icon. <input>s are replaced with <button>s to allow for the icon markup. To test, apply the patch and regenerate the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). - Enable the AllowHoldPolicyOverride system preference. - Start the process of placing a hold for a patron on a title which would not normally be available for hold. For instance: The patron already has too many holds. - On the hold confirmation screen the "Place hold" buttons should appear with a little yellow "warning" icon. - Clicking either of the two "Place hold" buttons should trigger a confirmation dialog. Test both the "Confirm" and "Cancel" options. Signed-off-by: Maryse Simard <maryse.simard at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 8 22:53:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 21:53:09 +0000 Subject: [Koha-bugs] [Bug 23957] Remove button style with famfamfam icon background and replace with Font Awesome In-Reply-To: <bug-23957-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23957-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23957-70-3tVNvXyVYc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23957 Maryse Simard <maryse.simard at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |maryse.simard at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 9 00:13:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 08 Nov 2019 23:13:48 +0000 Subject: [Koha-bugs] [Bug 24004] New: "Help" link at Intranet's mainpage leads to a "Forbidden" page (es-ES) Message-ID: <bug-24004-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24004 Bug ID: 24004 Summary: "Help" link at Intranet's mainpage leads to a "Forbidden" page (es-ES) Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: hilongo at gmail.com QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr When the language is set to spanish (es-ES), clicking on Help link at intranet's mainpage leads (or should lead) to the manual page in spanish for the specific version ... in this case, it leads to https://koha-community.org/manual//19.05/es/html/ which presents a "Forbidden" error. If the manual page for a specific version/language does not exists, it would be better if this error could be catched and redirected to a more useful page. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 9 05:50:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Nov 2019 04:50:32 +0000 Subject: [Koha-bugs] [Bug 24005] New: Software error: at login Message-ID: <bug-24005-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24005 Bug ID: 24005 Summary: Software error: at login Change sponsored?: --- Product: Koha Version: 19.05 Hardware: PC OS: Linux Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (command-line installer) Assignee: koha-bugs at lists.koha-community.org Reporter: andrewanandal at gmail.com QA Contact: testopia at bugs.koha-community.org Created attachment 95245 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95245&action=edit Error Page Dear all Greetings! I am a new Koha user establishing library system for a non-profit postgraduate educational institution. Nice to meet all developers and thank you for making Koha freely accessible to all globally. Just now I have installed Koha 19.05 on Ubuntu using Ubuntu 18.04.3 LTS terminal, following all the steps in the webinstaller. I attempted logging in using the newly created administrator password. An error message popped up in the subsequent screen: ______________________________________________________________________ Software error: DBIx::Class::Storage::DBI::_dbh_execute(): Table 'koha_library.discharges' doesn't exist at /usr/share/koha/lib/Koha/Patron/Discharge.pm line 31 For help, please send mail to the webmaster ([no address given]), giving this error message and the time and date of the error. ______________________________________________________________________ Attached is the error screen for your reference. For your information, the MySQL on the Ubuntu 18.04.3 LTS downloaded through Ubuntu terminal using "sudo apt-get mysql-server". Also during installation, I followed all the steps as mentioned on https://wiki.koha-community.org/wiki/Koha_on_ubuntu_-_packages. The patron categories and administrator account were already set up during the webinstall stage. Could anyone give some pointers ahead? Most grateful for all your professional advice! Best Andrew -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 9 11:06:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Nov 2019 10:06:05 +0000 Subject: [Koha-bugs] [Bug 24005] Software error: at login In-Reply-To: <bug-24005-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24005-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24005-70-hTvnsTXwUA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24005 --- Comment #1 from Andrew Lau <andrewanandal at gmail.com> --- No Executing opening the discharge.pm at the destination folder, the following is obtained: --------------------------------------------------------------------------- GNU nano 2.9.3 /usr/share/koha/lib/Koha/Patron/Discharge.pm Modified my $cond = { 'me.needed' => { '!=', undef }, 'me.validated' => undef, ( defined $borrowernumber ? ( 'me.borrower' => $borrowernumber ) : () ), ( defined $branchcode ? ( 'borrower.branchcode' => $branchcode ) : () ), }; return search_limited( $cond ); } sub get_validated { my ($params) = @_; my $branchcode = $params->{branchcode}; my $borrowernumber = $params->{borrowernumber}; my $cond = { 'me.validated' => { '!=', undef }, ( defined $borrowernumber ? ( 'me.borrower' => $borrowernumber ) : () ), ( defined $branchcode ? ( 'borrower.branchcode' => $branchcode ) : () ), }; return search_limited( $cond ); } # TODO This module should be based on Koha::Object[s] sub search_limited { my ( $params, $attributes ) = @_; my $userenv = C4::Context->userenv; my @restricted_branchcodes; if ( $userenv and $userenv->{number} ) { my $logged_in_user = Koha::Patrons->find( $userenv->{number} ); @restricted_branchcodes = $logged_in_user->libraries_where_can_see_patrons; } $params->{'borrower.branchcode'} = { -in => \@restricted_branchcodes } if @restricted_branchcodes; $attributes->{join} = 'borrower'; my $rs = Koha::Database->new->schema->resultset('Discharge'); return $rs->search( $params, { join => 'borrower' } ); } 1; ------------------------------------------------------------------------ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 9 11:14:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Nov 2019 10:14:55 +0000 Subject: [Koha-bugs] [Bug 24005] Software error: at login In-Reply-To: <bug-24005-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24005-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24005-70-0XuTwHpin4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24005 --- Comment #2 from Andrew Lau <andrewanandal at gmail.com> --- This is the complete text from nano at Discharge.pm ------------------------------------------------------------------------- GNU nano 2.9.3 /usr/share/koha/lib/Koha/Patron/Discharge.pm Modified package Koha::Patron::Discharge; use Modern::Perl; use CGI; use File::Temp qw( :POSIX ); use Carp; use C4::Templates qw ( gettemplate ); use C4::Letters qw ( GetPreparedLetter ); use Koha::Database; use Koha::DateUtils qw( dt_from_string output_pref ); use Koha::Patrons; use Koha::Patron::Debarments; sub count { my ($params) = @_; my $values = {}; if( $params->{borrowernumber} ) { $values->{borrower} = $params->{borrowernumber}; } if( $params->{pending} ) { $values->{needed} = { '!=', undef }; $values->{validated} = undef; } elsif( $params->{validated} ) { $values->{validated} = { '!=', undef }; } return search_limited( $values )->count; } sub can_be_discharged { my ($params) = @_; return unless $params->{borrowernumber}; my $patron = Koha::Patrons->find( $params->{borrowernumber} ); return unless $patron; my $has_pending_checkouts = $patron->checkouts->count; return $has_pending_checkouts ? 0 : 1; } sub is_discharged { my ($params) = @_; return unless $params->{borrowernumber}; my $borrowernumber = $params->{borrowernumber}; my $restricted = Koha::Patrons->find( $borrowernumber )->is_debarred; my @validated = get_validated({borrowernumber => $borrowernumber}); if ($restricted && @validated) { return 1; } else { return 0; } } sub request { my ($params) = @_; my $borrowernumber = $params->{borrowernumber}; return unless $borrowernumber; return unless can_be_discharged({ borrowernumber => $borrowernumber }); my $rs = Koha::Database->new->schema->resultset('Discharge'); return $rs->create({ borrower => $borrowernumber, needed => dt_from_string, }); } sub discharge { my ($params) = @_; my $borrowernumber = $params->{borrowernumber}; return unless $borrowernumber and can_be_discharged( { borrowernumber => $borrowernumber } ); # Cancel reserves my $patron = Koha::Patrons->find( $borrowernumber ); my $holds = $patron->holds; while ( my $hold = $holds->next ) { $hold->cancel; } # Debar the member Koha::Patron::Debarments::AddDebarment({ borrowernumber => $borrowernumber, type => 'DISCHARGE', }); # Generate the discharge my $rs = Koha::Database->new->schema->resultset('Discharge'); my $discharge = $rs->search({ borrower => $borrowernumber }, { order_by => { -desc => 'needed' }, rows => 1 }); if( $discharge->count > 0 ) { $discharge->update({ validated => dt_from_string }); } else { $rs->create({ borrower => $borrowernumber, validated => dt_from_string, }); } } sub generate_as_pdf { my ($params) = @_; return unless $params->{borrowernumber}; my $patron = Koha::Patrons->find( $params->{borrowernumber} ); my $letter = C4::Letters::GetPreparedLetter( module => 'members', letter_code => 'DISCHARGE', lang => $patron->lang, tables => { borrowers => $params->{borrowernumber}, branches => $params->{'branchcode'}, }, ); my $today = output_pref( dt_from_string() ); $letter->{'title'} =~ s/<<today>>/$today/g; $letter->{'content'} =~ s/<<today>>/$today/g; my $tmpl = C4::Templates::gettemplate('batch/print-notices.tt', 'intranet', new CGI); $tmpl->param( stylesheet => C4::Context->preference("NoticeCSS"), today => $today, messages => [$letter], ); my $html_path = tmpnam() . '.html'; my $pdf_path = tmpnam() . '.pdf'; my $html_content = $tmpl->output; open my $html_fh, '>:encoding(utf8)', $html_path; say $html_fh $html_content; close $html_fh; my $output = eval { require PDF::FromHTML; return; } || $@; if ($output && $params->{testing}) { carp $output; $pdf_path = undef; } elsif ($output) { die $output; } else { my $pdf = PDF::FromHTML->new( encoding => 'utf-8' ); $pdf->load_file( $html_path ); $pdf->convert; $pdf->write_file( $pdf_path ); } return $pdf_path; } sub get_pendings { my ($params) = @_; my $branchcode = $params->{branchcode}; my $borrowernumber = $params->{borrowernumber}; my $cond = { 'me.needed' => { '!=', undef }, 'me.validated' => undef, ( defined $borrowernumber ? ( 'me.borrower' => $borrowernumber ) : () ), ( defined $branchcode ? ( 'borrower.branchcode' => $branchcode ) : () ), }; return search_limited( $cond ); } sub get_validated { my ($params) = @_; my $branchcode = $params->{branchcode}; my $borrowernumber = $params->{borrowernumber}; my $cond = { 'me.validated' => { '!=', undef }, ( defined $borrowernumber ? ( 'me.borrower' => $borrowernumber ) : () ), ( defined $branchcode ? ( 'borrower.branchcode' => $branchcode ) : () ), }; return search_limited( $cond ); } # TODO This module should be based on Koha::Object[s] sub search_limited { my ( $params, $attributes ) = @_; my $userenv = C4::Context->userenv; my @restricted_branchcodes; if ( $userenv and $userenv->{number} ) { my $logged_in_user = Koha::Patrons->find( $userenv->{number} ); @restricted_branchcodes = $logged_in_user->libraries_where_can_see_patrons; } $params->{'borrower.branchcode'} = { -in => \@restricted_branchcodes } if @restricted_branchcodes; $attributes->{join} = 'borrower'; my $rs = Koha::Database->new->schema->resultset('Discharge'); return $rs->search( $params, { join => 'borrower' } ); } 1; ------------------------------------------------------------------------ Wonder if the table 'koha_library.discharges' should simply be added back at line 31. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sat Nov 9 12:34:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 09 Nov 2019 11:34:58 +0000 Subject: [Koha-bugs] [Bug 24005] Software error: at login In-Reply-To: <bug-24005-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24005-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24005-70-52dhIlxxAW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24005 Andrew Lau <andrewanandal at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Priority|P5 - low |P2 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 10 11:13:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 10 Nov 2019 10:13:36 +0000 Subject: [Koha-bugs] [Bug 23680] Can't open 'Edit items' or 'Add item' links in new tab - tab is closed immediately In-Reply-To: <bug-23680-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23680-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23680-70-7KcXuNrpR8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23680 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 03:31:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 02:31:23 +0000 Subject: [Koha-bugs] [Bug 22333] Replace duplicated code in CanBookBeRenewed with GetSoonestRenewDate In-Reply-To: <bug-22333-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22333-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22333-70-B5x2umKjG6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22333 --- Comment #10 from David Cook <dcook at prosentient.com.au> --- I have too many other priorities, so I'm probably not going to be looking at this any time soon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 03:32:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 02:32:16 +0000 Subject: [Koha-bugs] [Bug 22223] Item url double-encode when parameter is an encoded URL In-Reply-To: <bug-22223-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22223-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22223-70-ereolJW0sg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22223 --- Comment #13 from David Cook <dcook at prosentient.com.au> --- (In reply to Jonathan Druart from comment #12) > Here is a patch for discussion, could you confirm it fixes the issues you > faced? Apologies for the delay, Jonathan. I have too many other priorities at the moment, so I probably won't be testing this or following up for a long time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 03:33:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 02:33:59 +0000 Subject: [Koha-bugs] [Bug 19014] Patrons should not get an 'on_reserve' notification if the due date is far into the future In-Reply-To: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19014-70-uki7y5pR3E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 --- Comment #41 from David Cook <dcook at prosentient.com.au> --- I'm probably not going to work on this for a long time. I have a local fix which seems to be working for my libraries. I'll keep this on my todo list, but have no plans to work on it currently. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 07:41:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 06:41:17 +0000 Subject: [Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history In-Reply-To: <bug-18795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18795-70-ZhEOgucydp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795 Johanna Räisä <johanna.raisa at koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94547|0 |1 is obsolete| | --- Comment #11 from Johanna Räisä <johanna.raisa at koha-suomi.fi> --- Created attachment 95246 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95246&action=edit Bug 18795: DELETE (anonymize) checkout history Rebased patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 07:42:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 06:42:19 +0000 Subject: [Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history In-Reply-To: <bug-18795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18795-70-rkyjCmzphb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795 Johanna Räisä <johanna.raisa at koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94552|0 |1 is obsolete| | --- Comment #12 from Johanna Räisä <johanna.raisa at koha-suomi.fi> --- Created attachment 95247 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95247&action=edit Bug 18795: (follow-up) Check whether patrons exists before deleting history Rebased patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 07:43:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 06:43:03 +0000 Subject: [Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history In-Reply-To: <bug-18795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18795-70-ACQvrF996z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795 Johanna Räisä <johanna.raisa at koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94555|0 |1 is obsolete| | --- Comment #13 from Johanna Räisä <johanna.raisa at koha-suomi.fi> --- Created attachment 95248 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95248&action=edit Bug 18795: (follow-up) Unify error message to be same across codebase Rebased patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 08:25:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 07:25:28 +0000 Subject: [Koha-bugs] [Bug 24003] REST API basic auth lacks C4::Context->userenv In-Reply-To: <bug-24003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24003-70-hqJMuyWkTj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 09:25:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 08:25:05 +0000 Subject: [Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history In-Reply-To: <bug-18795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18795-70-wjgoujdcgP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795 Johanna Räisä <johanna.raisa at koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 09:32:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 08:32:05 +0000 Subject: [Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8 In-Reply-To: <bug-24002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24002-70-IHBXfDRT3d@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002 --- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Martin Renvoize from comment #14) > Minor concern is whether we might be missing some DB updates to ensure all > tables are filled with expected data to start with.. Hum actually it's too late. We cannot longer write such query: update opac_news set expirationdate=NULL WHERE expirationdate="0000-00-00"; As it will fail: ERROR 1292 (22007): Incorrect date value: '0000-00-00' for column 'expirationdate' at row 1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 09:43:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 08:43:00 +0000 Subject: [Koha-bugs] [Bug 23964] An item level hold when placed is set to Waiting, if ReservesNeedReturn is set to Automatic In-Reply-To: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23964-70-D79uFYF9d4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23964 --- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95249 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95249&action=edit Bug 23964: Use is instead of isnt in tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 09:45:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 08:45:26 +0000 Subject: [Koha-bugs] [Bug 23964] An item level hold when placed is set to Waiting, if ReservesNeedReturn is set to Automatic In-Reply-To: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23964-70-E01wy3Wxa0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23964 --- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- 725 my $hold_1 = place_item_hold( $patron, $item, $library, $priority ); 726 $hold = place_item_hold( $patron_2, $item, $library, $priority ); 727 is( $hold->priority, 1, 'If ReservesNeedReturns is 0 but item already on hold priority must be set to 1' ); What about $hold_1->priority? Should not we have $hold->priority == 1 here? 737 isnt( $hold->priority, 0, 'If ReservesNeedReturns is 0 but item in transit the hold must not be set to waiting' ); Test's description does not match the test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 09:48:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 08:48:09 +0000 Subject: [Koha-bugs] [Bug 23850] /t/db_dependent/www/history.t failing on D8 In-Reply-To: <bug-23850-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23850-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23850-70-OBr5ogBkWx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23850 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- This has been (magically?) fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 10:03:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 09:03:47 +0000 Subject: [Koha-bugs] [Bug 23672] Dependency graph colours missing In-Reply-To: <bug-23672-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23672-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23672-70-QNUtBPbKN1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23672 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95250 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95250&action=edit Display different colors on the dependency graph -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 10:04:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 09:04:32 +0000 Subject: [Koha-bugs] [Bug 23672] Dependency graph colours missing In-Reply-To: <bug-23672-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23672-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23672-70-thHaYdda9a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23672 --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- This is a patch I wrote for a previous version of Bugzilla. Chris could you confirm that it does no longer apply/works on the version we are now using? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 10:16:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 09:16:09 +0000 Subject: [Koha-bugs] [Bug 23785] Software error Can't call method "get_coins" on an undefined value at /usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 692. In-Reply-To: <bug-23785-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23785-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23785-70-oNHUtEcO38@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23785 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 10:16:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 09:16:13 +0000 Subject: [Koha-bugs] [Bug 23785] Software error Can't call method "get_coins" on an undefined value at /usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 692. In-Reply-To: <bug-23785-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23785-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23785-70-QnUJvsNKBi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23785 --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95251 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95251&action=edit Bug 23785: Fix call get_coins on undef value in opac-search.pl If the search engine index returns a record that is no longer in the DB, an OPAC search will explode with: Can't call method "get_coins" on an undefined value at /usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 692. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 10:16:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 09:16:50 +0000 Subject: [Koha-bugs] [Bug 23785] Software error Can't call method "get_coins" on an undefined value at /usr/share/koha/opac/cgi-bin/opac/opac-search.pl line 692. In-Reply-To: <bug-23785-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23785-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23785-70-X9SXP93NDl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23785 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|oleonard at myacpl.org |jonathan.druart at bugs.koha-c | |ommunity.org Version|19.05 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 11:14:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 10:14:07 +0000 Subject: [Koha-bugs] [Bug 23800] Batch modification tool orders items by barcode incremental by default (regression to 17.11) In-Reply-To: <bug-23800-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23800-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23800-70-A7gqA6QPLM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 --- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95252 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95252&action=edit [ALTERNATIVE-PATCH] Bug 23800: Does not order items by barcode in batch item modification They must be displayed in the same order they have been scanned (or they appear in the file) This is an alternative patch. Same behavior for barcodes or itemnumbers, as well as if a file has been used or items scanned. Code is duplicated, but refactoring is out of the scope. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 11:15:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 10:15:50 +0000 Subject: [Koha-bugs] [Bug 23850] /t/db_dependent/www/history.t failing on D8 In-Reply-To: <bug-23850-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23850-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23850-70-HZhGXw91cB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23850 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |DUPLICATE --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- My bad, I thought I'd marked this as a duplicated at the time I fixed it: It turns out it was bug 23655 *** This bug has been marked as a duplicate of bug 23655 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 11:15:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 10:15:50 +0000 Subject: [Koha-bugs] [Bug 23655] Debian jessie no longer supported In-Reply-To: <bug-23655-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23655-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23655-70-qD8G9dnLq2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23655 --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- *** Bug 23850 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 11:33:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 10:33:07 +0000 Subject: [Koha-bugs] [Bug 23788] Writing off multiple fees allows 'overpayment' of those fees In-Reply-To: <bug-23788-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23788-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23788-70-nwPhB61Gyk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23788 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 11:33:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 10:33:09 +0000 Subject: [Koha-bugs] [Bug 23788] Writing off multiple fees allows 'overpayment' of those fees In-Reply-To: <bug-23788-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23788-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23788-70-PdmYEeGpD1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23788 --- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 11:33:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 10:33:11 +0000 Subject: [Koha-bugs] [Bug 23986] Batch Record Deletion does not remove records from Elasticsearch search index In-Reply-To: <bug-23986-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23986-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23986-70-qat11xxQDr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23986 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 11:33:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 10:33:13 +0000 Subject: [Koha-bugs] [Bug 23986] Batch Record Deletion does not remove records from Elasticsearch search index In-Reply-To: <bug-23986-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23986-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23986-70-n908Ra1i4w@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23986 --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 11:45:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 10:45:26 +0000 Subject: [Koha-bugs] [Bug 23822] No warning is produced when trying to delete a patron with credit (patron is not deleted) In-Reply-To: <bug-23822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23822-70-mSJLEhUl5J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23822 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |martin.renvoize at ptfs-europe | |.com, tomascohen at gmail.com --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- This statement: my $charges = $patron->account->non_issues_charges; will return -15 on master and 0 on 19.05.X Tomas, Martin, what is the expected behavior? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 12:15:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 11:15:35 +0000 Subject: [Koha-bugs] [Bug 23822] No warning is produced when trying to delete a patron with credit (patron is not deleted) In-Reply-To: <bug-23822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23822-70-nZKnXcRSW9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23822 --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- (In reply to Jonathan Druart from comment #1) > This statement: > my $charges = $patron->account->non_issues_charges; > will return -15 on master and 0 on 19.05.X > > Tomas, Martin, what is the expected behavior? Well.. non_issuing_charges should only return debts, so I'd say master has developed a bug. (The query should include a `AND debit_type_code IS NOT NULL` I believe.) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 12:18:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 11:18:04 +0000 Subject: [Koha-bugs] [Bug 23888] Incorrect vendor id in subscription creation causes internal server error In-Reply-To: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23888-70-xZKAqQSioZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 12:18:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 11:18:08 +0000 Subject: [Koha-bugs] [Bug 23888] Incorrect vendor id in subscription creation causes internal server error In-Reply-To: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23888-70-XwZ5Uyebff@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888 --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95253 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95253&action=edit Bug 23888: Do not allow invalid vendor id on creating a subscription It will avoid crash and invalid data when creating/updating a subscription. This could have been done with a AJAX query but seems more convenient this way. Test plan: - Create or update a subscription - In the "Vendor" input try an empty string, a valid vendor's id, and invalid one. => With an empty string you get the existing alert message => With a valid id you do not get any messages => With an invalid id you are not allowed to go to page 2 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 12:18:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 11:18:36 +0000 Subject: [Koha-bugs] [Bug 23888] Incorrect vendor id in subscription creation causes internal server error In-Reply-To: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23888-70-w83vkFipDY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 12:19:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 11:19:48 +0000 Subject: [Koha-bugs] [Bug 23822] No warning is produced when trying to delete a patron with credit (patron is not deleted) In-Reply-To: <bug-23822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23822-70-XZ5hp5P5Ws@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23822 --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- I think this actually exposes some wider questions regarding that routine.. see bug 23293 for example.. it doesn't use the non_issuing_charges method when it probably should (again, my bad :( ) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 12:26:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 11:26:11 +0000 Subject: [Koha-bugs] [Bug 24006] New: Switching on QueryWeightFields (relevance ranking) breaks search Message-ID: <bug-24006-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24006 Bug ID: 24006 Summary: Switching on QueryWeightFields (relevance ranking) breaks search Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Zebra Assignee: koha-bugs at lists.koha-community.org Reporter: bernard.scaife at ptfs-europe.com eg/ using simple search in OPAC QueryWeightFields (enabled) flute AND oboe = 701 flute OR oboe = 115 flute NOT oboe = 10 QueryWeightFields (disabled) flute AND oboe = 1038 flute OR oboe = 3983 flute NOT oboe = 2121 The results from the "disabled" look correct but of course there is no longer any relevance ranking. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 12:38:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 11:38:17 +0000 Subject: [Koha-bugs] [Bug 23822] No warning is produced when trying to delete a patron with credit (patron is not deleted) In-Reply-To: <bug-23822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23822-70-tJvhavaXIU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23822 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 12:38:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 11:38:21 +0000 Subject: [Koha-bugs] [Bug 23822] No warning is produced when trying to delete a patron with credit (patron is not deleted) In-Reply-To: <bug-23822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23822-70-NHnu2JfofY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23822 --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95254 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95254&action=edit Bug 23822: Fix deletion of patrons with credit There are bugs in both master and 19.05, but different. Anyway we should have this check to make sure a negative value will have the same behavior: trigger the confirmation message (instead of a blank page). If we want to reject the deletion of a patron with credit we should handle it on a separate bug report (behavior change) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 12:39:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 11:39:09 +0000 Subject: [Koha-bugs] [Bug 23822] No warning is produced when trying to delete a patron with credit (patron is not deleted) In-Reply-To: <bug-23822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23822-70-cpV98ktNCC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23822 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I would suggest to push this patch into master even if this specific bug does not exist. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 13:19:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 12:19:45 +0000 Subject: [Koha-bugs] [Bug 24007] New: Koha::Account::non_issues_charges is badly named Message-ID: <bug-24007-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24007 Bug ID: 24007 Summary: Koha::Account::non_issues_charges is badly named Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org The non_issues_charges method name suggests you will be returned a set of charges (Account::Lines) which would block a patrons ability to check out items. In fact, it returns a 'balance' of such charges but includes outstanding credits in the calculation. We should either rename the method to clarify it's use or update the method to return the expectation given it's naming. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 13:20:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 12:20:24 +0000 Subject: [Koha-bugs] [Bug 24007] Koha::Account::non_issues_charges is badly named In-Reply-To: <bug-24007-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24007-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24007-70-9f4BVSLAQw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24007 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 13:20:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 12:20:24 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14825-70-3ZazWQRCm0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24007 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24007 [Bug 24007] Koha::Account::non_issues_charges is badly named -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 13:22:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 12:22:49 +0000 Subject: [Koha-bugs] [Bug 24007] Koha::Account::non_issues_charges is badly named In-Reply-To: <bug-24007-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24007-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24007-70-V2CofbM3wI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24007 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |kyle at bywatersolutions.com, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 13:23:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 12:23:38 +0000 Subject: [Koha-bugs] [Bug 24007] Koha::Account::non_issues_charges is badly named In-Reply-To: <bug-24007-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24007-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24007-70-uX89nVBxW8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24007 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23822, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23293 Blocks|14825 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 13:23:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 12:23:38 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14825-70-TjBp7mY3ET@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|24007 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24007 [Bug 24007] Koha::Account::non_issues_charges is badly named -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 13:23:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 12:23:38 +0000 Subject: [Koha-bugs] [Bug 23822] No warning is produced when trying to delete a patron with credit (patron is not deleted) In-Reply-To: <bug-23822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23822-70-neuoQrjpfo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23822 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24007 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 13:23:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 12:23:38 +0000 Subject: [Koha-bugs] [Bug 23293] OPACFineNoRenewals always compares against 'balance' not 'outstanding' In-Reply-To: <bug-23293-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23293-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23293-70-LTN82m9MgF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23293 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24007 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 13:23:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 12:23:47 +0000 Subject: [Koha-bugs] [Bug 24007] Koha::Account::non_issues_charges is badly named In-Reply-To: <bug-24007-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24007-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24007-70-2EVWK8TJq4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24007 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 13:32:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 12:32:28 +0000 Subject: [Koha-bugs] [Bug 24008] New: No warning is produced when trying to delete a patron with credit (patron is not deleted) Message-ID: <bug-24008-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 Bug ID: 24008 Summary: No warning is produced when trying to delete a patron with credit (patron is not deleted) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: fridolin.somers at biblibre.com, gmcharlt at gmail.com, jonathan.druart at bugs.koha-community.org, katrin.fischer at bsz-bw.de, kyle.m.hall at gmail.com, martin.renvoize at ptfs-europe.com, testopia at bugs.koha-community.org, theod at lib.auth.gr, tomascohen at gmail.com, victor.grousset at biblibre.com Depends on: 23822 +++ This bug was initially created as a clone of Bug #23822 +++ When one tries to delete a patron that has a credit in his account, no warning is produced. The deletion is not performed (which is the proper behavior), however one would expect to see a warning similar to the one that is produced when the patron has an unpaid fine, a checked out item, a hold, etc. The following screencast was performed in ByWaters' sandboxes running 19.05 and shows the issue: https://screencast-o-matic.com/watch/cq6D6vu4YJ Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23822 [Bug 23822] No warning is produced when trying to delete a patron with credit (patron is not deleted) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 13:32:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 12:32:28 +0000 Subject: [Koha-bugs] [Bug 23822] No warning is produced when trying to delete a patron with credit (patron is not deleted) In-Reply-To: <bug-23822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23822-70-iMn53PBBmW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23822 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24008 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 [Bug 24008] No warning is produced when trying to delete a patron with credit (patron is not deleted) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 13:33:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 12:33:33 +0000 Subject: [Koha-bugs] [Bug 23822] Regression: As of 19.05.04 deletion of patrons with outstanding credits is silently blocked In-Reply-To: <bug-23822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23822-70-IRaPNw8onb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23822 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|No warning is produced when |Regression: As of 19.05.04 |trying to delete a patron |deletion of patrons with |with credit (patron is not |outstanding credits is |deleted) |silently blocked -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 13:35:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 12:35:08 +0000 Subject: [Koha-bugs] [Bug 23822] Regression: As of 19.05.04 deletion of patrons with outstanding credits is silently blocked In-Reply-To: <bug-23822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23822-70-soTM3KPUDT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23822 --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Updated the bug title to reflect the impact of the change and Jonathans bugfix.. Cloned the original bug to bug 24008 to record the enhancement request to add blocking of patron deletions if outstanding credits are found and additional warnings as this is an additional workflow that needs implementing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 13:36:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 12:36:24 +0000 Subject: [Koha-bugs] [Bug 24008] Attempting to delete a patron with outstanding credits should warn and block the deletion. In-Reply-To: <bug-24008-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24008-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24008-70-IEoursZm0B@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|No warning is produced when |Attempting to delete a |trying to delete a patron |patron with outstanding |with credit (patron is not |credits should warn and |deleted) |block the deletion. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 13:45:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 12:45:15 +0000 Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23681-70-tw1tXTy2Pr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94896|0 |1 is obsolete| | --- Comment #44 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 95255 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95255&action=edit Bug 23681: Add PatronRestrictionTypes syspref This patch adds the new syspref "PatronRestrictionTypes" Signed-off-by: Benjamin Veasey <B.T.Veasey at lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 13:45:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 12:45:20 +0000 Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23681-70-bl8T8FsbwP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94897|0 |1 is obsolete| | --- Comment #45 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 95256 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95256&action=edit Bug 23681: Add debarment_types This patch adds the table debarment_types and changes borrower_debarments.type to be a foreign key to it Signed-off-by: Benjamin Veasey <B.T.Veasey at lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 13:45:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 12:45:25 +0000 Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23681-70-20kQmWHrHJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94898|0 |1 is obsolete| | --- Comment #46 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 95257 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95257&action=edit Bug 23681: Add modify_patron_restrictions perm This patch adds a new "modify_patron_restrictions" permission Signed-off-by: Benjamin Veasey <B.T.Veasey at lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 13:45:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 12:45:31 +0000 Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23681-70-9zdjihOaUv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94899|0 |1 is obsolete| | --- Comment #47 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 95258 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95258&action=edit Bug 23681: Add Koha::RestrictionType(s) This patch adds the following objects: Koha::RestrictionType Koha::RestrictionTypes Signed-off-by: Benjamin Veasey <B.T.Veasey at lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 13:45:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 12:45:37 +0000 Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23681-70-LZCJwNWx4N@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94900|0 |1 is obsolete| | --- Comment #48 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 95259 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95259&action=edit Bug 23681: Add management UI This patch adds UI to allow CRUD operations on restriction types Signed-off-by: Benjamin Veasey <B.T.Veasey at lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 13:45:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 12:45:43 +0000 Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23681-70-uNYekwzX4O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94901|0 |1 is obsolete| | --- Comment #49 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 95260 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95260&action=edit Bug 23681: Allow for changes to debarments The structure of debarments has changes slightly in that the displayed text is now a product of a call to Koha::RestrictionTypes rather than just the debarment's code. This patch allows for that Signed-off-by: Benjamin Veasey <B.T.Veasey at lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 13:45:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 12:45:48 +0000 Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23681-70-HNlnfMSgHj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94902|0 |1 is obsolete| | --- Comment #50 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 95261 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95261&action=edit Bug 23681: Allow for selection of restriction type This patch displays a restriction type select box (when appropriate) when adding manual patron restrictions Signed-off-by: Benjamin Veasey <B.T.Veasey at lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 13:45:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 12:45:54 +0000 Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23681-70-NeTx4lJWPY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94903|0 |1 is obsolete| | --- Comment #51 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 95262 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95262&action=edit Bug 23681: Clean up on delete When a patron restriction type is deleted, any debarments that use that type need to revert to the default type, this patch implements this behaviour Signed-off-by: Benjamin Veasey <B.T.Veasey at lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 13:46:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 12:46:00 +0000 Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23681-70-GPsJLNCR9v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94904|0 |1 is obsolete| | --- Comment #52 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 95263 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95263&action=edit Bug 23681: Add unit tests Signed-off-by: Benjamin Veasey <B.T.Veasey at lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 13:46:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 12:46:05 +0000 Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23681-70-dkN2n8jy4i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95148|0 |1 is obsolete| | --- Comment #53 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 95264 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95264&action=edit Bug 23681: (follow-up) Fix typo Signed-off-by: Benjamin Veasey <B.T.Veasey at lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 13:46:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 12:46:36 +0000 Subject: [Koha-bugs] [Bug 23681] Patron restrictions should be user definable In-Reply-To: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23681-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23681-70-Ui8H2JMvu2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23681 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 14:04:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 13:04:28 +0000 Subject: [Koha-bugs] [Bug 23035] Intranet search is slow if thousands of items are in the biblios shown in the search results In-Reply-To: <bug-23035-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23035-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23035-70-FHFz0svk3E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23035 Joonas Kylmälä <joonas.kylmala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW Assignee|joonas.kylmala at helsinki.fi |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 14:37:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 13:37:54 +0000 Subject: [Koha-bugs] [Bug 23941] Searching by Control Number doesn't return bibs in the "reservoir" In-Reply-To: <bug-23941-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23941-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23941-70-6qcVl8ldBa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23941 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- It seems that only title, author and isbn are supported by this search. We could extend it to the full MARC records but that may return too many results. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 14:38:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 13:38:04 +0000 Subject: [Koha-bugs] [Bug 23941] Searching by Control Number doesn't return bibs in the "reservoir" In-Reply-To: <bug-23941-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23941-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23941-70-eTcKRuXqTc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23941 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |enhancement Version|19.05 |master -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 14:38:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 13:38:43 +0000 Subject: [Koha-bugs] [Bug 23941] Searching by Control Number doesn't return bibs in the "reservoir" In-Reply-To: <bug-23941-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23941-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23941-70-995y2A5nfV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23941 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10047 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 14:38:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 13:38:43 +0000 Subject: [Koha-bugs] [Bug 10047] Cataloguing search maybe useless? In-Reply-To: <bug-10047-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10047-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10047-70-Pr8PG6cnrR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10047 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23941 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 14:46:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 13:46:11 +0000 Subject: [Koha-bugs] [Bug 24004] "Help" link at Intranet's mainpage leads to a "Forbidden" page (es-ES) In-Reply-To: <bug-24004-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24004-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24004-70-7vZSP9Llql@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24004 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major CC| |bgkriegel at gmail.com, | |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 14:51:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 13:51:50 +0000 Subject: [Koha-bugs] [Bug 24004] "Help" link at Intranet's mainpage leads to a "Forbidden" page (es-ES) In-Reply-To: <bug-24004-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24004-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24004-70-tpeicaoY70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24004 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 14:56:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 13:56:34 +0000 Subject: [Koha-bugs] [Bug 10047] Cataloguing search maybe useless? In-Reply-To: <bug-10047-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10047-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10047-70-jdKlavfxVg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10047 Cori Lynn Arnold <carnold at dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carnold at dgiinc.com --- Comment #15 from Cori Lynn Arnold <carnold at dgiinc.com> --- Librarian here: We currently use the cataloging search because the Advanced Search doesn't support searching by control number. We would prefer that the Advanced Search supports searching the control number as well as searching in the reservoir (for control number and the currently available fields). I agree with Barbara Johnson, make the search configurable for those that are confused and want to get rid of it. Then make the configurable preference of either the Basic or Advanced editor the default. I would ultimately prefer that a search works the same weather you are searching in the catalog, the reservoir, or Z39.50. There are a three searching interfaces in Koha in the cataloging tab and they all are drastically different and return different things. Why not have one, efficient interface that does the same thing? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 14:58:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 13:58:59 +0000 Subject: [Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history In-Reply-To: <bug-18795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18795-70-2U2FItzOvy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795 Joonas Kylmälä <joonas.kylmala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95246|0 |1 is obsolete| | --- Comment #14 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> --- Created attachment 95265 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95265&action=edit Bug 18795: DELETE (anonymize) checkout history Anonymize patron's checkout history via REST API DELETE /checkouts/history?patron_id=123 To test: 1. prove t/db_dependent/api/v1/checkouts.t 2. Manually send DELETE request to /api/v1/checkouts/history?patron_id=123 where 123 is your patron's borrowernumber Sponsored-by: Koha-Suomi Oy Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 14:59:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 13:59:02 +0000 Subject: [Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history In-Reply-To: <bug-18795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18795-70-mclxeZs0Px@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795 --- Comment #15 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> --- Created attachment 95266 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95266&action=edit Bug 18795: (follow-up) Check whether patrons exists before deleting history Running $patrons->anonymise_issue_history after checking patrons exists is more logical even though $patrons->anonymise_issue_history() can handle 0 patrons returned in the search. Also this way we don't have to run anonymise_issue_history() code unless needed, thus making the code finish faster. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 14:59:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 13:59:05 +0000 Subject: [Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history In-Reply-To: <bug-18795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18795-70-xSmqLIcYYm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795 --- Comment #16 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> --- Created attachment 95267 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95267&action=edit Bug 18795: (follow-up) Unify error message to be same across codebase In Koha/REST/V1/Patrons.pm the error message for not finding patron is "Patron not found" so let's use the same here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 15:00:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 14:00:13 +0000 Subject: [Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history In-Reply-To: <bug-18795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18795-70-iU7cGgIvDd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795 Joonas Kylmälä <joonas.kylmala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95248|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 15:00:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 14:00:27 +0000 Subject: [Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history In-Reply-To: <bug-18795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18795-70-LKSFH2LbTZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795 Joonas Kylmälä <joonas.kylmala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95247|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 15:01:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 14:01:35 +0000 Subject: [Koha-bugs] [Bug 24005] Software error: at login In-Reply-To: <bug-24005-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24005-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24005-70-9Tw9lpUWU1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24005 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Hi Andrew, and welcome! You should not need to modify anything after the installation process. Do you see the different tables in the database? How many? I would recommend you to remove the instance of Koha you have created and start again. Also, it could help to take a look at the logs (/var/log/koha/YOUR_INSTANCE) to see if there is something useful there. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 15:05:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 14:05:18 +0000 Subject: [Koha-bugs] [Bug 23992] Adding multiple items with barcode might end with infinite loop if same barcode will be next_value In-Reply-To: <bug-23992-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23992-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23992-70-NGWzLiSqWh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23992 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 15:05:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 14:05:38 +0000 Subject: [Koha-bugs] [Bug 23941] Searching by Control Number doesn't return bibs in the "reservoir" In-Reply-To: <bug-23941-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23941-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23941-70-bTiHDRrINe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23941 --- Comment #2 from Cori Lynn Arnold <carnold at dgiinc.com> --- I'm not sure I understand what you mean by "It seems that only title, author and isbn are supported by this search." Only title, author and isbn are supported by the *Reservoir* search, but other fields are supported by the *Catalog* search. Why not support the SAME search over both sets? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 15:17:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 14:17:26 +0000 Subject: [Koha-bugs] [Bug 23888] Incorrect vendor id in subscription creation causes internal server error In-Reply-To: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23888-70-LQ7av5JUsI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888 Joonas Kylmälä <joonas.kylmala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #4 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> --- If I don't have any vendors in Koha then this error comes up to the browser's JavaScript console: > ReferenceError: BOOKSELLER_IDS is not defined -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 15:23:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 14:23:22 +0000 Subject: [Koha-bugs] [Bug 24009] New: Koha::Account->outstanding_debits should support inline filtering Message-ID: <bug-24009-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24009 Bug ID: 24009 Summary: Koha::Account->outstanding_debits should support inline filtering Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org We have a number of places where we want to get a specific list of outstanding debits for comparison.. at the moment one would have to construct a search directly by inspecting system preferences at the controller level. By addins a filter option to oustanding_debits we can move that back to the object level without having to add additional methods. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 15:29:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 14:29:40 +0000 Subject: [Koha-bugs] [Bug 18595] Move C4::Members::Messaging to Koha namespace In-Reply-To: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18595-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18595-70-IPyhNIgMpu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18595 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|alex.arnaud at biblibre.com |testopia at bugs.koha-communit | |y.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 15:41:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 14:41:07 +0000 Subject: [Koha-bugs] [Bug 23676] Elasticsearch - 0 is not a valid boolean for suppress In-Reply-To: <bug-23676-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23676-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23676-70-1I473Pfjnk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23676 Joonas Kylmälä <joonas.kylmala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at helsinki.fi --- Comment #3 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> --- What log is where the warning goes and which version of elasticsearch do you use? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 15:42:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 14:42:09 +0000 Subject: [Koha-bugs] [Bug 24009] Koha::Account->outstanding_debits should support inline filtering In-Reply-To: <bug-24009-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24009-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24009-70-tPrsZ4O7WL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24009 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24007 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 15:42:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 14:42:09 +0000 Subject: [Koha-bugs] [Bug 24007] Koha::Account::non_issues_charges is badly named In-Reply-To: <bug-24007-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24007-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24007-70-FWKpakVQAj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24007 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24009 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 15:46:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 14:46:47 +0000 Subject: [Koha-bugs] [Bug 23173] ILL should be able to search third party sources prior to request creation In-Reply-To: <bug-23173-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23173-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23173-70-g8eIHx6uQb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23173 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93909|0 |1 is obsolete| | --- Comment #27 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 95268 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95268&action=edit Bug 23173: Add ILLCheckAvailability syspref This patch adds the new syspref "ILLCheckAvailability" Sponsored-by: Public Health England -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 15:46:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 14:46:53 +0000 Subject: [Koha-bugs] [Bug 23173] ILL should be able to search third party sources prior to request creation In-Reply-To: <bug-23173-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23173-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23173-70-k9ThqaqWuV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23173 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93910|0 |1 is obsolete| | --- Comment #28 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 95269 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95269&action=edit Bug 23173: Provide core infrastructure This patch adds the required infrastructure to enable ILL availability plugins to intercept the request creation process and, using the supplied metadata, search for and display possible relevant items from whichever availability plugins are installed. Currently three availability plugins exist: z39.50 - Searches any number of the Koha instance's configured Z targets https://github.com/PTFS-Europe/koha-plugin-ill-avail-z3950 EDS - Searches the EBSCO Discovery Service https://github.com/PTFS-Europe/koha-plugin-ill-avail-eds Unpaywall - Searches the Unpaywall API for possible open access versions of the requested item https://github.com/PTFS-Europe/koha-plugin-ill-avail-unpaywall The Unpaywall plugin is intended to serve as a "reference" plugin as the API it deals with is extremely simple -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 15:46:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 14:46:59 +0000 Subject: [Koha-bugs] [Bug 23173] ILL should be able to search third party sources prior to request creation In-Reply-To: <bug-23173-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23173-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23173-70-b9CLJy5Zma@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23173 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93911|0 |1 is obsolete| | --- Comment #29 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 95270 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95270&action=edit Bug 23173: Add unit tests Test Koha::Illrequests::Availability -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 15:47:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 14:47:35 +0000 Subject: [Koha-bugs] [Bug 23173] ILL should be able to search third party sources prior to request creation In-Reply-To: <bug-23173-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23173-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23173-70-msQx2zhcI3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23173 --- Comment #30 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Needed a rebase -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 15:48:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 14:48:53 +0000 Subject: [Koha-bugs] [Bug 24010] New: Number of issues to display to staff accepts non-integer values Message-ID: <bug-24010-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24010 Bug ID: 24010 Summary: Number of issues to display to staff accepts non-integer values Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: joonas.kylmala at helsinki.fi QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com When adding a new serial subscription in the page /cgi-bin/koha/serials/subscription-add.pl one can add to the field "Number of issues to display to staff" a non-integer value like "f" and then when you save this new subscription and go to the "Subscriptions" tab in /cgi-bin/koha/catalogue/detail.pl?biblionumber=XXXX you get the following error in plack-error.log: >DBD::mysql::st fetchrow_hashref failed: fetch() without execute() [for Statement "SELECT serialid,serialseq, status, planneddate, publisheddate, notes > FROM serial > WHERE subscriptionid = ? > AND status IN (2,4,41,42,43,44) > ORDER BY publisheddate DESC LIMIT 0,f > " with ParamValues: 0=2] at /home/koha/kohaclone/C4/Serials.pm line 784. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 16:31:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 15:31:31 +0000 Subject: [Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api methods to Koha::Object In-Reply-To: <bug-23893-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23893-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23893-70-Eo7l1ACEpr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lari.taskula at hypernova.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 16:46:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 15:46:32 +0000 Subject: [Koha-bugs] [Bug 24009] Koha::Account->outstanding_debits should support inline filtering In-Reply-To: <bug-24009-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24009-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24009-70-9cv5aapaer@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24009 --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95271 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95271&action=edit Bug 24009: Add filter_by option to outstanding_debits This patch adds an optional 'filter_by' arguament to Koha::Account->outstanding_debits which current accepts 'blocks_issue' and will filter down the result set of outstanding_debits based upon the values of the following system preferences. * `HoldsInNoissuesCharge` * `RentalsInNoissuesCharge` * `ManInvInNoissuesCharge` -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 16:46:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 15:46:35 +0000 Subject: [Koha-bugs] [Bug 24009] Koha::Account->outstanding_debits should support inline filtering In-Reply-To: <bug-24009-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24009-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24009-70-G6RffMRl69@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24009 --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95272 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95272&action=edit Bug 24009: Add Unit Tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 16:47:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 15:47:00 +0000 Subject: [Koha-bugs] [Bug 24009] Koha::Account->outstanding_debits should support inline filtering In-Reply-To: <bug-24009-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24009-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24009-70-ucxtgI0JDg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24009 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 16:47:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 15:47:11 +0000 Subject: [Koha-bugs] [Bug 24009] Koha::Account->outstanding_debits should support inline filtering In-Reply-To: <bug-24009-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24009-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24009-70-1cv24vDFMK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24009 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 16:47:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 15:47:21 +0000 Subject: [Koha-bugs] [Bug 24009] Koha::Account->outstanding_debits should support inline filtering In-Reply-To: <bug-24009-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24009-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24009-70-SQgjBxozmr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24009 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 16:47:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 15:47:58 +0000 Subject: [Koha-bugs] [Bug 24007] Koha::Account::non_issues_charges is badly named In-Reply-To: <bug-24007-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24007-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24007-70-pdcjg9vKUu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24007 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24009 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24009 [Bug 24009] Koha::Account->outstanding_debits should support inline filtering -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 16:47:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 15:47:58 +0000 Subject: [Koha-bugs] [Bug 24009] Koha::Account->outstanding_debits should support inline filtering In-Reply-To: <bug-24009-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24009-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24009-70-leX4GLsC0K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24009 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24007 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24007 [Bug 24007] Koha::Account::non_issues_charges is badly named -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 16:48:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 15:48:06 +0000 Subject: [Koha-bugs] [Bug 24007] Koha::Account::non_issues_charges is badly named In-Reply-To: <bug-24007-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24007-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24007-70-N7bloOAMDD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24007 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24009 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 16:48:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 15:48:06 +0000 Subject: [Koha-bugs] [Bug 24009] Koha::Account->outstanding_debits should support inline filtering In-Reply-To: <bug-24009-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24009-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24009-70-NEnnSrXIpp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24009 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24007 | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 16:49:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 15:49:13 +0000 Subject: [Koha-bugs] [Bug 24007] Koha::Account::non_issues_charges is badly named In-Reply-To: <bug-24007-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24007-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24007-70-HumlOB4nGp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24007 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 16:49:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 15:49:13 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14825-70-G5EbR605QB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24007 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24007 [Bug 24007] Koha::Account::non_issues_charges is badly named -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 16:49:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 15:49:53 +0000 Subject: [Koha-bugs] [Bug 23293] OPACFineNoRenewals always compares against 'balance' not 'outstanding' In-Reply-To: <bug-23293-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23293-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23293-70-l6Qz6AqNT4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23293 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14825 |24007 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24007 [Bug 24007] Koha::Account::non_issues_charges is badly named -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 16:49:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 15:49:53 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14825-70-PHrHfpRaqv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|23293 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23293 [Bug 23293] OPACFineNoRenewals always compares against 'balance' not 'outstanding' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 16:49:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 15:49:53 +0000 Subject: [Koha-bugs] [Bug 24007] Koha::Account::non_issues_charges is badly named In-Reply-To: <bug-24007-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24007-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24007-70-wyilRkogcP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24007 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23293 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23293 [Bug 23293] OPACFineNoRenewals always compares against 'balance' not 'outstanding' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 17:07:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 16:07:05 +0000 Subject: [Koha-bugs] [Bug 23953] Cancelling hold does not work if checkout not completed In-Reply-To: <bug-23953-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23953-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23953-70-VbZlz4kqdW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23953 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |oleonard at myacpl.org --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Looks like a long standing issue and I did not find a duplicated bug report, that's weird. At first glance I would say the checkbox is only taken into consideration for "Yes, check out" https://snipboard.io/jEXNBP.jpg Not sure how we could make it clear on the interface. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 17:08:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 16:08:09 +0000 Subject: [Koha-bugs] [Bug 23892] Code related to import/export biblio frameworks in XML format must be removed In-Reply-To: <bug-23892-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23892-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23892-70-yw7SPgG8T4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23892 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Code related to |Code related to |import/export biblio |import/export biblio |frameworks in CSV format |frameworks in XML format |must be removed |must be removed --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- ^CSV^XML^ -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 17:22:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 16:22:23 +0000 Subject: [Koha-bugs] [Bug 23899] Cannot change size of Show SQL Code box on run report page In-Reply-To: <bug-23899-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23899-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23899-70-WWGy2XusAu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23899 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- See https://github.com/codemirror/CodeMirror/issues/850 There is code we could take from https://codepen.io/sakifargo/pen/KodNyR -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 17:22:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 16:22:34 +0000 Subject: [Koha-bugs] [Bug 23899] Cannot change size of Show SQL Code box on run report page (Chromium) In-Reply-To: <bug-23899-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23899-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23899-70-fRWFsKVMUI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23899 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Cannot change size of Show |Cannot change size of Show |SQL Code box on run report |SQL Code box on run report |page |page (Chromium) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 17:51:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 16:51:10 +0000 Subject: [Koha-bugs] [Bug 24011] New: Browser tabs auto close when editing items from report with biblio links Message-ID: <bug-24011-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24011 Bug ID: 24011 Summary: Browser tabs auto close when editing items from report with biblio links Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: mkstephens at lancasterseminary.edu QA Contact: testopia at bugs.koha-community.org Since upgrading to 19.05, following a linked biblionumber from a report and making an edit to an item will close the new browser tab after the edit is complete. This is not desired behavior (at least for my library) because it doesn't allow us to check for accuracy after saving changes and it does not allow the opportunity to make edits to additional items attached to the record. The link has to be clicked again from the report to be able to see the record view. To test: 1. Create a report with linked biblios that includes this snippet of SQL code: CONCAT('<a target="_blank" href=\"/cgi-bin/koha/catalogue/detail.pl?biblionumber=',b.biblionumber,'\">',b.biblionumber,'</a>') as biblionumber 2. Run the report 3. Click on a biblio link; the record view opens in a new browser tab 4. Click on the edit item button; the edit item screen loads 5. Make a change to the item; click save changes 6. The browser tab closes, leaving only the report tab open. Note, the changes do appear to save before the tab closes. I suspect that a well-meaning developer intended for this to be a shortcut or time saver, but it is a major annoyance when attempting to make edits from a report and the record has multiple items attached. It would also be nice to have visual confirmation that the changes were indeed saved and they are accurate. The tab auto-closes before the user gets that visual confirmation. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 17:55:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 16:55:14 +0000 Subject: [Koha-bugs] [Bug 23900] Label maker cannot concatenate database fields In-Reply-To: <bug-23900-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23900-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23900-70-iyPeiXkEwu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23900 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Version|19.05 |master Assignee|cnighswonger at foundations.ed |jonathan.druart at bugs.koha-c |u |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 17:56:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 16:56:50 +0000 Subject: [Koha-bugs] [Bug 23900] Label maker cannot concatenate database fields In-Reply-To: <bug-23900-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23900-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23900-70-dM2jZ0QPJK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23900 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 17:56:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 16:56:53 +0000 Subject: [Koha-bugs] [Bug 23900] Label maker cannot concatenate database fields In-Reply-To: <bug-23900-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23900-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23900-70-BCpCppeAW5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23900 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95273 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95273&action=edit Bug 23900: Teach label maker to concat database fields Test plan: - define a label layout with this field list: "100a 245s","enumchron copynumber" - find or create a record with values for all of those fields - generate a label for that record - the 100a and 245s successfully display on one line - the enumchron and copynumber are displayed and separated by a space Try other combinations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 18:00:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 17:00:48 +0000 Subject: [Koha-bugs] [Bug 24012] New: Display 'Locked' budget in red Message-ID: <bug-24012-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24012 Bug ID: 24012 Summary: Display 'Locked' budget in red Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org I find it illogical that the 'Locked' in locked budget is displayed in green. Shouldn't it be displayed in red? To reproduce: 1- Go to Administration 2- Click on Budgets 3- Add a new budget and check the 'Lock budget' box 4- Click on the 'Inactive budgets' tab 5- Note that 'Locked' is displayed in green -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 18:38:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 17:38:17 +0000 Subject: [Koha-bugs] [Bug 23874] Advanced Editor is not loaded over HTTPS In-Reply-To: <bug-23874-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23874-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23874-70-7jZ5O2d3l3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23874 --- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95274 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95274&action=edit Bug 23874: Fix advanced editor if nosniff is set -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 18:39:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 17:39:00 +0000 Subject: [Koha-bugs] [Bug 24012] Display 'Locked' budget in red In-Reply-To: <bug-24012-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24012-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24012-70-oDQR1eKBZW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24012 --- Comment #1 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Also add "lock" icon for usability (specifically colour-blind users), as per Martin's request. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 18:39:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 17:39:14 +0000 Subject: [Koha-bugs] [Bug 23874] Advanced Editor is not loaded over HTTPS In-Reply-To: <bug-23874-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23874-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23874-70-9Vd4HZEIx4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23874 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.05 |master CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org --- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Hi Tomáš, can you try this patch please? I am pretty sure we will need to adjust much more occurrences. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 18:39:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 17:39:29 +0000 Subject: [Koha-bugs] [Bug 23874] Advanced Editor is not loaded if X-Content-Type-Options: nosniff In-Reply-To: <bug-23874-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23874-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23874-70-ExbfnuIrQi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23874 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Advanced Editor is not |Advanced Editor is not |loaded over HTTPS |loaded if | |X-Content-Type-Options: | |nosniff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 19:04:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 18:04:27 +0000 Subject: [Koha-bugs] [Bug 23777] Text converted to html entity codes in cataloguing edit form In-Reply-To: <bug-23777-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23777-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23777-70-2Zrs9CEWMZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 19:04:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 18:04:31 +0000 Subject: [Koha-bugs] [Bug 23777] Text converted to html entity codes in cataloguing edit form In-Reply-To: <bug-23777-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23777-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23777-70-TOJXCRbS6t@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95275 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95275&action=edit Bug 23777: Fix auth finder escaping -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 19:05:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 18:05:19 +0000 Subject: [Koha-bugs] [Bug 23777] Text converted to html entity codes in cataloguing edit form In-Reply-To: <bug-23777-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23777-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23777-70-QIj5hIAJjL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org Version|18.11 |master Severity|minor |normal Depends on| |13618 CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I will need to double check this fix, but it seems ok at first glance. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 [Bug 13618] Add additional template filter methods and a filter presence test to Koha -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 19:05:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 18:05:19 +0000 Subject: [Koha-bugs] [Bug 13618] Add additional template filter methods and a filter presence test to Koha In-Reply-To: <bug-13618-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13618-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13618-70-XF8O1TPXUE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23777 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 [Bug 23777] Text converted to html entity codes in cataloguing edit form -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 20:08:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 19:08:59 +0000 Subject: [Koha-bugs] [Bug 20168] Update of the OPAC bootstrap template to bootstrap v4 In-Reply-To: <bug-20168-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20168-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20168-70-RsANeAcTUV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20168 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 20:15:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 19:15:23 +0000 Subject: [Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api methods to Koha::Object In-Reply-To: <bug-23893-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23893-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23893-70-1GAmYJjZ9I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893 --- Comment #1 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 95276 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95276&action=edit Bug 23893: Unit tests This patch introduces tests for the implemented methods. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 20:15:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 19:15:27 +0000 Subject: [Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api methods to Koha::Object In-Reply-To: <bug-23893-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23893-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23893-70-A3iAzrGpV5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893 --- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 95277 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95277&action=edit Bug 23893: Implement Koha::Object->from_api_mapping This patch implements the from_api_mapping method, that calculates (and caches) the reserve mapping from the to_api_mapping method. A generic to_api_mapping is added to simplify things a bit in the generic to_api method and so the mappings are reusable in the way they are in from_api_mapping. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 20:15:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 19:15:30 +0000 Subject: [Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api methods to Koha::Object In-Reply-To: <bug-23893-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23893-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23893-70-wD0KfqJZfR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893 --- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 95278 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95278&action=edit Bug 23893: Add new_from_api and set_from_api to Koha::Object This patch introduces the following methods to the Koha::Object class: - set_from_api - new_from_api This methods are going to be used when writing API controllers that map to the attributes to the DB schema ones. To test: 1. Apply this patchset 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 20:16:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 19:16:00 +0000 Subject: [Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api methods to Koha::Object In-Reply-To: <bug-23893-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23893-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23893-70-RXit3Oq5Gi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 20:31:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 19:31:56 +0000 Subject: [Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api methods to Koha::Object In-Reply-To: <bug-23893-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23893-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23893-70-povUwIOj0u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893 --- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> --- I want to hear your opinions, I'm not feeling comfortable with this, looking at cleaning Koha::REST::V1::Patrons with this makes me wonder if it is falling short. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 21:03:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 20:03:57 +0000 Subject: [Koha-bugs] [Bug 10047] Cataloguing search maybe useless? In-Reply-To: <bug-10047-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10047-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10047-70-mPiPNEKTZu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10047 --- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Cori Lynn Arnold from comment #15) > Librarian here: > > We currently use the cataloging search because the Advanced Search doesn't > support searching by control number. Hi Cori, 001 should be indexed as Control-number and be searchable. You could add it to advanced search pull downs using jQuery - would that help of have you already tried and found something not working? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 21:17:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 20:17:24 +0000 Subject: [Koha-bugs] [Bug 15449] Move stuff to the Koha namespace In-Reply-To: <bug-15449-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15449-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15449-70-veIUfL5ddw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15449 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Move stuffs to the Koha |Move stuff to the Koha |namespace |namespace CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 21:26:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 20:26:33 +0000 Subject: [Koha-bugs] [Bug 21496] install.pl: DBD::mysql::st execute failed: Index column size too large. The maximum column size is 767 bytes. at /usr/share/perl5/DBIx/RunSQL.pm line 273. In-Reply-To: <bug-21496-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21496-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21496-70-ryvizbXBvN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21496 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|new feature |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 21:28:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 20:28:37 +0000 Subject: [Koha-bugs] [Bug 23953] Cancelling hold does not work if checkout not completed In-Reply-To: <bug-23953-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23953-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23953-70-RJykHtL6kU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23953 --- Comment #2 from Aleisha Amohia <aleisha at catalyst.net.nz> --- Yes it is a weird one. I think given that the option is a checkbox, it does imply that it's a separate action to the button, and you should be able to cancel a hold while clicking any button. In this case I think we just need to ensure that the cancel hold checkbox is considered if any of the buttons is clicked. Otherwise, the checkbox should be removed and the cancel hold action should be a second screen confirmation, after choosing "Yes, check out". -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 21:37:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 20:37:05 +0000 Subject: [Koha-bugs] [Bug 24013] New: Transferring a checked out item gives a software error Message-ID: <bug-24013-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24013 Bug ID: 24013 Summary: Transferring a checked out item gives a software error Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: aleisha at catalyst.net.nz QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com To reproduce: 1. check out an item 2. Go to circulation -> transfer and put in the barcode of the item you just checked out 3. error: Can't call method "borrowernumber" on unblessed reference at /home/vagrant/kohaclone/C4/Circulation.pm line 350 This occurs in the C4::Circulation::transferbook subroutine. It happens because Bug 18276 accidentally reintroduces an old subroutine (GetOpenIssue) that returns an unblessed reference. This line should use Koha Objects instead. Code causing an error: my $issue = GetOpenIssue($itemnumber); # check if it is still issued to someone, return it... if ( $issue ) { AddReturn( $barcode, $fbr ); $messages->{'WasReturned'} = $issue->borrowernumber; } Suggested fix: my $issue = Koha::Checkouts->find({ itemnumber => $itemnumber }); -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 21:37:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 20:37:17 +0000 Subject: [Koha-bugs] [Bug 24013] Transferring a checked out item gives a software error In-Reply-To: <bug-24013-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24013-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24013-70-p5eSPkIp92@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24013 Aleisha Amohia <aleisha at catalyst.net.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 21:48:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 20:48:21 +0000 Subject: [Koha-bugs] [Bug 10047] Cataloguing search maybe useless? In-Reply-To: <bug-10047-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10047-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10047-70-ZMrf1yw8WD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10047 --- Comment #17 from Cori Lynn Arnold <carnold at dgiinc.com> --- (In reply to Katrin Fischer from comment #16) > Hi Cori, 001 should be indexed as Control-number and be searchable. You > could add it to advanced search pull downs using jQuery - would that help of > have you already tried and found something not working? Katrin, Can you elaborate on this? Point me to some documentation? Which interface? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 22:02:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 21:02:11 +0000 Subject: [Koha-bugs] [Bug 23600] Library group search broken for group with a big number of libraries In-Reply-To: <bug-23600-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23600-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23600-70-BVaBq3HUkb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23600 --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Andres Ovalle from comment #6) > "ENTIDAD DE PRUEBA" was the last library created in the system, after that > there are the groups that is where we have problems. > > An example image: > > https://www.dropbox.com/s/vn753b4a9g4or6c/Captura%20de%20Pantalla%202019-11- > 06%20a%20la%28s%29%208.01.19%20p.%20m..png?dl=0 I know - but they really don't display for me like on your screenshot. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 22:21:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 21:21:27 +0000 Subject: [Koha-bugs] [Bug 23941] Searching by Control Number doesn't return bibs in the "reservoir" In-Reply-To: <bug-23941-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23941-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23941-70-C7V82gNDwc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23941 Cori Lynn Arnold <carnold at dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal --- Comment #3 from Cori Lynn Arnold <carnold at dgiinc.com> --- I specifically think this is a *BUG* and not an enhancement. If the interface lets you search and provides result sets, than it should return results from both places when searching for the same thing. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 22:31:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 21:31:42 +0000 Subject: [Koha-bugs] [Bug 24014] New: Return to last Advanced Search link incorrectly encoded Message-ID: <bug-24014-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24014 Bug ID: 24014 Summary: Return to last Advanced Search link incorrectly encoded Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: david.roberts at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org After performing an advanced search in the opac, if you click on the link to return to the last Advanced Search it is incorrectly encoded and results in a 404 page error. Changing line 117 of opac-results.tt from <p><a href="[% ReturnPath | uri %]">Return to the last advanced search</a></p> to <p><a href="[% ReturnPath | $raw %]">Return to the last advanced search</a></p> corrects the problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 22:46:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 21:46:19 +0000 Subject: [Koha-bugs] [Bug 23941] Searching by Control Number doesn't return bibs in the "reservoir" In-Reply-To: <bug-23941-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23941-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23941-70-so60hlcizD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23941 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Cori Lynn Arnold from comment #3) > I specifically think this is a *BUG* and not an enhancement. If the > interface lets you search and provides result sets, than it should return > results from both places when searching for the same thing. The records in the catalog are searched using Zebra, the reservoir records are not indexed by Zebra and can only be searched with SQL, that's why they don't work the same and it would be hard to make them, unless we decided to make an index for the reservoir records as well I think. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 11 22:52:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 11 Nov 2019 21:52:55 +0000 Subject: [Koha-bugs] [Bug 23985] The method Koha::Item-> is not covered by tests! In-Reply-To: <bug-23985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23985-70-vVR99ABNbd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23985 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 04:11:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 03:11:52 +0000 Subject: [Koha-bugs] [Bug 24015] New: UNIMARC Authorities Message-ID: <bug-24015-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24015 Bug ID: 24015 Summary: UNIMARC Authorities Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs at lists.koha-community.org Reporter: Igor.A.Sychev at mail.ru QA Contact: testopia at bugs.koha-community.org UNIMARC Authorities, 3rd edition Add 010 - International Standard Name Identifier (ISNI) (new 2016) 017 - Other Identifier (new 2017) https://www.ifla.org/publications/unimarc-authorities--3rd-edition--updates?og=33 authorities_normal_unimarc.sql: ... ('', '010', 'International Standard Name Identifier (ISNI)', 'International Standard Name Identifier (ISNI)', 0, 0, ''), ... ('', '017', 'Other Identifier', 'Other Identifier', 0, 0, ''), ... ('', '010', 'a', 'Number (ISNI)', 'Number (ISNI)', 0, 0, 0, '', '', '', 0, 1, 0, '', ''), ('', '010', 'y', 'Cancelled ISNI', 'Cancelled ISNI', 1, 0, 0, '', '', '', 0, 1, 0, '', ''), ('', '010', 'z', 'Erroneous ISNI', 'Erroneous ISNI', 1, 0, 0, '', '', '', 0, 1, 0, '', ''), ('', '010', '6', 'Interfield linking data', 'Interfield linking data', 1, 0, 0, '', '', '', 0, 1, 0, '', ''), ... ('', '017', 'a', 'Identifier', 'Identifier', 0, 0, 0, '', '', '', 0, 1, 0, '', ''), ('', '017', 'b', 'Qualification', 'Qualification', 1, 0, 0, '', '', '', 0, 1, 0, '', ''), ('', '017', 'z', 'Erroneous Identifier', 'Erroneous Identifier', 1, 0, 0, '', '', '', 0, 1, 0, '', ''), ('', '017', '2', 'System Code', 'System Code', 0, 0, 0, '', '', '', 0, 1, 0, '', ''), ... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 05:19:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 04:19:45 +0000 Subject: [Koha-bugs] [Bug 24005] Software error: at login In-Reply-To: <bug-24005-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24005-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24005-70-agVFyTtkwO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24005 --- Comment #4 from Andrew Lau <andrewanandal at gmail.com> --- Many thanks for the very practical advice! I removed the instance and attempted reinstalling it. Now the following error message occurs: ----------------------------------------- The following error occurred while importing the database structure: [Tue Nov 12 12:04:18 2019] install.pl: DBD::mysql::st execute failed: BLOB, TEXT, GEOMETRY or JSON column 'changed_fields' can't have a default value at /usr/share/perl5/DBIx/RunSQL.pm line 273. Please contact your system administrator ------------------------------------------------------------ The /usr/share/perl5/DBIx?RunSQL.pm looks like this: -------------------------------------------------------------- GNU nano 2.9.3 /usr/share/perl5/DBIx/RunSQL.pm package DBIx::RunSQL; use strict; use DBI; use vars qw($VERSION); $VERSION = '0.15'; =head1 NAME DBIx::RunSQL - run SQL from a file =cut =head1 SYNOPSIS #!/usr/bin/perl -w use strict; use lib 'lib'; use DBIx::RunSQL; my $test_dbh = DBIx::RunSQL->create( dsn => 'dbi:SQLite:dbname=:memory:', sql => 'sql/create.sql', force => 1, verbose => 1, ); ... # run your tests with a DB setup fresh from setup.sql =head1 METHODS =head2 C<< DBIx::RunSQL->create ARGS >> =head2 C<< DBIx::RunSQL->run ARGS >> Runs the SQL commands and returns the database handle. In list context, it returns the database handle and the suggested exit code. =over 4 =item * C<sql> - name of the file containing the SQL statements The default is C<sql/create.sql> If C<sql> is a reference to a glob or a filehandle, the SQL will be read from that. B<not implemented> This allows one to create SQL-as-programs as follows: #!/usr/bin/perl -w -MDBIx::RunSQL -e 'create()' create table ... If you want to run SQL statements from a scalar, you can simply pass in a reference to a scalar containing the SQL: sql => \"update mytable set foo='bar';", =item * C<dsn>, C<user>, C<password> - DBI parameters for connecting to the DB =item * C<dbh> - a premade database handle to be used instead of C<dsn> =item * C<force> - continue even if errors are encountered =item * C<verbose> - print each SQL statement as it is run =item * C<verbose_handler> - callback to call with each SQL statement instead of C<print> =item * C<verbose_fh> - filehandle to write to instead of C<STDOUT> =back =cut sub create { my ($self,%args) = @_; $args{sql} ||= 'sql/create.sql'; my $dbh = delete $args{ dbh }; if (! $dbh) { $dbh = DBI->connect($args{dsn}, $args{user}, $args{password}, {}) or die "Couldn't connect to DSN '$args{dsn}' : " . DBI->errstr; }; Runs an SQL file on a prepared database handle. Returns the number of errors encountered. If the statement returns rows, these are printed separated with tabs. =over 4 =item * C<dbh> - a premade database handle =item * C<sql> - name of the file containing the SQL statements =item * C<force> - continue even if errors are encountered =item * C<verbose> - print each SQL statement as it is run =item * C<verbose_handler> - callback to call with each SQL statement instead of C<print> =item * C<verbose_fh> - filehandle to write to instead of C<STDOUT> =item * C<output_bool> - whether to exit with a nonzero exit code if any row is found This makes the function return a nonzero value even if there is no error but a row was found. =item * C<output_string> - whether to output the (one) row and column, without any headers =back =cut sub run_sql_file { my ($self,%args) = @_; my @sql; { open my $fh, "<", $args{sql} or die "Couldn't read '$args{sql}' : $!"; # potentially this should become C<< $/ = ";\n"; >> # and a while loop to handle large SQL files local $/; $args{ sql }= <$fh>; # sluuurp }; $self->run_sql( %args ); } =head2 C<< DBIx::RunSQL->run_sql ARGS >> my $dbh = DBI->connect(...) for my $file (sort glob '*.sql') { DBIx::RunSQL->run_sql_file( verbose => 1, dbh => $dbh, sql => 'create table foo', ); }; Runs an SQL string on a prepared database handle. Returns the number of errors encountered. If the statement returns rows, these are printed separated with tabs, but see the C<output_bool> and C<output_string> options. =over 4 =item * C<dbh> - a premade database handle =item * C<sql> - string or array reference containing the SQL statements =item * C<force> - continue even if errors are encountered =item * C<verbose> - print each SQL statement as it is run =item * C<verbose_handler> - callback to call with each SQL statement instead of C<print> =item * C<verbose_fh> - filehandle to write to instead of C<STDOUT> =item * C<output_bool> - whether to exit with a nonzero exit code if any row is found This makes the function return a nonzero value even if there is no error but a row was found. =item * C<output_string> - whether to output the (one) row and column, without any headers =back =cut sub run_sql { my ($self,%args) = @_; my $errors = 0; ------------------------------------------------------------------------- The page runs on for another hundred lines. Would there be any method to overcome this? That seems to be a problem with the compatability with latest MySQL occuring at Bugs 16775. Thank you again for all the assistance extended! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 08:40:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 07:40:06 +0000 Subject: [Koha-bugs] [Bug 24005] Software error: at login In-Reply-To: <bug-24005-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24005-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24005-70-8ns75ny7Np@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24005 --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Hello Andrew, You are hitting an issue that has been fixed by bug 23579, and that will be part of the next 19.05.x version (19.05.05, not released yet). You should try with MariaDB instead of MySQL. Also it is not needed to copy the code into the comment, I have access to it as you provided me the version you are using :) Good luck! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 09:19:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 08:19:48 +0000 Subject: [Koha-bugs] [Bug 23777] Text converted to html entity codes in cataloguing edit form In-Reply-To: <bug-23777-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23777-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23777-70-4uRguHe3al@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95279 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95279&action=edit Bug 23777: Fix for the advanced editor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 09:37:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 08:37:21 +0000 Subject: [Koha-bugs] [Bug 23777] Text converted to html entity codes in cataloguing edit form In-Reply-To: <bug-23777-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23777-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23777-70-Wr1KQqh5I6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95280 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95280&action=edit Bug 23777: Use To.json in preferences.tt Test plan: Search for "foo bar" (with double quotes) in the sysprefs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 09:37:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 08:37:25 +0000 Subject: [Koha-bugs] [Bug 23777] Text converted to html entity codes in cataloguing edit form In-Reply-To: <bug-23777-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23777-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23777-70-X9meZgM6B3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95281 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95281&action=edit Bug 23777: Use To.json in authorities.tt No fix here. Test plan: Edit GENRE/FORM 040$a With text: Original catalo'"ging age"'ncy Save, you get the alert -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 09:37:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 08:37:29 +0000 Subject: [Koha-bugs] [Bug 23777] Text converted to html entity codes in cataloguing edit form In-Reply-To: <bug-23777-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23777-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23777-70-0k0SRFn5tC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 --- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95282 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95282&action=edit Bug 23777: Use To.json in results.tt Test plan: Search for a string with quote and confirm that it is correctly highlighted in the result list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 09:37:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 08:37:32 +0000 Subject: [Koha-bugs] [Bug 23777] Text converted to html entity codes in cataloguing edit form In-Reply-To: <bug-23777-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23777-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23777-70-JL1DOS2rxq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 --- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95283 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95283&action=edit Bug 23777: Use TO.json in value_builder/unimarc_field_4XX.tt No idea how to test this but, as other fixes work, this one should, right? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 09:37:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 08:37:36 +0000 Subject: [Koha-bugs] [Bug 23777] Text converted to html entity codes in cataloguing edit form In-Reply-To: <bug-23777-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23777-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23777-70-VWg4qaPkiC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 --- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95284 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95284&action=edit Bug 23777: Use To.json in request.tt Test plan: Use quotes in a library's name, then place an item on hold for a patron that cannot do it. If you are allowed to overwrite this restriction you will get a warning: "This item normally cannot be put on hold except for patrons from BRANCHNAME" The library's name should be correcty displayed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 09:38:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 08:38:04 +0000 Subject: [Koha-bugs] [Bug 23777] Text converted to html entity codes in cataloguing edit form In-Reply-To: <bug-23777-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23777-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23777-70-NybVlx4jXG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 --- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Last 5 patches fix similar issues in other templates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 09:40:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 08:40:33 +0000 Subject: [Koha-bugs] [Bug 21496] install.pl: DBD::mysql::st execute failed: Index column size too large. The maximum column size is 767 bytes. at /usr/share/perl5/DBIx/RunSQL.pm line 273. In-Reply-To: <bug-21496-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21496-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21496-70-gz4vzB1QPv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21496 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|UNCONFIRMED |RESOLVED Resolution|--- |FIXED --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Jorge Rodriguez from comment #4) > install.pl: DBD::mysql::st execute failed: Table > 'koha_library.audio_alerts' doesn't exist at /usr/share/perl5/DBIx/RunSQL.pm > line 273. I have Ubuntu 18.04 lts y Koha Estable 19.05 This is a different bug. You need to install MariaDB instead of MySQL, or wait for bug 23579 to be part of 19.05.x (it's pushed but not released and packaged yet). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 09:40:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 08:40:53 +0000 Subject: [Koha-bugs] [Bug 21496] install.pl: DBD::mysql::st execute failed: Index column size too large. The maximum column size is 767 bytes. at /usr/share/perl5/DBIx/RunSQL.pm line 273. In-Reply-To: <bug-21496-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21496-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21496-70-OS7vurzEHc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21496 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |--- Status|RESOLVED |UNCONFIRMED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 09:48:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 08:48:20 +0000 Subject: [Koha-bugs] [Bug 23971] Add logging for basket related actions In-Reply-To: <bug-23971-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23971-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23971-70-HhzOHcgbKx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #1 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 95285 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95285&action=edit Bug 23971: Add Acq action logging This patch adds logging for the following Acq actions: - Basket creation - Basket editing - Basket approval (via EDI) - Basket closure -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 09:51:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 08:51:09 +0000 Subject: [Koha-bugs] [Bug 23953] Cancelling hold does not work if checkout not completed In-Reply-To: <bug-23953-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23953-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23953-70-QyXpWoLtXL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23953 --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Something like that? https://snipboard.io/UXsqMB.jpg -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 09:52:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 08:52:17 +0000 Subject: [Koha-bugs] [Bug 23953] Cancelling hold does not work if checkout not completed In-Reply-To: <bug-23953-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23953-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23953-70-uOJONCY28m@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23953 --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #3) > Something like that? https://snipboard.io/UXsqMB.jpg Actually it's more than 2 options as there is also another checkbox for "Revert waiting status", if the hold is waiting. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 10:07:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 09:07:48 +0000 Subject: [Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images In-Reply-To: <bug-22445-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22445-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22445-70-A2flffZjqP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patchset adds three release notes| |new system preferences: | |* | |`CustomCoverImagesURL` - A | |URL string from which to | |fetch cover images. | |* | |`CustomCoverImages` - | |Allowing administrators to | |enable custom cover images | |display in the staff | |client. | |* | |`OPACCustomCoverImages` - | |Allowing administrators to | |enable custom cover images | |display at the OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 10:10:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 09:10:29 +0000 Subject: [Koha-bugs] [Bug 23971] Add logging for basket related actions In-Reply-To: <bug-23971-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23971-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23971-70-8ye2J8cr9a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95285|0 |1 is obsolete| | --- Comment #2 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 95286 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95286&action=edit Bug 23971: Add Acq action logging This patch adds logging for the following Acq actions: - Basket creation - Basket editing - Basket approval (via EDI) - Basket closure -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 10:12:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 09:12:31 +0000 Subject: [Koha-bugs] [Bug 23971] Add logging for basket related actions In-Reply-To: <bug-23971-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23971-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23971-70-xz2TcQopt8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #3 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Test plan: - Apply the patch - Create a basket => TEST: Observe that an Acquisitions action log has been created containing: => Basket number => Basket name => Creation date => Vendor name => Creator name - Modify a basket => TEST: Observe that an Acquisitions action log has been created containing: => Basket number => Basket name => Edited date => Vendor name => Editor name - Approve a basket via EDI => TEST: Observe that an Acquisitions action log has been created containing: => Basket number => Basket name => Approval date => Vendor name => Approver name - Close a basket => TEST: Observe that an Acquisitions action log has been created containing: => Basket number => Basket name => Closed date => Vendor name => Closer name -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 10:20:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 09:20:35 +0000 Subject: [Koha-bugs] [Bug 13881] Add desk management In-Reply-To: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13881-70-au9kSKKqtU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 --- Comment #27 from Nicolas Legrand <nicolas.legrand at bulac.fr> --- oups, thank you -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 10:22:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 09:22:20 +0000 Subject: [Koha-bugs] [Bug 13881] Add desk management In-Reply-To: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13881-70-rQXcVGhqW3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 Nicolas Legrand <nicolas.legrand at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 10:22:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 09:22:23 +0000 Subject: [Koha-bugs] [Bug 13881] Add desk management In-Reply-To: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13881-70-j8bxah9w3D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 Nicolas Legrand <nicolas.legrand at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93452|0 |1 is obsolete| | --- Comment #28 from Nicolas Legrand <nicolas.legrand at bulac.fr> --- Created attachment 95287 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95287&action=edit Bug 13881: Schema file DO NOT PUSH! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 10:22:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 09:22:28 +0000 Subject: [Koha-bugs] [Bug 13881] Add desk management In-Reply-To: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13881-70-LvfnUX01oV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 Nicolas Legrand <nicolas.legrand at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93453|0 |1 is obsolete| | --- Comment #29 from Nicolas Legrand <nicolas.legrand at bulac.fr> --- Created attachment 95288 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95288&action=edit Bug 13881: kohastructure and atomic update -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 10:22:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 09:22:34 +0000 Subject: [Koha-bugs] [Bug 13881] Add desk management In-Reply-To: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13881-70-sOXWlOLHkb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 Nicolas Legrand <nicolas.legrand at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93454|0 |1 is obsolete| | --- Comment #30 from Nicolas Legrand <nicolas.legrand at bulac.fr> --- Created attachment 95289 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95289&action=edit Bug 13881: Add desk management Add a desk and linked it to a library (branch). That's it. In the future it'll have super features like being able to link waiting reserve to a specific desk. Test plan: 1. go to the administration page and notice there isn't any mention of desk whatsoever 2. apply patches 3. ./installer/data/mysql/updatedatabase.pl 4. you now have desks links in admin-home and admin-menu 5. click the link 6. add a desk 7. add another one 8. delete one 9. you should have a fair list of all current desks defined 10. Done -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 10:26:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 09:26:45 +0000 Subject: [Koha-bugs] [Bug 20888] Allow use of boolean operator 'not' in item search In-Reply-To: <bug-20888-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20888-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20888-70-nDj9pqfAHR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20888 --- Comment #21 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Hi - $('div.form-field-select-text select[name="f"]').change(function() { + $('div.form-field-select-text select.form-field-column').change(function() { is this change necessary ? New select has name "op". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 10:43:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 09:43:39 +0000 Subject: [Koha-bugs] [Bug 23765] After TranslateNotices is set to 'Don't allow', email settings still show multiple languages In-Reply-To: <bug-23765-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23765-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23765-70-HaeZbC5XzE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23765 --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Thanks for implementing that Jonathan, looks great... Just testing it now. Thanks Bin Wen for raising it and submitting the first version :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 11:03:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 10:03:37 +0000 Subject: [Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed) In-Reply-To: <bug-22773-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22773-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22773-70-Svor7R2Qod@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 Devinim <kohadevinim at devinim.com.tr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 11:03:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 10:03:41 +0000 Subject: [Koha-bugs] [Bug 22773] Bulk Close invoices and Filter invoice view (open/closed) In-Reply-To: <bug-22773-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22773-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22773-70-ACLh6XpAJp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22773 --- Comment #12 from Devinim <kohadevinim at devinim.com.tr> --- Created attachment 95290 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95290&action=edit Bug 22773: The deprecated plugin is removed We used the deprecated plugin (fnFilterAll) to benefit "Show only subscriptions" checkbox property. In this new patch we removed fnFilterAll plugin and we put "Show only subscriptions" checkbox in each tab to be able to show checked subscriptions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 11:15:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 10:15:57 +0000 Subject: [Koha-bugs] [Bug 23425] Search explodes with "invalid data, cannot decode object" In-Reply-To: <bug-23425-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23425-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23425-70-8OIGSw18NP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23425 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23846 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23846 [Bug 23846] bad iso 2709 record silently results in broken marcxml -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 11:15:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 10:15:57 +0000 Subject: [Koha-bugs] [Bug 23846] bad iso 2709 record silently results in broken marcxml In-Reply-To: <bug-23846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23846-70-9S8D48VfvY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23846 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23425 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23425 [Bug 23425] Search explodes with "invalid data, cannot decode object" -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 11:16:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 10:16:36 +0000 Subject: [Koha-bugs] [Bug 23846] bad iso 2709 record silently results in broken marcxml In-Reply-To: <bug-23846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23846-70-CMs7GFHtgz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23846 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org Version|19.05 |master Status|NEW |ASSIGNED CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 11:22:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 10:22:43 +0000 Subject: [Koha-bugs] [Bug 23846] bad iso 2709 record silently results in broken marcxml In-Reply-To: <bug-23846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23846-70-QfyVT3j1uX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23846 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 11:22:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 10:22:46 +0000 Subject: [Koha-bugs] [Bug 23846] bad iso 2709 record silently results in broken marcxml In-Reply-To: <bug-23846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23846-70-nj7ry4irbH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23846 --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95291 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95291&action=edit Bug 23846: Display degraded view when MARCXML is invalid (staff detail) When an invalid bibliographic record is imported into the catalogue there is not warning or error. However the bibliographic record detail page will explode (Koha::Biblio::Metadata->record will raise an exception). This patch proposes to catch the exception on this view and display a warning about the situation. Note that editing/saving the record will fix the MARCXML data and so removes the warning (some black magic we should get rid of I suspect). Test plan: - Import a bibliographic record with invalid XML, you can add non printable characters, like 0x1F (CTRL-V 1F with vim) - Go to the detail page => Without this patch you get a 500 => With this patch applied you get a "degraded view" with a warning message, telling you what the error is. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 11:22:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 10:22:50 +0000 Subject: [Koha-bugs] [Bug 23846] bad iso 2709 record silently results in broken marcxml In-Reply-To: <bug-23846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23846-70-pgaFlVjLj1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23846 --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95292 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95292&action=edit Bug 23846: Add a check to the data inconsistencies script This may be quite long for big catalogue, but I think it is a good one to have. Test plan: Same as first patch, then execute search_for_data_inconsistencies.pl Notice the error. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 11:24:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 10:24:38 +0000 Subject: [Koha-bugs] [Bug 23846] Handle records with broken MARCXML on the bibliographic detail view In-Reply-To: <bug-23846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23846-70-0nPgp1HxM6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23846 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|bad iso 2709 record |Handle records with broken |silently results in broken |MARCXML on the |marcxml |bibliographic detail view --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Bonjour Dominique, There is certainly much more to do here, but this quick fix will at least prevent the page to crash. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 11:24:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 10:24:49 +0000 Subject: [Koha-bugs] [Bug 23846] Handle records with broken MARCXML on the bibliographic detail view In-Reply-To: <bug-23846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23846-70-X24V2BjfQC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23846 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 11:27:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 10:27:28 +0000 Subject: [Koha-bugs] [Bug 13881] Add desk management In-Reply-To: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13881-70-KlTOZzp6Rn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 11:27:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 10:27:32 +0000 Subject: [Koha-bugs] [Bug 13881] Add desk management In-Reply-To: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13881-70-9WGSiElFA6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95287|0 |1 is obsolete| | --- Comment #31 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 95293 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95293&action=edit Bug 13881: Schema file DO NOT PUSH! Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 11:27:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 10:27:37 +0000 Subject: [Koha-bugs] [Bug 13881] Add desk management In-Reply-To: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13881-70-J2FL0XBjCn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95288|0 |1 is obsolete| | --- Comment #32 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 95294 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95294&action=edit Bug 13881: kohastructure and atomic update Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 11:27:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 10:27:43 +0000 Subject: [Koha-bugs] [Bug 13881] Add desk management In-Reply-To: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13881-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13881-70-ojmNa0Sgo3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13881 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95289|0 |1 is obsolete| | --- Comment #33 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 95295 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95295&action=edit Bug 13881: Add desk management Add a desk and linked it to a library (branch). That's it. In the future it'll have super features like being able to link waiting reserve to a specific desk. Test plan: 1. go to the administration page and notice there isn't any mention of desk whatsoever 2. apply patches 3. ./installer/data/mysql/updatedatabase.pl 4. you now have desks links in admin-home and admin-menu 5. click the link 6. add a desk 7. add another one 8. delete one 9. you should have a fair list of all current desks defined 10. Done Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 11:40:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 10:40:36 +0000 Subject: [Koha-bugs] [Bug 23777] Text converted to html entity codes in cataloguing edit form In-Reply-To: <bug-23777-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23777-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23777-70-LCNT3qQ5vN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 --- Comment #12 from Bernard <bernard.scaife at ptfs-europe.com> --- Thanks for looking at this Jonathan. Using same workflow as in first post (2019-10-08 13:50:25 UTC): patch 95275 causes $9 field to be completed (link) but $a field to remain blank after clicking "choose". The entire field is discarded on "save". Adding patch 95279 - ditto but there is now no $9 field either. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 12:01:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 11:01:53 +0000 Subject: [Koha-bugs] [Bug 23777] Text converted to html entity codes in cataloguing edit form In-Reply-To: <bug-23777-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23777-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23777-70-yrzFWKYgCt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 --- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- What I see: https://snipboard.io/zuKCU0.jpg Everything looks correct for me, can you provide more details? Are you testing on a sandbox? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 12:05:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 11:05:38 +0000 Subject: [Koha-bugs] [Bug 23596] Update/Delete suggestion reason when receiving the item In-Reply-To: <bug-23596-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23596-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23596-70-Ire9fjNr15@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23596 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 12:05:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 11:05:41 +0000 Subject: [Koha-bugs] [Bug 23596] Update/Delete suggestion reason when receiving the item In-Reply-To: <bug-23596-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23596-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23596-70-Hu0uRJ7YIw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23596 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95231|0 |1 is obsolete| | --- Comment #2 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 95296 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95296&action=edit Bug 23596: Edit suggestion's reason when receiving This patch displays and let the librarian edit the suggestion.reason information when receiving an order. Note that if no reason was given the edit is not possible (easily modifiable if needed but it seems that we do not want to display too much details unnecessarily) Test plan: - Create a suggestion and fill the reason - Create an order from this suggestion - Close the basket and start receiving the order => The reason is displayed and editable - Modify the reason and click Save - Receive again => The reason has been correctly modified - Play with the "Others..." option and give a specific reason Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 12:30:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 11:30:04 +0000 Subject: [Koha-bugs] [Bug 23888] Incorrect vendor id in subscription creation causes internal server error In-Reply-To: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23888-70-41k64lACUa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 12:30:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 11:30:13 +0000 Subject: [Koha-bugs] [Bug 23888] Incorrect vendor id in subscription creation causes internal server error In-Reply-To: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23888-70-S3mbYkCqgz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888 --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95297 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95297&action=edit Bug 23888: Fix JS error if no vendor defined > ReferenceError: BOOKSELLER_IDS is not defined -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 12:34:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 11:34:21 +0000 Subject: [Koha-bugs] [Bug 23777] Text converted to html entity codes in cataloguing edit form In-Reply-To: <bug-23777-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23777-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23777-70-SxQ1QJ1rz7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 --- Comment #14 from Bernard <bernard.scaife at ptfs-europe.com> --- I'm on the customer test server where we had the original issue. 18.11.04. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 12:51:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 11:51:52 +0000 Subject: [Koha-bugs] [Bug 23777] Text converted to html entity codes in cataloguing edit form In-Reply-To: <bug-23777-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23777-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23777-70-8nFKDKJZBr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 --- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Bernard from comment #14) > I'm on the customer test server where we had the original issue. 18.11.04. Tested locally with this version + the patches, all good. Do you see an error in the console? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 13:15:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 12:15:30 +0000 Subject: [Koha-bugs] [Bug 24016] New: manager_id in Koha::Patron::Message->store should not depend on userenv alone Message-ID: <bug-24016-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24016 Bug ID: 24016 Summary: manager_id in Koha::Patron::Message->store should not depend on userenv alone Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: lari.taskula at hypernova.fi QA Contact: testopia at bugs.koha-community.org Koha::Patron::Message->store has this > my $userenv = C4::Context->userenv; > $self->manager_id( $userenv ? $userenv->{number} : undef); This breaks in REST API when userenv is not set. Let API user pass manager_id without relying on C4::Context->userenv. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 13:24:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 12:24:30 +0000 Subject: [Koha-bugs] [Bug 22393] Remove last remaining manualinvoice use In-Reply-To: <bug-22393-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22393-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22393-70-8MiA0Mtjj8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22393 --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95298 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95298&action=edit Bug 22393: Remove last remaining use of C4::Accounts::manualinvoice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 13:26:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 12:26:57 +0000 Subject: [Koha-bugs] [Bug 24016] manager_id in Koha::Patron::Message->store should not depend on userenv alone In-Reply-To: <bug-24016-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24016-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24016-70-xXROFZG8kv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24016 --- Comment #1 from Lari Taskula <lari.taskula at hypernova.fi> --- Created attachment 95299 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95299&action=edit Bug 24016: Add a failing test for overwrite-able manager_id in Koha::Patron::Message To test: 1. prove t/db_dependent/Koha/Patron/Messages.t 2. Observe failure t/db_dependent/Koha/Patron/Messages.t .. 2/12 Failed test 'Manager id should be overwrite-able even if defined in userenv' at t/db_dependent/Koha/Patron/Messages.t line 90. got: '1100' expected: '1101' Looks like you failed 1 test of 12. t/db_dependent/Koha/Patron/Messages.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/12 subtests -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 13:27:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 12:27:39 +0000 Subject: [Koha-bugs] [Bug 24016] manager_id in Koha::Patron::Message->store should not depend on userenv alone In-Reply-To: <bug-24016-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24016-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24016-70-B4y5wHvDOT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24016 Lari Taskula <lari.taskula at hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lari.taskula at hypernova.fi |ity.org | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24003 Status|NEW |Needs Signoff --- Comment #2 from Lari Taskula <lari.taskula at hypernova.fi> --- See https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003#c3 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 13:27:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 12:27:39 +0000 Subject: [Koha-bugs] [Bug 24003] REST API basic auth lacks C4::Context->userenv In-Reply-To: <bug-24003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24003-70-DnkBdhJr6K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24003 Lari Taskula <lari.taskula at hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24016 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 13:27:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 12:27:59 +0000 Subject: [Koha-bugs] [Bug 24016] manager_id in Koha::Patron::Message->store should not depend on userenv alone In-Reply-To: <bug-24016-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24016-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24016-70-wdnc3eBw6p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24016 --- Comment #3 from Lari Taskula <lari.taskula at hypernova.fi> --- Created attachment 95300 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95300&action=edit Bug 24016: manager_id in Koha::Patron::Message->store should not depend on userenv alone Koha::Patron::Message->store has this my $userenv = C4::Context->userenv; $self->manager_id( $userenv ? $userenv->{number} : undef); This breaks in REST API when userenv is not set. Let API user pass manager_id without relying on C4::Context->userenv. To test: 1. prove t/db_dependent/Koha/Patron/Messages.t 2. Observe success -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 13:29:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 12:29:26 +0000 Subject: [Koha-bugs] [Bug 24016] manager_id in Koha::Patron::Message->store should not depend on userenv alone In-Reply-To: <bug-24016-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24016-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24016-70-APJ7roXeQ8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24016 Lari Taskula <lari.taskula at hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95299|0 |1 is obsolete| | --- Comment #4 from Lari Taskula <lari.taskula at hypernova.fi> --- Created attachment 95301 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95301&action=edit Bug 24016: Add a failing test for overwrite-able manager_id in Koha::Patron::Message To test: 1. prove t/db_dependent/Koha/Patron/Messages.t 2. Observe failure t/db_dependent/Koha/Patron/Messages.t .. 2/12 Failed test 'Manager id should be overwrite-able even if defined in userenv' at t/db_dependent/Koha/Patron/Messages.t line 90. got: '1100' expected: '1101' Looks like you failed 1 test of 12. t/db_dependent/Koha/Patron/Messages.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/12 subtests Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 13:29:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 12:29:37 +0000 Subject: [Koha-bugs] [Bug 24016] manager_id in Koha::Patron::Message->store should not depend on userenv alone In-Reply-To: <bug-24016-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24016-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24016-70-I0P8KffxcS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24016 Lari Taskula <lari.taskula at hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95300|0 |1 is obsolete| | --- Comment #5 from Lari Taskula <lari.taskula at hypernova.fi> --- Created attachment 95302 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95302&action=edit Bug 24016: manager_id in Koha::Patron::Message->store should not depend on userenv alone Koha::Patron::Message->store has this my $userenv = C4::Context->userenv; $self->manager_id( $userenv ? $userenv->{number} : undef); This breaks in REST API when userenv is not set. Let API user pass manager_id without relying on C4::Context->userenv. To test: 1. prove t/db_dependent/Koha/Patron/Messages.t 2. Observe success Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 13:39:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 12:39:58 +0000 Subject: [Koha-bugs] [Bug 22393] Remove last remaining manualinvoice use In-Reply-To: <bug-22393-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22393-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22393-70-kappZP0x3c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22393 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95298|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95303 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95303&action=edit Bug 22393: Remove last remaining use of C4::Accounts::manualinvoice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 13:45:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 12:45:38 +0000 Subject: [Koha-bugs] [Bug 23998] Messages REST API In-Reply-To: <bug-23998-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23998-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23998-70-Nwo25G8bv1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23998 Lari Taskula <lari.taskula at hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24016 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24016 [Bug 24016] manager_id in Koha::Patron::Message->store should not depend on userenv alone -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 13:45:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 12:45:38 +0000 Subject: [Koha-bugs] [Bug 24016] manager_id in Koha::Patron::Message->store should not depend on userenv alone In-Reply-To: <bug-24016-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24016-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24016-70-dU9p1VUGPl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24016 Lari Taskula <lari.taskula at hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23998 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23998 [Bug 23998] Messages REST API -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 13:45:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 12:45:41 +0000 Subject: [Koha-bugs] [Bug 23998] Messages REST API In-Reply-To: <bug-23998-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23998-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23998-70-pEtoizXWqS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23998 --- Comment #1 from Lari Taskula <lari.taskula at hypernova.fi> --- Created attachment 95304 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95304&action=edit Bug 23998: REST API for messages - Add /api/v1/messages endpoint Exposes messages database table via REST API. GET /api/v1/messages POST /api/v1/messages PUT /api/v1/messages DELETE /api/v1/messages To test: 1. prove t/db_dependent/api/v1/messages.t https://bugs.koha-community.org/show_bug.cgi?id=23988 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 13:46:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 12:46:19 +0000 Subject: [Koha-bugs] [Bug 23998] Messages REST API In-Reply-To: <bug-23998-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23998-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23998-70-06xzzbNpi7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23998 Lari Taskula <lari.taskula at hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95304|0 |1 is obsolete| | --- Comment #2 from Lari Taskula <lari.taskula at hypernova.fi> --- Created attachment 95305 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95305&action=edit Bug 23998: REST API for messages - Add /api/v1/messages endpoint Exposes messages database table via REST API. GET /api/v1/messages POST /api/v1/messages PUT /api/v1/messages DELETE /api/v1/messages To test: 1. prove t/db_dependent/api/v1/messages.t Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 13:50:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 12:50:13 +0000 Subject: [Koha-bugs] [Bug 22393] Remove last remaining manualinvoice use In-Reply-To: <bug-22393-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22393-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22393-70-ZpaM6wsYiS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22393 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 13:51:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 12:51:27 +0000 Subject: [Koha-bugs] [Bug 22393] Remove last remaining manualinvoice use In-Reply-To: <bug-22393-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22393-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22393-70-YFIKrl540S@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22393 --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Test plan: Try adding various combinations of data in the manual invoice screen.. All options should still work as before, however a few new error cases are now caught and warned about.. for example, try entering a barcode that cannot be found in the system and you will see a new error is displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 14:20:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 13:20:28 +0000 Subject: [Koha-bugs] [Bug 23765] After TranslateNotices is set to 'Don't allow', email settings still show multiple languages In-Reply-To: <bug-23765-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23765-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23765-70-GjJ7iWN87U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23765 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95136|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95306 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95306&action=edit Bug 23765: Do not display localized templates if TranslateNotices is off To test: 1. Enable multi-languages 2. Set the preference 'TranslateNotices' on 'Allow' 3. Go to: tools==>Notices & slips==>Edit, make sure it has multilingual email templates. 4. Set the preference TranslateNotices on 'Don't allow'. 5. Go to: tools==>Notices & slips==>Edit, the template shows several tab for the same transport type. 6. Apply the patch. 7. Repeat the steps 4 and 5 8. Success. It only shows the default template when TranslateNotices is 'Dont allow'. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 14:20:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 13:20:43 +0000 Subject: [Koha-bugs] [Bug 23765] After TranslateNotices is set to 'Don't allow', email settings still show multiple languages In-Reply-To: <bug-23765-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23765-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23765-70-aiCh4try8U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23765 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 14:20:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 13:20:54 +0000 Subject: [Koha-bugs] [Bug 23765] After TranslateNotices is set to 'Don't allow', email settings still show multiple languages In-Reply-To: <bug-23765-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23765-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23765-70-PczRYSWVYz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23765 --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Works well, Signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 14:21:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 13:21:04 +0000 Subject: [Koha-bugs] [Bug 23874] Advanced Editor is not loaded if X-Content-Type-Options: nosniff In-Reply-To: <bug-23874-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23874-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23874-70-k25l6lXlbV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23874 --- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #8) > Created attachment 95274 [details] [review] > Bug 23874: Fix advanced editor if nosniff is set Hi Jonathan, I am curious why this makes a difference? The fact that you ask to return JSON does not make it a different GET request? Marcel Just for reference: jQuery.get( url [, data ] [, success ] [, dataType ] ) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 14:21:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 13:21:16 +0000 Subject: [Koha-bugs] [Bug 23900] Label maker cannot concatenate database fields In-Reply-To: <bug-23900-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23900-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23900-70-cxZeGf54la@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23900 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95273|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 95307 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95307&action=edit Bug 23900: Teach label maker to concat database fields Test plan: - define a label layout with this field list: "100a 245s","enumchron copynumber" - find or create a record with values for all of those fields - generate a label for that record - the 100a and 245s successfully display on one line - the enumchron and copynumber are displayed and separated by a space Try other combinations Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 14:21:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 13:21:31 +0000 Subject: [Koha-bugs] [Bug 23900] Label maker cannot concatenate database fields In-Reply-To: <bug-23900-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23900-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23900-70-Uvz84YFGQc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23900 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 14:25:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 13:25:38 +0000 Subject: [Koha-bugs] [Bug 23822] Regression: As of 19.05.04 deletion of patrons with outstanding credits is silently blocked In-Reply-To: <bug-23822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23822-70-hFkeREwaog@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23822 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 14:26:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 13:26:12 +0000 Subject: [Koha-bugs] [Bug 22393] Remove last remaining manualinvoice use In-Reply-To: <bug-22393-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22393-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22393-70-4BRP3CdUQd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22393 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 14:45:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 13:45:24 +0000 Subject: [Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8 In-Reply-To: <bug-24002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24002-70-qFT2qtlfWV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002 --- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- So really we shouldn't have any left around already. :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 14:47:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 13:47:59 +0000 Subject: [Koha-bugs] [Bug 22393] Remove last remaining manualinvoice use In-Reply-To: <bug-22393-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22393-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22393-70-SjDigxzUPe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22393 --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95308 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95308&action=edit Bug 22393: simplify? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 14:48:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 13:48:11 +0000 Subject: [Koha-bugs] [Bug 22393] Remove last remaining manualinvoice use In-Reply-To: <bug-22393-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22393-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22393-70-CmTIQPRSY2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22393 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95303|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95309 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95309&action=edit Bug 22393: Remove last remaining use of C4::Accounts::manualinvoice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 14:50:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 13:50:48 +0000 Subject: [Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8 In-Reply-To: <bug-24002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24002-70-0ULSDsJiZR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Trivial patches, Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 14:51:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 13:51:53 +0000 Subject: [Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8 In-Reply-To: <bug-24002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24002-70-pOt54j1b9F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 14:51:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 13:51:54 +0000 Subject: [Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8 In-Reply-To: <bug-24002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24002-70-h1HkVfSMDX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002 --- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 14:54:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 13:54:50 +0000 Subject: [Koha-bugs] [Bug 23998] Messages REST API In-Reply-To: <bug-23998-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23998-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23998-70-GiTVxkAjmQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23998 Lari Taskula <lari.taskula at hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95305|0 |1 is obsolete| | --- Comment #3 from Lari Taskula <lari.taskula at hypernova.fi> --- Created attachment 95310 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95310&action=edit Bug 23998: REST API for messages - Add /api/v1/messages endpoint Exposes messages database table via REST API. GET /api/v1/messages POST /api/v1/messages PUT /api/v1/messages DELETE /api/v1/messages To test: 1. prove t/db_dependent/api/v1/messages.t Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 14:54:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 13:54:58 +0000 Subject: [Koha-bugs] [Bug 23998] Messages REST API In-Reply-To: <bug-23998-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23998-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23998-70-OLHKIGmxYJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23998 Lari Taskula <lari.taskula at hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 15:00:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 14:00:46 +0000 Subject: [Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api methods to Koha::Object In-Reply-To: <bug-23893-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23893-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23893-70-QcKTZ7GLIN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 15:00:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 14:00:48 +0000 Subject: [Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api methods to Koha::Object In-Reply-To: <bug-23893-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23893-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23893-70-MH6FDx3vr0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95276|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 15:00:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 14:00:50 +0000 Subject: [Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api methods to Koha::Object In-Reply-To: <bug-23893-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23893-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23893-70-t0Yh6sHZqb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95277|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 15:00:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 14:00:53 +0000 Subject: [Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api methods to Koha::Object In-Reply-To: <bug-23893-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23893-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23893-70-l0CNjMU7T3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95278|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 15:01:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 14:01:16 +0000 Subject: [Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api methods to Koha::Object In-Reply-To: <bug-23893-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23893-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23893-70-b8nxZaUgbn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893 --- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 95311 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95311&action=edit Bug 23893: Unit tests This patch introduces tests for the implemented methods. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 15:01:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 14:01:19 +0000 Subject: [Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api methods to Koha::Object In-Reply-To: <bug-23893-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23893-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23893-70-bRU8z1xwDd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893 --- Comment #6 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 95312 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95312&action=edit Bug 23893: Implement Koha::Object->from_api_mapping This patch implements the from_api_mapping method, that calculates (and caches) the reserve mapping from the to_api_mapping method. A generic to_api_mapping is added to simplify things a bit in the generic to_api method and so the mappings are reusable in the way they are in from_api_mapping. To test: 1. Apply this patches 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 15:01:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 14:01:23 +0000 Subject: [Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api methods to Koha::Object In-Reply-To: <bug-23893-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23893-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23893-70-f7xNrEKkEP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893 --- Comment #7 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 95313 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95313&action=edit Bug 23893: Add new_from_api and set_from_api to Koha::Object This patch introduces the following methods to the Koha::Object class: - set_from_api - new_from_api This methods are going to be used when writing API controllers that map to the attributes to the DB schema ones. To test: 1. Apply this patchset 2. Run: $ kshell k$ prove t/db_dependent/Koha/Object.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 15:01:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 14:01:27 +0000 Subject: [Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api methods to Koha::Object In-Reply-To: <bug-23893-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23893-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23893-70-giO5r8yYfI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893 --- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 95314 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95314&action=edit Bug 23893: Use in /cities This patch makes the cities controller use the new methods from Koha::Object. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/cities.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 15:01:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 14:01:31 +0000 Subject: [Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api methods to Koha::Object In-Reply-To: <bug-23893-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23893-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23893-70-SSEHAATx4v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893 --- Comment #9 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 95315 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95315&action=edit Bug 23893: Use in /patrons This patch makes the patrons endpoint use the new methods from Koha::Object. To test: 1. Apply this patch 2. Run: $ kshell k$ prove t/db_dependent/api/v1/patrons.t => SUCCESS: Tests pass! 3. Sign off :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 15:08:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 14:08:45 +0000 Subject: [Koha-bugs] [Bug 23893] Add ->new_from_api and ->set_from_api methods to Koha::Object In-Reply-To: <bug-23893-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23893-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23893-70-E6eDtaHRHM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23893 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 15:09:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 14:09:59 +0000 Subject: [Koha-bugs] [Bug 23854] Cannot edit a suggestion In-Reply-To: <bug-23854-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23854-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23854-70-F9Pp7yYo8c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23854 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94518|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95316 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95316&action=edit [ON TOP OF 14973] Bug 23854: Fix failure on dates when editing a suggestion This is the patch to use if bug 14973 is pushed first. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 15:14:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 14:14:22 +0000 Subject: [Koha-bugs] [Bug 23918] Search results incorrect for multiple vowel words In-Reply-To: <bug-23918-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23918-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23918-70-sK53FIPOeo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23918 --- Comment #6 from Bernard <bernard.scaife at ptfs-europe.com> --- You were right! Commenting out equivalent ō(oo) did the trick for that example. Unfortunately, there may be similar problems for other vowel combinations. eg aa ("aachen" brings up "aachen" and "achen") I am assuming equivalent ā(aa) might be the one to comment out for that, but of course it means those diacritics are not properly mapped then if they should ever genuinely come up. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 15:24:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 14:24:44 +0000 Subject: [Koha-bugs] [Bug 23874] Advanced Editor is not loaded if X-Content-Type-Options: nosniff In-Reply-To: <bug-23874-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23874-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23874-70-VSr8A2k0EQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23874 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Hum I think my tests were wrong yesterday. I thought I saw a content type text/html before this patch, then json. But I cannot replicate this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 15:24:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 14:24:54 +0000 Subject: [Koha-bugs] [Bug 23874] Advanced Editor is not loaded if X-Content-Type-Options: nosniff In-Reply-To: <bug-23874-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23874-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23874-70-dVp2qvwqhl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23874 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW Assignee|jonathan.druart at bugs.koha-c |koha-bugs at lists.koha-commun |ommunity.org |ity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 15:25:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 14:25:30 +0000 Subject: [Koha-bugs] [Bug 23777] Text converted to html entity codes in cataloguing edit form In-Reply-To: <bug-23777-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23777-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23777-70-BAVOUmB1cb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23777 --- Comment #16 from Bernard <bernard.scaife at ptfs-europe.com> --- Nothing in the js console. When you click "choose", the small pop up window appears briefly saying "loading", but then Koha just returns to the main catalogue record window. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 15:29:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 14:29:11 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-4xIqctUGvq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95162|0 |1 is obsolete| | Attachment #95163|0 |1 is obsolete| | Attachment #95164|0 |1 is obsolete| | Attachment #95165|0 |1 is obsolete| | Attachment #95166|0 |1 is obsolete| | Attachment #95167|0 |1 is obsolete| | Attachment #95168|0 |1 is obsolete| | Attachment #95169|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95317 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95317&action=edit Bug 23590: Add ability to edit the manager of a suggestion Prior to this patch there was an hidden behavior that set the manager to the logged in user when a suggestion was edited. This patch proposes to let the librarian pick another manager. Other small adjustements will be added to polish this new behavior: * Create 2 new DB columns: suggestions.lastmodificationby and suggestion.lastmodificationdate * Choose a manager when editing a suggestion * Batch modify suggestions and set a manager for them * Let notify the new manager using the TO_PROCESS letter * Display the manageddate, lastmodificationby and lastmodificationdate info where appropriate This first patch adds a new "Select manager" link when editing a suggestion. Test plan for the whole patchset: 0/ a. Execute the update DB entry, generate the new DBIC file and restart all b. Create at least 2 patrons with the suggestions_manage permission 1/ Submit a new suggestion (OPAC or staff, not important) 2/ Accept it 3/ Edit it => "Last modification by" is empty => You see that you are the manager of this suggestion 4/ Click "Select manager" and search for a new manager => The patron search will only display patrons with the suggestions_manage permission 5/ Save 6/ Edit again => The manager is set to you, but there is a note saying that previously it was the patron you picked => The "Last modification by" is set to you 7/ Click "Keep existing manager" => The manager is now set to the previous manager 8/ Select another manager (which has a valid email address defined) 9/ Click the "notify" checkbox 10/ Save 11/ Confirm that a TO_PROCESS notice has been generated into the message_queue table 12/ Create at least one other suggestion 13/ List the suggestions => There is a 4th action column to assign a manager to several suggestions in one go. 14/ Use this new button and confirm that it works as expected 15/ Go to your purchase suggestion list (OPAC and staff) => You see the "managed date" displayed in a new column -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 15:29:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 14:29:17 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-ikpO4kukds@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95318 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95318&action=edit Bug 23590: Clean TT variables for patrons Just a bit of cleaning -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 15:29:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 14:29:22 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-4Akqt7GG3c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95319 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95319&action=edit Bug 23590: Cleaning - Remove op_* vars -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 15:29:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 14:29:27 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-MkWKpB0ZHU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95320 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95320&action=edit Bug 23590: Batch update manager for suggestions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 15:29:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 14:29:32 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-wFwbSznZCe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95321 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95321&action=edit Bug 23590: Only return patrons that have the suggestions_manage permission -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 15:29:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 14:29:36 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-JSvy4s2wHZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95322 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95322&action=edit Bug 23590: Add the ability to notify a new manager -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 15:29:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 14:29:41 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-QF5Kh1q7o0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95323 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95323&action=edit Bug 23590: Display managed date in 'Your purchase suggestions' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 15:29:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 14:29:48 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-V4YXK5tby4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95324 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95324&action=edit Bug 23590: Add lastmodification by and date columns No tests are provided for the changes made to SearchSuggestion. It is going to be remove very soon as it is super ugly... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 15:35:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 14:35:05 +0000 Subject: [Koha-bugs] [Bug 22393] Remove last remaining manualinvoice use In-Reply-To: <bug-22393-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22393-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22393-70-049ntXRhm3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22393 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Attachment #95308|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 15:35:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 14:35:56 +0000 Subject: [Koha-bugs] [Bug 24017] New: Search for year of birth Message-ID: <bug-24017-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24017 Bug ID: 24017 Summary: Search for year of birth Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: christian.stelzenmueller at bsz-bw.de QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Searching for the year of birth would be nice. Either in the searchfield "date of birth", or in an extra field. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 15:40:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 14:40:06 +0000 Subject: [Koha-bugs] [Bug 22393] Remove last remaining manualinvoice use In-Reply-To: <bug-22393-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22393-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22393-70-VcbVkUYKn8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22393 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95309|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95325 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95325&action=edit Bug 22393: Remove last remaining use of C4::Accounts::manualinvoice -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 15:40:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 14:40:10 +0000 Subject: [Koha-bugs] [Bug 22393] Remove last remaining manualinvoice use In-Reply-To: <bug-22393-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22393-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22393-70-8UhQ1WY5WB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22393 --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95326 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95326&action=edit Bug 22393: (follow-up) Handle deleted items -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 15:46:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 14:46:05 +0000 Subject: [Koha-bugs] [Bug 23888] Incorrect vendor id in subscription creation causes internal server error In-Reply-To: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23888-70-PQvyTmOe8k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888 Joonas Kylmälä <joonas.kylmala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> --- Jonathan, please squash that JS error follow-up to the original patch as both of these patches are yours. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 15:46:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 14:46:40 +0000 Subject: [Koha-bugs] [Bug 23822] Regression: As of 19.05.04 deletion of patrons with outstanding credits is silently blocked In-Reply-To: <bug-23822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23822-70-OIpAAnZxi0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23822 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95254|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95327 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95327&action=edit Bug 23822: Fix deletion of patrons with credit There are bugs in both master and 19.05, but different. Anyway we should have this check to make sure a negative value will have the same behavior: trigger the confirmation message (instead of a blank page). If we want to reject the deletion of a patron with credit we should handle it on a separate bug report (behavior change) Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 15:47:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 14:47:24 +0000 Subject: [Koha-bugs] [Bug 23822] Regression: As of 19.05.04 deletion of patrons with outstanding credits is silently blocked In-Reply-To: <bug-23822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23822-70-KXT9TIVxLg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23822 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- A simple patch that restores the original behaviour... Signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 15:52:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 14:52:28 +0000 Subject: [Koha-bugs] [Bug 24011] Browser tabs auto close when editing items from report with biblio links In-Reply-To: <bug-24011-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24011-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24011-70-CbJ9hwKNWF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24011 --- Comment #1 from Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> --- I would also like to add that selecting "edit items" from the edit menu will force the tab to close. I.e., Follow steps 1-3, then instead of clicking the edit item button, select "edit items" from the edit menu button. The tab closes without loading the additem.pl page -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 15:53:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 14:53:17 +0000 Subject: [Koha-bugs] [Bug 24011] Browser tabs auto close when editing items from report with biblio links In-Reply-To: <bug-24011-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24011-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24011-70-xCj0MafD20@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24011 Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 15:53:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 14:53:36 +0000 Subject: [Koha-bugs] [Bug 24011] Browser tabs auto close when editing items from report with biblio links In-Reply-To: <bug-24011-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24011-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24011-70-wZzD0KxHyM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24011 Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mkstephens at lancasterseminar | |y.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 15:58:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 14:58:48 +0000 Subject: [Koha-bugs] [Bug 23888] Incorrect vendor id in subscription creation causes internal server error In-Reply-To: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23888-70-nLSII6oRbo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Not a problem for testing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 16:01:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 15:01:58 +0000 Subject: [Koha-bugs] [Bug 23888] Incorrect vendor id in subscription creation causes internal server error In-Reply-To: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23888-70-KOYRjbIvMU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888 --- Comment #8 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> --- The meeting notes in https://wiki.koha-community.org/wiki/Development_IRC_meeting_27_September_2017 state that "follow-up patches must be squashed if not signed-off yet, and the history is not needed". It really makes reading the history a lot easier if we don't have unnecessary commits. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 16:03:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 15:03:27 +0000 Subject: [Koha-bugs] [Bug 24018] New: No need to die "Not logged in" Message-ID: <bug-24018-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24018 Bug ID: 24018 Summary: No need to die "Not logged in" Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 18403, 20489 There is a wrong pattern in several controller files: my $logged_in_user = Koha::Patrons->find( $loggedinuser ) or die "Not logged in"; This has been introduced by commit cee2cf9ff927504f9c24f6519462a7d702c5c27d Bug 18403: Add sub output_and_exit_if_error - unknown_patron & cannot_see_patron_infos Which noted: Note that the 'or die "Not logged in";' part should not be needed, but... who trusts C4::Auth? I think it could be used as a safeguard later. I am willing to sed and remove them if required. Since we prevent DB user login it's no longer needed. It is time to remove it, as we trust our code (don't you?) and it can be confusing. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 [Bug 18403] Hide patron information if not part of the logged in user library group https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489 [Bug 20489] Prevent DB user login -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 16:03:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 15:03:27 +0000 Subject: [Koha-bugs] [Bug 18403] Hide patron information if not part of the logged in user library group In-Reply-To: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18403-70-tvzC3rQoCc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18403 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24018 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24018 [Bug 24018] No need to die "Not logged in" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 16:03:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 15:03:27 +0000 Subject: [Koha-bugs] [Bug 20489] Prevent DB user login In-Reply-To: <bug-20489-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20489-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20489-70-MzVU229wLj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20489 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24018 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24018 [Bug 24018] No need to die "Not logged in" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 16:05:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 15:05:25 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: <bug-14973-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14973-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14973-70-6wlxSiZeNc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Keywords| |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 16:06:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 15:06:21 +0000 Subject: [Koha-bugs] [Bug 23854] Cannot edit a suggestion In-Reply-To: <bug-23854-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23854-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23854-70-BTHs4n9zQP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23854 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Keywords|rel_19_11_candidate |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 16:06:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 15:06:27 +0000 Subject: [Koha-bugs] [Bug 24019] New: Patron batch modification based on borrowernumber Message-ID: <bug-24019-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24019 Bug ID: 24019 Summary: Patron batch modification based on borrowernumber Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: sally.healey at cheshiresharedservices.gov.uk QA Contact: testopia at bugs.koha-community.org It would be useful for librarians to be able to batch modify patrons based on a list of borrowernumbers instead of just lists of cardnumbers. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 16:07:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 15:07:19 +0000 Subject: [Koha-bugs] [Bug 23854] Cannot edit a suggestion In-Reply-To: <bug-23854-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23854-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23854-70-QQ3nZLJI7w@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23854 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14973 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 16:07:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 15:07:19 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: <bug-14973-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14973-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14973-70-afYjc5APys@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23854 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23854 [Bug 23854] Cannot edit a suggestion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 16:13:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 15:13:14 +0000 Subject: [Koha-bugs] [Bug 23872] ManaKB Permissions can be subverted In-Reply-To: <bug-23872-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23872-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23872-70-WJqCv3ZRwQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23872 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 16:14:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 15:14:35 +0000 Subject: [Koha-bugs] [Bug 24020] New: System Preference todaysIssuesDefaultSortOrder is not sorting properly Message-ID: <bug-24020-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24020 Bug ID: 24020 Summary: System Preference todaysIssuesDefaultSortOrder is not sorting properly Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The system preference todaysIssuesDefaultSortOrder allows the library to choose how their patron's checkouts are sorted on the circulation.pl page. Currently (18.11.10), this is not sorting by due date with either Earliest to Latest or Latest to Earliest chosen. 1. Find 3 items types that circulate for different lengths of time. 2. Checkout out these 3 items to a patron. 3. See that the items are not sorted by due date at all. I found this bug, and there is disagreement with the wording of the system preference, but the manual states " Asks: Sort today’s checkouts on the circulation page from ___ due date", that this should be sorting on Due Date, not checkout date/time. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14005 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 16:21:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 15:21:58 +0000 Subject: [Koha-bugs] [Bug 24018] No need to die "Not logged in" In-Reply-To: <bug-24018-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24018-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24018-70-eQkFs0v62T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24018 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 16:22:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 15:22:02 +0000 Subject: [Koha-bugs] [Bug 24018] No need to die "Not logged in" In-Reply-To: <bug-24018-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24018-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24018-70-vlYMFizVOr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24018 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95328 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95328&action=edit Bug 24018: Remove die "Not logged in" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 16:26:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 15:26:26 +0000 Subject: [Koha-bugs] [Bug 23888] Incorrect vendor id in subscription creation causes internal server error In-Reply-To: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23888-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23888-70-DY72u21vxJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23888 --- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Joonas Kylmälä from comment #8) > The meeting notes in > https://wiki.koha-community.org/wiki/ > Development_IRC_meeting_27_September_2017 state that "follow-up patches must > be squashed if not signed-off yet, and the history is not needed". It really > makes reading the history a lot easier if we don't have unnecessary commits. The history is needed for you, to know which changes I made. QA and RM can squash patches if needed. Feel free to squash when signing off this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 16:33:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 15:33:46 +0000 Subject: [Koha-bugs] [Bug 24021] New: Koha allows creation of fines less than 1 cent, but not payment of those fines Message-ID: <bug-24021-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24021 Bug ID: 24021 Summary: Koha allows creation of fines less than 1 cent, but not payment of those fines Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org To test: - create a manual invoice on a patron account in the amount of $1.005 - verify that the charge saves successfully - verify that amount due shows as $1.01 on patron record - use a report to see that accountlines.amount is 1.005 - try to pay off charge - verify Koha will not allow payment of $1.01, gives error "You must pay a value less than or equal to 1.00" - verify that Koha will not allow you to enter a payment or writeoff amount of $1.005 I'm not sure if the better answer here is to block creation of fees in fractions of a cent or allow payment/writeoff of fees in fractions of a cent, but the mismatch is an issue. Confirmed behavior of 18.11, 19.05, and master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 16:35:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 15:35:16 +0000 Subject: [Koha-bugs] [Bug 23854] Cannot edit a suggestion In-Reply-To: <bug-23854-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23854-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23854-70-3q2HqTnVnC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23854 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94518|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 16:35:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 15:35:34 +0000 Subject: [Koha-bugs] [Bug 23854] Cannot edit a suggestion In-Reply-To: <bug-23854-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23854-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23854-70-Mrp4iLLaso@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23854 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|14973 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 16:35:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 15:35:34 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: <bug-14973-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14973-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14973-70-qHu5siAsmA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|23854 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23854 [Bug 23854] Cannot edit a suggestion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 16:46:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 15:46:38 +0000 Subject: [Koha-bugs] [Bug 24022] New: Z3950Responder tests are failing on D8 and U18 Message-ID: <bug-24022-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24022 Bug ID: 24022 Summary: Z3950Responder tests are failing on D8 and U18 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 13937 koha_1 | # Failed test 'test_search' koha_1 | # at t/db_dependent/Koha/Z3950Responder/GenericSession.t line 152. koha_1 | ZOOM error 10000 "Connect failed" (addinfo: "localhost:42111") from diag-set 'ZOOM'# Looks like your test exited with 255 just after 3. koha_1 | [14:13:54] t/db_dependent/Koha/Z3950Responder/GenericSession.t koha_1 | # Failed test 'test_search' koha_1 | # at t/db_dependent/Koha/Z3950Responder/ZebraSession.t line 118. koha_1 | ZOOM error 10000 "Connect failed" (addinfo: "127.0.0.1:42111") from diag-set 'ZOOM'# Looks like your test exited with 255 just after 3. koha_1 | [14:36:24] t/db_dependent/Koha/Z3950Responder/ZebraSession.t Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 16:46:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 15:46:38 +0000 Subject: [Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13937-70-e5eHi9hsU1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24022 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24022 [Bug 24022] Z3950Responder tests are failing on D8 and U18 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 16:51:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 15:51:13 +0000 Subject: [Koha-bugs] [Bug 23854] Cannot edit a suggestion In-Reply-To: <bug-23854-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23854-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23854-70-g3h4k4LO1d@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23854 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_20_05_target |rel_19_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 17:01:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 16:01:09 +0000 Subject: [Koha-bugs] [Bug 24022] Z3950Responder tests are failing on D8 and U18 In-Reply-To: <bug-24022-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24022-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24022-70-DkUJY9qUXK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24022 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW Assignee|jonathan.druart at bugs.koha-c |chris at bigballofwax.co.nz |ommunity.org | Severity|normal |major --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- We have a race condition here, I guess that's why we get the "Connect failed". kohadev-koha at c46b1ba2057e:/kohadevbox/koha$ prove t/db_dependent/Koha/Z3950Responder/Session*.t t/db_dependent/Koha/Z3950Responder/Session2.t .. ok t/db_dependent/Koha/Z3950Responder/Session.t ... 1/3 # Failed test 'All statuses added in one field as expected' # at t/db_dependent/Koha/Z3950Responder/Session.t line 63. # got: 'Checked Out, Lost, Not for Loan, Borked completely, Withdrawn, In Transit, On Hold' # expected: 'Checked Out, Lost, Not for Loan, Damaged, Withdrawn, In Transit, On Hold' # Failed test 'Available status added as expected' # at t/db_dependent/Koha/Z3950Responder/Session.t line 66. # got: 'Free as a bird' # expected: 'Available' # Looks like you failed 2 tests of 2. t/db_dependent/Koha/Z3950Responder/Session.t ... 3/3 # Failed test 'add_item_status' # at t/db_dependent/Koha/Z3950Responder/Session.t line 68. # Looks like you failed 1 test of 3. t/db_dependent/Koha/Z3950Responder/Session.t ... Dubious, test returned 1 (wstat 256, 0x100) Failed 1/3 subtests Test Summary Report ------------------- t/db_dependent/Koha/Z3950Responder/Session.t (Wstat: 256 Tests: 3 Failed: 1) Failed test: 3 Non-zero exit status: 1 Files=2, Tests=6, 6 wallclock secs ( 0.01 usr 0.01 sys + 4.65 cusr 1.31 csys = 5.98 CPU) Result: FAIL -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 17:04:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 16:04:40 +0000 Subject: [Koha-bugs] [Bug 8132] Batch delete tool deletes items with holds on them In-Reply-To: <bug-8132-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8132-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8132-70-3b0PaQ8kOa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8132 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |major -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 17:07:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 16:07:14 +0000 Subject: [Koha-bugs] [Bug 24022] Z3950Responder tests are failing on D8 and U18 In-Reply-To: <bug-24022-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24022-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24022-70-iapI8EUuLY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24022 --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Ok, maybe not. # Failed test 'All statuses added in one field as expected' # at t/db_dependent/Koha/Z3950Responder/Session.t line 63. # got: 'Checked Out, Lost, Not for Loan, Borked completely, Withdrawn, In Transit, On Hold' # expected: 'Checked Out, Lost, Not for Loan, Damaged, Withdrawn, In Transit, On Hold' # Failed test 'Available status added as expected' # at t/db_dependent/Koha/Z3950Responder/Session.t line 66. # got: 'Free as a bird' # expected: 'Available' # Looks like you failed 2 tests of 2. => This happens when Session2.t is run before Session.t To recreate: prove t/db_dependent/Koha/Z3950Responder/Session2.t t/db_dependent/Koha/Z3950Responder/Session.t I do not recreate the "Connect failed" when logged in to the container -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 17:07:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 16:07:15 +0000 Subject: [Koha-bugs] [Bug 23846] Handle records with broken MARCXML on the bibliographic detail view In-Reply-To: <bug-23846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23846-70-kRFKlYCWWM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23846 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95291|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95329 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95329&action=edit Bug 23846: Display degraded view when MARCXML is invalid (staff detail) When an invalid bibliographic record is imported into the catalogue there is not warning or error. However the bibliographic record detail page will explode (Koha::Biblio::Metadata->record will raise an exception). This patch proposes to catch the exception on this view and display a warning about the situation. Note that editing/saving the record will fix the MARCXML data and so removes the warning (some black magic we should get rid of I suspect). Test plan: - Import a bibliographic record with invalid XML, you can add non printable characters, like 0x1F (CTRL-V 1F with vim) - Go to the detail page => Without this patch you get a 500 => With this patch applied you get a "degraded view" with a warning message, telling you what the error is. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 17:07:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 16:07:19 +0000 Subject: [Koha-bugs] [Bug 23846] Handle records with broken MARCXML on the bibliographic detail view In-Reply-To: <bug-23846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23846-70-fdFUFYNnl2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23846 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95292|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95330 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95330&action=edit Bug 23846: Add a check to the data inconsistencies script This may be quite long for big catalogue, but I think it is a good one to have. Test plan: Same as first patch, then execute search_for_data_inconsistencies.pl Notice the error. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 17:08:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 16:08:29 +0000 Subject: [Koha-bugs] [Bug 23846] Handle records with broken MARCXML on the bibliographic detail view In-Reply-To: <bug-23846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23846-70-V369WZVlOI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23846 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Works as expected, thanks Jonathan.. Signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 17:08:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 16:08:52 +0000 Subject: [Koha-bugs] [Bug 24023] New: Add ability to create bundles of items Message-ID: <bug-24023-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24023 Bug ID: 24023 Summary: Add ability to create bundles of items Change sponsored?: Sponsored Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl This will add the ability to link items to a bibliographic record, making it a bundle of items. This bibliographic record can have item on its own, making it possible to reserve and check out bundles of items like a normal item. Items that are attached to a bundle will have their withdrawn status set, making them impossible to reserve or checkout individually. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 17:10:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 16:10:30 +0000 Subject: [Koha-bugs] [Bug 23985] The method Koha::Item-> is not covered by tests! In-Reply-To: <bug-23985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23985-70-Z7qBUkLPc0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23985 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 17:12:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 16:12:17 +0000 Subject: [Koha-bugs] [Bug 24023] Add ability to create bundles of items In-Reply-To: <bug-24023-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24023-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24023-70-nhqs1svwO8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24023 --- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 95331 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95331&action=edit Bug 24023: Add ability to create bundles of items This patch adds the ability to link items to a biblio to create bundles of items that can be reserved and checked out like a regular item. A withdrawn status will be set to linked items so that they can't be checked out while they are part of a bundle. When returning a bundle, the list of items that are part of this bundle will be displayed, allowing the librarian to verify that all items are there. Bundles can also be used in the inventory tool as a filter. Test plan: 0. Apply the patch, run updatedatabase + update_dbix_class_files 1. Create a biblio record with at least a title. Create an item for this biblio record 2. In the biblio 'Edit' menu you have a new option: 'Link elements'. Click on it 3. Enter a list of valid and invalid barcodes in the textarea, select a withdrawn status and click on 'Continue' 4. Verify that new fields have been added to the MARC record (462 for UNIMARC, 774 otherwise) 5. Verify that the withdrawn status has been correctly set for the items you have linked 6. Check that the biblionumber of the parent bibliographic record is in each linked items uri field 7. Verify that, for item created at step 1, items.materials has been updated with the number of items contained in the bundle 8. Edit the biblio record and remove one of the 462/774 fields 9. Verify that the corresponding item's withdrawn status has been reset 10. Check that the uri field in the corresponding items was removed 11. Checkout and checkin the item created at step 1 12. You should see the list of items contained in the bundle. Click on 'Confirm checkin without verifying'. Verify that the item has been returned 13. Checkout and checkin the item created at step 1 again 14. Now click on 'Verify items bundle contents'. A textarea lets you enter barcodes. Enter some (but not all) barcodes that are in the bundle. Select a 'lost' status and click on 'Confirm checkin and mark missing items as lost' 15. Verify that the items corresponding to barcodes you did not type in the textarea are now marked as lost with the lost status you chose 16. Go to the inventory tool, use the bundle filter and verify that it works Sponsored-by: Bibliothèque Départementale de l'Yonne -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 17:12:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 16:12:38 +0000 Subject: [Koha-bugs] [Bug 24023] Add ability to create bundles of items In-Reply-To: <bug-24023-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24023-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24023-70-R5HB5cfEW0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24023 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 17:13:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 16:13:39 +0000 Subject: [Koha-bugs] [Bug 24024] New: Holds Awaiting Pickup (Both Active and Expired) Sorts by Firstname Message-ID: <bug-24024-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24024 Bug ID: 24024 Summary: Holds Awaiting Pickup (Both Active and Expired) Sorts by Firstname Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: mfuerst at hmcpl.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com With the 19.05 upgrade, the Holds Awaiting Pickup lists in Circulation sort by the patron's firstname as opposed to their surname. Holds are on the shelf by surname, to protect patron privacy. I feel like this is a SOP for most systems, but if it isn't, it should be a preference we can set. Thanks! -Marti Fuerst Huntsville-Madison County Public Library -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 17:17:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 16:17:47 +0000 Subject: [Koha-bugs] [Bug 24022] Z3950Responder tests are failing on D8 and U18 In-Reply-To: <bug-24022-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24022-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24022-70-nf8Q7LQAub@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24022 --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95332 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95332&action=edit Bug 24022: Prevent Session2.t to fail if run after Session.t Cache must be cleaned! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 17:17:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 16:17:51 +0000 Subject: [Koha-bugs] [Bug 24022] Z3950Responder tests are failing on D8 and U18 In-Reply-To: <bug-24022-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24022-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24022-70-KB3DG9mkWn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24022 --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95333 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95333&action=edit Bug 24022: Remove unecessary delete from authorised_values Why do we need that exactly? The cache is not flushed so it should not be needed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 17:33:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 16:33:36 +0000 Subject: [Koha-bugs] [Bug 23767] Spent and Ordered total values don't include child funds on acqui-home In-Reply-To: <bug-23767-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23767-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23767-70-1w35SDRo2U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23767 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93828|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95334 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95334&action=edit Bug 23767: Include child funds in total spent and ordered on acqui-home To test: 1 - Have three funds, two parents and one child 2 - Open a basket and add an order to each fund 3 - View acqui-home.pl 4 - Note that ordered values are only added from the two parent funds 5 - Complete these orders (close basket, receive) 6 - Note the spent only includes parent funds 7 - Place three more orders, one from each fund 8 - Now you can see both spent and ordered are incorrect 9 - Apply patch 10 - Reload, all should add correctly Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 17:33:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 16:33:40 +0000 Subject: [Koha-bugs] [Bug 23767] Spent and Ordered total values don't include child funds on acqui-home In-Reply-To: <bug-23767-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23767-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23767-70-Py1ChmqRic@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23767 --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95335 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95335&action=edit Bug 23767: (QA follow-up) Same treatment for available -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 17:34:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 16:34:23 +0000 Subject: [Koha-bugs] [Bug 23767] Spent and Ordered total values don't include child funds on acqui-home In-Reply-To: <bug-23767-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23767-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23767-70-OIjHwnlgTn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23767 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 17:36:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 16:36:04 +0000 Subject: [Koha-bugs] [Bug 24022] Z3950Responder tests are failing on D8 and U18 In-Reply-To: <bug-24022-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24022-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24022-70-8ClzeI8mn0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24022 --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95336 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95336&action=edit Bug 24022: Try to fix 'connect failed' I am assuming that the tests fail on Jenkins's nodes because they are too slow. The server is not setup yet when we are trying to access it. Just a guess... Note that sleep is usually a bad idea... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 17:36:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 16:36:29 +0000 Subject: [Koha-bugs] [Bug 24022] Z3950Responder tests are failing randomly In-Reply-To: <bug-24022-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24022-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24022-70-N1YmRurEyx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24022 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |jonathan.druart at bugs.koha-c | |ommunity.org Summary|Z3950Responder tests are |Z3950Responder tests are |failing on D8 and U18 |failing randomly Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 17:36:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 16:36:43 +0000 Subject: [Koha-bugs] [Bug 24022] Z3950Responder tests are failing randomly In-Reply-To: <bug-24022-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24022-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24022-70-b3C4OfKZK0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24022 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 17:38:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 16:38:35 +0000 Subject: [Koha-bugs] [Bug 24022] Z3950Responder tests are failing randomly In-Reply-To: <bug-24022-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24022-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24022-70-ZVWmZo8xmP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24022 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ere.maijala at helsinki.fi, | |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 17:51:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 16:51:02 +0000 Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference In-Reply-To: <bug-18532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18532-70-UHyxfVzcH6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Agustín Moyano <agustinmoyano at theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95030|0 |1 is obsolete| | Attachment #95031|0 |1 is obsolete| | --- Comment #10 from Agustín Moyano <agustinmoyano at theke.io> --- Created attachment 95337 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95337&action=edit Bug 18532: Add new letter AUTO_RENEWALS_DGST, new Auto_Renewals in message_attributes, and configured message_transports -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 17:51:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 16:51:09 +0000 Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference In-Reply-To: <bug-18532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18532-70-mJr2fcgoUD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #11 from Agustín Moyano <agustinmoyano at theke.io> --- Created attachment 95338 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95338&action=edit Bug 18532: set auto_renewals as patron messaging preference This patch adds the "Auto renewals" messaging preference on intranet and OPAC, and adds digest feature to misc/cronjobs/automatic_renewals.pl script. To test: 1. apply patches 2. perl installer/data/mysql/updatedatabase.pl 3. make sure renewals are allowed in circ rules 4. grab a patron and go to details page CHECK => patron's messaging preferences has a "Auto renewals" row -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 17:56:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 16:56:05 +0000 Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference In-Reply-To: <bug-18532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18532-70-a4aYmyhJSa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 --- Comment #12 from Agustín Moyano <agustinmoyano at theke.io> --- (In reply to Katrin Fischer from comment #9) > Comment on attachment 95031 [details] [review] > Bug 18532: set auto_renewals as patron messaging preference > > Review of attachment 95031 [details] [review]: > ----------------------------------------------------------------- > > ::: misc/cronjobs/automatic_renewals.pl > @@ +2,4 @@ > > > > # This file is part of Koha. > > # > > +# Copyright (C) 2014 Hochschule f�r Gesundheit (hsg), Germany > > It looks like maybe the encoding of the file was changed? it Should be > reading "für". I didn't realize, but seems my editor didn't recognize that character encoding. I saved it now as UTF-8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 17:59:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 16:59:45 +0000 Subject: [Koha-bugs] [Bug 23846] Handle records with broken MARCXML on the bibliographic detail view In-Reply-To: <bug-23846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23846-70-50WpStqbrb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23846 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |tomascohen at gmail.com QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | --- Comment #8 from Tomás Cohen Arazi <tomascohen at gmail.com> --- I tested the change in catalogue/detail.pl and it works as expected. I loaded the failed marcxml into a sample record and had the maintenance script display the problem, and the staff UI display it as well. I have doubts about how useful the degraded view is or in what circumstances it will display anything. I would like it to display references to the introduced maintenance script so people can take actions (for example: It is recommended that you run the following maintenance script to find (this and maybe other) problems on your data: maintenance/search_for_data_inconsistencies.pl /end_suggestion Minor issues: - Missing filter in the tt. - POD error on the script -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 18:03:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 17:03:39 +0000 Subject: [Koha-bugs] [Bug 23985] The method Koha::Item-> is not covered by tests! In-Reply-To: <bug-23985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23985-70-0ZvXC3uk9K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23985 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 18:03:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 17:03:43 +0000 Subject: [Koha-bugs] [Bug 23985] The method Koha::Item-> is not covered by tests! In-Reply-To: <bug-23985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23985-70-qWcezcLgzb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23985 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95339 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95339&action=edit Bug 23985: (bug 21206 follow-up) Fix checkout list when "Hold pickup library match" not set This patch restores the behavior prior to bug 21206. If "Hold pickup library match" is "Not set", then hold_fulfillment_policy equals an empty string. Test plan: 1. Go to "Circulation and fines rules" 2. Under "Default checkout, hold and return policy", unset "Hold pickup library match" and Save 3. Place a hold on one item for one patron 4. Try to checkout the same item with another patron => Without this patch you the checkout list do not show, and the logs contain "The method Koha::Item-> is not covered by tests!" => With this patch applied you see the checkout list QA will take care of comparing the statement with the one before bug 21206 and make sure they are equivalent -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 18:09:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 17:09:41 +0000 Subject: [Koha-bugs] [Bug 23767] Spent and Ordered total values don't include child funds on acqui-home In-Reply-To: <bug-23767-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23767-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23767-70-llsKllZdpu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23767 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 18:19:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 17:19:15 +0000 Subject: [Koha-bugs] [Bug 23846] Handle records with broken MARCXML on the bibliographic detail view In-Reply-To: <bug-23846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23846-70-thzkhoB9Lo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23846 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 18:19:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 17:19:19 +0000 Subject: [Koha-bugs] [Bug 23846] Handle records with broken MARCXML on the bibliographic detail view In-Reply-To: <bug-23846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23846-70-6HuUI89BN9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23846 --- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95340 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95340&action=edit Bug 23846: Handle exception gracefully at the OPAC I do not think we should have the same trick as the intranet, and display a message. This should be enough. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 18:21:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 17:21:02 +0000 Subject: [Koha-bugs] [Bug 23846] Handle records with broken MARCXML on the bibliographic detail view In-Reply-To: <bug-23846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23846-70-gYDIShVQuE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23846 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95340|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95341 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95341&action=edit Bug 23846: Handle exception gracefully at the OPAC I do not think we should have the same trick as the intranet, and display a message. This should be enough. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 18:26:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 17:26:36 +0000 Subject: [Koha-bugs] [Bug 23640] L1 cache too long in SIP Server In-Reply-To: <bug-23640-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23640-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23640-70-7akRjgYiPS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23640 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- It should be done for every connection I'd say, to make sure it's always up-to-date. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 18:36:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 17:36:02 +0000 Subject: [Koha-bugs] [Bug 24025] New: Make CodeMirror content searchable Message-ID: <bug-24025-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24025 Bug ID: 24025 Summary: Make CodeMirror content searchable Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: george at nekls.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Bug 21582 added CodeMirror to the system preferences IntranetUserJS and OPACUserJS. Prior to this addition, if you wanted to search for something in one of these preferences you could use Firefox's built in "Find in This Page..." functions to search for content anywhere inside of the two UserJS system preferences. Since the addition of CodeMirror, you can only search for content in the two UserJS system preferences if the content is displayed on the screen. This makes it difficult to search for something on, say, line 500 of IntranetUserJS, unless you've already scrolled down to line 500 - or you've opened up CodeMirror to show every line in the preference you want to search through. It looks like CodeMirror has an addon for searching through CodeMirror content, so I'm wondering if this addon could be incorporated into Koha wherever we're using CodeMirror. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 18:56:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 17:56:45 +0000 Subject: [Koha-bugs] [Bug 23846] Handle records with broken MARCXML on the bibliographic detail view In-Reply-To: <bug-23846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23846-70-LTsJrzEiP3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23846 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 18:56:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 17:56:48 +0000 Subject: [Koha-bugs] [Bug 23846] Handle records with broken MARCXML on the bibliographic detail view In-Reply-To: <bug-23846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23846-70-nad3Ddot3R@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23846 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95329|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 18:56:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 17:56:51 +0000 Subject: [Koha-bugs] [Bug 23846] Handle records with broken MARCXML on the bibliographic detail view In-Reply-To: <bug-23846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23846-70-GjQv5Wse7f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23846 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95330|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 18:56:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 17:56:54 +0000 Subject: [Koha-bugs] [Bug 23846] Handle records with broken MARCXML on the bibliographic detail view In-Reply-To: <bug-23846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23846-70-syjlj6GvU1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23846 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95341|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 18:57:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 17:57:18 +0000 Subject: [Koha-bugs] [Bug 23846] Handle records with broken MARCXML on the bibliographic detail view In-Reply-To: <bug-23846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23846-70-u6ljxKOtnI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23846 --- Comment #11 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 95342 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95342&action=edit Bug 23846: Display degraded view when MARCXML is invalid (staff detail) When an invalid bibliographic record is imported into the catalogue there is not warning or error. However the bibliographic record detail page will explode (Koha::Biblio::Metadata->record will raise an exception). This patch proposes to catch the exception on this view and display a warning about the situation. Note that editing/saving the record will fix the MARCXML data and so removes the warning (some black magic we should get rid of I suspect). Test plan: - Import a bibliographic record with invalid XML, you can add non printable characters, like 0x1F (CTRL-V 1F with vim) - Go to the detail page => Without this patch you get a 500 => With this patch applied you get a "degraded view" with a warning message, telling you what the error is. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 18:57:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 17:57:22 +0000 Subject: [Koha-bugs] [Bug 23846] Handle records with broken MARCXML on the bibliographic detail view In-Reply-To: <bug-23846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23846-70-eNU9QwwIg1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23846 --- Comment #12 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 95343 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95343&action=edit Bug 23846: Add a check to the data inconsistencies script This may be quite long for big catalogue, but I think it is a good one to have. Test plan: Same as first patch, then execute search_for_data_inconsistencies.pl Notice the error. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 18:57:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 17:57:26 +0000 Subject: [Koha-bugs] [Bug 23846] Handle records with broken MARCXML on the bibliographic detail view In-Reply-To: <bug-23846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23846-70-GgFPY99gWE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23846 --- Comment #13 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 95344 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95344&action=edit Bug 23846: Handle exception gracefully at the OPAC I do not think we should have the same trick as the intranet, and display a message. This should be enough. Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 19:04:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 18:04:33 +0000 Subject: [Koha-bugs] [Bug 17498] Expose system preference values to JavaScript in the OPAC In-Reply-To: <bug-17498-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17498-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17498-70-AabENggFut@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17498 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> --- I'm not sure we should expose system preferences to the public front end. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 19:08:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 18:08:07 +0000 Subject: [Koha-bugs] [Bug 24026] New: Wrong parameters in Koha/Templates/Plugin/CirculationRules.pm and smart-rules.tt Message-ID: <bug-24026-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24026 Bug ID: 24026 Summary: Wrong parameters in Koha/Templates/Plugin/CirculationRules.pm and smart-rules.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com The searches in the module use $branchcode for all three parameters, looks like a copy/paste issue 29 $branchcode = undef if $branchcode eq q{} or $branchcode eq q{*}; 30 $categorycode = undef if $categorycode eq q{} or $branchcode eq q{*}; 31 $itemtype = undef if $itemtype eq q{} or $branchcode eq q{*}; The admin page uses 'Get' instead of 'Search' for maxisseqty/maxonsiteissueqty - this returns the 'effective' rule and so may return the wrong rule if things are not set 139 <td> 140 [% SET rule_value = CirculationRules.Get( rule.branchcode, rule.categorycode, rule.itemtype, 'maxissueqty' ) %] 141 [% IF rule_value || rule_value == "0" %] 142 [% rule_value | html %] 143 [% ELSE %] 144 <span>Unlimited</span> 145 [% END %] 146 </td> We discovered this from upgrade issues resulting from bug 23813 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 19:08:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 18:08:34 +0000 Subject: [Koha-bugs] [Bug 24026] Wrong parameters in Koha/Templates/Plugin/CirculationRules.pm and smart-rules.tt In-Reply-To: <bug-24026-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24026-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24026-70-RPSQH4tbLl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24026 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org, | |kelly at bywatersolutions.com, | |kyle at bywatersolutions.com, | |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 19:09:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 18:09:34 +0000 Subject: [Koha-bugs] [Bug 24011] Browser tabs auto close when editing items from report with biblio links In-Reply-To: <bug-24011-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24011-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24011-70-UbonZ4xl0P@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24011 Brendon Ford <brendon.ford at manhattan.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |brendon.ford at manhattan.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 19:12:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 18:12:58 +0000 Subject: [Koha-bugs] [Bug 15976] test bug for a script we are developping. In-Reply-To: <bug-15976-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15976-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15976-70-5OWNerxvxq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15976 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 19:13:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 18:13:05 +0000 Subject: [Koha-bugs] [Bug 15976] test bug for a script we are developping. In-Reply-To: <bug-15976-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15976-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15976-70-QjwMdJj4in@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15976 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|trivial |enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 19:14:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 18:14:30 +0000 Subject: [Koha-bugs] [Bug 24009] Koha::Account->outstanding_debits should support inline filtering In-Reply-To: <bug-24009-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24009-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24009-70-B4svhBYdRL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24009 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> --- I like this. It is in the lines of what we've been thinking when Koha::Account was conceived, right Kyle? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 19:16:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 18:16:10 +0000 Subject: [Koha-bugs] [Bug 24009] Koha::Account->outstanding_debits should support inline filtering In-Reply-To: <bug-24009-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24009-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24009-70-u8TVGgoaMb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24009 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 19:16:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 18:16:13 +0000 Subject: [Koha-bugs] [Bug 24009] Koha::Account->outstanding_debits should support inline filtering In-Reply-To: <bug-24009-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24009-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24009-70-sPDwkKPulQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24009 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95272|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 19:16:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 18:16:16 +0000 Subject: [Koha-bugs] [Bug 24009] Koha::Account->outstanding_debits should support inline filtering In-Reply-To: <bug-24009-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24009-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24009-70-nikRkwPjdE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24009 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95271|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 19:16:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 18:16:39 +0000 Subject: [Koha-bugs] [Bug 24009] Koha::Account->outstanding_debits should support inline filtering In-Reply-To: <bug-24009-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24009-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24009-70-yAo7b2R7dk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24009 --- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 95345 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95345&action=edit Bug 24009: Add filter_by option to outstanding_debits This patch adds an optional 'filter_by' argument to Koha::Account->outstanding_debits which current accepts 'blocks_issue' and will filter down the result set of outstanding_debits based upon the values of the following system preferences. * `HoldsInNoissuesCharge` * `RentalsInNoissuesCharge` * `ManInvInNoissuesCharge` Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 19:16:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 18:16:43 +0000 Subject: [Koha-bugs] [Bug 24009] Koha::Account->outstanding_debits should support inline filtering In-Reply-To: <bug-24009-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24009-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24009-70-xRuUtMIGrs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24009 --- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 95346 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95346&action=edit Bug 24009: Add Unit Tests Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 19:20:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 18:20:16 +0000 Subject: [Koha-bugs] [Bug 17499] Koha objects for messaging preferences In-Reply-To: <bug-17499-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17499-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17499-70-s7wyGQ0OFz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17499 --- Comment #66 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Can we de-squash this huge patch into meaningful pieces with easy to follow details on the resulting implementation, please? I like the results :-D -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 19:23:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 18:23:51 +0000 Subject: [Koha-bugs] [Bug 24024] Holds Awaiting Pickup (Both Active and Expired) Sorts by Firstname In-Reply-To: <bug-24024-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24024-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24024-70-vpRYwjCxhO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24024 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19770 CC| |nick at bywatersolutions.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19770 [Bug 19770] Add cardnumber to holds awaiting pickup screen and add classes to borrower info -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 19:23:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 18:23:51 +0000 Subject: [Koha-bugs] [Bug 19770] Add cardnumber to holds awaiting pickup screen and add classes to borrower info In-Reply-To: <bug-19770-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19770-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19770-70-WFdhBJOaOH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19770 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24024 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24024 [Bug 24024] Holds Awaiting Pickup (Both Active and Expired) Sorts by Firstname -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 19:30:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 18:30:24 +0000 Subject: [Koha-bugs] [Bug 24024] Holds Awaiting Pickup (Both Active and Expired) Sorts by Firstname In-Reply-To: <bug-24024-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24024-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24024-70-iH6JWh33Kn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24024 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 19:30:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 18:30:27 +0000 Subject: [Koha-bugs] [Bug 24024] Holds Awaiting Pickup (Both Active and Expired) Sorts by Firstname In-Reply-To: <bug-24024-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24024-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24024-70-EuVwwgIluZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24024 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95347 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95347&action=edit Bug 24024: Invert names on halds waiting report -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 19:31:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 18:31:18 +0000 Subject: [Koha-bugs] [Bug 24024] Holds Awaiting Pickup (Both Active and Expired) Sorts by Firstname In-Reply-To: <bug-24024-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24024-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24024-70-jkRg20Swnw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24024 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.05 |master Severity|enhancement |normal Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 19:54:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 18:54:47 +0000 Subject: [Koha-bugs] [Bug 17509] Notify patrons to return items requested on hold by another person In-Reply-To: <bug-17509-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17509-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17509-70-MBrNFJ9apT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|19014 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 [Bug 19014] Patrons should not get an 'on_reserve' notification if the due date is far into the future -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 19:54:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 18:54:47 +0000 Subject: [Koha-bugs] [Bug 19014] Patrons should not get an 'on_reserve' notification if the due date is far into the future In-Reply-To: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19014-70-jPNXIr0l0v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Josef Moravec <josef.moravec at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|17509 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17509 [Bug 17509] Notify patrons to return items requested on hold by another person -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 20:10:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 19:10:19 +0000 Subject: [Koha-bugs] [Bug 19014] Patrons should not get an 'on_reserve' notification if the due date is far into the future In-Reply-To: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19014-70-eUrIjQ1PqX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 20:10:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 19:10:23 +0000 Subject: [Koha-bugs] [Bug 19014] Patrons should not get an 'on_reserve' notification if the due date is far into the future In-Reply-To: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19014-70-KsEomsTTRE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #65590|0 |1 is obsolete| | Attachment #86960|0 |1 is obsolete| | Attachment #90509|0 |1 is obsolete| | --- Comment #42 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95348 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95348&action=edit Bug 19014: Only process issues for autorenewal if on or after soonest renewal date This patch check the soonest renewal date and skips processing auto renewals if before this date This ensures patrons won't get notifications far in advance if an item is on hold or has other issues To test: 1 - Checkout an item to a patron with a due date 2 days in the future and 'No renewal before' unset 2 - Place a hold on that item 3 - Define an AUTO_RENEWALS circulation notice with below at a minimum [% checkout.auto_renew_error %] 4 - perl misc/cronjobs/automatic_renewals.pl --send-notices 5 - Patron is not notified 6 - Set 'No renewal before' to 1 7 - run cronjob 8 - Patron is notified with error 'on_reserve' 9 - Set 'No renewal before' to 3 10 - UPDATE issues SET auto_renew_error = NULL; 11 - run cronjob 12 - Patron is notified with error 'on_reserve' 13 - APPLY PATCH 14 - Unset 'No renewal before' 15 - UPDATE issues SET auto_renew_error = NULL; 16 - run cronjob 17 - Patron is not notified 18 - UPDATE issues SET auto_renew_error = NULL; 19 - Set 'No renewal before' to 1 20 - run cronjob 21 - Patron is notified with error 'on_reserve' 22 - Set 'No renewal before' to 3 23 - UPDATE issues SET auto_renew_error = NULL; 24 - run cronjob 25 - Patron is not notified -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 20:10:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 19:10:35 +0000 Subject: [Koha-bugs] [Bug 19014] Patrons should not get an 'on_reserve' notification if the due date is far into the future In-Reply-To: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19014-70-UYePVJVxlO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 20:24:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 19:24:18 +0000 Subject: [Koha-bugs] [Bug 23672] Dependency graph colours missing In-Reply-To: <bug-23672-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23672-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23672-70-IuWhwmv8XZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23672 --- Comment #3 from Chris Cormack <chris at bigballofwax.co.nz> --- Thats right, it got dropped out in a merge. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 20:55:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 19:55:19 +0000 Subject: [Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record In-Reply-To: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23591-70-vXvyvwTlmd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org Change sponsored?|Seeking developer |Sponsored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 20:55:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 19:55:26 +0000 Subject: [Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record In-Reply-To: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23591-70-rZGIyQoTjt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 20:55:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 19:55:38 +0000 Subject: [Koha-bugs] [Bug 23592] Link between suggestion and bibliographic record on staff client In-Reply-To: <bug-23592-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23592-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23592-70-0xvreaE5xp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23592 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Change sponsored?|Seeking developer |Sponsored CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 20:55:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 19:55:55 +0000 Subject: [Koha-bugs] [Bug 23593] Link between suggestion and bibliographic record on OPAC In-Reply-To: <bug-23593-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23593-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23593-70-YiQ4TfMyMF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23593 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Change sponsored?|Seeking developer |Sponsored Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 20:58:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 19:58:16 +0000 Subject: [Koha-bugs] [Bug 23992] Adding multiple items with barcode might end with infinite loop if same barcode will be next_value In-Reply-To: <bug-23992-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23992-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23992-70-rj7TdQmrXW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23992 --- Comment #1 from Andrew Nugged <nugged at gmail.com> --- Created attachment 95349 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95349&action=edit Bug 23992: Items multi add - generate 'no_next_barcode' error if no barcode When multiple items added with barcode from the first, we expect for next barcode to be generated. If it will be the same barcode or empty one, then error 'no_next_barcode' will be generated to inform user/operator that operation wasn't completed as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 21:03:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 20:03:37 +0000 Subject: [Koha-bugs] [Bug 23953] Cancelling hold does not work if checkout not completed In-Reply-To: <bug-23953-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23953-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23953-70-HQY6akfb0m@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23953 --- Comment #5 from Aleisha Amohia <aleisha at catalyst.net.nz> --- (In reply to Jonathan Druart from comment #4) > (In reply to Jonathan Druart from comment #3) > > Something like that? https://snipboard.io/UXsqMB.jpg > > Actually it's more than 2 options as there is also another checkbox for > "Revert waiting status", if the hold is waiting. That could work! Would just also need the "Yes, check out and revert waiting status" option too. And to standardise the style of the other buttons. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 21:06:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 20:06:15 +0000 Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests In-Reply-To: <bug-23974-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23974-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23974-70-t2GufzllE1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 --- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- I think we're safe to push these additional tests as they are. Not sure what more needs discussing at the minute? Can we set to NSO ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 21:08:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 20:08:50 +0000 Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests In-Reply-To: <bug-23974-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23974-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23974-70-QoaKTYHVY6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 --- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Brain fuzz, already at signed off.. I meant I think these are safe to push and just improve our test coverage at this point. Would you just check my final followup looks ok Jonathan? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 21:14:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 20:14:40 +0000 Subject: [Koha-bugs] [Bug 23992] Adding multiple items with barcode might end with infinite loop if same barcode will be next_value In-Reply-To: <bug-23992-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23992-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23992-70-NzSupAHSre@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23992 --- Comment #2 from Andrew Nugged <nugged at gmail.com> --- this might be "WIP" (not full patch without test plan), so I need community help, because it's hard to generate test plan: I tried with all variants of barcodes and in most cases we have barcode just incremented in "->next_value" method. With patch, the error "no_next_barcode" will be generated so this will break the loop and inform the user about the wrong generation in cases when we start adding WITH barcode but then for some reason the same or empty barcode started to appear. If we start with empty barcode – then just requested numbers of items added without barcodes at all, as it was before. Also, this will prevent the infinite loop (when $i++ won't be executed) in cases when the barcode generator might stuck and return the same old or some another barcode which will be always found for some item. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 21:28:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 20:28:28 +0000 Subject: [Koha-bugs] [Bug 23592] Link between suggestion and bibliographic record on staff client In-Reply-To: <bug-23592-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23592-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23592-70-YdPWKmcOLA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23592 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 21:28:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 20:28:32 +0000 Subject: [Koha-bugs] [Bug 23592] Link between suggestion and bibliographic record on staff client In-Reply-To: <bug-23592-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23592-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23592-70-RhN9mgrR7t@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23592 --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95350 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95350&action=edit Bug 23592: Link to the bibliographic record from the suggestion If there is a link between a suggestion and a bibliographic record (ie. if suggestion.biblionumber is set), it makes sense to have an hyperlink on the suggestion detail page. Test plan: - Create 2 suggestions - Create an order from one of them - Go to the detail page of the suggestion => The one with the order has a to the bibliographic record => The other one is not linked with a bibliographic record, and so the title is displayed, without hyperlink -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 21:33:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 20:33:09 +0000 Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests In-Reply-To: <bug-23974-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23974-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23974-70-NZH8Z1toWO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 --- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- What about the FIXMEs? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 21:35:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 20:35:17 +0000 Subject: [Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch In-Reply-To: <bug-20478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20478-70-nYcIP0aM7G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 Margaret <margaret at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05 released in| | CC| |margaret at bywatersolutions.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 21:45:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 20:45:03 +0000 Subject: [Koha-bugs] [Bug 23593] Link between suggestion and bibliographic record on OPAC In-Reply-To: <bug-23593-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23593-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23593-70-8bjeIRS2aZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23593 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 21:45:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 20:45:06 +0000 Subject: [Koha-bugs] [Bug 23593] Link between suggestion and bibliographic record on OPAC In-Reply-To: <bug-23593-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23593-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23593-70-i3bXvcTwHn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23593 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95351 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95351&action=edit Bug 23593: Link to the bibliographic record from the suggestion (OPAC) If there is a link between a suggestion and a bibliographic record (ie. if suggestion.biblionumber is set), it makes sense to have an hyperlink on the suggestion list at the OPAC. Test plan: - Create 2 suggestions - Create an order from one of them - Go to the suggestion list at the OPAC => The one with the order has a to the bibliographic record => The other one is not linked with a bibliographic record, and so the title is displayed, without hyperlink -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 21:45:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 20:45:17 +0000 Subject: [Koha-bugs] [Bug 23593] Link between suggestion and bibliographic record on OPAC In-Reply-To: <bug-23593-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23593-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23593-70-HuAMOdMEsJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23593 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23592 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 21:45:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 20:45:17 +0000 Subject: [Koha-bugs] [Bug 23592] Link between suggestion and bibliographic record on staff client In-Reply-To: <bug-23592-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23592-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23592-70-1oe2pQdf6t@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23592 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23593 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 22:09:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 21:09:35 +0000 Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions In-Reply-To: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22784-70-za2ghYOpac@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Agustín Moyano <agustinmoyano at theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|agustinmoyano at theke.io |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 12 23:26:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 22:26:24 +0000 Subject: [Koha-bugs] [Bug 24025] Make CodeMirror content searchable In-Reply-To: <bug-24025-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24025-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24025-70-v2L135pwbJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24025 Barbara Johnson <barbara.johnson at bedfordtx.gov> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |barbara.johnson at bedfordtx.g | |ov -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 00:27:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 23:27:20 +0000 Subject: [Koha-bugs] [Bug 23640] L1 cache too long in SIP Server In-Reply-To: <bug-23640-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23640-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23640-70-9MLGadWrxO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23640 --- Comment #8 from David Cook <dcook at prosentient.com.au> --- (In reply to Jonathan Druart from comment #7) > It should be done for every connection I'd say, to make sure it's always > up-to-date. Do you know how long-lived the connections are? My concern is that the duration of a connection might be longer than we want an update window to be. I don't have enough SIP experience to know the answer to my question at this point though. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 00:27:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 23:27:57 +0000 Subject: [Koha-bugs] [Bug 23640] L1 cache too long in SIP Server In-Reply-To: <bug-23640-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23640-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23640-70-aa9GE0oNAY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23640 --- Comment #9 from David Cook <dcook at prosentient.com.au> --- (In reply to David Cook from comment #8) > I don't have enough SIP experience to know the answer to my question at this > point though. And it's not enough of a priority at the moment for me to gain that experience, so hoping that someone else knows. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 00:46:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 12 Nov 2019 23:46:47 +0000 Subject: [Koha-bugs] [Bug 23073] wiki.koha-community.org needs updating to a later version In-Reply-To: <bug-23073-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23073-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23073-70-i2iHFTbpxv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23073 --- Comment #14 from Thomas Dukleth <td-koha-bugs at agogme.com> --- There is much to report about MediaWiki encoding data for MySQL in binary form even in current versions of MediaWiki to compensate for the historic lack of proper UTF8 support in MySQL. I have some half started reports from weeks ago about how I needed to build a Debian old version time machine to create the MediaWiki binary tables properly for the version of MediaWiki from which we are upgrading. I will try to finish those reports when I am more awake. Meanwhile, I have been pressing on with automating the whole process and I should report something before falling asleep again. The following is the successful output from a script which I wrote to manage the steps of database migration with a friendly configuration file, much error checking, etc. There are still a few elements to add such as the initial pgrestore step and reading the configuration file from the Python script which does the data migration as distinct from the Perl script which manages most of the steps preparing for data migration and checks the results. "If you have reached this point without errors and you subsequently confirm that no errors or warnings have been logged, then the Koha MediaWiki database should have been successfully migrated.If you have reached this point without errors and you subsequently confirm that no errors or warnings have been logged, then the Koha MediaWiki database should have been successfully migrated. Remember that before any use MediaWiki and installed extensions must be migrated to a version supported by your PHP version andand MySQL version. Remember that before any use, MediaWiki and installed extensions must be upgraded to a version supported by your current PHP and MySQL versions." Depending on how awake I am later, I will test upgrading the test installation of MediaWiki and extensions to their current versions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 07:29:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 06:29:44 +0000 Subject: [Koha-bugs] [Bug 23985] The method Koha::Item-> is not covered by tests! In-Reply-To: <bug-23985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23985-70-RBgxsrxUUF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23985 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95339|0 |1 is obsolete| | --- Comment #2 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 95352 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95352&action=edit Bug 23985: (bug 21206 follow-up) Fix checkout list when "Hold pickup library match" not set This patch restores the behavior prior to bug 21206. If "Hold pickup library match" is "Not set", then hold_fulfillment_policy equals an empty string. Test plan: 1. Go to "Circulation and fines rules" 2. Under "Default checkout, hold and return policy", unset "Hold pickup library match" and Save 3. Place a hold on one item for one patron 4. Try to checkout the same item with another patron => Without this patch you the checkout list do not show, and the logs contain "The method Koha::Item-> is not covered by tests!" => With this patch applied you see the checkout list QA will take care of comparing the statement with the one before bug 21206 and make sure they are equivalent Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 07:30:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 06:30:29 +0000 Subject: [Koha-bugs] [Bug 23985] The method Koha::Item-> is not covered by tests! In-Reply-To: <bug-23985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23985-70-8icaR4PWqf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23985 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #3 from Julian Maurice <julian.maurice at biblibre.com> --- Works as expected. Thanks for the patch Jonathan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 07:54:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 06:54:01 +0000 Subject: [Koha-bugs] [Bug 23035] Intranet search is slow if thousands of items are in the biblios shown in the search results In-Reply-To: <bug-23035-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23035-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23035-70-MVJn645t4N@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23035 Andrew Nugged <nugged at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nugged at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 08:54:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 07:54:56 +0000 Subject: [Koha-bugs] [Bug 24027] New: Adding multiple items is slow Message-ID: <bug-24027-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24027 Bug ID: 24027 Summary: Adding multiple items is slow Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: nugged at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl In cataloguing/additem.pl?biblionumber=XXX when we choose "add multiple copies of the item" it's adds very slowly. I did analysis and there's one big inefficiency of calling ModZebra( $item->{biblionumber}, "specialUpdate", "biblioserver" ); in every AddItem call: it requests update for same biblionumber after adding each new item and time for execution of this ModZebra grows exponentially. My set of patches (preparatory + fix) I will provide here will make this call to ModZebra happen once in the end of adding of the whole number of these items once. Also I will attach a few smaller follow-up patches where I propose optimisations for extra operations. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 08:55:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 07:55:20 +0000 Subject: [Koha-bugs] [Bug 24027] Adding multiple items is slow In-Reply-To: <bug-24027-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24027-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24027-70-YnUkOfvZsz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24027 Andrew Nugged <nugged at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nugged at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 08:55:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 07:55:38 +0000 Subject: [Koha-bugs] [Bug 24027] Adding multiple items is slow In-Reply-To: <bug-24027-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24027-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24027-70-QiO5kH6Koo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24027 Andrew Nugged <nugged at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 09:17:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 08:17:34 +0000 Subject: [Koha-bugs] [Bug 23813] DB error on 18.12.00.020 In-Reply-To: <bug-23813-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23813-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23813-70-L6KYkgOCIf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23813 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|19.11.00 |19.11.00,19.05.05 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #11 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 19.05.x for 19.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 12:15:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 11:15:27 +0000 Subject: [Koha-bugs] [Bug 18930] Move 'refund lost item fee rules' into the `circulation_rules` table In-Reply-To: <bug-18930-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18930-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18930-70-7xzFh8tcpB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Move lost item refund rules |Move 'refund lost item fee |into the |rules' into the |`circulation_rules` table |`circulation_rules` table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 15:56:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 14:56:04 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-O7RDIjupA1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95398 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95398&action=edit Bug 23590: Add atomic update file -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 13:36:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 12:36:01 +0000 Subject: [Koha-bugs] [Bug 24027] Adding multiple items is slow In-Reply-To: <bug-24027-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24027-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24027-70-qJo5sACdRr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24027 --- Comment #9 from Andrew Nugged <nugged at gmail.com> --- > OpacMaxItemsToDisplay thought to make it configurable but hezitated :). Will be more brave then. Okay will use your vision and present rework for all the chain this week. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 11:17:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 10:17:23 +0000 Subject: [Koha-bugs] [Bug 24043] ILL module can't show requests from more than one backend In-Reply-To: <bug-24043-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24043-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24043-70-GaQng1ZReo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24043 --- Comment #1 from Magnus Enger <magnus at libriotech.no> --- Tested on 18.11.05. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 17:15:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 16:15:41 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-O3agd9hnTT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95318|0 |1 is obsolete| | --- Comment #28 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 95422 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95422&action=edit Bug 23590: Clean TT variables for patrons Just a bit of cleaning Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 21:52:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 20:52:28 +0000 Subject: [Koha-bugs] [Bug 9589] Authorities to authorities linker In-Reply-To: <bug-9589-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9589-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9589-70-EH4TZPFdhc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9589 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 17:55:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 16:55:07 +0000 Subject: [Koha-bugs] [Bug 23732] Hold rules checker: show matched rules and syspref values to help understand why a hold is possible or not In-Reply-To: <bug-23732-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23732-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23732-70-8wDbfmxQeU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 --- Comment #4 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- Created attachment 95444 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95444&action=edit Screen capture - position of "hold rule checker" button -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 13:25:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 12:25:26 +0000 Subject: [Koha-bugs] [Bug 23993] Can't call method "notforloan" on an undefined value at C4/Reserves.pm line 1177. In-Reply-To: <bug-23993-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23993-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23993-70-J21vakPH9G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23993 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21842 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 17:18:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 16:18:39 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-fIkv6I6emc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #38 from Séverine Queune <severine.queune at bulac.fr> --- Great development, thanks a lot Jonathan ! (In reply to Jonathan Druart from comment #25) > > On step 15 : I don't see the "managed date" on OPAC > > Looks ok for me: https://snipboard.io/KZ9bQS.jpg My bad, OpacSuggestionManagedBy needs to be enabled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 12:15:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 11:15:55 +0000 Subject: [Koha-bugs] [Bug 23035] Intranet search is slow if thousands of items are in the biblios shown in the search results In-Reply-To: <bug-23035-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23035-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23035-70-z2wTxoEZm3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23035 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- A quick and (hopefully) efficient change would be to replace the SELECT from authorised_values by a call to C4::Koha::GetAuthorisedValues (the cache is used there). -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 23:43:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 22:43:41 +0000 Subject: [Koha-bugs] [Bug 24034] Capitalization on suggestion edit form: No Status In-Reply-To: <bug-24034-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24034-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24034-70-wMFxusHMfq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24034 George Williams (NEKLS) <george at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org --- Comment #6 from George Williams (NEKLS) <george at nekls.org> --- +1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 17:56:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 16:56:48 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-1SBsNVVmQa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #25 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Séverine Queune from comment #22) > On step 8-9 : when I select a new manager, the checkbox to notify stays > disabled even if there is a valid email (I didn't notice that point on my > first tests and I correctly received an email at that moment, but I can't > reproduce it on my second tests) Fixed > On step 14 : the pop-up to select the new manager for several suggestions > only works on the first "Accepted" tab And fixed! > On step 15 : I don't see the "managed date" on OPAC Looks ok for me: https://snipboard.io/KZ9bQS.jpg -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 17:15:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 16:15:46 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-V2XUM2qXpc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95319|0 |1 is obsolete| | --- Comment #29 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 95423 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95423&action=edit Bug 23590: Cleaning - Remove op_* vars Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 12:30:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 11:30:44 +0000 Subject: [Koha-bugs] [Bug 24027] Adding multiple items is slow In-Reply-To: <bug-24027-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24027-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24027-70-Sf6sK7wx9B@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24027 --- Comment #5 from Andrew Nugged <nugged at gmail.com> --- Thanks Jonathan, > Only one thing, we will certainly reject the first patch, $dbh must be retrieved from C4::Context->dbh only. so I will rework in opposite direction, removing mine + old dbh in params: that > Also we prefer to have a hashref as parameters to make the flag explicit: > { postpone_indexes_update => 1 } yes, this is good coding style for not to seding unknown ", 1" or ", 0" in params :), thought about that but was afraid to announce it because it is more bigger change then (calling style from sequential params to hash with options). But both thumbs up for this! I will recreate now patches/chain, please then give feedback on last GUI change one: Bug 24027: (follow-up) Don't combine long items-add POST page with list generation ... so I will rework them in a batch :), and then I will ask for Sign-Off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 22:11:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 21:11:03 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12446-70-PsbNSDJcIU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 --- Comment #100 from Maryse Simard <maryse.simard at inlibro.com> --- Created attachment 95411 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95411&action=edit Bug 12446: (follow-up) Update for Bug 17168 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 17:55:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 16:55:39 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-cc0pVzZyyx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #24 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95408 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95408&action=edit Bug 23590: Fix select manager on list for all tabs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 11:39:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 10:39:15 +0000 Subject: [Koha-bugs] [Bug 23672] Dependency graph colours missing In-Reply-To: <bug-23672-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23672-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23672-70-Cx3fGvN3lZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23672 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95250|Display different colors on |[5.0.3] Display different description|the dependency graph |colors on the dependency | |graph -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 17:16:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 16:16:10 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-AvxVdYKu4U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95324|0 |1 is obsolete| | --- Comment #34 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 95428 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95428&action=edit Bug 23590: Add lastmodification by and date columns No tests are provided for the changes made to SearchSuggestion. It is going to be remove very soon as it is super ugly... Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 12:20:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 11:20:07 +0000 Subject: [Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes In-Reply-To: <bug-22563-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22563-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22563-70-1OydlfYbMN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Reports Note: The release notes| |`accounttype` for lost item | |fees has been updated from | |'L' and 'CR' to 'LOST' and | |the `status` field may now | |be populated with | |'UNRETURNED', '' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 17:55:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 16:55:16 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-4iimcZhTAB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95399|0 |1 is obsolete| | --- Comment #23 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95407 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95407&action=edit Bug 23590: Remove JS error on the suggestion list The notify option is only available from the edit view -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 13:24:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 12:24:34 +0000 Subject: [Koha-bugs] [Bug 23993] Can't call method "notforloan" on an undefined value at C4/Reserves.pm line 1177. In-Reply-To: <bug-23993-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23993-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23993-70-LnS8LHFhGJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23993 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Signed Off |In Discussion --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- See bug 21842 comment 12. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 17:15:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 16:15:51 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-elPrpzIrsS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95320|0 |1 is obsolete| | --- Comment #30 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 95424 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95424&action=edit Bug 23590: Batch update manager for suggestions Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 17:15:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 16:15:34 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-S91uIzbDyI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 11:38:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 10:38:57 +0000 Subject: [Koha-bugs] [Bug 23672] Dependency graph colours missing In-Reply-To: <bug-23672-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23672-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23672-70-b1zHSrzRjf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23672 --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95416 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95416&action=edit [5.0.6] Display different colors on the dependency graph -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 17:16:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 16:16:25 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-7H5IzZ0fYV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95420|0 |1 is obsolete| | --- Comment #37 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 95431 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95431&action=edit Bug 23590: DBIC Changes Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 13:34:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 12:34:40 +0000 Subject: [Koha-bugs] [Bug 24032] Creating a new serial in french version In-Reply-To: <bug-24032-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24032-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24032-70-nogWjjmO3n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24032 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Bonjour, In the 'en' template: 530 var mana_enabled = [% IF (Koha.Preference('Mana') == 1 && mana_url) %]1[% ELSE %]0[% END %]; In the French one: 514 var mana_enabled = [% IF (Koha.Preference('Mana') == 1 && mana_url) %]1[% ELSE %][% END %]; Same for the Spanish one. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 00:04:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 23:04:14 +0000 Subject: [Koha-bugs] [Bug 23101] Contracts permissions for staff patron In-Reply-To: <bug-23101-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23101-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23101-70-ZhLXwnP2HQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23101 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #13 from Lucas Gass <lucas at bywatersolutions.com> --- backported to 18.11.x for 18.11.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 12:52:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 11:52:56 +0000 Subject: [Koha-bugs] [Bug 23237] Add support for [% INCLUDE %] in plugin templates In-Reply-To: <bug-23237-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23237-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23237-70-nZJETO5sCa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23237 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |From a plugin template it release notes| |is useful to be able to | |include other templates | |with [% INCLUDE %] | |directives. But the TT | |module is used by Koha with | |absolute paths. Relative | |paths are forbidden for | |security reasons. A new | |param [% PLUGIN_DIR %] | |allow plugin templates to | |know where to find plugin | |home directory. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 13:35:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 12:35:16 +0000 Subject: [Koha-bugs] [Bug 24032] Cannot create a new serial in localized version In-Reply-To: <bug-24032-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24032-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24032-70-no387fzJOX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24032 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Creating a new serial in |Cannot create a new serial |french version |in localized version -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 17:16:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 16:16:16 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-GKL9wyfW3e@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95407|0 |1 is obsolete| | --- Comment #35 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 95429 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95429&action=edit Bug 23590: Remove JS error on the suggestion list The notify option is only available from the edit view Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 17:15:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 16:15:56 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-o2HSIhIR35@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95321|0 |1 is obsolete| | --- Comment #31 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 95425 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95425&action=edit Bug 23590: Only return patrons that have the suggestions_manage permission Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 13:38:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 12:38:34 +0000 Subject: [Koha-bugs] [Bug 23713] Subscription add form broken for translations In-Reply-To: <bug-23713-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23713-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23713-70-kZhG1uBOPe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23713 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Severity|major |critical -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 12:52:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 11:52:18 +0000 Subject: [Koha-bugs] [Bug 23237] Add support for [% INCLUDE %] in plugin templates In-Reply-To: <bug-23237-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23237-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23237-70-4ImtIbi6CK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23237 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Plugin allow [% INCLUDE %] |Add support for [% INCLUDE |from template |%] in plugin templates Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 12:49:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 11:49:54 +0000 Subject: [Koha-bugs] [Bug 23050] Add hook to add a tab in intranet biblio details page In-Reply-To: <bug-23050-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23050-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23050-70-KxoCnbmc4O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23050 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature Summary|Plugins: Add hook to add a |Add hook to add a tab in |tab in intranet biblio |intranet biblio details |details page |page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 23:52:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 22:52:04 +0000 Subject: [Koha-bugs] [Bug 24017] Search for year of birth In-Reply-To: <bug-24017-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24017-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24017-70-hFZdebNG2Q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24017 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|18.11 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 17:12:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 16:12:08 +0000 Subject: [Koha-bugs] [Bug 23593] Link between suggestion and bibliographic record on OPAC In-Reply-To: <bug-23593-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23593-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23593-70-KvG1leytRY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23593 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 12:16:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 11:16:29 +0000 Subject: [Koha-bugs] [Bug 21180] Allow Talking Tech outbound script to limit based on patron home library branchcode In-Reply-To: <bug-21180-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21180-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21180-70-S2iixDURrV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21180 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |Notices |and plumbing | CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 17:16:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 16:16:00 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-FpqRYWoUSx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95322|0 |1 is obsolete| | --- Comment #32 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 95426 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95426&action=edit Bug 23590: Add the ability to notify a new manager Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 12:49:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 11:49:32 +0000 Subject: [Koha-bugs] [Bug 22834] Add a method for plugins to return the absolute path for bundled files In-Reply-To: <bug-22834-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22834-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22834-70-58Q7VjVcyJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22834 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 10:36:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 09:36:16 +0000 Subject: [Koha-bugs] [Bug 21761] Koha::Object supports passing through 'update' which means we can side step 'set' + 'store' In-Reply-To: <bug-21761-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21761-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21761-70-XzdakErivN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21761 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_target, | |RM_priority -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 17:16:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 16:16:05 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-UuHKCivonq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95323|0 |1 is obsolete| | --- Comment #33 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 95427 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95427&action=edit Bug 23590: Display managed date in 'Your purchase suggestions' Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 00:07:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 23:07:49 +0000 Subject: [Koha-bugs] [Bug 23484] Holds to pull (pendingreserves.pl) uses removed default_branch_item_rules table In-Reply-To: <bug-23484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23484-70-rqHxbJ9dO1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23484 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #21 from Lucas Gass <lucas at bywatersolutions.com> --- missing dependency for 18.11.x, no backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 12:29:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 11:29:25 +0000 Subject: [Koha-bugs] [Bug 22709] Add hooks to notify plugins of biblio and item changes In-Reply-To: <bug-22709-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22709-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22709-70-V2TbJVUH7g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22709 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |Tools |and plumbing | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 17:15:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 16:15:37 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-KyoQNpi7rg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95317|0 |1 is obsolete| | --- Comment #27 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 95421 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95421&action=edit Bug 23590: Add ability to edit the manager of a suggestion Prior to this patch there was an hidden behavior that set the manager to the logged in user when a suggestion was edited. This patch proposes to let the librarian pick another manager. Other small adjustements will be added to polish this new behavior: * Create 2 new DB columns: suggestions.lastmodificationby and suggestion.lastmodificationdate * Choose a manager when editing a suggestion * Batch modify suggestions and set a manager for them * Let notify the new manager using the TO_PROCESS letter * Display the manageddate, lastmodificationby and lastmodificationdate info where appropriate This first patch adds a new "Select manager" link when editing a suggestion. Test plan for the whole patchset: 0/ a. Execute the update DB entry, generate the new DBIC file and restart all b. Create at least 2 patrons with the suggestions_manage permission 1/ Submit a new suggestion (OPAC or staff, not important) 2/ Accept it 3/ Edit it => "Last modification by" is empty => You see that you are the manager of this suggestion 4/ Click "Select manager" and search for a new manager => The patron search will only display patrons with the suggestions_manage permission 5/ Save 6/ Edit again => The manager is set to you, but there is a note saying that previously it was the patron you picked => The "Last modification by" is set to you 7/ Click "Keep existing manager" => The manager is now set to the previous manager 8/ Select another manager (which has a valid email address defined) 9/ Click the "notify" checkbox 10/ Save 11/ Confirm that a TO_PROCESS notice has been generated into the message_queue table 12/ Create at least one other suggestion 13/ List the suggestions => There is a 4th action column to assign a manager to several suggestions in one go. 14/ Use this new button and confirm that it works as expected 15/ Go to your purchase suggestion list (OPAC and staff) => You see the "managed date" displayed in a new column Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 17:13:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 16:13:12 +0000 Subject: [Koha-bugs] [Bug 14715] Results per page setting for catalog search in staff client and OPAC In-Reply-To: <bug-14715-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14715-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14715-70-lulIgcZmM9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14715 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_target CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 13:38:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 12:38:46 +0000 Subject: [Koha-bugs] [Bug 24032] Cannot create a new serial in localized version In-Reply-To: <bug-24032-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24032-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24032-70-F54b2Jo6p7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24032 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- *** This bug has been marked as a duplicate of bug 23713 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 17:17:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 16:17:18 +0000 Subject: [Koha-bugs] [Bug 23732] Hold rules checker: show matched rules and syspref values to help understand why a hold is possible or not In-Reply-To: <bug-23732-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23732-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23732-70-7XhO4dQBva@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 17:11:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 16:11:12 +0000 Subject: [Koha-bugs] [Bug 11808] When searching for a cardnumber in the intranet, also try to search for it on the LDAP server if one is configured and add/update user In-Reply-To: <bug-11808-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11808-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11808-70-bNxV80dVJi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11808 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 13:25:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 12:25:26 +0000 Subject: [Koha-bugs] [Bug 21842] always test Koha::ItemType in defined In-Reply-To: <bug-21842-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21842-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21842-70-5uuB0V2OkS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21842 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23993 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 17:12:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 16:12:12 +0000 Subject: [Koha-bugs] [Bug 23593] Link between suggestion and bibliographic record on OPAC In-Reply-To: <bug-23593-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23593-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23593-70-RqgeWglYZS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23593 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95351|0 |1 is obsolete| | --- Comment #2 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 95401 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95401&action=edit Bug 23593: Link to the bibliographic record from the suggestion (OPAC) If there is a link between a suggestion and a bibliographic record (ie. if suggestion.biblionumber is set), it makes sense to have an hyperlink on the suggestion list at the OPAC. Test plan: - Create 2 suggestions - Create an order from one of them - Go to the suggestion list at the OPAC => The one with the order has a to the bibliographic record => The other one is not linked with a bibliographic record, and so the title is displayed, without hyperlink Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 17:16:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 16:16:21 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-FlQVq4iTSh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95408|0 |1 is obsolete| | --- Comment #36 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 95430 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95430&action=edit Bug 23590: Fix select manager on list for all tabs Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 12:51:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 11:51:04 +0000 Subject: [Koha-bugs] [Bug 23213] Add hook to opac payments to allow plugins to set minimum payment threshold In-Reply-To: <bug-23213-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23213-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23213-70-QlOU9F3MFj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23213 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|OPAC check mimimum payment |Add hook to opac payments |threshold from payment |to allow plugins to set |plugin |minimum payment threshold -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 12:21:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 11:21:15 +0000 Subject: [Koha-bugs] [Bug 23035] Intranet search is slow if thousands of items are in the biblios shown in the search results In-Reply-To: <bug-23035-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23035-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23035-70-iAdpXY9VP1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23035 --- Comment #2 from Andrew Nugged <nugged at gmail.com> --- Because I am working with "Bug 24027" and also search/list is slow on slow machines as well, I can took over this replacement, > and (hopefully) efficient including testing for is it "hopefully", i.e. gives a boost, @Joonas, should I? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 17:54:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 16:54:52 +0000 Subject: [Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page In-Reply-To: <bug-12502-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12502-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12502-70-dn6W7mM7mV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 --- Comment #45 from Séverine Queune <severine.queune at bulac.fr> --- Thank you Maryse ! The new version is ok for me :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 12:22:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 11:22:18 +0000 Subject: [Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes In-Reply-To: <bug-22563-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22563-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22563-70-NormbPlEqO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Reports Note: The |Reports Note: The release notes|`accounttype` for lost item |`accounttype` for lost item |fees has been updated from |fees has been updated from |'L' and 'CR' to 'LOST' and |'L' to 'LOST' and for lost |the `status` field may now |item returned credits it |be populated with |has be updated from 'CR' to |'UNRETURNED', '' |'LOST_RETURNED'. The | |`status` field is now used | |to track -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 13:38:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 12:38:46 +0000 Subject: [Koha-bugs] [Bug 23713] Subscription add form broken for translations In-Reply-To: <bug-23713-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23713-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23713-70-I8AGr7g2TR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23713 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |library at iram.fr --- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- *** Bug 24032 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 13:54:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 12:54:54 +0000 Subject: [Koha-bugs] [Bug 24044] New: Cron keeps sending errors from advance_notices.pl, overdue_notices.pl, process_message_queue.pl Message-ID: <bug-24044-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24044 Bug ID: 24044 Summary: Cron keeps sending errors from advance_notices.pl, overdue_notices.pl, process_message_queue.pl Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Websites, Mailing Lists, etc Assignee: wizzyrea at gmail.com Reporter: b.pastern4k at gmail.com QA Contact: testopia at bugs.koha-community.org I tried setting up mail for Koha and set up crons for these files advance_notices.pl overdue_notices.pl process_message_queue.pl Each cron sends the same error message. unable to locate Koha configuration file koha-conf.xml at /usr/share/koha/lib/C4/Context.pm line 244. Use of uninitialized value in concatenation (.) or string at /usr/share/koha/lib/C4/Templates.pm line 154. unable to locate Koha configuration file koha-conf.xml at /usr/share/koha/lib/C4/Context.pm line 244. unable to locate Koha configuration file koha-conf.xml at /usr/share/koha/lib/C4/Context.pm line 244. Use of uninitialized value in concatenation (.) or string at /usr/share/koha/lib/C4/Auth_with_cas.pm line 42. unable to locate Koha configuration file koha-conf.xml at /usr/share/koha/lib/C4/Context.pm line 244. unable to locate Koha configuration file koha-conf.xml at /usr/share/koha/lib/C4/Context.pm line 244. unable to locate Koha configuration file koha-conf.xml at /usr/share/koha/lib/C4/Context.pm line 244. Can't call method "config" on unblessed reference at /usr/share/koha/lib/Koha/Database.pm line 56. I have just one koha instance on the server. What is the reason for this issue? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 08:58:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 07:58:34 +0000 Subject: [Koha-bugs] [Bug 13580] item circ history has 'last seen' labeled wrong In-Reply-To: <bug-13580-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13580-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13580-70-15YLss7AvM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13580 Ray Delahunty <r.delahunty at arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty at arts.ac.uk --- Comment #7 from Ray Delahunty <r.delahunty at arts.ac.uk> --- I would prefer the VERY LAST time the item was seen in any way by Koha show up in this screen via details.pl as it might help in searching etc. We have a record where Date last seen was showing the ISSUE date, and this puzzled a colleague. The items.datelastseen= 28/08/2019 (issue date - what details.pl showed), items.timestamp=13/11/2019 10:35 (the return date), old_issues.timestamp=13/11/2019 09:43 (probably the time the item was scanned by the puzzled staff member). I even had a look at statistics.timestamp at it showed 17/09/2019 22:04 (a renewal moment so not all that useful). In an inventory situation (but also generally), when Koha tells me the Date last seen, I expect it to be um... the date it was last seen! In this case I would prefer to see 13/11/2019 at 10:35. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 08:29:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 07:29:10 +0000 Subject: [Koha-bugs] [Bug 24047] New: Rename , Rearrange cataloging form fields Message-ID: <bug-24047-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24047 Bug ID: 24047 Summary: Rename , Rearrange cataloging form fields Change sponsored?: --- Product: Koha Version: 18.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: abhishekv at samanvayfoundation.org QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl I want to create a new MARC Structure with with limited fields, also want to rename and rearrange the required fields. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 08:58:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 07:58:45 +0000 Subject: [Koha-bugs] [Bug 19507] Add a sample CSV profile for exporting lost items In-Reply-To: <bug-19507-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19507-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19507-70-QWac4Km1wl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19507 Ray Delahunty <r.delahunty at arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty at arts.ac.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 08:53:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 07:53:00 +0000 Subject: [Koha-bugs] [Bug 23868] PayPal payment button is never enabled In-Reply-To: <bug-23868-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23868-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23868-70-EGs8SRD8F6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23868 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |RESOLVED CC| |fridolin.somers at biblibre.co | |m Resolution|--- |FIXED --- Comment #8 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Depends on Bug 23213 not in 19.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 08:33:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 07:33:56 +0000 Subject: [Koha-bugs] [Bug 23485] Holds to pull (pendingreserves.pl) should list barcodes In-Reply-To: <bug-23485-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23485-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23485-70-XapMX1nWro@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23485 Bug 23485 depends on bug 23484, which changed state. Bug 23484 Summary: Holds to pull (pendingreserves.pl) uses removed default_branch_item_rules table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23484 What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 08:33:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 07:33:56 +0000 Subject: [Koha-bugs] [Bug 23484] Holds to pull (pendingreserves.pl) uses removed default_branch_item_rules table In-Reply-To: <bug-23484-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23484-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23484-70-llQJCLMf62@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23484 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00,19.05.05 |19.11.00 released in| | Status|Pushed to stable |RESOLVED Resolution|--- |FIXED --- Comment #22 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Oups sorry Bug 18928 is not in 19.05.x, default_branch_item_rules still exists. so I revert -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 09:29:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 08:29:22 +0000 Subject: [Koha-bugs] [Bug 23398] Exporting/Reimporting frameworks in XML format will give incomplete results In-Reply-To: <bug-23398-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23398-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23398-70-YXBKO597XN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23398 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.05 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m --- Comment #11 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 19.05.x for 19.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 09:32:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 08:32:37 +0000 Subject: [Koha-bugs] [Bug 23713] Subscription add form broken for translations In-Reply-To: <bug-23713-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23713-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23713-70-hkpffCUAMf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23713 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|19.11.00 |19.11.00,19.05.05 released in| | --- Comment #20 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 19.05.x for 19.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 09:32:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 08:32:52 +0000 Subject: [Koha-bugs] [Bug 20919] A Zebra query is done for each item when opening a record detail page In-Reply-To: <bug-20919-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20919-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20919-70-BT3QKG1YGo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20919 mohamed <dali.bouazizi at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dali.bouazizi at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 14:37:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 13:37:02 +0000 Subject: [Koha-bugs] [Bug 23765] After TranslateNotices is set to 'Don't allow', email settings still show multiple languages In-Reply-To: <bug-23765-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23765-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23765-70-JBiGBO1ezp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23765 --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 17:28:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 16:28:35 +0000 Subject: [Koha-bugs] [Bug 23854] Cannot edit a suggestion In-Reply-To: <bug-23854-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23854-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23854-70-BAtCjkd3vP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23854 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 12:13:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 11:13:16 +0000 Subject: [Koha-bugs] [Bug 18930] Move lost item refund rules into the `circulation_rules` table In-Reply-To: <bug-18930-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18930-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18930-70-TgY54X4OOK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Move lost item refund rules |Move lost item refund rules |to circulation_rules table |into the | |`circulation_rules` table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 17:09:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 16:09:22 +0000 Subject: [Koha-bugs] [Bug 11808] When searching for a cardnumber in the intranet, also try to search for it on the LDAP server if one is configured and add/update user In-Reply-To: <bug-11808-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11808-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11808-70-QwH4qnjqkk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11808 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #60562|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 10:50:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 09:50:35 +0000 Subject: [Koha-bugs] [Bug 24029] New: marcrecord2csv.t displays a SQL error "Truncated incorrect DOUBLE value: '01e'" Message-ID: <bug-24029-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24029 Bug ID: 24029 Summary: marcrecord2csv.t displays a SQL error "Truncated incorrect DOUBLE value: '01e'" Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Blocks: 24002 t/db_dependent/Record/marcrecord2csv.t .. 1/12 DBD::mysql::db do failed: Truncated incorrect DOUBLE value: '01e' [for Statement "DELETE FROM marc_subfield_structure WHERE tagfield=998 and ( tagsubfield='8' or tagsubfield='9')"] at t/db_dependent/Record/marcrecord2csv.t line 104. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002 [Bug 24002] Test suite is failing on MySQL 8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 13:20:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 12:20:07 +0000 Subject: [Koha-bugs] [Bug 24026] Wrong parameters in Koha/Templates/Plugin/CirculationRules.pm and smart-rules.tt In-Reply-To: <bug-24026-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24026-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24026-70-kuUAbUnuuN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24026 --- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Nick Clemens from comment #7) > (In reply to Jonathan Druart from comment #3) > > See bug 22847. We should never call ->Search in this template, we want > > to display the values in the DB, not the calculated ones > > We should never call 'Get', we should always use 'Search' - I think just the > comment was wrong Move confusion, more fun! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 15:45:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 14:45:17 +0000 Subject: [Koha-bugs] [Bug 23854] Cannot edit a suggestion In-Reply-To: <bug-23854-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23854-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23854-70-MU3j0tVCIP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23854 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 17:25:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 16:25:31 +0000 Subject: [Koha-bugs] [Bug 21959] Batch item modification - ability to apply regular expression on text fields In-Reply-To: <bug-21959-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21959-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21959-70-Ap5qiZ7Xp0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21959 --- Comment #26 from Alex Arnaud <alex.arnaud at biblibre.com> --- Patch rebased -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 14:22:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 13:22:10 +0000 Subject: [Koha-bugs] [Bug 23765] After TranslateNotices is set to 'Don't allow', email settings still show multiple languages In-Reply-To: <bug-23765-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23765-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23765-70-JdxJBfEyDG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23765 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95306|0 |1 is obsolete| | --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 95375 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95375&action=edit Bug 23765: Do not display localized templates if TranslateNotices is off To test: 1. Enable multi-languages 2. Set the preference 'TranslateNotices' on 'Allow' 3. Go to: tools==>Notices & slips==>Edit, make sure it has multilingual email templates. 4. Set the preference TranslateNotices on 'Don't allow'. 5. Go to: tools==>Notices & slips==>Edit, the template shows several tab for the same transport type. 6. Apply the patch. 7. Repeat the steps 4 and 5 8. Success. It only shows the default template when TranslateNotices is 'Dont allow'. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 18:12:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 17:12:15 +0000 Subject: [Koha-bugs] [Bug 23854] Cannot edit a suggestion In-Reply-To: <bug-23854-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23854-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23854-70-NYkLM58OEg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23854 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95397|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95409 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95409&action=edit Bug 23854: Fix failure on dates when editing a suggestion - Watch plack-error-log - Change an accepted suggestion to 'No Status' - Verify error in the logs (use strict mode, depending on DBMS version) - Status changed was not saved - Apply patch - Verify the error is gone, change is saved now. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 17:24:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 16:24:35 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-HEpWZqj524@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #22 from Séverine Queune <severine.queune at bulac.fr> --- On step 8-9 : when I select a new manager, the checkbox to notify stays disabled even if there is a valid email (I didn't notice that point on my first tests and I correctly received an email at that moment, but I can't reproduce it on my second tests) On step 14 : the pop-up to select the new manager for several suggestions only works on the first "Accepted" tab On step 15 : I don't see the "managed date" on OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 14:26:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 13:26:20 +0000 Subject: [Koha-bugs] [Bug 24029] marcrecord2csv.t displays a SQL error "Truncated incorrect DOUBLE value: '01e'" In-Reply-To: <bug-24029-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24029-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24029-70-ejjd1eRR8b@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24029 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 12:22:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 11:22:08 +0000 Subject: [Koha-bugs] [Bug 23983] Contextualization of "Order" (verb) vs "Order" (noun) In-Reply-To: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23983-70-V91tL17QzD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23983 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95183|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95360 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95360&action=edit Bug 23983: Contextualization of 'Order' (verb) vs 'Order' (noun) This patch adds context (word class, either verb or noun) to the word 'Order' when it is displayed alone in the acquisitions module. The following files have been modified: basket.tt neworderbiblio.tt newordersubscription.tt newordersuggestion.tt ordered.tt parcel.tt spent.tt transferorder.tt uncertainprice.tt z3950_search.tt To test, check all those pages in English to make sure there is no change. 1- Go to Acquisitions 2- Create a basket 3- Add to basket from an existing record (neworderbiblio) 4- Add to basket from a subscription (newordersubscription) 5- Add to basket from a suggestion (newordersuggestion) 6- Add to basket from an external source (z3950_search) 7- In one of the orders, check the uncertain price box 8- Check the basket display table (basket) 9- Click transfer on one of the orders (transferorder) 10- Go to the vendor page and click on 'Uncertain prices' (uncertainprice) 11- Click on 'Receive parcel' (parcel) 12- Go to the Acquisitions home page and click on the amount for 'ordered' (ordered) 13- Go to the Acquisitions home page and click on the amount for 'spent' (spent) Next, install a new language (fr-CA used as example) 1- translate create fr-CA 2- open fr-CA-messages.po and add a translation for Order (verb) and Order (noun) (it doesn't have to be real, just write something different for each) 3- translate install fr-CA 4- in the system preferences, enable the french language in 'language' 5- change interface language to french Redo the tests above to make sure the word you put in the translation for the verb is in the places where 'Order' should be a verb and that the translation you put in for the noun is in the places where 'Order' should be a noun Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 14:26:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 13:26:25 +0000 Subject: [Koha-bugs] [Bug 24030] GetItemsForInventory failing with "ORDER BY clause is not in SELECT list" In-Reply-To: <bug-24030-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24030-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24030-70-gyu2iIt55W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24030 --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 12:49:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 11:49:21 +0000 Subject: [Koha-bugs] [Bug 22709] Add hooks to notify plugins of biblio and item changes In-Reply-To: <bug-22709-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22709-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22709-70-R2FIAXCFwf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22709 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 10:57:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 09:57:37 +0000 Subject: [Koha-bugs] [Bug 21261] OpacResults XSLT does not honor opachiddenitems In-Reply-To: <bug-21261-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21261-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21261-70-PdIC0Db6eQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21261 Ray Delahunty <r.delahunty at arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty at arts.ac.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 13:22:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 12:22:00 +0000 Subject: [Koha-bugs] [Bug 23932] Typo on 'aqinvoice_adjustments.encumber_open' description in Koha Schema In-Reply-To: <bug-23932-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23932-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23932-70-zzNr79aKeb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23932 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95359|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95374 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95374&action=edit Bug 23932: Typo on 'aqinvoice_adjustments.encumber_open' description in Koha Schema Correct a typo in Koha Schema comment. finds --> funds Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 17:28:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 16:28:25 +0000 Subject: [Koha-bugs] [Bug 23854] Cannot edit a suggestion In-Reply-To: <bug-23854-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23854-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23854-70-f2Ll8ETOcs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23854 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95316|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 14:26:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 13:26:24 +0000 Subject: [Koha-bugs] [Bug 24030] GetItemsForInventory failing with "ORDER BY clause is not in SELECT list" In-Reply-To: <bug-24030-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24030-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24030-70-6viMqBL568@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24030 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 11:56:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 10:56:43 +0000 Subject: [Koha-bugs] [Bug 24032] New: Creating a new serial in french version Message-ID: <bug-24032-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24032 Bug ID: 24032 Summary: Creating a new serial in french version Change sponsored?: --- Product: Koha Version: 19.05 Hardware: PC OS: Windows Status: NEW Severity: blocker Priority: P5 - low Component: Serials Assignee: koha-bugs at lists.koha-community.org Reporter: library at iram.fr QA Contact: testopia at bugs.koha-community.org CC: colin.campbell at ptfs-europe.com I have a bug in the french version of Koha 19.05.04. In the serials module, when I click on "recherche d'un fournisseur" (Search for a vendor) or on "Créer une notice" (create record), nothing happens: the pop-up doesn't appear. It's impossible to create a new serial. There is no problem when I work in the english interface. The bug appears only in the french one. Steps to reproduce: 1. Work in the french version 2. Try to create a new serial Version Koha : 19.05.04.000 Version de l'OS ('uname -a) : Linux library 4.9.0-11-amd64 #1 SMP Debian 4.9.189-3+deb9u1 (2019-09-20) x86_64 My PC runs on Windows 10 pro. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 12:22:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 11:22:13 +0000 Subject: [Koha-bugs] [Bug 23983] Contextualization of "Order" (verb) vs "Order" (noun) In-Reply-To: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23983-70-lcT0vHwUMq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23983 --- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95361 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95361&action=edit Bug 23983: Remove the comment from tt This comes from the example. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 10:51:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 09:51:08 +0000 Subject: [Koha-bugs] [Bug 23640] L1 cache too long in SIP Server In-Reply-To: <bug-23640-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23640-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23640-70-46V8i55Qar@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23640 --- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95415 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95415&action=edit Bug 23640: Flushing L1 on every SIP connection -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 20:56:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 19:56:26 +0000 Subject: [Koha-bugs] [Bug 19014] Patrons should not get an 'on_reserve' notification if the due date is far into the future In-Reply-To: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19014-70-eOZW4uxQfE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 12:30:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 11:30:37 +0000 Subject: [Koha-bugs] [Bug 24022] Z3950Responder tests are failing randomly In-Reply-To: <bug-24022-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24022-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24022-70-9Opz6FbTh7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24022 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95332|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95362 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95362&action=edit Bug 24022: Prevent Session2.t to fail if run after Session.t Cache must be cleaned! Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 10:52:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 09:52:06 +0000 Subject: [Koha-bugs] [Bug 23640] L1 cache too long in SIP Server In-Reply-To: <bug-23640-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23640-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23640-70-RAlijAQFWM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23640 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org --- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- David, here is a patch, I let you provide a test plan. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 22:40:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 21:40:28 +0000 Subject: [Koha-bugs] [Bug 24034] Capitalization on suggestion edit form: No Status In-Reply-To: <bug-24034-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24034-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24034-70-bOujRVi850@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24034 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95412|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 13:18:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 12:18:17 +0000 Subject: [Koha-bugs] [Bug 15976] Test bug for a script we are developing In-Reply-To: <bug-15976-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15976-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15976-70-yO2UYKFg7q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15976 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|test bug for a script we |Test bug for a script we |are developping. |are developing CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 15:37:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 14:37:45 +0000 Subject: [Koha-bugs] [Bug 24021] Koha allows creation of fines less than 1 cent, but not payment of those fines In-Reply-To: <bug-24021-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24021-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24021-70-zuV2uyTG2h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24021 Sally <sally.healey at cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 16:03:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 15:03:46 +0000 Subject: [Koha-bugs] [Bug 23900] Label maker cannot concatenate database fields In-Reply-To: <bug-23900-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23900-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23900-70-BDh5PgGtRC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23900 --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #3) > Hi Jonathan, could we have a regression test for this please? I tried but failed. I do not think the whole thing is tested at all. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 13:31:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 12:31:23 +0000 Subject: [Koha-bugs] [Bug 23640] L1 cache too long in SIP Server In-Reply-To: <bug-23640-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23640-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23640-70-8Kv0ivSgFQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23640 --- Comment #10 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** Bug 19740 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 14:50:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 13:50:38 +0000 Subject: [Koha-bugs] [Bug 24026] Wrong parameters in Koha/Templates/Plugin/CirculationRules.pm and smart-rules.tt In-Reply-To: <bug-24026-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24026-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24026-70-uESmNgdPEV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24026 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 13:16:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 12:16:28 +0000 Subject: [Koha-bugs] [Bug 24000] Some modules does not return 1 In-Reply-To: <bug-24000-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24000-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24000-70-VkJ5lnPmom@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24000 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA Summary|Koha::Item::Search::Field |Some modules does not |does not return 1 |return 1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 12:39:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 11:39:38 +0000 Subject: [Koha-bugs] [Bug 24026] Wrong parameters in Koha/Templates/Plugin/CirculationRules.pm and smart-rules.tt In-Reply-To: <bug-24026-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24026-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24026-70-kC0KZxWilA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24026 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |critical --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Upping severity. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 23:31:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 22:31:52 +0000 Subject: [Koha-bugs] [Bug 22804] OPAC Overdrive JavaScript contains untranslatable strings In-Reply-To: <bug-22804-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22804-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22804-70-1Xmx8KnqN5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22804 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> --- backported to 18.11.x for 18.11.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 19:36:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 18:36:44 +0000 Subject: [Koha-bugs] [Bug 23982] Count/pagination broken for reports with duplicated column names In-Reply-To: <bug-23982-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23982-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23982-70-PIMZK8HNBY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23982 --- Comment #3 from Nick Clemens <nick at bywatersolutions.com> --- I think if we can make a sensible error back to the user about deduplicating the names we would be okay. Ideally we would also make basic pagination work, just assumign 10 pages, and again having a friendly error if they page out of bounds -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 12:10:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 11:10:34 +0000 Subject: [Koha-bugs] [Bug 23677] Add API route to get a bibliographic record In-Reply-To: <bug-23677-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23677-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23677-70-fWwbKVIFpR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23677 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add route to get a |Add API route to get a |bibliographic record |bibliographic record -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 15:22:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 14:22:29 +0000 Subject: [Koha-bugs] [Bug 21507] Decimal separators issues in patrons payments/fines, simplified In-Reply-To: <bug-21507-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21507-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21507-70-S6nBFjsUYt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21507 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |arthur.suzuki at biblibre.com --- Comment #2 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- Here is a SQL query which helps detecting incoherences in the account lines. SELECT invoicenumber, link.ordernumber, items.itemnumber, unitprice, unitprice_tax_excluded, unitprice_tax_included, items.price, ecost, unitprice_tax_excluded/ecost as ratio FROM aqorders LEFT JOIN aqinvoices ON aqinvoices.invoiceid = aqorders.invoiceid LEFT JOIN aqorders_items as link ON link.ordernumber=aqorders.ordernumber LEFT JOIN items ON link.itemnumber=items.itemnumber WHERE unitprice/ecost > 5 OR unitprice_tax_excluded/ecost > 5 OR items.price/ecost > 5 ORDER BY ratio DESC; -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 20:56:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 19:56:15 +0000 Subject: [Koha-bugs] [Bug 19014] Patrons should not get an 'on_reserve' notification if the due date is far into the future In-Reply-To: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19014-70-WDVRp1BfAJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 14:22:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 13:22:04 +0000 Subject: [Koha-bugs] [Bug 23765] After TranslateNotices is set to 'Don't allow', email settings still show multiple languages In-Reply-To: <bug-23765-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23765-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23765-70-NP29WqaXvb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23765 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 16:45:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 15:45:07 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-8QJbc2mMD4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #26 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95420 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95420&action=edit Bug 23590: DBIC Changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 17:26:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 16:26:55 +0000 Subject: [Koha-bugs] [Bug 21959] Batch item modification - ability to apply regular expression on text fields In-Reply-To: <bug-21959-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21959-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21959-70-aReUZVt8s0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21959 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 16:40:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 15:40:43 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-yYz6YhYluW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #21 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95399 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95399&action=edit Bug 23590: Remove JS error on the suggestion list The notify option is only available from the edit view -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 12:39:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 11:39:46 +0000 Subject: [Koha-bugs] [Bug 23983] Contextualization of "Order" (verb) vs "Order" (noun) In-Reply-To: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23983-70-TygOaxAlXq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23983 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95360|0 |1 is obsolete| | --- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 95367 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95367&action=edit Bug 23983: Contextualization of 'Order' (verb) vs 'Order' (noun) This patch adds context (word class, either verb or noun) to the word 'Order' when it is displayed alone in the acquisitions module. The following files have been modified: basket.tt neworderbiblio.tt newordersubscription.tt newordersuggestion.tt ordered.tt parcel.tt spent.tt transferorder.tt uncertainprice.tt z3950_search.tt To test, check all those pages in English to make sure there is no change. 1- Go to Acquisitions 2- Create a basket 3- Add to basket from an existing record (neworderbiblio) 4- Add to basket from a subscription (newordersubscription) 5- Add to basket from a suggestion (newordersuggestion) 6- Add to basket from an external source (z3950_search) 7- In one of the orders, check the uncertain price box 8- Check the basket display table (basket) 9- Click transfer on one of the orders (transferorder) 10- Go to the vendor page and click on 'Uncertain prices' (uncertainprice) 11- Click on 'Receive parcel' (parcel) 12- Go to the Acquisitions home page and click on the amount for 'ordered' (ordered) 13- Go to the Acquisitions home page and click on the amount for 'spent' (spent) Next, install a new language (fr-CA used as example) 1- translate create fr-CA 2- open fr-CA-messages.po and add a translation for Order (verb) and Order (noun) (it doesn't have to be real, just write something different for each) 3- translate install fr-CA 4- in the system preferences, enable the french language in 'language' 5- change interface language to french Redo the tests above to make sure the word you put in the translation for the verb is in the places where 'Order' should be a verb and that the translation you put in for the noun is in the places where 'Order' should be a noun Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 14:10:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 13:10:50 +0000 Subject: [Koha-bugs] [Bug 23932] Typo on 'aqinvoice_adjustments.encumber_open' description in Koha Schema In-Reply-To: <bug-23932-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23932-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23932-70-5BzTY0tWtW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23932 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 20:57:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 19:57:34 +0000 Subject: [Koha-bugs] [Bug 23908] Require patrons to confirm their email address In-Reply-To: <bug-23908-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23908-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23908-70-1cD0De7fge@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23908 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_target -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 17:08:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 16:08:48 +0000 Subject: [Koha-bugs] [Bug 23592] Link between suggestion and bibliographic record on staff client In-Reply-To: <bug-23592-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23592-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23592-70-mhBFfxxWWG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23592 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 12:30:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 11:30:43 +0000 Subject: [Koha-bugs] [Bug 24022] Z3950Responder tests are failing randomly In-Reply-To: <bug-24022-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24022-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24022-70-7nnThGYLMa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24022 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95336|0 |1 is obsolete| | --- Comment #8 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95364 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95364&action=edit Bug 24022: Try to fix 'connect failed' I am assuming that the tests fail on Jenkins's nodes because they are too slow. The server is not setup yet when we are trying to access it. Just a guess... Note that sleep is usually a bad idea... Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 12:41:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 11:41:50 +0000 Subject: [Koha-bugs] [Bug 24000] Koha::Item::Search::Field does not return 1 In-Reply-To: <bug-24000-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24000-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24000-70-uFzuhJZzcA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24000 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Is it the only one? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 17:08:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 16:08:51 +0000 Subject: [Koha-bugs] [Bug 23592] Link between suggestion and bibliographic record on staff client In-Reply-To: <bug-23592-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23592-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23592-70-cEQwZB1nmQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23592 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95350|0 |1 is obsolete| | --- Comment #3 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 95400 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95400&action=edit Bug 23592: Link to the bibliographic record from the suggestion If there is a link between a suggestion and a bibliographic record (ie. if suggestion.biblionumber is set), it makes sense to have an hyperlink on the suggestion detail page. Test plan: - Create 2 suggestions - Create an order from one of them - Go to the detail page of the suggestion => The one with the order has a to the bibliographic record => The other one is not linked with a bibliographic record, and so the title is displayed, without hyperlink Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 16:22:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 15:22:19 +0000 Subject: [Koha-bugs] [Bug 24024] Holds Awaiting Pickup (Both Active and Expired) Sorts by Firstname In-Reply-To: <bug-24024-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24024-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24024-70-nqZk8ObTz1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24024 Holly <hc at interleaf.ie> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hc at interleaf.ie --- Comment #2 from Holly <hc at interleaf.ie> --- Hi, Can I just check how to test this change so the bug can be signed off? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 12:28:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 11:28:42 +0000 Subject: [Koha-bugs] [Bug 22847] Specific circ rule by patron category is displaying the default (or not displaying) In-Reply-To: <bug-22847-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22847-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22847-70-nw6Pqt2ln9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22847 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24026 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24026 [Bug 24026] Wrong parameters in Koha/Templates/Plugin/CirculationRules.pm and smart-rules.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 14:24:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 13:24:40 +0000 Subject: [Koha-bugs] [Bug 23713] Subscription add form broken for translations In-Reply-To: <bug-23713-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23713-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23713-70-MfAIWRaQ9V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23713 --- Comment #19 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Katrin Fischer from comment #14) > Hi all, this is a major bug confirmed in 18.11 - can this please be > backported? That should read 19.05 - as 18.11 has no Mana, this only needs to go in 19.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 12:22:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 11:22:04 +0000 Subject: [Koha-bugs] [Bug 23983] Contextualization of "Order" (verb) vs "Order" (noun) In-Reply-To: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23983-70-eECXU0LGJP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23983 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 23:43:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 22:43:10 +0000 Subject: [Koha-bugs] [Bug 23688] System preference uppercasesurnames broken by typo In-Reply-To: <bug-23688-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23688-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23688-70-OdjW530Vsr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23688 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com Status|Pushed to stable |Pushed to oldstable --- Comment #8 from Lucas Gass <lucas at bywatersolutions.com> --- backported to 18.11.x for 18.11.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 15:48:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 14:48:19 +0000 Subject: [Koha-bugs] [Bug 23900] Label maker cannot concatenate database fields In-Reply-To: <bug-23900-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23900-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23900-70-wWGjfJ4fLD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23900 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Jonathan, could we have a regression test for this please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 14:50:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 13:50:20 +0000 Subject: [Koha-bugs] [Bug 24026] Wrong parameters in Koha/Templates/Plugin/CirculationRules.pm and smart-rules.tt In-Reply-To: <bug-24026-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24026-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24026-70-UHix4qZ9eF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24026 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95369|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95386 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95386&action=edit Bug 24026: (bug 22847 follow-up) Remove c/p issues Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 13:20:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 12:20:47 +0000 Subject: [Koha-bugs] [Bug 17498] Expose system preference values to JavaScript in the OPAC In-Reply-To: <bug-17498-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17498-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17498-70-hitqqbASer@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17498 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I agree it should be a 'whitelist' for the OPAC related features if we do this - some of the preferences might contain critical information. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 14:26:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 13:26:04 +0000 Subject: [Koha-bugs] [Bug 24030] GetItemsForInventory failing with "ORDER BY clause is not in SELECT list" In-Reply-To: <bug-24030-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24030-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24030-70-BwBBegSxhj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24030 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 12:12:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 11:12:32 +0000 Subject: [Koha-bugs] [Bug 18928] Move `holdallowed`, `hold_fulfillment_policy` and `returnbranch` into `circulation_rules` In-Reply-To: <bug-18928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18928-70-nxmtrcBgRi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Move holdallowed, |Move `holdallowed`, |hold_fulfillment_policy, |`hold_fulfillment_policy` |returnbranch to |and `returnbranch` into |circulation_rules |`circulation_rules` -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 10:08:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 09:08:52 +0000 Subject: [Koha-bugs] [Bug 24028] New: bug in calorie mama application, baseball ball is recognized as an egg Message-ID: <bug-24028-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24028 Bug ID: 24028 Summary: bug in calorie mama application, baseball ball is recognized as an egg Change sponsored?: --- Product: Koha Version: unspecified Hardware: Macintosh OS: Mac OS Status: NEW Severity: normal Priority: P4 Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: taghreed.alzahrani at sjsu.edu QA Contact: testopia at bugs.koha-community.org Created attachment 95353 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95353&action=edit baseball ball is recognized as an egg, and other kind of ball is also recognized as an egg prerequisites: you have Calorie Mama application step to reproduce: actual results expected results -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 14:25:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 13:25:54 +0000 Subject: [Koha-bugs] [Bug 24030] GetItemsForInventory failing with "ORDER BY clause is not in SELECT list" In-Reply-To: <bug-24030-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24030-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24030-70-AQkljTP66S@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24030 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95357|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95378 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95378&action=edit Bug 24030: Fix GetItemsForInventory under MySQL 8 t/db_dependent/Items/GetItemsForInventory.t .. 1/9 DBD::mysql::st execute failed: Expression #1 of ORDER BY clause is not in SELECT list, references column 'koha_kohadev.items.cn_sort' which is not in SELECT list; this is incompatible with DISTINCT [for Statement " SELECT DISTINCT(items.itemnumber), barcode, itemcallnumber, title, author, biblio.biblionumber, biblio.frameworkcode, datelastseen, homebranch, location, notforloan, damaged, itemlost, withdrawn, stocknumber FROM items LEFT JOIN biblio ON items.biblionumber = biblio.biblionumber LEFT JOIN biblioitems on items.biblionumber = biblioitems.biblionumber ORDER BY items.cn_sort, itemcallnumber, title"] at /kohadevbox/koha/C4/Items.pm line 838. We simply follow what the error says, and add items.cn_sort to the SELECT list Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 20:56:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 19:56:57 +0000 Subject: [Koha-bugs] [Bug 23975] Add ability to search and install plugins from GitHub In-Reply-To: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23975-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23975-70-wXtvoC0eOs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23975 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 10:50:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 09:50:35 +0000 Subject: [Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8 In-Reply-To: <bug-24002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24002-70-mTWmMC8ms8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24029 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24029 [Bug 24029] marcrecord2csv.t displays a SQL error "Truncated incorrect DOUBLE value: '01e'" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 10:58:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 09:58:58 +0000 Subject: [Koha-bugs] [Bug 17921] Shelf Browser does not take OpacSuppression or OpacHiddenItems into consideration In-Reply-To: <bug-17921-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17921-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17921-70-ydSTeaScKM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17921 Ray Delahunty <r.delahunty at arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty at arts.ac.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 14:22:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 13:22:34 +0000 Subject: [Koha-bugs] [Bug 24029] marcrecord2csv.t displays a SQL error "Truncated incorrect DOUBLE value: '01e'" In-Reply-To: <bug-24029-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24029-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24029-70-CxIKXYsbUw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24029 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95355|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95376 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95376&action=edit Bug 24029: Remove "Truncated incorrect DOUBLE value: '01e'" from marcrecord2csv.t marc_subfield_structure.tagfield is a varchar(3) Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 13:33:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 12:33:49 +0000 Subject: [Koha-bugs] [Bug 23640] L1 cache too long in SIP Server In-Reply-To: <bug-23640-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23640-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23640-70-UzV4Gemb2l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23640 --- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Katrin Fischer from comment #5) > We also do nightly restarts, but it would be much nicer if it worked > immediately. The problem occurs for example, when the calendar is changed, > but it doesn't show on the self check immediately. (due dates calculated > differently than at the circ desk). Bug 19740 I filed a while ago could be a > possible duplicate? I marked my original bug duplicate. I would really like to see this fixed and pondering an update to 'major' - different due dates between circ and self check and other different behaviour are not good and hard to 'debug' for circ staff. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 23:40:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 22:40:04 +0000 Subject: [Koha-bugs] [Bug 22804] OPAC Overdrive JavaScript contains untranslatable strings In-Reply-To: <bug-22804-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22804-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22804-70-Bjq5HfZ2Nq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22804 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 12:03:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 11:03:16 +0000 Subject: [Koha-bugs] [Bug 23517] Add API route to update a holds priority In-Reply-To: <bug-23517-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23517-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23517-70-uKMdGtWjbM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23517 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add |Add API route to update a |/holds/{hold_id}/priority |holds priority |route (PUT) | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 13:16:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 12:16:09 +0000 Subject: [Koha-bugs] [Bug 24000] Koha::Item::Search::Field does not return 1 In-Reply-To: <bug-24000-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24000-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24000-70-mI9rv9sJv8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24000 --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- % perl -0777 -nlwE 'say $ARGV if !/\n1/i' **/*.pm Koha/Filter/MARC/EmbedItemsAvailability.pm Koha/Filter/MARC/EmbedSeeFromHeadings.pm Koha/Filter/MARC/Null.pm Koha/Item/Search/Field.pm Koha/SearchEngine.pm misc/translator/VerboseWarnings.pm t/lib/Koha/Plugin/Test.pm I think we should fix them all in one go. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 12:39:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 11:39:50 +0000 Subject: [Koha-bugs] [Bug 23983] Contextualization of "Order" (verb) vs "Order" (noun) In-Reply-To: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23983-70-pJlKuH1RIj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23983 --- Comment #14 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 95368 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95368&action=edit Bug 23983: Remove comment I think we can do without the comment - suggesting removal with this patch. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 13:31:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 12:31:23 +0000 Subject: [Koha-bugs] [Bug 19740] Self checks calculating wrong due dates / configuration changes go unnoticed In-Reply-To: <bug-19740-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19740-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19740-70-lafTnbhcb0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19740 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** This bug has been marked as a duplicate of bug 23640 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 12:02:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 11:02:14 +0000 Subject: [Koha-bugs] [Bug 17003] Add AP route to get checkout's renewability In-Reply-To: <bug-17003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17003-70-1HqELxLOJC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17003 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|REST API: add route to get |Add AP route to get |checkout's renewability |checkout's renewability -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 14:20:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 13:20:11 +0000 Subject: [Koha-bugs] [Bug 24022] Z3950Responder tests are failing randomly In-Reply-To: <bug-24022-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24022-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24022-70-olqcrAk1nk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24022 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 16:26:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 15:26:53 +0000 Subject: [Koha-bugs] [Bug 20948] Hold requests on detail.pl In-Reply-To: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20948-70-oFzrE03iB1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 --- Comment #6 from Christopher Brannon <cbrannon at cdalibrary.org> --- (In reply to Jonathan Druart from comment #5) > I would be happy to have a look at this one if someone can provide a > step-by-step plan to recreate the problem. Place several next available holds on a single item record. Then place an item level hold on the item. Look at the detail.pl page. The item will show the item level hold. Many staff interpret this to mean this is where the hold is going next. It is preferred if it just said "There is an item level hold on this item", without any specific details. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 14:24:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 13:24:57 +0000 Subject: [Koha-bugs] [Bug 24030] GetItemsForInventory failing with "ORDER BY clause is not in SELECT list" In-Reply-To: <bug-24030-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24030-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24030-70-wvgYu4e91T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24030 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Good catch, obvious corrections. Passing QA and Pushing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 14:00:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 13:00:41 +0000 Subject: [Koha-bugs] [Bug 23680] Can't open 'Edit items' or 'Add item' links in new tab - tab is closed immediately In-Reply-To: <bug-23680-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23680-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23680-70-pdGMSzsuwX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23680 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #12 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 19.05.x for 19.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 14:10:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 13:10:52 +0000 Subject: [Koha-bugs] [Bug 23932] Typo on 'aqinvoice_adjustments.encumber_open' description in Koha Schema In-Reply-To: <bug-23932-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23932-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23932-70-GiQZj7oMEk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23932 --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 13:19:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 12:19:46 +0000 Subject: [Koha-bugs] [Bug 24026] Wrong parameters in Koha/Templates/Plugin/CirculationRules.pm and smart-rules.tt In-Reply-To: <bug-24026-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24026-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24026-70-9Gm3VehshW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24026 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95370|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95373 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95373&action=edit Bug 24026: (bug 22847 follow-up) Display correctly max[onsite]issueqty (not the propagated ones) See bug 22847. We should never call ->Get in this template, we want to display the values in the DB, not the calculated ones Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 22:55:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 21:55:19 +0000 Subject: [Koha-bugs] [Bug 24034] Capitalization on suggestion edit form: No Status In-Reply-To: <bug-24034-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24034-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24034-70-t4wybkjxmU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24034 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 14:21:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 13:21:42 +0000 Subject: [Koha-bugs] [Bug 24029] marcrecord2csv.t displays a SQL error "Truncated incorrect DOUBLE value: '01e'" In-Reply-To: <bug-24029-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24029-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24029-70-iDNQBnO8qr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24029 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 17:29:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 16:29:03 +0000 Subject: [Koha-bugs] [Bug 23854] Cannot edit a suggestion In-Reply-To: <bug-23854-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23854-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23854-70-khbeIIYmEg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23854 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|martin.renvoize at ptfs-europe |testopia at bugs.koha-communit |.com |y.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 14:37:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 13:37:00 +0000 Subject: [Koha-bugs] [Bug 23765] After TranslateNotices is set to 'Don't allow', email settings still show multiple languages In-Reply-To: <bug-23765-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23765-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23765-70-CxbIVDrSpU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23765 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 14:50:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 13:50:24 +0000 Subject: [Koha-bugs] [Bug 24026] Wrong parameters in Koha/Templates/Plugin/CirculationRules.pm and smart-rules.tt In-Reply-To: <bug-24026-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24026-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24026-70-EAQ7XNcTfp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24026 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95373|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95387 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95387&action=edit Bug 24026: (bug 22847 follow-up) Display correctly max[onsite]issueqty (not the propagated ones) See bug 22847. We should never call ->Get in this template, we want to display the values in the DB, not the calculated ones Signed-off-by: Nick Clemens <nick at bywatersolutions.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 10:52:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 09:52:30 +0000 Subject: [Koha-bugs] [Bug 23029] OPAC Authorities Search. Internal Server Error. Free-floating subdivisions imported from LOC In-Reply-To: <bug-23029-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23029-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23029-70-Vcj3YxxMEO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23029 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95354 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95354&action=edit Bug 23029: Remove "Truncated incorrect DOUBLE value: '01e'" from marcrecord2csv.t marc_subfield_structure.tagfield is a varchar(3) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 10:52:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 09:52:27 +0000 Subject: [Koha-bugs] [Bug 23029] OPAC Authorities Search. Internal Server Error. Free-floating subdivisions imported from LOC In-Reply-To: <bug-23029-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23029-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23029-70-U0awsIvBgJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23029 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 12:10:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 11:10:18 +0000 Subject: [Koha-bugs] [Bug 23932] Typo on 'aqinvoice_adjustments.encumber_open' description in Koha Schema In-Reply-To: <bug-23932-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23932-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23932-70-QxZuFIxg16@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23932 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 15:50:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 14:50:10 +0000 Subject: [Koha-bugs] [Bug 23918] Search results incorrect for multiple vowel words In-Reply-To: <bug-23918-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23918-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23918-70-bgtZNjlbRh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23918 --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Bernard from comment #6) > You were right! Commenting out > equivalent ō(oo) > did the trick for that example. > > Unfortunately, there may be similar problems for other vowel combinations. eg > aa ("aachen" brings up "aachen" and "achen") > > > I am assuming > equivalent ā(aa) > > might be the one to comment out for that, but of course it means those > diacritics are not properly mapped then if they should ever genuinely come > up. A library reported this to us and we decided together that we won't change it... too worried about side effects for other searches, especially if you have records in multiple languages where these might appear... -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 10:51:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 09:51:04 +0000 Subject: [Koha-bugs] [Bug 23640] L1 cache too long in SIP Server In-Reply-To: <bug-23640-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23640-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23640-70-Kfac2UnvQ9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23640 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 20:54:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 19:54:45 +0000 Subject: [Koha-bugs] [Bug 23767] Spent and Ordered total values don't include child funds on acqui-home In-Reply-To: <bug-23767-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23767-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23767-70-xIsNHiFadD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23767 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_19_11_candidate |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 12:00:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 11:00:42 +0000 Subject: [Koha-bugs] [Bug 22581] Add support for Plaine & Easie musical incipits rendering in OPAC In-Reply-To: <bug-22581-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22581-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22581-70-gmPYyWCPI1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22581 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This development adds release notes| |support for displaying | |Plaine & Easie musical | |incipits in the OPAC. With | |this feature enabled, when | |a cataloguer adds incipits | |codes to the 031 MARC21 | |fields they will display as | |musical scores and | |optionally include a short | |audio clip. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 23:40:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 22:40:28 +0000 Subject: [Koha-bugs] [Bug 24006] Switching on QueryWeightFields (relevance ranking) breaks search In-Reply-To: <bug-24006-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24006-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24006-70-rUfvC8nSWj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24006 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- It should do some kind of relevance ranking without. Debugging search issues is hard, but what I would recommend is doing your testing again with and without QueryAutoTruncate - there is a known bug of it breaking relevance. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 14:26:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 13:26:22 +0000 Subject: [Koha-bugs] [Bug 24029] marcrecord2csv.t displays a SQL error "Truncated incorrect DOUBLE value: '01e'" In-Reply-To: <bug-24029-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24029-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24029-70-PTHjGDWYDM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24029 --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 12:02:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 11:02:24 +0000 Subject: [Koha-bugs] [Bug 17003] Add API route to get checkout's renewability In-Reply-To: <bug-17003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17003-70-LGSyDU0tTE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17003 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add AP route to get |Add API route to get |checkout's renewability |checkout's renewability -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 14:25:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 13:25:51 +0000 Subject: [Koha-bugs] [Bug 24030] GetItemsForInventory failing with "ORDER BY clause is not in SELECT list" In-Reply-To: <bug-24030-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24030-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24030-70-XcuTT49xnj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24030 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95356|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95377 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95377&action=edit Bug 24030: Remove OldWay comparaison from GetItemsForInventory.t This has been introduced to make sure there were no regression at a given point. But now we are fixing the "old way" so it does not make sense to keep it any longer Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 13:21:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 12:21:56 +0000 Subject: [Koha-bugs] [Bug 23932] Typo on 'aqinvoice_adjustments.encumber_open' description in Koha Schema In-Reply-To: <bug-23932-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23932-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23932-70-MdfCZPh1ax@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23932 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 18:12:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 17:12:58 +0000 Subject: [Koha-bugs] [Bug 23854] Cannot edit a suggestion In-Reply-To: <bug-23854-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23854-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23854-70-BqihVEpgil@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23854 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Thanks guys, all works for me here. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 16:39:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 15:39:53 +0000 Subject: [Koha-bugs] [Bug 24035] New: When recording local use, there is no alert for holds Message-ID: <bug-24035-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24035 Bug ID: 24035 Summary: When recording local use, there is no alert for holds Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com One way of recording local use is through a statistical patron. Checking an item out to a statistical patron records a local use but does not actually check the item out. However, if the item is on hold, there is no indication that it is so, since the item doesn't go through the checkout process. But since the staff is already processing the item to scan it for local use, I feel like it would be logical to alert them that there is a hold on this item. To reproduce: 1- Create a statistical patron category 1.1- Go to Administration > Patron categories 1.2- Create a new patron category 1.3- Fill in the code, description and expiry date 1.4- In the 'Category type' field, choose 'Statistical' 1.5- Save 2- Create a patron of that category 3- Place a hold on an item (for another patron) 4- Check out the item to the statistical patron => It says 'Local use recorded' but there is no pop-up saying the item is on hold -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 12:30:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 11:30:34 +0000 Subject: [Koha-bugs] [Bug 24022] Z3950Responder tests are failing randomly In-Reply-To: <bug-24022-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24022-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24022-70-T4SzxE2PSu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24022 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 22:55:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 21:55:25 +0000 Subject: [Koha-bugs] [Bug 24034] Capitalization on suggestion edit form: No Status In-Reply-To: <bug-24034-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24034-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24034-70-2bFIxtJNWz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24034 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95442|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 95447 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95447&action=edit Bug 24034: Capitalization on suggestion edit form: No Status When editing a purchase suggestion, the "No status" option in the status pulldown is incorrectly capatalized. This patch fixes the capitazliation. To test: 1) Create a purchase suggestion in the acquisitions module. 2) Edit the suggestion. Notice the capitalization in the status dropdown is incorrect. 3) Apply the patch. 4) Repeat step 2. 5) Note the capitalization has been fixed. 6) Sign off. Signed-off-by: George Williams <george at nekls.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 16:48:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 15:48:42 +0000 Subject: [Koha-bugs] [Bug 23589] Discharge notice does not show non-latin characters In-Reply-To: <bug-23589-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23589-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23589-70-F9fBJrilYN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23589 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.05 released in| | --- Comment #17 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 19.05.x for 19.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 12:28:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 11:28:42 +0000 Subject: [Koha-bugs] [Bug 24026] Wrong parameters in Koha/Templates/Plugin/CirculationRules.pm and smart-rules.tt In-Reply-To: <bug-24026-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24026-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24026-70-ZEyc1yrVZV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24026 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org Depends on| |22847 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- ARG! Impossible, I never copy paste, never! Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22847 [Bug 22847] Specific circ rule by patron category is displaying the default (or not displaying) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 12:09:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 11:09:57 +0000 Subject: [Koha-bugs] [Bug 23584] Add public API routes to change privacy settings In-Reply-To: <bug-23584-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23584-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23584-70-8iN18MmTvJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23584 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add public routes to change |Add public API routes to |privacy settings |change privacy settings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 17:08:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 16:08:41 +0000 Subject: [Koha-bugs] [Bug 24036] New: UpdateNotForLoanStatusOnCheckin preference requires space after colon (specify in manual) Message-ID: <bug-24036-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24036 Bug ID: 24036 Summary: UpdateNotForLoanStatusOnCheckin preference requires space after colon (specify in manual) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org As stated in bug #17480, the system preference UpdateNotForLoanStatusOnCheckin requires a specific syntax in order to work. While there is discussion on a possible validation, it would be best to specify it in the manual in the mean time. Other sysprefs require YAML syntax, I haven't checked if the manual specifies it: - BibtexExportAdditionalFields - MarcFieldsToOrder - MarcItemFieldsToOrder - OpacHiddenItems - RisExportAdditionalFields - UpdateItemLocationOnCheckin - UpdateItemWhenLostFromHoldList -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 12:03:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 11:03:29 +0000 Subject: [Koha-bugs] [Bug 23517] Add API route to update a holds priority In-Reply-To: <bug-23517-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23517-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23517-70-nZv4JM1dWo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23517 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This development enhances | release notes|with API with routes to to | |change holds priorities. | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 12:30:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 11:30:40 +0000 Subject: [Koha-bugs] [Bug 24022] Z3950Responder tests are failing randomly In-Reply-To: <bug-24022-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24022-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24022-70-QleY5AleDQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24022 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95333|0 |1 is obsolete| | --- Comment #7 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95363 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95363&action=edit Bug 24022: Remove unecessary delete from authorised_values Why do we need that exactly? The cache is not flushed so it should not be needed. Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 15:45:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 14:45:21 +0000 Subject: [Koha-bugs] [Bug 23854] Cannot edit a suggestion In-Reply-To: <bug-23854-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23854-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23854-70-OV9WUJZabf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23854 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94518|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 95397 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95397&action=edit Bug 23854: Fix failure on dates when editing a suggestion Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> - Watch plack-error-log - Change an accepted suggestion to 'No Status' - Verify error in the logs (use strict mode, depending on DBMS version) - Status changed was not saved - Apply patch - Verify the error is gone, change is saved now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 23:39:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 22:39:42 +0000 Subject: [Koha-bugs] [Bug 23679] Software error when trying to transfer an unknown barcode In-Reply-To: <bug-23679-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23679-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23679-70-GcfS0cRycs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23679 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to stable |Pushed to oldstable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 12:13:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 11:13:58 +0000 Subject: [Koha-bugs] [Bug 18928] Move `holdallowed`, `hold_fulfillment_policy` and `returnbranch` into the `circulation_rules` table. In-Reply-To: <bug-18928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18928-70-NNawWQBlRv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Move `holdallowed`, |Move `holdallowed`, |`hold_fulfillment_policy` |`hold_fulfillment_policy` |and `returnbranch` into |and `returnbranch` into the |`circulation_rules` |`circulation_rules` table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 08:47:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 07:47:24 +0000 Subject: [Koha-bugs] [Bug 24031] Add plugin hook after_hold_create In-Reply-To: <bug-24031-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24031-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24031-70-KofKZpAedi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24031 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 14:20:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 13:20:13 +0000 Subject: [Koha-bugs] [Bug 24022] Z3950Responder tests are failing randomly In-Reply-To: <bug-24022-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24022-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24022-70-LjmGyWygCZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24022 --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 10:56:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 09:56:19 +0000 Subject: [Koha-bugs] [Bug 21014] Availability of hidden items showing in OPAC In-Reply-To: <bug-21014-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21014-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21014-70-iGsuUoeueg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21014 Ray Delahunty <r.delahunty at arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty at arts.ac.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 02:12:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 01:12:47 +0000 Subject: [Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized In-Reply-To: <bug-22381-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22381-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22381-70-IULBWhyot6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Bill Carroll <bcarroll at dubuque.lib.ia.us> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bcarroll at dubuque.lib.ia.us Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 14:21:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 13:21:38 +0000 Subject: [Koha-bugs] [Bug 24029] marcrecord2csv.t displays a SQL error "Truncated incorrect DOUBLE value: '01e'" In-Reply-To: <bug-24029-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24029-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24029-70-s8lARcRqZN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24029 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize at ptfs-europe | |.com --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Obvious correction, tiny patch.. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 22:40:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 21:40:15 +0000 Subject: [Koha-bugs] [Bug 24034] Capitalization on suggestion edit form: No Status In-Reply-To: <bug-24034-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24034-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24034-70-TLZr5SIfui@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24034 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95410|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 10:56:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 09:56:54 +0000 Subject: [Koha-bugs] [Bug 14007] Item Types for items hidden by OpacHiddenItems turn up in facet results In-Reply-To: <bug-14007-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14007-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14007-70-HXJjuGkdSE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14007 Ray Delahunty <r.delahunty at arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty at arts.ac.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 20:57:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 19:57:54 +0000 Subject: [Koha-bugs] [Bug 23908] Require patrons to confirm their email address In-Reply-To: <bug-23908-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23908-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23908-70-rOJDq3VYIJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23908 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 08:43:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 07:43:08 +0000 Subject: [Koha-bugs] [Bug 22280] The ILL module assumes every status needs a next/previous status In-Reply-To: <bug-22280-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22280-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22280-70-3RLu2EJcuq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22280 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #18 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 19.05.x for 19.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 09:53:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 08:53:34 +0000 Subject: [Koha-bugs] [Bug 24026] Wrong parameters in Koha/Templates/Plugin/CirculationRules.pm and smart-rules.tt In-Reply-To: <bug-24026-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24026-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24026-70-tgl9qnO6TS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24026 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.05 released in| | CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable --- Comment #14 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 19.05.x for 19.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 01:07:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 00:07:15 +0000 Subject: [Koha-bugs] [Bug 6529] Cataloging search issues - withdrawn, lost, on-order counts not displayed consistently In-Reply-To: <bug-6529-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6529-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6529-70-5BBaT5cSvx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6529 Cori Lynn Arnold <carnold at dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME CC| |carnold at dgiinc.com --- Comment #2 from Cori Lynn Arnold <carnold at dgiinc.com> --- This appears to be working in 19.05. https://paste.pics/5051b7c195f7ae3ebe320a781e3b9644 Although, a book that is "Lost and Paid for" only shows up as "Lost" in the Cataloging search. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 15:04:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 14:04:10 +0000 Subject: [Koha-bugs] [Bug 24026] Wrong parameters in Koha/Templates/Plugin/CirculationRules.pm and smart-rules.tt In-Reply-To: <bug-24026-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24026-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24026-70-umieGbCOnn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24026 --- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 14:33:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 13:33:53 +0000 Subject: [Koha-bugs] [Bug 18433] Allow to select results to export in item search In-Reply-To: <bug-18433-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18433-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18433-70-FCWN2JxTNr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #32 from Julian Maurice <julian.maurice at biblibre.com> --- Patch rebased on master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 14:31:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 13:31:26 +0000 Subject: [Koha-bugs] [Bug 21665] Advanced editor - Double clicking on value brings subfield code as well In-Reply-To: <bug-21665-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21665-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21665-70-iIpCbam5oc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21665 --- Comment #2 from Cori Lynn Arnold <carnold at dgiinc.com> --- Created attachment 95379 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95379&action=edit Sample record -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 17:20:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 16:20:10 +0000 Subject: [Koha-bugs] [Bug 23050] Plugins: Add hook to add a tab in intranet biblio details page In-Reply-To: <bug-23050-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23050-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23050-70-646woOkezV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23050 --- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95406 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95406&action=edit Bug 23050: (RM follow-up) Add Try::Tiny to controller Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 19:52:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 18:52:01 +0000 Subject: [Koha-bugs] [Bug 24038] New: Missing new GDPR system preference in 19.05 manual Message-ID: <bug-24038-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24038 Bug ID: 24038 Summary: Missing new GDPR system preference in 19.05 manual Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Three new system preferences are added in 19.05, but the descriptions are missing from Manual. System preferences UnsubscribeReflectionDelay, PatronAnonymizeDelay and PatronRemovalDelay. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 20:52:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 19:52:08 +0000 Subject: [Koha-bugs] [Bug 23187] Koha::Objects supports find_or_create without passing through the Koha::Object store method In-Reply-To: <bug-23187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23187-70-Q85GMSyg0O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23187 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |major -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 12:43:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 11:43:02 +0000 Subject: [Koha-bugs] [Bug 22706] Add plugin hooks to enable Norwegian national patron database In-Reply-To: <bug-22706-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22706-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22706-70-OnrsRMMda2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22706 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Patrons |Plugin architecture -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 12:38:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 11:38:28 +0000 Subject: [Koha-bugs] [Bug 24026] Wrong parameters in Koha/Templates/Plugin/CirculationRules.pm and smart-rules.tt In-Reply-To: <bug-24026-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24026-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24026-70-RAx78zNs4O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24026 --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95365 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95365&action=edit Bug 24026: (bug 22847 follow-up) Remove c/p issues -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 12:25:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 11:25:20 +0000 Subject: [Koha-bugs] [Bug 24027] Adding multiple items is slow In-Reply-To: <bug-24027-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24027-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24027-70-WmuYkicYx9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24027 --- Comment #4 from Andrew Nugged <nugged at gmail.com> --- Created attachment 95417 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95417&action=edit Bug 24027: (follow-up) Don't combine long items-add POST page with list generation When hundreds or thousands of items added, it takes time. Then generation of items list also takes time, and more items more items list generation needed, so sometimes user gets even browser timeout. It's much more sensible on big databases and libraries hosting/clouds with limited resources. So - showing only counter of added items on POST-generated page instead of list generation shortens page generation time and then user can navigate further. This stacks up with previous patches in this ticket for the combined effect. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 20:33:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 19:33:32 +0000 Subject: [Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl In-Reply-To: <bug-23247-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23247-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23247-70-bllaoBXE1X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 --- Comment #14 from Tomás Cohen Arazi <tomascohen at gmail.com> --- (In reply to Marcel de Rooy from comment #12) > Does this report obsolete the borcat parameter of GetMarcBiblio btw? > If so, please provide a follow-up to get rid of it? (In reply to Marcel de Rooy from comment #11) > From Patron/Category: > > =head3 override_hidden_items > > if ( $patron->category->override_hidden_items ) { > ... > } > > Returns a boolean that if patrons of this category are exempt from the > OPACHiddenItems policies > > TODO: Remove on bug 22547 > > => Looks like we did not on 22547 ;) That was a typo, it was meant to be bug 22457 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 12:25:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 11:25:08 +0000 Subject: [Koha-bugs] [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace In-Reply-To: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23414-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23414-70-AOM50iedM5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15262 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15262 [Bug 15262] Run Koha Run. Koha search should be fast again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 18:14:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 17:14:31 +0000 Subject: [Koha-bugs] [Bug 23732] Hold rules checker: show matched rules and syspref values to help understand why a hold is possible or not In-Reply-To: <bug-23732-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23732-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23732-70-Y611McAc6z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 --- Comment #6 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- screenshots: Not that "Check this out" is the name of the record. A very great also not so great name for examples ^_^ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 21:35:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 20:35:18 +0000 Subject: [Koha-bugs] [Bug 9553] Link authorities to bibs when imported In-Reply-To: <bug-9553-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9553-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9553-70-D3WH3RJSYO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9553 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 17:23:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 16:23:50 +0000 Subject: [Koha-bugs] [Bug 23825] Object.t is failing - Exception not caught In-Reply-To: <bug-23825-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23825-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23825-70-GeCdxHSkk7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 19:16:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 18:16:12 +0000 Subject: [Koha-bugs] [Bug 22280] The ILL module assumes every status needs a next/previous status In-Reply-To: <bug-22280-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22280-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22280-70-fZeIKi76IU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22280 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 15:00:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 14:00:05 +0000 Subject: [Koha-bugs] [Bug 23822] Regression: As of 19.05.04 deletion of patrons with outstanding credits is silently blocked In-Reply-To: <bug-23822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23822-70-amiP76hIBG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23822 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95327|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 95388 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95388&action=edit Bug 23822: Fix deletion of patrons with credit There are bugs in both master and 19.05, but different. Anyway we should have this check to make sure a negative value will have the same behavior: trigger the confirmation message (instead of a blank page). If we want to reject the deletion of a patron with credit we should handle it on a separate bug report (behavior change) Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 20:49:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 19:49:39 +0000 Subject: [Koha-bugs] [Bug 22566] Stock rotation cronjob reporting has issues In-Reply-To: <bug-22566-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22566-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22566-70-pbPGEANdxZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22566 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|RM_priority | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 17:17:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 16:17:23 +0000 Subject: [Koha-bugs] [Bug 23825] Object.t is failing - Exception not caught In-Reply-To: <bug-23825-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23825-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23825-70-qhAsLvtVOQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94804|0 |1 is obsolete| | --- Comment #30 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95404 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95404&action=edit Bug 23825: (QA follow-up) Remove database name As requested on comment15. Test plan: Run t/db_dependent/Koha/Object.t again Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 15:04:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 14:04:08 +0000 Subject: [Koha-bugs] [Bug 24026] Wrong parameters in Koha/Templates/Plugin/CirculationRules.pm and smart-rules.tt In-Reply-To: <bug-24026-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24026-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24026-70-udo7idAxJo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24026 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 17:23:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 16:23:46 +0000 Subject: [Koha-bugs] [Bug 23822] Regression: As of 19.05.04 deletion of patrons with outstanding credits is silently blocked In-Reply-To: <bug-23822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23822-70-1WtG5Hfc0f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23822 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 15:02:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 14:02:25 +0000 Subject: [Koha-bugs] [Bug 24008] Attempting to delete a patron with outstanding credits should warn and block the deletion. In-Reply-To: <bug-24008-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24008-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24008-70-dblGtqwGKf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think we should think if this should block or only warn - holds warn, fines block currently. I could see a credit warning, but not blocking. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 12:43:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 11:43:13 +0000 Subject: [Koha-bugs] [Bug 23222] Fix DISABLE/ENABLE plugin label in plugins home In-Reply-To: <bug-23222-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23222-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23222-70-vD3ru8kpl6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23222 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |Plugin architecture |and plumbing | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 11:08:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 10:08:58 +0000 Subject: [Koha-bugs] [Bug 24029] marcrecord2csv.t displays a SQL error "Truncated incorrect DOUBLE value: '01e'" In-Reply-To: <bug-24029-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24029-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24029-70-xiihISE5XS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24029 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 11:07:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 10:07:34 +0000 Subject: [Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8 In-Reply-To: <bug-24002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24002-70-HY9JR5axKn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|24030 | Depends on| |24030 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24030 [Bug 24030] GetItemsForInventory failing with "ORDER BY clause is not in SELECT list" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 12:38:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 11:38:23 +0000 Subject: [Koha-bugs] [Bug 24026] Wrong parameters in Koha/Templates/Plugin/CirculationRules.pm and smart-rules.tt In-Reply-To: <bug-24026-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24026-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24026-70-msDfAakV3R@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24026 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 17:49:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 16:49:40 +0000 Subject: [Koha-bugs] [Bug 24046] New: 'Activate filters' untranslatable Message-ID: <bug-24046-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24046 Bug ID: 24046 Summary: 'Activate filters' untranslatable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Created attachment 95437 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95437&action=edit Intranet detail page in fr-CA When looking at the intranet detail page, in the holdings tab, there is 'Activate filters' which is untranslatable. I *think* it's because it's in a JS tidbit of code, but I'm not sure... See screenshot of fr-CA detail page with Activate filters in English. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 15:04:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 14:04:06 +0000 Subject: [Koha-bugs] [Bug 23985] The method Koha::Item-> is not covered by tests! In-Reply-To: <bug-23985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23985-70-iAvDIq5pJB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23985 --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 18:59:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 17:59:34 +0000 Subject: [Koha-bugs] [Bug 23265] Update to DB revision 16.12.00.032 fails: Unknown column 'me.item_level_hold' In-Reply-To: <bug-23265-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23265-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23265-70-tEotmo71Fg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23265 Cindy Murdock Ames <cmurdock at ccfls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |cmurdock at ccfls.org --- Comment #13 from Cindy Murdock Ames <cmurdock at ccfls.org> --- My apologies if this doesn't belong here, but I seem to be having an issue relating to this same section of code. I'm upgrading from a dev install of 3.22, slightly customized so maybe this is unique to me. I've imported the database into a fresh install on 19.05.04 using mariadb 10.1 on ubuntu 18.04, and I get this error and the database update halts when running koha-upgrade-schema: Upgrade to 16.12.00.031 done (Bug 15108: OAI-PMH provider improvements) Not a HASH reference at /usr/share/koha/intranet/cgi-bin/installer/data/mysql/updatedatabase.pl line 14371. My reserves table doesn't contain anything in expirationdate other than NULL. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 17:47:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 16:47:32 +0000 Subject: [Koha-bugs] [Bug 23732] Hold rules checker: show matched rules and syspref values to help understand why a hold is possible or not In-Reply-To: <bug-23732-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23732-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23732-70-NTgDRMHOCF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 15:42:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 14:42:58 +0000 Subject: [Koha-bugs] [Bug 24034] New: Capitalization on suggestion edit form: No Status Message-ID: <bug-24034-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24034 Bug ID: 24034 Summary: Capitalization on suggestion edit form: No Status Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org The "No Status" in the status pull down on the suggestion edit form should be "No status". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 20:48:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 19:48:15 +0000 Subject: [Koha-bugs] [Bug 24034] Capitalization on suggestion edit form: No Status In-Reply-To: <bug-24034-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24034-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24034-70-KE5z8LWWg8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24034 Lisette Scheer <lisetteslatah at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 17:17:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 16:17:59 +0000 Subject: [Koha-bugs] [Bug 23825] Object.t is failing - Exception not caught In-Reply-To: <bug-23825-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23825-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23825-70-m0O8iSBlTK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #32 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Thanks for the perseverance here guys, Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 14:36:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 13:36:08 +0000 Subject: [Koha-bugs] [Bug 24045] New: Cannot open port for Z39.50 Message-ID: <bug-24045-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24045 Bug ID: 24045 Summary: Cannot open port for Z39.50 Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Z39.50 / SRU / OpenSearch Servers Assignee: koha-bugs at lists.koha-community.org Reporter: b.pastern4k at gmail.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl For Z39 to work i followed the instructions and uncommented these blocks in koha-conf.xml <listen id="publicserver">tcp:@:nnn</listen> <server id="publicserver" listenref="publicserver">...</server> <serverinfo id="publicserver">...</serverinfo> Then i ran sudo koha-zebra --restart instance. When i try to check whether the connection is working via yaz-client -c /etc/koha/zebradb/ccl.properties localhost:$PORT/biblios i get this error Connecting...error = System (lower-layer) error: Connection refused I checked opened ports/IPs with this command sudo netstat -tuplen and could not find my port for z39 server. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 12:36:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 11:36:40 +0000 Subject: [Koha-bugs] [Bug 22835] Serve static files from plugins through the API In-Reply-To: <bug-22835-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22835-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22835-70-hLKY34pEkS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22835 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |Plugin architecture |and plumbing | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 12:25:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 11:25:08 +0000 Subject: [Koha-bugs] [Bug 23035] Intranet search is slow if thousands of items are in the biblios shown in the search results In-Reply-To: <bug-23035-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23035-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23035-70-G8SP0l6QE7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23035 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15262 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15262 [Bug 15262] Run Koha Run. Koha search should be fast again. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 12:48:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 11:48:08 +0000 Subject: [Koha-bugs] [Bug 22706] Add plugin hooks to enable Norwegian national patron database In-Reply-To: <bug-22706-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22706-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22706-70-aA2ILu4sMM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22706 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 12:42:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 11:42:07 +0000 Subject: [Koha-bugs] [Bug 23191] Administrators should be able to install plugins from the command line In-Reply-To: <bug-23191-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23191-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23191-70-BHBQh4ANSN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23191 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Command-line Utilities |Plugin architecture -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 12:59:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 11:59:53 +0000 Subject: [Koha-bugs] [Bug 24026] Wrong parameters in Koha/Templates/Plugin/CirculationRules.pm and smart-rules.tt In-Reply-To: <bug-24026-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24026-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24026-70-yNnZmyISQT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24026 --- Comment #8 from Nick Clemens <nick at bywatersolutions.com> --- To test: Add a standard rule for all libraries with maxisseqty and maxonsiteissueqty set to some value, say 5 Add several itemtype or categorycode specific rules, leaving max checkouts/onsite as blank to get unlimited Set an itemtype or cateogory specific rule for a branch as well. Remove the specific rules from the DB: delete from circulation_rules WHERE itemtype IS NOT NULL OR categorycode IS NOT NULL; Note that all rules for all libraries use the 'All/All' checkout limit Note that the specific library does as well Apply patch unset rules appear as unlimited now Note:thigns still won't work in this state, as we are introducing bad data, but it helps highlight the issue -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 20:54:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 19:54:05 +0000 Subject: [Koha-bugs] [Bug 23854] Cannot edit a suggestion In-Reply-To: <bug-23854-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23854-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23854-70-jLvP6949NY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23854 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_19_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 23:57:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 22:57:06 +0000 Subject: [Koha-bugs] [Bug 23689] Terminology: Branches limitations should be libraries limitations - Authorised Values In-Reply-To: <bug-23689-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23689-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23689-70-H2fcgtc457@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23689 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #10 from Lucas Gass <lucas at bywatersolutions.com> --- i cannot clean apply this patchset and I am a bit unsure about my rebase, without a proper test plan I am afraid to backport -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 12:06:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 11:06:12 +0000 Subject: [Koha-bugs] [Bug 23932] Typo on 'aqinvoice_adjustments.encumber_open' description in Koha Schema In-Reply-To: <bug-23932-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23932-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23932-70-d13W4xf7ip@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23932 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95209|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 95359 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95359&action=edit Bug 23932: Typo on 'aqinvoice_adjustments.encumber_open' description in Koha Schema Correct a typo in Koha Schema comment. finds --> funds Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 02:29:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 01:29:21 +0000 Subject: [Koha-bugs] [Bug 14226] LC help in professional cataloging interface In-Reply-To: <bug-14226-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14226-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14226-70-j62Ks55nf5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14226 Cori Lynn Arnold <carnold at dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carnold at dgiinc.com Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #1 from Cori Lynn Arnold <carnold at dgiinc.com> --- Links to the LC documentation appear at the bottom of the browser page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 17:49:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 16:49:14 +0000 Subject: [Koha-bugs] [Bug 23854] Cannot edit a suggestion In-Reply-To: <bug-23854-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23854-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23854-70-2IK6iWRVhY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23854 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 12:08:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 11:08:38 +0000 Subject: [Koha-bugs] [Bug 24027] Adding multiple items is slow In-Reply-To: <bug-24027-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24027-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24027-70-BRLWYqP53c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24027 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Hi Andrew, Thanks for the patch, that's a great idea. Is it ready for signoff? Only one thing, we will certainly reject the first patch, $dbh must be retrieved from C4::Context->dbh only. Also we prefer to have a hashref as parameters to make the flag explicit: { postpone_indexes_update => 1 } Cheers, Jonathan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 17:50:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 16:50:52 +0000 Subject: [Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page In-Reply-To: <bug-12502-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12502-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12502-70-KOKoc10dLT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 13:00:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 12:00:22 +0000 Subject: [Koha-bugs] [Bug 24025] Make CodeMirror content searchable In-Reply-To: <bug-24025-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24025-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24025-70-P3Ry0oe8dx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24025 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21582 Version|19.05 |master Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21582 [Bug 21582] Use CodeMirror for *UserJS & *UserCSS -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 20:54:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 19:54:12 +0000 Subject: [Koha-bugs] [Bug 23765] After TranslateNotices is set to 'Don't allow', email settings still show multiple languages In-Reply-To: <bug-23765-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23765-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23765-70-3qecRTEg4N@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23765 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_19_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 12:25:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 11:25:48 +0000 Subject: [Koha-bugs] [Bug 24027] Adding multiple items is slow In-Reply-To: <bug-24027-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24027-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24027-70-6XR6XPLviT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24027 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|15262 | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15262 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15262 [Bug 15262] Run Koha Run. Koha search should be fast again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 11:59:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 10:59:00 +0000 Subject: [Koha-bugs] [Bug 17842] Broken diacritics on records exported as MARC from cart In-Reply-To: <bug-17842-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17842-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17842-70-U2lbo7aydS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17842 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |RESOLVED Resolution|--- |WORKSFORME --- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Closing again, please reopen (and attach the file) if still valid. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 12:52:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 11:52:48 +0000 Subject: [Koha-bugs] [Bug 24026] Wrong parameters in Koha/Templates/Plugin/CirculationRules.pm and smart-rules.tt In-Reply-To: <bug-24026-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24026-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24026-70-6INMGgocgu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24026 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95365|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95369 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95369&action=edit Bug 24026: (bug 22847 follow-up) Remove c/p issues Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 17:48:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 16:48:07 +0000 Subject: [Koha-bugs] [Bug 23982] Count/pagination broken for reports with duplicated column names In-Reply-To: <bug-23982-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23982-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23982-70-MOg9cRnCdQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23982 --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- This is horrible.. I really don't like the idea of reverting that followup as it fixes an important performance hole. Feels like MySQL is getting it wrong to me.. grr Contemplating if we have any other options. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 13:01:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 12:01:32 +0000 Subject: [Koha-bugs] [Bug 23983] Contextualization of "Order" (verb) vs "Order" (noun) In-Reply-To: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23983-70-P3WroHsZwn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23983 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95368|0 |1 is obsolete| | --- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 95372 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95372&action=edit Bug 23983: Remove comment I think we can do without the comment - suggesting removal with this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 20:49:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 19:49:32 +0000 Subject: [Koha-bugs] [Bug 11573] Fine descriptions related to Rentals are untranslatable In-Reply-To: <bug-11573-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11573-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11573-70-eMkBUYLFPn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11573 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|RM_priority | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 20:50:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 19:50:08 +0000 Subject: [Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes In-Reply-To: <bug-22563-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22563-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22563-70-60X83OriNw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|RM_priority | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 00:12:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 23:12:43 +0000 Subject: [Koha-bugs] [Bug 21985] Test t/db_dependent/Circulation.t fails if SearchEngine is set to elasticsearch In-Reply-To: <bug-21985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21985-70-mMybkSerZm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21985 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #18 from Lucas Gass <lucas at bywatersolutions.com> --- 18.11.x is missing the bz21971 dependency so I will not backport for 18.11.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 11:52:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 10:52:20 +0000 Subject: [Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13937-70-EfyaVMQmBJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This patch allows libraries |This development allows release notes|wishing to run |libraries wishing to run |Elasticsearch but also |Elasticsearch but also |serve as a public |serve as a public |SRU/Z39.50 gateway to do so |SRU/Z39.50 gateway to do so |without running Zebra in |without running Zebra in |parallel. |parallel. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 12:27:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 11:27:30 +0000 Subject: [Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes In-Reply-To: <bug-22563-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22563-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22563-70-XYAMVDJ7gT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Reports Note: The |Reports Note: The release notes|`accounttype` for lost item |`accounttype` for lost item |fees has been updated from |fees has been updated from |'L' to 'LOST' and for lost |'L' to 'LOST' and for lost |item returned credits it |item returned credits it |has be updated from 'CR' to |has been updated from 'CR' |'LOST_RETURNED'. The |to 'LOST_RETURNED'. The |`status` field is now used |`status` field is now used |to track |to track the reason why an | |'OVERDUE' fee has stopped | |incrementing and it may | |include 'LOST' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 17:44:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 16:44:20 +0000 Subject: [Koha-bugs] [Bug 23732] Hold rules checker: show matched rules and syspref values to help understand why a hold is possible or not In-Reply-To: <bug-23732-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23732-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23732-70-TiwFyjXkS1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 --- Comment #2 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- Created attachment 95436 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95436&action=edit Bug 23732: Add unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 15:43:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 14:43:05 +0000 Subject: [Koha-bugs] [Bug 24034] Capitalization on suggestion edit form: No Status In-Reply-To: <bug-24034-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24034-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24034-70-k6SH573HMr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24034 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 15:02:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 14:02:34 +0000 Subject: [Koha-bugs] [Bug 24008] Attempting to delete a patron with outstanding credits should warn and block the deletion In-Reply-To: <bug-24008-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24008-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24008-70-eFPHbnlINj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Attempting to delete a |Attempting to delete a |patron with outstanding |patron with outstanding |credits should warn and |credits should warn and |block the deletion. |block the deletion -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 12:06:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 11:06:30 +0000 Subject: [Koha-bugs] [Bug 23932] Typo on 'aqinvoice_adjustments.encumber_open' description in Koha Schema In-Reply-To: <bug-23932-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23932-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23932-70-dqYYLwfBBZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23932 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Congrats Severine! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 15:10:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 14:10:49 +0000 Subject: [Koha-bugs] [Bug 23854] Cannot edit a suggestion In-Reply-To: <bug-23854-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23854-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23854-70-ZjkMI83Mmz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23854 --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Sorry, but I was not able to reproduce this issue: - In acquisition, I found a accepted suggestoin - Edit suggestion using the button at the end of the line - Changing nothing, saving - No error in GUI or log >From the result list: - Changed status from accepted to pending - No error in the GUI, warning in the logs: No suggestions ASKED letter transported by email at /home/vagrant/kohaclone/C4/Letters.pm line 608. CGI::param called in list context from /home/vagrant/kohaclone/suggestion/suggestion.pl line 237, this can lead to vulnerabilities. See the warning in "Fetching the value or values of a single named parameter" at /usr/share/perl5/CGI.pm line 412. I think I need more information here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 01:02:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 00:02:05 +0000 Subject: [Koha-bugs] [Bug 24027] Adding multiple items is slow In-Reply-To: <bug-24027-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24027-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24027-70-RtHDj5mEKR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24027 --- Comment #2 from Andrew Nugged <nugged at gmail.com> --- Created attachment 95414 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95414&action=edit Bug 24027: (follow-up) ModZebra should be called once after all items added, not on each item add Why happened: - call to ModZebra was done after EACH item added, but it was called only with main biblionumber only, so call was the same on each of requests - and also time spent in that ModZebra sub increased with every next hundred items in DB for that element: so adding every next 100 was slower and slower, Solved: - now it's called only once (by adding some extra parameter to "AddItem*" sub set in postponed mode) - and now adding of elements not so heavily depends from how much items was in DB before. Test plan / How to replicate the issue: (test depends from how already populated DB and Zebra/Elasticsearch DBs so might be not so noticeably fast on empty DBs) - go to one of bibliotitems cataloguing/additem.pl?biblionumber=XXX pages - press button "add multiple copies of this item", put 1000 on slower machines, 5000 on faster - start measuring time + submit page/form It takes some serious amount of time even up to timeout. After applying patch, same procedure for same number of items. Also it much less slows down when number of items rises, more linearly. But, again, it heavily depends how database is populated and indexes are rebuild but it's obvious that it will me much more efficient call "ModZebra" once after 1000 addings, then 1000 times on each item copied. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 14:47:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 13:47:17 +0000 Subject: [Koha-bugs] [Bug 24026] Wrong parameters in Koha/Templates/Plugin/CirculationRules.pm and smart-rules.tt In-Reply-To: <bug-24026-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24026-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24026-70-jVEj9BziX2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24026 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 18:59:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 17:59:28 +0000 Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20936-70-1kkCembjJl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|tomascohen at gmail.com |agustinmoyano at theke.io -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 13:42:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 12:42:01 +0000 Subject: [Koha-bugs] [Bug 24000] Some modules does not return 1 In-Reply-To: <bug-24000-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24000-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24000-70-98EPCFMgQS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24000 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|Failed QA |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 14:18:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 13:18:12 +0000 Subject: [Koha-bugs] [Bug 23983] Contextualization of "Order" (verb) vs "Order" (noun) In-Reply-To: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23983-70-cvNHLTOJzf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23983 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Keywords|rel_19_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 17:24:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 16:24:12 +0000 Subject: [Koha-bugs] [Bug 21959] Batch item modification - ability to apply regular expression on text fields In-Reply-To: <bug-21959-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21959-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21959-70-0z6nQJ3f1p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21959 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92872|0 |1 is obsolete| | --- Comment #25 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 95434 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95434&action=edit Bug 21959: allow only i and g regex modifiers Signed-off-by: Mathilde Formery <mathilde.formery at ville-nimes.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 14:18:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 13:18:36 +0000 Subject: [Koha-bugs] [Bug 24022] Z3950Responder tests are failing randomly In-Reply-To: <bug-24022-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24022-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24022-70-x1PPqfOk0G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24022 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 13:47:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 12:47:41 +0000 Subject: [Koha-bugs] [Bug 24000] Some modules does not return 1 In-Reply-To: <bug-24000-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24000-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24000-70-Vdl7W3nvu3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24000 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|WONTFIX |--- Status|RESOLVED |REOPENED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 21:24:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 20:24:51 +0000 Subject: [Koha-bugs] [Bug 24041] New: Renewal only slips Message-ID: <bug-24041-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24041 Bug ID: 24041 Summary: Renewal only slips Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org It would be very nice if Koha had a separate slip that the circulation desk could print up to show the patron only what items were renewed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 14:30:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 13:30:53 +0000 Subject: [Koha-bugs] [Bug 21665] Advanced editor - Double clicking on value brings subfield code as well In-Reply-To: <bug-21665-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21665-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21665-70-sRP5I7PW2s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21665 --- Comment #1 from Cori Lynn Arnold <carnold at dgiinc.com> --- To reproduce this issue: 1. Verify that the "Advanced Editor" for cataloging has been enabled by going to "Administration" from the home page and searching for "EnableAdvancedCatalogingEditor" Set this to "Enable" if it isn't already. 2. From the home page go to "Cataloging" 3. Click on the button that says "Advanced editor" 4. Import the record attached to this bug by clicking on the "Import" button and navigating to the saved record 5. Double click on the number "9781541724389" and copy it from line starting with 020. 6. Paste the result into notepad Result: a9781541724389 Expected Result: 9781541724389 The subfield should not be copied along with the data. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 12:49:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 11:49:04 +0000 Subject: [Koha-bugs] [Bug 22706] Add plugin hooks to allow custom password strength checking modules In-Reply-To: <bug-22706-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22706-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22706-70-54kyObOR2R@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22706 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add plugin hooks to enable |Add plugin hooks to allow |Norwegian national patron |custom password strength |database |checking modules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 20:53:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 19:53:05 +0000 Subject: [Koha-bugs] [Bug 24034] Capitalization on suggestion edit form: No Status In-Reply-To: <bug-24034-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24034-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24034-70-zBT01nYwYp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24034 Lisette Scheer <lisetteslatah at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 13:47:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 12:47:24 +0000 Subject: [Koha-bugs] [Bug 24043] ILL module can't show requests from more than one backend In-Reply-To: <bug-24043-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24043-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24043-70-Zey9oyNUQ0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24043 --- Comment #2 from Magnus Enger <magnus at libriotech.no> --- Played around a bit with the JS debugger, and it looks like my hunch was right. "meta" is a variable with this (very simplified) structure: meta col row settings oInit originalData 0 capabilities NEW REQ status 1 capabilities NEW REQ status So when we do this: var status_name = meta.settings.oInit.originalData[0].capabilities[ row.status ].name; we are trying to use the "capabilities" (a hash with status codes as keys and status names as values) of the first request returned ([0]) to translate the status codes of *all* requests into their status names. But requests from different backends can have completely different statuses, so this fails when there are requests from more than one backend. It looks like the solution is to use meta.settings.oInit.originalData[ meta.row ].capabilities to look up the correct capabilities for the current request being handled. Patch coming in a sec or two! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 14:49:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 13:49:10 +0000 Subject: [Koha-bugs] [Bug 23779] Add sample matching rule for authority records on $1xx field matches In-Reply-To: <bug-23779-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23779-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23779-70-o5dPJBAECd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23779 --- Comment #7 from Cori Lynn Arnold <carnold at dgiinc.com> --- (In reply to Katrin Fischer from comment #6) > I am surprised that the rule attached is working, I would have expected it > not to because the Search index information is empty - could it be that it's > using the keyword index for matching in this case? It does work. Should I add an index? If so, which one do you think? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 15:03:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 14:03:22 +0000 Subject: [Koha-bugs] [Bug 23985] The method Koha::Item-> is not covered by tests! In-Reply-To: <bug-23985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23985-70-vbFKW9kZfu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23985 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 12:06:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 11:06:09 +0000 Subject: [Koha-bugs] [Bug 23932] Typo on 'aqinvoice_adjustments.encumber_open' description in Koha Schema In-Reply-To: <bug-23932-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23932-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23932-70-6jcWvIedaW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23932 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 14:59:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 13:59:59 +0000 Subject: [Koha-bugs] [Bug 23822] Regression: As of 19.05.04 deletion of patrons with outstanding credits is silently blocked In-Reply-To: <bug-23822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23822-70-PUBIkFlGzd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23822 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 20:42:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 19:42:39 +0000 Subject: [Koha-bugs] [Bug 24039] New: Allow z3950 profiles to be linked to a user Message-ID: <bug-24039-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24039 Bug ID: 24039 Summary: Allow z3950 profiles to be linked to a user Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: chris at bigballofwax.co.nz QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl Differently cataloguers might have different access to z3950 servers. This will allow for z3950 profiles to be linked to users. (Or to all) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 13:17:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 12:17:25 +0000 Subject: [Koha-bugs] [Bug 24027] Adding multiple items is slow In-Reply-To: <bug-24027-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24027-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24027-70-XxhwWaAC3I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24027 --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #6) > I understand the need of the UI patch, but I am worry it will not fit all > needs, as it adds an extra step. I am pretty sure catalogers want to see if > the last action did what they wanted :) > > We have something similar for the batch item edit/del tools, driven by a > sysprefs. We could hardcoded it for now (50, 100?) and see if it passes QA :) I meant: do not display the item list if X items are added in one go. But it will not fix the problem if there are already thousands of items. So maybe a pref to limit the display of the number of items. I feel like we should ask the list to get feedbacks from catalogers. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 17:23:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 16:23:48 +0000 Subject: [Koha-bugs] [Bug 23822] Regression: As of 19.05.04 deletion of patrons with outstanding credits is silently blocked In-Reply-To: <bug-23822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23822-70-GC3L0pqx5r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23822 --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 11:10:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 10:10:14 +0000 Subject: [Koha-bugs] [Bug 24031] New: Add plugin hook after_hold_create Message-ID: <bug-24031-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24031 Bug ID: 24031 Summary: Add plugin hook after_hold_create Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: julian.maurice at biblibre.com Reporter: julian.maurice at biblibre.com QA Contact: testopia at bugs.koha-community.org This hook will be called after a hold has been placed. The need behind that is to create a plugin that will send a mail to the patron that has borrowed the reserved item, saying something like "Someone has requested this item, please return it as soon as you can" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 21:27:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 20:27:06 +0000 Subject: [Koha-bugs] [Bug 24042] New: Select what Items to Print on a slip Message-ID: <bug-24042-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24042 Bug ID: 24042 Summary: Select what Items to Print on a slip Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Notices Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org It would be very nice to have the ability to choose which items that the patrons have checked out. On some occasions, a patron already has checked out at the desk and finds one more item to checkout. Instead of printing another quick slip for the patron, allowing the library to print a slip with only the most current item/s that were checked out would be nice. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 00:48:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 23:48:16 +0000 Subject: [Koha-bugs] [Bug 23067] When confirming a hold in OPAC the last location column is empty In-Reply-To: <bug-23067-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23067-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23067-70-9zOZD1bawD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23067 Ed Veal <eveal at mckinneytexas.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eveal at mckinneytexas.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 23:57:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 22:57:42 +0000 Subject: [Koha-bugs] [Bug 24027] Adding multiple items is slow In-Reply-To: <bug-24027-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24027-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24027-70-ifs2e6TnaY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24027 --- Comment #1 from Andrew Nugged <nugged at gmail.com> --- Created attachment 95413 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95413&action=edit Bug 24027: dbh handler not passed through all chain preparatory fix for next patch to have all parameters aligned: $dbh handler passed through as parameter in AddItem but forgotten in AddItemFromMarc. Added. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 11:07:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 10:07:34 +0000 Subject: [Koha-bugs] [Bug 24030] GetItemsForInventory failing with "ORDER BY clause is not in SELECT list" In-Reply-To: <bug-24030-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24030-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24030-70-FqTP7fyEuN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24030 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Depends on|24002 | Blocks| |24002 Assignee|chris at bigballofwax.co.nz |jonathan.druart at bugs.koha-c | |ommunity.org Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002 [Bug 24002] Test suite is failing on MySQL 8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 22:57:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 21:57:16 +0000 Subject: [Koha-bugs] [Bug 24034] Capitalization on suggestion edit form: No Status In-Reply-To: <bug-24034-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24034-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24034-70-8TdJ66iYqY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24034 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Congratulations on your first patch, Lisette! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 12:23:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 11:23:35 +0000 Subject: [Koha-bugs] [Bug 23983] Contextualization of "Order" (verb) vs "Order" (noun) In-Reply-To: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23983-70-aVYDmzPOT9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23983 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |caroline.cyr-la-rose at inlibr |ity.org |o.com Keywords| |rel_19_11_candidate CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Great patch Caroline! I have edited the author of the patch, you should fix your local config. Unless it was expected, then let me know! Martin, I think it is a good last one to push on a string freeze day :) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 11:56:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 10:56:41 +0000 Subject: [Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images In-Reply-To: <bug-22445-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22445-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22445-70-5qg0r5JrSh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This development adds the |This development adds the release notes|ability to use alternative |ability to use alternative |cover art providers who |cover art providers who |provide covers openly via |provide covers openly via |consistent URLs. It adds |consistent URLs. Three new |three new system |system preferences are |preferences: |introduced, |* |`CustomCoverImagesURL`, |`CustomCoverImagesURL` - A |`CustomCoverImages` and |URL string from which to |`OPACCustomCoverImages`. |fetch cover images. | |* | |`CustomCoverImages` - | |Allowing administrators to | |enable custom cover images | |display in the staff | |client. | |* | |`OPACCustomCoverImages` - | |Allowing administrators to | |enable custom cover images | |display at the OPAC. | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 17:43:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 16:43:58 +0000 Subject: [Koha-bugs] [Bug 23732] Hold rules checker: show matched rules and syspref values to help understand why a hold is possible or not In-Reply-To: <bug-23732-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23732-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23732-70-J6NckOqomK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Medium patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 12:41:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 11:41:22 +0000 Subject: [Koha-bugs] [Bug 22834] Add a method for plugins to return the absolute path for bundled files In-Reply-To: <bug-22834-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22834-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22834-70-FlbVZfuSoa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22834 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |Plugin architecture |and plumbing | CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 00:47:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 23:47:55 +0000 Subject: [Koha-bugs] [Bug 23068] Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy In-Reply-To: <bug-23068-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23068-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23068-70-LldIkpFhZ4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068 Ed Veal <eveal at mckinneytexas.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |eveal at mckinneytexas.org --- Comment #31 from Ed Veal <eveal at mckinneytexas.org> --- Great job Kyle. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 18:59:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 17:59:18 +0000 Subject: [Koha-bugs] [Bug 24024] Holds Awaiting Pickup (Both Active and Expired) Sorts by Firstname In-Reply-To: <bug-24024-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24024-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24024-70-sI6EifgSIl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24024 --- Comment #3 from Nick Clemens <nick at bywatersolutions.com> --- Place a few holds for several patrons and set them all to waiting (check in, confirm the hold) Browse to Circulation->Holds awaiting pickup Try sorting the table on the patron's name Before patch: It sorts using firstname, and patron name is displayed as: Firtname Surname After patch: It sorts using lastname and patron name is displayed as: Surname, Firstname -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 17:17:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 16:17:14 +0000 Subject: [Koha-bugs] [Bug 23825] Object.t is failing - Exception not caught In-Reply-To: <bug-23825-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23825-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23825-70-gZa64LsFP6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94661|0 |1 is obsolete| | --- Comment #28 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95402 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95402&action=edit Bug 23825: Koha/Object.t might fail on a backtick If the SQL error message contains a backtick instead of a regular quote, the regex for throwing an exception did not work. Example: Incorrect datetime value: 'wrong_value' for column `koha_master`.`borrowers`.`lastseen` Note the backtics where the regex contains a regular quote. This patch makes it more flexible: it allows one \W character before the column name, even optional. Test plan: Run Koha/Object.t Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 17:29:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 16:29:55 +0000 Subject: [Koha-bugs] [Bug 24008] Attempting to delete a patron with outstanding credits should warn and block the deletion In-Reply-To: <bug-24008-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24008-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24008-70-LWf7V9arxm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24008 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_target -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 12:05:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 11:05:53 +0000 Subject: [Koha-bugs] [Bug 17003] Add API route to get checkout's renewability In-Reply-To: <bug-17003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17003-70-QU8ltRBsHC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17003 --- Comment #34 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Just working through bugs for the release notes.. Who sponsored this one? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 12:52:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 11:52:12 +0000 Subject: [Koha-bugs] [Bug 23983] Contextualization of "Order" (verb) vs "Order" (noun) In-Reply-To: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23983-70-GVTEJ0kbzc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23983 --- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I restored my signed-off patch as it corrects the commit's author. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 22:44:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 21:44:15 +0000 Subject: [Koha-bugs] [Bug 24034] Capitalization on suggestion edit form: No Status In-Reply-To: <bug-24034-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24034-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24034-70-P1ngzQsSKa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24034 --- Comment #2 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 95412 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95412&action=edit Bug 24034: Capitalization on suggestion edit form: No Status When editing a purchase suggestion, the "No status" option in the status pulldown is incorrectly capatalized. This patch fixes the capitazliation. To test: 1) Create a purchase suggestion in the Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 03:10:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 02:10:58 +0000 Subject: [Koha-bugs] [Bug 23640] L1 cache too long in SIP Server In-Reply-To: <bug-23640-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23640-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23640-70-iQoq28xDAd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23640 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #12 from David Cook <dcook at prosentient.com.au> --- (In reply to Katrin Fischer from comment #11) > I marked my original bug duplicate. I would really like to see this fixed > and pondering an update to 'major' - different due dates between circ and > self check and other different behaviour are not good and hard to 'debug' > for circ staff. That's true. Troubleshooting this issue drove me a bit crazy with the SIP server, so upgrading the severity sounds good to me. Doing that now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 12:25:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 11:25:48 +0000 Subject: [Koha-bugs] [Bug 15262] Run Koha Run. Koha search should be fast again. In-Reply-To: <bug-15262-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15262-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15262-70-4scvpcktnL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15262 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|24027 | See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24027 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24027 [Bug 24027] Adding multiple items is slow -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 11:07:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 10:07:22 +0000 Subject: [Koha-bugs] [Bug 24030] New: GetItemsForInventory failing with "ORDER BY clause is not in SELECT list" Message-ID: <bug-24030-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24030 Bug ID: 24030 Summary: GetItemsForInventory failing with "ORDER BY clause is not in SELECT list" Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 24002 t/db_dependent/Items/GetItemsForInventory.t .. 1/9 DBD::mysql::st execute failed: Expression #1 of ORDER BY clause is not in SELECT list, references column 'koha_kohadev.items.cn_sort' which is not in SELECT list; this is incompatible with DISTINCT [for Statement " SELECT DISTINCT(items.itemnumber), barcode, itemcallnumber, title, author, biblio.biblionumber, biblio.frameworkcode, datelastseen, homebranch, location, notforloan, damaged, itemlost, withdrawn, stocknumber FROM items LEFT JOIN biblio ON items.biblionumber = biblio.biblionumber LEFT JOIN biblioitems on items.biblionumber = biblioitems.biblionumber ORDER BY items.cn_sort, itemcallnumber, title"] at /kohadevbox/koha/C4/Items.pm line 838. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002 [Bug 24002] Test suite is failing on MySQL 8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 17:44:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 16:44:08 +0000 Subject: [Koha-bugs] [Bug 23732] Hold rules checker: show matched rules and syspref values to help understand why a hold is possible or not In-Reply-To: <bug-23732-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23732-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23732-70-KF94iz2OBL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 --- Comment #1 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- Created attachment 95435 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95435&action=edit Bug 23732: Hold rules checker == Test plan == - apply - yarn build - generate translations - try to place a hold, on the Hold details page you should see a "Holding rules" blue button - click it - check that the info if consistent with the holding rules, the syspref and the current and future number of holds of the patron - place the hold - set maxreserves syspref to 1 - try to place a hold - see in the holds rules checker that the maxreserves is highlighted in red (it the only thing supporting highlighting) - restore maxreserves syspref - test that sabotaging the matched circulation rule or hold policy is reflected (the limits) in the hold rules checker -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 15:03:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 14:03:17 +0000 Subject: [Koha-bugs] [Bug 23985] The method Koha::Item-> is not covered by tests! In-Reply-To: <bug-23985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23985-70-iHHm34gOW3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23985 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- I've checked the queries and am happy they match.. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 22:44:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 21:44:33 +0000 Subject: [Koha-bugs] [Bug 24034] Capitalization on suggestion edit form: No Status In-Reply-To: <bug-24034-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24034-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24034-70-VI1LpLMAvy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24034 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrew at bywatersolutions.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 01:46:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 00:46:07 +0000 Subject: [Koha-bugs] [Bug 11447] Hide existing item(s) that is/are linked to the bibliographic record when adding a new item In-Reply-To: <bug-11447-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11447-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11447-70-21Hh3MJFZ7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11447 Cori Lynn Arnold <carnold at dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carnold at dgiinc.com --- Comment #2 from Cori Lynn Arnold <carnold at dgiinc.com> --- Confirmed this is still the behavior in 19.05. Can we not just move this information to the bottom of the page below the interface for adding an item? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 12:59:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 11:59:58 +0000 Subject: [Koha-bugs] [Bug 24025] Make CodeMirror content searchable In-Reply-To: <bug-24025-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24025-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24025-70-7Bj0WqNGHT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24025 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- It seems to work on their demo, without additional addon: https://codemirror.net/demo/complete.html Maybe we need to upgrade (no idea how big it could be) to the newest version, but I do not see something in the changelog. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 13:12:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 12:12:34 +0000 Subject: [Koha-bugs] [Bug 24027] Adding multiple items is slow In-Reply-To: <bug-24027-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24027-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24027-70-95mgkQ83un@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24027 --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I understand the need of the UI patch, but I am worry it will not fit all needs, as it adds an extra step. I am pretty sure catalogers want to see if the last action did what they wanted :) We have something similar for the batch item edit/del tools, driven by a sysprefs. We could hardcoded it for now (50, 100?) and see if it passes QA :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 14:41:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 13:41:12 +0000 Subject: [Koha-bugs] [Bug 24043] ILL module can't show requests from more than one backend In-Reply-To: <bug-24043-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24043-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24043-70-MfBcANWYTa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24043 --- Comment #3 from Magnus Enger <magnus at libriotech.no> --- Looks like this has been fixed in master. In the example I looked at there was a bunch of FreeForm requests, then a bunch of Libris Requests, if you look at them in order of increasing illrequest_id. As long as the code was looping over the early FreeForm requests, meta.settings.oInit.originalData[0].capabilities contained only FreeForm statuses. When it came time to look at the Libris erquests, meta.settings.oInit.originalData[0].capabilities contained both FreeForm and Libris statuses, which ensures the status names can be displayed correctly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 23:37:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 22:37:24 +0000 Subject: [Koha-bugs] [Bug 24000] Some modules do not return 1 In-Reply-To: <bug-24000-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24000-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24000-70-xaZkSBihdR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24000 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Some modules does not |Some modules do not return |return 1 |1 CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 12:51:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 11:51:29 +0000 Subject: [Koha-bugs] [Bug 23983] Contextualization of "Order" (verb) vs "Order" (noun) In-Reply-To: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23983-70-SU2sjIB6Hu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23983 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95360|1 |0 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 11:10:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 10:10:12 +0000 Subject: [Koha-bugs] [Bug 24043] New: ILL module can't show requests from more than one backend Message-ID: <bug-24043-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24043 Bug ID: 24043 Summary: ILL module can't show requests from more than one backend Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: ILL Assignee: koha-bugs at lists.koha-community.org Reporter: magnus at libriotech.no A customer has 6 requests created with the FreeForm backend and 10 with the Libris backend. The table of requests tries to display a mix of these, but shows this error in the dev tools console: Uncaught TypeError: Cannot read property 'name' of undefined at createStatus (ill-requests.pl:714) at jquery.dataTables.min_18.1105000.js:18 at Object.b.fnGetData (jquery.dataTables.min_18.1105000.js:12) at B (jquery.dataTables.min_18.1105000.js:16) at Ia (jquery.dataTables.min_18.1105000.js:14) at mb (jquery.dataTables.min_18.1105000.js:66) at T (jquery.dataTables.min_18.1105000.js:30) at ia (jquery.dataTables.min_18.1105000.js:48) at HTMLTableElement.<anonymous> (jquery.dataTables.min_18.1105000.js:95) at Function.each (jquery-2.2.3.min_18.1105000.js:2) The code around ill-requests.pl line 714 looks like this: var createStatus = function(data, type, row, meta) { var origData = meta.settings.oInit.originalData; if (origData.length > 0) { var status_name = meta.settings.oInit.originalData[0].capabilities[ row.status ].name; switch( status_name ) { case "New request": return _("Ny förfrågan"); case "Requested": return _("Begärd"); Now if I manipulate Koha/REST/V1/Illrequests.pm line 56 to look like this: # Get all requests my @requests = Koha::Illrequests->as_list; # @requests = @requests[6..9]; I can choose which requests to display in the table, by changing the numbers in the brackets. Displaying only the FreeForm requests works fine, and displaying only the Libris requests works fine. So it looks like the problem is to display a mix. I am not sure I completely understand the JS here, but I have a hunch that meta.settings.oInit.originalData[0].capabilities[ means we are trying to use the metadata and the capabilities of the first ([0]) request returned to display *all* the requests. And the backends have different statuses, so trying to look up a Libris status in the set of FreeForm statuses fails? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 17:51:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 16:51:09 +0000 Subject: [Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page In-Reply-To: <bug-12502-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12502-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12502-70-VcffOJSXeD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95418|0 |1 is obsolete| | --- Comment #43 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 95440 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95440&action=edit Bug 12502: (QA follow-up) Remove the Save button Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 13:33:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 12:33:23 +0000 Subject: [Koha-bugs] [Bug 24027] Adding multiple items is slow In-Reply-To: <bug-24027-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24027-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24027-70-g2DvpFh1zn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24027 --- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (for the OPAC we have OpacMaxItemsToDisplay, to limit the number of items to display on the biblio detail view) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 09:04:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 08:04:41 +0000 Subject: [Koha-bugs] [Bug 23846] Handle records with broken MARCXML on the bibliographic detail view In-Reply-To: <bug-23846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23846-70-8qSIjBaFhO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23846 --- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 12:38:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 11:38:39 +0000 Subject: [Koha-bugs] [Bug 22709] Add hooks to notify plugins of biblio and item changes In-Reply-To: <bug-22709-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22709-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22709-70-0ecytSX7Dl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22709 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Tools |Plugin architecture -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 15:31:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 14:31:57 +0000 Subject: [Koha-bugs] [Bug 23089] Elasticsearch - cannot sort on non-text fields In-Reply-To: <bug-23089-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23089-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23089-70-gRRMix3rv6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23089 --- Comment #17 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95390 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95390&action=edit Bug 23089: [19.05 and earlier] Use integer field directly for sorting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 23:14:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 22:14:12 +0000 Subject: [Koha-bugs] [Bug 24033] Fix column labelling on basket summary page (ecost) In-Reply-To: <bug-24033-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24033-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24033-70-qXAGfQEMly@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24033 Lisette Scheer <lisetteslatah at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95448|0 |1 is obsolete| | --- Comment #2 from Lisette Scheer <lisetteslatah at gmail.com> --- Created attachment 95449 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95449&action=edit Bug 24033 : Fix column labelling on basket summary page (ecost) When viewing a basket, some of the column names are unclear and are different than the terms used for the same field on the order form. This patch edits the column titles to match To test: 1)In acquisitions, create a budget. 2)In acquisitions, create a fund. 3)In acquisitions, create a vendor. 4)In acquisitions, create a basket and add a test item to the basket. 5)Observe the column titles ecost tax inc. and ecost tax exc. Check the column visibility settings if you don't see the columns. 6)Apply the patch. 7)Observe the column titles have been updated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 15:13:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 14:13:43 +0000 Subject: [Koha-bugs] [Bug 23767] Spent and Ordered total values don't include child funds on acqui-home In-Reply-To: <bug-23767-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23767-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23767-70-BNWlAGW7ln@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23767 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #10 from Séverine Queune <severine.queune at bulac.fr> --- Hi Martin, Something is still bothering me with the 'total available'. To me, this total should add the 'total available' for parent funds, and the remove the 'ordered' and 'spent' for child funds. Without the patch, the child amount for 'ordered' and 'spent' are ignored. With the patch, the child 'total available' is added to the global total. Not sure to be enough, so you can find here the I got with the patch (problem with the last amount : I've got 10000€ in excess): PAR1 Parent 1 10 000,00 100,00 0,00 9 900,00 CHILD1 Child 1 5 000,00 0,00 10,00 4 990,00 CHILD2 Child 2 5 000,00 1,00 0,00 4 999,00 PAR2 Parent 2 10 000,00 0,00 0,00 10 000,00 Total 20 000,00 101,00 10,00 29 889,00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 13:01:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 12:01:57 +0000 Subject: [Koha-bugs] [Bug 23983] Contextualization of "Order" (verb) vs "Order" (noun) In-Reply-To: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23983-70-t456B1Vaz2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23983 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #18 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Jonathan Druart from comment #15) > I restored my signed-off patch as it corrects the commit's author. Good catch, should all be sorted now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 12:52:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 11:52:44 +0000 Subject: [Koha-bugs] [Bug 24026] Wrong parameters in Koha/Templates/Plugin/CirculationRules.pm and smart-rules.tt In-Reply-To: <bug-24026-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24026-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24026-70-iBBgHrPfrb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24026 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 10:31:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 09:31:08 +0000 Subject: [Koha-bugs] [Bug 17787] Suppressed items seem to be included in count of search results In-Reply-To: <bug-17787-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17787-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17787-70-0ZUxtsAiTu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17787 Ray Delahunty <r.delahunty at arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty at arts.ac.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 23:38:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 22:38:16 +0000 Subject: [Koha-bugs] [Bug 23679] Software error when trying to transfer an unknown barcode In-Reply-To: <bug-23679-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23679-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23679-70-SmPdhPAxrb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23679 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #14 from Lucas Gass <lucas at bywatersolutions.com> --- backported to 18.11.x for 18.11.11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 12:08:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 11:08:48 +0000 Subject: [Koha-bugs] [Bug 24027] Adding multiple items is slow In-Reply-To: <bug-24027-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24027-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24027-70-m8ZAWCZacH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24027 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|minor |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 20:14:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 19:14:13 +0000 Subject: [Koha-bugs] [Bug 23680] Can't open 'Edit items' or 'Add item' links in new tab - tab is closed immediately In-Reply-To: <bug-23680-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23680-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23680-70-SNGdC0wmCU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23680 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_19_05_candidate CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 17:51:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 16:51:03 +0000 Subject: [Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page In-Reply-To: <bug-12502-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12502-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12502-70-18Dt4rUu6W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91564|0 |1 is obsolete| | --- Comment #42 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 95439 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95439&action=edit Bug 12502: (follow-up) Use modal to add/edit order notes Replace inputs to edit notes by a link opening a modal, similar to the basket summary page. This makes it possible for the notes to appear in the datatable exports. Also fix exporting with the export as csv button at the bottom of the page to export notes. Test plan : 1) In the late orders table (acqui/lateorders.pl), a link should appear in both the internal and vendor note column, following the current value if it exist. -> This link should read "Add ..." if there is no existing note or "Edit ..." if there is. 2) Click on the link. A modal should appear. Confirm that saving a note works as expected. 3) Try exporting to any format using either the button at the top of the table or the one at the bottom of the page. -> The three new columns and their values should appear in the export. Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 12:41:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 11:41:33 +0000 Subject: [Koha-bugs] [Bug 23050] Plugins: Add hook to add a tab in intranet biblio details page In-Reply-To: <bug-23050-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23050-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23050-70-v2sVlangUI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23050 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |Plugin architecture |and plumbing | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 14:16:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 13:16:10 +0000 Subject: [Koha-bugs] [Bug 23983] Contextualization of "Order" (verb) vs "Order" (noun) In-Reply-To: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23983-70-FeVauVEILP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23983 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 11:12:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 10:12:50 +0000 Subject: [Koha-bugs] [Bug 24030] GetItemsForInventory failing with "ORDER BY clause is not in SELECT list" In-Reply-To: <bug-24030-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24030-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24030-70-A6R8xpSksi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24030 --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95357 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95357&action=edit Bug 24030: Fix GetItemsForInventory under MySQL 8 t/db_dependent/Items/GetItemsForInventory.t .. 1/9 DBD::mysql::st execute failed: Expression #1 of ORDER BY clause is not in SELECT list, references column 'koha_kohadev.items.cn_sort' which is not in SELECT list; this is incompatible with DISTINCT [for Statement " SELECT DISTINCT(items.itemnumber), barcode, itemcallnumber, title, author, biblio.biblionumber, biblio.frameworkcode, datelastseen, homebranch, location, notforloan, damaged, itemlost, withdrawn, stocknumber FROM items LEFT JOIN biblio ON items.biblionumber = biblio.biblionumber LEFT JOIN biblioitems on items.biblionumber = biblioitems.biblionumber ORDER BY items.cn_sort, itemcallnumber, title"] at /kohadevbox/koha/C4/Items.pm line 838. We simply follow what the error says, and add items.cn_sort to the SELECT list -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 17:51:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 16:51:15 +0000 Subject: [Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page In-Reply-To: <bug-12502-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12502-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12502-70-TFJHMj11xW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95419|0 |1 is obsolete| | --- Comment #44 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 95441 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95441&action=edit Bug 12502: (follow-up) Adds formatting for datatables export Add a format option to the datatables export that remove .noExport elements present in a data cell, just as .noExport columns are not exported. To test: 1. For late orders (which uses .noExport elements in data cells) : Export data in any format using the export button at the top of the datatable. => data should exclude "Add/Edit note" label, but otherwise look the same as before the patch. 2. Try exporting data in other datatables in Koha and make sure exported data is the same before and after applying the patch. Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 12:51:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 11:51:40 +0000 Subject: [Koha-bugs] [Bug 23983] Contextualization of "Order" (verb) vs "Order" (noun) In-Reply-To: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23983-70-kD1TZTmntB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23983 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95361|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 12:53:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 11:53:54 +0000 Subject: [Koha-bugs] [Bug 24026] Wrong parameters in Koha/Templates/Plugin/CirculationRules.pm and smart-rules.tt In-Reply-To: <bug-24026-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24026-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24026-70-S1oKkuYLEe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24026 --- Comment #7 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Jonathan Druart from comment #3) > See bug 22847. We should never call ->Search in this template, we want > to display the values in the DB, not the calculated ones We should never call 'Get', we should always use 'Search' - I think just the comment was wrong -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 17:47:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 16:47:47 +0000 Subject: [Koha-bugs] [Bug 23732] Hold rules checker: show matched rules and syspref values to help understand why a hold is possible or not In-Reply-To: <bug-23732-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23732-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23732-70-53eqoWYShf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 Arthur Suzuki <arthur.suzuki at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 15:01:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 14:01:23 +0000 Subject: [Koha-bugs] [Bug 23985] The method Koha::Item-> is not covered by tests! In-Reply-To: <bug-23985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23985-70-j181zYyLsl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23985 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95352|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95389 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95389&action=edit Bug 23985: (bug 21206 follow-up) Fix checkout list when "Hold pickup library match" not set This patch restores the behavior prior to bug 21206. If "Hold pickup library match" is "Not set", then hold_fulfillment_policy equals an empty string. Test plan: 1. Go to "Circulation and fines rules" 2. Under "Default checkout, hold and return policy", unset "Hold pickup library match" and Save 3. Place a hold on one item for one patron 4. Try to checkout the same item with another patron => Without this patch you the checkout list do not show, and the logs contain "The method Koha::Item-> is not covered by tests!" => With this patch applied you see the checkout list QA will take care of comparing the statement with the one before bug 21206 and make sure they are equivalent Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 20:52:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 19:52:13 +0000 Subject: [Koha-bugs] [Bug 23185] Koha::Objects supports passing through 'update' which means we can side step 'set' + 'store' In-Reply-To: <bug-23185-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23185-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23185-70-eQxacgdiCh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23185 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|critical |major -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 15:20:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 14:20:45 +0000 Subject: [Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page In-Reply-To: <bug-12502-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12502-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12502-70-AZnolYAzDw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 --- Comment #39 from Maryse Simard <maryse.simard at inlibro.com> --- Created attachment 95419 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95419&action=edit Bug 12502: (follow-up) Adds formatting for datatables export Add a format option to the datatables export that remove .noExport elements present in a data cell, just as .noExport columns are not exported. To test: 1. For late orders (which uses .noExport elements in data cells) : Export data in any format using the export button at the top of the datatable. => data should exclude "Add/Edit note" label, but otherwise look the same as before the patch. 2. Try exporting data in other datatables in Koha and make sure exported data is the same before and after applying the patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 18:01:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 17:01:09 +0000 Subject: [Koha-bugs] [Bug 23732] Hold rules checker: show matched rules and syspref values to help understand why a hold is possible or not In-Reply-To: <bug-23732-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23732-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23732-70-vciPmWYUMg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95436|0 |1 is obsolete| | --- Comment #5 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Created attachment 95445 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95445&action=edit Bug 23732: Add unit tests == test plan == 1. prove -r t/db_dependent/Reserves 2. Apply bugzilla 3. prove t/db_dependent/Reserves/HoldRulesChecker.t 4. prove -r t/db_dependent/Reserves -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 14:44:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 13:44:38 +0000 Subject: [Koha-bugs] [Bug 23932] Typo on 'aqinvoice_adjustments.encumber_open' description in Koha Schema In-Reply-To: <bug-23932-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23932-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23932-70-r0EfxMxs71@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23932 --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Thanks for your first patch Severine, it's lovely to have you aboard :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 23:07:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 22:07:29 +0000 Subject: [Koha-bugs] [Bug 24033] Fix column labelling on basket summary page (ecost) In-Reply-To: <bug-24033-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24033-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24033-70-ngeot9bRCF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24033 Lisette Scheer <lisetteslatah at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 19:49:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 18:49:57 +0000 Subject: [Koha-bugs] [Bug 24037] New: Koha manual missing System Preference documentation for GDPR Message-ID: <bug-24037-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24037 Bug ID: 24037 Summary: Koha manual missing System Preference documentation for GDPR Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org With the new system preference in 19.05 that works with GDPR, it was brought to our attention that the original system preference GDPR_policy is not in the 18.11 manual. It is in the 19.05 manual. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 11:12:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 10:12:45 +0000 Subject: [Koha-bugs] [Bug 24030] GetItemsForInventory failing with "ORDER BY clause is not in SELECT list" In-Reply-To: <bug-24030-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24030-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24030-70-gQVzr3E919@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24030 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95356 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95356&action=edit Bug 24030: Remove OldWay comparaison from GetItemsForInventory.t This has been introduced to make sure there were no regression at a given point. But now we are fixing the "old way" so it does not make sense to keep it any longer -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 12:52:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 11:52:51 +0000 Subject: [Koha-bugs] [Bug 24026] Wrong parameters in Koha/Templates/Plugin/CirculationRules.pm and smart-rules.tt In-Reply-To: <bug-24026-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24026-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24026-70-Xn6OKaTv1D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24026 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95366|0 |1 is obsolete| | --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95370 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95370&action=edit Bug 24026: (bug 22847 follow-up) Display correctly max[onsite]issueqty (not the propagated ones) See bug 22847. We should never call ->Search in this template, we want to display the values in the DB, not the calculated ones Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 17:23:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 16:23:52 +0000 Subject: [Koha-bugs] [Bug 23825] Object.t is failing - Exception not caught In-Reply-To: <bug-23825-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23825-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23825-70-hPplhABWDQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 --- Comment #33 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 18:16:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 17:16:41 +0000 Subject: [Koha-bugs] [Bug 23854] Cannot edit a suggestion In-Reply-To: <bug-23854-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23854-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23854-70-ZoUobYg1ia@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23854 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 11:04:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 10:04:38 +0000 Subject: [Koha-bugs] [Bug 15654] Integrating a cash register system into Koha: An Example In-Reply-To: <bug-15654-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15654-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15654-70-XAjIV4x6wQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15654 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- With bug 23321 having now been pushed, we should probably resurrect this bug as the exposure of that feature via API's? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 21:20:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 20:20:30 +0000 Subject: [Koha-bugs] [Bug 24040] New: Browser Tab closing when open through Manage Staged marc records Message-ID: <bug-24040-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24040 Bug ID: 24040 Summary: Browser Tab closing when open through Manage Staged marc records Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org There seems to be an issue where a browser tab will close when selecting "New Item" from a bib record that was opened from the "Manage staged MARC records" page. There seems to be a similar issue reported in bug #24011. https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24011 To reproduce: 1. Open a staged MARC record 2. Click to open one of the biblio records. 3. Click "New" then "New Item". 4. Watch the browser tab close. The library that is reporting this are using a workaround that consists of reopening the last closed tab which will then stay open on the "Add item" screen. This also seems familiar in this bug https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23680 All these have been reported in 19.05. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 15:04:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 14:04:05 +0000 Subject: [Koha-bugs] [Bug 23985] The method Koha::Item-> is not covered by tests! In-Reply-To: <bug-23985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23985-70-AcIL3vbwEK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23985 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 10:11:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 09:11:16 +0000 Subject: [Koha-bugs] [Bug 24028] bug in calorie mama application, baseball ball is recognized as an egg In-Reply-To: <bug-24028-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24028-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24028-70-tgkB0DPEbQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24028 --- Comment #1 from Taghreed <taghreed.alzahrani at sjsu.edu> --- prerequisites: you have Calorie Mama application step to reproduce: pick input the same shape of the egg and similar color to it will result to a wrong value. Ex picture: open application, select baseball ball then result will be wrong. actual results: egg expected results: baseball ball or object is not recognized as a food -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 14:16:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 13:16:12 +0000 Subject: [Koha-bugs] [Bug 23983] Contextualization of "Order" (verb) vs "Order" (noun) In-Reply-To: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23983-70-gsx28TCOu0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23983 --- Comment #19 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 15:21:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 14:21:00 +0000 Subject: [Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page In-Reply-To: <bug-12502-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12502-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12502-70-NzFcMsEwyQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 Maryse Simard <maryse.simard at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #40 from Maryse Simard <maryse.simard at inlibro.com> --- Thank you for testing and for your comment. I would say the different behaviors for the export buttons is expected since the button as the top is a part of the datatables plugin and uses it's filters to determine which row to export and the button at the bottom is part of Koha and uses the checkboxes to filter rows to export. I agree this behavior might be questionable, but I believe it is not in the scope of this bug which is about order notes. I did forget to remove the "Save notes" button, thank you for the catch. I've also added a patch to remove the "Add/Edit note" label. It adds a new formatting option to the datatables to accept the use of the .noExport class on data cell elements to remove them from exported data. It is now ready to be tested again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 13:40:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 12:40:48 +0000 Subject: [Koha-bugs] [Bug 23713] Subscription add form broken for translations In-Reply-To: <bug-23713-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23713-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23713-70-F5T3QbYb4b@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23713 --- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- This is weird, and this patch is just cheating. Any ideas how we could avoid that? Upping severity, backport this one urgently! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 15:20:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 14:20:41 +0000 Subject: [Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page In-Reply-To: <bug-12502-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12502-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12502-70-eiI6US7wii@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 --- Comment #38 from Maryse Simard <maryse.simard at inlibro.com> --- Created attachment 95418 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95418&action=edit Bug 12502: (QA follow-up) Remove the Save button -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 11:09:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 10:09:07 +0000 Subject: [Koha-bugs] [Bug 24029] marcrecord2csv.t displays a SQL error "Truncated incorrect DOUBLE value: '01e'" In-Reply-To: <bug-24029-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24029-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24029-70-H7OejrB35J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24029 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 14:16:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 13:16:21 +0000 Subject: [Koha-bugs] [Bug 23530] Opac-basket.pl script accidentally displays 'hidden' items In-Reply-To: <bug-23530-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23530-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23530-70-U9Z0WIJaSe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23530 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lucas at bywatersolutions.com --- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Lucas, has this been missed? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 12:25:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 11:25:08 +0000 Subject: [Koha-bugs] [Bug 15262] Run Koha Run. Koha search should be fast again. In-Reply-To: <bug-15262-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15262-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15262-70-ADXBpyC3IH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15262 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23035, 23414, 24027 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23035 [Bug 23035] Intranet search is slow if thousands of items are in the biblios shown in the search results https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23414 [Bug 23414] Improve performance of C4/XSLT/buildKohaItemsNamespace https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24027 [Bug 24027] Adding multiple items is slow -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 17:52:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 16:52:23 +0000 Subject: [Koha-bugs] [Bug 23732] Hold rules checker: show matched rules and syspref values to help understand why a hold is possible or not In-Reply-To: <bug-23732-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23732-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23732-70-QIb58YC34k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 --- Comment #3 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- Created attachment 95443 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95443&action=edit Screen capture - Check this out :) Screen capture of our nice hold rules checker tool :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 20:49:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 19:49:58 +0000 Subject: [Koha-bugs] [Bug 22741] Koha::Patron->store must not log updated_on changes (random failure of test BorrowerLogs and TrackLastPatronActivity) In-Reply-To: <bug-22741-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22741-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22741-70-Vd9cDEpBU7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22741 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|RM_priority | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 11:54:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 10:54:45 +0000 Subject: [Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images In-Reply-To: <bug-22445-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22445-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22445-70-IWN3JBJFdy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This patchset adds three |This development adds the release notes|new system preferences: |ability to use alternative |* |cover art providers who |`CustomCoverImagesURL` - A |provide covers openly via |URL string from which to |consistent URLs. It adds |fetch cover images. |three new system |* |preferences: |`CustomCoverImages` - |* |Allowing administrators to |`CustomCoverImagesURL` - A |enable custom cover images |URL string from which to |display in the staff |fetch cover images. |client. |* |* |`CustomCoverImages` - |`OPACCustomCoverImages` - |Allowing administrators to |Allowing administrators to |enable custom cover images |enable custom cover images |display in the staff |display at the OPAC. |client. | |* | |`OPACCustomCoverImages` - | |Allowing administrators to | |enable custom cover images | |display at the OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 12:49:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 11:49:58 +0000 Subject: [Koha-bugs] [Bug 24000] Koha::Item::Search::Field does not return 1 In-Reply-To: <bug-24000-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24000-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24000-70-K1KuN994iq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24000 --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #3) > Is it the only one? IIRC you fixed several ones a few years ago? I didnt look for it now. Just came across this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 09:04:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 08:04:40 +0000 Subject: [Koha-bugs] [Bug 23846] Handle records with broken MARCXML on the bibliographic detail view In-Reply-To: <bug-23846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23846-70-fsRYwPurvg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23846 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 12:41:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 11:41:43 +0000 Subject: [Koha-bugs] [Bug 23230] Make Koha::Plugins::Base::_version_compare OO In-Reply-To: <bug-23230-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23230-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23230-70-2Lv9qtksQw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23230 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |Plugin architecture |and plumbing | CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 20:49:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 19:49:16 +0000 Subject: [Koha-bugs] [Bug 19919] Writing off a Lost Item Fee marks as "Paid for by patron" In-Reply-To: <bug-19919-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19919-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19919-70-m15Hj45dCA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19919 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|RM_priority | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 11:56:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 10:56:12 +0000 Subject: [Koha-bugs] [Bug 20948] Hold requests on detail.pl In-Reply-To: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20948-70-UkAOQzvzPM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I would be happy to have a look at this one if someone can provide a step-by-step plan to recreate the problem. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 22:53:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 21:53:52 +0000 Subject: [Koha-bugs] [Bug 24033] Fix column labelling on basket summary page (ecost) In-Reply-To: <bug-24033-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24033-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24033-70-km7ecbKbl7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24033 Lisette Scheer <lisetteslatah at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lisetteslatah at gmail.com |ity.org | CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 12:38:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 11:38:23 +0000 Subject: [Koha-bugs] [Bug 21073] Improve plugin performance In-Reply-To: <bug-21073-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21073-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21073-70-J2Mpp9WBiO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21073 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |Plugin architecture |and plumbing | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 13:01:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 12:01:24 +0000 Subject: [Koha-bugs] [Bug 23983] Contextualization of "Order" (verb) vs "Order" (noun) In-Reply-To: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23983-70-ftY1PVXLl2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23983 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95360|0 |1 is obsolete| | --- Comment #16 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 95371 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95371&action=edit Bug 23983: Contextualization of 'Order' (verb) vs 'Order' (noun) This patch adds context (word class, either verb or noun) to the word 'Order' when it is displayed alone in the acquisitions module. The following files have been modified: basket.tt neworderbiblio.tt newordersubscription.tt newordersuggestion.tt ordered.tt parcel.tt spent.tt transferorder.tt uncertainprice.tt z3950_search.tt To test, check all those pages in English to make sure there is no change. 1- Go to Acquisitions 2- Create a basket 3- Add to basket from an existing record (neworderbiblio) 4- Add to basket from a subscription (newordersubscription) 5- Add to basket from a suggestion (newordersuggestion) 6- Add to basket from an external source (z3950_search) 7- In one of the orders, check the uncertain price box 8- Check the basket display table (basket) 9- Click transfer on one of the orders (transferorder) 10- Go to the vendor page and click on 'Uncertain prices' (uncertainprice) 11- Click on 'Receive parcel' (parcel) 12- Go to the Acquisitions home page and click on the amount for 'ordered' (ordered) 13- Go to the Acquisitions home page and click on the amount for 'spent' (spent) Next, install a new language (fr-CA used as example) 1- translate create fr-CA 2- open fr-CA-messages.po and add a translation for Order (verb) and Order (noun) (it doesn't have to be real, just write something different for each) 3- translate install fr-CA 4- in the system preferences, enable the french language in 'language' 5- change interface language to french Redo the tests above to make sure the word you put in the translation for the verb is in the places where 'Order' should be a verb and that the translation you put in for the noun is in the places where 'Order' should be a noun Signed-off-by: Julian Maurice <julian.maurice at biblibre.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 11:57:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 10:57:37 +0000 Subject: [Koha-bugs] [Bug 17492] Show warning if patron's age is out of category limits In-Reply-To: <bug-17492-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17492-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17492-70-6W8IA76njW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17492 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|new feature |enhancement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 14:19:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 13:19:06 +0000 Subject: [Koha-bugs] [Bug 24022] Z3950Responder tests are failing randomly In-Reply-To: <bug-24022-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24022-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24022-70-rgdCNBFeId@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24022 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- This all looks sane to me, passing QA and pushing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 20:49:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 19:49:46 +0000 Subject: [Koha-bugs] [Bug 23057] If checked_in_ok is set and item is not checked out, alert flag is supressed for *any* reason In-Reply-To: <bug-23057-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23057-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23057-70-mHZAdGhE5X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23057 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|RM_priority | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 11:07:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 10:07:22 +0000 Subject: [Koha-bugs] [Bug 24002] Test suite is failing on MySQL 8 In-Reply-To: <bug-24002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24002-70-tBiBbwFi18@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24002 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24030 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24030 [Bug 24030] GetItemsForInventory failing with "ORDER BY clause is not in SELECT list" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 13:00:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 12:00:22 +0000 Subject: [Koha-bugs] [Bug 21582] Use CodeMirror for *UserJS & *UserCSS In-Reply-To: <bug-21582-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21582-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21582-70-hfJ0yX4wiG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21582 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24025 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24025 [Bug 24025] Make CodeMirror content searchable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 11:55:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 10:55:23 +0000 Subject: [Koha-bugs] [Bug 11808] When searching for a cardnumber in the intranet, also try to search for it on the LDAP server if one is configured and add/update user In-Reply-To: <bug-11808-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11808-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11808-70-Met2a9P9gc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11808 Rui <astronomypt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |astronomypt at gmail.com --- Comment #13 from Rui <astronomypt at gmail.com> --- This functionality is absolutely essential in some institutional/corporate environments, and is a much better idea than using scripts to synchronize all users. We've just tested the patches and all is working as expected from a user perspective. However, there is room for improvement: a) when the user doesn't exist locally, if you checkout using circulation introducing cardnumber, the user is added as expected. However, in my opinion, it should be added as well if "Search patrons" is used and cardnumber is introduced in that form, which doesn't happen at the moment. b) if the user doesn't have branch code defined in the AD an error regarding FK constraints is produced. Koha should deal with that gracefully. Thanks a lot for your work. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 15:03:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 14:03:26 +0000 Subject: [Koha-bugs] [Bug 23985] The method Koha::Item-> is not covered by tests! In-Reply-To: <bug-23985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23985-70-Rz5pdZZgSj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23985 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 12:41:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 11:41:52 +0000 Subject: [Koha-bugs] [Bug 23237] Plugin allow [% INCLUDE %] from template In-Reply-To: <bug-23237-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23237-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23237-70-fDi3tlKQ3K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23237 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |Plugin architecture |and plumbing | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 17:24:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 16:24:03 +0000 Subject: [Koha-bugs] [Bug 21959] Batch item modification - ability to apply regular expression on text fields In-Reply-To: <bug-21959-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21959-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21959-70-gmBEr1dOH0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21959 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92871|0 |1 is obsolete| | --- Comment #24 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 95433 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95433&action=edit Bug 21959: use a link instead of a checkbox Signed-off-by: Mathilde Formery <mathilde.formery at ville-nimes.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 14:48:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 13:48:01 +0000 Subject: [Koha-bugs] [Bug 24033] New: Fix column labelling on basket summary page (ecost) Message-ID: <bug-24033-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24033 Bug ID: 24033 Summary: Fix column labelling on basket summary page (ecost) Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: trivial Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org The table of orders on the basket summary page includes a lot of columns with different prices. Two are not labelled well: - ecost tax inc. - ecost tax exc. Apart from the capitalization issue, I think it's not clear that this should mean 'estimated cost'. I suggest changing this to the term used on the order form: - Budgeted cost tax inc. - Budgeted cost tax exc. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 12:38:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 11:38:32 +0000 Subject: [Koha-bugs] [Bug 24026] Wrong parameters in Koha/Templates/Plugin/CirculationRules.pm and smart-rules.tt In-Reply-To: <bug-24026-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24026-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24026-70-XM3X17MseY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24026 --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95366 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95366&action=edit Bug 24026: (bug 22847 follow-up) Display correctly max[onsite]issueqty (not the propagated ones) See bug 22847. We should never call ->Search in this template, we want to display the values in the DB, not the calculated ones -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 01:49:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 00:49:05 +0000 Subject: [Koha-bugs] [Bug 11985] Auto insert MARC 005 (Date and Time of Latest Transaction) detail when saving new catalog record In-Reply-To: <bug-11985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11985-70-YF7KfiKAkz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11985 Cori Lynn Arnold <carnold at dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carnold at dgiinc.com Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #2 from Cori Lynn Arnold <carnold at dgiinc.com> --- Tested in Basic and Advanced Editor. Both interfaces automatically update the 005 with the current time upon hitting save. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 17:50:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 16:50:57 +0000 Subject: [Koha-bugs] [Bug 12502] Add columns for note, order number and ISBN to late orders page In-Reply-To: <bug-12502-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12502-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12502-70-inwZlZ9Cef@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12502 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #87236|0 |1 is obsolete| | --- Comment #41 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 95438 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95438&action=edit Bug 12502: Add vendor note, internal note, ordernumber and isbn to late orders page Test plan: 0) Make sure you have a late order a) Create a test vendor unless you have one b) Create a test basket unless you have one c) Close the basket to mark the order as late 1) Go to the late orders table Before patch : Orderno, ISBN, vendor notes, internal notes are absent After patch: fields are present 2) Edit the vendor note and/or the internal note 3) Press the save notes button 4) Refresh page and cache (CTRL+F5), if notes have been correctly saved, your modifications should be displayed. Signed-off-by: Alex Buckley <alexbuckley at catalyst.net.nz> Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 12:51:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 11:51:05 +0000 Subject: [Koha-bugs] [Bug 23983] Contextualization of "Order" (verb) vs "Order" (noun) In-Reply-To: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23983-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23983-70-jC9ywIbyaw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23983 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95367|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 17:51:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 16:51:43 +0000 Subject: [Koha-bugs] [Bug 24034] Capitalization on suggestion edit form: No Status In-Reply-To: <bug-24034-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24034-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24034-70-XpwVZoUMSH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24034 --- Comment #3 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 95442 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95442&action=edit Bug 24034: Capitalization on suggestion edit form: No Status When editing a purchase suggestion, the "No status" option in the status pulldown is incorrectly capatalized. This patch fixes the capitazliation. To test: 1) Create a purchase suggestion in the Signed-off-by: George Williams <george at nekls.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 11:12:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 10:12:41 +0000 Subject: [Koha-bugs] [Bug 24030] GetItemsForInventory failing with "ORDER BY clause is not in SELECT list" In-Reply-To: <bug-24030-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24030-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24030-70-UDF4f49Knx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24030 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 12:25:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 11:25:08 +0000 Subject: [Koha-bugs] [Bug 24027] Adding multiple items is slow In-Reply-To: <bug-24027-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24027-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24027-70-tS1QSsBqCl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24027 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |15262 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15262 [Bug 15262] Run Koha Run. Koha search should be fast again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 23:07:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 22:07:11 +0000 Subject: [Koha-bugs] [Bug 24033] Fix column labelling on basket summary page (ecost) In-Reply-To: <bug-24033-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24033-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24033-70-9LMuFjrZuS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24033 --- Comment #1 from Lisette Scheer <lisetteslatah at gmail.com> --- Created attachment 95448 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95448&action=edit Bug 24033 : Fix column labelling on basket summary page (ecost) When viewing a basket, some of the column names are unclear and are different than the terms used for the same field on the order form. This patch edits the column titles to match -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 22:07:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 21:07:21 +0000 Subject: [Koha-bugs] [Bug 15032] [Plack] Scripts that fork (like stage-marc-import.pl) don't work as expected In-Reply-To: <bug-15032-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15032-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15032-70-8p8z8Um9aq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15032 Daniel Gaghan <daniel.gaghan at pueblolibrary.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |daniel.gaghan at pueblolibrary | |.org --- Comment #38 from Daniel Gaghan <daniel.gaghan at pueblolibrary.org> --- We at PCCLD are also seeing this bug, is it related to the marc file size? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 11:03:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 10:03:33 +0000 Subject: [Koha-bugs] [Bug 23499] Show subtitle in serials search In-Reply-To: <bug-23499-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23499-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23499-70-z7NjxylCOy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23499 Ray Delahunty <r.delahunty at arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty at arts.ac.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 17:23:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 16:23:53 +0000 Subject: [Koha-bugs] [Bug 21959] Batch item modification - ability to apply regular expression on text fields In-Reply-To: <bug-21959-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21959-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21959-70-D3l7zdPvmu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21959 Alex Arnaud <alex.arnaud at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92870|0 |1 is obsolete| | --- Comment #23 from Alex Arnaud <alex.arnaud at biblibre.com> --- Created attachment 95432 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95432&action=edit Bug 21959: Batch item modification - ability to apply regular expression on text fields Test plan: - go to Tools > Batch item modification, - select items to modify, - for one or some text fields, check the second checkbox (Use regular expression) and type your regex, - check the regex has been applied. Signed-off-by: Pierre-Marc Thibault <pierre-marc.thibault at inLibro.com> Signed-off-by: Mathilde Formery <mathilde.formery at ville-nimes.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 19:07:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 18:07:08 +0000 Subject: [Koha-bugs] [Bug 24027] Adding multiple items is slow In-Reply-To: <bug-24027-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24027-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24027-70-8R9O52JXYi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24027 Andrew Nugged <nugged at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95413|0 |1 is obsolete| | Attachment #95414|0 |1 is obsolete| | --- Comment #10 from Andrew Nugged <nugged at gmail.com> --- Created attachment 95446 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95446&action=edit Bug 24027: ModZebra should be called once after all items added, not on each item add Why happened: - call to ModZebra was done after EACH item added, but it was called only with main biblionumber only, so call was the same on each of requests - and also time spent in that ModZebra sub increased with every next hundred items in DB for that element: so adding every next 100 was slower and slower, Solved: - now it's called only once (by adding some extra parameter to "AddItem*" sub set in postponed mode) - and now adding of elements not so heavily depends from how much items was in DB before. Test plan / How to replicate the issue: (test depends from how already populated DB and Zebra/Elasticsearch DBs so might be not so noticeably fast on empty DBs) - go to one of bibliotitems cataloguing/additem.pl?biblionumber=XXX pages - press button "add multiple copies of this item", put 1000 on slower machines, 5000 on faster - start measuring time + submit page/form It takes some amount of time even up to timeout. After applying patch, run the same procedure for same number of items. Note: it goes fast in both variants on empty database so time not so noticeable (also depents how ModZebra-related stuff is configured). Also it slows more linearly when number of items grows. But, again, it heavily depends how database is populated and indexes are rebuild but it's obvious that it will me much more efficient to call "ModZebra" once after 1000 addings, then call it 1000 times on each item created in the loop. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 12:46:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 11:46:02 +0000 Subject: [Koha-bugs] [Bug 23932] Typo on 'aqinvoice_adjustments.encumber_open' description in Koha Schema In-Reply-To: <bug-23932-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23932-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23932-70-KsyK3RWBET@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23932 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |severine.queune at bulac.fr |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 18:16:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 17:16:43 +0000 Subject: [Koha-bugs] [Bug 23854] Cannot edit a suggestion In-Reply-To: <bug-23854-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23854-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23854-70-VQKqjHSvhd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23854 --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 15:39:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 14:39:48 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-itiI3xgpm7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #19 from Séverine Queune <severine.queune at bulac.fr> --- Hi Jonathan, After I apply the patches, none of my suggestions are displayed. Do you know where it can come from ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 17:17:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 16:17:19 +0000 Subject: [Koha-bugs] [Bug 23825] Object.t is failing - Exception not caught In-Reply-To: <bug-23825-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23825-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23825-70-3lBedXfHNh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94662|0 |1 is obsolete| | --- Comment #29 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95403 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95403&action=edit Bug 23825: Add tests Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> [EDIT] Changed 'is' to 'like' with regex since we also have the db name. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 13:41:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 12:41:38 +0000 Subject: [Koha-bugs] [Bug 23993] Can't call method "notforloan" on an undefined value at C4/Reserves.pm line 1177. In-Reply-To: <bug-23993-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23993-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23993-70-D2iNtpiHwx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23993 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WONTFIX Status|In Discussion |RESOLVED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 20:48:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 19:48:01 +0000 Subject: [Koha-bugs] [Bug 24034] Capitalization on suggestion edit form: No Status In-Reply-To: <bug-24034-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24034-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24034-70-0vsOFHnhLv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24034 --- Comment #1 from Lisette Scheer <lisetteslatah at gmail.com> --- Created attachment 95410 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95410&action=edit Bug 24034: Capitalization on suggestion edit form: No Status When editing a purchase suggestion, the "No status" option in the status pulldown is incorrectly capatalized. This patch fixes the capitazliation. To test: 1) Create a purchase suggestion in the acquisitions module. 2) Edit the suggestion. Notice the capitalization in the status dropdown is incorrect. 3) Apply the patch. 4) Repeat step 2. 5) Note the capitalization has been fixed. 6) Sign off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 15:32:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 14:32:43 +0000 Subject: [Koha-bugs] [Bug 23089] Elasticsearch - cannot sort on non-text fields In-Reply-To: <bug-23089-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23089-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23089-70-Vdq5ggKHM8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23089 --- Comment #18 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Fridolin SOMERS from comment #16) > Can it be applyed on 19.05.x even without Bug 20589 that added changed > admin/searchengine/elasticsearch/field_config.yaml No, it relies on other logic there, but I made a new patch to bridge the behavior. I tried to keep it as small as possible. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 14:32:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 13:32:51 +0000 Subject: [Koha-bugs] [Bug 18433] Allow to select results to export in item search In-Reply-To: <bug-18433-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18433-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18433-70-IWpoZZ0GK4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18433 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #62472|0 |1 is obsolete| | --- Comment #31 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 95380 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95380&action=edit Bug 18433: Allow to select results to export in item search This adds a column of checkboxes in the results table to be able to select the items to be exported Test plan: 1. Go to item search and click 'Search' 2. Without checking any checkbox, verify that the export still works (it should export all results) 3. Tick some checkboxes and re-export, verify that only selected items are exported Followed test plan, works as expected. Signed-off-by: Marc Véron <veron at veron.ch> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 11:57:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 10:57:03 +0000 Subject: [Koha-bugs] [Bug 17492] Show warning if patron's age is out of category limits In-Reply-To: <bug-17492-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17492-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17492-70-IRSo0yM8CV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17492 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This patch adds a warning |This development adds a release notes|at checkout if a patron is |warning at checkout if a |found to have an age that |patron is found to have an |is outside their categories |age that is outside their |age range and allows the |categories age range and |staff user to immediately |allows the staff user to |update the patrons category |immediately update the |from the warning dialogue. |patrons' category from the | |warning dialogue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 20:10:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 19:10:27 +0000 Subject: [Koha-bugs] [Bug 23265] Update to DB revision 16.12.00.032 fails: Unknown column 'me.item_level_hold' In-Reply-To: <bug-23265-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23265-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23265-70-Alc5ITRpY4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23265 --- Comment #14 from Cindy Murdock Ames <cmurdock at ccfls.org> --- Nevermind, I found https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23809 which is the same issue I'm having. I applied that patch and my problem is resolved. Sorry for the noise! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 11:15:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 10:15:12 +0000 Subject: [Koha-bugs] [Bug 24031] Add plugin hook after_hold_create In-Reply-To: <bug-24031-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24031-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24031-70-bo2A93s90X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24031 --- Comment #1 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 95358 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95358&action=edit Bug 24031: Add plugin hook after_hold_create It is called after a hold has been placed Test plan: 1. Write a plugin that implements only after_hold_create (see `perldoc Koha::Plugins` for implementation details). Install it and enable it 2. Place a hold and verify that your plugin method has been called with the right parameters -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 17:17:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 16:17:28 +0000 Subject: [Koha-bugs] [Bug 23825] Object.t is failing - Exception not caught In-Reply-To: <bug-23825-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23825-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23825-70-Qo8rwdkkXv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23825 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95053|0 |1 is obsolete| | --- Comment #31 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95405 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95405&action=edit Bug 23825: table name is not always displayed Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 14 12:42:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 14 Nov 2019 11:42:22 +0000 Subject: [Koha-bugs] [Bug 23213] OPAC check mimimum payment threshold from payment plugin In-Reply-To: <bug-23213-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23213-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23213-70-orgQ84R7zR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23213 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Fines and fees |Plugin architecture -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 15:32:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 14:32:52 +0000 Subject: [Koha-bugs] [Bug 23089] Elasticsearch - cannot sort on non-text fields In-Reply-To: <bug-23089-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23089-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23089-70-Xug9uuGh8G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23089 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_19_05_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 10:05:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 09:05:34 +0000 Subject: [Koha-bugs] [Bug 23181] Unable to use payment library in ACCOUNT_PAYMENT or ACCOUNT_WRITEOFF notices In-Reply-To: <bug-23181-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23181-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23181-70-7OzmStZVI3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23181 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23805 CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 10:05:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 09:05:34 +0000 Subject: [Koha-bugs] [Bug 23805] Add a dedicated credit_types table In-Reply-To: <bug-23805-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23805-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23805-70-dHfsnkEZlw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23181 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 07:52:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 06:52:20 +0000 Subject: [Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl In-Reply-To: <bug-23247-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23247-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23247-70-DhSLQ2o7NH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA --- Comment #16 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Tomas, See my comment13. I have a book with three items. One is CF. Without your patch, normal view and marc view show 2 items. Which is ok. With your patch, normal view shows still 2 items (of course), but marc view shows no available items. Should be 2. Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 10:16:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 09:16:11 +0000 Subject: [Koha-bugs] [Bug 23181] Unable to use payment library in ACCOUNT_PAYMENT or ACCOUNT_WRITEOFF notices In-Reply-To: <bug-23181-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23181-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23181-70-yrWq8nlBQY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23181 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #11 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 19.05.x for 19.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 07:45:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 06:45:48 +0000 Subject: [Koha-bugs] [Bug 23247] Simplify visibility logic in opac-MARCdetail.pl In-Reply-To: <bug-23247-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23247-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23247-70-mzmBqudPqh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23247 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |BLOCKED --- Comment #15 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Testing again -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 13:47:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 12:47:53 +0000 Subject: [Koha-bugs] [Bug 24000] Some modules does not return 1 In-Reply-To: <bug-24000-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24000-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24000-70-Fd1xhHU4A6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24000 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW Keywords| |Academy Assignee|m.de.rooy at rijksmuseum.nl |koha-bugs at lists.koha-commun | |ity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 02:11:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 01:11:26 +0000 Subject: [Koha-bugs] [Bug 13246] Item edit doesn't respect cn_source if not defined In-Reply-To: <bug-13246-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13246-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13246-70-x5tQHVrlHA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13246 Cori Lynn Arnold <carnold at dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carnold at dgiinc.com --- Comment #1 from Cori Lynn Arnold <carnold at dgiinc.com> --- Confirmed this is the behavior in 19.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 13 11:09:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 13 Nov 2019 10:09:02 +0000 Subject: [Koha-bugs] [Bug 24029] marcrecord2csv.t displays a SQL error "Truncated incorrect DOUBLE value: '01e'" In-Reply-To: <bug-24029-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24029-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24029-70-LXmh41ptpZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24029 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95355 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95355&action=edit Bug 24029: Remove "Truncated incorrect DOUBLE value: '01e'" from marcrecord2csv.t marc_subfield_structure.tagfield is a varchar(3) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 07:51:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 06:51:03 +0000 Subject: [Koha-bugs] [Bug 24015] UNIMARC Authorities update from IFLA for new Koha installations In-Reply-To: <bug-24015-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24015-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24015-70-uquT5tG3of@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24015 Igor A. Sychev <Igor.A.Sychev at mail.ru> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|UNIMARC Authorities |UNIMARC Authorities update | |from IFLA for new Koha | |installations -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 10:20:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 09:20:05 +0000 Subject: [Koha-bugs] [Bug 23234] Circulation.t failing when comparing dates that seem identical In-Reply-To: <bug-23234-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23234-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23234-70-m0KEJD1473@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23234 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.05 released in| | Status|Pushed to master |Pushed to stable CC| |fridolin.somers at biblibre.co | |m --- Comment #6 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 19.05.x for 19.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 10:26:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 09:26:52 +0000 Subject: [Koha-bugs] [Bug 17359] Patron import results use wrong encoding In-Reply-To: <bug-17359-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17359-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17359-70-jWmRP5ez0b@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17359 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|19.11.00 |19.11.00,19.05.05 released in| | --- Comment #38 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 19.05.x for 19.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 11:03:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 10:03:59 +0000 Subject: [Koha-bugs] [Bug 23774] When placing a hold editing using Inspect Element allows addition to the code of non listed library In-Reply-To: <bug-23774-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23774-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23774-70-CZVhIfT4Yw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23774 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|19.11.00 |19.11.00,19.05.05 released in| | --- Comment #9 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 19.05.x for 19.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 11:05:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 10:05:00 +0000 Subject: [Koha-bugs] [Bug 23467] Duplicated screen if error in opac-reserve.pl In-Reply-To: <bug-23467-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23467-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23467-70-4CMte8O0MT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23467 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|19.11.00 |19.11.00,19.05.05 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #8 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 19.05.x for 19.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 11:06:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 10:06:38 +0000 Subject: [Koha-bugs] [Bug 23992] Adding multiple items with barcode might end with infinite loop if same barcode will be next_value In-Reply-To: <bug-23992-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23992-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23992-70-av3PtkGWjx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23992 --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Hi Andrew, Are you trying to fix a random FIXME or a bug you found? :) If I understand correctly you are trying to fix a logic issue, and so an hypothetical situation where the barcode plugin will return $new = $old. Maybe we should fix that in the plugins then? Even if the change makes sense to me I will need to think a bit more about it, especially the following "terribly hacky" fix I wrote few weeks ago. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 11:14:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 10:14:27 +0000 Subject: [Koha-bugs] [Bug 23963] Visible reduction in image quality In-Reply-To: <bug-23963-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23963-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23963-70-qsGMVHoX73@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23963 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)| |19.11.00,19.05.05 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #2 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 19.05.x for 19.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 11:16:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 10:16:32 +0000 Subject: [Koha-bugs] [Bug 23529] Interlibrary loan javascript is broken In-Reply-To: <bug-23529-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23529-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23529-70-qqCDpeCQKe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23529 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #19 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 19.05.x for 19.05.05 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 11:17:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 10:17:44 +0000 Subject: [Koha-bugs] [Bug 22857] Entries missing in koha-conf.xml In-Reply-To: <bug-22857-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22857-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22857-70-eSCup3WcTA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22857 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|19.11.00 |19.11.00,19.05.05 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #11 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 19.05.x for 19.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 11:19:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 10:19:17 +0000 Subject: [Koha-bugs] [Bug 23933] commit_file.pl Can't call method "get_effective_marcorgcode" on an undefined value at /usr/share/koha/lib/C4/AuthoritiesMarc.pm line 578. In-Reply-To: <bug-23933-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23933-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23933-70-IDuS7N0Uh5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23933 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|19.11.00 |19.11.00,19.05.05 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 19.05.x for 19.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 11:24:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 10:24:12 +0000 Subject: [Koha-bugs] [Bug 23851] Auto generate accession number format <branchcode>yymm0001 fails to add branchcode prefix(branchcode) for multiple item addition In-Reply-To: <bug-23851-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23851-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23851-70-Wv2Uhnnoc8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23851 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|19.11.00 |19.11.00,19.05.05 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #12 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 19.05.x for 19.05.05 # This is terribly hacky :'( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 11:25:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 10:25:53 +0000 Subject: [Koha-bugs] [Bug 23986] Batch Record Deletion does not remove records from Elasticsearch search index In-Reply-To: <bug-23986-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23986-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23986-70-BzxHKavOm3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23986 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #10 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 19.05.x for 19.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 11:43:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 10:43:46 +0000 Subject: [Koha-bugs] [Bug 23846] Handle records with broken MARCXML on the bibliographic detail view In-Reply-To: <bug-23846-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23846-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23846-70-VgqI6Rn0Tj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23846 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |Pushed to stable Version(s)|19.11.00 |19.11.00,19.05.05 released in| | --- Comment #15 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 19.05.x for 19.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 12:34:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 11:34:48 +0000 Subject: [Koha-bugs] [Bug 23091] Restore Forgiven Overdue Fines When Lost Item Returned In-Reply-To: <bug-23091-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23091-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23091-70-WJz3wq1MD1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 12:34:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 11:34:55 +0000 Subject: [Koha-bugs] [Bug 23091] Restore Forgiven Overdue Fines When Lost Item Returned In-Reply-To: <bug-23091-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23091-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23091-70-HfpI4jFNtI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23091 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 12:35:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 11:35:06 +0000 Subject: [Koha-bugs] [Bug 23504] Allow forgiving fines on returned lost items In-Reply-To: <bug-23504-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23504-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23504-70-X8wyJ7jjkr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23504 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Keywords| |rel_20_05_target -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 12:35:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 11:35:20 +0000 Subject: [Koha-bugs] [Bug 15521] Make circulation rules backend more granular In-Reply-To: <bug-15521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15521-70-n36mJwm6Ga@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_target CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 12:35:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 11:35:25 +0000 Subject: [Koha-bugs] [Bug 15521] Make circulation rules backend more granular In-Reply-To: <bug-15521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15521-70-J8iPJjAe0D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|Sponsored |--- -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 12:35:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 11:35:45 +0000 Subject: [Koha-bugs] [Bug 15521] Make circulation rules backend more granular In-Reply-To: <bug-15521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15521-70-OOFAKl43tq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jweaver at bywatersolutions.co |koha-bugs at lists.koha-commun |m |ity.org Keywords|rel_20_05_target | Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 12:36:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 11:36:00 +0000 Subject: [Koha-bugs] [Bug 15521] Make circulation rules backend more granular In-Reply-To: <bug-15521-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15521-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15521-70-BKX6SLBndW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15521 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|Sponsored |--- Keywords| |rel_20_05_target, | |RM_priority -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 13:10:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 12:10:44 +0000 Subject: [Koha-bugs] [Bug 24022] Z3950Responder tests are failing randomly In-Reply-To: <bug-24022-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24022-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24022-70-MtDXzW7G8W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24022 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |fridolin.somers at biblibre.co | |m Status|Pushed to master |RESOLVED --- Comment #11 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Depends on Bug 13937 not in 19.05.x -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 13:12:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 12:12:03 +0000 Subject: [Koha-bugs] [Bug 23985] The method Koha::Item-> is not covered by tests! In-Reply-To: <bug-23985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23985-70-yPD8y0TFMj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23985 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Depends on| |21206 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 [Bug 21206] C4::Items - Remove GetItem -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 13:12:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 12:12:03 +0000 Subject: [Koha-bugs] [Bug 21206] C4::Items - Remove GetItem In-Reply-To: <bug-21206-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21206-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21206-70-HXZ8P3QxSf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21206 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23985 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23985 [Bug 23985] The method Koha::Item-> is not covered by tests! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 13:13:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 12:13:31 +0000 Subject: [Koha-bugs] [Bug 23985] The method Koha::Item-> is not covered by tests! In-Reply-To: <bug-23985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23985-70-1YCo45fGwp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23985 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|19.11.00 |19.11.00,19.05.05 released in| | --- Comment #7 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 19.05.x for 19.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 13:33:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 12:33:27 +0000 Subject: [Koha-bugs] [Bug 23822] Regression: As of 19.05.04 deletion of patrons with outstanding credits is silently blocked In-Reply-To: <bug-23822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23822-70-Z1AGtgmI3B@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23822 --- Comment #11 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Shouldn't we also fix the other line : if ( $op eq 'delete_confirm' or $countissues > 0 or $charges or $is_guarantor ) { -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 13:38:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 12:38:16 +0000 Subject: [Koha-bugs] [Bug 24016] manager_id in Koha::Patron::Message->store should not depend on userenv alone In-Reply-To: <bug-24016-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24016-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24016-70-dloso4gKng@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24016 Joonas Kylmälä <joonas.kylmala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at helsinki.fi --- Comment #6 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> --- I think I'm missing some context from here. Why manager id should be overwrite-able even if defined in userenv? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 13:41:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 12:41:45 +0000 Subject: [Koha-bugs] [Bug 23854] Cannot edit a suggestion In-Reply-To: <bug-23854-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23854-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23854-70-pJDa7mF9cg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23854 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m Version(s)|19.11.00 |19.11.00,19.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #12 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 19.05.x for 19.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 13:43:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 12:43:40 +0000 Subject: [Koha-bugs] [Bug 23765] After TranslateNotices is set to 'Don't allow', email settings still show multiple languages In-Reply-To: <bug-23765-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23765-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23765-70-XNAD5YzFQX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23765 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|19.11.00 |19.11.00,19.05.05 released in| | CC| |fridolin.somers at biblibre.co | |m --- Comment #12 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 19.05.x for 19.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 14:22:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 13:22:14 +0000 Subject: [Koha-bugs] [Bug 24025] Make CodeMirror content searchable In-Reply-To: <bug-24025-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24025-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24025-70-5IyC6mwixT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24025 --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- (In reply to George Williams (NEKLS) from comment #0) > you can only search for > content in the two UserJS system preferences if the content is displayed on > the screen. I don't see how this is connected to the addition of CodeMirror. It has always been the case that you can't search the page for text which is hidden. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 14:28:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 13:28:26 +0000 Subject: [Koha-bugs] [Bug 24028] bug in calorie mama application, baseball ball is recognized as an egg In-Reply-To: <bug-24028-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24028-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24028-70-QAsxGAz0N8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24028 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- (In reply to Taghreed from comment #1) > expected results: baseball ball or object is not recognized as a food This bug tracker is for Koha, and around here we let people decide for themselves whether or not a baseball is food. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 14:46:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 13:46:52 +0000 Subject: [Koha-bugs] [Bug 23992] Adding multiple items with barcode might end with infinite loop if same barcode will be next_value In-Reply-To: <bug-23992-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23992-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23992-70-6TLGKfP5lQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23992 --- Comment #4 from Andrew Nugged <nugged at gmail.com> --- (In reply to Jonathan Druart from comment #3) > If I understand correctly you are trying to fix a logic issue, and so an > hypothetical situation where the barcode plugin will return $new = $old. or when it will return NO BARCODE (empty/undef) if such possible. Because our plugins/barcodes can change by time and I don't know how might behave, I propose to detect this in the sequence, and inform user that "something went wrong. But yes, if this never happens now and never later if someone will change barcode generator or use their own so that "no_barcode_generated" I've added not needed at all and this solution might look useless. But idea was not so clear, I agree, but let's assume we: 1. started loop with barcode provided, so each next item should be with next_value barcode, 2. but eventually no next_value or it is the same for "unknown future reasons" (someone will develop Barcode generator which will do that), 3. so we should stop in the middle bringing error to operator/user that "we failed to go further with your sequence", not just silently continue adding empty or same barcodes. But yes, this was unclear fix because it came as attempt to syncronize another bugfix in KohaSuomi fork which way behind of current KohaCommunity (v16 against v19), and because there's not exactly how this was solved in KohaSuomi, I wanted to have this fix in KC, port it back in KS, so then KS don't needs other fixes, but I also agree this is "silver tape fix" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 14:47:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 13:47:56 +0000 Subject: [Koha-bugs] [Bug 24016] manager_id in Koha::Patron::Message->store should not depend on userenv alone In-Reply-To: <bug-24016-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24016-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24016-70-ohq5EHWY0f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24016 --- Comment #7 from Lari Taskula <lari.taskula at hypernova.fi> --- (In reply to Joonas Kylmälä from comment #6) > I think I'm missing some context from here. Why manager id should be > overwrite-able even if defined in userenv? The point is that userenv should not be the only way to set manager_id (or any other values of Koha::Objects), because we can not expect userenv to be defined. It breaks in REST API when you are using basic auth method. Also, it's not a very nice idea to forcefully restrict developers using models in such way. I think the use of userenv should only be a fall-back method of accessing user data in Koha::Objects. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 14:59:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 13:59:08 +0000 Subject: [Koha-bugs] [Bug 20930] Validate and cache parsed YAML/JSON type system preferences In-Reply-To: <bug-20930-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20930-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20930-70-RAA8wPuyQN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20930 --- Comment #16 from Ere Maijala <ere.maijala at helsinki.fi> --- Just one minor thing: I'd like to assume we'll never just tell the user that there's invalid syntax without telling the position, so could the two messages be combined into one, like "Error: Preference '%s' has invalid syntax at line %s, column %s."? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 15:44:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 14:44:27 +0000 Subject: [Koha-bugs] [Bug 24023] Add ability to create bundles of items In-Reply-To: <bug-24023-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24023-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24023-70-yTEFLg9YgP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24023 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr --- Comment #2 from Séverine Queune <severine.queune at bulac.fr> --- Hi Julian, I've got a tiny issue on step 6, for url is not complete (detail.pl?biblionumber= is missing). Did I forgot a setting somewhere ? Except this point, everything is ok for me ! In the future, do you think the feature could be decline to link items using the itemnumber ? I'm thinking of it for some of our collections, it would be really helpfull ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 15:51:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 14:51:53 +0000 Subject: [Koha-bugs] [Bug 23732] Hold rules checker: show matched rules and syspref values to help understand why a hold is possible or not In-Reply-To: <bug-23732-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23732-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23732-70-loiQ6BAR9I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 --- Comment #7 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- *Note that -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 15:58:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 14:58:39 +0000 Subject: [Koha-bugs] [Bug 24048] New: We should have a koha-plugin-enable script Message-ID: <bug-24048-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24048 Bug ID: 24048 Summary: We should have a koha-plugin-enable script Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Plugin architecture Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org We have debian scripts for enabling and disable elastic search and other optional features.. we should add one for the process of enabled/disabling plugins too. It would need to update the config file and vhost for the instance. ``` Alias /plugin "/var/lib/koha/'instance'/plugins" # The stanza below is needed for Apache 2.4+ <Directory /var/lib/koha/'instance'/plugins> Options Indexes FollowSymLinks ExecCGI AddHandler cgi-script .pl AllowOverride None Require all granted </Directory> ``` -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 16:00:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 15:00:02 +0000 Subject: [Koha-bugs] [Bug 24023] Add ability to create bundles of items In-Reply-To: <bug-24023-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24023-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24023-70-ALnfnXBVmb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24023 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #3 from Julian Maurice <julian.maurice at biblibre.com> --- (In reply to Séverine Queune from comment #2) > Hi Julian, > > I've got a tiny issue on step 6, for url is not complete > (detail.pl?biblionumber= is missing). Did I forgot a setting somewhere ? No, there's a problem here that need to be fixed. Thanks. > Except this point, everything is ok for me ! > > In the future, do you think the feature could be decline to link items using > the itemnumber ? I'm thinking of it for some of our collections, it would be > really helpfull ! Yes, that shouldn't be too hard to implement -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 16:16:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 15:16:12 +0000 Subject: [Koha-bugs] [Bug 24039] Allow z3950 profiles to be linked to a user In-Reply-To: <bug-24039-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24039-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24039-70-MJ9RHenKiu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24039 George Williams (NEKLS) <george at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 16:42:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 15:42:29 +0000 Subject: [Koha-bugs] [Bug 24025] Make CodeMirror content searchable In-Reply-To: <bug-24025-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24025-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24025-70-n0F1979Kw4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24025 --- Comment #3 from George Williams (NEKLS) <george at nekls.org> --- Owen, If you're in 18.05 and you go to preferences.pl?tab=opac and hit the "Click to edit" link for OPACUserJS and then search for a word that appears in the textarea for #pref_OPACUserJS using the browser's built in "Find in this page..." feature, Firefox will search all of #pref_OPACUserJS - even if the text you're searching for is not visible on the page. When you hit "Click to edit" you get about 16 lines of OPACUserJS on the screen, but if you've got 500 lines in OPACUserJS and the text your searching for is on line 300, "Find in this page..." will scroll you down to line 300. If you're in 19.05 and follow these same steps, when you "Click to edit" you're no longer opening the textarea for #pref_OPACUserJS. The Code Mirror input area is a div styled as .CodeMirror.cm-s-default.CodeMirror-wrap and when you hit "Click to edit" you will get about 18 lines of OPACUserJS and only those 18 lines are searchable using "Find in this page...". Code Mirror has two searh addons (search.js and searchcursor.js) that could be added that would allow users to put the cursor in the Code Mirror div, type CTRL-F and search through all lines in the Code Mirror div. I think those addons would be a good addition to Koha. George -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 16:46:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 15:46:16 +0000 Subject: [Koha-bugs] [Bug 24023] Add ability to create bundles of items In-Reply-To: <bug-24023-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24023-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24023-70-8gvdmBEIc4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24023 George Williams (NEKLS) <george at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 16:54:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 15:54:25 +0000 Subject: [Koha-bugs] [Bug 22831] Elasticsearch - add a maintenance script for checking DB vs index counts In-Reply-To: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22831-70-YmL8TYdFrW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com QA Contact| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 17:05:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 16:05:43 +0000 Subject: [Koha-bugs] [Bug 19279] Performance of linked items in search In-Reply-To: <bug-19279-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19279-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19279-70-vCDHa3qFOc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19279 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 17:05:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 16:05:46 +0000 Subject: [Koha-bugs] [Bug 19279] Performance of linked items in search In-Reply-To: <bug-19279-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19279-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19279-70-0G8rClcoku@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19279 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92869|0 |1 is obsolete| | --- Comment #17 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Created attachment 95455 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95455&action=edit Bug 19279: performance of linked items in search When catalog has fields 773 (461 in UNIMARC), those linked items are fetched for display in search results. Looks like the code could be more performant by replacing item search by $9 with direct call with GetMarcItem(). Test plan : 1) Enable system preference EasyAnalyticalRecords 2) Get a record A with a lot of items, it will be the 'Host record' 3) Click on 'Analytics' on this record 4) On one of its items (say item A1) click on 'Create analytics' to create record B 5) Enter the same title as record A and all mandatory fields 6) Edit field 773 (461 in UNIMARC) 6) Check that $0 contains the biblionumber of record A 7) Check that $9 contains the itemnumber of item A1 8) Perform a search on record A title, be sure you see record B with other results => Compare execution times with and without patch Signed-off-by: Hugo Agud <hagud at orex.es> Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 17:13:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 16:13:42 +0000 Subject: [Koha-bugs] [Bug 19279] Performance of linked items in search In-Reply-To: <bug-19279-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19279-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19279-70-uUsdkoxHAs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19279 --- Comment #18 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- (In reply to Katrin Fischer from comment #16) > > I think at the moment we can't be sure if this works correctly. I am also a > bit doubtful about the test plan - it doesn't even mention the EasyAnalytics > feature this seems to be used for? > > I'd at least like a real good test plan here. Indeed. Here is a much better test plan. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 17:50:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 16:50:44 +0000 Subject: [Koha-bugs] [Bug 24025] Make CodeMirror content searchable In-Reply-To: <bug-24025-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24025-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24025-70-gOWhQ5swz6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24025 --- Comment #4 from Owen Leonard <oleonard at myacpl.org> --- (In reply to George Williams (NEKLS) from comment #3) > when you hit "Click to edit" you will get about 18 lines of OPACUserJS and > only those 18 lines are searchable using "Find in this page...". Thanks for the clarification! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 17:58:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 16:58:13 +0000 Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference In-Reply-To: <bug-18532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18532-70-1Qtj286lxt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95338|0 |1 is obsolete| | --- Comment #13 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 95456 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95456&action=edit Bug 18532: set auto_renewals as patron messaging preference This patch adds the "Auto renewals" messaging preference on intranet and OPAC, and adds digest feature to misc/cronjobs/automatic_renewals.pl script. To test: 1. apply patches 2. perl installer/data/mysql/updatedatabase.pl 3. make sure renewals are allowed in circ rules 4. grab a patron and go to details page CHECK => patron's messaging preferences has a "Auto renewals" row Signed-off-by: tgoat <tgoatley at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 18:13:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 17:13:00 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23260-70-lamtVHeGjv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Agustín Moyano <agustinmoyano at theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94858|0 |1 is obsolete| | Attachment #94859|0 |1 is obsolete| | Attachment #95033|0 |1 is obsolete| | --- Comment #15 from Agustín Moyano <agustinmoyano at theke.io> --- Created attachment 95457 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95457&action=edit Bug 23260: Make borrowernumber nullable in items_last_borrower This patch alters table structure to make borrowernumber nullable Sponsored-by: Northeast Kansas Library System -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 18:13:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 17:13:04 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23260-70-FrsCueYfHo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #16 from Agustín Moyano <agustinmoyano at theke.io> --- Created attachment 95458 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95458&action=edit Bug 23260: Add anonymize items_last_borrower feature This patch adds the feature to anonymize patrons from items_last_borrower table. This code is run from batch_anonymize script, which is triggered from a cron job. To test: 1) apply this patch and the previous one 2) perl installer/data/mysql/updatedatabase.pl 3) set StoreLastBorrower preference to Allow. 4) Create a Check out followed by a Check in. CHECK => a row should appear in items_last_borrower table with the borrower and the item number. 5) In mysql, update created_on date to one day earlier. 6) set AnonymousPatron preference to a valid patron id 7) perl misc/cronjobs/batch_anonymise.pl SUCCESS => borrower number in items_last_borrower changed to AnonymousPatron id 8) repeat steps 4 and 5 9) set AnonymousPatron preference to 0 10) perl misc/cronjobs/batch_anonymise.pl SUCCESS => borrower number in items_last_borrower changed to null 11) prove t/db_dependent/Koha/Patrons.t 12) Sign off Sponsored-by: Northeast Kansas Library System Signed-off-by: Maryse Simard <maryse.simard at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 18:13:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 17:13:09 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23260-70-jHATSLurzm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #17 from Agustín Moyano <agustinmoyano at theke.io> --- Created attachment 95459 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95459&action=edit Bug 23260: (follow-up) optimize anonymise_items_last_borrower Sponsored-by: Northeast Kansas Library System -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 18:16:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 17:16:34 +0000 Subject: [Koha-bugs] [Bug 18532] AUTO_RENEWALS should be a patron messaging preference In-Reply-To: <bug-18532-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18532-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18532-70-yQ8jTGjnpO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18532 Agustín Moyano <agustinmoyano at theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 18:17:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 17:17:02 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23260-70-eiTGBFVreX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Agustín Moyano <agustinmoyano at theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 19:15:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 18:15:21 +0000 Subject: [Koha-bugs] [Bug 24049] New: Limit for Consecutive Hold Requests Message-ID: <bug-24049-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24049 Bug ID: 24049 Summary: Limit for Consecutive Hold Requests Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com It would be great if there were a feature to limit the number of consecutive holds a person could place in X amount of days. This would be an answer to those of us who have patrons hoarding items, just to have them. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 19:17:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 18:17:24 +0000 Subject: [Koha-bugs] [Bug 24050] New: Limit Consecutive Issues Message-ID: <bug-24050-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24050 Bug ID: 24050 Summary: Limit Consecutive Issues Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: cbrannon at cdalibrary.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Like 24049, it would be great if there were a feature to limit the number of consecutive check outs (issues) of an item with X amount of days. This, also, would help those of us who deal with patrons hoarding items just to have them. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 19:44:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 18:44:01 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23260-70-eO1ZG27M6x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #18 from Christopher Brannon <cbrannon at cdalibrary.org> --- (In reply to Maryse Simard from comment #5) > Created attachment 93052 [details] [review] > Bug 23260: Add anonymize items_last_borrower feature > > This patch adds the feature to anonymize patrons from items_last_borrower > table. This code is run from batch_anonymize script, which is triggered from > a cron job. > > To test: > 1) apply this patch and the previous one > 2) perl installer/data/mysql/updatedatabase.pl > 3) set StoreLastBorrower preference to Allow. > 4) Create a Check out followed by a Check in. > CHECK => a row should appear in items_last_borrower table with the borrower > and the item number. > 5) In mysql, update created_on date to one day earlier. > 6) set AnonymousPatron preference to a valid patron id > 7) perl misc/cronjobs/batch_anonymise.pl > SUCCESS => borrower number in items_last_borrower changed to AnonymousPatron > id > 8) repeat steps 4 and 5 > 9) set AnonymousPatron preference to 0 > 10) perl misc/cronjobs/batch_anonymise.pl > SUCCESS => borrower number in items_last_borrower changed to null > 11) prove t/db_dependent/Koha/Patrons.t > 12) Sign off > > Signed-off-by: Maryse Simard <maryse.simard at inlibro.com> Your test plan has me concerned. If you must first set the feature to allow (#3), which is what Koha currently does without this feature, it sounds like this feature is not on by default. Is that true? It should retain the current behavior of Koha by default. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 20:03:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 19:03:06 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23260-70-F8deLit07t@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #19 from Agustín Moyano <agustinmoyano at theke.io> --- (In reply to Christopher Brannon from comment #18) > (In reply to Maryse Simard from comment #5) > > Created attachment 93052 [details] [review] [review] > > Bug 23260: Add anonymize items_last_borrower feature > > > > This patch adds the feature to anonymize patrons from items_last_borrower > > table. This code is run from batch_anonymize script, which is triggered from > > a cron job. > > > > To test: > > 1) apply this patch and the previous one > > 2) perl installer/data/mysql/updatedatabase.pl > > 3) set StoreLastBorrower preference to Allow. > > 4) Create a Check out followed by a Check in. > > CHECK => a row should appear in items_last_borrower table with the borrower > > and the item number. > > 5) In mysql, update created_on date to one day earlier. > > 6) set AnonymousPatron preference to a valid patron id > > 7) perl misc/cronjobs/batch_anonymise.pl > > SUCCESS => borrower number in items_last_borrower changed to AnonymousPatron > > id > > 8) repeat steps 4 and 5 > > 9) set AnonymousPatron preference to 0 > > 10) perl misc/cronjobs/batch_anonymise.pl > > SUCCESS => borrower number in items_last_borrower changed to null > > 11) prove t/db_dependent/Koha/Patrons.t > > 12) Sign off > > > > Signed-off-by: Maryse Simard <maryse.simard at inlibro.com> > > Your test plan has me concerned. If you must first set the feature to allow > (#3), which is what Koha currently does without this feature, it sounds like > this feature is not on by default. Is that true? It should retain the > current behavior of Koha by default. Hi Christopher, thanks for checking this out. This bug does not touch the StoreLastBorrower's default value (I had to change it in my koha-testing-docker, so I asumed it came off by default).. It's just to make sure that preference is set to Allow for the test to succeed. Sorry if I didn't make this test plan clear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 20:08:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 19:08:29 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23260-70-orb2ivHrUv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Maryse Simard <maryse.simard at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 20:08:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 19:08:32 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23260-70-7tbjH1MIb9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Maryse Simard <maryse.simard at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95459|0 |1 is obsolete| | --- Comment #20 from Maryse Simard <maryse.simard at inlibro.com> --- Created attachment 95460 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95460&action=edit Bug 23260: (follow-up) optimize anonymise_items_last_borrower Sponsored-by: Northeast Kansas Library System Signed-off-by: Maryse Simard <maryse.simard at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 20:24:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 19:24:13 +0000 Subject: [Koha-bugs] [Bug 24016] manager_id in Koha::Patron::Message->store should not depend on userenv alone In-Reply-To: <bug-24016-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24016-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24016-70-9hDUMu5MRn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24016 Maryse Simard <maryse.simard at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95301|0 |1 is obsolete| | --- Comment #8 from Maryse Simard <maryse.simard at inlibro.com> --- Created attachment 95461 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95461&action=edit Bug 24016: Add a failing test for overwrite-able manager_id in Koha::Patron::Message To test: 1. prove t/db_dependent/Koha/Patron/Messages.t 2. Observe failure t/db_dependent/Koha/Patron/Messages.t .. 2/12 Failed test 'Manager id should be overwrite-able even if defined in userenv' at t/db_dependent/Koha/Patron/Messages.t line 90. got: '1100' expected: '1101' Looks like you failed 1 test of 12. t/db_dependent/Koha/Patron/Messages.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/12 subtests Sponsored-by: Koha-Suomi Oy Signed-off-by: Maryse Simard <maryse.simard at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 20:24:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 19:24:15 +0000 Subject: [Koha-bugs] [Bug 24016] manager_id in Koha::Patron::Message->store should not depend on userenv alone In-Reply-To: <bug-24016-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24016-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24016-70-M2zJ1CPaHn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24016 Maryse Simard <maryse.simard at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95302|0 |1 is obsolete| | --- Comment #9 from Maryse Simard <maryse.simard at inlibro.com> --- Created attachment 95462 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95462&action=edit Bug 24016: manager_id in Koha::Patron::Message->store should not depend on userenv alone Koha::Patron::Message->store has this my $userenv = C4::Context->userenv; $self->manager_id( $userenv ? $userenv->{number} : undef); This breaks in REST API when userenv is not set. Let API user pass manager_id without relying on C4::Context->userenv. To test: 1. prove t/db_dependent/Koha/Patron/Messages.t 2. Observe success Sponsored-by: Koha-Suomi Oy Signed-off-by: Maryse Simard <maryse.simard at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 20:24:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 19:24:26 +0000 Subject: [Koha-bugs] [Bug 24016] manager_id in Koha::Patron::Message->store should not depend on userenv alone In-Reply-To: <bug-24016-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24016-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24016-70-CEBNQo7Esn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24016 Maryse Simard <maryse.simard at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |maryse.simard at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 21:04:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 20:04:48 +0000 Subject: [Koha-bugs] [Bug 18723] Dot not recognized as decimal separator on receive In-Reply-To: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18723-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18723-70-Ut7Nzju7bK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18723 --- Comment #46 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Hi :) Here is an SQL query to detect orders and items (items.price) that were affected by this bug. And 2 others to fix these cases. And finally a large price check query that should point any case of price difference > 5 (this is arbitrary) between prices that should be close to each other (unitprice, unitprice_tax_excluded, ecost, items.price, etc) The check queries were applied to a dozen of instances that were reporting price issue with acquisition receiving and thus the budget and funds total And the fix queries in there final version were applied to a bit more than half of them. === BZ 18723 specific price check query === Should only detect cases related to this bug. All values except ecost are x100 time bigger - unitprice - items.price - unitprice_tax_excluded - unitprice_tax_included - tax_value_on_receiving ``` SELECT invoicenumber, link.ordernumber, items.itemnumber, ecost, items.price, unitprice, unitprice_tax_excluded, unitprice_tax_included, tax_value_on_receiving, unitprice_tax_excluded/ecost as ratio FROM aqorders LEFT JOIN aqinvoices ON aqinvoices.invoiceid = aqorders.invoiceid LEFT JOIN aqorders_items as link ON link.ordernumber=aqorders.ordernumber LEFT JOIN items ON link.itemnumber=items.itemnumber WHERE unitprice_tax_excluded / ecost BETWEEN 50 AND 150 AND unitprice_tax_included / ecost BETWEEN 50 AND 150 AND unitprice / ecost BETWEEN 50 AND 150 ORDER BY ratio DESC; -- BETWEEN 50 AND 150 to get the differences between order cost and final cost. -- This is arbitrary. ``` === BZ 18723 specific data fix queries === Caveat, this might be not exhaustive, there might be remaining deriving data that isn't updated. divide by 100 - unitprice - items.price - unitprice_tax_excluded - unitprice_tax_included - tax_value_on_receiving (don't forget this one) ``` UPDATE aqorders SET unitprice=unitprice / 100, unitprice_tax_excluded=unitprice_tax_excluded / 100, unitprice_tax_included=unitprice_tax_included / 100, tax_value_on_receiving=tax_value_on_receiving / 100 WHERE -- we get only the x100 cases unitprice_tax_excluded / ecost BETWEEN 50 AND 150 AND unitprice_tax_included / ecost BETWEEN 50 AND 150 AND unitprice / ecost BETWEEN 50 AND 150; ``` ``` UPDATE items set price=price/100 -- wider criteria than the issue detection request -- because a JOIN in the update would have made it less readable and error prone. -- so it might fix more cases than the only those related to bug 18723 WHERE price/replacementprice between 50 and 150; -- we get only the x100 cases -- caveat; we have seen replacementprice being NULL and thus the fix doesn't happen -- we consider this to not be related to bug 18723 -- and it will be caught be the general analysis query. ``` Hopefully we can finally have a relief about this issue. === general price check query === Compare all the values in a systematic way. It can be summarized by A not more than 5x B B not more than 5x C C not more than 5x A 5 is arbitrary, any feedback welcome. ``` SELECT invoicenumber, link.ordernumber, items.itemnumber, ecost, items.replacementprice AS items_replacementprice, aqorders.replacementprice AS aqorders_replacementprice, items.price, unitprice, unitprice_tax_excluded, unitprice_tax_included, tax_value_on_receiving, unitprice_tax_excluded/ecost as ratio FROM aqorders LEFT JOIN aqinvoices ON aqinvoices.invoiceid = aqorders.invoiceid LEFT JOIN aqorders_items as link ON link.ordernumber=aqorders.ordernumber LEFT JOIN items ON link.itemnumber=items.itemnumber WHERE unitprice_tax_excluded / unitprice_tax_included > 5 OR unitprice_tax_included / unitprice > 5 OR unitprice / aqorders.replacementprice > 5 OR aqorders.replacementprice / ecost > 5 OR ecost / items.price > 5 OR items.price / unitprice_tax_excluded > 5 ORDER BY ratio DESC; ``` Thanks Arthur for you help in finally getting rid of this! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 21:06:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 20:06:16 +0000 Subject: [Koha-bugs] [Bug 21507] Decimal separators issues in patrons payments/fines, simplified In-Reply-To: <bug-21507-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21507-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21507-70-ObBlp4PWHQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21507 --- Comment #3 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- > Here is a SQL query which helps detecting incoherences in the account lines. We mistakenly sent the message here instead of bug 18723 about acquisitions. See there for the queries. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 21:34:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 20:34:31 +0000 Subject: [Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history In-Reply-To: <bug-18795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18795-70-rQbDY7QEUD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795 Bouzid Fergani <bouzid.fergani at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95265|0 |1 is obsolete| | --- Comment #17 from Bouzid Fergani <bouzid.fergani at inlibro.com> --- Created attachment 95463 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95463&action=edit Bug 18795: DELETE (anonymize) checkout history Anonymize patron's checkout history via REST API DELETE /checkouts/history?patron_id=123 To test: 1. prove t/db_dependent/api/v1/checkouts.t 2. Manually send DELETE request to /api/v1/checkouts/history?patron_id=123 where 123 is your patron's borrowernumber Sponsored-by: Koha-Suomi Oy Signed-off-by: Joonas Kylmälä <joonas.kylmala at helsinki.fi> Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 21:34:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 20:34:37 +0000 Subject: [Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history In-Reply-To: <bug-18795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18795-70-Tx9PioveDI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795 Bouzid Fergani <bouzid.fergani at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95266|0 |1 is obsolete| | --- Comment #18 from Bouzid Fergani <bouzid.fergani at inlibro.com> --- Created attachment 95464 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95464&action=edit Bug 18795: (follow-up) Check whether patrons exists before deleting history Running $patrons->anonymise_issue_history after checking patrons exists is more logical even though $patrons->anonymise_issue_history() can handle 0 patrons returned in the search. Also this way we don't have to run anonymise_issue_history() code unless needed, thus making the code finish faster. Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 21:34:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 20:34:45 +0000 Subject: [Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history In-Reply-To: <bug-18795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18795-70-e6iwDaC4fS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795 Bouzid Fergani <bouzid.fergani at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95267|0 |1 is obsolete| | --- Comment #19 from Bouzid Fergani <bouzid.fergani at inlibro.com> --- Created attachment 95465 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95465&action=edit Bug 18795: (follow-up) Unify error message to be same across codebase In Koha/REST/V1/Patrons.pm the error message for not finding patron is "Patron not found" so let's use the same here. Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 21:36:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 20:36:03 +0000 Subject: [Koha-bugs] [Bug 18795] REST API: DELETE (anonymize) checkout history In-Reply-To: <bug-18795-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18795-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18795-70-SpMhlFBshM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18795 Bouzid Fergani <bouzid.fergani at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 21:49:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 20:49:40 +0000 Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history In-Reply-To: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23838-70-EEVpWA9XTQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Bouzid Fergani <bouzid.fergani at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94681|0 |1 is obsolete| | --- Comment #17 from Bouzid Fergani <bouzid.fergani at inlibro.com> --- Created attachment 95466 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95466&action=edit Bug 23838: Add 'renewals' API route This patch adds a /patrons/x/renewals API GET route which returns a patron's renewals, optionally filtered by item_id. Tests are also included Sponsored-by: Loughborough University Signed-off-by: Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 21:49:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 20:49:47 +0000 Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history In-Reply-To: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23838-70-ybnqOZzCjD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Bouzid Fergani <bouzid.fergani at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94682|0 |1 is obsolete| | --- Comment #18 from Bouzid Fergani <bouzid.fergani at inlibro.com> --- Created attachment 95467 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95467&action=edit Bug 23838: Add renewals modal This patch adds the display of the renewals modal when appropriate. A "View" link is displayed next to renewals that have logs associated with them. Clicking the link opens the modal that displays the logged renewals. Signed-off-by: Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 21:49:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 20:49:52 +0000 Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history In-Reply-To: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23838-70-2whqknMwHk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Bouzid Fergani <bouzid.fergani at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94683|0 |1 is obsolete| | --- Comment #19 from Bouzid Fergani <bouzid.fergani at inlibro.com> --- Created attachment 95468 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95468&action=edit Bug 23838: (follow-up) Fix QA tool failures Remove those pesky tabs as requested by Owen in comment #7 Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 21:49:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 20:49:58 +0000 Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history In-Reply-To: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23838-70-jpMwJWFYyM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Bouzid Fergani <bouzid.fergani at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94684|0 |1 is obsolete| | --- Comment #20 from Bouzid Fergani <bouzid.fergani at inlibro.com> --- Created attachment 95469 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95469&action=edit Bug 23838: (follow-up) Fix JS strings As requested by Owen in comment #7 Owen, I have modified the "x out y renewals have been logged" formation as you suggested. The "Renewed on x by y" string is harder because it contains markup and I suspected the strings file should contain such things. I have however very slightly reworded it which will hopefully mean it's structure is suitable for other languages too. Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 21:50:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 20:50:02 +0000 Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history In-Reply-To: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23838-70-VkDEGDTGgF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Bouzid Fergani <bouzid.fergani at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94685|0 |1 is obsolete| | --- Comment #21 from Bouzid Fergani <bouzid.fergani at inlibro.com> --- Created attachment 95470 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95470&action=edit Bug 23838: (follow-up) Rephrase log message As suggested by Owen in comment #10 Thanks Owen, I went for the second option Signed-off-by: Owen Leonard <oleonard at myacpl.org> Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 21:57:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 20:57:03 +0000 Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history In-Reply-To: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23838-70-MH048xS8t2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 --- Comment #22 from Bouzid Fergani <bouzid.fergani at inlibro.com> --- Created attachment 95471 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95471&action=edit Bug 17374: (follow-up) Unit tests and remove warns Signed-off-by: Maxime Dufresne <maxime.dufresne at inlibro.com> Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 21:57:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 20:57:09 +0000 Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history In-Reply-To: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23838-70-xpm2r1Kf5g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 --- Comment #23 from Bouzid Fergani <bouzid.fergani at inlibro.com> --- Created attachment 95472 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95472&action=edit Bug 17374: Make use of fields from syspref 'DefaultPatronSearchFields' in patron search fields dropdown This patch preserves the current dropdown choices for patron search and adds fields from the DefaultPatronSearchFields system preference To test: 1 - View the regular patron search and note fields in dropdown 2 - Apply patch, ensure dropdown has not changed 3 - Add fields to DefaultPatronSearchFields, note they are available in dropdown 4 - Ensure existing and new fields search properly Signed-off-by: Kelly <kelly at bywatersolutions.com> Signed-off-by: Maxime Dufresne <maxime.dufresne at inlibro.com> Signed-off-by: Bouzid Fergani <bouzid.fergani at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 23:29:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 22:29:19 +0000 Subject: [Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch In-Reply-To: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17674-70-TJ1KXxg6nQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Maryse Simard <maryse.simard at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff CC| |maryse.simard at inlibro.com --- Comment #123 from Maryse Simard <maryse.simard at inlibro.com> --- I tried testing myself and could not reproduce the situation when the enumchron is emptied. I also tried testing with Biblibre's sandbox using Unimarc database and "Psychologies" subscription, but did not observe the problem. I wonder if I could trouble you for the exact steps you used to produce this error while testing? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 15 23:57:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 15 Nov 2019 22:57:28 +0000 Subject: [Koha-bugs] [Bug 21939] Permission for holds history tab is too strict In-Reply-To: <bug-21939-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21939-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21939-70-RybzaOIaGq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #8 from Liz Rea <wizzyrea at gmail.com> --- Hi, May we have this for 19.05 as well? It applies cleanly and works nicely there. Cheers, Liz -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 16 09:08:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Nov 2019 08:08:18 +0000 Subject: [Koha-bugs] [Bug 23992] Adding multiple items with barcode might end with infinite loop if same barcode will be next_value In-Reply-To: <bug-23992-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23992-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23992-70-kk3R0r5ao4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23992 --- Comment #5 from Andrew Nugged <nugged at gmail.com> --- (In reply to Jonathan Druart from comment #3) Also we had discussion about "sequence" of barcodes with KohaSuomi community/cataloguers but I still unclear in vision. Do librarians needs to insert barcodes for items in the middle as THEY want? Or is it enough to number barcodes from free space from the max? Or fill randomly from given incrementally skipping existing ones and no matter how they spreaded, just should be unique and different? Is these requirements worldwide or they need some settings + interface feedback about skipps/stopped generator/etc? I proposed just to print error/do partial add/inform user when barcode sequence generated not as "user may expect", if users expects barcodes to start from their own wished barcode. But I don't have answer then "should we also inform that some barcode numbers were skipped"? Example of the situation: if user will put first barcode which occupied, system will increment barcodes until free gap, and user will get all items numbered with totally diferent barcodes instead of that which he/she put on the beginning, and this even won't give any feedback to user. Should that be so? Maybe – we should inform user that sequence was broken (jumped over occupied barcode, empty next one generated, barcode not re-generated), and stop? I brought this question + partial solution here as WIP/unclear. Will re-translate this my message to IRC chat then. And thanks for you that you're joined this small brainstorming :). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 16 22:18:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 16 Nov 2019 21:18:50 +0000 Subject: [Koha-bugs] [Bug 24027] Adding multiple items is slow In-Reply-To: <bug-24027-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24027-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24027-70-BoMHmT6hUU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24027 Andrew Nugged <nugged at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95446|0 |1 is obsolete| | --- Comment #11 from Andrew Nugged <nugged at gmail.com> --- Created attachment 95473 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95473&action=edit Bug 24027: Call ModZebra only once after all items have been added Why happened: - call to ModZebra was done after EACH item added, but it was called only with main biblionumber only, so call was the same on each of requests - and also time spent in that ModZebra sub increased with every next hundred items in DB for that element: so adding every next 100 was slower and slower, Solved: - now it's called only once (by adding some extra parameter to "AddItem*" sub set in postponed mode) - and now adding of elements not so heavily depends from how much items was in DB before. Test plan / How to replicate the issue: (test depends from how already populated DB and Zebra/Elasticsearch DBs so might be not so noticeably fast on empty DBs) - go to one of bibliotitems cataloguing/additem.pl?biblionumber=XXX pages - press button "add multiple copies of this item", put 1000 on slower machines, 5000 on faster - start measuring time + submit page/form It takes some amount of time even up to timeout. After applying patch, run the same procedure for same number of items. Note: it goes fast in both variants on empty database so time not so noticeable (also depents how ModZebra-related stuff is configured). Also it slows more linearly when number of items grows. But, again, it heavily depends how database is populated and indexes are rebuild but it's obvious that it will me much more efficient to call "ModZebra" once after 1000 addings, then call it 1000 times on each item created in the loop. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 17 15:26:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Nov 2019 14:26:06 +0000 Subject: [Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch In-Reply-To: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17674-70-pilPP3JD3S@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Michal Denar <black23 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 17 15:26:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 17 Nov 2019 14:26:11 +0000 Subject: [Koha-bugs] [Bug 17674] Allow UI to delete serials issues in batch In-Reply-To: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17674-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17674-70-E1jx9Itfvb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17674 Michal Denar <black23 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86689|0 |1 is obsolete| | --- Comment #124 from Michal Denar <black23 at gmail.com> --- Created attachment 95474 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95474&action=edit Bug 17674: Allow UI to delete serials in batch This new feature allows for batch deletion of serials through the UI. The current usage is a one-by-one long game. Test plan : - Apply patch. - Create at least four serials with items. - Notice that new items have a numbering pattern and a date in the enumchron field. - Use the button Delete selected issues for the following steps. - Delete a serial and its associated item. - Confirm the serial and item are gone. - Delete a serial and not its item. - Confirm the serial is gone. - Confirm the item is still there and the date part in the enumchron field is gone. - Delete the two lasts serials. - Confirm they are gone. Sponsored by : CCSR Signed-off-by: Michal Denar <black23 at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 09:04:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 08:04:34 +0000 Subject: [Koha-bugs] [Bug 23822] Regression: As of 19.05.04 deletion of patrons with outstanding credits is silently blocked In-Reply-To: <bug-23822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23822-70-hEoAaUS5vt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23822 --- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Fridolin SOMERS from comment #11) > Shouldn't we also fix the other line : > if ( $op eq 'delete_confirm' or $countissues > 0 or $charges or > $is_guarantor ) { Maybe, we are going to follow-up on bug 24008 anyway. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 09:30:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 08:30:09 +0000 Subject: [Koha-bugs] [Bug 23822] Regression: As of 19.05.04 deletion of patrons with outstanding credits is silently blocked In-Reply-To: <bug-23822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23822-70-n5c2pAvbRb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23822 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Pushed to master |Pushed to stable Version(s)|19.11.00 |19.11.00,19.05.05 released in| | --- Comment #13 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 19.05.x for 19.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 09:45:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 08:45:26 +0000 Subject: [Koha-bugs] [Bug 22831] Elasticsearch - add a maintenance script for checking DB vs index counts In-Reply-To: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22831-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22831-70-tAusoyOLSL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22831 Michal Denar <black23 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |josef.moravec at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 10:23:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 09:23:19 +0000 Subject: [Koha-bugs] [Bug 23969] Add library to public lists In-Reply-To: <bug-23969-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23969-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23969-70-1ENHeE3DPW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23969 --- Comment #2 from BASE Library Consortium <baselibrary.consortium at nhs.net> --- Hi! Yes, the home library of the list's creator. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 10:34:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 09:34:21 +0000 Subject: [Koha-bugs] [Bug 20948] Hold requests on detail.pl In-Reply-To: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20948-70-QrFkA4NM4Q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|17.05 |master Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 10:38:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 09:38:49 +0000 Subject: [Koha-bugs] [Bug 20948] Hold requests on detail.pl In-Reply-To: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20948-70-ffTvB9w8Ua@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 10:38:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 09:38:53 +0000 Subject: [Koha-bugs] [Bug 20948] Hold requests on detail.pl In-Reply-To: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20948-70-kLWk8FZR6V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95476 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95476&action=edit Bug 20948: Simplify existing code No changes expected here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 10:38:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 09:38:56 +0000 Subject: [Koha-bugs] [Bug 20948] Hold requests on detail.pl In-Reply-To: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20948-70-39sUOvb6gW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 --- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95477 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95477&action=edit Bug 20948: Only display item-level hold info if first hold On the item list of the catalogue detail page we display next item-level hold info even if it is not the next hold. That leads to confusion as it will not necessarily be the accurate info. This patch makes the following changes: - Display the item-level hold only if it is the next hold (priority == 1) - Display "There is an item level hold on this item (priority=X)" if there is at least 1 item-level hold placed on this item Test plan: - Place several next available holds on a single item record - Place an item level hold on the item - Go the the biblio detail page => Without this patch, the item will show the item level hold => With the patch you see "There is an item level hold on this item" - Check the item in, confirm the hold => No changes, the item will show the waiting hold info - Cancel all the holds except the item-level one => No changes, the item will how the item-level one -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 10:40:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 09:40:48 +0000 Subject: [Koha-bugs] [Bug 20948] Item-level hold info displayed regardless its priority (detail.pl) In-Reply-To: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20948-70-qUwGJuKxL9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Hold requests on detail.pl |Item-level hold info | |displayed regardless its | |priority (detail.pl) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 11:20:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 10:20:10 +0000 Subject: [Koha-bugs] [Bug 24051] New: batchMod.pl: DBIx::Class::ResultSet::search_rs(): search( %condition ) is deprecated Message-ID: <bug-24051-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24051 Bug ID: 24051 Summary: batchMod.pl: DBIx::Class::ResultSet::search_rs(): search( %condition ) is deprecated Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org batchMod.pl: DBIx::Class::ResultSet::search_rs(): search( %condition ) is deprecated, use search( \\%condition ) instead at /kohadevbox/koha/Koha/Objects.pm line 136: /kohadevbox/koha/tools/batchMod.pl, referer: http://localhost:8081/cgi-bin/koha/reports/guided_reports.pl?reports=1&phase=Run%20this%20report -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 11:20:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 10:20:27 +0000 Subject: [Koha-bugs] [Bug 19490] Add a 'holds' column to the Batch Item Modification Tool In-Reply-To: <bug-19490-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19490-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19490-70-ozTWp3FPpE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24051 --- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #19) > From > commit e427cf5b3f3ded54dbc6899c149a2de3e8ab13ea > Bug 19490: Add a 'Holds' column to the items batchmodification tool > > This following line: > + $this_row{item_holds} = Koha::Holds->search( itemnumber => > $itemnumber )->count; > > displays a DBIC warning: > [Mon Apr 29 01:49:32.831375 2019] [cgi:error] [pid 17243] [client > 192.168.50.1:42814] AH01215: [Mon Apr 29 01:49:32 2019] batchMod.pl: > DBIx::Class::ResultSet::search_rs(): search( %condition ) is deprecated, use > search( \\%condition ) instead at /home/vagrant/kohaclone/Koha/Objects.pm > line 136: /home/vagrant/kohaclone/tools/batchMod.pl, referer: > http://pro.kohadev.org/cgi-bin/koha/tools/batchMod.pl > > Must be ->search({ itemnumber => $itemnumber })->count See bug 24051. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24051 [Bug 24051] batchMod.pl: DBIx::Class::ResultSet::search_rs(): search( %condition ) is deprecated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 11:20:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 10:20:27 +0000 Subject: [Koha-bugs] [Bug 24051] batchMod.pl: DBIx::Class::ResultSet::search_rs(): search( %condition ) is deprecated In-Reply-To: <bug-24051-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24051-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24051-70-2FLDUzkSKo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24051 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |19490 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19490 [Bug 19490] Add a 'holds' column to the Batch Item Modification Tool -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 11:23:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 10:23:46 +0000 Subject: [Koha-bugs] [Bug 23982] Count/pagination broken for reports with duplicated column names In-Reply-To: <bug-23982-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23982-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23982-70-1GoSgvnei8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23982 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 11:23:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 10:23:50 +0000 Subject: [Koha-bugs] [Bug 23982] Count/pagination broken for reports with duplicated column names In-Reply-To: <bug-23982-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23982-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23982-70-GbYqGMaptZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23982 --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95479 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95479&action=edit Bug 23982: (bug 23624 follow-up) Handle SQL error caused by derived table Caused by commit bca4453c50d8b5b1d3c7029ded2b522a9a2bf868 Bug 23624: (QA follow-up) Optimize even more A report like: SELECT * FROM issues JOIN borrowers USING (borrowernumber) will have two borrowernumber columns - SQL will give us there rsults, but if we try to wrap them in a SELECT COUNT(*) FROM (report) it throws a duplicated column error. This patch suggests to execute the query the old way if the derived table optimization failed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 11:24:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 10:24:11 +0000 Subject: [Koha-bugs] [Bug 23982] Count/pagination broken for reports with duplicated column names In-Reply-To: <bug-23982-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23982-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23982-70-7CIIa6BJJa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23982 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 11:24:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 10:24:47 +0000 Subject: [Koha-bugs] [Bug 23982] Count/pagination broken for reports with duplicated column names In-Reply-To: <bug-23982-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23982-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23982-70-KsdwBVaczT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23982 --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- This impacts stable releases and will cause reports to fail. I think it's a critical one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 11:32:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 10:32:11 +0000 Subject: [Koha-bugs] [Bug 24051] batchMod.pl: DBIx::Class::ResultSet::search_rs(): search( %condition ) is deprecated In-Reply-To: <bug-24051-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24051-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24051-70-w58UnzLwPS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24051 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 11:32:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 10:32:14 +0000 Subject: [Koha-bugs] [Bug 24051] batchMod.pl: DBIx::Class::ResultSet::search_rs(): search( %condition ) is deprecated In-Reply-To: <bug-24051-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24051-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24051-70-CbevCJxDEO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24051 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95486 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95486&action=edit Bug 24051: Remove "search( %condition ) is deprecated" warning from batchMod.pl Test plan: Go to Home › Tools › Batch item modification Insert barcodes and continue => Without this patch you will get warning in the log => With this patch applied you warning does no longer appear Confirm that the number of holds is correct -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 12:01:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 11:01:41 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-MHM3XUq9d9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95398|0 |1 is obsolete| | Attachment #95421|0 |1 is obsolete| | Attachment #95422|0 |1 is obsolete| | Attachment #95423|0 |1 is obsolete| | Attachment #95424|0 |1 is obsolete| | Attachment #95425|0 |1 is obsolete| | Attachment #95426|0 |1 is obsolete| | Attachment #95427|0 |1 is obsolete| | Attachment #95428|0 |1 is obsolete| | Attachment #95429|0 |1 is obsolete| | Attachment #95430|0 |1 is obsolete| | Attachment #95431|0 |1 is obsolete| | --- Comment #39 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95487 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95487&action=edit Bug 23590: Add ability to edit the manager of a suggestion Prior to this patch there was an hidden behavior that set the manager to the logged in user when a suggestion was edited. This patch proposes to let the librarian pick another manager. Other small adjustements will be added to polish this new behavior: * Create 2 new DB columns: suggestions.lastmodificationby and suggestion.lastmodificationdate * Choose a manager when editing a suggestion * Batch modify suggestions and set a manager for them * Let notify the new manager using the TO_PROCESS letter * Display the manageddate, lastmodificationby and lastmodificationdate info where appropriate This first patch adds a new "Select manager" link when editing a suggestion. Test plan for the whole patchset: 0/ a. Execute the update DB entry, generate the new DBIC file and restart all b. Create at least 2 patrons with the suggestions_manage permission 1/ Submit a new suggestion (OPAC or staff, not important) 2/ Accept it 3/ Edit it => "Last modification by" is empty => You see that you are the manager of this suggestion 4/ Click "Select manager" and search for a new manager => The patron search will only display patrons with the suggestions_manage permission 5/ Save 6/ Edit again => The manager is set to you, but there is a note saying that previously it was the patron you picked => The "Last modification by" is set to you 7/ Click "Keep existing manager" => The manager is now set to the previous manager 8/ Select another manager (which has a valid email address defined) 9/ Click the "notify" checkbox 10/ Save 11/ Confirm that a TO_PROCESS notice has been generated into the message_queue table 12/ Create at least one other suggestion 13/ List the suggestions => There is a 4th action column to assign a manager to several suggestions in one go. 14/ Use this new button and confirm that it works as expected 15/ Go to your purchase suggestion list (OPAC and staff) => You see the "managed date" displayed in a new column Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 12:01:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 11:01:46 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-af85Csoo4I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #40 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95488 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95488&action=edit Bug 23590: Clean TT variables for patrons Just a bit of cleaning Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 12:01:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 11:01:52 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-qLV3pmQ72v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #41 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95489 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95489&action=edit Bug 23590: Cleaning - Remove op_* vars Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 12:01:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 11:01:57 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-nLoRtvZKl3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #42 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95490 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95490&action=edit Bug 23590: Batch update manager for suggestions Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 12:02:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 11:02:03 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-SVJi3VO4mN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #43 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95491 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95491&action=edit Bug 23590: Only return patrons that have the suggestions_manage permission Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 12:02:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 11:02:09 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-eKgENIchE5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #44 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95492 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95492&action=edit Bug 23590: Add the ability to notify a new manager Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 12:02:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 11:02:14 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-96Vv795AM0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #45 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95493 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95493&action=edit Bug 23590: Display managed date in 'Your purchase suggestions' Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 12:02:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 11:02:20 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-twmiLI55Ws@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #46 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95494 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95494&action=edit Bug 23590: Add lastmodification by and date columns No tests are provided for the changes made to SearchSuggestion. It is going to be remove very soon as it is super ugly... Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 12:02:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 11:02:24 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-ik1HSgGm4t@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #47 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95495 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95495&action=edit Bug 23590: Add atomic update file Sponsored-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 12:02:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 11:02:30 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-N6mD7TQ2mL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #48 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95496 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95496&action=edit Bug 23590: Remove JS error on the suggestion list The notify option is only available from the edit view Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 12:02:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 11:02:37 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-S3JV7O1U2K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #49 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95497 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95497&action=edit Bug 23590: Fix select manager on list for all tabs Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 12:02:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 11:02:43 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-f58vY4VAcj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 --- Comment #50 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95498 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95498&action=edit Bug 23590: DBIC Changes Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 12:08:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 11:08:58 +0000 Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions In-Reply-To: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22784-70-rutCrqsLUV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 12:09:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 11:09:02 +0000 Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions In-Reply-To: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22784-70-6udPmhdm65@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95499 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95499&action=edit Bug 22784: DB Changes Sponsored-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 12:09:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 11:09:05 +0000 Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions In-Reply-To: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22784-70-U88HyNqz8p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95500 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95500&action=edit Bug 22784: DBIC Changes Sponsored-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 12:09:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 11:09:09 +0000 Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions In-Reply-To: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22784-70-eCK670llNf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95501 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95501&action=edit Bug 22784: Add the ability to archive/unarchive a purchase suggestions There are performance issues when searching suggestions if there are thousands of suggestions. To prevent that we are going to add the ability to archive purchase suggestions, in order to remove them from the search list (by default). Test plan: 0. Apply all the patches, execute the updatedatabase.pl script, restart all 1. Create some suggestions 2. Search for them 3. Use the "Archive" action button for one of them 4. Restart the search => The archived suggestion does no longer appear in the list 5. Use the filter "Included archived" in the "Suggestion information" filter box => The archived suggestion is now displayed 6. Use other filters => The "archived" filter is kept from one search to another 7. Use one of the action at the bottom of the suggestion list (change the status for instance) => The "archived" filter is still kept Sponsored-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 12:09:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 11:09:13 +0000 Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions In-Reply-To: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22784-70-zhP5Fhf7aR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95502 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95502&action=edit Bug 22784: Add a cronjob to archive suggestions given age or status criteria In order to deal automatically with suggestions that need to be archived, this cronjob will help to add the "archived" flag following their age or status. Test plan: - Execute the script with the --help parameter and read the documentation. - Does it make sense? - Use it without the --confirm flag and try several combination For instance you will want to archive suggestions that have been rejected for more than a week: perl misc/cronjobs/archive_purchase_suggestions.pl --age-date-field=rejecteddate --age=weeks:1 or even suggestion that have been suggested for more than a year and have a ORDERED status: perl misc/cronjobs/archive_purchase_suggestions.pl --age-date-field=suggesteddate --age=years:1 --status=ORDERED - Use it with the --confirm flag and make sure the suggestions have been archived. Sponsored-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 12:09:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 11:09:25 +0000 Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history In-Reply-To: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23838-70-G7uLWWIxOM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 --- Comment #24 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Hi Bouzid I think when you attached your sign off patches to this bug, you accidentally attached an unrelated patch to the end. If this is correct, could you please obsolete it? Many thanks Andrew -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 12:10:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 11:10:07 +0000 Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history In-Reply-To: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23838-70-DQJqqzTxvg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 --- Comment #25 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Sorry, correction, you appended two unrelated patches. They're clearly for another bug, so I'm going to obsolete them. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 12:10:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 11:10:10 +0000 Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions In-Reply-To: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22784-70-WNXjkBpqgI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22590 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22590 [Bug 22590] Allow batch printing of routing lists -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 12:10:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 11:10:10 +0000 Subject: [Koha-bugs] [Bug 22590] Allow batch printing of routing lists In-Reply-To: <bug-22590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22590-70-Yhb8t3mp67@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22590 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22784 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 [Bug 22784] Archiving Purchase Suggestions -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 12:10:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 11:10:28 +0000 Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history In-Reply-To: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23838-70-wlAx4JfDH2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95471|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 12:10:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 11:10:39 +0000 Subject: [Koha-bugs] [Bug 23838] Add ability to view item renew history In-Reply-To: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23838-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23838-70-eThN1XCsgB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23838 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95472|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 12:17:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 11:17:43 +0000 Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions In-Reply-To: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22784-70-40EM8XW5L4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://gitlab.com/joubu/Ko | |ha/commits/bug_22784 --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Joy Nelson from comment #0) > Create a way to archive the 'completed' purchase suggestions on the staff > side. > 1. Add an 'archived' column to purchase suggestions Done! > 2. Add a script to automatically mark suggestions of a certain age and > status as archived Done! > 3. Add a button on the purchase suggestions page to archive specific > suggestions Were you suggesting 1 new action for the selected suggestions? This patchset only add 1 new action per suggestion. We could have another action at the bottom of the suggestion list but I am afraid it will become a bit packed and we are going to lose readability, dependent bug reports already add stuff there. I would suggest to deal with that on a separate bug report. > 4. Add a 'view archived suggestions' button to view archived suggestions. > Default view does not display archived suggestions Not sure it is needed as there is the filter. I am willing to add something after you have tested the patches and can tell me what you have exactly in mind ;) > 5. Add 'archived' option to the filters on the purchase suggestions page. Done! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 12:18:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 11:18:50 +0000 Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions In-Reply-To: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22784-70-FqrH7HbbXJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 12:22:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 11:22:38 +0000 Subject: [Koha-bugs] [Bug 24053] New: Typo in FinePaymentAutoPopup description Message-ID: <bug-24053-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24053 Bug ID: 24053 Summary: Typo in FinePaymentAutoPopup description Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org There is a typo in the FinePaymentAutoPopup system preference description: automatically display a print dialog for a payment receipt when making a payment.. .. at the end. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 12:22:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 11:22:45 +0000 Subject: [Koha-bugs] [Bug 24053] Typo in FinePaymentAutoPopup description In-Reply-To: <bug-24053-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24053-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24053-70-8iFHhaNXRD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24053 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 12:30:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 11:30:02 +0000 Subject: [Koha-bugs] [Bug 24054] New: Typo in ClaimReturnedWarningThreshold system preference Message-ID: <bug-24054-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24054 Bug ID: 24054 Summary: Typo in ClaimReturnedWarningThreshold system preference Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org ClaimReturnedWarningThreshold# Warn librarians that a patron has excessive return cliams if the patron has claimed the return of more than cliams is spelled wrong. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 12:54:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 11:54:55 +0000 Subject: [Koha-bugs] [Bug 24055] New: Description of PayPalReturnURL system preference is unclear Message-ID: <bug-24055-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24055 Bug ID: 24055 Summary: Description of PayPalReturnURL system preference is unclear Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org PayPalReturnURL says: After payment or cancellation, PayPal should return to the␠OPAC's alias It's not clear what is meant by OPAC's alias. Could this be rephrased or an example be added to make this clearer? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 12:55:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 11:55:06 +0000 Subject: [Koha-bugs] [Bug 24055] Description of PayPalReturnURL system preference is unclear In-Reply-To: <bug-24055-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24055-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24055-70-NaHODcG1hJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24055 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 13:25:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 12:25:49 +0000 Subject: [Koha-bugs] [Bug 5145] Show call number for available item in XSLT availability information In-Reply-To: <bug-5145-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-5145-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5145-70-GhyZosWlaL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5145 Christian Stelzenmüller <christian.stelzenmueller at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |christian.stelzenmueller at bs | |z-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 13:33:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 12:33:23 +0000 Subject: [Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history In-Reply-To: <bug-23916-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23916-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23916-70-ufqzLjcb8X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 --- Comment #14 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 95503 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95503&action=edit Bug 23916: (follow-up) Fix column name collision Seems that joining 'borrowers' into the query run in C4::Members::GetAllIssues caused a column name collision, which blatted the retrieval of issues.branchcode. So we now are being a bit more specific in what is coming from where in the query. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 13:40:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 12:40:14 +0000 Subject: [Koha-bugs] [Bug 24056] New: Capitalization: Cash Register ID on cash register management page Message-ID: <bug-24056-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24056 Bug ID: 24056 Summary: Capitalization: Cash Register ID on cash register management page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org When editing a cash register, there is: Cash Register ID:␠ This should be: Cash register ID to follow our capitalization guidelines. Make sure you have activated cash registers via system preferences, add a cash register and edit it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 13:43:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 12:43:27 +0000 Subject: [Koha-bugs] [Bug 24057] New: Hea is not an acronym Message-ID: <bug-24057-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24057 Bug ID: 24057 Summary: Hea is not an acronym Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Found while translating: Change your HEA settings HEA is like Koha not an acronym, so should be: Hea. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 14:05:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 13:05:47 +0000 Subject: [Koha-bugs] [Bug 24047] Rename , Rearrange cataloging form fields In-Reply-To: <bug-24047-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24047-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24047-70-e2pPXc1r4o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24047 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |INVALID --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi, Bugzilla is used for bug reports and enhanement requests. What you describe is more of a support request. Please bring it up on the mailing list, but make sure you check the "Bibliographic frameworks" section on the manual first. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 14:07:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 13:07:44 +0000 Subject: [Koha-bugs] [Bug 24049] Limit for Consecutive Hold Requests In-Reply-To: <bug-24049-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24049-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24049-70-jLVuaBmqXV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24049 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Christopher, can you explain this a bit more? Is this a variation of the daily hold limit or do you mean holds on the same record/item? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 14:48:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 13:48:06 +0000 Subject: [Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history In-Reply-To: <bug-23916-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23916-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23916-70-Y1snyIMyjc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94914|0 |1 is obsolete| | --- Comment #15 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 95504 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95504&action=edit Bug 23916: Add issues.issuer column and FK This patch adds the issues.issuer column which is a foreign key to borrowers.borrowernumber Signed-off-by: Ben Veasey <B.T.Veasey at lboro.ac.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 14:48:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 13:48:09 +0000 Subject: [Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history In-Reply-To: <bug-23916-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23916-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23916-70-ySEQU2i7oU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94915|0 |1 is obsolete| | --- Comment #16 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 95505 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95505&action=edit Bug 23916: Add "RecordIssuer" syspref This patch adds the "RecordIssuer" syspref, which is disabled by default Signed-off-by: Ben Veasey <B.T.Veasey at lboro.ac.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 14:48:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 13:48:12 +0000 Subject: [Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history In-Reply-To: <bug-23916-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23916-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23916-70-fe4UeBCZvr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94916|0 |1 is obsolete| | --- Comment #17 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 95506 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95506&action=edit Bug 23916: Record and display item issuer This patch adds the recording and display of the item issuer. This behaviour is governed by the RecordIssuer syspref, if disabled (the default), no recording or display of issuer will take place. Signed-off-by: Ben Veasey <B.T.Veasey at lboro.ac.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 14:48:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 13:48:15 +0000 Subject: [Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history In-Reply-To: <bug-23916-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23916-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23916-70-Otz8tMyBRG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94917|0 |1 is obsolete| | --- Comment #18 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 95507 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95507&action=edit Bug 23916: Anonymise 'issuer' when required This patch adds the anonymisation of 'old_issues.issuer' alongside the existing anonymisation of 'old_issues.borrowernumber' Signed-off-by: Ben Veasey <B.T.Veasey at lboro.ac.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 14:48:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 13:48:18 +0000 Subject: [Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history In-Reply-To: <bug-23916-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23916-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23916-70-kI9zFCSxkX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94918|0 |1 is obsolete| | --- Comment #19 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 95508 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95508&action=edit Bug 23916: Add unit tests This patch adds unit tests for the new functions Signed-off-by: Ben Veasey <B.T.Veasey at lboro.ac.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 14:48:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 13:48:22 +0000 Subject: [Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history In-Reply-To: <bug-23916-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23916-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23916-70-k1naiMrIIV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95503|0 |1 is obsolete| | --- Comment #20 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 95509 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95509&action=edit Bug 23916: (follow-up) Fix column name collision Seems that joining 'borrowers' into the query run in C4::Members::GetAllIssues caused a column name collision, which blatted the retrieval of issues.branchcode. So we now are being a bit more specific in what is coming from where in the query. Signed-off-by: Ben Veasey <B.T.Veasey at lboro.ac.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 14:48:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 13:48:33 +0000 Subject: [Koha-bugs] [Bug 23916] Issuer should be recorded and visible in patron circulation history In-Reply-To: <bug-23916-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23916-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23916-70-1NNcQIjTAq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23916 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 14:57:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 13:57:29 +0000 Subject: [Koha-bugs] [Bug 23689] Terminology: Branches limitations should be libraries limitations - Authorised Values In-Reply-To: <bug-23689-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23689-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23689-70-IvsJVQ7KQq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23689 --- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Lucas Gass from comment #10) > i cannot clean apply this patchset and I am a bit unsure about my rebase, > without a proper test plan I am afraid to backport Hi Lucas, this is only a terminology change - I think we can skip it for the late 18.11 versions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 15:19:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 14:19:31 +0000 Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions In-Reply-To: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22784-70-LTVI1euuXw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 15:19:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 14:19:34 +0000 Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions In-Reply-To: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22784-70-5cVzwDHWVL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95501|0 |1 is obsolete| | Attachment #95502|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95510 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95510&action=edit Bug 22784: Add the ability to archive/unarchive a purchase suggestions There are performance issues when searching suggestions if there are thousands of suggestions. To prevent that we are going to add the ability to archive purchase suggestions, in order to remove them from the search list (by default). Test plan: 0. Apply all the patches, execute the updatedatabase.pl script, restart all 1. Create some suggestions 2. Search for them 3. Use the "Archive" action button for one of them 4. Restart the search => The archived suggestion does no longer appear in the list 5. Use the filter "Included archived" in the "Suggestion information" filter box => The archived suggestion is now displayed 6. Use other filters => The "archived" filter is kept from one search to another 7. Use one of the action at the bottom of the suggestion list (change the status for instance) => The "archived" filter is still kept Sponsored-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 15:19:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 14:19:38 +0000 Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions In-Reply-To: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22784-70-wpTxU4UaLq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 --- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95511 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95511&action=edit Bug 22784: Bugfix - do not modify #description build Debian packages from a git repository -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 15:19:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 14:19:42 +0000 Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions In-Reply-To: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22784-70-47H6Rw6gMP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 --- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95512 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95512&action=edit Bug 22784: Do not display an empty table This is terrible and highlight that the whole script must be rewrite. GetDistinctValues does not handle the "archived" flag (and we do not want to put our hands there), so let's hack that and plan to rewrite the whole script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 15:19:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 14:19:46 +0000 Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions In-Reply-To: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22784-70-Z1QgBAyRlE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 --- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95513 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95513&action=edit Bug 22784: Add a cronjob to archive suggestions given age or status criteria In order to deal automatically with suggestions that need to be archived, this cronjob will help to add the "archived" flag following their age or status. Test plan: - Execute the script with the --help parameter and read the documentation. - Does it make sense? - Use it without the --confirm flag and try several combination For instance you will want to archive suggestions that have been rejected for more than a week: perl misc/cronjobs/archive_purchase_suggestions.pl --age-date-field=rejecteddate --age=weeks:1 or even suggestion that have been suggested for more than a year and have a ORDERED status: perl misc/cronjobs/archive_purchase_suggestions.pl --age-date-field=suggesteddate --age=years:1 --status=ORDERED - Use it with the --confirm flag and make sure the suggestions have been archived. Sponsored-by: BULAC - http://www.bulac.fr/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 15:51:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 14:51:09 +0000 Subject: [Koha-bugs] [Bug 24046] 'Activate filters' untranslatable In-Reply-To: <bug-24046-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24046-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24046-70-wcLw2K18De@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24046 --- Comment #1 from Maryse Simard <maryse.simard at inlibro.com> --- Created attachment 95514 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95514&action=edit Bug 24046: Untranslatable 'Activate filters' Bug 9573 moved the code for the table filters activation to it's own javascript file. The strings contained in this file are not translatable. This patch moves the strings to their own strings file which is then included with the javascript from the templates. Test plan: Visit the catalogue/detail.pl and reports/itemslost.pl and test that the 'Activate/Deactivate filters' option still work correctly. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 15:51:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 14:51:47 +0000 Subject: [Koha-bugs] [Bug 24046] 'Activate filters' untranslatable In-Reply-To: <bug-24046-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24046-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24046-70-2OffDw8i2s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24046 Maryse Simard <maryse.simard at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch Assignee|koha-bugs at lists.koha-commun |maryse.simard at inlibro.com |ity.org | CC| |maryse.simard at inlibro.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 16:16:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 15:16:29 +0000 Subject: [Koha-bugs] [Bug 24058] New: acquisition table displayed even if no order exist (bib detail) Message-ID: <bug-24058-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24058 Bug ID: 24058 Summary: acquisition table displayed even if no order exist (bib detail) Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Keywords: Academy Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 20366 The acquisition table is displayed on the bibliographic detail page, even if the record has not been ordered. It is caused by commit 43326754b110c62fbb2909eea1595656833f8c02 Bug 20366: Add subscription info to the acq tab on the biblio detail page The "orders" variable sent to the template switched from an arrayref to a Koha::Acquisition::Orders object. The condition [% IF orders %] in the template is no longer correct (always true) and must be replaced with [% IF orders.count %] Wrong display: https://snipboard.io/wXOHLJ.jpg Expected display: https://snipboard.io/E8GP6K.jpg Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 [Bug 20366] More information about orders linked to subscriptions on "Acquisition details" tab -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 16:16:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 15:16:29 +0000 Subject: [Koha-bugs] [Bug 20366] More information about orders linked to subscriptions on "Acquisition details" tab In-Reply-To: <bug-20366-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20366-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20366-70-jqHmL5sWKp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20366 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24058 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24058 [Bug 24058] acquisition table displayed even if no order exist (bib detail) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 17:00:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 16:00:58 +0000 Subject: [Koha-bugs] [Bug 18945] UseQueryParser system preference breaks subject searches In-Reply-To: <bug-18945-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18945-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18945-70-h00880rTV3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18945 Galen Charlton <gmcharlt at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com --- Comment #1 from Galen Charlton <gmcharlt at gmail.com> --- I can reproduce this bug when UseICU is also on. Among other effects, UseICU will use {} rather than "" to quote a subject phrase when building the subject headings link (see bug 7092). However, a search like su:{Cats} triggers an infinite loop bug in OpenILS::QueryParser->decompose(). The following warnings emitted by QueryParser with debug logging turned on gives an idea of what's going on: Start of the loop. last_type: , joiner: &, struct: Koha::QueryParser::Driver::PQF::query_plan=HASH(0x40e1618) Encountered class change: subject|subject#su Start of the loop. last_type: , joiner: &, struct: Koha::QueryParser::Driver::PQF::query_plan=HASH(0x40e1618) Encountered atom: {Wizards Remainder: } Start of the loop. last_type: , joiner: &, struct: Koha::QueryParser::Driver::PQF::query_plan=HASH(0x40e1618) Start of the loop. last_type: , joiner: &, struct: Koha::QueryParser::Driver::PQF::query_plan=HASH(0x40e1618) Start of the loop. last_type: , joiner: &, struct: Koha::QueryParser::Driver::PQF::query_plan=HASH(0x40 ... above repeats indefinitely This bug appears to be more or less identical to one of the issues fixed by Evergreen bug https://bugs.launchpad.net/evergreen/+bug/1251359. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 17:08:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 16:08:17 +0000 Subject: [Koha-bugs] [Bug 24059] New: Remove unused Greybox assets from detail.tt Message-ID: <bug-24059-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24059 Bug ID: 24059 Summary: Remove unused Greybox assets from detail.tt Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: dcook at prosentient.com.au, josef.moravec at gmail.com, katrin.fischer at bsz-bw.de Blocks: 8290 The Greybox library is included on the bibliographic detail page in the staff client but doesn't seem to be required for anything. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8290 [Bug 8290] Replace usage of Greybox modals with Bootstrap modals -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 17:08:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 16:08:17 +0000 Subject: [Koha-bugs] [Bug 8290] Replace usage of Greybox modals with Bootstrap modals In-Reply-To: <bug-8290-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8290-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8290-70-3zbgXl7FZ0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8290 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24059 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24059 [Bug 24059] Remove unused Greybox assets from detail.tt -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 17:17:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 16:17:06 +0000 Subject: [Koha-bugs] [Bug 24057] Hea is not an acronym In-Reply-To: <bug-24057-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24057-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24057-70-YctZaqp7Oz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24057 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 17:17:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 16:17:09 +0000 Subject: [Koha-bugs] [Bug 24057] Hea is not an acronym In-Reply-To: <bug-24057-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24057-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24057-70-tq2kDD2ftN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24057 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 95515 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95515&action=edit Bug 24057: Hea is not an acronym This patch changes "HEA" (incorrectly capitalized) to "Hea" on the staff client administration home page. To test, apply the patch and set the "UsageStats" system preference to "No, let me think about it." - Go to Administration in the staff client. - There should be a message at the top asking if you want to share anonymous usage statisitcs with the community. The word "Hea" in this message should be capitalized correctly. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 17:18:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 16:18:21 +0000 Subject: [Koha-bugs] [Bug 24060] New: Can't load patron clubs tab on patron details page Message-ID: <bug-24060-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24060 Bug ID: 24060 Summary: Can't load patron clubs tab on patron details page Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Fixed in master by https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=94018&action=diff To recreate: 1 - Be using 19.05 2 - Create a club template and a club 3 - Go to a patron's checkout page 4 - Note the club tab will load 5 - Go to a patron's details page 6 - Note the club tab says 'Loading' -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 17:18:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 16:18:39 +0000 Subject: [Koha-bugs] [Bug 24060] Can't load patron clubs tab on patron details page In-Reply-To: <bug-24060-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24060-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24060-70-pbjZbFZ79H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24060 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | CC| |kelly at bywatersolutions.com, | |mkstephens at lancasterseminar | |y.edu -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 17:19:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 16:19:51 +0000 Subject: [Koha-bugs] [Bug 24060] Can't load patron clubs tab on patron details page In-Reply-To: <bug-24060-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24060-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24060-70-Km8UbGPkCF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24060 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 17:19:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 16:19:54 +0000 Subject: [Koha-bugs] [Bug 24060] Can't load patron clubs tab on patron details page In-Reply-To: <bug-24060-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24060-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24060-70-9FpY0pU3SG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24060 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95516 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95516&action=edit Bug 24060: Use patron object to load club tab To recreate: 1 - Be using 19.05 2 - Create a club template and a club 3 - Go to a patron's checkout page 4 - Note the club tab will load 5 - Go to a patron's details page 6 - Note the club tab says 'Loading' 7 - Apply patch 8 - It loads! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 17:24:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 16:24:44 +0000 Subject: [Koha-bugs] [Bug 19364] KOHA title search pulls documents with author matches In-Reply-To: <bug-19364-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19364-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19364-70-PFLYMsMaPp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19364 Felicia Beaudry <felicia.beaudry at equinoxinitiative.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|17.05 |19.05 CC| |felicia.beaudry at equinoxinit | |iative.org --- Comment #1 from Felicia Beaudry <felicia.beaudry at equinoxinitiative.org> --- This is still an issue in 19.05. If we're going to continue to include Author in a title search, then maybe the title search needs a different name to reflect that more is included. A colleague suggested "Title - Statement." I would expect a title search to be more focused. We're seeing results where the actual title entered is showing up way down the results list, which is confusing and frustrating for staff and patrons. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 17:32:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 16:32:34 +0000 Subject: [Koha-bugs] [Bug 19364] Title search returns results with author matches In-Reply-To: <bug-19364-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19364-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19364-70-YoprSMVe0a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19364 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal Summary|KOHA title search pulls |Title search returns |documents with author |results with author matches |matches | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 17:47:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 16:47:20 +0000 Subject: [Koha-bugs] [Bug 6813] Search for duplicates across orders, suggestions and catalog In-Reply-To: <bug-6813-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6813-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6813-70-opuubRHbM9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6813 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #41 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- *** This bug has been marked as a duplicate of bug 14973 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 17:47:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 16:47:20 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: <bug-14973-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14973-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14973-70-9i1fiWUWFh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |savitra.sirohi at osslabs.biz --- Comment #44 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- *** Bug 6813 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 18:00:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 17:00:57 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: <bug-14973-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14973-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14973-70-uQN7JYYpi1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 --- Comment #45 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95517 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95517&action=edit Bug 14973: Fix edit a suggestion and dup found The find duplicate call must only be done when the suggestion is new. It does not make sense to search for a duplicate when the suggestion already exists. This patch also fixes a side-effect: - Create a suggestion using an existing biblio title - Ignore the warning and save - Edit again and save => BOOM on date Template process failed: undef error - The given date (18/11/2019) does not match the date format (iso) at /kohadevbox/koha/Koha/DateUtils.pm line 168 The dates are not processed and so badly formatted when sent to the template. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 18:07:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 17:07:39 +0000 Subject: [Koha-bugs] [Bug 24061] New: Print List (opac-shelves.pl) broken in Chrome Message-ID: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24061 Bug ID: 24061 Summary: Print List (opac-shelves.pl) broken in Chrome Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org In Chrome if you try to print a public list from the OPAC the new tab is immediately closed by Chrome. TO TEST: -set up a new public list with a few items -go to the OPAC and view that list. -Click 'Print List' in Chrome. -The tab opens but immediately closes itself. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 18:08:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 17:08:02 +0000 Subject: [Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record In-Reply-To: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23591-70-8PE9uZeKZk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |22784 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 [Bug 22784] Archiving Purchase Suggestions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 18:08:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 17:08:02 +0000 Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions In-Reply-To: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22784-70-bjjdvHpFv3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23591 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591 [Bug 23591] Add a new "Suggestions details" tab on bibliographic record -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 18:08:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 17:08:51 +0000 Subject: [Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record In-Reply-To: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23591-70-QJ3PVcFMwT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 18:08:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 17:08:54 +0000 Subject: [Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record In-Reply-To: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23591-70-BjnDYKrKqf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95518 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95518&action=edit Bug 23591: Add some useful methods to Koha::Suggestions Those are methods initially written for bug 23991. I finally need them before than expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 18:08:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 17:08:58 +0000 Subject: [Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record In-Reply-To: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23591-70-LjxbF1ZSwV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591 --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95519 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95519&action=edit Bug 23591: Display a new "Suggestion detail" tab on the bib detail page This patch adds a new "Suggestion detail" tab on the bibliographic detail page. It will help suggestion management. Test plan: - Create several suggestions for a given biblio - Go to the detail page of the bibliographic record and confirm that there is a new "Suggestion detail" tab with all the suggestions you created. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 18:09:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 17:09:01 +0000 Subject: [Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record In-Reply-To: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23591-70-FyqD4bORW0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591 --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95520 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95520&action=edit Bug 23591: Use same css for suggestion notes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 18:09:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 17:09:06 +0000 Subject: [Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record In-Reply-To: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23591-70-cUwax9SXzJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591 --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95521 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95521&action=edit Bug 23591: [DO NOT PUSH] CSS Changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 18:10:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 17:10:13 +0000 Subject: [Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record In-Reply-To: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23591-70-jgGCwlxzlY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://gitlab.com/joubu/Ko | |ha/commits/bug_23591 --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- What about the archived suggestions? Do we want to display or hide them? Or maybe a show/hide link on top of the table? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 19:30:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 18:30:07 +0000 Subject: [Koha-bugs] [Bug 24059] Remove unused Greybox assets from detail.tt In-Reply-To: <bug-24059-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24059-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24059-70-SZhly33BEB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24059 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 19:30:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 18:30:09 +0000 Subject: [Koha-bugs] [Bug 24059] Remove unused Greybox assets from detail.tt In-Reply-To: <bug-24059-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24059-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24059-70-cSC5O1KphS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24059 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 95522 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95522&action=edit Bug 24059: Remove unused Greybox assets from detail.tt This patch removes reference to the Greybox include file because it is unused. To test, apply the patch and view the bibliographic details page. Test various JavaScript-driven interactions to make sure no functionality has been broken: Menus, tabs, table filters, MARC Preview, etc. Searching for "gb-" or "GB_" should return no results in any files related to the details page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 19:37:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 18:37:28 +0000 Subject: [Koha-bugs] [Bug 23068] Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy In-Reply-To: <bug-23068-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23068-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23068-70-NZ0aAAVBbd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |victor.grousset at biblibre.co | |m --- Comment #32 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- KohaDevBoxes (even new ones) and other development environments based on Debian or Ubuntu need to install the package "libnet-netmask-perl" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 20:02:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 19:02:03 +0000 Subject: [Koha-bugs] [Bug 24058] acquisition table displayed even if no order exist (bib detail) In-Reply-To: <bug-24058-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24058-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24058-70-Ex0s7yHSMx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24058 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 20:02:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 19:02:05 +0000 Subject: [Koha-bugs] [Bug 24058] acquisition table displayed even if no order exist (bib detail) In-Reply-To: <bug-24058-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24058-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24058-70-vx4nPssTku@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24058 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 95523 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95523&action=edit Bug 24058: acquisition table displayed even if no order exist (bib detail) This patch corrects the template check for existence of acquisitions data on the bibliographic detail page. Now it will correctly hide the DataTable when there is no data. To test, apply the patch and enable the AcquisitionDetails system preference. - View the bibliographic detail page for a title which has no associated Acquisitions data. Under the "Acquisitions details" tab you should see only a message, "There is no order for this biblio." - View the detail page for a title which has associated Acquisitions data. The "Acquisitions details" tab should show the correct information. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 20:02:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 19:02:37 +0000 Subject: [Koha-bugs] [Bug 24058] acquisition table displayed even if no order exist (bib detail) In-Reply-To: <bug-24058-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24058-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24058-70-D4xXlK4qd3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24058 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 21:19:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 20:19:42 +0000 Subject: [Koha-bugs] [Bug 24044] Cron keeps sending errors from advance_notices.pl, overdue_notices.pl, process_message_queue.pl In-Reply-To: <bug-24044-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24044-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24044-70-h8892142BX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24044 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |robin at catalyst.net.nz, | |wizzyrea at gmail.com Assignee|wizzyrea at gmail.com |koha-bugs at lists.koha-commun | |ity.org Component|Websites, Mailing Lists, |Command-line Utilities |etc | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 21:45:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 20:45:44 +0000 Subject: [Koha-bugs] [Bug 22828] Elasticsearch - display errors encountered during indexing on the command line In-Reply-To: <bug-22828-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22828-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22828-70-WYfrPsR05F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22828 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 21:51:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 20:51:30 +0000 Subject: [Koha-bugs] [Bug 17131] Zebra index for Title is too broad In-Reply-To: <bug-17131-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17131-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17131-70-P74tMQ7MIc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17131 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- I've had comments from several libraries that Title should not search in 245$c, which I agree with. 245$c is statement of responsibility. For library users, this will never mean title. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 23:26:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 22:26:28 +0000 Subject: [Koha-bugs] [Bug 19364] Title search returns results with author matches In-Reply-To: <bug-19364-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19364-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19364-70-kESG5c19Qj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19364 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Felicia Beaudry from comment #1) > This is still an issue in 19.05. > > If we're going to continue to include Author in a title search, then maybe > the title search needs a different name to reflect that more is included. A > colleague suggested "Title - Statement." I would expect a title search to > be more focused. We're seeing results where the actual title entered is > showing up way down the results list, which is confusing and frustrating for > staff and patrons. If you are using "QueryAutoTruncate" try turning this off to improve the relevancy ranking (there is an existing bug there) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 23:33:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 22:33:54 +0000 Subject: [Koha-bugs] [Bug 19364] Title search returns results with author matches In-Reply-To: <bug-19364-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19364-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19364-70-mUAqN3JV66@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19364 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** This bug has been marked as a duplicate of bug 17131 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 23:33:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 22:33:54 +0000 Subject: [Koha-bugs] [Bug 17131] Zebra index for Title is too broad In-Reply-To: <bug-17131-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17131-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17131-70-lpVj1kh1rJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17131 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nikeshn at gmail.com --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** Bug 19364 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 23:52:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 22:52:22 +0000 Subject: [Koha-bugs] [Bug 23920] Add preference to allow consortia to turn off purchase suggestions for branches that don't use it In-Reply-To: <bug-23920-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23920-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23920-70-5gyHf0Fofd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23920 Lisette Scheer <lisetteslatah at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE --- Comment #1 from Lisette Scheer <lisetteslatah at gmail.com> --- *** This bug has been marked as a duplicate of bug 12219 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 23:52:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 22:52:22 +0000 Subject: [Koha-bugs] [Bug 12219] Purchase Suggestions branch level permissions In-Reply-To: <bug-12219-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12219-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12219-70-VDfWjfQp8q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12219 --- Comment #3 from Lisette Scheer <lisetteslatah at gmail.com> --- *** Bug 23920 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 23:55:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 22:55:31 +0000 Subject: [Koha-bugs] [Bug 23538] Email Library when New Patrons Self Register In-Reply-To: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23538-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23538-70-mSQttMJJrR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23538 Lisette Scheer <lisetteslatah at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 18 23:55:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 22:55:45 +0000 Subject: [Koha-bugs] [Bug 21889] Include Staff Client entered Purchase Suggestions with System Preference maxopensuggestions In-Reply-To: <bug-21889-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21889-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21889-70-cuwShyjkIx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21889 Lisette Scheer <lisetteslatah at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 00:25:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 23:25:51 +0000 Subject: [Koha-bugs] [Bug 24044] Cron keeps sending errors from advance_notices.pl, overdue_notices.pl, process_message_queue.pl In-Reply-To: <bug-24044-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24044-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24044-70-AJxC2PPPxL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24044 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi, this sounds more like a support question than a bug report. You can get help on the mailing list, which is read by many more people than the bug tracker. Please include information on your exact Koha versio, how Koha was installed and how you've set up the cronjobs if you are not using the default settings. If Koha is installed using the packages, these cronjobs should already be active by default and not require any manual changes. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 00:30:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 18 Nov 2019 23:30:39 +0000 Subject: [Koha-bugs] [Bug 24045] Cannot open port for Z39.50 In-Reply-To: <bug-24045-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24045-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24045-70-1Yc0N8BuRE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24045 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi, this sounds more like a support request, than a bug. Please bring this up on the mailing list, where many more people will read your question and be able to offer help. Please make sure to include the exact version of Koha you are using. This might be helpful: https://wiki.koha-community.org/wiki/Troubleshooting_Koha_as_a_Z39.50_server -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 01:17:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 00:17:47 +0000 Subject: [Koha-bugs] [Bug 23213] Add hook to OPAC payments to allow plugins to set minimum payment threshold In-Reply-To: <bug-23213-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23213-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23213-70-vDnhw1QyA9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23213 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Add hook to opac payments |Add hook to OPAC payments |to allow plugins to set |to allow plugins to set |minimum payment threshold |minimum payment threshold Keywords| |Manual --- Comment #12 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Should we add this to https://wiki.koha-community.org/wiki/Koha_Plugin_Hooks? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 02:09:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 01:09:53 +0000 Subject: [Koha-bugs] [Bug 22706] Add plugin hooks to allow custom password strength checking modules In-Reply-To: <bug-22706-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22706-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22706-70-WSmc63Lc3r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22706 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #21 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- We have a documentation page for plugin hooks started on the wiki: https://wiki.koha-community.org/wiki/Koha_Plugin_Hooks Can these be added there please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 08:12:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 07:12:32 +0000 Subject: [Koha-bugs] [Bug 22706] Add plugin hooks to allow custom password strength checking modules In-Reply-To: <bug-22706-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22706-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22706-70-7oNP3tkwaV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22706 --- Comment #22 from Magnus Enger <magnus at libriotech.no> --- (In reply to Katrin Fischer from comment #21) > We have a documentation page for plugin hooks started on the wiki: > https://wiki.koha-community.org/wiki/Koha_Plugin_Hooks > > Can these be added there please? Done. Thanks for the reminder. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 08:51:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 07:51:20 +0000 Subject: [Koha-bugs] [Bug 23068] Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy In-Reply-To: <bug-23068-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23068-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23068-70-I0gbNn9sbf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068 --- Comment #33 from David Cook <dcook at prosentient.com.au> --- (In reply to Victor Grousset/tuxayo from comment #32) > KohaDevBoxes (even new ones) and other development environments based on > Debian or Ubuntu need to install the package "libnet-netmask-perl" I've often wondered when the debian control files get updated with the dependencies... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 09:09:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 08:09:51 +0000 Subject: [Koha-bugs] [Bug 24004] "Help" link at Intranet's mainpage leads to a "Forbidden" page (es-ES) In-Reply-To: <bug-24004-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24004-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24004-70-faWlJoaDaA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24004 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Fixed! https://gitlab.com/koha-community/koha-manual/issues/13 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 09:12:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 08:12:34 +0000 Subject: [Koha-bugs] [Bug 23068] Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy In-Reply-To: <bug-23068-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23068-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23068-70-clVBF5TgwP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068 --- Comment #34 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- (In reply to Victor Grousset/tuxayo from comment #32) > KohaDevBoxes (even new ones) and other development environments based on > Debian or Ubuntu need to install the package "libnet-netmask-perl" Correct, it has been escalated to a 'required' dependancy. This is because for plack we need to load it before we load C4::Context and as such we can't use it optionally as initially thought. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 09:13:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 08:13:56 +0000 Subject: [Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized In-Reply-To: <bug-22381-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22381-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22381-70-qpxqPKUl9Q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I think you need to update the recently added SuspensionsCalendar as well 844 - Calculate suspension expiration based on days overdue 845 - pref: SuspensionsCalendar 846 type: choice 847 choices: 848 ignoreCalendar: directly. 849 noSuspensionsWhenClosed: not including days the library is closed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 09:17:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 08:17:22 +0000 Subject: [Koha-bugs] [Bug 23964] An item level hold when placed is set to Waiting, if ReservesNeedReturn is set to Automatic In-Reply-To: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23964-70-Yg3GrUZxlM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23964 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- 725 my $hold_1 = place_item_hold( $patron, $item, $library, $priority ); 726 $hold = place_item_hold( $patron_2, $item, $library, $priority ); 727 is( $hold->priority, 1, 'If ReservesNeedReturns is 0 but item already on hold priority must be set to 1' ); What about $hold_1->priority? Should not we have $hold_1->priority == 1 instead of $hold->priority == 1? 737 isnt( $hold->priority, 0, 'If ReservesNeedReturns is 0 but item in transit the hold must not be set to waiting' ); Test's description does not match the test. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 09:17:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 08:17:51 +0000 Subject: [Koha-bugs] [Bug 23068] Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy In-Reply-To: <bug-23068-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23068-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23068-70-d1IXoUMUKR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068 --- Comment #35 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- (In reply to David Cook from comment #33) > (In reply to Victor Grousset/tuxayo from comment #32) > > KohaDevBoxes (even new ones) and other development environments based on > > Debian or Ubuntu need to install the package "libnet-netmask-perl" > > I've often wondered when the debian control files get updated with the > dependencies... The control files were updated almost immediately.. The process is to add a dependency to C4/Installer/PerlDependancies.pm and then push that up to master. The evening the nightly build bot will spot the new dependency and add it to the control file and send the patch to bug 17084 which the release manager should be watching. The next day, the release manager will do a quick QA on the resultant file and push the patch as necessary. So, in this case this took a sum total of a day to get the new dependency into the debian control files (there was indeed a day of Jenkins getting upset about the missing dependency too as the packages were failing to build). I can't entirely remember how the biblibre sandboxes work (koha-testing-docker, which koha-sandboxes-docker depends upon for it's base koha image, has already been updated). Do you now re-run apt install koha-perldeps or anything regularly? That should have caught the debian control change.. also, I presume if you are running such a command then you're also tracking the nightly repository to pickup the very latest changes. Hope that helps, Martin -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 09:29:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 08:29:29 +0000 Subject: [Koha-bugs] [Bug 24061] Print List (opac-shelves.pl) broken in Chrome In-Reply-To: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24061-70-dwWjN1NDhO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24061 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Which versions? Looks ok for me on Chrome 60.0.3112.113 and Chromium 73.0.3683.75 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 10:12:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 09:12:29 +0000 Subject: [Koha-bugs] [Bug 24061] Print List (opac-shelves.pl) broken in Chrome In-Reply-To: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24061-70-j2QLymY2Wk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24061 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Could this be related to the behavior fixed by bug 23680? I've tested too, but couldn't reproduce the problem: Google Chrome Version 70.0.3538.77 (Official Build) (64-bit) in Ubuntu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 10:14:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 09:14:30 +0000 Subject: [Koha-bugs] [Bug 22706] Add plugin hooks to allow custom password strength checking modules In-Reply-To: <bug-22706-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22706-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22706-70-hOqrSVH3FH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22706 --- Comment #23 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Magnus Enger from comment #22) > (In reply to Katrin Fischer from comment #21) > > We have a documentation page for plugin hooks started on the wiki: > > https://wiki.koha-community.org/wiki/Koha_Plugin_Hooks > > > > Can these be added there please? > > Done. Thanks for the reminder. Thank you! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 10:16:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 09:16:01 +0000 Subject: [Koha-bugs] [Bug 24061] Print List (opac-shelves.pl) broken in Chrome In-Reply-To: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24061-70-tE6KDQOmRq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24061 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think the print code was changed at some point - which version are you looking at? I tested on master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 10:17:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 09:17:53 +0000 Subject: [Koha-bugs] [Bug 24062] New: Circulation tests fail randomly if patron category type is 'X' Message-ID: <bug-24062-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24062 Bug ID: 24062 Summary: Circulation tests fail randomly if patron category type is 'X' Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Test Suite Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org The items are not issued if the patron category's type is 'X', used for statistics. koha_1 | # Failed test 'ISSUED_TO_ANOTHER question flag should be set if AutoReturnCheckedOutItems is disabled and item is checked out to another' koha_1 | # at t/db_dependent/Circulation.t line 1994. koha_1 | # got: undef koha_1 | # expected: '1' koha_1 | # Looks like you planned 2 tests but ran 1. koha_1 | # Looks like you failed 1 test of 1 run. koha_1 | koha_1 | # Failed test 'CanBookBeIssued + AutoReturnCheckedOutItems' koha_1 | # at t/db_dependent/Circulation.t line 2001. koha_1 | Can't call method "borrowernumber" on an undefined value at t/db_dependent/Circulation.t line 1998. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 10:18:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 09:18:58 +0000 Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions In-Reply-To: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22784-70-r3ljOWI28K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #12 from Séverine Queune <severine.queune at bulac.fr> --- Hi Jonathan, This patch doesn't apply on master : Applying: Bug 22784: DB Changes Using index info to reconstruct a base tree... M Koha/Schema/Result/Suggestion.pm M installer/data/mysql/kohastructure.sql Falling back to patching base and 3-way merge... Auto-merging installer/data/mysql/kohastructure.sql Auto-merging Koha/Schema/Result/Suggestion.pm Applying: Bug 22784: DBIC Changes Using index info to reconstruct a base tree... M Koha/Schema/Result/Suggestion.pm Falling back to patching base and 3-way merge... Auto-merging Koha/Schema/Result/Suggestion.pm CONFLICT (content): Merge conflict in Koha/Schema/Result/Suggestion.pm Failed to merge in the changes. Patch failed at 0001 Bug 22784: DBIC Changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 10:22:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 09:22:02 +0000 Subject: [Koha-bugs] [Bug 24062] Circulation tests fail randomly if patron category type is 'X' In-Reply-To: <bug-24062-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24062-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24062-70-PCzg7pbnXL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24062 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 10:22:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 09:22:06 +0000 Subject: [Koha-bugs] [Bug 24062] Circulation tests fail randomly if patron category type is 'X' In-Reply-To: <bug-24062-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24062-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24062-70-TllS3Xknca@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24062 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95524 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95524&action=edit Bug 24062: [DO NOT PUSH] Proof Only apply this patch and confirm the assumption is correct (test was failing because X was generated for the patron category's type) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 10:22:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 09:22:09 +0000 Subject: [Koha-bugs] [Bug 24062] Circulation tests fail randomly if patron category type is 'X' In-Reply-To: <bug-24062-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24062-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24062-70-PPhyTvuGkW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24062 --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95525 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95525&action=edit Bug 24062: Fix the failing test -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 10:22:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 09:22:13 +0000 Subject: [Koha-bugs] [Bug 24062] Circulation tests fail randomly if patron category type is 'X' In-Reply-To: <bug-24062-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24062-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24062-70-zCk8pQCScW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24062 --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95526 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95526&action=edit Bug 24062: Make sure TestBuilder will stop generate X or other invalid category's types To make sure this kind of random failures will not appear in a future we are going to fix it at TestBuilder level. Test plan: prove t/db_dependent/TestBuilder.t and confirm it returns green You could also only apply the tests against master, run them several times and confirm that they fail most of the time. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 10:22:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 09:22:50 +0000 Subject: [Koha-bugs] [Bug 24062] Circulation tests fail randomly if patron category type is 'X' In-Reply-To: <bug-24062-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24062-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24062-70-eVHxHnaTwM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24062 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl, | |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 10:24:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 09:24:59 +0000 Subject: [Koha-bugs] [Bug 24063] New: Add Sami language characters to Zebra Message-ID: <bug-24063-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24063 Bug ID: 24063 Summary: Add Sami language characters to Zebra Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: pasi.kallinen at koha-suomi.fi QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr To allow searching for eg. Skolt Sami texts, some additional characters should be mapped in Zebra: Ǩ, ǯ, and ŋ. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 10:26:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 09:26:22 +0000 Subject: [Koha-bugs] [Bug 24063] Add Sami language characters to Zebra In-Reply-To: <bug-24063-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24063-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24063-70-WE2JkAHYGt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24063 paxed <pasi.kallinen at koha-suomi.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |pasi.kallinen at koha-suomi.fi |ity.org | --- Comment #1 from paxed <pasi.kallinen at koha-suomi.fi> --- Created attachment 95527 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95527&action=edit Bug 24063: Add Sami language characters to Zebra Some Sami languages need few more characters to be mapped, or are otherwise very hard to search for. Test plan: 1) Catalogue a new record with title "Ǩoǯeŋa" 2) Make sure zebra indexed that record, then try to search for it with the text "kozena" 3) Apply patch 4) Redo 2, now the record should be found. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 10:29:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 09:29:55 +0000 Subject: [Koha-bugs] [Bug 24058] acquisition table displayed even if no order exist (bib detail) In-Reply-To: <bug-24058-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24058-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24058-70-lu5FtZ8ga5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24058 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 10:29:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 09:29:58 +0000 Subject: [Koha-bugs] [Bug 24058] acquisition table displayed even if no order exist (bib detail) In-Reply-To: <bug-24058-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24058-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24058-70-3XQ6tJZI6N@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24058 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95523|0 |1 is obsolete| | --- Comment #2 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 95528 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95528&action=edit Bug 24058: acquisition table displayed even if no order exist (bib detail) This patch corrects the template check for existence of acquisitions data on the bibliographic detail page. Now it will correctly hide the DataTable when there is no data. To test, apply the patch and enable the AcquisitionDetails system preference. - View the bibliographic detail page for a title which has no associated Acquisitions data. Under the "Acquisitions details" tab you should see only a message, "There is no order for this biblio." - View the detail page for a title which has associated Acquisitions data. The "Acquisitions details" tab should show the correct information. Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 10:34:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 09:34:29 +0000 Subject: [Koha-bugs] [Bug 24057] Hea is not an acronym In-Reply-To: <bug-24057-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24057-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24057-70-v0QwjfIZZ2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24057 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 10:34:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 09:34:32 +0000 Subject: [Koha-bugs] [Bug 24057] Hea is not an acronym In-Reply-To: <bug-24057-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24057-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24057-70-gLnxhm0Ok7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24057 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95515|0 |1 is obsolete| | --- Comment #2 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 95529 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95529&action=edit Bug 24057: Hea is not an acronym This patch changes "HEA" (incorrectly capitalized) to "Hea" on the staff client administration home page. To test, apply the patch and set the "UsageStats" system preference to "No, let me think about it." - Go to Administration in the staff client. - There should be a message at the top asking if you want to share anonymous usage statisitcs with the community. The word "Hea" in this message should be capitalized correctly. Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 10:49:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 09:49:11 +0000 Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests In-Reply-To: <bug-23974-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23974-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23974-70-W336mcqVv2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_19_11_candidate |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 10:49:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 09:49:17 +0000 Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions In-Reply-To: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22784-70-FBodTb77bi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|22590 |23590 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22590 [Bug 22590] Allow batch printing of routing lists https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 [Bug 23590] Allow to modify the manager of a suggestion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 10:49:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 09:49:17 +0000 Subject: [Koha-bugs] [Bug 22590] Allow batch printing of routing lists In-Reply-To: <bug-22590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22590-70-rCiN9ITgyX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22590 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|22784 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 [Bug 22784] Archiving Purchase Suggestions -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 10:49:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 09:49:17 +0000 Subject: [Koha-bugs] [Bug 23590] Allow to modify the manager of a suggestion In-Reply-To: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23590-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23590-70-ni1YFFhhsM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23590 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22784 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 [Bug 22784] Archiving Purchase Suggestions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 10:50:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 09:50:03 +0000 Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions In-Reply-To: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22784-70-SzxxnS13Xm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Sorry, wrong bug number in the dep list. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 10:57:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 09:57:27 +0000 Subject: [Koha-bugs] [Bug 22828] Elasticsearch - display errors encountered during indexing on the command line In-Reply-To: <bug-22828-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22828-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22828-70-eGXTEVWXLd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22828 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 10:57:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 09:57:30 +0000 Subject: [Koha-bugs] [Bug 22828] Elasticsearch - display errors encountered during indexing on the command line In-Reply-To: <bug-22828-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22828-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22828-70-chkDMFrPry@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22828 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95098|0 |1 is obsolete| | --- Comment #8 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 95530 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95530&action=edit Bug 22828: Elasticsearch - display errors encountered during indexing on the command line To test: 1 - Use the Koha sample data, or insert a blank 245$b into a record (easiest way is using advanced cataloging editor 2 - Reindex elasticsearch 3 - Check the ES count on the about page 4 - Check the count in the DB (SELECT count(*) FROM biblio) 5 - They don't match! 6 - perl misc/search_tools/rebuild_elastic_search.pl -v -v 7 - No errors indicated 8 - Apply patch 9 - perl misc/search_tools/rebuild_elastic_search.pl -v 10 - You should be notified of an error 11 - perl misc/search_tools/rebuild_elastic_search.pl -v -v 12 - You should be notified of the specific biblio with an error and a (somewhat) readable reason 13 - perl misc/search_tools/rebuild_elastic_search.pl 14 - No output Signed-off-by: Ere Maijala <ere.maijala at helsinki.fi> Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 10:58:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 09:58:32 +0000 Subject: [Koha-bugs] [Bug 14837] Allow to send separate DUEDGST und PREDUEDGST for item's homebranches In-Reply-To: <bug-14837-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14837-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14837-70-RcTis6LKVQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14837 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20478 --- Comment #1 from Magnus Enger <magnus at libriotech.no> --- Is this related to bug 20478? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 10:58:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 09:58:32 +0000 Subject: [Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch In-Reply-To: <bug-20478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20478-70-u6uGXtAVkZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14837 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 10:59:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 09:59:05 +0000 Subject: [Koha-bugs] [Bug 24001] Cannot edit card template In-Reply-To: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24001-70-LpAFnl6HKM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- This is even worst with strict_sql_modes turned on, the creation of a new template is impossible: DBD::mysql::st execute failed: Incorrect integer value: '' for column 'profile_id' at row 1 [for Statement "INSERT INTO creator_templates (`creator`, `label_height`, `top_margin`, `units`, `col_gap`, `row_gap`, `left_text_margin`, `rows`, `page_height`, `template_code`, `top_text_margin`, `label_width`, `left_margin`, `cols`, `profile_id`, `page_width`, `template_desc`) VALUES (?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?,?);" with ParamValues: 0='Patroncards', 1="0", 2="0", 3="POINT", 4="0", 5="0", 6=0, 7="0", 8="0", 9="DEFAULT TEMPLATE", 10=0, 11="0", 12="0", 13="0", 14='', 15="0", 16="Default description"] at /kohadevbox/koha/C4/Creators/Template.pm line 199. Database returned the following error: Incorrect integer value: '' for column 'profile_id' at row 1 at /kohadevbox/koha/C4/Creators/Template.pm line 201. There is a logic issue in the controller, the printer profile list is not passed to the template (only passed when editing). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 10:59:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 09:59:48 +0000 Subject: [Koha-bugs] [Bug 24005] Software error: at login In-Reply-To: <bug-24005-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24005-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24005-70-gvNoFUWjrX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24005 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- *** This bug has been marked as a duplicate of bug 23579 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 10:59:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 09:59:48 +0000 Subject: [Koha-bugs] [Bug 23579] error during web install: 'changed_fields' can't have a default value In-Reply-To: <bug-23579-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23579-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23579-70-U37B2bU5YY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23579 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |andrewanandal at gmail.com --- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- *** Bug 24005 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 11:00:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 10:00:35 +0000 Subject: [Koha-bugs] [Bug 24001] Cannot edit card template In-Reply-To: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24001-70-IZV0mSWF8r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17258 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 [Bug 17258] [OMNIBUS] MySQL 5.7 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 11:00:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 10:00:35 +0000 Subject: [Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7 In-Reply-To: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17258-70-7AgV6qZvrI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24001 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 [Bug 24001] Cannot edit card template -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 11:04:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 10:04:53 +0000 Subject: [Koha-bugs] [Bug 21466] Data inconsistencies - koha fields linked to AV cat values must have a corresponding authorised value In-Reply-To: <bug-21466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21466-70-g8m7hDSRVs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21466 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Keywords| |rel_19_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 11:05:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 10:05:09 +0000 Subject: [Koha-bugs] [Bug 23942] After upgrading koha from version 16.5 to 18.11 itemtype, itype and other list boxes corresponding to authorised values attached to frameworks fail to show the selected values upon editing the bib and item records In-Reply-To: <bug-23942-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23942-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23942-70-GqwXrkBt4Q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23942 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21466 --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- The script on bug 21466 can help you to search for such inconsistencies. It's not pushed yet however. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 11:05:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 10:05:09 +0000 Subject: [Koha-bugs] [Bug 21466] Data inconsistencies - koha fields linked to AV cat values must have a corresponding authorised value In-Reply-To: <bug-21466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21466-70-L5wJBBopgJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21466 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23942 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 11:12:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 10:12:49 +0000 Subject: [Koha-bugs] [Bug 24064] New: DUEDGST typoed as DUEGST Message-ID: <bug-24064-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24064 Bug ID: 24064 Summary: DUEDGST typoed as DUEGST Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Notices Assignee: magnus at libriotech.no Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org Attachment 86382 of bug introduces a typo in the letter code DUEDGST: - my $letter_type = 'DUEDGST'; + letter_code => 'DUEGST', This causes "Item Due Reminder (Digest)" messages not to be sent. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 11:13:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 10:13:37 +0000 Subject: [Koha-bugs] [Bug 24064] DUEDGST typoed as DUEGST In-Reply-To: <bug-24064-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24064-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24064-70-71wjI4fIo7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24064 --- Comment #1 from Magnus Enger <magnus at libriotech.no> --- Hm, that should be bug 20478. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 11:15:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 10:15:25 +0000 Subject: [Koha-bugs] [Bug 23721] Names of exported basketgroup files should be uniformised In-Reply-To: <bug-23721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23721-70-EE1dSi8FLE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23721 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 11:15:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 10:15:29 +0000 Subject: [Koha-bugs] [Bug 23721] Names of exported basketgroup files should be uniformised In-Reply-To: <bug-23721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23721-70-ooqMnrSaIa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23721 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95531 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95531&action=edit Bug 23721: Use basketgroup's name to name the CSV export file When exporting a basket group, the names of the files are different: * pdf => aqbasketgroup.name(.pdf) * csv => aqbasketgroup.id(.csv) Better to use basketgroup's name for consistency and readability Test plan: Create a basketgroup and export it in pdf and CSV. The name of the generated file must be the basketgroup's name suffixed by the extension. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 11:15:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 10:15:36 +0000 Subject: [Koha-bugs] [Bug 23721] Names of exported basketgroup files should be uniformised In-Reply-To: <bug-23721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23721-70-JkD1btOX5R@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23721 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 11:16:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 10:16:48 +0000 Subject: [Koha-bugs] [Bug 24064] DUEDGST typoed as DUEGST In-Reply-To: <bug-24064-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24064-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24064-70-xMQt2AB0Z1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24064 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- But 20478 is not in 18.11? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 11:22:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 10:22:04 +0000 Subject: [Koha-bugs] [Bug 24064] DUEDGST typoed as DUEGST In-Reply-To: <bug-24064-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24064-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24064-70-mLtflx1Ls1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24064 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 11:22:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 10:22:08 +0000 Subject: [Koha-bugs] [Bug 24064] DUEDGST typoed as DUEGST In-Reply-To: <bug-24064-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24064-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24064-70-1RjMOvDDZ2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24064 --- Comment #3 from Magnus Enger <magnus at libriotech.no> --- Created attachment 95532 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95532&action=edit Bug 24064 - DUEDGST typoed as DUEGST Bug 20478 introduced a typo where the letter code DUEDGST was changed to DUEGST. This patch fixes it. To test: - Run "grep -r DUEDGST *" on the Koha git repo. Notice that this letter code is used in e.g. sample notices. - Run "grep -r DUEGST *" and notice that this code only occurs twice, in misc/cronjobs/advance_notices.pl. - Aply this patch. - Run "grep -r DUEGST *" again, and notice there are no more occurences of this typo. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 11:32:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 10:32:08 +0000 Subject: [Koha-bugs] [Bug 24064] DUEDGST typoed as DUEGST In-Reply-To: <bug-24064-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24064-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24064-70-WCJzbXfvTp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24064 --- Comment #4 from Magnus Enger <magnus at libriotech.no> --- (In reply to Katrin Fischer from comment #2) > But 20478 is not in 18.11? No, Martin wrote: "Enhancement will not be backported to 18.11.x series." How so? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 11:32:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 10:32:45 +0000 Subject: [Koha-bugs] [Bug 24064] DUEDGST typoed as DUEGST In-Reply-To: <bug-24064-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24064-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24064-70-5QoBSxiWcw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24064 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.11 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 11:33:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 10:33:15 +0000 Subject: [Koha-bugs] [Bug 24064] DUEDGST typoed as DUEGST In-Reply-To: <bug-24064-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24064-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24064-70-bIGrTJDXjd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24064 --- Comment #5 from Magnus Enger <magnus at libriotech.no> --- Ah, the version was set to 18.11? Dunno how that happened... Set it to master now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 11:36:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 10:36:01 +0000 Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions In-Reply-To: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22784-70-C67GduZQyn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 11:36:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 10:36:04 +0000 Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions In-Reply-To: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22784-70-m2htNwgHsf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95499|0 |1 is obsolete| | --- Comment #14 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 95533 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95533&action=edit Bug 22784: DB Changes Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 11:36:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 10:36:08 +0000 Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions In-Reply-To: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22784-70-xQLGWQ6ctY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95500|0 |1 is obsolete| | --- Comment #15 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 95534 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95534&action=edit Bug 22784: DBIC Changes Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 11:36:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 10:36:11 +0000 Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions In-Reply-To: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22784-70-33Ad6hAYCJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95510|0 |1 is obsolete| | --- Comment #16 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 95535 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95535&action=edit Bug 22784: Add the ability to archive/unarchive a purchase suggestions There are performance issues when searching suggestions if there are thousands of suggestions. To prevent that we are going to add the ability to archive purchase suggestions, in order to remove them from the search list (by default). Test plan: 0. Apply all the patches, execute the updatedatabase.pl script, restart all 1. Create some suggestions 2. Search for them 3. Use the "Archive" action button for one of them 4. Restart the search => The archived suggestion does no longer appear in the list 5. Use the filter "Included archived" in the "Suggestion information" filter box => The archived suggestion is now displayed 6. Use other filters => The "archived" filter is kept from one search to another 7. Use one of the action at the bottom of the suggestion list (change the status for instance) => The "archived" filter is still kept Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 11:36:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 10:36:15 +0000 Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions In-Reply-To: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22784-70-dXJsbj5PFM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95511|0 |1 is obsolete| | --- Comment #17 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 95536 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95536&action=edit Bug 22784: Bugfix - do not modify #description build Debian packages from a git repository Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 11:36:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 10:36:19 +0000 Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions In-Reply-To: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22784-70-0AvT5oQXta@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95512|0 |1 is obsolete| | --- Comment #18 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 95537 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95537&action=edit Bug 22784: Do not display an empty table This is terrible and highlight that the whole script must be rewrite. GetDistinctValues does not handle the "archived" flag (and we do not want to put our hands there), so let's hack that and plan to rewrite the whole script. Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 11:36:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 10:36:23 +0000 Subject: [Koha-bugs] [Bug 22784] Archiving Purchase Suggestions In-Reply-To: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22784-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22784-70-RxYA0hRNH3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22784 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95513|0 |1 is obsolete| | --- Comment #19 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 95538 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95538&action=edit Bug 22784: Add a cronjob to archive suggestions given age or status criteria In order to deal automatically with suggestions that need to be archived, this cronjob will help to add the "archived" flag following their age or status. Test plan: - Execute the script with the --help parameter and read the documentation. - Does it make sense? - Use it without the --confirm flag and try several combination For instance you will want to archive suggestions that have been rejected for more than a week: perl misc/cronjobs/archive_purchase_suggestions.pl --age-date-field=rejecteddate --age=weeks:1 or even suggestion that have been suggested for more than a year and have a ORDERED status: perl misc/cronjobs/archive_purchase_suggestions.pl --age-date-field=suggesteddate --age=years:1 --status=ORDERED - Use it with the --confirm flag and make sure the suggestions have been archived. Sponsored-by: BULAC - http://www.bulac.fr/ Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 11:51:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 10:51:49 +0000 Subject: [Koha-bugs] [Bug 24064] DUEDGST typoed as DUEGST In-Reply-To: <bug-24064-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24064-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24064-70-OlUWes6WBz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24064 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 11:51:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 10:51:52 +0000 Subject: [Koha-bugs] [Bug 24064] DUEDGST typoed as DUEGST In-Reply-To: <bug-24064-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24064-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24064-70-58IcNUkaeh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24064 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95532|0 |1 is obsolete| | --- Comment #6 from David Nind <david at davidnind.com> --- Created attachment 95539 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95539&action=edit Bug 24064 - DUEDGST typoed as DUEGST Bug 20478 introduced a typo where the letter code DUEDGST was changed to DUEGST. This patch fixes it. To test: - Run "grep -r DUEDGST *" on the Koha git repo. Notice that this letter code is used in e.g. sample notices. - Run "grep -r DUEGST *" and notice that this code only occurs twice, in misc/cronjobs/advance_notices.pl. - Aply this patch. - Run "grep -r DUEGST *" again, and notice there are no more occurences of this typo. Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 11:54:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 10:54:47 +0000 Subject: [Koha-bugs] [Bug 21465] Cannot overlay patrons when matching by cardnumber if userid exists in file and in Koha In-Reply-To: <bug-21465-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21465-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21465-70-8IkGsdfbxb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21465 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23734 --- Comment #19 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #9) > Nick, did you investigate the new warnings your tests add? > > Argument "" isn't numeric in numeric eq (==) at > /usr/share/perl5/DBIx/Class/Row.pm line 1018, <$handle_3a> line 2. (In reply to Jonathan Druart from comment #10) > Comes from eval { $patron->set(\%borrower)->store }; in import_patrons, it > complains on invalid patron attribute's values (login_attempts, lost, etc.) > > Related to bug 21761. See bug 23734 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23734 [Bug 23734] Defaults set during patron imports throws warnings -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 11:54:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 10:54:47 +0000 Subject: [Koha-bugs] [Bug 23734] Defaults set during patron imports throws warnings In-Reply-To: <bug-23734-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23734-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23734-70-irD4RnDVIC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23734 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21465 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21465 [Bug 21465] Cannot overlay patrons when matching by cardnumber if userid exists in file and in Koha -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 11:56:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 10:56:52 +0000 Subject: [Koha-bugs] [Bug 24064] DUEDGST typoed as DUEGST In-Reply-To: <bug-24064-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24064-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24064-70-dk2iNPttTa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24064 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Depends on| |20478 --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Caused by commit e18626b6f142128064317e95ef4a7fb089f4f48d Bug 20478: Refactor to remove code duplication. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 [Bug 20478] Advance notices: send separate digest messages per branch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 11:56:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 10:56:52 +0000 Subject: [Koha-bugs] [Bug 20478] Advance notices: send separate digest messages per branch In-Reply-To: <bug-20478-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20478-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20478-70-yxgEixAZLJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20478 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24064 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24064 [Bug 24064] DUEDGST typoed as DUEGST -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 12:04:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 11:04:50 +0000 Subject: [Koha-bugs] [Bug 23721] Names of exported basketgroup files should be uniformised In-Reply-To: <bug-23721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23721-70-hnWRtqHWkc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23721 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 12:04:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 11:04:53 +0000 Subject: [Koha-bugs] [Bug 23721] Names of exported basketgroup files should be uniformised In-Reply-To: <bug-23721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23721-70-MwyWlqg8zN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23721 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95531|0 |1 is obsolete| | --- Comment #2 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 95540 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95540&action=edit Bug 23721: Use basketgroup's name to name the CSV export file When exporting a basket group, the names of the files are different: * pdf => aqbasketgroup.name(.pdf) * csv => aqbasketgroup.id(.csv) Better to use basketgroup's name for consistency and readability Test plan: Create a basketgroup and export it in pdf and CSV. The name of the generated file must be the basketgroup's name suffixed by the extension. Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 12:09:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 11:09:55 +0000 Subject: [Koha-bugs] [Bug 24064] DUEDGST typoed as DUEGST In-Reply-To: <bug-24064-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24064-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24064-70-AtIyZhKdyp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24064 --- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- That sucks! What about the notices in the DB? :-/ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 12:17:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 11:17:46 +0000 Subject: [Koha-bugs] [Bug 24062] Circulation tests fail randomly if patron category type is 'X' In-Reply-To: <bug-24062-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24062-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24062-70-tkJ1BcJgnX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24062 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95524|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95541 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95541&action=edit Bug 24062: [DO NOT PUSH] Proof Only apply this patch and confirm the assumption is correct (test was failing because X was generated for the patron category's type) Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 12:17:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 11:17:49 +0000 Subject: [Koha-bugs] [Bug 24062] Circulation tests fail randomly if patron category type is 'X' In-Reply-To: <bug-24062-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24062-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24062-70-47p4TuOMtg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24062 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95525|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95542 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95542&action=edit Bug 24062: Fix the failing test Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 12:17:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 11:17:52 +0000 Subject: [Koha-bugs] [Bug 24062] Circulation tests fail randomly if patron category type is 'X' In-Reply-To: <bug-24062-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24062-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24062-70-8gG3hXMkhh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24062 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95526|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95543 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95543&action=edit Bug 24062: Make sure TestBuilder will stop generate X or other invalid category's types To make sure this kind of random failures will not appear in a future we are going to fix it at TestBuilder level. Test plan: prove t/db_dependent/TestBuilder.t and confirm it returns green You could also only apply the tests against master, run them several times and confirm that they fail most of the time. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 12:18:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 11:18:21 +0000 Subject: [Koha-bugs] [Bug 24062] Circulation tests fail randomly if patron category type is 'X' In-Reply-To: <bug-24062-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24062-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24062-70-3torD8rOAb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24062 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice fix, works as expected.. thanks Jonathan. Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 12:18:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 11:18:38 +0000 Subject: [Koha-bugs] [Bug 24062] Circulation tests fail randomly if patron category type is 'X' In-Reply-To: <bug-24062-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24062-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24062-70-AVUBrXGHPY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24062 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_19_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 12:40:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 11:40:27 +0000 Subject: [Koha-bugs] [Bug 23734] Defaults set during patron imports throws warnings In-Reply-To: <bug-23734-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23734-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23734-70-lmnwki1ywm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23734 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- What you suggest do not remove the warning. I linked this bug report with bug 21761 as we saw that already in another (but similar) context. I tried: modified: Koha/Object.pm ─────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────────── @ Object.pm:139 @ sub store { } else { # If cannot be null, get the default value # What if cannot be null and does not have a default value? Possible? + undef $self->{$col}; $self->$col($columns_info->{$col}->{default_value}); } } And get rid of of one of the 2 warnings. There is 2 warnings per attributes: on ->set_column (called from ->store, see previous diff), and a bit later, I guess in update_or_insert The attributes are the tinyint and not null: privacy_guarantor_fines, privacy_guarantor_checkouts and anonymized. We could fix that at controller level but I feel like it must be fixed at Koha::Object level. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 12:58:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 11:58:14 +0000 Subject: [Koha-bugs] [Bug 23964] An item level hold when placed is set to Waiting, if ReservesNeedReturn is set to Automatic In-Reply-To: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23964-70-H3KiRbnBmU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23964 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 12:58:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 11:58:17 +0000 Subject: [Koha-bugs] [Bug 23964] An item level hold when placed is set to Waiting, if ReservesNeedReturn is set to Automatic In-Reply-To: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23964-70-Rz8qpxkOYF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23964 --- Comment #12 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95544&action=edit Bug 23964: (follow-up) more test clarification -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 13:00:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 12:00:09 +0000 Subject: [Koha-bugs] [Bug 23964] An item level hold when placed is set to Waiting, if ReservesNeedReturn is set to Automatic In-Reply-To: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23964-70-U9em7Usfzn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23964 --- Comment #13 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Jonathan Druart from comment #11) > 725 my $hold_1 = place_item_hold( $patron, $item, $library, $priority ); > 726 $hold = place_item_hold( $patron_2, $item, $library, $priority ); > 727 is( $hold->priority, 1, 'If ReservesNeedReturns is 0 but item > already on hold priority must be set to 1' ); > > What about $hold_1->priority? Should not we have $hold_1->priority == 1 > instead of $hold->priority == 1? The first hold should get set to waiting, the next hold on the item doesn't because there is a hold already on the item > 737 isnt( $hold->priority, 0, 'If ReservesNeedReturns is 0 but item in > transit the hold must not be set to waiting' ); > > Test's description does not match the test. I do not understand, I place a transfer before this test, the transfer means the hold is not waiting. Changed to 'is' '1' in any case -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 13:19:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 12:19:30 +0000 Subject: [Koha-bugs] [Bug 24065] New: Shibboleth should fail the login if matchpoint is not unique Message-ID: <bug-24065-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24065 Bug ID: 24065 Summary: Shibboleth should fail the login if matchpoint is not unique Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Authentication Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: dpavlin at rot13.org The shib config allows you to use any patron field for matching. Email is sometimes used, but Koha does not enforce uniqueness here. We call 'find' to get the patron, this will throw an error, but not fail We should 'search' instead and fail explicitly if there is more than one patron -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 13:46:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 12:46:23 +0000 Subject: [Koha-bugs] [Bug 24064] DUEDGST typoed as DUEGST In-Reply-To: <bug-24064-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24064-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24064-70-Nneynpakmo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24064 --- Comment #9 from Magnus Enger <magnus at libriotech.no> --- (In reply to Jonathan Druart from comment #8) > What about the notices in the DB? :-/ letters or message_queue? None of them should be affected, except that since DUEGST is not found in letters, no DUE(D)GST messages will end up in message_queue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 13:47:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 12:47:41 +0000 Subject: [Koha-bugs] [Bug 23982] Count/pagination broken for reports with duplicated column names In-Reply-To: <bug-23982-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23982-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23982-70-tFGQR32zlM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23982 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95479|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95545 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95545&action=edit Bug 23982: (bug 23624 follow-up) Handle SQL error caused by derived table Caused by commit bca4453c50d8b5b1d3c7029ded2b522a9a2bf868 Bug 23624: (QA follow-up) Optimize even more A report like: SELECT * FROM issues JOIN borrowers USING (borrowernumber) will have two borrowernumber columns - SQL will give us there rsults, but if we try to wrap them in a SELECT COUNT(*) FROM (report) it throws a duplicated column error. This patch suggests to execute the query the old way if the derived table optimization failed. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 13:48:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 12:48:11 +0000 Subject: [Koha-bugs] [Bug 23982] Count/pagination broken for reports with duplicated column names In-Reply-To: <bug-23982-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23982-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23982-70-IiVJAwkkXq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23982 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Thanks for jumping on this one Jonathan, looks reasonable and in a quick test it works for me.. Signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 13:52:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 12:52:39 +0000 Subject: [Koha-bugs] [Bug 24001] Cannot edit card template In-Reply-To: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24001-70-IstIQb1BU4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #2 from Chris Nighswonger <cnighswonger at foundations.edu> --- (In reply to Jonathan Druart from comment #1) > This is even worst with strict_sql_modes turned on, the creation of a new > template is impossible: > > DBD::mysql::st execute failed: Incorrect integer value: '' for column > 'profile_id' ... at > /kohadevbox/koha/C4/Creators/Template.pm line 199. > Database returned the following error: Incorrect integer value: '' for > column 'profile_id' at row 1 at /kohadevbox/koha/C4/Creators/Template.pm > line 201. > > There is a logic issue in the controller, the printer profile list is not > passed to the template (only passed when editing). The default profile_id should be 0: http://tinyurl.com/smoh5g6 Which is overwritten here: http://tinyurl.com/s2pj4cs Probably changing profile_id => scalar $cgi->param('profile_id'), to profile_id => scalar $cgi->param('profile_id') || 0, would fix the acute pain. I suspect that there are many such issues lurking in the label/patroncard code unfortunately. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 13:55:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 12:55:56 +0000 Subject: [Koha-bugs] [Bug 19721] Tabulation in the description of a patron category breaks the patron search. Cause: tabs must be escaped in JSON In-Reply-To: <bug-19721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19721-70-nOP7wsNIpf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19721 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- This appears to have been fixed. I can't reproduce the problem. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 14:00:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 13:00:31 +0000 Subject: [Koha-bugs] [Bug 3317] Author displays inconsistently ( and incorrectly ) in opac-basket.pl (and when emailing cart ) In-Reply-To: <bug-3317-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-3317-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3317-70-q169pQ5xB1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3317 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED --- Comment #4 from Owen Leonard <oleonard at myacpl.org> --- I believe this issue has been fixed. If someone finds otherwise please re-open with additional details. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 14:02:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 13:02:57 +0000 Subject: [Koha-bugs] [Bug 24065] Shibboleth should fail the login if matchpoint is not unique In-Reply-To: <bug-24065-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24065-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24065-70-gDiF6j0K54@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24065 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 14:03:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 13:03:00 +0000 Subject: [Koha-bugs] [Bug 24065] Shibboleth should fail the login if matchpoint is not unique In-Reply-To: <bug-24065-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24065-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24065-70-ZzF4HGVbH7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24065 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95546 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95546&action=edit Bug 24065: Fail shib login if multiple users matched Ideally you could test against active shib, but is a small code change and covered by tests and should be readable To test: prove -v t/Auth_with_shibboleth.t -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 14:03:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 13:03:40 +0000 Subject: [Koha-bugs] [Bug 24065] Shibboleth should fail the login if matchpoint is not unique In-Reply-To: <bug-24065-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24065-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24065-70-4f9gNtxkUx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24065 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.05 |master Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | CC| |liz at bywatersolutions.com, | |matthias.meusburger at biblibr | |e.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 14:13:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 13:13:11 +0000 Subject: [Koha-bugs] [Bug 4958] XSLT views in staff client and OPAC don't show multiple URL subfields In-Reply-To: <bug-4958-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-4958-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4958-70-OlMTXVEBvM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4958 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- This appears to be fixed. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 14:13:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 13:13:55 +0000 Subject: [Koha-bugs] [Bug 24064] DUEDGST typoed as DUEGST In-Reply-To: <bug-24064-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24064-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24064-70-Uxr7pqjoWH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24064 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 14:13:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 13:13:58 +0000 Subject: [Koha-bugs] [Bug 24064] DUEDGST typoed as DUEGST In-Reply-To: <bug-24064-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24064-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24064-70-DNSIjWNGn4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24064 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95539|0 |1 is obsolete| | --- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95547 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95547&action=edit Bug 24064 - DUEDGST typoed as DUEGST Bug 20478 introduced a typo where the letter code DUEDGST was changed to DUEGST. This patch fixes it. To test: - Run "grep -r DUEDGST *" on the Koha git repo. Notice that this letter code is used in e.g. sample notices. - Run "grep -r DUEGST *" and notice that this code only occurs twice, in misc/cronjobs/advance_notices.pl. - Aply this patch. - Run "grep -r DUEGST *" again, and notice there are no more occurences of this typo. Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 14:18:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 13:18:20 +0000 Subject: [Koha-bugs] [Bug 23982] Count/pagination broken for reports with duplicated column names In-Reply-To: <bug-23982-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23982-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23982-70-G1R5ULvyCl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23982 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 14:18:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 13:18:23 +0000 Subject: [Koha-bugs] [Bug 23982] Count/pagination broken for reports with duplicated column names In-Reply-To: <bug-23982-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23982-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23982-70-Qv38UOFseF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23982 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95545|0 |1 is obsolete| | --- Comment #8 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95548 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95548&action=edit Bug 23982: (bug 23624 follow-up) Handle SQL error caused by derived table Caused by commit bca4453c50d8b5b1d3c7029ded2b522a9a2bf868 Bug 23624: (QA follow-up) Optimize even more A report like: SELECT * FROM issues JOIN borrowers USING (borrowernumber) will have two borrowernumber columns - SQL will give us there rsults, but if we try to wrap them in a SELECT COUNT(*) FROM (report) it throws a duplicated column error. This patch suggests to execute the query the old way if the derived table optimization failed. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 14:19:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 13:19:40 +0000 Subject: [Koha-bugs] [Bug 24001] Cannot edit card template In-Reply-To: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24001-70-bYRJVN5Bqw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- There is not printers_profile.profile_id in DB, so I am expecting an error as well. Is there a good reason to not display the list of available profiles on adding? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 14:20:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 13:20:12 +0000 Subject: [Koha-bugs] [Bug 24001] Cannot edit card template In-Reply-To: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24001-70-iytepBPc7r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- There is no printers_profile.profile_id == 0 in DB, so I am expecting an error as well. Is there a good reason to not display the list of available profiles on adding? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 14:21:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 13:21:40 +0000 Subject: [Koha-bugs] [Bug 24064] DUEDGST typoed as DUEGST In-Reply-To: <bug-24064-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24064-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24064-70-Cz3BdN4fNe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24064 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Keywords| |rel_19_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 14:27:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 13:27:32 +0000 Subject: [Koha-bugs] [Bug 24001] Cannot edit card template In-Reply-To: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24001-70-ILA5ymVTrT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #5 from Chris Nighswonger <cnighswonger at foundations.edu> --- (In reply to Jonathan Druart from comment #4) > There is no printers_profile.profile_id == 0 in DB, so I am expecting an > error as well. > > Is there a good reason to not display the list of available profiles on > adding? It should: http://tinyurl.com/rkfw9fx And on further review of that code block, the profile_id should be set to 0 there. Something else must be failing along the way. Maybe in your instance its never dropping into that else block? If that's the case, I wonder where it goes? What is $op in your instance? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 14:28:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 13:28:52 +0000 Subject: [Koha-bugs] [Bug 24001] Cannot edit card template In-Reply-To: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24001-70-20R79zxKE1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #6 from Chris Nighswonger <cnighswonger at foundations.edu> --- (In reply to Chris Nighswonger from comment #5) > (In reply to Jonathan Druart from comment #4) > > There is no printers_profile.profile_id == 0 in DB, so I am expecting an > > error as well. > > > > Is there a good reason to not display the list of available profiles on > > adding? > > It should: http://tinyurl.com/rkfw9fx > > And on further review of that code block, the profile_id should be set to 0 > there. > > Something else must be failing along the way. Maybe in your instance its > never dropping into that else block? If that's the case, I wonder where it > goes? What is $op in your instance? Better yet, what is the value of $template_id in your instance? Maybe there is some corrupted data that the script is choking on? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 14:30:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 13:30:06 +0000 Subject: [Koha-bugs] [Bug 24062] Circulation tests fail randomly if patron category type is 'X' In-Reply-To: <bug-24062-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24062-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24062-70-yq5QTDtWl6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24062 --- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Looking here now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 14:30:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 13:30:24 +0000 Subject: [Koha-bugs] [Bug 24062] Circulation tests fail randomly if patron category type is 'X' In-Reply-To: <bug-24062-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24062-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24062-70-S9FCrY36BY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24062 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 14:41:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 13:41:34 +0000 Subject: [Koha-bugs] [Bug 5016] Basket PDF has several non-translatable issues In-Reply-To: <bug-5016-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-5016-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5016-70-5MsaQfrOiJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5016 --- Comment #4 from Owen Leonard <oleonard at myacpl.org> --- (In reply to Nicole C. Engard from comment #0) > * pdf invoice says “ publié par” instead of “published by” This has been fixed. > * pdf invoice says degree symbol instead of # (as does the basket > grouping) This could be corrected by modifying the .odt files in koha-tmpl/intranet-tmpl/prog/pdf > * pdf invoice says GST instead of tax rate Where does one generate a PDF of an invoice? > * pdf not translatable I don't know if this bug predates the introduction of the OrderPdfFormat preference... It's better than nothing but only expands the options to English, French, and German. Why don't we simply generate a printable view and let the user save as/print to a PDF? -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 14:43:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 13:43:30 +0000 Subject: [Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record In-Reply-To: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23591-70-HXmxQTrj5H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591 --- Comment #6 from Séverine Queune <severine.queune at bulac.fr> --- (In reply to Jonathan Druart from comment #5) > What about the archived suggestions? Do we want to display or hide them? Or > maybe a show/hide link on top of the table? After consulting the users, to not display the archives suggestions by default, but using a link, seems more useful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 14:46:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 13:46:15 +0000 Subject: [Koha-bugs] [Bug 24062] Circulation tests fail randomly if patron category type is 'X' In-Reply-To: <bug-24062-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24062-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24062-70-1WgmRSf3Wp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24062 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 14:46:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 13:46:18 +0000 Subject: [Koha-bugs] [Bug 24062] Circulation tests fail randomly if patron category type is 'X' In-Reply-To: <bug-24062-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24062-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24062-70-Xy6HUMBTnY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24062 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95542|0 |1 is obsolete| | --- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 95549 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95549&action=edit Bug 24062: Fix the failing test Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 14:46:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 13:46:23 +0000 Subject: [Koha-bugs] [Bug 24062] Circulation tests fail randomly if patron category type is 'X' In-Reply-To: <bug-24062-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24062-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24062-70-0khZf2c1Ht@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24062 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95543|0 |1 is obsolete| | --- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 95550 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95550&action=edit Bug 24062: Make sure TestBuilder will stop generate X or other invalid category's types To make sure this kind of random failures will not appear in a future we are going to fix it at TestBuilder level. Test plan: prove t/db_dependent/TestBuilder.t and confirm it returns green You could also only apply the tests against master, run them several times and confirm that they fail most of the time. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 14:46:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 13:46:45 +0000 Subject: [Koha-bugs] [Bug 24062] Circulation tests fail randomly if patron category type is 'X' In-Reply-To: <bug-24062-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24062-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24062-70-x9gwvcXMoo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24062 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95541|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 14:47:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 13:47:32 +0000 Subject: [Koha-bugs] [Bug 24062] Circulation tests fail randomly if patron category type is 'X' In-Reply-To: <bug-24062-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24062-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24062-70-Lskv9ibL0f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24062 --- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Tric with the sub in gen_default has a slight hacky nature, but ok ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 14:48:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 13:48:34 +0000 Subject: [Koha-bugs] [Bug 24001] Cannot edit card template In-Reply-To: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24001-70-ksoaQYnwL4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Chris Nighswonger from comment #5) > (In reply to Jonathan Druart from comment #4) > > There is no printers_profile.profile_id == 0 in DB, so I am expecting an > > error as well. > > > > Is there a good reason to not display the list of available profiles on > > adding? > > It should: http://tinyurl.com/rkfw9fx We are in patroncards/edit-profile.pl, which does not have this else{} part. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 14:52:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 13:52:40 +0000 Subject: [Koha-bugs] [Bug 24001] Cannot edit card template In-Reply-To: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24001-70-3cGTT7Y55H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #8 from Chris Nighswonger <cnighswonger at foundations.edu> --- (In reply to Jonathan Druart from comment #7) > (In reply to Chris Nighswonger from comment #5) > > (In reply to Jonathan Druart from comment #4) > > > There is no printers_profile.profile_id == 0 in DB, so I am expecting an > > > error as well. > > > > > > Is there a good reason to not display the list of available profiles on > > > adding? > > > > It should: http://tinyurl.com/rkfw9fx > > We are in patroncards/edit-profile.pl, which does not have this else{} part. edit-profile.pl or edit-template.pl? > This is even worst with strict_sql_modes turned on, the creation of a new > template is impossible: ... > There is a logic issue in the controller, the printer profile list is not > passed to the template (only passed when editing). http://tinyurl.com/t9zksc2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 15:01:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 14:01:05 +0000 Subject: [Koha-bugs] [Bug 24066] New: Koha::Patron->has_permission has no POD Message-ID: <bug-24066-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24066 Bug ID: 24066 Summary: Koha::Patron->has_permission has no POD Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org As the title says, Missing POD for Koha::Patron object. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 15:04:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 14:04:14 +0000 Subject: [Koha-bugs] [Bug 24066] Koha::Patron->has_permission has no POD In-Reply-To: <bug-24066-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24066-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24066-70-kjYi06Ni6P@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24066 --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95552 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95552&action=edit Bug 24066: Add missing POD for has_permission -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 15:04:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 14:04:23 +0000 Subject: [Koha-bugs] [Bug 24066] Koha::Patron->has_permission has no POD In-Reply-To: <bug-24066-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24066-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24066-70-wJH0Ij1LK4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24066 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 15:04:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 14:04:30 +0000 Subject: [Koha-bugs] [Bug 24066] Koha::Patron->has_permission has no POD In-Reply-To: <bug-24066-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24066-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24066-70-DamJl0lLKU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24066 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 15:06:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 14:06:14 +0000 Subject: [Koha-bugs] [Bug 24062] Circulation tests fail randomly if patron category type is 'X' In-Reply-To: <bug-24062-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24062-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24062-70-uZcjOvIEFn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24062 --- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #11) > Tric with the sub in gen_default has a slight hacky nature, but ok ;) I do not see it hacky but flexible however :) Any suggestions to improve it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 15:10:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 14:10:43 +0000 Subject: [Koha-bugs] [Bug 24067] New: Refactor REST API allow-owner authorization logic Message-ID: <bug-24067-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24067 Bug ID: 24067 Summary: Refactor REST API allow-owner authorization logic Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: REST api Assignee: koha-bugs at lists.koha-community.org Reporter: lari.taskula at hypernova.fi It is possible to authorize patron an access to their own resources by defining "allow-owner" under x-koha-authorization block in endpoint's OpenAPI specification. Currently the logic for this type of authorization is centralized under Koha::REST::V1::Auth::check_object_ownership with some messy, hard to understand and possibly at some point in future even insecure logic. A better and more flexible solution is to have each REST API controller handle the "allow-owner" authorization on their own. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 15:10:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 14:10:54 +0000 Subject: [Koha-bugs] [Bug 24067] Refactor REST API allow-owner authorization logic In-Reply-To: <bug-24067-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24067-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24067-70-CCG8ewL56F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24067 Lari Taskula <lari.taskula at hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |lari.taskula at hypernova.fi |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 15:12:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 14:12:39 +0000 Subject: [Koha-bugs] [Bug 22381] Wording on Calendar-related system preferences not standardized In-Reply-To: <bug-22381-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22381-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22381-70-C3iyuBfGFx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22381 --- Comment #10 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Good catch! Thanks, Jonathan! So, following the wording used above, that's be: (Use the calendar/Ignore the calendar) when calculating the period for suspension expiration. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 15:17:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 14:17:07 +0000 Subject: [Koha-bugs] [Bug 20529] Return to results link is truncated when the search contains a double quote In-Reply-To: <bug-20529-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20529-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20529-70-46spxJ64u8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20529 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #16 from Séverine Queune <severine.queune at bulac.fr> --- Sorry Victor, it failed when I tried. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 15:18:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 14:18:37 +0000 Subject: [Koha-bugs] [Bug 24001] Cannot edit card template In-Reply-To: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24001-70-b5AShed74l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- edit-template, sorry! So basically, /cgi-bin/koha/patroncards/edit-template.pl?op=new displays: https://snipboard.io/HCSgBE.jpg See the "Click here to define a printer profile", even if printer profiles exist (this is IMO a bug). Then save => It's not saved and we get the SQL error. Given the code you pointed it to me, a profile is created if none is passed. Are we expecting it to be created with a profile_id=0? What on the second template we will add? We created another profile_id=0? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 15:29:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 14:29:06 +0000 Subject: [Koha-bugs] [Bug 24001] Cannot edit card template In-Reply-To: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24001-70-jW8qcsj7ib@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #10 from Chris Nighswonger <cnighswonger at foundations.edu> --- (In reply to Jonathan Druart from comment #9) > edit-template, sorry! > > So basically, /cgi-bin/koha/patroncards/edit-template.pl?op=new > displays: > https://snipboard.io/HCSgBE.jpg > > See the "Click here to define a printer profile", even if printer profiles > exist (this is IMO a bug). I tend to agree. > > Then save => It's not saved and we get the SQL error. > > Given the code you pointed it to me, a profile is created if none is passed. > Are we expecting it to be created with a profile_id=0? > What on the second template we will add? We created another profile_id=0? No. When a new template is created with no profile_id passed along, the profile_id is set to 0: http://tinyurl.com/smoh5g6 Ah ha! Here is the offending line: http://tinyurl.com/qurdjnc It should be thus: my @params = ( profile_id => scalar $cgi->param('profile_id') || 0, Only we need to be sure that the value of profile_id is truly numeric and not just null. Perhaps it may need to be quoted. Field constraints disallow null values and '' is just that, of course. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 15:32:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 14:32:14 +0000 Subject: [Koha-bugs] [Bug 24001] Cannot edit card template In-Reply-To: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24001-70-Ls44Ip5H0B@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #11 from Chris Nighswonger <cnighswonger at foundations.edu> --- I would guess the same issue exists in labels: http://tinyurl.com/s2pj4cs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 15:36:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 14:36:37 +0000 Subject: [Koha-bugs] [Bug 24067] Refactor REST API allow-owner authorization logic In-Reply-To: <bug-24067-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24067-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24067-70-4mFYipZsVD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24067 --- Comment #1 from Lari Taskula <lari.taskula at hypernova.fi> --- Created attachment 95553 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95553&action=edit Bug 24067: Add new subroutine check_resource_ownership This patch adds a new subroutine called check_resource_ownership. The method is called when API consumer has no permission but the request may still be authorized if the user is accessing only their own resources. In this case, it will find a method called "owner_authorization" from the controller specified by the endpoint. Testable in following patches. Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 15:36:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 14:36:48 +0000 Subject: [Koha-bugs] [Bug 24067] Refactor REST API allow-owner authorization logic In-Reply-To: <bug-24067-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24067-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24067-70-Q9JGnWjI8l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24067 --- Comment #2 from Lari Taskula <lari.taskula at hypernova.fi> --- Created attachment 95554 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95554&action=edit Bug 24067: Use check_resource_ownership in authorization To test: 1. prove t/db_dependent/api/v1/patrons_password.t 2. Observe failure (yes, really a failure - tests will pass in later test) Looks like you failed 7 tests of 15. t/db_dependent/api/v1/patrons_password.t .. 2/2 Failed test 'set_public() (unprivileged user tests)' at t/db_dependent/api/v1/patrons_password.t line 235. Looks like you failed 1 test of 2. t/db_dependent/api/v1/patrons_password.t .. Dubious, test returned 1 (wstat 256, 0x100) Failed 1/2 subtests Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 15:36:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 14:36:59 +0000 Subject: [Koha-bugs] [Bug 24067] Refactor REST API allow-owner authorization logic In-Reply-To: <bug-24067-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24067-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24067-70-Vu0S0yUUog@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24067 --- Comment #3 from Lari Taskula <lari.taskula at hypernova.fi> --- Created attachment 95555 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95555&action=edit Bug 24067: Remove check_object_ownership and old authorization methods Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 15:37:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 14:37:20 +0000 Subject: [Koha-bugs] [Bug 24067] Refactor REST API allow-owner authorization logic In-Reply-To: <bug-24067-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24067-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24067-70-QtgZ2RFCRo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24067 Lari Taskula <lari.taskula at hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 15:37:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 14:37:23 +0000 Subject: [Koha-bugs] [Bug 24067] Refactor REST API allow-owner authorization logic In-Reply-To: <bug-24067-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24067-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24067-70-csVDdyx1A8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24067 --- Comment #4 from Lari Taskula <lari.taskula at hypernova.fi> --- Created attachment 95556 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95556&action=edit Bug 24067: Use owner_authorization in POST /public/patrons/{patron_id}/password As an example, use this functionality in Koha::REST::V1::Patrons::Password To test: 1. prove t/db_dependent/api/v1/patrons_password.t 2. Observe success Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 15:47:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 14:47:35 +0000 Subject: [Koha-bugs] [Bug 24001] Cannot edit card template In-Reply-To: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24001-70-xlcXM8WFe9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #12 from Chris Nighswonger <cnighswonger at foundations.edu> --- (In reply to Jonathan Druart from comment #9) > edit-template, sorry! > > So basically, /cgi-bin/koha/patroncards/edit-template.pl?op=new > displays: > https://snipboard.io/HCSgBE.jpg > > See the "Click here to define a printer profile", even if printer profiles > exist (this is IMO a bug). This could probably be fixed by doing something similar to this: http://tinyurl.com/rmhmmw8 in here: http://tinyurl.com/tshysa5 Adjusting the code for the fact that there is not yet a template_id, of course. I'll be away for a few hours now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 15:48:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 14:48:31 +0000 Subject: [Koha-bugs] [Bug 23051] Optionally renew fine accruing items when all fines on item are paid off In-Reply-To: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23051-70-5NDQgDon6b@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94604|0 |1 is obsolete| | --- Comment #55 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 95557 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95557&action=edit Bug 23051: Add RenewAccruingItemWhenPaid syspref This patch adds the new syspref "RenewAccruingItemWhenPaid" Signed-off-by: Lucy Harrison <L.M.Harrison at lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 15:48:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 14:48:36 +0000 Subject: [Koha-bugs] [Bug 23051] Optionally renew fine accruing items when all fines on item are paid off In-Reply-To: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23051-70-jC9pSJhkO9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94605|0 |1 is obsolete| | --- Comment #56 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 95558 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95558&action=edit Bug 23051: Add unit tests This patch adds unit tests for all modules affected by this bug Signed-off-by: Lucy Harrison <L.M.Harrison at lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 15:48:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 14:48:41 +0000 Subject: [Koha-bugs] [Bug 23051] Optionally renew fine accruing items when all fines on item are paid off In-Reply-To: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23051-70-FFQcUZVini@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94606|0 |1 is obsolete| | --- Comment #57 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 95559 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95559&action=edit Bug 23051: Renew items when fines paid off When the RenewAccruingItemWhenPaid syspref is enabled and all the fines on an item that is accruing fines are paid, we automatically renew that item to prevent it from starting to accrue fines again. This patch adds an additional argument to C4::Circulation::AddRenewal which allows us to skip the calculation of fines upon renewal, which we don't want to do if the fines on that item have just been paid. Existing calls to AddRenewal have not been amended because there seems to be a convention of only passing undef when adding arguments that require their positioning to be maintained. Since the new argument is the last one, this is not the case with any existing call. Signed-off-by: Lucy Harrison <L.M.Harrison at lboro.ac.uk> Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 15:48:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 14:48:46 +0000 Subject: [Koha-bugs] [Bug 23051] Optionally renew fine accruing items when all fines on item are paid off In-Reply-To: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23051-70-EfQavankwt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051 --- Comment #58 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 95560 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95560&action=edit Bug 23051: Squash of sign off follow-ups Rebasing was a nightmare, so I'm squashing the sign off follow-ups to ease the pain with any future rebases Includes: Bug 23051: (follow-up) Refactor renewal code As per Nick's first point in comment #20, the code that tests for renewability and renews items has been refactored into it's own function. Bug 23051: (follow-up) Provide feedback For renewals that fail when a fine is being paid off, this patch causes any errors to be passed back to the template for display. Addresses the second point in Nick's comment #20 Bug 23051: (follow-up) Fix unit tests As raised by Nick in comment #35 Bug 23051: (follow-up) Fix/improve feedback This follow up patch addresses the following parts of Nick's feedback in comment #35: - it would be nice to get feedback on what was successfully renewed as well - In general I think I would prefer to see 'ok' and 'not_ok' returned as a single 'renewal_results' array - There is no listing of errors if I use the 'pay' button on an individual fine Bug 23051: (follow-up) Refactor methods This follow up patch addresses the following parts of Nick's feedback in comment #35: - I don't really like that the functions are internal functions and then exported - I think the pref description should highlight that if 'RenewalPeriodBase' is set to due date, there may be doubled charges Bug 23051: (follow-up) Add SIP summary This follow up patch addresses the following parts of Nick's feedback in comment #35: - Ideally SIP would get feedback in a screen message Bug 23051: (follow-up) Renewing in OPAC This follow up patch addresses the following parts of Nick's feedback in comment #35: - I am also not sure about the code path if a patron paid fines on the opac (via paypal etc.) but renewals are not allowed on the opac. We've introduced the syspref RenewAccruingItemInOpac (default is off) which, when enabled, will cause items attached to fines that are paid off in the OPAC (via payment plugins), to be automatically renewed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 15:49:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 14:49:14 +0000 Subject: [Koha-bugs] [Bug 23051] Optionally renew fine accruing items when all fines on item are paid off In-Reply-To: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23051-70-aZFcoH0r5x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94649|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 15:49:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 14:49:19 +0000 Subject: [Koha-bugs] [Bug 23051] Optionally renew fine accruing items when all fines on item are paid off In-Reply-To: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23051-70-2WoDSmKSP4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94629|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 15:49:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 14:49:22 +0000 Subject: [Koha-bugs] [Bug 21574] Local use system preferences page doesn't have the system preferences menu In-Reply-To: <bug-21574-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21574-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21574-70-am3Mhdy13c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21574 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 15:49:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 14:49:26 +0000 Subject: [Koha-bugs] [Bug 23051] Optionally renew fine accruing items when all fines on item are paid off In-Reply-To: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23051-70-Lv9nmPVoWa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94611|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 15:49:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 14:49:31 +0000 Subject: [Koha-bugs] [Bug 23051] Optionally renew fine accruing items when all fines on item are paid off In-Reply-To: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23051-70-MQZ9GdUMhI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94610|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 15:49:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 14:49:35 +0000 Subject: [Koha-bugs] [Bug 23051] Optionally renew fine accruing items when all fines on item are paid off In-Reply-To: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23051-70-fFNmualBBw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94609|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 15:49:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 14:49:39 +0000 Subject: [Koha-bugs] [Bug 23051] Optionally renew fine accruing items when all fines on item are paid off In-Reply-To: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23051-70-dI8oaIukqn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94608|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 15:49:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 14:49:44 +0000 Subject: [Koha-bugs] [Bug 23051] Optionally renew fine accruing items when all fines on item are paid off In-Reply-To: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23051-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23051-70-DjUaULRIk3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23051 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94607|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 15:49:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 14:49:52 +0000 Subject: [Koha-bugs] [Bug 21574] Local use system preferences page doesn't have the system preferences menu In-Reply-To: <bug-21574-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21574-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21574-70-xvSCGE2YjK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21574 --- Comment #1 from Séverine Queune <severine.queune at bulac.fr> --- Still available on master. See screenshot : https://snipboard.io/CuMvIZ.jpg -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 15:50:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 14:50:06 +0000 Subject: [Koha-bugs] [Bug 24067] Refactor REST API allow-owner authorization logic In-Reply-To: <bug-24067-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24067-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24067-70-s1QaN48FlN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24067 Lari Taskula <lari.taskula at hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95556|0 |1 is obsolete| | --- Comment #5 from Lari Taskula <lari.taskula at hypernova.fi> --- Created attachment 95561 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95561&action=edit Bug 24067: Use owner_authorization in current public endpoints To test: 1. prove t/db_dependent/api/v1/patrons_password.t 2. Observe success 3. prove t/db_dependent/api/v1/patrons.t 4. Observe success Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 15:52:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 14:52:27 +0000 Subject: [Koha-bugs] [Bug 24065] Shibboleth should fail the login if matchpoint is not unique In-Reply-To: <bug-24065-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24065-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24065-70-PCeGNGruQf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24065 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 15:52:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 14:52:30 +0000 Subject: [Koha-bugs] [Bug 24065] Shibboleth should fail the login if matchpoint is not unique In-Reply-To: <bug-24065-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24065-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24065-70-ccDC4FWbsA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24065 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95546|0 |1 is obsolete| | --- Comment #2 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 95562 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95562&action=edit Bug 24065: Fail shib login if multiple users matched Ideally you could test against active shib, but is a small code change and covered by tests and should be readable To test: prove -v t/Auth_with_shibboleth.t Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 15:59:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 14:59:56 +0000 Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items In-Reply-To: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23112-70-r3w7X2rN4G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94264|0 |1 is obsolete| | --- Comment #39 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 95565 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95565&action=edit Bug 23112: Add CirculateILL syspref Sponsored-by: Loughborough University Signed-off-by: Chris Walton <C.J.Walton at lboro.ac.uk> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 16:00:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 15:00:01 +0000 Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items In-Reply-To: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23112-70-Jcz7sZ4ca9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94265|0 |1 is obsolete| | --- Comment #40 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 95566 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95566&action=edit Bug 23112: Add circulation to ILL requests This patch adds the ability to circulate ILL requests. Once a request has a suitable status, a "Check out" button is displayed on the "Manage request" toolbar. Clicking this will enable the user to check out the item either to the user who made the request or an in-house statistical user. A due date can be specified, but if not circ rules are used. Prior to the check out, an item is created which is attached to the biblio record that was created when the request was added Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 16:00:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 15:00:06 +0000 Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items In-Reply-To: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23112-70-UPigSqJ3in@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94266|0 |1 is obsolete| | --- Comment #41 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 95567 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95567&action=edit Bug 23112: Add permission checks We only want the ILL circulation functionality to be available if the appropriate syspref and perm are available, this patch adds those checks. Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 16:00:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 15:00:11 +0000 Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items In-Reply-To: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23112-70-MEM3sN5N4n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94267|0 |1 is obsolete| | --- Comment #42 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 95568 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95568&action=edit Bug 23112: Update request status on return This patch updates a request's status to RET upon return Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 16:00:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 15:00:16 +0000 Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items In-Reply-To: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23112-70-2egOKo2RPu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94268|0 |1 is obsolete| | --- Comment #43 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 95569 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95569&action=edit Bug 23112: Add unit tests This patch adds unit test for the new Koha::Illrequest::check_out method Sponsored-by: Loughborough University -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 16:00:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 15:00:20 +0000 Subject: [Koha-bugs] [Bug 23112] Circulation of ILL items In-Reply-To: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23112-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23112-70-KRvo0SmCBp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23112 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94269|0 |1 is obsolete| | --- Comment #44 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 95570 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95570&action=edit Bug 23112: (follow-up) Call C4::Koha::GetAuthorisedValues In response to the problem Magnus was experiencing in comment #28 & #29 we now call GetAuthorisedValues by it's full path -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 16:10:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 15:10:32 +0000 Subject: [Koha-bugs] [Bug 23982] Count/pagination broken for reports with duplicated column names In-Reply-To: <bug-23982-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23982-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23982-70-HCBnAPnTzu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23982 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 16:10:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 15:10:47 +0000 Subject: [Koha-bugs] [Bug 23982] Count/pagination broken for reports with duplicated column names In-Reply-To: <bug-23982-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23982-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23982-70-5dpnvaTo1L@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23982 --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 16:13:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 15:13:19 +0000 Subject: [Koha-bugs] [Bug 23971] Add logging for basket related actions In-Reply-To: <bug-23971-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23971-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23971-70-9WNwMk31VV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr --- Comment #4 from Séverine Queune <severine.queune at bulac.fr> --- I did not manage to test the EDI part, it's a feature that I know who to use. Except that point, the 3 others work as described, even if I'm always surprised by the random order of the informations in actions_logs, but it's certainly out of scope of this patch. I think I could be good if libraries could disable this log, like it's possible for the other modules using the "Logging" sysprefs. I would probably add the reopening of a basket in the log, for, in my library, this is THE action out of workflow and I'm always quite annoy not knowing who did it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 16:15:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 15:15:57 +0000 Subject: [Koha-bugs] [Bug 24062] Circulation tests fail randomly if patron category type is 'X' In-Reply-To: <bug-24062-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24062-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24062-70-eJYlg0sk03@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24062 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 16:15:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 15:15:58 +0000 Subject: [Koha-bugs] [Bug 24062] Circulation tests fail randomly if patron category type is 'X' In-Reply-To: <bug-24062-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24062-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24062-70-B173iGKRWR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24062 --- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 16:16:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 15:16:00 +0000 Subject: [Koha-bugs] [Bug 24064] DUEDGST typoed as DUEGST In-Reply-To: <bug-24064-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24064-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24064-70-JJr2823TOK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24064 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 16:16:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 15:16:02 +0000 Subject: [Koha-bugs] [Bug 24064] DUEDGST typoed as DUEGST In-Reply-To: <bug-24064-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24064-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24064-70-MBKxEaPXF0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24064 --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 16:18:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 15:18:36 +0000 Subject: [Koha-bugs] [Bug 23676] Elasticsearch - 0 is not a valid boolean for suppress In-Reply-To: <bug-23676-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23676-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23676-70-03o1jl6Y4F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23676 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply CC| |severine.queune at bulac.fr --- Comment #4 from Séverine Queune <severine.queune at bulac.fr> --- (In reply to Michal Denar from comment #2) > Hello Nick, > can you rebase this patch on master? > > CONFLICT (content): Merge conflict in > Koha/SearchEngine/Elasticsearch/QueryBuilder.pm > error: Failed to merge in the changes. > Patch failed at 0001 Bug 23676: Use 'false' for opac suppression > > > Thank you. Same as Michal :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 16:18:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 15:18:59 +0000 Subject: [Koha-bugs] [Bug 24067] Refactor REST API allow-owner authorization logic In-Reply-To: <bug-24067-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24067-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24067-70-xeybSDEESl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24067 Lari Taskula <lari.taskula at hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95561|0 |1 is obsolete| | --- Comment #6 from Lari Taskula <lari.taskula at hypernova.fi> --- Created attachment 95571 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95571&action=edit Bug 24067: Use owner_authorization in current public endpoints To test: 1. prove t/db_dependent/api/v1/patrons_password.t 2. Observe success 3. prove t/db_dependent/api/v1/patrons.t 4. Observe success Sponsored-by: Koha-Suomi Oy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 16:50:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 15:50:55 +0000 Subject: [Koha-bugs] [Bug 23676] Elasticsearch - 0 is not a valid boolean for suppress In-Reply-To: <bug-23676-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23676-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23676-70-EhVwl4MwK4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23676 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 16:50:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 15:50:58 +0000 Subject: [Koha-bugs] [Bug 23676] Elasticsearch - 0 is not a valid boolean for suppress In-Reply-To: <bug-23676-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23676-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23676-70-RQquXshiUy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23676 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93161|0 |1 is obsolete| | --- Comment #5 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95572 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95572&action=edit Bug 23676: Use 'false' for opac suppression To test: 1 - Enable ES 2 - Enable OpacSuppression 3 - Suppress a bib in staff client Edit 942n to be 1 4 - Search the opac for anything 5 - Tail the plack logs and note a deprecation warning 6 - Apply patch 7 - Restart all the things 8 - Repeat search on opac 9 - No error/warn in logs 10 - Record is correctly suppressed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 16:51:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 15:51:57 +0000 Subject: [Koha-bugs] [Bug 23676] Elasticsearch - 0 is not a valid boolean for suppress In-Reply-To: <bug-23676-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23676-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23676-70-7bKmxGundd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23676 --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Joonas Kylmälä from comment #3) > What log is where the warning goes and which version of elasticsearch do you > use? plack-error.log This is in ES 5.x, I think it breaks in 6 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 17:08:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 16:08:44 +0000 Subject: [Koha-bugs] [Bug 24066] Koha::Patron->has_permission has no POD In-Reply-To: <bug-24066-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24066-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24066-70-YO6hyjBzst@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24066 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 17:10:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 16:10:11 +0000 Subject: [Koha-bugs] [Bug 23982] Count/pagination broken for reports with duplicated column names In-Reply-To: <bug-23982-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23982-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23982-70-hzR5zLuZ5h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23982 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_19_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 17:10:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 16:10:17 +0000 Subject: [Koha-bugs] [Bug 24062] Circulation tests fail randomly if patron category type is 'X' In-Reply-To: <bug-24062-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24062-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24062-70-fjCVo7etQU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24062 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_19_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 17:10:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 16:10:23 +0000 Subject: [Koha-bugs] [Bug 24064] DUEDGST typoed as DUEGST In-Reply-To: <bug-24064-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24064-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24064-70-kk10qDeXi3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24064 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_19_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 17:16:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 16:16:38 +0000 Subject: [Koha-bugs] [Bug 11808] When searching for a cardnumber in the intranet, also try to search for it on the LDAP server if one is configured and add/update user In-Reply-To: <bug-11808-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11808-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11808-70-Np2f4Z6Kzm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11808 --- Comment #14 from Maryse Simard <maryse.simard at inlibro.com> --- Created attachment 95573 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95573&action=edit Bug 11808: (QA follow-up) Adds support for other patron searches This patch add supports to other pages where patron search is possible: patron search, hold and article requests. Removes the code that tried to support searching for search fields other than cardnumber in circulation.pl Catch exception on broken FK contraint if information on the LDAP server can't be added to the database as to not interrupt execution. The error message is shown on the UI. Revised test plan: 0. You need to have an ldap server containing patron informations configured in Koha. 1. Apply patch and update database. 2. Check that the new system preference SearchCardnumberWithLDAP has been added and set as 'never'. 3. Choose a patron who exists in your ldap server but not in Koha. (you can delete an existing patron from Koha if needed) 4. Search for the patron by it's cardnumber in the following locations. Do not choose from the dropdown list, use the submit button. - circ/circulation.pl - circ/article-request.pl - reserve/request.pl - members/member.pl both at the top and in the filter box - any page using common/patron_search.tt, for example adding a guarantor with the members/guarantor_search.pl popup => Should return cardnumber/patron not found or no results 5. Change SearchCardnumberWithLDAP to 'if not found locally'. 6. Repeat step 4. => The patron should be added to Koha. 7. Edit the patron and change any of the existing information. 8. Repeat step 4. => The patron has not been updated (the change made in step 7 is still there) 9. Change SearchCardnumberWithLDAP to 'always'. 10. Repeat step 4. => The patron has been updated. Change made in step 7 has been rewritten and patron informations is the same as in step 6. 11. Try searching for a patron who doesn't exist in Koha and has a nonexistant branch on the LDAP server. An error message should appear accompanying the absence of results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 17:21:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 16:21:28 +0000 Subject: [Koha-bugs] [Bug 11808] When searching for a cardnumber in the intranet, also try to search for it on the LDAP server if one is configured and add/update user In-Reply-To: <bug-11808-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11808-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11808-70-38rBRi4Ph8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11808 Maryse Simard <maryse.simard at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #15 from Maryse Simard <maryse.simard at inlibro.com> --- Thank you very much for testing and for your feedback! I added support for the functionality to other pages where patron search is possible, the list is in the patch description. I also added error handling, showing the error in the user interface if there is a problem when creating the new borrower in Koha. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 17:25:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 16:25:16 +0000 Subject: [Koha-bugs] [Bug 24068] New: Koha::Template::Plugin::I18N->tnpx should call Koha::I18->__npx Message-ID: <bug-24068-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24068 Bug ID: 24068 Summary: Koha::Template::Plugin::I18N->tnpx should call Koha::I18->__npx Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: I18N/L10N Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr It calls __np -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 17:25:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 16:25:29 +0000 Subject: [Koha-bugs] [Bug 24068] Koha::Template::Plugin::I18N->tnpx should call Koha::I18->__npx In-Reply-To: <bug-24068-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24068-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24068-70-CRBUk0wBT0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24068 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |15395 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 [Bug 15395] Internationalization: plural forms, context, and more -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 17:25:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 16:25:29 +0000 Subject: [Koha-bugs] [Bug 15395] Internationalization: plural forms, context, and more In-Reply-To: <bug-15395-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15395-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15395-70-5Flxz4DQwi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15395 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24068 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24068 [Bug 24068] Koha::Template::Plugin::I18N->tnpx should call Koha::I18->__npx -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 17:31:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 16:31:17 +0000 Subject: [Koha-bugs] [Bug 24068] Koha::Template::Plugin::I18N->tnpx should call Koha::I18->__npx In-Reply-To: <bug-24068-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24068-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24068-70-Qne6ypZ9hF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24068 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 17:31:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 16:31:20 +0000 Subject: [Koha-bugs] [Bug 24068] Koha::Template::Plugin::I18N->tnpx should call Koha::I18->__npx In-Reply-To: <bug-24068-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24068-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24068-70-7MAJXNQTZH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24068 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95578 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95578&action=edit Bug 24068: Fix I18 plugin - tnpx must call __npx Test plan: Use the following code to test this change [% PROCESS 'i18n.inc' %] [% SET nb_stuffs = 1 %] [% tnpx('context', 'There is one stuff.', 'There are {count} stuffs.', nb_stuffs, { count = nb_stuffs }) | $raw %] [% SET nb_stuffs = 42 %] [% tnpx('context', 'There is one stuff.', 'There are {count} stuffs.', nb_stuffs, { count = nb_stuffs }) | $raw %] Compare with and without the patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 17:31:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 16:31:41 +0000 Subject: [Koha-bugs] [Bug 24068] Koha::Template::Plugin::I18N->tnpx should call Koha::I18->__npx In-Reply-To: <bug-24068-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24068-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24068-70-Ez7VOr1Kse@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24068 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_19_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 17:36:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 16:36:23 +0000 Subject: [Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record In-Reply-To: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23591-70-nvJaCUlxqF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24068 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24068 [Bug 24068] Koha::Template::Plugin::I18N->tnpx should call Koha::I18->__npx -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 17:36:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 16:36:23 +0000 Subject: [Koha-bugs] [Bug 24068] Koha::Template::Plugin::I18N->tnpx should call Koha::I18->__npx In-Reply-To: <bug-24068-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24068-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24068-70-IJQZrSMth0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24068 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23591 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591 [Bug 23591] Add a new "Suggestions details" tab on bibliographic record -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 17:37:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 16:37:13 +0000 Subject: [Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record In-Reply-To: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23591-70-Na39sKmn25@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591 --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95579 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95579&action=edit Bug 23591: Hide archived suggestions However we are adding a note on top of the table to tell how many suggestions are archived. It seems that there is no good reason to display the archived suggestions on this table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 17:41:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 16:41:21 +0000 Subject: [Koha-bugs] [Bug 9156] itemcallnumber not pulling more than 2 subfields In-Reply-To: <bug-9156-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9156-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9156-70-E5W7CWfDjl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 17:41:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 16:41:24 +0000 Subject: [Koha-bugs] [Bug 9156] itemcallnumber not pulling more than 2 subfields In-Reply-To: <bug-9156-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9156-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9156-70-BRzPLt5j6l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156 --- Comment #5 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 95580 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95580&action=edit Bug 9156: itemcallnumber not pulling more than 2 subfields When the itemcallnumber system preference is defined, the item add form pulls data from the specified tag and subfield(s) to pre-populate the call number field. This update makes it possible to build the prepopulated callnumber from more than just the first two subfields. To test, apply the patch and update the itemcallnumber system preference so that it includes more than two subfields. For instance, "092abef" - Edit a bibliographic record and populate the specified subfields. e.g. subfield a -> "One", b-> "Two", e-> "Three", f-> "Four". - Save the record and go to the add/edit items screen. - The call number field should contain a string which contains each of the subfields you populated, concatenated with spaces: "One Two Three Four." - Test with other numbers of subfields. - Test with an empty itemcallnumber preference. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 17:43:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 16:43:55 +0000 Subject: [Koha-bugs] [Bug 23702] New UNIMARC XSLT according to last IFLA updates In-Reply-To: <bug-23702-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23702-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23702-70-BOE3zDmh0O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23702 --- Comment #17 from Koha Team University Lyon 3 <koha at univ-lyon3.fr> --- Created attachment 95581 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95581&action=edit Bug 23702 - New UNIMARC XSLT according to last IFLA updates -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 17:48:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 16:48:18 +0000 Subject: [Koha-bugs] [Bug 21574] Local use system preferences page doesn't have the system preferences menu In-Reply-To: <bug-21574-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21574-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21574-70-zTwfFXtQUx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21574 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20743 Keywords| |Academy --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Whoever wrote the patch for Bug 20743 was a little too careless with their cut-and-paste and included the wrong menu include. It should be [% INCLUDE 'prefs-menu.inc' %] instead of [% INCLUDE 'admin-menu.inc' %] Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20743 [Bug 20743] Update two-column templates with Bootstrap grid: Administration part 7 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 17:48:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 16:48:18 +0000 Subject: [Koha-bugs] [Bug 20743] Update two-column templates with Bootstrap grid: Administration part 7 In-Reply-To: <bug-20743-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20743-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20743-70-3i9yxR5YCZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20743 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |21574 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21574 [Bug 21574] Local use system preferences page doesn't have the system preferences menu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 17:55:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 16:55:11 +0000 Subject: [Koha-bugs] [Bug 19498] Translatability: Get rid of [% block_budget.count %] and similar In-Reply-To: <bug-19498-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19498-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19498-70-vR5n3P4mPV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19498 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |DUPLICATE CC| |bgkriegel at gmail.com --- Comment #2 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Fixed in Bug 10492 *** This bug has been marked as a duplicate of bug 10492 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 17:55:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 16:55:11 +0000 Subject: [Koha-bugs] [Bug 10492] Translation problems with TT directives in po files In-Reply-To: <bug-10492-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10492-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10492-70-ughNuDL9fQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10492 --- Comment #11 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- *** Bug 19498 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 17:59:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 16:59:46 +0000 Subject: [Koha-bugs] [Bug 10879] OverDrive should check for OverDriveLibraryID before performing search In-Reply-To: <bug-10879-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10879-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10879-70-b21uVpfOe7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10879 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|pianohacker at gmail.com |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 18:03:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 17:03:20 +0000 Subject: [Koha-bugs] [Bug 21574] Local use system preferences page doesn't have the system preferences menu In-Reply-To: <bug-21574-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21574-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21574-70-R814suZ9kr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21574 Lisette Scheer <lisetteslatah at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 18:03:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 17:03:23 +0000 Subject: [Koha-bugs] [Bug 21574] Local use system preferences page doesn't have the system preferences menu In-Reply-To: <bug-21574-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21574-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21574-70-UqBtchpiid@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21574 --- Comment #3 from Lisette Scheer <lisetteslatah at gmail.com> --- Created attachment 95583 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95583&action=edit Bug 21574 : Local use system preferences page doesn't have the system preferences menu The "local use" tab in system preferences is showing the admin menu instead of the system preferences menu tabs. This patch fixes the menu display. To test: 1) Go to the system preferences in administration. 2) Click the 'Local use' tab. 3) Observe the inncorrect menu. 4) Apply the patch. 5) Repeat steps 1-2 6) Observe the correct menu. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 18:03:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 17:03:48 +0000 Subject: [Koha-bugs] [Bug 21574] Local use system preferences page doesn't have the system preferences menu In-Reply-To: <bug-21574-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21574-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21574-70-iRYKp4Mw2V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21574 Lisette Scheer <lisetteslatah at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com Assignee|koha-bugs at lists.koha-commun |lisetteslatah at gmail.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 18:19:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 17:19:30 +0000 Subject: [Koha-bugs] [Bug 10879] OverDrive should check for OverDriveLibraryID before performing search In-Reply-To: <bug-10879-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10879-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10879-70-HVxjfLqTpx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10879 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 18:19:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 17:19:32 +0000 Subject: [Koha-bugs] [Bug 10879] OverDrive should check for OverDriveLibraryID before performing search In-Reply-To: <bug-10879-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10879-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10879-70-ApWQjOPy51@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10879 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 95584 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95584&action=edit Bug 10879: OverDrive should check for OverDriveLibraryID before performing search This patch modifies the OPAC search results template to check for three populated system preferences before performing an OverDrive search: OverDriveLibraryID, OverDriveClientKey, and OverDriveClientSecret. Previously OverDriveLibraryID was not checked, but without it the interface reports an error performing the search. To test you must have credentials for the OverDrive API as defined in OverDriveClientKey, OverDriveClientSecret, and OverDriveLibraryID system preferences. - With OverDriveLibraryID defined, the catalog search results page in the OPAC should show a link to results in the library's OverDrive collection. - With no value in the OverDriveLibraryID preference the catalog search page should not show any message about an OverDrive collection. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 18:26:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 17:26:10 +0000 Subject: [Koha-bugs] [Bug 24061] Print List (opac-shelves.pl) broken in Chrome In-Reply-To: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24061-70-QNP9s1yyl6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24061 --- Comment #4 from Lucas Gass <lucas at bywatersolutions.com> --- This is happening to me on master in Chrome 78.0.3904.97 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 18:31:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 17:31:43 +0000 Subject: [Koha-bugs] [Bug 24061] Print List (opac-shelves.pl) broken in Chrome In-Reply-To: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24061-70-GmPsBKAZzL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24061 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #5 from Liz Rea <wizzyrea at gmail.com> --- Same results for me - go to print, window opens and immediately closes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 18:51:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 17:51:10 +0000 Subject: [Koha-bugs] [Bug 13667] Provide script to regularly clean deletedborrowers table In-Reply-To: <bug-13667-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13667-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13667-70-i0oY9eOuAl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13667 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored Assignee|gmcharlt at gmail.com |jonathan.druart at bugs.koha-c | |ommunity.org Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 18:56:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 17:56:17 +0000 Subject: [Koha-bugs] [Bug 24053] Typo in FinePaymentAutoPopup description In-Reply-To: <bug-24053-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24053-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24053-70-BAdPrj0U4y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24053 Lisette Scheer <lisetteslatah at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 18:56:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 17:56:19 +0000 Subject: [Koha-bugs] [Bug 24053] Typo in FinePaymentAutoPopup description In-Reply-To: <bug-24053-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24053-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24053-70-13RmYCY2Di@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24053 --- Comment #1 from Lisette Scheer <lisetteslatah at gmail.com> --- Created attachment 95585 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95585&action=edit Bug 24053 : Typo in FinePaymentAutoPopup description There is a typo in the FinePaymentAutoPopup system preference description. This bug fixes that. To test: 1) Go to the systems preferences in administration. 2) Search for FinePaymentAutoPopup 3) Observe .. at the end of the preference description. 4) Apply the patch 5 ) Repeat steaps 1-2 6) Ovserve correct punctuation at the end of the preference description. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 18:56:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 17:56:51 +0000 Subject: [Koha-bugs] [Bug 24053] Typo in FinePaymentAutoPopup description In-Reply-To: <bug-24053-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24053-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24053-70-CJ3wPfsLX4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24053 Lisette Scheer <lisetteslatah at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |lisetteslatah at gmail.com CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 19:00:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 18:00:13 +0000 Subject: [Koha-bugs] [Bug 24001] Cannot edit card template In-Reply-To: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24001-70-iggDh5wmaD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #13 from Chris Nighswonger <cnighswonger at foundations.edu> --- (In reply to Jonathan Druart from comment #0) > To recreate: > - Go to Home › Tools › Patron card creator › Templates > - New > Card template > - Save > - Edit > - Save > > => > Can't bless non-reference value at > /home/vagrant/kohaclone/C4/Creators/Profile.pm line 89 > C4::Creators::Profile::retrieve('C4::Patroncards::Profile', > 'profile_id', 22, 'creator', 'Patroncards') called at > /home/vagrant/kohaclone/C4/Patroncards/Profile.pm line 29 > C4::Patroncards::Profile::retrieve('profile_id', 22, 'creator', > 'Patroncards') called at > /home/vagrant/kohaclone/patroncards/edit-template.pl line 78 Just reading back over this: Does your installation have a profile with a profile_id == 22? It seems that the problem described in the first comment could be different from the one described in the second second. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 19:11:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 18:11:53 +0000 Subject: [Koha-bugs] [Bug 24056] Capitalization: Cash Register ID on cash register management page In-Reply-To: <bug-24056-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24056-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24056-70-8RWHbIZTyd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24056 Lisette Scheer <lisetteslatah at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |lisetteslatah at gmail.com CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 19:34:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 18:34:47 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: <bug-6473-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6473-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6473-70-FI0ULo8H1C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|19.05 |--- --- Comment #226 from Lisette Scheer <lisetteslatah at gmail.com> --- Created attachment 95586 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95586&action=edit Bug 24056 : Capitalization: Cash Register ID on cash register management page When editing a cash register, Cash register ID doesn't follow our capitalization guidelines. This patch fixes that. To Test: 1) Turn on cash register usage in the system prefere -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 19:36:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 18:36:02 +0000 Subject: [Koha-bugs] [Bug 24056] Capitalization: Cash Register ID on cash register management page In-Reply-To: <bug-24056-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24056-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24056-70-FmVycH1lCS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24056 Lisette Scheer <lisetteslatah at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 19:36:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 18:36:04 +0000 Subject: [Koha-bugs] [Bug 24056] Capitalization: Cash Register ID on cash register management page In-Reply-To: <bug-24056-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24056-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24056-70-TQ45qu3qd4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24056 --- Comment #1 from Lisette Scheer <lisetteslatah at gmail.com> --- Created attachment 95587 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95587&action=edit Bug 24056 : Capitalization: Cash Register ID on cash register management page When editing a cash register, Cash register ID doesn't follow our capitalization guidelines. This patch fixes that. To Test: 1) Turn on cash register usage in the system preferences. 2) Add a cash register. 3) Edit the cash register. 4) Note the incorrect capitalization. 5) Apply the patch. 6) Edit the cash register. 7) Note the correct capitalization. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 20:29:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 19:29:08 +0000 Subject: [Koha-bugs] [Bug 11281] printing holds awaiting pickup prints both tabs In-Reply-To: <bug-11281-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11281-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11281-70-SA2k4TJDHh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11281 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 20:31:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 19:31:16 +0000 Subject: [Koha-bugs] [Bug 11281] Printing holds awaiting pickup prints both tabs In-Reply-To: <bug-11281-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11281-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11281-70-tYu3nGh7As@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11281 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|printing holds awaiting |Printing holds awaiting |pickup prints both tabs |pickup prints both tabs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 20:34:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 19:34:10 +0000 Subject: [Koha-bugs] [Bug 24001] Cannot edit card template In-Reply-To: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24001-70-JIxABkcPop@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- It has a printers_profile.profile_id = 22, but I think here we are talking about creator_templates.profile_id MySQL [koha_kohadev]> select template_id, profile_id from creator_templates; +-------------+------------+ | template_id | profile_id | +-------------+------------+ | 22 | 0 | | 24 | 0 | | 1 | 1 | | 7 | 13 | | 12 | 14 | | 23 | 16 | +-------------+------------+ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 20:39:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 19:39:07 +0000 Subject: [Koha-bugs] [Bug 23213] Add hook to OPAC payments to allow plugins to set minimum payment threshold In-Reply-To: <bug-23213-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23213-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23213-70-PH9wGfNDqa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23213 --- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- We certainly should, well spotted Katrin. Agustin, could you take care of adding this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 20:43:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 19:43:01 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: <bug-14973-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14973-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14973-70-y5SsmkYumR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23173 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 20:43:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 19:43:01 +0000 Subject: [Koha-bugs] [Bug 23173] ILL should be able to search third party sources prior to request creation In-Reply-To: <bug-23173-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23173-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23173-70-C2NSTkvUaM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23173 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14973 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 20:43:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 19:43:31 +0000 Subject: [Koha-bugs] [Bug 24001] Cannot edit card template In-Reply-To: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24001-70-19LTgFT1qN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #15 from Chris Nighswonger <cnighswonger at foundations.edu> --- (In reply to Jonathan Druart from comment #14) > It has a printers_profile.profile_id = 22, but I think here we are talking > about creator_templates.profile_id > > MySQL [koha_kohadev]> select template_id, profile_id from creator_templates; The error occurs on attempting to execute the following on your system in the script: SELECT * FROM printers_profile WHERE profile_id = 22 AND creator = 'Patroncards'; What does that say in the client? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 20:45:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 19:45:39 +0000 Subject: [Koha-bugs] [Bug 14973] Suggestions - Search and warn user about existing biblio when submitting a suggestion In-Reply-To: <bug-14973-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14973-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14973-70-WhRsDTVUbf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14973 --- Comment #46 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Hmm, might be worth taking a look at bug 23173 for some possible inspiration here.. it add hooks to allow searching of various sources via plugins before submitting an ILL request.. feels like a similar mechanism could be employed here too and would go be perhaps a more flexible end result? Just some food for thought.. it's still on my list to work through this patch set anyway. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 20:45:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 19:45:44 +0000 Subject: [Koha-bugs] [Bug 24001] Cannot edit card template In-Reply-To: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24001-70-rHw8lOlbeY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #16 from Chris Nighswonger <cnighswonger at foundations.edu> --- Just to be clear: I think we are encountering different issues in the description and comment #1. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 21:11:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 20:11:59 +0000 Subject: [Koha-bugs] [Bug 24060] Can't load patron clubs tab on patron details page In-Reply-To: <bug-24060-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24060-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24060-70-u23uHjALqE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24060 Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 21:12:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 20:12:01 +0000 Subject: [Koha-bugs] [Bug 24060] Can't load patron clubs tab on patron details page In-Reply-To: <bug-24060-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24060-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24060-70-kG0z7QMiZr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24060 Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95516|0 |1 is obsolete| | --- Comment #2 from Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> --- Created attachment 95588 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95588&action=edit Bug 24060: Use patron object to load club tab To recreate: 1 - Be using 19.05 2 - Create a club template and a club 3 - Go to a patron's checkout page 4 - Note the club tab will load 5 - Go to a patron's details page 6 - Note the club tab says 'Loading' 7 - Apply patch 8 - It loads! Signed-off-by: Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 21:13:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 20:13:02 +0000 Subject: [Koha-bugs] [Bug 24060] Can't load patron clubs tab on patron details page In-Reply-To: <bug-24060-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24060-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24060-70-xPgdWn5PMO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24060 --- Comment #3 from Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> --- Yes, this patch works on 19.05 as expected. This is only a bug on the 19.05 branch. Clubs tab loads on master at present. Thank you!! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 23:57:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 22:57:43 +0000 Subject: [Koha-bugs] [Bug 24061] Print List (opac-shelves.pl) broken in Chrome In-Reply-To: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24061-70-KjxFA9bDhy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24061 --- Comment #6 from Lucas Gass <lucas at bywatersolutions.com> --- I think this is because the setTimeout() is too quick for Chrome. (1ms) 967 [% IF print %] 968 window.print(); 969 setTimeout('window.close()', 1); 970 [% END %] -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 23:59:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 22:59:50 +0000 Subject: [Koha-bugs] [Bug 24061] Print List (opac-shelves.pl) broken in Chrome In-Reply-To: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24061-70-5xUg2KC7lg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24061 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 19 23:59:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 19 Nov 2019 22:59:52 +0000 Subject: [Koha-bugs] [Bug 24061] Print List (opac-shelves.pl) broken in Chrome In-Reply-To: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24061-70-0R8GW5YN46@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24061 --- Comment #7 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 95589 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95589&action=edit Bug 24061: change setTimeout in opac-shelves.tt TEST PLAN: -set up a new public list with a few items -go to the OPAC and view that list. -Click 'Print List' in Chrome. -The tab opens but immediately closes itself. -Apply patch and try again -Now you can print! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 01:28:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 00:28:23 +0000 Subject: [Koha-bugs] [Bug 23068] Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy In-Reply-To: <bug-23068-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23068-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23068-70-vJG4L8EhSp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068 --- Comment #36 from David Cook <dcook at prosentient.com.au> --- (In reply to Martin Renvoize from comment #34) > Correct, it has been escalated to a 'required' dependancy. This is because > for plack we need to load it before we load C4::Context and as such we can't > use it optionally as initially thought. I was thinking we could actually make good use of Net::Netmask in other parts of Koha as well. I'd love to use it for processing ILS-DI:AuthorizedIPs (could also use it for OpacSuppressionByIPRange, RestrictedPageLocalIPs, and surely other places that don't come to mind yet...). So it being a required dependency could be a motivator for updating those too. *puts it on his infinite todo list*. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 01:45:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 00:45:38 +0000 Subject: [Koha-bugs] [Bug 18499] 'Call Number Browser' on edit items screen uses the default classification source rather than the item specific source In-Reply-To: <bug-18499-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18499-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18499-70-EjMjPwcR9l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18499 Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mkstephens at lancasterseminar | |y.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 02:31:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 01:31:51 +0000 Subject: [Koha-bugs] [Bug 23184] Export/bibs/holdings settings unclear for exporting bibs without any holdings In-Reply-To: <bug-23184-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23184-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23184-70-oFQPkVTuaE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23184 Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 02:31:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 01:31:54 +0000 Subject: [Koha-bugs] [Bug 23184] Export/bibs/holdings settings unclear for exporting bibs without any holdings In-Reply-To: <bug-23184-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23184-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23184-70-ZiyaedQ1qA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23184 Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95002|0 |1 is obsolete| | --- Comment #5 from Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> --- Created attachment 95590 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95590&action=edit Bug 23184: Don't select branches for export by default This patch changes the include to require passing "selectall=1" to select all items This include is only used in this page, so changes should not have side effects git grep "branch-selector\.inc" This patch also corrects a mismatch in the class names To test: 1 - Browse to Tools->Export data 2 - Note all branches are selected 3 - Note this will exclude records wiuthout items if you click 'Export bibiographic records' 4 - Apply patch 5 - Visit page again 6 - Note no branches are selected by default 7 - Confirm 'Select all/Clear all' still work 8 - Note record with no items are exported by default now Signed-off-by: Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 02:32:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 01:32:26 +0000 Subject: [Koha-bugs] [Bug 23184] Export/bibs/holdings settings unclear for exporting bibs without any holdings In-Reply-To: <bug-23184-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23184-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23184-70-7QPmCrBo5U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23184 Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mkstephens at lancasterseminar | |y.edu --- Comment #6 from Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> --- Patch works as expected/described. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 09:20:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 08:20:33 +0000 Subject: [Koha-bugs] [Bug 24061] Print List (opac-shelves.pl) broken in Chrome In-Reply-To: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24061-70-Bzt4rtd2He@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24061 --- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95591 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95591&action=edit [ALTERNATIVE-PATCH] Bug 24061: Close the window after the page has been printed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 09:21:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 08:21:46 +0000 Subject: [Koha-bugs] [Bug 24061] Print List (opac-shelves.pl) broken in Chrome In-Reply-To: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24061-70-UO3JuaaL1a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24061 --- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Hi Lucas, Stackoverflow suggests to close the window after it has been print, ie. it takes back the focus. The solution sounds quite good to me. Could you try it? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 09:42:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 08:42:13 +0000 Subject: [Koha-bugs] [Bug 24069] software error In-Reply-To: <bug-24069-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24069-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24069-70-RGDkB1GWNP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24069 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|chris at bigballofwax.co.nz |koha-bugs at lists.koha-commun | |ity.org Product|Koha security |Koha Component|Koha |Architecture, internals, | |and plumbing QA Contact| |testopia at bugs.koha-communit | |y.org Group|Koha security | Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Hello, Please ask the general mailing list or the IRC channel for support. You will need to provide more details (how did you install Koha, the version you are using, which OS, etc.) https://wiki.koha-community.org/wiki/Mailing_lists https://wiki.koha-community.org/wiki/Getting_involved#First_steps_into_the_community -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 09:42:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 08:42:46 +0000 Subject: [Koha-bugs] [Bug 21574] Local use system preferences page doesn't have the system preferences menu In-Reply-To: <bug-21574-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21574-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21574-70-4Q0GIXDydJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21574 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 09:42:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 08:42:48 +0000 Subject: [Koha-bugs] [Bug 21574] Local use system preferences page doesn't have the system preferences menu In-Reply-To: <bug-21574-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21574-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21574-70-tH5Z3dyJgX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21574 --- Comment #4 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 95592 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95592&action=edit Bug 21574 : Local use system preferences page doesn't have the system preferences menu The "local use" tab in system preferences is showing the admin menu instead of the system preferences menu tabs. This patch fixes the menu display. To test: 1) Go to th Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 09:50:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 08:50:21 +0000 Subject: [Koha-bugs] [Bug 23982] Count/pagination broken for reports with duplicated column names In-Reply-To: <bug-23982-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23982-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23982-70-XS36u6ufQp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23982 --- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95593 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95593&action=edit Bug 23982: Fix the failing test # Failed test 'nb_rows returns 0 on bad queries' # at t/db_dependent/Reports/Guided.t line 441. # got: undef # expected: '0' Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 09:50:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 08:50:38 +0000 Subject: [Koha-bugs] [Bug 23982] Count/pagination broken for reports with duplicated column names In-Reply-To: <bug-23982-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23982-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23982-70-NIuIX1ti55@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23982 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 10:03:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 09:03:35 +0000 Subject: [Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record In-Reply-To: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23591-70-PGCtBxWE0B@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591 --- Comment #8 from Séverine Queune <severine.queune at bulac.fr> --- A detail but I need to ask... On the message "There is one archived suggestion.", "one" is written in full letters, but when there are more suggestions, numbers are used. Do you want to keep these different forms ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 10:05:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 09:05:39 +0000 Subject: [Koha-bugs] [Bug 23964] An item level hold when placed is set to Waiting, if ReservesNeedReturn is set to Automatic In-Reply-To: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23964-70-xTRgEaRfNo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23964 --- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Comment on attachment 95544 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95544 Bug 23964: (follow-up) more test clarification Review of attachment 95544: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=23964&attachment=95544) ----------------------------------------------------------------- ::: koha-tmpl/intranet-tmpl/prog/en/modules/members/tables/guarantor_search.tt @@ +18,4 @@ > "dt_address": > "[% INCLUDE escape_address data=data %]", > "dt_action": > + "<a href=\"#\" class=\"btn btn-default btn-xs select_user\" data-borrowernumber=\"[% data.borrowernumber | html %]\">Select</a><input type=\"hidden\" id=\"borrower_data[% data.borrowernumber | html %]\" name=\"borrower_data[% data.borrowernumber | html %]\" value=\"[% data | html | $To %]\" />" Not related to this patch. Will amend. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 10:06:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 09:06:17 +0000 Subject: [Koha-bugs] [Bug 23964] An item level hold when placed is set to Waiting, if ReservesNeedReturn is set to Automatic In-Reply-To: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23964-70-i9fZicOMZ1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23964 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95021|0 |1 is obsolete| | Attachment #95022|0 |1 is obsolete| | Attachment #95111|0 |1 is obsolete| | Attachment #95249|0 |1 is obsolete| | Attachment #95544|0 |1 is obsolete| | --- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95594 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95594&action=edit Bug 23964: Unit tests Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 10:06:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 09:06:22 +0000 Subject: [Koha-bugs] [Bug 23964] An item level hold when placed is set to Waiting, if ReservesNeedReturn is set to Automatic In-Reply-To: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23964-70-1IGzhchAZ5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23964 --- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95595 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95595&action=edit Bug 23964: ReservesNeedReturn should only apply to available items To test: 1 - Checkout an item to a patron 2 - Make sure 'ReservesNeedReturn' is set to 'Automatically' 3 - Place an item level hold on the checked out item 4 - Note the hold is marked waiting 5 - Delete the hold 6 - Apply patch 7 - Place a new hold 8 - Hold is not marked waiting 9 - Please a hold on a different item 10 - Note it is marked waiting 11 - Test when item is damaged and hold not allowed on damaged items 12 - Test when item is in transit 13 - Test when item has another hold 14 - Only in the case where none of the above are true should the hold be marked waiting Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 10:06:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 09:06:27 +0000 Subject: [Koha-bugs] [Bug 23964] An item level hold when placed is set to Waiting, if ReservesNeedReturn is set to Automatic In-Reply-To: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23964-70-BmKKP0UWwg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23964 --- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95596 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95596&action=edit Bug 23964: (follow-up) Add comments and improve readability Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 10:06:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 09:06:32 +0000 Subject: [Koha-bugs] [Bug 23964] An item level hold when placed is set to Waiting, if ReservesNeedReturn is set to Automatic In-Reply-To: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23964-70-zrQtEh7ZNX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23964 --- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95597 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95597&action=edit Bug 23964: Use is instead of isnt in tests Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 10:06:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 09:06:37 +0000 Subject: [Koha-bugs] [Bug 23964] An item level hold when placed is set to Waiting, if ReservesNeedReturn is set to Automatic In-Reply-To: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23964-70-c1ziAdZC6i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23964 --- Comment #19 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95598 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95598&action=edit Bug 23964: (follow-up) more test clarification Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 10:06:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 09:06:41 +0000 Subject: [Koha-bugs] [Bug 23964] An item level hold when placed is set to Waiting, if ReservesNeedReturn is set to Automatic In-Reply-To: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23964-70-BN6ne4iT2e@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23964 --- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95599 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95599&action=edit Bug 23964: 3 more tests to cover found and match the description Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 10:20:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 09:20:16 +0000 Subject: [Koha-bugs] [Bug 23128] Missing Net::OAuth2::AuthorizationServer dependency In-Reply-To: <bug-23128-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23128-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23128-70-DEcgxkX2uL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23128 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Wiki pages need to be updated: https://wiki.koha-community.org/wiki/Koha_on_Debian#Debian_Packages_on_Koha https://wiki.koha-community.org/wiki/Koha_on_ubuntu_-_packages#Introduction Also should not we inform the ML? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 10:31:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 09:31:08 +0000 Subject: [Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record In-Reply-To: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23591-70-nq6McmlSZL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591 --- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Séverine Queune from comment #8) > A detail but I need to ask... > On the message "There is one archived suggestion.", "one" is written in full > letters, but when there are more suggestions, numbers are used. > Do you want to keep these different forms ? I will let that for someone else. It makes sense to me to have it like that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 10:51:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 09:51:32 +0000 Subject: [Koha-bugs] [Bug 9156] itemcallnumber not pulling more than 2 subfields In-Reply-To: <bug-9156-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9156-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9156-70-bcbZX4JbyJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |severine.queune at bulac.fr --- Comment #6 from Séverine Queune <severine.queune at bulac.fr> --- Hi Owen, I had 2 issues during my tests. The itemcallnumber field is not populated when I add the item, I need to modify it and save it a second time. I know it's not allowed in MARC21, but we have in our Unimarc item framework both upper and lower case and the patch only works with Upper case. Do you think it can be case sensitive ? (if I remember well, I think Katrin can be also concerned). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 10:53:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 09:53:24 +0000 Subject: [Koha-bugs] [Bug 23987] batchMod.pl provides a link back to the record after the record is deleted In-Reply-To: <bug-23987-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23987-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23987-70-zkIiwGynUY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23987 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 10:57:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 09:57:02 +0000 Subject: [Koha-bugs] [Bug 23927] Duplicate a "Complete" order link the "New" one to the invoice In-Reply-To: <bug-23927-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23927-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23927-70-7Y5roHnLTz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23927 --- Comment #2 from Séverine Queune <severine.queune at bulac.fr> --- To me, as it's supposed to be a new order, status should be "NEW". The fact we use an other order is just a way to ease the acquisition process (e.g dictionaries, references items or subscriptions we want to buy each year), so it should not have effect on the new order. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 10:58:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 09:58:10 +0000 Subject: [Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record In-Reply-To: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23591-70-xlsuLu3iFl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591 --- Comment #10 from Séverine Queune <severine.queune at bulac.fr> --- No problem for me, just wanted to be sure :) Let's go for signing ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 11:06:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 10:06:37 +0000 Subject: [Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record In-Reply-To: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23591-70-t0H4bbZQwQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 11:06:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 10:06:41 +0000 Subject: [Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record In-Reply-To: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23591-70-q3KTZRP1OI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95518|0 |1 is obsolete| | --- Comment #11 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 95600 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95600&action=edit Bug 23591: Add some useful methods to Koha::Suggestions Those are methods initially written for bug 23991. I finally need them before than expected. Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 11:06:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 10:06:45 +0000 Subject: [Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record In-Reply-To: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23591-70-93DhFwmdee@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95519|0 |1 is obsolete| | --- Comment #12 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 95601 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95601&action=edit Bug 23591: Display a new "Suggestion detail" tab on the bib detail page This patch adds a new "Suggestion detail" tab on the bibliographic detail page. It will help suggestion management. Test plan: - Create several suggestions for a given biblio - Go to the detail page of the bibliographic record and confirm that there is a new "Suggestion detail" tab with all the suggestions you created. Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 11:06:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 10:06:49 +0000 Subject: [Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record In-Reply-To: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23591-70-wcYLyHtFbH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95520|0 |1 is obsolete| | --- Comment #13 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 95602 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95602&action=edit Bug 23591: Use same css for suggestion notes Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 11:06:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 10:06:53 +0000 Subject: [Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record In-Reply-To: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23591-70-gGfmitpsK4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95521|0 |1 is obsolete| | --- Comment #14 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 95603 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95603&action=edit Bug 23591: [DO NOT PUSH] CSS Changes Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 11:06:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 10:06:57 +0000 Subject: [Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record In-Reply-To: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23591-70-1QxDyL8XEI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95579|0 |1 is obsolete| | --- Comment #15 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 95604 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95604&action=edit Bug 23591: Hide archived suggestions However we are adding a note on top of the table to tell how many suggestions are archived. It seems that there is no good reason to display the archived suggestions on this table. Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 11:07:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 10:07:27 +0000 Subject: [Koha-bugs] [Bug 23987] batchMod.pl provides a link back to the record after the record is deleted In-Reply-To: <bug-23987-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23987-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23987-70-sJ1lRZ1UKS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23987 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 11:07:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 10:07:30 +0000 Subject: [Koha-bugs] [Bug 23987] batchMod.pl provides a link back to the record after the record is deleted In-Reply-To: <bug-23987-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23987-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23987-70-lFaUk2fVxj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23987 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95605 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95605&action=edit Bug 23987: Use src=CATALOGUING for edition/deletion in batch from items table There are 2 ways to land in batchMod from the detail page of a bib record: from the Edit menu, and the action buttons on top of the items table. We want the same behavior for both and so use src=CATALOGUING It will make batchMod to behave identically for the "return" button -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 11:07:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 10:07:34 +0000 Subject: [Koha-bugs] [Bug 23987] batchMod.pl provides a link back to the record after the record is deleted In-Reply-To: <bug-23987-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23987-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23987-70-Y7jScvXPtG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23987 --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95606 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95606&action=edit Bug 23987: "return to cataloguing" if the record is deleted from bachMod-del If a bibliographic record is deleted after having deleted all their items in a batch, we should not display a "return to the record" button but "return to cataloguing" instead Test plan: 1 - Have/make a bib with items 2 - On details page select Edit->Delete items in a batch 3 - Select all items and check "Delete record if no items remain" 4 - Delete the things 5 - On confirmation screen you have a count of items/bibs deleted => Without the patch there is a 'Return to record' button that leads to nowhere => With this patch there is a "Return to cataloging module" button 6 - Repeat using the "Delete selected items" link on top of the items table => Without the patch there is a 'Return to where you were' button that leads to nowhere => With this patch there is a "Return to cataloging module" button Note that there is a link AND a button, coming from commit 928c0af2b6a2c7aa6ed54019c5bd7dbddbccf4ee Bug 15824 - 'Done' button is unclear on batch item modification and deletion I do not think it makes sense to have both. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 11:13:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 10:13:52 +0000 Subject: [Koha-bugs] [Bug 24070] New: koha_es killed, missing RAM Message-ID: <bug-24070-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24070 Bug ID: 24070 Summary: koha_es killed, missing RAM Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Continuous Integration Assignee: tomascohen at gmail.com Reporter: jonathan.druart at bugs.koha-community.org We have some recent builds failing, the common pattern is: "koha_es_1 exited with code 137" https://jenkins.koha-community.org/job/Koha_Master_U18/477/consoleFull https://jenkins.koha-community.org/job/Koha_Master_D9_My8/20/consoleFull which means koha_es received a SIGKILL caused by a OOM. Could we increase the size of this container please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 11:16:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 10:16:35 +0000 Subject: [Koha-bugs] [Bug 24070] koha_es killed, missing RAM In-Reply-To: <bug-24070-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24070-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24070-70-pHahBp1inl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24070 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Well actually it's the RAM size of the nodes I guess. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 11:30:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 10:30:42 +0000 Subject: [Koha-bugs] [Bug 24070] koha_es killed, missing RAM In-Reply-To: <bug-24070-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24070-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24070-70-RZ3TzgWReA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24070 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Both builds happened on Docker_1, hosted by BWS, Ccing Nick -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 11:42:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 10:42:02 +0000 Subject: [Koha-bugs] [Bug 24053] Typo in FinePaymentAutoPopup description In-Reply-To: <bug-24053-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24053-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24053-70-2qx88iMrVG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24053 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 11:42:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 10:42:05 +0000 Subject: [Koha-bugs] [Bug 24053] Typo in FinePaymentAutoPopup description In-Reply-To: <bug-24053-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24053-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24053-70-Fodac7aGOY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24053 --- Comment #2 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 95607 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95607&action=edit Bug 24053 : Typo in FinePaymentAutoPopup description There is a typo in the FinePaymentAutoPopup system preference description. This bug fixes that. To test: 1) Go to the systems preferences in administration. 2) Search for FinePaymentAutoPopup 3) Observe Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 11:42:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 10:42:18 +0000 Subject: [Koha-bugs] [Bug 24013] Transferring a checked out item gives a software error In-Reply-To: <bug-24013-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24013-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24013-70-kikTGMa5ZL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24013 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|Academy | Status|NEW |ASSIGNED CC| |jonathan.druart at bugs.koha-c | |ommunity.org Severity|minor |major Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Upping severity. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 11:56:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 10:56:23 +0000 Subject: [Koha-bugs] [Bug 24013] Transferring a checked out item gives a software error In-Reply-To: <bug-24013-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24013-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24013-70-pk9rhtgJXp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24013 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 11:56:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 10:56:26 +0000 Subject: [Koha-bugs] [Bug 24013] Transferring a checked out item gives a software error In-Reply-To: <bug-24013-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24013-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24013-70-2Idm1Q9knW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24013 --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95608 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95608&action=edit Bug 24013: Add tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 11:56:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 10:56:30 +0000 Subject: [Koha-bugs] [Bug 24013] Transferring a checked out item gives a software error In-Reply-To: <bug-24013-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24013-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24013-70-Kseo5VEQWd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24013 --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95609 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95609&action=edit Bug 24013: Fix transferbook if item is checked out Wrong conflict resolution, the following commit 6eade474ed3a84a5ba372a26ac27bf9fb4bd2299 Bug 18276: Remove GetBiblioFromItemNumber - Easy ones restored a previous change from commit 546379cc92b733cb29a0b70247a72c770afdad26 Bug 17680: C4::Circulation - Remove GetItemIssue, simple calls Not that "easy" or "simple"... Test plan: Run the test before and after this patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 11:57:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 10:57:31 +0000 Subject: [Koha-bugs] [Bug 20595] EDI: Add support for LRP (Library Rotation Plan) for Koha with Stock Rotation enabled In-Reply-To: <bug-20595-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20595-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20595-70-4gIjD2qgvm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20595 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com Text to go in the| |This enhancement allows release notes| |items to be automatically | |added to rotas at | |acquisition time by using | |the LRP (Library Rotation | |Plan) field in EDI. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 11:58:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 10:58:33 +0000 Subject: [Koha-bugs] [Bug 24013] Transferring a checked out item gives a software error In-Reply-To: <bug-24013-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24013-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24013-70-WY8K1CMcy8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24013 --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Hello Aleisha, I removed the Academy kw and provided 2 patches, a bugfix and the tests to cover the changes. If you need this bug report to use as example, I can obsolete the bugfix and keep the tests. It sounded quite urgent to fix as it impact stable releases. Cheers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 12:01:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 11:01:02 +0000 Subject: [Koha-bugs] [Bug 23470] Elasticsearch - OpacSuppression not implemented in search result In-Reply-To: <bug-23470-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23470-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23470-70-ROAhBnrfAq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23470 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 12:03:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 11:03:55 +0000 Subject: [Koha-bugs] [Bug 24070] koha_es killed, missing RAM In-Reply-To: <bug-24070-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24070-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24070-70-maL1Bt2xuQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24070 --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Note that U18 just ran ok on node 1 https://jenkins.koha-community.org/job/Koha_Master_U18/478/consoleFull -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 12:06:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 11:06:28 +0000 Subject: [Koha-bugs] [Bug 24011] Browser tabs auto close when editing items from report with biblio links In-Reply-To: <bug-24011-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24011-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24011-70-qOhtBhkfzK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24011 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Works ok for me on master and 19.05.x Which exact version of Koha are you using? Which browser (and version)? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 12:08:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 11:08:44 +0000 Subject: [Koha-bugs] [Bug 18729] Librarian unable to update hold pickup library from patron pages without "modify_holds_priority" permission In-Reply-To: <bug-18729-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18729-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18729-70-UWQLYR3xK7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18729 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_target CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 12:22:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 11:22:54 +0000 Subject: [Koha-bugs] [Bug 24010] Number of issues to display to staff accepts non-integer values In-Reply-To: <bug-24010-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24010-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24010-70-Qi2JVTm8a7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24010 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22812 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Same as bug 22812, we must use Koha::Subscription here. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 12:22:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 11:22:54 +0000 Subject: [Koha-bugs] [Bug 22812] Cannot add new subscription with strict SQL modes turned on In-Reply-To: <bug-22812-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22812-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22812-70-VhWkD6WX8y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24010 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 12:27:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 11:27:55 +0000 Subject: [Koha-bugs] [Bug 24010] Number of issues to display to staff accepts non-integer values In-Reply-To: <bug-24010-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24010-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24010-70-bTk95Atju3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24010 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 12:28:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 11:28:39 +0000 Subject: [Koha-bugs] [Bug 24010] Number of issues to display to staff accepts non-integer values In-Reply-To: <bug-24010-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24010-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24010-70-QFxQNdtWQj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24010 --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95610 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95610&action=edit Bug 24010: Use Koha::Subscription in ModSubscription We must use Koha::Subscription instead of raw SQL. It will fix issue with default and integer values. Test plan: Edit a subscription and set number of issues = "f" Save => Without this patch there is a SQL error in the log: Incorrect integer value: 'f' for column 'numberlength' => With this patch the other changes are effective. Note: We also could change the type attribute of the input to "number", to have a client-side check Also, the return value of ModSuggestion is never used, so we are safe with that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 12:46:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 11:46:32 +0000 Subject: [Koha-bugs] [Bug 24011] Browser tabs auto close when editing items from report with biblio links In-Reply-To: <bug-24011-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24011-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24011-70-uoXbzjYhva@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24011 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23680 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Myka Kennedy Stephens from comment #1) > I would also like to add that selecting "edit items" from the edit menu will > force the tab to close. I.e., Follow steps 1-3, then instead of clicking the > edit item button, select "edit items" from the edit menu button. The tab > closes without loading the additem.pl page This has been fixed with bug 23680 - are you on the most recent 19.05 version? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 12:46:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 11:46:32 +0000 Subject: [Koha-bugs] [Bug 23680] Can't open 'Edit items' or 'Add item' links in new tab - tab is closed immediately In-Reply-To: <bug-23680-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23680-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23680-70-9k4bBh1Eci@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23680 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24011 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 13:03:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 12:03:03 +0000 Subject: [Koha-bugs] [Bug 24071] New: Ask for complete information when opening a bug report Message-ID: <bug-24071-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24071 Bug ID: 24071 Summary: Ask for complete information when opening a bug report Change sponsored?: --- Product: Project Infrastructure Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Bugzilla Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org I would like to patch our bug tracker to display a message about which information they need to provide in the description of the bug. * They should give the FULL version number, most of the time they only provide the major version, we will need to point to a link explaining how to get the exact version ("See the about page" I guess) * Check the log on the server (with the full error) * The JS console (if it's a UI issue) * Version of the OS * Version of DBMS (if related) What more? How could it be done to make them retrieve the info easily? Going further, what about a new area in Koha to post an issue, we could retrieve the correct info we need and open a new bug report for them? (but... spam, support companies, too easy and so will skip ML, etc.) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 13:03:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 12:03:41 +0000 Subject: [Koha-bugs] [Bug 24071] Ask for complete information when opening a bug report In-Reply-To: <bug-24071-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24071-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24071-70-tdKA3Hpj7o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24071 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion CC| |katrin.fischer at bsz-bw.de, | |martin.renvoize at ptfs-europe | |.com, | |nick at bywatersolutions.com, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 13:05:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 12:05:34 +0000 Subject: [Koha-bugs] [Bug 24010] Number of issues to display to staff accepts non-integer values In-Reply-To: <bug-24010-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24010-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24010-70-uNAfS5qEt0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24010 --- Comment #3 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> --- This fix doesn't solve the original problem reported plus I'm not able to reproduce the error described in the patch: > Incorrect integer value: 'f' for column 'numberlength' When I edit "Subscription length" field (I assume this is the "number of issues") to "f" Regardless whether this patch is applied I only get in plack-error.log > Use of uninitialized value $sub_on in concatenation (.) or string at /home/koha/kohaclone/serials/subscription-add.pl line 113. > Argument "f" isn't numeric in numeric ne (!=) at /home/koha/kohaclone/serials/subscription-add.pl line 279. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 14:00:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 13:00:17 +0000 Subject: [Koha-bugs] [Bug 24010] Number of issues to display to staff accepts non-integer values In-Reply-To: <bug-24010-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24010-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24010-70-7ojKNbvPjC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24010 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95610|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 14:01:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 13:01:02 +0000 Subject: [Koha-bugs] [Bug 24010] Number of issues to display to staff accepts non-integer values In-Reply-To: <bug-24010-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24010-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24010-70-uWgz68Xz9a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24010 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED Assignee|jonathan.druart at bugs.koha-c |koha-bugs at lists.koha-commun |ommunity.org |ity.org --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Sorry, I read the description too quickly! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 14:01:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 13:01:12 +0000 Subject: [Koha-bugs] [Bug 24010] Number of issues to display to staff accepts non-integer values In-Reply-To: <bug-24010-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24010-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24010-70-51mXiuF1ZV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24010 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 14:04:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 13:04:20 +0000 Subject: [Koha-bugs] [Bug 23064] Cannot edit subscription with strict SQL modes turned on In-Reply-To: <bug-23064-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23064-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23064-70-gQI0fpG0ks@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23064 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22812, | |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24010 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 14:04:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 13:04:20 +0000 Subject: [Koha-bugs] [Bug 22812] Cannot add new subscription with strict SQL modes turned on In-Reply-To: <bug-22812-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22812-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22812-70-0KVaRuXJAk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22812 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23064 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 14:04:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 13:04:20 +0000 Subject: [Koha-bugs] [Bug 24010] Number of issues to display to staff accepts non-integer values In-Reply-To: <bug-24010-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24010-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24010-70-drSAOlJeld@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24010 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23064 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 14:04:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 13:04:43 +0000 Subject: [Koha-bugs] [Bug 23064] Cannot edit subscription with strict SQL modes turned on In-Reply-To: <bug-23064-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23064-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23064-70-VzqkKZbxhO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23064 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17258 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 [Bug 17258] [OMNIBUS] MySQL 5.7 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 14:04:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 13:04:43 +0000 Subject: [Koha-bugs] [Bug 17258] [OMNIBUS] MySQL 5.7 In-Reply-To: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17258-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17258-70-hLjfWFivmk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17258 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23064 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23064 [Bug 23064] Cannot edit subscription with strict SQL modes turned on -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 14:06:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 13:06:48 +0000 Subject: [Koha-bugs] [Bug 23064] Cannot edit subscription with strict SQL modes turned on In-Reply-To: <bug-23064-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23064-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23064-70-16kamz5ryT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23064 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 14:06:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 13:06:52 +0000 Subject: [Koha-bugs] [Bug 23064] Cannot edit subscription with strict SQL modes turned on In-Reply-To: <bug-23064-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23064-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23064-70-VktLqqg7qt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23064 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #90386|0 |1 is obsolete| | Attachment #90387|0 |1 is obsolete| | --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95611 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95611&action=edit Bug 23064: Use Koha::Subscription in ModSubscription We must use Koha::Subscription instead of raw SQL. It will fix issue with default and integer values. Test plan: Edit a subscription and set number of issues = "f" Save => Without this patch there is a SQL error in the log: Incorrect integer value: 'f' for column 'numberlength' => With this patch the other changes are effective. Note: We also could change the type attribute of the input to "number", to have a client-side check Also, the return value of ModSuggestion is never used, so we are safe with that. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 14:07:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 13:07:18 +0000 Subject: [Koha-bugs] [Bug 23064] Cannot edit subscription with strict SQL modes turned on In-Reply-To: <bug-23064-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23064-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23064-70-pdyJQcQ4qQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23064 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 14:14:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 13:14:07 +0000 Subject: [Koha-bugs] [Bug 23365] Data migration from old to new version In-Reply-To: <bug-23365-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23365-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23365-70-ws8LJcTY0d@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23365 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 14:17:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 13:17:04 +0000 Subject: [Koha-bugs] [Bug 9156] itemcallnumber not pulling more than 2 subfields In-Reply-To: <bug-9156-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9156-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9156-70-qM0SFXNTHT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9156 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 14:17:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 13:17:23 +0000 Subject: [Koha-bugs] [Bug 23394] Circulation.t fails when RentalFeesCheckoutConfirmation is set In-Reply-To: <bug-23394-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23394-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23394-70-C4cFLtg27F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23394 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I do not recreate for RentalFeesCheckoutConfirmation. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 14:17:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 13:17:49 +0000 Subject: [Koha-bugs] [Bug 23394] Circulation.t fails when RentalFeesCheckoutConfirmation is set In-Reply-To: <bug-23394-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23394-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23394-70-n86Zp0jNTg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23394 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Nick Clemens from comment #0) > Also, tests die when SearchEngine is Elasticsearch This has been fixed by bug 21985. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 14:25:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 13:25:26 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:.NewsChannels to Koha namespace In-Reply-To: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22544-70-ejT20R80s0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|Needs Signoff |Failed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 14:29:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 13:29:28 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:.NewsChannels to Koha namespace In-Reply-To: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22544-70-mKUOmx9cxh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92010|0 |1 is obsolete| | Attachment #92011|0 |1 is obsolete| | Attachment #92012|0 |1 is obsolete| | --- Comment #29 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95613 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95613&action=edit Bug 22544: Move GetNewsToDisplay to Koha namespace -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 14:29:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 13:29:34 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:.NewsChannels to Koha namespace In-Reply-To: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22544-70-FxngftGPMf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #30 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95614 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95614&action=edit Bug 22544: Add tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 14:29:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 13:29:40 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:.NewsChannels to Koha namespace In-Reply-To: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22544-70-LXaL6kiOTU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #31 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95615 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95615&action=edit Bug 22544: Refactor searching of news items Test plan: 1) Go to tools and define some news 2) Try different parameters, try to edit new items, and delete some 3) Go to all places where news are presented and ensure that there are the right ones shown: opac main page - based on language opac righ column (formerly syspref OpacNavRight) - based on language opac news rss feed circulation slip (not quick slip) intranet main page 4) run tests: prove t/db_dependent/Koha/News.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 14:31:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 13:31:47 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:.NewsChannels to Koha namespace In-Reply-To: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22544-70-yu73KHizVa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #32 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to David Nind from comment #28) > However, the news items don't display where they should - even after a > flush_memcached and restart_all. Can you detail? I see the news on the intranet mainpage. I did see a weird thing: "Lost connection to MySQL server during query" appeared in the logs and the news did not show up. Then I restart_all and everything went fine. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 14:37:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 13:37:20 +0000 Subject: [Koha-bugs] [Bug 23256] fr-CA OPAC_REG_VERIFY has hard-coded http:// In-Reply-To: <bug-23256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23256-70-lG2rhDVUZg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23256 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 14:37:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 13:37:24 +0000 Subject: [Koha-bugs] [Bug 23256] fr-CA OPAC_REG_VERIFY has hard-coded http:// In-Reply-To: <bug-23256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23256-70-V62K7gO8wa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23256 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95616 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95616&action=edit Bug 23256: Remove the http:// prefix before OPACBaseURL in OPAC_REG_VERIFY The title explained everything, compare with installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql and other notices. It's certainly due to the fact that fr-CA took time to be integrated and the change happened in the meanwhile -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 14:38:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 13:38:03 +0000 Subject: [Koha-bugs] [Bug 23256] fr-CA OPAC_REG_VERIFY has hard-coded http:// In-Reply-To: <bug-23256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23256-70-TUvov09rYM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23256 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org Depends on| |14622 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14622 [Bug 14622] Add fr-CA data folder in the web installer -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 14:38:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 13:38:03 +0000 Subject: [Koha-bugs] [Bug 14622] Add fr-CA data folder in the web installer In-Reply-To: <bug-14622-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14622-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14622-70-8UTlKq7cym@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14622 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23256 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23256 [Bug 23256] fr-CA OPAC_REG_VERIFY has hard-coded http:// -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 14:41:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 13:41:28 +0000 Subject: [Koha-bugs] [Bug 23274] t/db_dependent/XISBN.t fails with Elasticsearch In-Reply-To: <bug-23274-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23274-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23274-70-aeymoGwabi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23274 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Maybe a duplicate of bug 23769. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 14:41:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 13:41:33 +0000 Subject: [Koha-bugs] [Bug 23274] t/db_dependent/XISBN.t fails with Elasticsearch In-Reply-To: <bug-23274-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23274-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23274-70-0rUN0sO8ek@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23274 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23769 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 14:41:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 13:41:33 +0000 Subject: [Koha-bugs] [Bug 23769] SearchWithISBNVariations not implemented in Elasticsearch In-Reply-To: <bug-23769-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23769-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23769-70-1L4AYdC9NS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23769 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23274 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 14:45:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 13:45:42 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:.NewsChannels to Koha namespace In-Reply-To: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22544-70-18yL75jvnH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #33 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- OPAC main page, I see: https://snipboard.io/CW4Bep.jpg It does not appear without the patchset. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 14:53:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 13:53:17 +0000 Subject: [Koha-bugs] [Bug 24072] New: Typos in advance_notices.pl causes DUEDGST not to be sent Message-ID: <bug-24072-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24072 Bug ID: 24072 Summary: Typos in advance_notices.pl causes DUEDGST not to be sent Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Notices Assignee: magnus at libriotech.no Reporter: magnus at libriotech.no QA Contact: testopia at bugs.koha-community.org In misc/cronjobs/advance_notices.pl we have this code: 372 if ($digest_per_branch) { 373 while (my ($branchcode, $digests) = each %$upcoming_digest) { 374 send_digests({ 375 sth => $sth_digest, 376 digests => $digests, 377 letter_code => 'PREDUEDGST', 378 branchcode => $branchcode, 379 get_item_info => sub { 380 my $params = shift; 381 $params->{sth}->execute($params->{borrowernumber}, 382 $params->{borrower_preferences}->{'days_in_advance'}); 383 return sub { 384 $params->{sth}->fetchrow_hashref; 385 }; 386 } 387 }); 388 } 389 390 while (my ($branchcode, $digests) = each %$due_digest) { 391 send_digests({ 392 sth => $sth_digest, 393 digest => $due_digest, ### HERE! 394 letter_code => 'DUEDGST', 395 branchcode => $branchcode, 396 get_item_info => sub { 397 my $params = shift; 398 $params->{sth}->execute($params->{borrowernumber}, 0); 399 return sub { 400 $params->{sth}->fetchrow_hashref; 401 }; 402 } 403 }); 404 } 405 } else { 406 send_digests({ 407 sth => $sth_digest, 408 digests => $upcoming_digest, 409 letter_code => 'PREDUEDGST', 410 get_item_info => sub { 411 my $params = shift; 412 $params->{sth}->execute($params->{borrowernumber}, 413 $params->{borrower_preferences}->{'days_in_advance'}); 414 return sub { 415 $params->{sth}->fetchrow_hashref; 416 }; 417 } 418 }); 419 420 send_digests({ 421 sth => $sth_digest, 422 digest => $due_digest, ### AND HERE! 423 letter_code => 'DUEDGST', 424 get_item_info => sub { 425 my $params = shift; 426 $params->{sth}->execute($params->{borrowernumber}, 0); 427 return sub { 428 $params->{sth}->fetchrow_hashref; 429 }; 430 } 431 }); 432 } A typo has crept in on lines 393 and 422, where "digest" should be written "digests", in the same way as it is done in the other two blocks of code. In send_digests() the incoming data is iterated over in this line: 531 PATRON: while ( my ( $borrowernumber, $digest ) = each %{$params->{digests}} ) { but when the data is actually in $params->{digest} they are not found and no DUEDGST messages are queued. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 15:01:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 14:01:54 +0000 Subject: [Koha-bugs] [Bug 23068] Add ability for Koha to handle X-Forwarded-For headers so REMOTE_ADDR features work behind a proxy In-Reply-To: <bug-23068-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23068-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23068-70-mpuwtLum61@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23068 --- Comment #37 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- > Do you now re-run apt install koha-perldeps or anything regularly? That should have caught the debian control change.. also, I presume if you are running such a command then you're also tracking the nightly repository to pickup the very latest changes. It was on a KohaDevBox, I guess the nightly repo wasn't up to date yet. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 15:26:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 14:26:09 +0000 Subject: [Koha-bugs] [Bug 24072] Typos in advance_notices.pl causes DUEDGST not to be sent In-Reply-To: <bug-24072-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24072-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24072-70-oKRctpRNC2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24072 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 15:26:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 14:26:12 +0000 Subject: [Koha-bugs] [Bug 24072] Typos in advance_notices.pl causes DUEDGST not to be sent In-Reply-To: <bug-24072-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24072-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24072-70-jgPBM1eqKl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24072 --- Comment #1 from Magnus Enger <magnus at libriotech.no> --- Created attachment 95617 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95617&action=edit Bug 24072 - Typos in advance_notices.pl causes DUEDGST not to be sent There are two typos in advance_notics.pl that cause DUEDGST messages not to be sent. See Bugzilla for full details. If you think the typo is sufficiently obvious, you can just eyeball the patch and sign off, methinks. Otherwise, testing can be done something like this: - Make sure you have enabled enhanced messaging preferences, and a patron with "Email" and "Digests only" set for "Item due" messages - Issue an item to this patron, with due date today - Run something like this to generate advance notices: $ sudo koha-shell -c "perl \ /home/vagrant/kohaclone/misc/cronjobs/advance_notices.pl -n -c" kohadev - See that no notices are shown (-n means messages will go to stdout, instead of into the message queue). - Apply the patch and run advance_notices.pl again, as before. A DUEDGST message should now be displayed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 15:33:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 14:33:05 +0000 Subject: [Koha-bugs] [Bug 24011] Browser tabs auto close when editing items from report with biblio links In-Reply-To: <bug-24011-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24011-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24011-70-c5hqleVnFS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24011 Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #4 from Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> --- We are on 19.05.04.000. I just tested this on 19.05.04.001, and you are correct that it has been fixed. I will advise our support company that we need a minor point upgrade. Thank you! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 15:40:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 14:40:47 +0000 Subject: [Koha-bugs] [Bug 23276] Don't show tags on tag cloud when tagging is disabled In-Reply-To: <bug-23276-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23276-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23276-70-PTHo421T91@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23276 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Severity|minor |normal Version|18.11 |master Assignee|oleonard at myacpl.org |jonathan.druart at bugs.koha-c | |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 15:44:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 14:44:03 +0000 Subject: [Koha-bugs] [Bug 23276] Don't show tags on tag cloud when tagging is disabled In-Reply-To: <bug-23276-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23276-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23276-70-HdjSFSAjqt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23276 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 15:44:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 14:44:06 +0000 Subject: [Koha-bugs] [Bug 23276] Don't show tags on tag cloud when tagging is disabled In-Reply-To: <bug-23276-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23276-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23276-70-GW5KyFokLS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23276 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95618 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95618&action=edit Bug 23276: Do not display tag if pref TagsEnabled is off If the pref TagsEnabled is off we should not display the tags at the OPAC. There is a message to tell that tags system is disabled, but the tags are displayed. This patch introduces the blocking_errors include file at the OPAC. Test plan: - Turn TagsEnabled on - Add some tags - Turn TagsEnabled off - Hit /cgi-bin/koha/opac-tags.pl => Without this patch you see a warning messaging saying that the tag system is disabled, but the tags are displayed => With this patch you see a (ugly) short screen saying that the tag system is disabled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 15:46:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 14:46:33 +0000 Subject: [Koha-bugs] [Bug 23287] JS Console Errors on Memberentry In-Reply-To: <bug-23287-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23287-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23287-70-14Fam6MB54@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23287 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Can you detail? On cgi-bin/koha/members/memberentry.pl?op=add&categorycode=PT I do not see anything in the console. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 15:57:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 14:57:33 +0000 Subject: [Koha-bugs] [Bug 23213] Add hook to OPAC payments to allow plugins to set minimum payment threshold In-Reply-To: <bug-23213-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23213-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23213-70-K40fCZxltX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23213 --- Comment #14 from Agustín Moyano <agustinmoyano at theke.io> --- (In reply to Martin Renvoize from comment #13) > We certainly should, well spotted Katrin. Agustin, could you take care of > adding this? Thanks Katrin for spotting it. Hook description was added. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 16:02:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 15:02:42 +0000 Subject: [Koha-bugs] [Bug 23924] Add a parameter to the script add_date_fields_to_marc_records.pl to specify a date field In-Reply-To: <bug-23924-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23924-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23924-70-eUDyTDjF72@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23924 --- Comment #2 from Hugo Agud <hagud at orex.es> --- I am testing the patch and It works fine but I have a doubt regarding the where clausule... according the help it claims that where limit the search, but I guess the where clausule doens't affect on the search.... becuase it takes the same time using and non usiing where clausule I guess where is limiting where the perl applies the action, not limiting the the bibs to check and apply, right? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 16:03:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 15:03:17 +0000 Subject: [Koha-bugs] [Bug 23318] False error about missing budget on neworderbiblio.pl In-Reply-To: <bug-23318-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23318-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23318-70-GymZvkIo4L@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23318 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Which error am I supposed to see? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 16:11:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 15:11:45 +0000 Subject: [Koha-bugs] [Bug 23239] install.pl: DBD::mysql::st execute failed: Incorrect integer value In-Reply-To: <bug-23239-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23239-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23239-70-2DCdbzajyR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23239 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |jonathan.druart at bugs.koha-c | |ommunity.org Resolution|--- |DUPLICATE --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Fixed on bug 22919. *** This bug has been marked as a duplicate of bug 22919 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 16:11:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 15:11:45 +0000 Subject: [Koha-bugs] [Bug 22919] Authorities MARC Structure not inserted with SQL strict modes In-Reply-To: <bug-22919-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22919-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22919-70-bcCdE7u7py@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22919 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ashwinloyal at gmail.com --- Comment #28 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- *** Bug 23239 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 16:13:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 15:13:06 +0000 Subject: [Koha-bugs] [Bug 19324] New Inventory workflow eliminates "mark item seen" and doesn't show data in table In-Reply-To: <bug-19324-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19324-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19324-70-fUimxzlHwV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19324 Sally <sally.healey at cheshiresharedservices.gov.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |sally.healey at cheshireshared | |services.gov.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 16:16:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 15:16:28 +0000 Subject: [Koha-bugs] [Bug 23241] Does misc/bin/koha-index-daemon-ctl.sh still belong in community koha? In-Reply-To: <bug-23241-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23241-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23241-70-bBgXYBFmBX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23241 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Depends on| |8519 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8519 [Bug 8519] Make koha-index-daemon run on startup -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 16:16:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 15:16:28 +0000 Subject: [Koha-bugs] [Bug 8519] Make koha-index-daemon run on startup In-Reply-To: <bug-8519-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8519-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8519-70-Wveuf0GA7q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8519 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23241 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23241 [Bug 23241] Does misc/bin/koha-index-daemon-ctl.sh still belong in community koha? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 16:21:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 15:21:53 +0000 Subject: [Koha-bugs] [Bug 23924] Add a parameter to the script add_date_fields_to_marc_records.pl to specify a date field In-Reply-To: <bug-23924-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23924-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23924-70-xguImPHnw4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23924 --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Hugo Agud from comment #2) > I am testing the patch and It works fine but I have a doubt regarding the > where clausule... according the help it claims that where limit the search, > but I guess the where clausule doens't affect on the search.... becuase it > takes the same time using and non usiing where clausule > > I guess where is limiting where the perl applies the action, not limiting > the the bibs to check and apply, right? It should, if you have biblionumbers from 1 to 1000 and the --where is biblionumber < 500, then only the first 500 records will be processed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 17:05:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 16:05:01 +0000 Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation' (bug 11373) In-Reply-To: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22359-70-l8KDGBp9ox@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95619 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95619&action=edit Bug 22359: Improvements to payment collection inputs This patch attempts to clarify the uses of the various input fields on the paycollect screens. It does this by adding validation to the form such that entering a 'collected' value that is lower than the 'paid' value is now forbidden. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 17:20:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 16:20:17 +0000 Subject: [Koha-bugs] [Bug 21574] Local use system preferences page doesn't have the system preferences menu In-Reply-To: <bug-21574-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21574-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21574-70-EdhC4xEZey@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21574 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95583|0 |1 is obsolete| | Attachment #95592|0 |1 is obsolete| | --- Comment #5 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- Created attachment 95620 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95620&action=edit Bug 21574 : Local use system preferences page doesn't have the system preferences menu The "local use" tab in system preferences is showing the admin menu instead of the system preferences menu tabs. This patch fixes the menu display. To test: 1) Go to the system preferences in administration. 2) Click the 'Local use' tab. 3) Observe the inncorrect menu. 4) Apply the patch. 5) Repeat steps 1-2 6) Observe the correct menu. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 17:21:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 16:21:10 +0000 Subject: [Koha-bugs] [Bug 21574] Local use system preferences page doesn't have the system preferences menu In-Reply-To: <bug-21574-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21574-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21574-70-9Lrdf9Y4Ui@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21574 --- Comment #6 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- I hope I did this correctly, I couldn't find Severine's sign-off line in my commit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 17:21:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 16:21:41 +0000 Subject: [Koha-bugs] [Bug 24073] New: Allow suggestion management page to default to all libraries Message-ID: <bug-24073-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24073 Bug ID: 24073 Summary: Allow suggestion management page to default to all libraries Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Acquisitions Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When looking at purchase suggestions on suggestion.pl, the default behavior is to show only suggestions for the branch one is logged in at. This can result in overlooked suggestions, especially for libraries that have more than once branch but process all suggestions at a single location. It would be good to have the option of making this page default to showing suggestions for all libraries. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 17:28:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 16:28:55 +0000 Subject: [Koha-bugs] [Bug 24073] Allow suggestion management page to default to all libraries In-Reply-To: <bug-24073-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24073-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24073-70-fELSw6rT53@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24073 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14830 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 17:28:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 16:28:55 +0000 Subject: [Koha-bugs] [Bug 14830] anonymous purchase suggestions are invisible/inaccessible in staff interface In-Reply-To: <bug-14830-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14830-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14830-70-eX3oOEG8pN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14830 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24073 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 17:40:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 16:40:01 +0000 Subject: [Koha-bugs] [Bug 13100] Search results with publication date limit give no results for next page of results In-Reply-To: <bug-13100-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13100-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13100-70-gzgTz0lSaQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13100 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #3 from Owen Leonard <oleonard at myacpl.org> --- This doesn't appear to be an issue anymore. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 17:41:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 16:41:40 +0000 Subject: [Koha-bugs] [Bug 4330] Copyright statements out of date In-Reply-To: <bug-4330-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-4330-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4330-70-lMS8qQMOyD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4330 --- Comment #47 from Owen Leonard <oleonard at myacpl.org> --- Should this bug remain open and assigned? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 17:42:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 16:42:42 +0000 Subject: [Koha-bugs] [Bug 24074] New: Access directory UX improvements Message-ID: <bug-24074-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24074 Bug ID: 24074 Summary: Access directory UX improvements Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: wizzyrea at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com I noticed a few things about this feature when I was setting it up (which by the way, I LIKE A LOT!!) - We cannot do subdirectories here. We should allow that? - Multiple access directories don't show the path, that seems like useful information we should have - either we should pick the directory we want before we see the list, or we should show the path to the file. An example of a use case would be that a library wants to put their print notices there, but they also put other things in that access directory. They may only want to see the directory that has the notices in it. Currently we can't do that. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 17:45:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 16:45:02 +0000 Subject: [Koha-bugs] =?utf-8?q?=5BBug_9874=5D_Adding_subfield_=C2=ABamper?= =?utf-8?q?sand=C2=BB_produce_unexpected_behaviours?= In-Reply-To: <bug-9874-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9874-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9874-70-3HWC8uMeh5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9874 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #8 from Owen Leonard <oleonard at myacpl.org> --- This appears to have been fixed, presumably via the extensive work we've done to properly escape variables. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 18:09:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 17:09:36 +0000 Subject: [Koha-bugs] [Bug 23924] Add a parameter to the script add_date_fields_to_marc_records.pl to specify a date field In-Reply-To: <bug-23924-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23924-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23924-70-JCaozK6wkg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23924 Hugo Agud <hagud at orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 18:09:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 17:09:38 +0000 Subject: [Koha-bugs] [Bug 23924] Add a parameter to the script add_date_fields_to_marc_records.pl to specify a date field In-Reply-To: <bug-23924-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23924-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23924-70-mt1fDUxbKP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23924 Hugo Agud <hagud at orex.es> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94860|0 |1 is obsolete| | --- Comment #4 from Hugo Agud <hagud at orex.es> --- Created attachment 95621 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95621&action=edit Bug 23924: Add --date-field to add_date_fields_to_marc_records.pl The date used in the script will use this parameter, instead of today. Test plan: Use the POD of the script to understand how this flag works. Then use the script to create fields with a date contained in a specific MARC field. Signed-off-by: Hugo Agud <hagud at orex.es> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 18:18:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 17:18:17 +0000 Subject: [Koha-bugs] [Bug 9993] On editing basket group delivery place resets to logged in branch In-Reply-To: <bug-9993-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9993-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9993-70-ngOtn7X6cv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9993 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Status|NEW |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 18:19:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 17:19:58 +0000 Subject: [Koha-bugs] [Bug 24074] Access directory UX improvements In-Reply-To: <bug-24074-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24074-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24074-70-PoFqPvkK9d@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24074 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |wizzyrea at gmail.com --- Comment #1 from Liz Rea <wizzyrea at gmail.com> --- Also the ability to delete files from this directory from the UI. >.< that'd be really nice. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 18:20:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 17:20:17 +0000 Subject: [Koha-bugs] [Bug 9993] On editing basket group delivery place resets to logged in branch In-Reply-To: <bug-9993-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9993-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9993-70-yRktMZunD9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9993 --- Comment #6 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 95622 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95622&action=edit Bug 9993: On editing basket group delivery place resets to logged in branch Bug 9993: On editing basket group delivery place resets to logged in branch This patch modifies basketgroups.pl so that existing data about a basket group's billing and delivery place are correctly pre-selected in the edit form. These fields shouldn't reset to the logged-in user's home branch just because they have an empty value. To test, apply the patch and go to Acquisitions -> Vendor -> Basket groups. When adding or editing a basket group the pre-selected value for "Billing place" and "Delivery place" should be correct: - When creating a new basket group: The logged-in user's library should be pre-selected. - When editing a basket group which has a library defined for either the billing or delivery places, the correct library should be pre-selected. - When editing a basket group which has no library defined for either the billing or delivery place there should be no library pre-selected (the "--" option should be pre-selected). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 18:20:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 17:20:33 +0000 Subject: [Koha-bugs] [Bug 9993] On editing basket group delivery place resets to logged in branch In-Reply-To: <bug-9993-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9993-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9993-70-LtAAr692sm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9993 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 18:25:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 17:25:35 +0000 Subject: [Koha-bugs] [Bug 11698] Add validity check for amount on budget page In-Reply-To: <bug-11698-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11698-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11698-70-RI8cQsVTGD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11698 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #3 from Owen Leonard <oleonard at myacpl.org> --- This appears to be fixed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 18:32:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 17:32:22 +0000 Subject: [Koha-bugs] [Bug 12097] replace cover replaces all covers In-Reply-To: <bug-12097-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12097-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12097-70-hB6H4KnQuo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12097 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- (In reply to Owen Leonard from comment #1) > Do you think this continues to be a point of confusion? I guess not! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 18:33:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 17:33:50 +0000 Subject: [Koha-bugs] [Bug 12516] The module C4::Tags needs more unit tests In-Reply-To: <bug-12516-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12516-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12516-70-WvZOx2GuR0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12516 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 18:38:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 17:38:24 +0000 Subject: [Koha-bugs] [Bug 12757] Integers in saved SQL report ODT export prepended with single quote In-Reply-To: <bug-12757-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12757-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12757-70-ggNdKDBH9B@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12757 --- Comment #4 from Owen Leonard <oleonard at myacpl.org> --- This bug is still valid in master as of 2019-11. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 18:39:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 17:39:12 +0000 Subject: [Koha-bugs] [Bug 23680] Can't open 'Edit items' or 'Add item' links in new tab - tab is closed immediately In-Reply-To: <bug-23680-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23680-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23680-70-dU0loDDISS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23680 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This fixes a problem where release notes| |the pop-up window or tab | |immediately closes when | |attempting to edit or add a | |bibliographic item. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 18:44:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 17:44:16 +0000 Subject: [Koha-bugs] [Bug 24061] Print List (opac-shelves.pl) broken in Chrome In-Reply-To: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24061-70-opky42t9g1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24061 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 18:44:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 17:44:18 +0000 Subject: [Koha-bugs] [Bug 24061] Print List (opac-shelves.pl) broken in Chrome In-Reply-To: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24061-70-ukJXFQ0wPg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24061 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95589|0 |1 is obsolete| | --- Comment #10 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 95623 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95623&action=edit Bug 24061: Close the window after the page has been printed Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 18:45:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 17:45:58 +0000 Subject: [Koha-bugs] [Bug 24061] Print List (opac-shelves.pl) broken in Chrome In-Reply-To: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24061-70-hCb0Qvrbkl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24061 --- Comment #11 from Lucas Gass <lucas at bywatersolutions.com> --- Jonathan, Yes this seems better to me and works perfect. Obsoleted my patch and SO'd on yours. Thanks so much. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 18:50:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 17:50:54 +0000 Subject: [Koha-bugs] [Bug 20936] Holds History for patrons in OPAC In-Reply-To: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20936-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20936-70-LynH0QNhcf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20936 George Williams (NEKLS) <george at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 18:55:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 17:55:12 +0000 Subject: [Koha-bugs] [Bug 12936] Road type value doesn't appear in OPAC borrower account In-Reply-To: <bug-12936-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12936-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12936-70-Dy7lYikQBp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12936 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Still valid in master as of 2019-11 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 19:04:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 18:04:57 +0000 Subject: [Koha-bugs] [Bug 13013] Selecting too many items in a batch hold operation triggers a strange error In-Reply-To: <bug-13013-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13013-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13013-70-Bi3ezENy2o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13013 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- This report appears to be obsolete. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 19:07:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 18:07:11 +0000 Subject: [Koha-bugs] [Bug 13830] Improve OPAC, by adding more html 'id' values to markup In-Reply-To: <bug-13830-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13830-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13830-70-kEvKnFfbWU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13830 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- With no activity on this bug report I'm going to close it and ask that individual changes be tracked in separate reports. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 19:12:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 18:12:48 +0000 Subject: [Koha-bugs] [Bug 14336] SCO: Move embedded JavaScript from sco-main.tt to new sco.js file In-Reply-To: <bug-14336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14336-70-K1WIy6eSxP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14336 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|SCO: Move embedded Jscript |SCO: Move embedded |code from sco-main.tt to |JavaScript from sco-main.tt |new sco.js file |to new sco.js file -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 19:14:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 18:14:30 +0000 Subject: [Koha-bugs] [Bug 17105] Do not see checkouts in the table of circulation.pl In-Reply-To: <bug-17105-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17105-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17105-70-mVyQYuCRLe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17105 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 19:19:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 18:19:45 +0000 Subject: [Koha-bugs] [Bug 13061] filters on invoices not clearing after results found In-Reply-To: <bug-13061-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13061-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13061-70-md9stv3NDQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13061 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 19:21:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 18:21:04 +0000 Subject: [Koha-bugs] [Bug 13061] filters on invoices not clearing after results found In-Reply-To: <bug-13061-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13061-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13061-70-6KXFm7rfq5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13061 Suzanne Fayle <sfayle at roseman.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|sfayle at roseman.edu | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 19:22:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 18:22:53 +0000 Subject: [Koha-bugs] [Bug 21220] Google Books covers are using zoom-5 which displays title page instead of cover In-Reply-To: <bug-21220-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21220-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21220-70-0FZDdxXuFe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21220 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- This appears to have been resolved on Google's end. Koha still sends the zoom=5 parameter but I'm not seeing any problems with the covers. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 19:32:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 18:32:47 +0000 Subject: [Koha-bugs] [Bug 18765] Bad cardnumber causes 'Borrower' search to fail In-Reply-To: <bug-18765-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18765-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18765-70-TCLznaEjbw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18765 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #4 from Owen Leonard <oleonard at myacpl.org> --- I'm not able to save a card number with a tab character, so I think this can be considered fixed. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 20:03:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 19:03:20 +0000 Subject: [Koha-bugs] [Bug 13955] 'Processing...' message out of place In-Reply-To: <bug-13955-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13955-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13955-70-S6DvmRaz5G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13955 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- I can't reproduce this error in master. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 20:11:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 19:11:07 +0000 Subject: [Koha-bugs] [Bug 16292] Allowtoomanyoverride - Don't allow does not give any message In-Reply-To: <bug-16292-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16292-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16292-70-GiPXnDqY7p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16292 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- I cannot reproduce this issue in master. Attempting to check out over the limit does give a message: "Too many checked out. XX checked out, only X are allowed." -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 20:21:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 19:21:06 +0000 Subject: [Koha-bugs] [Bug 17326] Koha not asking if the book is to be renewed when max book limit is reached In-Reply-To: <bug-17326-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17326-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17326-70-QCZTzglLSD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17326 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- I cannot reproduce this issue in master. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 20:23:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 19:23:03 +0000 Subject: [Koha-bugs] [Bug 17422] Holds amount per record produce error In-Reply-To: <bug-17422-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17422-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17422-70-1rQ5o5Y1I3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17422 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- I cannot reproduce this problem in master. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 20:51:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 19:51:23 +0000 Subject: [Koha-bugs] [Bug 21328] Purchase Suggestions View by Hierarchical Group In-Reply-To: <bug-21328-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21328-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21328-70-x0hvXt0vTe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21328 Lisette Scheer <lisetteslatah at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24073 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 20:51:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 19:51:23 +0000 Subject: [Koha-bugs] [Bug 24073] Allow suggestion management page to default to all libraries In-Reply-To: <bug-24073-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24073-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24073-70-WSWZklvHkK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24073 Lisette Scheer <lisetteslatah at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=21328 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 20:52:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 19:52:25 +0000 Subject: [Koha-bugs] [Bug 24071] Ask for complete information when opening a bug report In-Reply-To: <bug-24071-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24071-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24071-70-VGx7OqpC5d@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24071 Lisette Scheer <lisetteslatah at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 21:02:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 20:02:49 +0000 Subject: [Koha-bugs] [Bug 21296] suspend hold ignores system preference on intranet In-Reply-To: <bug-21296-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21296-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21296-70-TVbpLkY0YX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21296 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Version|17.11 |master Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 21:06:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 20:06:09 +0000 Subject: [Koha-bugs] [Bug 24075] New: Backdating a return to the exact due date and time results in the fine not being refunded Message-ID: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24075 Bug ID: 24075 Summary: Backdating a return to the exact due date and time results in the fine not being refunded Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: bwsdonna at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When you use the date picker or book drop mode and check in an item that is due on that date, a fine is assessed and not refunded. For example: item 12345 is due on 11/19/2109 23:59. On 11/20/2019 I check the item in using date picker/book drop setting the check in date to 11/19/2019 23:59, the patron is charged a fine, and the fine is not cleared as would be expected, since the item is being checked in before it is overdue. Confirmed as a problem in master by kidclamp and khall. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 21:17:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 20:17:26 +0000 Subject: [Koha-bugs] [Bug 21296] suspend hold ignores system preference on intranet In-Reply-To: <bug-21296-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21296-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21296-70-sMHCEiqR8W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21296 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 21:17:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 20:17:29 +0000 Subject: [Koha-bugs] [Bug 21296] suspend hold ignores system preference on intranet In-Reply-To: <bug-21296-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21296-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21296-70-QGmPn5Q8Gp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21296 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 95624 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95624&action=edit Bug 21296: suspend hold ignores system preference on intranet This patch modifies the DataTable configuration for the table of holds which displays under the "Holds" tab on the patron's checkout and details pages. A variable is now defined in the JavaScript with the value of the "SuspendHoldsIntranet" system preference. This variable is passed to the DataTable configuration to determine whether the column is visible or not. One of the changes made in this patch moves a <script> block so that it appears before some of the JS includes on the page. This helps keep the string-defining JS together in one block. To test, apply the patch and set the "SuspendHoldsIntranet" system preference to "Allow." - Open the checkout page for a patron with one or more holds. - Under the "Holds" tab, the table of holds should have a "Suspend" column with controls for suspending or resuming holds. - Check that the same is true on the patron detail page. - Set the "SuspendHoldsIntranet" system preference to "Don't allow." - Test the checkout and detail pages again and confirm that the "Suspend" column does not appear. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 21:19:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 20:19:40 +0000 Subject: [Koha-bugs] [Bug 24075] Backdating a return to the exact due date and time results in the fine not being refunded In-Reply-To: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24075-70-P9i6qO9Wpm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24075 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 21:19:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 20:19:48 +0000 Subject: [Koha-bugs] [Bug 24075] Backdating a return to the exact due date and time results in the fine not being refunded In-Reply-To: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24075-70-u72OgRZRda@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24075 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 95625 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95625&action=edit Bug 24075: Backdating a return to the exact due date and time results in the fine not being refunded When you use the date picker or book drop mode and check in an item that is due on that date, a fine is assessed and not refunded. For example: item 12345 is due on 11/19/2109 23:59. On 11/20/2019 I check the item in using date picker/book drop setting the check in date to 11/19/2019 23:59, the patron is charged a fine, and the fine is not cleared as would be expected, since the item is being checked in before it is overdue. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 21:21:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 20:21:56 +0000 Subject: [Koha-bugs] [Bug 24075] Backdating a return to the exact due date and time results in the fine not being refunded In-Reply-To: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24075-70-aXpT6PW0Qb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24075 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95625|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 95626 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95626&action=edit Bug 24075: Backdating a return to the exact due date and time results in the fine not being refunded When you use the date picker or book drop mode and check in an item that is due on that date, a fine is assessed and not refunded. For example: item 12345 is due on 11/19/2109 23:59. On 11/20/2019 I check the item in using date picker/book drop setting the check in date to 11/19/2019 23:59, the patron is charged a fine, and the fine is not cleared as would be expected, since the item is being checked in before it is overdue. Test Plan: 1) Back date a checkout so it is overdue 2) Run fines.pl to generate the fine 3) Return the item, backdating to the same date/time is was due 4) Note the fine was not removed 5) Apply this patch 6) Repeat steps 1-3 7) Fine should be zeroed out now! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 23:10:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 22:10:40 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:.NewsChannels to Koha namespace In-Reply-To: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22544-70-BSsMgmWxvZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 23:10:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 22:10:43 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:.NewsChannels to Koha namespace In-Reply-To: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22544-70-MNdRnfQYsz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92005|0 |1 is obsolete| | --- Comment #34 from David Nind <david at davidnind.com> --- Created attachment 95627 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95627&action=edit Bug 22544: Move get_opac_new to Koha namespace Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 23:10:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 22:10:46 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:.NewsChannels to Koha namespace In-Reply-To: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22544-70-oV6QcaMrQa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92006|0 |1 is obsolete| | --- Comment #35 from David Nind <david at davidnind.com> --- Created attachment 95628 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95628&action=edit Bug 22544: Move get_opac_news to Koha namespace Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 23:10:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 22:10:50 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:.NewsChannels to Koha namespace In-Reply-To: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22544-70-6AlOwRmkOz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92007|0 |1 is obsolete| | --- Comment #36 from David Nind <david at davidnind.com> --- Created attachment 95629 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95629&action=edit Bug 22544: Move del_opac_new to Koha namespace Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 23:10:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 22:10:54 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:.NewsChannels to Koha namespace In-Reply-To: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22544-70-CmGeVkoPjz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92008|0 |1 is obsolete| | --- Comment #37 from David Nind <david at davidnind.com> --- Created attachment 95630 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95630&action=edit Bug 22544: Move upd_opac_new to Koha namespace Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 23:10:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 22:10:57 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:.NewsChannels to Koha namespace In-Reply-To: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22544-70-PyaEx54MCn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92009|0 |1 is obsolete| | --- Comment #38 from David Nind <david at davidnind.com> --- Created attachment 95631 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95631&action=edit Bug 22544: Move add_opac_item to Koha namespace Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 23:11:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 22:11:01 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:.NewsChannels to Koha namespace In-Reply-To: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22544-70-kwr82o859a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95613|0 |1 is obsolete| | --- Comment #39 from David Nind <david at davidnind.com> --- Created attachment 95632 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95632&action=edit Bug 22544: Move GetNewsToDisplay to Koha namespace Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 23:11:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 22:11:05 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:.NewsChannels to Koha namespace In-Reply-To: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22544-70-O4nAQYU2PQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95614|0 |1 is obsolete| | --- Comment #40 from David Nind <david at davidnind.com> --- Created attachment 95633 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95633&action=edit Bug 22544: Add tests Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 23:11:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 22:11:09 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:.NewsChannels to Koha namespace In-Reply-To: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22544-70-8CQ5T4NMcm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95615|0 |1 is obsolete| | --- Comment #41 from David Nind <david at davidnind.com> --- Created attachment 95634 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95634&action=edit Bug 22544: Refactor searching of news items Test plan: 1) Go to tools and define some news 2) Try different parameters, try to edit new items, and delete some 3) Go to all places where news are presented and ensure that there are the right ones shown: opac main page - based on language opac righ column (formerly syspref OpacNavRight) - based on language opac news rss feed circulation slip (not quick slip) intranet main page 4) run tests: prove t/db_dependent/Koha/News.t Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 23:17:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 22:17:37 +0000 Subject: [Koha-bugs] [Bug 22544] Move C4:.NewsChannels to Koha namespace In-Reply-To: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22544-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22544-70-VJEyrq07ZK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22544 --- Comment #42 from David Nind <david at davidnind.com> --- Hi Jonathan. Figured out why the news items weren't displaying - I was picking today's date when adding, and my local machine time was ahead of koha-testing-docker. Changed date to an early one to resolve this. The only thing I noticed was the filter for 'Display location'. If you select the Librarian Interface there are no results. However, this was happening before the patches were applied. I can create a new bug for this. David -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 20 23:38:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 22:38:50 +0000 Subject: [Koha-bugs] [Bug 18132] Confirming a hold/transfer clears checkin history In-Reply-To: <bug-18132-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18132-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18132-70-ulk2cCgDgh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18132 Martha Fuerst <mfuerst at hmcpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mfuerst at hmcpl.org --- Comment #3 from Martha Fuerst <mfuerst at hmcpl.org> --- Cancelling a hold via the hold modal on check in triggers this issue as well. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 00:03:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 23:03:36 +0000 Subject: [Koha-bugs] [Bug 19793] Add a field for email in batch patron modification In-Reply-To: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19793-70-p5naXlD0Jv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793 David Roberts <david.roberts at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|david.roberts at ptfs-europe.c |testopia at bugs.koha-communit |om |y.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 00:03:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 23:03:58 +0000 Subject: [Koha-bugs] [Bug 19793] Add a field for email in batch patron modification In-Reply-To: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19793-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19793-70-paPV6E3jd2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19793 David Roberts <david.roberts at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |david.roberts at ptfs-europe.c |ity.org |om -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 00:04:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 23:04:36 +0000 Subject: [Koha-bugs] [Bug 24024] Holds Awaiting Pickup (Both Active and Expired) Sorts by Firstname In-Reply-To: <bug-24024-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24024-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24024-70-aOjjClR9RL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24024 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95347|0 |1 is obsolete| | --- Comment #4 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 95635 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95635&action=edit Bug 24024: Invert names on halds waiting report Signed-off-by: Rhonda Kuiper <rkuiper at roundrocktexas.gov> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 00:05:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 23:05:10 +0000 Subject: [Koha-bugs] [Bug 24024] Holds Awaiting Pickup (Both Active and Expired) Sorts by Firstname In-Reply-To: <bug-24024-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24024-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24024-70-2VHJd8yCeU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24024 rkuiper at roundrocktexas.gov changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |rkuiper at roundrocktexas.gov Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 00:15:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 23:15:10 +0000 Subject: [Koha-bugs] [Bug 20948] Item-level hold info displayed regardless its priority (detail.pl) In-Reply-To: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20948-70-OtbCcc2hH5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95476|0 |1 is obsolete| | --- Comment #9 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 95636 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95636&action=edit Bug 20948: Simplify existing code No changes expected here. Signed-off-by: Lisette Scheer <lisetteslatah at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 00:15:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 23:15:13 +0000 Subject: [Koha-bugs] [Bug 20948] Item-level hold info displayed regardless its priority (detail.pl) In-Reply-To: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20948-70-fQSes7HSWn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95477|0 |1 is obsolete| | --- Comment #10 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 95637 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95637&action=edit Bug 20948: Only display item-level hold info if first hold On the item list of the catalogue detail page we display next item-level hold info even if it is not the next hold. That leads to confusion as it will not necessarily be the accurate info. This patch makes the following changes: - Display the item-level hold only if it is the next hold (priority == 1) - Display "There is an item level hold on this item (priority=X)" if there is at least 1 item-level hold placed on this item Test plan: - Place several next available holds on a single item record - Place an item level hold on the item - Go the the biblio detail page => Without this patch, the item will show the item level hold => With the patch you see "There is an item level hold on this item" - Check the item in, confirm the hold => No changes, the item will show the waiting hold info - Cancel all the holds except the item-level one => No changes, the item will how the item-level one Signed-off-by: Lisette Scheer <lisetteslatah at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 00:15:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 23:15:35 +0000 Subject: [Koha-bugs] [Bug 20948] Item-level hold info displayed regardless its priority (detail.pl) In-Reply-To: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20948-70-ECQeGNR6ut@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 Lisette Scheer <lisetteslatah at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 00:45:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 23:45:07 +0000 Subject: [Koha-bugs] [Bug 23276] Don't show tags on tag cloud when tagging is disabled In-Reply-To: <bug-23276-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23276-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23276-70-0q7pBBztOw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23276 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com --- Comment #2 from David Nind <david at davidnind.com> --- When I apply the patch, but leave TagsEnabled enabled I get this message when accessing the page: response = { added: 0, deleted: 0, errors: 0 }; When I disable TagsEnabled I get a long page of error messages starting with: Can't call method "param" on an undefined value at /kohadevbox/koha/C4/Output.pm line 363 in C4::Output::output_and_exit at /kohadevbox/koha/C4/Output.pm line 363 360: 361: sub output_and_exit { 362: my ( $query, $cookie, $template, $error ) = @_; 363: $template->param( blocking_error => $error ); 364: output_html_with_http_headers ( $query, $cookie, $template->output ); 365: exit; 366: } Hide function arguments $_[0] 'CGI=HASH(0x559b4b806d98)' $_[1] undef $_[2] undef $_[3] 'tags_disabled' in (eval) at /kohadevbox/koha/opac/opac-tags.pl line 121 118: } 119: 120: 121: output_and_exit( $query, $cookie, $template, 'tags_disabled' ) 122: unless C4::Context->preference('TagsEnabled'); 123: 124: if ($add_op) { -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 00:51:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 20 Nov 2019 23:51:29 +0000 Subject: [Koha-bugs] [Bug 16102] Import batch into catalog very slow In-Reply-To: <bug-16102-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16102-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16102-70-tNw9oqu9zV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16102 Suresh Kumar <tejoskumar at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |BLOCKED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 01:59:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 00:59:31 +0000 Subject: [Koha-bugs] [Bug 23732] Hold rules checker: show matched rules and syspref values to help understand why a hold is possible or not In-Reply-To: <bug-23732-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23732-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23732-70-3YyWHibbmB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 --- Comment #8 from Owen Leonard <oleonard at myacpl.org> --- Overall this looks really good--and really useful! I see a few instances of "TODO" in the changes. Are these things which need a follow-up? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 02:13:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 01:13:21 +0000 Subject: [Koha-bugs] [Bug 24076] New: Remove inline CSS to center patron home library in search results Message-ID: <bug-24076-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24076 Bug ID: 24076 Summary: Remove inline CSS to center patron home library in search results Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Depends on: 9811 The DataTables configuration for patron search results adds inline CSS to center the contents of column #5, currently patron library. I'm not sure if other data was originally targeted by the #5 column, but I don't think it makes sense logically or visually to center the library in the table. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 [Bug 9811] Patrons search improvements -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 02:13:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 01:13:21 +0000 Subject: [Koha-bugs] [Bug 9811] Patrons search improvements In-Reply-To: <bug-9811-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9811-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9811-70-eKFSPyFJfc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9811 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24076 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24076 [Bug 24076] Remove inline CSS to center patron home library in search results -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 02:16:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 01:16:12 +0000 Subject: [Koha-bugs] [Bug 24076] Remove inline CSS to center patron home library in search results In-Reply-To: <bug-24076-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24076-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24076-70-quinaMuSWU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24076 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 02:16:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 01:16:14 +0000 Subject: [Koha-bugs] [Bug 24076] Remove inline CSS to center patron home library in search results In-Reply-To: <bug-24076-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24076-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24076-70-aPHEjDTBpY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24076 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 95638 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95638&action=edit Bug 24076: Remove inline CSS to center patron home library in search results This patch removes code from the patron search results DataTable configuration which was designed to add "text-align:center" to the table cells containing patron home library. I don't think there's a good reason to centering to that data. To test, apply the patch and perform a patron search in the staff client. The "Library" column should contain left-aligned data, matching almost every other column in the table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 07:37:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 06:37:32 +0000 Subject: [Koha-bugs] [Bug 23964] An item level hold when placed is set to Waiting, if ReservesNeedReturn is set to Automatic In-Reply-To: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23964-70-7Vw5GcUb6O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23964 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |BLOCKED --- Comment #21 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Looking here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 07:55:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 06:55:10 +0000 Subject: [Koha-bugs] [Bug 23964] An item level hold when placed is set to Waiting, if ReservesNeedReturn is set to Automatic In-Reply-To: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23964-70-4fbEZkchIQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23964 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 07:55:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 06:55:13 +0000 Subject: [Koha-bugs] [Bug 23964] An item level hold when placed is set to Waiting, if ReservesNeedReturn is set to Automatic In-Reply-To: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23964-70-kO9gq1rTdB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23964 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95594|0 |1 is obsolete| | --- Comment #22 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 95639 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95639&action=edit Bug 23964: Unit tests Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 07:55:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 06:55:18 +0000 Subject: [Koha-bugs] [Bug 23964] An item level hold when placed is set to Waiting, if ReservesNeedReturn is set to Automatic In-Reply-To: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23964-70-jjGgFC13Ps@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23964 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95595|0 |1 is obsolete| | --- Comment #23 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 95640 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95640&action=edit Bug 23964: ReservesNeedReturn should only apply to available items To test: 1 - Checkout an item to a patron 2 - Make sure 'ReservesNeedReturn' is set to 'Automatically' 3 - Place an item level hold on the checked out item 4 - Note the hold is marked waiting 5 - Delete the hold 6 - Apply patch 7 - Place a new hold 8 - Hold is not marked waiting 9 - Please a hold on a different item 10 - Note it is marked waiting 11 - Test when item is damaged and hold not allowed on damaged items 12 - Test when item is in transit 13 - Test when item has another hold 14 - Only in the case where none of the above are true should the hold be marked waiting Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 07:55:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 06:55:22 +0000 Subject: [Koha-bugs] [Bug 23964] An item level hold when placed is set to Waiting, if ReservesNeedReturn is set to Automatic In-Reply-To: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23964-70-9CVukUdE7F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23964 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95596|0 |1 is obsolete| | --- Comment #24 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 95641 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95641&action=edit Bug 23964: (follow-up) Add comments and improve readability Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Corrected typo: Similaryly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 07:55:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 06:55:27 +0000 Subject: [Koha-bugs] [Bug 23964] An item level hold when placed is set to Waiting, if ReservesNeedReturn is set to Automatic In-Reply-To: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23964-70-ssNoB7oIbQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23964 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95597|0 |1 is obsolete| | --- Comment #25 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 95642 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95642&action=edit Bug 23964: Use is instead of isnt in tests Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 07:55:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 06:55:31 +0000 Subject: [Koha-bugs] [Bug 23964] An item level hold when placed is set to Waiting, if ReservesNeedReturn is set to Automatic In-Reply-To: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23964-70-IKIRapjN9O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23964 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95598|0 |1 is obsolete| | --- Comment #26 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 95643 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95643&action=edit Bug 23964: (follow-up) more test clarification Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 07:55:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 06:55:35 +0000 Subject: [Koha-bugs] [Bug 23964] An item level hold when placed is set to Waiting, if ReservesNeedReturn is set to Automatic In-Reply-To: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23964-70-RhW21OES4n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23964 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95599|0 |1 is obsolete| | --- Comment #27 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 95644 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95644&action=edit Bug 23964: 3 more tests to cover found and match the description Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 07:56:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 06:56:03 +0000 Subject: [Koha-bugs] [Bug 23964] An item level hold when placed is set to Waiting, if ReservesNeedReturn is set to Automatic In-Reply-To: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23964-70-zFeDzgTexn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23964 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch QA Contact|jonathan.druart at bugs.koha-c |m.de.rooy at rijksmuseum.nl |ommunity.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 08:07:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 07:07:28 +0000 Subject: [Koha-bugs] [Bug 24061] Print List (opac-shelves.pl) broken in Chrome In-Reply-To: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24061-70-K1yON4uXwp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24061 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |Failed QA --- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- If you cancel the print action, the extra tab is not closed in Firefox. In that sense increasing the timeout worked better. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 08:10:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 07:10:36 +0000 Subject: [Koha-bugs] [Bug 20948] Item-level hold info displayed regardless its priority (detail.pl) In-Reply-To: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20948-70-SymNSzvXkL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- FAIL koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt FAIL filters missing_filter at line 365 ( There is an item level hold on this item (priority = [% hold.priority %]).) Work on qa tools ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 08:34:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 07:34:23 +0000 Subject: [Koha-bugs] [Bug 20948] Item-level hold info displayed regardless its priority (detail.pl) In-Reply-To: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20948-70-Lfm1h5FEwF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 --- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- There is an item level hold on this item (priority = 2). Personally, I think we'd better not show this at all. Please explain why we need this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 08:37:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 07:37:56 +0000 Subject: [Koha-bugs] [Bug 24024] Holds Awaiting Pickup (Both Active and Expired) Sorts by Firstname In-Reply-To: <bug-24024-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24024-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24024-70-WVyVAGPcG0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24024 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 08:37:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 07:37:59 +0000 Subject: [Koha-bugs] [Bug 24024] Holds Awaiting Pickup (Both Active and Expired) Sorts by Firstname In-Reply-To: <bug-24024-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24024-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24024-70-t7lai6TTH4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24024 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95635|0 |1 is obsolete| | --- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 95645 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95645&action=edit Bug 24024: Invert names on halds waiting report Signed-off-by: Rhonda Kuiper <rkuiper at roundrocktexas.gov> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 08:38:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 07:38:36 +0000 Subject: [Koha-bugs] [Bug 24024] Holds Awaiting Pickup (Both Active and Expired) Sorts by Firstname In-Reply-To: <bug-24024-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24024-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24024-70-RlKOi3bZ9C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24024 --- Comment #6 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 95646 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95646&action=edit Bug 24024: Invert names on holds waiting report Signed-off-by: Rhonda Kuiper <rkuiper at roundrocktexas.gov> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 08:38:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 07:38:51 +0000 Subject: [Koha-bugs] [Bug 24024] Holds Awaiting Pickup (Both Active and Expired) Sorts by Firstname In-Reply-To: <bug-24024-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24024-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24024-70-WhebsiCbrj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24024 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- halds => holds -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 08:39:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 07:39:05 +0000 Subject: [Koha-bugs] [Bug 24024] Holds Awaiting Pickup (Both Active and Expired) Sorts by Firstname In-Reply-To: <bug-24024-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24024-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24024-70-RIIOGPzavB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24024 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 08:41:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 07:41:18 +0000 Subject: [Koha-bugs] [Bug 24060] [19.05] Can't load patron clubs tab on patron details page In-Reply-To: <bug-24060-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24060-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24060-70-Z2qcgNTiTA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24060 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl Status|Signed Off |Passed QA Summary|Can't load patron clubs tab |[19.05] Can't load patron |on patron details page |clubs tab on patron details | |page --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Changing status, pushing it to next in line -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 08:51:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 07:51:50 +0000 Subject: [Koha-bugs] [Bug 23184] Export/bibs/holdings settings unclear for exporting bibs without any holdings In-Reply-To: <bug-23184-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23184-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23184-70-5YTv8qJtnA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23184 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 08:51:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 07:51:53 +0000 Subject: [Koha-bugs] [Bug 23184] Export/bibs/holdings settings unclear for exporting bibs without any holdings In-Reply-To: <bug-23184-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23184-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23184-70-lnAeCM0rnZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23184 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95590|0 |1 is obsolete| | --- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 95647 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95647&action=edit Bug 23184: Don't select branches for export by default This patch changes the include to require passing "selectall=1" to select all items This include is only used in this page, so changes should not have side effects git grep "branch-selector\.inc" This patch also corrects a mismatch in the class names To test: 1 - Browse to Tools->Export data 2 - Note all branches are selected 3 - Note this will exclude records wiuthout items if you click 'Export bibiographic records' 4 - Apply patch 5 - Visit page again 6 - Note no branches are selected by default 7 - Confirm 'Select all/Clear all' still work 8 - Note record with no items are exported by default now Signed-off-by: Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 08:52:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 07:52:08 +0000 Subject: [Koha-bugs] [Bug 23184] Export/bibs/holdings settings unclear for exporting bibs without any holdings In-Reply-To: <bug-23184-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23184-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23184-70-vl28LrYfl9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23184 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 08:54:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 07:54:55 +0000 Subject: [Koha-bugs] [Bug 23184] Export/bibs/holdings settings unclear for exporting bibs without any holdings In-Reply-To: <bug-23184-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23184-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23184-70-ceGlQsPOFO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23184 --- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- I think this could still use an updated description, but that would cause a string change during string freeze ;) Change: With items owned by the following libraries To: Only include records having items from selected libraries Or something in that direction ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 09:13:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 08:13:21 +0000 Subject: [Koha-bugs] [Bug 19324] New Inventory workflow eliminates "mark item seen" and doesn't show data in table In-Reply-To: <bug-19324-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19324-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19324-70-mTMk9MK2YS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19324 Ray Delahunty <r.delahunty at arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty at arts.ac.uk -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 09:14:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 08:14:37 +0000 Subject: [Koha-bugs] [Bug 24065] Shibboleth should fail the login if matchpoint is not unique In-Reply-To: <bug-24065-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24065-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24065-70-oqR8dFzIm7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24065 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 09:14:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 08:14:40 +0000 Subject: [Koha-bugs] [Bug 24065] Shibboleth should fail the login if matchpoint is not unique In-Reply-To: <bug-24065-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24065-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24065-70-d7hHO4xCBa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24065 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95562|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 95648 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95648&action=edit Bug 24065: Fail shib login if multiple users matched Ideally you could test against active shib, but is a small code change and covered by tests and should be readable To test: prove -v t/Auth_with_shibboleth.t Signed-off-by: Liz Rea <wizzyrea at gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 09:16:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 08:16:54 +0000 Subject: [Koha-bugs] [Bug 24065] Shibboleth should fail the login if matchpoint is not unique In-Reply-To: <bug-24065-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24065-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24065-70-GJ7FqEv4jH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24065 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 09:24:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 08:24:00 +0000 Subject: [Koha-bugs] [Bug 24065] Shibboleth should fail the login if matchpoint is not unique In-Reply-To: <bug-24065-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24065-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24065-70-VMyZrBjhPn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24065 --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- I still do not understand why we stick to Test::DBIx::Class to test changes like this. Obviously we need a borrowers database here ;) Even more, if we use C4::Context in a t script (like this one), it makes not much sense. The theoretical benefit of Test::DBIx::Class is imo not in balance with its *horrible* installation.. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 09:29:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 08:29:56 +0000 Subject: [Koha-bugs] [Bug 23732] Hold rules checker: show matched rules and syspref values to help understand why a hold is possible or not In-Reply-To: <bug-23732-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23732-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23732-70-OAA6MfhvIx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23732 Victor Grousset/tuxayo <victor.grousset at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED --- Comment #9 from Victor Grousset/tuxayo <victor.grousset at biblibre.com> --- Indeed I spotted these, I though I had fixed these but can't find the commit anywhere :o Planned to take care of these, at the same time of 18.11.x rebase. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 09:31:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 08:31:52 +0000 Subject: [Koha-bugs] [Bug 23721] Names of exported basketgroup files should be uniformised In-Reply-To: <bug-23721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23721-70-4bfxoevpkt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23721 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 09:31:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 08:31:55 +0000 Subject: [Koha-bugs] [Bug 23721] Names of exported basketgroup files should be uniformised In-Reply-To: <bug-23721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23721-70-y8Qn56TkNo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23721 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95540|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 95649 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95649&action=edit Bug 23721: Use basketgroup's name to name the CSV export file When exporting a basket group, the names of the files are different: * pdf => aqbasketgroup.name(.pdf) * csv => aqbasketgroup.id(.csv) Better to use basketgroup's name for consistency and readability Test plan: Create a basketgroup and export it in pdf and CSV. The name of the generated file must be the basketgroup's name suffixed by the extension. Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 09:32:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 08:32:06 +0000 Subject: [Koha-bugs] [Bug 23721] Names of exported basketgroup files should be uniformised In-Reply-To: <bug-23721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23721-70-ePkJeAaoBX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23721 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 10:14:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 09:14:56 +0000 Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table In-Reply-To: <bug-23049-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23049-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23049-70-aJUPZxyFCj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|17702 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 [Bug 17702] Create configuration for account types -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 14:40:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 13:40:19 +0000 Subject: [Koha-bugs] [Bug 24081] Add a 'discount' process to accounts In-Reply-To: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24081-70-dX73ZqRYkc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|13985 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 09:06:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 08:06:10 +0000 Subject: [Koha-bugs] [Bug 24061] Print List (opac-shelves.pl) broken in Chrome In-Reply-To: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24061-70-vk4rfjcXo6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24061 --- Comment #22 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Does not work fine with Chrome 62 too. Also a problem with Edge. Firefox seems to work. Easier to increase the timeout? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 08:37:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 07:37:00 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23260-70-3uvnRq0JMa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #35 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Agustín Moyano from comment #31) > (In reply to Marcel de Rooy from comment #24) > > Hmm > > > > sub last_returned_by { > > my ( $self, $borrower ) = @_; > > > > my $items_last_returned_by_rs = > > Koha::Database->new()->schema()->resultset('ItemsLastBorrower'); > > > > > > Not so nice in Koha::Item. (Possibly out of scope though) > > This was introduced in Bug 14945. > > Do you want me to change it to use Items::LastPatrons class? Another report? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 08:36:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 07:36:12 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23260-70-cjZ3UhsfNW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #34 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Tomás Cohen Arazi from comment #33) > Marcel, your patch introduces the use of ->update. Given the problems about > it raised on bug 21761, could you resubmit it without using ->update? Thanks! Ah, you are right about that ;) In this case it is a bit theoretical argument, since LastBorrower only contains three fields and has no individual store sub. So replacing the while..next was just regular optimization. I do not mind setting back the while loop, although personally I would be inclined to wait on the outcome of the discussion before removing all updates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 09:15:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 08:15:57 +0000 Subject: [Koha-bugs] [Bug 21761] Koha::Object supports passing through 'update' which means we can side step 'set' + 'store' In-Reply-To: <bug-21761-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21761-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21761-70-gJ4dp6RGXs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21761 --- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- I was referred here again from report 23260 where I used an update on a Koha object without store. (Table items_last_borrower just 4 fields.) Can we get this "discussion" further? As stated in comment1 I think we need some hook subroutine on store, update etc. If there is no 'hook', could we still do some faster updates than looping with store and next? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 15:33:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 14:33:31 +0000 Subject: [Koha-bugs] [Bug 23800] Batch modification tool orders items by barcode incremental by default (regression to 17.11) In-Reply-To: <bug-23800-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23800-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23800-70-RUuw3SYILW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |andrew at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 10:03:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 09:03:19 +0000 Subject: [Koha-bugs] [Bug 24078] Convert manual credit 'tab' to a modal In-Reply-To: <bug-24078-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24078-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24078-70-RGSXhZy3bI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24078 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24079 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24079 [Bug 24079] Convert paycollect 'page' to a modal -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:17:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:17:51 +0000 Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23354-70-4MhVTSi82V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94691|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 11:50:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 10:50:55 +0000 Subject: [Koha-bugs] [Bug 22781] Fields on patron search results should be html/json filtered In-Reply-To: <bug-22781-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22781-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22781-70-CJBr6Sh3HN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22781 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #23 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- *** Bug 18765 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 10:17:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 09:17:34 +0000 Subject: [Koha-bugs] [Bug 9173] Using description for monetary amount with MANUAL_INV is confusing In-Reply-To: <bug-9173-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9173-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9173-70-wEIJhJsDhA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9173 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14825 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:39:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:39:28 +0000 Subject: [Koha-bugs] [Bug 24075] Backdating a return to the exact due date and time results in the fine not being refunded In-Reply-To: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24075-70-oGTWejrDAH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24075 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95655|0 |1 is obsolete| | --- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 95656 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95656&action=edit Bug 24075: Unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 19:29:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 18:29:01 +0000 Subject: [Koha-bugs] [Bug 24084] PlainMARC view broken on OPAC if other $.ajax calls produce errors In-Reply-To: <bug-24084-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24084-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24084-70-OvlMegbgnX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24084 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 95704 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95704&action=edit Bug 24084: PlainMARC view broken on OPAC if other $.ajax calls produce errors This patch removes the use of jQuery's ajaxSetup() and load() to get the "plain" MARC view and replaces it with $.get(). This allows for error-handling on this specific AJAX request rather than all on the page. To test, apply the patch and view a bibliographic record in the OPAC. - Click the "MARC view" tab. - Click the "view plain" link. - The plain-text MARC view should load. - Clicking "view labeled" should return you to the original view. To test error handling, edit opac-MARCdetail.tt line 185 and add a typo to the URL, e.g. "opac-showmark.pl." Repeat the above steps. Clicking the "view plain" link should trigger an error message: "Sorry, plain view is temporarily unavailable." -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 11:22:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 10:22:59 +0000 Subject: [Koha-bugs] [Bug 23900] Label maker cannot concatenate database fields In-Reply-To: <bug-23900-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23900-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23900-70-OH86VgYnv4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23900 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|jonathan.druart at bugs.koha-c |cnighswonger at foundations.ed |ommunity.org |u --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #5) > Please add tests :) I have answered previously, I will not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:22:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:22:44 +0000 Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23354-70-zc2Zsrfd7P@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #79 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95687 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95687&action=edit Bug 23354: Update to account for bug 23049 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:36:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:36:37 +0000 Subject: [Koha-bugs] [Bug 23721] Names of exported basketgroup files should be uniformised In-Reply-To: <bug-23721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23721-70-FTQ1goAuyi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23721 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:46:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:46:08 +0000 Subject: [Koha-bugs] [Bug 23496] batchmod.pl no longer sorts results in scanned order In-Reply-To: <bug-23496-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23496-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23496-70-afNUvRKEoB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23496 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- *** This bug has been marked as a duplicate of bug 23800 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 09:57:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 08:57:10 +0000 Subject: [Koha-bugs] [Bug 24077] Convert manual invoice 'tab' to a modal In-Reply-To: <bug-24077-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24077-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24077-70-6nd9bCczqP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24077 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24078 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24078 [Bug 24078] Convert manual credit 'tab' to a modal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:54:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:54:51 +0000 Subject: [Koha-bugs] [Bug 23254] Batch item modification and deletion handle leading and trailing spaces inconsistently In-Reply-To: <bug-23254-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23254-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23254-70-vDre3BhTA6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23254 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23800 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:18:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:18:35 +0000 Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23354-70-4zlpqbkH0B@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94696|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:36:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:36:53 +0000 Subject: [Koha-bugs] [Bug 24058] acquisition table displayed even if no order exist (bib detail) In-Reply-To: <bug-24058-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24058-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24058-70-qgvPDQDqBa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24058 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 10:16:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 09:16:07 +0000 Subject: [Koha-bugs] [Bug 17596] Simplify accounting UI in staff client In-Reply-To: <bug-17596-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17596-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17596-70-hs26qgmHs9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17596 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|17702 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 [Bug 17702] Create configuration for account types -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:11:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:11:07 +0000 Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts In-Reply-To: <bug-23442-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23442-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23442-70-A9MwwGlA9f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add a 'refund' workflow to |Add a 'refund' process to |the POS feature |accounts -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:52:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:52:07 +0000 Subject: [Koha-bugs] [Bug 15689] Label editor: Fix issues with wrong batch_id parameter In-Reply-To: <bug-15689-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15689-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15689-70-v8gEMbmmp5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15689 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- My understanding of the bug report is this: If you remove (by "remove selected" or the delete button) all items in an existing label batch and then immediately add new items to the batch, the batch will be saved with a new batch_id. In my test this was not the case, so I'm closing this report. If someone finds otherwise please re-open with more details. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 14:26:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 13:26:13 +0000 Subject: [Koha-bugs] [Bug 6018] Batch modifitcation of items Enchancements In-Reply-To: <bug-6018-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6018-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6018-70-5lPm5pZdl6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6018 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23282 -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:21:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:21:49 +0000 Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23354-70-dM7rlSZatS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #70 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95678 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95678&action=edit Bug 23354: Add a Point Of Sale 'pay' screen This patch adds a new Point Of Sale module to Koha's staff client front page. The module button leads directly to a 'Pay' page giving the staff user the ability to record anonymous payments for items that would not normally require a patron to be registered at the library. Test plan: 1) Enable `UseCashRegisters` via the system preferences. 2) Ensure your user has the 'manage_cash_registers' permission. 3) Add a cash register for your current branch. 4) Add at least one 'MANUAL_INV' authorized value. 5) Navigate to the new 'POS' pay page via the main menu. 6) Add an item to the 'sale' by clicking 'add' from the right side of the screen. 7) Note that said item was added to the table of items this sale on the left. 8) At this point you should be able to 'click to edit' the quantity or price of the item in the table on the left. 9) Enter an amount greater than the price of the item into the 'amount collected from patron' box. 10) Click 'Confirm' 11) Varify that the same change to give modal from the paycollect pages appears here. 12) Click 'Confirm' 13) Payment will have been recorded (check the database) and you will be back at a fresh 'Pay' page ready for the next transaction. 14) Signoff Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 14:26:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 13:26:42 +0000 Subject: [Koha-bugs] [Bug 24061] Print List (opac-shelves.pl) broken in Chrome In-Reply-To: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24061-70-hdFw9a5Noo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24061 --- Comment #16 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #15) > Which versions of Firefox are you using? 70.0.1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 18:33:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 17:33:51 +0000 Subject: [Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record In-Reply-To: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23591-70-18M4g6vPDR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 18:14:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 17:14:10 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23260-70-rUd4kBKjx5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #27 from Agustín Moyano <agustinmoyano at theke.io> --- Created attachment 95699 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95699&action=edit Bug 23260: Add anonymize items_last_borrower feature This patch adds the feature to anonymize patrons from items_last_borrower table. This code is run from batch_anonymize script, which is triggered from a cron job. To test: 1) apply this patch and the previous one 2) perl installer/data/mysql/updatedatabase.pl 3) set StoreLastBorrower preference to Allow. 4) Create a Check out followed by a Check in. CHECK => a row should appear in items_last_borrower table with the borrower and the item number. 5) In mysql, update created_on date to one day earlier. 6) set AnonymousPatron preference to a valid patron id 7) perl misc/cronjobs/batch_anonymise.pl SUCCESS => borrower number in items_last_borrower changed to AnonymousPatron id 8) repeat steps 4 and 5 9) set AnonymousPatron preference to 0 10) perl misc/cronjobs/batch_anonymise.pl SUCCESS => borrower number in items_last_borrower changed to null 11) prove t/db_dependent/Koha/Patrons.t 12) Sign off Sponsored-by: Northeast Kansas Library System Signed-off-by: Maryse Simard <maryse.simard at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:37:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:37:14 +0000 Subject: [Koha-bugs] [Bug 24075] Backdating a return to the exact due date and time results in the fine not being refunded In-Reply-To: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24075-70-eLkAGeZ7mP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24075 --- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 95655 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95655&action=edit Bug 24075: Unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 16:34:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 15:34:01 +0000 Subject: [Koha-bugs] [Bug 24061] Print List (opac-shelves.pl) broken in Chrome In-Reply-To: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24061-70-YB2LoGQJ2K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24061 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 19:28:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 18:28:59 +0000 Subject: [Koha-bugs] [Bug 24084] PlainMARC view broken on OPAC if other $.ajax calls produce errors In-Reply-To: <bug-24084-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24084-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24084-70-sLbWQvvaEN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24084 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 10:03:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 09:03:19 +0000 Subject: [Koha-bugs] [Bug 17596] Simplify accounting UI in staff client In-Reply-To: <bug-17596-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17596-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17596-70-vCNtc0bMcV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17596 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24079 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24079 [Bug 24079] Convert paycollect 'page' to a modal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 09:57:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 08:57:10 +0000 Subject: [Koha-bugs] [Bug 24078] New: Convert manual credit 'tab' to a modal Message-ID: <bug-24078-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24078 Bug ID: 24078 Summary: Convert manual credit 'tab' to a modal Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: koha-bugs at lists.koha-community.org, testopia at bugs.koha-community.org Depends on: 24077 Blocks: 17596 As the title says, I think we could modernise the UX for accounts by converting the manual credit tab and form to a modal reached via a new button/accounts toolbar. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17596 [Bug 17596] Simplify accounting UI in staff client https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24077 [Bug 24077] Convert manual invoice 'tab' to a modal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:10:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:10:16 +0000 Subject: [Koha-bugs] [Bug 23276] Don't show tags on tag cloud when tagging is disabled In-Reply-To: <bug-23276-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23276-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23276-70-1nybhIeM8H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23276 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95652|0 |1 is obsolete| | --- Comment #5 from David Nind <david at davidnind.com> --- Created attachment 95653 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95653&action=edit Bug 23276: Do not display tag if pref TagsEnabled is off If the pref TagsEnabled is off we should not display the tags at the OPAC. There is a message to tell that tags system is disabled, but the tags are displayed. This patch introduces the blocking_errors include file at the OPAC. Test plan: - Turn TagsEnabled on - Add some tags - Turn TagsEnabled off - Hit /cgi-bin/koha/opac-tags.pl => Without this patch you see a warning messaging saying that the tag system is disabled, but the tags are displayed => With this patch you see a (ugly) short screen saying that the tag system is disabled. Signed-off-by: David Nind <david at davidnind.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:13:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:13:53 +0000 Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts In-Reply-To: <bug-23442-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23442-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23442-70-fSG8Gg9K1i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|24080 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 [Bug 24080] Add a 'payout' process to accounts -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 14:38:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 13:38:45 +0000 Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts In-Reply-To: <bug-23442-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23442-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23442-70-8SgKKVhLFl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23354 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 09:56:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 08:56:33 +0000 Subject: [Koha-bugs] [Bug 24077] Convert manual invoice 'tab' to a modal In-Reply-To: <bug-24077-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24077-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24077-70-n13rQSaOpZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24077 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |17596 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17596 [Bug 17596] Simplify accounting UI in staff client -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 09:43:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 08:43:38 +0000 Subject: [Koha-bugs] [Bug 24058] acquisition table displayed even if no order exist (bib detail) In-Reply-To: <bug-24058-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24058-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24058-70-QF0bPtosD3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24058 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 19:36:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 18:36:23 +0000 Subject: [Koha-bugs] [Bug 24084] PlainMARC view broken on OPAC if other $.ajax calls produce errors In-Reply-To: <bug-24084-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24084-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24084-70-CVrdjExNwC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24084 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:36:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:36:35 +0000 Subject: [Koha-bugs] [Bug 23184] Export/bibs/holdings settings unclear for exporting bibs without any holdings In-Reply-To: <bug-23184-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23184-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23184-70-UfzMvaPo80@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23184 --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 14:39:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 13:39:47 +0000 Subject: [Koha-bugs] [Bug 24081] Add a 'discount' process to accounts In-Reply-To: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24081-70-ka8wIHY5jo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|23355 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355 [Bug 23355] Add 'cashup' process to the accounts system -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:22:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:22:53 +0000 Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23354-70-p2XjL4APCz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #80 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95688 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95688&action=edit Bug 23354: (follow-up) Make display of debit types configurable This patch adds a the ability to define where a debit type will be available as a option for use. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 13:57:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 12:57:01 +0000 Subject: [Koha-bugs] [Bug 22359] Improve usability of 'change calculation' (bug 11373) In-Reply-To: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22359-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22359-70-vYDBN9lLjp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22359 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:47:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:47:18 +0000 Subject: [Koha-bugs] [Bug 20932] Add multiple items should have a maximum number to be able to add at a time In-Reply-To: <bug-20932-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20932-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20932-70-4XGphLJceG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20932 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Version|17.05 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:22:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:22:26 +0000 Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23354-70-LMPUBRfz4h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #76 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95684 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95684&action=edit Bug 23354: (follow-up) Input type on jEditable Update the jEditable plugin to a maintained version and use the new 'number' type to enable increment arrows on click and remap onblur event to submit. Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 11:44:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 10:44:19 +0000 Subject: [Koha-bugs] [Bug 20948] Item-level hold info displayed regardless its priority (detail.pl) In-Reply-To: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20948-70-e6JsKcuXuN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 --- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #13) > (In reply to Marcel de Rooy from comment #12) > > There is an item level hold on this item (priority = 2). > > > > Personally, I think we'd better not show this at all. Please explain why we > > need this. > > I used Christopher's suggestion: > > (In reply to Christopher Brannon from comment #6) > > It is preferred if it just said "There is an item level hold on this item", > > without any specific details. Well, Christopher is invited to reply too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 10:03:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 09:03:26 +0000 Subject: [Koha-bugs] [Bug 24078] Convert manual credit 'tab' to a modal In-Reply-To: <bug-24078-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24078-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24078-70-OrBHr7jkNN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24078 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|24079 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24079 [Bug 24079] Convert paycollect 'page' to a modal -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:10:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:10:23 +0000 Subject: [Koha-bugs] [Bug 17979] Fatal error when searching from addbooks.pl due to ISBN flaw In-Reply-To: <bug-17979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17979-70-Di6lvjFPeC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17979 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:12:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:12:13 +0000 Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts In-Reply-To: <bug-23442-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23442-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23442-70-7TWuit1yN0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24080 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 [Bug 24080] Add a 'payout' process to accounts -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:36:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:36:51 +0000 Subject: [Koha-bugs] [Bug 24034] Capitalization on suggestion edit form: No Status In-Reply-To: <bug-24034-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24034-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24034-70-Kj5NaNqLc7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24034 --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:23:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:23:21 +0000 Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23354-70-j9Sfp7sOHp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #84 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95692 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95692&action=edit Bug 23354: Format price on item add -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 11:54:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 10:54:51 +0000 Subject: [Koha-bugs] [Bug 23900] Label maker cannot concatenate database fields In-Reply-To: <bug-23900-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23900-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23900-70-2WZBSPVWMQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23900 --- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #4) > (In reply to Katrin Fischer from comment #3) > > Hi Jonathan, could we have a regression test for this please? > > I tried but failed. I do not think the whole thing is tested at all. t/Labels.t t/Labels_split_ccn.t t/Labels_split_lccn.t t/db_dependent/Labels/t_Label.t -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 16:21:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 15:21:03 +0000 Subject: [Koha-bugs] [Bug 24027] Adding multiple items is slow In-Reply-To: <bug-24027-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24027-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24027-70-c2RNUCLC0S@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24027 Andrew Nugged <nugged at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95417|0 |1 is obsolete| | --- Comment #12 from Andrew Nugged <nugged at gmail.com> --- Created attachment 95663 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95663&action=edit Bug 24027: (follow-up) Don't combine multiple items add POST page with list generation When hundreds or thousands of items added, it takes time to add to DB. Then generation of items list in the SAME request also takes time. This "doubles" page generation time. This patch proposes to show only the number of added and total items on POST-generated page instead of list generation, but not always: only if some limit are reached ("OpacMaxItemsToDisplay" // 50 is used), and propose navigation link for the user to see the list after. It's much more sensible on big databases and libraries hosting/clouds with limited resources even up to page generation timeout. This stacks up with previous patch for the combined speed up effect. Other improvements with this patch: because added counters for both: - added now items, - overall items for this biblioid in DB, it is now shows: - number of added items after adding in "dialog message" style box, - number of total displayed items on the beginning of the list table. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 18:20:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 17:20:17 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23260-70-hF4pDqmU3M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #31 from Agustín Moyano <agustinmoyano at theke.io> --- (In reply to Marcel de Rooy from comment #24) > Hmm > > sub last_returned_by { > my ( $self, $borrower ) = @_; > > my $items_last_returned_by_rs = > Koha::Database->new()->schema()->resultset('ItemsLastBorrower'); > > > Not so nice in Koha::Item. (Possibly out of scope though) This was introduced in Bug 14945. Do you want me to change it to use Items::LastPatrons class? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:36:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:36:45 +0000 Subject: [Koha-bugs] [Bug 24024] Holds Awaiting Pickup (Both Active and Expired) Sorts by Firstname In-Reply-To: <bug-24024-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24024-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24024-70-VKBiYUimjB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24024 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 11:50:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 10:50:55 +0000 Subject: [Koha-bugs] [Bug 18765] Bad cardnumber causes 'Borrower' search to fail In-Reply-To: <bug-18765-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18765-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18765-70-sV40DQXoX2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18765 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|FIXED |DUPLICATE --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- *** This bug has been marked as a duplicate of bug 22781 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 18:40:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 17:40:09 +0000 Subject: [Koha-bugs] [Bug 23403] SIP2 lends to wrong patron if cardnumber is missing In-Reply-To: <bug-23403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23403-70-smtnxqgvlK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23403 --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95703 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95703&action=edit Bug 23403: Remove cardnumber from SIP -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:02:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:02:36 +0000 Subject: [Koha-bugs] [Bug 23249] Print hold slips without confirmation for multiple locations In-Reply-To: <bug-23249-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23249-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23249-70-X6DMwt11LM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23249 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.11 |master CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 19:17:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 18:17:35 +0000 Subject: [Koha-bugs] [Bug 24084] New: PlainMARC view broken on OPAC if other $.ajax calls produce errors Message-ID: <bug-24084-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24084 Bug ID: 24084 Summary: PlainMARC view broken on OPAC if other $.ajax calls produce errors Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: lucas at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org There is a problem with the how the #plainmarc div is loaded on opac-MARCdetail.pl. If there is an unrelated AJAX error you will always see the "Sorry, plain view is temporarily unavailable". To Test: 1. Make a unrelated AJAX request that would produce an error. I added this to the OPACUSERJS: $(document).ready(function () { $.ajax({url: "thisURLwontWork.html", success: function(result){ console.log('Just Making an error') }}); }); 2. Go to opac-MARCdetail.pl and notice plainmarc will not load and you will see the "Sorry, plain view is temporarily unavailable" message. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:03:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:03:19 +0000 Subject: [Koha-bugs] [Bug 22548] Z39.50/SRU search replaces existing biblios In-Reply-To: <bug-22548-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22548-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22548-70-HLPqcJISfw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22548 --- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- I tested on 18.05.something and on current master, and could not reproduce the issue. I note that you marked it as 18.11. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 14:37:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 13:37:58 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24080-70-BSLVUamUtb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|23355 |23805 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355 [Bug 23355] Add 'cashup' process to the accounts system https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 [Bug 23805] Add a dedicated credit_types table -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 18:41:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 17:41:33 +0000 Subject: [Koha-bugs] [Bug 23403] SIP2 lends to wrong patron if cardnumber is missing In-Reply-To: <bug-23403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23403-70-ze8AjfSOAA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23403 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |NEW Assignee|jonathan.druart at bugs.koha-c |koha-bugs at lists.koha-commun |ommunity.org |ity.org --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I've tried but failed. There are many things broken apparently. I ended up with that patch, it does not work but I have no idea why, I do not get any useful warnings or errors. Someone with more knowledge in this code may be able to finish it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:18:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:18:26 +0000 Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23354-70-NbStUfBU4e@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94695|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 16:50:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 15:50:47 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24080-70-2YWS7vAbjI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95666 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95666&action=edit Bug 24080: Add 'payout' method to Koha::Account::Line This enhancement adds a 'payout' method to Koha::Account::Line which can be used to 'pay out' a credit to a patron. When such a credit is 'paid out' this method will create a corresponding account debit line with an amount equal to the amountoutstanding on the original credit and the two acocuntlines will be immediately applied against each other. Test Plan: 1) Run the included tests and verify they pass. 2) Signoff -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:22:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:22:20 +0000 Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23354-70-qMwsZvCnSv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #75 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95683 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95683&action=edit Bug 23354: Add tests for Koha::Charges::Sales Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 13:09:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 12:09:23 +0000 Subject: [Koha-bugs] [Bug 23249] Print hold slips without confirmation for multiple locations In-Reply-To: <bug-23249-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23249-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23249-70-jBqg8Vt4x8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23249 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Hi Jen, What is the desired outcome here? Are you thinking that Koha should print simply a transfer slip at this stage and not notify of the hold? Or is the issue that the hold slip that prints doesn't notify the patron of the transfer? -Nick -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 18:14:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 17:14:15 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23260-70-1iw8oYCP6v@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #28 from Agustín Moyano <agustinmoyano at theke.io> --- Created attachment 95700 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95700&action=edit Bug 23260: (follow-up) optimize anonymise_items_last_borrower Sponsored-by: Northeast Kansas Library System Signed-off-by: Maryse Simard <maryse.simard at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 11:26:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 10:26:56 +0000 Subject: [Koha-bugs] [Bug 20948] Item-level hold info displayed regardless its priority (detail.pl) In-Reply-To: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20948-70-KYUHRdPY5r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 --- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #12) > There is an item level hold on this item (priority = 2). > > Personally, I think we'd better not show this at all. Please explain why we > need this. I used Christopher's suggestion: (In reply to Christopher Brannon from comment #6) > It is preferred if it just said "There is an item level hold on this item", > without any specific details. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:12:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:12:13 +0000 Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale' In-Reply-To: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13985-70-4UhPWTmizi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24080 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 [Bug 24080] Add a 'payout' process to accounts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:16:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:16:07 +0000 Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts In-Reply-To: <bug-23442-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23442-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23442-70-qUmFHkhY1n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92955|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 10:18:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 09:18:58 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14825-70-nkdZI7puhx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|23636 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23636 [Bug 23636] MANUAL_INV values should be able to have a code, a description, and a price. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:15:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:15:59 +0000 Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts In-Reply-To: <bug-23442-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23442-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23442-70-9pn2BF77ft@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92956|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:36:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:36:43 +0000 Subject: [Koha-bugs] [Bug 23964] An item level hold when placed is set to Waiting, if ReservesNeedReturn is set to Automatic In-Reply-To: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23964-70-x7iLqgLQmj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23964 --- Comment #28 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 11:39:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 10:39:32 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23260-70-95x25XkrmP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|BLOCKED |Failed QA --- Comment #23 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Two things left, after the follow-up: We need an adjusted dbrev: `created_on` timestamp NOT NULL DEFAULT current_timestamp() ON UPDATE current_timestamp(), That is an updated_on ! So we should remove the ON UPDATE. This made me add the nb_rows comment. A count after the update would be affected by the updated timestamp. my $before = $now + DateTime::Duration->new( days => 1 ); That does not look good. Use add_days or something like that. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:22:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:22:59 +0000 Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23354-70-3gi5c1Wd3q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #81 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95689 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95689&action=edit Bug 23354: (follow-up) Ensure 'CASH' payment type is present -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 10:17:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 09:17:41 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14825-70-pESppmOoKI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|5620 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620 [Bug 5620] Capture Mode of payment -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 16:38:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 15:38:29 +0000 Subject: [Koha-bugs] [Bug 24061] Print List (opac-shelves.pl) broken in Chrome In-Reply-To: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24061-70-verQDyM3Ld@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24061 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Not with Chrome... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 10:03:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 09:03:26 +0000 Subject: [Koha-bugs] [Bug 24079] Convert paycollect 'page' to a modal In-Reply-To: <bug-24079-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24079-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24079-70-dc7LkjHig5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24079 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|24078 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24078 [Bug 24078] Convert manual credit 'tab' to a modal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:22:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:22:01 +0000 Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23354-70-jbma3nJLyF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #72 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95680 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95680&action=edit Bug 23354: Add ability to remove items This patch adds the ability to remove items from a transactions on the new Point of Sale pay page. Test plan: 1) Populate a transaction with at least one item. 2) Note the new button to 'Remove item' on the items table. 3) Click the button and confirm the item is removed 4) Signoff Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:31:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:31:40 +0000 Subject: [Koha-bugs] [Bug 20948] Item-level hold info displayed regardless its priority (detail.pl) In-Reply-To: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20948-70-4b2nA1u3kI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 --- Comment #15 from Christopher Brannon <cbrannon at cdalibrary.org> --- (In reply to Marcel de Rooy from comment #12) > There is an item level hold on this item (priority = 2). > > Personally, I think we'd better not show this at all. Please explain why we > need this. I would have suggested removing it altogether, but there are those that want to know if there are item level holds on items. Particularly if items are lost or missing or damaged. That way they can easily see them and do something about the holds. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 09:57:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 08:57:10 +0000 Subject: [Koha-bugs] [Bug 17596] Simplify accounting UI in staff client In-Reply-To: <bug-17596-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17596-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17596-70-ZlICniVUfA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17596 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24078 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24078 [Bug 24078] Convert manual credit 'tab' to a modal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:36:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:36:34 +0000 Subject: [Koha-bugs] [Bug 23184] Export/bibs/holdings settings unclear for exporting bibs without any holdings In-Reply-To: <bug-23184-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23184-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23184-70-4aZAcDm0gg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23184 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 09:59:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 08:59:02 +0000 Subject: [Koha-bugs] [Bug 24077] Convert manual invoice 'tab' to a modal In-Reply-To: <bug-24077-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24077-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24077-70-USTz35Piga@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24077 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|24078 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24078 [Bug 24078] Convert manual credit 'tab' to a modal -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:37:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:37:03 +0000 Subject: [Koha-bugs] [Bug 24075] Backdating a return to the exact due date and time results in the fine not being refunded In-Reply-To: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24075-70-M59WlosvqH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24075 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 18:38:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 17:38:00 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23260-70-dTZ5VNYy9x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #33 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Marcel, your patch introduces the use of ->update. Given the problems about it raised on bug 21761, could you resubmit it without using ->update? Thanks! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 16:50:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 15:50:50 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24080-70-DlR9gu68Uk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95667 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95667&action=edit Bug 24080: Add account_payout permission -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 10:18:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 09:18:58 +0000 Subject: [Koha-bugs] [Bug 23636] MANUAL_INV values should be able to have a code, a description, and a price. In-Reply-To: <bug-23636-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23636-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23636-70-ULsFFotLJq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23636 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14825 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:45:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:45:51 +0000 Subject: [Koha-bugs] [Bug 23800] Batch modification tool orders items by barcode incremental by default (regression to 17.11) In-Reply-To: <bug-23800-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23800-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23800-70-BviBCePTBc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94354|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 14:37:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 13:37:58 +0000 Subject: [Koha-bugs] [Bug 23805] Add a dedicated credit_types table In-Reply-To: <bug-23805-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23805-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23805-70-paOM2sbnYV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24080 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 [Bug 24080] Add a 'payout' process to accounts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:23:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:23:06 +0000 Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23354-70-LJ6pcqDtRO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #82 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95690 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95690&action=edit Bug 23354: (follow-up) Update for bugs 23049 and 23805 Remove all mentions of accounttype and replace with debit_type_code and credit_type_code as appropriate. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 10:16:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 09:16:07 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account types In-Reply-To: <bug-17702-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17702-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17702-70-jek6vyK8Sm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|17596 |14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17596 [Bug 17596] Simplify accounting UI in staff client -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 16:38:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 15:38:12 +0000 Subject: [Koha-bugs] [Bug 18698] Get rid of [%% in translation for shelves-result.tt In-Reply-To: <bug-18698-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18698-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18698-70-QVzteWg6AT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18698 --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- The way the item search handles generation of the JSON data might be useful here, although it's kind of convoluted. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:22:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:22:47 +0000 Subject: [Koha-bugs] [Bug 16683] Help links to fields 59X in cataloguing form are broken In-Reply-To: <bug-16683-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16683-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16683-70-WaMR53QsMq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16683 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |oleonard at myacpl.org Version|16.05 |master Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 14:26:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 13:26:13 +0000 Subject: [Koha-bugs] [Bug 23282] Show all columns in Batch Item Modification and Batch Item Deletion In-Reply-To: <bug-23282-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23282-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23282-70-avPu7o0BGP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23282 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=6018 Version|18.11 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 10:18:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 09:18:02 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14825-70-PcnKXMwZLR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|18868 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18868 [Bug 18868] Pay Selected doesn't add payment information to item information -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:45:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:45:32 +0000 Subject: [Koha-bugs] [Bug 23800] Batch modification tool orders items by barcode incremental by default (regression to 17.11) In-Reply-To: <bug-23800-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23800-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23800-70-v8FyHgbDt0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff Severity|minor |normal Assignee|arthur.suzuki at biblibre.com |jonathan.druart at bugs.koha-c | |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 16:19:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 15:19:03 +0000 Subject: [Koha-bugs] [Bug 17202] Deleting a rotating collection with items should either be prohibited or items should be removed In-Reply-To: <bug-17202-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17202-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17202-70-spUnTYhdUO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17202 Janet McGowan <janet.mcgowan at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |janet.mcgowan at ptfs-europe.c | |om --- Comment #3 from Janet McGowan <janet.mcgowan at ptfs-europe.com> --- I've found a problematic side-effect of this I think: - someone deletes a rotating collection without removing the items on that collection first - The itemnumbers remain in the collections_tracking table - Those items on that deleted collection no longer are subject to usual transfers - if you return an item it no longer gives the popup message to transfer the item to its home library until the rows are removed in the database. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 14:37:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 13:37:58 +0000 Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23355-70-TCMEIYKjdj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|24080 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 [Bug 24080] Add a 'payout' process to accounts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:18:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:18:45 +0000 Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23354-70-iNITpL8eAP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94697|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:36:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:36:41 +0000 Subject: [Koha-bugs] [Bug 23964] An item level hold when placed is set to Waiting, if ReservesNeedReturn is set to Automatic In-Reply-To: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23964-70-9D8LS67Hgf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23964 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 11:42:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 10:42:57 +0000 Subject: [Koha-bugs] [Bug 23900] Label maker cannot concatenate database fields In-Reply-To: <bug-23900-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23900-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23900-70-jA3bXY8Yhq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23900 --- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #6) > (In reply to Marcel de Rooy from comment #5) > > Please add tests :) > > I have answered previously, I will not. Didnt even see that, reading so fast :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:36:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:36:49 +0000 Subject: [Koha-bugs] [Bug 24034] Capitalization on suggestion edit form: No Status In-Reply-To: <bug-24034-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24034-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24034-70-LSU8b4nfRk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24034 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:10:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:10:37 +0000 Subject: [Koha-bugs] [Bug 24061] Print List (opac-shelves.pl) broken in Chrome In-Reply-To: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24061-70-YZl8liZmxI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24061 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #14 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #13) > (In reply to Marcel de Rooy from comment #12) > > If you cancel the print action, the extra tab is not closed in Firefox. In > > that sense increasing the timeout worked better. > > It works for me, could you retry? Retried although nothing changed. And still does not close the additional tab in FF when canceling the print dialog. If I confirm printing, it does close. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:23:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:23:14 +0000 Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23354-70-gOSbI64APb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #83 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95691 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95691&action=edit Bug 23354: (follow-up) Fix for sending code instead of description -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 14:38:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 13:38:45 +0000 Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23354-70-AxdeWTnVuG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|23805 |23442 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 [Bug 23442] Add a 'refund' process to accounts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 [Bug 23805] Add a dedicated credit_types table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:15:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:15:13 +0000 Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts In-Reply-To: <bug-23442-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23442-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23442-70-IBxYtlF6gW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92954|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 18:37:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 17:37:25 +0000 Subject: [Koha-bugs] [Bug 23287] JS Console Errors on Memberentry In-Reply-To: <bug-23287-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23287-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23287-70-68FCNhuTJE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23287 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |WORKSFORME Status|NEW |RESOLVED --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Hmm, I can't currently replicate it... curse my lack of notes.. I reckon lets close it -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 19:29:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 18:29:28 +0000 Subject: [Koha-bugs] [Bug 20948] Item-level hold info displayed regardless its priority (detail.pl) In-Reply-To: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20948-70-BEYXYzg7cm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 --- Comment #16 from Lisette Scheer <lisetteslatah at gmail.com> --- (In reply to Christopher Brannon from comment #15) > I would have suggested removing it altogether, but there are those that want > to know if there are item level holds on items. Particularly if items are > lost or missing or damaged. That way they can easily see them and do > something about the holds. This is why I would find the message helpful as well. Are there any performance issues from having it show? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 11:43:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 10:43:26 +0000 Subject: [Koha-bugs] [Bug 23276] Don't show tags on tag cloud when tagging is disabled In-Reply-To: <bug-23276-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23276-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23276-70-3xklYzcOci@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23276 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95618|0 |1 is obsolete| | --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95652 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95652&action=edit Bug 23276: Do not display tag if pref TagsEnabled is off If the pref TagsEnabled is off we should not display the tags at the OPAC. There is a message to tell that tags system is disabled, but the tags are displayed. This patch introduces the blocking_errors include file at the OPAC. Test plan: - Turn TagsEnabled on - Add some tags - Turn TagsEnabled off - Hit /cgi-bin/koha/opac-tags.pl => Without this patch you see a warning messaging saying that the tag system is disabled, but the tags are displayed => With this patch you see a (ugly) short screen saying that the tag system is disabled. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:22:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:22:07 +0000 Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23354-70-tg1AkCbPdq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #73 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95681 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95681&action=edit Bug 23354: (follow-up) Responses to feedback This patch impliments a number of refinements requested after the first round of feedback from the sponsors. 1) Fix padding on pay page 2) Switch 'items to add' from right to left on the page 3) Fix editable columns on pay page 4) Add explanitory text to pay page Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:10:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:10:25 +0000 Subject: [Koha-bugs] [Bug 17979] Fatal error when searching from addbooks.pl due to ISBN flaw In-Reply-To: <bug-17979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17979-70-ATuSHmS5iU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17979 --- Comment #3 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 95673 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95673&action=edit Bug 17979: Fatal error when searching from addbooks.pl due to ISBN flaw This patch adds true ISBN detection to cataloging searches so that ISBNs can be correctly identified and passed to queries of the reservoir. To test, apply the patch and go to Cataloging. - In the "Cataloging search" form at the top of the page, test various searches to confirm that results are returned in both the catalog and the reservoir: - Any title search - A search for a title which begins with a numeral, e.g. "1st to die" - A search by 10-digit ISBN - A search by 13-digit ISBN -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 09:43:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 08:43:23 +0000 Subject: [Koha-bugs] [Bug 24058] acquisition table displayed even if no order exist (bib detail) In-Reply-To: <bug-24058-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24058-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24058-70-tMmuHWIYOW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24058 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:18:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:18:17 +0000 Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23354-70-mTyrg66Zpu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94694|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:36:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:36:56 +0000 Subject: [Koha-bugs] [Bug 24065] Shibboleth should fail the login if matchpoint is not unique In-Reply-To: <bug-24065-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24065-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24065-70-mXo4YV8nsH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24065 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:35:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:35:52 +0000 Subject: [Koha-bugs] [Bug 24034] Capitalization on suggestion edit form: No Status In-Reply-To: <bug-24034-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24034-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24034-70-TWPUFKyA9p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24034 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- I've decided to let this one slip through after string freeze.. it's a tiny change and it'll be nice to get Lisette into the release notes as a new contributor ;) Thanks for your efforts here, it's always nice to welcome a new contributor :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 10:17:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 09:17:34 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14825-70-S5fFm634V2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|9173 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9173 [Bug 9173] Using description for monetary amount with MANUAL_INV is confusing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 14:38:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 13:38:45 +0000 Subject: [Koha-bugs] [Bug 23805] Add a dedicated credit_types table In-Reply-To: <bug-23805-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23805-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23805-70-eMPm5jD8Vw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|23354 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 16:50:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 15:50:52 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24080-70-1MkhCzFWUK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95668 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95668&action=edit Bug 24080: Add payout option to patron account page -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 10:16:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 09:16:07 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14825-70-pSUU2YmRE1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |17702 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 [Bug 17702] Create configuration for account types -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:06:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:06:14 +0000 Subject: [Koha-bugs] [Bug 24061] Print List (opac-shelves.pl) broken in Chrome In-Reply-To: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24061-70-WQcLEjO6GS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24061 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #12) > If you cancel the print action, the extra tab is not closed in Firefox. In > that sense increasing the timeout worked better. It works for me, could you retry? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 16:33:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 15:33:56 +0000 Subject: [Koha-bugs] [Bug 24061] Print List (opac-shelves.pl) broken in Chrome In-Reply-To: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24061-70-MMujuWIdKJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24061 --- Comment #19 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #17) > (In reply to Marcel de Rooy from comment #16) > > (In reply to Jonathan Druart from comment #15) > > > Which versions of Firefox are you using? > > > > 70.0.1 > > I have exactly this version... So, interestingly, or not, it did work on Firefox 70.0.1 but not on chromium. This patch makes the use of the onafterprint event which sounds definitely the correct way. This one works with chromium and Firefox. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 18:14:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 17:14:19 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23260-70-wglc9SpVHm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #29 from Agustín Moyano <agustinmoyano at theke.io> --- Created attachment 95701 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95701&action=edit Bug 23260: (QA follow-up) Use ->update instead of ->next Also moves initialization of $anonymous_patron closer to associated comment lines. And removes the unneeded changes from Koha::Patrons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:12:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:12:13 +0000 Subject: [Koha-bugs] [Bug 24080] New: Add a 'payout' process to accounts Message-ID: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 Bug ID: 24080 Summary: Add a 'payout' process to accounts Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, koha-bugs at lists.koha-community.org, testopia at bugs.koha-community.org Depends on: 23355, 23442 Blocks: 13985 There are times when a patron may end up with surplus credit on their account. The library should be able to pay out this credit as required and record the payout as a transaction. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355 [Bug 23355] Add 'cashup' process to the accounts system https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 [Bug 23442] Add a 'refund' process to accounts -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:18:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:18:07 +0000 Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23354-70-KRBE22O2bX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94693|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:19:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:19:11 +0000 Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23354-70-VkK8W1n1z8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94699|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:06:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:06:09 +0000 Subject: [Koha-bugs] [Bug 24073] Allow suggestion management page to default to all libraries In-Reply-To: <bug-24073-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24073-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24073-70-EjCeuZ3dac@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24073 George Williams (NEKLS) <george at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org --- Comment #1 from George Williams (NEKLS) <george at nekls.org> --- I think this is a good idea, so long as showing suggestions for all libraries as the default is optional. I used to work in a situations where staff at LIBRARYA did not want staff at LIBRARYB to see what patrons from LIBRARYA were suggesting due to privacy concerns. In that situation we used jQuery to disable the #branchcode dropdown on suggestion.pl and staff were not allowed to switch libraries so that they had to log out and log back in to see suggestions for other locations - but they could only do that if they had a username and password for that location. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:10:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:10:34 +0000 Subject: [Koha-bugs] [Bug 17979] Fatal error when searching from addbooks.pl due to ISBN flaw In-Reply-To: <bug-17979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17979-70-aEyM8f1aGe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17979 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|gmcharlt at gmail.com |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 18:02:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 17:02:50 +0000 Subject: [Koha-bugs] [Bug 23403] SIP2 lends to wrong patron if cardnumber is missing In-Reply-To: <bug-23403-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23403-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23403-70-knKop3qN7q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23403 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org CC| |jonathan.druart at bugs.koha-c | |ommunity.org Status|NEW |ASSIGNED --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Confirmed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 14:39:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 13:39:47 +0000 Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23355-70-olpwHjsdI1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|24081 |13985 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081 [Bug 24081] Add a 'discount' process to accounts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 15:32:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 14:32:52 +0000 Subject: [Koha-bugs] [Bug 23800] Batch modification tool orders items by barcode incremental by default (regression to 17.11) In-Reply-To: <bug-23800-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23800-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23800-70-Eb9a76tEGR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 --- Comment #11 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 95659 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95659&action=edit Bug 23800: Does not order items by barcode in batch item modification They must be displayed in the same order they have been scanned (or they appear in the file) This is an alternative patch. Same behavior for barcodes or itemnumbers, as well as if a file has been used or items scanned. Code is duplicated, but refactoring is out of the scope. Signed-off-by: Andrew Fuerste-Henry <andrew at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:36:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:36:54 +0000 Subject: [Koha-bugs] [Bug 24058] acquisition table displayed even if no order exist (bib detail) In-Reply-To: <bug-24058-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24058-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24058-70-VAZ37Sx00s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24058 --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:36:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:36:39 +0000 Subject: [Koha-bugs] [Bug 23721] Names of exported basketgroup files should be uniformised In-Reply-To: <bug-23721-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23721-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23721-70-d0yYKFNJrk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23721 --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:53:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:53:57 +0000 Subject: [Koha-bugs] [Bug 23254] Batch item modification and deletion handle leading and trailing spaces inconsistently In-Reply-To: <bug-23254-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23254-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23254-70-PFtq0hUIX7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23254 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=22996 CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Hi Andrew, The patch I attached on bug 23800 fixes this issue. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:37:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:37:05 +0000 Subject: [Koha-bugs] [Bug 24075] Backdating a return to the exact due date and time results in the fine not being refunded In-Reply-To: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24075-70-HDUhRJO5Xd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24075 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95626|0 |1 is obsolete| | --- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 95654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95654&action=edit Bug 24075: Backdating a return to the exact due date and time results in the fine not being refunded When you use the date picker or book drop mode and check in an item that is due on that date, a fine is assessed and not refunded. For example: item 12345 is due on 11/19/2109 23:59. On 11/20/2019 I check the item in using date picker/book drop setting the check in date to 11/19/2019 23:59, the patron is charged a fine, and the fine is not cleared as would be expected, since the item is being checked in before it is overdue. Test Plan: 1) Back date a checkout so it is overdue 2) Run fines.pl to generate the fine 3) Return the item, backdating to the same date/time is was due 4) Note the fine was not removed 5) Apply this patch 6) Repeat steps 1-3 7) Fine should be zeroed out now! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:54:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:54:51 +0000 Subject: [Koha-bugs] [Bug 23800] Batch modification tool orders items by barcode incremental by default (regression to 17.11) In-Reply-To: <bug-23800-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23800-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23800-70-FMVClK1Mef@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23254 --- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- The patch I attached also fixes bug 23800. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 09:56:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 08:56:33 +0000 Subject: [Koha-bugs] [Bug 17596] Simplify accounting UI in staff client In-Reply-To: <bug-17596-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17596-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17596-70-Vo6xUEWSkV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17596 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24077 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24077 [Bug 24077] Convert manual invoice 'tab' to a modal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:18:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:18:00 +0000 Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23354-70-zVfCTKmTKf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94692|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 14:39:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 13:39:47 +0000 Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale' In-Reply-To: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13985-70-TNnVAF7UIn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23355 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355 [Bug 23355] Add 'cashup' process to the accounts system -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 10:03:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 09:03:21 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23260-70-Md41bz2UKQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |BLOCKED --- Comment #21 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- ReQAing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 19:36:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 18:36:26 +0000 Subject: [Koha-bugs] [Bug 24084] PlainMARC view broken on OPAC if other $.ajax calls produce errors In-Reply-To: <bug-24084-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24084-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24084-70-PnYawdSt3I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24084 Lucas Gass <lucas at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95704|0 |1 is obsolete| | --- Comment #2 from Lucas Gass <lucas at bywatersolutions.com> --- Created attachment 95705 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95705&action=edit Bug 24084: PlainMARC view broken on OPAC if other $.ajax calls produce errors This patch removes the use of jQuery's ajaxSetup() and load() to get the "plain" MARC view and replaces it with $.get(). This allows for error-handling on this specific AJAX request rather than all on the page. To test, apply the patch and view a bibliographic record in the OPAC. - Click the "MARC view" tab. - Click the "view plain" link. - The plain-text MARC view should load. - Clicking "view labeled" should return you to the original view. To test error handling, edit opac-MARCdetail.tt line 185 and add a typo to the URL, e.g. "opac-showmark.pl." Repeat the above steps. Clicking the "view plain" link should trigger an error message: "Sorry, plain view is temporarily unavailable." Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:12:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:12:13 +0000 Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23355-70-NttuWFcbtx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24080 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 [Bug 24080] Add a 'payout' process to accounts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:17:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:17:41 +0000 Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23354-70-krE4k0QVD7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94690|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 09:59:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 08:59:02 +0000 Subject: [Koha-bugs] [Bug 24078] Convert manual credit 'tab' to a modal In-Reply-To: <bug-24078-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24078-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24078-70-fFc4jhG4KY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24078 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|24077 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24077 [Bug 24077] Convert manual invoice 'tab' to a modal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 10:17:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 09:17:26 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14825-70-qxu1LZ14pp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|14373 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14373 [Bug 14373] Disallow payment of accruing fines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 09:56:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 08:56:01 +0000 Subject: [Koha-bugs] [Bug 24077] New: Convert manual invoice 'tab' to a modal Message-ID: <bug-24077-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24077 Bug ID: 24077 Summary: Convert manual invoice 'tab' to a modal Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org As the title says, I think we could modernise the UX for accounts by converting the manual invoice tab and form to a modal reached via a new button/accounts toolbar. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:18:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:18:59 +0000 Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23354-70-JIIsjv76Kh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94698|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:10:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:10:13 +0000 Subject: [Koha-bugs] [Bug 23276] Don't show tags on tag cloud when tagging is disabled In-Reply-To: <bug-23276-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23276-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23276-70-8ZY3aUPNQN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23276 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 10:17:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 09:17:41 +0000 Subject: [Koha-bugs] [Bug 5620] Capture Mode of payment In-Reply-To: <bug-5620-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-5620-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5620-70-aTJoVm9ArK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5620 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14825 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 10:18:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 09:18:02 +0000 Subject: [Koha-bugs] [Bug 18868] Pay Selected doesn't add payment information to item information In-Reply-To: <bug-18868-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18868-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18868-70-9mtp7DXQY3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18868 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14825 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:53:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:53:57 +0000 Subject: [Koha-bugs] [Bug 22996] Move barcode separators to a preference In-Reply-To: <bug-22996-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22996-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22996-70-pb4fsxGWPi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22996 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23254 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 18:10:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 17:10:38 +0000 Subject: [Koha-bugs] [Bug 23249] Print hold slips without confirmation for multiple locations In-Reply-To: <bug-23249-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23249-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23249-70-bwwXGSIv3x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23249 --- Comment #2 from jdemuth at roseville.ca.us <jdemuth at roseville.ca.us> --- Hi Nick, Yes, it would be ideal if the transfer would just display a transfer box that would require the user to hit OK to move on. The hold/transfer slip that prints looks just like a hold slip our library uses on the floor and was confusing to staff. If there needs to be a printed slip, it would be nice if it was a different kind of slip for staff to recognize it was a transfer hold. Thanks, Jen -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:06:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:06:21 +0000 Subject: [Koha-bugs] [Bug 24061] Print List (opac-shelves.pl) broken in Chrome In-Reply-To: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24061-70-hLMXOovFmc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24061 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|oleonard at myacpl.org |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:34:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:34:10 +0000 Subject: [Koha-bugs] [Bug 16683] Help links to fields 59X in cataloguing form are broken In-Reply-To: <bug-16683-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16683-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16683-70-BGt55OfPiJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16683 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 10:03:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 09:03:19 +0000 Subject: [Koha-bugs] [Bug 24079] New: Convert paycollect 'page' to a modal Message-ID: <bug-24079-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24079 Bug ID: 24079 Summary: Convert paycollect 'page' to a modal Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: koha-bugs at lists.koha-community.org, testopia at bugs.koha-community.org Depends on: 24078 Blocks: 17596 As the title says, I think we could modernise the UX for accounts by converting the various paycollect displays into a modal. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17596 [Bug 17596] Simplify accounting UI in staff client https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24078 [Bug 24078] Convert manual credit 'tab' to a modal -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:17:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:17:31 +0000 Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23354-70-MsAuKmI9rw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94689|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 16:50:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 15:50:44 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24080-70-xCvoB9BGQk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95665 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95665&action=edit Bug 24080: Payout account debit type -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:52:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:52:04 +0000 Subject: [Koha-bugs] [Bug 24061] Print List (opac-shelves.pl) broken in Chrome In-Reply-To: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24061-70-FaSNMbKhLJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24061 --- Comment #15 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Which versions of Firefox are you using? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:22:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:22:38 +0000 Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23354-70-fOmvZEX1NV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #78 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95686 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95686&action=edit Bug 23354: Add Icon for POS system -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:34:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:34:13 +0000 Subject: [Koha-bugs] [Bug 16683] Help links to fields 59X in cataloguing form are broken In-Reply-To: <bug-16683-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16683-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16683-70-1jIeBn6Cq4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16683 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 95694 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95694&action=edit Bug 16683: Help links to fields 59X in cataloguing form are broken This patch adds more specificity to handling of MARC21 documentation links in the basic MARC editor. To test, apply the patch and make sure the "advancedMARCeditor" system preference is set to "Display." You may need to edit a bibliographic framework so that 09x, 59x, and 69x tags will display in the editor. Edit or create a bibliographic record using that framework. Next to each tag label in the editor should be a "?" link. Clicking this link should open a new window with the correct Library of Congress documentation page. Check the links for 09x, 59x, and 69x tags as well as others to confirm they open the correct pages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:36:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:36:58 +0000 Subject: [Koha-bugs] [Bug 24065] Shibboleth should fail the login if matchpoint is not unique In-Reply-To: <bug-24065-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24065-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24065-70-ToX4ApcPqm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24065 --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:22:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:22:14 +0000 Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23354-70-5lrkD5Es27@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #74 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95682 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95682&action=edit Bug 23354: Add permissions Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:13:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:13:53 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24080-70-xZlHi1puMy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|23442 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 [Bug 23442] Add a 'refund' process to accounts -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:22:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:22:32 +0000 Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23354-70-QdaURIh3lt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #77 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95685 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95685&action=edit Bug 23354: (follow-up) Use 'format_price' for totals Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:46:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:46:08 +0000 Subject: [Koha-bugs] [Bug 23800] Batch modification tool orders items by barcode incremental by default (regression to 17.11) In-Reply-To: <bug-23800-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23800-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23800-70-y1v06QZM9E@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jrobb at sekls.org --- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- *** Bug 23496 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:23:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:23:30 +0000 Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23354-70-HQDRmRoV9u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #85 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95693 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95693&action=edit Bug 23354: Prevent negatives from being entered -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 16:31:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 15:31:03 +0000 Subject: [Koha-bugs] [Bug 24061] Print List (opac-shelves.pl) broken in Chrome In-Reply-To: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24061-70-pKxQwc16Sc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24061 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95591|0 |1 is obsolete| | Attachment #95623|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95664 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95664&action=edit Bug 24061: Close the window after the page has been printed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 10:17:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 09:17:26 +0000 Subject: [Koha-bugs] [Bug 14373] Disallow payment of accruing fines In-Reply-To: <bug-14373-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14373-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14373-70-WOkL9AsCRM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14373 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14825 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:36:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:36:47 +0000 Subject: [Koha-bugs] [Bug 24024] Holds Awaiting Pickup (Both Active and Expired) Sorts by Firstname In-Reply-To: <bug-24024-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24024-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24024-70-5d3611KSyF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24024 --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 11:36:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 10:36:18 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23260-70-FyO5CA5h9q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #22 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 95651 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95651&action=edit Bug 23260: (QA follow-up) Use ->update instead of ->next Also moves initialization of $anonymous_patron closer to associated comment lines. And removes the unneeded changes from Koha::Patrons. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 18:01:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 17:01:04 +0000 Subject: [Koha-bugs] [Bug 23767] Spent and Ordered total values don't include child funds on acqui-home In-Reply-To: <bug-23767-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23767-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23767-70-9h3P5TvpAm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23767 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|major |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 19:38:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 18:38:47 +0000 Subject: [Koha-bugs] [Bug 13003] Prevent accidental form submission when scanning barcodes, in addbiblio.pl In-Reply-To: <bug-13003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13003-70-q0Bis5EvHv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13003 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|NEW |RESOLVED --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- This bug doesn't appear to be valid anymore. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 09:43:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 08:43:26 +0000 Subject: [Koha-bugs] [Bug 24058] acquisition table displayed even if no order exist (bib detail) In-Reply-To: <bug-24058-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24058-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24058-70-7DFHJcbnrv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24058 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95528|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 95650 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95650&action=edit Bug 24058: acquisition table displayed even if no order exist (bib detail) This patch corrects the template check for existence of acquisitions data on the bibliographic detail page. Now it will correctly hide the DataTable when there is no data. To test, apply the patch and enable the AcquisitionDetails system preference. - View the bibliographic detail page for a title which has no associated Acquisitions data. Under the "Acquisitions details" tab you should see only a message, "There is no order for this biblio." - View the detail page for a title which has associated Acquisitions data. The "Acquisitions details" tab should show the correct information. Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 11:50:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 10:50:53 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23260-70-oD6PDiyeg4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #25 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- $items_last_returned_by_rs->update_or_create( { borrowernumber => $borrower->borrowernumber, itemnumber => $self->id } ); So it might be better to KEEP the UPDATE clause but RENAME the field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:21:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:21:55 +0000 Subject: [Koha-bugs] [Bug 23354] Add a 'Pay' screen to allow anonymous payments in a POS fashion In-Reply-To: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23354-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23354-70-0VpN7TtJKE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23354 --- Comment #71 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95679 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95679&action=edit Bug 23354: Add receipting to Pay page This patch adds receipt printing to the new Point of Sale pay page. Test plan: 1) Apply patch and run database update 2) Enable automatic receipt printing via the `` system preference. 3) Make a payment for an item via the new POS pay page. 4) Note that a receipt printing dialogue is shown automatically after payment. 5) Note that a new notice is available under tools where you can alter the content of the receipt. 6) Signoff Sponsored-by: PTFS Europe Sponsored-by: Cheshire Libraries Shared Services -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 18:14:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 17:14:05 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23260-70-k4lroCVPX4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Agustín Moyano <agustinmoyano at theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95457|0 |1 is obsolete| | Attachment #95458|0 |1 is obsolete| | Attachment #95460|0 |1 is obsolete| | Attachment #95651|0 |1 is obsolete| | --- Comment #26 from Agustín Moyano <agustinmoyano at theke.io> --- Created attachment 95698 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95698&action=edit Bug 23260: Make borrowernumber nullable in items_last_borrower This patch alters table structure to make borrowernumber nullable Sponsored-by: Northeast Kansas Library System -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 11:44:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 10:44:49 +0000 Subject: [Koha-bugs] [Bug 23276] Don't show tags on tag cloud when tagging is disabled In-Reply-To: <bug-23276-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23276-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23276-70-IxUE6LlL0A@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23276 --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Sorry David, I added to the patch a last minute change that should never have been part of it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 06:26:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 05:26:46 +0000 Subject: [Koha-bugs] [Bug 23987] batchMod.pl provides a link back to the record after the record is deleted In-Reply-To: <bug-23987-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23987-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23987-70-E8CnqKCrhd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23987 George Williams (NEKLS) <george at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 06:26:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 05:26:07 +0000 Subject: [Koha-bugs] [Bug 23987] batchMod.pl provides a link back to the record after the record is deleted In-Reply-To: <bug-23987-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23987-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23987-70-UxtfmbhYeP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23987 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95605|0 |1 is obsolete| | --- Comment #3 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 95711 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95711&action=edit Bug 23987: Use src=CATALOGUING for edition/deletion in batch from items table There are 2 ways to land in batchMod from the detail page of a bib record: from the Edit menu, and the action buttons on top of the items table. We want the same behavior for both and so use src=CATALOGUING It will make batchMod to behave identically for the "return" button Signed-off-by: George Williams <george at nekls.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 06:26:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 05:26:09 +0000 Subject: [Koha-bugs] [Bug 23987] batchMod.pl provides a link back to the record after the record is deleted In-Reply-To: <bug-23987-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23987-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23987-70-FevlCOt2Wm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23987 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95606|0 |1 is obsolete| | --- Comment #4 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 95712 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95712&action=edit Bug 23987: "return to cataloguing" if the record is deleted from bachMod-del If a bibliographic record is deleted after having deleted all their items in a batch, we should not display a "return to the record" button but "return to cataloguing" instead Test plan: 1 - Have/make a bib with items 2 - On details page select Edit->Delete items in a batch 3 - Select all items and check "Delete record if no items remain" 4 - Delete the things 5 - On confirmation screen you have a count of items/bibs deleted => Without the patch there is a 'Return to record' button that leads to nowhere => With this patch there is a "Return to cataloging module" button 6 - Repeat using the "Delete selected items" link on top of the items table => Without the patch there is a 'Return to where you were' button that leads to nowhere => With this patch there is a "Return to cataloging module" button Note that there is a link AND a button, coming from commit 928c0af2b6a2c7aa6ed54019c5bd7dbddbccf4ee Bug 15824 - 'Done' button is unclear on batch item modification and deletion I do not think it makes sense to have both. Signed-off-by: George Williams <george at nekls.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 05:51:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 04:51:43 +0000 Subject: [Koha-bugs] [Bug 24056] Capitalization: Cash Register ID on cash register management page In-Reply-To: <bug-24056-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24056-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24056-70-WJyD80htx5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24056 --- Comment #2 from PTFS Europe Sandboxes <sandboxes at ptfs-europe.com> --- Created attachment 95709 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95709&action=edit Bug 24056 : Capitalization: Cash Register ID on cash register management page When editing a cash register, Cash register ID doesn't follow our capitalization guidelines. This patch fixes that. To Test: 1) Turn on cash register usage in the system prefere https://bugs.koha-community.org/show_bug.cgi?id=6473 Signed-off-by: George Williams <george at nekls.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 05:52:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 04:52:18 +0000 Subject: [Koha-bugs] [Bug 24056] Capitalization: Cash Register ID on cash register management page In-Reply-To: <bug-24056-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24056-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24056-70-xyakGPUuvz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24056 George Williams (NEKLS) <george at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:17:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:17:56 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24080-70-YBDGE6mAVg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24081 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081 [Bug 24081] Add a 'discount' process to accounts -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 03:38:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 02:38:30 +0000 Subject: [Koha-bugs] [Bug 22848] Ability to merge suggestions In-Reply-To: <bug-22848-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22848-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22848-70-d8PmStKr7e@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22848 Lisette Scheer <lisetteslatah at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:01:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:01:48 +0000 Subject: [Koha-bugs] [Bug 22291] 'Batch modify' button on itemnumber causes internal server error if itemnumbers do not correspond to real items. In-Reply-To: <bug-22291-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22291-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22291-70-8FtBeDfvUj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22291 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Can you give us a step by step plan to recreate the problem please? I have try to use the SQL query from comment 1: - Create an order with 3 items - Receive - Remove an item - Execute the report => I see the 3 lines with an itemnumber that have been deleted (ie. do not longer exist in the items table). - Batch operation, delete items => I see 2 items to delete -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:04:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:04:30 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24080-70-moxVkQVNuu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95667|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 20:06:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 19:06:40 +0000 Subject: [Koha-bugs] [Bug 24075] Backdating a return to the exact due date and time results in the fine not being refunded In-Reply-To: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24075-70-3O1VEMzoHZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24075 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 15:38:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 14:38:03 +0000 Subject: [Koha-bugs] [Bug 23282] Show all columns in Batch Item Modification and Batch Item Deletion In-Reply-To: <bug-23282-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23282-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23282-70-VfcpT4YUlj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23282 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |In Discussion -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 14:18:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 13:18:31 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14825-70-Zzwr0bGlzF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|24080 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 [Bug 24080] Add a 'payout' process to accounts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:18:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:18:19 +0000 Subject: [Koha-bugs] [Bug 24081] Add a 'discount' process to accounts In-Reply-To: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24081-70-jYuDgMYTQp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|24080 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 [Bug 24080] Add a 'payout' process to accounts -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 14:18:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 13:18:41 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14825-70-e6SifBg0pf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|23442 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 [Bug 23442] Add a 'refund' process to accounts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 14:46:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 13:46:54 +0000 Subject: [Koha-bugs] [Bug 24061] Print List (opac-shelves.pl) broken in Chrome In-Reply-To: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24061-70-VdQKQHrphM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24061 --- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #16) > (In reply to Jonathan Druart from comment #15) > > Which versions of Firefox are you using? > > 70.0.1 I have exactly this version... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 14:18:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 13:18:41 +0000 Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts In-Reply-To: <bug-23442-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23442-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23442-70-56PrxdYt7x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14825 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:15:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:15:36 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24080-70-QkFAlMZ9z7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 18:17:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 17:17:05 +0000 Subject: [Koha-bugs] [Bug 14741] Selecting all child permissions doesn't select the top level check box In-Reply-To: <bug-14741-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14741-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14741-70-BsHTbhui9D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14741 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Set permissions doesn't |Selecting all child |tick the top level check |permissions doesn't select |box and doesn't clear child |the top level check box |check boxes | Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | Status|NEW |ASSIGNED --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- The first half of this report is still valid. I can't reproduce the second half (child checkboxes not becoming unchecked), so I'm modifying the report title. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 20:06:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 19:06:51 +0000 Subject: [Koha-bugs] [Bug 24075] Backdating a return to the exact due date and time results in the fine not being refunded In-Reply-To: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24075-70-rD1bwVfTku@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24075 --- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 95707 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95707&action=edit Bug 24075: Unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 06:07:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 05:07:54 +0000 Subject: [Koha-bugs] [Bug 24033] Fix column labelling on basket summary page (ecost) In-Reply-To: <bug-24033-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24033-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24033-70-vNLJ8UAnY9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24033 --- Comment #3 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 95710 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95710&action=edit Bug 24033 : Fix column labelling on basket summary page (ecost) When viewing a basket, some of the column names are unclear and are different than the terms used for the same field on the order form. This patch edits the column titles to match the order f Signed-off-by: George Williams <george at nekls.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:15:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:15:24 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14825-70-1aenksym8a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23442 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 [Bug 23442] Add a 'refund' process to accounts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:56:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:56:04 +0000 Subject: [Koha-bugs] [Bug 23254] Batch item modification and deletion handle leading and trailing spaces inconsistently In-Reply-To: <bug-23254-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23254-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23254-70-arJZuHHotE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23254 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |BLOCKED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:17:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:17:56 +0000 Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale' In-Reply-To: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13985-70-Muj8pyJbkJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24081 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081 [Bug 24081] Add a 'discount' process to accounts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:15:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:15:24 +0000 Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts In-Reply-To: <bug-23442-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23442-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23442-70-vHfi6NsDN2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |14825 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 14:17:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 13:17:55 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24080-70-Qv0L0hmrGt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|13985 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 06:09:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 05:09:42 +0000 Subject: [Koha-bugs] [Bug 24033] Fix column labelling on basket summary page (ecost) In-Reply-To: <bug-24033-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24033-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24033-70-liUXfT5ikT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24033 George Williams (NEKLS) <george at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:56:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:56:37 +0000 Subject: [Koha-bugs] [Bug 23254] Batch item modification and deletion handle leading and trailing spaces inconsistently In-Reply-To: <bug-23254-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23254-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23254-70-0wi9jSrxyi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23254 --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- This is the confusing screen: https://snipboard.io/b6nxN8.jpg -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 20:06:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 19:06:42 +0000 Subject: [Koha-bugs] [Bug 24075] Backdating a return to the exact due date and time results in the fine not being refunded In-Reply-To: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24075-70-kkshLfnJPm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24075 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95654|0 |1 is obsolete| | Attachment #95656|0 |1 is obsolete| | --- Comment #8 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 95706 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95706&action=edit Bug 24075: Backdating a return to the exact due date and time results in the fine not being refunded When you use the date picker or book drop mode and check in an item that is due on that date, a fine is assessed and not refunded. For example: item 12345 is due on 11/19/2109 23:59. On 11/20/2019 I check the item in using date picker/book drop setting the check in date to 11/19/2019 23:59, the patron is charged a fine, and the fine is not cleared as would be expected, since the item is being checked in before it is overdue. Test Plan: 1) Back date a checkout so it is overdue 2) Run fines.pl to generate the fine 3) Return the item, backdating to the same date/time is was due 4) Note the fine was not removed 5) Apply this patch 6) Repeat steps 1-3 7) Fine should be zeroed out now! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:03:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:03:52 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24080-70-0H1f7dbtqx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95668|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95672 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95672&action=edit Bug 24080: Add payout option to patron account page This enhancement adds a refined workflow to allow librarians to pay out money to patrons and record these payouts on the patrons account. The use case is that a patron has somehow accrued credit, through a refund perhaps, and the library wants to be able to physically hand over some money to balance the patrons account. Test plan: 1) Undertake a series of transactions that result in some outstanding credit on a patrons account. 2) Note that a new 'Issue payout' button appears next to a credit with an outstanding balance (but only if your user has the payout permission or is a superlibrarian) 3) Click the 'Issue payout' button and a modal should appear pre-populated with the amountoutstanding. 4) You should be able to edit the amount you wish to payout, make payment or cancel. 5) Signoff -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 18:17:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 17:17:35 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23260-70-5h7JJevJ2f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #30 from Agustín Moyano <agustinmoyano at theke.io> --- (In reply to Marcel de Rooy from comment #23) > my $before = $now + DateTime::Duration->new( days => 1 ); > That does not look good. Use add_days or something like that. Hi Marcel, I've updated the test code to use my $before = DateTime->now->add( days => 1 ); It certainly looks nicer now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:18:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:18:19 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24080-70-lDHWl7ChIi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|24081 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081 [Bug 24081] Add a 'discount' process to accounts -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 14:17:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 13:17:16 +0000 Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts In-Reply-To: <bug-23442-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23442-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23442-70-fPCsG4l4dD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|23355 |24080 Blocks|13985 |24081 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355 [Bug 23355] Add 'cashup' process to the accounts system https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 [Bug 24080] Add a 'payout' process to accounts https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081 [Bug 24081] Add a 'discount' process to accounts -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:04:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:04:36 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24080-70-RfV9sbORnb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:55:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:55:57 +0000 Subject: [Koha-bugs] [Bug 23254] Batch item modification and deletion handle leading and trailing spaces inconsistently In-Reply-To: <bug-23254-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23254-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23254-70-e3MW5sbFXy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23254 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.11 |master --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Marking as blocked until bug 23254 is resolved (and see if it fixes the issue from this bug report). -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:03:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:03:46 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24080-70-mmeWeiAK94@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95666|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95670 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95670&action=edit Bug 24080: Add 'payout' method to Koha::Account::Line This enhancement adds a 'payout' method to Koha::Account::Line which can be used to 'pay out' a credit to a patron. When such a credit is 'paid out' this method will create a corresponding account debit line with an amount equal to the amountoutstanding on the original credit and the two acocuntlines will be immediately applied against each other. Test Plan: 1) Run the included tests and verify they pass. 2) Signoff -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:17:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:17:56 +0000 Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23355-70-9HgYHffHEN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24081 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081 [Bug 24081] Add a 'discount' process to accounts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 19:31:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 18:31:35 +0000 Subject: [Koha-bugs] [Bug 15272] aqbookseller addresses are combined into "physical address" field In-Reply-To: <bug-15272-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15272-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15272-70-VVsFKcA7XE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15272 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master Assignee|jweaver at bywatersolutions.co |koha-bugs at lists.koha-commun |m |ity.org Status|ASSIGNED |NEW --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Perhaps the problem is that the system parses the data entered into the textarea and splits it based on line breaks. If you put in more than 4 lines of data the last line will get discarded. We should at the very least add a note to the field about the 4-line limit. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:03:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:03:49 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24080-70-8WFWXVWsUm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95671 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95671&action=edit Bug 24080: Add updatecharge payout permission Add a new subpermission called 'payout' to the 'updatecharges' permission group which will allow/prevent payout actions to be performed by staff. -- You are receiving this mail because: You are on the CC list for the bug. You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 14:17:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 13:17:16 +0000 Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23355-70-JtFg7urpDD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|23442 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 [Bug 23442] Add a 'refund' process to accounts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 20:05:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 19:05:16 +0000 Subject: [Koha-bugs] [Bug 24075] Backdating a return to the exact due date and time results in the fine not being refunded In-Reply-To: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24075-70-9eTqtkVHby@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24075 --- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> --- I like it! Updated patch incoming! (In reply to Martin Renvoize from comment #6) > Comment on attachment 95654 [details] [review] > Bug 24075: Backdating a return to the exact due date and time results in the > fine not being refunded > > Review of attachment 95654 [details] [review]: > ----------------------------------------------------------------- > > ::: C4/Circulation.pm > @@ +1966,4 @@ > > MarkIssueReturned( $borrowernumber, $item->itemnumber, $return_date, $patron->privacy ); > > }; > > unless ( $@ ) { > > + if ( $return_date_is_forced || ( C4::Context->preference('CalculateFinesOnReturn') && $is_overdue && !$item->itemlost ) ) { > > This feels somewhat wrong.. I'm sure Katrin would say "But we don't ever > want to recalculate fines if we have 'CalculateFinesOnReturn' turned off" > > So.. could this perhaps be: > > `if ( C4::Context->preference('CalculateFinesOnReturn') && > ($return_date_is_forced || $is_overdue) && !$item->itemlost ) {` > > Instead? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 11:49:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 10:49:40 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23260-70-VMhAWlLMbm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #24 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Hmm sub last_returned_by { my ( $self, $borrower ) = @_; my $items_last_returned_by_rs = Koha::Database->new()->schema()->resultset('ItemsLastBorrower'); Not so nice in Koha::Item. (Possibly out of scope though) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 15:39:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 14:39:57 +0000 Subject: [Koha-bugs] [Bug 23254] Batch item modification and deletion handle leading and trailing spaces inconsistently In-Reply-To: <bug-23254-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23254-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23254-70-xN9219sRrB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23254 --- Comment #4 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- I just signed off bug 23800. While testing that, I also tested this. I created items with the barcodes "123 " and " 123" Without the patch for bug 23800, putting "123" in my list of barcode for batch item mod found the item with barcode "123 " but gave an erroneous barcode not found error. It did not find " 123" at all. With the patch and the same two barcodes in the system, I entered "123" into item batch mod and it didn't find anything. Then I entered " 123" and "123 " into item batch mod and they didn't find anything either. So the patch from 23800 has changed this behavior, but doesn't seem to have fixed it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 14:17:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 13:17:16 +0000 Subject: [Koha-bugs] [Bug 24081] Add a 'discount' process to accounts In-Reply-To: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24081-70-foGsq4z8Bv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23442 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 [Bug 23442] Add a 'refund' process to accounts -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 14:17:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 13:17:55 +0000 Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale' In-Reply-To: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13985-70-g9hY01DVUV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|24080 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 [Bug 24080] Add a 'payout' process to accounts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 14:17:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 13:17:10 +0000 Subject: [Koha-bugs] [Bug 24031] Add plugin hook after_hold_create In-Reply-To: <bug-24031-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24031-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24031-70-2nOEVr7cNE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24031 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 15:37:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 14:37:40 +0000 Subject: [Koha-bugs] [Bug 23282] Show all columns in Batch Item Modification and Batch Item Deletion In-Reply-To: <bug-23282-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23282-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23282-70-GTVWyWTrLO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23282 --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95660 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95660&action=edit Bug 23282: Display all item's subfields when batch item editing This is a start, but the display needs to be adjusted. Also there is something wrong in the logic (.pl). What is supposed to happen if a librarian decides to display in tab 10 a subfield that is not part of 942? Should we allow that? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:03:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:03:43 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24080-70-SVY9BUCr9z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95665|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95669 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95669&action=edit Bug 24080: Payout account debit type -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 14:18:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 13:18:31 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24080-70-VYGLzaGFCZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|14825 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 06:08:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 05:08:28 +0000 Subject: [Koha-bugs] [Bug 24033] Fix column labelling on basket summary page (ecost) In-Reply-To: <bug-24033-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24033-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24033-70-zPPo1ffOJ2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24033 George Williams (NEKLS) <george at nekls.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |george at nekls.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 14:17:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 13:17:16 +0000 Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale' In-Reply-To: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13985-70-pEg8anpoNm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|23442 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 [Bug 23442] Add a 'refund' process to accounts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 22:48:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 21:48:08 +0000 Subject: [Koha-bugs] [Bug 14527] zebra error 114 when searching for items added before or after a specific date In-Reply-To: <bug-14527-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14527-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14527-70-TtpszFntRm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14527 George Veranis <gveranis at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gveranis at gmail.com --- Comment #32 from George Veranis <gveranis at gmail.com> --- it is still valid at version 19.05 for unimarc. One way to solve it is to add zebra index for 995$5 or to use the script for the maintenance. It would more easy for libraries to added to zebra index configuration in my opinion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:17:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:17:56 +0000 Subject: [Koha-bugs] [Bug 24081] New: Add a 'discount' process to accounts Message-ID: <bug-24081-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081 Bug ID: 24081 Summary: Add a 'discount' process to accounts Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, koha-bugs at lists.koha-community.org, testopia at bugs.koha-community.org Depends on: 23355, 24080 Blocks: 13985, 14825 There are times when a staff member wishes to record and apply to a fine on a patrons account. We should add a formal method/workflow for this requirement. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 [Bug 14825] Accounts Rewrite Omnibus https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355 [Bug 23355] Add 'cashup' process to the accounts system https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 [Bug 24080] Add a 'payout' process to accounts -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:17:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:17:56 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14825-70-AKyN68UuQj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24081 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081 [Bug 24081] Add a 'discount' process to accounts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 12:15:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 11:15:36 +0000 Subject: [Koha-bugs] [Bug 14825] Accounts Rewrite Omnibus In-Reply-To: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14825-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14825-70-OiOQfFq04f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14825 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24080 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 [Bug 24080] Add a 'payout' process to accounts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 19:20:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 18:20:48 +0000 Subject: [Koha-bugs] [Bug 24084] PlainMARC view broken on OPAC if other $.ajax calls produce errors In-Reply-To: <bug-24084-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24084-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24084-70-9cezAcfjuP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24084 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 14:10:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 13:10:35 +0000 Subject: [Koha-bugs] [Bug 24031] Add plugin hook after_hold_create In-Reply-To: <bug-24031-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24031-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24031-70-Cgj3UEHMBi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24031 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95358|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 95657 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95657&action=edit Bug 24031: Add plugin hook after_hold_create It is called after a hold has been placed Test plan: 1. Write a plugin that implements only after_hold_create (see `perldoc Koha::Plugins` for implementation details). Install it and enable it 2. Place a hold and verify that your plugin method has been called with the right parameters Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 21:44:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 20:44:07 +0000 Subject: [Koha-bugs] [Bug 24085] Double submission of forms on returns.pl In-Reply-To: <bug-24085-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24085-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24085-70-YcxKk7xzkH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24085 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 16:47:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 15:47:06 +0000 Subject: [Koha-bugs] [Bug 24061] Print List (opac-shelves.pl) broken in Chrome In-Reply-To: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24061-70-GSVUVFRMj3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24061 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #21 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #20) > Not with Chrome... https://www.w3schools.com/tags/ev_onafterprint.asp It says from Chrome 63, so I think it's the way to go. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 14:17:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 13:17:16 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24080-70-nDDdgmUykc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23442 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 [Bug 23442] Add a 'refund' process to accounts -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are on the CC list for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:14:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:14:37 +0000 Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts In-Reply-To: <bug-23442-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23442-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23442-70-qRQOwbA5Lm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95675 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95675&action=edit Bug 23442: Add 'reduce' method to Koha::Account::Line This enhancement adds a 'reduce' method to Koha::Account::Line which can be used to reduce a charge/debit by adding a credit to offset against the amount outstanding. It may be used to apply a discount whilst retaining the original debit amounts or to apply a full or partial refund for example when a lost item is found and returned. The created credit will be immediately applied against the debit unless the debit has already been paid, in which case a 'zero' offset will be added to maintain a link to the debit but the outstanding credit will be left so it may be applied to other debts. Test Plan: 1) Run the included tests and verify they pass. 2) Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 14:43:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 13:43:18 +0000 Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23355-70-Wkj1zHq7X4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24082 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24082 [Bug 24082] Add a 'refund' option to anonymous payments -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 10:13:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 09:13:14 +0000 Subject: [Koha-bugs] [Bug 17406] Simplify pay.pl interface buttons In-Reply-To: <bug-17406-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17406-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17406-70-4qaVu5Rnad@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17406 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|17596 | CC| |martin.renvoize at ptfs-europe | |.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17596 [Bug 17596] Simplify accounting UI in staff client -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 10:12:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 09:12:44 +0000 Subject: [Koha-bugs] [Bug 17596] Simplify accounting UI in staff client In-Reply-To: <bug-17596-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17596-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17596-70-vyjDv5cosg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17596 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|17734 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 [Bug 17734] Make possible to pay and writeoff from boraccount page and make action buttons split button -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 10:14:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 09:14:56 +0000 Subject: [Koha-bugs] [Bug 17702] Create configuration for account types In-Reply-To: <bug-17702-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17702-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17702-70-oQ2zhRGqzx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17702 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|23049 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 14:40:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 13:40:19 +0000 Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale' In-Reply-To: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13985-70-Zc6r39p7tP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|24081 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24081 [Bug 24081] Add a 'discount' process to accounts -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 14:42:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 13:42:48 +0000 Subject: [Koha-bugs] [Bug 24082] New: Add a 'refund' option to anonymous payments Message-ID: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24082 Bug ID: 24082 Summary: Add a 'refund' option to anonymous payments Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org With bug 23442 we add a process for recording refunds to patrons. We need to expand this for anonymous payments once bug 23354 is available. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 14:10:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 13:10:45 +0000 Subject: [Koha-bugs] [Bug 24031] Add plugin hook after_hold_create In-Reply-To: <bug-24031-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24031-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24031-70-ojokIHdweF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24031 --- Comment #3 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 95658 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95658&action=edit Bug 24031: Fix warnings Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:58:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:58:13 +0000 Subject: [Koha-bugs] [Bug 24075] Backdating a return to the exact due date and time results in the fine not being refunded In-Reply-To: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24075-70-rFOntDrfgG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24075 --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Comment on attachment 95654 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95654 Bug 24075: Backdating a return to the exact due date and time results in the fine not being refunded Review of attachment 95654: --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=24075&attachment=95654) ----------------------------------------------------------------- ::: C4/Circulation.pm @@ +1966,4 @@ > MarkIssueReturned( $borrowernumber, $item->itemnumber, $return_date, $patron->privacy ); > }; > unless ( $@ ) { > + if ( $return_date_is_forced || ( C4::Context->preference('CalculateFinesOnReturn') && $is_overdue && !$item->itemlost ) ) { This feels somewhat wrong.. I'm sure Katrin would say "But we don't ever want to recalculate fines if we have 'CalculateFinesOnReturn' turned off" So.. could this perhaps be: `if ( C4::Context->preference('CalculateFinesOnReturn') && ($return_date_is_forced || $is_overdue) && !$item->itemlost ) {` Instead? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:44:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:44:32 +0000 Subject: [Koha-bugs] [Bug 24072] Typos in advance_notices.pl causes DUEDGST not to be sent In-Reply-To: <bug-24072-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24072-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24072-70-2GD5H1l4kw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24072 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_19_11_candidate -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 14:43:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 13:43:48 +0000 Subject: [Koha-bugs] [Bug 23355] Add 'cashup' process to the accounts system In-Reply-To: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23355-70-0ZBuUFsBz0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|13985 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 18:29:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 17:29:07 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23260-70-ZVk4dxX3cO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #32 from Agustín Moyano <agustinmoyano at theke.io> --- (In reply to Marcel de Rooy from comment #25) > $items_last_returned_by_rs->update_or_create( > { borrowernumber => $borrower->borrowernumber, itemnumber => > $self->id } ); > > So it might be better to KEEP the UPDATE clause but RENAME the field. I agree that the created_on column should be renamed to updated_on, or maybe we should have both columns, but I believe this should be done in a separate bug.. we have to analyze the impact of such a change Thanks for QAing! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 10:13:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 09:13:14 +0000 Subject: [Koha-bugs] [Bug 17596] Simplify accounting UI in staff client In-Reply-To: <bug-17596-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17596-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17596-70-3YSHY93rHr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17596 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|17406 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17406 [Bug 17406] Simplify pay.pl interface buttons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 18:26:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 17:26:04 +0000 Subject: [Koha-bugs] [Bug 14741] Selecting all child permissions doesn't select the top level check box In-Reply-To: <bug-14741-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14741-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14741-70-Lq2aUagYzb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14741 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 10:12:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 09:12:17 +0000 Subject: [Koha-bugs] [Bug 17596] Simplify accounting UI in staff client In-Reply-To: <bug-17596-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17596-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17596-70-YM5D1ZEKuP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17596 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|24079 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24079 [Bug 24079] Convert paycollect 'page' to a modal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:14:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:14:40 +0000 Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts In-Reply-To: <bug-23442-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23442-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23442-70-QEp12Ak6zQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95676 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95676&action=edit Bug 23442: Add refund permission Add a new subpermission called 'refund' to the 'updatecharges' permission group which will allow/prevent refund actions to be performed by staff. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:14:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:14:44 +0000 Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts In-Reply-To: <bug-23442-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23442-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23442-70-Z8ulRGilv3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95677 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95677&action=edit Bug 23442: Add refund option to patron account page This enhancement adds a refined workflow to allow librarians to refund payments to patrons and record these refunds on the patrons account. The use case is that a patron has paid for something before then performing an action that may require some level of refund to be actioned. Perhaps they are returning a lost and paid for book. Test plan: 1) Undertake a series of transactions that result in a debit accountline being partially or fully paid off. 2) Note that a new 'Issue refund' button appears next to a debit (but only if your user has the refund permission or is a superlibrarian) 3) Click the 'Issue refund' button and a modal should appear pre-populated with the amount - amountoutstanding. 4) You should be able to edit the amount you wish to refund, record the refund or cancel. 5) Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 15:53:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 14:53:22 +0000 Subject: [Koha-bugs] [Bug 23482] BakerTaylor images broken on opac lists In-Reply-To: <bug-23482-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23482-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23482-70-MgxlC5O3rz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #92390|0 |1 is obsolete| | --- Comment #2 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 95661 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95661&action=edit Bug 23482: Fix BakerTaylor cover images on lists While this needs a username/pass to fully test, it should be possible to verify the code changes by comparing to opac-results code To test: 1 - Enable BakerTaylor images 2 - Enter your usernme and password 3 - Do not fill the BookStore URL 4 - Verify OPAC covers are working 5 - Save some times with covers to a public list 6 - Verify they do not display in list 7 - Apply patch 8 - Verify images now work Signed-off-by: Kelly McElligott <kelly at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 15:55:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 14:55:04 +0000 Subject: [Koha-bugs] [Bug 23482] BakerTaylor images broken on opac lists In-Reply-To: <bug-23482-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23482-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23482-70-t5vJuStr2H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23482 Kelly McElligott <kelly at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly at bywatersolutions.com --- Comment #3 from Kelly McElligott <kelly at bywatersolutions.com> --- I contacted the library that submitted this bug to us and they provided me with their B&T user name and password, this patch works as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 14:43:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 13:43:18 +0000 Subject: [Koha-bugs] [Bug 24082] Add a 'refund' option to anonymous payments In-Reply-To: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24082-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24082-70-2GeFrIen6u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24082 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |13985 Depends on| |23355 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 [Bug 13985] Cash Management - Koha as 'Point of Sale' https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355 [Bug 23355] Add 'cashup' process to the accounts system -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:41:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:41:42 +0000 Subject: [Koha-bugs] [Bug 24013] Transferring a checked out item gives a software error In-Reply-To: <bug-24013-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24013-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24013-70-PPIhyBYYW4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24013 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95609|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95696 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95696&action=edit Bug 24013: Fix transferbook if item is checked out Wrong conflict resolution, the following commit 6eade474ed3a84a5ba372a26ac27bf9fb4bd2299 Bug 18276: Remove GetBiblioFromItemNumber - Easy ones restored a previous change from commit 546379cc92b733cb29a0b70247a72c770afdad26 Bug 17680: C4::Circulation - Remove GetItemIssue, simple calls Not that "easy" or "simple"... Test plan: Run the test before and after this patch. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:14:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:14:34 +0000 Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts In-Reply-To: <bug-23442-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23442-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23442-70-lbAJUp6X6U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95674 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95674&action=edit Bug 23442: Add account credit types -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:42:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:42:23 +0000 Subject: [Koha-bugs] [Bug 24013] Transferring a checked out item gives a software error In-Reply-To: <bug-24013-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24013-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24013-70-PM41clqENO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24013 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |martin.renvoize at ptfs-europe | |.com --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Thanks for the quick fix, works well.. Signing off. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 21:44:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 20:44:41 +0000 Subject: [Koha-bugs] [Bug 24085] Double submission of forms on returns.pl In-Reply-To: <bug-24085-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24085-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24085-70-e8Wm46ePHu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24085 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | CC| |oleonard at myacpl.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:43:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:43:52 +0000 Subject: [Koha-bugs] [Bug 24072] Typos in advance_notices.pl causes DUEDGST not to be sent In-Reply-To: <bug-24072-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24072-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24072-70-6t8OuclojS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24072 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95617|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95697 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95697&action=edit Bug 24072 - Typos in advance_notices.pl causes DUEDGST not to be sent There are two typos in advance_notics.pl that cause DUEDGST messages not to be sent. See Bugzilla for full details. If you think the typo is sufficiently obvious, you can just eyeball the patch and sign off, methinks. Otherwise, testing can be done something like this: - Make sure you have enabled enhanced messaging preferences, and a patron with "Email" and "Digests only" set for "Item due" messages - Issue an item to this patron, with due date today - Run something like this to generate advance notices: $ sudo koha-shell -c "perl \ /home/vagrant/kohaclone/misc/cronjobs/advance_notices.pl -n -c" kohadev - See that no notices are shown (-n means messages will go to stdout, instead of into the message queue). - Apply the patch and run advance_notices.pl again, as before. A DUEDGST message should now be displayed. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 15:50:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 14:50:59 +0000 Subject: [Koha-bugs] [Bug 23254] Batch item modification and deletion handle leading and trailing spaces inconsistently In-Reply-To: <bug-23254-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23254-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23254-70-EofdqHLeRh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23254 --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Andrew Fuerste-Henry from comment #4) > I just signed off bug 23800. While testing that, I also tested this. > > I created items with the barcodes "123 " and " 123" > Without the patch for bug 23800, putting "123" in my list of barcode for > batch item mod found the item with barcode "123 " but gave an erroneous > barcode not found error. It did not find " 123" at all. > With the patch and the same two barcodes in the system, I entered "123" into > item batch mod and it didn't find anything. Then I entered " 123" and "123 " > into item batch mod and they didn't find anything either. > So the patch from 23800 has changed this behavior, but doesn't seem to have > fixed it. Yes, and it cannot work, it is the expected behavior :) But, since bug 22996 you can define the separator, so try to remove \s from the separator list and try again, it should work. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 10:12:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 09:12:17 +0000 Subject: [Koha-bugs] [Bug 24079] Convert paycollect 'page' to a modal In-Reply-To: <bug-24079-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24079-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24079-70-WLxgxaQ3tZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24079 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|17596 |17735 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17596 [Bug 17596] Simplify accounting UI in staff client https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17735 [Bug 17735] Merge boraccount and pay pages into one -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 21:44:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 20:44:09 +0000 Subject: [Koha-bugs] [Bug 24085] Double submission of forms on returns.pl In-Reply-To: <bug-24085-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24085-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24085-70-48SmMa27pm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24085 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95708 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95708&action=edit Bug 24085: Make print and cancel-hold buttons instead of submit To test: 1 - Place a hold on an item 2 - Check in the item to trigger the hold 3 - Test both the print and cancel buttons to make sure all looks correct -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 19:22:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 18:22:15 +0000 Subject: [Koha-bugs] [Bug 24084] PlainMARC view broken on OPAC if other $.ajax calls produce errors In-Reply-To: <bug-24084-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24084-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24084-70-i4ndBJHHE1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24084 Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mkstephens at lancasterseminar | |y.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 14:43:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 13:43:18 +0000 Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale' In-Reply-To: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13985-70-0gxueRsRXx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24082 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24082 [Bug 24082] Add a 'refund' option to anonymous payments -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 16:14:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 15:14:16 +0000 Subject: [Koha-bugs] [Bug 23352] Set serial issue default values when creating a subscription in serials/subscription-add.pl In-Reply-To: <bug-23352-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23352-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23352-70-IXRzjYenA4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23352 Martha Fuerst <mfuerst at hmcpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mfuerst at hmcpl.org --- Comment #17 from Martha Fuerst <mfuerst at hmcpl.org> --- Created attachment 95662 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95662&action=edit Error trace - save subscription Could not save a new subscription to get through the test plan. Clicking "Save Subscription" results in an Error Trace. Attaching error trace in .txt file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 21:40:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 20:40:31 +0000 Subject: [Koha-bugs] [Bug 24085] New: Double submission of forms on returns.pl Message-ID: <bug-24085-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24085 Bug ID: 24085 Summary: Double submission of forms on returns.pl Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com The .print and .cancel-hold buttons in returns.tt have an event tied to the click, this adjusts some inputs and submits the forms. The buttons themselves are also submit buttons. We should only have one method of submitting the form. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 10:12:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 09:12:44 +0000 Subject: [Koha-bugs] [Bug 17734] Make possible to pay and writeoff from boraccount page and make action buttons split button In-Reply-To: <bug-17734-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17734-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17734-70-ot4pC9w8pQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17734 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Blocks|17596 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17596 [Bug 17596] Simplify accounting UI in staff client -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:14:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:14:58 +0000 Subject: [Koha-bugs] [Bug 23442] Add a 'refund' process to accounts In-Reply-To: <bug-23442-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23442-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23442-70-HbhhiDiTh0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23442 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 14:43:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 13:43:48 +0000 Subject: [Koha-bugs] [Bug 13985] Cash Management - Koha as 'Point of Sale' In-Reply-To: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13985-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13985-70-iE2jvY5w37@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13985 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|23355 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23355 [Bug 23355] Add 'cashup' process to the accounts system -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 19:10:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 18:10:38 +0000 Subject: [Koha-bugs] [Bug 23800] Batch modification tool orders items by barcode incremental by default (regression to 17.11) In-Reply-To: <bug-23800-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23800-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23800-70-NswckzO51i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 Lisette Scheer <lisetteslatah at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 10:12:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 09:12:17 +0000 Subject: [Koha-bugs] [Bug 17735] Merge boraccount and pay pages into one In-Reply-To: <bug-17735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17735-70-VNX25EilCz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17735 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |24079 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24079 [Bug 24079] Convert paycollect 'page' to a modal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 18:26:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 17:26:07 +0000 Subject: [Koha-bugs] [Bug 14741] Selecting all child permissions doesn't select the top level check box In-Reply-To: <bug-14741-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14741-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14741-70-uDhp3VyCZE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14741 --- Comment #3 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 95702 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95702&action=edit Bug 14741: Selecting all child permissions doesn't select the top level check box This patch modifies the patron flags page so that manually selecting all the child permissions also checks the checkbox for the parent permission. To test, apply the patch, open a patron record, select More -> Set permissions. - Expand a set of permissions, for instance "Add, modify, and view patron information." - If any boxes are checked, uncheck them. - Check each of the "child" checkboxes ("Add, modify, and view..." and "View patron infos..." ). - When both checkboxes are checked, the "Add, modify, and view" parent permission should be automatically checked. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 14:10:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 13:10:33 +0000 Subject: [Koha-bugs] [Bug 24031] Add plugin hook after_hold_create In-Reply-To: <bug-24031-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24031-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24031-70-4JSi0Zgmnr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24031 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 09:47:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 08:47:17 +0000 Subject: [Koha-bugs] [Bug 23900] Label maker cannot concatenate database fields In-Reply-To: <bug-23900-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23900-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23900-70-myy1A7LaRH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23900 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy at rijksmuseum.nl --- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Please add tests :) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:41:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:41:38 +0000 Subject: [Koha-bugs] [Bug 24013] Transferring a checked out item gives a software error In-Reply-To: <bug-24013-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24013-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24013-70-Vmq77xHNmo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24013 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95608|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95695 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95695&action=edit Bug 24013: Add tests Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:44:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:44:23 +0000 Subject: [Koha-bugs] [Bug 24072] Typos in advance_notices.pl causes DUEDGST not to be sent In-Reply-To: <bug-24072-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24072-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24072-70-to1hVX33qQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24072 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Trivial patch, works, Signing off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 14:52:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 13:52:58 +0000 Subject: [Koha-bugs] [Bug 24083] New: Koha should support "seen" vs "unseen" renewals Message-ID: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Bug ID: 24083 Summary: Koha should support "seen" vs "unseen" renewals Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: andrew.isherwood at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When carrying out a renewal transaction Koha should check for both the maximum number of renewals allowed and also the number of unseen renewals. If it finds a value equal to or greater than the number of renewals already carried out against that loan, it prevents the renewal. The purpose of this is to prevent borrowers from continually renewing a book when they have, in fact, lost or misplaced it! When a renewal takes place via a method that doesn't require visible sight or possession of the item (e.g. OPAC, automatic renewal) then the number of unseen renewals for that item should be incremented. SIP2 renewals can be considered seen since they will require the physical item to be scanned. The number of allowed unseen renewals before a renewal is denied should be specifiable in the circulation rules. If a renewal is denied due to the unseen maximum having been reached, the flow should be the same as when a renewal limit has been reached, though with appropriate messages displayed to the user. It should be possible to override the denial in the same was as when a renewal limit is reached. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 14:54:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 13:54:02 +0000 Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen" renewals In-Reply-To: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24083-70-0guO18UrLx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |andrew.isherwood at ptfs-europ |ity.org |e.com Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 21 17:58:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 21 Nov 2019 16:58:26 +0000 Subject: [Koha-bugs] [Bug 24075] Backdating a return to the exact due date and time results in the fine not being refunded In-Reply-To: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24075-70-hb8tptlpna@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24075 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 10:07:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 09:07:32 +0000 Subject: [Koha-bugs] [Bug 24061] Print List (opac-shelves.pl) broken in Chrome In-Reply-To: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24061-70-wwfI0VLB2F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24061 --- Comment #23 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Waiting for 1 second before closing the window? Looks very ugly to me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 10:14:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 09:14:18 +0000 Subject: [Koha-bugs] [Bug 24086] New: Update manual on placeholders for default values Message-ID: <bug-24086-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24086 Bug ID: 24086 Summary: Update manual on placeholders for default values Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Manual Severity: enhancement Priority: P5 - low Component: Documentation Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org I was looking for a description of a specific feature in Koha that allows automatic adding of some values (like dates) in records. I've found in the manual: https://koha-community.org/manual/19.05/en/html/administration.html#marc-bibliographic-frameworks-label If you would like a field to fill in with today’s date you can use the YYYY MM DD syntax in the ‘Default value’. For example: a default of “Year:YYYY Month:MM Day:DD” (without quotes) will print as “Year:2015 Month:11 Day:30” But I think the syntax has been updated to include << >> a longer while ago, so the documentation needs to be fixed and completed: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7045#c30 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 10:17:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 09:17:20 +0000 Subject: [Koha-bugs] [Bug 24061] Print List (opac-shelves.pl) broken in Chrome In-Reply-To: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24061-70-QeUu4h8Pdy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24061 --- Comment #24 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95715 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95715&action=edit Bug 24061: close after timeout if onafterprint no supported Not supported on Chrome < 63 https://www.w3schools.com/tags/ev_onafterprint.asp -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 10:17:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 09:17:56 +0000 Subject: [Koha-bugs] [Bug 24061] Print List (opac-shelves.pl) broken in Chrome In-Reply-To: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24061-70-8kCsVsiPc3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24061 --- Comment #25 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Let's do both then... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 10:34:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 09:34:47 +0000 Subject: [Koha-bugs] [Bug 24075] Backdating a return to the exact due date and time results in the fine not being refunded In-Reply-To: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24075-70-H8XdLUKkJR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24075 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Depends on| |14591 --- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I would say it has been caused by commit 467c24cb9da02deb00bf49333351a0843cdeda10 Bug 14591: book drop / drop box mode incorrectly decrements accrued overdue fines Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 10:34:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 09:34:47 +0000 Subject: [Koha-bugs] [Bug 14591] book drop / drop box mode incorrectly decrements accrued overdue fines In-Reply-To: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14591-70-dVuaSzo0n6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14591 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24075 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24075 [Bug 24075] Backdating a return to the exact due date and time results in the fine not being refunded -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 10:38:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 09:38:26 +0000 Subject: [Koha-bugs] [Bug 14911] Serial Subscr. and Item search: Display additional 245 subfields in search results In-Reply-To: <bug-14911-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14911-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14911-70-E9CYsba8bc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14911 Ray Delahunty <r.delahunty at arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty at arts.ac.uk --- Comment #2 from Ray Delahunty <r.delahunty at arts.ac.uk> --- Staff here are also keen to see more fields of the MARC21 245 displayed, not only in the serials-search.pl results, but more generally throughout the acquisitions area. We are waiting to see what comes with 19.11 with the new fields in the biblio table (bug 11529). Is the ease of adding subfields in search results suggested in this bug down to the addition being limited to them displaying rather than them being included in the searching (See https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23499)? If inclusion of the additional subfields in the search is complex I think my colleagues would be somewhat happy with having them simply displaying in the search results. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 11:03:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 10:03:27 +0000 Subject: [Koha-bugs] [Bug 23702] New UNIMARC XSLT according to last IFLA updates In-Reply-To: <bug-23702-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23702-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23702-70-hOFG7O8nne@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23702 jmbroust <jean-manuel.broust at univ-lyon2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jean-manuel.broust at univ-lyo | |n2.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 11:03:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 10:03:58 +0000 Subject: [Koha-bugs] [Bug 20424] New UNIMARC ZEBRA indexes according to last IFLA updates In-Reply-To: <bug-20424-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20424-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20424-70-Kh0hMJ2L7h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20424 jmbroust <jean-manuel.broust at univ-lyon2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jean-manuel.broust at univ-lyo | |n2.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 11:04:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 10:04:26 +0000 Subject: [Koha-bugs] [Bug 18309] UNIMARC update from IFLA for new Koha installations In-Reply-To: <bug-18309-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18309-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18309-70-1jvCxCXdQh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18309 jmbroust <jean-manuel.broust at univ-lyon2.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jean-manuel.broust at univ-lyo | |n2.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 11:06:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 10:06:18 +0000 Subject: [Koha-bugs] [Bug 24071] Ask for complete information when opening a bug report In-Reply-To: <bug-24071-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24071-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24071-70-HT8XXNf6ED@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24071 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think we should not overcomplicate filing a bug report as it's already proven to be a hurdle to a lot of people I talked to. I didn't think it was, so was really surprised at first, but people are a bit 'scared' of bugzilla at the moment. I think if we add more technical requirements, it will just make it even worse. What we could do: Add information pages on how to retrieve the information you mentioned to the wiki or the manual and point to them whenever we need them. So let's say someone filed a bug, that is not clear in itself, we can have the bug wranglers ask for the information and use the links with detailed explanations on how to do it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 11:15:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 10:15:27 +0000 Subject: [Koha-bugs] [Bug 24071] Ask for complete information when opening a bug report In-Reply-To: <bug-24071-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24071-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24071-70-pbBuCAr6JI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24071 --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- What I was suggesting is to ask them to copy/paste a given block of info from about.pl for instance, that would not require any technical skills or extra complications. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 11:33:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 10:33:47 +0000 Subject: [Koha-bugs] [Bug 24087] New: item's subfields (952|995) must be displayed on tab 10 Message-ID: <bug-24087-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24087 Bug ID: 24087 Summary: item's subfields (952|995) must be displayed on tab 10 Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org In the biblio frameworks we let the possibility to select a specific tab to display subfields. In some part there is code that handles (quite awkwardly) this possibility, but globally Koha is assuming the item's subfields must be in tab 10. I think it would make sense to simplify/clean the code and enforce that on the UI (framework edition): Hide "tab 10" for any fields != 952|995 and display only "tab 10" for 952|995. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 11:34:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 10:34:36 +0000 Subject: [Koha-bugs] [Bug 24087] item's subfields (952|995) must be displayed on tab 10 In-Reply-To: <bug-24087-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24087-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24087-70-XslysBV7UJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24087 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- For instance, to build the list of item's fields in tools/batchMod.pl 332 foreach my $tag (sort keys %{$tagslib}) { 333 # loop through each subfield 334 foreach my $subfield (sort keys %{$tagslib->{$tag}}) { 335 next if IsMarcStructureInternal( $tagslib->{$tag}{$subfield} ); 336 next if (not $allowAllSubfields and $restrictededition && !grep { $tag . '$' . $subfield eq $_ } @subfieldsToAllow ); 337 next if ($tagslib->{$tag}->{$subfield}->{'tab'} ne "10"); -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 11:35:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 10:35:00 +0000 Subject: [Koha-bugs] [Bug 23282] Show all columns in Batch Item Modification and Batch Item Deletion In-Reply-To: <bug-23282-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23282-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23282-70-8b0XntEcg4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23282 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24087 --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Jonathan Druart from comment #2) > Created attachment 95660 [details] [review] > Bug 23282: Display all item's subfields when batch item editing > > This is a start, but the display needs to be adjusted. > > Also there is something wrong in the logic (.pl). > > What is supposed to happen if a librarian decides to display in tab 10 a > subfield that is not part of 942? > Should we allow that? I opened a new bug report for that, see bug 24087. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 11:35:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 10:35:00 +0000 Subject: [Koha-bugs] [Bug 24087] item's subfields (952|995) must be displayed on tab 10 In-Reply-To: <bug-24087-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24087-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24087-70-2rDP8RAW3b@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24087 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23282 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 11:47:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 10:47:27 +0000 Subject: [Koha-bugs] [Bug 24060] [19.05] Can't load patron clubs tab on patron details page In-Reply-To: <bug-24060-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24060-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24060-70-jVV4AaC1wa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24060 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Pushed to 19.05.x for 19.05.06 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 11:47:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 10:47:34 +0000 Subject: [Koha-bugs] [Bug 24060] [19.05] Can't load patron clubs tab on patron details page In-Reply-To: <bug-24060-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24060-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24060-70-hw3912QfSK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24060 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.05.06 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 11:49:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 10:49:02 +0000 Subject: [Koha-bugs] [Bug 23827] [19.05] Cash register statistics uses old accounttype values In-Reply-To: <bug-23827-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23827-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23827-70-29bh5mkXhC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23827 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 11:49:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 10:49:22 +0000 Subject: [Koha-bugs] [Bug 24060] [19.05] Can't load patron clubs tab on patron details page In-Reply-To: <bug-24060-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24060-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24060-70-xoZjgYjyBW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24060 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to stable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 11:52:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 10:52:32 +0000 Subject: [Koha-bugs] [Bug 24071] Ask for complete information when opening a bug report In-Reply-To: <bug-24071-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24071-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24071-70-oAgnPCahvE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24071 --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- I like the templates you can use in github issues.. shame bugzilla doesn't support similar. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 11:54:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 10:54:46 +0000 Subject: [Koha-bugs] [Bug 6473] Test bug for Git-bz In-Reply-To: <bug-6473-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6473-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6473-70-vj5g4QnPLT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6473 --- Comment #227 from Julian Maurice <julian.maurice at biblibre.com> --- Created attachment 95716 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95716&action=edit Add 'Test' to README.md -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 12:04:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 11:04:58 +0000 Subject: [Koha-bugs] [Bug 24010] Number of issues to display to staff accepts non-integer values In-Reply-To: <bug-24010-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24010-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24010-70-mOGI33H5lX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24010 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 12:33:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 11:33:55 +0000 Subject: [Koha-bugs] [Bug 17229] ILS-DI HoldTitle and HoldItem should check if patron is expired In-Reply-To: <bug-17229-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17229-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17229-70-cOuWqfq30A@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17229 --- Comment #36 from Arthur Suzuki <arthur.suzuki at biblibre.com> --- (In reply to Magnus Enger from comment #35) > This can not really be tested before this bug is fixed: > Bug 23710 - Holds broken, displays a JSON page with an error this bug has been resolved fixed :) Also this could have been tested using curl and trying to put a hold through ILS-DI -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 12:34:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 11:34:33 +0000 Subject: [Koha-bugs] [Bug 24010] Number of issues to display to staff accepts non-integer values In-Reply-To: <bug-24010-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24010-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24010-70-Z7Nb2cULvr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24010 --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95717 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95717&action=edit Bug 24010: DB Changes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 12:34:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 11:34:37 +0000 Subject: [Koha-bugs] [Bug 24010] Number of issues to display to staff accepts non-integer values In-Reply-To: <bug-24010-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24010-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24010-70-gLeHbAQKxi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24010 --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95718 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95718&action=edit Bug 24010: Enforce integer values for staffdisplaycount and opacdisplaycount -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 12:37:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 11:37:18 +0000 Subject: [Koha-bugs] [Bug 24010] Number of issues to display to staff accepts non-integer values In-Reply-To: <bug-24010-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24010-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24010-70-idsI4BGGJK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24010 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |oleonard at myacpl.org --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- The second patch does not work as expected. I am struggling to make the validation work on the form. It seems that the validate jQuery function collides with the validated class put on the form. Owen, is it clear for you what we should do in this case? I have also tried type="number" but it does not block form submission. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 12:41:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 11:41:01 +0000 Subject: [Koha-bugs] [Bug 24010] Number of issues to display to staff accepts non-integer values In-Reply-To: <bug-24010-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24010-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24010-70-n50zYSov2y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24010 --- Comment #8 from Joonas Kylmälä <joonas.kylmala at helsinki.fi> --- Instead of failing the DB change could we just make the non-integer values NULL? The non-integer values never worked so it should not be a problem to modify them to NULL? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 12:46:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 11:46:45 +0000 Subject: [Koha-bugs] [Bug 24010] Number of issues to display to staff accepts non-integer values In-Reply-To: <bug-24010-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24010-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24010-70-LwQxRsq9y4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24010 --- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Joonas Kylmälä from comment #8) > Instead of failing the DB change could we just make the non-integer values > NULL? The non-integer values never worked so it should not be a problem to > modify them to NULL? I can use an SQL regex to set to NULL non-numeric values, yes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 13:22:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 12:22:34 +0000 Subject: [Koha-bugs] [Bug 24075] Backdating a return to the exact due date and time results in the fine not being refunded In-Reply-To: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24075-70-2LtTlf6F9g@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24075 --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95719 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95719&action=edit Bug 24075: Alternative 1 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 13:23:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 12:23:02 +0000 Subject: [Koha-bugs] [Bug 24061] Print List (opac-shelves.pl) broken in Chrome In-Reply-To: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24061-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24061-70-uVdhIyZv94@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24061 --- Comment #26 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #25) > Let's do both then... Seems to work in a quick test. Firefox, Chrome and Edge. Edge ask for permission to close the tab. Maybe change 1000 to 500 or even less? 100 works with me on Chrome -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 13:31:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 12:31:41 +0000 Subject: [Koha-bugs] [Bug 24075] Backdating a return to the exact due date and time results in the fine not being refunded In-Reply-To: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24075-70-TNyJugkW5N@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24075 --- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95720 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95720&action=edit Bug 24075: Alternative 2 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 13:32:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 12:32:23 +0000 Subject: [Koha-bugs] [Bug 24075] Backdating a return to the exact due date and time results in the fine not being refunded In-Reply-To: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24075-70-w7wjVaZmL6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24075 --- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Lets golf a little.. I've uploaded a couple of alternatives.. let me know which of the three options seems clearest -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 14:05:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 13:05:27 +0000 Subject: [Koha-bugs] [Bug 16787] 'Too many holds' message appears inappropriately and is missing data In-Reply-To: <bug-16787-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16787-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16787-70-qUOVjz1CW6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16787 benjamin.r.philbrook at lmco.com changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |benjamin.r.philbrook at lmco.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 14:14:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 13:14:08 +0000 Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions In-Reply-To: <bug-10758-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10758-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10758-70-aP6xTPMWf7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 karen.fellows at citruslibraries.org changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |karen.fellows at citruslibrari | |es.org --- Comment #64 from karen.fellows at citruslibraries.org --- It would be great if this got some attention. If it would be possible to just display the info in the Acquisitions side rather than just deleting the title and other information. Maybe remove the links and add an internal note (item deleted) or something to that effect? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 14:14:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 13:14:16 +0000 Subject: [Koha-bugs] [Bug 24088] New: Add link to item search in staff client main page Message-ID: <bug-24088-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24088 Bug ID: 24088 Summary: Add link to item search in staff client main page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Staff Client Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com In staff client main page, there is a link to advanced search. I propose to add a link to item search below it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 14:15:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 13:15:15 +0000 Subject: [Koha-bugs] [Bug 24088] Add link to item search in staff client main page In-Reply-To: <bug-24088-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24088-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24088-70-sdkEP9OxeD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24088 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 14:16:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 13:16:06 +0000 Subject: [Koha-bugs] [Bug 24075] Backdating a return to the exact due date and time results in the fine not being refunded In-Reply-To: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24075-70-443Xy0MTHO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24075 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 14:19:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 13:19:48 +0000 Subject: [Koha-bugs] [Bug 24089] New: Upgrade jQuery Validate plugin in the staff client Message-ID: <bug-24089-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24089 Bug ID: 24089 Summary: Upgrade jQuery Validate plugin in the staff client Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: enhancement Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org We are using jQuery Validation plugin v1.10.0--from 2012!. We should upgrade to the latest version, v1.19.1 released 6/15/2019. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 14:21:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 13:21:13 +0000 Subject: [Koha-bugs] [Bug 24088] Add link to item search in staff client main page In-Reply-To: <bug-24088-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24088-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24088-70-CX1sB36wHk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24088 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 14:21:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 13:21:15 +0000 Subject: [Koha-bugs] [Bug 24088] Add link to item search in staff client main page In-Reply-To: <bug-24088-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24088-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24088-70-Oa0gfImNQY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24088 --- Comment #1 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Created attachment 95721 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95721&action=edit Bug 24088: Add link to item search in staff client main page In staff client main page, there is a link to advanced search. I propose to add a link to item search below it. This search is very usefull, it needs more visibility. Test plan : 1) Loggin to staff client 2) On main page /cgi-bin/koha/mainpage.pl 3) Check you see a big link to item search below advanced search 4) Click on it and check you go to item search -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 14:30:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 13:30:48 +0000 Subject: [Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove In-Reply-To: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21336-70-hrnAtPszp0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 --- Comment #129 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I do not see a good reason to warn from the module, the script must done that job. Especially because misc/cronjobs/cleanup_database.pl uses print (STDOUT). Can you explain this choice? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 14:46:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 13:46:30 +0000 Subject: [Koha-bugs] [Bug 24089] Upgrade jQuery Validate plugin in the staff client In-Reply-To: <bug-24089-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24089-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24089-70-EYrftUZsOQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24089 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 14:46:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 13:46:32 +0000 Subject: [Koha-bugs] [Bug 24089] Upgrade jQuery Validate plugin in the staff client In-Reply-To: <bug-24089-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24089-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24089-70-lWCJLmuHUH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24089 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 95722 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95722&action=edit Bug 24089: Upgrade jQuery Validate plugin in the staff client This patch upgrades the jQuery Validate plugin in the staff client from v1.10.0 to v1.19.1. To test, apply the patch and clear your browser cache if necessary. Test various pages to confirm that form validation works as expected: - Patron password change form: - Password must conform to minPasswordLength - Password must not contain leading/trailing spaces - Passwords must match - Administration -> Add or edit budget: - Description, start date, and end date are required - Start date must be before end date - Administration -> Add or edit Z39.50/SRU server: - Server name, hostname, port, and database are required - Port, rank, and timeout must be a number -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 14:58:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 13:58:07 +0000 Subject: [Koha-bugs] [Bug 24090] New: Subfield text in red when mandatory in record edition Message-ID: <bug-24090-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24090 Bug ID: 24090 Summary: Subfield text in red when mandatory in record edition Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: fridolin.somers at biblibre.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl In record edition, color subfield text in red when mandatory. Like patron fields in patron edition form. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 14:58:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 13:58:16 +0000 Subject: [Koha-bugs] [Bug 24091] New: Add biblionumber and itemnumber in Item lost reports Message-ID: <bug-24091-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24091 Bug ID: 24091 Summary: Add biblionumber and itemnumber in Item lost reports Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Reports Assignee: koha-bugs at lists.koha-community.org Reporter: severine.queune at bulac.fr QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 14:58:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 13:58:16 +0000 Subject: [Koha-bugs] [Bug 24090] Subfield text in red when mandatory in record edition In-Reply-To: <bug-24090-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24090-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24090-70-TZm7XA5N7c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24090 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |fridolin.somers at biblibre.co |ity.org |m -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 14:58:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 13:58:24 +0000 Subject: [Koha-bugs] [Bug 24090] Subfield text in red when mandatory in record edition In-Reply-To: <bug-24090-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24090-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24090-70-vqeiar50qC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24090 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 14:59:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 13:59:02 +0000 Subject: [Koha-bugs] [Bug 24075] Backdating a return to the exact due date and time results in the fine not being refunded In-Reply-To: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24075-70-khdFWwOj6Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24075 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 14:59:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 13:59:04 +0000 Subject: [Koha-bugs] [Bug 24075] Backdating a return to the exact due date and time results in the fine not being refunded In-Reply-To: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24075-70-3yzHEZEzIp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24075 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95706|0 |1 is obsolete| | Attachment #95707|0 |1 is obsolete| | Attachment #95719|0 |1 is obsolete| | Attachment #95720|0 |1 is obsolete| | --- Comment #14 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 95723 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95723&action=edit Bug 24075: Backdating a return to the exact due date and time results in the fine not being refunded When you use the date picker or book drop mode and check in an item that is due on that date, a fine is assessed and not refunded. For example: item 12345 is due on 11/19/2109 23:59. On 11/20/2019 I check the item in using date picker/book drop setting the check in date to 11/19/2019 23:59, the patron is charged a fine, and the fine is not cleared as would be expected, since the item is being checked in before it is overdue. Test Plan: 1) Back date a checkout so it is overdue 2) Run fines.pl to generate the fine 3) Return the item, backdating to the same date/time is was due 4) Note the fine was not removed 5) Apply this patch 6) Repeat steps 1-3 7) Fine should be zeroed out now! Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 14:59:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 13:59:14 +0000 Subject: [Koha-bugs] [Bug 24075] Backdating a return to the exact due date and time results in the fine not being refunded In-Reply-To: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24075-70-dE5afqDqOZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24075 --- Comment #15 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 95724 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95724&action=edit Bug 24075: Unit tests -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 15:01:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 14:01:43 +0000 Subject: [Koha-bugs] [Bug 24091] Add biblionumber and itemnumber in Item lost reports In-Reply-To: <bug-24091-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24091-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24091-70-Ddy1VYTV8H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24091 --- Comment #1 from Séverine Queune <severine.queune at bulac.fr> --- Could be useful to add the biblionumber and itemnumber in the item lost report, especially when the list is exported and the items modified in a second time, using the batch biblio/item modification. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 15:04:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 14:04:20 +0000 Subject: [Koha-bugs] [Bug 23146] Add support for Basic auth on the OAuth2 token endpoint In-Reply-To: <bug-23146-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23146-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23146-70-GMZlBl0mV9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23146 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This patchset adds release notes| |flexibility to the OAuth2 | |implementation regarding | |how the parameters are | |passed on the request. The | |original implementation of | |OAuth2 only contemplated | |the option to pass the | |client_id and client_secret | |parameters on the request | |body. It is very common | |that clients expect to be | |able to pass them as a | |Basic authorization header. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 15:06:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 14:06:52 +0000 Subject: [Koha-bugs] [Bug 24090] Subfield text in red when mandatory in record edition In-Reply-To: <bug-24090-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24090-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24090-70-MYi2DrN6CP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24090 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 15:06:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 14:06:54 +0000 Subject: [Koha-bugs] [Bug 24090] Subfield text in red when mandatory in record edition In-Reply-To: <bug-24090-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24090-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24090-70-G5hibS0Kas@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24090 --- Comment #1 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Created attachment 95725 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95725&action=edit Bug 24090: Subfield text in red when mandatory in record edition In biblio or autority record edition, color subfield text in red when mandatory. Like patron fields in patron edition form. Test plan : 1) Edit a biblio record 2) See that mandatory subield text is red (#C00) 3) Same in autority record edition -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 15:07:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 14:07:22 +0000 Subject: [Koha-bugs] [Bug 24090] Subfield text in red when mandatory in record edition In-Reply-To: <bug-24090-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24090-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24090-70-kEGUfOh2rw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24090 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 15:19:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 14:19:20 +0000 Subject: [Koha-bugs] [Bug 24075] Backdating a return to the exact due date and time results in the fine not being refunded In-Reply-To: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24075-70-hd9rXeU8ry@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24075 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 15:25:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 14:25:38 +0000 Subject: [Koha-bugs] [Bug 15142] Titles facet does not work in UNIMARC In-Reply-To: <bug-15142-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15142-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15142-70-PyMME9wnhk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15142 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED --- Comment #4 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- In the end I think the best solution is to remove this facet for UNIMARC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 15:26:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 14:26:13 +0000 Subject: [Koha-bugs] [Bug 15142] Titles facet does not work in UNIMARC In-Reply-To: <bug-15142-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15142-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15142-70-8W37lyRtZY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15142 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 15:26:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 14:26:17 +0000 Subject: [Koha-bugs] [Bug 15142] Titles facet does not work in UNIMARC In-Reply-To: <bug-15142-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15142-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15142-70-OKKSER0wnq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15142 --- Comment #5 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Created attachment 95726 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95726&action=edit Bug 15142: Remove titles facet for UNIMARC There is a facet using 500$a, 501$a and 503$a and Subject index. In UNIMARC 500$a, 501$a and 503$a are not indexed as Subject. I propose to remove this facet for UNIMARC, looks like it does not make sens. Test plan: 1) Install UNIMARC database 2) Edit some records to have 500$a 3) Perform a search to find those records 4) Check you dont see the titles facet -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 15:31:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 14:31:44 +0000 Subject: [Koha-bugs] [Bug 11500] Use dateformat syspref and datepicker on additems.pl (and other item cataloguing pages) In-Reply-To: <bug-11500-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11500-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11500-70-0Ssw9mtUnD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11500 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt at gmail.com |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 15:33:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 14:33:30 +0000 Subject: [Koha-bugs] [Bug 24075] Backdating a return to the exact due date and time results in the fine not being refunded In-Reply-To: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24075-70-W6ZEfHFHlS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24075 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA --- Comment #16 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Tests pass: prove t/db_dependent/Circulation/CalcFine.t t/db_dependent/Fines.t t/db_dependent/Circulation.t Behavior is the described one. Passing! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 15:33:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 14:33:54 +0000 Subject: [Koha-bugs] [Bug 24075] Backdating a return to the exact due date and time results in the fine not being refunded In-Reply-To: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24075-70-6T0Dfel1dR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24075 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95723|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 15:33:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 14:33:56 +0000 Subject: [Koha-bugs] [Bug 24075] Backdating a return to the exact due date and time results in the fine not being refunded In-Reply-To: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24075-70-i42fKqMRzb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24075 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95724|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 15:34:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 14:34:17 +0000 Subject: [Koha-bugs] [Bug 24075] Backdating a return to the exact due date and time results in the fine not being refunded In-Reply-To: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24075-70-vurQhKJadH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24075 --- Comment #17 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 95727 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95727&action=edit Bug 24075: Backdating a return to the exact due date and time results in the fine not being refunded When you use the date picker or book drop mode and check in an item that is due on that date, a fine is assessed and not refunded. For example: item 12345 is due on 11/19/2109 23:59. On 11/20/2019 I check the item in using date picker/book drop setting the check in date to 11/19/2019 23:59, the patron is charged a fine, and the fine is not cleared as would be expected, since the item is being checked in before it is overdue. Test Plan: 1) Back date a checkout so it is overdue 2) Run fines.pl to generate the fine 3) Return the item, backdating to the same date/time is was due 4) Note the fine was not removed 5) Apply this patch 6) Repeat steps 1-3 7) Fine should be zeroed out now! Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 15:34:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 14:34:21 +0000 Subject: [Koha-bugs] [Bug 24075] Backdating a return to the exact due date and time results in the fine not being refunded In-Reply-To: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24075-70-w5iJjxtQkY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24075 --- Comment #18 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 95728 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95728&action=edit Bug 24075: Unit tests Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 15:37:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 14:37:24 +0000 Subject: [Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove In-Reply-To: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21336-70-HrrjyHtZms@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 --- Comment #130 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #129) > I do not see a good reason to warn from the module, the script must done > that job. Especially because misc/cronjobs/cleanup_database.pl uses print > (STDOUT). > > Can you explain this choice? Probably simpler in the first place. And if this is indeed about the existing issues warn, it is not just an informational print line. Surely, it can be done differently. In other places too? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 15:48:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 14:48:24 +0000 Subject: [Koha-bugs] [Bug 24068] Koha::Template::Plugin::I18N->tnpx should call Koha::I18->__npx In-Reply-To: <bug-24068-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24068-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24068-70-uhW6FYeFS2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24068 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95578|0 |1 is obsolete| | --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95729 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95729&action=edit Bug 24068: Fix I18 plugin - tnpx must call __npx Test plan: Use the following code to test this change [% PROCESS 'i18n.inc' %] [% SET nb_stuffs = 1 %] [% tnpx('context', 'There is one stuff.', 'There are {count} stuffs.', nb_stuffs, { count = nb_stuffs }) | $raw %] [% SET nb_stuffs = 42 %] [% tnpx('context', 'There is one stuff.', 'There are {count} stuffs.', nb_stuffs, { count = nb_stuffs }) | $raw %] Compare with and without the patch Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 15:48:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 14:48:27 +0000 Subject: [Koha-bugs] [Bug 24068] Koha::Template::Plugin::I18N->tnpx should call Koha::I18->__npx In-Reply-To: <bug-24068-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24068-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24068-70-o5hpfAGFuO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24068 --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95730 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95730&action=edit Bug 24068: (RM follow-up) Enhance the POD -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 15:49:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 14:49:57 +0000 Subject: [Koha-bugs] [Bug 24068] Koha::Template::Plugin::I18N->tnpx should call Koha::I18->__npx In-Reply-To: <bug-24068-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24068-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24068-70-AyBfoW8KVr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24068 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Needs Signoff |Signed Off --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Works well and is an obvious correction to a typo.. Signing off and Passing QA in one hit... I've also enhanced the documentation for the module a bit. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 15:51:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 14:51:14 +0000 Subject: [Koha-bugs] [Bug 24068] Koha::Template::Plugin::I18N->tnpx should call Koha::I18->__npx In-Reply-To: <bug-24068-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24068-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24068-70-vHv8NEZgQg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24068 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95730|0 |1 is obsolete| | --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95731 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95731&action=edit Bug 24068: (RM follow-up) Enhance the POD -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 15:55:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 14:55:22 +0000 Subject: [Koha-bugs] [Bug 20988] Internationalization: wrap all translatable text inside t() calls In-Reply-To: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20988-70-MlpB6mSYUR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_target CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 15:55:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 14:55:45 +0000 Subject: [Koha-bugs] [Bug 20988] Internationalization: wrap all translatable text inside t() calls In-Reply-To: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20988-70-bQp16sP4Yh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |bdiazmunoz at gmail.com, | |mtj at kohaaloha.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 15:55:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 14:55:58 +0000 Subject: [Koha-bugs] [Bug 20988] Internationalization: wrap all translatable text inside t() calls In-Reply-To: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20988-70-6j4Qp6xejp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 15:56:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 14:56:28 +0000 Subject: [Koha-bugs] [Bug 20988] Internationalization: wrap all translatable text inside t() calls In-Reply-To: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20988-70-d5vdWkeC3u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 15:58:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 14:58:19 +0000 Subject: [Koha-bugs] [Bug 24068] Koha::Template::Plugin::I18N->tnpx should call Koha::I18->__npx In-Reply-To: <bug-24068-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24068-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24068-70-Xhxv9TADPl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24068 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 15:58:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 14:58:33 +0000 Subject: [Koha-bugs] [Bug 24068] Koha::Template::Plugin::I18N->tnpx should call Koha::I18->__npx In-Reply-To: <bug-24068-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24068-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24068-70-MgMZA7HurA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24068 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 15:58:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 14:58:34 +0000 Subject: [Koha-bugs] [Bug 24068] Koha::Template::Plugin::I18N->tnpx should call Koha::I18->__npx In-Reply-To: <bug-24068-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24068-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24068-70-kPysHguXVf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24068 --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 16:00:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 15:00:22 +0000 Subject: [Koha-bugs] [Bug 24068] Koha::Template::Plugin::I18N->tnpx should call Koha::I18->__npx In-Reply-To: <bug-24068-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24068-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24068-70-VodHNxOh8Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24068 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_19_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 16:00:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 15:00:52 +0000 Subject: [Koha-bugs] [Bug 11500] Use dateformat syspref and datepicker on additems.pl (and other item cataloguing pages) In-Reply-To: <bug-11500-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11500-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11500-70-oAQiRp1qtt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11500 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 16:00:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 15:00:54 +0000 Subject: [Koha-bugs] [Bug 11500] Use dateformat syspref and datepicker on additems.pl (and other item cataloguing pages) In-Reply-To: <bug-11500-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11500-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11500-70-CngjOA9VFD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11500 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 95732 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95732&action=edit Bug 11500: Use dateformat syspref and datepicker on additems.pl (and other item cataloguing pages) This patch modifies the cataloging plugin dateaccessioned.pl so that it triggers the addition of a datepicker widget to fields it is linked with. Despite its name the plugin can be used on any item field which requires a date. To test, apply the patch and make sure you have one or more item subfields linked to the dateaccessioned.pl plugin. For instance, in MARC21: - Administration -> MARC bibliographic framework -> MARC structure -> 952 -> Edit subfields: - subfields d ("Date acquired") and w ("Price effective from"): - Other options -> Plugin -> dateaccessioned.pl - Go to cataloging and add or edit an item on a bibliographic record - The "Date acquired" and "Price effective from" fields should be styled as datepickers. - Clicking in these fields should populate the field with today's date and trigger the datepicker popup. - Test that all the datepicker features work correctly. - Test that manual entry of a date works. - With the AcqCreateItem system preference set to "placing an order," go to Acquisitions -> Vendor -> Add to basket. - Add a title to your basket using your preferred method. - In the "New order" form, find the section for adding an item. - Test the "Date acquired" and "Price effective from" fields, which should behave just like they did in the cataloging module. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 16:02:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 15:02:46 +0000 Subject: [Koha-bugs] [Bug 24092] New: Change Koha::Item to use Items::LastPatrons instead of ItemLastBorrower resultset Message-ID: <bug-24092-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24092 Bug ID: 24092 Summary: Change Koha::Item to use Items::LastPatrons instead of ItemLastBorrower resultset Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: agustinmoyano at theke.io QA Contact: testopia at bugs.koha-community.org Koha::Item uses my $items_last_returned_by_rs = Koha::Database->new()->schema()->resultset('ItemsLastBorrower'); to retrieve item's last borrower. It should use Items::LastPatrons class introduced in bug 23260 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 16:03:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 15:03:48 +0000 Subject: [Koha-bugs] [Bug 24092] Change Koha::Item to use Items::LastPatrons instead of ItemLastBorrower resultset In-Reply-To: <bug-24092-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24092-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24092-70-aNRh6aYk56@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24092 Agustín Moyano <agustinmoyano at theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |agustinmoyano at theke.io, | |m.de.rooy at rijksmuseum.nl, | |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 16:04:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 15:04:08 +0000 Subject: [Koha-bugs] [Bug 24092] Change Koha::Item to use Items::LastPatrons instead of ItemLastBorrower resultset In-Reply-To: <bug-24092-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24092-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24092-70-b4y9fHQC08@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24092 Agustín Moyano <agustinmoyano at theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23260 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 [Bug 23260] Anonymize (remove) patron data from items_last_borrower -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 16:04:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 15:04:08 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23260-70-SQSXDVsFWX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Agustín Moyano <agustinmoyano at theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24092 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24092 [Bug 24092] Change Koha::Item to use Items::LastPatrons instead of ItemLastBorrower resultset -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 16:05:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 15:05:28 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23260-70-QubkUWipEg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Agustín Moyano <agustinmoyano at theke.io> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #36 from Agustín Moyano <agustinmoyano at theke.io> --- (In reply to Marcel de Rooy from comment #35) > (In reply to Agustín Moyano from comment #31) > > (In reply to Marcel de Rooy from comment #24) > > > Hmm > > > > > > sub last_returned_by { > > > my ( $self, $borrower ) = @_; > > > > > > my $items_last_returned_by_rs = > > > Koha::Database->new()->schema()->resultset('ItemsLastBorrower'); > > > > > > > > > Not so nice in Koha::Item. (Possibly out of scope though) > > > > This was introduced in Bug 14945. > > > > Do you want me to change it to use Items::LastPatrons class? > > Another report? Agreed, I created bug 24092 to address this issue. Changing this bug to SO again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 16:06:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 15:06:44 +0000 Subject: [Koha-bugs] [Bug 23591] Add a new "Suggestions details" tab on bibliographic record In-Reply-To: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23591-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23591-70-0ipyw61YMe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23591 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 16:08:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 15:08:56 +0000 Subject: [Koha-bugs] [Bug 24075] Backdating a return to the exact due date and time results in the fine not being refunded In-Reply-To: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24075-70-g03L0sUzmq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24075 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 16:08:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 15:08:57 +0000 Subject: [Koha-bugs] [Bug 24075] Backdating a return to the exact due date and time results in the fine not being refunded In-Reply-To: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24075-70-dcNJvEVr9n@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24075 --- Comment #19 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 16:13:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 15:13:58 +0000 Subject: [Koha-bugs] [Bug 20988] Internationalization: wrap all translatable text inside t() calls In-Reply-To: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20988-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20988-70-v2JRENHR3X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20988 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 17:04:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 16:04:24 +0000 Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions In-Reply-To: <bug-10758-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10758-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10758-70-zlIG9D2hMP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 Suzanne Fayle <sfayle at roseman.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC|sfayle at roseman.edu | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 17:13:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 16:13:31 +0000 Subject: [Koha-bugs] [Bug 13806] No input sanitization where creating Reports subgroup In-Reply-To: <bug-13806-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13806-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13806-70-bHJKTw544d@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13806 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED Assignee|gmcharlt at gmail.com |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 17:26:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 16:26:57 +0000 Subject: [Koha-bugs] [Bug 22835] Serve static files from plugins through the API In-Reply-To: <bug-22835-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22835-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22835-70-OJB7fMYJFG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22835 --- Comment #24 from Tomás Cohen Arazi <tomascohen at gmail.com> --- @fridolin can we backport this? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 18:45:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 17:45:32 +0000 Subject: [Koha-bugs] [Bug 13806] No input sanitization where creating Reports subgroup In-Reply-To: <bug-13806-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13806-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13806-70-VlspEIPQqS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13806 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 18:45:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 17:45:36 +0000 Subject: [Koha-bugs] [Bug 13806] No input sanitization where creating Reports subgroup In-Reply-To: <bug-13806-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13806-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13806-70-CKK6u0oTKL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13806 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 95733 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95733&action=edit Bug 13806: No input sanitization where creating Reports subgroup This patch adds validation of report group and subgroup inputs so that the user can't enter data into only one half of the group code/name pair. To test, apply the patch and go to Reports -> Use saved. - Create or edit a report which doesn't have a group or subgroup assigned. - Under "Report group," select the "or create" radio button. - Click the "Update SQL" button to submit the form without entering a group code or name. The form should require taht you enter data into both fields. - Enter data into the report group code and name fields. Add data to either the code or data field under "Report subgroup." You should not be able to submit the form without populating both. - Start over editing a report which doesn't have a group or subgroup assigned. - Select an existing group under "Report group." - Under "Report subgroup," select the "or create" option. - You should not be able to submit the form without adding data in both the code and name fields for the report subgroup. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 19:02:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 18:02:43 +0000 Subject: [Koha-bugs] [Bug 21507] Decimal separators issues in patrons payments/fines, simplified In-Reply-To: <bug-21507-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21507-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21507-70-YJjHFnUXA3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21507 --- Comment #4 from Victor Grousset/tuxayo <victor at tuxayo.net> --- Created attachment 95734 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95734&action=edit WIP Bug 21507 - Fix decimal separators issues in patrons payments/fines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 19:02:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 18:02:52 +0000 Subject: [Koha-bugs] [Bug 21507] Decimal separators issues in patrons payments/fines, simplified In-Reply-To: <bug-21507-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21507-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21507-70-3Tg2QzikJG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21507 --- Comment #5 from Victor Grousset/tuxayo <victor at tuxayo.net> --- Created attachment 95735 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95735&action=edit WIP not validated at all -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 19:03:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 18:03:39 +0000 Subject: [Koha-bugs] [Bug 21507] Decimal separators issues in patrons payments/fines, simplified In-Reply-To: <bug-21507-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21507-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21507-70-x3WvAaEUxx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21507 --- Comment #6 from Victor Grousset/tuxayo <victor at tuxayo.net> --- TODO: - rebase on master (the last 13 months...) - write test plan -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 19:39:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 18:39:40 +0000 Subject: [Koha-bugs] [Bug 24093] New: Sorting indicators broken on list contents view Message-ID: <bug-24093-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24093 Bug ID: 24093 Summary: Sorting indicators broken on list contents view Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org Depends on: 23013 Bug 23013 removed some images files which were a dependency for the our previous implementation of DataTables. These image files were being used to indicate the (server-side) sorting direction of the lists contents view. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23013 [Bug 23013] Upgrade DataTables in the staff client -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 19:39:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 18:39:40 +0000 Subject: [Koha-bugs] [Bug 23013] Upgrade DataTables in the staff client In-Reply-To: <bug-23013-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23013-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23013-70-9UcVjGSe1B@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23013 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24093 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24093 [Bug 24093] Sorting indicators broken on list contents view -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 19:47:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 18:47:13 +0000 Subject: [Koha-bugs] [Bug 24093] Sorting indicators broken on list contents view In-Reply-To: <bug-24093-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24093-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24093-70-cfEFEdqM4i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24093 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 19:47:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 18:47:16 +0000 Subject: [Koha-bugs] [Bug 24093] Sorting indicators broken on list contents view In-Reply-To: <bug-24093-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24093-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24093-70-PcS4DXsR8O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24093 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 95736 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95736&action=edit Bug 24093: Sorting indicators broken on list contents view This patch updates the table markup for the lists contents view so that the table sort state is correctly indicated by arrows in the table headers. The markup changes allow the standard DataTables CSS to apply to this table even though it is not a DataTable. To test, apply the patch, go to Lists, and view any list with multiple titles attached. - The list should be sorted by default according to the list's settings, and the arrow in the header row should correctly reflect the sorting column and direction. - Test re-sorting the table by each of the different sortable columns, confirming each time that the sorting arrows are correct. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 20:02:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 19:02:17 +0000 Subject: [Koha-bugs] [Bug 24094] New: Authority punctuation mismatch prevents linking to correct records Message-ID: <bug-24094-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24094 Bug ID: 24094 Summary: Authority punctuation mismatch prevents linking to correct records Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs at lists.koha-community.org Reporter: bwsdonna at gmail.com QA Contact: testopia at bugs.koha-community.org In a bibliographic record, the comma preceding the relationship designator, i.e., the comma before $e, is prescribed--it has to be there for the record to conform to RDA and MARC21. Authority records view this as a different name/etc, so it does not match. Every, single, correctly cataloged RDA/MARC21 record is going to have a $e preceded by a comma in every authority controlled X00 and X10 field. Authorities need to disregard/strip trailing commas. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 20:10:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 19:10:47 +0000 Subject: [Koha-bugs] [Bug 24094] Authority punctuation mismatch prevents linking to correct records In-Reply-To: <bug-24094-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24094-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24094-70-SuTxp6Mlu4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24094 Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mkstephens at lancasterseminar | |y.edu -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 20:17:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 19:17:25 +0000 Subject: [Koha-bugs] [Bug 24071] Ask for complete information when opening a bug report In-Reply-To: <bug-24071-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24071-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24071-70-09DEPP8lda@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24071 --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think we are not far apart - I just don't want to up the requirements. It should still be possible to file a simple bug, growing into the process. We can still ask for more and help people to retrieve this information. - version (easy, about page) - logs (hard, especially since some can't access their servers on this level) - Js console (middle) - OS version (easy, about page) - DBMS (easy, about page) Should we add a copy button to the about page that makes it really easy to get a nicely formatted summary? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 20:37:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 19:37:26 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24080-70-eG42lQb1FG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 20:38:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 19:38:39 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23260-70-pipCUJnI6j@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #37 from Tomás Cohen Arazi <tomascohen at gmail.com> --- (In reply to Marcel de Rooy from comment #34) > (In reply to Tomás Cohen Arazi from comment #33) > > Marcel, your patch introduces the use of ->update. Given the problems about > > it raised on bug 21761, could you resubmit it without using ->update? Thanks! > > Ah, you are right about that ;) > In this case it is a bit theoretical argument, since LastBorrower only > contains three fields and has no individual store sub. So replacing the > while..next was just regular optimization. > I do not mind setting back the while loop, although personally I would be > inclined to wait on the outcome of the discussion before removing all > updates. Fair enough. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 20:44:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 19:44:15 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24080-70-Ls3r1eo6Zb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 Maryse Simard <maryse.simard at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maryse.simard at inlibro.com --- Comment #9 from Maryse Simard <maryse.simard at inlibro.com> --- > Test Plan: > 1) Run the included tests and verify they pass. I can't seem to find which tests this refers to. Could they be missing? -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 20:44:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 19:44:30 +0000 Subject: [Koha-bugs] [Bug 11281] Printing holds awaiting pickup prints both tabs In-Reply-To: <bug-11281-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11281-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11281-70-PQrMquYtQw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11281 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 20:44:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 19:44:33 +0000 Subject: [Koha-bugs] [Bug 11281] Printing holds awaiting pickup prints both tabs In-Reply-To: <bug-11281-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11281-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11281-70-CFrytlTYhm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11281 --- Comment #2 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 95737 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95737&action=edit Bug 11281: Printing holds awaiting pickup prints both tabs This patch adds columns configuration to the holds awaiting pickup tables. Doing so helps solve the printing issue by adding a "Print" option to both tables. Using this print function will provide a printable version of only that table. To test you should have multiple holds in your system which are marked "waiting" and some which have been waiting longer than the value specified in the ReservesMaxPickUpDelay system preference. Apply the patch and go to Circulation -> Holds awaiting pickup. - On both the "Holds waiting" and "Holds waiting over..." tabs the DataTable should display correctly and all the controls should work, including the columns settings and the choices in the export menu. - Confirm that the "Print" action creates a printable version of only the table you are viewing. - Go to Administration -> Columns settings -> Circulation. - Change some visibility controls for the tables under the "holds_awaiting_pickup" heading (id=holdso and id=holdst). Confirm that these changes are reflected in the "Holds waiting" interface. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 20:57:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 19:57:20 +0000 Subject: [Koha-bugs] [Bug 24095] New: Missing MSG_CONFIRM_DELETE_HOLD variable on the OPAC user account page Message-ID: <bug-24095-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24095 Bug ID: 24095 Summary: Missing MSG_CONFIRM_DELETE_HOLD variable on the OPAC user account page Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: OPAC Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org On the "my summary" page in the OPAC, under the holds tab, clicking the delete button for a hold should trigger a confirmation message. The MSG_CONFIRM_DELETE_HOLD is not defined so the confirmation is skipped and the hold is deleted without confirmation. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 20:59:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 19:59:45 +0000 Subject: [Koha-bugs] [Bug 24093] Sorting indicators broken on list contents view In-Reply-To: <bug-24093-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24093-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24093-70-9mo8qPdf4f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24093 Maryse Simard <maryse.simard at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95736|0 |1 is obsolete| | --- Comment #2 from Maryse Simard <maryse.simard at inlibro.com> --- Created attachment 95738 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95738&action=edit Bug 24093: Sorting indicators broken on list contents view This patch updates the table markup for the lists contents view so that the table sort state is correctly indicated by arrows in the table headers. The markup changes allow the standard DataTables CSS to apply to this table even though it is not a DataTable. To test, apply the patch, go to Lists, and view any list with multiple titles attached. - The list should be sorted by default according to the list's settings, and the arrow in the header row should correctly reflect the sorting column and direction. - Test re-sorting the table by each of the different sortable columns, confirming each time that the sorting arrows are correct. Signed-off-by: Maryse Simard <maryse.simard at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 20:59:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 19:59:52 +0000 Subject: [Koha-bugs] [Bug 24093] Sorting indicators broken on list contents view In-Reply-To: <bug-24093-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24093-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24093-70-sNM9NBtA3a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24093 Maryse Simard <maryse.simard at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |maryse.simard at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 21:24:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 20:24:08 +0000 Subject: [Koha-bugs] [Bug 24089] Upgrade jQuery Validate plugin in the staff client In-Reply-To: <bug-24089-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24089-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24089-70-bMoPe1WvF1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24089 Maryse Simard <maryse.simard at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95722|0 |1 is obsolete| | --- Comment #2 from Maryse Simard <maryse.simard at inlibro.com> --- Created attachment 95739 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95739&action=edit Bug 24089: Upgrade jQuery Validate plugin in the staff client This patch upgrades the jQuery Validate plugin in the staff client from v1.10.0 to v1.19.1. To test, apply the patch and clear your browser cache if necessary. Test various pages to confirm that form validation works as expected: - Patron password change form: - Password must conform to minPasswordLength - Password must not contain leading/trailing spaces - Passwords must match - Administration -> Add or edit budget: - Description, start date, and end date are required - Start date must be before end date - Administration -> Add or edit Z39.50/SRU server: - Server name, hostname, port, and database are required - Port, rank, and timeout must be a number Signed-off-by: Maryse Simard <maryse.simard at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 21:24:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 20:24:18 +0000 Subject: [Koha-bugs] [Bug 24089] Upgrade jQuery Validate plugin in the staff client In-Reply-To: <bug-24089-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24089-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24089-70-o41Ofbvj6w@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24089 Maryse Simard <maryse.simard at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |maryse.simard at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 21:45:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 20:45:15 +0000 Subject: [Koha-bugs] [Bug 24088] Add link to item search in staff client main page In-Reply-To: <bug-24088-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24088-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24088-70-EBNvTq4Ljx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24088 Maryse Simard <maryse.simard at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95721|0 |1 is obsolete| | --- Comment #2 from Maryse Simard <maryse.simard at inlibro.com> --- Created attachment 95740 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95740&action=edit Bug 24088: Add link to item search in staff client main page In staff client main page, there is a link to advanced search. I propose to add a link to item search below it. This search is very usefull, it needs more visibility. Test plan : 1) Loggin to staff client 2) On main page /cgi-bin/koha/mainpage.pl 3) Check you see a big link to item search below advanced search 4) Click on it and check you go to item search Signed-off-by: Maryse Simard <maryse.simard at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 21:45:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 20:45:25 +0000 Subject: [Koha-bugs] [Bug 24088] Add link to item search in staff client main page In-Reply-To: <bug-24088-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24088-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24088-70-1TV3g3l2m6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24088 Maryse Simard <maryse.simard at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |maryse.simard at inlibro.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 21:58:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 20:58:15 +0000 Subject: [Koha-bugs] [Bug 24033] Fix column labelling on basket summary page (ecost) In-Reply-To: <bug-24033-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24033-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24033-70-jD23umCgPi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24033 --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 95741 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95741&action=edit k -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 22:01:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 21:01:39 +0000 Subject: [Koha-bugs] [Bug 24033] Fix column labelling on basket summary page (ecost) In-Reply-To: <bug-24033-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24033-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24033-70-0Vu6ffaSkj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24033 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 22:01:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 21:01:43 +0000 Subject: [Koha-bugs] [Bug 24033] Fix column labelling on basket summary page (ecost) In-Reply-To: <bug-24033-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24033-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24033-70-IWoqz31OHu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24033 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95449|0 |1 is obsolete| | Attachment #95710|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 95742 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95742&action=edit Bug 24033: Fix column labelling on basket summary page (ecost) When viewing a basket, some of the column names are unclear and are different than the terms used for the same field on the order form. This patch edits the column titles to match the order form. To test: 1) In acquisitions, create a budget. 2) In acquisitions, create a fund. 3) In acquisitions, create a vendor. 4) In acquisitions, create a basket and add a test item to the basket. 5) Observe the column titles ecost tax inc. and ecost tax exc. Check the column visibility settings if you don't see the columns. 6) Apply the patch. 7) Observe the column titles have been updated. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 22:01:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 21:01:58 +0000 Subject: [Koha-bugs] [Bug 24033] Fix column labelling on basket summary page (ecost) In-Reply-To: <bug-24033-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24033-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24033-70-8ClLDO0FQD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24033 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95741|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 22:02:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 21:02:21 +0000 Subject: [Koha-bugs] [Bug 24033] Fix column labelling on basket summary page (ecost) In-Reply-To: <bug-24033-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24033-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24033-70-GXKadoscQr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24033 --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Lisette, nice patch! Just some small things for your next one: - The first line always needs to start with 'Bug xxxx:'. - Something seems to happen to the breaks in your patches - no problem, I've fixed it. How do you write the commit message? Maybe try to add an extra empty line after the first. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 22:04:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 21:04:00 +0000 Subject: [Koha-bugs] [Bug 24053] Typo in FinePaymentAutoPopup description In-Reply-To: <bug-24053-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24053-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24053-70-xGtB0zWDoI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24053 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95585|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 22:06:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 21:06:08 +0000 Subject: [Koha-bugs] [Bug 24053] Typo in FinePaymentAutoPopup description In-Reply-To: <bug-24053-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24053-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24053-70-EXdtmbOFbj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24053 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |String patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 22:06:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 21:06:12 +0000 Subject: [Koha-bugs] [Bug 24053] Typo in FinePaymentAutoPopup description In-Reply-To: <bug-24053-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24053-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24053-70-XV49HINXij@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24053 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95607|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 95743 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95743&action=edit Bug 24053: Typo in FinePaymentAutoPopup description There is a typo in the FinePaymentAutoPopup system preference description. This patch fixes that. To test: 1) Go to the systems preferences in administration. 2) Search for FinePaymentAutoPopup 3) Observe .. at the end of the preference description. 4) Apply the patch 5) Repeat steaps 1-2 6) Ovserve correct punctuation at the end of the preference description. Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 22:08:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 21:08:07 +0000 Subject: [Koha-bugs] [Bug 24057] Hea is not an acronym In-Reply-To: <bug-24057-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24057-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24057-70-o10vzquopy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24057 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 22:08:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 21:08:11 +0000 Subject: [Koha-bugs] [Bug 24057] Hea is not an acronym In-Reply-To: <bug-24057-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24057-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24057-70-ccF5xX3dXR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24057 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95529|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 95744 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95744&action=edit Bug 24057: Hea is not an acronym This patch changes "HEA" (incorrectly capitalized) to "Hea" on the staff client administration home page. To test, apply the patch and set the "UsageStats" system preference to "No, let me think about it." - Go to Administration in the staff client. - There should be a message at the top asking if you want to share anonymous usage statisitcs with the community. The word "Hea" in this message should be capitalized correctly. Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 22:09:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 21:09:22 +0000 Subject: [Koha-bugs] [Bug 24056] Capitalization: Cash Register ID on cash register management page In-Reply-To: <bug-24056-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24056-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24056-70-qlTzwultne@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24056 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |trivial -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 22:11:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 21:11:47 +0000 Subject: [Koha-bugs] [Bug 24056] Capitalization: Cash Register ID on cash register management page In-Reply-To: <bug-24056-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24056-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24056-70-F3uvYpiMk2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24056 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |String patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 22:11:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 21:11:51 +0000 Subject: [Koha-bugs] [Bug 24056] Capitalization: Cash Register ID on cash register management page In-Reply-To: <bug-24056-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24056-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24056-70-oqQ4TQHu8z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24056 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95587|0 |1 is obsolete| | Attachment #95709|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 95745 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95745&action=edit Bug 24056: Capitalization: Cash Register ID on cash register management page When editing a cash register, Cash register ID doesn't follow our capitalization guidelines. This patch fixes that. To Test: 1) Turn on cash register usage in the system preferences. 2) Add a cash register. 3) Edit the cash register. 4) Note the incorrect capitalization. 5) Apply the patch. 6) Edit the cash register. 7) Note the correct capitalization. Signed-off-by: George Williams <george at nekls.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 22:17:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 21:17:48 +0000 Subject: [Koha-bugs] [Bug 23958] Use Font Awesome icon to replace "new window" icon image In-Reply-To: <bug-23958-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23958-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23958-70-HBz4f0p2A2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23958 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 22:17:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 21:17:53 +0000 Subject: [Koha-bugs] [Bug 23958] Use Font Awesome icon to replace "new window" icon image In-Reply-To: <bug-23958-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23958-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23958-70-efebwR2Caz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23958 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95242|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 95746 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95746&action=edit Bug 23958: Use Font Awesome icon to replace "new window" icon image This patch modifies several templates in order to eliminate the dependency on an image file for styling certain links which open popups or new windows. A Font Awesome icon is used instead. To test, apply the patch and rebuild the staff client CSS (https://wiki.koha-community.org/wiki/Working_with_SCSS_in_the_OPAC_and_staff_client). Cataloging: - Create a new MARC record which has the same ISBN as a record in your catalog. - When you save the record it should warn you that it is a possible duplicate. The message should contain an icon-prefixed link to the existing record. - Clicking the link should open details about the title in a new window. Circulation: - Enable the itemBarcodeFallbackSearch system preference. - Open a patron for checkout and enter a word in the "barcode" field instead of a barcode. - The page should return a list of titles to choose from. Each title should be a link with an icon. Clicking the link should open details about the title in a new window. Acquisitions: - Go to Acquistisions -> Vendor -> Basket. - Choose "Add to basket" -> From an external source. - Search for and select a record which exists in your catalog. - You should be taken to a page with a "Duplicate warning" message. The message should contain an icon-prefixed link to the existing record. - Clicking this link should open details about the title in a new window. - Create a MARC file with two records: One which exists in your catalog and one which doesn't. Stage that file for import. - Choose "Add to basket" again and select "From a staged file." - Select the file you staged. - You should be taken to a page with a "Duplicate warning" message. The message should contain an icon-prefixed link to the existing record. - Clicking the link should open details about the title in a new window. Patrons: - Create a new patron which has the same name and birthday as an existing patron. - When you save the record you should be shown a duplicate warning. The link to the possible duplicate patron should be prefixed with an icon and should open the patron's details in a popup window. Signed-off-by: Maryse Simard <maryse.simard at inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 22:23:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 21:23:26 +0000 Subject: [Koha-bugs] [Bug 23389] Add 'All' option to report value dropdowns In-Reply-To: <bug-23389-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23389-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23389-70-3cSDwDLcjf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23389 Jessie Zairo <jzairo at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 22:23:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 21:23:41 +0000 Subject: [Koha-bugs] [Bug 21939] Permission for holds history tab is too strict In-Reply-To: <bug-21939-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21939-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21939-70-YIoe2Vo4bo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21939 Jessie Zairo <jzairo at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jzairo at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 22:25:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 21:25:39 +0000 Subject: [Koha-bugs] [Bug 23957] Remove button style with famfamfam icon background and replace with Font Awesome In-Reply-To: <bug-23957-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23957-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23957-70-gfdgqQvnXQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23957 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Failed QA --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Owen, I have some difficulties with this bug. The second "Place hold" button on the end of the page does no longer 'lock' when it should. Example: - override is not active - try to place a hold on a record with only 'not for loan' itemtypes - the first 'place hold' button is locked, but the second after the item table is not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 22:29:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 21:29:37 +0000 Subject: [Koha-bugs] [Bug 11500] Use dateformat syspref and datepicker on additems.pl (and other item cataloguing pages) In-Reply-To: <bug-11500-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11500-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11500-70-ETd5FVCmU7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11500 Maryse Simard <maryse.simard at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maryse.simard at inlibro.com Status|Needs Signoff |Failed QA --- Comment #2 from Maryse Simard <maryse.simard at inlibro.com> --- Everything works on the add/edit item page, but the datepicker looks a bit off on the new order page. The dialog is missing the selects for the month and year as well as the "today" button. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 22:30:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 21:30:59 +0000 Subject: [Koha-bugs] [Bug 24033] Fix column labelling on basket summary page (ecost) In-Reply-To: <bug-24033-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24033-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24033-70-naebspdjGk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24033 --- Comment #7 from Lisette Scheer <lisetteslatah at gmail.com> --- (In reply to Katrin Fischer from comment #6) > Hi Lisette, nice patch! > > Just some small things for your next one: > > - The first line always needs to start with 'Bug xxxx:'. > - Something seems to happen to the breaks in your patches - no problem, I've > fixed it. How do you write the commit message? Maybe try to add an extra > empty line after the first. Katrin, Thanks for fixing it. I'm using the devbox. I'll do: 1) git commit basket.tt 2) Write the commit notes, following the instructions on the wiki that I found here: https://wiki.koha-community.org/wiki/Commit_messages 3) :wq! to write and quit. 4) git bz attach -e 24403 HEAD 5) Put all the line breaks back in and change the status. I did think it was quirky that I had to put the line breaks in again. That was also why I had 2 patches on this one. The first time I forgot to -e so I re-attached it after editing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 22:34:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 21:34:27 +0000 Subject: [Koha-bugs] [Bug 21574] Local use system preferences page doesn't have the system preferences menu In-Reply-To: <bug-21574-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21574-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21574-70-FC0rIvvS3e@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21574 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 22:34:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 21:34:31 +0000 Subject: [Koha-bugs] [Bug 21574] Local use system preferences page doesn't have the system preferences menu In-Reply-To: <bug-21574-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21574-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21574-70-CWAWkWav82@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21574 --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 95747 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95747&action=edit Bug 21574: Local use system preferences page doesn't have the system preferences menu The "local use" tab in system preferences is showing the admin menu instead of the system preferences menu tabs. This patch fixes the menu display. To test: 1) Go to the system preferences in administration. 2) Click the 'Local use' tab. 3) Observe the inncorrect menu. 4) Apply the patch. 5) Repeat steps 1-2 6) Observe the correct menu. Signed-off-by: Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 22:35:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 21:35:13 +0000 Subject: [Koha-bugs] [Bug 24096] New: Mana KB "Shared successfully" untranslatable Message-ID: <bug-24096-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24096 Bug ID: 24096 Summary: Mana KB "Shared successfully" untranslatable Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: I18N/L10N Assignee: koha-bugs at lists.koha-community.org Reporter: caroline.cyr-la-rose at inlibro.com QA Contact: testopia at bugs.koha-community.org CC: frederic at tamil.fr Created attachment 95748 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95748&action=edit English Success message in fr-CA page When sharing a report with Mana KB, there is a message that says "Shared successfuly! (sic) Thanks for your help" That string is untranslatable. It is nowhere in the po files. I wonder if that has to do with the URL that I get http://v1905-intranet/cgi-bin/koha/reports/guided_reports.pl?phase=Use%20saved&manamsg=Shared%20successfuly!%20Thanks%20for%20your%20help If the message is in the URL, maybe it's just not in the tt? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 22:37:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 21:37:27 +0000 Subject: [Koha-bugs] [Bug 23955] Replace famfamfam icon in OPAC holds template In-Reply-To: <bug-23955-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23955-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23955-70-SxGyDhNTGo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23955 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Passed QA --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Tiny change, PQA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 22:43:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 21:43:38 +0000 Subject: [Koha-bugs] [Bug 24084] PlainMARC view broken on OPAC if other $.ajax calls produce errors In-Reply-To: <bug-24084-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24084-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24084-70-1WDqpNd84J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24084 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 22:43:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 21:43:42 +0000 Subject: [Koha-bugs] [Bug 24084] PlainMARC view broken on OPAC if other $.ajax calls produce errors In-Reply-To: <bug-24084-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24084-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24084-70-xpoW7W9iqu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24084 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95705|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 95749 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95749&action=edit Bug 24084: PlainMARC view broken on OPAC if other $.ajax calls produce errors This patch removes the use of jQuery's ajaxSetup() and load() to get the "plain" MARC view and replaces it with $.get(). This allows for error-handling on this specific AJAX request rather than all on the page. To test, apply the patch and view a bibliographic record in the OPAC. - Click the "MARC view" tab. - Click the "view plain" link. - The plain-text MARC view should load. - Clicking "view labeled" should return you to the original view. To test error handling, edit opac-MARCdetail.tt line 185 and add a typo to the URL, e.g. "opac-showmark.pl." Repeat the above steps. Clicking the "view plain" link should trigger an error message: "Sorry, plain view is temporarily unavailable." Signed-off-by: Lucas Gass <lucas at bywatersolutions.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 22:49:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 21:49:57 +0000 Subject: [Koha-bugs] [Bug 23276] Don't show tags on tag cloud when tagging is disabled In-Reply-To: <bug-23276-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23276-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23276-70-LfytlEKMit@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23276 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 22:50:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 21:50:00 +0000 Subject: [Koha-bugs] [Bug 23276] Don't show tags on tag cloud when tagging is disabled In-Reply-To: <bug-23276-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23276-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23276-70-hbVMs0nTvy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23276 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95653|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 95750 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95750&action=edit Bug 23276: Do not display tag if pref TagsEnabled is off If the pref TagsEnabled is off we should not display the tags at the OPAC. There is a message to tell that tags system is disabled, but the tags are displayed. This patch introduces the blocking_errors include file at the OPAC. Test plan: - Turn TagsEnabled on - Add some tags - Turn TagsEnabled off - Hit /cgi-bin/koha/opac-tags.pl => Without this patch you see a warning messaging saying that the tag system is disabled, but the tags are displayed => With this patch you see a (ugly) short screen saying that the tag system is disabled. Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 22:50:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 21:50:15 +0000 Subject: [Koha-bugs] [Bug 23276] Don't show tags on tag cloud when tagging is disabled In-Reply-To: <bug-23276-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23276-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23276-70-EWcuDvjZmX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23276 --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- It's really a little ugly... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 22:51:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 21:51:22 +0000 Subject: [Koha-bugs] [Bug 23800] Batch modification tool orders items by barcode incremental by default (regression to 17.11) In-Reply-To: <bug-23800-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23800-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23800-70-aWj6AnN3s8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23800 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95252|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 23:00:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 22:00:23 +0000 Subject: [Koha-bugs] [Bug 14741] Selecting all child permissions doesn't select the top level check box In-Reply-To: <bug-14741-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14741-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14741-70-bXg64hDswZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14741 Maryse Simard <maryse.simard at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95702|0 |1 is obsolete| | --- Comment #4 from Maryse Simard <maryse.simard at inlibro.com> --- Created attachment 95751 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95751&action=edit Bug 14741: Selecting all child permissions doesn't select the top level check box This patch modifies the patron flags page so that manually selecting all the child permissions also checks the checkbox for the parent permission. To test, apply the patch, open a patron record, select More -> Set permissions. - Expand a set of permissions, for instance "Add, modify, and view patron information." - If any boxes are checked, uncheck them. - Check each of the "child" checkboxes ("Add, modify, and view..." and "View patron infos..." ). - When both checkboxes are checked, the "Add, modify, and view" parent permission should be automatically checked. Signed-off-by: Maryse Simard <maryse.simard at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 23:00:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 22:00:31 +0000 Subject: [Koha-bugs] [Bug 14741] Selecting all child permissions doesn't select the top level check box In-Reply-To: <bug-14741-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14741-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14741-70-a4rInJnyi3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14741 Maryse Simard <maryse.simard at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |maryse.simard at inlibro.com Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 23:19:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 22:19:48 +0000 Subject: [Koha-bugs] [Bug 24033] Fix column labelling on basket summary page (ecost) In-Reply-To: <bug-24033-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24033-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24033-70-6CqId7ZuxA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24033 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Lisette Scheer from comment #7) > (In reply to Katrin Fischer from comment #6) > > Hi Lisette, nice patch! > > > > Just some small things for your next one: > > > > - The first line always needs to start with 'Bug xxxx:'. > > - Something seems to happen to the breaks in your patches - no problem, I've > > fixed it. How do you write the commit message? Maybe try to add an extra > > empty line after the first. > > > Katrin, > Thanks for fixing it. > I'm using the devbox. > I'll do: > 1) git commit basket.tt > 2) Write the commit notes, following the instructions on the wiki that I > found here: https://wiki.koha-community.org/wiki/Commit_messages > 3) :wq! to write and quit. > 4) git bz attach -e 24403 HEAD > 5) Put all the line breaks back in and change the status. > > I did think it was quirky that I had to put the line breaks in again. > That was also why I had 2 patches on this one. The first time I forgot to -e > so I re-attached it after editing. Hm something is odd there, you shouldn't have to do anything on bugzilla and it doesn't really work well this way. It sounds like you are using vi in the devbox. One can change the default editor for git via the config files for the devbox, maybe this could improve things... but it SHOULD work with vi too :( -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 23:22:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 22:22:24 +0000 Subject: [Koha-bugs] [Bug 24096] Mana KB "Shared successfully" untranslatable In-Reply-To: <bug-24096-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24096-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24096-70-H5NGfTQwjI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24096 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit | |y.org | Component|I18N/L10N |Mana-kb CC| |julian.maurice at biblibre.com | |, katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- It looks like this might be a bug in Mana itself, changing the module and adding Julian. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 23:22:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 22:22:43 +0000 Subject: [Koha-bugs] [Bug 24096] Mana KB "Shared successfully" untranslatable In-Reply-To: <bug-24096-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24096-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24096-70-XcYgy41qU3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24096 --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- successfuly => successfully -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 23:29:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 22:29:28 +0000 Subject: [Koha-bugs] [Bug 24093] Sorting indicators broken on list contents view In-Reply-To: <bug-24093-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24093-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24093-70-0IikjUMpeN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24093 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 23:29:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 22:29:32 +0000 Subject: [Koha-bugs] [Bug 24093] Sorting indicators broken on list contents view In-Reply-To: <bug-24093-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24093-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24093-70-jhZaueBPOC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24093 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95738|0 |1 is obsolete| | --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 95752 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95752&action=edit Bug 24093: Sorting indicators broken on list contents view This patch updates the table markup for the lists contents view so that the table sort state is correctly indicated by arrows in the table headers. The markup changes allow the standard DataTables CSS to apply to this table even though it is not a DataTable. To test, apply the patch, go to Lists, and view any list with multiple titles attached. - The list should be sorted by default according to the list's settings, and the arrow in the header row should correctly reflect the sorting column and direction. - Test re-sorting the table by each of the different sortable columns, confirming each time that the sorting arrows are correct. Signed-off-by: Maryse Simard <maryse.simard at inlibro.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 23:33:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 22:33:17 +0000 Subject: [Koha-bugs] [Bug 15142] Titles facet does not work in UNIMARC In-Reply-To: <bug-15142-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15142-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15142-70-yrRqai0LfE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15142 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 23:33:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 22:33:21 +0000 Subject: [Koha-bugs] [Bug 15142] Titles facet does not work in UNIMARC In-Reply-To: <bug-15142-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15142-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15142-70-CYbqPt1tT9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15142 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95726|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 95753 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95753&action=edit Bug 15142: Remove titles facet for UNIMARC There is a facet using 500$a, 501$a and 503$a and Subject index. In UNIMARC 500$a, 501$a and 503$a are not indexed as Subject. I propose to remove this facet for UNIMARC, looks like it does not make sens. Test plan: 1) Install UNIMARC database 2) Edit some records to have 500$a 3) Perform a search to find those records 4) Check you dont see the titles facet Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 23:34:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 22:34:21 +0000 Subject: [Koha-bugs] [Bug 23702] New UNIMARC XSLT according to last IFLA updates In-Reply-To: <bug-23702-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23702-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23702-70-ixmzCSKm5Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23702 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #18 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Is this still work in progress? (Status: Assigned) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 23:45:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 22:45:39 +0000 Subject: [Koha-bugs] [Bug 17979] Fatal error when searching from addbooks.pl due to ISBN flaw In-Reply-To: <bug-17979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17979-70-81AmZG1Dwv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17979 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Needs Signoff |Failed QA --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Owen, why not search the ISBN as is? Or in different formats according to our ISBN variations prefs? I am not sure about the line using the as_isbn10. + if( $isbn = Business::ISBN->new( $query ) ) { + $isbn = $isbn->as_isbn10->as_string; + $isbn =~ s/-//g; As I understand it, if the ISBN is a new one (13), this will return undef. as_isbn10 Returns a new ISBN object. If the object is already ISBN-10, this method clones it. If it is an ISBN-13 with the prefix 978, it returns the ISBN-10 equivalent. For all other cases it returns undef. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 22 23:48:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 22 Nov 2019 22:48:56 +0000 Subject: [Koha-bugs] [Bug 18698] Get rid of [%% in translation for shelves-result.tt In-Reply-To: <bug-18698-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18698-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18698-70-fVqiTaNbPi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18698 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Lists |I18N/L10N CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Still valid. Example: https://translate.koha-community.org/de/translate/#search=dt_modification_time&sfields=source,target&soptions=exact,case -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 23 08:37:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Nov 2019 07:37:45 +0000 Subject: [Koha-bugs] [Bug 24072] Typos in advance_notices.pl causes DUEDGST not to be sent In-Reply-To: <bug-24072-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24072-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24072-70-7j1adavFHP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24072 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 23 08:37:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Nov 2019 07:37:48 +0000 Subject: [Koha-bugs] [Bug 24072] Typos in advance_notices.pl causes DUEDGST not to be sent In-Reply-To: <bug-24072-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24072-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24072-70-Ki6TUy6PGx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24072 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95697|0 |1 is obsolete| | --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 95754 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95754&action=edit Bug 24072 - Typos in advance_notices.pl causes DUEDGST not to be sent There are two typos in advance_notics.pl that cause DUEDGST messages not to be sent. See Bugzilla for full details. If you think the typo is sufficiently obvious, you can just eyeball the patch and sign off, methinks. Otherwise, testing can be done something like this: - Make sure you have enabled enhanced messaging preferences, and a patron with "Email" and "Digests only" set for "Item due" messages - Issue an item to this patron, with due date today - Run something like this to generate advance notices: $ sudo koha-shell -c "perl \ /home/vagrant/kohaclone/misc/cronjobs/advance_notices.pl -n -c" kohadev - See that no notices are shown (-n means messages will go to stdout, instead of into the message queue). - Apply the patch and run advance_notices.pl again, as before. A DUEDGST message should now be displayed. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 23 08:41:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Nov 2019 07:41:14 +0000 Subject: [Koha-bugs] [Bug 24072] Typos in advance_notices.pl causes DUEDGST not to be sent In-Reply-To: <bug-24072-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24072-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24072-70-TJosLPWlXy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24072 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Is 18.11 the right version here? It looks like send_digests was introduced later. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 23 08:47:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Nov 2019 07:47:41 +0000 Subject: [Koha-bugs] [Bug 24013] Transferring a checked out item gives a software error In-Reply-To: <bug-24013-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24013-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24013-70-qyfB3DBORg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24013 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 23 08:47:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Nov 2019 07:47:45 +0000 Subject: [Koha-bugs] [Bug 24013] Transferring a checked out item gives a software error In-Reply-To: <bug-24013-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24013-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24013-70-B3iMzHQQlY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24013 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95695|0 |1 is obsolete| | --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 95755 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95755&action=edit Bug 24013: Add tests Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 23 08:47:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Nov 2019 07:47:48 +0000 Subject: [Koha-bugs] [Bug 24013] Transferring a checked out item gives a software error In-Reply-To: <bug-24013-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24013-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24013-70-Dy5So7Ckpk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24013 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95696|0 |1 is obsolete| | --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 95756 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95756&action=edit Bug 24013: Fix transferbook if item is checked out Wrong conflict resolution, the following commit 6eade474ed3a84a5ba372a26ac27bf9fb4bd2299 Bug 18276: Remove GetBiblioFromItemNumber - Easy ones restored a previous change from commit 546379cc92b733cb29a0b70247a72c770afdad26 Bug 17680: C4::Circulation - Remove GetItemIssue, simple calls Not that "easy" or "simple"... Test plan: Run the test before and after this patch. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 23 08:55:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Nov 2019 07:55:04 +0000 Subject: [Koha-bugs] [Bug 23987] batchMod.pl provides a link back to the record after the record is deleted In-Reply-To: <bug-23987-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23987-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23987-70-fc9fOgLzy2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23987 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 23 08:55:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Nov 2019 07:55:07 +0000 Subject: [Koha-bugs] [Bug 23987] batchMod.pl provides a link back to the record after the record is deleted In-Reply-To: <bug-23987-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23987-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23987-70-iHxlJrBlH4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23987 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95711|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 95757 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95757&action=edit Bug 23987: Use src=CATALOGUING for edition/deletion in batch from items table There are 2 ways to land in batchMod from the detail page of a bib record: from the Edit menu, and the action buttons on top of the items table. We want the same behavior for both and so use src=CATALOGUING It will make batchMod to behave identically for the "return" button Signed-off-by: George Williams <george at nekls.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 23 08:55:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 23 Nov 2019 07:55:11 +0000 Subject: [Koha-bugs] [Bug 23987] batchMod.pl provides a link back to the record after the record is deleted In-Reply-To: <bug-23987-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23987-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23987-70-ozCSfLrf7R@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23987 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95712|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 95758 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95758&action=edit Bug 23987: "return to cataloguing" if the record is deleted from bachMod-del If a bibliographic record is deleted after having deleted all their items in a batch, we should not display a "return to the record" button but "return to cataloguing" instead Test plan: 1 - Have/make a bib with items 2 - On details page select Edit->Delete items in a batch 3 - Select all items and check "Delete record if no items remain" 4 - Delete the things 5 - On confirmation screen you have a count of items/bibs deleted => Without the patch there is a 'Return to record' button that leads to nowhere => With this patch there is a "Return to cataloging module" button 6 - Repeat using the "Delete selected items" link on top of the items table => Without the patch there is a 'Return to where you were' button that leads to nowhere => With this patch there is a "Return to cataloging module" button Note that there is a link AND a button, coming from commit 928c0af2b6a2c7aa6ed54019c5bd7dbddbccf4ee Bug 15824 - 'Done' button is unclear on batch item modification and deletion I do not think it makes sense to have both. Signed-off-by: George Williams <george at nekls.org> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 11:34:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 10:34:37 +0000 Subject: [Koha-bugs] [Bug 20116] Cache language list In-Reply-To: <bug-20116-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20116-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20116-70-yXLClGhy6y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Failed QA --- Comment #48 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I tried testing this, not sure if what I saw is to be expected: sudo koha-translate --update de-DE --dev kohadev German is updated, activated via sysprefs sudo koha-translate --remove de-DE --dev kohadev sudo koha-translate --list --dev kohadev Only shows inactive fr-FR. But: In the OPAC German is still visible and only disappears when I run restart_all. I reinstalled the language: sudo koha-translate --install de-DE --dev kohadev As an additional find, searching the language preferences from the German interface exploded in an error (search for langu): Can't use an undefined value as an ARRAY reference at /usr/lib/x86_64-linux-gnu/perl5/5.24/YAML/Syck.pm line 76 Jonathan, can you have a look? Just switching to FQA temporarily. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 12:54:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 11:54:11 +0000 Subject: [Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and should only work for for SIP-based checkouts In-Reply-To: <bug-23233-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23233-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23233-70-E6HRtd6tGP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|AllowItemsOnHoldCheckout is |AllowItemsOnHoldCheckout is |misnamed and does not |misnamed and should only |indicate it is for |work for for SIP-based |SIP-based checkouts only |checkouts Status|Failed QA |Signed Off QA Contact|testopia at bugs.koha-communit | |y.org | --- Comment #23 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Switching back to Signed off. Changes make sense to me now, tests pass, database update is ok, but I can't test the SIP part - can someone take over from here? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 13:25:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 12:25:33 +0000 Subject: [Koha-bugs] [Bug 5016] Basket PDF has several non-translatable issues In-Reply-To: <bug-5016-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-5016-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5016-70-tXb6aQaUXO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5016 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Small patch -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 13:25:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 12:25:38 +0000 Subject: [Koha-bugs] [Bug 5016] Basket PDF has several non-translatable issues In-Reply-To: <bug-5016-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-5016-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5016-70-DD8SVF6clB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5016 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 95759 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95759&action=edit Bug 5016: Fix some translation issues with English PDF order templates Changes made: - Instead of n° print no. - Market Identification => Market identification - GST => Tax To test: - Create at least 2 baskets with one or more orders - Create a basket group with those baskets - Print the PDF using - the 2 page layout - the 3 page layout - Verify that the changes made appear and everything looks correct -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 13:26:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 12:26:13 +0000 Subject: [Koha-bugs] [Bug 5016] Fix some terminology and wording issues on English PDF order templates In-Reply-To: <bug-5016-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-5016-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5016-70-4ZXUE8BcM3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5016 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Assignee|koha-bugs at lists.koha-commun |katrin.fischer at bsz-bw.de |ity.org | Summary|Basket PDF has several |Fix some terminology and |non-translatable issues |wording issues on English | |PDF order templates -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 13:26:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 12:26:46 +0000 Subject: [Koha-bugs] [Bug 5016] Fix some terminology and wording issues on English PDF order templates In-Reply-To: <bug-5016-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-5016-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5016-70-h9VQuM3rCN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5016 --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- > I don't know if this bug predates the introduction of the OrderPdfFormat > preference... It's better than nothing but only expands the options to > English, French, and German. Why don't we simply generate a printable view > and let the user save as/print to a PDF? Yes, that would be nice! -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 13:29:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 12:29:22 +0000 Subject: [Koha-bugs] [Bug 17831] Remove non-existing bibliosubject.subject mapping from frameworks In-Reply-To: <bug-17831-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17831-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17831-70-qZ9gRaSMe7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17831 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Item Search fails on custom |Remove non-existing |subject search field |bibliosubject.subject | |mapping from frameworks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 13:42:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 12:42:39 +0000 Subject: [Koha-bugs] [Bug 17831] Remove non-existing bibliosubject.subject mapping from frameworks In-Reply-To: <bug-17831-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17831-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17831-70-v0FBMNQb0G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17831 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 13:42:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 12:42:44 +0000 Subject: [Koha-bugs] [Bug 17831] Remove non-existing bibliosubject.subject mapping from frameworks In-Reply-To: <bug-17831-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17831-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17831-70-15f8fJT0xC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17831 --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 95760 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95760&action=edit Bug 17831: Remove non-existig bibliosubject.subject mapping from frameworks This patch removes the assignment of non-existent koha field 'bibliosubject.subject' to MARC subject fields in the installer data for koha To test: You'll want a new fresh db 1 - Apply patch 2 - Run websintaller 3 - Ensure that thigns go smoothly 4 - Add/delete/edit some records and ensure that things are working with the installed frameworks Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 13:42:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 12:42:48 +0000 Subject: [Koha-bugs] [Bug 17831] Remove non-existing bibliosubject.subject mapping from frameworks In-Reply-To: <bug-17831-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17831-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17831-70-fFA0AJoVa2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17831 --- Comment #9 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 95761 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95761&action=edit Bug 17831: Database update - Tidy up frameworks in existing installations The mapped table and column doesn't exist, so we should also remove it from existing installations. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 13:45:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 12:45:06 +0000 Subject: [Koha-bugs] [Bug 20948] Item-level hold info displayed regardless its priority (detail.pl) In-Reply-To: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20948-70-oKvtJegvqJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #17 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Is this similar/related to Bug 19288? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 13:46:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 12:46:26 +0000 Subject: [Koha-bugs] [Bug 23845] Dashboard for database In-Reply-To: <bug-23845-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23845-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23845-70-KXdmMaykbB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23845 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|18.11 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 13:48:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 12:48:54 +0000 Subject: [Koha-bugs] [Bug 16223] Automatically remove any borrower debarments after a payment In-Reply-To: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16223-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16223-70-yvvJJMtQaX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16223 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Should this be "patch doesn't apply"? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 13:50:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 12:50:00 +0000 Subject: [Koha-bugs] [Bug 23317] Elasticsearch - IntranetCatalogSearchPulldown breaks searching indexes via query In-Reply-To: <bug-23317-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23317-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23317-70-7WNClU7ddl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23317 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Nick Clemens from comment #4) > So this actually works in master currently, as long as 'keyword' is selected. > > If you try to select 'Title' in the dropdown and then search 'au:dickens' it > fails > > Do we need to support searches like that? I think 'expert search' is only expected to work with keyword selected - if that is the question :) -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 13:53:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 12:53:37 +0000 Subject: [Koha-bugs] [Bug 23882] Use xslt or notice for sending results by email In-Reply-To: <bug-23882-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23882-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23882-70-U9MKCRdnt2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23882 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- This reads like a duplicate to the older bug 3150. *** This bug has been marked as a duplicate of bug 3150 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 13:53:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 12:53:37 +0000 Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool In-Reply-To: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3150-70-OupZb2N7tI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |hagud at orex.es --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** Bug 23882 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 13:59:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 12:59:03 +0000 Subject: [Koha-bugs] [Bug 23883] sip_cli_emulator.pl - typo in parameter name In-Reply-To: <bug-23883-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23883-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23883-70-Lj4mVpKn24@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23883 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |robin at catalyst.net.nz Component|SIP2 |Command-line Utilities -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 14:04:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 13:04:02 +0000 Subject: [Koha-bugs] [Bug 24097] New: Don't show claims tab in patron account, when there are no claims Message-ID: <bug-24097-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24097 Bug ID: 24097 Summary: Don't show claims tab in patron account, when there are no claims Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Not every library will want to use this feature - I think it would be nicer if we didn't show the tab when there are no claims, so this is a bit more 'invisible'. It also matches how we handle other tabs. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 14:08:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 13:08:15 +0000 Subject: [Koha-bugs] [Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name In-Reply-To: <bug-6508-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6508-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6508-70-SozaqLwzZK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I agree with Martin that this doesn't add any additional information. I have another suggestion: We could only show the tab when there are any fines and charges. This way, for libraries not using fines it will be a nicer display and the tab appearing will have a meaning. I've also noticed that we only show the tab on details, but not on the checkouts tab. -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 14:12:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 13:12:50 +0000 Subject: [Koha-bugs] [Bug 24098] New: Capitalization: Fees & Charges Message-ID: <bug-24098-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24098 Bug ID: 24098 Summary: Capitalization: Fees & Charges Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org We have quite some templates where "Fees & Charges" appears. It should be "Fees & charges" instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 14:17:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 13:17:54 +0000 Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha namespace In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20443-70-sTKKrio13W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 14:24:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 13:24:34 +0000 Subject: [Koha-bugs] [Bug 23901] Fix js error sms_input is null in opac-messaging.tt In-Reply-To: <bug-23901-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23901-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23901-70-LytloW5O0e@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23901 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 14:24:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 13:24:38 +0000 Subject: [Koha-bugs] [Bug 23901] Fix js error sms_input is null in opac-messaging.tt In-Reply-To: <bug-23901-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23901-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23901-70-5gi2EgE7Iw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23901 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94769|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 95762 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95762&action=edit Bug 23901: Fix sms_input is null in opac-messaging.tt When sms messaging is disabled, JavaScript breaks in opac-messaging.tt. Bug introduced in Bug 22862. To test: 1. Enable EnhancedMessagingPreferences system preference 2. Disable sms messaging by unsetting SMSSendDriver system preference 3. Go to OPAC -> your messaging 4. Observe JavaScript error "sms_input is null" in your browser console 5. Apply patch 6. Refresh page and observe the error is gone Sponsored-by: Koha-Suomi Oy Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 14:24:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 13:24:41 +0000 Subject: [Koha-bugs] [Bug 23901] Fix js error sms_input is null in opac-messaging.tt In-Reply-To: <bug-23901-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23901-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23901-70-PxL9jiyiWu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23901 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94770|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 95763 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95763&action=edit Bug 23901: Fix indentation This patch only fixes the indentation of code inside the if-block. To test: 1. Apply patch 2. Run: git diff -w HEAD~1 and observe no result Sponsored-by: Koha-Suomi Oy Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 14:25:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 13:25:24 +0000 Subject: [Koha-bugs] [Bug 23901] Fix js error sms_input is null in opac-messaging.tt In-Reply-To: <bug-23901-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23901-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23901-70-zB9turL2GV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23901 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Passed QA --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Simple change, passing QA too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 14:26:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 13:26:28 +0000 Subject: [Koha-bugs] [Bug 23905] Button "Search to add" don't wor at Quick add new patron In-Reply-To: <bug-23905-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23905-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23905-70-JU9qDfupHF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 14:27:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 13:27:09 +0000 Subject: [Koha-bugs] [Bug 23905] Button "Search to add" doesn't work on Quick add new patron In-Reply-To: <bug-23905-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23905-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23905-70-U1QuFKT6Ps@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major Summary|Button "Search to add" |Button "Search to add" |don't wor at Quick add new |doesn't work on Quick add |patron |new patron --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Tested and confirmed on master - you can no longer add guarantors from the quick add form. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 14:32:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 13:32:08 +0000 Subject: [Koha-bugs] [Bug 23929] Invoice adjustments should filter inactive funds In-Reply-To: <bug-23929-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23929-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23929-70-kTOSfwXNfa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23929 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.11 |master CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 14:42:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 13:42:19 +0000 Subject: [Koha-bugs] [Bug 23452] Multiple select options in system preferences are not translatable In-Reply-To: <bug-23452-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23452-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23452-70-VQovCcFKzL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23452 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 14:42:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 13:42:23 +0000 Subject: [Koha-bugs] [Bug 23452] Multiple select options in system preferences are not translatable In-Reply-To: <bug-23452-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23452-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23452-70-1BFQGTW9pz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23452 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95008|0 |1 is obsolete| | --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 95764 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95764&action=edit Bug 23452: Multiple select options in system preferences are not translatable Translate script ignores multiple options in system preferences, this patch fix that. To test: 1) Apply the patch 2) Go to misc/translator cd misc/translator 3) Update your preferred language perl translate update xx-YY 4) Updated pref file must contain new strings, eg. egrep "when cataloguing an item" po/xx-YY-pref.po 5) Edit & translate that string 6) Install the updated translation perl translate install xx-YY 7) Check that the translated pref file has a) multiple options present b) the message from 5) is translated see for example circulation.pref en: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref xx: koha-tmpl/intranet-tmpl/prog/xx-YY/modules/admin/preferences/circulation.pref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 14:42:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 13:42:52 +0000 Subject: [Koha-bugs] [Bug 23452] Multiple select options in system preferences are not translatable In-Reply-To: <bug-23452-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23452-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23452-70-xAy7nCtj5O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23452 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95764|0 |1 is obsolete| | --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 95765 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95765&action=edit Bug 23452: Multiple select options in system preferences are not translatable Translate script ignores multiple options in system preferences, this patch fix that. To test: 1) Apply the patch 2) Go to misc/translator cd misc/translator 3) Update your preferred language perl translate update xx-YY 4) Updated pref file must contain new strings, eg. egrep "when cataloguing an item" po/xx-YY-pref.po 5) Edit & translate that string 6) Install the updated translation perl translate install xx-YY 7) Check that the translated pref file has a) multiple options present b) the message from 5) is translated see for example circulation.pref en: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref xx: koha-tmpl/intranet-tmpl/prog/xx-YY/modules/admin/preferences/circulation.pref -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 14:43:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 13:43:47 +0000 Subject: [Koha-bugs] [Bug 23452] Multiple select options in system preferences are not translatable In-Reply-To: <bug-23452-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23452-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23452-70-fjMnKXmYl7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23452 --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Works like a charm, sorry I missed this before String freeze. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 14:45:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 13:45:36 +0000 Subject: [Koha-bugs] [Bug 23966] Library transfer limits editor unusable for sites with many libraries and ccodes/itemtypes In-Reply-To: <bug-23966-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23966-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23966-70-nptHD48tpG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23966 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Branch Transfer Limits |Library transfer limits |editor unusable for sites |editor unusable for sites |with many libraries and |with many libraries and |ccodes/itemtypes |ccodes/itemtypes -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 14:47:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 13:47:26 +0000 Subject: [Koha-bugs] [Bug 23967] Add system preference information about OrderpriceRounding in 19.05 manual In-Reply-To: <bug-23967-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23967-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23967-70-nPh4ygMIOP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23967 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Manual CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- This appears to be still valid. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 14:54:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 13:54:34 +0000 Subject: [Koha-bugs] [Bug 23978] notes field in saved reports should allow HTML In-Reply-To: <bug-23978-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23978-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23978-70-q844W26if1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23978 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|18.11 |master --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Theodoros, all patches must be based on the current master branch and if it's a bug will then be backported to the older supported versions. Also, you need to create a patch, not just a diff - the file is missing some necessary information and can't be applied with our tools. Do you want to have another go at this? Please let us know if we can help! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 14:54:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 13:54:43 +0000 Subject: [Koha-bugs] [Bug 23978] Notes field in saved reports should allow for HTML In-Reply-To: <bug-23978-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23978-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23978-70-NHuDOgBajK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23978 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|notes field in saved |Notes field in saved |reports should allow HTML |reports should allow for | |HTML -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 14:56:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 13:56:29 +0000 Subject: [Koha-bugs] [Bug 19718] Create message for patrons with multiple holds on the same item In-Reply-To: <bug-19718-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19718-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19718-70-X4zBEKpHiA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19718 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |katrin.fischer at bsz-bw.de --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Switching to Signed off - the sandbox doesn't do it automatically, so I think it was just forgotten. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 14:57:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 13:57:44 +0000 Subject: [Koha-bugs] [Bug 23415] Notify patron fines when renewing In-Reply-To: <bug-23415-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23415-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23415-70-KLmkC4vFIX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23415 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |katrin.fischer at bsz-bw.de --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Marking FQA because of Anneli's last comment. Can you please give feedback? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 15:02:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 14:02:02 +0000 Subject: [Koha-bugs] [Bug 14680] when doing acquisitions from a staged file, MarcFieldsToOrder-syspref discounts are instead added. In-Reply-To: <bug-14680-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14680-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14680-70-vAyM8ehC0K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 15:05:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 14:05:29 +0000 Subject: [Koha-bugs] [Bug 13775] software error when choosing authority via plugin In-Reply-To: <bug-13775-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13775-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13775-70-AKPBmhp1Zc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13775 --- Comment #11 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Jonathan Druart from comment #10) > (In reply to Katrin Fischer from comment #8) > > Hi Jonathan, those are the ones for MARC21: > > > > SELECT authtypecode, auth_tag_to_report FROM koha_kohadev.auth_types where > > authtypecode != "" > > > > 'CHRON_TERM', '148' > > 'CORPO_NAME', '110' > > 'GENRE/FORM', '155' > > 'GEOGR_NAME', '151' > > 'MEETI_NAME', '111' > > 'PERSO_NAME', '100' > > 'TOPIC_TERM', '150' > > 'UNIF_TITLE', '130' > > It that correct for all marc flavors? Only for existing installs I guess? > Fix should be provided for existing installs, at code level then. What kind > message should we display to the user? This only applies to MARC21 - I am not sure if UNIMARC is different, but as it usually is... the SQL I provided could help with UNIMARC: SELECT authtypecode, auth_tag_to_report FROM koha_kohadev.auth_types where authtypecode != "" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 15:07:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 14:07:44 +0000 Subject: [Koha-bugs] [Bug 24012] Display 'Locked' budget in red In-Reply-To: <bug-24012-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24012-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24012-70-mCqEO6myGn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24012 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Keywords| |Academy -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 15:08:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 14:08:42 +0000 Subject: [Koha-bugs] [Bug 10047] Cataloguing search maybe useless? In-Reply-To: <bug-10047-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10047-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10047-70-8gUHteL58k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10047 --- Comment #18 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Cori Lynn Arnold from comment #17) > (In reply to Katrin Fischer from comment #16) > > > Hi Cori, 001 should be indexed as Control-number and be searchable. You > > could add it to advanced search pull downs using jQuery - would that help of > > have you already tried and found something not working? > > Katrin, > > Can you elaborate on this? Point me to some documentation? Which interface? Verified on IRC that we talked about different things - Cori wants this for the Z39.50/catalog search in the advanced cataloguing editor. I was thinking regular Advanced search. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 15:11:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 14:11:01 +0000 Subject: [Koha-bugs] [Bug 24014] Return to last Advanced Search link incorrectly encoded In-Reply-To: <bug-24014-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24014-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24014-70-7pKErP67cK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24014 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED Resolution|--- |WORKSFORME --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- It's now: <p><a href="[% ReturnPath | url %] This seems to work well in my tests. Marking "WORKSFORME". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 15:14:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 14:14:27 +0000 Subject: [Koha-bugs] [Bug 24015] UNIMARC Authorities update from IFLA for new Koha installations In-Reply-To: <bug-24015-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24015-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24015-70-24bZKekhip@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24015 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |MOVED CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Igor, I think these have been resolved: bug 18309 bug 20434 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 15:20:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 14:20:14 +0000 Subject: [Koha-bugs] [Bug 24037] Koha manual missing System Preference documentation for GDPR In-Reply-To: <bug-24037-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24037-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24037-70-8HUvC7FZcq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24037 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Keywords| |Manual -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 15:24:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 14:24:16 +0000 Subject: [Koha-bugs] [Bug 24039] Allow z3950 profiles to be linked to a user In-Reply-To: <bug-24039-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24039-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24039-70-wCcwtnjCoT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24039 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |DUPLICATE Status|NEW |RESOLVED CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think this is a duplicate to the older bug 5316. *** This bug has been marked as a duplicate of bug 5316 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 15:24:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 14:24:16 +0000 Subject: [Koha-bugs] [Bug 5316] Limit Z39.50 targets to specific users In-Reply-To: <bug-5316-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-5316-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5316-70-QnTDMYPhh7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5316 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |chris at bigballofwax.co.nz --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** Bug 24039 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 15:26:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 14:26:00 +0000 Subject: [Koha-bugs] [Bug 24040] Browser Tab closing when open through Manage Staged marc records In-Reply-To: <bug-24040-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24040-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24040-70-v93Xzrm5Fh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24040 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE Status|NEW |RESOLVED See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=23680 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** This bug has been marked as a duplicate of bug 23680 *** -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 15:26:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 14:26:00 +0000 Subject: [Koha-bugs] [Bug 23680] Can't open 'Edit items' or 'Add item' links in new tab - tab is closed immediately In-Reply-To: <bug-23680-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23680-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23680-70-PhbQqQik4z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23680 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24040 CC| |kelly at bywatersolutions.com --- Comment #13 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** Bug 24040 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 15:29:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 14:29:22 +0000 Subject: [Koha-bugs] [Bug 24046] 'Activate filters' untranslatable In-Reply-To: <bug-24046-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24046-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24046-70-uup3P8i6We@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24046 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 15:31:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 14:31:14 +0000 Subject: [Koha-bugs] [Bug 13246] Item edit doesn't respect cn_source if not defined In-Reply-To: <bug-13246-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13246-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13246-70-kJPagPfmkl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13246 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- This doesn't sound wrong to me - if you don't set any default classification source it will cause problems with cn_sort - so it makes sense to enforce the default if nothing is selected. Maybe the subfield should be made mandatory by default? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 15:35:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 14:35:56 +0000 Subject: [Koha-bugs] [Bug 24063] Add Sami language characters to Zebra In-Reply-To: <bug-24063-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24063-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24063-70-Wz7ckIbUsA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24063 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 15:35:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 14:35:59 +0000 Subject: [Koha-bugs] [Bug 24063] Add Sami language characters to Zebra In-Reply-To: <bug-24063-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24063-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24063-70-1JBpW3KEA9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24063 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95527|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 95766 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95766&action=edit Bug 24063: Add Sami language characters to Zebra Some Sami languages need few more characters to be mapped, or are otherwise very hard to search for. Test plan: 1) Catalogue a new record with title "Ǩoǯeŋa" 2) Make sure zebra indexed that record, then try to search for it with the text "kozena" 3) Apply patch 4) Redo 2, now the record should be found. Signed-off-by: Pasi Kallinen <pasi.kallinen at koha-suomi.fi> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 15:37:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 14:37:19 +0000 Subject: [Koha-bugs] [Bug 23971] Add logging for basket related actions In-Reply-To: <bug-23971-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23971-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23971-70-wTfph7IWyy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #5 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think Severine is right - logging the reopening of a basket would be really helpful. Andrew, could this be added to this patch set? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 15:38:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 14:38:32 +0000 Subject: [Koha-bugs] [Bug 23971] Add logging for basket related actions In-Reply-To: <bug-23971-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23971-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23971-70-M0RbpZbcAb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think the missing pref could be considered a "Failed QA" as we should stick with existing patterns and it makes sense here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 15:40:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 14:40:54 +0000 Subject: [Koha-bugs] [Bug 23256] fr-CA OPAC_REG_VERIFY has hard-coded http:// In-Reply-To: <bug-23256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23256-70-sSpZU0w5Rl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23256 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 15:40:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 14:40:58 +0000 Subject: [Koha-bugs] [Bug 23256] fr-CA OPAC_REG_VERIFY has hard-coded http:// In-Reply-To: <bug-23256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23256-70-7ORiqq3fSR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23256 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95616|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 95767 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95767&action=edit Bug 23256: Remove the http:// prefix before OPACBaseURL in OPAC_REG_VERIFY The title explained everything, compare with installer/data/mysql/fr-FR/1-Obligatoire/sample_notices.sql and other notices. It's certainly due to the fact that fr-CA took time to be integrated and the change happened in the meanwhile Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 15:42:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 14:42:22 +0000 Subject: [Koha-bugs] [Bug 23256] fr-CA OPAC_REG_VERIFY has hard-coded http:// In-Reply-To: <bug-23256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23256-70-S3i9dROGqR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23256 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Status|Signed Off |Passed QA --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Trivial fix, passing QA. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 15:43:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 14:43:57 +0000 Subject: [Koha-bugs] [Bug 9993] On editing basket group delivery place resets to logged in branch In-Reply-To: <bug-9993-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9993-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9993-70-EpPYEk2lhv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9993 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Owen, something seems to have gone wrong with the patch file - can you have a look please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 15:47:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 14:47:38 +0000 Subject: [Koha-bugs] [Bug 24076] Remove inline CSS to center patron home library in search results In-Reply-To: <bug-24076-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24076-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24076-70-kMtSD1pGwD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24076 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 15:47:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 14:47:42 +0000 Subject: [Koha-bugs] [Bug 24076] Remove inline CSS to center patron home library in search results In-Reply-To: <bug-24076-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24076-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24076-70-dIDf8TZLAn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24076 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95638|0 |1 is obsolete| | --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Created attachment 95768 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95768&action=edit Bug 24076: Remove inline CSS to center patron home library in search results This patch removes code from the patron search results DataTable configuration which was designed to add "text-align:center" to the table cells containing patron home library. I don't think there's a good reason to centering to that data. To test, apply the patch and perform a patron search in the staff client. The "Library" column should contain left-aligned data, matching almost every other column in the table. Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 15:48:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 14:48:01 +0000 Subject: [Koha-bugs] [Bug 24076] Remove inline CSS to center patron home library in search results In-Reply-To: <bug-24076-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24076-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24076-70-MtMV6zkTZI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24076 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 15:48:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 14:48:57 +0000 Subject: [Koha-bugs] [Bug 24031] Add plugin hook after_hold_create In-Reply-To: <bug-24031-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24031-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24031-70-6eHnqHMh9b@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24031 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Please remember to add the new hook to the wiki once pushed: https://wiki.koha-community.org/wiki/Koha_Plugin_Hooks -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 15:53:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 14:53:04 +0000 Subject: [Koha-bugs] [Bug 23249] Print hold slips without confirmation for multiple locations In-Reply-To: <bug-23249-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23249-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23249-70-XmqTbUC9DU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23249 --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to jdemuth at roseville.ca.us from comment #2) > Hi Nick, > > Yes, it would be ideal if the transfer would just display a transfer box > that would require the user to hit OK to move on. The hold/transfer slip > that prints looks just like a hold slip our library uses on the floor and > was confusing to staff. If there needs to be a printed slip, it would be > nice if it was a different kind of slip for staff to recognize it was a > transfer hold. > > Thanks, > > Jen Hi Jen, I think bug 23249 goes in this direction. It would allow to print a transfer slip instead of a hold slip. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 15:59:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 14:59:56 +0000 Subject: [Koha-bugs] [Bug 23661] Check "Hold Pickup Library Match" when placing a hold In-Reply-To: <bug-23661-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23661-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23661-70-MMXaI7ZeRq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23661 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|19.05 |master CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 16:07:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 15:07:38 +0000 Subject: [Koha-bugs] [Bug 23620] Improve checkin message when suspensions are accrued at check in to include number of 'days' overdue and the resulting no. of suspension days In-Reply-To: <bug-23620-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23620-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23620-70-g0ZTeu0XDV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23620 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.11 |master CC| |katrin.fischer at bsz-bw.de Summary|Improve checkin message |Improve checkin message |when suspensions are |when suspensions are |accrued at check into |accrued at check in to |include number of 'days' |include number of 'days' |overdue and the resulting |overdue and the resulting |no. of suspension days. |no. of suspension days -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 16:11:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 15:11:24 +0000 Subject: [Koha-bugs] [Bug 22794] Omnibus: Improve and extend logging in Koha In-Reply-To: <bug-22794-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22794-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22794-70-BaG5xvRm6V@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|3342, 7021, 8094, 8273, | |8731, 8881, 9762, 23971, | |10680 | Depends on| |3342, 7021, 8094, 8273, | |8731, 8881, 9762, 23971, | |10680 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3342 [Bug 3342] Changes to holds priority list should be logged for accountability https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 [Bug 7021] patron category in the statistics table https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8094 [Bug 8094] Record interface for web based self checkouts in action logs https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8273 [Bug 8273] Add biblionumber to deleted item on log https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8731 [Bug 8731] Holds Log to track the number of times a hold is overriden https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8881 [Bug 8881] Tool to purge action logs https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 [Bug 9762] Log circulation overrides https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10680 [Bug 10680] "Modification log" gives wrong data https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 [Bug 23971] Add logging for basket related actions -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 16:11:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 15:11:24 +0000 Subject: [Koha-bugs] [Bug 3342] Changes to holds priority list should be logged for accountability In-Reply-To: <bug-3342-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-3342-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3342-70-tE6Rru0Q34@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3342 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22794 Depends on|22794 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794 [Bug 22794] Omnibus: Improve and extend logging in Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 16:11:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 15:11:24 +0000 Subject: [Koha-bugs] [Bug 7021] patron category in the statistics table In-Reply-To: <bug-7021-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7021-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7021-70-Kmwy6ZsU3x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7021 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22794 Depends on|22794 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794 [Bug 22794] Omnibus: Improve and extend logging in Koha -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 16:11:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 15:11:24 +0000 Subject: [Koha-bugs] [Bug 8731] Holds Log to track the number of times a hold is overriden In-Reply-To: <bug-8731-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8731-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8731-70-YDEaonuBO5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8731 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22794 Depends on|22794 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794 [Bug 22794] Omnibus: Improve and extend logging in Koha -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 16:11:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 15:11:24 +0000 Subject: [Koha-bugs] [Bug 8094] Record interface for web based self checkouts in action logs In-Reply-To: <bug-8094-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8094-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8094-70-jW5OOtHiJT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8094 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22794 Depends on|22794 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794 [Bug 22794] Omnibus: Improve and extend logging in Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 16:11:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 15:11:24 +0000 Subject: [Koha-bugs] [Bug 8273] Add biblionumber to deleted item on log In-Reply-To: <bug-8273-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8273-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8273-70-NdyzA1tVx8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8273 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22794 Depends on|22794 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794 [Bug 22794] Omnibus: Improve and extend logging in Koha -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 16:11:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 15:11:24 +0000 Subject: [Koha-bugs] [Bug 8881] Tool to purge action logs In-Reply-To: <bug-8881-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8881-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8881-70-6izRM4hB0L@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8881 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22794 Depends on|22794 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794 [Bug 22794] Omnibus: Improve and extend logging in Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 16:11:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 15:11:24 +0000 Subject: [Koha-bugs] [Bug 9762] Log circulation overrides In-Reply-To: <bug-9762-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9762-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9762-70-E8k77g53qe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9762 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22794 Depends on|22794 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794 [Bug 22794] Omnibus: Improve and extend logging in Koha -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 16:11:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 15:11:24 +0000 Subject: [Koha-bugs] [Bug 10680] "Modification log" gives wrong data In-Reply-To: <bug-10680-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10680-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10680-70-0XuRspGNZB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10680 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|19.05 |--- Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22794 Depends on|22794 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794 [Bug 22794] Omnibus: Improve and extend logging in Koha -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 16:11:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 15:11:24 +0000 Subject: [Koha-bugs] [Bug 23971] Add logging for basket related actions In-Reply-To: <bug-23971-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23971-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23971-70-612th3qCOB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |22794 Depends on|22794 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22794 [Bug 22794] Omnibus: Improve and extend logging in Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 16:11:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 15:11:51 +0000 Subject: [Koha-bugs] [Bug 23508] Track changes made to Circulation and Fine rule Matrix In-Reply-To: <bug-23508-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23508-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23508-70-6chhwhlXrt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23508 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Resolution|--- |DUPLICATE Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** This bug has been marked as a duplicate of bug 16544 *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 16:11:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 15:11:51 +0000 Subject: [Koha-bugs] [Bug 16544] Changes to circ rules should be logged In-Reply-To: <bug-16544-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16544-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16544-70-jzbXIebtKP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16544 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly at bywatersolutions.com --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- *** Bug 23508 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 16:18:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 15:18:28 +0000 Subject: [Koha-bugs] [Bug 23340] Patron import tool allows duplication of unique attributes In-Reply-To: <bug-23340-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23340-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23340-70-ED7MqzdXaT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23340 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Version|18.11 |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 16:18:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 15:18:33 +0000 Subject: [Koha-bugs] [Bug 23340] Patron import tool allows duplication of unique attributes In-Reply-To: <bug-23340-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23340-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23340-70-4hja6xJWsM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23340 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 16:44:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 15:44:52 +0000 Subject: [Koha-bugs] [Bug 23244] Sort order in basket to default to title In-Reply-To: <bug-23244-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23244-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23244-70-J2JJFcqRVd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23244 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.11 |master CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 17:04:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 16:04:09 +0000 Subject: [Koha-bugs] [Bug 23030] Installation and last update date in About In-Reply-To: <bug-23030-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23030-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23030-70-lsXwzHrmrL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23030 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Install Date |Installation and last | |update date in About CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 17:04:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 16:04:56 +0000 Subject: [Koha-bugs] [Bug 14666] adds fixed_fines for overdues In-Reply-To: <bug-14666-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14666-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14666-70-WSrCE96YdS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14666 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |dependency -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 17:05:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 16:05:41 +0000 Subject: [Koha-bugs] [Bug 23041] Add Custom reports/notices to patron record In-Reply-To: <bug-23041-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23041-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23041-70-60oENg1Mh4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23041 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Add Custom reports to |Add Custom reports/notices |patron record |to patron record -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 17:09:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 16:09:51 +0000 Subject: [Koha-bugs] [Bug 23087] Update DB system for Mana In-Reply-To: <bug-23087-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23087-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23087-70-5gP63t86vN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23087 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |FIXED --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Pull request has been merged - closing here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 17:20:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 16:20:59 +0000 Subject: [Koha-bugs] [Bug 22572] Garbled content of MARC control fields in MARC view In-Reply-To: <bug-22572-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22572-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22572-70-SeGoTrxznl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22572 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Should this be 'needs signoff'? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 20:45:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 19:45:39 +0000 Subject: [Koha-bugs] [Bug 22822] Ability to define circulation rule sets that can be applied to libraries In-Reply-To: <bug-22822-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22822-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22822-70-AdyB9L4hTi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22822 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Better Circulation Rules |Ability to define | |circulation rule sets that | |can be applied to libraries CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 21:35:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 20:35:52 +0000 Subject: [Koha-bugs] [Bug 24099] New: Capitalization: Copier Fees Message-ID: <bug-24099-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24099 Bug ID: 24099 Summary: Capitalization: Copier Fees Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Keywords: Academy Severity: trivial Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Manual debit type "Copier Fees" should be "Copier fees". -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 21:39:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 20:39:58 +0000 Subject: [Koha-bugs] [Bug 24100] New: "Pay selected" is broken Message-ID: <bug-24100-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24100 Bug ID: 24100 Summary: "Pay selected" is broken Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: critical Priority: P5 - low Component: Fines and fees Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org When using the "Pay selected" button to pay manual fees, I have the following error: Can't locate object method "search" via package "koha::account::lines" (perhaps you forgot to load "koha::account::lines"?) at /home/vagrant/kohaclone/members/paycollect.pl line 146 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 21:40:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 20:40:57 +0000 Subject: [Koha-bugs] [Bug 22912] Accidental multiple clicking of fine "pay" creates multiple entries in accountlines table In-Reply-To: <bug-22912-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22912-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22912-70-Ug1aWpYKfO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22912 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED CC| |katrin.fischer at bsz-bw.de Resolution|--- |WORKSFORME --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I've tried to reproduce this and failed as well - Closing WORKSFORME. Please reopen with more information if the problem still exists. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 21:43:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 20:43:26 +0000 Subject: [Koha-bugs] [Bug 22942] Inclusion of Javascript file references with IntranetUserJS or OPACUserJS In-Reply-To: <bug-22942-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22942-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22942-70-0seWihfdts@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22942 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|inclusion of javascript |Inclusion of Javascript |with IntranetUserJS or |file references with |OPACUserJS |IntranetUserJS or | |OPACUserJS CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 21:46:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 20:46:34 +0000 Subject: [Koha-bugs] [Bug 23023] Issue for subscription, but no item is added when duplicate barcode is used In-Reply-To: <bug-23023-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23023-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23023-70-ccBDdlof3H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23023 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|System adds item in |Issue for subscription, but |subscription but not in |no item is added when |record when duplicate |duplicate barcode is used |barcode is used | CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 21:47:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 20:47:47 +0000 Subject: [Koha-bugs] [Bug 23008] System preference AllowHoldItemTypeSelection to include more information In-Reply-To: <bug-23008-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23008-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23008-70-9nBMKaIOaw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23008 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Keywords| |Manual -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 21:49:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 20:49:21 +0000 Subject: [Koha-bugs] [Bug 23003] Accessibility improvements In-Reply-To: <bug-23003-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23003-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23003-70-2wGx3DJeOn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23003 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 21:53:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 20:53:27 +0000 Subject: [Koha-bugs] [Bug 23002] OPAC doesn't retain search filters in results pages In-Reply-To: <bug-23002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23002-70-eLSAla4thx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23002 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #2 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Alexandre, I cannot reproduce this. Could you please add a 'step by step' explanation that I can follow? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 21:53:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 20:53:58 +0000 Subject: [Koha-bugs] [Bug 23002] OPAC doesn't retain search filters in results pages In-Reply-To: <bug-23002-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23002-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23002-70-N0SIiuMj2l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23002 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |minor -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 21:55:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 20:55:40 +0000 Subject: [Koha-bugs] [Bug 22995] when importing from Z3950 format indicators In-Reply-To: <bug-22995-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22995-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22995-70-ARQSYEdUBv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22995 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Christophe, I am sorry, can you rephrase your bug report a bit? I don't understand the problem yet. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 22:09:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 21:09:43 +0000 Subject: [Koha-bugs] [Bug 7957] Routing lists: manage several routing list for each subscription, and export them as CSV In-Reply-To: <bug-7957-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7957-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7957-70-MDfhQG1dHT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7957 --- Comment #82 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to David Cook from comment #81) > Looking at the patches, is the idea that you'd have a routing list per issue? Multiple routing lists per subscription. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 22:27:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 21:27:38 +0000 Subject: [Koha-bugs] [Bug 12156] Merging staged records with no 952c with records created in acquisitions loses data from both In-Reply-To: <bug-12156-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12156-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12156-70-xlXoVMj0dh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12156 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |liz at bywatersolutions.com --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Liz, do you know if this is still an issue? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 22:27:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 21:27:51 +0000 Subject: [Koha-bugs] [Bug 12156] Merging staged records with no 942c with records created in acquisitions loses data from both In-Reply-To: <bug-12156-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12156-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12156-70-JpV8EYo9tg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12156 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Merging staged records with |Merging staged records with |no 952c with records |no 942c with records |created in acquisitions |created in acquisitions |loses data from both |loses data from both -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 22:28:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 21:28:32 +0000 Subject: [Koha-bugs] [Bug 21927] Acq: Allow blank values in pull downs in the item form when subfield is mandatory In-Reply-To: <bug-21927-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21927-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21927-70-bOtWL2YX6q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21927 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 22:36:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 21:36:50 +0000 Subject: [Koha-bugs] [Bug 14863] Koha authorities update linking authorities in subfield '0' In-Reply-To: <bug-14863-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14863-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14863-70-6wZ21gZ9pD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14863 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED CC| |katrin.fischer at bsz-bw.de Status|NEW |RESOLVED --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Eugene, I am not sure if I am understanding correctly, but there is the link_bibs_to_authorities.pl for linking records with authorities in Koha. Marking RESOLVED, please reopen with more information on the problem if I am mistaken. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 22:41:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 21:41:36 +0000 Subject: [Koha-bugs] [Bug 20841] Fine description is missing in payment details In-Reply-To: <bug-20841-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20841-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20841-70-fjm2NIvjo8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20841 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|Barcode and description are |Fine description is missing |needed in payment details |in payment details --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think this could be a regression - I seem to remember it was there when I tested the feature initially. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 22:46:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 21:46:00 +0000 Subject: [Koha-bugs] [Bug 21983] Deleting a bib does not delete a request's link to it - missing foreign key In-Reply-To: <bug-21983-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21983-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21983-70-8pHSbTsh1D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 --- Comment #7 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Andrew Isherwood from comment #6) > But it's just a foreign key to the (now deleted) bib ID, is that useful > information that needs preserving? Sorry, genuine question, I'm not being > facetious :) As long as the bilbio_id is there, you can join on the deleted* tables and get information about the records that were requested. This is interesting information to libraries. Example: if a record was requested multiple times, they might to purchase it. If records from a certain subject are ordered more than other subjects, they might want to shift the budget in this direction, etc. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 22:47:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 21:47:07 +0000 Subject: [Koha-bugs] [Bug 21983] Deleting a bib does not delete a request's link to it - missing foreign key In-Reply-To: <bug-21983-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21983-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21983-70-mcK3XL8LB2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21983 --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I think Martin solved this somewhere else by having a separate column for the deleted ID as this will allow to have cleaner FK constraints, but I don't quite remember the bug report at the moment. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 22:52:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 21:52:05 +0000 Subject: [Koha-bugs] [Bug 22470] Missing the table name on misc/migration_tools/switch_marc21_series_info.pl In-Reply-To: <bug-22470-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22470-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22470-70-FUz6Iul0Ix@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22470 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy Assignee|gveranis at gmail.com |koha-bugs at lists.koha-commun | |ity.org Status|ASSIGNED |NEW --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Changing back to default assignee. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 23:01:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 22:01:53 +0000 Subject: [Koha-bugs] [Bug 22691] Problem with holds when ExpireReservesMaxPickUpDelay is active In-Reply-To: <bug-22691-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22691-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22691-70-jyRQ1HXHq9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22691 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Patrick, is this bug still happening for you? Could you check the expirationdate of the waiting hold in the reserves table? This should be the date calculated for pickup from ExpireReservesMaxPickUpDelay and the day the hold is cancelld by the cronjob if not picked up. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 23:04:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 22:04:57 +0000 Subject: [Koha-bugs] [Bug 22712] Funds from inactive budgets appear on Item details if using MarcItemFieldstoOrder In-Reply-To: <bug-22712-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22712-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22712-70-MoKYSyISRq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22712 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Could this have been related to bug 20014? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 23:07:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 22:07:16 +0000 Subject: [Koha-bugs] [Bug 22720] Including branchcode in PatronSelfModificationBorrowerUnwantedField causes internal server error on self registration page In-Reply-To: <bug-22720-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22720-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22720-70-XOSqS3s0MB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22720 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Maybe we could make it a hidden form element for libraries with only one branch. For libraries with more than one branch, we could make the library pull down always show and display a note about the 'misconfiguration' on the About page? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 23:09:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 22:09:50 +0000 Subject: [Koha-bugs] [Bug 22752] Show if a placed hold is record or item level in the patron account in the OPAC In-Reply-To: <bug-22752-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22752-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22752-70-uFTJWl9u0h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22752 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy CC| |katrin.fischer at bsz-bw.de Summary|Show next available or item |Show if a placed hold is |specific hold types in |record or item level in the |opac-user.pl#opac-user-hold |patron account in the OPAC |s | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 23:12:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 22:12:20 +0000 Subject: [Koha-bugs] [Bug 22797] ILS-DI: GetRecords doesn't work with documented parameter id_type In-Reply-To: <bug-22797-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22797-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22797-70-sYcaPi4saG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22797 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- I'd vote for removing it from the documentation as a first simple step. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 23:18:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 22:18:43 +0000 Subject: [Koha-bugs] [Bug 22328] Inconsistent behavior throughout acquisitions for determining whether or not an item has been received In-Reply-To: <bug-22328-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22328-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22328-70-kZoRi7Dnmw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22328 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Inconsistent behavior |Inconsistent behavior |throughout acquisitions for |throughout acquisitions for |determining whether or not |determining whether or not |an item as been received |an item has been received -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 23:20:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 22:20:56 +0000 Subject: [Koha-bugs] [Bug 22290] Next pages results for cyrillic symbols shows decoded text in URL in anchor tag In-Reply-To: <bug-22290-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22290-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22290-70-3Cls4xqyCG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22290 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|REOPENED |NEW CC| |katrin.fischer at bsz-bw.de Assignee|gveranis at gmail.com |koha-bugs at lists.koha-commun | |ity.org --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Resetting assignee to default -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 23:21:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 22:21:42 +0000 Subject: [Koha-bugs] [Bug 22281] Does new Firefox update break some shortcut keys? (keypress deprecated) In-Reply-To: <bug-22281-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22281-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22281-70-0HYvuwvcgo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22281 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 23:22:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 22:22:30 +0000 Subject: [Koha-bugs] [Bug 22087] It would be helpful to have City and State visible in member.pl In-Reply-To: <bug-22087-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22087-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22087-70-XL7mrrWHWH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22087 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sun Nov 24 23:26:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sun, 24 Nov 2019 22:26:54 +0000 Subject: [Koha-bugs] [Bug 21071] Search results not sorting in staff client advanced search when only AdvancedSearchTypes checkboxes are used In-Reply-To: <bug-21071-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21071-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21071-70-tYIoWqn8BN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21071 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #6 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Lucy Vaux-Harvey from comment #5) > I think this bug can be > closed as the site will upgrade in the coming months. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 06:22:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 05:22:10 +0000 Subject: [Koha-bugs] [Bug 20826] libnet-oauth2-authorizationserver-perl not installable on 32bit systems In-Reply-To: <bug-20826-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20826-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20826-70-HVQn42dAZ8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20826 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mtj at kohaaloha.com --- Comment #21 from Mason James <mtj at kohaaloha.com> --- (In reply to Geodirk from comment #20) > Is there a final solution for this as I hit the same > libnet-oauth2-authorizationserver-perl issue? I went and changed the > /etc/apt/sources.list.d/koha.list to become: deb > http://debian.koha-community.org/koha 18.11 main > > After an apt-get update, I get this: > > root at connectbox:~# apt-get update > Hit:1 http://archive.raspberrypi.org/debian stretch InRelease > Hit:2 http://raspbian.raspberrypi.org/raspbian stretch InRelease > Hit:3 http://debian.koha-community.org/koha 18.11 InRelease > Reading package lists... Done > N: Skipping acquire of configured file 'main/binary-armhf/Packages' as > repository 'http://debian.koha-community.org/koha 18.11 InRelease' doesn't > support architecture 'armhf' > > What am I missing? Also trying to install on a RPi 3B+ (32 bit). try prefixing your koha repo line with 'deb [arch=i386] ', like... deb [arch=i386] http://debian.koha-community.org/koha stable main then run 'sudo apt-get update' again fyi, some good info here... http://avengingchicken.online/misc/installing_koha_on_raspberry-pi-4.pdf -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 06:29:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 05:29:02 +0000 Subject: [Koha-bugs] [Bug 20826] libnet-oauth2-authorizationserver-perl not installable on armhf/rpi systems In-Reply-To: <bug-20826-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20826-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20826-70-A7J8gEhsG2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20826 Mason James <mtj at kohaaloha.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|libnet-oauth2-authorization |libnet-oauth2-authorization |server-perl not installable |server-perl not installable |on 32bit systems |on armhf/rpi systems --- Comment #22 from Mason James <mtj at kohaaloha.com> --- > fyi, some good info here... > http://avengingchicken.online/misc/installing_koha_on_raspberry-pi-4.pdf here too.. https://wiki.koha-community.org/wiki/Koha_on_a_Raspberry_Pi_3_B%2B ------------ Add the Koha package source information 1. Add the source information for the Koha package: echo deb [arch=i386] http://debian.koha-community.org/koha stable main | sudo tee /etc/apt/sources.list.d/koha.list ------------ -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 07:57:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 06:57:52 +0000 Subject: [Koha-bugs] [Bug 23927] Duplicate a "Complete" order link the "New" one to the invoice In-Reply-To: <bug-23927-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23927-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23927-70-roXo5eUPbt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23927 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de --- Comment #3 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Séverine Queune from comment #2) > To me, as it's supposed to be a new order, status should be "NEW". > The fact we use an other order is just a way to ease the acquisition process > (e.g dictionaries, references items or subscriptions we want to buy each > year), so it should not have effect on the new order. +1 The status should be new and the datereceived and invoiceid etc. should be empty. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 08:13:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 07:13:50 +0000 Subject: [Koha-bugs] [Bug 24072] Typos in advance_notices.pl causes DUEDGST not to be sent In-Reply-To: <bug-24072-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24072-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24072-70-xFVbHdmJhL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24072 Magnus Enger <magnus at libriotech.no> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.11 |master --- Comment #6 from Magnus Enger <magnus at libriotech.no> --- (In reply to Katrin Fischer from comment #5) > Is 18.11 the right version here? It looks like send_digests was introduced > later. You are right, of course. It is relevant to master and 19.05. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 09:43:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 08:43:49 +0000 Subject: [Koha-bugs] [Bug 23901] Fix js error sms_input is null in opac-messaging.tt In-Reply-To: <bug-23901-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23901-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23901-70-DGIX8JE5I6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23901 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 09:43:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 08:43:51 +0000 Subject: [Koha-bugs] [Bug 23901] Fix js error sms_input is null in opac-messaging.tt In-Reply-To: <bug-23901-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23901-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23901-70-Tms58icqSr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23901 --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 09:43:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 08:43:53 +0000 Subject: [Koha-bugs] [Bug 24013] Transferring a checked out item gives a software error In-Reply-To: <bug-24013-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24013-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24013-70-jEEGyfjfIv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24013 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 09:43:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 08:43:56 +0000 Subject: [Koha-bugs] [Bug 24013] Transferring a checked out item gives a software error In-Reply-To: <bug-24013-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24013-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24013-70-QGENm1QslT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24013 --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 09:43:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 08:43:57 +0000 Subject: [Koha-bugs] [Bug 24072] Typos in advance_notices.pl causes DUEDGST not to be sent In-Reply-To: <bug-24072-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24072-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24072-70-sZlfFO23DQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24072 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 09:43:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 08:43:59 +0000 Subject: [Koha-bugs] [Bug 24072] Typos in advance_notices.pl causes DUEDGST not to be sent In-Reply-To: <bug-24072-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24072-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24072-70-y5okM0i8yR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24072 --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 09:44:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 08:44:01 +0000 Subject: [Koha-bugs] [Bug 24084] PlainMARC view broken on OPAC if other $.ajax calls produce errors In-Reply-To: <bug-24084-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24084-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24084-70-8BxbUQhsrf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24084 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 09:44:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 08:44:03 +0000 Subject: [Koha-bugs] [Bug 24084] PlainMARC view broken on OPAC if other $.ajax calls produce errors In-Reply-To: <bug-24084-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24084-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24084-70-laXkf1mLYk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24084 --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 09:44:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 08:44:04 +0000 Subject: [Koha-bugs] [Bug 24093] Sorting indicators broken on list contents view In-Reply-To: <bug-24093-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24093-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24093-70-up4L6zXKrh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24093 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 09:44:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 08:44:06 +0000 Subject: [Koha-bugs] [Bug 24093] Sorting indicators broken on list contents view In-Reply-To: <bug-24093-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24093-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24093-70-BCOCkATGiM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24093 --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 09:48:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 08:48:35 +0000 Subject: [Koha-bugs] [Bug 24101] New: Due date to on-site loans according to the calendar and possibility to renew on-site loans Message-ID: <bug-24101-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24101 Bug ID: 24101 Summary: Due date to on-site loans according to the calendar and possibility to renew on-site loans Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: new feature Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: inkeri.hakulinen+bugz at helsinki.fi QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com We have reading rooms, where patrons can have their on-site loans available for them for a long time - even a year or more! (That is, if no one else needs that item in the meanwhile, and makes a hold for it.) We wish to be able to distinguish the on-site loans from the checkouts they take home. The on-site option is good for this, because it shows clearly to the patrons and to the staff that the loans are on-site. However, we need two improvements to Koha for this. First, we need the option to set the due date automatically according to the calendar and the circulation rules, taking into account the holidays and the loan period that is set to the patron and to the item. In addition, we need the option for the patrons to be able to renew their on-site loans, too. Now the on-site loans are non-renewable, so if the patron needs them longer than what is set to due date originally, it would be good for them to be able to renew the loans themselves through our OPAC. Now the renewal is impossible altogether. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 09:50:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 08:50:14 +0000 Subject: [Koha-bugs] [Bug 23702] New UNIMARC XSLT according to last IFLA updates In-Reply-To: <bug-23702-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23702-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23702-70-0pDNQQ3YnM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23702 Julian Maurice <julian.maurice at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |julian.maurice at biblibre.com --- Comment #19 from Julian Maurice <julian.maurice at biblibre.com> --- I guess the status should be needs signoff, but there are some problems in the patch: FAIL koha-tmpl/intranet-tmpl/prog/en/xslt/UNIMARCslim2intranetResults.xsl FAIL xml_valid 266: parser error : Entity 'nbsp' not defined 88: parser error : Entity 'nbsp' not defined 73: parser error : Entity 'nbsp' not defined FAIL koha-tmpl/opac-tmpl/bootstrap/en/xslt/UNIMARCslimUtils.xsl FAIL xml_valid 447: parser error : Opening and ending tag mismatch: for-each line 180 and when 224: parser error : Opening and ending tag mismatch: when line 184 and if 497: parser error : Opening and ending tag mismatch: stylesheet line 3 and span 446: parser error : Opening and ending tag mismatch: span line 181 and xsl:if 496: parser error : Opening and ending tag mismatch: template line 179 and choose 225: parser error : Opening and ending tag mismatch: choose line 183 and when 498: parser error : Extra content at the end of the document -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 09:57:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 08:57:31 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23260-70-vs9qFs9B87@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 --- Comment #38 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Agustín Moyano from comment #32) > I agree that the created_on column should be renamed to updated_on, or maybe > we should have both columns, but I believe this should be done in a separate > bug.. we have to analyze the impact of such a change OK Separate bug. Please open it too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 10:05:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 09:05:14 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23260-70-t7MJK51QkT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 10:05:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 09:05:17 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23260-70-yTzyQiq7l1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95698|0 |1 is obsolete| | --- Comment #39 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 95769 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95769&action=edit Bug 23260: Make borrowernumber nullable in items_last_borrower This patch alters table structure to make borrowernumber nullable Sponsored-by: Northeast Kansas Library System Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 10:05:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 09:05:22 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23260-70-gRUJbB9ODr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95699|0 |1 is obsolete| | --- Comment #40 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 95770 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95770&action=edit Bug 23260: Add anonymize items_last_borrower feature This patch adds the feature to anonymize patrons from items_last_borrower table. This code is run from batch_anonymize script, which is triggered from a cron job. To test: 1) apply this patch and the previous one 2) perl installer/data/mysql/updatedatabase.pl 3) set StoreLastBorrower preference to Allow. 4) Create a Check out followed by a Check in. CHECK => a row should appear in items_last_borrower table with the borrower and the item number. 5) In mysql, update created_on date to one day earlier. 6) set AnonymousPatron preference to a valid patron id 7) perl misc/cronjobs/batch_anonymise.pl SUCCESS => borrower number in items_last_borrower changed to AnonymousPatron id 8) repeat steps 4 and 5 9) set AnonymousPatron preference to 0 10) perl misc/cronjobs/batch_anonymise.pl SUCCESS => borrower number in items_last_borrower changed to null 11) prove t/db_dependent/Koha/Patrons.t 12) Sign off Sponsored-by: Northeast Kansas Library System Signed-off-by: Maryse Simard <maryse.simard at inlibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 10:05:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 09:05:28 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23260-70-TOvwAE8B1J@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95700|0 |1 is obsolete| | --- Comment #41 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 95771 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95771&action=edit Bug 23260: (follow-up) optimize anonymise_items_last_borrower Sponsored-by: Northeast Kansas Library System Signed-off-by: Maryse Simard <maryse.simard at inlibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 10:05:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 09:05:33 +0000 Subject: [Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower In-Reply-To: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23260-70-YFLsdvRIot@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95701|0 |1 is obsolete| | --- Comment #42 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 95772 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95772&action=edit Bug 23260: (QA follow-up) Use ->update instead of ->next Also moves initialization of $anonymous_patron closer to associated comment lines. And removes the unneeded changes from Koha::Patrons. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Please see comment34 on use of update method. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 10:14:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 09:14:44 +0000 Subject: [Koha-bugs] [Bug 24024] Holds Awaiting Pickup (Both Active and Expired) Sorts by Firstname In-Reply-To: <bug-24024-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24024-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24024-70-ML70BsVmz9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24024 --- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #7) > halds => holds Hmm Forgot to obsolete the first patch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 10:47:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 09:47:44 +0000 Subject: [Koha-bugs] [Bug 21466] Data inconsistencies - koha fields linked to AV cat values must have a corresponding authorised value In-Reply-To: <bug-21466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21466-70-V4i6PJm1FR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21466 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #80746|0 |1 is obsolete| | --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95773 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95773&action=edit Bug 21466: Search for items.location inconsistencies Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 10:47:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 09:47:47 +0000 Subject: [Koha-bugs] [Bug 21466] Data inconsistencies - koha fields linked to AV cat values must have a corresponding authorised value In-Reply-To: <bug-21466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21466-70-Ql9w7LHCUG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21466 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #86118|0 |1 is obsolete| | --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95774 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95774&action=edit Bug 21466: Catch any values that should be defined in the AV but are not Let's expand the idea of the first patch to catch the wrong values for any others AV. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 10:48:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 09:48:53 +0000 Subject: [Koha-bugs] [Bug 21466] Data inconsistencies - koha fields linked to AV cat values must have a corresponding authorised value In-Reply-To: <bug-21466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21466-70-m7MqL5OLZt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21466 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Works as expected and it a useful addition.. Signing off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 10:55:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 09:55:03 +0000 Subject: [Koha-bugs] [Bug 18355] Permanent location should show with cart location In-Reply-To: <bug-18355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18355-70-jShDjO3EYj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Attachment #79786|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 10:55:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 09:55:12 +0000 Subject: [Koha-bugs] [Bug 18355] Permanent location should show with cart location In-Reply-To: <bug-18355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18355-70-3p50AB1m9U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #83665|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 10:57:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 09:57:25 +0000 Subject: [Koha-bugs] [Bug 18355] Permanent location should show with cart location In-Reply-To: <bug-18355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18355-70-LjQknMkMy7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 11:01:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 10:01:44 +0000 Subject: [Koha-bugs] [Bug 21466] Data inconsistencies - koha fields linked to AV cat values must have a corresponding authorised value In-Reply-To: <bug-21466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21466-70-vkS6ZF8o4W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21466 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |18355 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 [Bug 18355] Permanent location should show with cart location -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 11:01:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 10:01:44 +0000 Subject: [Koha-bugs] [Bug 18355] Permanent location should show with cart location In-Reply-To: <bug-18355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18355-70-rHIFlHLmNF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21466 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21466 [Bug 21466] Data inconsistencies - koha fields linked to AV cat values must have a corresponding authorised value -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 11:01:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 10:01:58 +0000 Subject: [Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove In-Reply-To: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21336-70-UpaeFd45c6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 claire.hernandez at biblibre.com <claire.hernandez at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |claire.hernandez at biblibre.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 11:02:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 10:02:33 +0000 Subject: [Koha-bugs] [Bug 18355] Permanent location should show with cart location In-Reply-To: <bug-18355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18355-70-xAHrwzTUx0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #43 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95775 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95775&action=edit Bug 18355: Display permanent location with cart location Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 11:02:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 10:02:49 +0000 Subject: [Koha-bugs] [Bug 18355] Permanent location should show with cart location In-Reply-To: <bug-18355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18355-70-u60NqWMZjz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #79717|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 11:02:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 10:02:57 +0000 Subject: [Koha-bugs] [Bug 18355] Permanent location should show with cart location In-Reply-To: <bug-18355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18355-70-gJBxPHjJTe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 11:07:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 10:07:22 +0000 Subject: [Koha-bugs] [Bug 20948] Item-level hold info displayed regardless its priority (detail.pl) In-Reply-To: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20948-70-ER02y3nAv2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19288 --- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #17) > Is this similar/related to Bug 19288? Yes, at first glance they refer to the same problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 11:07:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 10:07:22 +0000 Subject: [Koha-bugs] [Bug 19288] Holds placed on a specific item after a next available hold will show varied results In-Reply-To: <bug-19288-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19288-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19288-70-9qhQLfaVyh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19288 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20948 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 11:07:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 10:07:58 +0000 Subject: [Koha-bugs] [Bug 20948] Item-level hold info displayed regardless its priority (detail.pl) In-Reply-To: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20948-70-KFT7qfjn9b@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 --- Comment #19 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Lisette Scheer from comment #16) > (In reply to Christopher Brannon from comment #15) > > I would have suggested removing it altogether, but there are those that want > > to know if there are item level holds on items. Particularly if items are > > lost or missing or damaged. That way they can easily see them and do > > something about the holds. > > This is why I would find the message helpful as well. Are there any > performance issues from having it show? Absolutely not. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 11:29:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 10:29:50 +0000 Subject: [Koha-bugs] [Bug 10352] Cataloguing log search mixing itemnumber/bibnumber In-Reply-To: <bug-10352-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10352-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10352-70-S7osmNA1rQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10352 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 11:29:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 10:29:54 +0000 Subject: [Koha-bugs] [Bug 10352] Cataloguing log search mixing itemnumber/bibnumber In-Reply-To: <bug-10352-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10352-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10352-70-Vcbnjn6X2O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10352 --- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95776 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95776&action=edit Bug 10352: Use a new object_type parameter instead of the module's name To dissociate a search on biblio and item, we pass a new "object_type" parameter to viewlog.pl. If equals 'biblio' we will assume that "object" contains a biblionumber -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 11:31:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 10:31:11 +0000 Subject: [Koha-bugs] [Bug 10352] Cataloguing log search mixing itemnumber/bibnumber In-Reply-To: <bug-10352-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10352-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10352-70-HvF8EWQPV5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10352 --- Comment #14 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Nick Clemens from comment #12) > (In reply to Jonathan Druart from comment #11) > > (In reply to Nick Clemens from comment #10) > > I do not understand what you mean. > > > Sorry, what I meant is that you cannot directly search the catalog logs for > an itemnumber - you must now enter the biblionumber > > - Have an itemnumber that is a biblionumber and one that isn't > - Browse to Tools -> Log viewer > - Enter the itemnumber in the 'Object' field, select 'Catalog' module > - Submit > - If the itemnumber is a biblio you get the mod log for the biblio (which > may not contain your item) > - If the itemnumber is not a biblio you get 'No log found...' > > We fix the links, but not general searching. Possibly a radio button to > choose item/biblionumber if searching catalog? I don't really like that > there is magic happening for a cataloging log search Thanks for the suggestion but I would prefer to avoid adding a new box on the form and play with JS code. I picked the lazy approach, but will fix your concern. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 11:33:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 10:33:41 +0000 Subject: [Koha-bugs] [Bug 22572] Garbled content of MARC control fields in MARC view In-Reply-To: <bug-22572-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22572-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22572-70-5PFCQXMzCH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22572 --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- No, the fix needs to be confirmed, then apply to other places (regarding my last comment). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 11:56:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 10:56:49 +0000 Subject: [Koha-bugs] [Bug 23927] Duplicate a "Complete" order link the "New" one to the invoice In-Reply-To: <bug-23927-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23927-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23927-70-v5l0m8xRY2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23927 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 11:56:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 10:56:52 +0000 Subject: [Koha-bugs] [Bug 23927] Duplicate a "Complete" order link the "New" one to the invoice In-Reply-To: <bug-23927-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23927-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23927-70-jeFu5lMOQx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23927 --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95777 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95777&action=edit Bug 23927: Add tests -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 11:56:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 10:56:55 +0000 Subject: [Koha-bugs] [Bug 23927] Duplicate a "Complete" order link the "New" one to the invoice In-Reply-To: <bug-23927-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23927-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23927-70-kSOGMSuSCd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23927 --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95778 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95778&action=edit Bug 23927: Do not copy invoiceid for a new duplicated order When an order is created from an existing one (duplication), then the invoice should be set to null instead of retrieved. Test plan: - receive an order - in a new basket, add an order "From exisitions orders (copy)" - search your received order - duplicate - go to the bibliographic record "Acquisition details" tab => Without this patch you will see that the invoice is the same for the two orders => With this patch the invoice for the new order is not set -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 11:57:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 10:57:09 +0000 Subject: [Koha-bugs] [Bug 23927] Duplicate a "Complete" order link the "New" one to the invoice In-Reply-To: <bug-23927-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23927-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23927-70-B88UtFOiLo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23927 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 12:16:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 11:16:00 +0000 Subject: [Koha-bugs] [Bug 20116] Cache language list In-Reply-To: <bug-20116-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20116-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20116-70-TuheHH9CM3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #49 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Hi Katrin, My bet is that you tested without the correct koha-translate file. Are you sure you copied the one patched with this change? You can use reset_all to make sure it will be copied. Tested right now and it works as expected. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 12:18:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 11:18:48 +0000 Subject: [Koha-bugs] [Bug 24100] "Pay selected" is broken In-Reply-To: <bug-24100-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24100-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24100-70-pqHjo4W7jQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24100 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Not sure how `koha::account::lines` crept it.. when I QA'd the relevant bug it was `Koha::Account::Lines`.. perhaps a subsequent rebase.. Just testing a fix now. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 12:20:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 11:20:56 +0000 Subject: [Koha-bugs] [Bug 20116] Cache language list In-Reply-To: <bug-20116-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20116-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20116-70-LouJQ0KmHV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 --- Comment #50 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- That's correct, I didn't copy the file. From where to where do you have to copy it? A test plan would be helpful. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 12:25:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 11:25:27 +0000 Subject: [Koha-bugs] [Bug 24100] "Pay selected" is broken In-Reply-To: <bug-24100-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24100-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24100-70-hm0wF7Y9WR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24100 --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95779 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95779&action=edit Bug 24100: (bug 23788 follow-up) Capitalization correction Correct the capitalization of the class name introduced in bug 23788. Test plan: 1) Prior to patch attempt to 'pay off selected' - Note a server error 2) Apply patch 3) Attempt to 'pay off selected' - Note it now works as expected. 4) Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 12:25:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 11:25:45 +0000 Subject: [Koha-bugs] [Bug 24100] "Pay selected" is broken In-Reply-To: <bug-24100-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24100-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24100-70-tL5WGETQLk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24100 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 12:25:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 11:25:49 +0000 Subject: [Koha-bugs] [Bug 24100] "Pay selected" is broken In-Reply-To: <bug-24100-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24100-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24100-70-5pHdSHMxPZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24100 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 12:33:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 11:33:26 +0000 Subject: [Koha-bugs] [Bug 23964] An item level hold when placed is set to Waiting, if ReservesNeedReturn is set to Automatic In-Reply-To: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23964-70-ckH5Skgvvm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23964 --- Comment #29 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95780 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95780&action=edit Bug 23964: (follow-up) We should check for only active holds when determining to set waiting -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 12:33:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 11:33:39 +0000 Subject: [Koha-bugs] [Bug 23964] An item level hold when placed is set to Waiting, if ReservesNeedReturn is set to Automatic In-Reply-To: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23964-70-Cmo7u7SDYF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23964 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |additional_work_needed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 12:40:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 11:40:57 +0000 Subject: [Koha-bugs] [Bug 23964] An item level hold when placed is set to Waiting, if ReservesNeedReturn is set to Automatic In-Reply-To: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23964-70-e8ESsbH7uD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23964 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95780|0 |1 is obsolete| | --- Comment #30 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95781 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95781&action=edit Bug 23964: (follow-up) We should check for only active holds when determining to set waiting Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 13:01:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 12:01:11 +0000 Subject: [Koha-bugs] [Bug 10758] Show bibliographic information of deleted records in acquisitions In-Reply-To: <bug-10758-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10758-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10758-70-HHGOBAQTJ9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10758 --- Comment #65 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95782 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95782&action=edit Bug 10758: WIP Started working on this but then realised we do not have Koha::Old::Biblios classes. It is getting complicated and will put a spoke in bug 20271's wheel -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 13:10:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 12:10:42 +0000 Subject: [Koha-bugs] [Bug 20116] Cache language list In-Reply-To: <bug-20116-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20116-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20116-70-vwWsfEgH0Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20116 --- Comment #51 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Katrin Fischer from comment #50) > That's correct, I didn't copy the file. From where to where do you have to > copy it? A test plan would be helpful. Koha scripts are in /usr/sbin/koha-translate (`which koha-translate` tell you where it is). A test plan could be: 0/ Apply the patch and `reset_all` 1/ Install languages, enable them at staff and OPAC 2/ Confirm you have the languages listed at the bottom 3/ Uninstall one language 4/ Confirm that it does not longer appear in the language at the bottom of the pages and in the prefs Also play with koha-translate --install, --remove and --list Additionally, QA will make sure that the changes make sense. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 13:17:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 12:17:02 +0000 Subject: [Koha-bugs] [Bug 24001] Cannot edit card template In-Reply-To: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24001-70-0gKumT8PPW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Chris Nighswonger from comment #16) > Just to be clear: I think we are encountering different issues in the > description and comment #1. Yes of course, it is what I said in comment #1. If you have the strict_sql_modes turned on it explodes on creating the template. (In reply to Chris Nighswonger from comment #15) > (In reply to Jonathan Druart from comment #14) > > It has a printers_profile.profile_id = 22, but I think here we are talking > > about creator_templates.profile_id > > > > MySQL [koha_kohadev]> select template_id, profile_id from creator_templates; > > The error occurs on attempting to execute the following on your system in > the script: > > SELECT * FROM printers_profile WHERE profile_id = 22 AND creator = > 'Patroncards'; > > What does that say in the client? 0. I am using the fresh install, with all the sample data. 1. Turning off strict_sql_modes 2. Go to Home › Tools › Patron card creator › Templates 3. New > Card template 4. Save 5. Edit 6. Save Can't bless non-reference value at /kohadevbox/koha/C4/Creators/Profile.pm line 89 C4::Creators::Profile::retrieve('C4::Patroncards::Profile', 'profile_id', 22, 'creator', 'Patroncards') called at /kohadevbox/koha/C4/Patroncards/Profile.pm line 29 C4::Patroncards::Profile::retrieve('profile_id', 22, 'creator', 'Patroncards') called at /kohadevbox/koha/patroncards/edit-template.pl line 78 eval {...} at /kohadevbox/koha/patroncards/edit-template.pl line 2 MariaDB [koha_kohadev]> SELECT * FROM printers_profile WHERE profile_id = 22 AND creator = 'Patroncards'; Empty set (0.00 sec) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 13:17:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 12:17:53 +0000 Subject: [Koha-bugs] [Bug 10352] Cataloguing log search mixing itemnumber/bibnumber In-Reply-To: <bug-10352-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10352-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10352-70-RefhrEGOc0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10352 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91466|0 |1 is obsolete| | Attachment #95776|0 |1 is obsolete| | --- Comment #15 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95783 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95783&action=edit Bug 10352: Display the correct modification logs for bibliographic records The 'Modification log" link in the cataloguing module returns confusing results. The 'object' parameter is the biblionumber, but the all log from itemnumber=biblionumber will be displayed as well. Since bug 11473 we have the action_logs.info column that is prefixed by 'item ' or 'biblio ' to disociated an item modification from a biblio modif. This patch suggests a quick and dirty approach, use this column to make sure we are searching for the correct logs. /!\ As bug 11473 did not update the existing rows, we will no longer display the logs created prior to this change. Test plan: Make sure you have at least 2 bibliographic records with some items Make sure you have the biblionumbers of those records that match existing itemnumbers Edit them (no matter what you change) Go to the bibliographic detail page (staff) and click "Modification log" You should see the correct changes. Signed-off-by: hc <hc at interleaf.ie> Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 13:17:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 12:17:56 +0000 Subject: [Koha-bugs] [Bug 10352] Cataloguing log search mixing itemnumber/bibnumber In-Reply-To: <bug-10352-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10352-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10352-70-D1ivzpnKSy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10352 --- Comment #16 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95784 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95784&action=edit Bug 10352: Use a new object_type parameter instead of the module's name To dissociate a search on biblio and item, we pass a new "object_type" parameter to viewlog.pl. If equals 'biblio' we will assume that "object" contains a biblionumber Signed-off-by: Nick Clemens <nick at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 13:18:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 12:18:00 +0000 Subject: [Koha-bugs] [Bug 10352] Cataloguing log search mixing itemnumber/bibnumber In-Reply-To: <bug-10352-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10352-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10352-70-HCEvdhKiAG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10352 --- Comment #17 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95785 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95785&action=edit Bug 10352: (follow-up) show the biblionumber for items in modification logs This patch adds a link to the the biblio that shows the biblionumber of the item. It makes things a little more obvious To test: 1 - Find a biblio with an item where an itemnumber on another biblio is equal to that biblionumber i.e. In the sample data: biblionumber 59 with item with itemnumber 127 item with itemnumber 59 on biblionumber 23 2 - Edit both items however you wish 3 - On biblionumber 59 click the modification log 4 - You should see "Item 127" 5 - Click "Submit" on the form - this searches as itemnumber 6 - You should see "Item 59" 7 - Apply patch 8 - On biblionumber 59 click the modification log 9 - You should see "Item 127 from Biblio 59" 10 - Click "Submit" on the form - this searches as itemnumber 11 - You should see "Item 59 from Biblio 23" -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 13:18:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 12:18:23 +0000 Subject: [Koha-bugs] [Bug 23970] itemsearch: when combining two fields with the boolean operator OR, the entry of the second field is not taken into account In-Reply-To: <bug-23970-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23970-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23970-70-G5AaiVMNvj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23970 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |major CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 13:19:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 12:19:09 +0000 Subject: [Koha-bugs] [Bug 24001] Cannot edit card template In-Reply-To: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24001-70-UGDwQxfmXh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- On "Edit" I am on /patroncards/edit-template.pl?op=edit&element_id=24 https://snipboard.io/Qhk87I.jpg "Library Laser/Tray 3" has a profile_id=22 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 13:21:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 12:21:04 +0000 Subject: [Koha-bugs] [Bug 19288] Holds placed on a specific item after a next available hold will show varied results In-Reply-To: <bug-19288-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19288-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19288-70-Y1RwoMz28Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19288 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 13:23:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 12:23:11 +0000 Subject: [Koha-bugs] [Bug 7826] Standardize link for triggering plugins and auto-entry In-Reply-To: <bug-7826-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7826-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7826-70-9NS8e9VG0r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7826 --- Comment #4 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- We just got a complaint about the ... being easy to miss and hard to click - I'd love if we could change them to a nice FA icon. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 13:23:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 12:23:57 +0000 Subject: [Koha-bugs] [Bug 10352] Cataloguing log search mixing itemnumber/bibnumber In-Reply-To: <bug-10352-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10352-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10352-70-ZiArXxXzJP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10352 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 13:24:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 12:24:01 +0000 Subject: [Koha-bugs] [Bug 10352] Cataloguing log search mixing itemnumber/bibnumber In-Reply-To: <bug-10352-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10352-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10352-70-nbhkySkVMj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10352 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95785|0 |1 is obsolete| | --- Comment #18 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95786 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95786&action=edit Bug 10352: (follow-up) show the biblionumber for items in modification logs This patch adds a link to the the biblio that shows the biblionumber of the item. It makes things a little more obvious To test: 1 - Find a biblio with an item where an itemnumber on another biblio is equal to that biblionumber i.e. In the sample data: biblionumber 59 with item with itemnumber 127 item with itemnumber 59 on biblionumber 23 2 - Edit both items however you wish 3 - On biblionumber 59 click the modification log 4 - You should see "Item 127" 5 - Click "Submit" on the form - this searches as itemnumber 6 - You should see "Item 59" 7 - Apply patch 8 - On biblionumber 59 click the modification log 9 - You should see "Item 127 from Biblio 59" 10 - Click "Submit" on the form - this searches as itemnumber 11 - You should see "Item 59 from Biblio 23" Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 13:30:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 12:30:14 +0000 Subject: [Koha-bugs] [Bug 20813] Revamp user permissions system In-Reply-To: <bug-20813-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20813-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20813-70-l1909XA1Wf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20813 Lari Taskula <lari.taskula at hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14540 CC| |lari.taskula at hypernova.fi -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 13:30:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 12:30:14 +0000 Subject: [Koha-bugs] [Bug 14540] Move member-flags.pl to PermissionsManager to better manage permissions for testing. In-Reply-To: <bug-14540-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14540-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14540-70-gS9xcPgLHr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14540 Lari Taskula <lari.taskula at hypernova.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20813 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 13:36:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 12:36:11 +0000 Subject: [Koha-bugs] [Bug 24102] New: Item search: Remove leading/trailing whitespace for barcode search Message-ID: <bug-24102-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24102 Bug ID: 24102 Summary: Item search: Remove leading/trailing whitespace for barcode search Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Item search: While for some other searches it makes sense to search for whitespace, whitespace entered in the barocde search is ususally accidental. It would be nice to remove whitespace from the search term, when the barcode search option was selected. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 13:38:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 12:38:50 +0000 Subject: [Koha-bugs] [Bug 23970] itemsearch: when combining two fields with the boolean operator OR, the entry of the second field is not taken into account In-Reply-To: <bug-23970-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23970-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23970-70-u4mqwNMLgb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23970 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 13:38:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 12:38:54 +0000 Subject: [Koha-bugs] [Bug 23970] itemsearch: when combining two fields with the boolean operator OR, the entry of the second field is not taken into account In-Reply-To: <bug-23970-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23970-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23970-70-jd0XEb6lcI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23970 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95787 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95787&action=edit Bug 23970: Search by "publication date" only works if used in first field The changes made in the following commit: commit 0d2e83bca5b91376e9262b6cb0b993f09b919018 Bug 14636: Item search - fix search and sort by publication date for MARC21 was put at the wrong place. It was inside a "if $i == 1" test that impacts the first field only. Test plan: 0/ Use a MARC21 installation 1/ Search items by publication date, use twice the field using different values. For instance: publication date: 2005 OR publication date: 2006 => Without this patch you only get results for 2005 => With this patch applied you get results for both years. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 13:39:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 12:39:41 +0000 Subject: [Koha-bugs] [Bug 23970] itemsearch - publication date not taken into account if not used in the first field In-Reply-To: <bug-23970-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23970-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23970-70-WKxjRiv5Hw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23970 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.11 |master CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org Severity|major |normal Summary|itemsearch: when combining |itemsearch - publication |two fields with the boolean |date not taken into account |operator OR, the entry of |if not used in the first |the second field is not |field |taken into account | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 13:40:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 12:40:23 +0000 Subject: [Koha-bugs] [Bug 23970] itemsearch - publication date not taken into account if not used in the first field In-Reply-To: <bug-23970-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23970-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23970-70-al76rUVEqw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23970 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14636 Severity|normal |major Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 [Bug 14636] Sorting and searching by publication year in item search doesn't work correctly -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 13:40:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 12:40:23 +0000 Subject: [Koha-bugs] [Bug 14636] Sorting and searching by publication year in item search doesn't work correctly In-Reply-To: <bug-14636-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14636-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14636-70-FEo7fLCpz2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14636 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23970 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23970 [Bug 23970] itemsearch - publication date not taken into account if not used in the first field -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 13:56:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 12:56:06 +0000 Subject: [Koha-bugs] [Bug 17831] Remove non-existing bibliosubject.subject mapping from frameworks In-Reply-To: <bug-17831-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17831-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17831-70-2ASekI318Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17831 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #58769|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 14:45:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 13:45:47 +0000 Subject: [Koha-bugs] [Bug 14680] when doing acquisitions from a staged file, MarcFieldsToOrder-syspref discounts are instead added. In-Reply-To: <bug-14680-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14680-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14680-70-rV9wdO0akh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14680 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #6 from Nick Clemens <nick at bywatersolutions.com> --- This is still valid, but I don't know if these code changes are the ones we need You can recreate this without MarcItemFieldsToOrder in fact. 1 - Stage a file 2 - Add to basket form a staged file 3 - For any of the titles check the box to add 4 - In the details set a price, replacement price, and discount 5 - Add the order 6 - ecost is set to price and rrp is the ecost plus dicsount 7 - Repeat but don't set a discount this time (and ensure bookseller has a discount set) 8 - rrp is set to price, ecost is the rrp minus the discount Why? It is from bug 7180, so ha been in place since 2014 There is much conversation on the bug, ending with: "(In reply to mathieu saby from comment #96) > To be clear : my main concern is the fact that Koha calculates a RRP price > > 20 EUR from a record with "20.00 EUR" in 010$d field. Forget the rrp value, it is not used by this patch." RRP is not really used for anything, it just says the price the vendor set, but we do have strange behaviour of sometimes the price field being the 'rrp' and sometimes being the 'ecost' I think ideally we should use the same display as when adding an order manually, so the user can choose the fields to enter, and we discount the rrp to generate ecost unless they specify. Adding some CC's here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 14:52:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 13:52:32 +0000 Subject: [Koha-bugs] [Bug 24001] Cannot edit card template In-Reply-To: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24001-70-hDw16GS9MC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #19 from Chris Nighswonger <cnighswonger at foundations.edu> --- (In reply to Jonathan Druart from comment #17) > (In reply to Chris Nighswonger from comment #16) > > Just to be clear: I think we are encountering different issues in the > > description and comment #1. > > Yes of course, it is what I said in comment #1. > > If you have the strict_sql_modes turned on it explodes on creating the > template. > Let's open a separate bug for the second issue you mention. The strict sql issue. > > (In reply to Chris Nighswonger from comment #15) > > (In reply to Jonathan Druart from comment #14) > > > It has a printers_profile.profile_id = 22, but I think here we are talking > > > about creator_templates.profile_id > > > > > > MySQL [koha_kohadev]> select template_id, profile_id from creator_templates; > > > > The error occurs on attempting to execute the following on your system in > > the script: > > > > SELECT * FROM printers_profile WHERE profile_id = 22 AND creator = > > 'Patroncards'; > > > > What does that say in the client? > > 0. I am using the fresh install, with all the sample data. > 1. Turning off strict_sql_modes > 2. Go to Home › Tools › Patron card creator › Templates > 3. New > Card template > 4. Save > 5. Edit > 6. Save > > Can't bless non-reference value at /kohadevbox/koha/C4/Creators/Profile.pm > line 89 > > C4::Creators::Profile::retrieve('C4::Patroncards::Profile', > 'profile_id', 22, 'creator', 'Patroncards') called at > /kohadevbox/koha/C4/Patroncards/Profile.pm line 29 > > C4::Patroncards::Profile::retrieve('profile_id', 22, 'creator', > 'Patroncards') called at /kohadevbox/koha/patroncards/edit-template.pl line > 78 > eval {...} at /kohadevbox/koha/patroncards/edit-template.pl line 2 > > > MariaDB [koha_kohadev]> SELECT * FROM printers_profile WHERE profile_id = 22 > AND creator = 'Patroncards'; > Empty set (0.00 sec) Forgive me as I do not have a test installation setup nor the time to get one up and running: What does 'SELECT template_id, profile_id, template_desc, creator FROM creator_templates;' say? I think I know what is causing this. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 14:55:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 13:55:40 +0000 Subject: [Koha-bugs] [Bug 24100] "Pay selected" is broken In-Reply-To: <bug-24100-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24100-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24100-70-78jIRhkKbe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24100 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23788 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23788 [Bug 23788] Writing off multiple fees allows 'overpayment' of those fees -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 14:55:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 13:55:40 +0000 Subject: [Koha-bugs] [Bug 23788] Writing off multiple fees allows 'overpayment' of those fees In-Reply-To: <bug-23788-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23788-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23788-70-4z5BOZZZW9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23788 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24100 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24100 [Bug 24100] "Pay selected" is broken -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 15:09:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 14:09:42 +0000 Subject: [Koha-bugs] [Bug 24100] "Pay selected" is broken In-Reply-To: <bug-24100-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24100-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24100-70-zqTLPI63jD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24100 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 15:09:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 14:09:45 +0000 Subject: [Koha-bugs] [Bug 24100] "Pay selected" is broken In-Reply-To: <bug-24100-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24100-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24100-70-5nl6rX2O28@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24100 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95779|0 |1 is obsolete| | --- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 95788 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95788&action=edit Bug 24100: (bug 23788 follow-up) Capitalization correction Correct the capitalization of the class name introduced in bug 23788. Test plan: 1) Prior to patch attempt to 'pay off selected' - Note a server error 2) Apply patch 3) Attempt to 'pay off selected' - Note it now works as expected. 4) Signoff Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 15:10:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 14:10:18 +0000 Subject: [Koha-bugs] [Bug 5145] Show call number for available item in XSLT availability information In-Reply-To: <bug-5145-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-5145-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5145-70-75vo9WdrfJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5145 --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- This also applies to the list view it seems. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 15:10:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 14:10:44 +0000 Subject: [Koha-bugs] [Bug 24100] "Pay selected" is broken In-Reply-To: <bug-24100-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24100-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24100-70-30lbdCqY2e@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24100 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Status|Signed Off |Passed QA --- Comment #4 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Trivial typo fix, skipping QA step. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 15:17:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 14:17:32 +0000 Subject: [Koha-bugs] [Bug 23452] Multiple select options in system preferences are not translatable In-Reply-To: <bug-23452-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23452-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23452-70-ucDhikmXNS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23452 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 15:17:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 14:17:35 +0000 Subject: [Koha-bugs] [Bug 23452] Multiple select options in system preferences are not translatable In-Reply-To: <bug-23452-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23452-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23452-70-Z8dVkUDNf4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23452 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95765|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95789 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95789&action=edit Bug 23452: Multiple select options in system preferences are not translatable Translate script ignores multiple options in system preferences, this patch fix that. To test: 1) Apply the patch 2) Go to misc/translator cd misc/translator 3) Update your preferred language perl translate update xx-YY 4) Updated pref file must contain new strings, eg. egrep "when cataloguing an item" po/xx-YY-pref.po 5) Edit & translate that string 6) Install the updated translation perl translate install xx-YY 7) Check that the translated pref file has a) multiple options present b) the message from 5) is translated see for example circulation.pref en: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref xx: koha-tmpl/intranet-tmpl/prog/xx-YY/modules/admin/preferences/circulation.pref Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 15:18:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 14:18:23 +0000 Subject: [Koha-bugs] [Bug 23452] Multiple select options in system preferences are not translatable In-Reply-To: <bug-23452-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23452-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23452-70-ARfX604soU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23452 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95789|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95790 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95790&action=edit Bug 23452: Multiple select options in system preferences are not translatable Translate script ignores multiple options in system preferences, this patch fix that. To test: 1) Apply the patch 2) Go to misc/translator cd misc/translator 3) Update your preferred language perl translate update xx-YY 4) Updated pref file must contain new strings, eg. egrep "when cataloguing an item" po/xx-YY-pref.po 5) Edit & translate that string 6) Install the updated translation perl translate install xx-YY 7) Check that the translated pref file has a) multiple options present b) the message from 5) is translated see for example circulation.pref en: koha-tmpl/intranet-tmpl/prog/en/modules/admin/preferences/circulation.pref xx: koha-tmpl/intranet-tmpl/prog/xx-YY/modules/admin/preferences/circulation.pref Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 15:22:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 14:22:09 +0000 Subject: [Koha-bugs] [Bug 24001] Cannot edit card template In-Reply-To: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24001-70-u2gqqIfKWj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- MariaDB [koha_kohadev]> SELECT template_id, profile_id, template_desc, creator FROM creator_templates; +-------------+------------+------------------------------------------------------------+-------------+ | template_id | profile_id | template_desc | creator | +-------------+------------+------------------------------------------------------------+-------------+ | 1 | 1 | 3 columns, 10 rows of labels | Labels | | 7 | 13 | 1" X 1.5" Spine Label | Setup for up to four lines of text | Labels | | 12 | 14 | 1" X 1.5" Spine Label | Setup for five lines of text | Labels | | 22 | 0 | Default description | Labels | | 23 | 16 | A template for home brewed patron card forms | Patroncards | | 24 | 0 | Default description | Patroncards | +-------------+------------+------------------------------------------------------------+-------------+ 6 rows in set (0.00 sec) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 15:22:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 14:22:49 +0000 Subject: [Koha-bugs] [Bug 22252] Status messages returned by Mana are not translatable In-Reply-To: <bug-22252-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22252-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22252-70-n4bnxGvPPf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22252 Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |caroline.cyr-la-rose at inlibr | |o.com --- Comment #2 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- I don't think it's a duplicate, but a related bug Bug 24096 - Mana KB "Shared successfully" untranslatable -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 15:23:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 14:23:26 +0000 Subject: [Koha-bugs] [Bug 24096] Mana KB "Shared successfully" untranslatable In-Reply-To: <bug-24096-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24096-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24096-70-JzqNM46Q18@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24096 --- Comment #3 from Caroline Cyr La Rose <caroline.cyr-la-rose at inlibro.com> --- See also Bug 22252 - Status messages returned by Mana are not translatable -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 15:26:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 14:26:02 +0000 Subject: [Koha-bugs] [Bug 14741] Selecting all child permissions doesn't select the top level check box In-Reply-To: <bug-14741-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14741-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14741-70-awCP8hQeyu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14741 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 15:26:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 14:26:05 +0000 Subject: [Koha-bugs] [Bug 14741] Selecting all child permissions doesn't select the top level check box In-Reply-To: <bug-14741-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14741-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14741-70-ABIJjhPJJd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14741 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95751|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95791 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95791&action=edit Bug 14741: Selecting all child permissions doesn't select the top level check box This patch modifies the patron flags page so that manually selecting all the child permissions also checks the checkbox for the parent permission. To test, apply the patch, open a patron record, select More -> Set permissions. - Expand a set of permissions, for instance "Add, modify, and view patron information." - If any boxes are checked, uncheck them. - Check each of the "child" checkboxes ("Add, modify, and view..." and "View patron infos..." ). - When both checkboxes are checked, the "Add, modify, and view" parent permission should be automatically checked. Signed-off-by: Maryse Simard <maryse.simard at inlibro.com> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 15:29:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 14:29:43 +0000 Subject: [Koha-bugs] [Bug 24001] Cannot edit card template In-Reply-To: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24001-70-G3Zyt66SdX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #21 from Chris Nighswonger <cnighswonger at foundations.edu> --- What language sample data are you using on this test set? Side note: The sample data for labels/patroncards among various languages appears to vary tremendously and probably erroneously. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 15:30:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 14:30:32 +0000 Subject: [Koha-bugs] [Bug 15142] Titles facet does not work in UNIMARC In-Reply-To: <bug-15142-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15142-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15142-70-GjOcPHGsKo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15142 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Should not it be removed from xsl and xml files in etc/zebradb/marc_defs/unimarc/biblios? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 15:39:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 14:39:07 +0000 Subject: [Koha-bugs] [Bug 24046] 'Activate filters' untranslatable In-Reply-To: <bug-24046-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24046-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24046-70-drMqNCCLBx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24046 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Hi Maryse, I do not think we should have a new include file in str/ I would suggest to have those strings defined in datatables.inc instead, as they are related to dataTable -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 15:41:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 14:41:45 +0000 Subject: [Koha-bugs] [Bug 24001] Cannot edit card template In-Reply-To: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24001-70-fttQeorXXI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #22 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Chris Nighswonger from comment #21) > What language sample data are you using on this test set? > > Side note: The sample data for labels/patroncards among various languages > appears to vary tremendously and probably erroneously. I am using a 'classic' install, 'en'. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 15:49:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 14:49:14 +0000 Subject: [Koha-bugs] [Bug 3150] Move emails for sending cart and list contents into notices tool In-Reply-To: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-3150-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3150-70-uMQ0R4wUMh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3150 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Change sponsored?|--- |Sponsored CC| |tomascohen at gmail.com Assignee|gmcharlt at gmail.com |agustinmoyano at theke.io -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 15:57:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 14:57:50 +0000 Subject: [Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and should only work for for SIP-based checkouts In-Reply-To: <bug-23233-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23233-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23233-70-Ze0xWQkFGj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #24 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I do not understand the following change: +++ b/Koha/Item.pm @@ -382,7 +382,7 @@ This method checks the tmp_holdsqueue to see if this item has been selected for sub has_pending_hold { my ( $self ) = @_; my $pending_hold = $self->_result->tmp_holdsqueues; - return !C4::Context->preference('AllowItemsOnHoldCheckout') && $pending_hold->count ? 1: 0; + return $pending_hold->count ? 1: 0; } I also do not understand what it meant originally. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 16:02:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 15:02:14 +0000 Subject: [Koha-bugs] [Bug 24103] New: Add option to dump built search query to templates Message-ID: <bug-24103-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 Bug ID: 24103 Summary: Add option to dump built search query to templates Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org It would be nice to be able to see what is actually being searched in the search engine when performing a query -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 16:05:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 15:05:23 +0000 Subject: [Koha-bugs] [Bug 21520] More complex OAI sets mappings In-Reply-To: <bug-21520-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21520-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21520-70-fOpvtpCq1s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21520 Matthias Meusburger <matthias.meusburger at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |matthias.meusburger at biblibr | |e.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 16:08:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 15:08:57 +0000 Subject: [Koha-bugs] [Bug 24103] Add option to dump built search query to templates In-Reply-To: <bug-24103-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24103-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24103-70-qSUdcRJN8o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 16:09:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 15:09:00 +0000 Subject: [Koha-bugs] [Bug 24103] Add option to dump built search query to templates In-Reply-To: <bug-24103-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24103-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24103-70-9HdnyKpTCE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95792 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95792&action=edit Bug 24103: Add option to dump search query to templates To test: 1 - Apply patch, update database 2 - Note new syspref 'DumpSearchQueryTemplate' 3 - Leave it off 4 - Enable DumpTemplateVariablesOpac and Staff 5 - Search on staff and opac 6 - View the source 7 - Search for 'search_query' - you shouldn't find it 8 - Enable the new pref 9 - Repeat, but you should find the query 10 - Test staff/opac search and advanced search, cataloguing search, authority search, authfinder search, adding to a basket form a new biblio 11 - All should work and show the query 12 - This will work under both ES and Zebra -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 16:10:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 15:10:13 +0000 Subject: [Koha-bugs] [Bug 24103] Add option to dump built search query to templates In-Reply-To: <bug-24103-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24103-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24103-70-njagAJUyCj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |ere.maijala at helsinki.fi, | |jonathan.druart at bugs.koha-c | |ommunity.org, | |kyle at bywatersolutions.com, | |martin.renvoize at ptfs-europe | |.com Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 16:18:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 15:18:53 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24080-70-jc9Wow54oJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95669|0 |1 is obsolete| | --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95793 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95793&action=edit Bug 24080: Payout account debit type -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 16:18:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 15:18:56 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24080-70-Qz31CbSehW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95670|0 |1 is obsolete| | --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95794 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95794&action=edit Bug 24080: Add 'payout' method to Koha::Account::Line This enhancement adds a 'payout' method to Koha::Account::Line which can be used to 'pay out' a credit to a patron. When such a credit is 'paid out' this method will create a corresponding account debit line with an amount equal to the amountoutstanding on the original credit and the two acocuntlines will be immediately applied against each other. Test Plan: 1) Run the included tests and verify they pass. 2) Signoff -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 16:18:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 15:18:59 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24080-70-moaKlYtr04@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95671|0 |1 is obsolete| | --- Comment #12 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95795 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95795&action=edit Bug 24080: Add updatecharge payout permission Add a new subpermission called 'payout' to the 'updatecharges' permission group which will allow/prevent payout actions to be performed by staff. -- You are receiving this mail because: You are watching all bug changes. You are on the CC list for the bug. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 16:19:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 15:19:02 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24080-70-u6cfierwCl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95672|0 |1 is obsolete| | --- Comment #13 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95796 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95796&action=edit Bug 24080: Add payout option to patron account page This enhancement adds a refined workflow to allow librarians to pay out money to patrons and record these payouts on the patrons account. The use case is that a patron has somehow accrued credit, through a refund perhaps, and the library wants to be able to physically hand over some money to balance the patrons account. Test plan: 1) Undertake a series of transactions that result in some outstanding credit on a patrons account. 2) Note that a new 'Issue payout' button appears next to a credit with an outstanding balance (but only if your user has the payout permission or is a superlibrarian) 3) Click the 'Issue payout' button and a modal should appear pre-populated with the amountoutstanding. 4) You should be able to edit the amount you wish to payout, make payment or cancel. 5) Signoff -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 16:19:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 15:19:51 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24080-70-RvVh9HNa4U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 --- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Oops, seems I managed to miss committing the tests.. I've corrected that now.. thanks for bringing it to my attention. -- You are receiving this mail because: You are the assignee for the bug. You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 16:21:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 15:21:50 +0000 Subject: [Koha-bugs] [Bug 24080] Add a 'payout' process to accounts In-Reply-To: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24080-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24080-70-f0gjdSSduj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24080 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 16:22:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 15:22:38 +0000 Subject: [Koha-bugs] [Bug 23905] Button "Search to add" doesn't work on Quick add new patron In-Reply-To: <bug-23905-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23905-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23905-70-AwTdwCp1Hi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |23778 CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I think it has been caused by commit bc9871f428af323901ebe57a6d0888f1dcf871cf Bug 23778: Regression: Guarantor entry section no longer has a unique id Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23778 [Bug 23778] Regression: Guarantor entry section no longer has a unique id -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 16:22:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 15:22:38 +0000 Subject: [Koha-bugs] [Bug 23778] Regression: Guarantor entry section no longer has a unique id In-Reply-To: <bug-23778-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23778-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23778-70-1cPQ8aKgE0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23778 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23905 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 [Bug 23905] Button "Search to add" doesn't work on Quick add new patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 16:29:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 15:29:27 +0000 Subject: [Koha-bugs] [Bug 23905] Button "Search to add" doesn't work on Quick add new patron In-Reply-To: <bug-23905-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23905-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23905-70-SFsfhKnEFc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14570 --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- But I think it's also broken since bug 14570. This must be fixed for 19.11. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 [Bug 14570] Make it possible to add multiple guarantors to a record -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 16:29:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 15:29:27 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: <bug-14570-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14570-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14570-70-oI8pCcpA4h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23905 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 [Bug 23905] Button "Search to add" doesn't work on Quick add new patron -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 16:29:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 15:29:37 +0000 Subject: [Koha-bugs] [Bug 23905] Button "Search to add" doesn't work on Quick add new patron In-Reply-To: <bug-23905-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23905-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23905-70-hMgFePd6WU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_19_11_candidate -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 16:47:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 15:47:26 +0000 Subject: [Koha-bugs] [Bug 24104] New: Item search - dropdown buttons overflow Message-ID: <bug-24104-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24104 Bug ID: 24104 Summary: Item search - dropdown buttons overflow Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Templates Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org The "Edit" dropdown buttons of the item results create an overflow when clicked. The 2 options "Edit record" and "Edit items" contained in a dropdown menu will be displayed out of screen and the horizontal scrolbar will be shown. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 16:48:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 15:48:09 +0000 Subject: [Koha-bugs] [Bug 24104] Item search - dropdown buttons overflow In-Reply-To: <bug-24104-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24104-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24104-70-JELPM4k7Zl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24104 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- https://snipboard.io/ekSxZr.jpg -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 16:49:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 15:49:31 +0000 Subject: [Koha-bugs] [Bug 24104] Item search - dropdown buttons overflow In-Reply-To: <bug-24104-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24104-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24104-70-B2dz98wngO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24104 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 16:49:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 15:49:34 +0000 Subject: [Koha-bugs] [Bug 24104] Item search - dropdown buttons overflow In-Reply-To: <bug-24104-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24104-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24104-70-derd1QtuGA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24104 --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95797 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95797&action=edit Bug 24104: Item search - Prevent "Edit" dropdown button to overflow Making it displays on the left fixes the problem. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 17:02:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 16:02:11 +0000 Subject: [Koha-bugs] [Bug 22923] Items search does not take care of independent branches In-Reply-To: <bug-22923-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22923-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22923-70-QA3sps1kzE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22923 --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I do not understand. It seems that nothing block the edition, even with IndependentBranches turned on. The bug report should not focus on the item search but to fix globally the issue, if it is what you meant. If so, can you detail the condition of the edition please? * Superlibrarian can edit everything * librarian with editcatalogue can edit a biblio * librarian with editcatalogue and from the same library as holdingbranch or homebranch can edit an item We should then adjust all the links to item editing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 17:28:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 16:28:25 +0000 Subject: [Koha-bugs] [Bug 24105] New: Longoverdue gives error message when --itemtypes are specified Message-ID: <bug-24105-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24105 Bug ID: 24105 Summary: Longoverdue gives error message when --itemtypes are specified Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: wizzyrea at gmail.com QA Contact: testopia at bugs.koha-community.org CC: robin at catalyst.net.nz I hang my head in shame, my follow up on bug 20436 broke the implementation for longoverdue limiting by item types. Basically, Kyle had it right the first time, and the QA concern, which I "fixed," broke the feature. So! I shall "put that thing back where it came from, so help me." -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 17:37:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 16:37:51 +0000 Subject: [Koha-bugs] [Bug 19482] Elasticsearch - prevent removal / editing of required indexes In-Reply-To: <bug-19482-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19482-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19482-70-BiTZpL92CM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19482 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 17:38:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 16:38:38 +0000 Subject: [Koha-bugs] [Bug 23964] An item level hold when placed is set to Waiting, if ReservesNeedReturn is set to Automatic In-Reply-To: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23964-70-IVtdJFsNKB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23964 --- Comment #31 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 17:38:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 16:38:58 +0000 Subject: [Koha-bugs] [Bug 23964] An item level hold when placed is set to Waiting, if ReservesNeedReturn is set to Automatic In-Reply-To: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23964-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23964-70-EH5XQt5JXY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23964 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|additional_work_needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 17:51:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 16:51:00 +0000 Subject: [Koha-bugs] [Bug 23905] Button "Search to add" doesn't work on Quick add new patron In-Reply-To: <bug-23905-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23905-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23905-70-pfuODYXSbt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 --- Comment #4 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 95798 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95798&action=edit Bug 23905: Button "Search to add" doesn't work on Quick add new patron -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 17:53:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 16:53:03 +0000 Subject: [Koha-bugs] [Bug 23905] Button "Search to add" doesn't work on Quick add new patron In-Reply-To: <bug-23905-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23905-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23905-70-XhvSyfFkaz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kyle at bywatersolutions.com --- Comment #5 from Kyle M Hall <kyle at bywatersolutions.com> --- This fixes the popup not showing, but after selecting a patron, the info is not added to the page. the line: $('#guarantor_relationships').append( fieldset ); simply does nothing. If you add it to something outside of #guarantor_relationships such as 'body' or '#quick_add_form' it shows up! I'm not sure why it refused to append to '#guarantor_relationships'. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 17:53:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 16:53:38 +0000 Subject: [Koha-bugs] [Bug 23905] Button "Search to add" doesn't work on Quick add new patron In-Reply-To: <bug-23905-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23905-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23905-70-UmbRGnqERY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 --- Comment #6 from Kyle M Hall <kyle at bywatersolutions.com> --- I have a hunch that it has to do with these elements not existing at the time the page is loaded. These elements are created dynamically via javascript, right? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 17:54:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 16:54:40 +0000 Subject: [Koha-bugs] [Bug 23905] Button "Search to add" doesn't work on Quick add new patron In-Reply-To: <bug-23905-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23905-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23905-70-SPP6smkCcd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 --- Comment #7 from Kyle M Hall <kyle at bywatersolutions.com> --- In addition, I just realized the guarantor 'template' is visible on the quick add form, but should not be. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 18:02:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 17:02:27 +0000 Subject: [Koha-bugs] [Bug 23905] Button "Search to add" doesn't work on Quick add new patron In-Reply-To: <bug-23905-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23905-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23905-70-nYcVNxfEmr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 --- Comment #8 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- (In reply to Kyle M Hall from comment #7) > In addition, I just realized the guarantor 'template' is visible on the > quick add form, but should not be. Are we sure about that? I was wondering too, but there is a note referring quick add and guarantor: Note: Quick add guarantor form populates address fields in full form -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 18:03:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 17:03:56 +0000 Subject: [Koha-bugs] [Bug 24100] "Pay selected" is broken In-Reply-To: <bug-24100-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24100-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24100-70-hxQ9NiLeXw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24100 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 18:03:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 17:03:58 +0000 Subject: [Koha-bugs] [Bug 24100] "Pay selected" is broken In-Reply-To: <bug-24100-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24100-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24100-70-FvLOmgYceT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24100 --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 18:14:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 17:14:09 +0000 Subject: [Koha-bugs] [Bug 23246] Record detail page jumps into the 'images' tab if no holdings In-Reply-To: <bug-23246-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23246-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23246-70-CN77OWnWT2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #16 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Here again. This is the test plan I followed: - Have a record with an 856 $uhttps://www.youtube.com/watch?v=uHav6PL_4Bo - Have HTML5MediaYouTube and HTML5MediaEnabled disabled, and LocalCoverImages enabled - Load the detail page of the record => FAIL: you see: https://snipboard.io/Csb7HK.jpg (i.e. The syspref is disabled, but it jumps to the 'Images' tab, the fourth one, which is hardcoded and doesn't verify the syspref first). - Apply this patches, restart_all and refresh the browser => SUCCESS: It doesn't jump to the 'Images' tab (https://snipboard.io/4z9NTl.jpg) - Enable HTML5MediaYouTube and HTML5MediaEnabled - Reload the detail page => SUCCESS: The embedded media is displayed! (https://snipboard.io/REZ2T6.jpg) The fact that it jumps to the 'Images' tab is a coincidence, if you have EasyAnalytics enabled and LocalCoverImages disabled, it will jump to the Analytics tab. This is because it is hardcoded to jump to the tab with index of 3. It is very easy to spot the problem in the diff... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 18:16:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 17:16:07 +0000 Subject: [Koha-bugs] [Bug 23246] Record detail page jumps into the 'images' tab if no holdings In-Reply-To: <bug-23246-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23246-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23246-70-ZYpfygNuTA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246 --- Comment #17 from Tomás Cohen Arazi <tomascohen at gmail.com> --- (In reply to Marcel de Rooy from comment #14) > FAIL koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt > FAIL forbidden patterns > forbidden pattern: Do not use line breaks inside template > tags (bug 18675) (line 899) > > Please adjust your test plan too. Enabling the media pref is not enough; you > should have stuff in 856 fields too, indicators, etc? Done. I submitted a new plan, but beware that I'm fixing the negative case: i.e. the one in which context for displaying the media is not met, and yet there's a tab jump. So having 856 is not part of the requirements to test the wrong behavior I'm fixing. > What I do see without your patch for a biblio without holdings, is a flash > in staff from Acquisitions tab (==3) back to Holdings when loading detail. > Is solving 3 for media enough? My follow-up adds an id and makes it jump to the ID, if present. Otherwise the current behavior is kept and I'm not dealing with it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 18:18:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 17:18:34 +0000 Subject: [Koha-bugs] [Bug 23246] Record detail page jumps into the 'images' tab if no holdings In-Reply-To: <bug-23246-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23246-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23246-70-VQFcWrfkii@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246 --- Comment #18 from Tomás Cohen Arazi <tomascohen at gmail.com> --- (In reply to Katrin Fischer from comment #15) > I agree with Marcel, but I also still see an issue for a record with URL, > but without items: Tabs visible are holdings (0) and acquisitions. > Acquisitions is selected (I think it should not be). One reason I think we > should not jump is that we could still be displaying alternate holding > information that is hidden this way. This is the problem my patches fix: don't jump if you don't need to. And if you do, jump to the right place. You really need to have more than 3 tabs to see it. That's why I mention EasyAnalytics. I will explain again: the current code jumps to the 4th tab, no matter how the HTML5* sysprefs are set, or if the media tab is the fourth or another one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 18:30:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 17:30:00 +0000 Subject: [Koha-bugs] [Bug 24105] Longoverdue gives error message when --itemtypes are specified In-Reply-To: <bug-24105-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24105-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24105-70-u6dbQCnhUw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24105 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 18:30:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 17:30:02 +0000 Subject: [Koha-bugs] [Bug 24105] Longoverdue gives error message when --itemtypes are specified In-Reply-To: <bug-24105-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24105-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24105-70-z9uIhHH6SW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24105 --- Comment #1 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 95799 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95799&action=edit Bug 24105 - Fix error when running longoverdue.pl with --itemtypes To test: Run Longoverdue.pl as koha-shell with both 1 and several --itemtypes specified notice that it has an error apply this patch run longoverdue.pl as koha-shell with both 1 and several --itemtypes specified notice there isn't an error anymore! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 18:33:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 17:33:56 +0000 Subject: [Koha-bugs] [Bug 23905] Button "Search to add" doesn't work on Quick add new patron In-Reply-To: <bug-23905-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23905-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23905-70-3LgF7BQd8z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95798|0 |1 is obsolete| | --- Comment #9 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 95800 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95800&action=edit Bug 23905: Button "Search to add" doesn't work on Quick add new patron -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 18:41:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 17:41:04 +0000 Subject: [Koha-bugs] [Bug 23246] Record detail page jumps into the 'images' tab if no holdings In-Reply-To: <bug-23246-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23246-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23246-70-wnSRojEqsG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 18:41:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 17:41:18 +0000 Subject: [Koha-bugs] [Bug 23246] Record detail page jumps into the 'images' tab if no holdings In-Reply-To: <bug-23246-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23246-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23246-70-VZz9IAyjKU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91361|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 18:41:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 17:41:34 +0000 Subject: [Koha-bugs] [Bug 23246] Record detail page jumps into the 'images' tab if no holdings In-Reply-To: <bug-23246-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23246-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23246-70-rtTZMe6EAT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #91362|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 18:42:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 17:42:49 +0000 Subject: [Koha-bugs] [Bug 23246] Record detail page jumps into the 'images' tab if no holdings In-Reply-To: <bug-23246-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23246-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23246-70-jpsl9ejUnD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246 --- Comment #19 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 95801 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95801&action=edit Bug 23246: Only jump into the 'images' tab HTML5MediaEnabled is set to This patch makes jumping into the third tab happen only if HTML5MediaEnabled is set to 'both' or 'staff'. To test: - Have HTML5MediaEnabled set to 'opac' or 'not at all' - Open the detail page of a record with no holdings => FAIL: The 'images' tab is selected - Apply this patch - Reload => SUCCESS: The 'holdings' tab is selected as it should be. - Sign off :-D Sponsored-by: America Numismatic Society Signed-off-by: Maryse Simard <maryse.simard at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 18:42:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 17:42:54 +0000 Subject: [Koha-bugs] [Bug 23246] Record detail page jumps into the 'images' tab if no holdings In-Reply-To: <bug-23246-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23246-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23246-70-lm3wmif3DQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246 --- Comment #20 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 95802 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95802&action=edit Bug 23246: (follow-up) Hardcoding tab position is not enough There are many conditions that determine the tab number for 'media'. Translated into variables that hold the tabs count on each condition, it is clear that '3' was not good enough: [%- holdings = (SeparateHoldings) ? 2 : 1 notes = (MARCNOTES || notes) ? 1 : 0 acq = (Koha.Preference('AcquisitionDetails')) ? 1 : 0 frbr = (FRBRizeEditions && XISBNS) ? 1 : 0 local_covers = (LocalCoverImages && (localimages || CAN_user_tools_upload_local_cover_images)) ? 1 : 0 media_tab = holdings + notes + acq + frbr + local_covers -%] This patch gets rid of the hardcoded value, adds an id to the 'media' tab (i.e. 'media_tab') and uses JS to get the right index. To test: - Play with the different options governing those variables => FAIL: 3 is not always the 'media' tab - Apply this patch - Repeat your tests => SUCCESS: It always picks the 'media' tab - Sign off :-D Sponsored-by: American Numismatics Society Signed-off-by: Maryse Simard <maryse.simard at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 18:44:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 17:44:21 +0000 Subject: [Koha-bugs] [Bug 23246] Record detail page jumps into the 'images' tab if no holdings In-Reply-To: <bug-23246-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23246-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23246-70-cBG2VhQtbe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246 --- Comment #21 from Tomás Cohen Arazi <tomascohen at gmail.com> --- (In reply to Marcel de Rooy from comment #14) > FAIL koha-tmpl/intranet-tmpl/prog/en/modules/catalogue/detail.tt > FAIL forbidden patterns > forbidden pattern: Do not use line breaks inside template > tags (bug 18675) (line 899) Fixed this one! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 18:44:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 17:44:32 +0000 Subject: [Koha-bugs] [Bug 23246] Record detail page jumps into the 'images' tab if no holdings In-Reply-To: <bug-23246-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23246-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23246-70-gWZ14RhGhA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 18:48:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 17:48:11 +0000 Subject: [Koha-bugs] [Bug 9979] convert ./C4/Installer/PerlDependencies.pm into a YAML file In-Reply-To: <bug-9979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9979-70-5dqEDrrXVT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9979 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19735 CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 18:48:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 17:48:11 +0000 Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile In-Reply-To: <bug-19735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19735-70-qYpejsShEw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=9979 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 18:50:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 17:50:49 +0000 Subject: [Koha-bugs] [Bug 23905] Button "Search to add" doesn't work on Quick add new patron In-Reply-To: <bug-23905-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23905-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23905-70-vufILJXjGo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 18:50:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 17:50:51 +0000 Subject: [Koha-bugs] [Bug 23905] Button "Search to add" doesn't work on Quick add new patron In-Reply-To: <bug-23905-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23905-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23905-70-SCj3mUHebl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95800|0 |1 is obsolete| | --- Comment #10 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 95803 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95803&action=edit Bug 23905: Button "Search to add" doesn't work on Quick add new patron This issue is caused by duplicating the patron guarantor fieldset. The solution is to move it between the two forms insetad. In addition, this patch moves the guarantor information fieldset to the area below the "Quick add" fieldset, instead of *inside* it. This change preserves the correct styling and layout of the Guarantor information fieldset whilst it is moved back and forth by the "quick add"/"full form" toggle. Test Plan: 1) Quick add a child patron 2) Attempt to use the "Search to add" button 3) Note it does nothing 4) Apply this patch 5) Repeat steps 1 and 2 6) It works now! 7) Test toggling between the quick add and full form views, note the "Guarantor information" fieldset shows correctly in the full form view. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 18:53:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 17:53:20 +0000 Subject: [Koha-bugs] [Bug 19735] Move Perl deps definitions into a cpanfile In-Reply-To: <bug-19735-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19735-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19735-70-GsesvdIzZn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19735 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 18:53:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 17:53:27 +0000 Subject: [Koha-bugs] [Bug 23905] Button "Search to add" doesn't work on Quick add new patron In-Reply-To: <bug-23905-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23905-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23905-70-sp2Bo8Uhgw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |ASSIGNED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 19:01:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 18:01:49 +0000 Subject: [Koha-bugs] [Bug 23905] Button "Search to add" doesn't work on Quick add new patron In-Reply-To: <bug-23905-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23905-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23905-70-uvRZ6EbEuZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 19:01:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 18:01:51 +0000 Subject: [Koha-bugs] [Bug 23905] Button "Search to add" doesn't work on Quick add new patron In-Reply-To: <bug-23905-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23905-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23905-70-1yZKrwjFhn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95803|0 |1 is obsolete| | --- Comment #11 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 95804 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95804&action=edit Bug 23905: Button "Search to add" doesn't work on Quick add new patron This issue is caused by duplicating the patron guarantor fieldset. The solution is to move it between the two forms insetad. In addition, this patch moves the guarantor information fieldset to the area below the "Quick add" fieldset, instead of *inside* it. This change preserves the correct styling and layout of the Guarantor information fieldset whilst it is moved back and forth by the "quick add"/"full form" toggle. Test Plan: 1) Quick add a child patron 2) Attempt to use the "Search to add" button 3) Note it does nothing 4) Apply this patch 5) Repeat steps 1 and 2 6) It works now! 7) Test toggling between the quick add and full form views, note the "Guarantor information" fieldset shows correctly in the full form view. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 19:18:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 18:18:01 +0000 Subject: [Koha-bugs] [Bug 24106] New: In returns.pl, don't search for item if no barcode is provided Message-ID: <bug-24106-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24106 Bug ID: 24106 Summary: In returns.pl, don't search for item if no barcode is provided Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org When loading returns.pl, code to check rotating collections fires off an search for items by barcode, but doesn't check for a barcode first. This means the code will search for items where barcode is NULL, which is definitely not the intended function. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 19:18:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 18:18:05 +0000 Subject: [Koha-bugs] [Bug 24106] In returns.pl, don't search for item if no barcode is provided In-Reply-To: <bug-24106-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24106-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24106-70-Q4b0FwecmI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24106 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 19:20:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 18:20:33 +0000 Subject: [Koha-bugs] [Bug 24106] In returns.pl, don't search for item if no barcode is provided In-Reply-To: <bug-24106-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24106-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24106-70-rlYPayH5JE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24106 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 19:20:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 18:20:36 +0000 Subject: [Koha-bugs] [Bug 24106] In returns.pl, don't search for item if no barcode is provided In-Reply-To: <bug-24106-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24106-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24106-70-c703PqqK2F@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24106 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 95805 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95805&action=edit Bug 24106: In returns.pl, don't search for item if no barcode is provided When loading returns.pl, code to check rotating collections fires off an search for items by barcode, but doesn't check for a barcode first. This means the code will search for items where barcode is NULL, which is definitely not the intended function. Test Plan: 1) Apply this patch 2) Set up a rotating collection with items 3) Transfer the collection 4) Check in a rotating collection item 5) Note no change in functionality -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 19:22:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 18:22:35 +0000 Subject: [Koha-bugs] [Bug 19014] Patrons should not get an 'on_reserve' notification if the due date is far into the future In-Reply-To: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19014-70-j0fBOPMmrE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 --- Comment #43 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- New test plan: To test: 1 - Checkout an item to a patron with a due date 2 days in the future and 'No renewal before' set to 1 2 - Place a hold on that item 3 - Define an AUTO_RENEWALS circulation notice with below at a minimum [% checkout.auto_renew_error %] 4 - Patron is notified with error 'on_reserve' 5 - Set 'No renewal before' to 3 6 - UPDATE issues SET auto_renew_error = NULL; 7 - run cronjob 8 - Patron is notified with error 'on_reserve' 9 - APPLY PATCH 10 - Set 'No renewal before' to 1 11 - UPDATE issues SET auto_renew_error = NULL; 12 - run cronjob 13 - Patron is not notified 14 - UPDATE issues SET auto_renew_error = NULL; 15 - Set 'No renewal before' to 3 16 - UPDATE issues SET auto_renew_error = NULL; 17 - run cronjob 18 - Patron is notified with error 'on_reserve' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 19:43:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 18:43:33 +0000 Subject: [Koha-bugs] [Bug 24107] New: Returns.pl fetches the same item from the database multiple times Message-ID: <bug-24107-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24107 Bug ID: 24107 Summary: Returns.pl fetches the same item from the database multiple times Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: kyle at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org I noticed while writing the patch for bug 24106 that we get the same item from the database multiple times. It would make sense to only fetch it once for efficiency. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 20:18:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 19:18:54 +0000 Subject: [Koha-bugs] [Bug 23672] Dependency graph colours missing In-Reply-To: <bug-23672-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23672-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23672-70-oiKSf1XFYv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23672 Chris Cormack <chris at bigballofwax.co.nz> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #5 from Chris Cormack <chris at bigballofwax.co.nz> --- Applied and it looks to be working for me. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 20:27:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 19:27:37 +0000 Subject: [Koha-bugs] [Bug 24106] In returns.pl, don't search for item if no barcode is provided In-Reply-To: <bug-24106-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24106-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24106-70-xCW7NOkxEi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24106 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 20:27:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 19:27:40 +0000 Subject: [Koha-bugs] [Bug 24106] In returns.pl, don't search for item if no barcode is provided In-Reply-To: <bug-24106-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24106-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24106-70-ccxoMPfgPE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24106 Liz Rea <wizzyrea at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95805|0 |1 is obsolete| | --- Comment #2 from Liz Rea <wizzyrea at gmail.com> --- Created attachment 95806 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95806&action=edit Bug 24106: In returns.pl, don't search for item if no barcode is provided When loading returns.pl, code to check rotating collections fires off an search for items by barcode, but doesn't check for a barcode first. This means the code will search for items where barcode is NULL, which is definitely not the intended function. Test Plan: 1) Apply this patch 2) Set up a rotating collection with items 3) Transfer the collection 4) Check in a rotating collection item 5) Note no change in functionality Signed-off-by: Liz Rea <wizzyrea at gmail.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 20:30:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 19:30:07 +0000 Subject: [Koha-bugs] [Bug 19014] Patrons should not get an 'on_reserve' notification if the due date is far into the future In-Reply-To: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19014-70-3UNHxArVSf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA --- Comment #44 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Failing QA. Testing with an item due 4 days in the future, No Renewal Before set to 1, issue still gets assessed by the auto-renew cron. Gets an auto_renew_error of auto_too_soon when no hold is placed on the item. Gets an error of on_reserve when there is a hold. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 20:43:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 19:43:12 +0000 Subject: [Koha-bugs] [Bug 21270] Not finding what you're looking for displaying uselessly In-Reply-To: <bug-21270-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21270-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21270-70-VKjGCa2d6b@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 Blou <philippe.blouin at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #78239|0 |1 is obsolete| | --- Comment #9 from Blou <philippe.blouin at inlibro.com> --- Created attachment 95807 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95807&action=edit Bug 21270: "Not finding what you're looking for" displaying uselessly When doing OPAC search, at the bottom you have an offer presented with "Not finding what you're looking for" to introduce Suggestions or ILL if enabled. Bug 7317 modified the if-else and now if you enable ILLModule but not AnonSuggestions and are not logged, you have this little string sitting there, offering nothing to the user. Just taunting them... TEST: 0) Set IllModule to true, AnonSuggestions to false. 1) Without login, just to an OPAC search. At the bottom will be a nice string laughing at your failed search 2) Apply the patch. 3) Problem at 1) is fixed. 4) Login to validate that ILL link now appear. 5) Modify combination of IllModule and AnonSuggestions to validate links appearing. Patch applies and functions as described. Signed-off-by: Dilan Johnpullé <dilan at calyx.net.au> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 20:44:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 19:44:07 +0000 Subject: [Koha-bugs] [Bug 21270] Not finding what you're looking for displaying uselessly In-Reply-To: <bug-21270-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21270-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21270-70-Pv4ama2hIT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21270 Blou <philippe.blouin at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 21:21:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 20:21:12 +0000 Subject: [Koha-bugs] [Bug 11361] Add a Z39.50 search page in the OPAC to let members search for records on remote Koha instances In-Reply-To: <bug-11361-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11361-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11361-70-xe0QKl5gLD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11361 Arthur Bousquet <arthur.bousquet at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #72813|0 |1 is obsolete| | --- Comment #15 from Arthur Bousquet <arthur.bousquet at inlibro.com> --- Created attachment 95808 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95808&action=edit Bug11361 - opac z3950 search bug11361 - atomicupdate bug -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 21:26:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 20:26:44 +0000 Subject: [Koha-bugs] [Bug 11361] Add a Z39.50 search page in the OPAC to let members search for records on remote Koha instances In-Reply-To: <bug-11361-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11361-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11361-70-4C3fGVgtHl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11361 Arthur Bousquet <arthur.bousquet at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on|11297 | CC| |arthur.bousquet at inlibro.com Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 21:26:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 20:26:44 +0000 Subject: [Koha-bugs] [Bug 11297] Add support for custom PQF attributes for Z39.50 server searches In-Reply-To: <bug-11297-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11297-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11297-70-0xTwggE4Yi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11297 Arthur Bousquet <arthur.bousquet at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks|11361 | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11361 [Bug 11361] Add a Z39.50 search page in the OPAC to let members search for records on remote Koha instances -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 21:42:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 20:42:47 +0000 Subject: [Koha-bugs] [Bug 24108] New: Advanced Editor: Save .mrc save with a configurable value Message-ID: <bug-24108-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24108 Bug ID: 24108 Summary: Advanced Editor: Save .mrc save with a configurable value Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: carnold at dgiinc.com QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When saving a file as .mrc in the Advanced Editor, please add an identifier to the name of the file. Either: *Koha Number *Control Number (our preference, but we understand not everyone uses this) Bonus if it is configurable (default can be Koha Number) Currently the file is saved as "record.mrc" which does no one any good at all. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 21:44:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 20:44:47 +0000 Subject: [Koha-bugs] [Bug 11361] Add a Z39.50 search page in the OPAC to let members search for records on remote Koha instances In-Reply-To: <bug-11361-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11361-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11361-70-CTfRMZc7Zv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11361 Arthur Bousquet <arthur.bousquet at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff --- Comment #16 from Arthur Bousquet <arthur.bousquet at inlibro.com> --- I rebased the patch and it should apply correctly, here is a test plan: - apply patch - update the database - set "OpacZ3950" to "Allow" in OPAC preferences - go in Z39.50/SRU servers administration - edit one server line - check the "OPAC (Shown in OPAC Z39.50 search)" checkbox - go in the opac - click the "Z39.50 Search" link on top - check the z3950 server you want and make a search - verify that you have results If you need a Z3950 server for testing purpose, here is the library of congress online catalog: hostname: lx2.loc.gov port: 210 database: LCDB syntax: MARC21/USMARC encoding: utf8 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 22:00:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 21:00:46 +0000 Subject: [Koha-bugs] [Bug 22158] Add keyboard shortcuts in advanced editor to move current line up or down within record In-Reply-To: <bug-22158-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22158-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22158-70-Fb8O8kGymx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22158 Cori Lynn Arnold <carnold at dgiinc.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |carnold at dgiinc.com --- Comment #3 from Cori Lynn Arnold <carnold at dgiinc.com> --- ++ this bug. A button to sort by number would be good, but we still need a hotkey or some sort of dragging ability because 5xxs have a specific, non-number ordering scheme. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 22:19:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 21:19:36 +0000 Subject: [Koha-bugs] [Bug 24013] Transferring a checked out item gives a software error In-Reply-To: <bug-24013-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24013-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24013-70-TvXm3OEAAk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24013 --- Comment #11 from Aleisha Amohia <aleisha at catalyst.net.nz> --- (In reply to Jonathan Druart from comment #4) > Hello Aleisha, > > I removed the Academy kw and provided 2 patches, a bugfix and the tests to > cover the changes. If you need this bug report to use as example, I can > obsolete the bugfix and keep the tests. > > It sounded quite urgent to fix as it impact stable releases. > > Cheers No worries Jonathan, thank you for fixing! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Mon Nov 25 22:35:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Mon, 25 Nov 2019 21:35:15 +0000 Subject: [Koha-bugs] [Bug 23672] Dependency graph colours missing In-Reply-To: <bug-23672-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23672-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23672-70-yErxPRTIwY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23672 --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Thanks guys, u find the graph so much more usable with this scheme, much appreciated. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 02:12:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 01:12:14 +0000 Subject: [Koha-bugs] [Bug 24097] Don't show claims tab in patron account, when there are no claims In-Reply-To: <bug-24097-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24097-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24097-70-Waouc8XYiR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24097 Lisette Scheer <lisetteslatah at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 02:12:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 01:12:29 +0000 Subject: [Koha-bugs] [Bug 24098] Capitalization: Fees & Charges In-Reply-To: <bug-24098-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24098-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24098-70-QGefpJZ7Ex@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24098 Lisette Scheer <lisetteslatah at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 02:12:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 01:12:37 +0000 Subject: [Koha-bugs] [Bug 24099] Capitalization: Copier Fees In-Reply-To: <bug-24099-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24099-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24099-70-F0T8qVBXLR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24099 Lisette Scheer <lisetteslatah at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |lisetteslatah at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 03:18:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 02:18:49 +0000 Subject: [Koha-bugs] [Bug 24109] New: Elasticsearch - Advanced search limit by shelving location uses AND instead of OR Message-ID: <bug-24109-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24109 Bug ID: 24109 Summary: Elasticsearch - Advanced search limit by shelving location uses AND instead of OR Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: mkstephens at lancasterseminary.edu When performing an advanced catalog search, the limits for item type and collection are formed into a query string with OR, while the limits for shelving location are formed into the query string with AND. This prevents searching multiple locations at once and is also confusing since the behavior is different from the other limit tabs and is accompanied by the same instruction, "Limit to any of the following." Steps to replicate: 1. In the advanced catalog search, select two limits on the item types tab. Perform search. Note the search query was constructed with OR. 2. Return to the advanced catalog search and clear fields. Select two limits on the shelving location tab. Perform search. Note the search query was constructed with AND. 3. Return to the advanced catalog search and clear fields. Select two limits on the collections tab. Perform search. Note the search query was constructed with OR. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 09:03:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 08:03:30 +0000 Subject: [Koha-bugs] [Bug 13326] Add possibilty to edit purchase suggestion on opac In-Reply-To: <bug-13326-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13326-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13326-70-uyDg6vQyfD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13326 Ray Delahunty <r.delahunty at arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty at arts.ac.uk --- Comment #2 from Ray Delahunty <r.delahunty at arts.ac.uk> --- Currently a suggestion that is deleted by the user who submitted it via their account sees the data in the suggestions table deleted. This can be even AFTER the suggestion has been accepted, the user notified, and the ordering process has started. For us this is unwelcome functionality as we want to record counts of purchase suggestions. We will be looking at using jquery to hide the delete functionality in the user account. We did consider adding an old_suggestions table as well, so we could archive suggestions (such as those made in a previous academic year), so we note and are delighted with the development work for bug 22784. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 09:15:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 08:15:14 +0000 Subject: [Koha-bugs] [Bug 24101] Due date to on-site loans according to the calendar and possibility to renew on-site loans In-Reply-To: <bug-24101-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24101-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24101-70-FWfaobQTQf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24101 Joonas Kylmälä <joonas.kylmala at helsinki.fi> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |joonas.kylmala at helsinki.fi -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 09:24:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 08:24:36 +0000 Subject: [Koha-bugs] [Bug 24110] New: Template vars are incorrectly html filtered when dumped Message-ID: <bug-24110-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24110 Bug ID: 24110 Summary: Template vars are incorrectly html filtered when dumped Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 13618 Referring to DumpTemplateVarsIntranet and DumpTemplateVarsOpac Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 [Bug 13618] Add additional template filter methods and a filter presence test to Koha -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 09:24:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 08:24:36 +0000 Subject: [Koha-bugs] [Bug 13618] Add additional template filter methods and a filter presence test to Koha In-Reply-To: <bug-13618-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13618-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13618-70-ftuYfRnPxR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24110 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24110 [Bug 24110] Template vars are incorrectly html filtered when dumped -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 09:24:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 08:24:36 +0000 Subject: [Koha-bugs] [Bug 24103] Add option to dump built search query to templates In-Reply-To: <bug-24103-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24103-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24103-70-ap81qC88Dl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24103 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24110 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 09:30:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 08:30:31 +0000 Subject: [Koha-bugs] [Bug 24110] Template vars are incorrectly html filtered when dumped In-Reply-To: <bug-24110-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24110-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24110-70-Tq3LLobwkK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24110 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 09:30:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 08:30:34 +0000 Subject: [Koha-bugs] [Bug 24110] Template vars are incorrectly html filtered when dumped In-Reply-To: <bug-24110-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24110-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24110-70-YYnkxBkukF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24110 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95809 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95809&action=edit Bug 24110: Do not html filter TT vars when dumped DumpTemplateVarsIntranet and DumpTemplateVarsOpac are devs tools to display the variables sent to the template. They should not be filtered otherwise it's getting completed to read. For instance: $VAR1 = { var => val } Test plan: Turn DumpTemplateVarsIntranet on Go to the main page Show the source of the page Confirm that the variable are displayed as it and not filtered -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 09:39:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 08:39:50 +0000 Subject: [Koha-bugs] [Bug 22835] Serve static files from plugins through the API In-Reply-To: <bug-22835-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22835-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22835-70-kMkwFvWZHQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22835 --- Comment #25 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- (In reply to Tomás Cohen Arazi from comment #24) > @fridolin can we backport this? I'd love to but I'm actually on last release. You will have to see this with next maintainer. Best regards, -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 09:44:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 08:44:26 +0000 Subject: [Koha-bugs] [Bug 24111] New: Incorrect "Can't create any orders" alert Message-ID: <bug-24111-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24111 Bug ID: 24111 Summary: Incorrect "Can't create any orders" alert Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Acquisitions Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org It happens to see "You can't create any orders unless you first define a budget and a fund" when adding a new order. The test on neworderbiblio.pl is not the same as other pages. We should test if the logged in user can use the budget, not if they are the owner. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 09:44:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 08:44:37 +0000 Subject: [Koha-bugs] [Bug 24111] Incorrect "Can't create any orders" alert In-Reply-To: <bug-24111-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24111-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24111-70-KVZKuU9tFS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24111 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |6994 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6994 [Bug 6994] 'No budget defined' showing up although budgets and funds are defined -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 09:44:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 08:44:37 +0000 Subject: [Koha-bugs] [Bug 6994] 'No budget defined' showing up although budgets and funds are defined In-Reply-To: <bug-6994-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6994-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6994-70-WSurDFHTcm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6994 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24111 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24111 [Bug 24111] Incorrect "Can't create any orders" alert -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 09:45:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 08:45:27 +0000 Subject: [Koha-bugs] [Bug 15142] Titles facet does not work in UNIMARC In-Reply-To: <bug-15142-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15142-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15142-70-NPVUCa1cL5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15142 --- Comment #8 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Created attachment 95810 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95810&action=edit Bug 15142: (follow-up) remove from Zebra UNIMARC config files -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 09:46:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 08:46:00 +0000 Subject: [Koha-bugs] [Bug 15142] Titles facet does not work in UNIMARC In-Reply-To: <bug-15142-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15142-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15142-70-rbHyZDWDI2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15142 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Needs Signoff --- Comment #9 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- (In reply to Jonathan Druart from comment #7) > Should not it be removed from xsl and xml files in > etc/zebradb/marc_defs/unimarc/biblios? Yes indeed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 09:46:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 08:46:59 +0000 Subject: [Koha-bugs] [Bug 24111] Incorrect "Can't create any orders" alert In-Reply-To: <bug-24111-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24111-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24111-70-EdYkdVSjlj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24111 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 09:47:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 08:47:03 +0000 Subject: [Koha-bugs] [Bug 24111] Incorrect "Can't create any orders" alert In-Reply-To: <bug-24111-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24111-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24111-70-iunX1bGm9c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24111 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95811 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95811&action=edit Bug 24111: Remove incorrect "Can't create any orders" alert It happens to see "You can't create any orders unless you first define a budget and a fund" when adding a new order. The test on neworderbiblio.pl is not the same as other pages. We should test if the logged in user can use the budget, not if they are the owner. Test plan: 0/ Add an owner to all of your funds 1/ Create an order from an existing record => Without this patch you should see the alert at the bottom of the result list => With this patch applied you should not see it QA will compare with the 2 other occurrences, in acqui/basket.pl and acqui/booksellers.pl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 09:56:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 08:56:27 +0000 Subject: [Koha-bugs] [Bug 24112] New: Cannot edit or save a patron when a duplicate is found Message-ID: <bug-24112-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24112 Bug ID: 24112 Summary: Cannot edit or save a patron when a duplicate is found Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com If a duplicated patron is found there are 2 buttons ("edit existing record" or "save a new record") but none is working. The submit seems to be blocked by the form validation: https://snipboard.io/7QFbwE.jpg To recreate: Create a patron with surname=xxx Create another one and save You get the alert but the buttons do not work -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 10:02:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 09:02:17 +0000 Subject: [Koha-bugs] [Bug 22923] Items search does not take care of independent branches In-Reply-To: <bug-22923-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22923-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22923-70-6fXR5H4Nda@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22923 --- Comment #5 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- (In reply to Jonathan Druart from comment #4) > I do not understand. It seems that nothing block the edition, even with > IndependentBranches turned on. The bug report should not focus on the item > search but to fix globally the issue, if it is what you meant. Oh yes indeed. > > If so, can you detail the condition of the edition please? > > * Superlibrarian can edit everything > > * librarian with editcatalogue can edit a biblio > > * librarian with editcatalogue and from the same library as holdingbranch or > homebranch can edit an item Maybe we use to use HomeOrHoldingBranch ? Or create a new preference with allow edition depending on home/holding/both. > > We should then adjust all the links to item editing. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 10:11:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 09:11:43 +0000 Subject: [Koha-bugs] [Bug 22923] Items search does not take care of independent branches In-Reply-To: <bug-22923-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22923-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22923-70-05wA25w00e@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22923 --- Comment #6 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- (In reply to Jonathan Druart from comment #4) > I do not understand. It seems that nothing block the edition, even with > IndependentBranches turned on. Oh but now I have tested : With IndependentBranches turned on, in record normal view, you see the "Edit" button only on the items of your branch. Pref says : Prevent staff (but not superlibrarians) from modifying objects (holds, items, patrons, etc.) belonging to other libraries. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 10:14:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 09:14:00 +0000 Subject: [Koha-bugs] [Bug 24112] Cannot edit or save a patron when a duplicate is found In-Reply-To: <bug-24112-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24112-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24112-70-hfRZUNHKCZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24112 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Hum, cannot recreate right now, I may have missed a step. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 10:23:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 09:23:48 +0000 Subject: [Koha-bugs] [Bug 24113] New: guarantor info lost when a duplicate is found Message-ID: <bug-24113-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24113 Bug ID: 24113 Summary: guarantor info lost when a duplicate is found Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Patrons Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com Depends on: 14570 When a patron is created with a guarantor but a duplicate is found (or any other warnings I guess) the guarantor's info are lost. To recreate: Create a patron with surname=toto Create a kid with surname=toto and a guarantor Save Confirm that you want to create a new record => The guarantor info is not saved It works prior to bug 14570. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 [Bug 14570] Make it possible to add multiple guarantors to a record -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 10:23:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 09:23:48 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: <bug-14570-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14570-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14570-70-Ix6UW0NNFY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24113 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24113 [Bug 24113] guarantor info lost when a duplicate is found -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 10:32:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 09:32:27 +0000 Subject: [Koha-bugs] [Bug 23905] Button "Search to add" doesn't work on Quick add new patron In-Reply-To: <bug-23905-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23905-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23905-70-mUiHarV7WP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 10:32:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 09:32:30 +0000 Subject: [Koha-bugs] [Bug 23905] Button "Search to add" doesn't work on Quick add new patron In-Reply-To: <bug-23905-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23905-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23905-70-aAYBMAtw79@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95804|0 |1 is obsolete| | --- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95812 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95812&action=edit Bug 23905: Button "Search to add" doesn't work on Quick add new patron This issue is caused by duplicating the patron guarantor fieldset. The solution is to move it between the two forms insetad. In addition, this patch moves the guarantor information fieldset to the area below the "Quick add" fieldset, instead of *inside* it. This change preserves the correct styling and layout of the Guarantor information fieldset whilst it is moved back and forth by the "quick add"/"full form" toggle. Test Plan: 1) Quick add a child patron 2) Attempt to use the "Search to add" button 3) Note it does nothing 4) Apply this patch 5) Repeat steps 1 and 2 6) It works now! 7) Test toggling between the quick add and full form views, note the "Guarantor information" fieldset shows correctly in the full form view. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 10:32:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 09:32:34 +0000 Subject: [Koha-bugs] [Bug 23905] Button "Search to add" doesn't work on Quick add new patron In-Reply-To: <bug-23905-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23905-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23905-70-eL91QFYrk0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 --- Comment #13 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95813 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95813&action=edit Bug 23905: Remove extra closing span Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 10:34:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 09:34:15 +0000 Subject: [Koha-bugs] [Bug 24113] guarantor info lost when a duplicate is found In-Reply-To: <bug-24113-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24113-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24113-70-xsCZ2AG1O8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24113 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_19_11_candidate CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 10:41:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 09:41:51 +0000 Subject: [Koha-bugs] [Bug 22923] Items search does not take care of independent branches In-Reply-To: <bug-22923-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22923-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22923-70-4uuEIzZyxv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22923 --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Fridolin SOMERS from comment #6) > (In reply to Jonathan Druart from comment #4) > > I do not understand. It seems that nothing block the edition, even with > > IndependentBranches turned on. > > Oh but now I have tested : > With IndependentBranches turned on, in record normal view, you see the > "Edit" button only on the items of your branch. > > Pref says : > Prevent staff (but not superlibrarians) from modifying objects (holds, > items, patrons, etc.) belonging to other libraries. Hum indeed, but you can "Edit items", then edit whichever you want... -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 10:48:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 09:48:35 +0000 Subject: [Koha-bugs] [Bug 23727] Editing course reserve items is broken In-Reply-To: <bug-23727-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23727-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23727-70-KSM2CIDKBW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_target CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 10:48:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 09:48:55 +0000 Subject: [Koha-bugs] [Bug 23727] Editing course reserve items is broken In-Reply-To: <bug-23727-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23727-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23727-70-yqt74aRqiF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23727 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|blocker |critical -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 10:50:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 09:50:59 +0000 Subject: [Koha-bugs] [Bug 23006] Can't use inventory tool with barcodes that contain regex reserved characters ($, ...) In-Reply-To: <bug-23006-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23006-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23006-70-LvisaRYP8p@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23006 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Summary|Can't use inventory tool |Can't use inventory tool |with barcodes that contain |with barcodes that contain |regex relevant characters |regex reserved characters |($,...) |($,...) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 11:10:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 10:10:12 +0000 Subject: [Koha-bugs] [Bug 24114] New: modules must not warn Message-ID: <bug-24114-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24114 Bug ID: 24114 Summary: modules must not warn Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: jonathan.druart at bugs.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Bug 21336 introduced warn statements in Koha::Patrons. That should be avoided, the warn must be done in the cronjob script. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 11:10:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 10:10:37 +0000 Subject: [Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove In-Reply-To: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21336-70-0SPpA2JfwO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24114 --- Comment #131 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Marcel de Rooy from comment #130) > (In reply to Jonathan Druart from comment #129) > > I do not see a good reason to warn from the module, the script must done > > that job. Especially because misc/cronjobs/cleanup_database.pl uses print > > (STDOUT). > > > > Can you explain this choice? > > Probably simpler in the first place. And if this is indeed about the > existing issues warn, it is not just an informational print line. > Surely, it can be done differently. In other places too? Which other places? I do not think there were any before this patchset. I have opened bug 24114 to deal with the verbose flag. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24114 [Bug 24114] modules must not warn -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 11:10:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 10:10:37 +0000 Subject: [Koha-bugs] [Bug 24114] modules must not warn In-Reply-To: <bug-24114-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24114-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24114-70-sKEfPUcF88@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24114 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21336 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 11:12:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 10:12:09 +0000 Subject: [Koha-bugs] [Bug 24114] modules must not warn In-Reply-To: <bug-24114-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24114-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24114-70-M6AwSCEtvG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24114 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95814 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95814&action=edit Bug 24114: Remove warn statements from Koha::Patrons The warn must be done in the cronjob -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 11:14:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 10:14:04 +0000 Subject: [Koha-bugs] [Bug 24115] New: patron import tool should have option to not overwrite specific fields Message-ID: <bug-24115-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24115 Bug ID: 24115 Summary: patron import tool should have option to not overwrite specific fields Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: jeremy.evans at phe.gov.uk QA Contact: testopia at bugs.koha-community.org Following a test load of users exported from our active directory using the import users tool (Koha 18.11) we have encountered a few issues. The default settings specified for the load are being applied to also overwrite existing users. For example, all users now have the same profile and home library. We would wish to have the option for the default settings to only apply for new users created and for example retain the current user profile and home library for existing users. These 2 fields would not be included in the file loaded to Koha from the Active directory. There are other fields such as the email address, expiry date, address, etc where we do want the load to overwrite the existing records to keep these up to date in Koha. Probably another tick box next to each of the fields listed for the default settings to only apply to new records would make it flexible to retain specific fields whilst allowing others to be updated As a minimum this should apply to user profile and home library. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 11:14:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 10:14:11 +0000 Subject: [Koha-bugs] [Bug 24114] modules must not warn In-Reply-To: <bug-24114-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24114-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24114-70-mJnUXszhIV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24114 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I do not understand how to test properly this patch, why do not we have a separated flag for this task? The following commit 2ca2585b1c5b61024351c32d84e605f61d04a418 Bug 21336: Adjust cleanup_database.pl says "Run cleanup_database.pl --logs (or any other flag) for the first time." But it sounds wrong to me, I am expecting the script to do what I am asking it to do. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 11:20:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 10:20:48 +0000 Subject: [Koha-bugs] [Bug 23927] Duplicate a "Complete" order link the "New" one to the invoice In-Reply-To: <bug-23927-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23927-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23927-70-zguRRrXZtA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23927 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 11:20:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 10:20:51 +0000 Subject: [Koha-bugs] [Bug 23927] Duplicate a "Complete" order link the "New" one to the invoice In-Reply-To: <bug-23927-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23927-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23927-70-SbS9xAnwbS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23927 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95777|0 |1 is obsolete| | --- Comment #6 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 95815 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95815&action=edit Bug 23927: Add tests Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 11:20:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 10:20:54 +0000 Subject: [Koha-bugs] [Bug 23927] Duplicate a "Complete" order link the "New" one to the invoice In-Reply-To: <bug-23927-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23927-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23927-70-jDNa7o2ybh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23927 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95778|0 |1 is obsolete| | --- Comment #7 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 95816 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95816&action=edit Bug 23927: Do not copy invoiceid for a new duplicated order When an order is created from an existing one (duplication), then the invoice should be set to null instead of retrieved. Test plan: - receive an order - in a new basket, add an order "From exisitions orders (copy)" - search your received order - duplicate - go to the bibliographic record "Acquisition details" tab => Without this patch you will see that the invoice is the same for the two orders => With this patch the invoice for the new order is not set Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 11:46:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 10:46:31 +0000 Subject: [Koha-bugs] [Bug 13806] No input sanitization where creating Reports subgroup In-Reply-To: <bug-13806-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13806-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13806-70-NghKRysCbJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13806 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 11:46:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 10:46:35 +0000 Subject: [Koha-bugs] [Bug 13806] No input sanitization where creating Reports subgroup In-Reply-To: <bug-13806-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13806-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13806-70-Fs5ksXNw2h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13806 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95733|0 |1 is obsolete| | --- Comment #2 from Séverine Queune <severine.queune at bulac.fr> --- Created attachment 95817 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95817&action=edit Bug 13806: No input sanitization where creating Reports subgroup This patch adds validation of report group and subgroup inputs so that the user can't enter data into only one half of the group code/name pair. To test, apply the patch and go to Reports -> Use saved. - Create or edit a report which doesn't have a group or subgroup assigned. - Under "Report group," select the "or create" radio button. - Click the "Update SQL" button to submit the form without entering a group code or name. The form should require taht you enter data into both fields. - Enter data into the report group code and name fields. Add data to either the code or data field under "Report subgroup." You should not be able to submit the form without populating both. - Start over editing a report which doesn't have a group or subgroup assigned. - Select an existing group under "Report group." - Under "Report subgroup," select the "or create" option. - You should not be able to submit the form without adding data in both the code and name fields for the report subgroup. Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 11:49:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 10:49:29 +0000 Subject: [Koha-bugs] [Bug 23702] New UNIMARC XSLT according to last IFLA updates In-Reply-To: <bug-23702-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23702-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23702-70-HJYBoJYwjP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23702 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 12:08:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 11:08:30 +0000 Subject: [Koha-bugs] [Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name In-Reply-To: <bug-6508-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6508-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6508-70-iJC16pCSX1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr --- Comment #9 from Séverine Queune <severine.queune at bulac.fr> --- (In reply to Katrin Fischer from comment #8) > I agree with Martin that this doesn't add any additional information. > Does this tab really needs to be kept ? As Katrin said, it the only page where it's display, and we have and alert at the top of the page showing the total amount of charges, with 2 useful action buttons. Isn't that enough ? > I have another suggestion: We could only show the tab when there are any > fines and charges. > This way, for libraries not using fines it will be a nicer display and the > tab appearing will have a meaning. > +1 if the tab is kept ! -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 12:09:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 11:09:07 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18936-70-4fFWDKlfkK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #89 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Josef Moravec from comment #88) Hi Josef, thanks for testing this! > I tested using git branch and found two issues: > > - holds per day are not transferred in database update Fixed! > - in note column, I can see link "view notes" even if there is no note Fixed! > - if the rule is specific for library and patron category, or for library > and itemtype, the rules for current checkouts allowed and current on-site > checkouts allowed are not transferred I do not recreate that. checkout master create specific rule for CPL and a given patron's category checkout bug_18936 update => I do see the value for current checkouts allowed > - No automatic renewal after (hard limit) does not respect dateformat and is > shown in iso format Fixed! > - Overdue fines cap (amount) is not possible to edit in GUI I do not recreate: Edit the line Modify the value for 'Overdue fines cap (amount)' Save => The value is correctly displayed in the table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 12:09:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 11:09:54 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18936-70-q9LK2dvjVK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94179|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 12:09:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 11:09:59 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18936-70-AkwGCvSIQE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94180|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 12:10:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 11:10:03 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18936-70-zUOOdiynaL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94181|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 12:10:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 11:10:07 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18936-70-AUtV36RBWQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94182|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 12:10:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 11:10:11 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18936-70-SLww6QhNVy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94183|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 12:10:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 11:10:14 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18936-70-L5MnTdAyLf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94184|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 12:10:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 11:10:18 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18936-70-ER0mWZMYa7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94185|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 12:10:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 11:10:21 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18936-70-NodzMIFiGR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94186|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 12:10:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 11:10:24 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18936-70-9YqSbv5qfC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94187|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 12:10:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 11:10:28 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18936-70-6WHu4Uj0sf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94188|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 12:10:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 11:10:32 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18936-70-wIky3ZssH7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94189|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 12:10:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 11:10:35 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18936-70-QvijO76p17@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94190|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 12:10:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 11:10:39 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18936-70-burTTueFMO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94191|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 12:10:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 11:10:42 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18936-70-fsD2eWlaYy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94192|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 12:10:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 11:10:46 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18936-70-qIKioFjNAw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94193|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 12:10:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 11:10:49 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18936-70-qlYnI4YHMz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94194|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 12:10:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 11:10:53 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18936-70-LlWl47gWXZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94195|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 12:10:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 11:10:56 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18936-70-7hcvAvAFHX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94196|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 12:11:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 11:11:00 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18936-70-ThogQbMfVZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94197|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 12:11:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 11:11:03 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18936-70-Lc88T9bqtR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94198|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 12:11:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 11:11:07 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18936-70-T7u8f5y0gW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94199|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 12:11:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 11:11:10 +0000 Subject: [Koha-bugs] [Bug 18936] Convert issuingrules fields to circulation_rules In-Reply-To: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18936-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18936-70-mK4UZ3FAC8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18936 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94200|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 12:12:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 11:12:30 +0000 Subject: [Koha-bugs] [Bug 14741] Selecting all child permissions doesn't select the top level check box In-Reply-To: <bug-14741-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14741-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14741-70-S5si3asiIj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14741 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master CC| |martin.renvoize at ptfs-europe | |.com --- Comment #6 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Thanks everyone, Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 12:13:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 11:13:52 +0000 Subject: [Koha-bugs] [Bug 23905] Button "Search to add" doesn't work on Quick add new patron In-Reply-To: <bug-23905-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23905-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23905-70-NaRbpaTomC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 12:16:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 11:16:28 +0000 Subject: [Koha-bugs] [Bug 23905] Button "Search to add" doesn't work on Quick add new patron In-Reply-To: <bug-23905-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23905-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23905-70-vcKrjpTsLj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95812|0 |1 is obsolete| | --- Comment #14 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95818 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95818&action=edit Bug 23905: Button "Search to add" doesn't work on Quick add new patron This issue is caused by duplicating the patron guarantor fieldset. The solution is to move it between the two forms insetad. In addition, this patch moves the guarantor information fieldset to the area below the "Quick add" fieldset, instead of *inside* it. This change preserves the correct styling and layout of the Guarantor information fieldset whilst it is moved back and forth by the "quick add"/"full form" toggle. Test Plan: 1) Quick add a child patron 2) Attempt to use the "Search to add" button 3) Note it does nothing 4) Apply this patch 5) Repeat steps 1 and 2 6) It works now! 7) Test toggling between the quick add and full form views, note the "Guarantor information" fieldset shows correctly in the full form view. Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 12:16:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 11:16:32 +0000 Subject: [Koha-bugs] [Bug 23905] Button "Search to add" doesn't work on Quick add new patron In-Reply-To: <bug-23905-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23905-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23905-70-vprPASKgsH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95813|0 |1 is obsolete| | --- Comment #15 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95819 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95819&action=edit Bug 23905: Remove extra closing span Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 12:16:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 11:16:54 +0000 Subject: [Koha-bugs] [Bug 23905] Button "Search to add" doesn't work on Quick add new patron In-Reply-To: <bug-23905-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23905-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23905-70-oAD60rnDic@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Looks good to me, thanks guys.. PQA and Pushing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 12:17:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 11:17:13 +0000 Subject: [Koha-bugs] [Bug 23905] Button "Search to add" doesn't work on Quick add new patron In-Reply-To: <bug-23905-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23905-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23905-70-Ohgr198yrX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 12:17:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 11:17:15 +0000 Subject: [Koha-bugs] [Bug 23905] Button "Search to add" doesn't work on Quick add new patron In-Reply-To: <bug-23905-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23905-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23905-70-xw0R7KZAsf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 --- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 12:26:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 11:26:46 +0000 Subject: [Koha-bugs] [Bug 17179] Advanced editor: Add keyboard shortcuts to repeat (duplicate) a field, and cut text In-Reply-To: <bug-17179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17179-70-xxaEtc8lcY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Text to go in the|Sponsored by: Round Rock |This patchset introduces an release notes|Public Library |internal clipboard to the | |advanced editor and | |provides some new | |functionality to make use | |of it; The following | |default shortcuts are | |provided but can be edited | |as per bug 21411. | | | |Changed: | |* `Ctrl-X`: Now cuts a line | |into the clipboard area | |* | |`Shift-Ctrl-X`: Now cuts | |current subfield into | |clipboard area | | | |Added: | |* | |`Ctrl-C`: Copies a line | |into the clipboard area | |* | |`Shift-Ctrl-C`: Copies | |current subfield into | |clipboard area | |* `Ctrl-P`: | |Pastes the selected item | |from the clipboard at | |cursor | |* `Ctrl-I`: Copies | |the current line and | |inserts onto a new line | |below -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 12:27:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 11:27:21 +0000 Subject: [Koha-bugs] [Bug 17179] Advanced editor: Add keyboard shortcuts to repeat (duplicate) a field, and cut text In-Reply-To: <bug-17179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17179-70-AsLqCTGxWf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 --- Comment #27 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Added text for the release notes and moved the sponsored by details into a follow-up commit which has been pushed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 12:32:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 11:32:42 +0000 Subject: [Koha-bugs] [Bug 14697] Extend and enhance "Claims returned" lost status In-Reply-To: <bug-14697-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14697-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14697-70-mVxzsQfWZt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement extends |This enhancement extends release notes|the "Claims returned" lost |the "Claims returned" lost |status and allows staff to |status and allows staff to |track items that patrons |track items that patrons |claim to have returned. |claim to have returned. |Items are marked as "Claims |Items are marked as "Claims |returned" from the checkout |returned" from the checkout |page in the staff side. |page in the staff side. |There are 3 new systems | |preferences to set for this |There are 3 new systems |functionality to work. |preferences to set for this |Sponsored by: Fargo Public |functionality to work: |Library |`ClaimReturnedChargeFee`, | |`ClaimReturnedLostValue` | |and | |`ClaimReturnedWarningThresh | |old` -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 12:33:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 11:33:01 +0000 Subject: [Koha-bugs] [Bug 14697] Extend and enhance "Claims returned" lost status In-Reply-To: <bug-14697-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14697-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14697-70-oH2jC6CgxF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 --- Comment #77 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Added sponsor details to follow-up commit -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 12:37:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 11:37:16 +0000 Subject: [Koha-bugs] [Bug 23626] Add a system preference to limit the number of rows of data used when charting or exporting report results In-Reply-To: <bug-23626-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23626-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23626-70-HkNV3iIfqf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23626 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Sponsored and written by | release notes|HELM/FLO | --- Comment #52 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Moved sponsorship detail to a git follow-up for the release notes (and about page) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 12:39:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 11:39:48 +0000 Subject: [Koha-bugs] [Bug 23624] Count rows in report without (potentially) consuming all memory In-Reply-To: <bug-23624-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23624-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23624-70-MEMwLowZ4R@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23624 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Sponsored and written by | release notes|HELM/FLO | --- Comment #27 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Moved sponsorship into a git followup commit ensuring it appears in the release notes and on the about page. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 12:41:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 11:41:45 +0000 Subject: [Koha-bugs] [Bug 22445] Ability to define a URL for custom cover images In-Reply-To: <bug-22445-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22445-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22445-70-HfZ9KwaiEn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22445 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This development adds the |This development adds the release notes|ability to use alternative |ability to use alternative |cover art providers who |cover art providers who |provide covers openly via |provide covers openly via |consistent URLs. Three new |consistent URLs. |system preferences are |Three new |introduced, |system preferences are |`CustomCoverImagesURL`, |introduced, |`CustomCoverImages` and |`CustomCoverImagesURL`, |`OPACCustomCoverImages`. |`CustomCoverImages` and | |`OPACCustomCoverImages`. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 12:42:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 11:42:47 +0000 Subject: [Koha-bugs] [Bug 21574] Local use system preferences page doesn't have the system preferences menu In-Reply-To: <bug-21574-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21574-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21574-70-J55HKXzekA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21574 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Attachment #95620|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 12:44:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 11:44:31 +0000 Subject: [Koha-bugs] [Bug 21574] Local use system preferences page doesn't have the system preferences menu In-Reply-To: <bug-21574-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21574-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21574-70-Dxa6cxGWKA@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21574 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 12:44:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 11:44:33 +0000 Subject: [Koha-bugs] [Bug 21574] Local use system preferences page doesn't have the system preferences menu In-Reply-To: <bug-21574-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21574-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21574-70-2D5wsSqTPB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21574 --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 12:46:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 11:46:15 +0000 Subject: [Koha-bugs] [Bug 23256] fr-CA OPAC_REG_VERIFY has hard-coded http:// In-Reply-To: <bug-23256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23256-70-Rj3OC27glx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23256 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 12:46:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 11:46:17 +0000 Subject: [Koha-bugs] [Bug 23256] fr-CA OPAC_REG_VERIFY has hard-coded http:// In-Reply-To: <bug-23256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23256-70-XCCvblNP8h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23256 --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 12:46:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 11:46:19 +0000 Subject: [Koha-bugs] [Bug 23452] Multiple select options in system preferences are not translatable In-Reply-To: <bug-23452-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23452-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23452-70-J1twxvwnI4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23452 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 12:46:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 11:46:21 +0000 Subject: [Koha-bugs] [Bug 23452] Multiple select options in system preferences are not translatable In-Reply-To: <bug-23452-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23452-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23452-70-0QCmwzjOwP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23452 --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 12:48:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 11:48:19 +0000 Subject: [Koha-bugs] [Bug 24076] Remove inline CSS to center patron home library in search results In-Reply-To: <bug-24076-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24076-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24076-70-rRTGf4Fcr9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24076 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 12:48:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 11:48:21 +0000 Subject: [Koha-bugs] [Bug 24076] Remove inline CSS to center patron home library in search results In-Reply-To: <bug-24076-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24076-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24076-70-BvPfIq1wzH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24076 --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 12:49:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 11:49:32 +0000 Subject: [Koha-bugs] [Bug 23905] Button "Search to add" doesn't work on Quick add new patron In-Reply-To: <bug-23905-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23905-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23905-70-rfsPhjzRKH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23905 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_19_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 12:51:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 11:51:07 +0000 Subject: [Koha-bugs] [Bug 18928] Move `holdallowed`, `hold_fulfillment_policy` and `returnbranch` into the `circulation_rules` table. In-Reply-To: <bug-18928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18928-70-GwDpsJx0ML@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Reports Note: This changes |**Reports Note**: This release notes|the database schema, |changes the database |reports referencing the |schema, reports referencing |`default_branch_circ_rules` |the |, `default_circ_rules`, |`default_branch_circ_rules` |`default_branch_item_rules` |, `default_circ_rules`, |or `branch_item_rules` |`default_branch_item_rules` |tables will need to be |or `branch_item_rules` |updated |tables will need to be | |updated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 12:51:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 11:51:27 +0000 Subject: [Koha-bugs] [Bug 18930] Move 'refund lost item fee rules' into the `circulation_rules` table In-Reply-To: <bug-18930-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18930-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18930-70-G3dzKtca9s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18930 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Reports note: This changes |**Reports note**: This release notes|the database schema, |changes the database |reports referencing the |schema, reports referencing |`refund_lost_item_fee_rules |the |` table will need to be |`refund_lost_item_fee_rules |updated |` table will need to be | |updated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 12:51:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 11:51:50 +0000 Subject: [Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes In-Reply-To: <bug-22563-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22563-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22563-70-Jl1wuyGRvW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Reports Note: The |**Reports Note**: The release notes|`accounttype` for lost item |`accounttype` for lost item |fees has been updated from |fees has been updated from |'L' to 'LOST' and for lost |'L' to 'LOST' and for lost |item returned credits it |item returned credits it |has been updated from 'CR' |has been updated from 'CR' |to 'LOST_RETURNED'. The |to 'LOST_RETURNED'. The |`status` field is now used |`status` field is now used |to track the reason why an |to track the reason why an |'OVERDUE' fee has stopped |'OVERDUE' fee has stopped |incrementing and it may |incrementing and it may |include 'LOST' |include 'LOST' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 12:57:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 11:57:52 +0000 Subject: [Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status In-Reply-To: <bug-17168-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17168-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17168-70-85YNSWPAtS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|These patches introduce a |These patches introduce a release notes|new script to replace the |new script to replace the |j2a.pl script with a more |`j2a.pl` script with a more |flexible set of options. |flexible set of options. | | |misc/cronjobs/update_patron |`misc/cronjobs/update_patro |s_category.pl |ns_category.pl` can now be |Can now be |used to update patrons who |used to update patrons who |are older or younger than |are older or younger than |their patron categories to |theri patron categories to |a category chosen by the |a category chosen by the |user. |user. | | |Additionally, this |Additionally this |script allows users to |script allows users to |specify a fine total to |specify a fine total to |update patrons, to use any |update patrons, to use any |specified borrowers field, |specified borrowers field, |and to run by category |and to run by category |and/or branch. |and/or branch. | | |The |The |intention here is to assist |intention here is to assist |in automating updating |in automating updating |patrons for schools or |patrons for schools or |libraries where patrons are |libraries where patrons are |regularly changed - patrons |regularly changed - patrons |with fines can be moved to |with fine can be moved to |'probational statuses' or |'probational statuses' or |patrons without fines can |patrons without fines can |be moved to 'privileged |be moved to 'privileged' |statuses'. |statuses. | | |The flexibility |The flexibility |should allow for various |should allow for various |workflows to be automated |workflows to be automated |via cronjob. |via cronjob | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 12:59:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 11:59:15 +0000 Subject: [Koha-bugs] [Bug 24116] New: Grab this amazing opportunity and get up to 60-80% discount on Kaspersky Products on this Black Friday. Message-ID: <bug-24116-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24116 Bug ID: 24116 Summary: Grab this amazing opportunity and get up to 60-80% discount on Kaspersky Products on this Black Friday. Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: shiragranger4 at gmail.com QA Contact: testopia at bugs.koha-community.org Along with a developing world, all people are accessing the Internet and all want the best security protection against malware and cyber threats to your device. On this Kaspersky Black Friday Sale 2019, you will get the biggest discount offer on its latest Antivirus Software. Grab this amazing opportunity and get up to 60-80% discount on Kaspersky Products on this Black Friday. Much more info - https://www.webtoolsoffers.com/kaspersky-black-friday-sale.html -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 13:00:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 12:00:13 +0000 Subject: [Koha-bugs] [Bug 24116] Grab this amazing opportunity and get up to 60-80% discount on Kaspersky Products on this Black Friday. In-Reply-To: <bug-24116-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24116-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24116-70-WFuoE982Hc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24116 webtoolsoffers <shiragranger4 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://www.webtoolsoffers. | |com/kaspersky-black-friday- | |sale.html -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 13:01:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 12:01:22 +0000 Subject: [Koha-bugs] [Bug 23346] Add without-db-name parameter to koha-dump In-Reply-To: <bug-23346-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23346-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23346-70-ZJJLVU72ld@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23346 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement is the release notes| |first step in allowing a | |koha database dump file to | |be restored into another | |koha instance. | | | |One can now | |pass the | |`--without-db-name` option | |to `koha-dump` to attain a | |zipped sql dump with no | |longer contains the `CREATE | |DATABASE` and `USE` | |statements within the | |restore file. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 13:05:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 12:05:21 +0000 Subject: [Koha-bugs] [Bug 6759] Use a different account type for account renewals than for new accounts In-Reply-To: <bug-6759-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6759-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6759-70-b3BCinwzoB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6759 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement makes release notes| |account renewal charges | |distinct from initial | |account registration | |charges. | | | |**Reports note**: | |Prior to this patch both | |account creations and | |account renewals would | |result in an accountline | |with accounttype `A`; After | |this patch account | |creations will result in an | |accountline with | |accounttype `ACCOUNT` and | |account renewals will | |result in ana ccountline | |with accounttype | |`ACCOUNT_RENEW`. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 13:06:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 12:06:34 +0000 Subject: [Koha-bugs] [Bug 22627] Rephrase 'your fines and charges' tab in OPAC In-Reply-To: <bug-22627-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22627-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22627-70-jofoQbxa9r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22627 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Rephrase 'your fines' tab |Rephrase 'your fines and |in OPAC |charges' tab in OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 13:08:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 12:08:12 +0000 Subject: [Koha-bugs] [Bug 23049] Replace MANUAL_INV authorised value with a dedicated table In-Reply-To: <bug-23049-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23049-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23049-70-Sjz6FjmsBU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23049 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This patchset moves the |This patchset moves the release notes|'MANUAL_INV' authorized |`MANUAL_INV` authorized |values into their own table |values into their own table |and adds in interface into |and adds an interface into |the administration pages to |the administration pages to |allow addition and |allow the addition and |modification of such |modification of such |account types. |account types. | | |This serves |This serves |as the foundation for |as the foundation for |enhancing the accounts |enhancing the accounts |system and leads to clearer |system and leads to clearer |code and more consistent |code and more consistent |data via database-level |data via database-level |constraints. |constraints. | | |Note: Reports |**Reports |will need to be updated to |note**: Reports will need |look in the new |to be updated to look in |debit_type_code field for |the new debit_type_code |accountlines of type |field for accountlines of |'debit' and use the updated |type 'debit' and use the |coded values. |updated coded values. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 13:10:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 12:10:18 +0000 Subject: [Koha-bugs] [Bug 23214] OPAC add ability to pay guarantees fines In-Reply-To: <bug-23214-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23214-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23214-70-tVWR5QnJsK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23214 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 13:11:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 12:11:26 +0000 Subject: [Koha-bugs] [Bug 23805] Add a dedicated credit_types table In-Reply-To: <bug-23805-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23805-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23805-70-M46aln8XGN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This patchset moves the |This patchset moves the release notes|remaining accounttypes, all |remaining accounttypes, all |of which should be credits |of which should be credits |after bug 23049, into their |after bug 23049, into their |own table. |own table. | | |This serves as |This serves as |the foundation for |the foundation for |enhancing the accounts |enhancing the accounts |system and leads to clearer |system and leads to clearer |code and more consistent |code and more consistent |data via database-level |data via database-level |constraints. |constraints. | | |Note: Reports |**Reports |will need to be updated to |note**: Reports will need |look in the new |to be updated to look in |credit_type_code field for |the new credit_type_code |accountlines of type |field for accountlines of |'credit' and use the |type 'credit' and use the |updated coded values. |updated coded values. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 13:15:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 12:15:58 +0000 Subject: [Koha-bugs] [Bug 15260] Option for extended loan with useDaysMode In-Reply-To: <bug-15260-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15260-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15260-70-L9ZdMdAJSf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15260 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|The useDaysMode system |The `useDaysMode` system release notes|preference has been |preference has been |enhanced to include an |enhanced to include an |additional option. This |additional option. |allows libraries to dictate | |that if the library is |This |closed on the usual due |allows libraries to dictate |date, the loan period |that if the library is |should be pushed forward to |closed on the usual due |the next open day which is |date, the loan period |the same day of the week. |should be pushed forward to |For example - if an item |the next open day which is |should be due back on a |the same day of the week. |Tuesday but that particular | |Tuesday is closed, then |For example : If an item |instead of it being due |should be due back on a |back the Wednesday (usual |Tuesday but that particular |behaviour when due date is |Tuesday is closed, then |pushed forward to next open |instead of it being due |day), it would actually be |back the Wednesday (usual |due back the next available |behaviour when due date is |open Tuesday. |pushed forward to next open |To note that |day), it would actually be |this preference setting |due back the next available |only works in multiples of |open Tuesday. |7. | | |**Note**: | |This preference setting | |only works in multiples of | |7. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 13:17:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 12:17:41 +0000 Subject: [Koha-bugs] [Bug 18084] Language selector is hidden in user menu on mobile interfaces In-Reply-To: <bug-18084-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18084-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18084-70-0h3xYnwUkG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18084 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Language selector hidden in |Language selector is hidden |user menu on mobile |in user menu on mobile |interfaces |interfaces CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 13:17:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 12:17:48 +0000 Subject: [Koha-bugs] [Bug 18084] Language selector is hidden in user menu on mobile interfaces In-Reply-To: <bug-18084-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18084-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18084-70-raxaOzQ4M3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18084 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 13:19:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 12:19:06 +0000 Subject: [Koha-bugs] [Bug 23648] The logged in link (class "loggedinusername") needs data-patroncategory In-Reply-To: <bug-23648-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23648-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23648-70-YuaSiN0lDO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23648 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 13:20:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 12:20:05 +0000 Subject: [Koha-bugs] [Bug 23537] Overdrive won't show complete results if the Overdrive object doesn't have a primaryCreator In-Reply-To: <bug-23537-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23537-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23537-70-NS3HFBPUiY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23537 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 13:20:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 12:20:28 +0000 Subject: [Koha-bugs] [Bug 23492] OPAC search facet header should not be a link at larger browser widths In-Reply-To: <bug-23492-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23492-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23492-70-ZPrKl1Gd2O@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23492 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 13:21:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 12:21:22 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: <bug-14570-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14570-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14570-70-RMAJhqu6J1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 13:22:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 12:22:39 +0000 Subject: [Koha-bugs] [Bug 21390] Self registration verification emails should send immediately In-Reply-To: <bug-21390-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21390-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21390-70-k0C37yYoGY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21390 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Send self registration |Self registration |verification emails |verification emails should |immediately |send immediately Severity|enhancement |normal -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 13:22:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 12:22:56 +0000 Subject: [Koha-bugs] [Bug 23697] Add auto complete for patron search in patron module In-Reply-To: <bug-23697-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23697-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23697-70-bFBuAxgBYy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23697 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Auto complete for patron |Add auto complete for |search in patron module |patron search in patron | |module -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 13:27:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 12:27:21 +0000 Subject: [Koha-bugs] [Bug 23697] Add auto complete for patron search in patron module In-Reply-To: <bug-23697-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23697-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23697-70-u7MboL0nAX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23697 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds an release notes| |optional auto-complete | |function to the patron | |search field when in the | |patrons module. | | | |We rename | |the `CircAutocompl` system | |preference to | |`PatronAutoComplete` and | |use it for both functions. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 13:28:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 12:28:04 +0000 Subject: [Koha-bugs] [Bug 23230] Make Koha::Plugins::Base::_version_compare OO In-Reply-To: <bug-23230-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23230-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23230-70-Eqxm93oH5w@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23230 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Plugin architecture |Architecture, internals, | |and plumbing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 13:28:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 12:28:44 +0000 Subject: [Koha-bugs] [Bug 24117] New: Patron does not get debarred upon returning overdue item if syspref item-level_itypes is set to biblio and item does not have type information Message-ID: <bug-24117-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24117 Bug ID: 24117 Summary: Patron does not get debarred upon returning overdue item if syspref item-level_itypes is set to biblio and item does not have type information Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: pjamorim91 at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com To reproduce: 1) Have item-level_itypes sys pref set to "biblio" 2) Return an overdue item which biblio record has correct type information but item itself does not (which should be fine because 1)) 3) Notice that the item is returned just fine, but the patron does not get debarred, respecting circulation rules correctly configured. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 13:37:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 12:37:47 +0000 Subject: [Koha-bugs] [Bug 23214] OPAC add ability to pay guarantees fines In-Reply-To: <bug-23214-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23214-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23214-70-pgHAbv6JrZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23214 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Fines and fees |OPAC -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 13:38:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 12:38:41 +0000 Subject: [Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon that can inject item status MARC subfields In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13937-70-YiwP5iWu14@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Architecture, internals, |Z39.50 / SRU / OpenSearch |and plumbing |Servers -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 13:39:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 12:39:58 +0000 Subject: [Koha-bugs] [Bug 23228] Add option to automatically display payment receipt for printing after making a payment In-Reply-To: <bug-23228-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23228-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23228-70-GakhSVgAeh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23228 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Patrons |Fines and fees -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 13:43:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 12:43:45 +0000 Subject: [Koha-bugs] [Bug 6508] Show indication of existing 'Fines & Charges' on tab of the same name In-Reply-To: <bug-6508-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-6508-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-6508-70-cfB8jyhJhr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=6508 --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- +1 to just getting rid of it. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 13:44:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 12:44:37 +0000 Subject: [Koha-bugs] [Bug 24117] Patron does not get debarred upon returning overdue item if syspref item-level_itypes is set to biblio and item does not have type information In-Reply-To: <bug-24117-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24117-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24117-70-yIZSqkdrgI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24117 --- Comment #1 from Pedro Amorim <pjamorim91 at gmail.com> --- Created attachment 95820 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95820&action=edit Bugfix commit -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 13:46:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 12:46:12 +0000 Subject: [Koha-bugs] [Bug 9993] On editing basket group delivery place resets to logged in branch In-Reply-To: <bug-9993-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9993-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9993-70-zU6OsNZmZI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9993 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 13:46:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 12:46:14 +0000 Subject: [Koha-bugs] [Bug 9993] On editing basket group delivery place resets to logged in branch In-Reply-To: <bug-9993-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9993-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9993-70-CHy0KxOojF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9993 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95622|0 |1 is obsolete| | --- Comment #8 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 95821 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95821&action=edit Bug 9993: On editing basket group delivery place resets to logged in branch This patch modifies basketgroups.pl so that existing data about a basket group's billing and delivery place are correctly preselected in the edit form. These fields shouldn't reset to the logged-in user's home branch just because they have an empty value. To test, apply the patch and go to Acquisitions -> Vendor -> Basket groups. When adding or editing a basket group the pre-selected value for "Billing place" and "Delivery place" should be correct: - When creating a new basket group: The logged-in user's library should be pre-selected. - When editing a basket group which has a library defined for either the billing or delivery places, the correct library should be pre-selected. - When editing a basket group which has no library defined for either the billing or delivery place there should be no library pre-selected (the "--" option should be pre-selected). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 13:48:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 12:48:16 +0000 Subject: [Koha-bugs] [Bug 24117] Patron does not get debarred upon returning overdue item if syspref item-level_itypes is set to biblio and item does not have type information In-Reply-To: <bug-24117-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24117-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24117-70-uoHhQLVz8w@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24117 --- Comment #2 from Pedro Amorim <pjamorim91 at gmail.com> --- Created attachment 95822 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95822&action=edit Proposed fix for reported bug -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 13:49:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 12:49:21 +0000 Subject: [Koha-bugs] [Bug 24117] Patron does not get debarred upon returning overdue item if syspref item-level_itypes is set to biblio and item does not have type information In-Reply-To: <bug-24117-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24117-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24117-70-eYlk9PoYL2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24117 Pedro Amorim <pjamorim91 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95820|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 13:52:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 12:52:02 +0000 Subject: [Koha-bugs] [Bug 24116] SPAM In-Reply-To: <bug-24116-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24116-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24116-70-wNHZ3jCelR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24116 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Grab this amazing |SPAM |opportunity and get up to | |60-80% discount on | |Kaspersky Products on this | |Black Friday. | CC| |katrin.fischer at bsz-bw.de Resolution|--- |INVALID Status|NEW |RESOLVED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 13:53:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 12:53:48 +0000 Subject: [Koha-bugs] [Bug 24117] Patron does not get debarred upon returning overdue item if syspref item-level_itypes is set to biblio and item does not have type information In-Reply-To: <bug-24117-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24117-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24117-70-AZdxPiShq8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24117 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 13:57:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 12:57:36 +0000 Subject: [Koha-bugs] [Bug 23274] t/db_dependent/XISBN.t fails with Elasticsearch In-Reply-To: <bug-23274-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23274-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23274-70-9e99tegyoj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23274 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 13:57:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 12:57:39 +0000 Subject: [Koha-bugs] [Bug 23274] t/db_dependent/XISBN.t fails with Elasticsearch In-Reply-To: <bug-23274-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23274-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23274-70-3CnwalQItl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23274 --- Comment #2 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95823 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95823&action=edit Bug 23274: Mock simple_search_compat to cover both search engines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 14:00:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 13:00:37 +0000 Subject: [Koha-bugs] [Bug 24118] New: Allow to set time for publication and expiration of news entries Message-ID: <bug-24118-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24118 Bug ID: 24118 Summary: Allow to set time for publication and expiration of news entries Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: katrin.fischer at bsz-bw.de QA Contact: testopia at bugs.koha-community.org Currently the appearance and disappearance of news entries can be controlled by setting the publication and expiration dates. It would be nice if not only the date, but also a time could be set. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 14:01:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 13:01:31 +0000 Subject: [Koha-bugs] [Bug 24119] New: Records indexed into ES during tests are not removed by rollback Message-ID: <bug-24119-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24119 Bug ID: 24119 Summary: Records indexed into ES during tests are not removed by rollback Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Test Suite Assignee: chris at bigballofwax.co.nz Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org If SearchEngine is set to Elasticsearch we index bibs directly into the engine. This means that a rollback won't remove these records. Zebra only indexes from the zebraqueue which is in DB so is protected by transactions -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 14:01:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 13:01:50 +0000 Subject: [Koha-bugs] [Bug 23274] t/db_dependent/XISBN.t fails with Elasticsearch In-Reply-To: <bug-23274-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23274-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23274-70-GZuwRQbXfi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23274 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com --- Comment #3 from Nick Clemens <nick at bywatersolutions.com> --- Testing here did highlight bug 24119 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 14:02:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 13:02:04 +0000 Subject: [Koha-bugs] [Bug 19821] Run tests on a separate database In-Reply-To: <bug-19821-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19821-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19821-70-8udh8M9Rda@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19821 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24119 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 14:02:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 13:02:04 +0000 Subject: [Koha-bugs] [Bug 24119] Records indexed into ES during tests are not removed by rollback In-Reply-To: <bug-24119-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24119-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24119-70-JuPRptJtXP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24119 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19821 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 14:07:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 13:07:53 +0000 Subject: [Koha-bugs] [Bug 11500] Use dateformat syspref and datepicker on additems.pl (and other item cataloguing pages) In-Reply-To: <bug-11500-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11500-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11500-70-zJnFKDit7q@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11500 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 14:07:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 13:07:56 +0000 Subject: [Koha-bugs] [Bug 11500] Use dateformat syspref and datepicker on additems.pl (and other item cataloguing pages) In-Reply-To: <bug-11500-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11500-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11500-70-owXALUDI15@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11500 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95732|0 |1 is obsolete| | --- Comment #3 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 95824 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95824&action=edit Bug 11500: Use dateformat syspref and datepicker on additems.pl (and other item cataloguing pages) This patch modifies the cataloging plugin dateaccessioned.pl so that it triggers the addition of a datepicker widget to fields it is linked with. Despite its name the plugin can be used on any item field which requires a date. To test, apply the patch and make sure you have one or more item subfields linked to the dateaccessioned.pl plugin. For instance, in MARC21: - Administration -> MARC bibliographic framework -> MARC structure -> 952 -> Edit subfields: - subfields d ("Date acquired") and w ("Price effective from"): - Other options -> Plugin -> dateaccessioned.pl - Go to cataloging and add or edit an item on a bibliographic record - The "Date acquired" and "Price effective from" fields should be styled as datepickers. - Clicking in these fields should populate the field with today's date and trigger the datepicker popup. - Test that all the datepicker features work correctly. - Test that manual entry of a date works. - With the AcqCreateItem system preference set to "placing an order," go to Acquisitions -> Vendor -> Add to basket. - Add a title to your basket using your preferred method. - In the "New order" form, find the section for adding an item. - Test the "Date acquired" and "Price effective from" fields, which should behave just like they did in the cataloging module. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 14:15:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 13:15:48 +0000 Subject: [Koha-bugs] [Bug 23276] Don't show tags on tag cloud when tagging is disabled In-Reply-To: <bug-23276-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23276-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23276-70-F00jAQtDVZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23276 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95750|0 |1 is obsolete| | --- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95825 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95825&action=edit Bug 23276: Do not display tag if pref TagsEnabled is off If the pref TagsEnabled is off we should not display the tags at the OPAC. There is a message to tell that tags system is disabled, but the tags are displayed. This patch introduces the blocking_errors include file at the OPAC. Test plan: - Turn TagsEnabled on - Add some tags - Turn TagsEnabled off - Hit /cgi-bin/koha/opac-tags.pl => Without this patch you see a warning messaging saying that the tag system is disabled, but the tags are displayed => With this patch you see a (ugly) short screen saying that the tag system is disabled. Signed-off-by: David Nind <david at davidnind.com> Signed-off-by: Katrin Fischer <katrin.fischer.83 at web.de> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 14:16:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 13:16:03 +0000 Subject: [Koha-bugs] [Bug 23276] Don't show tags on tag cloud when tagging is disabled In-Reply-To: <bug-23276-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23276-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23276-70-QfI15mRD4s@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23276 --- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I removed a debug statement. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 14:19:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 13:19:20 +0000 Subject: [Koha-bugs] [Bug 24120] New: Search terms in search dropdown must be URI filtered Message-ID: <bug-24120-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24120 Bug ID: 24120 Summary: Search terms in search dropdown must be URI filtered Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org To recreate: 1 - Search for C++ 2 - Sort your results 3 - Note search is now for "C " -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 14:20:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 13:20:12 +0000 Subject: [Koha-bugs] [Bug 24120] Search terms in search dropdown must be URI filtered In-Reply-To: <bug-24120-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24120-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24120-70-Ixz02QvPJg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24120 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |21526 CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21526 [Bug 21526] TT variables used to build a link should be uri filtered -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 14:20:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 13:20:12 +0000 Subject: [Koha-bugs] [Bug 21526] TT variables used to build a link should be uri filtered In-Reply-To: <bug-21526-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21526-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21526-70-ZlxGQQcHy6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21526 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24120 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24120 [Bug 24120] Search terms in search dropdown must be URI filtered -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 14:21:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 13:21:17 +0000 Subject: [Koha-bugs] [Bug 24120] Search terms in search dropdown must be URI filtered In-Reply-To: <bug-24120-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24120-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24120-70-JOS2Yh5lA3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24120 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 14:21:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 13:21:19 +0000 Subject: [Koha-bugs] [Bug 24120] Search terms in search dropdown must be URI filtered In-Reply-To: <bug-24120-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24120-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24120-70-pFbs8QWJDv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24120 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95826 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95826&action=edit Bug 24120: URI filter search terms in sort dropdowns To test: 1 - Search for C++ 2 - Sort your results 3 - Note search is now for "C " 4 - Apply patch 5 - Search for C++ 6 - Reorder results 7 - Still searching for C++ -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 14:22:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 13:22:48 +0000 Subject: [Koha-bugs] [Bug 24121] New: Item types icons not showing in intra search results if item-level_itypes syspref is set to biblio Message-ID: <bug-24121-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 Bug ID: 24121 Summary: Item types icons not showing in intra search results if item-level_itypes syspref is set to biblio Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: koha-bugs at lists.koha-community.org Reporter: pjamorim91 at gmail.com QA Contact: testopia at bugs.koha-community.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 14:25:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 13:25:26 +0000 Subject: [Koha-bugs] [Bug 24121] Item types icons not showing in intra search results if item-level_itypes syspref is set to biblio In-Reply-To: <bug-24121-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24121-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24121-70-bRBF7ysx0M@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 --- Comment #1 from Pedro Amorim <pjamorim91 at gmail.com> --- Created attachment 95827 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95827&action=edit Fix for knowing correct interface (opac or intra) when requesting itemtype icons -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 14:26:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 13:26:22 +0000 Subject: [Koha-bugs] [Bug 24121] Item types icons not showing in intra search results if item-level_itypes syspref is set to biblio In-Reply-To: <bug-24121-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24121-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24121-70-63x89ZEZIP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 --- Comment #2 from Pedro Amorim <pjamorim91 at gmail.com> --- Itemtype icons in intra search results are pointing to opac image path, this patch fixes that. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 14:29:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 13:29:36 +0000 Subject: [Koha-bugs] [Bug 18170] Show damaged status on check-in In-Reply-To: <bug-18170-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18170-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18170-70-O9K47elaiR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18170 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #1 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- +1 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 14:32:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 13:32:13 +0000 Subject: [Koha-bugs] [Bug 24120] Search terms in search dropdown must be URI filtered In-Reply-To: <bug-24120-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24120-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24120-70-nNCh6ivhtQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24120 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off CC| |tomascohen at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 14:32:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 13:32:15 +0000 Subject: [Koha-bugs] [Bug 24120] Search terms in search dropdown must be URI filtered In-Reply-To: <bug-24120-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24120-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24120-70-xsabF1oIuW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24120 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95826|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 14:32:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 13:32:44 +0000 Subject: [Koha-bugs] [Bug 24120] Search terms in search dropdown must be URI filtered In-Reply-To: <bug-24120-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24120-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24120-70-YYWUAf6stt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24120 --- Comment #2 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 95828 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95828&action=edit Bug 24120: URI filter search terms in sort dropdowns To test: 1 - Search for C++ 2 - Sort your results 3 - Note search is now for "C " 4 - Apply patch 5 - Search for C++ 6 - Reorder results 7 - Still searching for C++ Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 14:33:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 13:33:37 +0000 Subject: [Koha-bugs] [Bug 10352] Cataloguing log search mixing itemnumber/bibnumber In-Reply-To: <bug-10352-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10352-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10352-70-Me5t1tyIgX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10352 Kelly McElligott <kelly at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly at bywatersolutions.com --- Comment #19 from Kelly McElligott <kelly at bywatersolutions.com> --- I have gone through the test plan, and I would like to understand step 10 a bit more. From the user's perspective, go to the modification log from one bib (bib 59) and see you are getting bib# x and Item #y, but then hitting Submit (never leaving the log page) will retrieve results will get a different "object". No other parameters changed in the system log filter such as Module, Object, Action. How would the user understand the difference? There is a lot of logic that is happening behind the scenes that the user doesn't know. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 14:42:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 13:42:41 +0000 Subject: [Koha-bugs] [Bug 23276] Don't show tags on tag cloud when tagging is disabled In-Reply-To: <bug-23276-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23276-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23276-70-lI74J0h7mc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23276 --- Comment #10 from Owen Leonard <oleonard at myacpl.org> --- I think it would be better to remove the in-page message altogether and trigger a 404 if tagging is disabled and the user navigates directly to opac-tags.pl. This is what we do with opac-topissues.pl and opac-suggestions.pl. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 14:56:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 13:56:39 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15522-70-JqWz2KFyET@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Patch doesn't apply |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 14:56:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 13:56:43 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15522-70-NkUTOvtPBl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94208|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 14:56:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 13:56:46 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15522-70-UT8TClo1AM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94201|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 14:56:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 13:56:50 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15522-70-S8XfbjP8NI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94202|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 14:56:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 13:56:54 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15522-70-HEDSFOIuZl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94203|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 14:56:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 13:56:57 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15522-70-9dMl8m7Myw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94204|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 14:57:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 13:57:01 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15522-70-w8wFgwWeAk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94205|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 14:57:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 13:57:04 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15522-70-aN6EiXLOKe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94206|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 14:57:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 13:57:08 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15522-70-Ngwf75Cggv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #94207|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 15:00:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 14:00:32 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15522-70-MkgXZkXKGk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 --- Comment #41 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Rebased patches are on the remote branch. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 15:03:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 14:03:10 +0000 Subject: [Koha-bugs] [Bug 24122] New: Typo in administration.rst Message-ID: <bug-24122-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24122 Bug ID: 24122 Summary: Typo in administration.rst Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: trivial Priority: P5 - low Component: Documentation Assignee: koha-bugs at lists.koha-community.org Reporter: alexander.borkowski at kau.se QA Contact: testopia at bugs.koha-community.org Created attachment 95829 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95829&action=edit Patch to fix the typo There is a typo in the Administration / Defining circulation rules section of the manual (source/administration.rst, "Exampple" instead of "Example"), patch attached. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 15:06:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 14:06:53 +0000 Subject: [Koha-bugs] [Bug 23706] Item search CSV export doesn't include collection code In-Reply-To: <bug-23706-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23706-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23706-70-w1SBg85Hmh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23706 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m --- Comment #14 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- (In reply to David Roberts from comment #11) > Actually, it looks like this might have already been fixed in > https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22424 Indeed this bug made the change. So fixed since 19.05.x ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 15:07:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 14:07:29 +0000 Subject: [Koha-bugs] [Bug 24120] Search terms in search dropdown must be URI filtered In-Reply-To: <bug-24120-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24120-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24120-70-39RcNllZQJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24120 --- Comment #3 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Why not QUERY_INPUT.input_name as well? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 15:08:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 14:08:58 +0000 Subject: [Koha-bugs] [Bug 24123] New: bulkmarcimport.pl doesn't support UTF-8 encoded MARCXML records Message-ID: <bug-24123-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24123 Bug ID: 24123 Summary: bulkmarcimport.pl doesn't support UTF-8 encoded MARCXML records Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Command-line Utilities Assignee: koha-bugs at lists.koha-community.org Reporter: joonas.kylmala at helsinki.fi QA Contact: testopia at bugs.koha-community.org CC: jonathan.druart at bugs.koha-community.org, robin at catalyst.net.nz Importing an UTF-8 encoded MARC21 MARCXML record that has leader value in position 09 equal 'a' (unicode) makes non-ascii characters like 'ä' to be replaced with character '�'. The command being run is > misc/migration_tools/bulkmarcimport.pl -biblios -file record.marcxml -m=MARCXML -v -v I tracked this problem down to the line > $MARC::File::XML::_load_args{BinaryEncoding} = 'utf-8'; If you add that line again as first thing in the RECORD label block further down in the bulkmarcimport.pl the problem is fixed. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 15:12:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 14:12:22 +0000 Subject: [Koha-bugs] [Bug 24120] Search terms in search dropdown must be URI filtered In-Reply-To: <bug-24120-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24120-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24120-70-frUhb3zETf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24120 --- Comment #4 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95830 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95830&action=edit Bug 24120: (follow-up) input_name too -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 15:24:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 14:24:05 +0000 Subject: [Koha-bugs] [Bug 24122] Typo in administration.rst In-Reply-To: <bug-24122-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24122-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24122-70-WEn7aFMDnY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24122 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |david at davidnind.com, | |katrin.fischer at bsz-bw.de --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- Hi Alexander, the workflow for the manual is slightly different than the workflow for Koha itself. Could you maybe create merge request on gitlab instead? This would make it easier to integrate your contribution: https://wiki.koha-community.org/wiki/Editing_the_Koha_Manual https://gitlab.com/koha-community/koha-manual Also adding the Documentation manager in CC. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 15:30:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 14:30:42 +0000 Subject: [Koha-bugs] [Bug 23237] Add support for [% INCLUDE %] in plugin templates In-Reply-To: <bug-23237-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23237-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23237-70-kwTW5ajp2i@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23237 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|From a plugin template it |From a plugin template it release notes|is useful to be able to |is useful to include other |include other templates |templates with [% INCLUDE |with [% INCLUDE %] |%] directives. But the TT |directives. But the TT |module is used by Koha with |module is used by Koha with |absolute paths. Relative |absolute paths. Relative |paths are forbidden for |paths are forbidden for |security reasons. A new |security reasons. A new |param [% PLUGIN_DIR %] |param [% PLUGIN_DIR %] |allows plugin templates to |allow plugin templates to |know where to find plugin |know where to find plugin |home directory. |home directory. | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 15:31:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 14:31:47 +0000 Subject: [Koha-bugs] [Bug 23237] Add support for [% INCLUDE %] in plugin templates In-Reply-To: <bug-23237-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23237-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23237-70-k0smUc9MXG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23237 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|From a plugin template it |From a plugin template it release notes|is useful to include other |is useful to include other |templates with [% INCLUDE |templates with [% INCLUDE |%] directives. But the TT |%] directives. But the TT |module is used by Koha with |module is used by Koha with |absolute paths. Relative |absolute paths. Relative |paths are forbidden for |paths are forbidden for |security reasons. A new |security reasons. A new |param [% PLUGIN_DIR %] |param [% PLUGIN_DIR %] |allows plugin templates to |allows plugin templates to |know where to find plugin |know where to find the |home directory. |plugin home directory. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 15:32:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 14:32:40 +0000 Subject: [Koha-bugs] [Bug 24120] Search terms in search dropdown must be URI filtered In-Reply-To: <bug-24120-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24120-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24120-70-wEpHNguCbe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24120 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95830|0 |1 is obsolete| | --- Comment #5 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 95831 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95831&action=edit Bug 24120: (follow-up) input_name too Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 15:33:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 14:33:00 +0000 Subject: [Koha-bugs] [Bug 24124] New: Cannot select authorities in batch deletion tool in Chrome Message-ID: <bug-24124-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24124 Bug ID: 24124 Summary: Cannot select authorities in batch deletion tool in Chrome Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Tools Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Browse to Tools->Batch record deletion, try to select 'Authorities' - nothing happens -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 15:33:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 14:33:11 +0000 Subject: [Koha-bugs] [Bug 24124] Cannot select authorities in batch deletion tool in Chrome In-Reply-To: <bug-24124-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24124-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24124-70-vfIulENHxT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24124 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |oleonard at myacpl.org |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 15:33:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 14:33:54 +0000 Subject: [Koha-bugs] [Bug 24122] Typo in administration.rst In-Reply-To: <bug-24122-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24122-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24122-70-tly4bsT83u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24122 --- Comment #2 from Alexander Borkowski <alexander.borkowski at kau.se> --- Sure, thank you for the link to the manual on editing the manual :-) https://gitlab.com/koha-community/koha-manual/merge_requests/300 -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 15:34:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 14:34:44 +0000 Subject: [Koha-bugs] [Bug 24125] New: Deleting an authority clears the record heading Message-ID: <bug-24125-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24125 Bug ID: 24125 Summary: Deleting an authority clears the record heading Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: MARC Authority data support Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org To recreate: 1 - Find a record with an author linked to an authority 2 - Get that authority number 3 - Browse to tools->batch record deletion 4 - Select authorities and enter that authority id 5 - Delete the authority 6 - View the record, the 100 field has been cleared -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 15:34:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 14:34:55 +0000 Subject: [Koha-bugs] [Bug 24125] Deleting an authority clears the record heading In-Reply-To: <bug-24125-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24125-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24125-70-TsFjS2jsXd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24125 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |m.de.rooy at rijksmuseum.nl |ity.org | -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 15:35:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 14:35:00 +0000 Subject: [Koha-bugs] [Bug 18928] Move `holdallowed`, `hold_fulfillment_policy` and `returnbranch` into the `circulation_rules` table. In-Reply-To: <bug-18928-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18928-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18928-70-NeSGaI3ZIG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18928 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|**Reports Note**: This |**Reports note**: This release notes|changes the database |changes the database |schema, reports referencing |schema, reports referencing |the |the |`default_branch_circ_rules` |`default_branch_circ_rules` |, `default_circ_rules`, |, `default_circ_rules`, |`default_branch_item_rules` |`default_branch_item_rules` |or `branch_item_rules` |or `branch_item_rules` |tables will need to be |tables will need to be |updated |updated -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 15:35:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 14:35:06 +0000 Subject: [Koha-bugs] [Bug 22563] Convert lost handling to use 'status' instead of multiple accounttypes In-Reply-To: <bug-22563-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22563-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22563-70-sInNj8kbYH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22563 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Text to go in the|**Reports Note**: The |**Reports note**: The release notes|`accounttype` for lost item |`accounttype` for lost item |fees has been updated from |fees has been updated from |'L' to 'LOST' and for lost |'L' to 'LOST' and for lost |item returned credits it |item returned credits it |has been updated from 'CR' |has been updated from 'CR' |to 'LOST_RETURNED'. The |to 'LOST_RETURNED'. The |`status` field is now used |`status` field is now used |to track the reason why an |to track the reason why an |'OVERDUE' fee has stopped |'OVERDUE' fee has stopped |incrementing and it may |incrementing and it may |include 'LOST' |include 'LOST' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 15:36:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 14:36:24 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11529-70-hwzqGGBWGb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|**Important Note**: |**Important note**: release notes|misc/batchRebuildBiblioTabl |misc/batchRebuildBiblioTabl |es.pl should be run, after |es.pl should be run, after |this enhancement is |this enhancement is |applied, to populate the |applied, to populate the |fields in the database, and |fields in the database, and |it will take some time for |it will take some time for |larger databases. |larger databases. | | | | |Keywords to MARC mapping |Keywords to MARC mapping |functionality has been |functionality has been |replaced with additional |replaced with additional |Koha fields in the |Koha fields in the |bibliographic framework. |bibliographic framework. | | | | |The keyword mapping only |The keyword mapping only |offered a single field, |offered a single field, |subtitle, and the |subtitle, and the |information was always |information was always |retrieved from the MARC |retrieved from the MARC |record, which made it |record, which made it |relatively slow. The |relatively slow. The |subtitle and other relevant |subtitle and other relevant |fields are now available as |fields are now available as |normal Koha fields: |normal Koha fields: | | | | | | |biblio.medium - Medium |biblio.medium - Medium |information (MARC 21: 245h, |information (MARC 21: 245h, |UNIMARC: 200b) |UNIMARC: 200b) | | |biblio.subtitle - Subtitle |biblio.subtitle - Subtitle |(MARC 21: 245b, UNIMARC: |(MARC 21: 245b, UNIMARC: |200e) |200e) | | |biblio.part_number - Part |biblio.part_number - Part |number (MARC 21: 245n, |number (MARC 21: 245n, |UNIMARC: 200h) |UNIMARC: 200h) | | |biblio.part_name - Part |biblio.part_name - Part |name (MARC 21: 245p, |name (MARC 21: 245p, |UNIMARC: 200i) |UNIMARC: 200i) | | | | |The |The |subfields in the default |subfields in the default |framework are automatically |framework are automatically |updated to include these |updated to include these |new fields unless they are |new fields unless they are |already mapped to another |already mapped to another |Koha field. |Koha field. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 15:38:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 14:38:38 +0000 Subject: [Koha-bugs] [Bug 24001] Cannot edit card template In-Reply-To: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24001-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24001-70-oKhrtb1ekb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24001 --- Comment #23 from Chris Nighswonger <cnighswonger at foundations.edu> --- I'm working on using Bywater's sandbox script to set up a test bed. Once that's up and running, I'll work through this bug. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 15:39:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 14:39:55 +0000 Subject: [Koha-bugs] [Bug 15497] Limit item types by library In-Reply-To: <bug-15497-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15497-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15497-70-wOvjLwf2cX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Limit Item Types by Branch |Limit item types by library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 15:43:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 14:43:58 +0000 Subject: [Koha-bugs] [Bug 23903] Replace OPAC icons with Font Awesome In-Reply-To: <bug-23903-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23903-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23903-70-xKBXUW7Q5U@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23903 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Text to go in the|This patchset updates the |This patchset updates the release notes|majority of icons in the |majority of icons in the |opac to use fontawesome |opac to use Font Awesome |icons. It improves the |icons. It improves the |consistency of icons, icon |consistency of icons, icon |alignment and also gives a |alignment and also gives a |minor performance boost in |minor performance boost in |opac display. |opac display. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 15:45:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 14:45:16 +0000 Subject: [Koha-bugs] [Bug 23697] Add auto complete for patron search in patron module In-Reply-To: <bug-23697-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23697-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23697-70-S9Cuq4F1rE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23697 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement adds an |This enhancement adds an release notes|optional auto-complete |optional auto-complete |function to the patron |function to the patron |search field when in the |search field when in the |patrons module. |patrons module. | | |We rename |The |the `CircAutocompl` system |`CircAutocompl` system |preference to |preference is renamed to |`PatronAutoComplete` and |`PatronAutoComplete` and |use it for both functions. |use for both the | |circulation and patrons | |module auto-complete. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 15:52:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 14:52:20 +0000 Subject: [Koha-bugs] [Bug 24120] Search terms in search dropdown must be URI filtered In-Reply-To: <bug-24120-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24120-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24120-70-u1u1du7ZPR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24120 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 15:52:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 14:52:23 +0000 Subject: [Koha-bugs] [Bug 24120] Search terms in search dropdown must be URI filtered In-Reply-To: <bug-24120-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24120-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24120-70-xG5IKVdi7Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24120 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95828|0 |1 is obsolete| | --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95832 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95832&action=edit Bug 24120: URI filter search terms in sort dropdowns To test: 1 - Search for C++ 2 - Sort your results 3 - Note search is now for "C " 4 - Apply patch 5 - Search for C++ 6 - Reorder results 7 - Still searching for C++ Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 15:52:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 14:52:27 +0000 Subject: [Koha-bugs] [Bug 24120] Search terms in search dropdown must be URI filtered In-Reply-To: <bug-24120-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24120-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24120-70-n5SnQMIt8f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24120 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95831|0 |1 is obsolete| | --- Comment #7 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95833 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95833&action=edit Bug 24120: (follow-up) input_name too Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 15:57:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 14:57:04 +0000 Subject: [Koha-bugs] [Bug 17851] Add Elasticsearch config to koha-conf.xml In-Reply-To: <bug-17851-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17851-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17851-70-vLrdbvZAoQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17851 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add elasticsearch config to |Add Elasticsearch config to |koha-conf.xml |koha-conf.xml -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 16:04:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 15:04:13 +0000 Subject: [Koha-bugs] [Bug 22210] Allow organisations to sign up to Mana KB (don't only ask for firstname lastname) In-Reply-To: <bug-22210-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22210-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22210-70-AbKKhX42XS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement changes |This changes the Mana release notes|the Mana registration form |registration form to make |to make it easier for |it easier for organizations |organizations to register. |to register. It now only |It now only requires name |requires name and email |and email address, rather |address, rather than first |than first name, last name |name, last name and email |and email address. |address. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 16:06:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 15:06:03 +0000 Subject: [Koha-bugs] [Bug 23123] Status AVAILABLE and ORDERED for suggestions are not translated in the templates In-Reply-To: <bug-23123-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23123-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23123-70-tCpe2yw4Xm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23123 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |frederic at tamil.fr Component|Acquisitions |I18N/L10N -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 16:06:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 15:06:56 +0000 Subject: [Koha-bugs] [Bug 24125] Deleting an authority clears the record heading In-Reply-To: <bug-24125-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24125-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24125-70-wvLtUYb9g8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24125 --- Comment #1 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Nick Clemens from comment #0) > To recreate: > 1 - Find a record with an author linked to an authority > 2 - Get that authority number > 3 - Browse to tools->batch record deletion > 4 - Select authorities and enter that authority id > 5 - Delete the authority > 6 - View the record, the 100 field has been cleared Is that really a bug or actually what you should expect? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 16:07:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 15:07:40 +0000 Subject: [Koha-bugs] [Bug 24125] Deleting an authority clears the record heading In-Reply-To: <bug-24125-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24125-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24125-70-u8kMMVPLiR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24125 --- Comment #2 from Nick Clemens <nick at bywatersolutions.com> --- (In reply to Marcel de Rooy from comment #1) > Is that really a bug or actually what you should expect? I think it either should remove only the $9 or prevent deletion if record is linked -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 16:08:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 15:08:16 +0000 Subject: [Koha-bugs] [Bug 22037] Regression: guarantor no longer blocked (debarred) if child is over limit, when checking out via SIP In-Reply-To: <bug-22037-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22037-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22037-70-tzYg2E2SJv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22037 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|regression: guarantor no |Regression: guarantor no |longer blocked (debarred) |longer blocked (debarred) |if child is over limit, |if child is over limit, |when checking out via SIP. |when checking out via SIP -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 16:08:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 15:08:53 +0000 Subject: [Koha-bugs] [Bug 24058] Acquisition table displayed even if no order exist (bib detail) In-Reply-To: <bug-24058-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24058-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24058-70-C9sPyZe3yq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24058 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|acquisition table displayed |Acquisition table displayed |even if no order exist (bib |even if no order exist (bib |detail) |detail) CC| |katrin.fischer at bsz-bw.de -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 16:09:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 15:09:03 +0000 Subject: [Koha-bugs] [Bug 19886] Two Factor Authentication: Yubikey In-Reply-To: <bug-19886-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19886-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19886-70-77uEJUsxwI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19886 Ray Delahunty <r.delahunty at arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty at arts.ac.uk --- Comment #3 from Ray Delahunty <r.delahunty at arts.ac.uk> --- Koha needs additional layers of authentication. With the spread of equipment such as Amazon-locker type units to hold (often expensive) items obtained for interlibrary loan, and kit such as laptop loan units, there is the danger of unauthorised use via SIP2. Sites using RFID user cards with the cardnumber embedded on them are vulnerable to stock loss if a user card is lost and then found and used maliciously. Adding PIN functionality (for example) would reduce this risk. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 16:09:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 15:09:36 +0000 Subject: [Koha-bugs] [Bug 23246] Record detail page jumps into the 'images' tab if no holdings In-Reply-To: <bug-23246-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23246-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23246-70-hjRZEsgyZv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246 --- Comment #22 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Great. Will check later this week. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 16:23:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 15:23:03 +0000 Subject: [Koha-bugs] [Bug 24121] Item types icons in intra search results are requesting icons from opac images path if item-level_itypes syspref is set to biblio In-Reply-To: <bug-24121-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24121-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24121-70-MkhSVpiHOr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 Pedro Amorim <pjamorim91 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Item types icons not |Item types icons in intra |showing in intra search |search results are |results if |requesting icons from opac |item-level_itypes syspref |images path if |is set to biblio |item-level_itypes syspref | |is set to biblio -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 16:25:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 15:25:13 +0000 Subject: [Koha-bugs] [Bug 24114] modules must not warn In-Reply-To: <bug-24114-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24114-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24114-70-iWZ7fAi0zL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24114 --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- git grep -l -E "warn [\'\"]" Account.pm ArticleRequest.pm AuthUtils.pm Authorities.pm BiblioUtils.pm Cache.pm Club/Hold.pm I18N.pm Item/Search/Field.pm Logger.pm Middleware/SetEnv.pm Patron.pm Plugins/Base.pm Plugins/Handler.pm QueryParser/Driver/PQF.pm REST/Plugin/PluginRoutes.pm Schema/Result/Item.pm SearchEngine/Elasticsearch/QueryBuilder.pm SimpleMARC.pm Template/Plugin/Asset.pm UploadedFile.pm Util/MARC.pm XSLT_Handler.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 16:25:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 15:25:17 +0000 Subject: [Koha-bugs] [Bug 21336] GDPR: Handle unsubscribe requests automatically by optional (administrative) lock, anonymize and remove In-Reply-To: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21336-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21336-70-WKzUI9UGNQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21336 --- Comment #132 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #131) > (In reply to Marcel de Rooy from comment #130) > > (In reply to Jonathan Druart from comment #129) > > > I do not see a good reason to warn from the module, the script must done > > > that job. Especially because misc/cronjobs/cleanup_database.pl uses print > > > (STDOUT). > > > > > > Can you explain this choice? > > > > Probably simpler in the first place. And if this is indeed about the > > existing issues warn, it is not just an informational print line. > > Surely, it can be done differently. In other places too? > > Which other places? I do not think there were any before this patchset. > > I have opened bug 24114 to deal with the verbose flag. Answer on the new report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 16:25:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 15:25:26 +0000 Subject: [Koha-bugs] [Bug 24123] bulkmarcimport.pl doesn't support UTF-8 encoded MARCXML records In-Reply-To: <bug-24123-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24123-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24123-70-kzT5ePxpPy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24123 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Command-line Utilities |Searching - Elasticsearch QA Contact|testopia at bugs.koha-communit | |y.org | --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- The problem only appears with SearchEngine=Elastic, Koha::SearchEngine::Search->new uses a require statement to load the correct Search module. This is done l.257 of bulkmarcimport.pl: 257 my $searcher = Koha::SearchEngine::Search->new Koha::SearchEngine::Elasticsearch::Search will `use MARC::File::XML`, and so resets the arguments set before: 216 $MARC::File::XML::_load_args{BinaryEncoding} = 'utf-8'; 220 $MARC::File::XML::_load_args{RecordFormat} = $recordformat; An easy (but dirty) fix could be to move the declaration of my $searcher before in the script. The tricky (but correct) fix would be to remove the long standing "ugly hack follows" comment. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 16:25:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 15:25:57 +0000 Subject: [Koha-bugs] [Bug 24121] Item types icons in intra search results are requesting icons from opac images path if item-level_itypes syspref is set to biblio In-Reply-To: <bug-24121-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24121-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24121-70-TvOKuMG6P3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 --- Comment #3 from Pedro Amorim <pjamorim91 at gmail.com> --- Edited original title of "Item types icons not showing in intra search results if item-level_itypes syspref is set to biblio" to something more accurate. The original reason it was not showing for my installation is something specific (IP and port access - instead of url) but the fix still remains relevant, I believe. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 16:25:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 15:25:58 +0000 Subject: [Koha-bugs] [Bug 24123] bulkmarcimport.pl doesn't support UTF-8 encoded MARCXML records In-Reply-To: <bug-24123-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24123-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24123-70-houiyXJbBr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24123 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|normal |major --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Upping severity. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 16:26:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 15:26:15 +0000 Subject: [Koha-bugs] [Bug 24114] modules must not warn In-Reply-To: <bug-24114-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24114-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24114-70-bmCl4EJXFS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24114 --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- C4 git grep -l -E "warn [\'\"]" Acquisition.pm Auth.pm Auth_with_cas.pm Auth_with_ldap.pm Auth_with_shibboleth.pm AuthoritiesMarc.pm Barcodes.pm Barcodes/EAN13.pm Barcodes/ValueBuilder.pm Barcodes/annual.pm Barcodes/hbyymmincr.pm Biblio.pm Bookseller.pm Charset.pm Circulation.pm ClassSortRoutine.pm ClassSplitRoutine/LCC.pm Context.pm CourseReserves.pm Creators/PDF.pm Creators/Profile.pm Debug.pm External/BakerTaylor.pm External/OverDrive.pm External/Syndetics.pm HoldsQueue.pm Images.pm ImportExportFramework.pm InstallAuth.pm Installer.pm Items.pm Koha.pm Labels/Label.pm Languages.pm Letters.pm Matcher.pm Members/Attributes.pm Members/Messaging.pm Message.pm OAI/Sets.pm Output.pm Overdues.pm Record.pm Reserves.pm Ris.pm SIP/ILS.pm SIP/ILS/Item.pm SIP/ILS/Patron.pm SIP/ILS/Transaction/Checkin.pm SIP/ILS/Transaction/Checkout.pm SIP/Sip/Checksum.pm SIP/Sip/MsgType.pm SMS.pm Search.pm Search/History.pm Serials.pm Service.pm SocialData.pm Suggestions.pm Tags.pm Templates.pm Utils/DataTables/ColumnsSettings.pm XISBN.pm XSLT.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 16:28:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 15:28:10 +0000 Subject: [Koha-bugs] [Bug 24113] guarantor info lost when a duplicate is found In-Reply-To: <bug-24113-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24113-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24113-70-KXmRgoM3a4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24113 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 16:28:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 15:28:12 +0000 Subject: [Koha-bugs] [Bug 24113] guarantor info lost when a duplicate is found In-Reply-To: <bug-24113-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24113-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24113-70-HrYel2Syku@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24113 --- Comment #1 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 95834 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95834&action=edit Bug 24113: guarantor info lost when a duplicate is found When a patron is created with a guarantor but a duplicate is found (or any other warnings I guess) the guarantor's info are lost. This patch improves on previous functionality by retaining the select guarantor relationship as well. Test Plan: 1) Create a new child with a name already used, add a guarantor 2) Attempt to save, no the guarantor is not shown when the editor is redisplayed 3) Apply this patch 4) Restart all the things! 5) Repeat 1 6) Note the guarantor is retained and the relationship is as well! -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 16:31:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 15:31:10 +0000 Subject: [Koha-bugs] [Bug 24114] modules must not warn In-Reply-To: <bug-24114-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24114-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24114-70-zi0ZtVzvMh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24114 --- Comment #5 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #2) > I do not understand how to test properly this patch, why do not we have a > separated flag for this task? > > The following commit 2ca2585b1c5b61024351c32d84e605f61d04a418 > Bug 21336: Adjust cleanup_database.pl > says > "Run cleanup_database.pl --logs (or any other flag) for the first time." > > But it sounds wrong to me, I am expecting the script to do what I am asking > it to do. Underlying thought is we do not want to override the prefs here. If you run cleanup, it will cleanup what the prefs control. Do we really need 30 options or something like that in cleanup? For each simple task it does. I guess this is again not the only place where this is done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 16:31:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 15:31:34 +0000 Subject: [Koha-bugs] [Bug 24114] modules must not warn In-Reply-To: <bug-24114-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24114-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24114-70-zALdnhKhAV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24114 --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Marcel, to me they are completely different. Those are warnings displayed in the Koha logs because we encountered something wrong (or debug is on). The ones I am removing here are information displayed in the cronjob. The proof they are wrong is that the cronjob is printing (STDOUT) all other messages, but warn (STDERR) these ones, whereas they are not errors/warnings but verbose messages. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 16:32:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 15:32:39 +0000 Subject: [Koha-bugs] [Bug 24114] modules must not warn In-Reply-To: <bug-24114-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24114-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24114-70-DBzrff04Q9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24114 --- Comment #7 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #6) > Marcel, to me they are completely different. > Those are warnings displayed in the Koha logs because we encountered > something wrong (or debug is on). > > The ones I am removing here are information displayed in the cronjob. The > proof they are wrong is that the cronjob is printing (STDOUT) all other > messages, but warn (STDERR) these ones, whereas they are not errors/warnings > but verbose messages. You have a point. I cannot see what all these warns do. But probably there are bad ones ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 16:35:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 15:35:49 +0000 Subject: [Koha-bugs] [Bug 23380] GuessAuthTypeCode should check authority type exists In-Reply-To: <bug-23380-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23380-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23380-70-3lrbe7Rtka@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23380 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Failed QA CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Please cover subroutines changes by tests. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 16:39:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 15:39:20 +0000 Subject: [Koha-bugs] [Bug 24114] modules must not warn In-Reply-To: <bug-24114-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24114-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24114-70-VXgRgue4H4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24114 --- Comment #8 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- I can test later this week. I doubt if all ->count calls are working correctly after the changes but will check. Adjust title and status ? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 16:57:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 15:57:19 +0000 Subject: [Koha-bugs] [Bug 24113] guarantor info lost when a duplicate is found In-Reply-To: <bug-24113-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24113-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24113-70-azSc03wbS8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24113 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 16:57:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 15:57:22 +0000 Subject: [Koha-bugs] [Bug 24113] guarantor info lost when a duplicate is found In-Reply-To: <bug-24113-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24113-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24113-70-SnAhDHhD7k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24113 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95834|0 |1 is obsolete| | --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95835 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95835&action=edit Bug 24113: guarantor info lost when a duplicate is found When a patron is created with a guarantor but a duplicate is found (or any other warnings I guess) the guarantor's info are lost. This patch improves on previous functionality by retaining the select guarantor relationship as well. Test Plan: 1) Create a new child with a name already used, add a guarantor 2) Attempt to save, no the guarantor is not shown when the editor is redisplayed 3) Apply this patch 4) Restart all the things! 5) Repeat 1 6) Note the guarantor is retained and the relationship is as well! Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 16:57:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 15:57:31 +0000 Subject: [Koha-bugs] [Bug 22437] Subsequent authority merges in cron cause biblios to lose authority information In-Reply-To: <bug-22437-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22437-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22437-70-RVFs3Hz0bC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22437 --- Comment #3 from Pedro Amorim <pjamorim91 at gmail.com> --- Created attachment 95836 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95836&action=edit fix-for-subsequent-authorities-merge This patch makes it so that Koha will skip the merge process if the destination authority has been deleted before the cron has had the chance to run. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 16:57:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 15:57:48 +0000 Subject: [Koha-bugs] [Bug 24113] guarantor info lost when a duplicate is found In-Reply-To: <bug-24113-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24113-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24113-70-AAfw99qAQI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24113 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |kyle at bywatersolutions.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 17:26:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 16:26:08 +0000 Subject: [Koha-bugs] [Bug 13937] Add an Elasticsearch-compatible Z39.50/SRU daemon In-Reply-To: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13937-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13937-70-IxbDjTjAbX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13937 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Add an |Add an |Elasticsearch-compatible |Elasticsearch-compatible |Z39.50/SRU daemon that can |Z39.50/SRU daemon |inject item status MARC | |subfields | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 17:27:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 16:27:05 +0000 Subject: [Koha-bugs] [Bug 19014] Patrons should not get an 'on_reserve' notification if the due date is far into the future In-Reply-To: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19014-70-EcPbZr1ZV6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #45 from Nick Clemens <nick at bywatersolutions.com> --- Please retest -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 17:39:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 16:39:33 +0000 Subject: [Koha-bugs] [Bug 23237] Add support for [% INCLUDE %] in plugin templates In-Reply-To: <bug-23237-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23237-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23237-70-Z8A3fp9hxv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23237 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|From a plugin template it |The new feature allows release notes|is useful to include other |plugin authors to use |templates with [% INCLUDE |template `[% INCLUDE %]` |%] directives. But the TT |directives in their |module is used by Koha with |templates. It does so by |absolute paths. Relative |introducing a new variable, |paths are forbidden for |`PLUGIN_DIR`, allowing the |security reasons. A new |template engine to locate |param [% PLUGIN_DIR %] |the includes. |allows plugin templates to | |know where to find the |**Usage**: |plugin home directory. |`[% INCLUDE | |"$PLUGIN_DIR/header.tt" %]` -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 17:42:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 16:42:04 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11529-70-lclNzQvlE4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |gmcharlt at gmail.com Component|Architecture, internals, |System Administration |and plumbing | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 17:42:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 16:42:53 +0000 Subject: [Koha-bugs] [Bug 11529] Add subtitle, medium and part fields to biblio table In-Reply-To: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11529-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11529-70-LwEBQzjB4o@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11529 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|**Important note**: |Keywords to MARC mapping release notes|misc/batchRebuildBiblioTabl |functionality has been |es.pl should be run, after |replaced with additional |this enhancement is |Koha fields in the |applied, to populate the |bibliographic framework. |fields in the database, and | |it will take some time for |The keyword mapping only |larger databases. |offered a single field, | |subtitle, and the | |information was always |Keywords to MARC mapping |retrieved from the MARC |functionality has been |record, which made it |replaced with additional |relatively slow. The |Koha fields in the |subtitle and other relevant |bibliographic framework. |fields are now available as | |normal Koha fields: | | |The keyword mapping only | |offered a single field, |biblio.medium - Medium |subtitle, and the |information (MARC 21: 245h, |information was always |UNIMARC: 200b) |retrieved from the MARC | |record, which made it |biblio.subtitle - Subtitle |relatively slow. The |(MARC 21: 245b, UNIMARC: |subtitle and other relevant |200e) |fields are now available as | |normal Koha fields: |biblio.part_number - Part | |number (MARC 21: 245n, | |UNIMARC: 200h) | | |biblio.medium - Medium |biblio.part_name - Part |information (MARC 21: 245h, |name (MARC 21: 245p, |UNIMARC: 200b) |UNIMARC: 200i) | | |biblio.subtitle - Subtitle |The |(MARC 21: 245b, UNIMARC: |subfields in the default |200e) |framework are automatically | |updated to include these |biblio.part_number - Part |new fields unless they are |number (MARC 21: 245n, |already mapped to another |UNIMARC: 200h) |Koha field. | | |biblio.part_name - Part |**Important |name (MARC 21: 245p, |note**: |UNIMARC: 200i) |misc/batchRebuildBiblioTabl | |es.pl should be run, after | |this enhancement is |The |applied, to populate the |subfields in the default |fields in the database, and |framework are automatically |it will take some time for |updated to include these |larger databases. |new fields unless they are | |already mapped to another | |Koha field. | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 17:43:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 16:43:57 +0000 Subject: [Koha-bugs] [Bug 23522] Show "Actual price" in basket when available In-Reply-To: <bug-23522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23522-70-cAAOm2Ezun@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23522 Margaret <margaret at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Sponsored by: Virginia Tech release notes| |<https://lib.vt.edu/> CC| |margaret at bywatersolutions.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 17:45:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 16:45:13 +0000 Subject: [Koha-bugs] [Bug 20292] Filter/censor info sent via SIP In-Reply-To: <bug-20292-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20292-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20292-70-saR2U8W9UV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20292 Margaret <margaret at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement allows the |This enhancement allows the release notes|administrator to set if, |administrator to set if, |and which, fields should |and which, fields should |not be sent to third party |not be sent to third party |SIP2 clients for privacy |SIP2 clients for privacy |reasons. |reasons. | |Sponsored by: | |Uintah and Duchesne County | |Library | |<http://uintahlibrary.org/> CC| |margaret at bywatersolutions.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 17:46:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 16:46:02 +0000 Subject: [Koha-bugs] [Bug 23206] Batch patron modification from reports which return cardnumber In-Reply-To: <bug-23206-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23206-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23206-70-9jWIafIEwf@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23206 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement adds release notes| |`Batch patron modification` | |to the available options | |display when a report | |outputs a list of | |borrowernumbers or | |cardnumbers. CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are on the CC list for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 17:49:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 16:49:58 +0000 Subject: [Koha-bugs] [Bug 20954] Add ability to set syspref overrides in SIP as we can in Apache In-Reply-To: <bug-20954-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20954-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20954-70-4XsBFOIW5a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20954 Margaret <margaret at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Sponsored by: South East release notes| |Kansas Library System | |<http://www.sekls.org/> CC| |margaret at bywatersolutions.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 17:52:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 16:52:41 +0000 Subject: [Koha-bugs] [Bug 23389] Add 'All' option to report value dropdowns In-Reply-To: <bug-23389-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23389-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23389-70-YviOoUVAZP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23389 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Text to go in the| |This enhancement adds the release notes| |ability to optionally | |include an `all` option in | |report placeholders | |allowing for an 'All' | |option to be displayed in | |filter select lists. | | | |**Usage**: `WHERE | |branchcode LIKE | |<<Branch|branches:all>>` -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 17:52:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 16:52:47 +0000 Subject: [Koha-bugs] [Bug 23389] Add 'All' option to report value dropdowns In-Reply-To: <bug-23389-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23389-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23389-70-C9jMI5aiXY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23389 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 17:53:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 16:53:53 +0000 Subject: [Koha-bugs] [Bug 14697] Extend and enhance "Claims returned" lost status In-Reply-To: <bug-14697-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14697-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14697-70-yHQyWaCv9P@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 Margaret <margaret at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |margaret at bywatersolutions.c | |om Text to go in the|This enhancement extends |This enhancement extends release notes|the "Claims returned" lost |the "Claims returned" lost |status and allows staff to |status and allows staff to |track items that patrons |track items that patrons |claim to have returned. |claim to have returned. |Items are marked as "Claims |Items are marked as "Claims |returned" from the checkout |returned" from the checkout |page in the staff side. |page in the staff side. | | |There are 3 new systems |There are 3 new systems |preferences to set for this |preferences to set for this |functionality to work: |functionality to work: |`ClaimReturnedChargeFee`, |`ClaimReturnedChargeFee`, |`ClaimReturnedLostValue` |`ClaimReturnedLostValue` |and |and |`ClaimReturnedWarningThresh |`ClaimReturnedWarningThresh |old` |old` | | | |Sponsored by: Fargo | |Public Library | |<http://fargond.gov/city-go | |vernment/departments/librar | |y> | |North Central Regional | |Library System | |<http://www.ncrl.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 17:57:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 16:57:47 +0000 Subject: [Koha-bugs] [Bug 19618] Add 'Club Holds' feature In-Reply-To: <bug-19618-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19618-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19618-70-5BWBnBHTxz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618 Margaret <margaret at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This new feature adds the |This new feature adds the release notes|ability for clubs to place |ability for clubs to place |a hold for bibs. When such |a hold for bibs. When such |a hold is placed, in the |a hold is placed, in the |background a hold will be |background a hold will be |automatically placed for |automatically placed for |each member of the group in |each member of the group in |random order. |random order. | | | |Sponsored | |by: Southeast Kansas | |Library System | |<http://www.sekls.org/> CC| |margaret at bywatersolutions.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 17:58:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 16:58:58 +0000 Subject: [Koha-bugs] [Bug 23809] Update to DB revision 16.12.00.032 fails In-Reply-To: <bug-23809-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23809-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23809-70-XjQeEOSme5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23809 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Update to DB revision |Update to DB revision |16.12.00.032 fails: `Not a |16.12.00.032 fails |HASH reference at | |/usr/share/koha/intranet/cg | |i-bin/installer/data/mysql/ | |updatedatabase.pl line | |14371.` | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 17:59:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 16:59:10 +0000 Subject: [Koha-bugs] [Bug 23390] Add placeholder syntax for column names In-Reply-To: <bug-23390-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23390-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23390-70-rGCUmLQuNe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23390 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |release-notes-needed CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 17:59:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 16:59:29 +0000 Subject: [Koha-bugs] [Bug 23655] Debian jessie no longer supported In-Reply-To: <bug-23655-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23655-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23655-70-Z3ZlZEbccD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23655 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Component|Documentation |Architecture, internals, | |and plumbing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 18:00:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 17:00:57 +0000 Subject: [Koha-bugs] [Bug 23655] Errors when running on Debian Jessie In-Reply-To: <bug-23655-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23655-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23655-70-HKfOlukxi1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23655 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Debian jessie no longer |Errors when running on |supported |Debian Jessie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 18:01:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 17:01:14 +0000 Subject: [Koha-bugs] [Bug 17179] Advanced editor: Add keyboard shortcuts to repeat (duplicate) a field, and cut text In-Reply-To: <bug-17179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17179-70-jfLYZy1Ypo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Margaret <margaret at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |margaret at bywatersolutions.c | |om Text to go in the|This patchset introduces an |This patchset introduces an release notes|internal clipboard to the |internal clipboard to the |advanced editor and |advanced editor and |provides some new |provides some new |functionality to make use |functionality to make use |of it; The following |of it; The following |default shortcuts are |default shortcuts are |provided but can be edited |provided but can be edited |as per bug 21411. |as per bug 21411. | | |Changed: |Changed: |* `Ctrl-X`: Now cuts a line |* `Ctrl-X`: Now cuts a line |into the clipboard area |into the clipboard area |* |* |`Shift-Ctrl-X`: Now cuts |`Shift-Ctrl-X`: Now cuts |current subfield into |current subfield into |clipboard area |clipboard area | | |Added: |Added: |* |* |`Ctrl-C`: Copies a line |`Ctrl-C`: Copies a line |into the clipboard area |into the clipboard area |* |* |`Shift-Ctrl-C`: Copies |`Shift-Ctrl-C`: Copies |current subfield into |current subfield into |clipboard area |clipboard area |* `Ctrl-P`: |* `Ctrl-P`: |Pastes the selected item |Pastes the selected item |from the clipboard at |from the clipboard at |cursor |cursor |* `Ctrl-I`: Copies |* `Ctrl-I`: Copies |the current line and |the current line and |inserts onto a new line |inserts onto a new line |below |below | | | |Sponsored by: Round | |Rock Public Library | |<https://www.roundrocktexas | |.gov/departments/library/> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 18:01:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 17:01:47 +0000 Subject: [Koha-bugs] [Bug 17178] Add a popup/keyboard shortcuts for diacritics and symbols in the advanced cataloging editor In-Reply-To: <bug-17178-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17178-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17178-70-padF3rBxL5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17178 Margaret <margaret at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |margaret at bywatersolutions.c | |om Text to go in the| |Sponsored by: Round Rock release notes| |Public Library | |<https://www.roundrocktexas | |.gov/departments/library/> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 18:02:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 17:02:17 +0000 Subject: [Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status In-Reply-To: <bug-17168-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17168-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17168-70-3mDsOURJww@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168 Margaret <margaret at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|These patches introduce a |These patches introduce a release notes|new script to replace the |new script to replace the |`j2a.pl` script with a more |`j2a.pl` script with a more |flexible set of options. |flexible set of options. | | |`misc/cronjobs/update_patro |`misc/cronjobs/update_patro |ns_category.pl` can now be |ns_category.pl` can now be |used to update patrons who |used to update patrons who |are older or younger than |are older or younger than |their patron categories to |their patron categories to |a category chosen by the |a category chosen by the |user. |user. | | |Additionally, this |Additionally, this |script allows users to |script allows users to |specify a fine total to |specify a fine total to |update patrons, to use any |update patrons, to use any |specified borrowers field, |specified borrowers field, |and to run by category |and to run by category |and/or branch. |and/or branch. | | |The |The |intention here is to assist |intention here is to assist |in automating updating |in automating updating |patrons for schools or |patrons for schools or |libraries where patrons are |libraries where patrons are |regularly changed - patrons |regularly changed - patrons |with fines can be moved to |with fines can be moved to |'probational statuses' or |'probational statuses' or |patrons without fines can |patrons without fines can |be moved to 'privileged |be moved to 'privileged |statuses'. |statuses'. | | |The flexibility |The flexibility |should allow for various |should allow for various |workflows to be automated |workflows to be automated |via cronjob. |via cronjob. | | | |Sponsored by: | |Round Rock Public Library | |<https://www.roundrocktexas | |.gov/departments/library/> CC| |margaret at bywatersolutions.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 18:02:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 17:02:46 +0000 Subject: [Koha-bugs] [Bug 22210] ManaKB should not require firstname and lastname; allowing organisations to sign up In-Reply-To: <bug-22210-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22210-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22210-70-ze2IdeleEk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Allow organisations to sign |ManaKB should not require |up to Mana KB (don't only |firstname and lastname; |ask for firstname lastname) |allowing organisations to | |sign up -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 18:02:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 17:02:58 +0000 Subject: [Koha-bugs] [Bug 22210] ManaKB should not require firstname and lastname In-Reply-To: <bug-22210-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22210-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22210-70-A6l5lx01kC@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ManaKB should not require |ManaKB should not require |firstname and lastname; |firstname and lastname |allowing organisations to | |sign up | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 18:03:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 17:03:07 +0000 Subject: [Koha-bugs] [Bug 22210] ManaKB should not require firstname and lastname for signup In-Reply-To: <bug-22210-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22210-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22210-70-DfroYA8FLv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22210 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|ManaKB should not require |ManaKB should not require |firstname and lastname |firstname and lastname for | |signup -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 18:05:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 17:05:16 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: <bug-14570-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14570-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14570-70-MecEWegq0B@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Margaret <margaret at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This features adds the |This features adds the release notes|ability for a patron to |ability for a patron to |have an unlimited number of |have an unlimited number of |guarantors in any |guarantors in any |combination of existing |combination of existing |Koha patrons and manually |Koha patrons and manually |added guarantors ( e.g. the |added guarantors ( e.g. the |person has no patron record |person has no patron record |in Koha ). |in Koha ). | | |This feature |This feature |retains the existing |retains the existing |behavior for importing |behavior for importing |guarantors during patron |guarantors during patron |imports. |imports. | | |Guarantors can no |Guarantors can no |longer be |longer be |viewed/added/updated from |viewed/added/updated from |the REST API. |the REST API. | | |Reports that |Reports that |utilize |utilize |borrowers.guarantorid will |borrowers.guarantorid will |need to be updated. |need to be updated. | | | |Sponsored by: Northeast | |Kansas Library System | |<http://www.nekls.org> | |Vermont Organization of | |Koha Automated Libraries | |<http://gmlc.org/index.php/ | |vokal> CC| |margaret at bywatersolutions.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 18:11:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 17:11:55 +0000 Subject: [Koha-bugs] [Bug 23390] Add placeholder syntax for column names In-Reply-To: <bug-23390-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23390-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23390-70-wWSvPg1Uww@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23390 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This enhancement allows for release notes| |renaming columns used to | |trigger batch modification | |actions in reports. Before | |this patch, a column had to | |be called 'itemnumber' to | |be sent from reports to | |batch modification. With | |this enhancement, you can | |specify `[[itemnumber| | |Koha_internal_id]]` to | |allow for a clearer name | |for the end-user and to | |allow translation of terms | |like 'itemnumber' while | |preserving the batch | |modification functionality | |something like that? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 18:12:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 17:12:01 +0000 Subject: [Koha-bugs] [Bug 23390] Add placeholder syntax for column names In-Reply-To: <bug-23390-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23390-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23390-70-0cKGMhYNxM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23390 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 18:13:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 17:13:11 +0000 Subject: [Koha-bugs] [Bug 23390] Add placeholder syntax for column names In-Reply-To: <bug-23390-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23390-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23390-70-ynDTOXBcUi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23390 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement allows for |This enhancement allows for release notes|renaming columns used to |renaming columns used to |trigger batch modification |trigger batch modification |actions in reports. Before |actions in reports. Before |this patch, a column had to |this patch, a column had to |be called 'itemnumber' to |be called 'itemnumber' to |be sent from reports to |be sent from reports to |batch modification. With |batch modification. With |this enhancement, you can |this enhancement, you can |specify `[[itemnumber| |specify `[[itemnumber| |Koha_internal_id]]` to |Koha_internal_id]]` to |allow for a clearer name |allow for a clearer name |for the end-user and to |for the end-user and to |allow translation of terms |allow translation of terms |like 'itemnumber' while |like 'itemnumber' while |preserving the batch |preserving the batch |modification functionality |modification functionality. |something like that? | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 18:13:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 17:13:57 +0000 Subject: [Koha-bugs] [Bug 15497] Limit item types by library In-Reply-To: <bug-15497-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15497-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15497-70-MnnNjb6BcU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497 Margaret <margaret at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |Sponsored by: Central release notes| |Kansas Library System | |<https://ckls.org/> | |Northeast Kansas Library | |System | |<http://www.nekls.org> | |Southeast Kansas Library | |System | |<http://www.sekls.org/> CC| |margaret at bywatersolutions.c | |om -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 18:29:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 17:29:47 +0000 Subject: [Koha-bugs] [Bug 24126] New: Article requests tab appears twice on patron's checkout screen Message-ID: <bug-24126-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24126 Bug ID: 24126 Summary: Article requests tab appears twice on patron's checkout screen Change sponsored?: Sponsored Product: Koha Version: master Hardware: All URL: http://devs.bywatersolutions.com/projects/claimed-retu rned/ OS: All Status: ASSIGNED Severity: normal Priority: P5 - low Component: Templates Assignee: oleonard at myacpl.org Reporter: oleonard at myacpl.org QA Contact: testopia at bugs.koha-community.org CC: bdaeuber at cityoffargo.com, bklein at dubuque.lib.ia.us, cbrannon at cdalibrary.org, clackman at fargolibrary.org, cmartin at rcplib.org, cslone at camdencountylibrary.org, daniel.gaghan at pueblolibrary.org, george at nekls.org, gmcharlt at gmail.com, horganl at middlesex.mass.edu, hughr at brimbank.vic.gov.au, joy at bywatersolutions.com, jwagner at ptfs.com, jzairo at bywatersolutions.com, katrin.fischer at bsz-bw.de, kelly at bywatersolutions.com, kyle.m.hall at gmail.com, kyle at bywatersolutions.com, lisetteslatah at gmail.com, margaret at bywatersolutions.com, marjorie.barry-vila at collecto.ca, martin.renvoize at ptfs-europe.com, niamh.walker-headon at it-tallaght.ie, tmisilo at gmail.com, tomascohen at gmail.com Depends on: 14697 Added by Bug 14697, the "Article requests" tab on the patron checkout screen now appears twice. Presumably a merge error. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 [Bug 14697] Extend and enhance "Claims returned" lost status -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 18:29:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 17:29:47 +0000 Subject: [Koha-bugs] [Bug 14697] Extend and enhance "Claims returned" lost status In-Reply-To: <bug-14697-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14697-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14697-70-jvP4CDhLkS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24126 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24126 [Bug 24126] Article requests tab appears twice on patron's checkout screen -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 18:36:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 17:36:50 +0000 Subject: [Koha-bugs] [Bug 24122] Typo in administration.rst In-Reply-To: <bug-24122-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24122-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24122-70-xBwv0FEAUl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24122 David Nind <david at davidnind.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #3 from David Nind <david at davidnind.com> --- Thanks Alexander! Merged to master version of the manual (19.11) and 19.05 on GitLab. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 18:41:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 17:41:13 +0000 Subject: [Koha-bugs] [Bug 24126] Article requests tab appears twice on patron's checkout screen In-Reply-To: <bug-24126-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24126-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24126-70-5jCb6LUM0I@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24126 Owen Leonard <oleonard at myacpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff Patch complexity|--- |Trivial patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 18:41:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 17:41:17 +0000 Subject: [Koha-bugs] [Bug 24126] Article requests tab appears twice on patron's checkout screen In-Reply-To: <bug-24126-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24126-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24126-70-nYzKVSjGpt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24126 --- Comment #1 from Owen Leonard <oleonard at myacpl.org> --- Created attachment 95837 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95837&action=edit Bug 24126: Article requests tab appears twice on patron's checkout screen This patch removes duplicated markup on the checkout page which results in the "Article requests" tab appearing twice. To test, apply the patch and enable ArticleRequests. Check out to a patron. In the set of tabs that includes checkouts, holds, restrictions, etc., the "Article requests" tab should appear only once. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 18:45:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 17:45:47 +0000 Subject: [Koha-bugs] [Bug 23214] Add ability to pay guarantees fines In-Reply-To: <bug-23214-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23214-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23214-70-w2nAd0GuyU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23214 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|OPAC add ability to pay |Add ability to pay |guarantees fines |guarantees fines -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 18:46:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 17:46:02 +0000 Subject: [Koha-bugs] [Bug 24126] Article requests tab appears twice on patron's checkout screen In-Reply-To: <bug-24126-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24126-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24126-70-lTCEh4CyPQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24126 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 18:46:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 17:46:06 +0000 Subject: [Koha-bugs] [Bug 24126] Article requests tab appears twice on patron's checkout screen In-Reply-To: <bug-24126-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24126-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24126-70-vs5bFtIMO7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24126 Kyle M Hall <kyle at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95837|0 |1 is obsolete| | --- Comment #2 from Kyle M Hall <kyle at bywatersolutions.com> --- Created attachment 95838 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95838&action=edit Bug 24126: Article requests tab appears twice on patron's checkout screen This patch removes duplicated markup on the checkout page which results in the "Article requests" tab appearing twice. To test, apply the patch and enable ArticleRequests. Check out to a patron. In the set of tabs that includes checkouts, holds, restrictions, etc., the "Article requests" tab should appear only once. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 18:47:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 17:47:34 +0000 Subject: [Koha-bugs] [Bug 23214] Add ability to pay guarantees fines In-Reply-To: <bug-23214-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23214-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23214-70-PGr9FmQJ4S@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23214 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This new feature gives release notes| |guarantors the option to | |pay off their guarantees | |charges using online | |payments via the OPAC. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 18:49:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 17:49:08 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: <bug-14570-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14570-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14570-70-KguHxWDpj9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This features adds the |This development adds the release notes|ability for a patron to |ability for a patron to |have an unlimited number of |have an unlimited number of |guarantors in any |guarantors in any |combination of existing |combination of existing |Koha patrons and manually |Koha patrons and manually |added guarantors ( e.g. the |added guarantors ( e.g. the |person has no patron record |person has no patron record |in Koha ). |in Koha ). | | |This feature |This feature |retains the existing |retains the existing |behavior for importing |behavior for importing |guarantors during patron |guarantors during patron |imports. |imports. | | |Guarantors can no |Guarantors can no |longer be |longer be |viewed/added/updated from |viewed/added/updated from |the REST API. |the REST API. | | |Reports that |Reports that |utilize |utilize |borrowers.guarantorid will |borrowers.guarantorid will |need to be updated. |need to be updated. | | |Sponsored by: Northeast |Sponsored by: Northeast |Kansas Library System |Kansas Library System |<http://www.nekls.org> |<http://www.nekls.org> |Vermont Organization of |Vermont Organization of |Koha Automated Libraries |Koha Automated Libraries |<http://gmlc.org/index.php/ |<http://gmlc.org/index.php/ |vokal> |vokal> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 19:14:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 18:14:40 +0000 Subject: [Koha-bugs] [Bug 24085] Double submission of forms on returns.pl In-Reply-To: <bug-24085-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24085-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24085-70-ofnTWzkmax@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24085 --- Comment #2 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95839 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95839&action=edit Bug 24085: [18.11.x ONLY] Rebased version for testing -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 19:53:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 18:53:11 +0000 Subject: [Koha-bugs] [Bug 23522] Show "Actual price" in basket when available In-Reply-To: <bug-23522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23522-70-3cxkBMpiZS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23522 --- Comment #15 from Michael Sutherland <sudrland at vt.edu> --- (In reply to Martin Renvoize from comment #14) > Nice work! > > Pushed to master for 19.11.00 Can this be applied to 19.05.x as well? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 20:02:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 19:02:27 +0000 Subject: [Koha-bugs] [Bug 17979] Fatal error when searching from addbooks.pl due to ISBN flaw In-Reply-To: <bug-17979-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17979-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17979-70-YQkLkD3Ueh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17979 --- Comment #5 from Owen Leonard <oleonard at myacpl.org> --- I was going off existing code, so perhaps I misunderstood that other instance. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 20:18:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 19:18:47 +0000 Subject: [Koha-bugs] [Bug 24127] New: Using the dropdown option of Shelving Location as a search choice retrieves no results Message-ID: <bug-24127-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24127 Bug ID: 24127 Summary: Using the dropdown option of Shelving Location as a search choice retrieves no results Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: minor Priority: P5 - low Component: Searching Assignee: nick at bywatersolutions.com Reporter: kelly at bywatersolutions.com QA Contact: testopia at bugs.koha-community.org Shelving location is an option in the dropdown option in both a basic search and the advanced search on the Staff Client. This search does not work in either place. It is unclear what Koha would want in this search, would a user type the shelving location description or code? Since this option is secondary to the other ways (in the advanced search (using the checkmark boxes under shelving location) and item search) - I believe this option in the dropdown menu should be removed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 20:29:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 19:29:34 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: <bug-14570-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14570-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14570-70-hLlWiTJpvg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #241 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Something wrong happening on the about page: https://snipboard.io/QmBPeJ.jpg MariaDB [koha_kohadev]> select * from systempreferences where variable="borrowerRelationship"; +----------------------+---------------+---------+------------------------------------------------------------------------------------+------+ | variable | value | options | explanation | type | +----------------------+---------------+---------+------------------------------------------------------------------------------------+------+ | borrowerRelationship | father|mother | | Define valid relationships between a guarantor & a guarantee (separated by | or ,) | free | +----------------------+---------------+---------+------------------------------------------------------------------------------------+------+ 1 row in set (0.00 sec) MariaDB [koha_kohadev]> select distinct relationship from borrowers; +--------------+ | relationship | +--------------+ | NULL | +--------------+ 1 row in set (0.01 sec) MariaDB [koha_kohadev]> select * from borrower_relationships; Empty set (0.00 sec) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 20:46:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 19:46:56 +0000 Subject: [Koha-bugs] [Bug 23767] Spent and Ordered total values don't include child funds on acqui-home In-Reply-To: <bug-23767-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23767-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23767-70-s4xHxISiMo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23767 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 20:46:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 19:46:59 +0000 Subject: [Koha-bugs] [Bug 23767] Spent and Ordered total values don't include child funds on acqui-home In-Reply-To: <bug-23767-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23767-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23767-70-FDwmeE9WPI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23767 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95334|0 |1 is obsolete| | --- Comment #11 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95840 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95840&action=edit Bug 23767: Include child funds in total spent and ordered on acqui-home To test: 1 - Have three funds, two parents and one child 2 - Open a basket and add an order to each fund 3 - View acqui-home.pl 4 - Note that ordered values are only added from the two parent funds 5 - Complete these orders (close basket, receive) 6 - Note the spent only includes parent funds 7 - Place three more orders, one from each fund 8 - Now you can see both spent and ordered are incorrect 9 - Apply patch 10 - Reload, all should add correctly Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 20:47:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 19:47:02 +0000 Subject: [Koha-bugs] [Bug 23767] Spent and Ordered total values don't include child funds on acqui-home In-Reply-To: <bug-23767-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23767-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23767-70-VpdfFbfGSK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23767 --- Comment #12 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95841 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95841&action=edit Bug 23767: Don't calculate 'Total available' The acqui-home page is meant to be a simple view of the budgets. For details you should lok at aqbudgets.pl ( i.e. click on a budget) The total available column isn't easy to calculate - it depends on child funds - trying to calculate what a top level fund has left depends on the values of the child funds. When searching the table and limiting rows you lose the values form the children. On acqbudgets.pl we solve this with the Base-level/Total available columns, and we don't total base-level on that page at all. 'Total available' on acqui-home equals the 'Base level' on the other page. Removing a recalculated total is the simplest answer here, otherwise we must add complexity to this view. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 20:52:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 19:52:09 +0000 Subject: [Koha-bugs] [Bug 24127] Using the dropdown option of Shelving Location as a search choice retrieves no results In-Reply-To: <bug-24127-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24127-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24127-70-GzGPn7ZFPl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24127 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|18.11 |master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 20:52:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 19:52:21 +0000 Subject: [Koha-bugs] [Bug 24127] Using the dropdown option of Shelving Location as a search choice retrieves no results In-Reply-To: <bug-24127-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24127-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24127-70-aWPGpg6keK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24127 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 20:52:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 19:52:23 +0000 Subject: [Koha-bugs] [Bug 24127] Using the dropdown option of Shelving Location as a search choice retrieves no results In-Reply-To: <bug-24127-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24127-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24127-70-3CYk6z3gnI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24127 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95842 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95842&action=edit Bug 24127: Remove 'Shelving location' from search dropdown To test: 1 - In staff client enable IntranetCatalogSearchPulldown 2 - Click on the 'Search the catalog' tab 3 - Note 'Shelving location' option in dropdown 4 - Search for code or description of a locatio, no results 5 - Repeat on advanced search 6 - Apply patch 7 - Note option is now removed -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 21:25:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 20:25:07 +0000 Subject: [Koha-bugs] [Bug 24024] Holds Awaiting Pickup (Both Active and Expired) Sorts by Firstname In-Reply-To: <bug-24024-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24024-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24024-70-JvD8DjHxvY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24024 --- Comment #10 from Martha Fuerst <mfuerst at hmcpl.org> --- Will this get backdated to 19.05? It's currently a hassle and a half in regard to managing our holds shelves. -Marti Fuerst Hunstville-Madison County Public Library -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 21:28:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 20:28:31 +0000 Subject: [Koha-bugs] [Bug 24024] Holds Awaiting Pickup (Both Active and Expired) Sorts by Firstname In-Reply-To: <bug-24024-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24024-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24024-70-BNw6dmqMcQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24024 --- Comment #11 from rkuiper at roundrocktexas.gov --- I second Marti's comment. Our staff would really love to see this fixed. Rhonda Kuiper -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Tue Nov 26 21:30:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Tue, 26 Nov 2019 20:30:22 +0000 Subject: [Koha-bugs] [Bug 24075] Backdating a return to the exact due date and time results in the fine not being refunded In-Reply-To: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24075-70-h10JwI4j4K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24075 Martha Fuerst <mfuerst at hmcpl.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mfuerst at hmcpl.org --- Comment #20 from Martha Fuerst <mfuerst at hmcpl.org> --- Will this be backdated to 19.05? Thanks! -Marti Fuerst -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 02:34:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 01:34:35 +0000 Subject: [Koha-bugs] [Bug 19887] Two Factor Authentication: Google Authenticator In-Reply-To: <bug-19887-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19887-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19887-70-1jSmTNlokS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19887 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 02:38:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 01:38:33 +0000 Subject: [Koha-bugs] [Bug 19886] Two Factor Authentication: Yubikey In-Reply-To: <bug-19886-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19886-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19886-70-ATuC570NLw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19886 --- Comment #4 from David Cook <dcook at prosentient.com.au> --- (In reply to Jon Knight from comment #1) > Is this something that needs to be built into Koha, or is it better to make > use of existing third party systems such as PrivacyIDEA > (https://www.privacyidea.org/) that can be used in conjuction with normal > SSO mechanisms? For example we (Loughborough University) have tested > Yubikeys with PrivacyIDEA and simpleSAMLphp IdP and it works, and we already > know that Koha can use the SAML2.0 authentication assertions from the IdP > (as that's what we're doing in production with PTFS-E). PrivacyIDEA also > can also support Google Authentication as suggested in Bug 19887. I wonder about this as well. I'm fond of Keycloak for this purpose. It can use SAML or OpenID Connect. I have a local OpenID Connect client I wrote for Koha, and I've thought about using Keycloak in the test plan for when I finish the patches for Bugzilla... That said, adding support to Koha would make it easy for people to have more secure out of the box implementations without needing more third party software. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 02:41:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 01:41:59 +0000 Subject: [Koha-bugs] [Bug 19886] Two Factor Authentication: Yubikey In-Reply-To: <bug-19886-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19886-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19886-70-hoOtTVJVOE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19886 --- Comment #5 from David Cook <dcook at prosentient.com.au> --- (In reply to Ray Delahunty from comment #3) > Koha needs additional layers of authentication. With the spread of equipment > such as Amazon-locker type units to hold (often expensive) items obtained > for interlibrary loan, and kit such as laptop loan units, there is the > danger of unauthorised use via SIP2. Sites using RFID user cards with the > cardnumber embedded on them are vulnerable to stock loss if a user card is > lost and then found and used maliciously. Adding PIN functionality (for > example) would reduce this risk. Additional layers of authentication could be used for Staff Client login or OPAC login, but I don't think the layers you describe are very realistic for most libraries (ie I worked on the front lines of libraries for years and getting patrons to remember a number or a card is hard enough in itself). I also think they're a different use case than what is being described in this bug report. But an interesting idea. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 03:06:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 02:06:22 +0000 Subject: [Koha-bugs] [Bug 13193] Make Memcached usage fork safe In-Reply-To: <bug-13193-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13193-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13193-70-jyPthNyYRZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 --- Comment #50 from David Cook <dcook at prosentient.com.au> --- Still have libraries being impacted about this in rather nasty ways. It would be great to see progress on this one. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 07:59:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 06:59:27 +0000 Subject: [Koha-bugs] [Bug 23276] Don't show tags on tag cloud when tagging is disabled In-Reply-To: <bug-23276-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23276-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23276-70-zXwXTybbwD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23276 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 08:51:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 07:51:49 +0000 Subject: [Koha-bugs] [Bug 24113] guarantor info lost when a duplicate is found In-Reply-To: <bug-24113-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24113-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24113-70-WPEYZxbiaX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24113 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95835|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95843 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95843&action=edit Bug 24113: guarantor info lost when a duplicate is found When a patron is created with a guarantor but a duplicate is found (or any other warnings I guess) the guarantor's info are lost. This patch improves on previous functionality by retaining the select guarantor relationship as well. Test Plan: 1) Create a new child with a name already used, add a guarantor 2) Attempt to save, no the guarantor is not shown when the editor is redisplayed 3) Apply this patch 4) Restart all the things! 5) Repeat 1 6) Note the guarantor is retained and the relationship is as well! Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 08:52:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 07:52:10 +0000 Subject: [Koha-bugs] [Bug 24113] guarantor info lost when a duplicate is found In-Reply-To: <bug-24113-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24113-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24113-70-KZOcZTofii@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24113 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Thanks for the quick fix, Passing QA and Pushing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 08:52:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 07:52:17 +0000 Subject: [Koha-bugs] [Bug 24113] guarantor info lost when a duplicate is found In-Reply-To: <bug-24113-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24113-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24113-70-3xelCuYVOd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24113 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_19_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 08:52:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 07:52:35 +0000 Subject: [Koha-bugs] [Bug 24113] guarantor info lost when a duplicate is found In-Reply-To: <bug-24113-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24113-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24113-70-smhz8oiupc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24113 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 08:52:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 07:52:37 +0000 Subject: [Koha-bugs] [Bug 24113] guarantor info lost when a duplicate is found In-Reply-To: <bug-24113-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24113-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24113-70-br3GQN5MOz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24113 --- Comment #5 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 08:55:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 07:55:11 +0000 Subject: [Koha-bugs] [Bug 24120] Search terms in search dropdown must be URI filtered In-Reply-To: <bug-24120-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24120-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24120-70-8l2NG2ukG3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24120 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 08:55:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 07:55:13 +0000 Subject: [Koha-bugs] [Bug 24120] Search terms in search dropdown must be URI filtered In-Reply-To: <bug-24120-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24120-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24120-70-MTRhfizpLd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24120 --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 10:06:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 09:06:53 +0000 Subject: [Koha-bugs] [Bug 12759] Add ability to pass list contents to batch record modification/deletion tools In-Reply-To: <bug-12759-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12759-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12759-70-yBuEL44I7u@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12759 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24124 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24124 [Bug 24124] Cannot select authorities in batch deletion tool in Chrome -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 10:06:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 09:06:53 +0000 Subject: [Koha-bugs] [Bug 24124] Cannot select authorities in batch deletion tool in Chrome In-Reply-To: <bug-24124-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24124-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24124-70-6M8yrHVI45@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24124 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |12759 CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- It's caused by the use of toptabs. I do not understand what is going on here. It also affects Batch record modification. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12759 [Bug 12759] Add ability to pass list contents to batch record modification/deletion tools -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 10:12:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 09:12:03 +0000 Subject: [Koha-bugs] [Bug 23276] Don't show tags on tag cloud when tagging is disabled In-Reply-To: <bug-23276-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23276-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23276-70-H4uvt3nFjq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23276 --- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I am good with both approaches. I wanted to provide a patch that kept the original behavior. As well it introduces the use of blocking-errors.inc OPAC-side, which was a good move forward. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 10:15:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 09:15:28 +0000 Subject: [Koha-bugs] [Bug 23927] Duplicate a "Complete" order link the "New" one to the invoice In-Reply-To: <bug-23927-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23927-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23927-70-mvC7tYZpZT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23927 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95815|0 |1 is obsolete| | --- Comment #8 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95844 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95844&action=edit Bug 23927: Add tests Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 10:15:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 09:15:31 +0000 Subject: [Koha-bugs] [Bug 23927] Duplicate a "Complete" order link the "New" one to the invoice In-Reply-To: <bug-23927-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23927-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23927-70-PT0lokZb8H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23927 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95816|0 |1 is obsolete| | --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95845 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95845&action=edit Bug 23927: Do not copy invoiceid for a new duplicated order When an order is created from an existing one (duplication), then the invoice should be set to null instead of retrieved. Test plan: - receive an order - in a new basket, add an order "From exisitions orders (copy)" - search your received order - duplicate - go to the bibliographic record "Acquisition details" tab => Without this patch you will see that the invoice is the same for the two orders => With this patch the invoice for the new order is not set Signed-off-by: Séverine QUEUNE <severine.queune at bulac.fr> Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 10:17:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 09:17:51 +0000 Subject: [Koha-bugs] [Bug 23927] Duplicate a "Complete" order link the "New" one to the invoice In-Reply-To: <bug-23927-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23927-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23927-70-8B1GtYBuEe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23927 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Status|Signed Off |Passed QA --- Comment #10 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Works as expected, contains tests (which all pass) and passes QA scripts. Passing QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 10:17:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 09:17:55 +0000 Subject: [Koha-bugs] [Bug 23927] Duplicate a "Complete" order link the "New" one to the invoice In-Reply-To: <bug-23927-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23927-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23927-70-y6EksRIZs3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23927 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 10:18:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 09:18:40 +0000 Subject: [Koha-bugs] [Bug 23927] Duplicate a "Complete" order link the "New" one to the invoice In-Reply-To: <bug-23927-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23927-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23927-70-UrnsERUUb2@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23927 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 10:18:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 09:18:42 +0000 Subject: [Koha-bugs] [Bug 23927] Duplicate a "Complete" order link the "New" one to the invoice In-Reply-To: <bug-23927-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23927-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23927-70-lBBZpuxTxp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23927 --- Comment #11 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 10:26:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 09:26:25 +0000 Subject: [Koha-bugs] [Bug 23955] Replace famfamfam icon in OPAC holds template In-Reply-To: <bug-23955-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23955-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23955-70-6A946zMYiX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23955 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 10:26:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 09:26:27 +0000 Subject: [Koha-bugs] [Bug 23955] Replace famfamfam icon in OPAC holds template In-Reply-To: <bug-23955-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23955-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23955-70-GST6JYkFLM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23955 --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 10:26:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 09:26:29 +0000 Subject: [Koha-bugs] [Bug 23958] Use Font Awesome icon to replace "new window" icon image In-Reply-To: <bug-23958-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23958-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23958-70-5KjwJsatR8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23958 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 10:26:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 09:26:31 +0000 Subject: [Koha-bugs] [Bug 23958] Use Font Awesome icon to replace "new window" icon image In-Reply-To: <bug-23958-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23958-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23958-70-t4UjSKUdpo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23958 --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Nice work! Pushed to master for 19.11.00 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 10:41:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 09:41:54 +0000 Subject: [Koha-bugs] [Bug 3041] Permit to change hidden settings for all subfields of a tag at once In-Reply-To: <bug-3041-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-3041-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-3041-70-6ikOPXFzEr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=3041 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 10:42:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 09:42:46 +0000 Subject: [Koha-bugs] [Bug 10469] Display more when editing subfields in frameworks In-Reply-To: <bug-10469-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10469-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10469-70-4WUjCaqFoV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10469 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 10:43:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 09:43:13 +0000 Subject: [Koha-bugs] [Bug 10470] way to add multiple subfields to frameworks In-Reply-To: <bug-10470-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10470-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10470-70-6JwFTg20Fu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10470 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr --- Comment #2 from Séverine Queune <severine.queune at bulac.fr> --- (In reply to emjhet from comment #1) > I agree that it is unnecessarily time consuming to have to save each > subfield individually. +1 ! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 10:44:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 09:44:03 +0000 Subject: [Koha-bugs] [Bug 21927] Acq: Allow blank values in pull downs in the item form when subfield is mandatory In-Reply-To: <bug-21927-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21927-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21927-70-xZHDwCSjJU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21927 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |severine.queune at bulac.fr -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 10:54:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 09:54:16 +0000 Subject: [Koha-bugs] [Bug 24122] Typo in administration.rst In-Reply-To: <bug-24122-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24122-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24122-70-5vPCuBIOJM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24122 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Resolution|FIXED |MOVED -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 11:01:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 10:01:55 +0000 Subject: [Koha-bugs] [Bug 20604] Provide a way to anonymise patron records In-Reply-To: <bug-20604-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20604-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20604-70-PXxb6jMl6h@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20604 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |ASSIGNED CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org Change sponsored?|--- |Sponsored -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 11:03:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 10:03:14 +0000 Subject: [Koha-bugs] [Bug 24112] Cannot edit or save a patron when a duplicate is found In-Reply-To: <bug-24112-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24112-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24112-70-ngZQOGJRVy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24112 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |INVALID -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 11:05:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 10:05:24 +0000 Subject: [Koha-bugs] [Bug 24075] Backdating a return to the exact due date and time results in the fine not being refunded In-Reply-To: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24075-70-L4PJcYjQvj@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24075 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |fridolin.somers at biblibre.co | |m -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 11:11:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 10:11:30 +0000 Subject: [Koha-bugs] [Bug 19016] Add a script to fix corrupted data In-Reply-To: <bug-19016-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19016-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19016-70-q8V09fQnyE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19016 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |WONTFIX --- Comment #23 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- This approach never received the necessary feedbacks from upgrades done in production environment. Closing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 11:19:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 10:19:02 +0000 Subject: [Koha-bugs] [Bug 12825] GST / VAT rewrite In-Reply-To: <bug-12825-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12825-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12825-70-WtwekiEbjz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12825 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Considering this done. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 11:19:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 10:19:03 +0000 Subject: [Koha-bugs] [Bug 10253] tax rate only takes 1 decimal point In-Reply-To: <bug-10253-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10253-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10253-70-TwhRdMUOlO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10253 Bug 10253 depends on bug 12825, which changed state. Bug 12825 Summary: GST / VAT rewrite https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12825 What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 11:23:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 10:23:21 +0000 Subject: [Koha-bugs] [Bug 14819] Add missing DBIx::Class relationships - biblio<->biblioitem<->item In-Reply-To: <bug-14819-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14819-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14819-70-4jjIGS03BX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14819 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED Status|Failed QA |RESOLVED See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14544 --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Done by commit 2410afd7b768bbdd69db5fa21bee9715bd4650d1 Bug 14544: Add missing biblio <=> biblioitems <=> items relationships to the schema among others... -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 11:23:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 10:23:22 +0000 Subject: [Koha-bugs] [Bug 14818] Add missing DBIx::Class relationships In-Reply-To: <bug-14818-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14818-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14818-70-CAfR3KoCWp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14818 Bug 14818 depends on bug 14819, which changed state. Bug 14819 Summary: Add missing DBIx::Class relationships - biblio<->biblioitem<->item https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14819 What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 11:23:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 10:23:21 +0000 Subject: [Koha-bugs] [Bug 14544] Move the list related code to Koha::Virtualshelves In-Reply-To: <bug-14544-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14544-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14544-70-B5ok3jYhBp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14544 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=14819 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 11:30:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 10:30:19 +0000 Subject: [Koha-bugs] [Bug 19121] Prevent XSS in the Staff Client and the OPAC - bis In-Reply-To: <bug-19121-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19121-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19121-70-wzQX2x02v5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19121 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=13618 | Status|In Discussion |RESOLVED Resolution|--- |DUPLICATE --- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Hum, that was wrong! We dealt with that on bug 13618 (second try). *** This bug has been marked as a duplicate of bug 13618 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 11:30:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 10:30:19 +0000 Subject: [Koha-bugs] [Bug 13618] Add additional template filter methods and a filter presence test to Koha In-Reply-To: <bug-13618-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13618-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13618-70-CaES5jaZ5T@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13618 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also|https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=19121 | --- Comment #271 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- *** Bug 19121 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 11:31:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 10:31:29 +0000 Subject: [Koha-bugs] [Bug 24075] Backdating a return to the exact due date and time results in the fine not being refunded In-Reply-To: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24075-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24075-70-6ak9Y3QfkS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24075 Fridolin SOMERS <fridolin.somers at biblibre.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)|19.11.00 |19.11.00,19.05.05 released in| | Status|Pushed to master |Pushed to stable --- Comment #21 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- Pushed to 19.05.x for 19.05.05 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 11:37:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 10:37:15 +0000 Subject: [Koha-bugs] [Bug 19819] C4::Context->dbh is unreasonably slow In-Reply-To: <bug-19819-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19819-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19819-70-CPrpIyzH3N@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19819 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|INVALID |DUPLICATE --- Comment #16 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I forgot about bug 16156, it has a patch that was waiting for feedback. The idea was similar, but $dbh cache would be flushed when needed. *** This bug has been marked as a duplicate of bug 16156 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 11:37:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 10:37:15 +0000 Subject: [Koha-bugs] [Bug 16156] Do not ensure the dbh is connected all the time In-Reply-To: <bug-16156-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16156-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16156-70-ZYmKzfKjqN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16156 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |glasklas at gmail.com --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- *** Bug 19819 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 11:39:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 10:39:09 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: <bug-14570-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14570-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14570-70-JpCREduLsv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This development adds the |This development adds the release notes|ability for a patron to |ability for a patron to |have an unlimited number of |have an unlimited number of |guarantors in any |guarantors in any |combination of existing |combination of existing |Koha patrons and manually |Koha patrons and manually |added guarantors ( e.g. the |added guarantors ( e.g. the |person has no patron record |guarantor has no patron |in Koha ). |record in Koha ). | | |This feature |This |retains the existing |feature retains the |behavior for importing |existing behaviour for |guarantors during patron |importing guarantors during |imports. |patron imports; However, | |guarantors can no longer be |Guarantors can no |viewed, added or updated |longer be |via the REST API. |viewed/added/updated from | |the REST API. |Reports | |that utilize |Reports that |`borrowers.guarantorid` |utilize |will need to be updated. |borrowers.guarantorid will | |need to be updated. |Sponsored by: Northeast | |Kansas Library System |Sponsored by: Northeast |<http://www.nekls.org> |Kansas Library System |Vermont Organization of |<http://www.nekls.org> |Koha Automated Libraries |Vermont Organization of |<http://gmlc.org/index.php/ |Koha Automated Libraries |vokal> |<http://gmlc.org/index.php/ | |vokal> | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 11:42:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 10:42:05 +0000 Subject: [Koha-bugs] [Bug 13193] Make Memcached usage fork safe In-Reply-To: <bug-13193-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13193-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13193-70-ijqKFLMPaT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 Alexander Borkowski <alexander.borkowski at kau.se> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |alexander.borkowski at kau.se -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 11:42:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 10:42:45 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: <bug-14570-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14570-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14570-70-qbByTBHIiy@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This development adds the |This development adds the release notes|ability for a patron to |ability for a patron to |have an unlimited number of |have an unlimited number of |guarantors in any |guarantors in any |combination of existing |combination of existing |Koha patrons and manually |Koha patrons and manually |added guarantors ( e.g. the |added guarantors ( e.g. the |guarantor has no patron |guarantor has no patron |record in Koha ). |record in Koha ). | | |This |This |feature retains the |feature retains the |existing behaviour for |existing behaviour for |importing guarantors during |importing guarantors during |patron imports; However, |patron imports; However, |guarantors can no longer be |guarantors can no longer be |viewed, added or updated |viewed, added or updated |via the REST API. |via the REST API. | | |Reports |Reports |that utilize |that utilize |`borrowers.guarantorid` |`borrowers.guarantorid` |will need to be updated. |will need to be updated. | | |Sponsored by: Northeast | |Kansas Library System | |<http://www.nekls.org> | |Vermont Organization of | |Koha Automated Libraries | |<http://gmlc.org/index.php/ | |vokal> | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 11:43:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 10:43:12 +0000 Subject: [Koha-bugs] [Bug 14570] Make it possible to add multiple guarantors to a record In-Reply-To: <bug-14570-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14570-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14570-70-yExs4Oybtt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14570 --- Comment #242 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Sponsorship lines moved into git commit for release notes and about page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 11:48:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 10:48:27 +0000 Subject: [Koha-bugs] [Bug 22706] Add plugin hooks to allow custom password strength checking modules In-Reply-To: <bug-22706-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22706-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22706-70-RNZp1c0UQx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22706 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This new feature allows release notes| |plugin authors to implement | |a `check_password` method | |to enable custom password | |validation routines. | | | |**Warning**: Care should be | |taken when installing any | |plugins and only plugins | |you trust should be used. | |The hook introduced here | |allows plugin authors to | |potentially steel plain | |text passwords during | |patron creations and | |updates. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 11:48:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 10:48:35 +0000 Subject: [Koha-bugs] [Bug 22706] Add plugin hooks to allow custom password strength checking modules In-Reply-To: <bug-22706-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22706-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22706-70-Azgvy6MSDe@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22706 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|release-notes-needed | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 11:52:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 10:52:33 +0000 Subject: [Koha-bugs] [Bug 22709] Add hooks to notify plugins of biblio and item changes In-Reply-To: <bug-22709-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22709-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22709-70-7sYQBAS0Hu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22709 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This new feature allows release notes| |plugin authors to implement | |`after_biblio_action` and | |`after_item_action` methods | |which may be used to take | |various actions upon biblio | |and item creations, | |modifications and | |deletions. | | | |**Warning**: | |Care should be taken when | |installing any plugins and | |only plugins you trust | |should be used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 11:56:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 10:56:00 +0000 Subject: [Koha-bugs] [Bug 22834] Add a method for plugins to return the absolute path for bundled files In-Reply-To: <bug-22834-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22834-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22834-70-uF1kQN75Wn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22834 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This new feature allows release notes| |plugin authors to construct | |absolute paths to resources | |contained within their | |plugins using the new | |`bundle_path` method. | | | |This | |can be used to aid in | |serving static content. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 11:56:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 10:56:20 +0000 Subject: [Koha-bugs] [Bug 22834] Add a method for plugins to return the absolute path for bundled files In-Reply-To: <bug-22834-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22834-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22834-70-E0jE3kAI3r@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22834 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This new feature allows |This new feature allows release notes|plugin authors to construct |plugin authors to construct |absolute paths to resources |absolute paths to resources |contained within their |contained within their |plugins using the new |plugins using the new |`bundle_path` method. |`bundle_path` method. | | |This |This |can be used to aid in |can be used to aid in |serving static content. |serving static content. | | | |**Warning**: Care should be | |taken when installing any | |plugins and only plugins | |you trust should be used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 11:57:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 10:57:17 +0000 Subject: [Koha-bugs] [Bug 22835] Serve static files from plugins through the API In-Reply-To: <bug-22835-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22835-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22835-70-X8nqtnqcqu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22835 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This development allows |This new feature allows release notes|plugins to serve static |plugin authors to serve |files through the API |static files through the |without the requirement to |API without the requirement |tweak the Apache |to tweak the Apache |configuration files. Routes |configuration files. Routes |to the static files tree |to the static files tree |are automatically loaded |are automatically loaded |from a specially crafted |from a specially crafted |file the plugin authors |file the plugin authors |need to include in the |need to include in the |distributed .kpz files. |distributed .kpz files. | | | |**Warning**: Care should be | |taken when installing any | |plugins and only plugins | |you trust should be used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 12:00:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 11:00:18 +0000 Subject: [Koha-bugs] [Bug 23050] Add hook to add a tab in intranet biblio details page In-Reply-To: <bug-23050-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23050-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23050-70-kQyyqZ7Cjl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23050 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |This new feature allows release notes| |plugin authors to add | |additional tabs to the | |intranet biblio details | |page. The new | |`intranet_catalog_biblio_ta | |b` method which should | |return an array of | |`Koha::Plugins::Tab` | |objects is introduced. | | | |**Warning**: Care should be | |taken when installing any | |plugins and only plugins | |you trust should be used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 12:01:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 11:01:00 +0000 Subject: [Koha-bugs] [Bug 23237] Add support for [% INCLUDE %] in plugin templates In-Reply-To: <bug-23237-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23237-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23237-70-idqklYjjwg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23237 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|The new feature allows |The new feature allows release notes|plugin authors to use |plugin authors to use |template `[% INCLUDE %]` |template `[% INCLUDE %]` |directives in their |directives in their |templates. It does so by |templates. It does so by |introducing a new variable, |introducing a new variable, |`PLUGIN_DIR`, allowing the |`PLUGIN_DIR`, allowing the |template engine to locate |template engine to locate |the includes. |the includes. | | |**Usage**: |**Usage**: |`[% INCLUDE |`[% INCLUDE |"$PLUGIN_DIR/header.tt" %]` |"$PLUGIN_DIR/header.tt" %]` | | | |**Warning**: Care should | |be taken when installing | |any plugins and only | |plugins you trust should be | |used. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 12:11:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 11:11:32 +0000 Subject: [Koha-bugs] [Bug 15350] DBIx::Class Startup speed In-Reply-To: <bug-15350-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15350-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15350-70-W8NHmbSDNO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15350 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Resolution|--- |FIXED See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20582 Status|In Discussion |RESOLVED --- Comment #8 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Nothing more from here, closing. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 12:11:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 11:11:32 +0000 Subject: [Koha-bugs] [Bug 15342] Performance 3.22 - Omnibus In-Reply-To: <bug-15342-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15342-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15342-70-v8Ihv87Rtu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15342 Bug 15342 depends on bug 15350, which changed state. Bug 15350 Summary: DBIx::Class Startup speed https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15350 What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |RESOLVED Resolution|--- |FIXED -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 12:11:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 11:11:32 +0000 Subject: [Koha-bugs] [Bug 20582] Turn Koha into a Mojolicious application In-Reply-To: <bug-20582-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20582-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20582-70-azYUU0DFFs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20582 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=15350 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 12:12:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 11:12:26 +0000 Subject: [Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype In-Reply-To: <bug-22610-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22610-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22610-70-wl0Z0PSxjN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the| |**Reports note**: SIP2 release notes| |`accounttypes` have been | |deprecated in favour of | |using standard accounttypes | |across transactions in the | |accountlines. Reports | |should be updated to use | |`payment_type` to | |distinguish between the | |diffrent SIP2 payment type | |as required. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 12:12:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 11:12:34 +0000 Subject: [Koha-bugs] [Bug 22610] SIP Payment Types should be moved out of accountype In-Reply-To: <bug-22610-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22610-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22610-70-3o0eVfVVNg@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22610 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|**Reports note**: SIP2 |**Reports note**: SIP2 release notes|`accounttypes` have been |`accounttypes` have been |deprecated in favour of |deprecated in favour of |using standard accounttypes |using standard accounttypes |across transactions in the |across transactions in the |accountlines. Reports |accountlines. Reports |should be updated to use |should be updated to use |`payment_type` to |`payment_type` to |distinguish between the |distinguish between the |diffrent SIP2 payment type |different SIP2 payment type |as required. |as required. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 12:14:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 11:14:21 +0000 Subject: [Koha-bugs] [Bug 17179] Advanced editor: Add keyboard shortcuts to repeat (duplicate) a field, and cut text In-Reply-To: <bug-17179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17179-70-Kewp6kROIJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Severity|enhancement |new feature -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 12:15:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 11:15:00 +0000 Subject: [Koha-bugs] [Bug 17179] Advanced editor: Add keyboard shortcuts to repeat (duplicate) a field, and cut text In-Reply-To: <bug-17179-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17179-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17179-70-nSJwLddz9m@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17179 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This patchset introduces an |This patchset introduces an release notes|internal clipboard to the |internal clipboard to the |advanced editor and |advanced editor and |provides some new |provides some new |functionality to make use |functionality to make use |of it; The following |of it; The following |default shortcuts are |default shortcuts are |provided but can be edited |provided but can be edited |as per bug 21411. |as per bug 21411. | | |Changed: |Changed: |* `Ctrl-X`: Now cuts a line |* `Ctrl-X`: Now cuts a line |into the clipboard area |into the clipboard area |* |* |`Shift-Ctrl-X`: Now cuts |`Shift-Ctrl-X`: Now cuts |current subfield into |current subfield into |clipboard area |clipboard area | | |Added: |Added: |* |* |`Ctrl-C`: Copies a line |`Ctrl-C`: Copies a line |into the clipboard area |into the clipboard area |* |* |`Shift-Ctrl-C`: Copies |`Shift-Ctrl-C`: Copies |current subfield into |current subfield into |clipboard area |clipboard area |* `Ctrl-P`: |* `Ctrl-P`: |Pastes the selected item |Pastes the selected item |from the clipboard at |from the clipboard at |cursor |cursor |* `Ctrl-I`: Copies |* `Ctrl-I`: Copies |the current line and |the current line and |inserts onto a new line |inserts onto a new line |below |below | | |Sponsored by: Round | |Rock Public Library | |<https://www.roundrocktexas | |.gov/departments/library/> | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 12:15:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 11:15:33 +0000 Subject: [Koha-bugs] [Bug 14697] Extend and enhance "Claims returned" lost status In-Reply-To: <bug-14697-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14697-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14697-70-ejbv2f60Yq@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14697 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement extends |This enhancement extends release notes|the "Claims returned" lost |the "Claims returned" lost |status and allows staff to |status and allows staff to |track items that patrons |track items that patrons |claim to have returned. |claim to have returned. |Items are marked as "Claims |Items are marked as "Claims |returned" from the checkout |returned" from the checkout |page in the staff side. |page in the staff side. | | |There are 3 new systems |There are 3 new systems |preferences to set for this |preferences to set for this |functionality to work: |functionality to work: |`ClaimReturnedChargeFee`, |`ClaimReturnedChargeFee`, |`ClaimReturnedLostValue` |`ClaimReturnedLostValue` |and |and |`ClaimReturnedWarningThresh |`ClaimReturnedWarningThresh |old` |old` | | |Sponsored by: Fargo | |Public Library | |<http://fargond.gov/city-go | |vernment/departments/librar | |y> | |North Central Regional | |Library System | |<http://www.ncrl.org> | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 12:16:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 11:16:58 +0000 Subject: [Koha-bugs] [Bug 17168] Add a command line script for updating patron category based on status In-Reply-To: <bug-17168-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17168-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17168-70-yxiDqyVtXH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17168 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|These patches introduce a |These patches introduce a release notes|new script to replace the |new script to replace the |`j2a.pl` script with a more |`j2a.pl` script with a more |flexible set of options. |flexible set of options. | | |`misc/cronjobs/update_patro |`misc/cronjobs/update_patro |ns_category.pl` can now be |ns_category.pl` can now be |used to update patrons who |used to update patrons who |are older or younger than |are older or younger than |their patron categories to |their patron categories to |a category chosen by the |a category chosen by the |user. |user. | | |Additionally, this |Additionally, this |script allows users to |script allows users to |specify a fine total to |specify a fine total to |update patrons, to use any |update patrons, to use any |specified borrowers field, |specified borrowers field, |and to run by category |and to run by category |and/or branch. |and/or branch. | | |The |The |intention here is to assist |intention here is to assist |in automating updating |in automating updating |patrons for schools or |patrons for schools or |libraries where patrons are |libraries where patrons are |regularly changed - patrons |regularly changed - patrons |with fines can be moved to |with fines can be moved to |'probational statuses' or |'probational statuses' or |patrons without fines can |patrons without fines can |be moved to 'privileged |be moved to 'privileged |statuses'. |statuses'. | | |The flexibility |The flexibility |should allow for various |should allow for various |workflows to be automated |workflows to be automated |via cronjob. |via cronjob. | | |Sponsored by: | |Round Rock Public Library | |<https://www.roundrocktexas | |.gov/departments/library/> | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 12:19:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 11:19:08 +0000 Subject: [Koha-bugs] [Bug 20292] Filter/censor info sent via SIP In-Reply-To: <bug-20292-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20292-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20292-70-GOmoSyqjyJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20292 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement allows the |This enhancement allows the release notes|administrator to set if, |administrator to set if, |and which, fields should |and which, fields should |not be sent to third party |not be sent to third-party |SIP2 clients for privacy |SIP2 clients for privacy |reasons. |reasons. |Sponsored by: | |Uintah and Duchesne County | |Library | |<http://uintahlibrary.org/> | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 12:20:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 11:20:19 +0000 Subject: [Koha-bugs] [Bug 20954] Add ability to set syspref overrides in SIP as we can in Apache In-Reply-To: <bug-20954-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20954-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20954-70-8lr2XmFbky@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20954 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Sponsored by: South East | release notes|Kansas Library System | |<http://www.sekls.org/> | CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 12:22:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 11:22:03 +0000 Subject: [Koha-bugs] [Bug 22996] Move barcode separators to a preference In-Reply-To: <bug-22996-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22996-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22996-70-0oQExG6c62@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22996 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Text to go in the|Adds preference |Adds preference release notes|BarcodeSeparators. |`BarcodeSeparators` |NOTE: If | |you currently depend on |**NOTE**: If you currently |comma, semicolon, pipe char |depend on a comma, |or hyphen as a barcode |semicolon, pipe character |separator within inventory |or hyphen as a barcode |tool, please ADD them to |separator within inventory |this new preference. The |tool, please ADD them to |default behavior is set |this new preference. The |back to carriage return, |default behaviour is set |linefeed or whitespace now. |back to a carriage return, | |linefeed or whitespace now. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 12:23:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 11:23:50 +0000 Subject: [Koha-bugs] [Bug 13958] Add a suspensionsCalendar syspref In-Reply-To: <bug-13958-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13958-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13958-70-KXDluzxm5H@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13958 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Before 18.05, suspension |Before 18.05, suspension release notes|expiry date calculation |expiry date calculation |didn't take the calendar |didn't take the calendar |into account. This behavior |into account. This |changed with bug 19204, and |behaviour changed with bug |some libraries miss the old |19204, and some libraries |behavior. This patches |miss the old behaviour. |decouple overdue days | |calculation configuration |These patches decouple |(finesCalendar) from how |overdue days calculation |the expiry date is |configuration |calculated for the |(`finesCalendar`) from how |suspension through a new |the expiry date is |system preference: |calculated for the |SuspensionsCalendar, that |suspension through a new |has the exact same options |system preference: |but only applies to |`SuspensionsCalendar`, that |suspensions. During |has the exact same options |upgrade, the new preference |but only applies to |is populated with the value |suspensions. On upgrade, |from 'finesCalendar', thus |the new preference is |respecting the current |populated with the value |configuration. |from `finesCalendar`, thus | |respecting the current | |configuration. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 12:24:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 11:24:20 +0000 Subject: [Koha-bugs] [Bug 17526] OPAC lists sortfield breaks with a `(` In-Reply-To: <bug-17526-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17526-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17526-70-M2N3hbOoJX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17526 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|OPAC lists sortfield breaks |OPAC lists sortfield breaks |with a ( |with a `(` -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 12:25:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 11:25:25 +0000 Subject: [Koha-bugs] [Bug 20780] EDI: Add support for 'AcqItemSetSubfieldsWhenReceived' In-Reply-To: <bug-20780-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20780-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20780-70-lMjSJWW5xQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20780 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|EDIFACT receipting of items |EDIFACT receipting of items release notes|should now respect the |should now respect the |AcqItemSetSubfieldsWhenRece |`AcqItemSetSubfieldsWhenRec |ived systempreference |eived` system preference -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 12:26:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 11:26:16 +0000 Subject: [Koha-bugs] [Bug 24128] New: Add alias for biblionumber => local-number Message-ID: <bug-24128-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24128 Bug ID: 24128 Summary: Add alias for biblionumber => local-number Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: nick at bywatersolutions.com This was setup in zebra - it would be nice to preserve this functionality -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 12:28:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 11:28:32 +0000 Subject: [Koha-bugs] [Bug 24128] Add alias for biblionumber => local-number In-Reply-To: <bug-24128-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24128-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24128-70-kBiRRoYcjH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24128 --- Comment #1 from Nick Clemens <nick at bywatersolutions.com> --- Created attachment 95846 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95846&action=edit Bug 24128: Add alias for biblionumber search To test: 1 - In staff or OPAC using ES, search for "biblionumber:3" or any existing biblionumber 2 - No results 3 - Apply patch, restart all the things 4 - Search again 5 - You go to the biblionumber -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 12:28:53 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 11:28:53 +0000 Subject: [Koha-bugs] [Bug 24128] Add alias for biblionumber => local-number In-Reply-To: <bug-24128-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24128-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24128-70-WwevwMfocB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24128 Nick Clemens <nick at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Assignee|koha-bugs at lists.koha-commun |nick at bywatersolutions.com |ity.org | CC| |andrew at bywatersolutions.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 12:39:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 11:39:26 +0000 Subject: [Koha-bugs] [Bug 19618] Add 'Club Holds' feature In-Reply-To: <bug-19618-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19618-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19618-70-mWyoiXUpbI@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19618 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This new feature adds the |This new feature adds the release notes|ability for clubs to place |ability for clubs to place |a hold for bibs. When such |a hold for bibs. When such |a hold is placed, in the |a hold is placed, in the |background a hold will be |background a hold will be |automatically placed for |automatically placed for |each member of the group in |each member of the group in |random order. |random order. | | |Sponsored | |by: Southeast Kansas | |Library System | |<http://www.sekls.org/> | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 12:39:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 11:39:55 +0000 Subject: [Koha-bugs] [Bug 23522] Show "Actual price" in basket when available In-Reply-To: <bug-23522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23522-70-p46VngvMd6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23522 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Sponsored by: Virginia Tech | release notes|<https://lib.vt.edu/> | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 12:41:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 11:41:26 +0000 Subject: [Koha-bugs] [Bug 15497] Limit item types by library In-Reply-To: <bug-15497-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15497-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15497-70-KRVVRqPvih@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15497 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Sponsored by: Central | release notes|Kansas Library System | |<https://ckls.org/> | |Northeast Kansas Library | |System | |<http://www.nekls.org> | |Southeast Kansas Library | |System | |<http://www.sekls.org/> | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 12:41:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 11:41:41 +0000 Subject: [Koha-bugs] [Bug 17178] Add a popup/keyboard shortcuts for diacritics and symbols in the advanced cataloging editor In-Reply-To: <bug-17178-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-17178-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-17178-70-Yj7kUH5t5a@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17178 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|Sponsored by: Round Rock | release notes|Public Library | |<https://www.roundrocktexas | |.gov/departments/library/> | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 13:48:41 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 12:48:41 +0000 Subject: [Koha-bugs] [Bug 24010] Number of issues to display to staff accepts non-integer values In-Reply-To: <bug-24010-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24010-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24010-70-2iOdqIfFAM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24010 --- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Owen, you suggested me to use the new version of jQuery Validate (from bug 24089), but it still does not work for me. >From IRC: <Joubu> oleonard: does it work with the new version? <oleonard> Yes. I suggest you favor the "validated" class and add 'data-rule-number="true"' to the inputs -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 13:49:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 12:49:28 +0000 Subject: [Koha-bugs] [Bug 24010] Number of issues to display to staff accepts non-integer values In-Reply-To: <bug-24010-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24010-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24010-70-fAW9lot4SO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24010 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95718|0 |1 is obsolete| | --- Comment #11 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95847 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95847&action=edit Bug 24010: Enforce integer values for staffdisplaycount and opacdisplaycount (second try) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 14:11:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 13:11:20 +0000 Subject: [Koha-bugs] [Bug 22437] Subsequent authority merges in cron cause biblios to lose authority information In-Reply-To: <bug-22437-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22437-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22437-70-E5kpJt0HSS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22437 --- Comment #4 from Pedro Amorim <pjamorim91 at gmail.com> --- Created attachment 95848 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95848&action=edit Previous attachment had a typo -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 14:12:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 13:12:00 +0000 Subject: [Koha-bugs] [Bug 22437] Subsequent authority merges in cron cause biblios to lose authority information In-Reply-To: <bug-22437-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22437-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22437-70-6brnBtYy1W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22437 Pedro Amorim <pjamorim91 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95836|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 14:12:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 13:12:19 +0000 Subject: [Koha-bugs] [Bug 9290] Restricting patron category for online purchase suggestion In-Reply-To: <bug-9290-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-9290-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-9290-70-aaL5zPkZ0W@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=9290 --- Comment #11 from Vinod <mishravk79 at gmail.com> --- Hello Is there any update on this development, please? -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 14:18:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 13:18:04 +0000 Subject: [Koha-bugs] [Bug 21177] Use koha-conf.xml in misc/devel/update_dbix_class_files.pl In-Reply-To: <bug-21177-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21177-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21177-70-2eKQt0LUDn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21177 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 14:18:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 13:18:07 +0000 Subject: [Koha-bugs] [Bug 21177] Use koha-conf.xml in misc/devel/update_dbix_class_files.pl In-Reply-To: <bug-21177-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21177-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21177-70-4hMVLJCi5Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21177 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #77574|0 |1 is obsolete| | --- Comment #9 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95849 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95849&action=edit Bug 21177: Use koha-conf.xml in misc/devel/update_dbix_class_files.pl It is annoying to have to specify database connection parameters each time DBIx::Class files need to be updated. This patch adds a new option --koha-conf that takes an optional <path> which defaults to the value of KOHA_CONF environment variable, and use the database connection parameters found in that file. --db_* options override values from $KOHA_CONF Test plan: 1. Run the script with the same parameters as before the patch and see that it still works. Example: misc/devel/update_dbix_class_files.pl --db_name koha_dev \ --db_user koha --db_pass koha 2. Verify that KOHA_CONF is set and execute: misc/devel/update_dbix_class_files.pl --koha-conf Verify that Koha/Schema files were updated accordingly 3. Execute: misc/devel/update_dbix_class_files.pl --koha-conf \ /path/to/another/koha-conf.xml Verify that Koha/Schema files were updated accordingly Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 14:18:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 13:18:46 +0000 Subject: [Koha-bugs] [Bug 21177] Use koha-conf.xml in misc/devel/update_dbix_class_files.pl In-Reply-To: <bug-21177-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21177-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21177-70-4AT95e7VnY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21177 --- Comment #10 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to Julian Maurice from comment #7) > (In reply to Jonathan Druart from comment #6) > > (In reply to Julian Maurice from comment #4) > > > (In reply to Jonathan Druart from comment #3) > > > > Maybe we could even remove the need of the option (--koha-conf) and make it > > > > the default? > > > > > > I think that making it the default can potentially break existing workflows. > > > > What I meant was to use info from $ENV{KOHA_CONF} if called without options. > > Ah so you mean use $KOHA_CONF *only* if no other options is specified ? Yes. Not blocker. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 14:29:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 13:29:42 +0000 Subject: [Koha-bugs] [Bug 24095] Missing MSG_CONFIRM_DELETE_HOLD variable on the OPAC user account page In-Reply-To: <bug-24095-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24095-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24095-70-hgS2uoMycD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24095 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Depends on| |21772 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- From commit 6a7d4b19c7fa224fc1a5abd596a81d3ca52f43f9 Bug 21772: Move OPAC holds and account tables into .inc Also needed in sco/sco-main.tt Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 [Bug 21772] Add holds and account information tab to the SCO module -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 14:29:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 13:29:42 +0000 Subject: [Koha-bugs] [Bug 21772] Add holds and account information tab to the SCO module In-Reply-To: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21772-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21772-70-OoTKRE37Zb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21772 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24095 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24095 [Bug 24095] Missing MSG_CONFIRM_DELETE_HOLD variable on the OPAC user account page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 14:52:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 13:52:57 +0000 Subject: [Koha-bugs] [Bug 24129] New: Add ability to configure some indexes to not autotruncate Message-ID: <bug-24129-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24129 Bug ID: 24129 Summary: Add ability to configure some indexes to not autotruncate Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: Searching - Elasticsearch Assignee: koha-bugs at lists.koha-community.org Reporter: andrew at bywatersolutions.com To Test: - Set QueryAutoTruncate to Automatically - Set search engine to Zebra - search for sn:1 - Confirm you only get biblionumber 1 in your results - Set search engine to Elastic - search for sn:1 - confirm you get bibs 1, 10, 11, 100, etc Zebra apparently knows to ignore autotruncate for some instances. We should at least maintain that behavior. It would probably be good to go a step further and make it configurable per index in our search engine config. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 14:53:07 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 13:53:07 +0000 Subject: [Koha-bugs] [Bug 24129] Add ability to configure some indexes to not autotruncate In-Reply-To: <bug-24129-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24129-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24129-70-cmRNwHqW3Y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24129 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |nick at bywatersolutions.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 16:33:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 15:33:26 +0000 Subject: [Koha-bugs] [Bug 24130] New: Update 18.12.00.024 can fail due to bad date data Message-ID: <bug-24130-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24130 Bug ID: 24130 Summary: Update 18.12.00.024 can fail due to bad date data Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: blocker Priority: P5 - low Component: Database Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org DBD::mysql::db do failed: Incorrect date value: '0000-00-00' for column 'suggesteddate' at row 1 [for Statement "ALTER TABLE suggestions ADD CONSTRAINTsuggestions_ibfk_suggestedbyFOREIGN KEY (suggestedby) REFERENCESborrowers(borrowernumber) ON DELETE SET NULL ON UPDATE CASCADE"] at /installer/data/mysql/updatedatabase.pl line 17646. DBD::mysql::db do failed: Incorrect date value: '0000-00-00' for column 'suggesteddate' at row 1 [for Statement "ALTER TABLE suggestions ADD CONSTRAINTsuggestions_ibfk_managedbyFOREIGN KEY (managedby) REFERENCESborrowers(borrowernumber) ON DELETE SET NULL ON UPDATE CASCADE"] at /installer/data/mysql/updatedatabase.pl line 17657. DBD::mysql::db do failed: Incorrect date value: '0000-00-00' for column 'suggesteddate' at row 1 [for Statement "ALTER TABLE suggestions ADD CONSTRAINTsuggestions_ibfk_acceptedbyFOREIGN KEY (acceptedby) REFERENCESborrowers(borrowernumber) ON DELETE SET NULL ON UPDATE CASCADE"] at /installer/data/mysql/updatedatabase.pl line 17669. DBD::mysql::db do failed: Incorrect date value: '0000-00-00' for column 'suggesteddate' at row 1 [for Statement "ALTER TABLE suggestions ADD CONSTRAINTsuggestions_ibfk_rejectedbyFOREIGN KEY (rejectedby) REFERENCESborrowers(borrowernumber) ON DELETE SET NULL ON UPDATE CASCADE"] at /installer/data/mysql/updatedatabase.pl line 17681. DBD::mysql::db do failed: Incorrect date value: '0000-00-00' for column 'suggesteddate' at row 1 [for Statement "ALTER TABLE suggestions ADD CONSTRAINTsuggestions_ibfk_biblionumberFOREIGN KEY (biblionumber) REFERENCESbiblio(biblionumber) ON DELETE SET NULL ON UPDATE CASCADE"] at /installer/data/mysql/updatedatabase.pl line 17693. DBD::mysql::db do failed: Incorrect date value: '0000-00-00' for column 'suggesteddate' at row 1 [for Statement "ALTER TABLE suggestions ADD CONSTRAINTsuggestions_ibfk_branchcodeFOREIGN KEY (branchcode) REFERENCESbranches(branchcode) ON DELETE SET NULL ON UPDATE CASCADE"] at /installer/data/mysql/updatedatabase.pl line 17705. This is undoubtedly due to bad data having been left behind after bug 12627. I think the most pragmatic approach is to just update any such values with a default date far in the past. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 16:35:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 15:35:31 +0000 Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha namespace In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20443-70-ylShy3q7Cu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443 --- Comment #17 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Remote branch rebased against master. The failing test is fixed! -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 16:35:58 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 15:35:58 +0000 Subject: [Koha-bugs] [Bug 24130] Update 18.12.00.024 can fail due to bad date data In-Reply-To: <bug-24130-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24130-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24130-70-IEIyWHEFLv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24130 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 16:36:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 15:36:02 +0000 Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha namespace In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20443-70-AtYNXs2QK8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- URL| |https://gitlab.com/joubu/Ko | |ha/commits/bug_20443 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 16:55:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 15:55:10 +0000 Subject: [Koha-bugs] [Bug 24130] Update 18.12.00.024 can fail due to bad date data In-Reply-To: <bug-24130-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24130-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24130-70-LL7RPaLeA6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24130 --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95850 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95850&action=edit Bug 24130: (RM follow-up) Fix old invalid data Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 16:55:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 15:55:22 +0000 Subject: [Koha-bugs] [Bug 24130] Update 18.12.00.024 can fail due to bad date data In-Reply-To: <bug-24130-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24130-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24130-70-iL4YICmSaT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24130 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 16:55:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 15:55:27 +0000 Subject: [Koha-bugs] [Bug 24130] Update 18.12.00.024 can fail due to bad date data In-Reply-To: <bug-24130-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24130-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24130-70-xMjB1RpHS0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24130 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 16:55:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 15:55:32 +0000 Subject: [Koha-bugs] [Bug 24130] Update 18.12.00.024 can fail due to bad date data In-Reply-To: <bug-24130-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24130-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24130-70-CTEqts6DJn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24130 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 16:55:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 15:55:36 +0000 Subject: [Koha-bugs] [Bug 24130] Update 18.12.00.024 can fail due to bad date data In-Reply-To: <bug-24130-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24130-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24130-70-PIbmDjW6he@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24130 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Passed QA |Pushed to master -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 16:55:43 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 15:55:43 +0000 Subject: [Koha-bugs] [Bug 24130] Update 18.12.00.024 can fail due to bad date data In-Reply-To: <bug-24130-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24130-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24130-70-0ZFY5t9NKt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24130 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version(s)| |19.11.00 released in| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 17:08:55 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 16:08:55 +0000 Subject: [Koha-bugs] [Bug 19014] Patrons should not get an 'on_reserve' notification if the due date is far into the future In-Reply-To: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19014-70-Jcmh20UZh4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95348|0 |1 is obsolete| | --- Comment #46 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 95851 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95851&action=edit Bug 19014: Only process issues for autorenewal if on or after soonest renewal date This patch check the soonest renewal date and skips processing auto renewals if before this date This ensures patrons won't get notifications far in advance if an item is on hold or has other issues To test: 1 - Checkout an item to a patron with a due date 2 days in the future and 'No renewal before' unset 2 - Place a hold on that item 3 - Define an AUTO_RENEWALS circulation notice with below at a minimum [% checkout.auto_renew_error %] 4 - perl misc/cronjobs/automatic_renewals.pl --send-notices 5 - Patron is not notified 6 - Set 'No renewal before' to 1 7 - run cronjob 8 - Patron is notified with error 'on_reserve' 9 - Set 'No renewal before' to 3 10 - UPDATE issues SET auto_renew_error = NULL; 11 - run cronjob 12 - Patron is notified with error 'on_reserve' 13 - APPLY PATCH 14 - Unset 'No renewal before' 15 - UPDATE issues SET auto_renew_error = NULL; 16 - run cronjob 17 - Patron is not notified 18 - UPDATE issues SET auto_renew_error = NULL; 19 - Set 'No renewal before' to 1 20 - run cronjob 21 - Patron is notified with error 'on_reserve' 22 - Set 'No renewal before' to 3 23 - UPDATE issues SET auto_renew_error = NULL; 24 - run cronjob 25 - Patron is not notified Signed-off-by: Signed-off-by: -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 17:15:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 16:15:01 +0000 Subject: [Koha-bugs] [Bug 19014] Patrons should not get an 'on_reserve' notification if the due date is far into the future In-Reply-To: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19014-70-5AjbXKM7Q0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 ByWater Sandboxes <bws.sandboxes at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95851|0 |1 is obsolete| | --- Comment #47 from ByWater Sandboxes <bws.sandboxes at gmail.com> --- Created attachment 95852 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95852&action=edit Bug 19014: Only process issues for autorenewal if on or after soonest renewal date This patch check the soonest renewal date and skips processing auto renewals if before this date This ensures patrons won't get notifications far in advance if an item is on hold or has other issues To test: 1 - Checkout an item to a patron with a due date 2 days in the future and 'No renewal before' unset 2 - Place a hold on that item 3 - Define an AUTO_RENEWALS circulation notice with below at a minimum [% checkout.auto_renew_error %] 4 - perl misc/cronjobs/automatic_renewals.pl --send-notices 5 - Patron is not notified 6 - Set 'No renewal before' to 1 7 - run cronjob 8 - Patron is notified with error 'on_reserve' 9 - Set 'No renewal before' to 3 10 - UPDATE issues SET auto_renew_error = NULL; 11 - run cronjob 12 - Patron is notified with error 'on_reserve' 13 - APPLY PATCH 14 - Unset 'No renewal before' 15 - UPDATE issues SET auto_renew_error = NULL; 16 - run cronjob 17 - Patron is not notified 18 - UPDATE issues SET auto_renew_error = NULL; 19 - Set 'No renewal before' to 1 20 - run cronjob 21 - Patron is notified with error 'on_reserve' 22 - Set 'No renewal before' to 3 23 - UPDATE issues SET auto_renew_error = NULL; 24 - run cronjob 25 - Patron is not notified Signed-off-by: Signed-off-by: Signed-off-by: Hasina Akhter <hasinaa at pascolibraries.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 17:17:02 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 16:17:02 +0000 Subject: [Koha-bugs] [Bug 19014] Patrons should not get an 'on_reserve' notification if the due date is far into the future In-Reply-To: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19014-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19014-70-dPg8QNmgIS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19014 Andrew Fuerste-Henry <andrew at bywatersolutions.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off --- Comment #48 from Andrew Fuerste-Henry <andrew at bywatersolutions.com> --- Apologies for some messy signing-off :) Signed off on behalf of Hasina. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 17:18:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 16:18:54 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12446-70-PrMUpUfE9x@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Maryse Simard <maryse.simard at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93388|0 |1 is obsolete| | --- Comment #101 from Maryse Simard <maryse.simard at inlibro.com> --- Created attachment 95853 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95853&action=edit Bug 12446: Enable an adult to have a guarantor Conflicts have been fixed. Also attributes in system preference : AdditionalGuarantorField are now displayed correctly in all scenarios. I have rebased every patch. This includes all the features from the previous patches. Removed the dollar signs and stopped using C4::Category On the patron category page, there is a new field to specify whether patrons can be guarantee or not. The atomic update SQL script adds this new field and sets it to true for categories of type "C" and "P". 1) Apply the patch 2) Run updatedatabase.pl to add AdditionalGuarantorField to preferences and canbeguarantee to categories. 3) Go to patron category administration, edit a category and change the value of Can Be Guarantee to yes (for Child and Professional it should have been set by default) 4) See below to test various scenarios - Enable an adult to have a guarantor: 0.0) Create or edit a patron category of type 'A'. 0.1) Set the "Can be guarantee" field to "Yes" and save. 1) Select an adult patron -> details tab; 2) Click edit button; 3) validate "guarantor information" fieldset; - Shows guarantees' fines in the guarantor's page: 4) Click Set to patron button and select a guarantor; 5) Generate a fine; 6) Select guarantor patron -> details tab; 7) Validate guarantee's fine information. - Transfer some guarantor's information to the guarantee while adding a guarantee: 0) Select an adult patron; 1) Insert all information; 2) Click Add guarantee bouton; 3) Validate Garantor information/Main address/Contact fieldsets filled; - Transfer some guarantor's information to the guarantee while creating a new patron 0) Select an adult patron; 1) Insert all information; 2) Add a new adult patron; 3) Click "Set to patron" button; 4) Select the adult patron from 0); 5) Validate Garantor information/Main address/Contact fieldsets filled; - Transfer guarantor's alternate address/contact to the guarantee while creating a new patron: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 2) Select an adult patron; 3) Insert all information; 4) Add a new adult patron; 5) Click "Set to patron" button; 6) Select the adult patron from 0); 7) Validate Garantor information/Main address/Contact fieldsets filled; 8) Validate Garantor additional alternate address/contact filled; - Transfer guarantor's alternate address/contact to the guarantee while adding a guarantee: 0) Search AdditionalGuarantorField preference; 1) Insert some additional database columns from alternate address/contact to be transferred from guarantor; 3) Select an adult patron; 4) Insert all information; 5) Click Add guarantee bouton; 6) Validate Garantor information/Main address/Contact fieldsets filled; 7) Validate Garantor additional alternate address/contact filled; Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 17:18:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 16:18:59 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12446-70-ksiyI2ttEJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Maryse Simard <maryse.simard at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93389|0 |1 is obsolete| | --- Comment #102 from Maryse Simard <maryse.simard at inlibro.com> --- Created attachment 95854 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95854&action=edit Bug 12446: (QA follow-up) Cleaning, and fixing, old code carried accidentally Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 17:19:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 16:19:05 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12446-70-mSPfIL6ogR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Maryse Simard <maryse.simard at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93390|0 |1 is obsolete| | --- Comment #103 from Maryse Simard <maryse.simard at inlibro.com> --- Created attachment 95855 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95855&action=edit Bug 12446: (follow-up) Show all guarantees on the guarantor detail page Only one guarantee is shown on the guarantor detail page. The guarantees list should be passed to the template as a ref. Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 17:19:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 16:19:10 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12446-70-cwT8ntINZm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Maryse Simard <maryse.simard at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93391|0 |1 is obsolete| | --- Comment #104 from Maryse Simard <maryse.simard at inlibro.com> --- Created attachment 95856 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95856&action=edit Bug 12446: (QA follow-up) QA tests fixing, cleaning code This patch does 3 things : - Remove old code in C4/Utils/DataTables/Members.pm. - Fix the AdditionalGuarantorField dead link for the borrowers table schema. - Remove unused variables so QA tests pass. Signed-off-by: Hayley Mapley <hayleymapley at catalyst.net.nz> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 17:19:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 16:19:15 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12446-70-SnB6eaBl0b@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Maryse Simard <maryse.simard at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93392|0 |1 is obsolete| | --- Comment #105 from Maryse Simard <maryse.simard at inlibro.com> --- Created attachment 95857 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95857&action=edit Bug 12446: Schema update Category.pm -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 17:19:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 16:19:20 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12446-70-2RTnZkeHCz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Maryse Simard <maryse.simard at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93393|0 |1 is obsolete| | --- Comment #106 from Maryse Simard <maryse.simard at inlibro.com> --- Created attachment 95858 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95858&action=edit Bug 12446: (follow-up) Remove mandatory transfered values With the new system preference AdditionalGuarantorField, one can add data to be transfered to the guarantee, but cannot remove default ones. This patch renames the syspref to GuarantorFields and set hardcoded default values as the preference's default. To test: 1. After database update, check that the default value for the syspref GuarantorFields contains these columns: streetnumber|address|address2|city|state|zipcode|country| branchcode|phonepro|mobile|email|emailpro|fax 2. Set the value as empty 3. Try adding a guarantor to a patron (from the guarantor's page or the guarantee's): no values should be imported. 4. Check that it still works with different values for the preference. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 17:19:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 16:19:25 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12446-70-7M4vsLRyol@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Maryse Simard <maryse.simard at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #93394|0 |1 is obsolete| | --- Comment #107 from Maryse Simard <maryse.simard at inlibro.com> --- Created attachment 95859 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95859&action=edit Bug 12446: (follow-up) Code cleaning Some variable name change, put database update in a perl file, remove unused code and other small fixes. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 17:19:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 16:19:31 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12446-70-72KfaruCHE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Maryse Simard <maryse.simard at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95411|0 |1 is obsolete| | --- Comment #108 from Maryse Simard <maryse.simard at inlibro.com> --- Created attachment 95860 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95860&action=edit Bug 12446: (follow-up) Update for Bug 17168 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 17:20:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 16:20:37 +0000 Subject: [Koha-bugs] [Bug 12446] Enable an adult to have a guarantor In-Reply-To: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-12446-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-12446-70-K5QpiHIZUs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=12446 Maryse Simard <maryse.simard at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|charles.farmer at inlibro.com |maryse.simard at inlibro.com --- Comment #109 from Maryse Simard <maryse.simard at inlibro.com> --- Rebased the patches against current master. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 17:26:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 16:26:46 +0000 Subject: [Koha-bugs] [Bug 24131] New: Improved formatting for output of updatedatabase Message-ID: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24131 Bug ID: 24131 Summary: Improved formatting for output of updatedatabase Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Some updates include more than just the 'Updated to' text.. like Warnings and Notes to run scripts. It would be nice to format these nicely in the webinstaller. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 17:51:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 16:51:34 +0000 Subject: [Koha-bugs] [Bug 24131] Improved formatting for output of updatedatabase In-Reply-To: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24131-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24131-70-ocyulwHfKn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24131 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_target -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 17:52:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 16:52:15 +0000 Subject: [Koha-bugs] [Bug 15522] New interface for revamped circulation rules In-Reply-To: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15522-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15522-70-y6k8LSUXjx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15522 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 17:52:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 16:52:38 +0000 Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha namespace In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20443-70-OjShOxrzEQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |RM_priority -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 17:55:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 16:55:14 +0000 Subject: [Koha-bugs] [Bug 5161] patron attributes clearing if duplicate warning In-Reply-To: <bug-5161-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-5161-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-5161-70-V2kdBXjEuJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=5161 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Keywords| |rel_20_05_target, | |RM_priority -- You are receiving this mail because: You are the QA Contact for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 17:55:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 16:55:37 +0000 Subject: [Koha-bugs] [Bug 20271] Merge deleted biblio, biblioitems, biblio_metadata, and items tables with their "alive" cousins In-Reply-To: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20271-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20271-70-hvMhNTzO5f@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20271 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_target, | |RM_priority -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 19:24:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 18:24:25 +0000 Subject: [Koha-bugs] [Bug 23571] fines.pl may block server In-Reply-To: <bug-23571-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23571-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23571-70-dAcuLtTTXw@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23571 Amit Gupta <amitddng135 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |amit.gupta at informaticsgloba | |l.com, | |amitddng135 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 20:01:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 19:01:30 +0000 Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha namespace In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20443-70-uCkoIlqI0C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |23666 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 [Bug 23666] Add API route for additional patron attributes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 20:01:30 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 19:01:30 +0000 Subject: [Koha-bugs] [Bug 23666] Add API route for additional patron attributes In-Reply-To: <bug-23666-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23666-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23666-70-yEEE4nNK3S@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23666 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |20443 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443 [Bug 20443] Move C4::Members::Attributes to Koha namespace -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 20:37:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 19:37:24 +0000 Subject: [Koha-bugs] [Bug 23237] Add support for [% INCLUDE %] in plugin templates In-Reply-To: <bug-23237-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23237-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23237-70-jphiePD5Lx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23237 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com --- Comment #10 from Tomás Cohen Arazi <tomascohen at gmail.com> --- I think the get_plugin_dir method is not quite correct as there can be more than one plugins_dir entry. bundle_dir should be used instead. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Wed Nov 27 21:10:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Wed, 27 Nov 2019 20:10:38 +0000 Subject: [Koha-bugs] [Bug 14837] Allow to send separate DUEDGST und PREDUEDGST for item's homebranches In-Reply-To: <bug-14837-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14837-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14837-70-JdZCVN7zvV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14837 Michal Denar <black23 at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |black23 at gmail.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 01:26:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2019 00:26:31 +0000 Subject: [Koha-bugs] [Bug 16156] Do not ensure the dbh is connected all the time In-Reply-To: <bug-16156-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16156-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16156-70-0wWBSaOErh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16156 David Cook <dcook at prosentient.com.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |dcook at prosentient.com.au --- Comment #5 from David Cook <dcook at prosentient.com.au> --- I don't have time to think about this right now, but I'd do things with persistent/long running processes as the target? I figure this is one of those things that is best handled at the start of a request but I don't know. I ran into this problem with Wildfly/JBoss and this is how I dealt with it: https://access.redhat.com/documentation/en-us/red_hat_jboss_enterprise_application_platform/6.4/html/administration_and_configuration_guide/sect-database_connection_validation -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 01:31:18 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2019 00:31:18 +0000 Subject: [Koha-bugs] [Bug 8959] Self checkout timeout is JavaScript-dependent In-Reply-To: <bug-8959-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-8959-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-8959-70-7yQsg1u5rb@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=8959 Jerwyn <os.jerwynfernandez at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |os.jerwynfernandez at gmail.co | |m --- Comment #2 from Jerwyn <os.jerwynfernandez at gmail.com> --- Hi Owen, I noticed also when printing in SCO v19.5 it redirects to OPAC log-in page. Do you experience the same? Or this bug came back again https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21054 We don't have any issue printing in SCO using 18.5 and 18.11 Best regards, -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 08:10:45 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2019 07:10:45 +0000 Subject: [Koha-bugs] [Bug 24027] Adding multiple items is slow In-Reply-To: <bug-24027-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24027-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24027-70-qph0sKf81R@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24027 Andrew Nugged <nugged at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 09:42:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2019 08:42:40 +0000 Subject: [Koha-bugs] [Bug 16156] Do not ensure the dbh is connected all the time In-Reply-To: <bug-16156-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16156-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16156-70-BIWpairVh0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16156 --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- (In reply to David Cook from comment #5) > I don't have time to think about this right now, but I'd do things with > persistent/long running processes as the target? To answer I am going to quote content from previous comments: (In reply to Jonathan Druart from comment #1) > Created attachment 49632 [details] [review] > Unfortunately this patch will revive timeout issues with long run > process (SIP server for instance). (In reply to Jonathan Druart from comment #2) > We could also imagine a 'ensure_connected' flag, not to use the > $context->{dbh} even if exists, for long run processes. It is in discussion. So first "Do you think it makes sense?" then either we abandon or we go further and I continue to implement the idea. As you can see I have been waiting for "discussion" for more than 3 years now ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 10:07:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2019 09:07:14 +0000 Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen" renewals In-Reply-To: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24083-70-WOVGbZAOlm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 --- Comment #1 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 95861 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95861&action=edit Bug 24083: Required atomic updates & DB update This patch adds: - An "UnseenRenewals" circulation syspref that enables/disables the functionality added in this bug - A change to the issuingrules table schema and a corresponding database upgrade to add issuingrules.unseen_renewals_allowed - A change to the issues & old_issues table schemas and corresponding database upgrades to add issues.unseen_renewals & old_issues.unseen_renewals - An update for the renewals letter to include a message for unseen renewals -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 10:07:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2019 09:07:16 +0000 Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen" renewals In-Reply-To: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24083-70-T4s1SfUWgp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 --- Comment #2 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 95862 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95862&action=edit Bug 24083: Add circ rules management This patch adds the ability to set the "Unseen renewals allowed" value in the circulation rules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 10:07:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2019 09:07:19 +0000 Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen" renewals In-Reply-To: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24083-70-9LFZbrnrrh@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 --- Comment #3 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 95863 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95863&action=edit Bug 24083: Add support for unseen_renewals This patch adds support for unseen renewals. Here we retrofit knowledge of unseen renewals and add the display of unseen renewal counts and warnings, in addition to adding the ability to specify a renewal as being "unseen". The functionality added here is goverened by the UnseenRenewals syspref. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 10:07:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2019 09:07:22 +0000 Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen" renewals In-Reply-To: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24083-70-z3kpweRrA1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 --- Comment #4 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 95864 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95864&action=edit Bug 24083: Add unit tests This patch adds unit tests for unseen renewals -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 10:49:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2019 09:49:05 +0000 Subject: [Koha-bugs] [Bug 20443] Move C4::Members::Attributes to Koha namespace In-Reply-To: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20443-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20443-70-OS3extViqz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24132 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24132 [Bug 24132] search_with_library_limits vs filter_by_branch_limitations -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 10:49:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2019 09:49:05 +0000 Subject: [Koha-bugs] [Bug 24132] New: search_with_library_limits vs filter_by_branch_limitations Message-ID: <bug-24132-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24132 Bug ID: 24132 Summary: search_with_library_limits vs filter_by_branch_limitations Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Architecture, internals, and plumbing Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org Depends on: 20443 Aside from the naming of these two subroutines (implemented at different times), Koha::Patron::Attribute::Types->search_with_library_limits and Koha::Patron::Attributes->filter_by_branch_limitations looks similar and that the code must be simplified. The join table is between borrower_attribute_types and branches (borrower_attribute_types_branches). So Koha::Patron::Attribute::Types can inherit directly from Koha::Objects::Limit::Library, not Koha::Patron::Attributes There are a couple of ways to deal with that: 1. Improve Koha::Objects::Limit::Library => Sounds wrong as there is no join table between borrower_attributes and branches 2. Remove Koha::Patron::Attributes->filter_by_branch_limitations and replace it by something like: my $attribute_types = Koha::Patron::Attribute::Types ->search_with_library_limits; my $attribute = $patron->extended_attributes ->search({ code => { -in => attribute_types->column('code') } }); Which sounds more correct. Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20443 [Bug 20443] Move C4::Members::Attributes to Koha namespace -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 11:40:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2019 10:40:27 +0000 Subject: [Koha-bugs] [Bug 20256] Add ability to limit editing of items to home library In-Reply-To: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20256-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20256-70-lu9KSwturN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20256 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=10263 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 11:40:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2019 10:40:27 +0000 Subject: [Koha-bugs] [Bug 10263] Add ability to limit which branch can edit a bibliographic record In-Reply-To: <bug-10263-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10263-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10263-70-F69C6OvMv1@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10263 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=20256 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 11:41:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2019 10:41:25 +0000 Subject: [Koha-bugs] [Bug 22923] Items edition does not take care of independent branches In-Reply-To: <bug-22923-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22923-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22923-70-KlpW5dJkgJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22923 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|Items search does not take |Items edition does not take |care of independent |care of independent |branches |branches -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 12:00:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2019 11:00:04 +0000 Subject: [Koha-bugs] [Bug 22923] Items edition does not take care of independent branches In-Reply-To: <bug-22923-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22923-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22923-70-jzED5ZF4j9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22923 --- Comment #8 from Fridolin SOMERS <fridolin.somers at biblibre.com> --- (In reply to Jonathan Druart from comment #7) > Hum indeed, but you can "Edit items", then edit whichever you want... Ah when I test that I see in items table the "Actions" button only on my items. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 12:01:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2019 11:01:16 +0000 Subject: [Koha-bugs] [Bug 16887] Entering a bad date in 'Koha out on loan' field sets items.onloan to 0000-00-00. In-Reply-To: <bug-16887-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16887-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16887-70-G9dwppgzSB@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16887 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED CC| |jonathan.druart at bugs.koha-c | |ommunity.org Resolution|--- |FIXED --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- "Koha out on loan" does not longer exist, I have tried to put space in a date field and I do get a crash. Assuming this is fixed. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 12:06:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2019 11:06:39 +0000 Subject: [Koha-bugs] [Bug 24133] New: nb-NO and pl-PL out of sync Message-ID: <bug-24133-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24133 Bug ID: 24133 Summary: nb-NO and pl-PL out of sync Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: normal Priority: P5 - low Component: System Administration Assignee: koha-bugs at lists.koha-community.org Reporter: jonathan.druart at bugs.koha-community.org QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Just found that: % git grep 'Koha out on loan' installer/data/mysql/nb-NO/marcflavour/marc21/optional/marc21_sample_fastadd_framework.sql: ('952','q','Koha out on loan','Koha out on loan',0,0,'items.onloan',10,'','','',NULL,0,'FA','',NULL,NULL), installer/data/mysql/pl-PL/marcflavour/marc21/optional/marc21_sample_fastadd_framework.sql: ('952','q','Koha out on loan','Koha out on loan',0,0,'items.onloan',10,'','','',NULL,0,'FA','',NULL,NULL), No idea what happened. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 12:06:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2019 11:06:39 +0000 Subject: [Koha-bugs] [Bug 11330] Inconsistent field/subfield descriptions on MARC21 bibliographic frameworks In-Reply-To: <bug-11330-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11330-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11330-70-ldR0qmkRIX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11330 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24133 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 12:06:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2019 11:06:39 +0000 Subject: [Koha-bugs] [Bug 15181] Rename fast add framework sql file In-Reply-To: <bug-15181-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15181-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15181-70-MfGvSAytg9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15181 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Target Milestone|Oldversions |--- Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24133 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 12:13:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2019 11:13:09 +0000 Subject: [Koha-bugs] [Bug 10470] Way to add multiple subfields to frameworks at once In-Reply-To: <bug-10470-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10470-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10470-70-OdU1vcTY8y@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10470 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de Summary|way to add multiple |Way to add multiple |subfields to frameworks |subfields to frameworks at | |once -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 12:13:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2019 11:13:32 +0000 Subject: [Koha-bugs] [Bug 24133] nb-NO and pl-PL biblio frameworks out of sync In-Reply-To: <bug-24133-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24133-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24133-70-NE3ySAPtuX@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24133 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |magnus at libriotech.no Summary|nb-NO and pl-PL out of sync |nb-NO and pl-PL biblio | |frameworks out of sync -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 12:20:25 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2019 11:20:25 +0000 Subject: [Koha-bugs] [Bug 4392] bulkmarcimport.pl leaves items.onloan set to '0000-00-00' instead of NULL In-Reply-To: <bug-4392-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-4392-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-4392-70-dNcIa7IL8R@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=4392 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |RESOLVED Resolution|--- |FIXED --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Do not recreate. -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 12:28:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2019 11:28:01 +0000 Subject: [Koha-bugs] [Bug 24121] Item types icons in intra search results are requesting icons from opac images path if item-level_itypes syspref is set to biblio In-Reply-To: <bug-24121-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24121-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24121-70-jQHAt9rEGz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff Version|19.05 |master CC| |jonathan.druart at bugs.koha-c | |ommunity.org Assignee|koha-bugs at lists.koha-commun |pjamorim91 at gmail.com |ity.org | -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 12:31:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2019 11:31:50 +0000 Subject: [Koha-bugs] [Bug 24121] Item types icons in intra search results are requesting icons from opac images path if item-level_itypes syspref is set to biblio In-Reply-To: <bug-24121-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24121-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24121-70-PXZdiEcfVZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Depends on| |14385 --- Comment #4 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Caused by commit 5e4e10c4ca558180137bf5a4ff5a68495efa0ec7 Bug 14385: Extend OpacHiddenItems to allow specifying exempt borrower categories Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 12:31:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2019 11:31:50 +0000 Subject: [Koha-bugs] [Bug 14385] Extend OpacHiddenItems to allow specifying exempt borrower categories In-Reply-To: <bug-14385-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-14385-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-14385-70-oCjxvBCrEZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=14385 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24121 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24121 [Bug 24121] Item types icons in intra search results are requesting icons from opac images path if item-level_itypes syspref is set to biblio -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 13:25:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2019 12:25:03 +0000 Subject: [Koha-bugs] [Bug 24124] Cannot select authorities in batch deletion tool in Chrome In-Reply-To: <bug-24124-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24124-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24124-70-9titiQYMdD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24124 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |katrin.fischer at bsz-bw.de, | |oleonard at myacpl.org -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 13:37:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2019 12:37:27 +0000 Subject: [Koha-bugs] [Bug 24072] Typos in advance_notices.pl causes DUEDGST not to be sent In-Reply-To: <bug-24072-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24072-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24072-70-FWkBoZ5QB3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24072 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_19_11_candidate | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 13:38:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2019 12:38:17 +0000 Subject: [Koha-bugs] [Bug 21466] Data inconsistencies - koha fields linked to AV cat values must have a corresponding authorised value In-Reply-To: <bug-21466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21466-70-JhRzvOUSQp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21466 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords|rel_19_11_candidate |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 13:39:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2019 12:39:08 +0000 Subject: [Koha-bugs] [Bug 21466] Data inconsistencies - koha fields linked to AV cat values must have a corresponding authorised value In-Reply-To: <bug-21466-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21466-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21466-70-62tDMtrrN3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21466 --- Comment #9 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- It would be good to get this into 19.11.01, it sohuld have been in .00 really, but it got stuck awaiting QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 13:40:24 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2019 12:40:24 +0000 Subject: [Koha-bugs] [Bug 23454] Fine for the previous overdue may get overwritten by the next one In-Reply-To: <bug-23454-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23454-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23454-70-AchqPeR9eo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23454 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |martin.renvoize at ptfs-europe | |.com Keywords| |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 16:34:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2019 15:34:15 +0000 Subject: [Koha-bugs] [Bug 22890] Add a chronological changelog In-Reply-To: <bug-22890-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22890-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22890-70-zlGOvlZf2D@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22890 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #6 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I like the "tags" on https://keepachangelog.com/en/1.0.0/, like "Added", "Deprecated", etc. It would be great to have some like "new modules", "new method", "new api route", "deprecated", "new/rm/mv sysprefs", "new table/column", etc. So a single entry "feature foo" could have several tags. We could have that at the end of the "Text to go in the release notes", like: """ This is a release note for feature foo that bring useful stuffs. %%%%%%%%%%%%%% # a separator line [Add pref]YetAnotherPref [Add DB table]a_new_db_table """ The changelog could then be built using that and make the DB changes (or any other type of changes) eyeballed easily. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 17:02:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2019 16:02:33 +0000 Subject: [Koha-bugs] [Bug 21187] GDPR: Force patrons password renew In-Reply-To: <bug-21187-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21187-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21187-70-BFK9OKjFoY@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21187 Marjorie Barry-Vila <marjorie.barry-vila at collecto.ca> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |marjorie.barry-vila at collect | |o.ca -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 17:09:23 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2019 16:09:23 +0000 Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen" renewals In-Reply-To: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24083-70-P1TsNLXzBM@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95861|0 |1 is obsolete| | --- Comment #5 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 95865 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95865&action=edit Bug 24083: Required atomic updates & DB update This patch adds: - An "UnseenRenewals" circulation syspref that enables/disables the functionality added in this bug - A change to the issuingrules table schema and a corresponding database upgrade to add issuingrules.unseen_renewals_allowed - A change to the issues & old_issues table schemas and corresponding database upgrades to add issues.unseen_renewals & old_issues.unseen_renewals - An update for the renewals letter to include a message for unseen renewals -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 17:09:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2019 16:09:26 +0000 Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen" renewals In-Reply-To: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24083-70-jliMiv2cDu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95862|0 |1 is obsolete| | --- Comment #6 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 95866 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95866&action=edit Bug 24083: Add circ rules management This patch adds the ability to set the "Unseen renewals allowed" value in the circulation rules -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 17:09:29 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2019 16:09:29 +0000 Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen" renewals In-Reply-To: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24083-70-ocb0PuFGev@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95863|0 |1 is obsolete| | --- Comment #7 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 95867 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95867&action=edit Bug 24083: Add support for unseen_renewals This patch adds support for unseen renewals. Here we retrofit knowledge of unseen renewals and add the display of unseen renewal counts and warnings, in addition to adding the ability to specify a renewal as being "unseen". The functionality added here is goverened by the UnseenRenewals syspref. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 17:09:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2019 16:09:32 +0000 Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen" renewals In-Reply-To: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24083-70-3DzgOxK5fU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95864|0 |1 is obsolete| | --- Comment #8 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 95868 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95868&action=edit Bug 24083: Add unit tests This patch adds unit tests for unseen renewals -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 17:20:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2019 16:20:32 +0000 Subject: [Koha-bugs] [Bug 24083] Koha should support "seen" vs "unseen" renewals In-Reply-To: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24083-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24083-70-uKufMY4Bge@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24083 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #9 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- - Apply patches (if on a platform requiring this to be done manually) - Run DB updates and rebuild schema (if on a platform requiring this to be done manually) - Rebuild CSS (if on a platform requiring this to be done manually) - Issue an item to a patron - Navigate to Koha Administration > Circulation and fines rules => TEST: Observe that there *isn't* a column titled "Unseen renewals allowed (count)" - Navigate to a patron's checkouts list => TEST: Observe that in the "Renew" column, only details of their remaining renewals are shown, unseen renewals are not mentioned - Navigate to a patron's "Your account" page => TEST: Observe that in the "Renew" column, only details of their remaining renewals are shown, unseen renewals are not mentioned - Turn on the "UnseenRenewals" syspref - Turn on the "OpacRenewalAllowed" syspref - Navigate to Koha Administration > Circulation and fines rules - If you have no circulation rules defined, define one that will: - Apply to all patron categories - Apply to item types - Allow renewals => TEST: Observe that there *is* a column titled "Unseen renewals allowed (count)" and the value is empty - Add a value for "Unseen renewals allowed", make the value reasonably low so we can test what happens when that value is reached - Navigate to a patron's checkouts list in the staff client => TEST: Observe that in the "Renew" column, details of their remaining unseen renewals are now shown - Navigate to a patron's "Your account" page => TEST: Observe that in the "Renew" column, details of their remaining unseen renewals are now shown - In the OPAC, renew an item => TEST: Observe that, since the renewal took place in the OPAC, the number of unseen renewals left is decremented - In the OPAC, repeatedly renew the item until the unseen renewals limit is reached => TEST: Observe that the item can no longer be renewed and the borrower is advised to take the item to the library - Navigate to the patron's checkouts list in the staff client => TEST: Observe that the item is listed as "Must be renewed at the library" and is blocked from renewal - Select the "Override renewal restrictions" checkbox => TEST: Observe that the item can now be selected for renewal - Select the item and click "Renew or check in selected items" => TEST: Observe that now the item has been renewed by the library, the unseen renewals remaining count has been reset - Select the item for renewal again and check the "Renew as unseen if appropriate" checkbox, click "Renew or check in selected items" => TEST: Observe that, since the item was renewed as "unseen", the unseen renewals remaining has been decremented - Navigate to Circulation > Renew => TEST: Observe that a new "Record renewal as unseen if appropriate" checkbox is displayed - Renew the item, do not check the unseen checkbox => TEST: Observe in the patron's checkouts list that the unseen renewals count has not been decremented - Renew the item, check the unseen checkbox => TEST: Observe in the patron's checkouts list that the unseen renewals count has been decremented - Navigate to Tools > Notices & Slips, edit the "AUTO_RENEWALS" Email notice => TEST: Observe that there is now a test for the "too_unseen" error, with an appropriate message SIP RENEWALS: - Use sip_cli_emulator.pl to send a renew message for the item, for example: ./misc/sip_cli_emulator.pl -a 127.0.0.1 -p 6001 -su <kiosk_username> -sp <kiosk_password> --patron <patron_username> --password <patron_password> -l CPL -i <item_barcode> -m renew - TEST: Observe that, as the SIP renewal is considered to be "seen", the item's unseen renewals count has been reset -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 17:29:37 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2019 16:29:37 +0000 Subject: [Koha-bugs] [Bug 15729] SIP server allows checkin of reserved item In-Reply-To: <bug-15729-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15729-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15729-70-Syrdbu8STv@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15729 clodagh.kerin at educampus.ie changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |clodagh.kerin at educampus.ie -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Thu Nov 28 18:12:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Thu, 28 Nov 2019 17:12:04 +0000 Subject: [Koha-bugs] [Bug 23767] Spent and Ordered total values don't include child funds on acqui-home In-Reply-To: <bug-23767-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23767-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23767-70-sX6Vc72vls@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23767 Séverine Queune <severine.queune at bulac.fr> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Patch doesn't apply --- Comment #13 from Séverine Queune <severine.queune at bulac.fr> --- Sorry Nick :( M koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt Falling back to patching base and 3-way merge... Auto-merging koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt CONFLICT (content): Merge conflict in koha-tmpl/intranet-tmpl/prog/en/modules/acqui/acqui-home.tt Failed to merge in the changes. Patch failed at 0001 Bug 23767: Don't calculate 'Total available' -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 03:16:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 02:16:54 +0000 Subject: [Koha-bugs] [Bug 13193] Make Memcached usage fork safe In-Reply-To: <bug-13193-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13193-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13193-70-fOqJDvwhNL@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13193 --- Comment #51 from David Cook <dcook at prosentient.com.au> --- (In reply to Joonas Kylmälä from comment #48) > well, we can either make the debian package ourselves or remove the > dependency by solving this with another way. I'm checking with the Release Manager to see the process for one of us building the Debian package and getting it into Koha's APT repository. Happy to share this information with you as I receive it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 05:55:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 04:55:47 +0000 Subject: [Koha-bugs] [Bug 24134] New: improve 008 framework flexibility (autogenerate date) Message-ID: <bug-24134-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24134 Bug ID: 24134 Summary: improve 008 framework flexibility (autogenerate date) Change sponsored?: --- Product: Koha Version: 18.11 Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Cataloging Assignee: koha-bugs at lists.koha-community.org Reporter: philip.bertling at rbg.vic.gov.au QA Contact: testopia at bugs.koha-community.org CC: m.de.rooy at rijksmuseum.nl When creating a framework for a form type other than book, it does not seem possible to autogenerate the date correctly. The 00-05 ‘date entered on file’ in the 008 field, can almost be auto-filled by using the code <<YYYY>><<MM>><<DD>>. However it doesn’t quite work because the 008 field expects a 6 digit date [YYMMDD] – this code inserts an 8 digit date [YYYYMMDD]. e.g. <<YY>><<MM>><<DD>> b at |||p |||||00| eng d = entered on the date <<29>><<11>><<25>> This creates the following data in a record: <<YY>>1125 b at |||p |||||00| eng d Is it possible to make this date code work to insert a date comprising 6 digits? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 07:42:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 06:42:57 +0000 Subject: [Koha-bugs] [Bug 7045] Default-value substitution inconsistent In-Reply-To: <bug-7045-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7045-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7045-70-qFLxRQbgXx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7045 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=24134 -- You are receiving this mail because: You are watching all bug changes. You are the QA Contact for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 07:42:57 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 06:42:57 +0000 Subject: [Koha-bugs] [Bug 24134] Add placeholder for 2 digit years to allow autogeneration of dates in 008 In-Reply-To: <bug-24134-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24134-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24134-70-S6i52w7wCO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24134 Katrin Fischer <katrin.fischer at bsz-bw.de> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|improve 008 framework |Add placeholder for 2 digit |flexibility (autogenerate |years to allow |date) |autogeneration of dates in | |008 See Also| |https://bugs.koha-community | |.org/bugzilla3/show_bug.cgi | |?id=7045 CC| |katrin.fischer at bsz-bw.de Keywords| |Academy Version|18.11 |master --- Comment #1 from Katrin Fischer <katrin.fischer at bsz-bw.de> --- See bug 7045 for the other placeholders already available. At the moment we support: <<DD>> - 2 digit day of month <<MM>> - 2 digit number of month <<YYYY>> - 4 digit year <<USER>> - user adding the record -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 08:49:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 07:49:08 +0000 Subject: [Koha-bugs] [Bug 21177] Use koha-conf.xml in misc/devel/update_dbix_class_files.pl In-Reply-To: <bug-21177-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21177-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21177-70-6rHF9lunQT@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21177 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |m.de.rooy at rijksmuseum.nl --- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- database, hostname and port are in koha-conf.xml too It is still "annoying" to enter db_name, hostname, port too. Could be extended to db_driver too. We should remove all parameters coming from koha-conf to be consistent. And when removing the mandatory from db_name, I guess we should add a confirm parameter like other misc scripts. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 08:54:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 07:54:17 +0000 Subject: [Koha-bugs] [Bug 24126] Article requests tab appears twice on patron's checkout screen In-Reply-To: <bug-24126-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24126-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24126-70-JdFydEjlSV@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24126 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 08:54:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 07:54:21 +0000 Subject: [Koha-bugs] [Bug 24126] Article requests tab appears twice on patron's checkout screen In-Reply-To: <bug-24126-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24126-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24126-70-SDBDz0QbKZ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24126 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95838|0 |1 is obsolete| | --- Comment #3 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 95869 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95869&action=edit Bug 24126: Article requests tab appears twice on patron's checkout screen This patch removes duplicated markup on the checkout page which results in the "Article requests" tab appearing twice. To test, apply the patch and enable ArticleRequests. Check out to a patron. In the set of tabs that includes checkouts, holds, restrictions, etc., the "Article requests" tab should appear only once. Signed-off-by: Kyle M Hall <kyle at bywatersolutions.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 08:54:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 07:54:35 +0000 Subject: [Koha-bugs] [Bug 24126] Article requests tab appears twice on patron's checkout screen In-Reply-To: <bug-24126-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24126-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24126-70-wIrNb3I2yG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24126 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 08:55:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 07:55:15 +0000 Subject: [Koha-bugs] [Bug 24126] Article requests tab appears twice on patron's checkout screen In-Reply-To: <bug-24126-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24126-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24126-70-IJfooZTVJa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24126 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Text to go in the|This enhancement extends | release notes|the "Claims returned" lost | |status and allows staff to | |track items that patrons | |claim to have returned. | |Items are marked as "Claims | |returned" from the checkout | |page in the staff side. | | | |There are 3 new systems | |preferences to set for this | |functionality to work: | |`ClaimReturnedChargeFee`, | |`ClaimReturnedLostValue` | |and | |`ClaimReturnedWarningThresh | |old` | | | |Sponsored by: Fargo | |Public Library | |<http://fargond.gov/city-go | |vernment/departments/librar | |y> | |North Central Regional | |Library System | |<http://www.ncrl.org> | --- Comment #4 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Removed Release Notes text. Does not apply here. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 09:04:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 08:04:09 +0000 Subject: [Koha-bugs] [Bug 20948] Item-level hold info displayed regardless its priority (detail.pl) In-Reply-To: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20948-70-QOMlgrhcN0@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 09:04:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 08:04:12 +0000 Subject: [Koha-bugs] [Bug 20948] Item-level hold info displayed regardless its priority (detail.pl) In-Reply-To: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20948-70-H35EfhrURl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95636|0 |1 is obsolete| | --- Comment #20 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 95870 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95870&action=edit Bug 20948: Simplify existing code No changes expected here. Signed-off-by: Lisette Scheer <lisetteslatah at gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 09:04:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 08:04:16 +0000 Subject: [Koha-bugs] [Bug 20948] Item-level hold info displayed regardless its priority (detail.pl) In-Reply-To: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20948-70-Cds250qtMP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95637|0 |1 is obsolete| | --- Comment #21 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 95871 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95871&action=edit Bug 20948: Only display item-level hold info if first hold On the item list of the catalogue detail page we display next item-level hold info even if it is not the next hold. That leads to confusion as it will not necessarily be the accurate info. This patch makes the following changes: - Display the item-level hold only if it is the next hold (priority == 1) - Display "There is an item level hold on this item (priority=X)" if there is at least 1 item-level hold placed on this item Test plan: - Place several next available holds on a single item record - Place an item level hold on the item - Go the the biblio detail page => Without this patch, the item will show the item level hold => With the patch you see "There is an item level hold on this item" - Check the item in, confirm the hold => No changes, the item will show the waiting hold info - Cancel all the holds except the item-level one => No changes, the item will how the item-level one Signed-off-by: Lisette Scheer <lisetteslatah at gmail.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 09:04:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 08:04:42 +0000 Subject: [Koha-bugs] [Bug 20948] Item-level hold info displayed regardless its priority (detail.pl) In-Reply-To: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20948-70-asZOIMIyuF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 09:25:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 08:25:22 +0000 Subject: [Koha-bugs] [Bug 22890] Add a chronological changelog In-Reply-To: <bug-22890-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-22890-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-22890-70-Q1yElvYDoE@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=22890 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |rel_20_05_target -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 09:44:28 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 08:44:28 +0000 Subject: [Koha-bugs] [Bug 23246] Record detail page jumps into the 'images' tab if no holdings In-Reply-To: <bug-23246-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23246-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23246-70-SKyS41yeAn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 09:44:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 08:44:32 +0000 Subject: [Koha-bugs] [Bug 23246] Record detail page jumps into the 'images' tab if no holdings In-Reply-To: <bug-23246-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23246-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23246-70-PIjgdHRWLa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95801|0 |1 is obsolete| | --- Comment #23 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 95872 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95872&action=edit Bug 23246: Only jump into the 'images' tab HTML5MediaEnabled is set to This patch makes jumping into the third tab happen only if HTML5MediaEnabled is set to 'both' or 'staff'. To test: - Have HTML5MediaEnabled set to 'opac' or 'not at all' - Open the detail page of a record with no holdings => FAIL: The 'images' tab is selected - Apply this patch - Reload => SUCCESS: The 'holdings' tab is selected as it should be. - Sign off :-D Sponsored-by: America Numismatic Society Signed-off-by: Maryse Simard <maryse.simard at inlibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 09:44:36 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 08:44:36 +0000 Subject: [Koha-bugs] [Bug 23246] Record detail page jumps into the 'images' tab if no holdings In-Reply-To: <bug-23246-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23246-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23246-70-Sy15blPIpt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95802|0 |1 is obsolete| | --- Comment #24 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 95873 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95873&action=edit Bug 23246: (follow-up) Hardcoding tab position is not enough There are many conditions that determine the tab number for 'media'. Translated into variables that hold the tabs count on each condition, it is clear that '3' was not good enough: [%- holdings = (SeparateHoldings) ? 2 : 1 notes = (MARCNOTES || notes) ? 1 : 0 acq = (Koha.Preference('AcquisitionDetails')) ? 1 : 0 frbr = (FRBRizeEditions && XISBNS) ? 1 : 0 local_covers = (LocalCoverImages && (localimages || CAN_user_tools_upload_local_cover_images)) ? 1 : 0 media_tab = holdings + notes + acq + frbr + local_covers -%] This patch gets rid of the hardcoded value, adds an id to the 'media' tab (i.e. 'media_tab') and uses JS to get the right index. To test: - Play with the different options governing those variables => FAIL: 3 is not always the 'media' tab - Apply this patch - Repeat your tests => SUCCESS: It always picks the 'media' tab - Sign off :-D Sponsored-by: American Numismatics Society Signed-off-by: Maryse Simard <maryse.simard at inlibro.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 09:45:08 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 08:45:08 +0000 Subject: [Koha-bugs] [Bug 23246] Record detail page jumps into the 'images' tab if no holdings In-Reply-To: <bug-23246-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23246-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23246-70-XH9KRlF2cO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 09:47:48 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 08:47:48 +0000 Subject: [Koha-bugs] [Bug 23246] Record detail page jumps into the 'images' tab if no holdings In-Reply-To: <bug-23246-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23246-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23246-70-YlEfPtLQd7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23246 --- Comment #25 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Thank you, Marcel. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 09:55:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 08:55:34 +0000 Subject: [Koha-bugs] [Bug 19288] Holds placed on a specific item after a next available hold will show varied results In-Reply-To: <bug-19288-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-19288-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-19288-70-Lg92JbPr5X@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=19288 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |RESOLVED CC| |m.de.rooy at rijksmuseum.nl Resolution|--- |DUPLICATE --- Comment #16 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Bug 20948 has hit PQA in favor of this one, sorry ;) Please reopen and explain if this cannot be closed. *** This bug has been marked as a duplicate of bug 20948 *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 09:55:34 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 08:55:34 +0000 Subject: [Koha-bugs] [Bug 20948] Item-level hold info displayed regardless its priority (detail.pl) In-Reply-To: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20948-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20948-70-j2QXZkNdsU@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20948 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kelly at bywatersolutions.com --- Comment #22 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- *** Bug 19288 has been marked as a duplicate of this bug. *** -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 09:59:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 08:59:20 +0000 Subject: [Koha-bugs] [Bug 24114] modules must not warn In-Reply-To: <bug-24114-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24114-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24114-70-d6ar0kGBGa@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24114 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|ASSIGNED |Needs Signoff --- Comment #9 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Working here now -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 10:17:05 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 09:17:05 +0000 Subject: [Koha-bugs] [Bug 23881] SPAM In-Reply-To: <bug-23881-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23881-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23881-70-dX1nEz8XKF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23881 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|No control! |SPAM CC| |jonathan.druart at bugs.koha-c | |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 10:22:33 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 09:22:33 +0000 Subject: [Koha-bugs] [Bug 24135] New: Tidy up the team Message-ID: <bug-24135-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24135 Bug ID: 24135 Summary: Tidy up the team Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: About Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org The current form of the Koha team tab is a bit misleading/confusing. I think the release and maintenance teams should go at the top of the page as they're the most relevant for that moment in time. I don't really like the 'Special thanks' and 'Additional thanks' sections, they are not maintained in any meaningful way. I think they should be merged into the existing 'Koha development team' and 'Contributing companies and institutions' sections, perhaps highlighting them with the notes of what (and when) they contributed. This should all be pretty simple to achieve by just updating the yaml files that feed those two sections now and removing the hardcoded sections from the templates. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 10:22:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 09:22:40 +0000 Subject: [Koha-bugs] [Bug 24135] Tidy up the team In-Reply-To: <bug-24135-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24135-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24135-70-92m81BuNLr@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24135 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Keywords| |Academy -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 10:23:52 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 09:23:52 +0000 Subject: [Koha-bugs] [Bug 24114] modules must not warn In-Reply-To: <bug-24114-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24114-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24114-70-Lg3ZECADMW@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24114 --- Comment #10 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Marcel de Rooy from comment #8) > I doubt if all ->count calls are working > correctly after the changes but will check. Yes, the counts are wrong. Will add a followup. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 10:29:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 09:29:03 +0000 Subject: [Koha-bugs] [Bug 16349] Indicate what branches of Koha are supported In-Reply-To: <bug-16349-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16349-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16349-70-r8zAFpU6wP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16349 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Product|Project Infrastructure |Koha Component|Project website |About Version|unspecified |master QA Contact| |testopia at bugs.koha-communit | |y.org Assignee|wizzyrea at gmail.com |koha-bugs at lists.koha-commun | |ity.org CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 10:31:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 09:31:12 +0000 Subject: [Koha-bugs] [Bug 16349] Indicate what branches of Koha are supported In-Reply-To: <bug-16349-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16349-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16349-70-rjMNqKeJ0c@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16349 --- Comment #7 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Since bug 21626 we have the 'current' maintenance team highlighted in the 'Koha team' tab along with the date at which they step down from their roles. Does that cover this perhaps, or should we make it more pronounced somewhere? -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 10:31:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 09:31:17 +0000 Subject: [Koha-bugs] [Bug 16349] Indicate what branches of Koha are supported In-Reply-To: <bug-16349-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-16349-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-16349-70-BFO7SlslFm@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=16349 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |In Discussion -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 11:15:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 10:15:00 +0000 Subject: [Koha-bugs] [Bug 24114] modules must not warn In-Reply-To: <bug-24114-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24114-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24114-70-KEPdICo9br@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24114 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 11:15:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 10:15:04 +0000 Subject: [Koha-bugs] [Bug 24114] modules must not warn In-Reply-To: <bug-24114-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24114-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24114-70-ZqEGCu7RpQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24114 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95814|0 |1 is obsolete| | --- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 95874 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95874&action=edit Bug 24114: Remove warn statements from Koha::Patrons The warn must be done in the cronjob. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> Followed this test plan (with two follow-ups applied): [1] Prefs: UnsubscribeReflectionDelay=1, PatronAnonymizeDelay=2, PatronRemovalDelay=3, FailedLoginAttempts was undef [2] Pick borrower and set expiry to NOW-2, and lock him (login_attempts=-1) Could be achieved too by settings FailedLoginAttempts and trying wrong passwords. Run cleanup job: Locked 0 patrons Anonymized 1 patrons Deleted 0 patrons [3] Pick borrower, set expiry to NOW-3. Run cleanup job: Locked 0 patrons Anonymized 0 patrons Deleted 1 patrons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 11:15:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 10:15:09 +0000 Subject: [Koha-bugs] [Bug 24114] modules must not warn In-Reply-To: <bug-24114-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24114-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24114-70-BKvQ1lCcf8@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24114 --- Comment #12 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 95875 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95875&action=edit Bug 24114: (follow-up) Resolve warning on non-numeric subtraction Argument "" isn't numeric in subtraction (-) at /usr/share/koha/Koha/Patrons.pm line 290. Coming from an empty or undefined FailedLoginAttempts. Test plan: Verify that Koha/Patrons.t still passes. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 11:15:13 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 10:15:13 +0000 Subject: [Koha-bugs] [Bug 24114] modules must not warn In-Reply-To: <bug-24114-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24114-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24114-70-lpEzP134Qs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24114 --- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 95876 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95876&action=edit Bug 24114: (QA follow-up) Fix counts for lock, anonymize and delete Since these operations impact on the resultset, the counts should be saved before. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 11:17:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 10:17:49 +0000 Subject: [Koha-bugs] [Bug 24114] Remove warn statements from Koha::Patrons In-Reply-To: <bug-24114-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24114-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24114-70-uo4vL1rNFc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24114 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Summary|modules must not warn |Remove warn statements from | |Koha::Patrons -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 11:49:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 10:49:10 +0000 Subject: [Koha-bugs] [Bug 24136] New: Add libraries (sponsors) to the about page Message-ID: <bug-24136-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24136 Bug ID: 24136 Summary: Add libraries (sponsors) to the about page Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Keywords: Academy Severity: minor Priority: P5 - low Component: About Assignee: koha-bugs at lists.koha-community.org Reporter: martin.renvoize at ptfs-europe.com QA Contact: testopia at bugs.koha-community.org CC: caroline.cyr-la-rose at inlibro.com, claire.hernandez at biblibre.com, fridolin.somers at biblibre.com, jonathan.druart at bugs.koha-community.org, katrin.fischer at bsz-bw.de, liz at catalyst.net.nz, martin.renvoize at ptfs-europe.com, nick at bywatersolutions.com, oleonard at myacpl.org, testopia at bugs.koha-community.org, tomascohen at gmail.com Depends on: 20720 +++ This bug was initially created as a clone of Bug #20720 +++ Update for 19.11 Cycle Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20720 [Bug 20720] Add libraries (sponsors) to the about page -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 11:49:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 10:49:10 +0000 Subject: [Koha-bugs] [Bug 20720] Add libraries (sponsors) to the about page In-Reply-To: <bug-20720-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-20720-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-20720-70-oHPynx2UZt@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20720 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Blocks| |24136 Referenced Bugs: https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24136 [Bug 24136] Add libraries (sponsors) to the about page -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 11:49:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 10:49:21 +0000 Subject: [Koha-bugs] [Bug 24136] Add libraries (sponsors) to the about page In-Reply-To: <bug-24136-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24136-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24136-70-oJ5Ixemk2Z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24136 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Version|unspecified |master -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 11:50:04 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 10:50:04 +0000 Subject: [Koha-bugs] [Bug 24136] Add libraries (sponsors) to the about page In-Reply-To: <bug-24136-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24136-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24136-70-7o185dOMKd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24136 --- Comment #1 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95877 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95877&action=edit Bug 24136: Update sponsors for 19.11 cycle -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 11:50:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 10:50:15 +0000 Subject: [Koha-bugs] [Bug 24136] Add libraries (sponsors) to the about page In-Reply-To: <bug-24136-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24136-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24136-70-XPdqzlGDf6@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24136 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 11:50:38 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 10:50:38 +0000 Subject: [Koha-bugs] [Bug 24136] Add libraries (sponsors) to the about page In-Reply-To: <bug-24136-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24136-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24136-70-Dl4Lp6ts8l@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24136 --- Comment #2 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Taken from the release notes. I forgot to merge them in here as part of my release.. oops :( -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 11:58:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 10:58:09 +0000 Subject: [Koha-bugs] [Bug 24136] Add libraries (sponsors) to the about page In-Reply-To: <bug-24136-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24136-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24136-70-N9OpbWX0Nd@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24136 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95877|0 |1 is obsolete| | --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95878 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95878&action=edit Bug 24136: Update sponsors for 19.11 cycle -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 11:58:40 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 10:58:40 +0000 Subject: [Koha-bugs] [Bug 24136] Add libraries (sponsors) to the about page In-Reply-To: <bug-24136-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24136-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24136-70-6Up4V2twLx@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24136 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |martin.renvoize at ptfs-europe |ity.org |.com -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 12:18:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 11:18:17 +0000 Subject: [Koha-bugs] [Bug 18355] Permanent location should show with cart location In-Reply-To: <bug-18355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18355-70-nhfeIaE327@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Passed QA Patch complexity|Trivial patch |Small patch -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 12:18:20 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 11:18:20 +0000 Subject: [Koha-bugs] [Bug 18355] Permanent location should show with cart location In-Reply-To: <bug-18355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18355-70-jmW80YshoG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95775|0 |1 is obsolete| | --- Comment #44 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 95879 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95879&action=edit Bug 18355: Display permanent location with cart location Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 12:18:26 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 11:18:26 +0000 Subject: [Koha-bugs] [Bug 18355] Permanent location should show with cart location In-Reply-To: <bug-18355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18355-70-bmYBUgeJ2e@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 --- Comment #45 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- Created attachment 95880 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95880&action=edit Bug 18355: (QA follow-up) Rearrange comments, improve code Comments were hard to read (for me) but tastes differ.. Code should reflect that permanent_location is a code and that location may be already an authval. See detail.pl: $item->{'location'} = $shelflocations->{$shelfcode} if ( defined( $shelfcode ) && defined($shelflocations) && exists( $shelflocations->{$shelfcode} ) ); Obviously, this kind of logic divided over two places should be reduced. Signed-off-by: Marcel de Rooy <m.de.rooy at rijksmuseum.nl> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 12:18:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 11:18:42 +0000 Subject: [Koha-bugs] [Bug 18355] Permanent location should show with cart location In-Reply-To: <bug-18355-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18355-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18355-70-S8WKiRrSdK@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18355 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |m.de.rooy at rijksmuseum.nl |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 12:26:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 11:26:35 +0000 Subject: [Koha-bugs] [Bug 10352] Cataloguing log search mixing itemnumber/bibnumber In-Reply-To: <bug-10352-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-10352-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-10352-70-APRqpDpXxi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=10352 --- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- I agree with you Kelly. I would suggest to move forward with those patches, to fix the long standing issue, then deal with an ergonomic improvement on a separate bug report. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 12:30:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 11:30:19 +0000 Subject: [Koha-bugs] [Bug 24135] Tidy up the team In-Reply-To: <bug-24135-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24135-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24135-70-5Qx5nl5Kgc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24135 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |m.de.rooy at rijksmuseum.nl -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 12:40:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 11:40:54 +0000 Subject: [Koha-bugs] [Bug 21177] Use koha-conf.xml in misc/devel/update_dbix_class_files.pl In-Reply-To: <bug-21177-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21177-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21177-70-c4tDw1kNwG@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21177 --- Comment #12 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Marcel, I do not understand. If --koha-conf is passed, all those variables will be retrieved from the config file. Are you suggesting to pick the value from koha-conf by default then overwrite them by the parameters? That's more or less what I suggested in a previous comment. But 1 year after I prefer to let it go as it than to block it again. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 12:49:51 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 11:49:51 +0000 Subject: [Koha-bugs] [Bug 24136] Add libraries (sponsors) to the about page In-Reply-To: <bug-24136-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24136-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24136-70-67IHEl3NM5@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24136 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95878|0 |1 is obsolete| | --- Comment #4 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95881 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95881&action=edit Bug 24136: Update sponsors for 19.11 cycle -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 13:25:50 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 12:25:50 +0000 Subject: [Koha-bugs] [Bug 24137] New: Marc21 bibliographic fails to install for other language Message-ID: <bug-24137-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24137 Bug ID: 24137 Summary: Marc21 bibliographic fails to install for other language Change sponsored?: --- Product: Koha Version: 19.05 Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: b.pastern4k at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com When i try a fresh install for a language other than english, i get this error marc21_bibliographic_DEFAULT_general.sql [Fri Nov 29 13:15:36 2019] install.pl: DBD::mysql::st execute failed: Column 'hidden' cannot be null at /usr/share/perl5/DBIx/RunSQL.pm line 273. marc21_bibliographic_DEFAULT_local.sql [Fri Nov 29 13:15:36 2019] install.pl: DBD::mysql::st execute failed: Column 'hidden' cannot be null at /usr/share/perl5/DBIx/RunSQL.pm line 273. As a result, default bibliographic framework is almost empty and import via web interface is broken. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 13:47:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 12:47:09 +0000 Subject: [Koha-bugs] [Bug 24136] Add libraries (sponsors) to the about page In-Reply-To: <bug-24136-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24136-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24136-70-v5DbLRbX2S@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24136 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 13:47:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 12:47:12 +0000 Subject: [Koha-bugs] [Bug 24136] Add libraries (sponsors) to the about page In-Reply-To: <bug-24136-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24136-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24136-70-ZRTODqT6wN@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24136 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95881|0 |1 is obsolete| | --- Comment #5 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95882 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95882&action=edit Bug 24136: Update sponsors for 19.11 cycle Signed-off-by: Jonathan Druart <jonathan.druart at bugs.koha-community.org> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 14:05:01 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 13:05:01 +0000 Subject: [Koha-bugs] [Bug 21177] Use koha-conf.xml in misc/devel/update_dbix_class_files.pl In-Reply-To: <bug-21177-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-21177-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-21177-70-cZjOipHQR4@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21177 Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #13 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> --- (In reply to Jonathan Druart from comment #12) > Marcel, I do not understand. If --koha-conf is passed, all those variables > will be retrieved from the config file. Hmm. Overlooked that probably. > Are you suggesting to pick the value from koha-conf by default then > overwrite them by the parameters? That's more or less what I suggested in a > previous comment. But 1 year after I prefer to let it go as it than to block > it again. Good idea. But ok. Back to SO for now. Next week things will be better ;) -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 14:52:03 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 13:52:03 +0000 Subject: [Koha-bugs] [Bug 24137] Marc21 bibliographic fails to install for other language In-Reply-To: <bug-24137-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24137-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24137-70-9sdIh7QgIo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24137 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Which one are you trying? -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 15:22:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 14:22:14 +0000 Subject: [Koha-bugs] [Bug 15439] Current Location incorrect when item in transit In-Reply-To: <bug-15439-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-15439-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-15439-70-62i0HkIEEs@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=15439 Ray Delahunty <r.delahunty at arts.ac.uk> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |r.delahunty at arts.ac.uk --- Comment #1 from Ray Delahunty <r.delahunty at arts.ac.uk> --- If you discharge the item TWICE at library A when sending it to library B the first action sets the current location to library B but the second one brings it back to library A. It's a pretty easy workaround that sort-of works. (We have returns sorters at some of out libraries, so that can complicate things where one discharge scan has already happened by the time the staff member goes to the exceptions bin to sort out what needs to go where.) -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 15:42:35 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 14:42:35 +0000 Subject: [Koha-bugs] [Bug 24138] New: suspension miscalculated when Suspension charging interval bigger than 1 and Max. suspension duration is defined Message-ID: <bug-24138-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138 Bug ID: 24138 Summary: suspension miscalculated when Suspension charging interval bigger than 1 and Max. suspension duration is defined Change sponsored?: --- Product: Koha Version: master Hardware: All OS: All Status: NEW Severity: enhancement Priority: P5 - low Component: Circulation Assignee: koha-bugs at lists.koha-community.org Reporter: hagud at orex.es QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com When a circulation rule have a suspension charging interval bigger than one and also has defined a max suspension day, the fine is miscalculated. The issue is that the max suspension day is affected by "suspension Charging interval" for example if we have a suspension interval of 15 and max suspension days of 365 , koha will only apply of 24 suspension day, it seems there a direct inversion relation between both variables. reproduce plan. set up a rule of 7 days suspension every 15 days with max suspension of 365 days check out a book with due date 28/10/2018, and check in, you will see that the suspension is just 24 days If you increase the max suspension day to 730, you will have a suspension of 48 days (aprox) If you increase the max suspension day to (15x365) you will have the year suspension. If you define 1 suspension day every day with max of 365 and you check out andcheck in the same dates, you will have the suspension of 365 days -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 15:45:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 14:45:11 +0000 Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests In-Reply-To: <bug-23974-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23974-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23974-70-QOee2EnnMk@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA CC| |tomascohen at gmail.com --- Comment #15 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Minor issue with variable declared twice on the tests ('Different hours' subtest). -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 15:45:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 14:45:32 +0000 Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests In-Reply-To: <bug-23974-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23974-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23974-70-e5WBE64REi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 15:47:15 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 14:47:15 +0000 Subject: [Koha-bugs] [Bug 24106] In returns.pl, don't search for item if no barcode is provided In-Reply-To: <bug-24106-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24106-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24106-70-1xyV8eaZNu@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24106 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |tomascohen at gmail.com Version|unspecified |master QA Contact|testopia at bugs.koha-communit |tomascohen at gmail.com |y.org | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 16:02:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 15:02:54 +0000 Subject: [Koha-bugs] [Bug 24106] In returns.pl, don't search for item if no barcode is provided In-Reply-To: <bug-24106-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24106-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24106-70-ETojlzSoHD@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24106 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Patch complexity|--- |Trivial patch Status|Signed Off |Passed QA -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 16:02:56 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 15:02:56 +0000 Subject: [Koha-bugs] [Bug 24106] In returns.pl, don't search for item if no barcode is provided In-Reply-To: <bug-24106-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24106-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24106-70-ntgzrTMs7z@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24106 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95806|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 16:03:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 15:03:14 +0000 Subject: [Koha-bugs] [Bug 24106] In returns.pl, don't search for item if no barcode is provided In-Reply-To: <bug-24106-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24106-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24106-70-lJgDz9GQ0K@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24106 --- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> --- Created attachment 95883 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95883&action=edit Bug 24106: In returns.pl, don't search for item if no barcode is provided When loading returns.pl, code to check rotating collections fires off an search for items by barcode, but doesn't check for a barcode first. This means the code will search for items where barcode is NULL, which is definitely not the intended function. Test Plan: 1) Apply this patch 2) Set up a rotating collection with items 3) Transfer the collection 4) Check in a rotating collection item 5) Note no change in functionality Signed-off-by: Liz Rea <wizzyrea at gmail.com> Signed-off-by: Tomas Cohen Arazi <tomascohen at theke.io> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 16:10:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 15:10:22 +0000 Subject: [Koha-bugs] [Bug 13897] Use XML files for installer data In-Reply-To: <bug-13897-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13897-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13897-70-AjfiKepiCH@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 --- Comment #8 from Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> --- Created attachment 95884 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95884&action=edit Bug 13897: Use XML files for installer data This patch modifies C4/Installer.pm to add support for loading XML files into database (MySQL only). As an example of the functionality, optional auth_val.sql file is replaced by auth_val.xml The rationale behind this feature is to enable the translation of the data that is loaded into the database. That will be addressed in another bug. But taking into account that goal, non translatable values are put into XML attributes, translatable ones into elements which can already be captured by translate script. To test: 0) Do a clean install with all optional data, then dump authorised_values table, reserve. 1) Apply the patch 2) Do a clean install in English (marc21/unimarc) 3) On optional data check for description of auth_val "Some basic default authorised values for ..." 4) Select all optional data 5) Finish installation 6) Dump again authorised_values table and compare with that of point '0'. There must be no differences. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 16:10:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 15:10:54 +0000 Subject: [Koha-bugs] [Bug 13897] Use XML files for installer data In-Reply-To: <bug-13897-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13897-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13897-70-DVkd4fije9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75930|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 16:11:09 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 15:11:09 +0000 Subject: [Koha-bugs] [Bug 13897] Use XML files for installer data In-Reply-To: <bug-13897-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13897-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13897-70-FpbrxxyfSO@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #75931|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 16:14:17 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 15:14:17 +0000 Subject: [Koha-bugs] [Bug 24139] New: I do not know how to obtain or set credentials that will let me log in to use webinstaller Message-ID: <bug-24139-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24139 Bug ID: 24139 Summary: I do not know how to obtain or set credentials that will let me log in to use webinstaller Change sponsored?: --- Product: Koha Version: 19.05 Hardware: PC OS: Linux Status: NEW Severity: blocker Priority: P5 - low Component: Installation and upgrade (web-based installer) Assignee: koha-bugs at lists.koha-community.org Reporter: christos.hayward at gmail.com QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com I am trying to install Koha under Mint 19.2, and have had some list traffic (search for christos.hayward at gmail.com under koha at lists.kapito.co.nz to find my traffic). In a nutshell, I can't log into the webinstaller from attempting to follow the Debian wiki at https://wiki.koha-community.org/wiki/Debian. I have attempted to enter a new password for an instance 'catalog' and have failed to log in successfully with any credentials, including the original username and password, the username and password I set to /etc/koha/sites/catalog/koha-conf.xml and /etc/koha/sites/catalog/koha-conf.xml. There appear to be some difficulties accessing the database as MariaDB is not available under the credentials in koha-conf.xml. I'm wiping the drive for a clean install where we know MariaDB is available and accessible, but right now I have not been able to start the webinstaller after attempting all prior steps on https://wiki.koha-community.org/wiki/Debian -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 16:14:59 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 15:14:59 +0000 Subject: [Koha-bugs] [Bug 13897] Use XML files for installer data In-Reply-To: <bug-13897-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-13897-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-13897-70-jFfSqJszp9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=13897 Bernardo Gonzalez Kriegel <bgkriegel at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|In Discussion |Needs Signoff -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 16:18:16 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 15:18:16 +0000 Subject: [Koha-bugs] [Bug 23971] Add logging for basket related actions In-Reply-To: <bug-23971-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23971-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23971-70-McKeHiKsRS@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95286|0 |1 is obsolete| | --- Comment #7 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 95885 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95885&action=edit Bug 23971: Add Acq action logging This patch adds logging for the following Acq actions: - Basket creation - Basket editing - Basket approval (via EDI) - Basket closure -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 16:26:31 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 15:26:31 +0000 Subject: [Koha-bugs] [Bug 23971] Add logging for basket related actions In-Reply-To: <bug-23971-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23971-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23971-70-4MJuOd0a1G@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Needs Signoff --- Comment #8 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- The nature of the logging has now changed according to customer requirements. I am logging less, and it is necessary now to use table joins in reports in order to gain access to the more detailed information, this will make the logging done here much more usable and flexible. Katrin and Séverine - I agree that basket reopening would be a useful thing to log, but it is outside of the scope of the requirements for this bug. There are many Acq actions that could be logged, I'm hoping these will be added in time. Katrin - I have put the logging behind an AcqLog syspref, thanks for highlighting this. Revised test plan: - Apply the patch => TEST: Observe there is a new "AcqLog" syspref - Enable the AcqLog syspref - Create a basket => TEST: Observe that an Acquisitions action log has been created containing: => Basket number - Modify a basket => TEST: Observe that an Acquisitions action log has been created containing: => Basket number => Borrowernumber of the user who modified the basket, this is stored in "info" as a left padded 10 digit number which can be joined on to the borrowers table - Approve a basket via EDI => TEST: Observe that an Acquisitions action log has been created containing: => Basket number => Borrowernumber of the user who approved the basket, this is stored in "info" as a left padded 10 digit number which can be joined on to the borrowers table - Close a basket => TEST: Observe that an Acquisitions action log has been created containing: => Basket number => Borrowernumber of the user who closed the basket, this is stored in "info" as a left padded 10 digit number which can be joined on to the borrowers table -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 16:28:39 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 15:28:39 +0000 Subject: [Koha-bugs] [Bug 24138] suspension miscalculated when Suspension charging interval bigger than 1 and Max. suspension duration is defined In-Reply-To: <bug-24138-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24138-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24138-70-Ot2OsAlyHQ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|NEW |Needs Signoff -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 16:28:42 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 15:28:42 +0000 Subject: [Koha-bugs] [Bug 24138] suspension miscalculated when Suspension charging interval bigger than 1 and Max. suspension duration is defined In-Reply-To: <bug-24138-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24138-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24138-70-UIE9hIKDJ3@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138 --- Comment #1 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95886 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95886&action=edit Bug 24138: Move the calculation out of the sub No changes expected here. For the next patch we are going to need to add test and calculate the new debarment date. To ease the writing of these tests the calculation is moved out of the existing subroutine. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 16:28:46 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 15:28:46 +0000 Subject: [Koha-bugs] [Bug 24138] suspension miscalculated when Suspension charging interval bigger than 1 and Max. suspension duration is defined In-Reply-To: <bug-24138-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24138-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24138-70-93teV3dng9@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138 --- Comment #2 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> --- Created attachment 95887 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95887&action=edit Bug 24138: Fix calculation of suspension days when a limit is set If there is a limit for the number of suspension days (maxsuspensiondays), the calculation is wrong. We are reducing the number of days before taking into account the suspension charging interval. For instance, a checkin is 1 year late and the circ rules are defined to charge 7 days every 15 days. It results in 365 * 7 / 15 days of suspension => 170 days Before this patch the calculation was: 365 * 7 limited to 333, 333 / 15 => 22 days Test plan: Given the examples in the commit messages and the description of the bug report, setup complex circulation rules and confirm that the debarment dates are calculated correctly -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 16:29:00 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 15:29:00 +0000 Subject: [Koha-bugs] [Bug 24138] suspension miscalculated when Suspension charging interval bigger than 1 and Max. suspension duration is defined In-Reply-To: <bug-24138-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24138-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24138-70-c87O8DBZZl@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138 Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |jonathan.druart at bugs.koha-c | |ommunity.org Severity|enhancement |major Assignee|koha-bugs at lists.koha-commun |jonathan.druart at bugs.koha-c |ity.org |ommunity.org -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 16:41:49 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 15:41:49 +0000 Subject: [Koha-bugs] [Bug 23971] Add logging for basket related actions In-Reply-To: <bug-23971-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23971-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23971-70-H385KHZomi@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 --- Comment #9 from Andrew Isherwood <andrew.isherwood at ptfs-europe.com> --- Created attachment 95888 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95888&action=edit Bug 23971 - Add logging for basket related actions This patch adds logging for the following Acq actions: - Basket creation - Basket editing - Basket approval (via EDI) - Basket closure -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 16:42:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 15:42:21 +0000 Subject: [Koha-bugs] [Bug 23971] Add logging for basket related actions In-Reply-To: <bug-23971-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23971-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23971-70-XIDDZCh3uF@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23971 Andrew Isherwood <andrew.isherwood at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95885|0 |1 is obsolete| | -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 16:57:10 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 15:57:10 +0000 Subject: [Koha-bugs] [Bug 24138] suspension miscalculated when Suspension charging interval bigger than 1 and Max. suspension duration is defined In-Reply-To: <bug-24138-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24138-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24138-70-OoBrlFMuEz@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- QA Contact|testopia at bugs.koha-communit |martin.renvoize at ptfs-europe |y.org |.com CC| |martin.renvoize at ptfs-europe | |.com -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 16:57:54 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 15:57:54 +0000 Subject: [Koha-bugs] [Bug 24138] suspension miscalculated when Suspension charging interval bigger than 1 and Max. suspension duration is defined In-Reply-To: <bug-24138-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24138-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24138-70-td550xjLfn@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24138 --- Comment #3 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Code looks solid, but it would be good to get Hugo's signoff that he believes it's working as expected before I QA it. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 17:01:32 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 16:01:32 +0000 Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests In-Reply-To: <bug-23974-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23974-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23974-70-ndtordbH0S@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95214|0 |1 is obsolete| | --- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95889 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95889&action=edit Bug 23974: (follow-up) Add same day loan tests Hourly loans can be short enough to not cross a day boundary and as such we should test for that scenario in the hour_between tests too. Signed-off-by: Martin Renvoize <martin.renvoize at ptfs-europe.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 17:10:27 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 16:10:27 +0000 Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests In-Reply-To: <bug-23974-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23974-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23974-70-zpAyFO5BVo@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Failed QA |Signed Off --- Comment #17 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Corrected the double variable. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 17:22:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 16:22:12 +0000 Subject: [Koha-bugs] [Bug 24137] Marc21 bibliographic fails to install for other language In-Reply-To: <bug-24137-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24137-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24137-70-Bk8Aybt1io@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24137 --- Comment #2 from b.pastern4k at gmail.com --- I am trying ukrainian version. Koha version is 19.05.04. Previous versions of 19.05 did not have this issue. -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 17:27:44 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 16:27:44 +0000 Subject: [Koha-bugs] [Bug 24137] Marc21 bibliographic fails to install for other language In-Reply-To: <bug-24137-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24137-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24137-70-0apaikSB2C@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24137 b.pastern4k at gmail.com changed: What |Removed |Added ---------------------------------------------------------------------------- Priority|P5 - low |P3 -- You are receiving this mail because: You are watching all bug changes. You are the assignee for the bug. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 18:10:19 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 17:10:19 +0000 Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests In-Reply-To: <bug-23974-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23974-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23974-70-20w8lazdUp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 --- Comment #18 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95890 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95890&action=edit Bug 23974: Add POD for hours_between Add a bit of missing POD whilst we're working in here -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 18:10:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 17:10:22 +0000 Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests In-Reply-To: <bug-23974-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23974-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23974-70-HjUD9r5j8k@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 --- Comment #19 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- Created attachment 95891 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95891&action=edit Bug 23974: Test Notes -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 18:11:47 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 17:11:47 +0000 Subject: [Koha-bugs] [Bug 23974] hours_between and days_between lack tests In-Reply-To: <bug-23974-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-23974-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-23974-70-oppZbzdE51@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23974 Martin Renvoize <martin.renvoize at ptfs-europe.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Signed Off |Failed QA --- Comment #20 from Martin Renvoize <martin.renvoize at ptfs-europe.com> --- We do not yet test for the behaviour when passing a start_dt which is a holiday.. I think to get full coverage we should test that case too. -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 19:56:11 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 18:56:11 +0000 Subject: [Koha-bugs] [Bug 18105] Should we restart koha-indexer differently i.e. like koha-plack? In-Reply-To: <bug-18105-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-18105-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-18105-70-smaOPfJNOJ@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18105 Tomás Cohen Arazi <tomascohen at gmail.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Assignee|koha-bugs at lists.koha-commun |tomascohen at gmail.com |ity.org | --- Comment #3 from Tomás Cohen Arazi <tomascohen at gmail.com> --- I'm taking this one, as I'll be revisiting all the daemon handling scripts as part of the containerization effort. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 23:03:12 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 22:03:12 +0000 Subject: [Koha-bugs] [Bug 11500] Use dateformat syspref and datepicker on additems.pl (and other item cataloguing pages) In-Reply-To: <bug-11500-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11500-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11500-70-5keudrQgs7@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11500 Maryse Simard <maryse.simard at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Attachment #95824|0 |1 is obsolete| | --- Comment #4 from Maryse Simard <maryse.simard at inlibro.com> --- Created attachment 95892 --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=95892&action=edit Bug 11500: Use dateformat syspref and datepicker on additems.pl (and other item cataloguing pages) This patch modifies the cataloging plugin dateaccessioned.pl so that it triggers the addition of a datepicker widget to fields it is linked with. Despite its name the plugin can be used on any item field which requires a date. To test, apply the patch and make sure you have one or more item subfields linked to the dateaccessioned.pl plugin. For instance, in MARC21: - Administration -> MARC bibliographic framework -> MARC structure -> 952 -> Edit subfields: - subfields d ("Date acquired") and w ("Price effective from"): - Other options -> Plugin -> dateaccessioned.pl - Go to cataloging and add or edit an item on a bibliographic record - The "Date acquired" and "Price effective from" fields should be styled as datepickers. - Clicking in these fields should populate the field with today's date and trigger the datepicker popup. - Test that all the datepicker features work correctly. - Test that manual entry of a date works. - With the AcqCreateItem system preference set to "placing an order," go to Acquisitions -> Vendor -> Add to basket. - Add a title to your basket using your preferred method. - In the "New order" form, find the section for adding an item. - Test the "Date acquired" and "Price effective from" fields, which should behave just like they did in the cataloging module. Signed-off-by: Maryse Simard <maryse.simard at inlibro.com> -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 23:03:22 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 22:03:22 +0000 Subject: [Koha-bugs] [Bug 11500] Use dateformat syspref and datepicker on additems.pl (and other item cataloguing pages) In-Reply-To: <bug-11500-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-11500-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-11500-70-kLaHAlUrcP@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=11500 Maryse Simard <maryse.simard at inlibro.com> changed: What |Removed |Added ---------------------------------------------------------------------------- Status|Needs Signoff |Signed Off -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 23:44:21 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 22:44:21 +0000 Subject: [Koha-bugs] [Bug 7711] clear holds statuses and workflow In-Reply-To: <bug-7711-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-7711-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-7711-70-eKnzhnKAFp@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=7711 Kathy <kathy at gosfordcommunity.org.au> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |kathy at gosfordcommunity.org. | |au -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Fri Nov 29 23:47:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Fri, 29 Nov 2019 22:47:06 +0000 Subject: [Koha-bugs] =?utf-8?b?W0J1ZyAyNDE0MF0gTmV3OiBJIGNhbuKAmXQgY2xl?= =?utf-8?q?ar/delete_holds=2E?= Message-ID: <bug-24140-70@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24140 Bug ID: 24140 Summary: I can’t clear/delete holds. Change sponsored?: --- Product: Koha Version: unspecified Hardware: All OS: All Status: NEW Severity: major Priority: P5 - low Component: Hold requests Assignee: koha-bugs at lists.koha-community.org Reporter: kathy at gosfordcommunity.org.au QA Contact: testopia at bugs.koha-community.org CC: gmcharlt at gmail.com Relatively new user here! Testing holds yesterday but now can’t clear or delete those holds either as Patron through OPAC or as Librarian. Keep getting Internal server error. Tried on both IPad and PC. Help! Thank you. -- You are receiving this mail because: You are the assignee for the bug. You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 30 22:30:06 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 30 Nov 2019 21:30:06 +0000 Subject: [Koha-bugs] [Bug 24128] Add alias for biblionumber => local-number In-Reply-To: <bug-24128-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24128-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24128-70-zDn4rV8AwR@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24128 Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mkstephens at lancasterseminar | |y.edu Status|Needs Signoff |Patch doesn't apply --- Comment #2 from Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> --- Patch does not apply. What happened: 1 - searched for "biblionumber:19" (without double quotes) 2 - no results 3 - applied patch, restart_all, updatedatabase (just to be safe) 4 - search again 5 - 11 results: biblio numbers 19, 190, 191, 192, 193, 194, 195, 196, 197, 198, and 199 -- You are receiving this mail because: You are watching all bug changes. From bugzilla-daemon at bugs.koha-community.org Sat Nov 30 23:14:14 2019 From: bugzilla-daemon at bugs.koha-community.org (bugzilla-daemon at bugs.koha-community.org) Date: Sat, 30 Nov 2019 22:14:14 +0000 Subject: [Koha-bugs] [Bug 24127] Using the dropdown option of Shelving Location as a search choice retrieves no results In-Reply-To: <bug-24127-70@https.bugs.koha-community.org/bugzilla3/> References: <bug-24127-70@https.bugs.koha-community.org/bugzilla3/> Message-ID: <bug-24127-70-sWKmadmdRc@https.bugs.koha-community.org/bugzilla3/> https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24127 Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> changed: What |Removed |Added ---------------------------------------------------------------------------- CC| |mkstephens at lancasterseminar | |y.edu --- Comment #2 from Myka Kennedy Stephens <mkstephens at lancasterseminary.edu> --- I'm not able to test this bug fully because performing a search by shelving location does work when Elasticsearch is enabled and the code is used. For example, in the sample database a search for shelving location (dropdown) General Stacks does not return results. However, a search for shelving location (dropdown) GEN returns 352 results. Is it really necessary to remove the option? It can be helpful. The checkmark boxes in the advanced search and item search are designed to function as search limiters. This is not the same thing as searching shelving location as a field. At the very least, I think it should remain as an option in the dropdown for the advanced search for the purposes of building complex queries. -- You are receiving this mail because: You are watching all bug changes.