[Koha-bugs] [Bug 18958] If patron has multiple record level holds on one record transferring first hold causes next hold to become item level

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=18958

--- Comment #36 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
(In reply to Marcel de Rooy from comment #15)
> Failing QA because this patch has side-effects when you cancel a hold from
> the confirm hold popup. Before we called GetOtherReserves and now we dont.

Still looking at my older comment, and having the feeling that it was kind of
ignored.
Let me rephrase it by showing this diff part:

     } else {
         my $diffBranchSend = ($userenv_branch ne $diffBranchReturned) ?
$diffBranchReturned : undef;
+
         # diffBranchSend tells ModReserveAffect whether document is expected
in this library or not,
         # i.e., whether to apply waiting status
         ModReserveAffect( $itemnumber, $borrowernumber, $diffBranchSend,
$reserve_id );
-    }
-#   check if we have other reserves for this document, if we have a return
send the message of transfer
-    my ( $messages, $nextreservinfo ) = GetOtherReserves($itemnumber);

As you can see here, the GetOtherReserves call and code around it was placed
AFTER the else, but we remove the closing accolade and put the new code INTO
the else branch.
So what happens: if you come from the if branch (you canceled a hold), you wont
jump into the GetOtherReserves stuff anymore.
Still does not look good to me. Please convince me with some good arguments!

-- 
You are receiving this mail because:
You are watching all bug changes.