[Koha-bugs] [Bug 21944] Fix waiting holds at wrong location bug

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21944

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Failed QA

--- Comment #26 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
    ($resfound, $resrec, undef) = C4::Reserves::CheckReserves(
$item->itemnumber, undef, $lookahead ) unless ( $item->withdrawn );
    # if a hold is found and is waiting at another branch, change the priority
back to 1 and trigger the hold (this will trigger a transfer and update the
hold status properly)
    if ( $resfound eq "Waiting" and $branch ne $resrec->{branchcode} ) {
        C4::Reserves::RevertWaitingStatus( { itemnumber => $item->itemnumber }
);
        #If the hold is reverted we need to refetch for the return values
        ($resfound, $resrec, undef) = C4::Reserves::CheckReserves(
$item->itemnumber, undef, $lookahead ) unless ( $item->withdrawn );
    }
    ($resfound, $resrec, undef) = C4::Reserves::CheckReserves(
$item->itemnumber, undef, $lookahead ) unless ( $item->withdrawn );

In short what do we see here:
call CheckReserves
if(  )
    call CheckReserves
endif
call CheckReserves
Three times in a row ? Please explain why you also add the last call. Rebase
problem?

-- 
You are receiving this mail because:
You are watching all bug changes.