[Koha-bugs] [Bug 17359] Patron import results use wrong encoding

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17359

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Failed QA

--- Comment #27 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
QA Comment:

my $surname ='Chloé';
my $surname_utf8 = encode_utf8($surname);
=> This name is not the best example for UTF-8. Could be Latin too.
=> You dont do anything with this encoded string.
=> When I am adding some Chinese character in the surname, the test fails.

decode_utf8($borrowerline)
Instead of adding this all over the place, we should try to fix at the source
or at least closer.
LINE: while ( my $borrowerline = <$handle> ) {
You could add it here, which would be closer but thats not all. Is the
assumption correct that it is UTF-8? We just got a handle from the caller. On
the report I am reading about people uploading Latin data.
Actually, we see in tools/import_borrowers.pl:
use CGI qw ( -utf8 );
and
my $handle   = $input->upload('uploadborrowers');
CGI tells me that "binary upload data ... are left untouched".
Do we actually need another parameter for the file encoding?

Looks like this needs some more attention.

-- 
You are receiving this mail because:
You are watching all bug changes.