[Koha-bugs] [Bug 23260] Anonymize (remove) patron data from items_last_borrower

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23260

Marcel de Rooy <m.de.rooy at rijksmuseum.nl> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
             Status|BLOCKED                     |Failed QA

--- Comment #11 from Marcel de Rooy <m.de.rooy at rijksmuseum.nl> ---
Hi Augustin,

I would like to see you optimize a bit.

for => $table_to_anonymize
Both anonymize and anonymise are correct and in use, but you mix them on this
report (no blocker, just seeing it). The z spelling is American.
But I do not really understand why you put the patron select in
search_patrons_to_anonymise. Why not leave this sub alone? We could directly
call anonymise_items_last_borrower, since you are not really interested in the
patrons here. And optimize it rightaway. Make the query in the new sub, and run
update on that result set without looping with next?

Thanks.

-- 
You are receiving this mail because:
You are watching all bug changes.