[Koha-bugs] [Bug 23805] Add a dedicated credit_types table

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23805

--- Comment #54 from Julian Maurice <julian.maurice at biblibre.com> ---
(In reply to Martin Renvoize from comment #52)
> Check constraints are not a mysqlism and have been in mariadb since 4 Jul
> 2016, postgres since before 2001-08-15.. they're not be thing.
> 
> I will remove the constraint if people are really that anti having
> consistent data.  It really is a "do no harm" feature, I don't see why
> people are getting so sound up about it.  The database update threw a
> warning but carried on and didn't break anything.. you just ended up without
> the constraint.  
> 
> If we bring this silly about supported systems we should be removing the
> entire restful API in my mmm opinion as mojolicious is far less easily
> packaged, faster moving  and unstable.
> 
> I've said my piece.

Just to be clear, I am all for consistent data, but I'm also all for consistent
behaviour. That's why I think Koha shouldn't use a database feature that is not
supported by all database systems supported by Koha (btw, does the list of
supported databases - with versions - exist somewhere ?).
With a CHECK constraint, someone with MySQL 8.0.16+ will have different
database constraints than someone with MySQL 5.7. So, possibly different
behaviours, bugs that are hard to reproduce, ... And that, IMO, should be
avoided if possible.

That particular problem could be solved if we decide that Koha now requires at
least MySQL 8.0.16 (which is 6 months old) or MariaDB 10.2 (first 10.2 stable
version is more than 2 years old).
But there's still the problem of the error message shown during
updatedatabase.pl (because of different syntax) that need to be solved (maybe
in a new bug ?)

-- 
You are receiving this mail because:
You are watching all bug changes.