[Koha-bugs] [Bug 23233] AllowItemsOnHoldCheckout is misnamed and does not indicate it is for SIP-based checkouts only

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23233

--- Comment #22 from Kyle M Hall <kyle at bywatersolutions.com> ---
(In reply to Joonas Kylmälä from comment #21)
> (In reply to Katrin Fischer from comment #20)
> > Hi Joonas,
> > 
> > this one is confusing to me - from the bug title/description it only seemed
> > to affect the description of the pref/naming of the pref, so I expected an
> > easy QA, but there is definitely more going on here.
> > 
> > Can you explain why you removed the checks for the prefs in several parts of
> > the code? Especially the changes to GetItemsInfo.
> 
> Does the comment #6 explain (and the ones before that)?
> 
> Kyle, maybe you would like to improve the commit messages?

I've re-read the commit message and even with the followups if still reads
accurately. What happened is that Joonas noticed that some places in Koha would
present certain data only if AllowItemsOnHoldCheckoutSIP although that data
should be displayed regardless of AllowItemsOnHoldCheckoutSIP!

-- 
You are receiving this mail because:
You are watching all bug changes.