[Koha-bugs] [Bug 17359] Patron import results use wrong encoding

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=17359

--- Comment #29 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Marcel de Rooy from comment #27)

Hi Marcel, thanks for the review.

> my $surname ='Chloé';
> my $surname_utf8 = encode_utf8($surname);
> => This name is not the best example for UTF-8. Could be Latin too.
> => You dont do anything with this encoded string.
> => When I am adding some Chinese character in the surname, the test fails.

Looks correct for me, see the last patch. Which tests fail?

> decode_utf8($borrowerline)
> Instead of adding this all over the place, we should try to fix at the
> source or at least closer.
> LINE: while ( my $borrowerline = <$handle> ) {
> You could add it here, which would be closer but thats not all. Is the
> assumption correct that it is UTF-8? We just got a handle from the caller.
> On the report I am reading about people uploading Latin data.
> Actually, we see in tools/import_borrowers.pl:
> use CGI qw ( -utf8 );
> and
> my $handle   = $input->upload('uploadborrowers');
> CGI tells me that "binary upload data ... are left untouched".
> Do we actually need another parameter for the file encoding?

As it seems that there is no encoding issue during the import process I tried
to provide a patch that will not have impact on it. That's why I preferred to
only modify the lines where @missing_criticals was used.

-- 
You are receiving this mail because:
You are watching all bug changes.