[Koha-bugs] [Bug 23523] Unitprice tax column values are not populated if entered upon ordering
bugzilla-daemon at bugs.koha-community.org
bugzilla-daemon at bugs.koha-community.org
Wed Nov 6 10:01:05 CET 2019
https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23523
--- Comment #16 from Martin Renvoize <martin.renvoize at ptfs-europe.com> ---
My followup gets the tests passing but I'm pretty confident it's not right :(.
The deeper down this rabbit hole I dive the less confidence in this original
patchset I have I'm afraid.
So, digging deeply it seems that unitprice is pretty much always passed into
populate_order_with_prices (regardless of whether you have entered such a price
into the UI at order time). If you have not entered a such a price then it
will fallback to using 'ecost' which is calculated clientside by JS and added
to a readonly form field.
As such, the t/Prices.t (which before my patch always submitted ecost =
unitprice), should continue to pass but it does not.. this to my highlights an
issue somewhere, but I'm stuck regarding finding it.
--
You are receiving this mail because:
You are watching all bug changes.
More information about the Koha-bugs
mailing list