[Koha-bugs] [Bug 21249] Syspref to choose whether to search homebranch, holding branch or both for library groups in advanced search

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=21249

Jonathan Druart <jonathan.druart at bugs.koha-community.org> changed:

           What    |Removed                     |Added
----------------------------------------------------------------------------
                 CC|                            |jonathan.druart at bugs.koha-c
                   |                            |ommunity.org
             Status|Passed QA                   |Failed QA

--- Comment #20 from Jonathan Druart <jonathan.druart at bugs.koha-community.org> ---
(In reply to Katrin Fischer from comment #16)
> Hi Alex,
> 
> some small stuff:
> 
> 1) The pref name and pref description use 'branch' according to our
> terminology guidelines 'library' should be used. This would also be
> consistent with other prefs using 'home library' and 'holding library' (see
> OPAC results library, OpacLocationOnDetail, ...)
> 
> 2) The pref description always talks about the advanced search, but I think
> this applies to the branch selection on the simple search
> (OpacAddMastheadLibraryPulldown) too or should apply to it to have
> consistent behaviour - can you clarify?
> 
> 3) You are missing the change to sysprefs.sql.

Sorry, I missed that comment!

-- 
You are receiving this mail because:
You are watching all bug changes.