[Koha-bugs] [Bug 23985] New: The method Koha::Item-> is not covered by tests!

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=23985

            Bug ID: 23985
           Summary: The method Koha::Item-> is not covered by tests!
 Change sponsored?: ---
           Product: Koha
           Version: master
          Hardware: All
                OS: All
            Status: NEW
          Severity: normal
          Priority: P5 - low
         Component: Circulation
          Assignee: koha-bugs at lists.koha-community.org
          Reporter: julian.maurice at biblibre.com
        QA Contact: testopia at bugs.koha-community.org
                CC: gmcharlt at gmail.com, kyle.m.hall at gmail.com

When checking out an item:

The method Koha::Item-> is not covered by tests!

Trace begun at /home/koha/env/master/src/Koha/Object.pm line 495
Koha::Object::AUTOLOAD('Koha::Item=HASH(0x55c5a43bcfb0)') called at
/home/koha/env/master/src/C4/Reserves.pm line 799
C4::Reserves::CheckReserves(9) called at
/home/koha/env/master/src/C4/Circulation.pm line 1024
C4::Circulation::CanBookBeIssued('Koha::Patron=HASH(0x55c5a43d6298)', 1, undef,
undef, undef, 'HASH(0x55c5a45432b0)') called at
/home/koha/env/master/src/circ/circulation.pl line 349

The bad lines are :

my $hold_fulfillment_policy = $branchitemrule->{hold_fulfillment_policy};
next if ( ($branchitemrule->{hold_fulfillment_policy} ne 'any') &&
($res->{branchcode} ne $item->$hold_fulfillment_policy) );

$hold_fulfillment_policy can apparently be empty, and this is not
checked.

I'm not sure what should be done in this case.

Steps to reproduce:
1. Go to "Circulation and fines rules"
2. Under "Default checkout, hold and return policy", unset "Hold pickup library
match" and Save
3. Place a hold on one item for one patron
4. Try to checkout the same item with another patron

Caused by bug 21206

-- 
You are receiving this mail because:
You are the assignee for the bug.
You are watching all bug changes.