[Koha-bugs] [Bug 20844] Reset a hold when it is missing after allocation

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=20844

--- Comment #32 from David Cook <dcook at prosentient.com.au> ---
Comment on attachment 81710
  --> https://bugs.koha-community.org/bugzilla3/attachment.cgi?id=81710
Bug 20844: Revert hold when setting an item to lost

Review of attachment 81710:
 --> (https://bugs.koha-community.org/bugzilla3/page.cgi?id=splinter.html&bug=20844&attachment=81710)
-----------------------------------------------------------------

::: C4/Circulation.pm
@@ +3688,5 @@
> +    my $LostItemLevelHold;
> +    if ( $restype eq "Waiting" || $restype eq "Reserved" ) {
> +        if ( $res->{originalholdtype} eq "B" ) {
> +            #originalholdtype equalling "B" means this is a bib level hold
> +            C4::Reserves::RevertWaitingStatus({itemnumber => $itemnumber});

This line appears to be buggy. I haven't fully investigated, but if the hold
type is B, the itemnumber can't be used to look up the reserve, and eventually
causes a fatal error in _FixPriority (due to a lack of error handling in
RevertWaitingStatus, _FixPriority, etc.)

-- 
You are receiving this mail because:
You are watching all bug changes.