[Koha-bugs] [Bug 24027] Adding multiple items is slow

[bugzilla-daemon at bugs.koha-community.org]

https://bugs.koha-community.org/bugzilla3/show_bug.cgi?id=24027

--- Comment #5 from Andrew Nugged <nugged at gmail.com> ---
Thanks Jonathan,

> Only one thing, we will certainly reject the first patch, $dbh must be retrieved from C4::Context->dbh only.

so I will rework in opposite direction, removing mine + old dbh in params: that


> Also we prefer to have a hashref as parameters to make the flag explicit:
>  { postpone_indexes_update => 1 }

yes, this is good coding style for not to seding unknown ", 1" or ", 0" in
params :),
thought about that but was afraid to announce it because it is more bigger
change then (calling style from sequential params to hash with options). But
both thumbs up for this!


I will recreate now patches/chain,
please then give feedback on last GUI change one:

Bug 24027: (follow-up) Don't combine long items-add POST page with list
generation

... so I will rework them in a batch :), and then I will ask for Sign-Off.

-- 
You are receiving this mail because:
You are watching all bug changes.